ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ArrayBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ArrayBlockingQueueTest.java (file contents):
Revision 1.76 by jsr166, Sun Nov 6 02:40:38 2016 UTC vs.
Revision 1.87 by jsr166, Sun May 14 00:56:43 2017 UTC

# Line 11 | Line 11 | import static java.util.concurrent.TimeU
11   import java.util.ArrayList;
12   import java.util.Arrays;
13   import java.util.Collection;
14 + import java.util.Collections;
15   import java.util.Iterator;
16   import java.util.NoSuchElementException;
17   import java.util.Queue;
# Line 104 | Line 105 | public class ArrayBlockingQueueTest exte
105      /**
106       * Constructor throws IAE if capacity argument nonpositive
107       */
108 <    public void testConstructor2() {
109 <        try {
110 <            new ArrayBlockingQueue(0);
111 <            shouldThrow();
112 <        } catch (IllegalArgumentException success) {}
108 >    public void testConstructor_nonPositiveCapacity() {
109 >        for (int i : new int[] { 0, -1, Integer.MIN_VALUE }) {
110 >            try {
111 >                new ArrayBlockingQueue(i);
112 >                shouldThrow();
113 >            } catch (IllegalArgumentException success) {}
114 >            for (boolean fair : new boolean[] { true, false }) {
115 >                try {
116 >                    new ArrayBlockingQueue(i, fair);
117 >                    shouldThrow();
118 >                } catch (IllegalArgumentException success) {}
119 >            }
120 >        }
121      }
122  
123      /**
124       * Initializing from null Collection throws NPE
125       */
126 <    public void testConstructor3() {
126 >    public void testConstructor_nullCollection() {
127          try {
128              new ArrayBlockingQueue(1, true, null);
129              shouldThrow();
# Line 149 | Line 158 | public class ArrayBlockingQueueTest exte
158      /**
159       * Initializing from too large collection throws IAE
160       */
161 <    public void testConstructor6() {
162 <        Integer[] ints = new Integer[SIZE];
163 <        for (int i = 0; i < SIZE; ++i)
164 <            ints[i] = i;
156 <        Collection<Integer> elements = Arrays.asList(ints);
161 >    public void testConstructor_collectionTooLarge() {
162 >        // just barely fits - succeeds
163 >        new ArrayBlockingQueue(SIZE, false,
164 >                               Collections.nCopies(SIZE, ""));
165          try {
166 <            new ArrayBlockingQueue(SIZE - 1, false, elements);
166 >            new ArrayBlockingQueue(SIZE - 1, false,
167 >                                   Collections.nCopies(SIZE, ""));
168              shouldThrow();
169          } catch (IllegalArgumentException success) {}
170      }
# Line 177 | Line 186 | public class ArrayBlockingQueueTest exte
186       * Queue transitions from empty to full when elements added
187       */
188      public void testEmptyFull() {
189 <        ArrayBlockingQueue q = new ArrayBlockingQueue(2);
189 >        BlockingQueue q = populatedQueue(0, 2, 2, false);
190          assertTrue(q.isEmpty());
191          assertEquals(2, q.remainingCapacity());
192          q.add(one);
193          assertFalse(q.isEmpty());
194 <        q.add(two);
194 >        assertTrue(q.offer(two));
195          assertFalse(q.isEmpty());
196          assertEquals(0, q.remainingCapacity());
197          assertFalse(q.offer(three));
# Line 192 | Line 201 | public class ArrayBlockingQueueTest exte
201       * remainingCapacity decreases on add, increases on remove
202       */
203      public void testRemainingCapacity() {
204 <        BlockingQueue q = populatedQueue(SIZE);
205 <        for (int i = 0; i < SIZE; ++i) {
206 <            assertEquals(i, q.remainingCapacity());
207 <            assertEquals(SIZE, q.size() + q.remainingCapacity());
204 >        int size = ThreadLocalRandom.current().nextInt(1, SIZE);
205 >        BlockingQueue q = populatedQueue(size, size, 2 * size, false);
206 >        int spare = q.remainingCapacity();
207 >        int capacity = spare + size;
208 >        for (int i = 0; i < size; i++) {
209 >            assertEquals(spare + i, q.remainingCapacity());
210 >            assertEquals(capacity, q.size() + q.remainingCapacity());
211              assertEquals(i, q.remove());
212          }
213 <        for (int i = 0; i < SIZE; ++i) {
214 <            assertEquals(SIZE - i, q.remainingCapacity());
215 <            assertEquals(SIZE, q.size() + q.remainingCapacity());
213 >        for (int i = 0; i < size; i++) {
214 >            assertEquals(capacity - i, q.remainingCapacity());
215 >            assertEquals(capacity, q.size() + q.remainingCapacity());
216              assertTrue(q.add(i));
217          }
218      }
# Line 219 | Line 231 | public class ArrayBlockingQueueTest exte
231       */
232      public void testAdd() {
233          ArrayBlockingQueue q = new ArrayBlockingQueue(SIZE);
234 <        for (int i = 0; i < SIZE; ++i) {
223 <            assertTrue(q.add(new Integer(i)));
224 <        }
234 >        for (int i = 0; i < SIZE; i++) assertTrue(q.add((Integer) i));
235          assertEquals(0, q.remainingCapacity());
236          try {
237 <            q.add(new Integer(SIZE));
237 >            q.add((Integer) SIZE);
238              shouldThrow();
239          } catch (IllegalStateException success) {}
240      }
# Line 258 | Line 268 | public class ArrayBlockingQueueTest exte
268      /**
269       * addAll throws ISE if not enough room
270       */
271 <    public void testAddAll4() {
272 <        ArrayBlockingQueue q = new ArrayBlockingQueue(1);
273 <        Integer[] ints = new Integer[SIZE];
274 <        for (int i = 0; i < SIZE; ++i)
275 <            ints[i] = new Integer(i);
271 >    public void testAddAll_insufficientSpace() {
272 >        int size = ThreadLocalRandom.current().nextInt(1, SIZE);
273 >        ArrayBlockingQueue q = populatedQueue(0, size, size, false);
274 >        // Just fits:
275 >        q.addAll(populatedQueue(size, size, 2 * size, false));
276 >        assertEquals(0, q.remainingCapacity());
277 >        assertEquals(size, q.size());
278 >        assertEquals(0, q.peek());
279          try {
280 <            q.addAll(Arrays.asList(ints));
280 >            q = populatedQueue(0, size, size, false);
281 >            q.addAll(Collections.nCopies(size + 1, 42));
282              shouldThrow();
283          } catch (IllegalStateException success) {}
284      }
# Line 326 | Line 340 | public class ArrayBlockingQueueTest exte
340              }});
341  
342          await(pleaseInterrupt);
343 <        assertThreadStaysAlive(t);
343 >        assertThreadBlocks(t, Thread.State.WAITING);
344          t.interrupt();
345          awaitTermination(t);
346          assertEquals(SIZE, q.size());
# Line 361 | Line 375 | public class ArrayBlockingQueueTest exte
375          assertEquals(0, q.take());
376  
377          await(pleaseInterrupt);
378 <        assertThreadStaysAlive(t);
378 >        assertThreadBlocks(t, Thread.State.WAITING);
379          t.interrupt();
380          awaitTermination(t);
381          assertEquals(0, q.remainingCapacity());
# Line 385 | Line 399 | public class ArrayBlockingQueueTest exte
399                      q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
400                      shouldThrow();
401                  } catch (InterruptedException success) {}
402 +                assertFalse(Thread.interrupted());
403              }});
404  
405          await(pleaseInterrupt);
406 <        assertThreadStaysAlive(t);
406 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
407          t.interrupt();
408          awaitTermination(t);
409      }
# Line 411 | Line 426 | public class ArrayBlockingQueueTest exte
426          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
427          Thread t = newStartedThread(new CheckedRunnable() {
428              public void realRun() throws InterruptedException {
429 <                for (int i = 0; i < SIZE; ++i) {
415 <                    assertEquals(i, q.take());
416 <                }
429 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
430  
431                  Thread.currentThread().interrupt();
432                  try {
# Line 431 | Line 444 | public class ArrayBlockingQueueTest exte
444              }});
445  
446          await(pleaseInterrupt);
447 <        assertThreadStaysAlive(t);
447 >        assertThreadBlocks(t, Thread.State.WAITING);
448          t.interrupt();
449          awaitTermination(t);
450      }
# Line 481 | Line 494 | public class ArrayBlockingQueueTest exte
494       */
495      public void testInterruptedTimedPoll() throws InterruptedException {
496          final BlockingQueue<Integer> q = populatedQueue(SIZE);
497 <        final CountDownLatch aboutToWait = new CountDownLatch(1);
497 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
498          Thread t = newStartedThread(new CheckedRunnable() {
499              public void realRun() throws InterruptedException {
500                  long startTime = System.nanoTime();
501                  for (int i = 0; i < SIZE; ++i) {
502                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
503                  }
504 <                aboutToWait.countDown();
504 >
505 >                pleaseInterrupt.countDown();
506                  try {
507                      q.poll(LONG_DELAY_MS, MILLISECONDS);
508                      shouldThrow();
509 <                } catch (InterruptedException success) {
510 <                    assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
511 <                }
509 >                } catch (InterruptedException success) {}
510 >                assertFalse(Thread.interrupted());
511 >
512 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
513              }});
514  
515 <        await(aboutToWait);
516 <        waitForThreadToEnterWaitState(t);
515 >        await(pleaseInterrupt);
516 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
517          t.interrupt();
518          awaitTermination(t);
519          checkEmpty(q);
# Line 551 | Line 566 | public class ArrayBlockingQueueTest exte
566       * contains(x) reports true when elements added but not yet removed
567       */
568      public void testContains() {
569 <        ArrayBlockingQueue q = populatedQueue(SIZE);
570 <        for (int i = 0; i < SIZE; ++i) {
569 >        int size = ThreadLocalRandom.current().nextInt(1, SIZE);
570 >        ArrayBlockingQueue q = populatedQueue(size, size, 2 * size, false);
571 >        assertFalse(q.contains(null));
572 >        for (int i = 0; i < size; ++i) {
573              assertTrue(q.contains(new Integer(i)));
574              assertEquals(i, q.poll());
575              assertFalse(q.contains(new Integer(i)));
# Line 563 | Line 580 | public class ArrayBlockingQueueTest exte
580       * clear removes all elements
581       */
582      public void testClear() {
583 <        ArrayBlockingQueue q = populatedQueue(SIZE);
583 >        int size = ThreadLocalRandom.current().nextInt(1, 5);
584 >        ArrayBlockingQueue q = populatedQueue(size, size, 2 * size, false);
585 >        int capacity = size + q.remainingCapacity();
586          q.clear();
587          assertTrue(q.isEmpty());
588          assertEquals(0, q.size());
589 <        assertEquals(SIZE, q.remainingCapacity());
589 >        assertEquals(capacity, q.remainingCapacity());
590          q.add(one);
591          assertFalse(q.isEmpty());
592          assertTrue(q.contains(one));
# Line 921 | Line 940 | public class ArrayBlockingQueueTest exte
940       */
941      public void testNeverContainsNull() {
942          Collection<?>[] qs = {
943 <            new ArrayBlockingQueue<Object>(10),
944 <            populatedQueue(2),
943 >            populatedQueue(0, 1, 10, false),
944 >            populatedQueue(2, 2, 10, true),
945          };
946  
947          for (Collection<?> q : qs) {

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines