ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ArrayBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ArrayBlockingQueueTest.java (file contents):
Revision 1.87 by jsr166, Sun May 14 00:56:43 2017 UTC vs.
Revision 1.97 by jsr166, Mon Dec 16 21:16:08 2019 UTC

# Line 34 | Line 34 | public class ArrayBlockingQueueTest exte
34          class Implementation implements CollectionImplementation {
35              public Class<?> klazz() { return ArrayBlockingQueue.class; }
36              public Collection emptyCollection() {
37 <                boolean fair = ThreadLocalRandom.current().nextBoolean();
37 >                boolean fair = randomBoolean();
38                  return populatedQueue(0, SIZE, 2 * SIZE, fair);
39              }
40              public Object makeElement(int i) { return i; }
# Line 103 | Line 103 | public class ArrayBlockingQueueTest exte
103      }
104  
105      /**
106 <     * Constructor throws IAE if capacity argument nonpositive
106 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
107       */
108      public void testConstructor_nonPositiveCapacity() {
109          for (int i : new int[] { 0, -1, Integer.MIN_VALUE }) {
# Line 156 | Line 156 | public class ArrayBlockingQueueTest exte
156      }
157  
158      /**
159 <     * Initializing from too large collection throws IAE
159 >     * Initializing from too large collection throws IllegalArgumentException
160       */
161      public void testConstructor_collectionTooLarge() {
162          // just barely fits - succeeds
# Line 227 | Line 227 | public class ArrayBlockingQueueTest exte
227      }
228  
229      /**
230 <     * add succeeds if not full; throws ISE if full
230 >     * add succeeds if not full; throws IllegalStateException if full
231       */
232      public void testAdd() {
233          ArrayBlockingQueue q = new ArrayBlockingQueue(SIZE);
# Line 240 | Line 240 | public class ArrayBlockingQueueTest exte
240      }
241  
242      /**
243 <     * addAll(this) throws IAE
243 >     * addAll(this) throws IllegalArgumentException
244       */
245      public void testAddAllSelf() {
246          ArrayBlockingQueue q = populatedQueue(SIZE);
# Line 266 | Line 266 | public class ArrayBlockingQueueTest exte
266      }
267  
268      /**
269 <     * addAll throws ISE if not enough room
269 >     * addAll throws IllegalStateException if not enough room
270       */
271      public void testAddAll_insufficientSpace() {
272          int size = ThreadLocalRandom.current().nextInt(1, SIZE);
# Line 340 | Line 340 | public class ArrayBlockingQueueTest exte
340              }});
341  
342          await(pleaseInterrupt);
343 <        assertThreadBlocks(t, Thread.State.WAITING);
343 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
344          t.interrupt();
345          awaitTermination(t);
346          assertEquals(SIZE, q.size());
# Line 362 | Line 362 | public class ArrayBlockingQueueTest exte
362                  pleaseTake.countDown();
363                  q.put(86);
364  
365 +                Thread.currentThread().interrupt();
366 +                try {
367 +                    q.put(99);
368 +                    shouldThrow();
369 +                } catch (InterruptedException success) {}
370 +                assertFalse(Thread.interrupted());
371 +
372                  pleaseInterrupt.countDown();
373                  try {
374                      q.put(99);
# Line 375 | Line 382 | public class ArrayBlockingQueueTest exte
382          assertEquals(0, q.take());
383  
384          await(pleaseInterrupt);
385 <        assertThreadBlocks(t, Thread.State.WAITING);
385 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
386          t.interrupt();
387          awaitTermination(t);
388          assertEquals(0, q.remainingCapacity());
# Line 384 | Line 391 | public class ArrayBlockingQueueTest exte
391      /**
392       * timed offer times out if full and elements not taken
393       */
394 <    public void testTimedOffer() throws InterruptedException {
394 >    public void testTimedOffer() {
395          final ArrayBlockingQueue q = new ArrayBlockingQueue(2);
396          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
397          Thread t = newStartedThread(new CheckedRunnable() {
# Line 394 | Line 401 | public class ArrayBlockingQueueTest exte
401                  long startTime = System.nanoTime();
402                  assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
403                  assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
404 +
405 +                Thread.currentThread().interrupt();
406 +                try {
407 +                    q.offer(new Object(), randomTimeout(), randomTimeUnit());
408 +                    shouldThrow();
409 +                } catch (InterruptedException success) {}
410 +                assertFalse(Thread.interrupted());
411 +
412                  pleaseInterrupt.countDown();
413                  try {
414 <                    q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
414 >                    q.offer(new Object(), LONGER_DELAY_MS, MILLISECONDS);
415                      shouldThrow();
416                  } catch (InterruptedException success) {}
417                  assertFalse(Thread.interrupted());
418              }});
419  
420          await(pleaseInterrupt);
421 <        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
421 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
422          t.interrupt();
423          awaitTermination(t);
424      }
# Line 444 | Line 459 | public class ArrayBlockingQueueTest exte
459              }});
460  
461          await(pleaseInterrupt);
462 <        assertThreadBlocks(t, Thread.State.WAITING);
462 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
463          t.interrupt();
464          awaitTermination(t);
465      }
# Line 497 | Line 512 | public class ArrayBlockingQueueTest exte
512          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
513          Thread t = newStartedThread(new CheckedRunnable() {
514              public void realRun() throws InterruptedException {
515 <                long startTime = System.nanoTime();
501 <                for (int i = 0; i < SIZE; ++i) {
515 >                for (int i = 0; i < SIZE; i++)
516                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
503 –                }
517  
518 <                pleaseInterrupt.countDown();
518 >                Thread.currentThread().interrupt();
519                  try {
520 <                    q.poll(LONG_DELAY_MS, MILLISECONDS);
520 >                    q.poll(randomTimeout(), randomTimeUnit());
521                      shouldThrow();
522                  } catch (InterruptedException success) {}
523                  assertFalse(Thread.interrupted());
524  
525 <                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
525 >                pleaseInterrupt.countDown();
526 >                try {
527 >                    q.poll(LONGER_DELAY_MS, MILLISECONDS);
528 >                    shouldThrow();
529 >                } catch (InterruptedException success) {}
530 >                assertFalse(Thread.interrupted());
531              }});
532  
533          await(pleaseInterrupt);
534 <        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
534 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
535          t.interrupt();
536          awaitTermination(t);
537          checkEmpty(q);
# Line 670 | Line 688 | public class ArrayBlockingQueueTest exte
688              Integer x = (Integer) it.next();
689              assertEquals(s + i, (int) x);
690              for (Object[] a : as)
691 <                assertSame(a1[i], x);
691 >                assertSame(a[i], x);
692          }
693      }
694  
# Line 855 | Line 873 | public class ArrayBlockingQueueTest exte
873      }
874  
875      /**
876 <     * A deserialized serialized queue has same elements in same order
876 >     * A deserialized/reserialized queue has same elements in same order
877       */
878      public void testSerialization() throws Exception {
879          Queue x = populatedQueue(SIZE);

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines