ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.56 by jsr166, Mon Jun 2 22:20:32 2014 UTC vs.
Revision 1.78 by jsr166, Sat Jun 7 23:32:17 2014 UTC

# Line 105 | Line 105 | public class CompletableFutureTest exten
105          assertTrue(f.toString().contains("[Completed exceptionally]"));
106      }
107  
108 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
109 <                                              CFException ex) {
108 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
109 >                                                      Throwable ex) {
110          try {
111              f.get(LONG_DELAY_MS, MILLISECONDS);
112              shouldThrow();
# Line 131 | Line 131 | public class CompletableFutureTest exten
131          } catch (ExecutionException success) {
132              assertSame(ex, success.getCause());
133          } catch (Throwable fail) { threadUnexpectedException(fail); }
134 +
135          assertTrue(f.isDone());
136          assertFalse(f.isCancelled());
137          assertTrue(f.toString().contains("[Completed exceptionally]"));
138      }
139  
140 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
141 +                                                Throwable ex) {
142 +        checkCompletedExceptionallyWithRootCause(f, ex);
143 +        try {
144 +            CompletableFuture<Throwable> spy = f.handle
145 +                ((U u, Throwable t) -> t);
146 +            assertTrue(spy.join() instanceof CompletionException);
147 +            assertSame(ex, spy.join().getCause());
148 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
149 +    }
150 +
151 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
152 +        checkCompletedExceptionallyWithRootCause(f, ex);
153 +        try {
154 +            CompletableFuture<Throwable> spy = f.handle
155 +                ((U u, Throwable t) -> t);
156 +            assertSame(ex, spy.join());
157 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
158 +    }
159 +
160      void checkCancelled(CompletableFuture<?> f) {
161          try {
162              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 206 | Line 227 | public class CompletableFutureTest exten
227       * isCancelled, join, get, and getNow
228       */
229      public void testComplete() {
230 +        for (Integer v1 : new Integer[] { 1, null })
231 +    {
232          CompletableFuture<Integer> f = new CompletableFuture<>();
233          checkIncomplete(f);
234 <        f.complete(one);
235 <        checkCompletedNormally(f, one);
236 <    }
234 >        assertTrue(f.complete(v1));
235 >        assertFalse(f.complete(v1));
236 >        checkCompletedNormally(f, v1);
237 >    }}
238  
239      /**
240       * completeExceptionally completes exceptionally, as indicated by
# Line 218 | Line 242 | public class CompletableFutureTest exten
242       */
243      public void testCompleteExceptionally() {
244          CompletableFuture<Integer> f = new CompletableFuture<>();
245 +        CFException ex = new CFException();
246          checkIncomplete(f);
247 <        f.completeExceptionally(new CFException());
248 <        checkCompletedWithWrappedCFException(f);
247 >        f.completeExceptionally(ex);
248 >        checkCompletedExceptionally(f, ex);
249      }
250  
251      /**
# Line 228 | Line 253 | public class CompletableFutureTest exten
253       * methods isDone, isCancelled, join, get, and getNow
254       */
255      public void testCancel() {
256 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
257 +    {
258          CompletableFuture<Integer> f = new CompletableFuture<>();
259          checkIncomplete(f);
260          assertTrue(f.cancel(true));
261 +        assertTrue(f.cancel(true));
262          checkCancelled(f);
263 <    }
263 >    }}
264  
265      /**
266       * obtrudeValue forces completion with given value
# Line 240 | Line 268 | public class CompletableFutureTest exten
268      public void testObtrudeValue() {
269          CompletableFuture<Integer> f = new CompletableFuture<>();
270          checkIncomplete(f);
271 <        f.complete(one);
271 >        assertTrue(f.complete(one));
272          checkCompletedNormally(f, one);
273          f.obtrudeValue(three);
274          checkCompletedNormally(f, three);
# Line 261 | Line 289 | public class CompletableFutureTest exten
289       * obtrudeException forces completion with given exception
290       */
291      public void testObtrudeException() {
292 <        CompletableFuture<Integer> f = new CompletableFuture<>();
293 <        checkIncomplete(f);
294 <        f.complete(one);
295 <        checkCompletedNormally(f, one);
296 <        f.obtrudeException(new CFException());
269 <        checkCompletedWithWrappedCFException(f);
292 >        for (Integer v1 : new Integer[] { 1, null })
293 >    {
294 >        CFException ex;
295 >        CompletableFuture<Integer> f;
296 >
297          f = new CompletableFuture<>();
298 <        f.obtrudeException(new CFException());
299 <        checkCompletedWithWrappedCFException(f);
298 >        assertTrue(f.complete(v1));
299 >        for (int i = 0; i < 2; i++) {
300 >            f.obtrudeException(ex = new CFException());
301 >            checkCompletedExceptionally(f, ex);
302 >        }
303 >
304          f = new CompletableFuture<>();
305 +        for (int i = 0; i < 2; i++) {
306 +            f.obtrudeException(ex = new CFException());
307 +            checkCompletedExceptionally(f, ex);
308 +        }
309 +
310 +        f = new CompletableFuture<>();
311 +        f.completeExceptionally(ex = new CFException());
312 +        f.obtrudeValue(v1);
313 +        checkCompletedNormally(f, v1);
314 +        f.obtrudeException(ex = new CFException());
315 +        checkCompletedExceptionally(f, ex);
316          f.completeExceptionally(new CFException());
317 <        f.obtrudeValue(four);
318 <        checkCompletedNormally(f, four);
319 <        f.obtrudeException(new CFException());
320 <        checkCompletedWithWrappedCFException(f);
279 <    }
317 >        checkCompletedExceptionally(f, ex);
318 >        assertFalse(f.complete(v1));
319 >        checkCompletedExceptionally(f, ex);
320 >    }}
321  
322      /**
323       * getNumberOfDependents returns number of dependent tasks
324       */
325      public void testGetNumberOfDependents() {
326 +        for (ExecutionMode m : ExecutionMode.values())
327 +        for (Integer v1 : new Integer[] { 1, null })
328 +    {
329          CompletableFuture<Integer> f = new CompletableFuture<>();
330          assertEquals(0, f.getNumberOfDependents());
331 <        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
331 >        final CompletableFuture<Void> g = m.thenRun(f, new Noop(m));
332          assertEquals(1, f.getNumberOfDependents());
333          assertEquals(0, g.getNumberOfDependents());
334 <        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
334 >        final CompletableFuture<Void> h = m.thenRun(f, new Noop(m));
335          assertEquals(2, f.getNumberOfDependents());
336 <        f.complete(1);
336 >        assertEquals(0, h.getNumberOfDependents());
337 >        assertTrue(f.complete(v1));
338          checkCompletedNormally(g, null);
339 +        checkCompletedNormally(h, null);
340          assertEquals(0, f.getNumberOfDependents());
341          assertEquals(0, g.getNumberOfDependents());
342 <    }
342 >        assertEquals(0, h.getNumberOfDependents());
343 >    }}
344  
345      /**
346       * toString indicates current completion state
# Line 304 | Line 351 | public class CompletableFutureTest exten
351          f = new CompletableFuture<String>();
352          assertTrue(f.toString().contains("[Not completed]"));
353  
354 <        f.complete("foo");
354 >        assertTrue(f.complete("foo"));
355          assertTrue(f.toString().contains("[Completed normally]"));
356  
357          f = new CompletableFuture<String>();
358 <        f.completeExceptionally(new IndexOutOfBoundsException());
358 >        assertTrue(f.completeExceptionally(new IndexOutOfBoundsException()));
359          assertTrue(f.toString().contains("[Completed exceptionally]"));
360 +
361 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
362 +            f = new CompletableFuture<String>();
363 +            assertTrue(f.cancel(mayInterruptIfRunning));
364 +            assertTrue(f.toString().contains("[Completed exceptionally]"));
365 +        }
366      }
367  
368      /**
# Line 320 | Line 373 | public class CompletableFutureTest exten
373          checkCompletedNormally(f, "test");
374      }
375  
376 <    // Choose non-commutative actions for better coverage
376 >    abstract class CheckedAction {
377 >        int invocationCount = 0;
378 >        final ExecutionMode m;
379 >        CheckedAction(ExecutionMode m) { this.m = m; }
380 >        void invoked() {
381 >            m.checkExecutionMode();
382 >            assertEquals(0, invocationCount++);
383 >        }
384 >        void assertNotInvoked() { assertEquals(0, invocationCount); }
385 >        void assertInvoked() { assertEquals(1, invocationCount); }
386 >    }
387  
388 <    // A non-commutative function that handles and produces null values as well.
389 <    static Integer subtract(Integer x, Integer y) {
390 <        return (x == null && y == null) ? null :
391 <            ((x == null) ? 42 : x.intValue())
392 <            - ((y == null) ? 99 : y.intValue());
388 >    abstract class CheckedIntegerAction extends CheckedAction {
389 >        Integer value;
390 >        CheckedIntegerAction(ExecutionMode m) { super(m); }
391 >        void assertValue(Integer expected) {
392 >            assertInvoked();
393 >            assertEquals(expected, value);
394 >        }
395 >    }
396 >
397 >    class IntegerSupplier extends CheckedAction
398 >        implements Supplier<Integer>
399 >    {
400 >        final Integer value;
401 >        IntegerSupplier(ExecutionMode m, Integer value) {
402 >            super(m);
403 >            this.value = value;
404 >        }
405 >        public Integer get() {
406 >            invoked();
407 >            return value;
408 >        }
409      }
410  
411      // A function that handles and produces null values as well.
# Line 334 | Line 413 | public class CompletableFutureTest exten
413          return (x == null) ? null : x + 1;
414      }
415  
416 <    static final Supplier<Integer> supplyOne =
417 <        () -> Integer.valueOf(1);
418 <    static final Function<Integer, Integer> inc =
419 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
341 <    static final BiFunction<Integer, Integer, Integer> subtract =
342 <        (Integer x, Integer y) -> subtract(x, y);
343 <    static final class IncAction implements Consumer<Integer> {
344 <        int invocationCount = 0;
345 <        Integer value;
416 >    class NoopConsumer extends CheckedIntegerAction
417 >        implements Consumer<Integer>
418 >    {
419 >        NoopConsumer(ExecutionMode m) { super(m); }
420          public void accept(Integer x) {
421 <            invocationCount++;
422 <            value = inc(x);
421 >            invoked();
422 >            value = x;
423          }
424      }
425 <    static final class IncFunction implements Function<Integer,Integer> {
426 <        final ExecutionMode m;
427 <        int invocationCount = 0;
428 <        Integer value;
429 <        IncFunction(ExecutionMode m) { this.m = m; }
425 >
426 >    class IncFunction extends CheckedIntegerAction
427 >        implements Function<Integer,Integer>
428 >    {
429 >        IncFunction(ExecutionMode m) { super(m); }
430          public Integer apply(Integer x) {
431 <            m.checkExecutionMode();
358 <            invocationCount++;
431 >            invoked();
432              return value = inc(x);
433          }
434      }
435 <    static final class SubtractAction implements BiConsumer<Integer, Integer> {
436 <        final ExecutionMode m;
437 <        int invocationCount = 0;
438 <        Integer value;
439 <        // Check this action was invoked exactly once when result is computed.
440 <        SubtractAction(ExecutionMode m) { this.m = m; }
435 >
436 >    // Choose non-commutative actions for better coverage
437 >    // A non-commutative function that handles and produces null values as well.
438 >    static Integer subtract(Integer x, Integer y) {
439 >        return (x == null && y == null) ? null :
440 >            ((x == null) ? 42 : x.intValue())
441 >            - ((y == null) ? 99 : y.intValue());
442 >    }
443 >
444 >    class SubtractAction extends CheckedIntegerAction
445 >        implements BiConsumer<Integer, Integer>
446 >    {
447 >        SubtractAction(ExecutionMode m) { super(m); }
448          public void accept(Integer x, Integer y) {
449 <            m.checkExecutionMode();
370 <            invocationCount++;
449 >            invoked();
450              value = subtract(x, y);
451          }
452      }
453 <    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
454 <        final ExecutionMode m;
455 <        int invocationCount = 0;
456 <        Integer value;
457 <        // Check this action was invoked exactly once when result is computed.
379 <        SubtractFunction(ExecutionMode m) { this.m = m; }
453 >
454 >    class SubtractFunction extends CheckedIntegerAction
455 >        implements BiFunction<Integer, Integer, Integer>
456 >    {
457 >        SubtractFunction(ExecutionMode m) { super(m); }
458          public Integer apply(Integer x, Integer y) {
459 <            m.checkExecutionMode();
382 <            invocationCount++;
459 >            invoked();
460              return value = subtract(x, y);
461          }
462      }
463 <    static final class Noop implements Runnable {
464 <        final ExecutionMode m;
465 <        int invocationCount = 0;
389 <        Noop(ExecutionMode m) { this.m = m; }
463 >
464 >    class Noop extends CheckedAction implements Runnable {
465 >        Noop(ExecutionMode m) { super(m); }
466          public void run() {
467 <            m.checkExecutionMode();
392 <            invocationCount++;
467 >            invoked();
468          }
469      }
470  
471 <    static final class FailingSupplier implements Supplier<Integer> {
472 <        final ExecutionMode m;
473 <        int invocationCount = 0;
474 <        FailingSupplier(ExecutionMode m) { this.m = m; }
471 >    class FailingSupplier extends CheckedAction
472 >        implements Supplier<Integer>
473 >    {
474 >        FailingSupplier(ExecutionMode m) { super(m); }
475          public Integer get() {
476 <            m.checkExecutionMode();
402 <            invocationCount++;
476 >            invoked();
477              throw new CFException();
478          }
479      }
480 <    static final class FailingConsumer implements Consumer<Integer> {
481 <        final ExecutionMode m;
482 <        int invocationCount = 0;
483 <        FailingConsumer(ExecutionMode m) { this.m = m; }
480 >
481 >    class FailingConsumer extends CheckedIntegerAction
482 >        implements Consumer<Integer>
483 >    {
484 >        FailingConsumer(ExecutionMode m) { super(m); }
485          public void accept(Integer x) {
486 <            m.checkExecutionMode();
487 <            invocationCount++;
486 >            invoked();
487 >            value = x;
488              throw new CFException();
489          }
490      }
491 <    static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
492 <        final ExecutionMode m;
493 <        int invocationCount = 0;
494 <        FailingBiConsumer(ExecutionMode m) { this.m = m; }
491 >
492 >    class FailingBiConsumer extends CheckedIntegerAction
493 >        implements BiConsumer<Integer, Integer>
494 >    {
495 >        FailingBiConsumer(ExecutionMode m) { super(m); }
496          public void accept(Integer x, Integer y) {
497 <            m.checkExecutionMode();
498 <            invocationCount++;
497 >            invoked();
498 >            value = subtract(x, y);
499              throw new CFException();
500          }
501      }
502 <    static final class FailingFunction implements Function<Integer, Integer> {
503 <        final ExecutionMode m;
504 <        int invocationCount = 0;
505 <        FailingFunction(ExecutionMode m) { this.m = m; }
502 >
503 >    class FailingFunction extends CheckedIntegerAction
504 >        implements Function<Integer, Integer>
505 >    {
506 >        FailingFunction(ExecutionMode m) { super(m); }
507          public Integer apply(Integer x) {
508 <            m.checkExecutionMode();
509 <            invocationCount++;
508 >            invoked();
509 >            value = x;
510              throw new CFException();
511          }
512      }
513 <    static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
514 <        final ExecutionMode m;
515 <        int invocationCount = 0;
516 <        FailingBiFunction(ExecutionMode m) { this.m = m; }
513 >
514 >    class FailingBiFunction extends CheckedIntegerAction
515 >        implements BiFunction<Integer, Integer, Integer>
516 >    {
517 >        FailingBiFunction(ExecutionMode m) { super(m); }
518          public Integer apply(Integer x, Integer y) {
519 <            m.checkExecutionMode();
520 <            invocationCount++;
519 >            invoked();
520 >            value = subtract(x, y);
521              throw new CFException();
522          }
523      }
524 <    static final class FailingRunnable implements Runnable {
525 <        final ExecutionMode m;
526 <        int invocationCount = 0;
449 <        FailingRunnable(ExecutionMode m) { this.m = m; }
524 >
525 >    class FailingRunnable extends CheckedAction implements Runnable {
526 >        FailingRunnable(ExecutionMode m) { super(m); }
527          public void run() {
528 <            m.checkExecutionMode();
452 <            invocationCount++;
528 >            invoked();
529              throw new CFException();
530          }
531      }
532  
533 <    static final class CompletableFutureInc
534 <        implements Function<Integer, CompletableFuture<Integer>> {
535 <        final ExecutionMode m;
536 <        int invocationCount = 0;
537 <        CompletableFutureInc(ExecutionMode m) { this.m = m; }
533 >
534 >    class CompletableFutureInc extends CheckedIntegerAction
535 >        implements Function<Integer, CompletableFuture<Integer>>
536 >    {
537 >        CompletableFutureInc(ExecutionMode m) { super(m); }
538          public CompletableFuture<Integer> apply(Integer x) {
539 <            m.checkExecutionMode();
540 <            invocationCount++;
539 >            invoked();
540 >            value = x;
541              CompletableFuture<Integer> f = new CompletableFuture<>();
542 <            f.complete(inc(x));
542 >            assertTrue(f.complete(inc(x)));
543              return f;
544          }
545      }
546  
547 <    static final class FailingCompletableFutureFunction
548 <        implements Function<Integer, CompletableFuture<Integer>> {
549 <        final ExecutionMode m;
550 <        int invocationCount = 0;
475 <        FailingCompletableFutureFunction(ExecutionMode m) { this.m = m; }
547 >    class FailingCompletableFutureFunction extends CheckedIntegerAction
548 >        implements Function<Integer, CompletableFuture<Integer>>
549 >    {
550 >        FailingCompletableFutureFunction(ExecutionMode m) { super(m); }
551          public CompletableFuture<Integer> apply(Integer x) {
552 <            m.checkExecutionMode();
553 <            invocationCount++;
552 >            invoked();
553 >            value = x;
554              throw new CFException();
555          }
556      }
# Line 496 | Line 571 | public class CompletableFutureTest exten
571  
572      /**
573       * Permits the testing of parallel code for the 3 different
574 <     * execution modes without repeating all the testing code.
574 >     * execution modes without copy/pasting all the test methods.
575       */
576      enum ExecutionMode {
577          DEFAULT {
578              public void checkExecutionMode() {
579 +                assertFalse(ThreadExecutor.startedCurrentThread());
580                  assertNull(ForkJoinTask.getPool());
581              }
582 +            public CompletableFuture<Void> runAsync(Runnable a) {
583 +                throw new UnsupportedOperationException();
584 +            }
585 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
586 +                throw new UnsupportedOperationException();
587 +            }
588              public <T> CompletableFuture<Void> thenRun
589                  (CompletableFuture<T> f, Runnable a) {
590                  return f.thenRun(a);
# Line 571 | Line 653 | public class CompletableFutureTest exten
653                  assertSame(ForkJoinPool.commonPool(),
654                             ForkJoinTask.getPool());
655              }
656 +            public CompletableFuture<Void> runAsync(Runnable a) {
657 +                return CompletableFuture.runAsync(a);
658 +            }
659 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
660 +                return CompletableFuture.supplyAsync(a);
661 +            }
662              public <T> CompletableFuture<Void> thenRun
663                  (CompletableFuture<T> f, Runnable a) {
664                  return f.thenRunAsync(a);
# Line 638 | Line 726 | public class CompletableFutureTest exten
726              public void checkExecutionMode() {
727                  assertTrue(ThreadExecutor.startedCurrentThread());
728              }
729 +            public CompletableFuture<Void> runAsync(Runnable a) {
730 +                return CompletableFuture.runAsync(a, new ThreadExecutor());
731 +            }
732 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
733 +                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
734 +            }
735              public <T> CompletableFuture<Void> thenRun
736                  (CompletableFuture<T> f, Runnable a) {
737                  return f.thenRunAsync(a, new ThreadExecutor());
# Line 702 | Line 796 | public class CompletableFutureTest exten
796          };
797  
798          public abstract void checkExecutionMode();
799 +        public abstract CompletableFuture<Void> runAsync(Runnable a);
800 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
801          public abstract <T> CompletableFuture<Void> thenRun
802              (CompletableFuture<T> f, Runnable a);
803          public abstract <T> CompletableFuture<Void> thenAccept
# Line 751 | Line 847 | public class CompletableFutureTest exten
847      {
848          final AtomicInteger a = new AtomicInteger(0);
849          final CompletableFuture<Integer> f = new CompletableFuture<>();
850 <        if (!createIncomplete) f.complete(v1);
850 >        if (!createIncomplete) assertTrue(f.complete(v1));
851          final CompletableFuture<Integer> g = f.exceptionally
852              ((Throwable t) -> {
853                  // Should not be called
854                  a.getAndIncrement();
855                  throw new AssertionError();
856              });
857 <        if (createIncomplete) f.complete(v1);
857 >        if (createIncomplete) assertTrue(f.complete(v1));
858  
859          checkCompletedNormally(g, v1);
860          checkCompletedNormally(f, v1);
861          assertEquals(0, a.get());
862      }}
863  
768
864      /**
865       * exceptionally action completes with function value on source
866       * exception
# Line 780 | Line 875 | public class CompletableFutureTest exten
875          if (!createIncomplete) f.completeExceptionally(ex);
876          final CompletableFuture<Integer> g = f.exceptionally
877              ((Throwable t) -> {
878 +                ExecutionMode.DEFAULT.checkExecutionMode();
879                  threadAssertSame(t, ex);
880                  a.getAndIncrement();
881                  return v1;
# Line 801 | Line 897 | public class CompletableFutureTest exten
897          if (!createIncomplete) f.completeExceptionally(ex1);
898          final CompletableFuture<Integer> g = f.exceptionally
899              ((Throwable t) -> {
900 +                ExecutionMode.DEFAULT.checkExecutionMode();
901                  threadAssertSame(t, ex1);
902                  a.getAndIncrement();
903                  throw ex2;
904              });
905          if (createIncomplete) f.completeExceptionally(ex1);
906  
907 <        checkCompletedWithWrappedCFException(g, ex2);
907 >        checkCompletedWithWrappedException(g, ex2);
908 >        assertEquals(1, a.get());
909 >    }}
910 >
911 >    /**
912 >     * whenComplete action executes on normal completion, propagating
913 >     * source result.
914 >     */
915 >    public void testWhenComplete_normalCompletion1() {
916 >        for (ExecutionMode m : ExecutionMode.values())
917 >        for (boolean createIncomplete : new boolean[] { true, false })
918 >        for (Integer v1 : new Integer[] { 1, null })
919 >    {
920 >        final AtomicInteger a = new AtomicInteger(0);
921 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
922 >        if (!createIncomplete) assertTrue(f.complete(v1));
923 >        final CompletableFuture<Integer> g = m.whenComplete
924 >            (f,
925 >             (Integer x, Throwable t) -> {
926 >                m.checkExecutionMode();
927 >                threadAssertSame(x, v1);
928 >                threadAssertNull(t);
929 >                a.getAndIncrement();
930 >            });
931 >        if (createIncomplete) assertTrue(f.complete(v1));
932 >
933 >        checkCompletedNormally(g, v1);
934 >        checkCompletedNormally(f, v1);
935 >        assertEquals(1, a.get());
936 >    }}
937 >
938 >    /**
939 >     * whenComplete action executes on exceptional completion, propagating
940 >     * source result.
941 >     */
942 >    public void testWhenComplete_exceptionalCompletion() {
943 >        for (ExecutionMode m : ExecutionMode.values())
944 >        for (boolean createIncomplete : new boolean[] { true, false })
945 >        for (Integer v1 : new Integer[] { 1, null })
946 >    {
947 >        final AtomicInteger a = new AtomicInteger(0);
948 >        final CFException ex = new CFException();
949 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
950 >        if (!createIncomplete) f.completeExceptionally(ex);
951 >        final CompletableFuture<Integer> g = m.whenComplete
952 >            (f,
953 >             (Integer x, Throwable t) -> {
954 >                m.checkExecutionMode();
955 >                threadAssertNull(x);
956 >                threadAssertSame(t, ex);
957 >                a.getAndIncrement();
958 >            });
959 >        if (createIncomplete) f.completeExceptionally(ex);
960 >
961 >        checkCompletedWithWrappedException(g, ex);
962 >        checkCompletedExceptionally(f, ex);
963 >        assertEquals(1, a.get());
964 >    }}
965 >
966 >    /**
967 >     * whenComplete action executes on cancelled source, propagating
968 >     * CancellationException.
969 >     */
970 >    public void testWhenComplete_sourceCancelled() {
971 >        for (ExecutionMode m : ExecutionMode.values())
972 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
973 >        for (boolean createIncomplete : new boolean[] { true, false })
974 >    {
975 >        final AtomicInteger a = new AtomicInteger(0);
976 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
977 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
978 >        final CompletableFuture<Integer> g = m.whenComplete
979 >            (f,
980 >             (Integer x, Throwable t) -> {
981 >                m.checkExecutionMode();
982 >                threadAssertNull(x);
983 >                threadAssertTrue(t instanceof CancellationException);
984 >                a.getAndIncrement();
985 >            });
986 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
987 >
988 >        checkCompletedWithWrappedCancellationException(g);
989 >        checkCancelled(f);
990 >        assertEquals(1, a.get());
991 >    }}
992 >
993 >    /**
994 >     * If a whenComplete action throws an exception when triggered by
995 >     * a normal completion, it completes exceptionally
996 >     */
997 >    public void testWhenComplete_actionFailed() {
998 >        for (boolean createIncomplete : new boolean[] { true, false })
999 >        for (ExecutionMode m : ExecutionMode.values())
1000 >        for (Integer v1 : new Integer[] { 1, null })
1001 >    {
1002 >        final AtomicInteger a = new AtomicInteger(0);
1003 >        final CFException ex = new CFException();
1004 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1005 >        if (!createIncomplete) assertTrue(f.complete(v1));
1006 >        final CompletableFuture<Integer> g = m.whenComplete
1007 >            (f,
1008 >             (Integer x, Throwable t) -> {
1009 >                m.checkExecutionMode();
1010 >                threadAssertSame(x, v1);
1011 >                threadAssertNull(t);
1012 >                a.getAndIncrement();
1013 >                throw ex;
1014 >            });
1015 >        if (createIncomplete) assertTrue(f.complete(v1));
1016 >
1017 >        checkCompletedWithWrappedException(g, ex);
1018 >        checkCompletedNormally(f, v1);
1019 >        assertEquals(1, a.get());
1020 >    }}
1021 >
1022 >    /**
1023 >     * If a whenComplete action throws an exception when triggered by
1024 >     * a source completion that also throws an exception, the source
1025 >     * exception takes precedence.
1026 >     */
1027 >    public void testWhenComplete_actionFailedSourceFailed() {
1028 >        for (boolean createIncomplete : new boolean[] { true, false })
1029 >        for (ExecutionMode m : ExecutionMode.values())
1030 >        for (Integer v1 : new Integer[] { 1, null })
1031 >    {
1032 >        final AtomicInteger a = new AtomicInteger(0);
1033 >        final CFException ex1 = new CFException();
1034 >        final CFException ex2 = new CFException();
1035 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1036 >
1037 >        if (!createIncomplete) f.completeExceptionally(ex1);
1038 >        final CompletableFuture<Integer> g = m.whenComplete
1039 >            (f,
1040 >             (Integer x, Throwable t) -> {
1041 >                m.checkExecutionMode();
1042 >                threadAssertSame(t, ex1);
1043 >                threadAssertNull(x);
1044 >                a.getAndIncrement();
1045 >                throw ex2;
1046 >            });
1047 >        if (createIncomplete) f.completeExceptionally(ex1);
1048 >
1049 >        checkCompletedWithWrappedException(g, ex1);
1050 >        checkCompletedExceptionally(f, ex1);
1051          assertEquals(1, a.get());
1052      }}
1053  
# Line 822 | Line 1062 | public class CompletableFutureTest exten
1062      {
1063          final CompletableFuture<Integer> f = new CompletableFuture<>();
1064          final AtomicInteger a = new AtomicInteger(0);
1065 <        if (!createIncomplete) f.complete(v1);
1065 >        if (!createIncomplete) assertTrue(f.complete(v1));
1066          final CompletableFuture<Integer> g = m.handle
1067              (f,
1068               (Integer x, Throwable t) -> {
1069 +                m.checkExecutionMode();
1070                  threadAssertSame(x, v1);
1071                  threadAssertNull(t);
1072                  a.getAndIncrement();
1073                  return inc(v1);
1074              });
1075 <        if (createIncomplete) f.complete(v1);
1075 >        if (createIncomplete) assertTrue(f.complete(v1));
1076  
1077          checkCompletedNormally(g, inc(v1));
1078          checkCompletedNormally(f, v1);
# Line 854 | Line 1095 | public class CompletableFutureTest exten
1095          final CompletableFuture<Integer> g = m.handle
1096              (f,
1097               (Integer x, Throwable t) -> {
1098 +                m.checkExecutionMode();
1099                  threadAssertNull(x);
1100                  threadAssertSame(t, ex);
1101                  a.getAndIncrement();
# Line 862 | Line 1104 | public class CompletableFutureTest exten
1104          if (createIncomplete) f.completeExceptionally(ex);
1105  
1106          checkCompletedNormally(g, v1);
1107 <        checkCompletedWithWrappedCFException(f, ex);
1107 >        checkCompletedExceptionally(f, ex);
1108          assertEquals(1, a.get());
1109      }}
1110  
# Line 882 | Line 1124 | public class CompletableFutureTest exten
1124          final CompletableFuture<Integer> g = m.handle
1125              (f,
1126               (Integer x, Throwable t) -> {
1127 +                m.checkExecutionMode();
1128                  threadAssertNull(x);
1129                  threadAssertTrue(t instanceof CancellationException);
1130                  a.getAndIncrement();
# Line 909 | Line 1152 | public class CompletableFutureTest exten
1152          final CompletableFuture<Integer> g = m.handle
1153              (f,
1154               (Integer x, Throwable t) -> {
1155 +                m.checkExecutionMode();
1156                  threadAssertNull(x);
1157                  threadAssertSame(ex1, t);
1158                  a.getAndIncrement();
# Line 916 | Line 1160 | public class CompletableFutureTest exten
1160              });
1161          if (createIncomplete) f.completeExceptionally(ex1);
1162  
1163 <        checkCompletedWithWrappedCFException(g, ex2);
1164 <        checkCompletedWithWrappedCFException(f, ex1);
1163 >        checkCompletedWithWrappedException(g, ex2);
1164 >        checkCompletedExceptionally(f, ex1);
1165          assertEquals(1, a.get());
1166      }}
1167  
# Line 929 | Line 1173 | public class CompletableFutureTest exten
1173          final CompletableFuture<Integer> f = new CompletableFuture<>();
1174          final AtomicInteger a = new AtomicInteger(0);
1175          final CFException ex = new CFException();
1176 <        if (!createIncomplete) f.complete(v1);
1176 >        if (!createIncomplete) assertTrue(f.complete(v1));
1177          final CompletableFuture<Integer> g = m.handle
1178              (f,
1179               (Integer x, Throwable t) -> {
1180 +                m.checkExecutionMode();
1181                  threadAssertSame(x, v1);
1182                  threadAssertNull(t);
1183                  a.getAndIncrement();
1184                  throw ex;
1185              });
1186 <        if (createIncomplete) f.complete(v1);
1186 >        if (createIncomplete) assertTrue(f.complete(v1));
1187  
1188 <        checkCompletedWithWrappedCFException(g, ex);
1188 >        checkCompletedWithWrappedException(g, ex);
1189          checkCompletedNormally(f, v1);
1190          assertEquals(1, a.get());
1191      }}
# Line 948 | Line 1193 | public class CompletableFutureTest exten
1193      /**
1194       * runAsync completes after running Runnable
1195       */
1196 <    public void testRunAsync() {
1197 <        Noop r = new Noop(ExecutionMode.ASYNC);
1198 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1199 <        assertNull(f.join());
1200 <        assertEquals(1, r.invocationCount);
1201 <        checkCompletedNormally(f, null);
1202 <    }
1203 <
1204 <    /**
960 <     * runAsync with executor completes after running Runnable
961 <     */
962 <    public void testRunAsync2() {
963 <        Noop r = new Noop(ExecutionMode.EXECUTOR);
964 <        ThreadExecutor exec = new ThreadExecutor();
965 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
1196 >    public void testRunAsync_normalCompletion() {
1197 >        ExecutionMode[] executionModes = {
1198 >            ExecutionMode.ASYNC,
1199 >            ExecutionMode.EXECUTOR,
1200 >        };
1201 >        for (ExecutionMode m : executionModes)
1202 >    {
1203 >        final Noop r = new Noop(m);
1204 >        final CompletableFuture<Void> f = m.runAsync(r);
1205          assertNull(f.join());
967        assertEquals(1, r.invocationCount);
1206          checkCompletedNormally(f, null);
1207 <        assertEquals(1, exec.count.get());
1208 <    }
1207 >        r.assertInvoked();
1208 >    }}
1209  
1210      /**
1211       * failing runAsync completes exceptionally after running Runnable
1212       */
1213 <    public void testRunAsync3() {
1214 <        FailingRunnable r = new FailingRunnable(ExecutionMode.ASYNC);
1215 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1213 >    public void testRunAsync_exceptionalCompletion() {
1214 >        ExecutionMode[] executionModes = {
1215 >            ExecutionMode.ASYNC,
1216 >            ExecutionMode.EXECUTOR,
1217 >        };
1218 >        for (ExecutionMode m : executionModes)
1219 >    {
1220 >        final FailingRunnable r = new FailingRunnable(m);
1221 >        final CompletableFuture<Void> f = m.runAsync(r);
1222          checkCompletedWithWrappedCFException(f);
1223 <        assertEquals(1, r.invocationCount);
1224 <    }
1223 >        r.assertInvoked();
1224 >    }}
1225  
1226      /**
1227       * supplyAsync completes with result of supplier
1228       */
1229 <    public void testSupplyAsync() {
1230 <        CompletableFuture<Integer> f;
1231 <        f = CompletableFuture.supplyAsync(supplyOne);
1232 <        assertEquals(f.join(), one);
1233 <        checkCompletedNormally(f, one);
1234 <    }
1235 <
1236 <    /**
1237 <     * supplyAsync with executor completes with result of supplier
1238 <     */
1239 <    public void testSupplyAsync2() {
1240 <        CompletableFuture<Integer> f;
1241 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
1242 <        assertEquals(f.join(), one);
999 <        checkCompletedNormally(f, one);
1000 <    }
1229 >    public void testSupplyAsync_normalCompletion() {
1230 >        ExecutionMode[] executionModes = {
1231 >            ExecutionMode.ASYNC,
1232 >            ExecutionMode.EXECUTOR,
1233 >        };
1234 >        for (ExecutionMode m : executionModes)
1235 >        for (Integer v1 : new Integer[] { 1, null })
1236 >    {
1237 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1238 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1239 >        assertSame(v1, f.join());
1240 >        checkCompletedNormally(f, v1);
1241 >        r.assertInvoked();
1242 >    }}
1243  
1244      /**
1245       * Failing supplyAsync completes exceptionally
1246       */
1247 <    public void testSupplyAsync3() {
1248 <        FailingSupplier r = new FailingSupplier(ExecutionMode.ASYNC);
1249 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1247 >    public void testSupplyAsync_exceptionalCompletion() {
1248 >        ExecutionMode[] executionModes = {
1249 >            ExecutionMode.ASYNC,
1250 >            ExecutionMode.EXECUTOR,
1251 >        };
1252 >        for (ExecutionMode m : executionModes)
1253 >    {
1254 >        FailingSupplier r = new FailingSupplier(m);
1255 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1256          checkCompletedWithWrappedCFException(f);
1257 <        assertEquals(1, r.invocationCount);
1258 <    }
1257 >        r.assertInvoked();
1258 >    }}
1259  
1260      // seq completion methods
1261  
# Line 1021 | Line 1269 | public class CompletableFutureTest exten
1269      {
1270          final CompletableFuture<Integer> f = new CompletableFuture<>();
1271          final Noop r = new Noop(m);
1272 <        if (!createIncomplete) f.complete(v1);
1272 >        if (!createIncomplete) assertTrue(f.complete(v1));
1273          final CompletableFuture<Void> g = m.thenRun(f, r);
1274          if (createIncomplete) {
1275              checkIncomplete(g);
1276 <            f.complete(v1);
1276 >            assertTrue(f.complete(v1));
1277          }
1278  
1279          checkCompletedNormally(g, null);
1280          checkCompletedNormally(f, v1);
1281 <        assertEquals(1, r.invocationCount);
1281 >        r.assertInvoked();
1282      }}
1283  
1284      /**
# Line 1051 | Line 1299 | public class CompletableFutureTest exten
1299              f.completeExceptionally(ex);
1300          }
1301  
1302 <        checkCompletedWithWrappedCFException(g, ex);
1303 <        checkCompletedWithWrappedCFException(f, ex);
1304 <        assertEquals(0, r.invocationCount);
1302 >        checkCompletedWithWrappedException(g, ex);
1303 >        checkCompletedExceptionally(f, ex);
1304 >        r.assertNotInvoked();
1305      }}
1306  
1307      /**
# Line 1075 | Line 1323 | public class CompletableFutureTest exten
1323  
1324          checkCompletedWithWrappedCancellationException(g);
1325          checkCancelled(f);
1326 <        assertEquals(0, r.invocationCount);
1326 >        r.assertNotInvoked();
1327      }}
1328  
1329      /**
# Line 1088 | Line 1336 | public class CompletableFutureTest exten
1336      {
1337          final CompletableFuture<Integer> f = new CompletableFuture<>();
1338          final FailingRunnable r = new FailingRunnable(m);
1339 <        if (!createIncomplete) f.complete(v1);
1339 >        if (!createIncomplete) assertTrue(f.complete(v1));
1340          final CompletableFuture<Void> g = m.thenRun(f, r);
1341          if (createIncomplete) {
1342              checkIncomplete(g);
1343 <            f.complete(v1);
1343 >            assertTrue(f.complete(v1));
1344          }
1345  
1346          checkCompletedWithWrappedCFException(g);
# Line 1109 | Line 1357 | public class CompletableFutureTest exten
1357      {
1358          final CompletableFuture<Integer> f = new CompletableFuture<>();
1359          final IncFunction r = new IncFunction(m);
1360 <        if (!createIncomplete) f.complete(v1);
1360 >        if (!createIncomplete) assertTrue(f.complete(v1));
1361          final CompletableFuture<Integer> g = m.thenApply(f, r);
1362          if (createIncomplete) {
1363              checkIncomplete(g);
1364 <            f.complete(v1);
1364 >            assertTrue(f.complete(v1));
1365          }
1366  
1367          checkCompletedNormally(g, inc(v1));
1368          checkCompletedNormally(f, v1);
1369 <        assertEquals(1, r.invocationCount);
1369 >        r.assertValue(inc(v1));
1370      }}
1371  
1372      /**
# Line 1139 | Line 1387 | public class CompletableFutureTest exten
1387              f.completeExceptionally(ex);
1388          }
1389  
1390 <        checkCompletedWithWrappedCFException(g, ex);
1391 <        checkCompletedWithWrappedCFException(f, ex);
1392 <        assertEquals(0, r.invocationCount);
1390 >        checkCompletedWithWrappedException(g, ex);
1391 >        checkCompletedExceptionally(f, ex);
1392 >        r.assertNotInvoked();
1393      }}
1394  
1395      /**
# Line 1163 | Line 1411 | public class CompletableFutureTest exten
1411  
1412          checkCompletedWithWrappedCancellationException(g);
1413          checkCancelled(f);
1414 <        assertEquals(0, r.invocationCount);
1414 >        r.assertNotInvoked();
1415      }}
1416  
1417      /**
# Line 1176 | Line 1424 | public class CompletableFutureTest exten
1424      {
1425          final CompletableFuture<Integer> f = new CompletableFuture<>();
1426          final FailingFunction r = new FailingFunction(m);
1427 <        if (!createIncomplete) f.complete(v1);
1427 >        if (!createIncomplete) assertTrue(f.complete(v1));
1428          final CompletableFuture<Integer> g = m.thenApply(f, r);
1429          if (createIncomplete) {
1430              checkIncomplete(g);
1431 <            f.complete(v1);
1431 >            assertTrue(f.complete(v1));
1432          }
1433  
1434          checkCompletedWithWrappedCFException(g);
# Line 1196 | Line 1444 | public class CompletableFutureTest exten
1444          for (Integer v1 : new Integer[] { 1, null })
1445      {
1446          final CompletableFuture<Integer> f = new CompletableFuture<>();
1447 <        final IncAction r = new IncAction();
1448 <        if (!createIncomplete) f.complete(v1);
1447 >        final NoopConsumer r = new NoopConsumer(m);
1448 >        if (!createIncomplete) assertTrue(f.complete(v1));
1449          final CompletableFuture<Void> g = m.thenAccept(f, r);
1450          if (createIncomplete) {
1451              checkIncomplete(g);
1452 <            f.complete(v1);
1452 >            assertTrue(f.complete(v1));
1453          }
1454  
1455          checkCompletedNormally(g, null);
1456 +        r.assertValue(v1);
1457          checkCompletedNormally(f, v1);
1209        assertEquals(1, r.invocationCount);
1210        assertEquals(inc(v1), r.value);
1458      }}
1459  
1460      /**
# Line 1220 | Line 1467 | public class CompletableFutureTest exten
1467      {
1468          final CFException ex = new CFException();
1469          final CompletableFuture<Integer> f = new CompletableFuture<>();
1470 <        final IncAction r = new IncAction();
1470 >        final NoopConsumer r = new NoopConsumer(m);
1471          if (!createIncomplete) f.completeExceptionally(ex);
1472          final CompletableFuture<Void> g = m.thenAccept(f, r);
1473          if (createIncomplete) {
# Line 1228 | Line 1475 | public class CompletableFutureTest exten
1475              f.completeExceptionally(ex);
1476          }
1477  
1478 <        checkCompletedWithWrappedCFException(g, ex);
1479 <        checkCompletedWithWrappedCFException(f, ex);
1480 <        assertEquals(0, r.invocationCount);
1478 >        checkCompletedWithWrappedException(g, ex);
1479 >        checkCompletedExceptionally(f, ex);
1480 >        r.assertNotInvoked();
1481      }}
1482  
1483      /**
1484 <     * thenAccept result completes exceptionally if action does
1484 >     * thenAccept result completes exceptionally if source cancelled
1485       */
1486 <    public void testThenAccept_actionFailed() {
1486 >    public void testThenAccept_sourceCancelled() {
1487          for (ExecutionMode m : ExecutionMode.values())
1488          for (boolean createIncomplete : new boolean[] { true, false })
1489 <        for (Integer v1 : new Integer[] { 1, null })
1489 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1490      {
1491          final CompletableFuture<Integer> f = new CompletableFuture<>();
1492 <        final FailingConsumer r = new FailingConsumer(m);
1493 <        if (!createIncomplete) f.complete(v1);
1492 >        final NoopConsumer r = new NoopConsumer(m);
1493 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1494          final CompletableFuture<Void> g = m.thenAccept(f, r);
1495          if (createIncomplete) {
1496              checkIncomplete(g);
1497 <            f.complete(v1);
1497 >            assertTrue(f.cancel(mayInterruptIfRunning));
1498          }
1499  
1500 <        checkCompletedWithWrappedCFException(g);
1501 <        checkCompletedNormally(f, v1);
1500 >        checkCompletedWithWrappedCancellationException(g);
1501 >        checkCancelled(f);
1502 >        r.assertNotInvoked();
1503      }}
1504  
1505      /**
1506 <     * thenAccept result completes exceptionally if source cancelled
1506 >     * thenAccept result completes exceptionally if action does
1507       */
1508 <    public void testThenAccept_sourceCancelled() {
1508 >    public void testThenAccept_actionFailed() {
1509          for (ExecutionMode m : ExecutionMode.values())
1510          for (boolean createIncomplete : new boolean[] { true, false })
1511 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1511 >        for (Integer v1 : new Integer[] { 1, null })
1512      {
1513          final CompletableFuture<Integer> f = new CompletableFuture<>();
1514 <        final IncAction r = new IncAction();
1515 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1514 >        final FailingConsumer r = new FailingConsumer(m);
1515 >        if (!createIncomplete) f.complete(v1);
1516          final CompletableFuture<Void> g = m.thenAccept(f, r);
1517          if (createIncomplete) {
1518              checkIncomplete(g);
1519 <            assertTrue(f.cancel(mayInterruptIfRunning));
1519 >            f.complete(v1);
1520          }
1521  
1522 <        checkCompletedWithWrappedCancellationException(g);
1523 <        checkCancelled(f);
1276 <        assertEquals(0, r.invocationCount);
1522 >        checkCompletedWithWrappedCFException(g);
1523 >        checkCompletedNormally(f, v1);
1524      }}
1525  
1526      /**
# Line 1291 | Line 1538 | public class CompletableFutureTest exten
1538          final CompletableFuture<Integer> g = new CompletableFuture<>();
1539          final SubtractFunction r = new SubtractFunction(m);
1540  
1541 <        if (fFirst) f.complete(v1); else g.complete(v2);
1541 >        assertTrue(fFirst ? f.complete(v1) : g.complete(v2));
1542          if (!createIncomplete)
1543 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1543 >            assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1544          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1545          if (createIncomplete) {
1546              checkIncomplete(h);
1547 <            assertEquals(0, r.invocationCount);
1548 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1547 >            r.assertNotInvoked();
1548 >            assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1549          }
1550  
1551          checkCompletedNormally(h, subtract(v1, v2));
1552          checkCompletedNormally(f, v1);
1553          checkCompletedNormally(g, v2);
1554 <        assertEquals(1, r.invocationCount);
1554 >        r.assertValue(subtract(v1, v2));
1555      }}
1556  
1557      /**
# Line 1322 | Line 1569 | public class CompletableFutureTest exten
1569          final CFException ex = new CFException();
1570          final SubtractFunction r = new SubtractFunction(m);
1571  
1572 <        (fFirst ? f : g).complete(v1);
1572 >        assertTrue((fFirst ? f : g).complete(v1));
1573          if (!createIncomplete)
1574 <            (!fFirst ? f : g).completeExceptionally(ex);
1574 >            assertTrue((!fFirst ? f : g).completeExceptionally(ex));
1575          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1576          if (createIncomplete) {
1577              checkIncomplete(h);
1578 <            (!fFirst ? f : g).completeExceptionally(ex);
1578 >            assertTrue((!fFirst ? f : g).completeExceptionally(ex));
1579          }
1580  
1581 <        checkCompletedWithWrappedCFException(h, ex);
1582 <        assertEquals(0, r.invocationCount);
1581 >        checkCompletedWithWrappedException(h, ex);
1582 >        r.assertNotInvoked();
1583          checkCompletedNormally(fFirst ? f : g, v1);
1584 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1338 <    }}
1339 <
1340 <    /**
1341 <     * thenCombine result completes exceptionally if action does
1342 <     */
1343 <    public void testThenCombine_actionFailed() {
1344 <        for (ExecutionMode m : ExecutionMode.values())
1345 <        for (boolean fFirst : new boolean[] { true, false })
1346 <        for (Integer v1 : new Integer[] { 1, null })
1347 <        for (Integer v2 : new Integer[] { 2, null })
1348 <    {
1349 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1350 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1351 <        final FailingBiFunction r = new FailingBiFunction(m);
1352 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1353 <
1354 <        if (fFirst) {
1355 <            f.complete(v1);
1356 <            g.complete(v2);
1357 <        } else {
1358 <            g.complete(v2);
1359 <            f.complete(v1);
1360 <        }
1361 <
1362 <        checkCompletedWithWrappedCFException(h);
1363 <        checkCompletedNormally(f, v1);
1364 <        checkCompletedNormally(g, v2);
1584 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1585      }}
1586  
1587      /**
# Line 1378 | Line 1598 | public class CompletableFutureTest exten
1598          final CompletableFuture<Integer> g = new CompletableFuture<>();
1599          final SubtractFunction r = new SubtractFunction(m);
1600  
1601 <        (fFirst ? f : g).complete(v1);
1601 >        assertTrue((fFirst ? f : g).complete(v1));
1602          if (!createIncomplete)
1603              assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1604          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
# Line 1389 | Line 1609 | public class CompletableFutureTest exten
1609  
1610          checkCompletedWithWrappedCancellationException(h);
1611          checkCancelled(!fFirst ? f : g);
1612 <        assertEquals(0, r.invocationCount);
1612 >        r.assertNotInvoked();
1613          checkCompletedNormally(fFirst ? f : g, v1);
1614      }}
1615  
1616      /**
1617 +     * thenCombine result completes exceptionally if action does
1618 +     */
1619 +    public void testThenCombine_actionFailed() {
1620 +        for (ExecutionMode m : ExecutionMode.values())
1621 +        for (boolean fFirst : new boolean[] { true, false })
1622 +        for (Integer v1 : new Integer[] { 1, null })
1623 +        for (Integer v2 : new Integer[] { 2, null })
1624 +    {
1625 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1626 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1627 +        final FailingBiFunction r = new FailingBiFunction(m);
1628 +        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1629 +
1630 +        assertTrue( fFirst ? f.complete(v1) : g.complete(v2));
1631 +        assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1632 +
1633 +        checkCompletedWithWrappedCFException(h);
1634 +        checkCompletedNormally(f, v1);
1635 +        checkCompletedNormally(g, v2);
1636 +    }}
1637 +
1638 +    /**
1639       * thenAcceptBoth result completes normally after normal
1640       * completion of sources
1641       */
# Line 1408 | Line 1650 | public class CompletableFutureTest exten
1650          final CompletableFuture<Integer> g = new CompletableFuture<>();
1651          final SubtractAction r = new SubtractAction(m);
1652  
1653 <        if (fFirst) f.complete(v1); else g.complete(v2);
1653 >        assertTrue(fFirst ? f.complete(v1) : g.complete(v2));
1654          if (!createIncomplete)
1655 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1655 >            assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1656          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1657          if (createIncomplete) {
1658              checkIncomplete(h);
1659 <            assertEquals(0, r.invocationCount);
1660 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1659 >            r.assertNotInvoked();
1660 >            assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1661          }
1662  
1663          checkCompletedNormally(h, null);
1664 <        assertEquals(subtract(v1, v2), r.value);
1664 >        r.assertValue(subtract(v1, v2));
1665          checkCompletedNormally(f, v1);
1666          checkCompletedNormally(g, v2);
1667      }}
# Line 1439 | Line 1681 | public class CompletableFutureTest exten
1681          final CFException ex = new CFException();
1682          final SubtractAction r = new SubtractAction(m);
1683  
1684 <        (fFirst ? f : g).complete(v1);
1684 >        assertTrue((fFirst ? f : g).complete(v1));
1685          if (!createIncomplete)
1686 <            (!fFirst ? f : g).completeExceptionally(ex);
1686 >            assertTrue((!fFirst ? f : g).completeExceptionally(ex));
1687          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1688          if (createIncomplete) {
1689              checkIncomplete(h);
1690 <            (!fFirst ? f : g).completeExceptionally(ex);
1690 >            assertTrue((!fFirst ? f : g).completeExceptionally(ex));
1691          }
1692  
1693 <        checkCompletedWithWrappedCFException(h, ex);
1694 <        assertEquals(0, r.invocationCount);
1693 >        checkCompletedWithWrappedException(h, ex);
1694 >        r.assertNotInvoked();
1695          checkCompletedNormally(fFirst ? f : g, v1);
1696 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1455 <    }}
1456 <
1457 <    /**
1458 <     * thenAcceptBoth result completes exceptionally if action does
1459 <     */
1460 <    public void testThenAcceptBoth_actionFailed() {
1461 <        for (ExecutionMode m : ExecutionMode.values())
1462 <        for (boolean fFirst : new boolean[] { true, false })
1463 <        for (Integer v1 : new Integer[] { 1, null })
1464 <        for (Integer v2 : new Integer[] { 2, null })
1465 <    {
1466 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1467 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1468 <        final FailingBiConsumer r = new FailingBiConsumer(m);
1469 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1470 <
1471 <        if (fFirst) {
1472 <            f.complete(v1);
1473 <            g.complete(v2);
1474 <        } else {
1475 <            g.complete(v2);
1476 <            f.complete(v1);
1477 <        }
1478 <
1479 <        checkCompletedWithWrappedCFException(h);
1480 <        checkCompletedNormally(f, v1);
1481 <        checkCompletedNormally(g, v2);
1696 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1697      }}
1698  
1699      /**
# Line 1495 | Line 1710 | public class CompletableFutureTest exten
1710          final CompletableFuture<Integer> g = new CompletableFuture<>();
1711          final SubtractAction r = new SubtractAction(m);
1712  
1713 <        (fFirst ? f : g).complete(v1);
1713 >        assertTrue((fFirst ? f : g).complete(v1));
1714          if (!createIncomplete)
1715              assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1716          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
# Line 1506 | Line 1721 | public class CompletableFutureTest exten
1721  
1722          checkCompletedWithWrappedCancellationException(h);
1723          checkCancelled(!fFirst ? f : g);
1724 <        assertEquals(0, r.invocationCount);
1724 >        r.assertNotInvoked();
1725          checkCompletedNormally(fFirst ? f : g, v1);
1726      }}
1727  
1728      /**
1729 +     * thenAcceptBoth result completes exceptionally if action does
1730 +     */
1731 +    public void testThenAcceptBoth_actionFailed() {
1732 +        for (ExecutionMode m : ExecutionMode.values())
1733 +        for (boolean fFirst : new boolean[] { true, false })
1734 +        for (Integer v1 : new Integer[] { 1, null })
1735 +        for (Integer v2 : new Integer[] { 2, null })
1736 +    {
1737 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1738 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1739 +        final FailingBiConsumer r = new FailingBiConsumer(m);
1740 +        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1741 +
1742 +        assertTrue(fFirst ? f.complete(v1) : g.complete(v2));
1743 +        assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1744 +
1745 +        checkCompletedWithWrappedCFException(h);
1746 +        checkCompletedNormally(f, v1);
1747 +        checkCompletedNormally(g, v2);
1748 +    }}
1749 +
1750 +    /**
1751       * runAfterBoth result completes normally after normal
1752       * completion of sources
1753       */
# Line 1525 | Line 1762 | public class CompletableFutureTest exten
1762          final CompletableFuture<Integer> g = new CompletableFuture<>();
1763          final Noop r = new Noop(m);
1764  
1765 <        if (fFirst) f.complete(v1); else g.complete(v2);
1765 >        assertTrue(fFirst ? f.complete(v1) : g.complete(v2));
1766          if (!createIncomplete)
1767 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1767 >            assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1768          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1769          if (createIncomplete) {
1770              checkIncomplete(h);
1771 <            assertEquals(0, r.invocationCount);
1772 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1771 >            r.assertNotInvoked();
1772 >            assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1773          }
1774  
1775          checkCompletedNormally(h, null);
1776 <        assertEquals(1, r.invocationCount);
1776 >        r.assertInvoked();
1777          checkCompletedNormally(f, v1);
1778          checkCompletedNormally(g, v2);
1779      }}
# Line 1556 | Line 1793 | public class CompletableFutureTest exten
1793          final CFException ex = new CFException();
1794          final Noop r = new Noop(m);
1795  
1796 <        (fFirst ? f : g).complete(v1);
1796 >        assertTrue((fFirst ? f : g).complete(v1));
1797          if (!createIncomplete)
1798 <            (!fFirst ? f : g).completeExceptionally(ex);
1798 >            assertTrue((!fFirst ? f : g).completeExceptionally(ex));
1799          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1800          if (createIncomplete) {
1801              checkIncomplete(h);
1802 <            (!fFirst ? f : g).completeExceptionally(ex);
1802 >            assertTrue((!fFirst ? f : g).completeExceptionally(ex));
1803          }
1804  
1805 <        checkCompletedWithWrappedCFException(h, ex);
1806 <        assertEquals(0, r.invocationCount);
1805 >        checkCompletedWithWrappedException(h, ex);
1806 >        r.assertNotInvoked();
1807          checkCompletedNormally(fFirst ? f : g, v1);
1808 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1572 <    }}
1573 <
1574 <    /**
1575 <     * runAfterBoth result completes exceptionally if action does
1576 <     */
1577 <    public void testRunAfterBoth_actionFailed() {
1578 <        for (ExecutionMode m : ExecutionMode.values())
1579 <        for (boolean fFirst : new boolean[] { true, false })
1580 <        for (Integer v1 : new Integer[] { 1, null })
1581 <        for (Integer v2 : new Integer[] { 2, null })
1582 <    {
1583 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1584 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1585 <        final FailingRunnable r = new FailingRunnable(m);
1586 <
1587 <        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1588 <        if (fFirst) {
1589 <            f.complete(v1);
1590 <            g.complete(v2);
1591 <        } else {
1592 <            g.complete(v2);
1593 <            f.complete(v1);
1594 <        }
1595 <        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1596 <
1597 <        checkCompletedWithWrappedCFException(h1);
1598 <        checkCompletedWithWrappedCFException(h2);
1599 <        checkCompletedNormally(f, v1);
1600 <        checkCompletedNormally(g, v2);
1808 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1809      }}
1810  
1811      /**
# Line 1614 | Line 1822 | public class CompletableFutureTest exten
1822          final CompletableFuture<Integer> g = new CompletableFuture<>();
1823          final Noop r = new Noop(m);
1824  
1825 <
1618 <        (fFirst ? f : g).complete(v1);
1825 >        assertTrue((fFirst ? f : g).complete(v1));
1826          if (!createIncomplete)
1827              assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1828          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
# Line 1626 | Line 1833 | public class CompletableFutureTest exten
1833  
1834          checkCompletedWithWrappedCancellationException(h);
1835          checkCancelled(!fFirst ? f : g);
1836 <        assertEquals(0, r.invocationCount);
1836 >        r.assertNotInvoked();
1837          checkCompletedNormally(fFirst ? f : g, v1);
1838      }}
1839  
1840      /**
1841 <     * applyToEither result completes normally after normal completion
1635 <     * of either source
1841 >     * runAfterBoth result completes exceptionally if action does
1842       */
1843 <    public void testApplyToEither_normalCompletion() {
1843 >    public void testRunAfterBoth_actionFailed() {
1844          for (ExecutionMode m : ExecutionMode.values())
1639        for (boolean createIncomplete : new boolean[] { true, false })
1845          for (boolean fFirst : new boolean[] { true, false })
1846          for (Integer v1 : new Integer[] { 1, null })
1847          for (Integer v2 : new Integer[] { 2, null })
1848      {
1849          final CompletableFuture<Integer> f = new CompletableFuture<>();
1850          final CompletableFuture<Integer> g = new CompletableFuture<>();
1851 <        final IncFunction r = new IncFunction(m);
1851 >        final FailingRunnable r1 = new FailingRunnable(m);
1852 >        final FailingRunnable r2 = new FailingRunnable(m);
1853  
1854 <        if (!createIncomplete)
1855 <            if (fFirst) f.complete(v1); else g.complete(v2);
1856 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1857 <        if (createIncomplete) {
1652 <            checkIncomplete(h);
1653 <            assertEquals(0, r.invocationCount);
1654 <            if (fFirst) f.complete(v1); else g.complete(v2);
1655 <        }
1656 <        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1657 <        if (!fFirst) f.complete(v1); else g.complete(v2);
1854 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1855 >        assertTrue(fFirst ? f.complete(v1) : g.complete(v2));
1856 >        assertTrue(!fFirst ? f.complete(v1) : g.complete(v2));
1857 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1858  
1859 +        checkCompletedWithWrappedCFException(h1);
1860 +        checkCompletedWithWrappedCFException(h2);
1861          checkCompletedNormally(f, v1);
1862          checkCompletedNormally(g, v2);
1661        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1863      }}
1864  
1865 <    public void testApplyToEither_normalCompletionBothAvailable() {
1865 >    /**
1866 >     * applyToEither result completes normally after normal completion
1867 >     * of either source
1868 >     */
1869 >    public void testApplyToEither_normalCompletion() {
1870          for (ExecutionMode m : ExecutionMode.values())
1666        for (boolean fFirst : new boolean[] { true, false })
1871          for (Integer v1 : new Integer[] { 1, null })
1872          for (Integer v2 : new Integer[] { 2, null })
1873      {
1874          final CompletableFuture<Integer> f = new CompletableFuture<>();
1875          final CompletableFuture<Integer> g = new CompletableFuture<>();
1876 <        final IncFunction r = new IncFunction(m);
1876 >        final IncFunction[] rs = new IncFunction[6];
1877 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1878  
1879 <        if (fFirst) {
1880 <            f.complete(v1);
1881 <            g.complete(v2);
1882 <        } else {
1883 <            g.complete(v2);
1884 <            f.complete(v1);
1885 <        }
1879 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1880 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1881 >        checkIncomplete(h0);
1882 >        checkIncomplete(h1);
1883 >        rs[0].assertNotInvoked();
1884 >        rs[1].assertNotInvoked();
1885 >        f.complete(v1);
1886 >        checkCompletedNormally(h0, inc(v1));
1887 >        checkCompletedNormally(h1, inc(v1));
1888 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1889 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1890 >        checkCompletedNormally(h2, inc(v1));
1891 >        checkCompletedNormally(h3, inc(v1));
1892 >        g.complete(v2);
1893  
1894 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1894 >        // unspecified behavior - both source completions available
1895 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1896 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1897 >        rs[4].assertValue(h4.join());
1898 >        rs[5].assertValue(h5.join());
1899 >        assertTrue(Objects.equals(inc(v1), h4.join()) ||
1900 >                   Objects.equals(inc(v2), h4.join()));
1901 >        assertTrue(Objects.equals(inc(v1), h5.join()) ||
1902 >                   Objects.equals(inc(v2), h5.join()));
1903  
1904          checkCompletedNormally(f, v1);
1905          checkCompletedNormally(g, v2);
1906 <
1907 <        // unspecified behavior
1908 <        assertTrue(Objects.equals(h.join(), inc(v1)) ||
1909 <                   Objects.equals(h.join(), inc(v2)));
1910 <        assertEquals(1, r.invocationCount);
1906 >        checkCompletedNormally(h0, inc(v1));
1907 >        checkCompletedNormally(h1, inc(v1));
1908 >        checkCompletedNormally(h2, inc(v1));
1909 >        checkCompletedNormally(h3, inc(v1));
1910 >        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
1911      }}
1912  
1913      /**
1914       * applyToEither result completes exceptionally after exceptional
1915       * completion of either source
1916       */
1917 <    public void testApplyToEither_exceptionalCompletion1() {
1917 >    public void testApplyToEither_exceptionalCompletion() {
1918          for (ExecutionMode m : ExecutionMode.values())
1699        for (boolean createIncomplete : new boolean[] { true, false })
1700        for (boolean fFirst : new boolean[] { true, false })
1919          for (Integer v1 : new Integer[] { 1, null })
1920      {
1921          final CompletableFuture<Integer> f = new CompletableFuture<>();
1922          final CompletableFuture<Integer> g = new CompletableFuture<>();
1923          final CFException ex = new CFException();
1924 <        final IncFunction r = new IncFunction(m);
1924 >        final IncFunction[] rs = new IncFunction[6];
1925 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1926  
1927 <        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1928 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1929 <        if (createIncomplete) {
1930 <            checkIncomplete(h);
1931 <            assertEquals(0, r.invocationCount);
1932 <            (fFirst ? f : g).completeExceptionally(ex);
1933 <        }
1927 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1928 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1929 >        checkIncomplete(h0);
1930 >        checkIncomplete(h1);
1931 >        rs[0].assertNotInvoked();
1932 >        rs[1].assertNotInvoked();
1933 >        f.completeExceptionally(ex);
1934 >        checkCompletedWithWrappedException(h0, ex);
1935 >        checkCompletedWithWrappedException(h1, ex);
1936 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1937 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1938 >        checkCompletedWithWrappedException(h2, ex);
1939 >        checkCompletedWithWrappedException(h3, ex);
1940 >        g.complete(v1);
1941  
1942 <        checkCompletedWithWrappedCFException(h, ex);
1943 <        (!fFirst ? f : g).complete(v1);
1942 >        // unspecified behavior - both source completions available
1943 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1944 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1945 >        try {
1946 >            assertEquals(inc(v1), h4.join());
1947 >            rs[4].assertValue(inc(v1));
1948 >        } catch (CompletionException ok) {
1949 >            checkCompletedWithWrappedException(h4, ex);
1950 >            rs[4].assertNotInvoked();
1951 >        }
1952 >        try {
1953 >            assertEquals(inc(v1), h5.join());
1954 >            rs[5].assertValue(inc(v1));
1955 >        } catch (CompletionException ok) {
1956 >            checkCompletedWithWrappedException(h5, ex);
1957 >            rs[5].assertNotInvoked();
1958 >        }
1959  
1960 <        assertEquals(0, r.invocationCount);
1961 <        checkCompletedNormally(!fFirst ? f : g, v1);
1962 <        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1963 <        checkCompletedWithWrappedCFException(h, ex);
1960 >        checkCompletedExceptionally(f, ex);
1961 >        checkCompletedNormally(g, v1);
1962 >        checkCompletedWithWrappedException(h0, ex);
1963 >        checkCompletedWithWrappedException(h1, ex);
1964 >        checkCompletedWithWrappedException(h2, ex);
1965 >        checkCompletedWithWrappedException(h3, ex);
1966 >        checkCompletedWithWrappedException(h4, ex);
1967 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1968      }}
1969  
1970      public void testApplyToEither_exceptionalCompletion2() {
1971          for (ExecutionMode m : ExecutionMode.values())
1727        for (boolean reverseArgs : new boolean[] { true, false })
1972          for (boolean fFirst : new boolean[] { true, false })
1973          for (Integer v1 : new Integer[] { 1, null })
1974      {
1975          final CompletableFuture<Integer> f = new CompletableFuture<>();
1976          final CompletableFuture<Integer> g = new CompletableFuture<>();
1733        final IncFunction r1 = new IncFunction(m);
1734        final IncFunction r2 = new IncFunction(m);
1977          final CFException ex = new CFException();
1978 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1979 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1980 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1981 <        if (fFirst) {
1982 <            f.complete(v1);
1983 <            g.completeExceptionally(ex);
1984 <        } else {
1985 <            g.completeExceptionally(ex);
1986 <            f.complete(v1);
1745 <        }
1746 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1978 >        final IncFunction[] rs = new IncFunction[6];
1979 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1980 >
1981 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1982 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1983 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
1984 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
1985 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1986 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1987  
1988 <        // unspecified behavior
1988 >        // unspecified behavior - both source completions available
1989 >        try {
1990 >            assertEquals(inc(v1), h0.join());
1991 >            rs[0].assertValue(inc(v1));
1992 >        } catch (CompletionException ok) {
1993 >            checkCompletedWithWrappedException(h0, ex);
1994 >            rs[0].assertNotInvoked();
1995 >        }
1996          try {
1997              assertEquals(inc(v1), h1.join());
1998 <            assertEquals(1, r1.invocationCount);
1998 >            rs[1].assertValue(inc(v1));
1999          } catch (CompletionException ok) {
2000 <            checkCompletedWithWrappedCFException(h1, ex);
2001 <            assertEquals(0, r1.invocationCount);
2000 >            checkCompletedWithWrappedException(h1, ex);
2001 >            rs[1].assertNotInvoked();
2002          }
1756
2003          try {
2004              assertEquals(inc(v1), h2.join());
2005 <            assertEquals(1, r2.invocationCount);
2005 >            rs[2].assertValue(inc(v1));
2006          } catch (CompletionException ok) {
2007 <            checkCompletedWithWrappedCFException(h2, ex);
2008 <            assertEquals(0, r2.invocationCount);
2007 >            checkCompletedWithWrappedException(h2, ex);
2008 >            rs[2].assertNotInvoked();
2009 >        }
2010 >        try {
2011 >            assertEquals(inc(v1), h3.join());
2012 >            rs[3].assertValue(inc(v1));
2013 >        } catch (CompletionException ok) {
2014 >            checkCompletedWithWrappedException(h3, ex);
2015 >            rs[3].assertNotInvoked();
2016          }
2017  
1765        checkCompletedWithWrappedCFException(g, ex);
1766        checkCompletedNormally(f, v1);
1767    }}
1768
1769    /**
1770     * applyToEither result completes exceptionally if action does
1771     */
1772    public void testApplyToEither_actionFailed1() {
1773        for (ExecutionMode m : ExecutionMode.values())
1774        for (Integer v1 : new Integer[] { 1, null })
1775        for (Integer v2 : new Integer[] { 2, null })
1776    {
1777        final CompletableFuture<Integer> f = new CompletableFuture<>();
1778        final CompletableFuture<Integer> g = new CompletableFuture<>();
1779        final FailingFunction r = new FailingFunction(m);
1780        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1781
1782        f.complete(v1);
1783        checkCompletedWithWrappedCFException(h);
1784        g.complete(v2);
1785        checkCompletedNormally(f, v1);
1786        checkCompletedNormally(g, v2);
1787    }}
1788
1789    public void testApplyToEither_actionFailed2() {
1790        for (ExecutionMode m : ExecutionMode.values())
1791        for (Integer v1 : new Integer[] { 1, null })
1792        for (Integer v2 : new Integer[] { 2, null })
1793    {
1794        final CompletableFuture<Integer> f = new CompletableFuture<>();
1795        final CompletableFuture<Integer> g = new CompletableFuture<>();
1796        final FailingFunction r = new FailingFunction(m);
1797        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1798
1799        g.complete(v2);
1800        checkCompletedWithWrappedCFException(h);
1801        f.complete(v1);
2018          checkCompletedNormally(f, v1);
2019 <        checkCompletedNormally(g, v2);
2019 >        checkCompletedExceptionally(g, ex);
2020      }}
2021  
2022      /**
2023       * applyToEither result completes exceptionally if either source cancelled
2024       */
2025 <    public void testApplyToEither_sourceCancelled1() {
2025 >    public void testApplyToEither_sourceCancelled() {
2026          for (ExecutionMode m : ExecutionMode.values())
2027          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1812        for (boolean createIncomplete : new boolean[] { true, false })
1813        for (boolean fFirst : new boolean[] { true, false })
2028          for (Integer v1 : new Integer[] { 1, null })
2029      {
2030          final CompletableFuture<Integer> f = new CompletableFuture<>();
2031          final CompletableFuture<Integer> g = new CompletableFuture<>();
2032 <        final IncFunction r = new IncFunction(m);
2032 >        final IncFunction[] rs = new IncFunction[6];
2033 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2034  
2035 <        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
2036 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2037 <        if (createIncomplete) {
2038 <            checkIncomplete(h);
2039 <            assertEquals(0, r.invocationCount);
2040 <            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
2041 <        }
2035 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2036 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2037 >        checkIncomplete(h0);
2038 >        checkIncomplete(h1);
2039 >        rs[0].assertNotInvoked();
2040 >        rs[1].assertNotInvoked();
2041 >        f.cancel(mayInterruptIfRunning);
2042 >        checkCompletedWithWrappedCancellationException(h0);
2043 >        checkCompletedWithWrappedCancellationException(h1);
2044 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2045 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2046 >        checkCompletedWithWrappedCancellationException(h2);
2047 >        checkCompletedWithWrappedCancellationException(h3);
2048 >        g.complete(v1);
2049  
2050 <        checkCompletedWithWrappedCancellationException(h);
2051 <        (!fFirst ? f : g).complete(v1);
2050 >        // unspecified behavior - both source completions available
2051 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2052 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2053 >        try {
2054 >            assertEquals(inc(v1), h4.join());
2055 >            rs[4].assertValue(inc(v1));
2056 >        } catch (CompletionException ok) {
2057 >            checkCompletedWithWrappedCancellationException(h4);
2058 >            rs[4].assertNotInvoked();
2059 >        }
2060 >        try {
2061 >            assertEquals(inc(v1), h5.join());
2062 >            rs[5].assertValue(inc(v1));
2063 >        } catch (CompletionException ok) {
2064 >            checkCompletedWithWrappedCancellationException(h5);
2065 >            rs[5].assertNotInvoked();
2066 >        }
2067  
2068 <        assertEquals(0, r.invocationCount);
2069 <        checkCompletedNormally(!fFirst ? f : g, v1);
2070 <        checkCancelled(fFirst ? f : g);
2071 <        checkCompletedWithWrappedCancellationException(h);
2068 >        checkCancelled(f);
2069 >        checkCompletedNormally(g, v1);
2070 >        checkCompletedWithWrappedCancellationException(h0);
2071 >        checkCompletedWithWrappedCancellationException(h1);
2072 >        checkCompletedWithWrappedCancellationException(h2);
2073 >        checkCompletedWithWrappedCancellationException(h3);
2074 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2075      }}
2076  
2077      public void testApplyToEither_sourceCancelled2() {
2078          for (ExecutionMode m : ExecutionMode.values())
2079          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1840        for (boolean reverseArgs : new boolean[] { true, false })
2080          for (boolean fFirst : new boolean[] { true, false })
2081          for (Integer v1 : new Integer[] { 1, null })
2082      {
2083          final CompletableFuture<Integer> f = new CompletableFuture<>();
2084          final CompletableFuture<Integer> g = new CompletableFuture<>();
2085 <        final IncFunction r1 = new IncFunction(m);
2086 <        final IncFunction r2 = new IncFunction(m);
1848 <        final CFException ex = new CFException();
1849 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1850 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
2085 >        final IncFunction[] rs = new IncFunction[6];
2086 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2087  
2088 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
2089 <        if (fFirst) {
2090 <            f.complete(v1);
2091 <            assertTrue(g.cancel(mayInterruptIfRunning));
2092 <        } else {
2093 <            assertTrue(g.cancel(mayInterruptIfRunning));
1858 <            f.complete(v1);
1859 <        }
1860 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
2088 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2089 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2090 >        assertTrue(fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2091 >        assertTrue(!fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2092 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2093 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2094  
2095 <        // unspecified behavior
2095 >        // unspecified behavior - both source completions available
2096 >        try {
2097 >            assertEquals(inc(v1), h0.join());
2098 >            rs[0].assertValue(inc(v1));
2099 >        } catch (CompletionException ok) {
2100 >            checkCompletedWithWrappedCancellationException(h0);
2101 >            rs[0].assertNotInvoked();
2102 >        }
2103          try {
2104              assertEquals(inc(v1), h1.join());
2105 <            assertEquals(1, r1.invocationCount);
2105 >            rs[1].assertValue(inc(v1));
2106          } catch (CompletionException ok) {
2107              checkCompletedWithWrappedCancellationException(h1);
2108 <            assertEquals(0, r1.invocationCount);
2108 >            rs[1].assertNotInvoked();
2109          }
1870
2110          try {
2111              assertEquals(inc(v1), h2.join());
2112 <            assertEquals(1, r2.invocationCount);
2112 >            rs[2].assertValue(inc(v1));
2113          } catch (CompletionException ok) {
2114              checkCompletedWithWrappedCancellationException(h2);
2115 <            assertEquals(0, r2.invocationCount);
2115 >            rs[2].assertNotInvoked();
2116 >        }
2117 >        try {
2118 >            assertEquals(inc(v1), h3.join());
2119 >            rs[3].assertValue(inc(v1));
2120 >        } catch (CompletionException ok) {
2121 >            checkCompletedWithWrappedCancellationException(h3);
2122 >            rs[3].assertNotInvoked();
2123          }
2124  
1879        checkCancelled(g);
2125          checkCompletedNormally(f, v1);
2126 +        checkCancelled(g);
2127      }}
2128  
2129      /**
2130 <     * acceptEither result completes normally after normal completion
1885 <     * of either source
2130 >     * applyToEither result completes exceptionally if action does
2131       */
2132 <    public void testAcceptEither_normalCompletion1() {
2132 >    public void testApplyToEither_actionFailed() {
2133          for (ExecutionMode m : ExecutionMode.values())
2134          for (Integer v1 : new Integer[] { 1, null })
2135          for (Integer v2 : new Integer[] { 2, null })
2136      {
2137          final CompletableFuture<Integer> f = new CompletableFuture<>();
2138          final CompletableFuture<Integer> g = new CompletableFuture<>();
2139 <        final IncAction r = new IncAction();
2140 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2139 >        final FailingFunction[] rs = new FailingFunction[6];
2140 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
2141  
2142 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2143 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2144          f.complete(v1);
2145 <        checkCompletedNormally(h, null);
2146 <        assertEquals(inc(v1), r.value);
2147 <        g.complete(v2);
2148 <
2149 <        checkCompletedNormally(f, v1);
2150 <        checkCompletedNormally(g, v2);
2151 <        checkCompletedNormally(h, null);
1905 <    }}
1906 <
1907 <    public void testAcceptEither_normalCompletion2() {
1908 <        for (ExecutionMode m : ExecutionMode.values())
1909 <        for (Integer v1 : new Integer[] { 1, null })
1910 <        for (Integer v2 : new Integer[] { 2, null })
1911 <    {
1912 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1913 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1914 <        final IncAction r = new IncAction();
1915 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2145 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2146 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2147 >        checkCompletedWithWrappedCFException(h0);
2148 >        checkCompletedWithWrappedCFException(h1);
2149 >        checkCompletedWithWrappedCFException(h2);
2150 >        checkCompletedWithWrappedCFException(h3);
2151 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2152  
2153          g.complete(v2);
2154 <        checkCompletedNormally(h, null);
2155 <        assertEquals(inc(v2), r.value);
2156 <        f.complete(v1);
2154 >
2155 >        // unspecified behavior - both source completions available
2156 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2157 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2158 >
2159 >        checkCompletedWithWrappedCFException(h4);
2160 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2161 >                   Objects.equals(v2, rs[4].value));
2162 >        checkCompletedWithWrappedCFException(h5);
2163 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2164 >                   Objects.equals(v2, rs[5].value));
2165  
2166          checkCompletedNormally(f, v1);
2167          checkCompletedNormally(g, v2);
1924        checkCompletedNormally(h, null);
2168      }}
2169  
2170 <    public void testAcceptEither_normalCompletion3() {
2170 >    /**
2171 >     * acceptEither result completes normally after normal completion
2172 >     * of either source
2173 >     */
2174 >    public void testAcceptEither_normalCompletion() {
2175          for (ExecutionMode m : ExecutionMode.values())
2176          for (Integer v1 : new Integer[] { 1, null })
2177          for (Integer v2 : new Integer[] { 2, null })
2178      {
2179          final CompletableFuture<Integer> f = new CompletableFuture<>();
2180          final CompletableFuture<Integer> g = new CompletableFuture<>();
2181 <        final IncAction r = new IncAction();
2181 >        final NoopConsumer[] rs = new NoopConsumer[6];
2182 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2183  
2184 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2185 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2186 +        checkIncomplete(h0);
2187 +        checkIncomplete(h1);
2188 +        rs[0].assertNotInvoked();
2189 +        rs[1].assertNotInvoked();
2190          f.complete(v1);
2191 +        checkCompletedNormally(h0, null);
2192 +        checkCompletedNormally(h1, null);
2193 +        rs[0].assertValue(v1);
2194 +        rs[1].assertValue(v1);
2195 +        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2196 +        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2197 +        checkCompletedNormally(h2, null);
2198 +        checkCompletedNormally(h3, null);
2199 +        rs[2].assertValue(v1);
2200 +        rs[3].assertValue(v1);
2201          g.complete(v2);
1938        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2202  
2203 <        checkCompletedNormally(h, null);
2203 >        // unspecified behavior - both source completions available
2204 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2205 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2206 >        checkCompletedNormally(h4, null);
2207 >        checkCompletedNormally(h5, null);
2208 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2209 >                   Objects.equals(v2, rs[4].value));
2210 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2211 >                   Objects.equals(v2, rs[5].value));
2212 >
2213          checkCompletedNormally(f, v1);
2214          checkCompletedNormally(g, v2);
2215 <
2216 <        // unspecified behavior
2217 <        assertTrue(Objects.equals(r.value, inc(v1)) ||
2218 <                   Objects.equals(r.value, inc(v2)));
2215 >        checkCompletedNormally(h0, null);
2216 >        checkCompletedNormally(h1, null);
2217 >        checkCompletedNormally(h2, null);
2218 >        checkCompletedNormally(h3, null);
2219 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2220      }}
2221  
2222      /**
2223       * acceptEither result completes exceptionally after exceptional
2224       * completion of either source
2225       */
2226 <    public void testAcceptEither_exceptionalCompletion1() {
2226 >    public void testAcceptEither_exceptionalCompletion() {
2227          for (ExecutionMode m : ExecutionMode.values())
2228          for (Integer v1 : new Integer[] { 1, null })
2229      {
2230          final CompletableFuture<Integer> f = new CompletableFuture<>();
2231          final CompletableFuture<Integer> g = new CompletableFuture<>();
1959        final IncAction r = new IncAction();
1960        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2232          final CFException ex = new CFException();
2233 +        final NoopConsumer[] rs = new NoopConsumer[6];
2234 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2235  
2236 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2237 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2238 +        checkIncomplete(h0);
2239 +        checkIncomplete(h1);
2240 +        rs[0].assertNotInvoked();
2241 +        rs[1].assertNotInvoked();
2242          f.completeExceptionally(ex);
2243 <        checkCompletedWithWrappedCFException(h, ex);
2243 >        checkCompletedWithWrappedException(h0, ex);
2244 >        checkCompletedWithWrappedException(h1, ex);
2245 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2246 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2247 >        checkCompletedWithWrappedException(h2, ex);
2248 >        checkCompletedWithWrappedException(h3, ex);
2249 >
2250          g.complete(v1);
2251  
2252 <        assertEquals(0, r.invocationCount);
2252 >        // unspecified behavior - both source completions available
2253 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2254 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2255 >        try {
2256 >            assertNull(h4.join());
2257 >            rs[4].assertValue(v1);
2258 >        } catch (CompletionException ok) {
2259 >            checkCompletedWithWrappedException(h4, ex);
2260 >            rs[4].assertNotInvoked();
2261 >        }
2262 >        try {
2263 >            assertNull(h5.join());
2264 >            rs[5].assertValue(v1);
2265 >        } catch (CompletionException ok) {
2266 >            checkCompletedWithWrappedException(h5, ex);
2267 >            rs[5].assertNotInvoked();
2268 >        }
2269 >
2270 >        checkCompletedExceptionally(f, ex);
2271          checkCompletedNormally(g, v1);
2272 <        checkCompletedWithWrappedCFException(f, ex);
2273 <        checkCompletedWithWrappedCFException(h, ex);
2272 >        checkCompletedWithWrappedException(h0, ex);
2273 >        checkCompletedWithWrappedException(h1, ex);
2274 >        checkCompletedWithWrappedException(h2, ex);
2275 >        checkCompletedWithWrappedException(h3, ex);
2276 >        checkCompletedWithWrappedException(h4, ex);
2277 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2278      }}
2279  
2280      public void testAcceptEither_exceptionalCompletion2() {
2281          for (ExecutionMode m : ExecutionMode.values())
2282 +        for (boolean fFirst : new boolean[] { true, false })
2283          for (Integer v1 : new Integer[] { 1, null })
2284      {
2285          final CompletableFuture<Integer> f = new CompletableFuture<>();
2286          final CompletableFuture<Integer> g = new CompletableFuture<>();
1979        final IncAction r = new IncAction();
1980        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1981        final CFException ex = new CFException();
1982
1983        g.completeExceptionally(ex);
1984        checkCompletedWithWrappedCFException(h, ex);
1985        f.complete(v1);
1986
1987        assertEquals(0, r.invocationCount);
1988        checkCompletedNormally(f, v1);
1989        checkCompletedWithWrappedCFException(g, ex);
1990        checkCompletedWithWrappedCFException(h, ex);
1991    }}
1992
1993    public void testAcceptEither_exceptionalCompletion3() {
1994        for (ExecutionMode m : ExecutionMode.values())
1995        for (Integer v1 : new Integer[] { 1, null })
1996    {
1997        final CompletableFuture<Integer> f = new CompletableFuture<>();
1998        final CompletableFuture<Integer> g = new CompletableFuture<>();
1999        final IncAction r = new IncAction();
2287          final CFException ex = new CFException();
2288 +        final NoopConsumer[] rs = new NoopConsumer[6];
2289 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2290  
2291 <        g.completeExceptionally(ex);
2292 <        f.complete(v1);
2293 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2291 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2292 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2293 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2294 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2295 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2296 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2297  
2298 <        // unspecified behavior
2007 <        Integer v;
2298 >        // unspecified behavior - both source completions available
2299          try {
2300 <            assertNull(h.join());
2301 <            assertEquals(1, r.invocationCount);
2011 <            assertEquals(inc(v1), r.value);
2300 >            assertEquals(null, h0.join());
2301 >            rs[0].assertValue(v1);
2302          } catch (CompletionException ok) {
2303 <            checkCompletedWithWrappedCFException(h, ex);
2304 <            assertEquals(0, r.invocationCount);
2303 >            checkCompletedWithWrappedException(h0, ex);
2304 >            rs[0].assertNotInvoked();
2305          }
2016
2017        checkCompletedWithWrappedCFException(g, ex);
2018        checkCompletedNormally(f, v1);
2019    }}
2020
2021    public void testAcceptEither_exceptionalCompletion4() {
2022        for (ExecutionMode m : ExecutionMode.values())
2023        for (Integer v1 : new Integer[] { 1, null })
2024    {
2025        final CompletableFuture<Integer> f = new CompletableFuture<>();
2026        final CompletableFuture<Integer> g = new CompletableFuture<>();
2027        final IncAction r = new IncAction();
2028        final CFException ex = new CFException();
2029
2030        f.completeExceptionally(ex);
2031        g.complete(v1);
2032        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2033
2034        // unspecified behavior
2035        Integer v;
2306          try {
2307 <            assertNull(h.join());
2308 <            assertEquals(1, r.invocationCount);
2039 <            assertEquals(inc(v1), r.value);
2307 >            assertEquals(null, h1.join());
2308 >            rs[1].assertValue(v1);
2309          } catch (CompletionException ok) {
2310 <            checkCompletedWithWrappedCFException(h, ex);
2311 <            assertEquals(0, r.invocationCount);
2310 >            checkCompletedWithWrappedException(h1, ex);
2311 >            rs[1].assertNotInvoked();
2312 >        }
2313 >        try {
2314 >            assertEquals(null, h2.join());
2315 >            rs[2].assertValue(v1);
2316 >        } catch (CompletionException ok) {
2317 >            checkCompletedWithWrappedException(h2, ex);
2318 >            rs[2].assertNotInvoked();
2319 >        }
2320 >        try {
2321 >            assertEquals(null, h3.join());
2322 >            rs[3].assertValue(v1);
2323 >        } catch (CompletionException ok) {
2324 >            checkCompletedWithWrappedException(h3, ex);
2325 >            rs[3].assertNotInvoked();
2326          }
2327  
2045        checkCompletedWithWrappedCFException(f, ex);
2046        checkCompletedNormally(g, v1);
2047    }}
2048
2049    /**
2050     * acceptEither result completes exceptionally if action does
2051     */
2052    public void testAcceptEither_actionFailed1() {
2053        for (ExecutionMode m : ExecutionMode.values())
2054        for (Integer v1 : new Integer[] { 1, null })
2055        for (Integer v2 : new Integer[] { 2, null })
2056    {
2057        final CompletableFuture<Integer> f = new CompletableFuture<>();
2058        final CompletableFuture<Integer> g = new CompletableFuture<>();
2059        final FailingConsumer r = new FailingConsumer(m);
2060        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2061
2062        f.complete(v1);
2063        checkCompletedWithWrappedCFException(h);
2064        g.complete(v2);
2065        checkCompletedNormally(f, v1);
2066        checkCompletedNormally(g, v2);
2067    }}
2068
2069    public void testAcceptEither_actionFailed2() {
2070        for (ExecutionMode m : ExecutionMode.values())
2071        for (Integer v1 : new Integer[] { 1, null })
2072        for (Integer v2 : new Integer[] { 2, null })
2073    {
2074        final CompletableFuture<Integer> f = new CompletableFuture<>();
2075        final CompletableFuture<Integer> g = new CompletableFuture<>();
2076        final FailingConsumer r = new FailingConsumer(m);
2077        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2078
2079        g.complete(v2);
2080        checkCompletedWithWrappedCFException(h);
2081        f.complete(v1);
2328          checkCompletedNormally(f, v1);
2329 <        checkCompletedNormally(g, v2);
2329 >        checkCompletedExceptionally(g, ex);
2330      }}
2331  
2332      /**
2333       * acceptEither result completes exceptionally if either source cancelled
2334       */
2335 <    public void testAcceptEither_sourceCancelled1() {
2090 <        for (ExecutionMode m : ExecutionMode.values())
2091 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2092 <        for (Integer v1 : new Integer[] { 1, null })
2093 <    {
2094 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2095 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2096 <        final IncAction r = new IncAction();
2097 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2098 <
2099 <        assertTrue(f.cancel(mayInterruptIfRunning));
2100 <        checkCompletedWithWrappedCancellationException(h);
2101 <        g.complete(v1);
2102 <
2103 <        checkCancelled(f);
2104 <        assertEquals(0, r.invocationCount);
2105 <        checkCompletedNormally(g, v1);
2106 <        checkCompletedWithWrappedCancellationException(h);
2107 <    }}
2108 <
2109 <    public void testAcceptEither_sourceCancelled2() {
2335 >    public void testAcceptEither_sourceCancelled() {
2336          for (ExecutionMode m : ExecutionMode.values())
2337          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2338          for (Integer v1 : new Integer[] { 1, null })
2339      {
2340          final CompletableFuture<Integer> f = new CompletableFuture<>();
2341          final CompletableFuture<Integer> g = new CompletableFuture<>();
2342 <        final IncAction r = new IncAction();
2343 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2342 >        final NoopConsumer[] rs = new NoopConsumer[6];
2343 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2344  
2345 <        assertTrue(g.cancel(mayInterruptIfRunning));
2346 <        checkCompletedWithWrappedCancellationException(h);
2347 <        f.complete(v1);
2345 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2346 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2347 >        checkIncomplete(h0);
2348 >        checkIncomplete(h1);
2349 >        rs[0].assertNotInvoked();
2350 >        rs[1].assertNotInvoked();
2351 >        f.cancel(mayInterruptIfRunning);
2352 >        checkCompletedWithWrappedCancellationException(h0);
2353 >        checkCompletedWithWrappedCancellationException(h1);
2354 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2355 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2356 >        checkCompletedWithWrappedCancellationException(h2);
2357 >        checkCompletedWithWrappedCancellationException(h3);
2358  
2359 <        checkCancelled(g);
2124 <        assertEquals(0, r.invocationCount);
2125 <        checkCompletedNormally(f, v1);
2126 <        checkCompletedWithWrappedCancellationException(h);
2127 <    }}
2128 <
2129 <    public void testAcceptEither_sourceCancelled3() {
2130 <        for (ExecutionMode m : ExecutionMode.values())
2131 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2132 <        for (Integer v1 : new Integer[] { 1, null })
2133 <    {
2134 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2135 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2136 <        final IncAction r = new IncAction();
2137 <
2138 <        assertTrue(g.cancel(mayInterruptIfRunning));
2139 <        f.complete(v1);
2140 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2359 >        g.complete(v1);
2360  
2361 <        // unspecified behavior
2362 <        Integer v;
2361 >        // unspecified behavior - both source completions available
2362 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2363 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2364          try {
2365 <            assertNull(h.join());
2366 <            assertEquals(1, r.invocationCount);
2147 <            assertEquals(inc(v1), r.value);
2365 >            assertNull(h4.join());
2366 >            rs[4].assertValue(v1);
2367          } catch (CompletionException ok) {
2368 <            checkCompletedWithWrappedCancellationException(h);
2369 <            assertEquals(0, r.invocationCount);
2368 >            checkCompletedWithWrappedCancellationException(h4);
2369 >            rs[4].assertNotInvoked();
2370          }
2152
2153        checkCancelled(g);
2154        checkCompletedNormally(f, v1);
2155    }}
2156
2157    public void testAcceptEither_sourceCancelled4() {
2158        for (ExecutionMode m : ExecutionMode.values())
2159        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2160        for (Integer v1 : new Integer[] { 1, null })
2161    {
2162        final CompletableFuture<Integer> f = new CompletableFuture<>();
2163        final CompletableFuture<Integer> g = new CompletableFuture<>();
2164        final IncAction r = new IncAction();
2165
2166        assertTrue(f.cancel(mayInterruptIfRunning));
2167        g.complete(v1);
2168        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2169
2170        // unspecified behavior
2171        Integer v;
2371          try {
2372 <            assertNull(h.join());
2373 <            assertEquals(1, r.invocationCount);
2175 <            assertEquals(inc(v1), r.value);
2372 >            assertNull(h5.join());
2373 >            rs[5].assertValue(v1);
2374          } catch (CompletionException ok) {
2375 <            checkCompletedWithWrappedCancellationException(h);
2376 <            assertEquals(0, r.invocationCount);
2375 >            checkCompletedWithWrappedCancellationException(h5);
2376 >            rs[5].assertNotInvoked();
2377          }
2378  
2379          checkCancelled(f);
2380          checkCompletedNormally(g, v1);
2381 +        checkCompletedWithWrappedCancellationException(h0);
2382 +        checkCompletedWithWrappedCancellationException(h1);
2383 +        checkCompletedWithWrappedCancellationException(h2);
2384 +        checkCompletedWithWrappedCancellationException(h3);
2385 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2386      }}
2387  
2388      /**
2389 <     * runAfterEither result completes normally after normal completion
2187 <     * of either source
2389 >     * acceptEither result completes exceptionally if action does
2390       */
2391 <    public void testRunAfterEither_normalCompletion1() {
2391 >    public void testAcceptEither_actionFailed() {
2392          for (ExecutionMode m : ExecutionMode.values())
2393          for (Integer v1 : new Integer[] { 1, null })
2394          for (Integer v2 : new Integer[] { 2, null })
2395      {
2396          final CompletableFuture<Integer> f = new CompletableFuture<>();
2397          final CompletableFuture<Integer> g = new CompletableFuture<>();
2398 <        final Noop r = new Noop(m);
2399 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2398 >        final FailingConsumer[] rs = new FailingConsumer[6];
2399 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
2400  
2401 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2402 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2403          f.complete(v1);
2404 <        checkCompletedNormally(h, null);
2405 <        assertEquals(1, r.invocationCount);
2404 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2405 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2406 >        checkCompletedWithWrappedCFException(h0);
2407 >        checkCompletedWithWrappedCFException(h1);
2408 >        checkCompletedWithWrappedCFException(h2);
2409 >        checkCompletedWithWrappedCFException(h3);
2410 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2411 >
2412          g.complete(v2);
2413  
2414 +        // unspecified behavior - both source completions available
2415 +        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2416 +        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2417 +
2418 +        checkCompletedWithWrappedCFException(h4);
2419 +        assertTrue(Objects.equals(v1, rs[4].value) ||
2420 +                   Objects.equals(v2, rs[4].value));
2421 +        checkCompletedWithWrappedCFException(h5);
2422 +        assertTrue(Objects.equals(v1, rs[5].value) ||
2423 +                   Objects.equals(v2, rs[5].value));
2424 +
2425          checkCompletedNormally(f, v1);
2426          checkCompletedNormally(g, v2);
2206        checkCompletedNormally(h, null);
2207        assertEquals(1, r.invocationCount);
2427      }}
2428  
2429 <    public void testRunAfterEither_normalCompletion2() {
2429 >    /**
2430 >     * runAfterEither result completes normally after normal completion
2431 >     * of either source
2432 >     */
2433 >    public void testRunAfterEither_normalCompletion() {
2434          for (ExecutionMode m : ExecutionMode.values())
2435          for (Integer v1 : new Integer[] { 1, null })
2436          for (Integer v2 : new Integer[] { 2, null })
2437      {
2438          final CompletableFuture<Integer> f = new CompletableFuture<>();
2439          final CompletableFuture<Integer> g = new CompletableFuture<>();
2440 <        final Noop r = new Noop(m);
2441 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2440 >        final Noop[] rs = new Noop[6];
2441 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2442  
2443 <        g.complete(v2);
2444 <        checkCompletedNormally(h, null);
2445 <        assertEquals(1, r.invocationCount);
2443 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2444 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2445 >        checkIncomplete(h0);
2446 >        checkIncomplete(h1);
2447 >        rs[0].assertNotInvoked();
2448 >        rs[1].assertNotInvoked();
2449          f.complete(v1);
2450 +        checkCompletedNormally(h0, null);
2451 +        checkCompletedNormally(h1, null);
2452 +        rs[0].assertInvoked();
2453 +        rs[1].assertInvoked();
2454 +        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2455 +        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2456 +        checkCompletedNormally(h2, null);
2457 +        checkCompletedNormally(h3, null);
2458 +        rs[2].assertInvoked();
2459 +        rs[3].assertInvoked();
2460  
2225        checkCompletedNormally(f, v1);
2226        checkCompletedNormally(g, v2);
2227        checkCompletedNormally(h, null);
2228        assertEquals(1, r.invocationCount);
2229        }}
2230
2231    public void testRunAfterEither_normalCompletion3() {
2232        for (ExecutionMode m : ExecutionMode.values())
2233        for (Integer v1 : new Integer[] { 1, null })
2234        for (Integer v2 : new Integer[] { 2, null })
2235    {
2236        final CompletableFuture<Integer> f = new CompletableFuture<>();
2237        final CompletableFuture<Integer> g = new CompletableFuture<>();
2238        final Noop r = new Noop(m);
2239
2240        f.complete(v1);
2461          g.complete(v2);
2242        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2462  
2463 <        checkCompletedNormally(h, null);
2463 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2464 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2465 >
2466          checkCompletedNormally(f, v1);
2467          checkCompletedNormally(g, v2);
2468 <        assertEquals(1, r.invocationCount);
2468 >        checkCompletedNormally(h0, null);
2469 >        checkCompletedNormally(h1, null);
2470 >        checkCompletedNormally(h2, null);
2471 >        checkCompletedNormally(h3, null);
2472 >        checkCompletedNormally(h4, null);
2473 >        checkCompletedNormally(h5, null);
2474 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2475      }}
2476  
2477      /**
2478       * runAfterEither result completes exceptionally after exceptional
2479       * completion of either source
2480       */
2481 <    public void testRunAfterEither_exceptionalCompletion1() {
2255 <        for (ExecutionMode m : ExecutionMode.values())
2256 <        for (Integer v1 : new Integer[] { 1, null })
2257 <    {
2258 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2259 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2260 <        final Noop r = new Noop(m);
2261 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2262 <        final CFException ex = new CFException();
2263 <
2264 <        f.completeExceptionally(ex);
2265 <        checkCompletedWithWrappedCFException(h, ex);
2266 <        g.complete(v1);
2267 <
2268 <        assertEquals(0, r.invocationCount);
2269 <        checkCompletedNormally(g, v1);
2270 <        checkCompletedWithWrappedCFException(f, ex);
2271 <        checkCompletedWithWrappedCFException(h, ex);
2272 <    }}
2273 <
2274 <    public void testRunAfterEither_exceptionalCompletion2() {
2481 >    public void testRunAfterEither_exceptionalCompletion() {
2482          for (ExecutionMode m : ExecutionMode.values())
2483          for (Integer v1 : new Integer[] { 1, null })
2484      {
2485          final CompletableFuture<Integer> f = new CompletableFuture<>();
2486          final CompletableFuture<Integer> g = new CompletableFuture<>();
2280        final Noop r = new Noop(m);
2281        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2487          final CFException ex = new CFException();
2488 +        final Noop[] rs = new Noop[6];
2489 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2490  
2491 <        g.completeExceptionally(ex);
2492 <        checkCompletedWithWrappedCFException(h, ex);
2493 <        f.complete(v1);
2491 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2492 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2493 >        checkIncomplete(h0);
2494 >        checkIncomplete(h1);
2495 >        rs[0].assertNotInvoked();
2496 >        rs[1].assertNotInvoked();
2497 >        assertTrue(f.completeExceptionally(ex));
2498 >        checkCompletedWithWrappedException(h0, ex);
2499 >        checkCompletedWithWrappedException(h1, ex);
2500 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2501 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2502 >        checkCompletedWithWrappedException(h2, ex);
2503 >        checkCompletedWithWrappedException(h3, ex);
2504  
2505 <        assertEquals(0, r.invocationCount);
2289 <        checkCompletedNormally(f, v1);
2290 <        checkCompletedWithWrappedCFException(g, ex);
2291 <        checkCompletedWithWrappedCFException(h, ex);
2292 <    }}
2505 >        assertTrue(g.complete(v1));
2506  
2507 <    public void testRunAfterEither_exceptionalCompletion3() {
2508 <        for (ExecutionMode m : ExecutionMode.values())
2509 <        for (Integer v1 : new Integer[] { 1, null })
2297 <    {
2298 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2299 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2300 <        final Noop r = new Noop(m);
2301 <        final CFException ex = new CFException();
2302 <
2303 <        g.completeExceptionally(ex);
2304 <        f.complete(v1);
2305 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2306 <
2307 <        // unspecified behavior
2308 <        Integer v;
2507 >        // unspecified behavior - both source completions available
2508 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2509 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2510          try {
2511 <            assertNull(h.join());
2512 <            assertEquals(1, r.invocationCount);
2511 >            assertNull(h4.join());
2512 >            rs[4].assertInvoked();
2513          } catch (CompletionException ok) {
2514 <            checkCompletedWithWrappedCFException(h, ex);
2515 <            assertEquals(0, r.invocationCount);
2514 >            checkCompletedWithWrappedException(h4, ex);
2515 >            rs[4].assertNotInvoked();
2516          }
2316
2317        checkCompletedWithWrappedCFException(g, ex);
2318        checkCompletedNormally(f, v1);
2319    }}
2320
2321    public void testRunAfterEither_exceptionalCompletion4() {
2322        for (ExecutionMode m : ExecutionMode.values())
2323        for (Integer v1 : new Integer[] { 1, null })
2324    {
2325        final CompletableFuture<Integer> f = new CompletableFuture<>();
2326        final CompletableFuture<Integer> g = new CompletableFuture<>();
2327        final Noop r = new Noop(m);
2328        final CFException ex = new CFException();
2329
2330        f.completeExceptionally(ex);
2331        g.complete(v1);
2332        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2333
2334        // unspecified behavior
2335        Integer v;
2517          try {
2518 <            assertNull(h.join());
2519 <            assertEquals(1, r.invocationCount);
2518 >            assertNull(h5.join());
2519 >            rs[5].assertInvoked();
2520          } catch (CompletionException ok) {
2521 <            checkCompletedWithWrappedCFException(h, ex);
2522 <            assertEquals(0, r.invocationCount);
2521 >            checkCompletedWithWrappedException(h5, ex);
2522 >            rs[5].assertNotInvoked();
2523          }
2524  
2525 <        checkCompletedWithWrappedCFException(f, ex);
2525 >        checkCompletedExceptionally(f, ex);
2526          checkCompletedNormally(g, v1);
2527 +        checkCompletedWithWrappedException(h0, ex);
2528 +        checkCompletedWithWrappedException(h1, ex);
2529 +        checkCompletedWithWrappedException(h2, ex);
2530 +        checkCompletedWithWrappedException(h3, ex);
2531 +        checkCompletedWithWrappedException(h4, ex);
2532 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2533      }}
2534  
2535 <    /**
2349 <     * runAfterEither result completes exceptionally if action does
2350 <     */
2351 <    public void testRunAfterEither_actionFailed1() {
2535 >    public void testRunAfterEither_exceptionalCompletion2() {
2536          for (ExecutionMode m : ExecutionMode.values())
2537 +        for (boolean fFirst : new boolean[] { true, false })
2538          for (Integer v1 : new Integer[] { 1, null })
2354        for (Integer v2 : new Integer[] { 2, null })
2539      {
2540          final CompletableFuture<Integer> f = new CompletableFuture<>();
2541          final CompletableFuture<Integer> g = new CompletableFuture<>();
2542 <        final FailingRunnable r = new FailingRunnable(m);
2543 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2542 >        final CFException ex = new CFException();
2543 >        final Noop[] rs = new Noop[6];
2544 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2545  
2546 <        f.complete(v1);
2547 <        checkCompletedWithWrappedCFException(h);
2548 <        g.complete(v2);
2549 <        checkCompletedNormally(f, v1);
2550 <        checkCompletedNormally(g, v2);
2551 <    }}
2546 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2547 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2548 >        assertTrue( fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2549 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2550 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2551 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2552  
2553 <    public void testRunAfterEither_actionFailed2() {
2554 <        for (ExecutionMode m : ExecutionMode.values())
2555 <        for (Integer v1 : new Integer[] { 1, null })
2556 <        for (Integer v2 : new Integer[] { 2, null })
2557 <    {
2558 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2559 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2560 <        final FailingRunnable r = new FailingRunnable(m);
2561 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2553 >        // unspecified behavior - both source completions available
2554 >        try {
2555 >            assertEquals(null, h0.join());
2556 >            rs[0].assertInvoked();
2557 >        } catch (CompletionException ok) {
2558 >            checkCompletedWithWrappedException(h0, ex);
2559 >            rs[0].assertNotInvoked();
2560 >        }
2561 >        try {
2562 >            assertEquals(null, h1.join());
2563 >            rs[1].assertInvoked();
2564 >        } catch (CompletionException ok) {
2565 >            checkCompletedWithWrappedException(h1, ex);
2566 >            rs[1].assertNotInvoked();
2567 >        }
2568 >        try {
2569 >            assertEquals(null, h2.join());
2570 >            rs[2].assertInvoked();
2571 >        } catch (CompletionException ok) {
2572 >            checkCompletedWithWrappedException(h2, ex);
2573 >            rs[2].assertNotInvoked();
2574 >        }
2575 >        try {
2576 >            assertEquals(null, h3.join());
2577 >            rs[3].assertInvoked();
2578 >        } catch (CompletionException ok) {
2579 >            checkCompletedWithWrappedException(h3, ex);
2580 >            rs[3].assertNotInvoked();
2581 >        }
2582  
2378        g.complete(v2);
2379        checkCompletedWithWrappedCFException(h);
2380        f.complete(v1);
2583          checkCompletedNormally(f, v1);
2584 <        checkCompletedNormally(g, v2);
2584 >        checkCompletedExceptionally(g, ex);
2585      }}
2586  
2587      /**
2588       * runAfterEither result completes exceptionally if either source cancelled
2589       */
2590 <    public void testRunAfterEither_sourceCancelled1() {
2590 >    public void testRunAfterEither_sourceCancelled() {
2591          for (ExecutionMode m : ExecutionMode.values())
2592          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2593          for (Integer v1 : new Integer[] { 1, null })
2594      {
2595          final CompletableFuture<Integer> f = new CompletableFuture<>();
2596          final CompletableFuture<Integer> g = new CompletableFuture<>();
2597 <        final Noop r = new Noop(m);
2598 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2397 <
2398 <        assertTrue(f.cancel(mayInterruptIfRunning));
2399 <        checkCompletedWithWrappedCancellationException(h);
2400 <        g.complete(v1);
2597 >        final Noop[] rs = new Noop[6];
2598 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2599  
2600 <        checkCancelled(f);
2601 <        assertEquals(0, r.invocationCount);
2602 <        checkCompletedNormally(g, v1);
2603 <        checkCompletedWithWrappedCancellationException(h);
2604 <    }}
2605 <
2606 <    public void testRunAfterEither_sourceCancelled2() {
2607 <        for (ExecutionMode m : ExecutionMode.values())
2608 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2609 <        for (Integer v1 : new Integer[] { 1, null })
2610 <    {
2611 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2612 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2613 <        final Noop r = new Noop(m);
2614 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2615 <
2616 <        assertTrue(g.cancel(mayInterruptIfRunning));
2617 <        checkCompletedWithWrappedCancellationException(h);
2618 <        f.complete(v1);
2619 <
2620 <        checkCancelled(g);
2621 <        assertEquals(0, r.invocationCount);
2622 <        checkCompletedNormally(f, v1);
2623 <        checkCompletedWithWrappedCancellationException(h);
2624 <    }}
2625 <
2428 <    public void testRunAfterEither_sourceCancelled3() {
2429 <        for (ExecutionMode m : ExecutionMode.values())
2430 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2431 <        for (Integer v1 : new Integer[] { 1, null })
2432 <    {
2433 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2434 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2435 <        final Noop r = new Noop(m);
2436 <
2437 <        assertTrue(g.cancel(mayInterruptIfRunning));
2438 <        f.complete(v1);
2439 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2440 <
2441 <        // unspecified behavior
2442 <        Integer v;
2600 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2601 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2602 >        checkIncomplete(h0);
2603 >        checkIncomplete(h1);
2604 >        rs[0].assertNotInvoked();
2605 >        rs[1].assertNotInvoked();
2606 >        f.cancel(mayInterruptIfRunning);
2607 >        checkCompletedWithWrappedCancellationException(h0);
2608 >        checkCompletedWithWrappedCancellationException(h1);
2609 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2610 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2611 >        checkCompletedWithWrappedCancellationException(h2);
2612 >        checkCompletedWithWrappedCancellationException(h3);
2613 >
2614 >        assertTrue(g.complete(v1));
2615 >
2616 >        // unspecified behavior - both source completions available
2617 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2618 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2619 >        try {
2620 >            assertNull(h4.join());
2621 >            rs[4].assertInvoked();
2622 >        } catch (CompletionException ok) {
2623 >            checkCompletedWithWrappedCancellationException(h4);
2624 >            rs[4].assertNotInvoked();
2625 >        }
2626          try {
2627 <            assertNull(h.join());
2628 <            assertEquals(1, r.invocationCount);
2627 >            assertNull(h5.join());
2628 >            rs[5].assertInvoked();
2629          } catch (CompletionException ok) {
2630 <            checkCompletedWithWrappedCancellationException(h);
2631 <            assertEquals(0, r.invocationCount);
2630 >            checkCompletedWithWrappedCancellationException(h5);
2631 >            rs[5].assertNotInvoked();
2632          }
2633  
2634 <        checkCancelled(g);
2635 <        checkCompletedNormally(f, v1);
2634 >        checkCancelled(f);
2635 >        checkCompletedNormally(g, v1);
2636 >        checkCompletedWithWrappedCancellationException(h0);
2637 >        checkCompletedWithWrappedCancellationException(h1);
2638 >        checkCompletedWithWrappedCancellationException(h2);
2639 >        checkCompletedWithWrappedCancellationException(h3);
2640 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2641      }}
2642  
2643 <    public void testRunAfterEither_sourceCancelled4() {
2643 >    /**
2644 >     * runAfterEither result completes exceptionally if action does
2645 >     */
2646 >    public void testRunAfterEither_actionFailed() {
2647          for (ExecutionMode m : ExecutionMode.values())
2457        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2648          for (Integer v1 : new Integer[] { 1, null })
2649 +        for (Integer v2 : new Integer[] { 2, null })
2650      {
2651          final CompletableFuture<Integer> f = new CompletableFuture<>();
2652          final CompletableFuture<Integer> g = new CompletableFuture<>();
2653 <        final Noop r = new Noop(m);
2653 >        final FailingRunnable[] rs = new FailingRunnable[6];
2654 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2655  
2656 <        assertTrue(f.cancel(mayInterruptIfRunning));
2657 <        g.complete(v1);
2658 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2659 <
2660 <        // unspecified behavior
2661 <        Integer v;
2662 <        try {
2663 <            assertNull(h.join());
2664 <            assertEquals(1, r.invocationCount);
2665 <        } catch (CompletionException ok) {
2666 <            checkCompletedWithWrappedCancellationException(h);
2667 <            assertEquals(0, r.invocationCount);
2668 <        }
2656 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2657 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2658 >        assertTrue(f.complete(v1));
2659 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2660 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2661 >        checkCompletedWithWrappedCFException(h0);
2662 >        checkCompletedWithWrappedCFException(h1);
2663 >        checkCompletedWithWrappedCFException(h2);
2664 >        checkCompletedWithWrappedCFException(h3);
2665 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2666 >        assertTrue(g.complete(v2));
2667 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2668 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2669 >        checkCompletedWithWrappedCFException(h4);
2670 >        checkCompletedWithWrappedCFException(h5);
2671  
2672 <        checkCancelled(f);
2673 <        checkCompletedNormally(g, v1);
2672 >        checkCompletedNormally(f, v1);
2673 >        checkCompletedNormally(g, v2);
2674 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2675      }}
2676  
2677      /**
# Line 2489 | Line 2684 | public class CompletableFutureTest exten
2684      {
2685          final CompletableFuture<Integer> f = new CompletableFuture<>();
2686          final CompletableFutureInc r = new CompletableFutureInc(m);
2687 <        if (!createIncomplete) f.complete(v1);
2687 >        if (!createIncomplete) assertTrue(f.complete(v1));
2688          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2689 <        if (createIncomplete) f.complete(v1);
2689 >        if (createIncomplete) assertTrue(f.complete(v1));
2690  
2691          checkCompletedNormally(g, inc(v1));
2692          checkCompletedNormally(f, v1);
2693 <        assertEquals(1, r.invocationCount);
2693 >        r.assertValue(v1);
2694      }}
2695  
2696      /**
# Line 2513 | Line 2708 | public class CompletableFutureTest exten
2708          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2709          if (createIncomplete) f.completeExceptionally(ex);
2710  
2711 <        checkCompletedWithWrappedCFException(g, ex);
2712 <        checkCompletedWithWrappedCFException(f, ex);
2713 <        assertEquals(0, r.invocationCount);
2711 >        checkCompletedWithWrappedException(g, ex);
2712 >        checkCompletedExceptionally(f, ex);
2713 >        r.assertNotInvoked();
2714      }}
2715  
2716      /**
# Line 2529 | Line 2724 | public class CompletableFutureTest exten
2724          final CompletableFuture<Integer> f = new CompletableFuture<>();
2725          final FailingCompletableFutureFunction r
2726              = new FailingCompletableFutureFunction(m);
2727 <        if (!createIncomplete) f.complete(v1);
2727 >        if (!createIncomplete) assertTrue(f.complete(v1));
2728          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2729 <        if (createIncomplete) f.complete(v1);
2729 >        if (createIncomplete) assertTrue(f.complete(v1));
2730  
2731          checkCompletedWithWrappedCFException(g);
2732          checkCompletedNormally(f, v1);
# Line 2575 | Line 2770 | public class CompletableFutureTest exten
2770       */
2771      public void testAllOf_normal() throws Exception {
2772          for (int k = 1; k < 20; ++k) {
2773 <            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2773 >            CompletableFuture<Integer>[] fs
2774 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2775              for (int i = 0; i < k; ++i)
2776                  fs[i] = new CompletableFuture<>();
2777              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
# Line 2589 | Line 2785 | public class CompletableFutureTest exten
2785          }
2786      }
2787  
2788 +    public void testAllOf_backwards() throws Exception {
2789 +        for (int k = 1; k < 20; ++k) {
2790 +            CompletableFuture<Integer>[] fs
2791 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2792 +            for (int i = 0; i < k; ++i)
2793 +                fs[i] = new CompletableFuture<>();
2794 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
2795 +            for (int i = k - 1; i >= 0; i--) {
2796 +                checkIncomplete(f);
2797 +                checkIncomplete(CompletableFuture.allOf(fs));
2798 +                fs[i].complete(one);
2799 +            }
2800 +            checkCompletedNormally(f, null);
2801 +            checkCompletedNormally(CompletableFuture.allOf(fs), null);
2802 +        }
2803 +    }
2804 +
2805      /**
2806       * anyOf(no component futures) returns an incomplete future
2807       */
# Line 2647 | Line 2860 | public class CompletableFutureTest exten
2860          Runnable[] throwingActions = {
2861              () -> CompletableFuture.supplyAsync(null),
2862              () -> CompletableFuture.supplyAsync(null, exec),
2863 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
2863 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
2864  
2865              () -> CompletableFuture.runAsync(null),
2866              () -> CompletableFuture.runAsync(null, exec),
# Line 2752 | Line 2965 | public class CompletableFutureTest exten
2965          assertSame(f, f.toCompletableFuture());
2966      }
2967  
2968 <    /**
2969 <     * whenComplete action executes on normal completion, propagating
2970 <     * source result.
2971 <     */
2972 <    public void testWhenComplete_normalCompletion1() {
2973 <        for (ExecutionMode m : ExecutionMode.values())
2974 <        for (boolean createIncomplete : new boolean[] { true, false })
2975 <        for (Integer v1 : new Integer[] { 1, null })
2976 <    {
2977 <        final AtomicInteger a = new AtomicInteger(0);
2978 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2979 <        if (!createIncomplete) f.complete(v1);
2980 <        final CompletableFuture<Integer> g = m.whenComplete
2981 <            (f,
2982 <             (Integer x, Throwable t) -> {
2983 <                threadAssertSame(x, v1);
2984 <                threadAssertNull(t);
2772 <                a.getAndIncrement();
2773 <            });
2774 <        if (createIncomplete) f.complete(v1);
2775 <
2776 <        checkCompletedNormally(g, v1);
2777 <        checkCompletedNormally(f, v1);
2778 <        assertEquals(1, a.get());
2779 <    }}
2780 <
2781 <    /**
2782 <     * whenComplete action executes on exceptional completion, propagating
2783 <     * source result.
2784 <     */
2785 <    public void testWhenComplete_exceptionalCompletion() {
2786 <        for (ExecutionMode m : ExecutionMode.values())
2787 <        for (boolean createIncomplete : new boolean[] { true, false })
2788 <        for (Integer v1 : new Integer[] { 1, null })
2789 <    {
2790 <        final AtomicInteger a = new AtomicInteger(0);
2791 <        final CFException ex = new CFException();
2792 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2793 <        if (!createIncomplete) f.completeExceptionally(ex);
2794 <        final CompletableFuture<Integer> g = m.whenComplete
2795 <            (f,
2796 <             (Integer x, Throwable t) -> {
2797 <                threadAssertNull(x);
2798 <                threadAssertSame(t, ex);
2799 <                a.getAndIncrement();
2800 <            });
2801 <        if (createIncomplete) f.completeExceptionally(ex);
2802 <        checkCompletedWithWrappedCFException(f, ex);
2803 <        checkCompletedWithWrappedCFException(g, ex);
2804 <        assertEquals(1, a.get());
2805 <    }}
2806 <
2807 <    /**
2808 <     * whenComplete action executes on cancelled source, propagating
2809 <     * CancellationException.
2810 <     */
2811 <    public void testWhenComplete_sourceCancelled() {
2812 <        for (ExecutionMode m : ExecutionMode.values())
2813 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2814 <        for (boolean createIncomplete : new boolean[] { true, false })
2815 <    {
2816 <        final AtomicInteger a = new AtomicInteger(0);
2817 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2818 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2819 <        final CompletableFuture<Integer> g = m.whenComplete
2820 <            (f,
2821 <             (Integer x, Throwable t) -> {
2822 <                threadAssertNull(x);
2823 <                threadAssertTrue(t instanceof CancellationException);
2824 <                a.getAndIncrement();
2825 <            });
2826 <        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2827 <
2828 <        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2829 <        checkCompletedWithWrappedCancellationException(g);
2830 <        checkCancelled(f);
2831 <        assertEquals(1, a.get());
2832 <    }}
2833 <
2834 <    /**
2835 <     * If a whenComplete action throws an exception when triggered by
2836 <     * a normal completion, it completes exceptionally
2837 <     */
2838 <    public void testWhenComplete_actionFailed() {
2839 <        for (boolean createIncomplete : new boolean[] { true, false })
2840 <        for (ExecutionMode m : ExecutionMode.values())
2841 <        for (Integer v1 : new Integer[] { 1, null })
2842 <    {
2843 <        final AtomicInteger a = new AtomicInteger(0);
2844 <        final CFException ex = new CFException();
2845 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2846 <        if (!createIncomplete) f.complete(v1);
2847 <        final CompletableFuture<Integer> g = m.whenComplete
2848 <            (f,
2849 <             (Integer x, Throwable t) -> {
2850 <                threadAssertSame(x, v1);
2851 <                threadAssertNull(t);
2852 <                a.getAndIncrement();
2853 <                throw ex;
2854 <            });
2855 <        if (createIncomplete) f.complete(v1);
2856 <        checkCompletedNormally(f, v1);
2857 <        checkCompletedWithWrappedCFException(g, ex);
2858 <        assertEquals(1, a.get());
2859 <    }}
2860 <
2861 <    /**
2862 <     * If a whenComplete action throws an exception when triggered by
2863 <     * a source completion that also throws an exception, the source
2864 <     * exception takes precedence.
2865 <     */
2866 <    public void testWhenComplete_actionFailedSourceFailed() {
2867 <        for (boolean createIncomplete : new boolean[] { true, false })
2868 <        for (ExecutionMode m : ExecutionMode.values())
2869 <        for (Integer v1 : new Integer[] { 1, null })
2870 <    {
2871 <        final AtomicInteger a = new AtomicInteger(0);
2872 <        final CFException ex1 = new CFException();
2873 <        final CFException ex2 = new CFException();
2874 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2875 <
2876 <        if (!createIncomplete) f.completeExceptionally(ex1);
2877 <        final CompletableFuture<Integer> g = m.whenComplete
2878 <            (f,
2879 <             (Integer x, Throwable t) -> {
2880 <                threadAssertSame(t, ex1);
2881 <                threadAssertNull(x);
2882 <                a.getAndIncrement();
2883 <                throw ex2;
2884 <            });
2885 <        if (createIncomplete) f.completeExceptionally(ex1);
2886 <
2887 <        checkCompletedWithWrappedCFException(f, ex1);
2888 <        checkCompletedWithWrappedCFException(g, ex1);
2889 <        assertEquals(1, a.get());
2890 <    }}
2968 > //     public void testRunAfterEither_resultDeterminedAtTimeOfCreation() {
2969 > //         for (ExecutionMode m : ExecutionMode.values())
2970 > //         for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2971 > //         for (Integer v1 : new Integer[] { 1, null })
2972 > //     {
2973 > //         final CompletableFuture<Integer> f = new CompletableFuture<>();
2974 > //         final CompletableFuture<Integer> g = new CompletableFuture<>();
2975 > //         final Noop[] rs = new Noop[2];
2976 > //         for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2977 > //         f.complete(v1);
2978 > //         final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2979 > //         final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2980 > //         assertTrue(g.cancel(mayInterruptIfRunning));
2981 > //         checkCompletedNormally(h0, null);
2982 > //         checkCompletedNormally(h1, null);
2983 > //         for (Noop r : rs) r.assertInvoked();
2984 > //     }}
2985  
2986   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines