ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ConcurrentLinkedDequeTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ConcurrentLinkedDequeTest.java (file contents):
Revision 1.17 by jsr166, Sat Jan 17 22:55:06 2015 UTC vs.
Revision 1.35 by jsr166, Wed Aug 14 23:06:11 2019 UTC

# Line 13 | Line 13 | import java.util.Iterator;
13   import java.util.NoSuchElementException;
14   import java.util.Queue;
15   import java.util.Random;
16 + import java.util.concurrent.CompletableFuture;
17   import java.util.concurrent.ConcurrentLinkedDeque;
18 + import java.util.concurrent.ThreadLocalRandom;
19 + import java.util.concurrent.atomic.LongAdder;
20  
21   import junit.framework.Test;
19 import junit.framework.TestSuite;
22  
23   public class ConcurrentLinkedDequeTest extends JSR166TestCase {
24  
25      public static void main(String[] args) {
26 <        junit.textui.TestRunner.run(suite());
26 >        main(suite(), args);
27      }
28  
29      public static Test suite() {
30 <        return new TestSuite(ConcurrentLinkedDequeTest.class);
30 >        class Implementation implements CollectionImplementation {
31 >            public Class<?> klazz() { return ConcurrentLinkedDeque.class; }
32 >            public Collection emptyCollection() { return new ConcurrentLinkedDeque(); }
33 >            public Object makeElement(int i) { return i; }
34 >            public boolean isConcurrent() { return true; }
35 >            public boolean permitsNulls() { return false; }
36 >        }
37 >        return newTestSuite(ConcurrentLinkedDequeTest.class,
38 >                            CollectionTest.testSuite(new Implementation()));
39      }
40  
41      /**
42       * Returns a new deque of given size containing consecutive
43 <     * Integers 0 ... n.
43 >     * Integers 0 ... n - 1.
44       */
45 <    private ConcurrentLinkedDeque<Integer> populatedDeque(int n) {
46 <        ConcurrentLinkedDeque<Integer> q = new ConcurrentLinkedDeque<Integer>();
45 >    private static ConcurrentLinkedDeque<Integer> populatedDeque(int n) {
46 >        ConcurrentLinkedDeque<Integer> q = new ConcurrentLinkedDeque<>();
47          assertTrue(q.isEmpty());
48          for (int i = 0; i < n; ++i)
49              assertTrue(q.offer(new Integer(i)));
50          assertFalse(q.isEmpty());
51          assertEquals(n, q.size());
52 +        assertEquals((Integer) 0, q.peekFirst());
53 +        assertEquals((Integer) (n - 1), q.peekLast());
54          return q;
55      }
56  
# Line 55 | Line 67 | public class ConcurrentLinkedDequeTest e
67       */
68      public void testConstructor3() {
69          try {
70 <            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque((Collection)null);
70 >            new ConcurrentLinkedDeque((Collection)null);
71              shouldThrow();
72          } catch (NullPointerException success) {}
73      }
# Line 65 | Line 77 | public class ConcurrentLinkedDequeTest e
77       */
78      public void testConstructor4() {
79          try {
80 <            Integer[] ints = new Integer[SIZE];
69 <            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque(Arrays.asList(ints));
80 >            new ConcurrentLinkedDeque(Arrays.asList(new Integer[SIZE]));
81              shouldThrow();
82          } catch (NullPointerException success) {}
83      }
# Line 75 | Line 86 | public class ConcurrentLinkedDequeTest e
86       * Initializing from Collection with some null elements throws NPE
87       */
88      public void testConstructor5() {
89 +        Integer[] ints = new Integer[SIZE];
90 +        for (int i = 0; i < SIZE - 1; ++i)
91 +            ints[i] = new Integer(i);
92          try {
93 <            Integer[] ints = new Integer[SIZE];
80 <            for (int i = 0; i < SIZE-1; ++i)
81 <                ints[i] = new Integer(i);
82 <            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque(Arrays.asList(ints));
93 >            new ConcurrentLinkedDeque(Arrays.asList(ints));
94              shouldThrow();
95          } catch (NullPointerException success) {}
96      }
# Line 116 | Line 127 | public class ConcurrentLinkedDequeTest e
127      public void testSize() {
128          ConcurrentLinkedDeque q = populatedDeque(SIZE);
129          for (int i = 0; i < SIZE; ++i) {
130 <            assertEquals(SIZE-i, q.size());
130 >            assertEquals(SIZE - i, q.size());
131              q.remove();
132          }
133          for (int i = 0; i < SIZE; ++i) {
# Line 129 | Line 140 | public class ConcurrentLinkedDequeTest e
140       * push(null) throws NPE
141       */
142      public void testPushNull() {
143 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
144          try {
133            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
145              q.push(null);
146              shouldThrow();
147          } catch (NullPointerException success) {}
# Line 164 | Line 175 | public class ConcurrentLinkedDequeTest e
175       * offer(null) throws NPE
176       */
177      public void testOfferNull() {
178 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
179          try {
168            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
180              q.offer(null);
181              shouldThrow();
182          } catch (NullPointerException success) {}
# Line 175 | Line 186 | public class ConcurrentLinkedDequeTest e
186       * offerFirst(null) throws NPE
187       */
188      public void testOfferFirstNull() {
189 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
190          try {
179            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
191              q.offerFirst(null);
192              shouldThrow();
193          } catch (NullPointerException success) {}
# Line 186 | Line 197 | public class ConcurrentLinkedDequeTest e
197       * offerLast(null) throws NPE
198       */
199      public void testOfferLastNull() {
200 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
201          try {
190            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
202              q.offerLast(null);
203              shouldThrow();
204          } catch (NullPointerException success) {}
# Line 230 | Line 241 | public class ConcurrentLinkedDequeTest e
241       * add(null) throws NPE
242       */
243      public void testAddNull() {
244 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
245          try {
234            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
246              q.add(null);
247              shouldThrow();
248          } catch (NullPointerException success) {}
# Line 241 | Line 252 | public class ConcurrentLinkedDequeTest e
252       * addFirst(null) throws NPE
253       */
254      public void testAddFirstNull() {
255 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
256          try {
245            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
257              q.addFirst(null);
258              shouldThrow();
259          } catch (NullPointerException success) {}
# Line 252 | Line 263 | public class ConcurrentLinkedDequeTest e
263       * addLast(null) throws NPE
264       */
265      public void testAddLastNull() {
266 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
267          try {
256            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
268              q.addLast(null);
269              shouldThrow();
270          } catch (NullPointerException success) {}
# Line 296 | Line 307 | public class ConcurrentLinkedDequeTest e
307       * addAll(null) throws NPE
308       */
309      public void testAddAll1() {
310 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
311          try {
300            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
312              q.addAll(null);
313              shouldThrow();
314          } catch (NullPointerException success) {}
315      }
316  
317      /**
318 <     * addAll(this) throws IAE
318 >     * addAll(this) throws IllegalArgumentException
319       */
320      public void testAddAllSelf() {
321 +        ConcurrentLinkedDeque q = populatedDeque(SIZE);
322          try {
311            ConcurrentLinkedDeque q = populatedDeque(SIZE);
323              q.addAll(q);
324              shouldThrow();
325          } catch (IllegalArgumentException success) {}
# Line 318 | Line 329 | public class ConcurrentLinkedDequeTest e
329       * addAll of a collection with null elements throws NPE
330       */
331      public void testAddAll2() {
332 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
333          try {
334 <            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
323 <            Integer[] ints = new Integer[SIZE];
324 <            q.addAll(Arrays.asList(ints));
334 >            q.addAll(Arrays.asList(new Integer[SIZE]));
335              shouldThrow();
336          } catch (NullPointerException success) {}
337      }
# Line 331 | Line 341 | public class ConcurrentLinkedDequeTest e
341       * possibly adding some elements
342       */
343      public void testAddAll3() {
344 +        ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
345 +        Integer[] ints = new Integer[SIZE];
346 +        for (int i = 0; i < SIZE - 1; ++i)
347 +            ints[i] = new Integer(i);
348          try {
335            ConcurrentLinkedDeque q = new ConcurrentLinkedDeque();
336            Integer[] ints = new Integer[SIZE];
337            for (int i = 0; i < SIZE-1; ++i)
338                ints[i] = new Integer(i);
349              q.addAll(Arrays.asList(ints));
350              shouldThrow();
351          } catch (NullPointerException success) {}
# Line 372 | Line 382 | public class ConcurrentLinkedDequeTest e
382       */
383      public void testPollLast() {
384          ConcurrentLinkedDeque q = populatedDeque(SIZE);
385 <        for (int i = SIZE-1; i >= 0; --i) {
385 >        for (int i = SIZE - 1; i >= 0; --i) {
386              assertEquals(i, q.pollLast());
387          }
388          assertNull(q.pollLast());
# Line 441 | Line 451 | public class ConcurrentLinkedDequeTest e
451              assertTrue(q.contains(i));
452              assertTrue(q.remove(i));
453              assertFalse(q.contains(i));
454 <            assertTrue(q.contains(i-1));
454 >            assertTrue(q.contains(i - 1));
455          }
456          for (int i = 0; i < SIZE; i += 2) {
457              assertTrue(q.contains(i));
458              assertTrue(q.remove(i));
459              assertFalse(q.contains(i));
460 <            assertFalse(q.remove(i+1));
461 <            assertFalse(q.contains(i+1));
460 >            assertFalse(q.remove(i + 1));
461 >            assertFalse(q.contains(i + 1));
462          }
463          assertTrue(q.isEmpty());
464      }
# Line 472 | Line 482 | public class ConcurrentLinkedDequeTest e
482       */
483      public void testPeekLast() {
484          ConcurrentLinkedDeque q = populatedDeque(SIZE);
485 <        for (int i = SIZE-1; i >= 0; --i) {
485 >        for (int i = SIZE - 1; i >= 0; --i) {
486              assertEquals(i, q.peekLast());
487              assertEquals(i, q.pollLast());
488              assertTrue(q.peekLast() == null ||
# Line 501 | Line 511 | public class ConcurrentLinkedDequeTest e
511       */
512      public void testLastElement() {
513          ConcurrentLinkedDeque q = populatedDeque(SIZE);
514 <        for (int i = SIZE-1; i >= 0; --i) {
514 >        for (int i = SIZE - 1; i >= 0; --i) {
515              assertEquals(i, q.getLast());
516              assertEquals(i, q.pollLast());
517          }
# Line 552 | Line 562 | public class ConcurrentLinkedDequeTest e
562          }
563          for (int i = 0; i < SIZE; i += 2) {
564              assertTrue(q.removeFirstOccurrence(new Integer(i)));
565 <            assertFalse(q.removeFirstOccurrence(new Integer(i+1)));
565 >            assertFalse(q.removeFirstOccurrence(new Integer(i + 1)));
566          }
567          assertTrue(q.isEmpty());
568      }
# Line 567 | Line 577 | public class ConcurrentLinkedDequeTest e
577          }
578          for (int i = 0; i < SIZE; i += 2) {
579              assertTrue(q.removeLastOccurrence(new Integer(i)));
580 <            assertFalse(q.removeLastOccurrence(new Integer(i+1)));
580 >            assertFalse(q.removeLastOccurrence(new Integer(i + 1)));
581          }
582          assertTrue(q.isEmpty());
583      }
# Line 626 | Line 636 | public class ConcurrentLinkedDequeTest e
636                  assertTrue(changed);
637  
638              assertTrue(q.containsAll(p));
639 <            assertEquals(SIZE-i, q.size());
639 >            assertEquals(SIZE - i, q.size());
640              p.remove();
641          }
642      }
# Line 639 | Line 649 | public class ConcurrentLinkedDequeTest e
649              ConcurrentLinkedDeque q = populatedDeque(SIZE);
650              ConcurrentLinkedDeque p = populatedDeque(i);
651              assertTrue(q.removeAll(p));
652 <            assertEquals(SIZE-i, q.size());
652 >            assertEquals(SIZE - i, q.size());
653              for (int j = 0; j < i; ++j) {
654                  Integer x = (Integer)(p.remove());
655                  assertFalse(q.contains(x));
# Line 652 | Line 662 | public class ConcurrentLinkedDequeTest e
662       */
663      public void testToArray() {
664          ConcurrentLinkedDeque q = populatedDeque(SIZE);
665 <        Object[] o = q.toArray();
666 <        for (int i = 0; i < o.length; i++)
667 <            assertSame(o[i], q.poll());
665 >        Object[] a = q.toArray();
666 >        assertSame(Object[].class, a.getClass());
667 >        for (Object o : a)
668 >            assertSame(o, q.poll());
669 >        assertTrue(q.isEmpty());
670      }
671  
672      /**
# Line 665 | Line 677 | public class ConcurrentLinkedDequeTest e
677          Integer[] ints = new Integer[SIZE];
678          Integer[] array = q.toArray(ints);
679          assertSame(ints, array);
680 <        for (int i = 0; i < ints.length; i++)
681 <            assertSame(ints[i], q.poll());
680 >        for (Integer o : ints)
681 >            assertSame(o, q.poll());
682 >        assertTrue(q.isEmpty());
683      }
684  
685      /**
# Line 675 | Line 688 | public class ConcurrentLinkedDequeTest e
688      public void testToArray_NullArg() {
689          ConcurrentLinkedDeque q = populatedDeque(SIZE);
690          try {
691 <            q.toArray(null);
691 >            q.toArray((Object[])null);
692              shouldThrow();
693          } catch (NullPointerException success) {}
694      }
# Line 755 | Line 768 | public class ConcurrentLinkedDequeTest e
768          final Random rng = new Random();
769          for (int iters = 0; iters < 100; ++iters) {
770              int max = rng.nextInt(5) + 2;
771 <            int split = rng.nextInt(max-1) + 1;
771 >            int split = rng.nextInt(max - 1) + 1;
772              for (int j = 1; j <= max; ++j)
773                  q.add(new Integer(j));
774              Iterator it = q.iterator();
775              for (int j = 1; j <= split; ++j)
776                  assertEquals(it.next(), new Integer(j));
777              it.remove();
778 <            assertEquals(it.next(), new Integer(split+1));
778 >            assertEquals(it.next(), new Integer(split + 1));
779              for (int j = 1; j <= split; ++j)
780                  q.remove(new Integer(j));
781              it = q.iterator();
782 <            for (int j = split+1; j <= max; ++j) {
782 >            for (int j = split + 1; j <= max; ++j) {
783                  assertEquals(it.next(), new Integer(j));
784                  it.remove();
785              }
# Line 823 | Line 836 | public class ConcurrentLinkedDequeTest e
836          final Random rng = new Random();
837          for (int iters = 0; iters < 100; ++iters) {
838              int max = rng.nextInt(5) + 2;
839 <            int split = rng.nextInt(max-1) + 1;
839 >            int split = rng.nextInt(max - 1) + 1;
840              for (int j = max; j >= 1; --j)
841                  q.add(new Integer(j));
842              Iterator it = q.descendingIterator();
843              for (int j = 1; j <= split; ++j)
844                  assertEquals(it.next(), new Integer(j));
845              it.remove();
846 <            assertEquals(it.next(), new Integer(split+1));
846 >            assertEquals(it.next(), new Integer(split + 1));
847              for (int j = 1; j <= split; ++j)
848                  q.remove(new Integer(j));
849              it = q.descendingIterator();
850 <            for (int j = split+1; j <= max; ++j) {
850 >            for (int j = split + 1; j <= max; ++j) {
851                  assertEquals(it.next(), new Integer(j));
852                  it.remove();
853              }
# Line 855 | Line 868 | public class ConcurrentLinkedDequeTest e
868      }
869  
870      /**
871 <     * A deserialized serialized deque has same elements in same order
871 >     * A deserialized/reserialized deque has same elements in same order
872       */
873      public void testSerialization() throws Exception {
874          Queue x = populatedDeque(SIZE);
# Line 898 | Line 911 | public class ConcurrentLinkedDequeTest e
911              } catch (NullPointerException success) {}
912          }
913      }
914 +
915 +    void runAsync(Runnable r1, Runnable r2) {
916 +        boolean b = randomBoolean();
917 +        CompletableFuture<Void> f1 = CompletableFuture.runAsync(b ? r1 : r2);
918 +        CompletableFuture<Void> f2 = CompletableFuture.runAsync(b ? r2 : r1);
919 +        f1.join();
920 +        f2.join();
921 +    }
922 +
923 +    /**
924 +     * Non-traversing Deque operations are linearizable.
925 +     * https://bugs.openjdk.java.net/browse/JDK-8188900
926 +     * ant -Djsr166.expensiveTests=true -Djsr166.tckTestClass=ConcurrentLinkedDequeTest -Djsr166.methodFilter=testBug8188900 tck
927 +     */
928 +    public void testBug8188900() {
929 +        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
930 +        final LongAdder nulls = new LongAdder(), zeros = new LongAdder();
931 +        for (int n = expensiveTests ? 100_000 : 10; n--> 0; ) {
932 +            ConcurrentLinkedDeque<Integer> d = new ConcurrentLinkedDeque<>();
933 +
934 +            boolean peek = rnd.nextBoolean();
935 +            Runnable getter = () -> {
936 +                Integer x = peek ? d.peekFirst() : d.pollFirst();
937 +                if (x == null) nulls.increment();
938 +                else if (x == 0) zeros.increment();
939 +                else
940 +                    throw new AssertionError(
941 +                        String.format(
942 +                            "unexpected value %d after %d nulls and %d zeros",
943 +                            x, nulls.sum(), zeros.sum()));
944 +            };
945 +
946 +            Runnable adder = () -> { d.addFirst(0); d.addLast(42); };
947 +
948 +            runAsync(getter, adder);
949 +        }
950 +    }
951 +
952 +    /**
953 +     * Reverse direction variant of testBug8188900
954 +     */
955 +    public void testBug8188900_reverse() {
956 +        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
957 +        final LongAdder nulls = new LongAdder(), zeros = new LongAdder();
958 +        for (int n = expensiveTests ? 100_000 : 10; n--> 0; ) {
959 +            ConcurrentLinkedDeque<Integer> d = new ConcurrentLinkedDeque<>();
960 +
961 +            boolean peek = rnd.nextBoolean();
962 +            Runnable getter = () -> {
963 +                Integer x = peek ? d.peekLast() : d.pollLast();
964 +                if (x == null) nulls.increment();
965 +                else if (x == 0) zeros.increment();
966 +                else
967 +                    throw new AssertionError(
968 +                        String.format(
969 +                            "unexpected value %d after %d nulls and %d zeros",
970 +                            x, nulls.sum(), zeros.sum()));
971 +            };
972 +
973 +            Runnable adder = () -> { d.addLast(0); d.addFirst(42); };
974 +
975 +            runAsync(getter, adder);
976 +        }
977 +    }
978 +
979 +    /**
980 +     * Non-traversing Deque operations (that return null) are linearizable.
981 +     * Don't return null when the deque is observably never empty.
982 +     * https://bugs.openjdk.java.net/browse/JDK-8189387
983 +     * ant -Djsr166.expensiveTests=true -Djsr166.tckTestClass=ConcurrentLinkedDequeTest -Djsr166.methodFilter=testBug8189387 tck
984 +     */
985 +    public void testBug8189387() {
986 +        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
987 +        Object x = new Object();
988 +        for (int n = expensiveTests ? 100_000 : 10; n--> 0; ) {
989 +            ConcurrentLinkedDeque<Object> d = new ConcurrentLinkedDeque<>();
990 +            Runnable add = chooseRandomly(
991 +                () -> d.addFirst(x),
992 +                () -> d.offerFirst(x),
993 +                () -> d.addLast(x),
994 +                () -> d.offerLast(x));
995 +
996 +            Runnable get = chooseRandomly(
997 +                () -> assertFalse(d.isEmpty()),
998 +                () -> assertSame(x, d.peekFirst()),
999 +                () -> assertSame(x, d.peekLast()),
1000 +                () -> assertSame(x, d.pollFirst()),
1001 +                () -> assertSame(x, d.pollLast()));
1002 +
1003 +            Runnable addRemove = chooseRandomly(
1004 +                () -> { d.addFirst(x); d.pollLast(); },
1005 +                () -> { d.offerFirst(x); d.removeFirst(); },
1006 +                () -> { d.offerLast(x); d.removeLast(); },
1007 +                () -> { d.addLast(x); d.pollFirst(); });
1008 +
1009 +            add.run();
1010 +            runAsync(get, addRemove);
1011 +        }
1012 +    }
1013   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines