ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CopyOnWriteArrayListTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CopyOnWriteArrayListTest.java (file contents):
Revision 1.1 by dl, Sun Aug 31 19:24:54 2003 UTC vs.
Revision 1.52 by jsr166, Wed Jan 27 02:55:18 2021 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
9 > import java.util.ArrayList;
10 > import java.util.Arrays;
11 > import java.util.Collection;
12 > import java.util.Collections;
13 > import java.util.Iterator;
14 > import java.util.List;
15 > import java.util.ListIterator;
16 > import java.util.NoSuchElementException;
17 > import java.util.concurrent.CopyOnWriteArrayList;
18 > import java.util.concurrent.ThreadLocalRandom;
19 >
20 > import junit.framework.Test;
21 >
22 > public class CopyOnWriteArrayListTest extends JSR166TestCase {
23  
12 public class CopyOnWriteArrayListTest extends TestCase{
13    
24      public static void main(String[] args) {
25 <        junit.textui.TestRunner.run (suite());  
25 >        main(suite(), args);
26      }
27  
28      public static Test suite() {
29 <        return new TestSuite(CopyOnWriteArrayListTest.class);
29 >        class Implementation implements CollectionImplementation {
30 >            public Class<?> klazz() { return CopyOnWriteArrayList.class; }
31 >            public List emptyCollection() { return new CopyOnWriteArrayList(); }
32 >            public Object makeElement(int i) { return JSR166TestCase.itemFor(i); }
33 >            public boolean isConcurrent() { return true; }
34 >            public boolean permitsNulls() { return true; }
35 >        }
36 >        class SubListImplementation extends Implementation {
37 >            @SuppressWarnings("unchecked")
38 >            public List emptyCollection() {
39 >                List list = super.emptyCollection();
40 >                ThreadLocalRandom rnd = ThreadLocalRandom.current();
41 >                if (rnd.nextBoolean())
42 >                    list.add(makeElement(rnd.nextInt()));
43 >                int i = rnd.nextInt(list.size() + 1);
44 >                return list.subList(i, i);
45 >            }
46 >        }
47 >        return newTestSuite(
48 >                CopyOnWriteArrayListTest.class,
49 >                CollectionTest.testSuite(new Implementation()),
50 >                CollectionTest.testSuite(new SubListImplementation()));
51      }
52  
53 <    static CopyOnWriteArrayList fullArray(int n){
54 <        CopyOnWriteArrayList a = new CopyOnWriteArrayList();
55 <        assertTrue(a.isEmpty());
56 <        for (int i = 0; i < n; ++i)
57 <            a.add(new Integer(i));
58 <        assertFalse(a.isEmpty());
59 <        assertEquals(n, a.size());
60 <        return a;
53 >    static CopyOnWriteArrayList<Item> populatedList(int n) {
54 >        CopyOnWriteArrayList<Item> list = new CopyOnWriteArrayList<>();
55 >        assertTrue(list.isEmpty());
56 >        for (int i = 0; i < n; i++)
57 >            mustAdd(list, i);
58 >        mustEqual(n <= 0, list.isEmpty());
59 >        mustEqual(n, list.size());
60 >        return list;
61      }
62  
63 <    /**
64 <     *  Test to verify addAll correctly adds each element from the given collection
65 <     */
66 <    public void testAddAll(){
67 <        CopyOnWriteArrayList full = fullArray(3);
68 <        Vector v = new Vector();
69 <        v.add(new Integer(3));
70 <        v.add(new Integer(4));
40 <        v.add(new Integer(5));
41 <        full.addAll(v);
42 <        assertEquals(6, full.size());
63 >    static CopyOnWriteArrayList<Item> populatedList(Item[] elements) {
64 >        CopyOnWriteArrayList<Item> list = new CopyOnWriteArrayList<>();
65 >        assertTrue(list.isEmpty());
66 >        for (Item element : elements)
67 >            list.add(element);
68 >        assertFalse(list.isEmpty());
69 >        mustEqual(elements.length, list.size());
70 >        return list;
71      }
72  
73      /**
74 <     *  Test to verify addAllAbsent adds each element from the given collection that did not
47 <     *  already exist in the List
74 >     * a new list is empty
75       */
76 <    public void testAddAllAbsent(){
77 <        CopyOnWriteArrayList full = fullArray(3);
78 <        Vector v = new Vector();
52 <        v.add(new Integer(3));
53 <        v.add(new Integer(4));
54 <        v.add(new Integer(1)); // will not add this element
55 <        full.addAllAbsent(v);
56 <        assertEquals(5, full.size());
76 >    public void testConstructor() {
77 >        List<Item> list = new CopyOnWriteArrayList<>();
78 >        assertTrue(list.isEmpty());
79      }
80  
81      /**
82 <     *  Test to verify addIfAbsent will not add the element if it already exists in the list
82 >     * new list contains all elements of initializing array
83       */
84 <    public void testAddIfAbsent(){
85 <        CopyOnWriteArrayList full = fullArray(3);
86 <        full.addIfAbsent(new Integer(1));
87 <        assertEquals(3, full.size());
84 >    public void testConstructor2() {
85 >        Item[] elts = defaultItems;
86 >        List<Item> list = new CopyOnWriteArrayList<>(elts);
87 >        for (int i = 0; i < SIZE; ++i)
88 >            mustEqual(elts[i], list.get(i));
89      }
90  
91      /**
92 <     *  test to verify addIfAbsent correctly adds the element when it does not exist in the list
92 >     * new list contains all elements of initializing collection
93       */
94 <    public void testAddIfAbsent2(){
95 <        CopyOnWriteArrayList full = fullArray(3);
96 <        full.addIfAbsent(new Integer(3));
97 <        assertTrue(full.contains(new Integer(3)));
94 >    public void testConstructor3() {
95 >        Item[] elts = defaultItems;
96 >        List<Item> list = new CopyOnWriteArrayList<>(Arrays.asList(elts));
97 >        for (int i = 0; i < SIZE; ++i)
98 >            mustEqual(elts[i], list.get(i));
99      }
100  
101      /**
102 <     *  Test to verify clear correctly removes all elements from the list
102 >     * addAll adds each element from the given collection, including duplicates
103       */
104 <    public void testClear(){
105 <        CopyOnWriteArrayList full = fullArray(3);
106 <        full.clear();
107 <        assertEquals(0, full.size());
104 >    public void testAddAll() {
105 >        List<Item> list = populatedList(3);
106 >        assertTrue(list.addAll(Arrays.asList(three, four, five)));
107 >        mustEqual(6, list.size());
108 >        assertTrue(list.addAll(Arrays.asList(three, four, five)));
109 >        mustEqual(9, list.size());
110      }
111  
112      /**
113 <     *  Test to verify contains returns the correct values
113 >     * addAllAbsent adds each element from the given collection that did not
114 >     * already exist in the List
115       */
116 <    public void testContains(){
117 <        CopyOnWriteArrayList full = fullArray(3);
118 <        assertTrue(full.contains(new Integer(1)));
119 <        assertFalse(full.contains(new Integer(5)));
120 <    }
121 <
122 <    public void testAddIndex() {
96 <        CopyOnWriteArrayList full = fullArray(3);
97 <        full.add(0, new Integer(-1));
98 <        assertEquals(4, full.size());
99 <        assertEquals(new Integer(-1), full.get(0));
100 <        assertEquals(new Integer(0), full.get(1));
101 <
102 <        full.add(2, new Integer(-2));
103 <        assertEquals(5, full.size());
104 <        assertEquals(new Integer(-2), full.get(2));
105 <        assertEquals(new Integer(2), full.get(4));
106 <    }
107 <
108 <    public void testEquals() {
109 <        CopyOnWriteArrayList a = fullArray(3);
110 <        CopyOnWriteArrayList b = fullArray(3);
111 <        assertTrue(a.equals(b));
112 <        assertTrue(b.equals(a));
113 <        assertEquals(a.hashCode(), b.hashCode());
114 <        a.add(new Integer(-1));
115 <        assertFalse(a.equals(b));
116 <        assertFalse(b.equals(a));
117 <        b.add(new Integer(-1));
118 <        assertTrue(a.equals(b));
119 <        assertTrue(b.equals(a));
120 <        assertEquals(a.hashCode(), b.hashCode());
116 >    public void testAddAllAbsent() {
117 >        CopyOnWriteArrayList<Item> list = populatedList(3);
118 >        // "one" is duplicate and will not be added
119 >        mustEqual(2, list.addAllAbsent(Arrays.asList(three, four, one)));
120 >        mustEqual(5, list.size());
121 >        mustEqual(0, list.addAllAbsent(Arrays.asList(three, four, one)));
122 >        mustEqual(5, list.size());
123      }
124  
123    
125      /**
126 <     *  Test to verify containsAll returns the correct values
126 >     * addIfAbsent will not add the element if it already exists in the list
127       */
128 <    public void testContainsAll(){
129 <        CopyOnWriteArrayList full = fullArray(3);
130 <        Vector v = new Vector();
131 <        v.add(new Integer(1));
131 <        v.add(new Integer(2));
132 <        assertTrue(full.containsAll(v));
133 <        v.add(new Integer(6));
134 <        assertFalse(full.containsAll(v));
128 >    public void testAddIfAbsent() {
129 >        CopyOnWriteArrayList<Item> list = populatedList(SIZE);
130 >        list.addIfAbsent(one);
131 >        mustEqual(SIZE, list.size());
132      }
133  
134      /**
135 <     *  Test to verify get returns the correct value for the given index
135 >     * addIfAbsent adds the element when it does not exist in the list
136       */
137 <    public void testGet(){
138 <        CopyOnWriteArrayList full = fullArray(3);
139 <        assertEquals(0, ((Integer)full.get(0)).intValue());
137 >    public void testAddIfAbsent2() {
138 >        CopyOnWriteArrayList<Item> list = populatedList(SIZE);
139 >        list.addIfAbsent(three);
140 >        mustContain(list, three);
141      }
142  
143      /**
144 <     *  Test to verify indexOf gives the correct index for the given object
144 >     * clear removes all elements from the list
145       */
146 <    public void testIndexOf(){
147 <        CopyOnWriteArrayList full = fullArray(3);
148 <        assertEquals(1, full.indexOf(new Integer(1)));
149 <        assertEquals(-1, full.indexOf("puppies"));
146 >    public void testClear() {
147 >        List<Item> list = populatedList(SIZE);
148 >        list.clear();
149 >        mustEqual(0, list.size());
150      }
151  
152      /**
153 <     *  Test to verify indexOf gives the correct index based on the given index
156 <     *  at which to start searching
153 >     * Cloned list is equal
154       */
155 <    public void testIndexOf2(){
156 <        CopyOnWriteArrayList full = fullArray(3);
157 <        assertEquals(1, full.indexOf(new Integer(1), 0));
158 <        assertEquals(-1, full.indexOf(new Integer(1), 2));
155 >    public void testClone() {
156 >        CopyOnWriteArrayList<Item> l1 = populatedList(SIZE);
157 >        @SuppressWarnings("unchecked")
158 >        CopyOnWriteArrayList<Item> l2 = (CopyOnWriteArrayList<Item>)(l1.clone());
159 >        mustEqual(l1, l2);
160 >        l1.clear();
161 >        assertFalse(l1.equals(l2));
162      }
163  
164      /**
165 <     *  Test to verify isEmpty returns the correct values
165 >     * contains is true for added elements
166       */
167 <    public void testIsEmpty(){
168 <        CopyOnWriteArrayList empty = new CopyOnWriteArrayList();
169 <        CopyOnWriteArrayList full = fullArray(3);
170 <        assertTrue(empty.isEmpty());
171 <        assertFalse(full.isEmpty());
167 >    public void testContains() {
168 >        List<Item> list = populatedList(3);
169 >        mustContain(list, one);
170 >        mustNotContain(list, five);
171      }
172  
173      /**
174 <     *  Test to verify iterator() returns an iterator containing the elements of the list
174 >     * adding at an index places it in the indicated index
175       */
176 <    public void testIterator(){
177 <        CopyOnWriteArrayList full = fullArray(3);
178 <        Iterator i = full.iterator();
179 <        int j;
180 <        for(j = 0; i.hasNext(); j++)
181 <            assertEquals(j, ((Integer)i.next()).intValue());
183 <        assertEquals(3, j);
184 <    }
176 >    public void testAddIndex() {
177 >        List<Item> list = populatedList(3);
178 >        list.add(0, minusOne);
179 >        mustEqual(4, list.size());
180 >        mustEqual(minusOne, list.get(0));
181 >        mustEqual(zero, list.get(1));
182  
183 <    public void testIteratorRemove () {
184 <        CopyOnWriteArrayList full = fullArray(3);
185 <        Iterator it = full.iterator();
186 <        it.next();
190 <        try {
191 <            it.remove();
192 <            fail("should throw");
193 <        }
194 <        catch (UnsupportedOperationException success) {}
183 >        list.add(2, minusTwo);
184 >        mustEqual(5, list.size());
185 >        mustEqual(minusTwo, list.get(2));
186 >        mustEqual(two, list.get(4));
187      }
188  
197    public void testToString(){
198        CopyOnWriteArrayList full = fullArray(3);
199        String s = full.toString();
200        for (int i = 0; i < 3; ++i) {
201            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
202        }
203    }        
204
189      /**
190 <     *  Test to verify lastIndexOf returns the correct index for the given object
190 >     * lists with same elements are equal and have same hashCode
191       */
192 <    public void testLastIndexOf1(){
193 <        CopyOnWriteArrayList full = fullArray(3);
194 <        full.add(new Integer(1));
195 <        full.add(new Integer(3));
196 <        assertEquals(3, full.lastIndexOf(new Integer(1)));
197 <        assertEquals(-1, full.lastIndexOf(new Integer(6)));
192 >    public void testEquals() {
193 >        List<Item> a = populatedList(3);
194 >        List<Item> b = populatedList(3);
195 >        assertTrue(a.equals(b));
196 >        assertTrue(b.equals(a));
197 >        assertTrue(a.containsAll(b));
198 >        assertTrue(b.containsAll(a));
199 >        mustEqual(a.hashCode(), b.hashCode());
200 >        a.add(minusOne);
201 >        assertFalse(a.equals(b));
202 >        assertFalse(b.equals(a));
203 >        assertTrue(a.containsAll(b));
204 >        assertFalse(b.containsAll(a));
205 >        b.add(minusOne);
206 >        assertTrue(a.equals(b));
207 >        assertTrue(b.equals(a));
208 >        assertTrue(a.containsAll(b));
209 >        assertTrue(b.containsAll(a));
210 >        mustEqual(a.hashCode(), b.hashCode());
211 >
212 >        assertFalse(a.equals(null));
213      }
214  
215      /**
216 <     *  Test to verify lastIndexOf returns the correct index from the given starting point
216 >     * containsAll returns true for collections with subset of elements
217       */
218 <    public void testlastIndexOf2(){
219 <        CopyOnWriteArrayList full = fullArray(3);
220 <        full.add(new Integer(1));
221 <        full.add(new Integer(3));
222 <        assertEquals(3, full.lastIndexOf(new Integer(1), 4));
223 <        assertEquals(-1, full.lastIndexOf(new Integer(3), 3));
218 >    public void testContainsAll() {
219 >        List<Item> list = populatedList(3);
220 >        assertTrue(list.containsAll(Arrays.asList()));
221 >        assertTrue(list.containsAll(Arrays.asList(one)));
222 >        assertTrue(list.containsAll(Arrays.asList(one, two)));
223 >        assertFalse(list.containsAll(Arrays.asList(one, two, six)));
224 >        assertFalse(list.containsAll(Arrays.asList(six)));
225 >
226 >        try {
227 >            list.containsAll(null);
228 >            shouldThrow();
229 >        } catch (NullPointerException success) {}
230      }
231  
232      /**
233 <     *  Identical to testIterator, except ListInterator has more functionality
233 >     * get returns the value at the given index
234       */
235 <    public void testListIterator1(){
236 <        CopyOnWriteArrayList full = fullArray(3);
237 <        ListIterator i = full.listIterator();
233 <        int j;
234 <        for(j = 0; i.hasNext(); j++)
235 <            assertEquals(j, ((Integer)i.next()).intValue());
236 <        assertEquals(3, j);
235 >    public void testGet() {
236 >        List<Item> list = populatedList(3);
237 >        mustEqual(0, list.get(0));
238      }
239  
240      /**
241 <     *  Identical to testIterator and testListIterator1, but only returns those elements
242 <     *  after the given index
241 >     * indexOf(Object) returns the index of the first occurrence of the
242 >     * specified element in this list, or -1 if this list does not
243 >     * contain the element
244       */
245 <    public void testListIterator2(){
246 <        CopyOnWriteArrayList full = fullArray(3);
247 <        ListIterator i = full.listIterator(1);
248 <        int j;
249 <        for(j = 0; i.hasNext(); j++)
250 <            assertEquals(j+1, ((Integer)i.next()).intValue());
251 <        assertEquals(2, j);
245 >    public void testIndexOf() {
246 >        List<Item> list = populatedList(3);
247 >        mustEqual(-1, list.indexOf(minusTen));
248 >        int size = list.size();
249 >        for (int i = 0; i < size; i++) {
250 >            Item I = itemFor(i);
251 >            mustEqual(i, list.indexOf(I));
252 >            mustEqual(i, list.subList(0, size).indexOf(I));
253 >            mustEqual(i, list.subList(0, i + 1).indexOf(I));
254 >            mustEqual(-1, list.subList(0, i).indexOf(I));
255 >            mustEqual(0, list.subList(i, size).indexOf(I));
256 >            mustEqual(-1, list.subList(i + 1, size).indexOf(I));
257 >        }
258 >
259 >        list.add(one);
260 >        mustEqual(1, list.indexOf(one));
261 >        mustEqual(1, list.subList(0, size + 1).indexOf(one));
262 >        mustEqual(0, list.subList(1, size + 1).indexOf(one));
263 >        mustEqual(size - 2, list.subList(2, size + 1).indexOf(one));
264 >        mustEqual(0, list.subList(size, size + 1).indexOf(one));
265 >        mustEqual(-1, list.subList(size + 1, size + 1).indexOf(one));
266      }
267  
268      /**
269 <     *  Test to verify remove correctly removes and returns the object at the given index
270 <     */
271 <    public void testRemove(){
272 <        CopyOnWriteArrayList full = fullArray(3);
273 <        assertEquals(new Integer(2), full.remove(2));
274 <        assertEquals(2, full.size());
269 >     * indexOf(E, int) returns the index of the first occurrence of the
270 >     * specified element in this list, searching forwards from index,
271 >     * or returns -1 if the element is not found
272 >     */
273 >    public void testIndexOf2() {
274 >        CopyOnWriteArrayList<Item> list = populatedList(3);
275 >        int size = list.size();
276 >        mustEqual(-1, list.indexOf(minusTen, 0));
277 >
278 >        // we might expect IOOBE, but spec says otherwise
279 >        mustEqual(-1, list.indexOf(zero, size));
280 >        mustEqual(-1, list.indexOf(zero, Integer.MAX_VALUE));
281 >
282 >        assertThrows(
283 >            IndexOutOfBoundsException.class,
284 >            () -> list.indexOf(zero, -1),
285 >            () -> list.indexOf(zero, Integer.MIN_VALUE));
286 >
287 >        for (int i = 0; i < size; i++) {
288 >            Item I = itemFor(i);
289 >            mustEqual(i, list.indexOf(I, 0));
290 >            mustEqual(i, list.indexOf(I, i));
291 >            mustEqual(-1, list.indexOf(I, i + 1));
292 >        }
293 >
294 >        list.add(one);
295 >        mustEqual(1, list.indexOf(one, 0));
296 >        mustEqual(1, list.indexOf(one, 1));
297 >        mustEqual(size, list.indexOf(one, 2));
298 >        mustEqual(size, list.indexOf(one, size));
299      }
300  
301      /**
302 <     *  Test to verify removeAll correctly removes all elements from the given collection
302 >     * isEmpty returns true when empty, else false
303       */
304 <    public void testRemoveAll(){
305 <        CopyOnWriteArrayList full = fullArray(3);
306 <        Vector v = new Vector();
307 <        v.add(new Integer(1));
308 <        v.add(new Integer(2));
309 <        full.removeAll(v);
310 <        assertEquals(1, full.size());
304 >    public void testIsEmpty() {
305 >        List<Item> empty = new CopyOnWriteArrayList<>();
306 >        assertTrue(empty.isEmpty());
307 >        assertTrue(empty.subList(0, 0).isEmpty());
308 >
309 >        List<Item> full = populatedList(SIZE);
310 >        assertFalse(full.isEmpty());
311 >        assertTrue(full.subList(0, 0).isEmpty());
312 >        assertTrue(full.subList(SIZE, SIZE).isEmpty());
313      }
314  
315      /**
316 <     *  Test to verify set correctly changes the element at the given index
316 >     * iterator() returns an iterator containing the elements of the
317 >     * list in insertion order
318       */
319 <    public void testSet(){
320 <        CopyOnWriteArrayList full = fullArray(3);
321 <        assertEquals(new Integer(2), full.set(2, new Integer(4)));
322 <        assertEquals(4, ((Integer)full.get(2)).intValue());
319 >    public void testIterator() {
320 >        Collection<Item> empty = new CopyOnWriteArrayList<>();
321 >        assertFalse(empty.iterator().hasNext());
322 >        try {
323 >            empty.iterator().next();
324 >            shouldThrow();
325 >        } catch (NoSuchElementException success) {}
326 >
327 >        Item[] elements = seqItems(SIZE);
328 >        shuffle(elements);
329 >        Collection<Item> full = populatedList(elements);
330 >
331 >        Iterator<? extends Item> it = full.iterator();
332 >        for (int j = 0; j < SIZE; j++) {
333 >            assertTrue(it.hasNext());
334 >            mustEqual(elements[j], it.next());
335 >        }
336 >        assertIteratorExhausted(it);
337      }
338  
339      /**
340 <     *  Test to verify size returns the correct values
340 >     * iterator of empty collection has no elements
341       */
342 <    public void testSize(){
343 <        CopyOnWriteArrayList empty = new CopyOnWriteArrayList();
344 <        CopyOnWriteArrayList full = fullArray(3);
288 <        assertEquals(3, full.size());
289 <        assertEquals(0, empty.size());
342 >    public void testEmptyIterator() {
343 >        Collection<Item> c = new CopyOnWriteArrayList<>();
344 >        assertIteratorExhausted(c.iterator());
345      }
346  
347      /**
348 <     *  Test to verify toArray returns an Object array containing all elements from the list
348 >     * iterator.remove throws UnsupportedOperationException
349       */
350 <    public void testToArray(){
351 <        CopyOnWriteArrayList full = fullArray(3);
352 <        Object[] o = full.toArray();
353 <        assertEquals(3, o.length);
354 <        assertEquals(0, ((Integer)o[0]).intValue());
355 <        assertEquals(1, ((Integer)o[1]).intValue());
356 <        assertEquals(2, ((Integer)o[2]).intValue());
350 >    public void testIteratorRemove() {
351 >        CopyOnWriteArrayList<Item> list = populatedList(SIZE);
352 >        Iterator<? extends Item> it = list.iterator();
353 >        it.next();
354 >        try {
355 >            it.remove();
356 >            shouldThrow();
357 >        } catch (UnsupportedOperationException success) {}
358      }
359  
360      /**
361 <     *  test to verify toArray returns an Integer array containing all elements from the list
361 >     * toString contains toString of elements
362       */
363 <    public void testToArray2(){
364 <        CopyOnWriteArrayList full = fullArray(3);
365 <        Integer[] i = new Integer[3];
366 <        i = (Integer[])full.toArray(i);
367 <        assertEquals(3, i.length);
368 <        assertEquals(0, i[0].intValue());
369 <        assertEquals(1, i[1].intValue());
370 <        assertEquals(2, i[2].intValue());
363 >    public void testToString() {
364 >        mustEqual("[]", new CopyOnWriteArrayList<>().toString());
365 >        List<Item> list = populatedList(3);
366 >        String s = list.toString();
367 >        for (int i = 0; i < 3; ++i)
368 >            assertTrue(s.contains(String.valueOf(i)));
369 >        mustEqual(new ArrayList<Item>(list).toString(),
370 >                     list.toString());
371      }
372  
373 +    /**
374 +     * lastIndexOf(Object) returns the index of the last occurrence of
375 +     * the specified element in this list, or -1 if this list does not
376 +     * contain the element
377 +     */
378 +    public void testLastIndexOf1() {
379 +        List<Item> list = populatedList(3);
380 +        mustEqual(-1, list.lastIndexOf(itemFor(-42)));
381 +        int size = list.size();
382 +        for (int i = 0; i < size; i++) {
383 +            Item I = itemFor(i);
384 +            mustEqual(i, list.lastIndexOf(I));
385 +            mustEqual(i, list.subList(0, size).lastIndexOf(I));
386 +            mustEqual(i, list.subList(0, i + 1).lastIndexOf(I));
387 +            mustEqual(-1, list.subList(0, i).lastIndexOf(I));
388 +            mustEqual(0, list.subList(i, size).lastIndexOf(I));
389 +            mustEqual(-1, list.subList(i + 1, size).lastIndexOf(I));
390 +        }
391  
392 <    public void testSubList() {
393 <        CopyOnWriteArrayList a = fullArray(10);
394 <        assertTrue(a.subList(1,1).isEmpty());
395 <        for(int j = 0; j < 9; ++j) {
396 <            for(int i = j ; i < 10; ++i) {
397 <                List b = a.subList(j,i);
324 <                for(int k = j; k < i; ++k) {
325 <                    assertEquals(new Integer(k), b.get(k-j));
326 <                }
327 <            }
328 <        }
329 <
330 <        Integer m1 = new Integer(-1);
331 <        List s = a.subList(2, 5);
332 <        assertEquals(s.size(), 3);
333 <        s.set(2, new Integer(m1));
334 <        assertEquals(a.get(4), m1);
335 <        s.clear();
336 <        assertEquals(a.size(), 7);
392 >        list.add(one);
393 >        mustEqual(size, list.lastIndexOf(one));
394 >        mustEqual(size, list.subList(0, size + 1).lastIndexOf(one));
395 >        mustEqual(1, list.subList(0, size).lastIndexOf(one));
396 >        mustEqual(0, list.subList(1, 2).lastIndexOf(one));
397 >        mustEqual(-1, list.subList(0, 1).indexOf(one));
398      }
399  
339    // Exception tests
340
400      /**
401 <     *  Test to verify toArray throws an ArrayStoreException when the given array
402 <     *  can not store the objects inside the list
403 <     */
404 <    public void testToArray_ArrayStoreException(){
405 <        try{
406 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
407 <            c.add("zfasdfsdf");
408 <            c.add("asdadasd");
409 <            c.toArray(new Long[5]);
410 <            fail("Object[] toArray(Object[]) should throw ArrayStoreException");
411 <        }catch(ArrayStoreException e){}
401 >     * lastIndexOf(E, int) returns the index of the last occurrence of the
402 >     * specified element in this list, searching backwards from index, or
403 >     * returns -1 if the element is not found
404 >     */
405 >    public void testLastIndexOf2() {
406 >        CopyOnWriteArrayList<Item> list = populatedList(3);
407 >
408 >        // we might expect IOOBE, but spec says otherwise
409 >        mustEqual(-1, list.lastIndexOf(zero, -1));
410 >
411 >        int size = list.size();
412 >        assertThrows(
413 >            IndexOutOfBoundsException.class,
414 >            () -> list.lastIndexOf(zero, size),
415 >            () -> list.lastIndexOf(zero, Integer.MAX_VALUE));
416 >
417 >        for (int i = 0; i < size; i++) {
418 >            Item I = itemFor(i);
419 >            mustEqual(i, list.lastIndexOf(I, i));
420 >            mustEqual(list.indexOf(I), list.lastIndexOf(I, i));
421 >            if (i > 0)
422 >                mustEqual(-1, list.lastIndexOf(I, i - 1));
423 >        }
424 >        list.add(one);
425 >        list.add(three);
426 >        mustEqual(1, list.lastIndexOf(one, 1));
427 >        mustEqual(1, list.lastIndexOf(one, 2));
428 >        mustEqual(3, list.lastIndexOf(one, 3));
429 >        mustEqual(3, list.lastIndexOf(one, 4));
430 >        mustEqual(-1, list.lastIndexOf(three, 3));
431      }
432  
433      /**
434 <     *  Test to verify get throws an IndexOutOfBoundsException on a negative index
434 >     * listIterator traverses all elements
435       */
436 <    public void testGet1_IndexOutOfBoundsException(){
437 <        try{
438 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
439 <            c.get(-1);
440 <            fail("Object get(int) should throw IndexOutOfBounds exception");
441 <        }catch(IndexOutOfBoundsException e){}
442 <    }
365 <    
366 <    /**
367 <     *  Test to verify get throws an IndexOutOfBoundsException on a too high index
368 <     */
369 <    public void testGet2_IndexOutOfBoundsException(){
370 <        try{
371 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
372 <            c.add("asdasd");
373 <            c.add("asdad");
374 <            c.get(100);
375 <            fail("Object get(int) should throw IndexOutOfBounds exception");
376 <        }catch(IndexOutOfBoundsException e){}
436 >    public void testListIterator1() {
437 >        List<Item> list = populatedList(SIZE);
438 >        ListIterator<? extends Item> i = list.listIterator();
439 >        int j;
440 >        for (j = 0; i.hasNext(); j++)
441 >            mustEqual(j, i.next());
442 >        mustEqual(SIZE, j);
443      }
444  
445      /**
446 <     *  Test to verify set throws an IndexOutOfBoundsException on a negative index
381 <     */
382 <    public void testSet1_IndexOutOfBoundsException(){
383 <        try{
384 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
385 <            c.set(-1,"qwerty");
386 <            fail("Object get(int, Object) should throw IndexOutOfBounds exception");
387 <        }catch(IndexOutOfBoundsException e){}
388 <    }
389 <    
390 <    /**
391 <     *  Test to verify set throws an IndexOutOfBoundsException on a too high index
446 >     * listIterator only returns those elements after the given index
447       */
448 <    public void testSet2(){
449 <        try{
450 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
451 <            c.add("asdasd");
452 <            c.add("asdad");
453 <            c.set(100, "qwerty");
454 <            fail("Object set(int, Object) should throw IndexOutOfBounds exception");
400 <        }catch(IndexOutOfBoundsException e){}
448 >    public void testListIterator2() {
449 >        List<Item> list = populatedList(3);
450 >        ListIterator<? extends Item> i = list.listIterator(1);
451 >        int j;
452 >        for (j = 0; i.hasNext(); j++)
453 >            mustEqual(j + 1, i.next());
454 >        mustEqual(2, j);
455      }
456  
457      /**
458 <     *  Test to verify add throws an IndexOutOfBoundsException on a negative index
458 >     * remove(int) removes and returns the object at the given index
459       */
460 <    public void testAdd1_IndexOutOfBoundsException(){
461 <        try{
462 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
463 <            c.add(-1,"qwerty");
464 <            fail("void add(int, Object) should throw IndexOutOfBounds exception");
465 <        }catch(IndexOutOfBoundsException e){}
466 <    }
467 <    
414 <    /**
415 <     *  Test to verify add throws an IndexOutOfBoundsException on a too high index
416 <     */
417 <    public void testAdd2_IndexOutOfBoundsException(){
418 <        try{
419 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
420 <            c.add("asdasd");
421 <            c.add("asdasdasd");
422 <            c.add(100, "qwerty");
423 <            fail("void add(int, Object) should throw IndexOutOfBounds exception");
424 <        }catch(IndexOutOfBoundsException e){}
460 >    public void testRemove_int() {
461 >        int SIZE = 3;
462 >        for (int i = 0; i < SIZE; i++) {
463 >            List<Item> list = populatedList(SIZE);
464 >            mustEqual(i, list.remove(i));
465 >            mustEqual(SIZE - 1, list.size());
466 >            mustNotContain(list, i);
467 >        }
468      }
469  
470      /**
471 <     *  Test to verify remove throws an IndexOutOfBoundsException on a negative index
471 >     * remove(Object) removes the object if found and returns true
472       */
473 <    public void testRemove1_IndexOutOfBounds(){
474 <        try{
475 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
476 <            c.remove(-1);
477 <            fail("Object remove(int) should throw IndexOutOfBounds exception");
478 <        }catch(IndexOutOfBoundsException e){}
473 >    public void testRemove_Object() {
474 >        int SIZE = 3;
475 >        for (int i = 0; i < SIZE; i++) {
476 >            List<Item> list = populatedList(SIZE);
477 >            mustNotRemove(list, fortytwo);
478 >            mustRemove(list, i);
479 >            mustEqual(SIZE - 1, list.size());
480 >            mustNotContain(list, i);
481 >        }
482 >        CopyOnWriteArrayList<Item> x = new CopyOnWriteArrayList<>(Arrays.asList(four, five, six));
483 >        mustRemove(x, six);
484 >        mustEqual(x, Arrays.asList(four, five));
485 >        mustRemove(x, four);
486 >        mustEqual(x, Arrays.asList(five));
487 >        mustRemove(x, five);
488 >        mustEqual(x, Arrays.asList());
489 >        mustNotRemove(x, five);
490      }
491  
492      /**
493 <     *  Test to verify remove throws an IndexOutOfBoundsException on a too high index
493 >     * removeAll removes all elements from the given collection
494       */
495 <    public void testRemove2_IndexOutOfBounds(){
496 <        try{
497 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
498 <            c.add("asdasd");
499 <            c.add("adasdasd");
500 <            c.remove(100);
447 <            fail("Object remove(int) should throw IndexOutOfBounds exception");
448 <        }catch(IndexOutOfBoundsException e){}
495 >    public void testRemoveAll() {
496 >        List<Item> list = populatedList(3);
497 >        assertTrue(list.removeAll(Arrays.asList(one, two)));
498 >        mustEqual(1, list.size());
499 >        assertFalse(list.removeAll(Arrays.asList(one, two)));
500 >        mustEqual(1, list.size());
501      }
502 <    
451 <    /**
452 <     *  Test to verify addAll throws an IndexOutOfBoundsException on a negative index
453 <     */
454 <    public void testAddAll1_IndexOutOfBoundsException(){
455 <        try{
456 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
457 <            c.addAll(-1,new LinkedList());
458 <            fail("boolean add(int, Collection) should throw IndexOutOfBounds exception");
459 <        }catch(IndexOutOfBoundsException e){}
460 <    }
461 <    
502 >
503      /**
504 <     *  Test to verify addAll throws an IndexOutOfBoundsException on a too high index
504 >     * set changes the element at the given index
505       */
506 <    public void testAddAll2_IndexOutOfBoundsException(){
507 <        try{
508 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
509 <            c.add("asdasd");
469 <            c.add("asdasdasd");
470 <            c.addAll(100, new LinkedList());
471 <            fail("boolean addAll(int, Collection) should throw IndexOutOfBounds exception");
472 <        }catch(IndexOutOfBoundsException e){}
506 >    public void testSet() {
507 >        List<Item> list = populatedList(3);
508 >        mustEqual(2, list.set(2, four));
509 >        mustEqual(4, list.get(2));
510      }
511  
512      /**
513 <     *  Test to verify listIterator throws an IndexOutOfBoundsException on a negative index
513 >     * size returns the number of elements
514       */
515 <    public void testListIterator1_IndexOutOfBoundsException(){
516 <        try{
517 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
518 <            c.listIterator(-1);
519 <            fail("ListIterator listIterator(int) should throw IndexOutOfBounds exceptione");
520 <        }catch(IndexOutOfBoundsException e){}
515 >    public void testSize() {
516 >        List<Item> empty = new CopyOnWriteArrayList<>();
517 >        mustEqual(0, empty.size());
518 >        mustEqual(0, empty.subList(0, 0).size());
519 >
520 >        List<Item> full = populatedList(SIZE);
521 >        mustEqual(SIZE, full.size());
522 >        mustEqual(0, full.subList(0, 0).size());
523 >        mustEqual(0, full.subList(SIZE, SIZE).size());
524      }
525  
526      /**
527 <     *  Test to verify listIterator throws an IndexOutOfBoundsException on a too high index
527 >     * toArray() returns an Object array containing all elements from
528 >     * the list in insertion order
529       */
530 <    public void testListIterator2_IndexOutOfBoundsException(){
531 <        try{
532 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
533 <            c.add("adasd");
534 <            c.add("asdasdas");
535 <            c.listIterator(100);
536 <            fail("ListIterator listIterator(int) should throw IndexOutOfBounds exception");
537 <        }catch(IndexOutOfBoundsException e){}
530 >    public void testToArray() {
531 >        Object[] a = new CopyOnWriteArrayList<>().toArray();
532 >        assertTrue(Arrays.equals(new Object[0], a));
533 >        assertSame(Object[].class, a.getClass());
534 >
535 >        Item[] elements = seqItems(SIZE);
536 >        shuffle(elements);
537 >        Collection<Item> full = populatedList(elements);
538 >
539 >        assertTrue(Arrays.equals(elements, full.toArray()));
540 >        assertSame(Object[].class, full.toArray().getClass());
541      }
542  
543      /**
544 <     *  Test to verify subList throws an IndexOutOfBoundsException on a negative index
544 >     * toArray(Item array) returns an Item array containing all
545 >     * elements from the list in insertion order
546       */
547 <    public void testSubList1_IndexOutOfBoundsException(){
548 <        try{
549 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
550 <            c.subList(-1,100);
547 >    public void testToArray2() {
548 >        Collection<Item> empty = new CopyOnWriteArrayList<>();
549 >        Item[] a;
550 >
551 >        a = new Item[0];
552 >        assertSame(a, empty.toArray(a));
553 >
554 >        a = new Item[SIZE / 2];
555 >        Arrays.fill(a, fortytwo);
556 >        assertSame(a, empty.toArray(a));
557 >        assertNull(a[0]);
558 >        for (int i = 1; i < a.length; i++)
559 >            mustEqual(42, a[i]);
560 >
561 >        Item[] elements = seqItems(SIZE);
562 >        shuffle(elements);
563 >        Collection<Item> full = populatedList(elements);
564 >
565 >        Arrays.fill(a, fortytwo);
566 >        assertTrue(Arrays.equals(elements, full.toArray(a)));
567 >        for (int i = 0; i < a.length; i++)
568 >            mustEqual(42, a[i]);
569 >        assertSame(Item[].class, full.toArray(a).getClass());
570  
571 <            fail("List subList(int, int) should throw IndexOutofBounds exception");
572 <        }catch(IndexOutOfBoundsException e){}
571 >        a = new Item[SIZE];
572 >        Arrays.fill(a, fortytwo);
573 >        assertSame(a, full.toArray(a));
574 >        assertTrue(Arrays.equals(elements, a));
575 >
576 >        a = new Item[2 * SIZE];
577 >        Arrays.fill(a, fortytwo);
578 >        assertSame(a, full.toArray(a));
579 >        assertTrue(Arrays.equals(elements, Arrays.copyOf(a, SIZE)));
580 >        assertNull(a[SIZE]);
581 >        for (int i = SIZE + 1; i < a.length; i++)
582 >            mustEqual(42, a[i]);
583      }
584  
585      /**
586 <     *  Test to verify subList throws an IndexOutOfBoundsException on a too high index
586 >     * sublists contains elements at indexes offset from their base
587       */
588 <    public void testSubList2_IndexOutOfBoundsException(){
589 <        try{
590 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
591 <            c.add("asdasd");
592 <            c.subList(1,100);
593 <            fail("List subList(int, int) should throw IndexOutofBounds exception");
594 <        }catch(IndexOutOfBoundsException e){}
588 >    public void testSubList() {
589 >        List<Item> a = populatedList(10);
590 >        assertTrue(a.subList(1,1).isEmpty());
591 >        for (int j = 0; j < 9; ++j) {
592 >            for (int i = j ; i < 10; ++i) {
593 >                List<Item> b = a.subList(j,i);
594 >                for (int k = j; k < i; ++k) {
595 >                    mustEqual(itemFor(k), b.get(k-j));
596 >                }
597 >            }
598 >        }
599 >
600 >        List<Item> s = a.subList(2, 5);
601 >        mustEqual(3, s.size());
602 >        s.set(2, minusOne);
603 >        mustEqual(a.get(4), minusOne);
604 >        s.clear();
605 >        mustEqual(7, a.size());
606 >
607 >        assertThrows(
608 >            IndexOutOfBoundsException.class,
609 >            () -> s.get(0),
610 >            () -> s.set(0, fortytwo));
611      }
612  
613 +    // Exception tests
614 +
615      /**
616 <     *  Test to verify subList throws IndexOutOfBoundsException when the second index
617 <     *  is lower then the first
616 >     * toArray throws an ArrayStoreException when the given array
617 >     * can not store the objects inside the list
618       */
619 <    public void testSubList3_IndexOutOfBoundsException(){
620 <        try{
621 <            CopyOnWriteArrayList c = new CopyOnWriteArrayList();
622 <            c.subList(3,1);
623 <
624 <            fail("List subList(int, int) should throw IndexOutofBounds exception");
625 <        }catch(IndexOutOfBoundsException e){}
619 >    @SuppressWarnings("CollectionToArraySafeParameter")
620 >    public void testToArray_ArrayStoreException() {
621 >        List<Item> list = new CopyOnWriteArrayList<>();
622 >        // Items are not auto-converted to Longs
623 >        list.add(eightysix);
624 >        list.add(ninetynine);
625 >        assertThrows(
626 >            ArrayStoreException.class,
627 >            () -> list.toArray(new Long[0]),
628 >            () -> list.toArray(new Long[5]));
629 >    }
630 >
631 >    @SuppressWarnings("unchecked")
632 >    void testIndexOutOfBoundsException(List list) {
633 >        int size = list.size();
634 >        assertThrows(
635 >            IndexOutOfBoundsException.class,
636 >            () -> list.get(-1),
637 >            () -> list.get(size),
638 >            () -> list.set(-1, "qwerty"),
639 >            () -> list.set(size, "qwerty"),
640 >            () -> list.add(-1, "qwerty"),
641 >            () -> list.add(size + 1, "qwerty"),
642 >            () -> list.remove(-1),
643 >            () -> list.remove(size),
644 >            () -> list.addAll(-1, Collections.emptyList()),
645 >            () -> list.addAll(size + 1, Collections.emptyList()),
646 >            () -> list.listIterator(-1),
647 >            () -> list.listIterator(size + 1),
648 >            () -> list.subList(-1, size),
649 >            () -> list.subList(0, size + 1));
650 >
651 >        // Conversely, operations that must not throw
652 >        list.addAll(0, Collections.emptyList());
653 >        list.addAll(size, Collections.emptyList());
654 >        list.add(0, "qwerty");
655 >        list.add(list.size(), "qwerty");
656 >        list.get(0);
657 >        list.get(list.size() - 1);
658 >        list.set(0, "azerty");
659 >        list.set(list.size() - 1, "azerty");
660 >        list.listIterator(0);
661 >        list.listIterator(list.size());
662 >        list.subList(0, list.size());
663 >        list.remove(list.size() - 1);
664 >    }
665 >
666 >    /**
667 >     * IndexOutOfBoundsException is thrown when specified
668 >     */
669 >    public void testIndexOutOfBoundsException() {
670 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
671 >        List<Item> x = populatedList(rnd.nextInt(5));
672 >        testIndexOutOfBoundsException(x);
673 >
674 >        int start = rnd.nextInt(x.size() + 1);
675 >        int end = rnd.nextInt(start, x.size() + 1);
676 >        assertThrows(
677 >            IndexOutOfBoundsException.class,
678 >            () -> x.subList(start, start - 1));
679 >        List<Item> subList = x.subList(start, end);
680 >        testIndexOutOfBoundsException(x);
681 >    }
682 >
683 >    /**
684 >     * a deserialized/reserialized list equals original
685 >     */
686 >    public void testSerialization() throws Exception {
687 >        List<Item> x = populatedList(SIZE);
688 >        List<Item> y = serialClone(x);
689 >
690 >        assertNotSame(x, y);
691 >        mustEqual(x.size(), y.size());
692 >        mustEqual(x.toString(), y.toString());
693 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
694 >        mustEqual(x, y);
695 >        mustEqual(y, x);
696 >        while (!x.isEmpty()) {
697 >            assertFalse(y.isEmpty());
698 >            mustEqual(x.remove(0), y.remove(0));
699 >        }
700 >        assertTrue(y.isEmpty());
701      }
702 <    
702 >
703   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines