ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedTransferQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedTransferQueueTest.java (file contents):
Revision 1.27 by jsr166, Thu Oct 28 17:22:13 2010 UTC vs.
Revision 1.78 by jsr166, Sun May 14 01:30:34 2017 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include John Vint
6   */
7  
8 < import java.io.BufferedInputStream;
9 < import java.io.BufferedOutputStream;
10 < import java.io.ByteArrayInputStream;
11 < import java.io.ByteArrayOutputStream;
12 < import java.io.ObjectInputStream;
13 < import java.io.ObjectOutputStream;
8 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
9 >
10   import java.util.ArrayList;
11   import java.util.Arrays;
12 + import java.util.Collection;
13   import java.util.Iterator;
14   import java.util.List;
15   import java.util.NoSuchElementException;
16 < import java.util.concurrent.*;
17 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
18 < import static java.util.concurrent.TimeUnit.NANOSECONDS;
16 > import java.util.Queue;
17 > import java.util.concurrent.BlockingQueue;
18 > import java.util.concurrent.Callable;
19 > import java.util.concurrent.CountDownLatch;
20 > import java.util.concurrent.Executors;
21 > import java.util.concurrent.ExecutorService;
22 > import java.util.concurrent.LinkedTransferQueue;
23 >
24   import junit.framework.Test;
23 import junit.framework.TestSuite;
25  
26   @SuppressWarnings({"unchecked", "rawtypes"})
27   public class LinkedTransferQueueTest extends JSR166TestCase {
27
28      public static class Generic extends BlockingQueueTest {
29          protected BlockingQueue emptyCollection() {
30              return new LinkedTransferQueue();
# Line 32 | Line 32 | public class LinkedTransferQueueTest ext
32      }
33  
34      public static void main(String[] args) {
35 <        junit.textui.TestRunner.run(suite());
35 >        main(suite(), args);
36      }
37  
38      public static Test suite() {
39 +        class Implementation implements CollectionImplementation {
40 +            public Class<?> klazz() { return LinkedTransferQueue.class; }
41 +            public Collection emptyCollection() { return new LinkedTransferQueue(); }
42 +            public Object makeElement(int i) { return i; }
43 +            public boolean isConcurrent() { return true; }
44 +            public boolean permitsNulls() { return false; }
45 +        }
46          return newTestSuite(LinkedTransferQueueTest.class,
47 <                            new Generic().testSuite());
48 <    }
42 <
43 <    void checkEmpty(LinkedTransferQueue q) throws InterruptedException {
44 <        assertTrue(q.isEmpty());
45 <        assertEquals(0, q.size());
46 <        assertNull(q.peek());
47 <        assertNull(q.poll());
48 <        assertNull(q.poll(0, MILLISECONDS));
49 <        assertEquals(q.toString(), "[]");
50 <        assertTrue(Arrays.equals(q.toArray(), new Object[0]));
51 <        assertFalse(q.iterator().hasNext());
52 <        try {
53 <            q.element();
54 <            shouldThrow();
55 <        } catch (NoSuchElementException success) {}
56 <        try {
57 <            q.iterator().next();
58 <            shouldThrow();
59 <        } catch (NoSuchElementException success) {}
60 <        try {
61 <            q.remove();
62 <            shouldThrow();
63 <        } catch (NoSuchElementException success) {}
47 >                            new Generic().testSuite(),
48 >                            CollectionTest.testSuite(new Implementation()));
49      }
50  
51      /**
# Line 88 | Line 73 | public class LinkedTransferQueueTest ext
73       * NullPointerException
74       */
75      public void testConstructor3() {
76 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
77          try {
78 <            Integer[] ints = new Integer[SIZE];
93 <            new LinkedTransferQueue(Arrays.asList(ints));
78 >            new LinkedTransferQueue(elements);
79              shouldThrow();
80          } catch (NullPointerException success) {}
81      }
# Line 100 | Line 85 | public class LinkedTransferQueueTest ext
85       * throws NullPointerException
86       */
87      public void testConstructor4() {
88 +        Integer[] ints = new Integer[SIZE];
89 +        for (int i = 0; i < SIZE - 1; ++i)
90 +            ints[i] = i;
91 +        Collection<Integer> elements = Arrays.asList(ints);
92          try {
93 <            Integer[] ints = new Integer[SIZE];
105 <            for (int i = 0; i < SIZE - 1; ++i) {
106 <                ints[i] = i;
107 <            }
108 <            new LinkedTransferQueue(Arrays.asList(ints));
93 >            new LinkedTransferQueue(elements);
94              shouldThrow();
95          } catch (NullPointerException success) {}
96      }
# Line 138 | Line 123 | public class LinkedTransferQueueTest ext
123       * remainingCapacity() always returns Integer.MAX_VALUE
124       */
125      public void testRemainingCapacity() {
126 <        LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
126 >        BlockingQueue q = populatedQueue(SIZE);
127          for (int i = 0; i < SIZE; ++i) {
128              assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
129              assertEquals(SIZE - i, q.size());
130 <            q.remove();
130 >            assertEquals(i, q.remove());
131          }
132          for (int i = 0; i < SIZE; ++i) {
133              assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
134              assertEquals(i, q.size());
135 <            q.add(i);
135 >            assertTrue(q.add(i));
136          }
137      }
138  
139      /**
155     * offer(null) throws NullPointerException
156     */
157    public void testOfferNull() {
158        try {
159            LinkedTransferQueue q = new LinkedTransferQueue();
160            q.offer(null);
161            shouldThrow();
162        } catch (NullPointerException success) {}
163    }
164
165    /**
166     * add(null) throws NullPointerException
167     */
168    public void testAddNull() {
169        try {
170            LinkedTransferQueue q = new LinkedTransferQueue();
171            q.add(null);
172            shouldThrow();
173        } catch (NullPointerException success) {}
174    }
175
176    /**
177     * addAll(null) throws NullPointerException
178     */
179    public void testAddAll1() {
180        try {
181            LinkedTransferQueue q = new LinkedTransferQueue();
182            q.addAll(null);
183            shouldThrow();
184        } catch (NullPointerException success) {}
185    }
186
187    /**
140       * addAll(this) throws IllegalArgumentException
141       */
142      public void testAddAllSelf() {
143 +        LinkedTransferQueue q = populatedQueue(SIZE);
144          try {
192            LinkedTransferQueue q = populatedQueue(SIZE);
145              q.addAll(q);
146              shouldThrow();
147          } catch (IllegalArgumentException success) {}
148      }
149  
150      /**
199     * addAll of a collection with null elements throws NullPointerException
200     */
201    public void testAddAll2() {
202        try {
203            LinkedTransferQueue q = new LinkedTransferQueue();
204            Integer[] ints = new Integer[SIZE];
205            q.addAll(Arrays.asList(ints));
206            shouldThrow();
207        } catch (NullPointerException success) {}
208    }
209
210    /**
151       * addAll of a collection with any null elements throws
152       * NullPointerException after possibly adding some elements
153       */
154      public void testAddAll3() {
155 +        LinkedTransferQueue q = new LinkedTransferQueue();
156 +        Integer[] ints = new Integer[SIZE];
157 +        for (int i = 0; i < SIZE - 1; ++i)
158 +            ints[i] = i;
159          try {
216            LinkedTransferQueue q = new LinkedTransferQueue();
217            Integer[] ints = new Integer[SIZE];
218            for (int i = 0; i < SIZE - 1; ++i) {
219                ints[i] = i;
220            }
160              q.addAll(Arrays.asList(ints));
161              shouldThrow();
162          } catch (NullPointerException success) {}
# Line 241 | Line 180 | public class LinkedTransferQueueTest ext
180      }
181  
182      /**
244     * put(null) throws NullPointerException
245     */
246    public void testPutNull() throws InterruptedException {
247        try {
248            LinkedTransferQueue q = new LinkedTransferQueue();
249            q.put(null);
250            shouldThrow();
251        } catch (NullPointerException success) {}
252    }
253
254    /**
183       * all elements successfully put are contained
184       */
185      public void testPut() {
186 <        LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
186 >        LinkedTransferQueue<Integer> q = new LinkedTransferQueue<>();
187          for (int i = 0; i < SIZE; ++i) {
188 <            assertEquals(q.size(), i);
188 >            assertEquals(i, q.size());
189              q.put(i);
190              assertTrue(q.contains(i));
191          }
# Line 274 | Line 202 | public class LinkedTransferQueueTest ext
202      }
203  
204      /**
205 <     * take blocks interruptibly when empty
278 <     */
279 <    public void testTakeFromEmpty() throws InterruptedException {
280 <        final LinkedTransferQueue q = new LinkedTransferQueue();
281 <        Thread t = newStartedThread(new CheckedInterruptedRunnable() {
282 <            public void realRun() throws InterruptedException {
283 <                q.take();
284 <            }});
285 <        Thread.sleep(SHORT_DELAY_MS);
286 <        t.interrupt();
287 <        t.join();
288 <    }
289 <
290 <    /**
291 <     * Take removes existing elements until empty, then blocks interruptibly
205 >     * take removes existing elements until empty, then blocks interruptibly
206       */
207      public void testBlockingTake() throws InterruptedException {
208 <        final LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
209 <        Thread t = new Thread(new CheckedRunnable() {
208 >        final BlockingQueue q = populatedQueue(SIZE);
209 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
210 >        Thread t = newStartedThread(new CheckedRunnable() {
211              public void realRun() throws InterruptedException {
212 <                for (int i = 0; i < SIZE; ++i) {
213 <                    assertEquals(i, (int) q.take());
214 <                }
212 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
213 >
214 >                Thread.currentThread().interrupt();
215 >                try {
216 >                    q.take();
217 >                    shouldThrow();
218 >                } catch (InterruptedException success) {}
219 >                assertFalse(Thread.interrupted());
220 >
221 >                pleaseInterrupt.countDown();
222                  try {
223                      q.take();
224                      shouldThrow();
225                  } catch (InterruptedException success) {}
226 +                assertFalse(Thread.interrupted());
227              }});
228  
229 <        t.start();
230 <        Thread.sleep(SHORT_DELAY_MS);
229 >        await(pleaseInterrupt);
230 >        assertThreadBlocks(t, Thread.State.WAITING);
231          t.interrupt();
232 <        t.join();
310 <        checkEmpty(q);
232 >        awaitTermination(t);
233      }
234  
235      /**
# Line 323 | Line 245 | public class LinkedTransferQueueTest ext
245      }
246  
247      /**
248 <     * timed pool with zero timeout succeeds when non-empty, else times out
248 >     * timed poll with zero timeout succeeds when non-empty, else times out
249       */
250      public void testTimedPoll0() throws InterruptedException {
251          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
# Line 335 | Line 257 | public class LinkedTransferQueueTest ext
257      }
258  
259      /**
260 <     * timed pool with nonzero timeout succeeds when non-empty, else times out
260 >     * timed poll with nonzero timeout succeeds when non-empty, else times out
261       */
262      public void testTimedPoll() throws InterruptedException {
263          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
264 <        for (int i = 0; i < SIZE; ++i) {
265 <            long t0 = System.nanoTime();
264 >        long startTime = System.nanoTime();
265 >        for (int i = 0; i < SIZE; ++i)
266              assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
267 <            long millisElapsed = (System.nanoTime() - t0)/(1024 * 1024);
268 <            assertTrue(millisElapsed < SMALL_DELAY_MS);
269 <        }
270 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
267 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
268 >
269 >        startTime = System.nanoTime();
270 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
271 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
272          checkEmpty(q);
273      }
274  
# Line 354 | Line 277 | public class LinkedTransferQueueTest ext
277       * returning timeout status
278       */
279      public void testInterruptedTimedPoll() throws InterruptedException {
280 <        final LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
280 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
281 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
282          Thread t = newStartedThread(new CheckedRunnable() {
283              public void realRun() throws InterruptedException {
284 <                for (int i = 0; i < SIZE; ++i) {
285 <                    long t0 = System.nanoTime();
284 >                long startTime = System.nanoTime();
285 >                for (int i = 0; i < SIZE; i++)
286                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
287 <                    long millisElapsed = (System.nanoTime() - t0)/(1024 * 1024);
288 <                    assertTrue(millisElapsed < SMALL_DELAY_MS);
289 <                }
287 >
288 >                Thread.currentThread().interrupt();
289 >                try {
290 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
291 >                    shouldThrow();
292 >                } catch (InterruptedException success) {}
293 >                assertFalse(Thread.interrupted());
294 >
295 >                pleaseInterrupt.countDown();
296                  try {
297                      q.poll(LONG_DELAY_MS, MILLISECONDS);
298                      shouldThrow();
299                  } catch (InterruptedException success) {}
300 +                assertFalse(Thread.interrupted());
301 +
302 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
303              }});
304  
305 <        Thread.sleep(SMALL_DELAY_MS);
305 >        await(pleaseInterrupt);
306 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
307          t.interrupt();
308 <        t.join();
308 >        awaitTermination(t);
309 >        checkEmpty(q);
310 >    }
311 >
312 >    /**
313 >     * timed poll after thread interrupted throws InterruptedException
314 >     * instead of returning timeout status
315 >     */
316 >    public void testTimedPollAfterInterrupt() throws InterruptedException {
317 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
318 >        Thread t = newStartedThread(new CheckedRunnable() {
319 >            public void realRun() throws InterruptedException {
320 >                long startTime = System.nanoTime();
321 >                Thread.currentThread().interrupt();
322 >                for (int i = 0; i < SIZE; ++i)
323 >                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
324 >                try {
325 >                    q.poll(LONG_DELAY_MS, MILLISECONDS);
326 >                    shouldThrow();
327 >                } catch (InterruptedException success) {}
328 >                assertFalse(Thread.interrupted());
329 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
330 >            }});
331 >
332 >        awaitTermination(t);
333          checkEmpty(q);
334      }
335  
# Line 422 | Line 380 | public class LinkedTransferQueueTest ext
380      }
381  
382      /**
425     * remove(x) removes x and returns true if present
426     */
427    public void testRemoveElement() throws InterruptedException {
428        LinkedTransferQueue q = populatedQueue(SIZE);
429        for (int i = 1; i < SIZE; i += 2) {
430            assertTrue(q.remove(i));
431        }
432        for (int i = 0; i < SIZE; i += 2) {
433            assertTrue(q.remove(i));
434            assertFalse(q.remove(i + 1));
435        }
436        checkEmpty(q);
437    }
438
439    /**
383       * An add following remove(x) succeeds
384       */
385      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 482 | Line 425 | public class LinkedTransferQueueTest ext
425       */
426      public void testContainsAll() {
427          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
428 <        LinkedTransferQueue<Integer> p = new LinkedTransferQueue<Integer>();
428 >        LinkedTransferQueue<Integer> p = new LinkedTransferQueue<>();
429          for (int i = 0; i < SIZE; ++i) {
430              assertTrue(q.containsAll(p));
431              assertFalse(p.containsAll(q));
# Line 528 | Line 471 | public class LinkedTransferQueueTest ext
471      }
472  
473      /**
474 <     * toArray() contains all elements
474 >     * toArray() contains all elements in FIFO order
475       */
476 <    public void testToArray() throws InterruptedException {
476 >    public void testToArray() {
477          LinkedTransferQueue q = populatedQueue(SIZE);
478          Object[] o = q.toArray();
479          for (int i = 0; i < o.length; i++) {
480 <            assertEquals(o[i], q.take());
480 >            assertSame(o[i], q.poll());
481          }
482      }
483  
484      /**
485 <     * toArray(a) contains all elements
485 >     * toArray(a) contains all elements in FIFO order
486       */
487 <    public void testToArray2() throws InterruptedException {
487 >    public void testToArray2() {
488          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
489          Integer[] ints = new Integer[SIZE];
490 <        ints = q.toArray(ints);
490 >        Integer[] array = q.toArray(ints);
491 >        assertSame(ints, array);
492          for (int i = 0; i < ints.length; i++) {
493 <            assertEquals(ints[i], q.take());
493 >            assertSame(ints[i], q.poll());
494          }
495      }
496  
497      /**
498 <     * toArray(null) throws NullPointerException
555 <     */
556 <    public void testToArray_BadArg() {
557 <        LinkedTransferQueue q = populatedQueue(SIZE);
558 <        try {
559 <            Object o[] = q.toArray(null);
560 <            shouldThrow();
561 <        } catch (NullPointerException success) {}
562 <    }
563 <
564 <    /**
565 <     * toArray(incompatible array type) throws CCE
498 >     * toArray(incompatible array type) throws ArrayStoreException
499       */
500      public void testToArray1_BadArg() {
501          LinkedTransferQueue q = populatedQueue(SIZE);
502          try {
503 <            Object o[] = q.toArray(new String[10]);
503 >            q.toArray(new String[10]);
504              shouldThrow();
505          } catch (ArrayStoreException success) {}
506      }
# Line 578 | Line 511 | public class LinkedTransferQueueTest ext
511      public void testIterator() throws InterruptedException {
512          LinkedTransferQueue q = populatedQueue(SIZE);
513          Iterator it = q.iterator();
514 <        int i = 0;
515 <        while (it.hasNext()) {
516 <            assertEquals(it.next(), i++);
517 <        }
514 >        int i;
515 >        for (i = 0; it.hasNext(); i++)
516 >            assertTrue(q.contains(it.next()));
517 >        assertEquals(i, SIZE);
518 >        assertIteratorExhausted(it);
519 >
520 >        it = q.iterator();
521 >        for (i = 0; it.hasNext(); i++)
522 >            assertEquals(it.next(), q.take());
523          assertEquals(i, SIZE);
524 +        assertIteratorExhausted(it);
525 +    }
526 +
527 +    /**
528 +     * iterator of empty collection has no elements
529 +     */
530 +    public void testEmptyIterator() {
531 +        assertIteratorExhausted(new LinkedTransferQueue().iterator());
532      }
533  
534      /**
# Line 608 | Line 554 | public class LinkedTransferQueueTest ext
554       * iterator ordering is FIFO
555       */
556      public void testIteratorOrdering() {
557 <        final LinkedTransferQueue<Integer> q
612 <            = new LinkedTransferQueue<Integer>();
557 >        final LinkedTransferQueue<Integer> q = new LinkedTransferQueue<>();
558          assertEquals(Integer.MAX_VALUE, q.remainingCapacity());
559          q.add(one);
560          q.add(two);
# Line 644 | Line 589 | public class LinkedTransferQueueTest ext
589          LinkedTransferQueue q = populatedQueue(SIZE);
590          String s = q.toString();
591          for (int i = 0; i < SIZE; ++i) {
592 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
592 >            assertTrue(s.contains(String.valueOf(i)));
593          }
594      }
595  
# Line 653 | Line 598 | public class LinkedTransferQueueTest ext
598       */
599      public void testOfferInExecutor() {
600          final LinkedTransferQueue q = new LinkedTransferQueue();
601 <        q.add(one);
602 <        q.add(two);
603 <        ExecutorService executor = Executors.newFixedThreadPool(2);
659 <
660 <        executor.execute(new CheckedRunnable() {
661 <            public void realRun() {
662 <                assertTrue(q.offer(three, MEDIUM_DELAY_MS, MILLISECONDS));
663 <            }});
601 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
602 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
603 >        try (PoolCleaner cleaner = cleaner(executor)) {
604  
605 <        executor.execute(new CheckedRunnable() {
606 <            public void realRun() throws InterruptedException {
607 <                Thread.sleep(SMALL_DELAY_MS);
608 <                assertSame(one, q.take());
609 <            }});
605 >            executor.execute(new CheckedRunnable() {
606 >                public void realRun() throws InterruptedException {
607 >                    threadsStarted.await();
608 >                    long startTime = System.nanoTime();
609 >                    assertTrue(q.offer(one, LONG_DELAY_MS, MILLISECONDS));
610 >                    assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
611 >                }});
612  
613 <        joinPool(executor);
613 >            executor.execute(new CheckedRunnable() {
614 >                public void realRun() throws InterruptedException {
615 >                    threadsStarted.await();
616 >                    assertSame(one, q.take());
617 >                    checkEmpty(q);
618 >                }});
619 >        }
620      }
621  
622      /**
# Line 676 | Line 624 | public class LinkedTransferQueueTest ext
624       */
625      public void testPollInExecutor() {
626          final LinkedTransferQueue q = new LinkedTransferQueue();
627 <        ExecutorService executor = Executors.newFixedThreadPool(2);
627 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
628 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
629 >        try (PoolCleaner cleaner = cleaner(executor)) {
630  
631 <        executor.execute(new CheckedRunnable() {
632 <            public void realRun() throws InterruptedException {
633 <                assertNull(q.poll());
634 <                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
635 <                assertTrue(q.isEmpty());
636 <            }});
637 <
638 <        executor.execute(new CheckedRunnable() {
639 <            public void realRun() throws InterruptedException {
690 <                Thread.sleep(SMALL_DELAY_MS);
691 <                q.put(one);
692 <            }});
631 >            executor.execute(new CheckedRunnable() {
632 >                public void realRun() throws InterruptedException {
633 >                    assertNull(q.poll());
634 >                    threadsStarted.await();
635 >                    long startTime = System.nanoTime();
636 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
637 >                    assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
638 >                    checkEmpty(q);
639 >                }});
640  
641 <        joinPool(executor);
641 >            executor.execute(new CheckedRunnable() {
642 >                public void realRun() throws InterruptedException {
643 >                    threadsStarted.await();
644 >                    q.put(one);
645 >                }});
646 >        }
647      }
648  
649      /**
650       * A deserialized serialized queue has same elements in same order
651       */
652      public void testSerialization() throws Exception {
653 <        LinkedTransferQueue q = populatedQueue(SIZE);
654 <
703 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
704 <        ObjectOutputStream out
705 <            = new ObjectOutputStream(new BufferedOutputStream(bout));
706 <        out.writeObject(q);
707 <        out.close();
653 >        Queue x = populatedQueue(SIZE);
654 >        Queue y = serialClone(x);
655  
656 <        ByteArrayInputStream bin
657 <            = new ByteArrayInputStream(bout.toByteArray());
658 <        ObjectInputStream in
659 <            = new ObjectInputStream(new BufferedInputStream(bin));
660 <        LinkedTransferQueue r = (LinkedTransferQueue) in.readObject();
661 <
662 <        assertEquals(q.size(), r.size());
716 <        while (!q.isEmpty()) {
717 <            assertEquals(q.remove(), r.remove());
656 >        assertNotSame(y, x);
657 >        assertEquals(x.size(), y.size());
658 >        assertEquals(x.toString(), y.toString());
659 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
660 >        while (!x.isEmpty()) {
661 >            assertFalse(y.isEmpty());
662 >            assertEquals(x.remove(), y.remove());
663          }
664 <    }
720 <
721 <    /**
722 <     * drainTo(null) throws NullPointerException
723 <     */
724 <    public void testDrainToNull() {
725 <        LinkedTransferQueue q = populatedQueue(SIZE);
726 <        try {
727 <            q.drainTo(null);
728 <            shouldThrow();
729 <        } catch (NullPointerException success) {}
730 <    }
731 <
732 <    /**
733 <     * drainTo(this) throws IllegalArgumentException
734 <     */
735 <    public void testDrainToSelf() {
736 <        LinkedTransferQueue q = populatedQueue(SIZE);
737 <        try {
738 <            q.drainTo(q);
739 <            shouldThrow();
740 <        } catch (IllegalArgumentException success) {}
664 >        assertTrue(y.isEmpty());
665      }
666  
667      /**
# Line 747 | Line 671 | public class LinkedTransferQueueTest ext
671          LinkedTransferQueue q = populatedQueue(SIZE);
672          ArrayList l = new ArrayList();
673          q.drainTo(l);
674 <        assertEquals(q.size(), 0);
675 <        assertEquals(l.size(), SIZE);
674 >        assertEquals(0, q.size());
675 >        assertEquals(SIZE, l.size());
676          for (int i = 0; i < SIZE; ++i) {
677 <            assertEquals(l.get(i), i);
677 >            assertEquals(i, l.get(i));
678          }
679          q.add(zero);
680          q.add(one);
# Line 759 | Line 683 | public class LinkedTransferQueueTest ext
683          assertTrue(q.contains(one));
684          l.clear();
685          q.drainTo(l);
686 <        assertEquals(q.size(), 0);
687 <        assertEquals(l.size(), 2);
686 >        assertEquals(0, q.size());
687 >        assertEquals(2, l.size());
688          for (int i = 0; i < 2; ++i) {
689 <            assertEquals(l.get(i), i);
689 >            assertEquals(i, l.get(i));
690          }
691      }
692  
# Line 778 | Line 702 | public class LinkedTransferQueueTest ext
702          ArrayList l = new ArrayList();
703          q.drainTo(l);
704          assertTrue(l.size() >= SIZE);
705 <        for (int i = 0; i < SIZE; ++i) {
706 <            assertEquals(l.get(i), i);
707 <        }
784 <        t.join();
705 >        for (int i = 0; i < SIZE; ++i)
706 >            assertEquals(i, l.get(i));
707 >        awaitTermination(t);
708          assertTrue(q.size() + l.size() >= SIZE);
709      }
710  
711      /**
789     * drainTo(null, n) throws NullPointerException
790     */
791    public void testDrainToNullN() {
792        LinkedTransferQueue q = populatedQueue(SIZE);
793        try {
794            q.drainTo(null, SIZE);
795            shouldThrow();
796        } catch (NullPointerException success) {}
797    }
798
799    /**
800     * drainTo(this, n) throws IllegalArgumentException
801     */
802    public void testDrainToSelfN() {
803        LinkedTransferQueue q = populatedQueue(SIZE);
804        try {
805            q.drainTo(q, SIZE);
806            shouldThrow();
807        } catch (IllegalArgumentException success) {}
808    }
809
810    /**
712       * drainTo(c, n) empties first min(n, size) elements of queue into c
713       */
714      public void testDrainToN() {
# Line 819 | Line 720 | public class LinkedTransferQueueTest ext
720              ArrayList l = new ArrayList();
721              q.drainTo(l, i);
722              int k = (i < SIZE) ? i : SIZE;
723 <            assertEquals(l.size(), k);
724 <            assertEquals(q.size(), SIZE - k);
725 <            for (int j = 0; j < k; ++j) {
726 <                assertEquals(l.get(j), j);
727 <            }
827 <            while (q.poll() != null)
828 <                ;
723 >            assertEquals(k, l.size());
724 >            assertEquals(SIZE - k, q.size());
725 >            for (int j = 0; j < k; ++j)
726 >                assertEquals(j, l.get(j));
727 >            do {} while (q.poll() != null);
728          }
729      }
730  
# Line 835 | Line 734 | public class LinkedTransferQueueTest ext
734       */
735      public void testWaitingConsumer() throws InterruptedException {
736          final LinkedTransferQueue q = new LinkedTransferQueue();
737 <        assertEquals(q.getWaitingConsumerCount(), 0);
737 >        assertEquals(0, q.getWaitingConsumerCount());
738          assertFalse(q.hasWaitingConsumer());
739 +        final CountDownLatch threadStarted = new CountDownLatch(1);
740  
741          Thread t = newStartedThread(new CheckedRunnable() {
742              public void realRun() throws InterruptedException {
743 <                Thread.sleep(SMALL_DELAY_MS);
744 <                assertTrue(q.hasWaitingConsumer());
745 <                assertEquals(q.getWaitingConsumerCount(), 1);
746 <                assertTrue(q.offer(one));
743 >                threadStarted.countDown();
744 >                long startTime = System.nanoTime();
745 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
746 >                assertEquals(0, q.getWaitingConsumerCount());
747                  assertFalse(q.hasWaitingConsumer());
748 <                assertEquals(q.getWaitingConsumerCount(), 0);
748 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
749              }});
750  
751 <        assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
752 <        assertEquals(q.getWaitingConsumerCount(), 0);
751 >        threadStarted.await();
752 >        Callable<Boolean> oneConsumer
753 >            = new Callable<Boolean>() { public Boolean call() {
754 >                return q.hasWaitingConsumer()
755 >                && q.getWaitingConsumerCount() == 1; }};
756 >        waitForThreadToEnterWaitState(t, oneConsumer);
757 >
758 >        assertTrue(q.offer(one));
759 >        assertEquals(0, q.getWaitingConsumerCount());
760          assertFalse(q.hasWaitingConsumer());
761 <        t.join();
761 >
762 >        awaitTermination(t);
763      }
764  
765      /**
# Line 867 | Line 775 | public class LinkedTransferQueueTest ext
775  
776      /**
777       * transfer waits until a poll occurs. The transfered element
778 <     * is returned by this associated poll.
778 >     * is returned by the associated poll.
779       */
780      public void testTransfer2() throws InterruptedException {
781 <        final LinkedTransferQueue<Integer> q
782 <            = new LinkedTransferQueue<Integer>();
781 >        final LinkedTransferQueue<Integer> q = new LinkedTransferQueue<>();
782 >        final CountDownLatch threadStarted = new CountDownLatch(1);
783  
784          Thread t = newStartedThread(new CheckedRunnable() {
785              public void realRun() throws InterruptedException {
786 <                q.transfer(SIZE);
787 <                assertTrue(q.isEmpty());
786 >                threadStarted.countDown();
787 >                q.transfer(five);
788 >                checkEmpty(q);
789              }});
790  
791 <        Thread.sleep(SHORT_DELAY_MS);
792 <        assertEquals(1, q.size());
793 <        assertEquals(SIZE, (int) q.poll());
794 <        assertTrue(q.isEmpty());
795 <        t.join();
791 >        threadStarted.await();
792 >        Callable<Boolean> oneElement
793 >            = new Callable<Boolean>() { public Boolean call() {
794 >                return !q.isEmpty() && q.size() == 1; }};
795 >        waitForThreadToEnterWaitState(t, oneElement);
796 >
797 >        assertSame(five, q.poll());
798 >        checkEmpty(q);
799 >        awaitTermination(t);
800      }
801  
802      /**
803       * transfer waits until a poll occurs, and then transfers in fifo order
804       */
805      public void testTransfer3() throws InterruptedException {
806 <        final LinkedTransferQueue<Integer> q
894 <            = new LinkedTransferQueue<Integer>();
806 >        final LinkedTransferQueue<Integer> q = new LinkedTransferQueue<>();
807  
808          Thread first = newStartedThread(new CheckedRunnable() {
809              public void realRun() throws InterruptedException {
810 <                Integer i = SIZE + 1;
811 <                q.transfer(i);
900 <                assertTrue(!q.contains(i));
810 >                q.transfer(four);
811 >                assertFalse(q.contains(four));
812                  assertEquals(1, q.size());
813              }});
814  
815          Thread interruptedThread = newStartedThread(
816              new CheckedInterruptedRunnable() {
817                  public void realRun() throws InterruptedException {
818 <                    while (q.size() == 0)
818 >                    while (q.isEmpty())
819                          Thread.yield();
820 <                    q.transfer(SIZE);
820 >                    q.transfer(five);
821                  }});
822  
823          while (q.size() < 2)
824              Thread.yield();
825          assertEquals(2, q.size());
826 <        assertEquals(SIZE + 1, (int) q.poll());
826 >        assertSame(four, q.poll());
827          first.join();
828          assertEquals(1, q.size());
829          interruptedThread.interrupt();
830          interruptedThread.join();
831 <        assertEquals(0, q.size());
921 <        assertTrue(q.isEmpty());
831 >        checkEmpty(q);
832      }
833  
834      /**
# Line 935 | Line 845 | public class LinkedTransferQueueTest ext
845                  assertSame(three, q.poll());
846              }});
847  
848 <        Thread.sleep(SHORT_DELAY_MS);
848 >        while (q.isEmpty())
849 >            Thread.yield();
850 >        assertFalse(q.isEmpty());
851 >        assertEquals(1, q.size());
852          assertTrue(q.offer(three));
853          assertSame(four, q.poll());
854 <        t.join();
854 >        awaitTermination(t);
855      }
856  
857      /**
858       * transfer waits until a take occurs. The transfered element
859 <     * is returned by this associated take.
859 >     * is returned by the associated take.
860       */
861      public void testTransfer5() throws InterruptedException {
862 <        final LinkedTransferQueue<Integer> q
950 <            = new LinkedTransferQueue<Integer>();
862 >        final LinkedTransferQueue<Integer> q = new LinkedTransferQueue<>();
863  
864          Thread t = newStartedThread(new CheckedRunnable() {
865              public void realRun() throws InterruptedException {
866 <                q.transfer(SIZE);
866 >                q.transfer(four);
867                  checkEmpty(q);
868              }});
869  
870 <        Thread.sleep(SHORT_DELAY_MS);
871 <        assertEquals(SIZE, (int) q.take());
870 >        while (q.isEmpty())
871 >            Thread.yield();
872 >        assertFalse(q.isEmpty());
873 >        assertEquals(1, q.size());
874 >        assertSame(four, q.take());
875          checkEmpty(q);
876 <        t.join();
876 >        awaitTermination(t);
877      }
878  
879      /**
880       * tryTransfer(null) throws NullPointerException
881       */
882      public void testTryTransfer1() {
883 +        final LinkedTransferQueue q = new LinkedTransferQueue();
884          try {
969            final LinkedTransferQueue q = new LinkedTransferQueue();
885              q.tryTransfer(null);
886              shouldThrow();
887          } catch (NullPointerException success) {}
# Line 996 | Line 911 | public class LinkedTransferQueueTest ext
911                  while (! q.hasWaitingConsumer())
912                      Thread.yield();
913                  assertTrue(q.hasWaitingConsumer());
914 <                assertTrue(q.isEmpty());
1000 <                assertEquals(q.size(), 0);
914 >                checkEmpty(q);
915                  assertTrue(q.tryTransfer(hotPotato));
916              }});
917  
918 <        assertSame(hotPotato, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
918 >        long startTime = System.nanoTime();
919 >        assertSame(hotPotato, q.poll(LONG_DELAY_MS, MILLISECONDS));
920 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
921          checkEmpty(q);
922 <        t.join();
922 >        awaitTermination(t);
923      }
924  
925      /**
# Line 1019 | Line 935 | public class LinkedTransferQueueTest ext
935                  while (! q.hasWaitingConsumer())
936                      Thread.yield();
937                  assertTrue(q.hasWaitingConsumer());
938 <                assertTrue(q.isEmpty());
1023 <                assertEquals(q.size(), 0);
938 >                checkEmpty(q);
939                  assertTrue(q.tryTransfer(hotPotato));
940              }});
941  
942          assertSame(q.take(), hotPotato);
943          checkEmpty(q);
944 <        t.join();
944 >        awaitTermination(t);
945      }
946  
947      /**
948 <     * tryTransfer waits the amount given if interrupted, and
1034 <     * throws interrupted exception
948 >     * tryTransfer blocks interruptibly if no takers
949       */
950      public void testTryTransfer5() throws InterruptedException {
951          final LinkedTransferQueue q = new LinkedTransferQueue();
952 +        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
953 +        assertTrue(q.isEmpty());
954  
955 <        Thread toInterrupt = newStartedThread(new CheckedInterruptedRunnable() {
955 >        Thread t = newStartedThread(new CheckedRunnable() {
956              public void realRun() throws InterruptedException {
957 <                q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
957 >                long startTime = System.nanoTime();
958 >                Thread.currentThread().interrupt();
959 >                try {
960 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
961 >                    shouldThrow();
962 >                } catch (InterruptedException success) {}
963 >                assertFalse(Thread.interrupted());
964 >
965 >                pleaseInterrupt.countDown();
966 >                try {
967 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
968 >                    shouldThrow();
969 >                } catch (InterruptedException success) {}
970 >                assertFalse(Thread.interrupted());
971 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
972              }});
973  
974 <        Thread.sleep(SMALL_DELAY_MS);
975 <        toInterrupt.interrupt();
976 <        toInterrupt.join();
974 >        await(pleaseInterrupt);
975 >        assertThreadBlocks(t, Thread.State.TIMED_WAITING);
976 >        t.interrupt();
977 >        awaitTermination(t);
978 >        checkEmpty(q);
979      }
980  
981      /**
982 <     * tryTransfer gives up after the timeout and return false
982 >     * tryTransfer gives up after the timeout and returns false
983       */
984      public void testTryTransfer6() throws InterruptedException {
985          final LinkedTransferQueue q = new LinkedTransferQueue();
986  
987          Thread t = newStartedThread(new CheckedRunnable() {
988              public void realRun() throws InterruptedException {
989 <                long t0 = System.nanoTime();
989 >                long startTime = System.nanoTime();
990                  assertFalse(q.tryTransfer(new Object(),
991 <                                          SHORT_DELAY_MS, MILLISECONDS));
992 <                long elapsed = NANOSECONDS.toMillis(System.nanoTime() - t0);
993 <                assertTrue(elapsed >= SHORT_DELAY_MS);
991 >                                          timeoutMillis(), MILLISECONDS));
992 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
993 >                checkEmpty(q);
994              }});
995  
996 <        checkEmpty(q);
1065 <        awaitTermination(t, MEDIUM_DELAY_MS);
996 >        awaitTermination(t);
997          checkEmpty(q);
998      }
999  
# Line 1076 | Line 1007 | public class LinkedTransferQueueTest ext
1007  
1008          Thread t = newStartedThread(new CheckedRunnable() {
1009              public void realRun() throws InterruptedException {
1010 <                assertTrue(q.tryTransfer(five, MEDIUM_DELAY_MS, MILLISECONDS));
1011 <                assertTrue(q.isEmpty());
1010 >                long startTime = System.nanoTime();
1011 >                assertTrue(q.tryTransfer(five, LONG_DELAY_MS, MILLISECONDS));
1012 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
1013 >                checkEmpty(q);
1014              }});
1015  
1016 <        Thread.sleep(SHORT_DELAY_MS);
1016 >        while (q.size() != 2)
1017 >            Thread.yield();
1018          assertEquals(2, q.size());
1019          assertSame(four, q.poll());
1020          assertSame(five, q.poll());
1021          checkEmpty(q);
1022 <        t.join();
1022 >        awaitTermination(t);
1023      }
1024  
1025      /**
1026 <     * tryTransfer attempts to enqueue into the q and fails returning
1027 <     * false not enqueueing and the successive poll is null
1026 >     * tryTransfer attempts to enqueue into the queue and fails
1027 >     * returning false not enqueueing and the successive poll is null
1028       */
1029      public void testTryTransfer8() throws InterruptedException {
1030          final LinkedTransferQueue q = new LinkedTransferQueue();
1031          assertTrue(q.offer(four));
1032          assertEquals(1, q.size());
1033 <        assertFalse(q.tryTransfer(five, SHORT_DELAY_MS, MILLISECONDS));
1033 >        long startTime = System.nanoTime();
1034 >        assertFalse(q.tryTransfer(five, timeoutMillis(), MILLISECONDS));
1035 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
1036          assertEquals(1, q.size());
1037          assertSame(four, q.poll());
1038          assertNull(q.poll());
# Line 1104 | Line 1040 | public class LinkedTransferQueueTest ext
1040      }
1041  
1042      private LinkedTransferQueue<Integer> populatedQueue(int n) {
1043 <        LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
1044 <        assertTrue(q.isEmpty());
1043 >        LinkedTransferQueue<Integer> q = new LinkedTransferQueue<>();
1044 >        checkEmpty(q);
1045          for (int i = 0; i < n; i++) {
1046              assertEquals(i, q.size());
1047              assertTrue(q.offer(i));
# Line 1114 | Line 1050 | public class LinkedTransferQueueTest ext
1050          assertFalse(q.isEmpty());
1051          return q;
1052      }
1053 +
1054 +    /**
1055 +     * remove(null), contains(null) always return false
1056 +     */
1057 +    public void testNeverContainsNull() {
1058 +        Collection<?>[] qs = {
1059 +            new LinkedTransferQueue<Object>(),
1060 +            populatedQueue(2),
1061 +        };
1062 +
1063 +        for (Collection<?> q : qs) {
1064 +            assertFalse(q.contains(null));
1065 +            assertFalse(q.remove(null));
1066 +        }
1067 +    }
1068   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines