ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedTransferQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedTransferQueueTest.java (file contents):
Revision 1.33 by jsr166, Fri Oct 29 06:22:12 2010 UTC vs.
Revision 1.54 by jsr166, Wed Dec 31 16:44:02 2014 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include John Vint
6   */
7  
8 < import java.io.BufferedInputStream;
9 < import java.io.BufferedOutputStream;
10 < import java.io.ByteArrayInputStream;
11 < import java.io.ByteArrayOutputStream;
12 < import java.io.ObjectInputStream;
13 < import java.io.ObjectOutputStream;
14 < import java.util.ArrayList;
8 > import junit.framework.*;
9   import java.util.Arrays;
10 + import java.util.ArrayList;
11 + import java.util.Collection;
12   import java.util.Iterator;
13   import java.util.List;
14   import java.util.NoSuchElementException;
15 < import java.util.concurrent.*;
15 > import java.util.Queue;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Executors;
19 > import java.util.concurrent.ExecutorService;
20 > import java.util.concurrent.LinkedTransferQueue;
21   import static java.util.concurrent.TimeUnit.MILLISECONDS;
21 import static java.util.concurrent.TimeUnit.NANOSECONDS;
22 import junit.framework.Test;
23 import junit.framework.TestSuite;
22  
23   @SuppressWarnings({"unchecked", "rawtypes"})
24   public class LinkedTransferQueueTest extends JSR166TestCase {
# Line 40 | Line 38 | public class LinkedTransferQueueTest ext
38                              new Generic().testSuite());
39      }
40  
43    void checkEmpty(BlockingQueue q) {
44        try {
45            assertTrue(q.isEmpty());
46            assertEquals(0, q.size());
47            assertNull(q.peek());
48            assertNull(q.poll());
49            assertNull(q.poll(0, MILLISECONDS));
50            assertEquals(q.toString(), "[]");
51            assertTrue(Arrays.equals(q.toArray(), new Object[0]));
52            assertFalse(q.iterator().hasNext());
53            try {
54                q.element();
55                shouldThrow();
56            } catch (NoSuchElementException success) {}
57            try {
58                q.iterator().next();
59                shouldThrow();
60            } catch (NoSuchElementException success) {}
61            try {
62                q.remove();
63                shouldThrow();
64            } catch (NoSuchElementException success) {}
65        } catch (InterruptedException ie) {
66            threadUnexpectedException(ie);
67        }
68    }
69
41      /**
42       * Constructor builds new queue with size being zero and empty
43       * being true
# Line 92 | Line 63 | public class LinkedTransferQueueTest ext
63       * NullPointerException
64       */
65      public void testConstructor3() {
66 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
67          try {
68 <            Integer[] ints = new Integer[SIZE];
97 <            new LinkedTransferQueue(Arrays.asList(ints));
68 >            new LinkedTransferQueue(elements);
69              shouldThrow();
70          } catch (NullPointerException success) {}
71      }
# Line 104 | Line 75 | public class LinkedTransferQueueTest ext
75       * throws NullPointerException
76       */
77      public void testConstructor4() {
78 +        Integer[] ints = new Integer[SIZE];
79 +        for (int i = 0; i < SIZE-1; ++i)
80 +            ints[i] = i;
81 +        Collection<Integer> elements = Arrays.asList(ints);
82          try {
83 <            Integer[] ints = new Integer[SIZE];
109 <            for (int i = 0; i < SIZE - 1; ++i) {
110 <                ints[i] = i;
111 <            }
112 <            new LinkedTransferQueue(Arrays.asList(ints));
83 >            new LinkedTransferQueue(elements);
84              shouldThrow();
85          } catch (NullPointerException success) {}
86      }
# Line 156 | Line 127 | public class LinkedTransferQueueTest ext
127      }
128  
129      /**
159     * offer(null) throws NullPointerException
160     */
161    public void testOfferNull() {
162        try {
163            LinkedTransferQueue q = new LinkedTransferQueue();
164            q.offer(null);
165            shouldThrow();
166        } catch (NullPointerException success) {}
167    }
168
169    /**
170     * add(null) throws NullPointerException
171     */
172    public void testAddNull() {
173        try {
174            LinkedTransferQueue q = new LinkedTransferQueue();
175            q.add(null);
176            shouldThrow();
177        } catch (NullPointerException success) {}
178    }
179
180    /**
181     * addAll(null) throws NullPointerException
182     */
183    public void testAddAll1() {
184        try {
185            LinkedTransferQueue q = new LinkedTransferQueue();
186            q.addAll(null);
187            shouldThrow();
188        } catch (NullPointerException success) {}
189    }
190
191    /**
130       * addAll(this) throws IllegalArgumentException
131       */
132      public void testAddAllSelf() {
# Line 200 | Line 138 | public class LinkedTransferQueueTest ext
138      }
139  
140      /**
203     * addAll of a collection with null elements throws NullPointerException
204     */
205    public void testAddAll2() {
206        try {
207            LinkedTransferQueue q = new LinkedTransferQueue();
208            Integer[] ints = new Integer[SIZE];
209            q.addAll(Arrays.asList(ints));
210            shouldThrow();
211        } catch (NullPointerException success) {}
212    }
213
214    /**
141       * addAll of a collection with any null elements throws
142       * NullPointerException after possibly adding some elements
143       */
# Line 245 | Line 171 | public class LinkedTransferQueueTest ext
171      }
172  
173      /**
248     * put(null) throws NullPointerException
249     */
250    public void testPutNull() throws InterruptedException {
251        try {
252            LinkedTransferQueue q = new LinkedTransferQueue();
253            q.put(null);
254            shouldThrow();
255        } catch (NullPointerException success) {}
256    }
257
258    /**
174       * all elements successfully put are contained
175       */
176      public void testPut() {
177          LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
178          for (int i = 0; i < SIZE; ++i) {
179 <            assertEquals(q.size(), i);
179 >            assertEquals(i, q.size());
180              q.put(i);
181              assertTrue(q.contains(i));
182          }
# Line 281 | Line 196 | public class LinkedTransferQueueTest ext
196       * take removes existing elements until empty, then blocks interruptibly
197       */
198      public void testBlockingTake() throws InterruptedException {
199 <        final BlockingQueue<Integer> q = populatedQueue(SIZE);
200 <        final CountDownLatch aboutToWait = new CountDownLatch(1);
199 >        final BlockingQueue q = populatedQueue(SIZE);
200 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
201          Thread t = newStartedThread(new CheckedRunnable() {
202              public void realRun() throws InterruptedException {
203                  for (int i = 0; i < SIZE; ++i) {
204 <                    assertEquals(i, (int) q.take());
204 >                    assertEquals(i, q.take());
205                  }
206 <                aboutToWait.countDown();
206 >
207 >                Thread.currentThread().interrupt();
208 >                try {
209 >                    q.take();
210 >                    shouldThrow();
211 >                } catch (InterruptedException success) {}
212 >                assertFalse(Thread.interrupted());
213 >
214 >                pleaseInterrupt.countDown();
215                  try {
216                      q.take();
217                      shouldThrow();
218                  } catch (InterruptedException success) {}
219 +                assertFalse(Thread.interrupted());
220              }});
221  
222 <        aboutToWait.await();
223 <        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
222 >        await(pleaseInterrupt);
223 >        assertThreadStaysAlive(t);
224          t.interrupt();
225 <        awaitTermination(t, MEDIUM_DELAY_MS);
302 <        checkEmpty(q);
225 >        awaitTermination(t);
226      }
227  
228      /**
# Line 332 | Line 255 | public class LinkedTransferQueueTest ext
255      public void testTimedPoll() throws InterruptedException {
256          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
257          for (int i = 0; i < SIZE; ++i) {
258 <            long t0 = System.nanoTime();
259 <            assertEquals(i, (int) q.poll(SMALL_DELAY_MS, MILLISECONDS));
260 <            assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
261 <        }
262 <        long t0 = System.nanoTime();
263 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
264 <        assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
258 >            long startTime = System.nanoTime();
259 >            assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
260 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
261 >        }
262 >        long startTime = System.nanoTime();
263 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
264 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
265          checkEmpty(q);
266      }
267  
# Line 354 | Line 277 | public class LinkedTransferQueueTest ext
277                  for (int i = 0; i < SIZE; ++i) {
278                      long t0 = System.nanoTime();
279                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
280 <                    assertTrue(millisElapsedSince(t0) < SHORT_DELAY_MS);
280 >                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
281                  }
282 +                long t0 = System.nanoTime();
283                  aboutToWait.countDown();
284                  try {
285                      q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
286                      shouldThrow();
287 <                } catch (InterruptedException success) {}
287 >                } catch (InterruptedException success) {
288 >                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
289 >                }
290              }});
291  
292          aboutToWait.await();
# Line 382 | Line 308 | public class LinkedTransferQueueTest ext
308                  for (int i = 0; i < SIZE; ++i) {
309                      long t0 = System.nanoTime();
310                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
311 <                    assertTrue(millisElapsedSince(t0) < SHORT_DELAY_MS);
311 >                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
312                  }
313                  try {
314                      q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
# Line 441 | Line 367 | public class LinkedTransferQueueTest ext
367      }
368  
369      /**
444     * remove(x) removes x and returns true if present
445     */
446    public void testRemoveElement() throws InterruptedException {
447        LinkedTransferQueue q = populatedQueue(SIZE);
448        for (int i = 1; i < SIZE; i += 2) {
449            assertTrue(q.remove(i));
450        }
451        for (int i = 0; i < SIZE; i += 2) {
452            assertTrue(q.remove(i));
453            assertFalse(q.remove(i + 1));
454        }
455        checkEmpty(q);
456    }
457
458    /**
370       * An add following remove(x) succeeds
371       */
372      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 547 | Line 458 | public class LinkedTransferQueueTest ext
458      }
459  
460      /**
461 <     * toArray() contains all elements
461 >     * toArray() contains all elements in FIFO order
462       */
463 <    public void testToArray() throws InterruptedException {
463 >    public void testToArray() {
464          LinkedTransferQueue q = populatedQueue(SIZE);
465          Object[] o = q.toArray();
466          for (int i = 0; i < o.length; i++) {
467 <            assertEquals(o[i], q.take());
467 >            assertSame(o[i], q.poll());
468          }
469      }
470  
471      /**
472 <     * toArray(a) contains all elements
472 >     * toArray(a) contains all elements in FIFO order
473       */
474 <    public void testToArray2() throws InterruptedException {
474 >    public void testToArray2() {
475          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
476          Integer[] ints = new Integer[SIZE];
477 <        ints = q.toArray(ints);
477 >        Integer[] array = q.toArray(ints);
478 >        assertSame(ints, array);
479          for (int i = 0; i < ints.length; i++) {
480 <            assertEquals(ints[i], q.take());
480 >            assertSame(ints[i], q.poll());
481          }
482      }
483  
484      /**
485 <     * toArray(null) throws NullPointerException
574 <     */
575 <    public void testToArray_BadArg() {
576 <        LinkedTransferQueue q = populatedQueue(SIZE);
577 <        try {
578 <            Object o[] = q.toArray(null);
579 <            shouldThrow();
580 <        } catch (NullPointerException success) {}
581 <    }
582 <
583 <    /**
584 <     * toArray(incompatible array type) throws CCE
485 >     * toArray(incompatible array type) throws ArrayStoreException
486       */
487      public void testToArray1_BadArg() {
488          LinkedTransferQueue q = populatedQueue(SIZE);
489          try {
490 <            Object o[] = q.toArray(new String[10]);
490 >            q.toArray(new String[10]);
491              shouldThrow();
492          } catch (ArrayStoreException success) {}
493      }
# Line 663 | Line 564 | public class LinkedTransferQueueTest ext
564          LinkedTransferQueue q = populatedQueue(SIZE);
565          String s = q.toString();
566          for (int i = 0; i < SIZE; ++i) {
567 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
567 >            assertTrue(s.contains(String.valueOf(i)));
568          }
569      }
570  
# Line 672 | Line 573 | public class LinkedTransferQueueTest ext
573       */
574      public void testOfferInExecutor() {
575          final LinkedTransferQueue q = new LinkedTransferQueue();
576 <        final CountDownLatch threadsStarted = new CountDownLatch(2);
576 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
577          ExecutorService executor = Executors.newFixedThreadPool(2);
578  
579          executor.execute(new CheckedRunnable() {
580              public void realRun() throws InterruptedException {
680                threadsStarted.countDown();
581                  threadsStarted.await();
582 <                assertTrue(q.offer(one, MEDIUM_DELAY_MS, MILLISECONDS));
582 >                assertTrue(q.offer(one, LONG_DELAY_MS, MILLISECONDS));
583              }});
584  
585          executor.execute(new CheckedRunnable() {
586              public void realRun() throws InterruptedException {
687                threadsStarted.countDown();
587                  threadsStarted.await();
588                  assertSame(one, q.take());
589                  checkEmpty(q);
# Line 698 | Line 597 | public class LinkedTransferQueueTest ext
597       */
598      public void testPollInExecutor() {
599          final LinkedTransferQueue q = new LinkedTransferQueue();
600 <        final CountDownLatch threadsStarted = new CountDownLatch(2);
600 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
601          ExecutorService executor = Executors.newFixedThreadPool(2);
602  
603          executor.execute(new CheckedRunnable() {
604              public void realRun() throws InterruptedException {
605                  assertNull(q.poll());
707                threadsStarted.countDown();
606                  threadsStarted.await();
607 <                assertSame(one, q.poll(SMALL_DELAY_MS, MILLISECONDS));
607 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
608                  checkEmpty(q);
609              }});
610  
611          executor.execute(new CheckedRunnable() {
612              public void realRun() throws InterruptedException {
715                threadsStarted.countDown();
613                  threadsStarted.await();
614                  q.put(one);
615              }});
# Line 724 | Line 621 | public class LinkedTransferQueueTest ext
621       * A deserialized serialized queue has same elements in same order
622       */
623      public void testSerialization() throws Exception {
624 <        LinkedTransferQueue q = populatedQueue(SIZE);
625 <
729 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
730 <        ObjectOutputStream out
731 <            = new ObjectOutputStream(new BufferedOutputStream(bout));
732 <        out.writeObject(q);
733 <        out.close();
624 >        Queue x = populatedQueue(SIZE);
625 >        Queue y = serialClone(x);
626  
627 <        ByteArrayInputStream bin
628 <            = new ByteArrayInputStream(bout.toByteArray());
629 <        ObjectInputStream in
630 <            = new ObjectInputStream(new BufferedInputStream(bin));
631 <        LinkedTransferQueue r = (LinkedTransferQueue) in.readObject();
632 <
633 <        assertEquals(q.size(), r.size());
742 <        assertEquals(q.toString(), r.toString());
743 <        assertTrue(Arrays.equals(q.toArray(), r.toArray()));
744 <        while (!q.isEmpty()) {
745 <            assertEquals(q.remove(), r.remove());
627 >        assertNotSame(y, x);
628 >        assertEquals(x.size(), y.size());
629 >        assertEquals(x.toString(), y.toString());
630 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
631 >        while (!x.isEmpty()) {
632 >            assertFalse(y.isEmpty());
633 >            assertEquals(x.remove(), y.remove());
634          }
635 <    }
748 <
749 <    /**
750 <     * drainTo(null) throws NullPointerException
751 <     */
752 <    public void testDrainToNull() {
753 <        LinkedTransferQueue q = populatedQueue(SIZE);
754 <        try {
755 <            q.drainTo(null);
756 <            shouldThrow();
757 <        } catch (NullPointerException success) {}
758 <    }
759 <
760 <    /**
761 <     * drainTo(this) throws IllegalArgumentException
762 <     */
763 <    public void testDrainToSelf() {
764 <        LinkedTransferQueue q = populatedQueue(SIZE);
765 <        try {
766 <            q.drainTo(q);
767 <            shouldThrow();
768 <        } catch (IllegalArgumentException success) {}
635 >        assertTrue(y.isEmpty());
636      }
637  
638      /**
# Line 775 | Line 642 | public class LinkedTransferQueueTest ext
642          LinkedTransferQueue q = populatedQueue(SIZE);
643          ArrayList l = new ArrayList();
644          q.drainTo(l);
645 <        assertEquals(q.size(), 0);
646 <        assertEquals(l.size(), SIZE);
645 >        assertEquals(0, q.size());
646 >        assertEquals(SIZE, l.size());
647          for (int i = 0; i < SIZE; ++i) {
648 <            assertEquals(l.get(i), i);
648 >            assertEquals(i, l.get(i));
649          }
650          q.add(zero);
651          q.add(one);
# Line 787 | Line 654 | public class LinkedTransferQueueTest ext
654          assertTrue(q.contains(one));
655          l.clear();
656          q.drainTo(l);
657 <        assertEquals(q.size(), 0);
658 <        assertEquals(l.size(), 2);
657 >        assertEquals(0, q.size());
658 >        assertEquals(2, l.size());
659          for (int i = 0; i < 2; ++i) {
660 <            assertEquals(l.get(i), i);
660 >            assertEquals(i, l.get(i));
661          }
662      }
663  
# Line 806 | Line 673 | public class LinkedTransferQueueTest ext
673          ArrayList l = new ArrayList();
674          q.drainTo(l);
675          assertTrue(l.size() >= SIZE);
676 <        for (int i = 0; i < SIZE; ++i) {
677 <            assertEquals(l.get(i), i);
811 <        }
676 >        for (int i = 0; i < SIZE; ++i)
677 >            assertEquals(i, l.get(i));
678          awaitTermination(t, MEDIUM_DELAY_MS);
679          assertTrue(q.size() + l.size() >= SIZE);
680      }
681  
682      /**
817     * drainTo(null, n) throws NullPointerException
818     */
819    public void testDrainToNullN() {
820        LinkedTransferQueue q = populatedQueue(SIZE);
821        try {
822            q.drainTo(null, SIZE);
823            shouldThrow();
824        } catch (NullPointerException success) {}
825    }
826
827    /**
828     * drainTo(this, n) throws IllegalArgumentException
829     */
830    public void testDrainToSelfN() {
831        LinkedTransferQueue q = populatedQueue(SIZE);
832        try {
833            q.drainTo(q, SIZE);
834            shouldThrow();
835        } catch (IllegalArgumentException success) {}
836    }
837
838    /**
683       * drainTo(c, n) empties first min(n, size) elements of queue into c
684       */
685      public void testDrainToN() {
# Line 847 | Line 691 | public class LinkedTransferQueueTest ext
691              ArrayList l = new ArrayList();
692              q.drainTo(l, i);
693              int k = (i < SIZE) ? i : SIZE;
694 <            assertEquals(l.size(), k);
695 <            assertEquals(q.size(), SIZE - k);
696 <            for (int j = 0; j < k; ++j) {
697 <                assertEquals(l.get(j), j);
854 <            }
694 >            assertEquals(k, l.size());
695 >            assertEquals(SIZE - k, q.size());
696 >            for (int j = 0; j < k; ++j)
697 >                assertEquals(j, l.get(j));
698              while (q.poll() != null)
699                  ;
700          }
# Line 863 | Line 706 | public class LinkedTransferQueueTest ext
706       */
707      public void testWaitingConsumer() throws InterruptedException {
708          final LinkedTransferQueue q = new LinkedTransferQueue();
709 <        assertEquals(q.getWaitingConsumerCount(), 0);
709 >        assertEquals(0, q.getWaitingConsumerCount());
710          assertFalse(q.hasWaitingConsumer());
711          final CountDownLatch threadStarted = new CountDownLatch(1);
712  
# Line 871 | Line 714 | public class LinkedTransferQueueTest ext
714              public void realRun() throws InterruptedException {
715                  threadStarted.countDown();
716                  assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
717 <                assertEquals(q.getWaitingConsumerCount(), 0);
717 >                assertEquals(0, q.getWaitingConsumerCount());
718                  assertFalse(q.hasWaitingConsumer());
719              }});
720  
721          threadStarted.await();
722          waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
723 <        assertEquals(q.getWaitingConsumerCount(), 1);
723 >        assertEquals(1, q.getWaitingConsumerCount());
724          assertTrue(q.hasWaitingConsumer());
725  
726          assertTrue(q.offer(one));
727 <        assertEquals(q.getWaitingConsumerCount(), 0);
727 >        assertEquals(0, q.getWaitingConsumerCount());
728          assertFalse(q.hasWaitingConsumer());
729  
730          awaitTermination(t, MEDIUM_DELAY_MS);
# Line 910 | Line 753 | public class LinkedTransferQueueTest ext
753          Thread t = newStartedThread(new CheckedRunnable() {
754              public void realRun() throws InterruptedException {
755                  threadStarted.countDown();
756 <                q.transfer(SIZE);
756 >                q.transfer(five);
757                  checkEmpty(q);
758              }});
759  
760          threadStarted.await();
761          waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
919        assertTrue(t.isAlive());
762          assertEquals(1, q.size());
763 <        assertEquals(SIZE, (int) q.poll());
763 >        assertSame(five, q.poll());
764          checkEmpty(q);
765          awaitTermination(t, MEDIUM_DELAY_MS);
766      }
# Line 1069 | Line 911 | public class LinkedTransferQueueTest ext
911      }
912  
913      /**
914 <     * tryTransfer waits the amount given if interrupted, and
1073 <     * throws interrupted exception
914 >     * tryTransfer blocks interruptibly if no takers
915       */
916      public void testTryTransfer5() throws InterruptedException {
917          final LinkedTransferQueue q = new LinkedTransferQueue();
918 <        final CountDownLatch threadStarted = new CountDownLatch(1);
918 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
919 >        assertTrue(q.isEmpty());
920  
921          Thread t = newStartedThread(new CheckedRunnable() {
922              public void realRun() throws InterruptedException {
923 <                long t0 = System.nanoTime();
924 <                threadStarted.countDown();
923 >                Thread.currentThread().interrupt();
924 >                try {
925 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
926 >                    shouldThrow();
927 >                } catch (InterruptedException success) {}
928 >                assertFalse(Thread.interrupted());
929 >
930 >                pleaseInterrupt.countDown();
931                  try {
932                      q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
933                      shouldThrow();
934                  } catch (InterruptedException success) {}
935 <                assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
935 >                assertFalse(Thread.interrupted());
936              }});
937  
938 <        threadStarted.await();
939 <        Thread.sleep(SHORT_DELAY_MS);
938 >        await(pleaseInterrupt);
939 >        assertThreadStaysAlive(t);
940          t.interrupt();
941 <        awaitTermination(t, MEDIUM_DELAY_MS);
941 >        awaitTermination(t);
942          checkEmpty(q);
943      }
944  
# Line 1104 | Line 952 | public class LinkedTransferQueueTest ext
952              public void realRun() throws InterruptedException {
953                  long t0 = System.nanoTime();
954                  assertFalse(q.tryTransfer(new Object(),
955 <                                          SHORT_DELAY_MS, MILLISECONDS));
956 <                assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
955 >                                          timeoutMillis(), MILLISECONDS));
956 >                assertTrue(millisElapsedSince(t0) >= timeoutMillis());
957                  checkEmpty(q);
958              }});
959  
960 <        awaitTermination(t, MEDIUM_DELAY_MS);
960 >        awaitTermination(t);
961          checkEmpty(q);
962      }
963  
# Line 1137 | Line 985 | public class LinkedTransferQueueTest ext
985      }
986  
987      /**
988 <     * tryTransfer attempts to enqueue into the q and fails returning
989 <     * false not enqueueing and the successive poll is null
988 >     * tryTransfer attempts to enqueue into the queue and fails
989 >     * returning false not enqueueing and the successive poll is null
990       */
991      public void testTryTransfer8() throws InterruptedException {
992          final LinkedTransferQueue q = new LinkedTransferQueue();
993          assertTrue(q.offer(four));
994          assertEquals(1, q.size());
995          long t0 = System.nanoTime();
996 <        assertFalse(q.tryTransfer(five, SHORT_DELAY_MS, MILLISECONDS));
997 <        assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
996 >        assertFalse(q.tryTransfer(five, timeoutMillis(), MILLISECONDS));
997 >        assertTrue(millisElapsedSince(t0) >= timeoutMillis());
998          assertEquals(1, q.size());
999          assertSame(four, q.poll());
1000          assertNull(q.poll());
# Line 1164 | Line 1012 | public class LinkedTransferQueueTest ext
1012          assertFalse(q.isEmpty());
1013          return q;
1014      }
1015 +
1016 +    /**
1017 +     * remove(null), contains(null) always return false
1018 +     */
1019 +    public void testNeverContainsNull() {
1020 +        Collection<?>[] qs = {
1021 +            new LinkedTransferQueue<Object>(),
1022 +            populatedQueue(2),
1023 +        };
1024 +
1025 +        for (Collection<?> q : qs) {
1026 +            assertFalse(q.contains(null));
1027 +            assertFalse(q.remove(null));
1028 +        }
1029 +    }
1030   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines