ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/LinkedTransferQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/LinkedTransferQueueTest.java (file contents):
Revision 1.30 by jsr166, Thu Oct 28 22:20:47 2010 UTC vs.
Revision 1.53 by jsr166, Sun Nov 23 22:27:06 2014 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include John Vint
6   */
7  
8 < import java.io.BufferedInputStream;
9 < import java.io.BufferedOutputStream;
10 < import java.io.ByteArrayInputStream;
11 < import java.io.ByteArrayOutputStream;
12 < import java.io.ObjectInputStream;
13 < import java.io.ObjectOutputStream;
14 < import java.util.ArrayList;
8 > import junit.framework.*;
9   import java.util.Arrays;
10 + import java.util.ArrayList;
11 + import java.util.Collection;
12   import java.util.Iterator;
13   import java.util.List;
14   import java.util.NoSuchElementException;
15 < import java.util.concurrent.*;
15 > import java.util.Queue;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Executors;
19 > import java.util.concurrent.ExecutorService;
20 > import java.util.concurrent.LinkedTransferQueue;
21   import static java.util.concurrent.TimeUnit.MILLISECONDS;
22   import static java.util.concurrent.TimeUnit.NANOSECONDS;
22 import junit.framework.Test;
23 import junit.framework.TestSuite;
23  
24   @SuppressWarnings({"unchecked", "rawtypes"})
25   public class LinkedTransferQueueTest extends JSR166TestCase {
# Line 40 | Line 39 | public class LinkedTransferQueueTest ext
39                              new Generic().testSuite());
40      }
41  
43    void checkEmpty(LinkedTransferQueue q) throws InterruptedException {
44        assertTrue(q.isEmpty());
45        assertEquals(0, q.size());
46        assertNull(q.peek());
47        assertNull(q.poll());
48        assertNull(q.poll(0, MILLISECONDS));
49        assertEquals(q.toString(), "[]");
50        assertTrue(Arrays.equals(q.toArray(), new Object[0]));
51        assertFalse(q.iterator().hasNext());
52        try {
53            q.element();
54            shouldThrow();
55        } catch (NoSuchElementException success) {}
56        try {
57            q.iterator().next();
58            shouldThrow();
59        } catch (NoSuchElementException success) {}
60        try {
61            q.remove();
62            shouldThrow();
63        } catch (NoSuchElementException success) {}
64    }
65
42      /**
43       * Constructor builds new queue with size being zero and empty
44       * being true
# Line 88 | Line 64 | public class LinkedTransferQueueTest ext
64       * NullPointerException
65       */
66      public void testConstructor3() {
67 +        Collection<Integer> elements = Arrays.asList(new Integer[SIZE]);
68          try {
69 <            Integer[] ints = new Integer[SIZE];
93 <            new LinkedTransferQueue(Arrays.asList(ints));
69 >            new LinkedTransferQueue(elements);
70              shouldThrow();
71          } catch (NullPointerException success) {}
72      }
# Line 100 | Line 76 | public class LinkedTransferQueueTest ext
76       * throws NullPointerException
77       */
78      public void testConstructor4() {
79 +        Integer[] ints = new Integer[SIZE];
80 +        for (int i = 0; i < SIZE-1; ++i)
81 +            ints[i] = i;
82 +        Collection<Integer> elements = Arrays.asList(ints);
83          try {
84 <            Integer[] ints = new Integer[SIZE];
105 <            for (int i = 0; i < SIZE - 1; ++i) {
106 <                ints[i] = i;
107 <            }
108 <            new LinkedTransferQueue(Arrays.asList(ints));
84 >            new LinkedTransferQueue(elements);
85              shouldThrow();
86          } catch (NullPointerException success) {}
87      }
# Line 152 | Line 128 | public class LinkedTransferQueueTest ext
128      }
129  
130      /**
155     * offer(null) throws NullPointerException
156     */
157    public void testOfferNull() {
158        try {
159            LinkedTransferQueue q = new LinkedTransferQueue();
160            q.offer(null);
161            shouldThrow();
162        } catch (NullPointerException success) {}
163    }
164
165    /**
166     * add(null) throws NullPointerException
167     */
168    public void testAddNull() {
169        try {
170            LinkedTransferQueue q = new LinkedTransferQueue();
171            q.add(null);
172            shouldThrow();
173        } catch (NullPointerException success) {}
174    }
175
176    /**
177     * addAll(null) throws NullPointerException
178     */
179    public void testAddAll1() {
180        try {
181            LinkedTransferQueue q = new LinkedTransferQueue();
182            q.addAll(null);
183            shouldThrow();
184        } catch (NullPointerException success) {}
185    }
186
187    /**
131       * addAll(this) throws IllegalArgumentException
132       */
133      public void testAddAllSelf() {
# Line 196 | Line 139 | public class LinkedTransferQueueTest ext
139      }
140  
141      /**
199     * addAll of a collection with null elements throws NullPointerException
200     */
201    public void testAddAll2() {
202        try {
203            LinkedTransferQueue q = new LinkedTransferQueue();
204            Integer[] ints = new Integer[SIZE];
205            q.addAll(Arrays.asList(ints));
206            shouldThrow();
207        } catch (NullPointerException success) {}
208    }
209
210    /**
142       * addAll of a collection with any null elements throws
143       * NullPointerException after possibly adding some elements
144       */
# Line 241 | Line 172 | public class LinkedTransferQueueTest ext
172      }
173  
174      /**
244     * put(null) throws NullPointerException
245     */
246    public void testPutNull() throws InterruptedException {
247        try {
248            LinkedTransferQueue q = new LinkedTransferQueue();
249            q.put(null);
250            shouldThrow();
251        } catch (NullPointerException success) {}
252    }
253
254    /**
175       * all elements successfully put are contained
176       */
177      public void testPut() {
178          LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
179          for (int i = 0; i < SIZE; ++i) {
180 <            assertEquals(q.size(), i);
180 >            assertEquals(i, q.size());
181              q.put(i);
182              assertTrue(q.contains(i));
183          }
# Line 277 | Line 197 | public class LinkedTransferQueueTest ext
197       * take removes existing elements until empty, then blocks interruptibly
198       */
199      public void testBlockingTake() throws InterruptedException {
200 <        final LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
201 <        Thread t = new Thread(new CheckedRunnable() {
200 >        final BlockingQueue q = populatedQueue(SIZE);
201 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
202 >        Thread t = newStartedThread(new CheckedRunnable() {
203              public void realRun() throws InterruptedException {
204                  for (int i = 0; i < SIZE; ++i) {
205 <                    assertEquals(i, (int) q.take());
205 >                    assertEquals(i, q.take());
206                  }
207 +
208 +                Thread.currentThread().interrupt();
209                  try {
210                      q.take();
211                      shouldThrow();
212                  } catch (InterruptedException success) {}
213 +                assertFalse(Thread.interrupted());
214 +
215 +                pleaseInterrupt.countDown();
216 +                try {
217 +                    q.take();
218 +                    shouldThrow();
219 +                } catch (InterruptedException success) {}
220 +                assertFalse(Thread.interrupted());
221              }});
222  
223 <        t.start();
224 <        Thread.sleep(SHORT_DELAY_MS);
223 >        await(pleaseInterrupt);
224 >        assertThreadStaysAlive(t);
225          t.interrupt();
226 <        awaitTermination(t, MEDIUM_DELAY_MS);
296 <        checkEmpty(q);
226 >        awaitTermination(t);
227      }
228  
229      /**
# Line 326 | Line 256 | public class LinkedTransferQueueTest ext
256      public void testTimedPoll() throws InterruptedException {
257          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
258          for (int i = 0; i < SIZE; ++i) {
259 <            long t0 = System.nanoTime();
259 >            long startTime = System.nanoTime();
260              assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
261 <            assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
261 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
262          }
263 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
263 >        long startTime = System.nanoTime();
264 >        assertNull(q.poll(timeoutMillis(), MILLISECONDS));
265 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
266          checkEmpty(q);
267      }
268  
# Line 339 | Line 271 | public class LinkedTransferQueueTest ext
271       * returning timeout status
272       */
273      public void testInterruptedTimedPoll() throws InterruptedException {
274 <        final LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
274 >        final BlockingQueue<Integer> q = populatedQueue(SIZE);
275 >        final CountDownLatch aboutToWait = new CountDownLatch(1);
276          Thread t = newStartedThread(new CheckedRunnable() {
277              public void realRun() throws InterruptedException {
278                  for (int i = 0; i < SIZE; ++i) {
# Line 347 | Line 280 | public class LinkedTransferQueueTest ext
280                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
281                      assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
282                  }
283 +                long t0 = System.nanoTime();
284 +                aboutToWait.countDown();
285                  try {
286 <                    q.poll(LONG_DELAY_MS, MILLISECONDS);
286 >                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
287                      shouldThrow();
288 <                } catch (InterruptedException success) {}
288 >                } catch (InterruptedException success) {
289 >                    assertTrue(millisElapsedSince(t0) < MEDIUM_DELAY_MS);
290 >                }
291              }});
292  
293 <        Thread.sleep(SMALL_DELAY_MS);
293 >        aboutToWait.await();
294 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
295          t.interrupt();
296          awaitTermination(t, MEDIUM_DELAY_MS);
297          checkEmpty(q);
298      }
299  
300      /**
301 +     * timed poll after thread interrupted throws InterruptedException
302 +     * instead of returning timeout status
303 +     */
304 +    public void testTimedPollAfterInterrupt() throws InterruptedException {
305 +        final BlockingQueue<Integer> q = populatedQueue(SIZE);
306 +        Thread t = newStartedThread(new CheckedRunnable() {
307 +            public void realRun() throws InterruptedException {
308 +                Thread.currentThread().interrupt();
309 +                for (int i = 0; i < SIZE; ++i) {
310 +                    long t0 = System.nanoTime();
311 +                    assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
312 +                    assertTrue(millisElapsedSince(t0) < SMALL_DELAY_MS);
313 +                }
314 +                try {
315 +                    q.poll(MEDIUM_DELAY_MS, MILLISECONDS);
316 +                    shouldThrow();
317 +                } catch (InterruptedException success) {}
318 +            }});
319 +
320 +        awaitTermination(t, MEDIUM_DELAY_MS);
321 +        checkEmpty(q);
322 +    }
323 +
324 +    /**
325       * peek returns next element, or null if empty
326       */
327      public void testPeek() throws InterruptedException {
# Line 406 | Line 368 | public class LinkedTransferQueueTest ext
368      }
369  
370      /**
409     * remove(x) removes x and returns true if present
410     */
411    public void testRemoveElement() throws InterruptedException {
412        LinkedTransferQueue q = populatedQueue(SIZE);
413        for (int i = 1; i < SIZE; i += 2) {
414            assertTrue(q.remove(i));
415        }
416        for (int i = 0; i < SIZE; i += 2) {
417            assertTrue(q.remove(i));
418            assertFalse(q.remove(i + 1));
419        }
420        checkEmpty(q);
421    }
422
423    /**
371       * An add following remove(x) succeeds
372       */
373      public void testRemoveElementAndAdd() throws InterruptedException {
# Line 512 | Line 459 | public class LinkedTransferQueueTest ext
459      }
460  
461      /**
462 <     * toArray() contains all elements
462 >     * toArray() contains all elements in FIFO order
463       */
464 <    public void testToArray() throws InterruptedException {
464 >    public void testToArray() {
465          LinkedTransferQueue q = populatedQueue(SIZE);
466          Object[] o = q.toArray();
467          for (int i = 0; i < o.length; i++) {
468 <            assertEquals(o[i], q.take());
468 >            assertSame(o[i], q.poll());
469          }
470      }
471  
472      /**
473 <     * toArray(a) contains all elements
473 >     * toArray(a) contains all elements in FIFO order
474       */
475 <    public void testToArray2() throws InterruptedException {
475 >    public void testToArray2() {
476          LinkedTransferQueue<Integer> q = populatedQueue(SIZE);
477          Integer[] ints = new Integer[SIZE];
478 <        ints = q.toArray(ints);
478 >        Integer[] array = q.toArray(ints);
479 >        assertSame(ints, array);
480          for (int i = 0; i < ints.length; i++) {
481 <            assertEquals(ints[i], q.take());
481 >            assertSame(ints[i], q.poll());
482          }
483      }
484  
485      /**
486 <     * toArray(null) throws NullPointerException
539 <     */
540 <    public void testToArray_BadArg() {
541 <        LinkedTransferQueue q = populatedQueue(SIZE);
542 <        try {
543 <            Object o[] = q.toArray(null);
544 <            shouldThrow();
545 <        } catch (NullPointerException success) {}
546 <    }
547 <
548 <    /**
549 <     * toArray(incompatible array type) throws CCE
486 >     * toArray(incompatible array type) throws ArrayStoreException
487       */
488      public void testToArray1_BadArg() {
489          LinkedTransferQueue q = populatedQueue(SIZE);
490          try {
491 <            Object o[] = q.toArray(new String[10]);
491 >            q.toArray(new String[10]);
492              shouldThrow();
493          } catch (ArrayStoreException success) {}
494      }
# Line 628 | Line 565 | public class LinkedTransferQueueTest ext
565          LinkedTransferQueue q = populatedQueue(SIZE);
566          String s = q.toString();
567          for (int i = 0; i < SIZE; ++i) {
568 <            assertTrue(s.indexOf(String.valueOf(i)) >= 0);
568 >            assertTrue(s.contains(String.valueOf(i)));
569          }
570      }
571  
# Line 637 | Line 574 | public class LinkedTransferQueueTest ext
574       */
575      public void testOfferInExecutor() {
576          final LinkedTransferQueue q = new LinkedTransferQueue();
577 <        q.add(one);
641 <        q.add(two);
577 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
578          ExecutorService executor = Executors.newFixedThreadPool(2);
579  
580          executor.execute(new CheckedRunnable() {
581 <            public void realRun() {
582 <                assertTrue(q.offer(three, MEDIUM_DELAY_MS, MILLISECONDS));
581 >            public void realRun() throws InterruptedException {
582 >                threadsStarted.await();
583 >                assertTrue(q.offer(one, LONG_DELAY_MS, MILLISECONDS));
584              }});
585  
586          executor.execute(new CheckedRunnable() {
587              public void realRun() throws InterruptedException {
588 <                Thread.sleep(SMALL_DELAY_MS);
588 >                threadsStarted.await();
589                  assertSame(one, q.take());
590 +                checkEmpty(q);
591              }});
592  
593          joinPool(executor);
# Line 660 | Line 598 | public class LinkedTransferQueueTest ext
598       */
599      public void testPollInExecutor() {
600          final LinkedTransferQueue q = new LinkedTransferQueue();
601 +        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
602          ExecutorService executor = Executors.newFixedThreadPool(2);
603  
604          executor.execute(new CheckedRunnable() {
605              public void realRun() throws InterruptedException {
606                  assertNull(q.poll());
607 <                assertSame(one, q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
608 <                assertTrue(q.isEmpty());
607 >                threadsStarted.await();
608 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
609 >                checkEmpty(q);
610              }});
611  
612          executor.execute(new CheckedRunnable() {
613              public void realRun() throws InterruptedException {
614 <                Thread.sleep(SMALL_DELAY_MS);
614 >                threadsStarted.await();
615                  q.put(one);
616              }});
617  
# Line 682 | Line 622 | public class LinkedTransferQueueTest ext
622       * A deserialized serialized queue has same elements in same order
623       */
624      public void testSerialization() throws Exception {
625 <        LinkedTransferQueue q = populatedQueue(SIZE);
625 >        Queue x = populatedQueue(SIZE);
626 >        Queue y = serialClone(x);
627  
628 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
629 <        ObjectOutputStream out
630 <            = new ObjectOutputStream(new BufferedOutputStream(bout));
631 <        out.writeObject(q);
632 <        out.close();
633 <
634 <        ByteArrayInputStream bin
694 <            = new ByteArrayInputStream(bout.toByteArray());
695 <        ObjectInputStream in
696 <            = new ObjectInputStream(new BufferedInputStream(bin));
697 <        LinkedTransferQueue r = (LinkedTransferQueue) in.readObject();
698 <
699 <        assertEquals(q.size(), r.size());
700 <        while (!q.isEmpty()) {
701 <            assertEquals(q.remove(), r.remove());
628 >        assertNotSame(y, x);
629 >        assertEquals(x.size(), y.size());
630 >        assertEquals(x.toString(), y.toString());
631 >        assertTrue(Arrays.equals(x.toArray(), y.toArray()));
632 >        while (!x.isEmpty()) {
633 >            assertFalse(y.isEmpty());
634 >            assertEquals(x.remove(), y.remove());
635          }
636 <    }
704 <
705 <    /**
706 <     * drainTo(null) throws NullPointerException
707 <     */
708 <    public void testDrainToNull() {
709 <        LinkedTransferQueue q = populatedQueue(SIZE);
710 <        try {
711 <            q.drainTo(null);
712 <            shouldThrow();
713 <        } catch (NullPointerException success) {}
714 <    }
715 <
716 <    /**
717 <     * drainTo(this) throws IllegalArgumentException
718 <     */
719 <    public void testDrainToSelf() {
720 <        LinkedTransferQueue q = populatedQueue(SIZE);
721 <        try {
722 <            q.drainTo(q);
723 <            shouldThrow();
724 <        } catch (IllegalArgumentException success) {}
636 >        assertTrue(y.isEmpty());
637      }
638  
639      /**
# Line 731 | Line 643 | public class LinkedTransferQueueTest ext
643          LinkedTransferQueue q = populatedQueue(SIZE);
644          ArrayList l = new ArrayList();
645          q.drainTo(l);
646 <        assertEquals(q.size(), 0);
647 <        assertEquals(l.size(), SIZE);
646 >        assertEquals(0, q.size());
647 >        assertEquals(SIZE, l.size());
648          for (int i = 0; i < SIZE; ++i) {
649 <            assertEquals(l.get(i), i);
649 >            assertEquals(i, l.get(i));
650          }
651          q.add(zero);
652          q.add(one);
# Line 743 | Line 655 | public class LinkedTransferQueueTest ext
655          assertTrue(q.contains(one));
656          l.clear();
657          q.drainTo(l);
658 <        assertEquals(q.size(), 0);
659 <        assertEquals(l.size(), 2);
658 >        assertEquals(0, q.size());
659 >        assertEquals(2, l.size());
660          for (int i = 0; i < 2; ++i) {
661 <            assertEquals(l.get(i), i);
661 >            assertEquals(i, l.get(i));
662          }
663      }
664  
# Line 762 | Line 674 | public class LinkedTransferQueueTest ext
674          ArrayList l = new ArrayList();
675          q.drainTo(l);
676          assertTrue(l.size() >= SIZE);
677 <        for (int i = 0; i < SIZE; ++i) {
678 <            assertEquals(l.get(i), i);
767 <        }
677 >        for (int i = 0; i < SIZE; ++i)
678 >            assertEquals(i, l.get(i));
679          awaitTermination(t, MEDIUM_DELAY_MS);
680          assertTrue(q.size() + l.size() >= SIZE);
681      }
682  
683      /**
773     * drainTo(null, n) throws NullPointerException
774     */
775    public void testDrainToNullN() {
776        LinkedTransferQueue q = populatedQueue(SIZE);
777        try {
778            q.drainTo(null, SIZE);
779            shouldThrow();
780        } catch (NullPointerException success) {}
781    }
782
783    /**
784     * drainTo(this, n) throws IllegalArgumentException
785     */
786    public void testDrainToSelfN() {
787        LinkedTransferQueue q = populatedQueue(SIZE);
788        try {
789            q.drainTo(q, SIZE);
790            shouldThrow();
791        } catch (IllegalArgumentException success) {}
792    }
793
794    /**
684       * drainTo(c, n) empties first min(n, size) elements of queue into c
685       */
686      public void testDrainToN() {
# Line 803 | Line 692 | public class LinkedTransferQueueTest ext
692              ArrayList l = new ArrayList();
693              q.drainTo(l, i);
694              int k = (i < SIZE) ? i : SIZE;
695 <            assertEquals(l.size(), k);
696 <            assertEquals(q.size(), SIZE - k);
697 <            for (int j = 0; j < k; ++j) {
698 <                assertEquals(l.get(j), j);
810 <            }
695 >            assertEquals(k, l.size());
696 >            assertEquals(SIZE - k, q.size());
697 >            for (int j = 0; j < k; ++j)
698 >                assertEquals(j, l.get(j));
699              while (q.poll() != null)
700                  ;
701          }
# Line 819 | Line 707 | public class LinkedTransferQueueTest ext
707       */
708      public void testWaitingConsumer() throws InterruptedException {
709          final LinkedTransferQueue q = new LinkedTransferQueue();
710 <        assertEquals(q.getWaitingConsumerCount(), 0);
710 >        assertEquals(0, q.getWaitingConsumerCount());
711          assertFalse(q.hasWaitingConsumer());
712 +        final CountDownLatch threadStarted = new CountDownLatch(1);
713  
714          Thread t = newStartedThread(new CheckedRunnable() {
715              public void realRun() throws InterruptedException {
716 <                Thread.sleep(SMALL_DELAY_MS);
717 <                assertTrue(q.hasWaitingConsumer());
718 <                assertEquals(q.getWaitingConsumerCount(), 1);
830 <                assertTrue(q.offer(one));
716 >                threadStarted.countDown();
717 >                assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
718 >                assertEquals(0, q.getWaitingConsumerCount());
719                  assertFalse(q.hasWaitingConsumer());
832                assertEquals(q.getWaitingConsumerCount(), 0);
720              }});
721  
722 <        assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
723 <        assertEquals(q.getWaitingConsumerCount(), 0);
722 >        threadStarted.await();
723 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
724 >        assertEquals(1, q.getWaitingConsumerCount());
725 >        assertTrue(q.hasWaitingConsumer());
726 >
727 >        assertTrue(q.offer(one));
728 >        assertEquals(0, q.getWaitingConsumerCount());
729          assertFalse(q.hasWaitingConsumer());
730 +
731          awaitTermination(t, MEDIUM_DELAY_MS);
732      }
733  
# Line 856 | Line 749 | public class LinkedTransferQueueTest ext
749      public void testTransfer2() throws InterruptedException {
750          final LinkedTransferQueue<Integer> q
751              = new LinkedTransferQueue<Integer>();
752 +        final CountDownLatch threadStarted = new CountDownLatch(1);
753  
754          Thread t = newStartedThread(new CheckedRunnable() {
755              public void realRun() throws InterruptedException {
756 <                q.transfer(SIZE);
757 <                assertTrue(q.isEmpty());
756 >                threadStarted.countDown();
757 >                q.transfer(five);
758 >                checkEmpty(q);
759              }});
760  
761 <        Thread.sleep(SHORT_DELAY_MS);
761 >        threadStarted.await();
762 >        waitForThreadToEnterWaitState(t, SMALL_DELAY_MS);
763          assertEquals(1, q.size());
764 <        assertEquals(SIZE, (int) q.poll());
765 <        assertTrue(q.isEmpty());
764 >        assertSame(five, q.poll());
765 >        checkEmpty(q);
766          awaitTermination(t, MEDIUM_DELAY_MS);
767      }
768  
# Line 879 | Line 775 | public class LinkedTransferQueueTest ext
775  
776          Thread first = newStartedThread(new CheckedRunnable() {
777              public void realRun() throws InterruptedException {
778 <                Integer i = SIZE + 1;
779 <                q.transfer(i);
884 <                assertTrue(!q.contains(i));
778 >                q.transfer(four);
779 >                assertTrue(!q.contains(four));
780                  assertEquals(1, q.size());
781              }});
782  
783          Thread interruptedThread = newStartedThread(
784              new CheckedInterruptedRunnable() {
785                  public void realRun() throws InterruptedException {
786 <                    while (q.size() == 0)
786 >                    while (q.isEmpty())
787                          Thread.yield();
788 <                    q.transfer(SIZE);
788 >                    q.transfer(five);
789                  }});
790  
791          while (q.size() < 2)
792              Thread.yield();
793          assertEquals(2, q.size());
794 <        assertEquals(SIZE + 1, (int) q.poll());
794 >        assertSame(four, q.poll());
795          first.join();
796          assertEquals(1, q.size());
797          interruptedThread.interrupt();
798          interruptedThread.join();
799 <        assertEquals(0, q.size());
905 <        assertTrue(q.isEmpty());
799 >        checkEmpty(q);
800      }
801  
802      /**
# Line 919 | Line 813 | public class LinkedTransferQueueTest ext
813                  assertSame(three, q.poll());
814              }});
815  
816 <        Thread.sleep(SHORT_DELAY_MS);
816 >        while (q.isEmpty())
817 >            Thread.yield();
818 >        assertFalse(q.isEmpty());
819 >        assertEquals(1, q.size());
820          assertTrue(q.offer(three));
821          assertSame(four, q.poll());
822          awaitTermination(t, MEDIUM_DELAY_MS);
# Line 935 | Line 832 | public class LinkedTransferQueueTest ext
832  
833          Thread t = newStartedThread(new CheckedRunnable() {
834              public void realRun() throws InterruptedException {
835 <                q.transfer(SIZE);
835 >                q.transfer(four);
836                  checkEmpty(q);
837              }});
838  
839 <        Thread.sleep(SHORT_DELAY_MS);
840 <        assertEquals(SIZE, (int) q.take());
839 >        while (q.isEmpty())
840 >            Thread.yield();
841 >        assertFalse(q.isEmpty());
842 >        assertEquals(1, q.size());
843 >        assertSame(four, q.take());
844          checkEmpty(q);
845          awaitTermination(t, MEDIUM_DELAY_MS);
846      }
# Line 980 | Line 880 | public class LinkedTransferQueueTest ext
880                  while (! q.hasWaitingConsumer())
881                      Thread.yield();
882                  assertTrue(q.hasWaitingConsumer());
883 <                assertTrue(q.isEmpty());
984 <                assertEquals(q.size(), 0);
883 >                checkEmpty(q);
884                  assertTrue(q.tryTransfer(hotPotato));
885              }});
886  
# Line 1003 | Line 902 | public class LinkedTransferQueueTest ext
902                  while (! q.hasWaitingConsumer())
903                      Thread.yield();
904                  assertTrue(q.hasWaitingConsumer());
905 <                assertTrue(q.isEmpty());
1007 <                assertEquals(q.size(), 0);
905 >                checkEmpty(q);
906                  assertTrue(q.tryTransfer(hotPotato));
907              }});
908  
# Line 1014 | Line 912 | public class LinkedTransferQueueTest ext
912      }
913  
914      /**
915 <     * tryTransfer waits the amount given if interrupted, and
1018 <     * throws interrupted exception
915 >     * tryTransfer blocks interruptibly if no takers
916       */
917      public void testTryTransfer5() throws InterruptedException {
918          final LinkedTransferQueue q = new LinkedTransferQueue();
919 +        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
920 +        assertTrue(q.isEmpty());
921  
922 <        Thread toInterrupt = newStartedThread(new CheckedInterruptedRunnable() {
922 >        Thread t = newStartedThread(new CheckedRunnable() {
923              public void realRun() throws InterruptedException {
924 <                q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
924 >                Thread.currentThread().interrupt();
925 >                try {
926 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
927 >                    shouldThrow();
928 >                } catch (InterruptedException success) {}
929 >                assertFalse(Thread.interrupted());
930 >
931 >                pleaseInterrupt.countDown();
932 >                try {
933 >                    q.tryTransfer(new Object(), LONG_DELAY_MS, MILLISECONDS);
934 >                    shouldThrow();
935 >                } catch (InterruptedException success) {}
936 >                assertFalse(Thread.interrupted());
937              }});
938  
939 <        Thread.sleep(SMALL_DELAY_MS);
940 <        toInterrupt.interrupt();
941 <        toInterrupt.join();
939 >        await(pleaseInterrupt);
940 >        assertThreadStaysAlive(t);
941 >        t.interrupt();
942 >        awaitTermination(t);
943 >        checkEmpty(q);
944      }
945  
946      /**
947 <     * tryTransfer gives up after the timeout and return false
947 >     * tryTransfer gives up after the timeout and returns false
948       */
949      public void testTryTransfer6() throws InterruptedException {
950          final LinkedTransferQueue q = new LinkedTransferQueue();
# Line 1040 | Line 953 | public class LinkedTransferQueueTest ext
953              public void realRun() throws InterruptedException {
954                  long t0 = System.nanoTime();
955                  assertFalse(q.tryTransfer(new Object(),
956 <                                          SHORT_DELAY_MS, MILLISECONDS));
957 <                assertTrue(millisElapsedSince(t0) >= SHORT_DELAY_MS);
956 >                                          timeoutMillis(), MILLISECONDS));
957 >                assertTrue(millisElapsedSince(t0) >= timeoutMillis());
958 >                checkEmpty(q);
959              }});
960  
961 <        checkEmpty(q);
1048 <        awaitTermination(t, MEDIUM_DELAY_MS);
961 >        awaitTermination(t);
962          checkEmpty(q);
963      }
964  
# Line 1060 | Line 973 | public class LinkedTransferQueueTest ext
973          Thread t = newStartedThread(new CheckedRunnable() {
974              public void realRun() throws InterruptedException {
975                  assertTrue(q.tryTransfer(five, MEDIUM_DELAY_MS, MILLISECONDS));
976 <                assertTrue(q.isEmpty());
976 >                checkEmpty(q);
977              }});
978  
979 <        Thread.sleep(SHORT_DELAY_MS);
979 >        while (q.size() != 2)
980 >            Thread.yield();
981          assertEquals(2, q.size());
982          assertSame(four, q.poll());
983          assertSame(five, q.poll());
# Line 1072 | Line 986 | public class LinkedTransferQueueTest ext
986      }
987  
988      /**
989 <     * tryTransfer attempts to enqueue into the q and fails returning
990 <     * false not enqueueing and the successive poll is null
989 >     * tryTransfer attempts to enqueue into the queue and fails
990 >     * returning false not enqueueing and the successive poll is null
991       */
992      public void testTryTransfer8() throws InterruptedException {
993          final LinkedTransferQueue q = new LinkedTransferQueue();
994          assertTrue(q.offer(four));
995          assertEquals(1, q.size());
996 <        assertFalse(q.tryTransfer(five, SHORT_DELAY_MS, MILLISECONDS));
996 >        long t0 = System.nanoTime();
997 >        assertFalse(q.tryTransfer(five, timeoutMillis(), MILLISECONDS));
998 >        assertTrue(millisElapsedSince(t0) >= timeoutMillis());
999          assertEquals(1, q.size());
1000          assertSame(four, q.poll());
1001          assertNull(q.poll());
# Line 1088 | Line 1004 | public class LinkedTransferQueueTest ext
1004  
1005      private LinkedTransferQueue<Integer> populatedQueue(int n) {
1006          LinkedTransferQueue<Integer> q = new LinkedTransferQueue<Integer>();
1007 <        assertTrue(q.isEmpty());
1007 >        checkEmpty(q);
1008          for (int i = 0; i < n; i++) {
1009              assertEquals(i, q.size());
1010              assertTrue(q.offer(i));
# Line 1097 | Line 1013 | public class LinkedTransferQueueTest ext
1013          assertFalse(q.isEmpty());
1014          return q;
1015      }
1016 +
1017 +    /**
1018 +     * remove(null), contains(null) always return false
1019 +     */
1020 +    public void testNeverContainsNull() {
1021 +        Collection<?>[] qs = {
1022 +            new LinkedTransferQueue<Object>(),
1023 +            populatedQueue(2),
1024 +        };
1025 +
1026 +        for (Collection<?> q : qs) {
1027 +            assertFalse(q.contains(null));
1028 +            assertFalse(q.remove(null));
1029 +        }
1030 +    }
1031   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines