ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ReentrantReadWriteLockTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ReentrantReadWriteLockTest.java (file contents):
Revision 1.64 by jsr166, Tue May 24 23:40:14 2011 UTC vs.
Revision 1.78 by jsr166, Fri Jul 3 05:48:30 2015 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 – import junit.framework.*;
10 – import java.util.concurrent.atomic.AtomicBoolean;
11 – import java.util.concurrent.locks.*;
12 – import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
11 < import java.util.*;
10 >
11 > import java.util.Arrays;
12 > import java.util.Collection;
13 > import java.util.HashSet;
14 > import java.util.concurrent.CountDownLatch;
15 > import java.util.concurrent.atomic.AtomicBoolean;
16 > import java.util.concurrent.locks.Condition;
17 > import java.util.concurrent.locks.Lock;
18 > import java.util.concurrent.locks.ReentrantReadWriteLock;
19 >
20 > import junit.framework.AssertionFailedError;
21 > import junit.framework.Test;
22 > import junit.framework.TestSuite;
23  
24   public class ReentrantReadWriteLockTest extends JSR166TestCase {
25      public static void main(String[] args) {
26 <        junit.textui.TestRunner.run(suite());
26 >        main(suite(), args);
27      }
28      public static Test suite() {
29          return new TestSuite(ReentrantReadWriteLockTest.class);
# Line 84 | Line 91 | public class ReentrantReadWriteLockTest
91              Thread.yield();
92          }
93          assertTrue(t.isAlive());
94 <        assertTrue(lock.getOwner() != t);
94 >        assertNotSame(t, lock.getOwner());
95      }
96  
97      /**
# Line 145 | Line 152 | public class ReentrantReadWriteLockTest
152          lock.writeLock().unlock();
153      }
154  
155 <    enum AwaitMethod { await, awaitTimed, awaitNanos, awaitUntil };
155 >    enum AwaitMethod { await, awaitTimed, awaitNanos, awaitUntil }
156  
157      /**
158 <     * Awaits condition using the specified AwaitMethod.
158 >     * Awaits condition "indefinitely" using the specified AwaitMethod.
159       */
160      void await(Condition c, AwaitMethod awaitMethod)
161              throws InterruptedException {
162 +        long timeoutMillis = 2 * LONG_DELAY_MS;
163          switch (awaitMethod) {
164          case await:
165              c.await();
166              break;
167          case awaitTimed:
168 <            assertTrue(c.await(2 * LONG_DELAY_MS, MILLISECONDS));
168 >            assertTrue(c.await(timeoutMillis, MILLISECONDS));
169              break;
170          case awaitNanos:
171 <            long nanosRemaining = c.awaitNanos(MILLISECONDS.toNanos(2 * LONG_DELAY_MS));
172 <            assertTrue(nanosRemaining > 0);
171 >            long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis);
172 >            long nanosRemaining = c.awaitNanos(timeoutNanos);
173 >            assertTrue(nanosRemaining > timeoutNanos / 2);
174 >            assertTrue(nanosRemaining <= timeoutNanos);
175              break;
176          case awaitUntil:
177 <            java.util.Date d = new java.util.Date();
168 <            assertTrue(c.awaitUntil(new java.util.Date(d.getTime() + 2 * LONG_DELAY_MS)));
177 >            assertTrue(c.awaitUntil(delayedDate(timeoutMillis)));
178              break;
179 +        default:
180 +            throw new AssertionError();
181          }
182      }
183  
# Line 227 | Line 238 | public class ReentrantReadWriteLockTest
238          }
239          for (int i = SIZE; i > 0; i--) {
240              lock.writeLock().unlock();
241 <            assertEquals(i-1,lock.getWriteHoldCount());
241 >            assertEquals(i - 1,lock.getWriteHoldCount());
242          }
243      }
244  
# Line 244 | Line 255 | public class ReentrantReadWriteLockTest
255          }
256          for (int i = SIZE; i > 0; i--) {
257              lock.writeLock().unlock();
258 <            assertEquals(i-1,lock.writeLock().getHoldCount());
258 >            assertEquals(i - 1,lock.writeLock().getHoldCount());
259          }
260      }
261  
# Line 261 | Line 272 | public class ReentrantReadWriteLockTest
272          }
273          for (int i = SIZE; i > 0; i--) {
274              lock.readLock().unlock();
275 <            assertEquals(i-1,lock.getReadHoldCount());
275 >            assertEquals(i - 1,lock.getReadHoldCount());
276          }
277      }
278  
# Line 821 | Line 832 | public class ReentrantReadWriteLockTest
832              new PublicReentrantReadWriteLock(fair);
833          try {
834              lock.writeLock().lockInterruptibly();
835 <        } catch (InterruptedException ie) {
825 <            threadUnexpectedException(ie);
826 <        }
835 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
836          Thread t = newStartedThread(new CheckedInterruptedRunnable() {
837              public void realRun() throws InterruptedException {
838                  lock.writeLock().lockInterruptibly();
# Line 848 | Line 857 | public class ReentrantReadWriteLockTest
857              lock.readLock().lockInterruptibly();
858              lock.readLock().unlock();
859              lock.writeLock().lockInterruptibly();
860 <        } catch (InterruptedException ie) {
852 <            threadUnexpectedException(ie);
853 <        }
860 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
861          Thread t = newStartedThread(new CheckedInterruptedRunnable() {
862              public void realRun() throws InterruptedException {
863                  lock.readLock().lockInterruptibly();
# Line 876 | Line 883 | public class ReentrantReadWriteLockTest
883                  await(c, awaitMethod);
884                  shouldThrow();
885              } catch (IllegalMonitorStateException success) {
886 <            } catch (InterruptedException e) { threadUnexpectedException(e); }
886 >            } catch (InterruptedException fail) {
887 >                threadUnexpectedException(fail);
888 >            }
889              assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
890          }
891      }
# Line 927 | Line 936 | public class ReentrantReadWriteLockTest
936              assertTrue(nanosRemaining <= 0);
937              assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
938              lock.writeLock().unlock();
939 <        } catch (InterruptedException e) {
931 <            threadUnexpectedException(e);
932 <        }
939 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
940      }
941  
942      /**
# Line 948 | Line 955 | public class ReentrantReadWriteLockTest
955              assertFalse(c.await(timeoutMillis, MILLISECONDS));
956              assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
957              lock.writeLock().unlock();
958 <        } catch (InterruptedException e) {
952 <            threadUnexpectedException(e);
953 <        }
958 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
959      }
960  
961      /**
# Line 964 | Line 969 | public class ReentrantReadWriteLockTest
969                  new ReentrantReadWriteLock(fair);
970              final Condition c = lock.writeLock().newCondition();
971              lock.writeLock().lock();
972 <            long startTime = System.nanoTime();
973 <            long timeoutMillis = 10;
974 <            java.util.Date d = new java.util.Date();
975 <            assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + timeoutMillis)));
976 <            assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
972 >            // We shouldn't assume that nanoTime and currentTimeMillis
973 >            // use the same time source, so don't use nanoTime here.
974 >            java.util.Date delayedDate = delayedDate(timeoutMillis());
975 >            assertFalse(c.awaitUntil(delayedDate));
976 >            assertTrue(new java.util.Date().getTime() >= delayedDate.getTime());
977              lock.writeLock().unlock();
978 <        } catch (InterruptedException e) {
974 <            threadUnexpectedException(e);
975 <        }
978 >        } catch (InterruptedException fail) { threadUnexpectedException(fail); }
979      }
980  
981      /**
# Line 1004 | Line 1007 | public class ReentrantReadWriteLockTest
1007      }
1008  
1009      /**
1010 <     * awaitUninterruptibly doesn't abort on interrupt
1010 >     * awaitUninterruptibly is uninterruptible
1011       */
1012      public void testAwaitUninterruptibly()      { testAwaitUninterruptibly(false); }
1013      public void testAwaitUninterruptibly_fair() { testAwaitUninterruptibly(true); }
1014      public void testAwaitUninterruptibly(boolean fair) {
1015          final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair);
1016          final Condition c = lock.writeLock().newCondition();
1017 <        final CountDownLatch locked = new CountDownLatch(1);
1018 <        Thread t = newStartedThread(new CheckedRunnable() {
1017 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(2);
1018 >
1019 >        Thread t1 = newStartedThread(new CheckedRunnable() {
1020              public void realRun() {
1021 +                // Interrupt before awaitUninterruptibly
1022                  lock.writeLock().lock();
1023 <                locked.countDown();
1023 >                pleaseInterrupt.countDown();
1024 >                Thread.currentThread().interrupt();
1025                  c.awaitUninterruptibly();
1026                  assertTrue(Thread.interrupted());
1027                  lock.writeLock().unlock();
1028              }});
1029  
1030 <        await(locked);
1030 >        Thread t2 = newStartedThread(new CheckedRunnable() {
1031 >            public void realRun() {
1032 >                // Interrupt during awaitUninterruptibly
1033 >                lock.writeLock().lock();
1034 >                pleaseInterrupt.countDown();
1035 >                c.awaitUninterruptibly();
1036 >                assertTrue(Thread.interrupted());
1037 >                lock.writeLock().unlock();
1038 >            }});
1039 >
1040 >        await(pleaseInterrupt);
1041          lock.writeLock().lock();
1042          lock.writeLock().unlock();
1043 <        t.interrupt();
1044 <        long timeoutMillis = 10;
1045 <        assertThreadStaysAlive(t, timeoutMillis);
1043 >        t2.interrupt();
1044 >
1045 >        assertThreadStaysAlive(t1);
1046 >        assertTrue(t2.isAlive());
1047 >
1048          lock.writeLock().lock();
1049 <        c.signal();
1049 >        c.signalAll();
1050          lock.writeLock().unlock();
1051 <        awaitTermination(t);
1051 >
1052 >        awaitTermination(t1);
1053 >        awaitTermination(t2);
1054      }
1055  
1056      /**

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines