ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/SplittableRandomTest.java
(Generate patch)

Comparing jsr166/src/test/tck/SplittableRandomTest.java (file contents):
Revision 1.9 by jsr166, Tue Sep 24 06:35:35 2013 UTC vs.
Revision 1.10 by jsr166, Tue Sep 24 15:29:18 2013 UTC

# Line 145 | Line 145 | public class SplittableRandomTest extend
145       */
146      public void testNextIntBadBounds() {
147          SplittableRandom sr = new SplittableRandom();
148 <        try {
149 <            int f = sr.nextInt(17, 2);
150 <            shouldThrow();
151 <        } catch (IllegalArgumentException success) {}
148 >        Runnable[] throwingActions = {
149 >            () -> sr.nextInt(17, 2),
150 >            () -> sr.nextInt(-42, -42),
151 >            () -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE),
152 >        };
153 >        assertThrows(IllegalArgumentException.class, throwingActions);
154      }
155  
156      /**
# Line 212 | Line 214 | public class SplittableRandomTest extend
214       */
215      public void testNextLongBadBounds() {
216          SplittableRandom sr = new SplittableRandom();
217 <        try {
218 <            long f = sr.nextLong(17, 2);
219 <            shouldThrow();
220 <        } catch (IllegalArgumentException success) {}
217 >        Runnable[] throwingActions = {
218 >            () -> sr.nextLong(17L, 2L),
219 >            () -> sr.nextLong(-42L, -42L),
220 >            () -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE),
221 >        };
222 >        assertThrows(IllegalArgumentException.class, throwingActions);
223      }
224  
225      /**
# Line 276 | Line 280 | public class SplittableRandomTest extend
280      }
281  
282      /**
283 +     * nextDouble(! (least < bound)) throws IllegalArgumentException
284 +     */
285 +    public void testNextDoubleBadBounds() {
286 +        SplittableRandom sr = new SplittableRandom();
287 +        Runnable[] throwingActions = {
288 +            () -> sr.nextDouble(17.0d, 2.0d),
289 +            () -> sr.nextDouble(-42.0d, -42.0d),
290 +            () -> sr.nextDouble(Double.MAX_VALUE, Double.MIN_VALUE),
291 +            () -> sr.nextDouble(Double.NaN, 0.0d),
292 +            () -> sr.nextDouble(0.0d, Double.NaN),
293 +        };
294 +        assertThrows(IllegalArgumentException.class, throwingActions);
295 +    }
296 +
297 +    // TODO: Test infinite bounds!
298 +    //() -> sr.nextDouble(Double.NEGATIVE_INFINITY, 0.0d),
299 +    //() -> sr.nextDouble(0.0d, Double.POSITIVE_INFINITY),
300 +
301 +    /**
302       * nextDouble(least, bound) returns least <= value < bound;
303       * repeated calls produce at least two distinct results
304       */

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines