ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ThreadPoolExecutorTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ThreadPoolExecutorTest.java (file contents):
Revision 1.6 by dl, Thu Sep 25 11:02:41 2003 UTC vs.
Revision 1.90 by jsr166, Sun Oct 4 03:07:31 2015 UTC

# Line 1 | Line 1
1   /*
2 < * Written by members of JCP JSR-166 Expert Group and released to the
3 < * public domain. Use, modify, and redistribute this code in any way
4 < * without acknowledgement. Other contributors include Andrew Wright,
5 < * Jeffrey Hayes, Pat Fischer, Mike Judd.
2 > * Written by Doug Lea with assistance from members of JCP JSR-166
3 > * Expert Group and released to the public domain, as explained at
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5 > * Other contributors include Andrew Wright, Jeffrey Hayes,
6 > * Pat Fisher, Mike Judd.
7   */
8  
9 < import java.util.concurrent.*;
10 < import junit.framework.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 > import static java.util.concurrent.TimeUnit.NANOSECONDS;
11 > import static java.util.concurrent.TimeUnit.SECONDS;
12 >
13 > import java.util.ArrayList;
14   import java.util.List;
15 + import java.util.concurrent.ArrayBlockingQueue;
16 + import java.util.concurrent.BlockingQueue;
17 + import java.util.concurrent.Callable;
18 + import java.util.concurrent.CancellationException;
19 + import java.util.concurrent.CountDownLatch;
20 + import java.util.concurrent.ExecutionException;
21 + import java.util.concurrent.Executors;
22 + import java.util.concurrent.ExecutorService;
23 + import java.util.concurrent.Future;
24 + import java.util.concurrent.FutureTask;
25 + import java.util.concurrent.LinkedBlockingQueue;
26 + import java.util.concurrent.RejectedExecutionException;
27 + import java.util.concurrent.RejectedExecutionHandler;
28 + import java.util.concurrent.SynchronousQueue;
29 + import java.util.concurrent.ThreadFactory;
30 + import java.util.concurrent.ThreadPoolExecutor;
31 + import java.util.concurrent.TimeUnit;
32 + import java.util.concurrent.atomic.AtomicInteger;
33 +
34 + import junit.framework.Test;
35 + import junit.framework.TestSuite;
36  
37   public class ThreadPoolExecutorTest extends JSR166TestCase {
38      public static void main(String[] args) {
39 <        junit.textui.TestRunner.run (suite());  
39 >        main(suite(), args);
40      }
41      public static Test suite() {
42          return new TestSuite(ThreadPoolExecutorTest.class);
43      }
44 <    
45 <    /**
46 <     * For use as ThreadFactory in constructors
47 <     */
48 <    static class MyThreadFactory implements ThreadFactory{
49 <        public Thread newThread(Runnable r){
44 >
45 >    static class ExtendedTPE extends ThreadPoolExecutor {
46 >        final CountDownLatch beforeCalled = new CountDownLatch(1);
47 >        final CountDownLatch afterCalled = new CountDownLatch(1);
48 >        final CountDownLatch terminatedCalled = new CountDownLatch(1);
49 >
50 >        public ExtendedTPE() {
51 >            super(1, 1, LONG_DELAY_MS, MILLISECONDS, new SynchronousQueue<Runnable>());
52 >        }
53 >        protected void beforeExecute(Thread t, Runnable r) {
54 >            beforeCalled.countDown();
55 >        }
56 >        protected void afterExecute(Runnable r, Throwable t) {
57 >            afterCalled.countDown();
58 >        }
59 >        protected void terminated() {
60 >            terminatedCalled.countDown();
61 >        }
62 >
63 >        public boolean beforeCalled() {
64 >            return beforeCalled.getCount() == 0;
65 >        }
66 >        public boolean afterCalled() {
67 >            return afterCalled.getCount() == 0;
68 >        }
69 >        public boolean terminatedCalled() {
70 >            return terminatedCalled.getCount() == 0;
71 >        }
72 >    }
73 >
74 >    static class FailingThreadFactory implements ThreadFactory {
75 >        int calls = 0;
76 >        public Thread newThread(Runnable r) {
77 >            if (++calls > 1) return null;
78              return new Thread(r);
79 <        }  
79 >        }
80      }
81  
82      /**
83 <     * For use as RejectedExecutionHandler in constructors
83 >     * execute successfully executes a runnable
84       */
85 <    static class MyREHandler implements RejectedExecutionHandler{
86 <        public void rejectedExecution(Runnable r, ThreadPoolExecutor executor){}
85 >    public void testExecute() throws InterruptedException {
86 >        final ThreadPoolExecutor p =
87 >            new ThreadPoolExecutor(1, 1,
88 >                                   LONG_DELAY_MS, MILLISECONDS,
89 >                                   new ArrayBlockingQueue<Runnable>(10));
90 >        try (PoolCleaner cleaner = cleaner(p)) {
91 >            final CountDownLatch done = new CountDownLatch(1);
92 >            final Runnable task = new CheckedRunnable() {
93 >                public void realRun() { done.countDown(); }};
94 >            p.execute(task);
95 >            assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
96 >        }
97 >    }
98 >
99 >    /**
100 >     * getActiveCount increases but doesn't overestimate, when a
101 >     * thread becomes active
102 >     */
103 >    public void testGetActiveCount() throws InterruptedException {
104 >        final ThreadPoolExecutor p =
105 >            new ThreadPoolExecutor(2, 2,
106 >                                   LONG_DELAY_MS, MILLISECONDS,
107 >                                   new ArrayBlockingQueue<Runnable>(10));
108 >        try (PoolCleaner cleaner = cleaner(p)) {
109 >            final CountDownLatch threadStarted = new CountDownLatch(1);
110 >            final CountDownLatch done = new CountDownLatch(1);
111 >            assertEquals(0, p.getActiveCount());
112 >            p.execute(new CheckedRunnable() {
113 >                public void realRun() throws InterruptedException {
114 >                    threadStarted.countDown();
115 >                    assertEquals(1, p.getActiveCount());
116 >                    done.await();
117 >                }});
118 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
119 >            assertEquals(1, p.getActiveCount());
120 >            done.countDown();
121 >        }
122 >    }
123 >
124 >    /**
125 >     * prestartCoreThread starts a thread if under corePoolSize, else doesn't
126 >     */
127 >    public void testPrestartCoreThread() {
128 >        final ThreadPoolExecutor p =
129 >            new ThreadPoolExecutor(2, 6,
130 >                                   LONG_DELAY_MS, MILLISECONDS,
131 >                                   new ArrayBlockingQueue<Runnable>(10));
132 >        try (PoolCleaner cleaner = cleaner(p)) {
133 >            assertEquals(0, p.getPoolSize());
134 >            assertTrue(p.prestartCoreThread());
135 >            assertEquals(1, p.getPoolSize());
136 >            assertTrue(p.prestartCoreThread());
137 >            assertEquals(2, p.getPoolSize());
138 >            assertFalse(p.prestartCoreThread());
139 >            assertEquals(2, p.getPoolSize());
140 >            p.setCorePoolSize(4);
141 >            assertTrue(p.prestartCoreThread());
142 >            assertEquals(3, p.getPoolSize());
143 >            assertTrue(p.prestartCoreThread());
144 >            assertEquals(4, p.getPoolSize());
145 >            assertFalse(p.prestartCoreThread());
146 >            assertEquals(4, p.getPoolSize());
147 >        }
148 >    }
149 >
150 >    /**
151 >     * prestartAllCoreThreads starts all corePoolSize threads
152 >     */
153 >    public void testPrestartAllCoreThreads() {
154 >        final ThreadPoolExecutor p =
155 >            new ThreadPoolExecutor(2, 6,
156 >                                   LONG_DELAY_MS, MILLISECONDS,
157 >                                   new ArrayBlockingQueue<Runnable>(10));
158 >        try (PoolCleaner cleaner = cleaner(p)) {
159 >            assertEquals(0, p.getPoolSize());
160 >            p.prestartAllCoreThreads();
161 >            assertEquals(2, p.getPoolSize());
162 >            p.prestartAllCoreThreads();
163 >            assertEquals(2, p.getPoolSize());
164 >            p.setCorePoolSize(4);
165 >            p.prestartAllCoreThreads();
166 >            assertEquals(4, p.getPoolSize());
167 >            p.prestartAllCoreThreads();
168 >            assertEquals(4, p.getPoolSize());
169 >        }
170 >    }
171 >
172 >    /**
173 >     * getCompletedTaskCount increases, but doesn't overestimate,
174 >     * when tasks complete
175 >     */
176 >    public void testGetCompletedTaskCount() throws InterruptedException {
177 >        final ThreadPoolExecutor p =
178 >            new ThreadPoolExecutor(2, 2,
179 >                                   LONG_DELAY_MS, MILLISECONDS,
180 >                                   new ArrayBlockingQueue<Runnable>(10));
181 >        try (PoolCleaner cleaner = cleaner(p)) {
182 >            final CountDownLatch threadStarted = new CountDownLatch(1);
183 >            final CountDownLatch threadProceed = new CountDownLatch(1);
184 >            final CountDownLatch threadDone = new CountDownLatch(1);
185 >            assertEquals(0, p.getCompletedTaskCount());
186 >            p.execute(new CheckedRunnable() {
187 >                public void realRun() throws InterruptedException {
188 >                    threadStarted.countDown();
189 >                    assertEquals(0, p.getCompletedTaskCount());
190 >                    threadProceed.await();
191 >                    threadDone.countDown();
192 >                }});
193 >            await(threadStarted);
194 >            assertEquals(0, p.getCompletedTaskCount());
195 >            threadProceed.countDown();
196 >            threadDone.await();
197 >            long startTime = System.nanoTime();
198 >            while (p.getCompletedTaskCount() != 1) {
199 >                if (millisElapsedSince(startTime) > LONG_DELAY_MS)
200 >                    fail("timed out");
201 >                Thread.yield();
202 >            }
203 >        }
204      }
205 <
205 >
206      /**
207 <     *   execute successfully executes a runnable
207 >     * getCorePoolSize returns size given in constructor if not otherwise set
208       */
209 <    public void testExecute() {
210 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
211 <        try {
212 <            p1.execute(new Runnable() {
213 <                    public void run() {
214 <                        try {
215 <                            Thread.sleep(SHORT_DELAY_MS);
216 <                        } catch(InterruptedException e){
47 <                            threadUnexpectedException();
48 <                        }
49 <                    }
50 <                });
51 <            Thread.sleep(SMALL_DELAY_MS);
52 <        } catch(InterruptedException e){
53 <            unexpectedException();
54 <        }
55 <        joinPool(p1);
209 >    public void testGetCorePoolSize() {
210 >        final ThreadPoolExecutor p =
211 >            new ThreadPoolExecutor(1, 1,
212 >                                   LONG_DELAY_MS, MILLISECONDS,
213 >                                   new ArrayBlockingQueue<Runnable>(10));
214 >        try (PoolCleaner cleaner = cleaner(p)) {
215 >            assertEquals(1, p.getCorePoolSize());
216 >        }
217      }
218  
219      /**
220 <     *  getActiveCount increases but doesn't overestimate, when a
60 <     *  thread becomes active
220 >     * getKeepAliveTime returns value given in constructor if not otherwise set
221       */
222 <    public void testGetActiveCount() {
223 <        ThreadPoolExecutor p2 = new ThreadPoolExecutor(2, 2, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
224 <        assertEquals(0, p2.getActiveCount());
225 <        p2.execute(new MediumRunnable());
226 <        try {
227 <            Thread.sleep(SHORT_DELAY_MS);
228 <        } catch(Exception e){
69 <            unexpectedException();
222 >    public void testGetKeepAliveTime() {
223 >        final ThreadPoolExecutor p =
224 >            new ThreadPoolExecutor(2, 2,
225 >                                   1000, MILLISECONDS,
226 >                                   new ArrayBlockingQueue<Runnable>(10));
227 >        try (PoolCleaner cleaner = cleaner(p)) {
228 >            assertEquals(1, p.getKeepAliveTime(SECONDS));
229          }
71        assertEquals(1, p2.getActiveCount());
72        joinPool(p2);
230      }
231 <    
231 >
232      /**
233 <     *   getCompletedTaskCount increases, but doesn't overestimate,
77 <     *   when tasks complete
233 >     * getThreadFactory returns factory in constructor if not set
234       */
235 <    public void testGetCompletedTaskCount() {
236 <        ThreadPoolExecutor p2 = new ThreadPoolExecutor(2, 2, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
237 <        assertEquals(0, p2.getCompletedTaskCount());
238 <        p2.execute(new ShortRunnable());
239 <        try {
240 <            Thread.sleep(MEDIUM_DELAY_MS);
241 <        } catch(Exception e){
242 <            unexpectedException();
235 >    public void testGetThreadFactory() {
236 >        ThreadFactory threadFactory = new SimpleThreadFactory();
237 >        final ThreadPoolExecutor p =
238 >            new ThreadPoolExecutor(1, 2,
239 >                                   LONG_DELAY_MS, MILLISECONDS,
240 >                                   new ArrayBlockingQueue<Runnable>(10),
241 >                                   threadFactory,
242 >                                   new NoOpREHandler());
243 >        try (PoolCleaner cleaner = cleaner(p)) {
244 >            assertSame(threadFactory, p.getThreadFactory());
245          }
88        assertEquals(1, p2.getCompletedTaskCount());
89        p2.shutdown();
90        joinPool(p2);
246      }
247 <    
247 >
248      /**
249 <     *   getCorePoolSize returns size given in constructor if not otherwise set
249 >     * setThreadFactory sets the thread factory returned by getThreadFactory
250       */
251 <    public void testGetCorePoolSize() {
252 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
253 <        assertEquals(1, p1.getCorePoolSize());
254 <        joinPool(p1);
251 >    public void testSetThreadFactory() {
252 >        final ThreadPoolExecutor p =
253 >            new ThreadPoolExecutor(1, 2,
254 >                                   LONG_DELAY_MS, MILLISECONDS,
255 >                                   new ArrayBlockingQueue<Runnable>(10));
256 >        try (PoolCleaner cleaner = cleaner(p)) {
257 >            ThreadFactory threadFactory = new SimpleThreadFactory();
258 >            p.setThreadFactory(threadFactory);
259 >            assertSame(threadFactory, p.getThreadFactory());
260 >        }
261      }
262 <    
262 >
263      /**
264 <     *   getKeepAliveTime returns value given in constructor if not otherwise set
264 >     * setThreadFactory(null) throws NPE
265       */
266 <    public void testGetKeepAliveTime() {
267 <        ThreadPoolExecutor p2 = new ThreadPoolExecutor(2, 2, 1000, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
268 <        assertEquals(1, p2.getKeepAliveTime(TimeUnit.SECONDS));
269 <        joinPool(p2);
270 <    }
271 <    
272 <    /**
273 <     *   getLargestPoolSize increases, but doesn't overestimate, when
274 <     *   multiple threads active
275 <     */
276 <    public void testGetLargestPoolSize() {
116 <        ThreadPoolExecutor p2 = new ThreadPoolExecutor(2, 2, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
117 <        try {
118 <            assertEquals(0, p2.getLargestPoolSize());
119 <            p2.execute(new MediumRunnable());
120 <            p2.execute(new MediumRunnable());
121 <            Thread.sleep(SHORT_DELAY_MS);
122 <            assertEquals(2, p2.getLargestPoolSize());
123 <        } catch(Exception e){
124 <            unexpectedException();
125 <        }
126 <        joinPool(p2);
266 >    public void testSetThreadFactoryNull() {
267 >        final ThreadPoolExecutor p =
268 >            new ThreadPoolExecutor(1, 2,
269 >                                   LONG_DELAY_MS, MILLISECONDS,
270 >                                   new ArrayBlockingQueue<Runnable>(10));
271 >        try (PoolCleaner cleaner = cleaner(p)) {
272 >            try {
273 >                p.setThreadFactory(null);
274 >                shouldThrow();
275 >            } catch (NullPointerException success) {}
276 >        }
277      }
278 <    
278 >
279      /**
280 <     *   getMaximumPoolSize returns value given in constructor if not
131 <     *   otherwise set
280 >     * getRejectedExecutionHandler returns handler in constructor if not set
281       */
282 <    public void testGetMaximumPoolSize() {
283 <        ThreadPoolExecutor p2 = new ThreadPoolExecutor(2, 2, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
284 <        assertEquals(2, p2.getMaximumPoolSize());
285 <        joinPool(p2);
282 >    public void testGetRejectedExecutionHandler() {
283 >        final RejectedExecutionHandler handler = new NoOpREHandler();
284 >        final ThreadPoolExecutor p =
285 >            new ThreadPoolExecutor(1, 2,
286 >                                   LONG_DELAY_MS, MILLISECONDS,
287 >                                   new ArrayBlockingQueue<Runnable>(10),
288 >                                   handler);
289 >        try (PoolCleaner cleaner = cleaner(p)) {
290 >            assertSame(handler, p.getRejectedExecutionHandler());
291 >        }
292      }
293 <    
293 >
294      /**
295 <     *   getPoolSize increases, but doesn't overestimate, when threads
296 <     *   become active
295 >     * setRejectedExecutionHandler sets the handler returned by
296 >     * getRejectedExecutionHandler
297       */
298 <    public void testGetPoolSize() {
299 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
300 <        assertEquals(0, p1.getPoolSize());
301 <        p1.execute(new MediumRunnable());
302 <        assertEquals(1, p1.getPoolSize());
303 <        joinPool(p1);
298 >    public void testSetRejectedExecutionHandler() {
299 >        final ThreadPoolExecutor p =
300 >            new ThreadPoolExecutor(1, 2,
301 >                                   LONG_DELAY_MS, MILLISECONDS,
302 >                                   new ArrayBlockingQueue<Runnable>(10));
303 >        try (PoolCleaner cleaner = cleaner(p)) {
304 >            RejectedExecutionHandler handler = new NoOpREHandler();
305 >            p.setRejectedExecutionHandler(handler);
306 >            assertSame(handler, p.getRejectedExecutionHandler());
307 >        }
308      }
309 <    
309 >
310      /**
311 <     *   getTaskCount increases, but doesn't overestimate, when tasks submitted
311 >     * setRejectedExecutionHandler(null) throws NPE
312       */
313 <    public void testGetTaskCount() {
314 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
315 <        try {
316 <            assertEquals(0, p1.getTaskCount());
317 <            p1.execute(new MediumRunnable());
318 <            Thread.sleep(SHORT_DELAY_MS);
319 <            assertEquals(1, p1.getTaskCount());
320 <        } catch(Exception e){
321 <            unexpectedException();
322 <        }
323 <        joinPool(p1);
313 >    public void testSetRejectedExecutionHandlerNull() {
314 >        final ThreadPoolExecutor p =
315 >            new ThreadPoolExecutor(1, 2,
316 >                                   LONG_DELAY_MS, MILLISECONDS,
317 >                                   new ArrayBlockingQueue<Runnable>(10));
318 >        try (PoolCleaner cleaner = cleaner(p)) {
319 >            try {
320 >                p.setRejectedExecutionHandler(null);
321 >                shouldThrow();
322 >            } catch (NullPointerException success) {}
323 >        }
324      }
325 <    
325 >
326      /**
327 <     *   isShutDown is false before shutdown, true after
327 >     * getLargestPoolSize increases, but doesn't overestimate, when
328 >     * multiple threads active
329       */
330 <    public void testIsShutdown() {
331 <        
332 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
333 <        assertFalse(p1.isShutdown());
334 <        p1.shutdown();
335 <        assertTrue(p1.isShutdown());
336 <        joinPool(p1);
330 >    public void testGetLargestPoolSize() throws InterruptedException {
331 >        final int THREADS = 3;
332 >        final ThreadPoolExecutor p =
333 >            new ThreadPoolExecutor(THREADS, THREADS,
334 >                                   LONG_DELAY_MS, MILLISECONDS,
335 >                                   new ArrayBlockingQueue<Runnable>(10));
336 >        try (PoolCleaner cleaner = cleaner(p)) {
337 >            final CountDownLatch threadsStarted = new CountDownLatch(THREADS);
338 >            final CountDownLatch done = new CountDownLatch(1);
339 >            assertEquals(0, p.getLargestPoolSize());
340 >            for (int i = 0; i < THREADS; i++)
341 >                p.execute(new CheckedRunnable() {
342 >                    public void realRun() throws InterruptedException {
343 >                        threadsStarted.countDown();
344 >                        done.await();
345 >                        assertEquals(THREADS, p.getLargestPoolSize());
346 >                    }});
347 >            assertTrue(threadsStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
348 >            assertEquals(THREADS, p.getLargestPoolSize());
349 >            done.countDown();   // release pool
350 >        }
351 >        assertEquals(THREADS, p.getLargestPoolSize());
352      }
353  
179        
354      /**
355 <     *  isTerminated is false before termination, true after
355 >     * getMaximumPoolSize returns value given in constructor if not
356 >     * otherwise set
357       */
358 <    public void testIsTerminated() {
359 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
360 <        assertFalse(p1.isTerminated());
361 <        try {
362 <            p1.execute(new MediumRunnable());
363 <        } finally {
364 <            p1.shutdown();
358 >    public void testGetMaximumPoolSize() {
359 >        final ThreadPoolExecutor p =
360 >            new ThreadPoolExecutor(2, 3,
361 >                                   LONG_DELAY_MS, MILLISECONDS,
362 >                                   new ArrayBlockingQueue<Runnable>(10));
363 >        try (PoolCleaner cleaner = cleaner(p)) {
364 >            assertEquals(3, p.getMaximumPoolSize());
365 >            p.setMaximumPoolSize(5);
366 >            assertEquals(5, p.getMaximumPoolSize());
367 >            p.setMaximumPoolSize(4);
368 >            assertEquals(4, p.getMaximumPoolSize());
369 >        }
370 >    }
371 >
372 >    /**
373 >     * getPoolSize increases, but doesn't overestimate, when threads
374 >     * become active
375 >     */
376 >    public void testGetPoolSize() throws InterruptedException {
377 >        final ThreadPoolExecutor p =
378 >            new ThreadPoolExecutor(1, 1,
379 >                                   LONG_DELAY_MS, MILLISECONDS,
380 >                                   new ArrayBlockingQueue<Runnable>(10));
381 >        try (PoolCleaner cleaner = cleaner(p)) {
382 >            final CountDownLatch threadStarted = new CountDownLatch(1);
383 >            final CountDownLatch done = new CountDownLatch(1);
384 >            assertEquals(0, p.getPoolSize());
385 >            p.execute(new CheckedRunnable() {
386 >                public void realRun() throws InterruptedException {
387 >                    threadStarted.countDown();
388 >                    assertEquals(1, p.getPoolSize());
389 >                    done.await();
390 >                }});
391 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
392 >            assertEquals(1, p.getPoolSize());
393 >            done.countDown();   // release pool
394 >        }
395 >    }
396 >
397 >    /**
398 >     * getTaskCount increases, but doesn't overestimate, when tasks submitted
399 >     */
400 >    public void testGetTaskCount() throws InterruptedException {
401 >        final ThreadPoolExecutor p =
402 >            new ThreadPoolExecutor(1, 1,
403 >                                   LONG_DELAY_MS, MILLISECONDS,
404 >                                   new ArrayBlockingQueue<Runnable>(10));
405 >        try (PoolCleaner cleaner = cleaner(p)) {
406 >            final CountDownLatch threadStarted = new CountDownLatch(1);
407 >            final CountDownLatch done = new CountDownLatch(1);
408 >            assertEquals(0, p.getTaskCount());
409 >            p.execute(new CheckedRunnable() {
410 >                public void realRun() throws InterruptedException {
411 >                    threadStarted.countDown();
412 >                    assertEquals(1, p.getTaskCount());
413 >                    done.await();
414 >                }});
415 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
416 >            assertEquals(1, p.getTaskCount());
417 >            done.countDown();
418          }
191        try {
192            assertTrue(p1.awaitTermination(LONG_DELAY_MS, TimeUnit.MILLISECONDS));
193            assertTrue(p1.isTerminated());
194        } catch(Exception e){
195            unexpectedException();
196        }      
419      }
420  
421      /**
422 <     *  isTerminating is not true when running or when terminated
422 >     * isShutdown is false before shutdown, true after
423       */
424 <    public void testIsTerminating() {
425 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
426 <        assertFalse(p1.isTerminating());
427 <        try {
428 <            p1.execute(new SmallRunnable());
429 <            assertFalse(p1.isTerminating());
430 <        } finally {
431 <            p1.shutdown();
424 >    public void testIsShutdown() {
425 >        final ThreadPoolExecutor p =
426 >            new ThreadPoolExecutor(1, 1,
427 >                                   LONG_DELAY_MS, MILLISECONDS,
428 >                                   new ArrayBlockingQueue<Runnable>(10));
429 >        try (PoolCleaner cleaner = cleaner(p)) {
430 >            assertFalse(p.isShutdown());
431 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
432 >            assertTrue(p.isShutdown());
433 >        }
434 >    }
435 >
436 >    /**
437 >     * awaitTermination on a non-shutdown pool times out
438 >     */
439 >    public void testAwaitTermination_timesOut() throws InterruptedException {
440 >        final ThreadPoolExecutor p =
441 >            new ThreadPoolExecutor(1, 1,
442 >                                   LONG_DELAY_MS, MILLISECONDS,
443 >                                   new ArrayBlockingQueue<Runnable>(10));
444 >        try (PoolCleaner cleaner = cleaner(p)) {
445 >            assertFalse(p.isTerminated());
446 >            assertFalse(p.awaitTermination(Long.MIN_VALUE, NANOSECONDS));
447 >            assertFalse(p.awaitTermination(Long.MIN_VALUE, MILLISECONDS));
448 >            assertFalse(p.awaitTermination(-1L, NANOSECONDS));
449 >            assertFalse(p.awaitTermination(-1L, MILLISECONDS));
450 >            assertFalse(p.awaitTermination(0L, NANOSECONDS));
451 >            assertFalse(p.awaitTermination(0L, MILLISECONDS));
452 >            long timeoutNanos = 999999L;
453 >            long startTime = System.nanoTime();
454 >            assertFalse(p.awaitTermination(timeoutNanos, NANOSECONDS));
455 >            assertTrue(System.nanoTime() - startTime >= timeoutNanos);
456 >            assertFalse(p.isTerminated());
457 >            startTime = System.nanoTime();
458 >            long timeoutMillis = timeoutMillis();
459 >            assertFalse(p.awaitTermination(timeoutMillis, MILLISECONDS));
460 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
461 >            assertFalse(p.isTerminated());
462 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
463 >            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
464 >            assertTrue(p.isTerminated());
465 >        }
466 >    }
467 >
468 >    /**
469 >     * isTerminated is false before termination, true after
470 >     */
471 >    public void testIsTerminated() throws InterruptedException {
472 >        final ThreadPoolExecutor p =
473 >            new ThreadPoolExecutor(1, 1,
474 >                                   LONG_DELAY_MS, MILLISECONDS,
475 >                                   new ArrayBlockingQueue<Runnable>(10));
476 >        try (PoolCleaner cleaner = cleaner(p)) {
477 >            final CountDownLatch threadStarted = new CountDownLatch(1);
478 >            final CountDownLatch done = new CountDownLatch(1);
479 >            assertFalse(p.isTerminating());
480 >            p.execute(new CheckedRunnable() {
481 >                public void realRun() throws InterruptedException {
482 >                    assertFalse(p.isTerminating());
483 >                    threadStarted.countDown();
484 >                    done.await();
485 >                }});
486 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
487 >            assertFalse(p.isTerminating());
488 >            done.countDown();
489 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
490 >            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
491 >            assertTrue(p.isTerminated());
492 >            assertFalse(p.isTerminating());
493 >        }
494 >    }
495 >
496 >    /**
497 >     * isTerminating is not true when running or when terminated
498 >     */
499 >    public void testIsTerminating() throws InterruptedException {
500 >        final ThreadPoolExecutor p =
501 >            new ThreadPoolExecutor(1, 1,
502 >                                   LONG_DELAY_MS, MILLISECONDS,
503 >                                   new ArrayBlockingQueue<Runnable>(10));
504 >        try (PoolCleaner cleaner = cleaner(p)) {
505 >            final CountDownLatch threadStarted = new CountDownLatch(1);
506 >            final CountDownLatch done = new CountDownLatch(1);
507 >            assertFalse(p.isTerminating());
508 >            p.execute(new CheckedRunnable() {
509 >                public void realRun() throws InterruptedException {
510 >                    assertFalse(p.isTerminating());
511 >                    threadStarted.countDown();
512 >                    done.await();
513 >                }});
514 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
515 >            assertFalse(p.isTerminating());
516 >            done.countDown();
517 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
518 >            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
519 >            assertTrue(p.isTerminated());
520 >            assertFalse(p.isTerminating());
521 >        }
522 >    }
523 >
524 >    /**
525 >     * getQueue returns the work queue, which contains queued tasks
526 >     */
527 >    public void testGetQueue() throws InterruptedException {
528 >        final BlockingQueue<Runnable> q = new ArrayBlockingQueue<Runnable>(10);
529 >        final ThreadPoolExecutor p =
530 >            new ThreadPoolExecutor(1, 1,
531 >                                   LONG_DELAY_MS, MILLISECONDS,
532 >                                   q);
533 >        try (PoolCleaner cleaner = cleaner(p)) {
534 >            final CountDownLatch threadStarted = new CountDownLatch(1);
535 >            final CountDownLatch done = new CountDownLatch(1);
536 >            FutureTask[] tasks = new FutureTask[5];
537 >            for (int i = 0; i < tasks.length; i++) {
538 >                Callable task = new CheckedCallable<Boolean>() {
539 >                    public Boolean realCall() throws InterruptedException {
540 >                        threadStarted.countDown();
541 >                        assertSame(q, p.getQueue());
542 >                        done.await();
543 >                        return Boolean.TRUE;
544 >                    }};
545 >                tasks[i] = new FutureTask(task);
546 >                p.execute(tasks[i]);
547 >            }
548 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
549 >            assertSame(q, p.getQueue());
550 >            assertFalse(q.contains(tasks[0]));
551 >            assertTrue(q.contains(tasks[tasks.length - 1]));
552 >            assertEquals(tasks.length - 1, q.size());
553 >            done.countDown();
554          }
211        try {
212            assertTrue(p1.awaitTermination(LONG_DELAY_MS, TimeUnit.MILLISECONDS));
213            assertTrue(p1.isTerminated());
214            assertFalse(p1.isTerminating());
215        } catch(Exception e){
216            unexpectedException();
217        }      
555      }
556  
557      /**
558 <     *   purge removes cancelled tasks from the queue
559 <     */
560 <    public void testPurge() {
561 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
562 <        CancellableTask[] tasks = new CancellableTask[5];
563 <        for(int i = 0; i < 5; i++){
564 <            tasks[i] = new CancellableTask(new MediumPossiblyInterruptedRunnable());
565 <            p1.execute(tasks[i]);
558 >     * remove(task) removes queued task, and fails to remove active task
559 >     */
560 >    public void testRemove() throws InterruptedException {
561 >        BlockingQueue<Runnable> q = new ArrayBlockingQueue<Runnable>(10);
562 >        final ThreadPoolExecutor p =
563 >            new ThreadPoolExecutor(1, 1,
564 >                                   LONG_DELAY_MS, MILLISECONDS,
565 >                                   q);
566 >        try (PoolCleaner cleaner = cleaner(p)) {
567 >            Runnable[] tasks = new Runnable[6];
568 >            final CountDownLatch threadStarted = new CountDownLatch(1);
569 >            final CountDownLatch done = new CountDownLatch(1);
570 >            for (int i = 0; i < tasks.length; i++) {
571 >                tasks[i] = new CheckedRunnable() {
572 >                    public void realRun() throws InterruptedException {
573 >                        threadStarted.countDown();
574 >                        done.await();
575 >                    }};
576 >                p.execute(tasks[i]);
577 >            }
578 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
579 >            assertFalse(p.remove(tasks[0]));
580 >            assertTrue(q.contains(tasks[4]));
581 >            assertTrue(q.contains(tasks[3]));
582 >            assertTrue(p.remove(tasks[4]));
583 >            assertFalse(p.remove(tasks[4]));
584 >            assertFalse(q.contains(tasks[4]));
585 >            assertTrue(q.contains(tasks[3]));
586 >            assertTrue(p.remove(tasks[3]));
587 >            assertFalse(q.contains(tasks[3]));
588 >            done.countDown();
589          }
230        tasks[4].cancel(true);
231        tasks[3].cancel(true);
232        p1.purge();
233        long count = p1.getTaskCount();
234        assertTrue(count >= 2 && count < 5);
235        joinPool(p1);
590      }
591  
592      /**
593 <     *  shutDownNow returns a list containing tasks that were not run
594 <     */
595 <    public void testShutDownNow() {
596 <        ThreadPoolExecutor p1 = new ThreadPoolExecutor(1, 1, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
597 <        List l;
598 <        try {
599 <            for(int i = 0; i < 5; i++)
600 <                p1.execute(new MediumPossiblyInterruptedRunnable());
601 <        }
602 <        finally {
603 <            l = p1.shutdownNow();
593 >     * purge removes cancelled tasks from the queue
594 >     */
595 >    public void testPurge() throws InterruptedException {
596 >        final CountDownLatch threadStarted = new CountDownLatch(1);
597 >        final CountDownLatch done = new CountDownLatch(1);
598 >        final BlockingQueue<Runnable> q = new ArrayBlockingQueue<Runnable>(10);
599 >        final ThreadPoolExecutor p =
600 >            new ThreadPoolExecutor(1, 1,
601 >                                   LONG_DELAY_MS, MILLISECONDS,
602 >                                   q);
603 >        try (PoolCleaner cleaner = cleaner(p)) {
604 >            FutureTask[] tasks = new FutureTask[5];
605 >            for (int i = 0; i < tasks.length; i++) {
606 >                Callable task = new CheckedCallable<Boolean>() {
607 >                    public Boolean realCall() throws InterruptedException {
608 >                        threadStarted.countDown();
609 >                        done.await();
610 >                        return Boolean.TRUE;
611 >                    }};
612 >                tasks[i] = new FutureTask(task);
613 >                p.execute(tasks[i]);
614 >            }
615 >            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
616 >            assertEquals(tasks.length, p.getTaskCount());
617 >            assertEquals(tasks.length - 1, q.size());
618 >            assertEquals(1L, p.getActiveCount());
619 >            assertEquals(0L, p.getCompletedTaskCount());
620 >            tasks[4].cancel(true);
621 >            tasks[3].cancel(false);
622 >            p.purge();
623 >            assertEquals(tasks.length - 3, q.size());
624 >            assertEquals(tasks.length - 2, p.getTaskCount());
625 >            p.purge();         // Nothing to do
626 >            assertEquals(tasks.length - 3, q.size());
627 >            assertEquals(tasks.length - 2, p.getTaskCount());
628 >            done.countDown();
629          }
630 <        assertTrue(p1.isShutdown());
631 <        assertTrue(l.size() <= 4);
630 >    }
631 >
632 >    /**
633 >     * shutdownNow returns a list containing tasks that were not run,
634 >     * and those tasks are drained from the queue
635 >     */
636 >    public void testShutdownNow() throws InterruptedException {
637 >        final int poolSize = 2;
638 >        final int count = 5;
639 >        final AtomicInteger ran = new AtomicInteger(0);
640 >        final ThreadPoolExecutor p =
641 >            new ThreadPoolExecutor(poolSize, poolSize,
642 >                                   LONG_DELAY_MS, MILLISECONDS,
643 >                                   new ArrayBlockingQueue<Runnable>(10));
644 >        CountDownLatch threadsStarted = new CountDownLatch(poolSize);
645 >        Runnable waiter = new CheckedRunnable() { public void realRun() {
646 >            threadsStarted.countDown();
647 >            try {
648 >                MILLISECONDS.sleep(2 * LONG_DELAY_MS);
649 >            } catch (InterruptedException success) {}
650 >            ran.getAndIncrement();
651 >        }};
652 >        for (int i = 0; i < count; i++)
653 >            p.execute(waiter);
654 >        assertTrue(threadsStarted.await(LONG_DELAY_MS, MILLISECONDS));
655 >        assertEquals(poolSize, p.getActiveCount());
656 >        assertEquals(0, p.getCompletedTaskCount());
657 >        final List<Runnable> queuedTasks;
658 >        try {
659 >            queuedTasks = p.shutdownNow();
660 >        } catch (SecurityException ok) {
661 >            return; // Allowed in case test doesn't have privs
662 >        }
663 >        assertTrue(p.isShutdown());
664 >        assertTrue(p.getQueue().isEmpty());
665 >        assertEquals(count - poolSize, queuedTasks.size());
666 >        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
667 >        assertTrue(p.isTerminated());
668 >        assertEquals(poolSize, ran.get());
669 >        assertEquals(poolSize, p.getCompletedTaskCount());
670      }
671  
672      // Exception Tests
256    
673  
674 <    /**
675 <     * Constructor throws if corePoolSize argument is less than zero
674 >    /**
675 >     * Constructor throws if corePoolSize argument is less than zero
676       */
677      public void testConstructor1() {
678          try {
679 <            new ThreadPoolExecutor(-1,1,LONG_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
679 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
680 >                                   new ArrayBlockingQueue<Runnable>(10));
681              shouldThrow();
682 <        }
266 <        catch (IllegalArgumentException success){}
682 >        } catch (IllegalArgumentException success) {}
683      }
684 <    
685 <    /**
686 <     * Constructor throws if maximumPoolSize is less than zero
684 >
685 >    /**
686 >     * Constructor throws if maximumPoolSize is less than zero
687       */
688      public void testConstructor2() {
689          try {
690 <            new ThreadPoolExecutor(1,-1,LONG_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
690 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
691 >                                   new ArrayBlockingQueue<Runnable>(10));
692              shouldThrow();
693 <        }
277 <        catch (IllegalArgumentException success){}
693 >        } catch (IllegalArgumentException success) {}
694      }
695 <    
696 <    /**
697 <     * Constructor throws if maximumPoolSize is equal to zero
695 >
696 >    /**
697 >     * Constructor throws if maximumPoolSize is equal to zero
698       */
699      public void testConstructor3() {
700          try {
701 <            new ThreadPoolExecutor(1,0,LONG_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
701 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
702 >                                   new ArrayBlockingQueue<Runnable>(10));
703              shouldThrow();
704 <        }
288 <        catch (IllegalArgumentException success){}
704 >        } catch (IllegalArgumentException success) {}
705      }
706  
707 <    /**
708 <     * Constructor throws if keepAliveTime is less than zero
707 >    /**
708 >     * Constructor throws if keepAliveTime is less than zero
709       */
710      public void testConstructor4() {
711          try {
712 <            new ThreadPoolExecutor(1,2,-1L,TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
712 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
713 >                                   new ArrayBlockingQueue<Runnable>(10));
714              shouldThrow();
715 <        }
299 <        catch (IllegalArgumentException success){}
715 >        } catch (IllegalArgumentException success) {}
716      }
717  
718 <    /**
719 <     * Constructor throws if corePoolSize is greater than the maximumPoolSize
718 >    /**
719 >     * Constructor throws if corePoolSize is greater than the maximumPoolSize
720       */
721      public void testConstructor5() {
722          try {
723 <            new ThreadPoolExecutor(2,1,LONG_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10));
723 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
724 >                                   new ArrayBlockingQueue<Runnable>(10));
725              shouldThrow();
726 <        }
310 <        catch (IllegalArgumentException success){}
726 >        } catch (IllegalArgumentException success) {}
727      }
728 <        
729 <    /**
730 <     * Constructor throws if workQueue is set to null
728 >
729 >    /**
730 >     * Constructor throws if workQueue is set to null
731       */
732 <    public void testNullPointerException() {
732 >    public void testConstructorNullPointerException() {
733          try {
734 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,null);
734 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
735 >                                   (BlockingQueue) null);
736              shouldThrow();
737 <        }
321 <        catch (NullPointerException success){}  
737 >        } catch (NullPointerException success) {}
738      }
323    
739  
740 <    
741 <    /**
327 <     * Constructor throws if corePoolSize argument is less than zero
740 >    /**
741 >     * Constructor throws if corePoolSize argument is less than zero
742       */
743      public void testConstructor6() {
744          try {
745 <            new ThreadPoolExecutor(-1,1,LONG_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory());
745 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
746 >                                   new ArrayBlockingQueue<Runnable>(10),
747 >                                   new SimpleThreadFactory());
748              shouldThrow();
749 <        } catch (IllegalArgumentException success){}
749 >        } catch (IllegalArgumentException success) {}
750      }
751 <    
752 <    /**
753 <     * Constructor throws if maximumPoolSize is less than zero
751 >
752 >    /**
753 >     * Constructor throws if maximumPoolSize is less than zero
754       */
755      public void testConstructor7() {
756          try {
757 <            new ThreadPoolExecutor(1,-1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory());
757 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
758 >                                   new ArrayBlockingQueue<Runnable>(10),
759 >                                   new SimpleThreadFactory());
760              shouldThrow();
761 <        }
344 <        catch (IllegalArgumentException success){}
761 >        } catch (IllegalArgumentException success) {}
762      }
763  
764 <    /**
765 <     * Constructor throws if maximumPoolSize is equal to zero
764 >    /**
765 >     * Constructor throws if maximumPoolSize is equal to zero
766       */
767      public void testConstructor8() {
768          try {
769 <            new ThreadPoolExecutor(1,0,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory());
769 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
770 >                                   new ArrayBlockingQueue<Runnable>(10),
771 >                                   new SimpleThreadFactory());
772              shouldThrow();
773 <        }
355 <        catch (IllegalArgumentException success){}
773 >        } catch (IllegalArgumentException success) {}
774      }
775  
776 <    /**
777 <     * Constructor throws if keepAliveTime is less than zero
776 >    /**
777 >     * Constructor throws if keepAliveTime is less than zero
778       */
779      public void testConstructor9() {
780          try {
781 <            new ThreadPoolExecutor(1,2,-1L,TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory());
781 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
782 >                                   new ArrayBlockingQueue<Runnable>(10),
783 >                                   new SimpleThreadFactory());
784              shouldThrow();
785 <        }
366 <        catch (IllegalArgumentException success){}
785 >        } catch (IllegalArgumentException success) {}
786      }
787  
788 <    /**
789 <     * Constructor throws if corePoolSize is greater than the maximumPoolSize
788 >    /**
789 >     * Constructor throws if corePoolSize is greater than the maximumPoolSize
790       */
791      public void testConstructor10() {
792          try {
793 <            new ThreadPoolExecutor(2,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory());
793 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
794 >                                   new ArrayBlockingQueue<Runnable>(10),
795 >                                   new SimpleThreadFactory());
796              shouldThrow();
797 <        }
377 <        catch (IllegalArgumentException success){}
797 >        } catch (IllegalArgumentException success) {}
798      }
799  
800 <    /**
801 <     * Constructor throws if workQueue is set to null
800 >    /**
801 >     * Constructor throws if workQueue is set to null
802       */
803 <    public void testNullPointerException2() {
803 >    public void testConstructorNullPointerException2() {
804          try {
805 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,null,new MyThreadFactory());
805 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
806 >                                   (BlockingQueue) null,
807 >                                   new SimpleThreadFactory());
808              shouldThrow();
809 <        }
388 <        catch (NullPointerException success){}  
809 >        } catch (NullPointerException success) {}
810      }
811  
812 <    /**
813 <     * Constructor throws if threadFactory is set to null
812 >    /**
813 >     * Constructor throws if threadFactory is set to null
814       */
815 <    public void testNullPointerException3() {
815 >    public void testConstructorNullPointerException3() {
816          try {
817 <            ThreadFactory f = null;
818 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10),f);
817 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
818 >                                   new ArrayBlockingQueue<Runnable>(10),
819 >                                   (ThreadFactory) null);
820              shouldThrow();
821 <        }
400 <        catch (NullPointerException success){}  
821 >        } catch (NullPointerException success) {}
822      }
823 <
824 <    
825 <    /**
405 <     * Constructor throws if corePoolSize argument is less than zero
823 >
824 >    /**
825 >     * Constructor throws if corePoolSize argument is less than zero
826       */
827      public void testConstructor11() {
828          try {
829 <            new ThreadPoolExecutor(-1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyREHandler());
829 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
830 >                                   new ArrayBlockingQueue<Runnable>(10),
831 >                                   new NoOpREHandler());
832              shouldThrow();
833 <        }
412 <        catch (IllegalArgumentException success){}
833 >        } catch (IllegalArgumentException success) {}
834      }
835  
836 <    /**
837 <     * Constructor throws if maximumPoolSize is less than zero
836 >    /**
837 >     * Constructor throws if maximumPoolSize is less than zero
838       */
839      public void testConstructor12() {
840          try {
841 <            new ThreadPoolExecutor(1,-1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyREHandler());
841 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
842 >                                   new ArrayBlockingQueue<Runnable>(10),
843 >                                   new NoOpREHandler());
844              shouldThrow();
845 <        }
423 <        catch (IllegalArgumentException success){}
845 >        } catch (IllegalArgumentException success) {}
846      }
847  
848 <    /**
849 <     * Constructor throws if maximumPoolSize is equal to zero
848 >    /**
849 >     * Constructor throws if maximumPoolSize is equal to zero
850       */
851      public void testConstructor13() {
852          try {
853 <            new ThreadPoolExecutor(1,0,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyREHandler());
853 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
854 >                                   new ArrayBlockingQueue<Runnable>(10),
855 >                                   new NoOpREHandler());
856              shouldThrow();
857 <        }
434 <        catch (IllegalArgumentException success){}
857 >        } catch (IllegalArgumentException success) {}
858      }
859  
860 <    /**
861 <     * Constructor throws if keepAliveTime is less than zero
860 >    /**
861 >     * Constructor throws if keepAliveTime is less than zero
862       */
863      public void testConstructor14() {
864          try {
865 <            new ThreadPoolExecutor(1,2,-1L,TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyREHandler());
865 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
866 >                                   new ArrayBlockingQueue<Runnable>(10),
867 >                                   new NoOpREHandler());
868              shouldThrow();
869 <        }
445 <        catch (IllegalArgumentException success){}
869 >        } catch (IllegalArgumentException success) {}
870      }
871  
872 <    /**
873 <     * Constructor throws if corePoolSize is greater than the maximumPoolSize
872 >    /**
873 >     * Constructor throws if corePoolSize is greater than the maximumPoolSize
874       */
875      public void testConstructor15() {
876          try {
877 <            new ThreadPoolExecutor(2,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyREHandler());
877 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
878 >                                   new ArrayBlockingQueue<Runnable>(10),
879 >                                   new NoOpREHandler());
880              shouldThrow();
881 +        } catch (IllegalArgumentException success) {}
882 +    }
883 +
884 +    /**
885 +     * Constructor throws if workQueue is set to null
886 +     */
887 +    public void testConstructorNullPointerException4() {
888 +        try {
889 +            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
890 +                                   (BlockingQueue) null,
891 +                                   new NoOpREHandler());
892 +            shouldThrow();
893 +        } catch (NullPointerException success) {}
894 +    }
895 +
896 +    /**
897 +     * Constructor throws if handler is set to null
898 +     */
899 +    public void testConstructorNullPointerException5() {
900 +        try {
901 +            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
902 +                                   new ArrayBlockingQueue<Runnable>(10),
903 +                                   (RejectedExecutionHandler) null);
904 +            shouldThrow();
905 +        } catch (NullPointerException success) {}
906 +    }
907 +
908 +    /**
909 +     * Constructor throws if corePoolSize argument is less than zero
910 +     */
911 +    public void testConstructor16() {
912 +        try {
913 +            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
914 +                                   new ArrayBlockingQueue<Runnable>(10),
915 +                                   new SimpleThreadFactory(),
916 +                                   new NoOpREHandler());
917 +            shouldThrow();
918 +        } catch (IllegalArgumentException success) {}
919 +    }
920 +
921 +    /**
922 +     * Constructor throws if maximumPoolSize is less than zero
923 +     */
924 +    public void testConstructor17() {
925 +        try {
926 +            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
927 +                                   new ArrayBlockingQueue<Runnable>(10),
928 +                                   new SimpleThreadFactory(),
929 +                                   new NoOpREHandler());
930 +            shouldThrow();
931 +        } catch (IllegalArgumentException success) {}
932 +    }
933 +
934 +    /**
935 +     * Constructor throws if maximumPoolSize is equal to zero
936 +     */
937 +    public void testConstructor18() {
938 +        try {
939 +            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
940 +                                   new ArrayBlockingQueue<Runnable>(10),
941 +                                   new SimpleThreadFactory(),
942 +                                   new NoOpREHandler());
943 +            shouldThrow();
944 +        } catch (IllegalArgumentException success) {}
945 +    }
946 +
947 +    /**
948 +     * Constructor throws if keepAliveTime is less than zero
949 +     */
950 +    public void testConstructor19() {
951 +        try {
952 +            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
953 +                                   new ArrayBlockingQueue<Runnable>(10),
954 +                                   new SimpleThreadFactory(),
955 +                                   new NoOpREHandler());
956 +            shouldThrow();
957 +        } catch (IllegalArgumentException success) {}
958 +    }
959 +
960 +    /**
961 +     * Constructor throws if corePoolSize is greater than the maximumPoolSize
962 +     */
963 +    public void testConstructor20() {
964 +        try {
965 +            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
966 +                                   new ArrayBlockingQueue<Runnable>(10),
967 +                                   new SimpleThreadFactory(),
968 +                                   new NoOpREHandler());
969 +            shouldThrow();
970 +        } catch (IllegalArgumentException success) {}
971 +    }
972 +
973 +    /**
974 +     * Constructor throws if workQueue is null
975 +     */
976 +    public void testConstructorNullPointerException6() {
977 +        try {
978 +            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
979 +                                   (BlockingQueue) null,
980 +                                   new SimpleThreadFactory(),
981 +                                   new NoOpREHandler());
982 +            shouldThrow();
983 +        } catch (NullPointerException success) {}
984 +    }
985 +
986 +    /**
987 +     * Constructor throws if handler is null
988 +     */
989 +    public void testConstructorNullPointerException7() {
990 +        try {
991 +            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
992 +                                   new ArrayBlockingQueue<Runnable>(10),
993 +                                   new SimpleThreadFactory(),
994 +                                   (RejectedExecutionHandler) null);
995 +            shouldThrow();
996 +        } catch (NullPointerException success) {}
997 +    }
998 +
999 +    /**
1000 +     * Constructor throws if ThreadFactory is null
1001 +     */
1002 +    public void testConstructorNullPointerException8() {
1003 +        try {
1004 +            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
1005 +                                   new ArrayBlockingQueue<Runnable>(10),
1006 +                                   (ThreadFactory) null,
1007 +                                   new NoOpREHandler());
1008 +            shouldThrow();
1009 +        } catch (NullPointerException success) {}
1010 +    }
1011 +
1012 +    /**
1013 +     * get of submitted callable throws InterruptedException if interrupted
1014 +     */
1015 +    public void testInterruptedSubmit() throws InterruptedException {
1016 +        final ThreadPoolExecutor p =
1017 +            new ThreadPoolExecutor(1, 1,
1018 +                                   60, SECONDS,
1019 +                                   new ArrayBlockingQueue<Runnable>(10));
1020 +
1021 +        try (PoolCleaner cleaner = cleaner(p)) {
1022 +            final CountDownLatch threadStarted = new CountDownLatch(1);
1023 +            final CountDownLatch done = new CountDownLatch(1);
1024 +            Thread t = newStartedThread(new CheckedInterruptedRunnable() {
1025 +                public void realRun() throws Exception {
1026 +                    Callable task = new CheckedCallable<Boolean>() {
1027 +                        public Boolean realCall() throws InterruptedException {
1028 +                            threadStarted.countDown();
1029 +                            done.await();
1030 +                            return Boolean.TRUE;
1031 +                        }};
1032 +                    p.submit(task).get();
1033 +                }});
1034 +
1035 +            assertTrue(threadStarted.await(MEDIUM_DELAY_MS, MILLISECONDS));
1036 +            t.interrupt();
1037 +            awaitTermination(t, MEDIUM_DELAY_MS);
1038 +            done.countDown();
1039          }
456        catch (IllegalArgumentException success){}
1040      }
1041  
1042 <    /**
1043 <     * Constructor throws if workQueue is set to null
1042 >    /**
1043 >     * execute throws RejectedExecutionException if saturated.
1044 >     */
1045 >    public void testSaturatedExecute() {
1046 >        final ThreadPoolExecutor p =
1047 >            new ThreadPoolExecutor(1, 1,
1048 >                                   LONG_DELAY_MS, MILLISECONDS,
1049 >                                   new ArrayBlockingQueue<Runnable>(1));
1050 >        try (PoolCleaner cleaner = cleaner(p)) {
1051 >            final CountDownLatch done = new CountDownLatch(1);
1052 >            Runnable task = new CheckedRunnable() {
1053 >                public void realRun() throws InterruptedException {
1054 >                    done.await();
1055 >                }};
1056 >            for (int i = 0; i < 2; ++i)
1057 >                p.execute(task);
1058 >            for (int i = 0; i < 2; ++i) {
1059 >                try {
1060 >                    p.execute(task);
1061 >                    shouldThrow();
1062 >                } catch (RejectedExecutionException success) {}
1063 >                assertTrue(p.getTaskCount() <= 2);
1064 >            }
1065 >            done.countDown();
1066 >        }
1067 >    }
1068 >
1069 >    /**
1070 >     * submit(runnable) throws RejectedExecutionException if saturated.
1071 >     */
1072 >    public void testSaturatedSubmitRunnable() {
1073 >        ThreadPoolExecutor p =
1074 >            new ThreadPoolExecutor(1, 1,
1075 >                                   LONG_DELAY_MS, MILLISECONDS,
1076 >                                   new ArrayBlockingQueue<Runnable>(1));
1077 >        final CountDownLatch done = new CountDownLatch(1);
1078 >        try {
1079 >            Runnable task = new CheckedRunnable() {
1080 >                public void realRun() throws InterruptedException {
1081 >                    done.await();
1082 >                }};
1083 >            for (int i = 0; i < 2; ++i)
1084 >                p.submit(task);
1085 >            for (int i = 0; i < 2; ++i) {
1086 >                try {
1087 >                    p.execute(task);
1088 >                    shouldThrow();
1089 >                } catch (RejectedExecutionException success) {}
1090 >                assertTrue(p.getTaskCount() <= 2);
1091 >            }
1092 >        } finally {
1093 >            done.countDown();
1094 >            joinPool(p);
1095 >        }
1096 >    }
1097 >
1098 >    /**
1099 >     * submit(callable) throws RejectedExecutionException if saturated.
1100       */
1101 <    public void testNullPointerException4() {
1101 >    public void testSaturatedSubmitCallable() {
1102 >        ThreadPoolExecutor p =
1103 >            new ThreadPoolExecutor(1, 1,
1104 >                                   LONG_DELAY_MS, MILLISECONDS,
1105 >                                   new ArrayBlockingQueue<Runnable>(1));
1106 >        final CountDownLatch done = new CountDownLatch(1);
1107 >        try {
1108 >            Runnable task = new CheckedRunnable() {
1109 >                public void realRun() throws InterruptedException {
1110 >                    done.await();
1111 >                }};
1112 >            for (int i = 0; i < 2; ++i)
1113 >                p.submit(Executors.callable(task));
1114 >            for (int i = 0; i < 2; ++i) {
1115 >                try {
1116 >                    p.execute(task);
1117 >                    shouldThrow();
1118 >                } catch (RejectedExecutionException success) {}
1119 >                assertTrue(p.getTaskCount() <= 2);
1120 >            }
1121 >        } finally {
1122 >            done.countDown();
1123 >            joinPool(p);
1124 >        }
1125 >    }
1126 >
1127 >    /**
1128 >     * executor using CallerRunsPolicy runs task if saturated.
1129 >     */
1130 >    public void testSaturatedExecute2() {
1131 >        final ThreadPoolExecutor p =
1132 >            new ThreadPoolExecutor(1, 1,
1133 >                                   LONG_DELAY_MS,
1134 >                                   MILLISECONDS,
1135 >                                   new ArrayBlockingQueue<Runnable>(1),
1136 >                                   new ThreadPoolExecutor.CallerRunsPolicy());
1137 >        try (PoolCleaner cleaner = cleaner(p)) {
1138 >            final CountDownLatch done = new CountDownLatch(1);
1139 >            Runnable blocker = new CheckedRunnable() {
1140 >                public void realRun() throws InterruptedException {
1141 >                    done.await();
1142 >                }};
1143 >            p.execute(blocker);
1144 >            TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1145 >            for (int i = 0; i < tasks.length; i++)
1146 >                tasks[i] = new TrackedNoOpRunnable();
1147 >            for (int i = 0; i < tasks.length; i++)
1148 >                p.execute(tasks[i]);
1149 >            for (int i = 1; i < tasks.length; i++)
1150 >                assertTrue(tasks[i].done);
1151 >            // tasks[0] is waiting in queue
1152 >            assertFalse(tasks[0].done);
1153 >            done.countDown();
1154 >        }
1155 >    }
1156 >
1157 >    /**
1158 >     * executor using DiscardPolicy drops task if saturated.
1159 >     */
1160 >    public void testSaturatedExecute3() {
1161 >        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardPolicy();
1162 >        final ThreadPoolExecutor p =
1163 >            new ThreadPoolExecutor(1, 1,
1164 >                                   LONG_DELAY_MS, MILLISECONDS,
1165 >                                   new ArrayBlockingQueue<Runnable>(1),
1166 >                                   h);
1167 >        try {
1168 >            TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1169 >            for (int i = 0; i < tasks.length; ++i)
1170 >                tasks[i] = new TrackedNoOpRunnable();
1171 >            p.execute(new TrackedLongRunnable());
1172 >            for (TrackedNoOpRunnable task : tasks)
1173 >                p.execute(task);
1174 >            for (TrackedNoOpRunnable task : tasks)
1175 >                assertFalse(task.done);
1176 >            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1177 >        } finally {
1178 >            joinPool(p);
1179 >        }
1180 >    }
1181 >
1182 >    /**
1183 >     * executor using DiscardOldestPolicy drops oldest task if saturated.
1184 >     */
1185 >    public void testSaturatedExecute4() {
1186 >        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardOldestPolicy();
1187 >        final ThreadPoolExecutor p =
1188 >            new ThreadPoolExecutor(1, 1,
1189 >                                   LONG_DELAY_MS, MILLISECONDS,
1190 >                                   new ArrayBlockingQueue<Runnable>(1),
1191 >                                   h);
1192 >        try {
1193 >            p.execute(new TrackedLongRunnable());
1194 >            TrackedLongRunnable r2 = new TrackedLongRunnable();
1195 >            p.execute(r2);
1196 >            assertTrue(p.getQueue().contains(r2));
1197 >            TrackedNoOpRunnable r3 = new TrackedNoOpRunnable();
1198 >            p.execute(r3);
1199 >            assertFalse(p.getQueue().contains(r2));
1200 >            assertTrue(p.getQueue().contains(r3));
1201 >            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1202 >        } finally {
1203 >            joinPool(p);
1204 >        }
1205 >    }
1206 >
1207 >    /**
1208 >     * execute throws RejectedExecutionException if shutdown
1209 >     */
1210 >    public void testRejectedExecutionExceptionOnShutdown() {
1211 >        ThreadPoolExecutor p =
1212 >            new ThreadPoolExecutor(1, 1,
1213 >                                   LONG_DELAY_MS, MILLISECONDS,
1214 >                                   new ArrayBlockingQueue<Runnable>(1));
1215 >        try { p.shutdown(); } catch (SecurityException ok) { return; }
1216          try {
1217 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,null,new MyREHandler());
1217 >            p.execute(new NoOpRunnable());
1218              shouldThrow();
1219 +        } catch (RejectedExecutionException success) {}
1220 +
1221 +        joinPool(p);
1222 +    }
1223 +
1224 +    /**
1225 +     * execute using CallerRunsPolicy drops task on shutdown
1226 +     */
1227 +    public void testCallerRunsOnShutdown() {
1228 +        RejectedExecutionHandler h = new ThreadPoolExecutor.CallerRunsPolicy();
1229 +        final ThreadPoolExecutor p =
1230 +            new ThreadPoolExecutor(1, 1,
1231 +                                   LONG_DELAY_MS, MILLISECONDS,
1232 +                                   new ArrayBlockingQueue<Runnable>(1), h);
1233 +
1234 +        try { p.shutdown(); } catch (SecurityException ok) { return; }
1235 +        try {
1236 +            TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1237 +            p.execute(r);
1238 +            assertFalse(r.done);
1239 +        } finally {
1240 +            joinPool(p);
1241 +        }
1242 +    }
1243 +
1244 +    /**
1245 +     * execute using DiscardPolicy drops task on shutdown
1246 +     */
1247 +    public void testDiscardOnShutdown() {
1248 +        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardPolicy();
1249 +        ThreadPoolExecutor p =
1250 +            new ThreadPoolExecutor(1, 1,
1251 +                                   LONG_DELAY_MS, MILLISECONDS,
1252 +                                   new ArrayBlockingQueue<Runnable>(1),
1253 +                                   h);
1254 +
1255 +        try { p.shutdown(); } catch (SecurityException ok) { return; }
1256 +        try {
1257 +            TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1258 +            p.execute(r);
1259 +            assertFalse(r.done);
1260 +        } finally {
1261 +            joinPool(p);
1262          }
467        catch (NullPointerException success){}  
1263      }
1264  
1265 <    /**
1266 <     * Constructor throws if handler is set to null
1265 >    /**
1266 >     * execute using DiscardOldestPolicy drops task on shutdown
1267       */
1268 <    public void testNullPointerException5() {
1268 >    public void testDiscardOldestOnShutdown() {
1269 >        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardOldestPolicy();
1270 >        ThreadPoolExecutor p =
1271 >            new ThreadPoolExecutor(1, 1,
1272 >                                   LONG_DELAY_MS, MILLISECONDS,
1273 >                                   new ArrayBlockingQueue<Runnable>(1),
1274 >                                   h);
1275 >
1276 >        try { p.shutdown(); } catch (SecurityException ok) { return; }
1277          try {
1278 <            RejectedExecutionHandler r = null;
1279 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10),r);
1278 >            TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1279 >            p.execute(r);
1280 >            assertFalse(r.done);
1281 >        } finally {
1282 >            joinPool(p);
1283 >        }
1284 >    }
1285 >
1286 >    /**
1287 >     * execute(null) throws NPE
1288 >     */
1289 >    public void testExecuteNull() {
1290 >        ThreadPoolExecutor p =
1291 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
1292 >                                   new ArrayBlockingQueue<Runnable>(10));
1293 >        try {
1294 >            p.execute(null);
1295 >            shouldThrow();
1296 >        } catch (NullPointerException success) {}
1297 >
1298 >        joinPool(p);
1299 >    }
1300 >
1301 >    /**
1302 >     * setCorePoolSize of negative value throws IllegalArgumentException
1303 >     */
1304 >    public void testCorePoolSizeIllegalArgumentException() {
1305 >        ThreadPoolExecutor p =
1306 >            new ThreadPoolExecutor(1, 2,
1307 >                                   LONG_DELAY_MS, MILLISECONDS,
1308 >                                   new ArrayBlockingQueue<Runnable>(10));
1309 >        try {
1310 >            p.setCorePoolSize(-1);
1311              shouldThrow();
1312 +        } catch (IllegalArgumentException success) {
1313 +        } finally {
1314 +            try { p.shutdown(); } catch (SecurityException ok) { return; }
1315          }
1316 <        catch (NullPointerException success){}  
1316 >        joinPool(p);
1317      }
1318  
1319 <    
1320 <    /**
1321 <     * Constructor throws if corePoolSize argument is less than zero
1319 >    /**
1320 >     * setMaximumPoolSize(int) throws IllegalArgumentException if
1321 >     * given a value less the core pool size
1322       */
1323 <    public void testConstructor16() {
1323 >    public void testMaximumPoolSizeIllegalArgumentException() {
1324 >        ThreadPoolExecutor p =
1325 >            new ThreadPoolExecutor(2, 3,
1326 >                                   LONG_DELAY_MS, MILLISECONDS,
1327 >                                   new ArrayBlockingQueue<Runnable>(10));
1328          try {
1329 <            new ThreadPoolExecutor(-1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory(),new MyREHandler());
1329 >            p.setMaximumPoolSize(1);
1330              shouldThrow();
1331 +        } catch (IllegalArgumentException success) {
1332 +        } finally {
1333 +            try { p.shutdown(); } catch (SecurityException ok) { return; }
1334          }
1335 <        catch (IllegalArgumentException success){}
1335 >        joinPool(p);
1336      }
1337  
1338 <    /**
1339 <     * Constructor throws if maximumPoolSize is less than zero
1338 >    /**
1339 >     * setMaximumPoolSize throws IllegalArgumentException
1340 >     * if given a negative value
1341       */
1342 <    public void testConstructor17() {
1342 >    public void testMaximumPoolSizeIllegalArgumentException2() {
1343 >        ThreadPoolExecutor p =
1344 >            new ThreadPoolExecutor(2, 3,
1345 >                                   LONG_DELAY_MS, MILLISECONDS,
1346 >                                   new ArrayBlockingQueue<Runnable>(10));
1347          try {
1348 <            new ThreadPoolExecutor(1,-1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory(),new MyREHandler());
1348 >            p.setMaximumPoolSize(-1);
1349              shouldThrow();
1350 +        } catch (IllegalArgumentException success) {
1351 +        } finally {
1352 +            try { p.shutdown(); } catch (SecurityException ok) { return; }
1353          }
1354 <        catch (IllegalArgumentException success){}
1354 >        joinPool(p);
1355      }
1356  
1357 <    /**
1358 <     * Constructor throws if maximumPoolSize is equal to zero
1357 >    /**
1358 >     * Configuration changes that allow core pool size greater than
1359 >     * max pool size result in IllegalArgumentException.
1360       */
1361 <    public void testConstructor18() {
1361 >    public void testPoolSizeInvariants() {
1362 >        ThreadPoolExecutor p =
1363 >            new ThreadPoolExecutor(1, 1,
1364 >                                   LONG_DELAY_MS, MILLISECONDS,
1365 >                                   new ArrayBlockingQueue<Runnable>(10));
1366 >        for (int s = 1; s < 5; s++) {
1367 >            p.setMaximumPoolSize(s);
1368 >            p.setCorePoolSize(s);
1369 >            try {
1370 >                p.setMaximumPoolSize(s - 1);
1371 >                shouldThrow();
1372 >            } catch (IllegalArgumentException success) {}
1373 >            assertEquals(s, p.getCorePoolSize());
1374 >            assertEquals(s, p.getMaximumPoolSize());
1375 >            try {
1376 >                p.setCorePoolSize(s + 1);
1377 >                shouldThrow();
1378 >            } catch (IllegalArgumentException success) {}
1379 >            assertEquals(s, p.getCorePoolSize());
1380 >            assertEquals(s, p.getMaximumPoolSize());
1381 >        }
1382 >        joinPool(p);
1383 >    }
1384 >
1385 >    /**
1386 >     * setKeepAliveTime throws IllegalArgumentException
1387 >     * when given a negative value
1388 >     */
1389 >    public void testKeepAliveTimeIllegalArgumentException() {
1390 >        ThreadPoolExecutor p =
1391 >            new ThreadPoolExecutor(2, 3,
1392 >                                   LONG_DELAY_MS, MILLISECONDS,
1393 >                                   new ArrayBlockingQueue<Runnable>(10));
1394          try {
1395 <            new ThreadPoolExecutor(1,0,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory(),new MyREHandler());
1395 >            p.setKeepAliveTime(-1,MILLISECONDS);
1396              shouldThrow();
1397 +        } catch (IllegalArgumentException success) {
1398 +        } finally {
1399 +            try { p.shutdown(); } catch (SecurityException ok) { return; }
1400          }
1401 <        catch (IllegalArgumentException success){}
1401 >        joinPool(p);
1402      }
1403  
1404 <    /**
1405 <     * Constructor throws if keepAliveTime is less than zero
1404 >    /**
1405 >     * terminated() is called on termination
1406       */
1407 <    public void testConstructor19() {
1407 >    public void testTerminated() {
1408 >        ExtendedTPE p = new ExtendedTPE();
1409 >        try { p.shutdown(); } catch (SecurityException ok) { return; }
1410 >        assertTrue(p.terminatedCalled());
1411 >        joinPool(p);
1412 >    }
1413 >
1414 >    /**
1415 >     * beforeExecute and afterExecute are called when executing task
1416 >     */
1417 >    public void testBeforeAfter() throws InterruptedException {
1418 >        ExtendedTPE p = new ExtendedTPE();
1419 >        try {
1420 >            final CountDownLatch done = new CountDownLatch(1);
1421 >            p.execute(new CheckedRunnable() {
1422 >                public void realRun() {
1423 >                    done.countDown();
1424 >                }});
1425 >            await(p.afterCalled);
1426 >            assertEquals(0, done.getCount());
1427 >            assertTrue(p.afterCalled());
1428 >            assertTrue(p.beforeCalled());
1429 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
1430 >        } finally {
1431 >            joinPool(p);
1432 >        }
1433 >    }
1434 >
1435 >    /**
1436 >     * completed submit of callable returns result
1437 >     */
1438 >    public void testSubmitCallable() throws Exception {
1439 >        ExecutorService e =
1440 >            new ThreadPoolExecutor(2, 2,
1441 >                                   LONG_DELAY_MS, MILLISECONDS,
1442 >                                   new ArrayBlockingQueue<Runnable>(10));
1443 >        try {
1444 >            Future<String> future = e.submit(new StringTask());
1445 >            String result = future.get();
1446 >            assertSame(TEST_STRING, result);
1447 >        } finally {
1448 >            joinPool(e);
1449 >        }
1450 >    }
1451 >
1452 >    /**
1453 >     * completed submit of runnable returns successfully
1454 >     */
1455 >    public void testSubmitRunnable() throws Exception {
1456 >        ExecutorService e =
1457 >            new ThreadPoolExecutor(2, 2,
1458 >                                   LONG_DELAY_MS, MILLISECONDS,
1459 >                                   new ArrayBlockingQueue<Runnable>(10));
1460          try {
1461 <            new ThreadPoolExecutor(1,2,-1L,TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory(),new MyREHandler());
1461 >            Future<?> future = e.submit(new NoOpRunnable());
1462 >            future.get();
1463 >            assertTrue(future.isDone());
1464 >        } finally {
1465 >            joinPool(e);
1466 >        }
1467 >    }
1468 >
1469 >    /**
1470 >     * completed submit of (runnable, result) returns result
1471 >     */
1472 >    public void testSubmitRunnable2() throws Exception {
1473 >        ExecutorService e =
1474 >            new ThreadPoolExecutor(2, 2,
1475 >                                   LONG_DELAY_MS, MILLISECONDS,
1476 >                                   new ArrayBlockingQueue<Runnable>(10));
1477 >        try {
1478 >            Future<String> future = e.submit(new NoOpRunnable(), TEST_STRING);
1479 >            String result = future.get();
1480 >            assertSame(TEST_STRING, result);
1481 >        } finally {
1482 >            joinPool(e);
1483 >        }
1484 >    }
1485 >
1486 >    /**
1487 >     * invokeAny(null) throws NPE
1488 >     */
1489 >    public void testInvokeAny1() throws Exception {
1490 >        ExecutorService e =
1491 >            new ThreadPoolExecutor(2, 2,
1492 >                                   LONG_DELAY_MS, MILLISECONDS,
1493 >                                   new ArrayBlockingQueue<Runnable>(10));
1494 >        try {
1495 >            e.invokeAny(null);
1496              shouldThrow();
1497 +        } catch (NullPointerException success) {
1498 +        } finally {
1499 +            joinPool(e);
1500          }
524        catch (IllegalArgumentException success){}
1501      }
1502  
1503 <    /**
1504 <     * Constructor throws if corePoolSize is greater than the maximumPoolSize
1503 >    /**
1504 >     * invokeAny(empty collection) throws IAE
1505       */
1506 <    public void testConstructor20() {
1506 >    public void testInvokeAny2() throws Exception {
1507 >        ExecutorService e =
1508 >            new ThreadPoolExecutor(2, 2,
1509 >                                   LONG_DELAY_MS, MILLISECONDS,
1510 >                                   new ArrayBlockingQueue<Runnable>(10));
1511          try {
1512 <            new ThreadPoolExecutor(2,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory(),new MyREHandler());
1512 >            e.invokeAny(new ArrayList<Callable<String>>());
1513              shouldThrow();
1514 +        } catch (IllegalArgumentException success) {
1515 +        } finally {
1516 +            joinPool(e);
1517          }
535        catch (IllegalArgumentException success){}
1518      }
1519  
1520 <    /**
1521 <     * Constructor throws if workQueue is set to null
1520 >    /**
1521 >     * invokeAny(c) throws NPE if c has null elements
1522       */
1523 <    public void testNullPointerException6() {
1523 >    public void testInvokeAny3() throws Exception {
1524 >        final CountDownLatch latch = new CountDownLatch(1);
1525 >        final ExecutorService e =
1526 >            new ThreadPoolExecutor(2, 2,
1527 >                                   LONG_DELAY_MS, MILLISECONDS,
1528 >                                   new ArrayBlockingQueue<Runnable>(10));
1529 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1530 >        l.add(latchAwaitingStringTask(latch));
1531 >        l.add(null);
1532          try {
1533 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,null,new MyThreadFactory(),new MyREHandler());
1533 >            e.invokeAny(l);
1534              shouldThrow();
1535 +        } catch (NullPointerException success) {
1536 +        } finally {
1537 +            latch.countDown();
1538 +            joinPool(e);
1539          }
546        catch (NullPointerException success){}  
1540      }
1541  
1542 <    /**
1543 <     * Constructor throws if handler is set to null
1542 >    /**
1543 >     * invokeAny(c) throws ExecutionException if no task completes
1544       */
1545 <    public void testNullPointerException7() {
1545 >    public void testInvokeAny4() throws Exception {
1546 >        ExecutorService e =
1547 >            new ThreadPoolExecutor(2, 2,
1548 >                                   LONG_DELAY_MS, MILLISECONDS,
1549 >                                   new ArrayBlockingQueue<Runnable>(10));
1550 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1551 >        l.add(new NPETask());
1552          try {
1553 <            RejectedExecutionHandler r = null;
555 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10),new MyThreadFactory(),r);
1553 >            e.invokeAny(l);
1554              shouldThrow();
1555 +        } catch (ExecutionException success) {
1556 +            assertTrue(success.getCause() instanceof NullPointerException);
1557 +        } finally {
1558 +            joinPool(e);
1559          }
558        catch (NullPointerException success){}  
1560      }
1561  
1562 <    /**
1563 <     * Constructor throws if ThreadFactory is set top null
1562 >    /**
1563 >     * invokeAny(c) returns result of some task
1564       */
1565 <    public void testNullPointerException8() {
1565 >    public void testInvokeAny5() throws Exception {
1566 >        ExecutorService e =
1567 >            new ThreadPoolExecutor(2, 2,
1568 >                                   LONG_DELAY_MS, MILLISECONDS,
1569 >                                   new ArrayBlockingQueue<Runnable>(10));
1570          try {
1571 <            ThreadFactory f = null;
1572 <            new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10),f,new MyREHandler());
1571 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1572 >            l.add(new StringTask());
1573 >            l.add(new StringTask());
1574 >            String result = e.invokeAny(l);
1575 >            assertSame(TEST_STRING, result);
1576 >        } finally {
1577 >            joinPool(e);
1578 >        }
1579 >    }
1580 >
1581 >    /**
1582 >     * invokeAll(null) throws NPE
1583 >     */
1584 >    public void testInvokeAll1() throws Exception {
1585 >        ExecutorService e =
1586 >            new ThreadPoolExecutor(2, 2,
1587 >                                   LONG_DELAY_MS, MILLISECONDS,
1588 >                                   new ArrayBlockingQueue<Runnable>(10));
1589 >        try {
1590 >            e.invokeAll(null);
1591              shouldThrow();
1592 +        } catch (NullPointerException success) {
1593 +        } finally {
1594 +            joinPool(e);
1595          }
570        catch (NullPointerException successdn8){}  
1596      }
572    
1597  
1598      /**
1599 <     *  execute throws RejectedExecutionException if shutdown
1599 >     * invokeAll(empty collection) returns empty collection
1600       */
1601 <    public void testRejectedExecutionException() {
1602 <        ThreadPoolExecutor tpe = null;
1601 >    public void testInvokeAll2() throws InterruptedException {
1602 >        ExecutorService e =
1603 >            new ThreadPoolExecutor(2, 2,
1604 >                                   LONG_DELAY_MS, MILLISECONDS,
1605 >                                   new ArrayBlockingQueue<Runnable>(10));
1606          try {
1607 <            tpe = new ThreadPoolExecutor(1,1,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(1));
1608 <        } catch(Exception e){}
1609 <        tpe.shutdown();
1610 <        try {
1611 <            tpe.execute(new NoOpRunnable());
585 <            shouldThrow();
586 <        } catch(RejectedExecutionException success){}
587 <        
588 <        joinPool(tpe);
1607 >            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>());
1608 >            assertTrue(r.isEmpty());
1609 >        } finally {
1610 >            joinPool(e);
1611 >        }
1612      }
1613  
1614      /**
1615 <     *  execute throws RejectedExecutionException
593 <     *  if saturated.
1615 >     * invokeAll(c) throws NPE if c has null elements
1616       */
1617 <    public void testSaturatedExecute() {
1618 <        ThreadPoolExecutor p = new ThreadPoolExecutor(1,1, SHORT_DELAY_MS, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(1));
1617 >    public void testInvokeAll3() throws Exception {
1618 >        ExecutorService e =
1619 >            new ThreadPoolExecutor(2, 2,
1620 >                                   LONG_DELAY_MS, MILLISECONDS,
1621 >                                   new ArrayBlockingQueue<Runnable>(10));
1622 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1623 >        l.add(new StringTask());
1624 >        l.add(null);
1625 >        try {
1626 >            e.invokeAll(l);
1627 >            shouldThrow();
1628 >        } catch (NullPointerException success) {
1629 >        } finally {
1630 >            joinPool(e);
1631 >        }
1632 >    }
1633 >
1634 >    /**
1635 >     * get of element of invokeAll(c) throws exception on failed task
1636 >     */
1637 >    public void testInvokeAll4() throws Exception {
1638 >        ExecutorService e =
1639 >            new ThreadPoolExecutor(2, 2,
1640 >                                   LONG_DELAY_MS, MILLISECONDS,
1641 >                                   new ArrayBlockingQueue<Runnable>(10));
1642          try {
1643 <            
1644 <            for(int i = 0; i < 5; ++i){
1645 <                p.execute(new MediumRunnable());
1643 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1644 >            l.add(new NPETask());
1645 >            List<Future<String>> futures = e.invokeAll(l);
1646 >            assertEquals(1, futures.size());
1647 >            try {
1648 >                futures.get(0).get();
1649 >                shouldThrow();
1650 >            } catch (ExecutionException success) {
1651 >                assertTrue(success.getCause() instanceof NullPointerException);
1652              }
1653 +        } finally {
1654 +            joinPool(e);
1655 +        }
1656 +    }
1657 +
1658 +    /**
1659 +     * invokeAll(c) returns results of all completed tasks
1660 +     */
1661 +    public void testInvokeAll5() throws Exception {
1662 +        ExecutorService e =
1663 +            new ThreadPoolExecutor(2, 2,
1664 +                                   LONG_DELAY_MS, MILLISECONDS,
1665 +                                   new ArrayBlockingQueue<Runnable>(10));
1666 +        try {
1667 +            List<Callable<String>> l = new ArrayList<Callable<String>>();
1668 +            l.add(new StringTask());
1669 +            l.add(new StringTask());
1670 +            List<Future<String>> futures = e.invokeAll(l);
1671 +            assertEquals(2, futures.size());
1672 +            for (Future<String> future : futures)
1673 +                assertSame(TEST_STRING, future.get());
1674 +        } finally {
1675 +            joinPool(e);
1676 +        }
1677 +    }
1678 +
1679 +    /**
1680 +     * timed invokeAny(null) throws NPE
1681 +     */
1682 +    public void testTimedInvokeAny1() throws Exception {
1683 +        ExecutorService e =
1684 +            new ThreadPoolExecutor(2, 2,
1685 +                                   LONG_DELAY_MS, MILLISECONDS,
1686 +                                   new ArrayBlockingQueue<Runnable>(10));
1687 +        try {
1688 +            e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
1689              shouldThrow();
1690 <        } catch(RejectedExecutionException success){}
1691 <        joinPool(p);
1690 >        } catch (NullPointerException success) {
1691 >        } finally {
1692 >            joinPool(e);
1693 >        }
1694      }
1695  
1696      /**
1697 <     *  execute (null) throws NPE
1697 >     * timed invokeAny(,,null) throws NPE
1698       */
1699 <    public void testExecuteNull() {
1700 <        ThreadPoolExecutor tpe = null;
1699 >    public void testTimedInvokeAnyNullTimeUnit() throws Exception {
1700 >        ExecutorService e =
1701 >            new ThreadPoolExecutor(2, 2,
1702 >                                   LONG_DELAY_MS, MILLISECONDS,
1703 >                                   new ArrayBlockingQueue<Runnable>(10));
1704 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1705 >        l.add(new StringTask());
1706          try {
1707 <            tpe = new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10));
614 <            tpe.execute(null);
1707 >            e.invokeAny(l, MEDIUM_DELAY_MS, null);
1708              shouldThrow();
1709 <        } catch(NullPointerException success){}
1710 <        
1711 <        joinPool(tpe);
1709 >        } catch (NullPointerException success) {
1710 >        } finally {
1711 >            joinPool(e);
1712 >        }
1713      }
1714 <    
1714 >
1715      /**
1716 <     *  setCorePoolSize of netaitev value throws IllegalArgumentException
1716 >     * timed invokeAny(empty collection) throws IAE
1717       */
1718 <    public void testCorePoolSizeIllegalArgumentException() {
1719 <        ThreadPoolExecutor tpe = null;
1720 <        try {
1721 <            tpe = new ThreadPoolExecutor(1,2,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10));
1722 <        } catch(Exception e){}
629 <        try {
630 <            tpe.setCorePoolSize(-1);
631 <            shouldThrow();
632 <        } catch(IllegalArgumentException success){
633 <        } finally {
634 <            tpe.shutdown();
635 <        }
636 <        joinPool(tpe);
637 <    }  
638 <
639 <    /**
640 <     *  setMaximumPoolSize(int) throws IllegalArgumentException if
641 <     *  given a value less the core pool size
642 <     */  
643 <    public void testMaximumPoolSizeIllegalArgumentException() {
644 <        ThreadPoolExecutor tpe = null;
1718 >    public void testTimedInvokeAny2() throws Exception {
1719 >        ExecutorService e =
1720 >            new ThreadPoolExecutor(2, 2,
1721 >                                   LONG_DELAY_MS, MILLISECONDS,
1722 >                                   new ArrayBlockingQueue<Runnable>(10));
1723          try {
1724 <            tpe = new ThreadPoolExecutor(2,3,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10));
1725 <        } catch(Exception e){}
1724 >            e.invokeAny(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1725 >            shouldThrow();
1726 >        } catch (IllegalArgumentException success) {
1727 >        } finally {
1728 >            joinPool(e);
1729 >        }
1730 >    }
1731 >
1732 >    /**
1733 >     * timed invokeAny(c) throws NPE if c has null elements
1734 >     */
1735 >    public void testTimedInvokeAny3() throws Exception {
1736 >        final CountDownLatch latch = new CountDownLatch(1);
1737 >        final ExecutorService e =
1738 >            new ThreadPoolExecutor(2, 2,
1739 >                                   LONG_DELAY_MS, MILLISECONDS,
1740 >                                   new ArrayBlockingQueue<Runnable>(10));
1741 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1742 >        l.add(latchAwaitingStringTask(latch));
1743 >        l.add(null);
1744          try {
1745 <            tpe.setMaximumPoolSize(1);
1745 >            e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1746              shouldThrow();
1747 <        } catch(IllegalArgumentException success){
1747 >        } catch (NullPointerException success) {
1748          } finally {
1749 <            tpe.shutdown();
1749 >            latch.countDown();
1750 >            joinPool(e);
1751          }
655        joinPool(tpe);
1752      }
1753 <    
1753 >
1754      /**
1755 <     *  setMaximumPoolSize throws IllegalArgumentException
660 <     *  if given a negative value
1755 >     * timed invokeAny(c) throws ExecutionException if no task completes
1756       */
1757 <    public void testMaximumPoolSizeIllegalArgumentException2() {
1758 <        ThreadPoolExecutor tpe = null;
1757 >    public void testTimedInvokeAny4() throws Exception {
1758 >        ExecutorService e =
1759 >            new ThreadPoolExecutor(2, 2,
1760 >                                   LONG_DELAY_MS, MILLISECONDS,
1761 >                                   new ArrayBlockingQueue<Runnable>(10));
1762 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1763 >        l.add(new NPETask());
1764          try {
1765 <            tpe = new ThreadPoolExecutor(2,3,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10));
1766 <        } catch(Exception e){}
1765 >            e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1766 >            shouldThrow();
1767 >        } catch (ExecutionException success) {
1768 >            assertTrue(success.getCause() instanceof NullPointerException);
1769 >        } finally {
1770 >            joinPool(e);
1771 >        }
1772 >    }
1773 >
1774 >    /**
1775 >     * timed invokeAny(c) returns result of some task
1776 >     */
1777 >    public void testTimedInvokeAny5() throws Exception {
1778 >        ExecutorService e =
1779 >            new ThreadPoolExecutor(2, 2,
1780 >                                   LONG_DELAY_MS, MILLISECONDS,
1781 >                                   new ArrayBlockingQueue<Runnable>(10));
1782          try {
1783 <            tpe.setMaximumPoolSize(-1);
1783 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1784 >            l.add(new StringTask());
1785 >            l.add(new StringTask());
1786 >            String result = e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1787 >            assertSame(TEST_STRING, result);
1788 >        } finally {
1789 >            joinPool(e);
1790 >        }
1791 >    }
1792 >
1793 >    /**
1794 >     * timed invokeAll(null) throws NPE
1795 >     */
1796 >    public void testTimedInvokeAll1() throws Exception {
1797 >        ExecutorService e =
1798 >            new ThreadPoolExecutor(2, 2,
1799 >                                   LONG_DELAY_MS, MILLISECONDS,
1800 >                                   new ArrayBlockingQueue<Runnable>(10));
1801 >        try {
1802 >            e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
1803              shouldThrow();
1804 <        } catch(IllegalArgumentException success){
1804 >        } catch (NullPointerException success) {
1805          } finally {
1806 <            tpe.shutdown();
1806 >            joinPool(e);
1807          }
674        joinPool(tpe);
1808      }
676    
1809  
1810      /**
1811 <     *  setKeepAliveTime  throws IllegalArgumentException
680 <     *  when given a negative value
1811 >     * timed invokeAll(,,null) throws NPE
1812       */
1813 <    public void testKeepAliveTimeIllegalArgumentException() {
1814 <        ThreadPoolExecutor tpe = null;
1813 >    public void testTimedInvokeAllNullTimeUnit() throws Exception {
1814 >        ExecutorService e =
1815 >            new ThreadPoolExecutor(2, 2,
1816 >                                   LONG_DELAY_MS, MILLISECONDS,
1817 >                                   new ArrayBlockingQueue<Runnable>(10));
1818 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1819 >        l.add(new StringTask());
1820 >        try {
1821 >            e.invokeAll(l, MEDIUM_DELAY_MS, null);
1822 >            shouldThrow();
1823 >        } catch (NullPointerException success) {
1824 >        } finally {
1825 >            joinPool(e);
1826 >        }
1827 >    }
1828 >
1829 >    /**
1830 >     * timed invokeAll(empty collection) returns empty collection
1831 >     */
1832 >    public void testTimedInvokeAll2() throws InterruptedException {
1833 >        ExecutorService e =
1834 >            new ThreadPoolExecutor(2, 2,
1835 >                                   LONG_DELAY_MS, MILLISECONDS,
1836 >                                   new ArrayBlockingQueue<Runnable>(10));
1837 >        try {
1838 >            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1839 >            assertTrue(r.isEmpty());
1840 >        } finally {
1841 >            joinPool(e);
1842 >        }
1843 >    }
1844 >
1845 >    /**
1846 >     * timed invokeAll(c) throws NPE if c has null elements
1847 >     */
1848 >    public void testTimedInvokeAll3() throws Exception {
1849 >        ExecutorService e =
1850 >            new ThreadPoolExecutor(2, 2,
1851 >                                   LONG_DELAY_MS, MILLISECONDS,
1852 >                                   new ArrayBlockingQueue<Runnable>(10));
1853 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1854 >        l.add(new StringTask());
1855 >        l.add(null);
1856 >        try {
1857 >            e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1858 >            shouldThrow();
1859 >        } catch (NullPointerException success) {
1860 >        } finally {
1861 >            joinPool(e);
1862 >        }
1863 >    }
1864 >
1865 >    /**
1866 >     * get of element of invokeAll(c) throws exception on failed task
1867 >     */
1868 >    public void testTimedInvokeAll4() throws Exception {
1869 >        ExecutorService e =
1870 >            new ThreadPoolExecutor(2, 2,
1871 >                                   LONG_DELAY_MS, MILLISECONDS,
1872 >                                   new ArrayBlockingQueue<Runnable>(10));
1873 >        List<Callable<String>> l = new ArrayList<Callable<String>>();
1874 >        l.add(new NPETask());
1875 >        List<Future<String>> futures =
1876 >            e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1877 >        assertEquals(1, futures.size());
1878          try {
1879 <            tpe = new ThreadPoolExecutor(2,3,SHORT_DELAY_MS, TimeUnit.MILLISECONDS,new ArrayBlockingQueue<Runnable>(10));
686 <        } catch(Exception e){}
687 <        
688 <        try {
689 <            tpe.setKeepAliveTime(-1,TimeUnit.MILLISECONDS);
1879 >            futures.get(0).get();
1880              shouldThrow();
1881 <        } catch(IllegalArgumentException success){
1881 >        } catch (ExecutionException success) {
1882 >            assertTrue(success.getCause() instanceof NullPointerException);
1883          } finally {
1884 <            tpe.shutdown();
1884 >            joinPool(e);
1885          }
695        joinPool(tpe);
1886      }
1887 <  
1887 >
1888 >    /**
1889 >     * timed invokeAll(c) returns results of all completed tasks
1890 >     */
1891 >    public void testTimedInvokeAll5() throws Exception {
1892 >        ExecutorService e =
1893 >            new ThreadPoolExecutor(2, 2,
1894 >                                   LONG_DELAY_MS, MILLISECONDS,
1895 >                                   new ArrayBlockingQueue<Runnable>(10));
1896 >        try {
1897 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1898 >            l.add(new StringTask());
1899 >            l.add(new StringTask());
1900 >            List<Future<String>> futures =
1901 >                e.invokeAll(l, LONG_DELAY_MS, MILLISECONDS);
1902 >            assertEquals(2, futures.size());
1903 >            for (Future<String> future : futures)
1904 >                assertSame(TEST_STRING, future.get());
1905 >        } finally {
1906 >            joinPool(e);
1907 >        }
1908 >    }
1909 >
1910 >    /**
1911 >     * timed invokeAll(c) cancels tasks not completed by timeout
1912 >     */
1913 >    public void testTimedInvokeAll6() throws Exception {
1914 >        ExecutorService e =
1915 >            new ThreadPoolExecutor(2, 2,
1916 >                                   LONG_DELAY_MS, MILLISECONDS,
1917 >                                   new ArrayBlockingQueue<Runnable>(10));
1918 >        try {
1919 >            for (long timeout = timeoutMillis();;) {
1920 >                List<Callable<String>> tasks = new ArrayList<>();
1921 >                tasks.add(new StringTask("0"));
1922 >                tasks.add(Executors.callable(new LongPossiblyInterruptedRunnable(), TEST_STRING));
1923 >                tasks.add(new StringTask("2"));
1924 >                long startTime = System.nanoTime();
1925 >                List<Future<String>> futures =
1926 >                    e.invokeAll(tasks, timeout, MILLISECONDS);
1927 >                assertEquals(tasks.size(), futures.size());
1928 >                assertTrue(millisElapsedSince(startTime) >= timeout);
1929 >                for (Future future : futures)
1930 >                    assertTrue(future.isDone());
1931 >                assertTrue(futures.get(1).isCancelled());
1932 >                try {
1933 >                    assertEquals("0", futures.get(0).get());
1934 >                    assertEquals("2", futures.get(2).get());
1935 >                    break;
1936 >                } catch (CancellationException retryWithLongerTimeout) {
1937 >                    timeout *= 2;
1938 >                    if (timeout >= LONG_DELAY_MS / 2)
1939 >                        fail("expected exactly one task to be cancelled");
1940 >                }
1941 >            }
1942 >        } finally {
1943 >            joinPool(e);
1944 >        }
1945 >    }
1946 >
1947 >    /**
1948 >     * Execution continues if there is at least one thread even if
1949 >     * thread factory fails to create more
1950 >     */
1951 >    public void testFailingThreadFactory() throws InterruptedException {
1952 >        final ExecutorService e =
1953 >            new ThreadPoolExecutor(100, 100,
1954 >                                   LONG_DELAY_MS, MILLISECONDS,
1955 >                                   new LinkedBlockingQueue<Runnable>(),
1956 >                                   new FailingThreadFactory());
1957 >        try {
1958 >            final int TASKS = 100;
1959 >            final CountDownLatch done = new CountDownLatch(TASKS);
1960 >            for (int k = 0; k < TASKS; ++k)
1961 >                e.execute(new CheckedRunnable() {
1962 >                    public void realRun() {
1963 >                        done.countDown();
1964 >                    }});
1965 >            assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
1966 >        } finally {
1967 >            joinPool(e);
1968 >        }
1969 >    }
1970 >
1971 >    /**
1972 >     * allowsCoreThreadTimeOut is by default false.
1973 >     */
1974 >    public void testAllowsCoreThreadTimeOut() {
1975 >        final ThreadPoolExecutor p =
1976 >            new ThreadPoolExecutor(2, 2,
1977 >                                   1000, MILLISECONDS,
1978 >                                   new ArrayBlockingQueue<Runnable>(10));
1979 >        assertFalse(p.allowsCoreThreadTimeOut());
1980 >        joinPool(p);
1981 >    }
1982 >
1983 >    /**
1984 >     * allowCoreThreadTimeOut(true) causes idle threads to time out
1985 >     */
1986 >    public void testAllowCoreThreadTimeOut_true() throws Exception {
1987 >        long keepAliveTime = timeoutMillis();
1988 >        final ThreadPoolExecutor p =
1989 >            new ThreadPoolExecutor(2, 10,
1990 >                                   keepAliveTime, MILLISECONDS,
1991 >                                   new ArrayBlockingQueue<Runnable>(10));
1992 >        final CountDownLatch threadStarted = new CountDownLatch(1);
1993 >        try {
1994 >            p.allowCoreThreadTimeOut(true);
1995 >            p.execute(new CheckedRunnable() {
1996 >                public void realRun() {
1997 >                    threadStarted.countDown();
1998 >                    assertEquals(1, p.getPoolSize());
1999 >                }});
2000 >            await(threadStarted);
2001 >            delay(keepAliveTime);
2002 >            long startTime = System.nanoTime();
2003 >            while (p.getPoolSize() > 0
2004 >                   && millisElapsedSince(startTime) < LONG_DELAY_MS)
2005 >                Thread.yield();
2006 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
2007 >            assertEquals(0, p.getPoolSize());
2008 >        } finally {
2009 >            joinPool(p);
2010 >        }
2011 >    }
2012 >
2013 >    /**
2014 >     * allowCoreThreadTimeOut(false) causes idle threads not to time out
2015 >     */
2016 >    public void testAllowCoreThreadTimeOut_false() throws Exception {
2017 >        long keepAliveTime = timeoutMillis();
2018 >        final ThreadPoolExecutor p =
2019 >            new ThreadPoolExecutor(2, 10,
2020 >                                   keepAliveTime, MILLISECONDS,
2021 >                                   new ArrayBlockingQueue<Runnable>(10));
2022 >        final CountDownLatch threadStarted = new CountDownLatch(1);
2023 >        try {
2024 >            p.allowCoreThreadTimeOut(false);
2025 >            p.execute(new CheckedRunnable() {
2026 >                public void realRun() throws InterruptedException {
2027 >                    threadStarted.countDown();
2028 >                    assertTrue(p.getPoolSize() >= 1);
2029 >                }});
2030 >            delay(2 * keepAliveTime);
2031 >            assertTrue(p.getPoolSize() >= 1);
2032 >        } finally {
2033 >            joinPool(p);
2034 >        }
2035 >    }
2036 >
2037 >    /**
2038 >     * execute allows the same task to be submitted multiple times, even
2039 >     * if rejected
2040 >     */
2041 >    public void testRejectedRecycledTask() throws InterruptedException {
2042 >        final int nTasks = 1000;
2043 >        final CountDownLatch done = new CountDownLatch(nTasks);
2044 >        final Runnable recycledTask = new Runnable() {
2045 >            public void run() {
2046 >                done.countDown();
2047 >            }};
2048 >        final ThreadPoolExecutor p =
2049 >            new ThreadPoolExecutor(1, 30,
2050 >                                   60, SECONDS,
2051 >                                   new ArrayBlockingQueue(30));
2052 >        try {
2053 >            for (int i = 0; i < nTasks; ++i) {
2054 >                for (;;) {
2055 >                    try {
2056 >                        p.execute(recycledTask);
2057 >                        break;
2058 >                    }
2059 >                    catch (RejectedExecutionException ignore) {}
2060 >                }
2061 >            }
2062 >            // enough time to run all tasks
2063 >            assertTrue(done.await(nTasks * SHORT_DELAY_MS, MILLISECONDS));
2064 >        } finally {
2065 >            joinPool(p);
2066 >        }
2067 >    }
2068 >
2069 >    /**
2070 >     * get(cancelled task) throws CancellationException
2071 >     */
2072 >    public void testGet_cancelled() throws Exception {
2073 >        final ExecutorService e =
2074 >            new ThreadPoolExecutor(1, 1,
2075 >                                   LONG_DELAY_MS, MILLISECONDS,
2076 >                                   new LinkedBlockingQueue<Runnable>());
2077 >        try {
2078 >            final CountDownLatch blockerStarted = new CountDownLatch(1);
2079 >            final CountDownLatch done = new CountDownLatch(1);
2080 >            final List<Future<?>> futures = new ArrayList<>();
2081 >            for (int i = 0; i < 2; i++) {
2082 >                Runnable r = new CheckedRunnable() { public void realRun()
2083 >                                                         throws Throwable {
2084 >                    blockerStarted.countDown();
2085 >                    assertTrue(done.await(2 * LONG_DELAY_MS, MILLISECONDS));
2086 >                }};
2087 >                futures.add(e.submit(r));
2088 >            }
2089 >            assertTrue(blockerStarted.await(LONG_DELAY_MS, MILLISECONDS));
2090 >            for (Future<?> future : futures) future.cancel(false);
2091 >            for (Future<?> future : futures) {
2092 >                try {
2093 >                    future.get();
2094 >                    shouldThrow();
2095 >                } catch (CancellationException success) {}
2096 >                try {
2097 >                    future.get(LONG_DELAY_MS, MILLISECONDS);
2098 >                    shouldThrow();
2099 >                } catch (CancellationException success) {}
2100 >                assertTrue(future.isCancelled());
2101 >                assertTrue(future.isDone());
2102 >            }
2103 >            done.countDown();
2104 >        } finally {
2105 >            joinPool(e);
2106 >        }
2107 >    }
2108 >
2109   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines