--- jsr166/build.xml	2003/05/29 15:53:58	1.35
+++ jsr166/build.xml	2003/05/30 03:24:18	1.37
@@ -77,6 +77,11 @@
 
     <mkdir dir="${build.classes.dir}"/>
 
+<!--
+    <echo>javac ${gjc.args}</echo>
+    <echo>bootclasspath=${compile.bootclasspath}</echo>
+-->
+
     <javac srcdir="${prepare.src.dir}"
           destdir="${build.classes.dir}"
             debug="${build.debug}"
@@ -85,8 +90,8 @@
            source="${build.sourcelevel}"
              fork="true">
 
-      <bootclasspath refid="javac.bootclasspath"/>
-      <compilerarg line="${build.javac.args}"/>
+      <compilerarg    line="${gjc.args}"/>
+      <bootclasspath refid="compile.bootclasspath"/>
 
     </javac>
 
@@ -177,8 +182,8 @@
            source="${build.sourcelevel}"
              fork="true">
 
-      <bootclasspath refid="javac.bootclasspath"/>
-      <compilerarg line="${build.javac.args} -s"/>
+      <compilerarg    line="${gjc.args} -s"/>
+      <bootclasspath refid="compile.bootclasspath"/>
 
     </javac>
 
@@ -272,8 +277,8 @@
            source="${build.sourcelevel}"
              fork="true">
 
-      <bootclasspath refid="javac.bootclasspath"/>
-      <compilerarg line="${build.javac.args}"/>
+      <compilerarg    line="${gjc.args}"/>
+      <bootclasspath refid="compile.bootclasspath"/>
 
     </javac>
 
@@ -327,41 +332,79 @@
       </fileset>
     </copy>
 
+    <!-- Not needed now, used for doccheck filtering:
+    <property name="generic.declarations"
+             value="public interface E {} public interface T {} public interface K {} public interface V {}"
+    />
+    -->
+
     <copy todir="${build.filter.src.dir}">
       <fileset dir="${src.dir}">
         <exclude name="**/*.html"/>
         <patternset refid="emulation.excludes"/>
       </fileset>
       <filterchain>
+
+        <!--
+         # This filter gets rid of angle-bracketed type parameters
+         # so that javadoc can run on the result. The following
+         # heuristic seems to work:
+         #
+         # For all lines not starting with space(s)-asterisk-space(s),
+         #   replace <something> with a space, where there may be more
+         #   than one right angle bracket at the end, and "something"
+         #   must not contain parens or pipes. (This may need some
+         #   tweaking.)
+         -->
+
         <filterreader classname="jsr166.ant.filters.ReplaceFilter"
                       classpath="${build.ant.dir}">
-          <!--
-           # These arguments are to get rid of angle-bracketed type
-           # parameters so that javadoc can run on the result. The
-           # following heuristic that seems to work:
-           #
-           # For all lines not starting with space(s)-asterisk-space(s),
-           #   replace <something> with a space, where there may be more
-           #   than one right angle bracket at the end, and "something"
-           #   must not contain parens or pipes. (This may need some
-           #   tweaking.)
-           -->
           <param name="notmatching" value="^\s+\*\s.*$"/>
-          <param name="pattern" value="&lt;[^|>()]+?>+"/>
+          <param name="pattern"     value="&lt;[^|>()]+?>+"/>
           <param name="replacement" value=" "/>
         </filterreader>
+
+
+        <!--
+         # This filter uncomments lines beginning with "//@" so that
+         # javadoc can see imports that are needed to resolve links
+         # but that shouldn't be in the compiled code.
+         -->
+
         <filterreader classname="jsr166.ant.filters.ReplaceFilter"
                       classpath="${build.ant.dir}">
-          <!--
-           # These arguments are to uncomment lines beginning with
-           # "//@" so that javadoc can see imports that are needed
-           # to resolve links but that shouldn't be in the compiled
-           # code.
-           -->
-          <param name="matching" value="^//@.*$"/>
-          <param name="pattern" value="^//@"/>
+          <param name="matching"    value="^//@.*$"/>
+          <param name="pattern"     value="^//@"/>
           <param name="replacement" value=""/>
         </filterreader>
+
+
+        <!--
+         # The next two filters try to make the source look like
+         # something that doccheck can process. The first removes
+         # -source 1.4 assertions and the second adds in a bunch
+         # of single letter public nested marker interfaces so that
+         # the generic type parameters are recognized.
+         #
+         # Currently commented out because doccheck doesn't work. :-(
+         -->
+
+        <!--
+        <filterreader classname="jsr166.ant.filters.ReplaceFilter"
+                      classpath="${build.ant.dir}">
+          <param name="matching"    value="^\s*assert[\s ].*$"/>
+          <param name="pattern"     value="assert"/>
+          <param name="replacement" value="//assert"/>
+        </filterreader>
+
+        <filterreader classname="jsr166.ant.filters.ReplaceFilter"
+                      classpath="${build.ant.dir}">
+          <param name="matching"    value="^(.*(class|interface|implements) .*|)\{.*$"/>
+          <param name="pattern"     value="$"/>
+          <param name="replacement" value=" ${generic.declarations}"/>
+        </filterreader>
+        -->
+
       </filterchain>
     </copy>
 
@@ -373,6 +416,12 @@
 
     <mkdir dir="${build.testcases.dir}"/>
 
+<!--
+    <echo>javac ${gjc.args}</echo>
+    <echo>bootclasspath=${test.compile.bootclasspath}</echo>
+    <echo>classpath="${test.classpath}"</echo>
+-->
+
     <javac srcdir="${test.src.dir}"
           destdir="${build.testcases.dir}"
             debug="${build.debug}"
@@ -381,9 +430,9 @@
            source="${build.sourcelevel}"
              fork="true">
 
-      <classpath refid="test.classpath"/>
-      <bootclasspath refid="javac.bootclasspath"/>
-      <compilerarg line="${build.javac.args}"/>
+      <compilerarg    line="${gjc.args}"/>
+      <bootclasspath refid="test.compile.bootclasspath"/>
+      <classpath     refid="test.classpath"/>
 
     </javac>
 
@@ -405,7 +454,7 @@
                     dir="${build.reports.dir}"
                    fork="true">
 
-      <jvmarg value="${test.bootclasspath.arg}"/>
+      <jvmarg value="-Xbootclasspath/p:${test.run.bootclasspath}"/>
 
       <formatter type="xml"/>
 
@@ -451,7 +500,7 @@
     <property name="gjc.version"
              value="2.0"/>
 
-    <condition property="build.novariance" value="-novariance">
+    <condition property="novariance.arg" value="-novariance">
       <and>
         <equals arg1="${gjc.version}" arg2="2.0"/>
         <or>
@@ -461,7 +510,7 @@
       </and>
     </condition>
 
-    <property name="build.novariance"
+    <property name="novariance.arg"
              value=""/>
 
     <property name="gjc.dir"
@@ -471,14 +520,14 @@
           location="${gjc.dir}/${gjc.version}/javac.jar"/>
 
     <property name="collect.jar"
-          location="${gjc.dir}/${gjc.version}/collect${build.novariance}.jar"/>
+          location="${gjc.dir}/${gjc.version}/collect${novariance.arg}.jar"/>
 
 
-    <condition property="build.warnunchecked" value="-warnunchecked">
+    <condition property="warnunchecked.arg" value="-warnunchecked">
       <istrue value="${gjc.warnunchecked}"/>
     </condition>
 
-    <property name="build.warnunchecked" value=""/>
+    <property name="warnunchecked.arg" value=""/>
 
     <condition property="prepare.src.dir" value="${build.dir}/prepare-src">
       <istrue value="${build.nothreads}"/>
@@ -489,35 +538,26 @@
      ! Bootclasspath munging for source compilation.
      -->
 
-    <path id="javac.bootclasspath.prefix">
+    <path id="pre.bootclasspath">
       <!-- <pathelement location="${src.dir}"/> -->
       <pathelement location="${javac.jar}"/>
     </path>
 
-    <path id="javac.bootclasspath">
+    <path id="compile.bootclasspath">
       <!-- <pathelement location="${src.dir}"/> -->
       <pathelement location="${collect.jar}"/>
       <pathelement location="${rt.jar}"/>
     </path>
 
-    <!-- Flatten bootclasspath prefix into a platform-appropriate string -->
-    <property name="javac.bootclasspath.prefix"
-             refid="javac.bootclasspath.prefix"/>
-
-    <!-- Turn the flattened bootclasspath prefix into a javac argument -->
-    <property name="build.bootclasspath.arg"
-             value='-J-Xbootclasspath/p:${javac.bootclasspath.prefix}'/>
-
-    <!-- Flatten bootclasspath for trace message -->
-    <property name="javac.bootclasspath"
-             refid="javac.bootclasspath"/>
+    <!-- Flatten paths into platform-appropriate strings -->
+    <property name="pre.bootclasspath"     refid="pre.bootclasspath"/>
+    <property name="compile.bootclasspath" refid="compile.bootclasspath"/>
 
-    <!-- Common options in javac invocations -->
-    <property name="build.javac.args"
-             value="${build.bootclasspath.arg} ${build.warnunchecked} ${build.novariance}"/>
 
-    <echo>javac ${build.javac.args}</echo>
-    <echo>bootclasspath=${javac.bootclasspath}</echo>
+    <!-- Common options in javac invocations -->
+    <property name="gjc.args"
+             value="-J-Xbootclasspath/p:${pre.bootclasspath} ${warnunchecked.arg} ${novariance.arg}"
+    />
 
   </target>
 
@@ -553,7 +593,8 @@
   </target>
 
 
-  <target name="configure-tests">
+  <target name="configure-tests"
+       depends="configure-compiler">
 
     <!-- junit.framework.Protectable is in JUnit 3.8.1 but not in 3.7 -->
     <available property="junit.available"
@@ -574,12 +615,21 @@
       <pathelement location="${junit.jar}"/>
     </path>
 
-    <!-- Flatten test classpath into a platform-appropriate string -->
-    <property name="test.classpath" refid="test.classpath"/>
+    <path id="test.compile.bootclasspath">
+      <pathelement location="${javac.jar}"/>
+      <pathelement location="${collect.jar}"/>
+      <pathelement location="${rt.jar}"/>
+    </path>
+
+    <path id="test.run.bootclasspath">
+      <pathelement location="${javac.jar}"/>
+      <path refid="test.classpath"/>
+    </path>
 
-    <!-- Turn the flattened test classpath into a javac argument -->
-    <property name="test.bootclasspath.arg"
-             value='-Xbootclasspath/p:${test.classpath}'/>
+    <!-- Flatten test classpaths into platform-appropriate strings -->
+    <property name="test.classpath"             refid="test.classpath"/>
+    <property name="test.compile.bootclasspath" refid="test.compile.bootclasspath"/>
+    <property name="test.run.bootclasspath"     refid="test.run.bootclasspath"/>
 
   </target>