--- jsr166/build.xml	2013/02/06 19:55:06	1.137
+++ jsr166/build.xml	2015/09/04 19:37:34	1.175
@@ -16,17 +16,23 @@
   $HOME/jdk/jdk6
   $HOME/jdk/jdk7
   $HOME/jdk/jdk8
+  $HOME/jdk/jdk9
   where each of the above is a JDK or a symlink to same, and
   $HOME/jdk/src/jdk6
   $HOME/jdk/src/jdk7
   $HOME/jdk/src/jdk8
+  $HOME/jdk/src/jdk9
   where each of the above is a complete JDK source tree
   (e.g. mercurial forest) or a symlink to same.
-As of 2013-02, the very latest lambda 8 jdk is needed for jdk8.
+
+  Alternatively, define ant variables thus:
+  ant -Djdk$N.home=...
+  for $N in 6 7 8 9 ...
 ------------------------------------------------------------------------------
   </description>
 
-  <target name="usage" description="Display main targets by running 'ant -projecthelp'">
+  <!-- Display main targets by running 'ant -projecthelp' -->
+  <target name="usage">
     <java classname="org.apache.tools.ant.Main">
       <arg value="-projecthelp" />
     </java>
@@ -44,6 +50,17 @@ As of 2013-02, the very latest lambda 8
   <property name="build.deprecation"    value="false"/>
   <property name="build.javadoc.access" value="protected"/>
 
+  <!-- Tck options; see JSR166TestCase.java
+   To profile a single tck test class:
+   ant -Djsr166.profileTests=true -Djsr166.profileThreshold=10 -Djsr166.tckTestClass=CompletableFutureTest tck
+   To stress test a single tck test class:
+   ant -Djsr166.tckTestClass=CountedCompleterTest -Djsr166.runsPerTest=100 tck
+  -->
+  <property name="jsr166.profileTests"     value="false"/>
+  <property name="jsr166.profileThreshold" value="100"/>
+  <property name="jsr166.runsPerTest"      value="1"/>
+  <property name="jsr166.tckTestClass"     value="JSR166TestCase"/>
+
   <!-- Build locations -->
   <property name="build.dir"                   location="build"/>
   <property name="build.classes.dir"           location="${build.dir}/classes"/>
@@ -105,13 +122,17 @@ As of 2013-02, the very latest lambda 8
   <defjdklocations v="6"/>
   <defjdklocations v="7"/>
   <defjdklocations v="8"/>
+  <defjdklocations v="9"/>
 
   <!-- Source locations -->
   <property name="src.dir"              location="${basedir}/src/main"/>
   <property name="test.src.dir"         location="${basedir}/src/test"/>
   <property name="loops.src.dir"        location="${basedir}/src/loops"/>
   <property name="tck.src.dir"          location="${test.src.dir}/tck"/>
-  <property name="jtreg.src.dir"        location="${test.src.dir}/jtreg"/>
+  <property name="jtreg7.src.dir"       location="${test.src.dir}/jtreg-jdk7"/>
+  <property name="jtreg8.src.dir"       location="${test.src.dir}/jtreg"/>
+  <property name="jtreg9.src.dir"       location="${test.src.dir}/jtreg"/>
+  <property name="jtreg.src.dir"        location="${jtreg9.src.dir}"/>
   <property name="lib.dir"              location="${basedir}/lib"/>
   <property name="dist.dir"             location="${basedir}/dist"/>
   <property name="topsrc.dir"           location="${basedir}/src"/>
@@ -145,17 +166,24 @@ As of 2013-02, the very latest lambda 8
   <property name="extra166y.jar"    location="${build.extra166y.dir}/extra166y.jar"/>
   <property name="junit.jar"        location="${lib.dir}/junit.jar"/>
 
-  <!-- Canonical location of jdk API docs, to use with javadoc link attribute -->
-  <property name="jdkapi5docs.url"      value="http://docs.oracle.com/javase/1.5.0/docs/api/"/>
-  <property name="jdkapi6docs.url"      value="http://docs.oracle.com/javase/6/docs/api/"/>
-  <property name="jdkapi7docs.url"      value="http://docs.oracle.com/javase/7/docs/api/"/>
-
-  <property name="jdkapi8docs.url"      value="http://download.java.net/jdk8/docs/api/"/>
-  <!-- The below does not yet exist as of 2013-01 -->
-  <!-- <property name="jdkapi8docs.url" value="http://docs.oracle.com/javase/8/docs/api/"/> -->
+  <!-- Canonical location of jdk docs root, to use with javadoc -Xdocrootparent flag -->
+  <property name="java5.docroot.url"      value="http://docs.oracle.com/javase/1.5.0/docs"/>
+  <property name="java6.docroot.url"      value="http://docs.oracle.com/javase/6/docs"/>
+  <property name="java7.docroot.url"      value="http://docs.oracle.com/javase/7/docs"/>
+  <property name="java8.docroot.url"      value="http://docs.oracle.com/javase/8/docs"/>
+  <!-- The expected canonical location does not yet exist as of 2014-07 -->
+  <!-- <property name="java9.docroot.url" value="http://docs.oracle.com/javase/9/docs"/> -->
+  <property name="java9.docroot.url"      value="http://download.java.net/jdk9/docs"/>
+  <!-- Default jdk doc location (latest stable release seems best) -->
+  <property name="java.docroot.url"       value="${java8.docroot.url}"/>
 
-  <!-- Default jdk api doc location (latest stable release seems best) -->
-  <property name="jdkapidocs.url"       value="${jdkapi7docs.url}"/>
+  <!-- Canonical location of jdk API docs, to use with javadoc link attribute -->
+  <property name="java5.api.url"      value="${java5.docroot.url}/api/"/>
+  <property name="java6.api.url"      value="${java6.docroot.url}/api/"/>
+  <property name="java7.api.url"      value="${java7.docroot.url}/api/"/>
+  <property name="java8.api.url"      value="${java8.docroot.url}/api/"/>
+  <property name="java9.api.url"      value="${java9.docroot.url}/api/"/>
+  <property name="java.api.url"       value="${java.docroot.url}/api/"/>
 
   <!-- Define the "jtreg" task -->
   <!-- See the docs in "jtreg -onlineHelp" -->
@@ -170,11 +198,11 @@ As of 2013-02, the very latest lambda 8
 
   <macrodef name="run-tck-tests">
     <attribute name="tck.src.dir" default="${tck.src.dir}"/>
-    <attribute name="source" default="6"/>
     <attribute name="target"/>
+    <attribute name="compile-target" default="@{target}"/>
     <attribute name="workdir"/>
     <attribute name="classes"/>
-    <attribute name="jvmflags" default=""/>
+    <attribute name="jvmflags" default="-ea -esa -Djsr166.testImplementationDetails=true"/>
     <element name="javac-elements" optional="true"/>
     <sequential>
 
@@ -185,28 +213,38 @@ As of 2013-02, the very latest lambda 8
            debug="${build.debug}"
            debuglevel="${build.debuglevel}"
            deprecation="${build.deprecation}"
-           source="@{source}"
+           source="@{compile-target}"
+           target="@{compile-target}"
            classpath="${junit.jar}"
-           bootclasspath="@{classes}:${bootclasspath@{source}}"
            includeAntRuntime="false"
            includeJavaRuntime="false"
-           executable="${javac@{target}}"
+           executable="${javac@{compile-target}}"
            fork="true">
 
       <include name="*.java"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial,-deprecation"/>
+      <compilerarg value="-Xbootclasspath/p:@{classes}"/>
       <compilerarg line="${build.args}"/>
       <javac-elements/>
 
     </javac>
 
-    <java classname="JSR166TestCase"
+    <java classname="${jsr166.tckTestClass}"
           failonerror="true"
           jvm="${java@{target}}"
           fork="true">
 	<jvmarg value="-Xbootclasspath/p:@{classes}"/>
 	<jvmarg line="@{jvmflags}"/>
+
+        <!-- ant -Djava.util.concurrent.ForkJoinPool.common.parallelism=1 tck -->
+	<syspropertyset id="java.util.concurrent.ForkJoinPool-properties">
+	  <propertyref prefix="java.util.concurrent.ForkJoinPool"/>
+	</syspropertyset>
+
+        <sysproperty key="jsr166.profileTests"     value="${jsr166.profileTests}"/>
+        <sysproperty key="jsr166.profileThreshold" value="${jsr166.profileThreshold}"/>
+        <sysproperty key="jsr166.runsPerTest"      value="${jsr166.runsPerTest}"/>
 	<classpath>
 	  <pathelement location="${junit.jar}"/>
 	  <pathelement location="@{workdir}/tck-classes"/>
@@ -216,8 +254,30 @@ As of 2013-02, the very latest lambda 8
     </sequential>
   </macrodef>
 
+  <!-- Define jtreg test sets for different jdk versions -->
+  <fileset dir="${jtreg9.src.dir}">
+    <patternset id="jdk9.jtreg.tests">
+      <include name="**/*.java"/>
+    </patternset>
+  </fileset>
+
+  <fileset dir="${jtreg8.src.dir}">
+    <patternset id="jdk8.jtreg.tests">
+      <include name="**/*.java"/>
+      <exclude name="**/SpliteratorCharacteristics.java"/>
+      <!-- https://bugs.openjdk.java.net/browse/JDK-6842353 -->
+      <exclude name="**/GCDuringIteration.java"/>
+    </patternset>
+  </fileset>
+
+  <fileset dir="${jtreg7.src.dir}">
+    <patternset id="jdk7.jtreg.tests">
+      <include name="**/*.java"/>
+    </patternset>
+  </fileset>
+
   <macrodef name="run-jtreg-tests">
-    <attribute name="jtreg.src.dir" default="${jtreg.src.dir}"/>
+    <!-- ant -Djtreg9.src.dir=src/test/jtreg/util/concurrent/CompletableFuture jtreg -->
     <attribute name="source" default="7"/>
     <attribute name="target"/>
     <attribute name="workdir"/>
@@ -228,11 +288,11 @@ As of 2013-02, the very latest lambda 8
     <delete dir="@{workdir}/JTreport" quiet="true"/>
     <mkdir dir="@{workdir}/JTwork/scratch"/>
     <mkdir dir="@{workdir}/JTreport"/>
-    <jtreg dir="@{jtreg.src.dir}"
+    <jtreg dir="${jtreg@{target}.src.dir}"
            jdk="${jdk@{target}.home}"
            workDir="@{workdir}/JTwork"
            reportDir="@{workdir}/JTreport">
-
+      <patternset refid="jdk@{target}.jtreg.tests"/>
       <arg value="-Xbootclasspath/p:@{classes}"/>
       <arg value="-agentvm"/>
       <arg value="-v:nopass,fail"/>
@@ -255,6 +315,9 @@ As of 2013-02, the very latest lambda 8
 
   <!-- Main targets -->
 
+  <property name="build.main.java.version" value="9"/>
+  <property name="build.main.javac" value="${javac9}"/>
+
   <target name="dists"
           depends="dist, 4jdk7dist, jsr166edist, jsr166ydist, extra166ydist, jsr166xdist"
           description="Builds all public jars and docs"/>
@@ -273,13 +336,16 @@ As of 2013-02, the very latest lambda 8
            classpath=""
            includeAntRuntime="false"
            includeJavaRuntime="false"
-           executable="${javac8}"
+           executable="${build.main.javac}"
            fork="true">
 
       <include name="**/*.java"/>
       <compilerarg value="-Xprefer:source"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all"/>
+      <compilerarg value="-Werror"/>
+      <compilerarg value="-Xdoclint:all/protected"/>
+      <compilerarg line="-Xmaxerrs 1000 -Xmaxwarns 1000"/>
       <compilerarg line="${build.args}"/>
 
     </javac>
@@ -296,11 +362,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="test"
-          depends="configure-tests, report-tests"
-          description="Runs all tests (requires JUnit 3.8.1 in ${ant.home}/lib)" />
-
-
   <target name="docs"
           description="Builds javadocs for src/main to dist dir">
 
@@ -312,18 +373,26 @@ As of 2013-02, the very latest lambda 8
 
     <javadoc destdir="${docs.dir}"
              packagenames="none"
-             link="${jdkapi8docs.url}"
+             link="${java9.api.url}"
              overview="${src.dir}/intro.html"
              access="${build.javadoc.access}"
-             sourcepath="${src.dir}:${jdk8src.dir}"
+             sourcepath="${src.dir}:${jdk9src.dir}"
              classpath=""
-             executable="${javadoc8}">
+             executable="${javadoc9}">
       <fileset dir="${src.dir}" defaultexcludes="yes">
         <include name="**/*.java"/>
       </fileset>
+      <arg line="-Xdocrootparent ${java9.docroot.url}"/>
+      <arg line="-Xmaxerrs 1000 -Xmaxwarns 1000"/>
       <arg value="-XDignore.symbol.file=true"/>
       <arg value="-tag"/>
       <arg value="${javadoc.jls.option}"/>
+      <arg value="-tag"/>
+      <arg value="apiNote:a:&lt;em&gt;API Note:&lt;/em&gt;"/>
+      <arg value="-tag"/>
+      <arg value="implSpec:a:&lt;em&gt;Implementation Requirements:&lt;/em&gt;"/>
+      <arg value="-tag"/>
+      <arg value="implNote:a:&lt;em&gt;Implementation Note:&lt;/em&gt;"/>
     </javadoc>
   </target>
 
@@ -362,14 +431,12 @@ As of 2013-02, the very latest lambda 8
   <target name="dist-clean"
           description="Removes all build and distribution products">
 
+    <delete dir="${build.dir}"/>
     <delete dir="${dist.dir}"/>
 
   </target>
 
 
-  <!-- Internal targets -->
-
-
   <target name="dist-jar"
           depends="clean, jar">
     <copy file="${product.jar}" todir="${dist.dir}"/>
@@ -380,167 +447,72 @@ As of 2013-02, the very latest lambda 8
     <mirror-dir src="${docs.dir}" dst="${dist.docs.dir}"/>
   </target>
 
-
-  <target name="compile-tests"
-          depends="jar">
-
-    <mkdir dir="${build.testcases.dir}"/>
-
-    <javac srcdir="${tck.src.dir}"
-           destdir="${build.testcases.dir}"
-           debug="${build.debug}"
-           debuglevel="${build.debuglevel}"
-           deprecation="${build.deprecation}"
-           source="6"
-           classpath="${junit.jar}"
-           bootclasspath="@{product.jar}:${bootclasspath6}"
-           includeAntRuntime="false"
-           includeJavaRuntime="false"
-           executable="${javac8}"
-           fork="true">
-
-      <include name="**/*.java"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-      <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial,-deprecation"/>
-      <compilerarg line="${build.args}"/>
-
-    </javac>
-
-    <javac srcdir="${test.src.dir}"
-           destdir="${build.testcases.dir}"
-           debug="${build.debug}"
-           debuglevel="${build.debuglevel}"
-           deprecation="${build.deprecation}"
-           source="6"
-           classpath=""
-           bootclasspath="@{product.jar}:${bootclasspath6}"
-           includeAntRuntime="false"
-           includeJavaRuntime="false"
-           executable="${javac8}"
-           fork="true">
-
-      <include name="jsr166/test/**/*.java"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-      <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial,-deprecation"/>
-      <compilerarg line="${build.args}"/>
-
-    </javac>
-
-<!--
-    <javac srcdir="${jtreg.src.dir}"
-          destdir="${build.testcases.dir}"
-            debug="${build.debug}"
-       debuglevel="${build.debuglevel}"
-      deprecation="${build.deprecation}"
-           source="${build.sourcelevel}"
-             fork="true">
-
-      <compilerarg value="-Xbootclasspath/p:${product.jar}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-      <compilerarg line="${build.args}"/>
-
-    </javac>
--->
-
-  </target>
-
-  <target name="test-tck"
+  <target name="tck"
 	  depends="jar"
           description="Runs tck tests for main directly">
 
     <run-tck-tests
-      target="8"
+      target="${build.main.java.version}"
       workdir="${build.dir}"
       classes="${product.jar}"/>
   </target>
 
-  <target name="test-jtreg"
+  <target name="tck-parallelism-1"
+          description="Runs tck with given common pool parallelism">
+    <antcall target="tck">
+      <param name="java.util.concurrent.ForkJoinPool.common.parallelism" value="1"/>
+    </antcall>
+  </target>
+
+  <target name="tck-parallelism-0"
+          description="Runs tck with given common pool parallelism">
+    <antcall target="tck">
+      <param name="java.util.concurrent.ForkJoinPool.common.parallelism" value="0"/>
+    </antcall>
+  </target>
+
+  <target name="jtreg"
 	  depends="jar"
           description="Runs jtreg tests for main using the jtreg ant task">
     <run-jtreg-tests
-       target="8"
+       target="${build.main.java.version}"
        workdir="${build.dir}"
        classes="${product.jar}"/>
   </target>
 
-  <target name="test-ng"
-          depends="test-tck, test-jtreg"
+  <target name="test"
+          depends="tck, tck-parallelism-1, jtreg"
           description="Runs tck and jtreg tests for main">
   </target>
 
-  <target name="run-tests"
-          depends="compile-tests">
-
-    <!-- May be overridden by user.properties -->
-    <property name="testcase" value="*"/>
-
-    <mkdir dir="${build.reports.dir}"/>
-
-    <junit printsummary="true"
-             showoutput="true"
-          errorProperty="junit.failed"
-        failureProperty="junit.failed"
-                    dir="${build.reports.dir}"
-                    jvm="${java8}"
-                   fork="true">
-
-      <jvmarg value="-Xbootclasspath/p:${product.jar}"/>
-      <jvmarg value="-server"/>
-      <jvmarg value="-showversion"/>
-
-      <classpath refid="test.classpath"/>
-
-      <formatter type="xml"/>
-
-      <batchtest todir="${build.reports.dir}" unless="no.test.tck">
-        <fileset dir="${tck.src.dir}">
-          <include name="**/${testcase}Test.java"/>
-        </fileset>
-      </batchtest>
-
-      <batchtest todir="${build.reports.dir}" if="do.test.old">
-        <fileset dir="${test.src.dir}">
-          <include name="jsr166/test/**/${testcase}Test.java"/>
-        </fileset>
-      </batchtest>
-
-<!--
-      <batchtest todir="${build.reports.dir}" if="do.test.jtreg">
-        <fileset dir="${jtreg.src.dir}">
-          <include name="**/${testcase}Test.java"/>
-        </fileset>
-      </batchtest>
--->
+  <target name="jtreg8" description="Runs jtreg tests with jdk8">
 
-    </junit>
+    <antcall target="jtreg">
+      <param name="build.main.java.version" value="8"/>
+      <param name="build.main.javac" value="${javac8}"/>
+    </antcall>
 
   </target>
 
+  <target name="test89"
+          description="Runs tck and jtreg tests for main for multiple java versions">
 
-  <target name="report-tests"
-          depends="run-tests">
-
-    <!-- Sets junit.report.format to frames if redirection is present,
-         otherwise sets it to noframes. -->
-    <available property="junit.report.format"
-                  value="frames"
-              classname="org.apache.xalan.lib.Redirect"
-    />
-    <property name="junit.report.format" value="noframes"/>
-
-    <junitreport todir="${build.reports.dir}">
-      <fileset dir="${build.reports.dir}">
-        <include name="TEST-*.xml"/>
-      </fileset>
-      <report format="${junit.report.format}" todir="${build.reports.dir}"
-      />
-    </junitreport>
+    <antcall target="clean"/>
+    <antcall target="test">
+      <param name="build.main.java.version" value="8"/>
+      <param name="build.main.javac" value="${javac8}"/>
+    </antcall>
 
-    <fail message="Test Cases Failed" if="junit.failed"/>
+    <antcall target="clean"/>
+    <antcall target="test">
+      <param name="build.main.java.version" value="9"/>
+      <param name="build.main.javac" value="${javac9}"/>
+    </antcall>
 
   </target>
 
 
+
   <target name="configure-compiler">
 
     <property name="unchecked.option" value="-Xlint:unchecked"/>
@@ -558,29 +530,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="configure-tests"
-       depends="configure-compiler">
-
-    <!-- junit.framework.Protectable is in JUnit 3.8.1 but not in 3.7 -->
-    <available property="junit.available"
-               classname="junit.framework.Protectable"/>
-
-    <!-- Xalan -->
-    <available property="xalan.available"
-               classname="org.apache.xalan.Version"/>
-
-
-    <!-- Ant 1.6beta and later don't need or want this check -->
-    <!--
-    <fail message="Need JUnit 3.8.1 in ${ant.home}${file.separator}lib to run tests"
-          unless="junit.available"/>
-
-    <fail message="Need Xalan 2.5.1 jar in ${ant.home}${file.separator}lib to run tests"
-          unless="xalan.available"/>
-    -->
-
-  </target>
-
 
   <!-- Various demos and test programs -->
 
@@ -611,6 +560,32 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
+  <target name="compile-test-loops" depends="jar"
+          description="compile all the perf tests in src/test/loops">
+
+    <mkdir dir="${build.dir}/test/loops"/>
+
+    <javac srcdir="${basedir}/src/test/loops"
+           destdir="${build.dir}/test/loops"
+           debug="${build.debug}"
+           debuglevel="${build.debuglevel}"
+           deprecation="${build.deprecation}"
+           includeAntRuntime="false"
+           includeJavaRuntime="false"
+           executable="${javac9}"
+           fork="true">
+
+      <include name="*.java"/>
+      <compilerarg value="-XDignore.symbol.file=true"/>
+      <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial"/>
+      <compilerarg value="-Xbootclasspath/p:${product.jar}"/>
+      <compilerarg line="${build.args}"/>
+
+    </javac>
+
+  </target>
+
+
   <!-- jsr166 4jdk7 -->
 
   <target name="4jdk7compile"
@@ -636,6 +611,36 @@ As of 2013-02, the very latest lambda 8
       <compilerarg value="-Xprefer:source"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all"/>
+      <compilerarg value="-Werror"/>
+      <compilerarg line="${build.args}"/>
+
+    </javac>
+  </target>
+
+  <target name="4jdk7doclint"
+          depends="configure-compiler"
+          description="Finds doclint warnings">
+
+    <mkdir dir="${build.4jdk7.classes.dir}"/>
+
+    <javac srcdir="${4jdk7src.dir}"
+           destdir="${build.4jdk7.classes.dir}"
+           debug="${build.debug}"
+           debuglevel="${build.debuglevel}"
+           deprecation="${build.deprecation}"
+           source="6"
+           classpath=""
+           bootclasspath="${bootclasspath7}"
+           includeAntRuntime="false"
+           includeJavaRuntime="false"
+           executable="${javac8}"
+           fork="true">
+
+      <include name="**/*.java"/>
+      <compilerarg value="-Xprefer:source"/>
+      <compilerarg value="-XDignore.symbol.file=true"/>
+      <compilerarg value="-Xlint:all"/>
+      <compilerarg value="-Xdoclint:all/protected"/>
       <compilerarg line="${build.args}"/>
 
     </javac>
@@ -653,7 +658,7 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="4jdk7-test-tck"
+  <target name="4jdk7-tck"
 	  depends="4jdk7jar"
           description="Runs tck tests for jsr166-4jdk7 directly">
 
@@ -664,14 +669,20 @@ As of 2013-02, the very latest lambda 8
       <javac-elements>
         <!-- JDK8+ test classes -->
         <exclude name="*8Test.java"/>
+        <exclude name="*9Test.java"/>
+        <exclude name="DoubleAccumulatorTest.java"/>
+        <exclude name="DoubleAdderTest.java"/>
+        <exclude name="LongAccumulatorTest.java"/>
+        <exclude name="LongAdderTest.java"/>
         <exclude name="CompletableFutureTest.java"/>
+        <exclude name="SplittableRandomTest.java"/>
         <exclude name="StampedLockTest.java"/>
       </javac-elements>
     </run-tck-tests>
   </target>
 
 
-  <target name="4jdk7-test-tck-junit"
+  <target name="4jdk7-tck-junit"
           depends="4jdk7compile"
           description="Runs tck tests for jsr166-4jdk7 via junit task (experimental)">
 
@@ -693,13 +704,13 @@ As of 2013-02, the very latest lambda 8
 
       <formatter type="brief"/>
 
-      <test name="JSR166TestCase" haltonfailure="no">
+      <test name="${jsr166.tckTestClass}" haltonfailure="no">
       </test>
 
     </junit>
   </target>
 
-  <target name="4jdk7-test-jtreg"
+  <target name="4jdk7-jtreg"
 	  depends="4jdk7jar"
           description="Runs jtreg tests for jsr166-4jdk7 using the jtreg ant task">
     <run-jtreg-tests
@@ -710,7 +721,7 @@ As of 2013-02, the very latest lambda 8
 
 
   <target name="4jdk7-test"
-	  depends="4jdk7-test-tck, 4jdk7-test-jtreg"
+	  depends="4jdk7-tck, 4jdk7-jtreg"
           description="Runs tck and jtreg tests for jsr166-4jdk7">
   </target>
 
@@ -723,7 +734,7 @@ As of 2013-02, the very latest lambda 8
 
     <javadoc destdir="${4jdk7docs.dir}"
              packagenames="none"
-             link="${jdkapi7docs.url}"
+             link="${java7.api.url}"
              overview="${4jdk7src.dir}/intro.html"
              access="${build.javadoc.access}"
              sourcepath="${4jdk7src.dir}:${jdk7src.dir}"
@@ -732,6 +743,7 @@ As of 2013-02, the very latest lambda 8
       <fileset dir="${4jdk7src.dir}" defaultexcludes="yes">
         <include name="**/*.java"/>
       </fileset>
+      <arg line="-Xdocrootparent ${java7.docroot.url}"/>
       <arg value="-XDignore.symbol.file=true"/>
     </javadoc>
   </target>
@@ -750,11 +762,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="4jdk7dist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
   <target name="4jdk7dist-jar"
           depends="4jdk7clean, 4jdk7jar">
     <copy file="${4jdk7product.jar}" todir="${dist.dir}"/>
@@ -791,6 +798,7 @@ As of 2013-02, the very latest lambda 8
       <include name="jsr166x/**/*.java"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all,-unchecked,-rawtypes"/>
+      <compilerarg value="-Werror"/>
       <compilerarg line="${build.args}"/>
 
     </javac>
@@ -816,12 +824,13 @@ As of 2013-02, the very latest lambda 8
 
     <javadoc destdir="${jsr166xdocs.dir}"
              packagenames="jsr166x.*"
-             link="${jdkapidocs.url}"
+             link="${java.api.url}"
              access="${build.javadoc.access}"
              sourcepath="${topsrc.dir}:${jdk6src.dir}"
              bootclasspath="${bootclasspath6}"
              source="5"
              executable="${javadoc7}">
+      <arg line="-Xdocrootparent ${java.docroot.url}"/>
       <arg value="-XDignore.symbol.file=true"/>
 
     </javadoc>
@@ -841,12 +850,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="jsr166xdist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
-
   <target name="jsr166xdist-jar"
           depends="jsr166xclean, jsr166xjar">
     <copy file="${jsr166x.jar}" todir="${dist.dir}"/>
@@ -882,6 +885,7 @@ As of 2013-02, the very latest lambda 8
       <include name="jsr166y/**/*.java"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all"/>
+      <compilerarg value="-Werror"/>
       <compilerarg line="${build.args}"/>
 
     </javac>
@@ -907,12 +911,13 @@ As of 2013-02, the very latest lambda 8
 
     <javadoc destdir="${jsr166ydocs.dir}"
              packagenames="jsr166y.*"
-             link="${jdkapidocs.url}"
+             link="${java.api.url}"
              access="${build.javadoc.access}"
              sourcepath="${topsrc.dir}:${jdk6src.dir}"
              bootclasspath="${bootclasspath6}"
              source="6"
              executable="${javadoc7}">
+      <arg line="-Xdocrootparent ${java.docroot.url}"/>
       <arg value="-XDignore.symbol.file=true"/>
 
     </javadoc>
@@ -932,11 +937,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="jsr166ydist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
   <target name="jsr166ydist-jar"
           depends="jsr166yclean, jsr166yjar">
     <copy file="${jsr166y.jar}" todir="${dist.dir}"/>
@@ -973,6 +973,7 @@ As of 2013-02, the very latest lambda 8
       <include name="extra166y/**/*.java"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial"/>
+      <compilerarg value="-Werror"/>
       <compilerarg line="${build.args}"/>
 
     </javac>
@@ -998,12 +999,13 @@ As of 2013-02, the very latest lambda 8
 
     <javadoc destdir="${extra166ydocs.dir}"
              packagenames="extra166y.*"
-             link="${jdkapidocs.url}"
+             link="${java.api.url}"
              access="${build.javadoc.access}"
              sourcepath="${topsrc.dir}:${jdk6src.dir}"
              bootclasspath="${bootclasspath6}"
              source="6"
              executable="${javadoc7}">
+      <arg line="-Xdocrootparent ${java.docroot.url}"/>
       <arg value="-XDignore.symbol.file=true"/>
 
     </javadoc>
@@ -1023,11 +1025,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="extra166ydist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
   <target name="extra166ydist-jar"
           depends="extra166yclean, extra166yjar">
     <copy file="${extra166y.jar}" todir="${dist.dir}"/>
@@ -1040,6 +1037,9 @@ As of 2013-02, the very latest lambda 8
 
   <!-- jsr166e -->
 
+  <property name="build.jsr166e.java.version" value="6"/>
+  <property name="build.jsr166e.javac" value="${javac6}"/>
+
   <target name="jsr166ecompile"
           depends="configure-compiler"
           description="Compiles jsr166e sources">
@@ -1051,21 +1051,49 @@ As of 2013-02, the very latest lambda 8
            debug="${build.debug}"
            debuglevel="${build.debuglevel}"
            deprecation="${build.deprecation}"
-           source="7"
+           source="${build.jsr166e.java.version}"
            classpath=""
            includeAntRuntime="false"
            includeJavaRuntime="false"
-           executable="${javac7}"
+           executable="${build.jsr166e.javac}"
            fork="true">
 
       <include name="jsr166e/**/*.java"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all"/>
+      <compilerarg value="-Werror"/>
       <compilerarg line="${build.args}"/>
 
     </javac>
   </target>
 
+  <!-- jsr166e: find doclint errors -->
+  <target name="jsr166edoclint">
+
+    <mkdir dir="${build.jsr166e.classes.dir}"/>
+
+    <javac srcdir="${topsrc.dir}"
+           destdir="${build.jsr166e.classes.dir}"
+           debug="${build.debug}"
+           debuglevel="${build.debuglevel}"
+           deprecation="${build.deprecation}"
+           source="${build.jsr166e.java.version}"
+           classpath=""
+           bootclasspath="${bootclasspath7}"
+           includeAntRuntime="false"
+           includeJavaRuntime="false"
+           executable="${javac8}"
+           fork="true">
+
+      <include name="jsr166e/**/*.java"/>
+      <compilerarg value="-XDignore.symbol.file=true"/>
+      <compilerarg value="-Xlint:all"/>
+      <compilerarg value="-Werror"/>
+      <compilerarg value="-Xdoclint:all/protected"/>
+
+    </javac>
+  </target>
+
 
   <target name="jsr166ejar"
           depends="jsr166ecompile"
@@ -1086,29 +1114,57 @@ As of 2013-02, the very latest lambda 8
 
     <javadoc destdir="${jsr166edocs.dir}"
              packagenames="jsr166e.*"
-             link="${jdkapidocs.url}"
+             link="${java.api.url}"
              access="${build.javadoc.access}"
-             sourcepath="${topsrc.dir}:${jdk7src.dir}"
-             source="7"
+             sourcepath="${topsrc.dir}:${jdk6src.dir}"
+             source="${build.jsr166e.java.version}"
              executable="${javadoc7}">
+      <arg line="-Xdocrootparent ${java.docroot.url}"/>
       <arg value="-XDignore.symbol.file=true"/>
 
     </javadoc>
   </target>
 
 
-  <target name="jsr166e-test-tck"
-	  depends="jsr166ejar"
-          description="Runs tck tests for jsr166e">
+  <target name="jsr166e-tck-one-java-version"
+	  depends="jsr166ejar">
+
+    <echo message="Testing with jdk${build.jsr166e.java.version} ..."/>
 
     <run-tck-tests
       tck.src.dir="${test.src.dir}/tck-jsr166e"
-      source="7"
-      target="8"
+      target="${build.jsr166e.java.version}"
       workdir="${build.jsr166e.dir}"
       classes="${jsr166e.jar}"/>
   </target>
 
+  <target name="jsr166e-tck"
+          description="Runs tck tests for jsr166e for multiple java versions">
+
+<!--     <antcall target="clean"/> -->
+<!--     <antcall target="jsr166e-tck-one-java-version"> -->
+<!--       <param name="build.jsr166e.java.version" value="8"/> -->
+<!--       <param name="build.jsr166e.javac" value="${javac8}"/> -->
+<!--     </antcall> -->
+
+    <antcall target="clean"/>
+    <antcall target="jsr166e-tck-one-java-version">
+      <param name="build.jsr166e.java.version" value="7"/>
+      <param name="build.jsr166e.javac" value="${javac7}"/>
+    </antcall>
+
+    <antcall target="clean"/>
+    <antcall target="jsr166e-tck-one-java-version">
+      <param name="build.jsr166e.java.version" value="6"/>
+      <param name="build.jsr166e.javac" value="${javac6}"/>
+    </antcall>
+  </target>
+
+
+  <target name="jsr166e-test"
+	  depends="jsr166e-tck"
+          description="Runs all tests for jsr166e">
+  </target>
 
   <target name="jsr166edist"
           depends="jsr166edist-jar, jsr166edist-docs"
@@ -1121,11 +1177,6 @@ As of 2013-02, the very latest lambda 8
   </target>
 
 
-  <target name="jsr166edist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
   <target name="jsr166edist-jar"
           depends="jsr166eclean, jsr166ejar">
     <copy file="${jsr166e.jar}" todir="${dist.dir}"/>
@@ -1141,6 +1192,13 @@ As of 2013-02, the very latest lambda 8
 
   <target name="lint">
     <antcall target="dists">
+      <param name="build.javadoc.access" value="public"/>
+    </antcall>
+  </target>
+
+<!-- Generates all doclint warnings, even for private methods (rarely useful) -->
+  <target name="lint-private">
+    <antcall target="dist">
       <param name="build.javadoc.access" value="private"/>
     </antcall>
   </target>