--- jsr166/build.xml	2018/10/27 01:16:23	1.284
+++ jsr166/build.xml	2018/12/13 01:12:01	1.292
@@ -1,5 +1,5 @@
 <project name="jsr166" default="usage"
-  xmlns:if="ant:if" 
+  xmlns:if="ant:if"
   xmlns:unless="ant:unless"
   xmlns:ivy="antlib:org.apache.ivy.ant">
 
@@ -202,10 +202,8 @@
   <!-- <property name="java10.docroot.url" value="http://download.java.net/java/jdk10/docs"/> -->
   <!-- <property name="java11.docroot.url" value="http://download.java.net/java/jdk11/docs"/> -->
   <property name="java12.docroot.url" value="https://download.java.net/java/jdk12/docs"/>
-  <!-- Default jdk doc location (latest stable release seems best) -->
-  <!-- But pin to jdk 10 until fix for -->
-  <!-- 8211194: javadoc -link doesn't take module path into consideration -->
-  <property name="java.docroot.url"   value="${java10.docroot.url}"/>
+  <!-- Default jdk doc location (latest stable LTS release seems best) -->
+  <property name="java.docroot.url"   value="${java11.docroot.url}"/>
 
   <!-- Canonical location of jdk API docs, to use with javadoc link attribute -->
   <property name="java5.api.url"      value="${java5.docroot.url}/api/"/>
@@ -340,7 +338,7 @@
   <property name="jtreg.flags" value=""/>
 
   <macrodef name="run-jtreg-tests">
-    <!-- ant -Djtreg9.src.dir=src/test/jtreg/util/concurrent/CompletableFuture jtreg -->
+    <!-- ant -Djtreg11.src.dir=src/test/jtreg/util/concurrent/CompletableFuture jtreg -->
     <attribute name="target"/>
     <attribute name="workdir"/>
     <attribute name="classes"/>
@@ -393,11 +391,17 @@
   <!-- Default values: may seem strange ... -->
   <!-- At runtime, target latest LTS, i.e. jdk11 -->
   <!-- But at build time, target jdk9, for maximal binary portability -->
-  <!-- Use javadoc12, so we can use override-methods=summary, and JDK-8202628 -->
-  <property name="build.main.java.version" value="11"/>
+  <!-- Use javadoc12 (but -link to jdk11 api docs!), to get:
+    o override-methods=summary
+    o {@systemProperty ...}
+    o 8211194: issues linking to external documentation (was: missing package-list for JDK10 / JDK11 documentation)
+    o 8202628: javadoc generates bad links in TestModules.java
+    -->
+  <property name="java.runtime.target" value="11"/>
   <property name="build.main.java" value="${java11}"/>
   <property name="build.main.javac" value="${javac9}"/>
   <property name="build.main.javadoc" value="${javadoc12}"/>
+  <property name="build.main.javadoc.source" value="${java.runtime.target}"/>
 
   <target name="dists"
           depends="dist, 4jdk8dist"
@@ -471,21 +475,23 @@
 <!-- TODO: <arg line="- -module-source-path ${jdk9.home}/src.zip"/> -->
     <javadoc destdir="${docs.dir}"
              packagenames="none"
-             link="${java11.api.url}"
+             link="${java.api.url}"
              overview="${src.dir}/intro.html"
              access="${build.javadoc.access}"
              sourcepath="${src.dir}"
              classpath=""
-             source="11"
+             source="${build.main.javadoc.source}"
              executable="${build.main.javadoc}">
+<!-- TODO: JDK-8214571 failonerror = "true" -->
       <fileset dir="${src.dir}" defaultexcludes="yes">
         <include name="**/*.java"/>
       </fileset>
-      <arg line="-Xdocrootparent ${java10.docroot.url}"/>
+      <arg line="-Xdocrootparent ${java.docroot.url}"/>
       <arg line="-Xmaxerrs 1000 -Xmaxwarns 1000"/>
       <arg value="-XDignore.symbol.file=true"/>
       <arg value="-html5"/>
       <arg value="--patch-module=java.base=${src.dir}"/>
+<!-- old school frames via docs/index.html?overview-summary.html -->
       <arg value="--frames"/>
       <arg value="--override-methods=summary"/>
       <arg value="-tag"/> <arg value="${javadoc.jls.option}"/>
@@ -532,7 +538,7 @@
           description="Runs tck tests for src/main directly">
 
     <run-tck-tests
-      target="${build.main.java.version}"
+      target="${java.runtime.target}"
       workdir="${build.dir}"
       classes="${product.jar}">
       <javac-elements>
@@ -566,7 +572,7 @@
 	  depends="jar"
           description="Runs jtreg tests for src/main using the jtreg ant task">
     <run-jtreg-tests
-       target="${build.main.java.version}"
+       target="${java.runtime.target}"
        workdir="${build.dir}"
        classes="${product.jar}"/>
   </target>
@@ -582,20 +588,22 @@
   <target name="test9">
     <antcall target="clean"/>
     <antcall>
-      <param name="build.main.java.version" value="9"/>
-      <param name="build.main.java" value="${java9}"/>
+      <param name="java.runtime.target" value="9"/>
       <param name="build.main.javac" value="${javac9}"/>
+      <param name="build.main.javadoc" value="${javadoc12}"/>
+      <param name="build.main.javadoc.source" value="9"/>
       <target name="test"/>
+      <target name="docs"/>
     </antcall>
   </target>
 
   <target name="test10">
     <antcall target="clean"/>
     <antcall>
-      <param name="build.main.java.version" value="10"/>
-      <param name="build.main.java" value="${java10}"/>
+      <param name="java.runtime.target" value="10"/>
       <param name="build.main.javac" value="${javac10}"/>
-      <param name="build.main.javadoc" value="${javadoc10}"/>
+      <param name="build.main.javadoc" value="${javadoc12}"/>
+      <param name="build.main.javadoc.source" value="10"/>
       <target name="test"/>
       <target name="docs"/>
     </antcall>
@@ -604,10 +612,10 @@
   <target name="test11">
     <antcall target="clean"/>
     <antcall>
-      <param name="build.main.java.version" value="11"/>
-      <param name="build.main.java" value="${java11}"/>
+      <param name="java.runtime.target" value="11"/>
       <param name="build.main.javac" value="${javac11}"/>
-      <param name="build.main.javadoc" value="${javadoc11}"/>
+      <param name="build.main.javadoc" value="${javadoc12}"/>
+      <param name="build.main.javadoc.source" value="11"/>
       <target name="test"/>
       <target name="docs"/>
     </antcall>
@@ -616,10 +624,10 @@
   <target name="test12">
     <antcall target="clean"/>
     <antcall>
-      <param name="build.main.java.version" value="12"/>
-      <param name="build.main.java" value="${java12}"/>
+      <param name="java.runtime.target" value="12"/>
       <param name="build.main.javac" value="${javac12}"/>
       <param name="build.main.javadoc" value="${javadoc12}"/>
+      <param name="build.main.javadoc.source" value="12"/>
       <target name="test"/>
       <target name="docs"/>
     </antcall>
@@ -628,10 +636,10 @@
   <target name="test9-11">
     <antcall target="clean"/>
     <antcall>
-      <param name="build.main.java.version" value="11"/>
-      <param name="build.main.java" value="${java11}"/>
+      <param name="java.runtime.target" value="11"/>
       <param name="build.main.javac" value="${javac9}"/>
-      <param name="build.main.javadoc" value="${javadoc11}"/>
+      <param name="build.main.javadoc" value="${javadoc12}"/>
+      <param name="build.main.javadoc.source" value="9"/>
       <target name="test"/>
       <target name="docs"/>
     </antcall>
@@ -640,10 +648,10 @@
   <target name="test9-12">
     <antcall target="clean"/>
     <antcall>
-      <param name="build.main.java.version" value="12"/>
-      <param name="build.main.java" value="${java12}"/>
+      <param name="java.runtime.target" value="12"/>
       <param name="build.main.javac" value="${javac9}"/>
       <param name="build.main.javadoc" value="${javadoc12}"/>
+      <param name="build.main.javadoc.source" value="9"/>
       <target name="test"/>
       <target name="docs"/>
     </antcall>
@@ -1373,15 +1381,25 @@
 
 
 <!-- ==============================================================
-  Experimental errorprone support - https://errorprone.info
+  Experimental errorprone support
+  https://errorprone.info
+  https://errorprone.info/docs/installation
+  https://github.com/google/error-prone/issues/1143
 =================================================================== -->
-  <property name="errorprone.jar" location="${lib.dir}/error_prone_ant-2.3.1.jar"/>
+  <path id="errorprone.processorpath.path">
+    <pathelement location="${lib.dir}/error_prone_core-2.3.2-with-dependencies.jar"/>
+    <pathelement location="${lib.dir}/dataflow-2.5.7.jar"/>
+    <pathelement location="${lib.dir}/javacutil-2.5.7.jar"/>
+    <pathelement location="${lib.dir}/jFormatString-3.0.0.jar"/>
+  </path>
+  <property name="errorprone.processorpath" refid="errorprone.processorpath.path" />
   <property name="errorprone.jsr166.user.flags" value=""/>
   <property name="errorprone.jsr166.flags"
             value="-Xep:HashtableContains:OFF
                    -Xep:JdkObsolete:OFF
                    -Xep:MissingOverride:OFF
                    -Xep:MissingFail:OFF
+                   -Xep:ThreadPriorityCheck:OFF
                    -Xep:MixedArrayDimensions:ERROR
                    -Xep:RemoveUnusedImports:ERROR
                    -Xep:EmptyIf:ERROR
@@ -1390,6 +1408,7 @@
                    -Xep:LongLiteralLowerCaseSuffix:ERROR
                    -Xep:RedundantThrows:ERROR
                    -Xep:IdentityBinaryExpression:WARN
+                   -Xep:ConstructorInvokesOverridable:WARN
                    -Xep:MethodCanBeStatic:WARN
                    ${errorprone.jsr166.user.flags}"/>
   <!-- -Xep:WildcardImport:ERROR -->
@@ -1422,7 +1441,8 @@
       <!-- Needed to silence -Xep:FutureReturnValueIgnored -->
       <compilerarg value="-J--illegal-access=permit"/>
       <compilerarg value="-XDcompilePolicy=simple"/>
-      <compilerarg line="-processorpath ${errorprone.jar}"/>
+      <compilerarg value="-processorpath"/>
+      <compilerarg pathref="errorprone.processorpath.path"/>
       <compilerarg value="-Xplugin:ErrorProne
                           ${errorprone.jsr166.flags}"/>
       <compilerarg value="--patch-module=java.base=${src.dir}"/>
@@ -1439,14 +1459,14 @@
     </jar>
 
     <run-tck-tests
-      target="${build.main.java.version}"
+      target="${java.runtime.target}"
       workdir="${build.dir}"
       classes="${product.jar}">
       <javac-elements>
         <!-- Needed to silence -Xep:FutureReturnValueIgnored -->
         <compilerarg value="-J--illegal-access=permit"/>
         <compilerarg value="-XDcompilePolicy=simple"/>
-        <compilerarg line="-processorpath ${errorprone.jar}"/>
+        <compilerarg line="-processorpath ${errorprone.processorpath}"/>
         <compilerarg value="-Xplugin:ErrorProne
                             ${errorprone.jsr166.flags}
                             ${errorprone.jsr166.test.flags}"/>
@@ -1462,14 +1482,14 @@
           description="Run errorprone over jtreg tests (experimental)">
 
     <run-jtreg-tests
-       target="${build.main.java.version}"
+       target="${java.runtime.target}"
        workdir="${build.dir}"
        classes="${product.jar}"
        verbose="all">
       <jtreg-elements>
         <arg value="-javacoption:-XDcompilePolicy=simple"/>
         <arg value="-javacoption:-processorpath"/>
-        <arg value="-javacoption:${errorprone.jar}"/>
+        <arg value="-javacoption:${errorprone.processorpath}"/>
         <arg value="-javacoption:-Xplugin:ErrorProne
                             ${errorprone.jsr166.flags}
                             ${errorprone.jsr166.test.flags}