--- jsr166/build.xml	2013/01/19 21:40:04	1.104
+++ jsr166/build.xml	2022/11/25 20:33:50	1.327
@@ -1,4 +1,7 @@
-<project name="jsr166" default="usage">
+<project name="jsr166" default="usage"
+  xmlns:if="ant:if"
+  xmlns:unless="ant:unless"
+  xmlns:ivy="antlib:org.apache.ivy.ant">
 
   <description>
 ------------------------------------------------------------------------------
@@ -6,6 +9,9 @@
 
   Usage: ant [target]
 
+  See http://gee.cs.oswego.edu/dl/concurrency-interest/index.html for
+  more details.
+
   User-specific settings are read from user.properties.
   See user.properties.sample for an explanation of some useful settings.
 
@@ -13,154 +19,266 @@
   itself.  Because the JDK version matters and because different
   targets require different JDKs, we assume that users have created a
   hierarchy containing:
-  $HOME/jdk/jdk6
-  $HOME/jdk/jdk7
-  $HOME/jdk/jdk8
+  $HOME/jdk/jdk17
+  $HOME/jdk/jdk19
   where each of the above is a JDK or a symlink to same, and
-  $HOME/jdk/src/jdk6
-  $HOME/jdk/src/jdk7
-  $HOME/jdk/src/jdk8
-  where each of the above is a complete JDK source tree
-  (e.g. mercurial forest) or a symlink to same.
+  $HOME/jdk/src/jdk17
+  where each of the above is a JDK source tree or a symlink to same.
+
+  Alternatively, define ant variables thus:
+  ant -Djdk$N.home=... -Djdk$N.src.home=...
+  for $N in 17 .. 19 ...
+
+  As of 2016-03, the sources in src/main are for jdk9+ only.
+  As of 2019-08, the sources in src/main are for jdk11+ only.
+  As of 2019-10, compatibility support for jdk8 is dropped entirely.
+  As of 2022-02, the sources in src/main are for jdk17+ only.
 ------------------------------------------------------------------------------
   </description>
 
-  <target name="usage" description="Advises user to run with -projecthelp">
-    <echo>Run "ant -projecthelp" for full usage information.</echo>
+  <!-- Run 'ant -projecthelp' (default target) -->
+  <target name="usage">
+    <java classname="org.apache.tools.ant.Main">
+      <arg value="-projecthelp" />
+    </java>
   </target>
 
+  <!-- HOWTO printf debug: <echo message="prop=${prop}"/> -->
 
   <!-- User-specific settings -->
   <property file="user.properties"/>
 
 
   <!-- Compilation options -->
-  <property name="build.sourcelevel"    value="1.6"/>
   <property name="build.debug"          value="true"/>
   <property name="build.debuglevel"     value="source,lines,vars"/>
   <property name="build.deprecation"    value="false"/>
+  <property name="build.javadoc.access" value="protected"/>
 
   <!-- Build locations -->
   <property name="build.dir"                   location="build"/>
   <property name="build.classes.dir"           location="${build.dir}/classes"/>
   <property name="build.testcases.dir"         location="${build.dir}/testcases"/>
   <property name="build.loops.dir"             location="${build.dir}/loops"/>
-  <property name="build.lib.dir"               location="${build.dir}/lib"/>
-  <property name="build.javadocs.dir"          location="${build.dir}/javadocs"/>
-  <property name="build.reports.dir"           location="${build.dir}/reports"/>
-
-  <property name="build.4jdk7.dir"              location="${build.dir}/4jdk7"/>
-  <property name="build.4jdk7.lib.dir"          location="${build.4jdk7.dir}"/>
-  <property name="build.4jdk7.classes.dir"      location="${build.4jdk7.dir}/classes"/>
-  <property name="build.4jdk7.tck.classes.dir"  location="${build.4jdk7.dir}/tck/classes"/>
-  <property name="build.4jdk7.docs.dir"         location="${build.4jdk7.dir}/docs"/>
-
-  <property name="build.jsr166x.dir"           location="${build.dir}/jsr166x"/>
-  <property name="build.jsr166xlib.dir"        location="${build.dir}/jsr166xlib"/>
-  <property name="build.jsr166xjavadocs.dir"   location="${build.dir}/jsr166xjavadocs"/>
-
-  <property name="build.jsr166y.dir"           location="${build.dir}/jsr166y"/>
-  <property name="build.jsr166ylib.dir"        location="${build.dir}/jsr166ylib"/>
-  <property name="build.jsr166yjavadocs.dir"   location="${build.dir}/jsr166yjavadocs"/>
-
-  <property name="build.jsr166e.dir"           location="${build.dir}/jsr166e"/>
-  <property name="build.jsr166elib.dir"        location="${build.dir}/jsr166elib"/>
-  <property name="build.jsr166ejavadocs.dir"   location="${build.dir}/jsr166ejavadocs"/>
-
-  <property name="build.extra166y.dir"         location="${build.dir}/extra166y"/>
-  <property name="build.extra166ylib.dir"      location="${build.dir}/extra166ylib"/>
-  <property name="build.extra166yjavadocs.dir" location="${build.dir}/extra166yjavadocs"/>
 
-  <!-- JDK binary locations -->
+  <!-- JDK locations -->
   <property name="jdks.home"  location="${user.home}/jdk"/>
 
   <macrodef name="defjdklocations">
     <attribute name="v"/>
     <sequential>
-    <property name="jdk@{v}.home"   location="${jdks.home}/jdk@{v}"/>
-    <property name="java@{v}"       location="${jdk@{v}.home}/bin/java"/>
-    <property name="javac@{v}"      location="${jdk@{v}.home}/bin/javac"/>
-    <property name="javadoc@{v}"    location="${jdk@{v}.home}/bin/javadoc"/>
-    <property name="bootdir@{v}"    location="${jdk@{v}.home}/jre/lib"/>
-    <property name="jdk@{v}src.dir" location="${jdks.home}/src/jdk@{v}/jdk/src/share/classes"/>
-    <property name="bootclasspath@{v}"
-     value="${bootdir@{v}}/resources.jar:${bootdir@{v}}/rt.jar:${bootdir@{v}}/jsse.jar:${bootdir@{v}}/jce.jar:${bootdir@{v}}/:${bootdir@{v}}/charsets.jar"/>
+    <property name="jdk@{v}.home"     location="${jdks.home}/jdk@{v}"/>
+    <property name="java@{v}"         location="${jdk@{v}.home}/bin/java"/>
+    <property name="javac@{v}"        location="${jdk@{v}.home}/bin/javac"/>
+    <property name="javadoc@{v}"      location="${jdk@{v}.home}/bin/javadoc"/>
+    <property name="jdk@{v}.src.home" location="${jdks.home}/src/jdk@{v}"/>
+    <property name="jdk@{v}.src.dir"  location="${jdk@{v}.src.home}/jdk/src/java.base/share/classes"/>
     </sequential>
   </macrodef>
 
-  <defjdklocations v="6"/>
-  <defjdklocations v="7"/>
-  <defjdklocations v="8"/>
-
-  <macrodef name="run-tck-tests">
-    <attribute name="jvm"/>
-    <attribute name="tck.classes"/>
-    <attribute name="product.jar" default="${product.jar}"/>
-    <attribute name="jvmflags" default=""/>
+  <macrodef name="mirror-dir">
+    <attribute name="src"/>
+    <attribute name="dst"/>
     <sequential>
-    <java classname="JSR166TestCase"
-          jvm="@{jvm}" fork="true">
-	<jvmarg value="-Xbootclasspath/p:@{product.jar}"/>
-	<jvmarg line="@{jvmflags}"/>
-	<classpath>
-	  <pathelement location="${junit.jar}"/>
-	  <pathelement location="@{tck.classes}"/>
-	</classpath>
-    </java>
+    <delete dir="@{dst}"/>
+    <mkdir dir="@{dst}"/>
+    <copy todir="@{dst}" preservelastmodified="true">
+      <fileset dir="@{src}"/>
+    </copy>
     </sequential>
   </macrodef>
 
+  <defjdklocations v="17"/>
+  <defjdklocations v="18"/>
+  <defjdklocations v="19"/>
+  <defjdklocations v="20"/>
+
   <!-- Source locations -->
   <property name="src.dir"              location="${basedir}/src/main"/>
   <property name="test.src.dir"         location="${basedir}/src/test"/>
   <property name="loops.src.dir"        location="${basedir}/src/loops"/>
   <property name="tck.src.dir"          location="${test.src.dir}/tck"/>
-  <property name="jtreg.src.dir"        location="${test.src.dir}/jtreg"/>
+  <property name="jtreg17.src.dir"      location="${test.src.dir}/jtreg"/>
+  <property name="jtreg18.src.dir"      location="${test.src.dir}/jtreg"/>
+  <property name="jtreg19.src.dir"      location="${test.src.dir}/jtreg"/>
+  <property name="jtreg20.src.dir"      location="${test.src.dir}/jtreg"/>
+  <property name="jtreg.src.dir"        location="${jtreg17.src.dir}"/>
   <property name="lib.dir"              location="${basedir}/lib"/>
   <property name="dist.dir"             location="${basedir}/dist"/>
   <property name="topsrc.dir"           location="${basedir}/src"/>
-  <property name="4jdk7src.dir"         location="${topsrc.dir}/jdk7"/>
-  <property name="jsr166xsrc.dir"       location="${topsrc.dir}/jsr166x"/>
-  <property name="jsr166ysrc.dir"       location="${topsrc.dir}/jsr166y"/>
-  <property name="jsr166esrc.dir"       location="${topsrc.dir}/jsr166e"/>
-  <property name="extra166ysrc.dir"     location="${topsrc.dir}/extra166y"/>
-  <property name="jdksrc.dir"           location="/home/dl/1.6.0/j2se/martin/j2se/src/share/classes"/>
-
-  <!-- Distribution locations -->
-  <property name="dist.javadocs.dir"           location="${dist.dir}/docs"/>
-  <property name="dist.4jdk7.docs.dir"         location="${dist.dir}/jsr166-4jdk7docs"/>
-  <property name="dist.jsr166xjavadocs.dir"    location="${dist.dir}/jsr166xdocs"/>
-  <property name="dist.jsr166yjavadocs.dir"    location="${dist.dir}/jsr166ydocs"/>
-  <property name="dist.jsr166ejavadocs.dir"    location="${dist.dir}/jsr166edocs"/>
-  <property name="dist.extra166yjavadocs.dir"  location="${dist.dir}/extra166ydocs"/>
+
+  <!-- Javadoc locations -->
+  <property name="docs.dir"          location="${build.dir}/docs"/>
+  <property name="dist.docs.dir"     location="${dist.dir}/docs"/>
 
   <!-- Jar locations -->
-  <property name="product.jar"          location="${build.lib.dir}/jsr166.jar"/>
-  <property name="4jdk7product.jar"     location="${build.4jdk7.lib.dir}/jsr166-4jdk7.jar"/>
-  <property name="jsr166xproduct.jar"   location="${build.jsr166xlib.dir}/jsr166x.jar"/>
-  <property name="jsr166yproduct.jar"   location="${build.jsr166ylib.dir}/jsr166y.jar"/>
-  <property name="jsr166eproduct.jar"   location="${build.jsr166elib.dir}/jsr166e.jar"/>
-  <property name="extra166yproduct.jar" location="${build.extra166ylib.dir}/extra166y.jar"/>
-  <property name="junit.jar"            location="${lib.dir}/junit.jar"/>
+  <property name="product.jar"      location="${build.dir}/jsr166.jar"/>
+  <property name="junit.jar"        location="${lib.dir}/junit.jar"/>
 
-  <!-- Bootclasspath argument -->
-  <property name="bootclasspath.args"   value="-Xbootclasspath/p:${product.jar}"/>
+  <!-- Canonical location of jdk docs root, to use with javadoc -Xdocrootparent flag -->
+  <!-- Switched to https: in 2017-10 - JDK-8190312 -->
+  <property name="java17.docroot.url" value="https://docs.oracle.com/en/java/javase/17/docs"/>
+  <property name="java18.docroot.url" value="https://docs.oracle.com/en/java/javase/18/docs"/>
+  <property name="java19.docroot.url" value="https://docs.oracle.com/en/java/javase/19/docs"/>
+  <property name="java20.docroot.url" value="https://download.java.net/java/early_access/jdk20/docs"/>
+  <!-- Default jdk doc location (latest stable LTS release seems best) -->
+  <property name="java.docroot.url"   value="${java17.docroot.url}"/>
 
   <!-- Canonical location of jdk API docs, to use with javadoc link attribute -->
-  <property name="jdkapi5docs.url"      value="http://docs.oracle.com/javase/1.5.0/docs/api/"/>
-  <property name="jdkapi6docs.url"      value="http://docs.oracle.com/javase/6/docs/api/"/>
-  <property name="jdkapi7docs.url"      value="http://docs.oracle.com/javase/7/docs/api/"/>
-
-  <property name="jdkapi8docs.url"      value="http://download.java.net/jdk8/docs/api/"/>
-  <!-- The below does not yet exist as of 2012-11 -->
-  <!-- <property name="jdkapi8docs.url" value="http://docs.oracle.com/javase/8/docs/api/"/> -->
-  <property name="jdkapidocs.url"       value="${jdkapi7docs.url}"/>
-
-  <!-- Test classpath -->
-  <path id="test.classpath">
-    <pathelement location="${build.testcases.dir}"/>
-    <pathelement location="${junit.jar}"/>
-  </path>
+  <property name="java17.api.url"     value="${java17.docroot.url}/api/"/>
+  <property name="java18.api.url"     value="${java18.docroot.url}/api/"/>
+  <property name="java19.api.url"     value="${java19.docroot.url}/api/"/>
+  <property name="java20.api.url"     value="${java20.docroot.url}/api/"/>
+  <property name="java.api.url"       value="${java.docroot.url}/api/"/>
+
+  <!-- Define the "jtreg" task -->
+  <!-- See the docs in "jtreg -onlineHelp" -->
+  <taskdef name="jtreg" classname="com.sun.javatest.regtest.Main$$Ant"
+           classpath="${lib.dir}/jtreg.jar" />
+
+  <!-- Tck configuration options; see JSR166TestCase.java
+   To profile a single tck test class:
+   ant -Djsr166.profileTests=true -Djsr166.profileThreshold=10 -Djsr166.tckTestClass=CompletableFutureTest tck
+   To stress test a single tck test class:
+   ant -Djsr166.tckTestClass=CountedCompleterTest -Djsr166.runsPerTest=100 tck
+   To stress test a single tck test method:
+   ant -Djsr166.tckTestClass=RecursiveTaskTest -Djsr166.runsPerTest=1000 -Djsr166.methodFilter=testAbnormalInvokeAll3 tck
+  -->
+  <property name="jsr166.tckTestClass"     value="JSR166TestCase"/>
+  <macrodef name="run-tck-tests">
+    <attribute name="tck.src.dir" default="${tck.src.dir}"/>
+    <attribute name="target"/>
+    <attribute name="compile-target" default="@{target}"/>
+    <attribute name="workdir"/>
+    <attribute name="classes"/>
+    <!--
+        <attribute name="jvmflags" default="-XX:+UseParallelGC -XX:-UseBiasedLocking -ea -esa -Djsr166.testImplementationDetails=true"/>
+    -->
+        <attribute name="jvmflags" default="-ea -esa -Djsr166.testImplementationDetails=true"/>
+    <element name="javac-elements" optional="true"/>
+
+    <sequential>
+
+    <mkdir dir="@{workdir}/tck-classes"/>
+
+    <javac srcdir="@{tck.src.dir}"
+           destdir="@{workdir}/tck-classes"
+           debug="${build.debug}"
+           debuglevel="${build.debuglevel}"
+           deprecation="${build.deprecation}"
+           source="@{compile-target}"
+           target="@{compile-target}"
+           classpath="${junit.jar}"
+           includeAntRuntime="false"
+           includeJavaRuntime="false"
+           encoding="ASCII"
+           executable="${javac@{compile-target}}"
+           fork="true">
+
+      <include name="*.java"/>
+      <compilerarg value="-XDignore.symbol.file=true"/>
+      <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial,-deprecation,-try"/>
+      <compilerarg value="-Xdoclint:reference/private"/>
+      <compilerarg value="--patch-module=java.base=@{classes}"/>
+      <compilerarg line="${build.args}"/>
+      <javac-elements/>
+
+    </javac>
+
+    <java classname="${jsr166.tckTestClass}"
+          failonerror="true"
+          jvm="${java@{target}}"
+          fork="true">
+        <jvmarg value="--patch-module=java.base=@{classes}"/>
+        <jvmarg value="--add-opens=java.base/java.lang=ALL-UNNAMED"/>
+        <jvmarg value="--add-opens=java.base/java.util=ALL-UNNAMED"/>
+        <jvmarg value="--add-opens=java.base/java.util.concurrent=ALL-UNNAMED"/>
+        <jvmarg value="--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED"/>
+        <jvmarg value="--add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED"/>
+        <jvmarg line="@{jvmflags}"/>
+        <!-- ant -Dvmoptions="-Xmx8m" -Djsr166.tckTestClass=CompletableFutureTest tck -->
+        <jvmarg line="${vmoptions}" if:set="vmoptions"/>
+
+        <!-- ant -Djava.util.concurrent.ForkJoinPool.common.parallelism=1 tck -->
+        <syspropertyset id="system-properties-used-by-tck">
+          <propertyref prefix="java.util.concurrent.ForkJoinPool"/>
+          <propertyref prefix="jsr166."/>
+          <propertyref name="test.timeout.factor"/>
+        </syspropertyset>
+
+        <classpath>
+          <pathelement location="${junit.jar}"/>
+          <pathelement location="@{workdir}/tck-classes"/>
+        </classpath>
+    </java>
+
+    </sequential>
+  </macrodef>
+
+  <!-- Define jtreg test sets for different jdk versions -->
+  <!-- ant -Djtreg.test.pattern="**/ConcurrentHashMap/" -->
+  <!-- ant -Djtreg.test.pattern="**/ToArray.java" -->
+  <property name="jtreg.test.pattern" value="**/*.java"/>
+  <macrodef name="defjtregtests">
+    <attribute name="v"/>
+    <sequential>
+      <fileset dir="${jtreg@{v}.src.dir}">
+        <patternset id="jdk@{v}.jtreg.tests">
+          <include name="${jtreg.test.pattern}"/>
+        </patternset>
+      </fileset>
+    </sequential>
+  </macrodef>
+
+  <defjtregtests v="17"/>
+  <defjtregtests v="18"/>
+  <defjtregtests v="19"/>
+  <defjtregtests v="20"/>
+
+  <!-- ant -Djtreg.flags=-timeoutFactor:4 -->
+  <property name="jtreg.flags" value=""/>
+
+  <macrodef name="run-jtreg-tests">
+    <attribute name="target"/>
+    <attribute name="workdir"/>
+    <attribute name="classes"/>
+    <attribute name="verbose" default="${jtreg.verbose}"/>
+    <attribute name="jtregflags" default=""/>
+    <element name="jtreg-elements" optional="true"/>
+
+    <sequential>
+
+    <!-- ant -Djtreg.verbose=time,fail,error jtreg -->
+    <property name="jtreg.verbose" value="nopass,fail,error"/>
+
+    <!-- concurrency > 1 mitigates slowness of some jtreg tests -->
+    <!-- BUT concurrency:auto starts "too many" VMs; just 1 free core each -->
+    <!-- In 2020 concurrency:3 seems like a sweet spot -->
+    <!-- Override using:  ant -Djtreg.concurrency="N" jtreg -->
+    <property name="jtreg.concurrency" value="3"/>
+
+    <delete dir="@{workdir}/JTwork" quiet="true"/>
+    <jtreg dir="${jtreg@{target}.src.dir}"
+           jdk="${jdk@{target}.home}"
+           workDir="@{workdir}/JTwork">
+      <patternset refid="jdk@{target}.jtreg.tests"/>
+      <arg value="-javacoption:--patch-module=java.base=@{classes}"/>
+      <arg value="-vmoption:--patch-module=java.base=@{classes}"/>
+      <arg value="-vmoption:-Xmx256m"/>
+      <arg value="-concurrency:${jtreg.concurrency}"/>
+      <arg value="-vmoptions:-esa -ea"/>
+      <arg value="-vmoptions:${vmoptions}" if:set="vmoptions"/>
+      <arg value="-agentvm"/>
+      <arg value="-noreport"/>
+      <arg value="-verbose:@{verbose}"/>
+      <arg value="-automatic"/>
+      <arg value="-k:!ignore"/>
+      <arg line="@{jtregflags}"/>
+      <arg line="${jtreg.flags}"/>
+      <jtreg-elements/>
+    </jtreg>
+    </sequential>
+  </macrodef>
 
   <!-- ALoops classpath -->
   <path id="loops.classpath">
@@ -168,289 +286,211 @@
   </path>
 
   <!-- Support @jls tag, used in jdk8+ javadoc -->
-  <!-- TODO: How do we get &trade to work? -->
-  <!-- TODO: Why isn't @jls a "standard" tag? -->
-  <!--   property name="javadoc.jls.cite" value="The Java&trade; Language Specification" -->
-  <property name="javadoc.jls.cite" value="The Java Language Specification"/>
+  <!-- TODO: switch to @jls taglet, as supported by jdk14+ javadoc -->
+  <property name="javadoc.jls.cite" value="The Java&amp;trade; Language Specification"/>
   <property name="javadoc.jls.option" value="jls:a:See &lt;cite&gt;${javadoc.jls.cite}&lt;/cite&gt;:"/>
 
   <!-- Main targets -->
 
+  <!-- Default values: may seem strange ... -->
+  <!-- At runtime, target latest, but build for current LTS -->
+  <property name="java.runtime.target" value="19"/>
+  <property name="build.main.java" value="${java17}"/>
+  <property name="build.main.javac" value="${javac17}"/>
+  <property name="build.main.javadoc" value="${javadoc19}"/>
+  <property name="build.main.javadoc.source" value="${java.runtime.target}"/>
+
   <target name="dists"
-          depends="dist, jsr166xdist, jsr166ydist,jsr166edist,  extra166ydist"
+          depends="dist"
           description="Builds all public jars and docs"/>
 
   <target name="compile"
           depends="configure-compiler"
           description="Compiles src/main sources to build dir">
 
-    <mkdir dir="${build.classes.dir}"/>
+    <local name="destdir"/>
+    <property name="destdir" value="${build.classes.dir}/java.base"/>
+
+    <mkdir dir="${destdir}"/>
 
     <javac srcdir="${src.dir}"
-           destdir="${build.classes.dir}"
+           destdir="${destdir}"
            debug="${build.debug}"
            debuglevel="${build.debuglevel}"
            deprecation="${build.deprecation}"
            classpath=""
            includeAntRuntime="false"
            includeJavaRuntime="false"
-           executable="${javac8}"
+           encoding="ASCII"
+           executable="${build.main.javac}"
            fork="true">
 
       <include name="**/*.java"/>
-      <compilerarg line="${build.args}"/>
+      <compilerarg value="--patch-module=java.base=${src.dir}"/>
+      <compilerarg value="-Xprefer:source"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all"/>
-
-<!--
-      <exclude name="java/lang/**"/>
+      <compilerarg value="-Xdoclint:all/protected"/>
+      <compilerarg value="-Xdoclint/package:java.util.*"/>
+      <compilerarg value="-Werror"/>
+      <compilerarg line="-Xmaxerrs 1000 -Xmaxwarns 1000"/>
       <compilerarg line="${build.args}"/>
-      <compilerarg line="-Xlint -Xmaxwarns 1000"/>
--->
-
     </javac>
-
   </target>
 
-
-
   <target name="jar"
           depends="compile"
-          description="Builds library jar from compiled sources">
-
-    <mkdir dir="${build.lib.dir}"/>
-
+          description="Builds library jar for src/main from compiled sources">
+    <local name="subdir"/>
+    <available property="subdir" file="${build.classes.dir}/java.base" type="dir" value="/java.base"/>
     <jar destfile="${product.jar}">
-      <fileset dir="${build.classes.dir}"/>
+      <fileset dir="${build.classes.dir}${subdir}"/>
+      <manifest>
+        <attribute name="Built-By" value="${user.name}"/>
+        <attribute name="Implementation-Vendor" value="JCP JSR-166 Expert Group."/>
+      </manifest>
     </jar>
-
   </target>
 
 
-
-  <target name="test"
-          depends="configure-tests, report-tests"
-          description="Runs all tests (requires JUnit 3.8.1 in ${ant.home}/lib)" />
-
-
-
   <target name="docs"
           description="Builds javadocs for src/main to dist dir">
-
-    <delete dir="${dist.javadocs.dir}"/>
-    <mkdir dir="${dist.javadocs.dir}"/>
-
-    <!-- the packagenames="none" hack below prevents scanning the -->
-    <!-- sourcepath for packages -->
-
-    <javadoc destdir="${dist.javadocs.dir}"
+    <delete dir="${docs.dir}" quiet="true"/>
+    <mkdir dir="${docs.dir}"/>
+    <javadoc destdir="${docs.dir}"
              packagenames="none"
-             link="${jdkapi8docs.url}"
+             link="${java.api.url}"
              overview="${src.dir}/intro.html"
-             sourcepath="${src.dir}:${jdk8src.dir}"
+             access="${build.javadoc.access}"
+             sourcepath="${src.dir}"
              classpath=""
-             executable="${javadoc8}">
-      <arg value="-XDignore.symbol.file=true"/>
-      <arg value="-tag"/>
-      <arg value="${javadoc.jls.option}"/>
+             source="${build.main.javadoc.source}"
+             executable="${build.main.javadoc}">
       <fileset dir="${src.dir}" defaultexcludes="yes">
-        <include name="**/*.java"/>
+        <include name="java/**/*.java"/>
       </fileset>
+      <arg line="-Xdocrootparent ${java.docroot.url}"/>
+      <arg line="-Xmaxerrs 1000 -Xmaxwarns 1000"/>
+      <arg line="-Xmaxerrs 1000 -Xmaxwarns 1"/>
+      <arg value="-quiet"/>
+      <arg value="-XDignore.symbol.file=true"/>
+      <arg value="-html5"/>
+      <arg value="-Xdoclint:all,-missing"/>
+      <arg value="--patch-module=java.base=${src.dir}"/>
+      <arg value="--frames" if:set="use-frames"/>
+      <arg value="--override-methods=summary"/>
+      <arg value="-tag"/> <arg value="${javadoc.jls.option}"/>
+      <arg value="-tag"/> <arg value="implSpec:a:Implementation Requirements:"/>
+      <arg value="-tag"/> <arg value="implNote:a:Implementation Note:"/>
+      <arg value="-tag"/> <arg value="apiNote:a:API Note:"/>
     </javadoc>
-
   </target>
 
-
-
   <target name="dist"
-          depends="dist-clean, dist-jar, docs"
+          depends="dist-clean, dist-jar, dist-docs"
           description="Puts all distributable products in single hierarchy"/>
 
-
-  <target name="release"
-          depends="dist"
-          description="Puts entire CVS tree, plus distribution productions, in a jar">
-
-    <property name="release.jar" value="dist/jsr166-${version}-dist.jar"/>
-
-    <jar basedir="${basedir}" destfile="${release.jar}">
-      <!-- <exclude name="build/**"/> -->
-      <exclude name="${release.jar}"/>
-      <exclude name="user.properties"/>
-      <exclude name="etc/notes/**"/>
-      <exclude name="src/emulation/**"/>
-      <exclude name="**/SyntaxTest.java"/>
-      <exclude name="**/SuperfluousAbstract.java"/>
-    </jar>
-
-  </target>
-
-
-
   <target name="clean"
           description="Removes all build products">
-
     <delete dir="${build.dir}"/>
-    <delete dir="${build.classes.dir}"/>
-    <delete dir="${build.lib.dir}"/>
-
   </target>
 
-
-
   <target name="dist-clean"
           description="Removes all build and distribution products">
-
+    <delete dir="${build.dir}"/>
     <delete dir="${dist.dir}"/>
-
   </target>
 
-
-
-  <!-- Internal targets -->
-
-
   <target name="dist-jar"
           depends="clean, jar">
-
     <copy file="${product.jar}" todir="${dist.dir}"/>
-
   </target>
 
-
-  <target name="compile-tests"
-          depends="jar">
-
-    <mkdir dir="${build.testcases.dir}"/>
-
-    <javac srcdir="${tck.src.dir}"
-          destdir="${build.testcases.dir}"
-            debug="${build.debug}"
-       debuglevel="${build.debuglevel}"
-      deprecation="${build.deprecation}"
-           source="${build.sourcelevel}"
-             fork="true">
-
-      <compilerarg value="${bootclasspath.args}"/>
-      <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-
-      <classpath refid="test.classpath"/>
-
-    </javac>
-
-    <javac srcdir="${test.src.dir}"
-          destdir="${build.testcases.dir}"
-            debug="${build.debug}"
-       debuglevel="${build.debuglevel}"
-      deprecation="${build.deprecation}"
-           source="${build.sourcelevel}"
-             fork="true">
-
-      <include name="jsr166/test/**"/>
-
-      <compilerarg value="${bootclasspath.args}"/>
-      <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-
-      <classpath refid="test.classpath"/>
-
-    </javac>
-
-<!--
-    <javac srcdir="${jtreg.src.dir}"
-          destdir="${build.testcases.dir}"
-            debug="${build.debug}"
-       debuglevel="${build.debuglevel}"
-      deprecation="${build.deprecation}"
-           source="${build.sourcelevel}"
-             fork="true">
-
-      <compilerarg value="${bootclasspath.args}"/>
-      <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-
-      <classpath refid="test.classpath"/>
-
-    </javac>
--->
-
+  <target name="dist-docs"
+          depends="clean, docs">
+    <mirror-dir src="${docs.dir}" dst="${dist.docs.dir}"/>
   </target>
 
-
-  <target name="run-tests"
-          depends="compile-tests">
-
-    <!-- May be overridden by user.properties -->
-    <property name="testcase" value="*"/>
-
-    <mkdir dir="${build.reports.dir}"/>
-
-    <junit printsummary="true"
-             showoutput="true"
-          errorProperty="junit.failed"
-        failureProperty="junit.failed"
-                    dir="${build.reports.dir}"
-                   fork="true">
-
-      <jvmarg value="${bootclasspath.args}"/>
-      <jvmarg value="-server"/>
-      <jvmarg value="-showversion"/>
-
-      <classpath refid="test.classpath"/>
-
-      <formatter type="xml"/>
-
-      <batchtest todir="${build.reports.dir}" unless="no.test.tck">
-        <fileset dir="${tck.src.dir}">
-          <include name="**/${testcase}Test.java"/>
-        </fileset>
-      </batchtest>
-
-      <batchtest todir="${build.reports.dir}" if="do.test.old">
-        <fileset dir="${test.src.dir}">
-          <include name="jsr166/test/**/${testcase}Test.java"/>
-        </fileset>
-      </batchtest>
-
-<!--
-      <batchtest todir="${build.reports.dir}" if="do.test.jtreg">
-        <fileset dir="${jtreg.src.dir}">
-          <include name="**/${testcase}Test.java"/>
-        </fileset>
-      </batchtest>
--->
-
-    </junit>
-
+  <target name="tck"
+          depends="jar"
+          description="Runs tck tests for src/main directly">
+    <run-tck-tests
+      target="${java.runtime.target}"
+      workdir="${build.dir}"
+      classes="${product.jar}">
+      <javac-elements>
+        <!-- <compilerarg value="-Werror"/> -->
+      </javac-elements>
+    </run-tck-tests>
+  </target>
+
+  <target name="tck-parallelism-1"
+          description="Runs tck with common pool parallelism 1">
+    <antcall target="tck">
+      <param name="java.util.concurrent.ForkJoinPool.common.parallelism" value="1"/>
+    </antcall>
+  </target>
+
+  <target name="tck-parallelism-0"
+          description="Runs tck with common pool parallelism 0">
+    <antcall target="tck">
+      <param name="java.util.concurrent.ForkJoinPool.common.parallelism" value="0"/>
+    </antcall>
+  </target>
+
+  <target name="tck-security-manager"
+          description="Runs tck with a security manager">
+    <antcall target="tck">
+      <param name="jsr166.useSecurityManager" value="true"/>
+    </antcall>
+  </target>
+
+  <target name="jtreg"
+          depends="jar"
+          description="Runs jtreg tests for src/main using the jtreg ant task">
+    <run-jtreg-tests
+       target="${java.runtime.target}"
+       workdir="${build.dir}"
+       classes="${product.jar}"/>
   </target>
 
+  <target name="test"
+          depends="tck, tck-parallelism-1, tck-parallelism-0, jtreg"
+          description="Runs tck and jtreg tests for src/main"/>
 
-  <target name="report-tests"
-          depends="run-tests">
-
-    <!-- Sets junit.report.format to frames if redirection is present,
-         otherwise sets it to noframes. -->
-    <available property="junit.report.format"
-                  value="frames"
-              classname="org.apache.xalan.lib.Redirect"
-    />
-    <property name="junit.report.format" value="noframes"/>
-
-    <junitreport todir="${build.reports.dir}">
-      <fileset dir="${build.reports.dir}">
-        <include name="TEST-*.xml"/>
-      </fileset>
-      <report format="${junit.report.format}" todir="${build.reports.dir}"
-      />
-    </junitreport>
-
-    <fail message="Test Cases Failed" if="junit.failed"/>
-
+  <target name="test-version-permutations"
+          depends="test17, test19, clean, test, docs"
+          description="Runs tck and jtreg tests for various build-time and runtime java versions"/>
+
+
+  <target name="test17">
+    <antcall>
+      <param name="java.runtime.target" value="17"/>
+      <param name="build.main.javac" value="${javac17}"/>
+      <param name="build.main.javadoc" value="${javadoc17}"/>
+      <param name="build.main.javadoc.source" value="17"/>
+      <target name="clean"/>
+      <target name="test"/>
+      <target name="docs"/>
+    </antcall>
+  </target>
+  <target name="test19">
+    <antcall>
+      <param name="java.runtime.target" value="19"/>
+      <param name="build.main.javac" value="${javac19}"/>
+      <param name="build.main.javadoc" value="${javadoc19}"/>
+      <param name="build.main.javadoc.source" value="19"/>
+      <target name="clean"/>
+      <target name="test"/>
+      <target name="docs"/>
+    </antcall>
   </target>
 
 
   <target name="configure-compiler">
+    <fail message="ant version too old">
+      <condition> <not> <antversion atleast="1.9.1"/> </not> </condition>
+    </fail>
 
     <property name="unchecked.option" value="-Xlint:unchecked"/>
 
@@ -467,626 +507,243 @@
   </target>
 
 
-  <target name="configure-tests"
-       depends="configure-compiler">
-
-    <!-- junit.framework.Protectable is in JUnit 3.8.1 but not in 3.7 -->
-    <available property="junit.available"
-               classname="junit.framework.Protectable"/>
-
-    <!-- Xalan -->
-    <available property="xalan.available"
-               classname="org.apache.xalan.Version"/>
-
-
-    <!-- Ant 1.6beta and later don't need or want this check -->
-    <!--
-    <fail message="Need JUnit 3.8.1 in ${ant.home}${file.separator}lib to run tests"
-          unless="junit.available"/>
-
-    <fail message="Need Xalan 2.5.1 jar in ${ant.home}${file.separator}lib to run tests"
-          unless="xalan.available"/>
-    -->
-
-  </target>
-
-
-  <!-- Various demos and test programs -->
-
-
-  <target name="loops" depends="configure-compiler"
-          description="Benchmark from Doug Lea's AQS paper">
-
-    <mkdir dir="${build.loops.dir}"/>
-
-    <javac srcdir="${loops.src.dir}"
-          destdir="${build.loops.dir}"
-            debug="${build.debug}"
-       debuglevel="${build.debuglevel}"
-      deprecation="${build.deprecation}"
-           source="${build.sourcelevel}"
-             fork="true">
-
-      <compilerarg line="${build.args}"/>
-      <classpath refid="loops.classpath"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-
-    </javac>
-
-    <java classname="ALoops" fork="true">
-      <classpath refid="loops.classpath"/>
-    </java>
-
-  </target>
-
-
-  <!-- jsr166 4jdk7 -->
-
-
-  <target name="4jdk7compile"
-          depends="configure-compiler"
-          description="Compiles src/jdk7 sources, targeting jdk7">
-
-    <mkdir dir="${build.4jdk7.classes.dir}"/>
-
-    <javac srcdir="${4jdk7src.dir}"
-           destdir="${build.4jdk7.classes.dir}"
-           debug="${build.debug}"
-           debuglevel="${build.debuglevel}"
-           deprecation="${build.deprecation}"
-           source="1.6"
-           classpath=""
-           bootclasspath="${bootclasspath6}"
-           includeAntRuntime="false"
-           includeJavaRuntime="false"
-           executable="${javac7}"
-           fork="true">
-
-      <include name="**/*.java"/>
-      <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-      <compilerarg value="-Xlint:all"/>
-
-    </javac>
+  <target name="compile-test-loops" depends="jar"
+          description="Compiles all the perf tests in src/test/loops">
 
-    <mkdir dir="${build.4jdk7.lib.dir}"/>
+    <mkdir dir="${build.dir}/test/loops"/>
 
-    <jar destfile="${4jdk7product.jar}" index="true">
-      <fileset dir="${build.4jdk7.classes.dir}"/>
-    </jar>
-
-    <mkdir dir="${build.4jdk7.tck.classes.dir}"/>
-
-    <javac srcdir="${tck.src.dir}"
-           destdir="${build.4jdk7.tck.classes.dir}"
+    <javac srcdir="${basedir}/src/test/loops"
+           destdir="${build.dir}/test/loops"
            debug="${build.debug}"
            debuglevel="${build.debuglevel}"
            deprecation="${build.deprecation}"
-           source="1.6"
-           classpath="${junit.jar}"
-           bootclasspath="${4jdk7product.jar}:${bootclasspath6}"
            includeAntRuntime="false"
            includeJavaRuntime="false"
-           executable="${javac7}"
+           encoding="ASCII"
+           executable="${build.main.javac}"
            fork="true">
 
-      <include name="**/*.java"/>
-      <compilerarg line="${build.args}"/>
+      <include name="*.java"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial,-deprecation"/>
-
-    </javac>
-
-  </target>
-
-
-  <target name="4jdk7-test-tck"
-	  depends="4jdk7compile"
-          description="Runs tck tests for jsr166-4jdk7 directly">
-    <run-tck-tests
-      jvm="${java7}"
-      tck.classes="${build.4jdk7.tck.classes.dir}"
-      product.jar="${4jdk7product.jar}"/>
-  </target>
-
-
-  <target name="4jdk7-test-tck-junit"
-          depends="4jdk7compile"
-          description="Runs tck tests for jsr166-4jdk7 via junit task (experimental)">
-
-    <junit printsummary="true"
-           showoutput="true"
-           errorProperty="junit.failed"
-           failureProperty="junit.failed"
-           includeantruntime="true"
-           jvm="${java7}"
-           fork="true">
-
-      <jvmarg value="-Xbootclasspath/p:${4jdk7product.jar}"/>
-      <jvmarg value="-server"/>
-
-      <classpath>
-        <pathelement location="${junit.jar}"/>
-        <pathelement location="${build.4jdk7.tck.classes.dir}"/>
-      </classpath>
-
-      <formatter type="brief"/>
-
-      <test name="JSR166TestCase" haltonfailure="no">
-      </test>
-
-    </junit>
-  </target>
-
-
-  <target name="4jdk7docs"
-          description="Builds javadocs for src/jdk7 to dist dir">
-
-    <delete dir="${dist.4jdk7.docs.dir}"/>
-    <mkdir dir="${dist.4jdk7.docs.dir}"/>
-
-    <javadoc destdir="${dist.4jdk7.docs.dir}"
-             packagenames="none"
-             link="${jdkapi7docs.url}"
-             overview="${4jdk7src.dir}/intro.html"
-             sourcepath="${4jdk7src.dir}:${jdk7src.dir}"
-             classpath=""
-             executable="${javadoc7}">
-      <arg value="-XDignore.symbol.file=true"/>
-      <fileset dir="${4jdk7src.dir}" defaultexcludes="yes">
-        <include name="**/*.java"/>
-      </fileset>
-    </javadoc>
-
-  </target>
-
-
-  <target name="4jdk7dist"
-          depends="4jdk7dist-clean, 4jdk7dist-jar, 4jdk7docs"
-          description="Puts all distributable products in single hierarchy"/>
-
-
-
-  <target name="4jdk7clean"
-          description="Removes all build products">
-
-    <delete dir="${build.4jdk7.dir}"/>
-
-  </target>
-
-
-
-  <target name="4jdk7dist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
-  <target name="4jdk7dist-jar"
-          depends="4jdk7clean, 4jdk7compile">
-
-    <copy file="${4jdk7product.jar}" todir="${dist.dir}"/>
-
-  </target>
-
-  <!-- jsr166x -->
-
-
-  <target name="jsr166xcompile"
-          depends="configure-compiler"
-          description="Compiles jsr166x sources">
-
-    <mkdir dir="${build.jsr166x.dir}"/>
-
-    <javac srcdir="${jsr166xsrc.dir}"
-          destdir="${build.jsr166x.dir}"
-            debug="${build.debug}"
-       debuglevel="${build.debuglevel}"
-      deprecation="${build.deprecation}"
-           source="${build.sourcelevel}"
-             fork="true">
-
-      <include name="**/*.java"/>
+      <compilerarg value="--patch-module=java.base=${src.dir}"/>
       <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-
     </javac>
-
   </target>
 
 
+  <!-- old branches no longer maintained.  build support deleted -->
+  <!-- jsr166 4jdk8; (no longer maintained as of 2019-10) -->
+  <!-- jsr166 4jdk7 (no longer maintained) -->
+  <!-- jsr166x (no longer maintained) -->
+  <!-- jsr166y (no longer maintained) -->
+  <!-- extra166y (no longer maintained) -->
+  <!-- jsr166e (no longer maintained) -->
 
-  <target name="jsr166xjar"
-          depends="jsr166xcompile"
-          description="Builds library jar from compiled sources">
-
-    <mkdir dir="${build.jsr166xlib.dir}"/>
-
-    <jar destfile="${jsr166xproduct.jar}">
-      <fileset dir="${build.jsr166x.dir}"/>
-    </jar>
-
-  </target>
-
-
-
-  <target name="jsr166xdocs"
-          description="Builds javadocs to dist dir">
-
-    <delete dir="${build.jsr166xjavadocs.dir}"/>
-    <mkdir dir="${build.jsr166xjavadocs.dir}"/>
-
-    <javadoc destdir="${build.jsr166xjavadocs.dir}"
-             packagenames="jsr166x"
-             link="${jdkapidocs.url}"
-             source="${build.sourcelevel}"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-
-  <target name="jsr166xdist"
-          depends="jsr166xdist-clean, jsr166xdist-jar, jsr166xdist-docs"
-          description="Puts all distributable products in single hierarchy"/>
-
-
-
-  <target name="jsr166xclean"
-          description="Removes all build products">
-
-    <delete dir="${build.jsr166x.dir}"/>
-    <delete dir="${build.jsr166xlib.dir}"/>
-
-  </target>
-
-
-
-  <target name="jsr166xdist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
-
-
-  <target name="jsr166xdist-docs"
-          description="Builds javadocs to dist dir">
-
-    <delete dir="${dist.jsr166xjavadocs.dir}"/>
-    <mkdir dir="${dist.jsr166xjavadocs.dir}"/>
-
-    <javadoc destdir="${dist.jsr166xjavadocs.dir}"
-             packagenames="jsr166x"
-             link="${jdkapidocs.url}"
-             source="${build.sourcelevel}"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-  <target name="jsr166xdist-jar"
-          depends="jsr166xclean, jsr166xjar">
+<!-- Find buglets that can be detected by static build tools -->
 
-    <copy file="${jsr166xproduct.jar}" todir="${dist.dir}"/>
+<!--   <target name="lint"> -->
+<!--     <antcall target="dists"> -->
+<!--       <param name="build.javadoc.access" value="protected"/> -->
+<!--     </antcall> -->
+<!--   </target> -->
 
+<!-- Generates all doclint warnings, even for private methods (rarely useful) -->
+  <target name="doclint-private">
+    <antcall target="dist">
+      <param name="build.javadoc.access" value="private"/>
+    </antcall>
   </target>
 
-  <!-- jsr166y -->
-
-
-  <target name="jsr166ycompile"
-          depends="configure-compiler"
-          description="Compiles jsr166y sources">
 
-    <mkdir dir="${build.jsr166y.dir}"/>
+<!-- ==============================================================
+  Experimental errorprone support
+  https://errorprone.info
+  https://errorprone.info/docs/installation
+  https://github.com/google/error-prone/issues/1143
+=================================================================== -->
+  <path id="errorprone.processorpath.path">
+    <pathelement location="${lib.dir}/error_prone_core-2.3.4-with-dependencies.jar"/>
+    <pathelement location="${lib.dir}/dataflow-2.5.7.jar"/>
+    <pathelement location="${lib.dir}/javacutil-2.5.7.jar"/>
+    <pathelement location="${lib.dir}/jFormatString-3.0.0.jar"/>
+    <pathelement location="${lib.dir}/caffeine-2.8.0.jar"/>
+  </path>
+  <property name="errorprone.processorpath" refid="errorprone.processorpath.path" />
+  <property name="errorprone.jsr166.user.flags" value=""/>
+  <property name="errorprone.jsr166.flags"
+            value="-Xep:HashtableContains:OFF
+                   -Xep:PreferJavaTimeOverload:OFF
+                   -Xep:JdkObsolete:OFF
+                   -Xep:MissingOverride:OFF
+                   -Xep:MissingFail:OFF
+                   -Xep:ThreadPriorityCheck:OFF
+                   -Xep:MixedArrayDimensions:ERROR
+                   -Xep:RemoveUnusedImports:ERROR
+                   -Xep:EmptyIf:ERROR
+                   -Xep:MultipleTopLevelClasses:ERROR
+                   -Xep:ClassName:ERROR
+                   -Xep:LongLiteralLowerCaseSuffix:ERROR
+                   -Xep:RedundantThrows:ERROR
+                   -Xep:IdentityBinaryExpression:WARN
+                   -Xep:ConstructorInvokesOverridable:WARN
+                   -Xep:MethodCanBeStatic:WARN
+                   ${errorprone.jsr166.user.flags}"/>
+  <!-- -Xep:WildcardImport:ERROR -->
+  <property name="errorprone.jsr166.test.flags"
+            value="-Xep:StringSplitter:OFF
+                   -Xep:BoxedPrimitiveConstructor:OFF
+                   -Xep:UnnecessaryParentheses:OFF
+                   -Xep:ModifyingCollectionWithItself:OFF"/>
+  <!-- ant -emacs errorprone |& grep -EA1 '(warning|error):|warnings' -->
+  <target name="errorprone"
+          depends="clean, configure-compiler"
+          description="Run errorprone over jsr166 source code (experimental)">
+
+    <local name="destdir"/>
+    <property name="destdir" value="${build.classes.dir}/java.base"/>
+    <mkdir dir="${destdir}"/>
 
-    <javac srcdir="${topsrc.dir}"
-           destdir="${build.jsr166y.dir}"
+    <javac srcdir="${src.dir}"
+           destdir="${destdir}"
            debug="${build.debug}"
            debuglevel="${build.debuglevel}"
            deprecation="${build.deprecation}"
-           source="1.6"
            classpath=""
-           bootclasspath="${bootclasspath6}"
            includeAntRuntime="false"
            includeJavaRuntime="false"
-           executable="${javac7}"
+           encoding="ASCII"
+           executable="${build.main.javac}"
            fork="true">
 
-      <include name="jsr166y/**/*.java"/>
-      <compilerarg line="${build.args}"/>
+      <include name="**/*.java"/>
+      <!-- Needed to silence -Xep:FutureReturnValueIgnored -->
+      <compilerarg value="-J--illegal-access=permit"/>
+      <compilerarg value="-XDcompilePolicy=simple"/>
+      <compilerarg value="-processorpath"/>
+      <compilerarg pathref="errorprone.processorpath.path"/>
+      <compilerarg value="-Xplugin:ErrorProne
+                          ${errorprone.jsr166.flags}"/>
+      <compilerarg value="--patch-module=java.base=${src.dir}"/>
+      <compilerarg value="-Xprefer:source"/>
       <compilerarg value="-XDignore.symbol.file=true"/>
       <compilerarg value="-Xlint:all"/>
-    </javac>
-  </target>
-
-
-  <target name="jsr166yjar"
-          depends="jsr166ycompile"
-          description="Builds library jar from compiled sources">
-
-    <mkdir dir="${build.jsr166ylib.dir}"/>
-
-    <jar destfile="${jsr166yproduct.jar}" index="true">
-      <fileset dir="${build.jsr166y.dir}"/>
-    </jar>
-
-  </target>
-
-
-
-  <target name="jsr166ydocs"
-          description="Builds javadocs to dist dir">
-
-    <delete dir="${build.jsr166yjavadocs.dir}"/>
-    <mkdir dir="${build.jsr166yjavadocs.dir}"/>
-
-    <javadoc destdir="${build.jsr166yjavadocs.dir}"
-             packagenames="jsr166y"
-             link="${jdkapidocs.url}"
-             source="${build.sourcelevel}"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-
-  <target name="jsr166ydist"
-          depends="jsr166ydist-clean, jsr166ydist-jar, jsr166ydist-docs"
-          description="Puts all distributable products in single hierarchy"/>
-
-
-
-  <target name="jsr166yclean"
-          description="Removes all build products">
-
-    <delete dir="${build.jsr166y.dir}"/>
-    <delete dir="${build.jsr166ylib.dir}"/>
-
-  </target>
-
-
-
-  <target name="jsr166ydist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
-  <target name="jsr166ydist-docs"
-          description="Builds javadocs to dist dir">
-
-    <delete dir="${dist.jsr166yjavadocs.dir}"/>
-    <mkdir dir="${dist.jsr166yjavadocs.dir}"/>
-
-    <javadoc destdir="${dist.jsr166yjavadocs.dir}"
-             packagenames="jsr166y"
-             link="${jdkapidocs.url}"
-             source="${build.sourcelevel}"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-  <target name="jsr166ydist-jar"
-          depends="jsr166yclean, jsr166yjar">
-
-    <copy file="${jsr166yproduct.jar}" todir="${dist.dir}"/>
-
-  </target>
-
-
-  <!-- extra166y -->
-
-
-  <target name="extra166ycompile"
-          depends="configure-compiler, jsr166yjar"
-          description="Compiles extra166y sources">
-
-    <mkdir dir="${build.extra166y.dir}"/>
-
-    <javac srcdir="${topsrc.dir}"
-           destdir="${build.extra166y.dir}"
-           debug="${build.debug}"
-           classpath=""
-           debuglevel="${build.debuglevel}"
-           deprecation="${build.deprecation}"
-           source="1.6"
-           bootclasspath="${jsr166yproduct.jar}:${bootclasspath6}"
-           includeAntRuntime="false"
-           includeJavaRuntime="false"
-           executable="${javac7}"
-           fork="true">
-
-      <include name="extra166y/**/*.java"/>
-      <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-      <compilerarg value="-Xlint:all,-unchecked,-rawtypes,-serial"/>
-
-    </javac>
-
-  </target>
-
-
-
-  <target name="extra166yjar"
-          depends="extra166ycompile"
-          description="Builds library jar from compiled sources">
-
-    <mkdir dir="${build.extra166ylib.dir}"/>
-
-    <jar destfile="${extra166yproduct.jar}" index="true">
-      <fileset dir="${build.extra166y.dir}"/>
-    </jar>
-
-  </target>
-
-
-
-  <target name="extra166ydocs"
-          description="Builds javadocs with custom tags to build dir">
-
-    <delete dir="${build.extra166yjavadocs.dir}"/>
-    <mkdir dir="${build.extra166yjavadocs.dir}"/>
-
-    <javadoc destdir="${build.extra166yjavadocs.dir}"
-             packagenames="extra166y"
-             link="${jdkapidocs.url}"
-             source="${build.sourcelevel}"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-
-  <target name="extra166ydist"
-          depends="extra166ydist-clean, extra166ydist-jar, extra166ydist-docs"
-          description="Puts all distributable products in single hierarchy"/>
-
-
-
-  <target name="extra166yclean"
-          description="Removes all build products">
-
-    <delete dir="${build.extra166y.dir}"/>
-    <delete dir="${build.extra166ylib.dir}"/>
-
-  </target>
-
-
-
-  <target name="extra166ydist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
-  <target name="extra166ydist-docs"
-          description="Builds javadocs to dist dir">
-
-    <delete dir="${dist.extra166yjavadocs.dir}"/>
-    <mkdir dir="${dist.extra166yjavadocs.dir}"/>
-
-    <javadoc destdir="${dist.extra166yjavadocs.dir}"
-             packagenames="extra166y"
-             link="${jdkapidocs.url}"
-             source="${build.sourcelevel}"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-  <target name="extra166ydist-jar"
-          depends="extra166yclean, extra166yjar">
-
-    <copy file="${extra166yproduct.jar}" todir="${dist.dir}"/>
-
-  </target>
-
-  <!-- jsr166e -->
-
-  <target name="jsr166ecompile"
-          depends="configure-compiler"
-          description="Compiles jsr166e sources">
-
-    <mkdir dir="${build.jsr166e.dir}"/>
-
-    <javac srcdir="${topsrc.dir}"
-           destdir="${build.jsr166e.dir}"
-           debug="${build.debug}"
-           debuglevel="${build.debuglevel}"
-           deprecation="${build.deprecation}"
-           source="1.7"
-           classpath=""
-           includeAntRuntime="false"
-           includeJavaRuntime="false"
-           executable="${javac7}"
-           fork="true">
-
-      <include name="jsr166e/**/*.java"/>
+      <compilerarg value="-Xdoclint:all/protected,reference/private"/>
+      <!--      <compilerarg line="-Xmaxerrs 3000 -Xmaxwarns 3000"/> -->
+      <compilerarg line="-Xmaxerrs 3000 -Xmaxwarns 1"/>
       <compilerarg line="${build.args}"/>
-      <compilerarg value="-XDignore.symbol.file=true"/>
-      <compilerarg value="-Xlint:all"/>
-
     </javac>
 
-  </target>
-
-
-
-  <target name="jsr166ejar"
-          depends="jsr166ecompile"
-          description="Builds library jar from compiled sources">
-
-    <mkdir dir="${build.jsr166elib.dir}"/>
-
-    <jar destfile="${jsr166eproduct.jar}" index="true">
-      <fileset dir="${build.jsr166e.dir}"/>
+    <jar destfile="${product.jar}">
+      <fileset dir="${destdir}"/>
     </jar>
 
-  </target>
-
-
-
-  <target name="jsr166edocs"
-          description="Builds javadocs with custom tags to build dir">
-
-    <delete dir="${build.jsr166ejavadocs.dir}"/>
-    <mkdir dir="${build.jsr166ejavadocs.dir}"/>
-
-    <javadoc destdir="${build.jsr166ejavadocs.dir}"
-             packagenames="jsr166e,jsr166e.extra"
-             link="${jdkapi7docs.url}"
-             source="1.7"
-             sourcepath="${topsrc.dir}:${jdk7src.dir}"
-             executable="${javadoc7}"
-             additionalparam="-XDignore.symbol.file=true" >
-      <fileset dir="${topsrc.dir}" defaultexcludes="yes">
-        <include name="jsr166e/**/*.java"/>
-      </fileset>
-    </javadoc>
-
-  </target>
-
-
-  <target name="jsr166edist"
-          depends="jsr166edist-clean, jsr166edist-jar, jsr166edist-docs"
-          description="Puts all distributable products in single hierarchy"/>
-
-
-
-  <target name="jsr166eclean"
-          description="Removes all build products">
-
-    <delete dir="${build.jsr166e.dir}"/>
-    <delete dir="${build.jsr166elib.dir}"/>
-
-  </target>
-
-
-
-  <target name="jsr166edist-clean"
-          description="Removes all build and distribution products">
-
-  </target>
-
-  <target name="jsr166edist-docs"
-          description="Builds javadocs to dist dir">
-
-    <delete dir="${dist.jsr166ejavadocs.dir}"/>
-    <mkdir dir="${dist.jsr166ejavadocs.dir}"/>
-
-    <javadoc destdir="${dist.jsr166ejavadocs.dir}"
-             packagenames="jsr166e,jsr166e.extra"
-             link="${jdkapidocs.url}"
-             source="1.7"
-             sourcepath="${topsrc.dir}:${jdksrc.dir}"
-             additionalparam="-XDignore.symbol.file=true" />
-
-  </target>
-
-  <target name="jsr166edist-jar"
-          depends="jsr166eclean, jsr166ejar">
-
-    <copy file="${jsr166eproduct.jar}" todir="${dist.dir}"/>
+    <run-tck-tests
+      target="${java.runtime.target}"
+      workdir="${build.dir}"
+      classes="${product.jar}">
+      <javac-elements>
+        <!-- Needed to silence -Xep:FutureReturnValueIgnored -->
+        <compilerarg value="-J--illegal-access=permit"/>
+        <compilerarg value="-XDcompilePolicy=simple"/>
+        <compilerarg line="-processorpath ${errorprone.processorpath}"/>
+        <compilerarg value="-Xplugin:ErrorProne
+                            ${errorprone.jsr166.flags}
+                            ${errorprone.jsr166.test.flags}"/>
+        <!--      <compilerarg line="-Xmaxerrs 3000 -Xmaxwarns 3000"/> -->
+        <compilerarg line="-Xmaxerrs 3000 -Xmaxwarns 1"/>
+      </javac-elements>
+    </run-tck-tests>
+  </target>
+
+  <!-- ant -emacs errorprone-jtreg |& grep -EA1 '(warning|error):' -->
+  <!-- -XDcompilePolicy=simple or byfile avoids confusing UnusedImports -->
+  <target name="errorprone-jtreg"
+          depends="jar"
+          description="Run errorprone over jtreg tests (experimental)">
+
+    <run-jtreg-tests
+       target="${java.runtime.target}"
+       workdir="${build.dir}"
+       classes="${product.jar}"
+       verbose="all">
+      <jtreg-elements>
+        <arg value="-javacoption:-XDcompilePolicy=simple"/>
+        <arg value="-javacoption:-processorpath"/>
+        <arg value="-javacoption:${errorprone.processorpath}"/>
+        <arg value="-javacoption:-Xplugin:ErrorProne
+                            ${errorprone.jsr166.flags}
+                            ${errorprone.jsr166.test.flags}
+                            -Xep:MultipleTopLevelClasses:WARN
+                            -Xep:NonAtomicVolatileUpdate:OFF"/>
+      </jtreg-elements>
+    </run-jtreg-tests>
+  </target>
+
+
+<!-- ==============================================================
+  Running guava tests against jsr166 code
+=================================================================== -->
+
+<!-- <ivy:cachepath pathid="lib.path.id" inline="true" conf="*" -->
+<!--   organisation="com.google.guava" module="guava-testlib" revision="21.0"/> -->
+<!-- <property name="guava.version" value="21.0"/> -->
+
+<!-- HOWTO debug print a path id -->
+<!-- <pathconvert property="guava.testlib.classpath" refid="guava.testlib.classpath" /> -->
+<!-- <echo message="guava.testlib.classpath=${guava.testlib.classpath}"/> -->
+
+<!-- <ivy:retrieve pathid="guava.tests.classpath" type="jar" inline="true" conf="*" pattern="${lib.dir}/[type]/[artifact].[ext]" -->
+<!--   organisation="com.google.guava" module="guava-tests"/> -->
+<!-- <get src="http://repo2.maven.org/maven2/com/google/guava/guava-tests/${guava.version}/guava-tests-${guava.version}-tests.jar" -->
+<!--   dest="${lib.dir}/jar/guava-tests-tests.jar" usetimestamp="true"/> -->
+<!--     <ivy:cachepath pathid="lib.path.id" inline="true" conf="*" type="*" -->
+<!--       organisation="com.google.guava" module="guava-testlib" revision="${guava.version}"/> -->
+
+<!-- <test name="com.google.common.collect.testing.TestsForQueuesInJavaUtil"/> -->
+<!-- <test name="com.google.common.collect.testing.TestsForListsInJavaUtil"/> -->
+<!-- <test name="com.google.common.collect.testing.TestsForSetsInJavaUtil"/> -->
+<!-- <test name="com.google.common.collect.testing.TestsForMapsInJavaUtil"/> -->
+
+<!-- <ivy:retrieve pathid="guava.testlib.classpath" -->
+<!--   type="*" inline="true" conf="*(private),*(public)" -->
+<!--   pattern="${guava.dir}/[artifact].[ext]" -->
+<!--   organisation="com.google.guava" module="guava-testlib"/> -->
+
+<!-- Work around bug below by downloading guava-testlib-tests.jar "by hand": -->
+<!-- https://issues.apache.org/jira/browse/IVY-1444 -->
+<!-- maven tests artifacts cannot be downloaded because they are mapped to private configurations -->
+
+  <target name="init-ivy">
+    <get src="http://repo2.maven.org/maven2/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar"
+         dest="${build.dir}/ivy.jar" usetimestamp="true" skipexisting="true"/>
+    <taskdef resource="org/apache/ivy/ant/antlib.xml" uri="antlib:org.apache.ivy.ant"
+             classpath="${build.dir}/ivy.jar"/>
+  </target>
+
+  <target name="guava-tests" depends="jar, init-ivy"
+          description="Guava tests run against jsr166 collections">
+    <property name="guava.dir" value="${build.dir}/guava-testlib"/>
+    <mkdir dir="${guava.dir}"/>
+    <ivy:retrieve pathid="guava.testlib.classpath"
+      type="jar,bundle" inline="true" conf="default,master"
+      pattern="${guava.dir}/[artifact].[ext]"
+      organisation="com.google.guava" module="guava-testlib"/>
+    <property name="guava.version" value="21.0"/>
+    <get src="http://repo2.maven.org/maven2/com/google/guava/guava-testlib/${guava.version}/guava-testlib-${guava.version}-tests.jar"
+         dest="${guava.dir}/guava-testlib-tests.jar" usetimestamp="true"/>
+    <junit printsummary="true" showoutput="true" haltonfailure="true"
+           jvm="${build.main.java}" fork="true">
+      <jvmarg line="-ea -esa --patch-module=java.base=${product.jar}"/>
+      <formatter type="brief"/>
+      <classpath>
+        <pathelement location="${guava.dir}/guava-testlib-tests.jar"/>
+        <path refid="guava.testlib.classpath"/>
+      </classpath>
 
+      <!-- "6" in "OpenJdk6Tests" misleadingly means "6+" -->
+      <test name="com.google.common.collect.testing.OpenJdk6Tests"/>
+    </junit>
   </target>
 
 </project>