--- jsr166/src/jsr166e/DoubleAdder.java 2012/11/18 03:07:22 1.5 +++ jsr166/src/jsr166e/DoubleAdder.java 2014/05/05 20:20:15 1.12 @@ -5,10 +5,11 @@ */ package jsr166e; + import java.io.IOException; -import java.io.Serializable; import java.io.ObjectInputStream; import java.io.ObjectOutputStream; +import java.io.Serializable; /** * One or more variables that together maintain an initially zero @@ -19,9 +20,9 @@ import java.io.ObjectOutputStream; * variables maintaining the sum. * *

This class extends {@link Number}, but does not define - * methods such as {@code hashCode} and {@code compareTo} because - * instances are expected to be mutated, and so are not useful as - * collection keys. + * methods such as {@code equals}, {@code hashCode} and {@code + * compareTo} because instances are expected to be mutated, and so are + * not useful as collection keys. * *

jsr166e note: This class is targeted to be placed in * java.util.concurrent.atomic. @@ -62,15 +63,15 @@ public class DoubleAdder extends Striped * @param x the value to add */ public void add(double x) { - Cell[] as; long b, v; HashCode hc; Cell a; int n; + Cell[] as; long b, v; int[] hc; Cell a; int n; if ((as = cells) != null || !casBase(b = base, Double.doubleToRawLongBits (Double.longBitsToDouble(b) + x))) { boolean uncontended = true; - int h = (hc = threadHashCode.get()).code; - if (as == null || (n = as.length) < 1 || - (a = as[(n - 1) & h]) == null || + if ((hc = threadHashCode.get()) == null || + as == null || (n = as.length) < 1 || + (a = as[(n - 1) & hc[0]]) == null || !(uncontended = a.cas(v = a.value, Double.doubleToRawLongBits (Double.longBitsToDouble(v) + x)))) @@ -80,10 +81,10 @@ public class DoubleAdder extends Striped /** * Returns the current sum. The returned value is NOT an - * atomic snapshot: Invocation in the absence of concurrent + * atomic snapshot; invocation in the absence of concurrent * updates returns an accurate result, but concurrent updates that * occur while the sum is being calculated might not be - * incorporated. Also, because double-precision arithmetic is not + * incorporated. Also, because floating-point arithmetic is not * strictly associative, the returned result need not be identical * to the value that would be obtained in a sequential series of * updates to a single variable. @@ -184,14 +185,13 @@ public class DoubleAdder extends Striped return (float)sum(); } - private void writeObject(java.io.ObjectOutputStream s) - throws java.io.IOException { + private void writeObject(ObjectOutputStream s) throws IOException { s.defaultWriteObject(); s.writeDouble(sum()); } private void readObject(ObjectInputStream s) - throws IOException, ClassNotFoundException { + throws IOException, ClassNotFoundException { s.defaultReadObject(); busy = 0; cells = null;