ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/jsr166y/ForkJoinTask.java
(Generate patch)

Comparing jsr166/src/jsr166y/ForkJoinTask.java (file contents):
Revision 1.44 by jsr166, Wed Aug 19 17:44:45 2009 UTC vs.
Revision 1.53 by dl, Wed Aug 11 18:45:12 2010 UTC

# Line 64 | Line 64 | import java.util.WeakHashMap;
64   * results of a task is {@link #join}, but there are several variants:
65   * The {@link Future#get} methods support interruptible and/or timed
66   * waits for completion and report results using {@code Future}
67 < * conventions. Method {@link #helpJoin} enables callers to actively
68 < * execute other tasks while awaiting joins, which is sometimes more
69 < * efficient but only applies when all subtasks are known to be
70 < * strictly tree-structured. Method {@link #invoke} is semantically
67 > * conventions. Method {@link #invoke} is semantically
68   * equivalent to {@code fork(); join()} but always attempts to begin
69   * execution in the current thread. The "<em>quiet</em>" forms of
70   * these methods do not extract results or report exceptions. These
# Line 125 | Line 122 | import java.util.WeakHashMap;
122   *
123   * <p>This class provides {@code adapt} methods for {@link Runnable}
124   * and {@link Callable}, that may be of use when mixing execution of
125 < * {@code ForkJoinTasks} with other kinds of tasks. When all tasks
126 < * are of this form, consider using a pool in
130 < * {@linkplain ForkJoinPool#setAsyncMode async mode}.
125 > * {@code ForkJoinTasks} with other kinds of tasks. When all tasks are
126 > * of this form, consider using a pool constructed in <em>asyncMode</em>.
127   *
128   * <p>ForkJoinTasks are {@code Serializable}, which enables them to be
129   * used in extensions such as remote execution frameworks. It is
# Line 139 | Line 135 | import java.util.WeakHashMap;
135   */
136   public abstract class ForkJoinTask<V> implements Future<V>, Serializable {
137  
138 <    /**
139 <     * Run control status bits packed into a single int to minimize
140 <     * footprint and to ensure atomicity (via CAS).  Status is
141 <     * initially zero, and takes on nonnegative values until
142 <     * completed, upon which status holds COMPLETED. CANCELLED, or
143 <     * EXCEPTIONAL, which use the top 3 bits.  Tasks undergoing
144 <     * blocking waits by other threads have SIGNAL_MASK bits set --
145 <     * bit 15 for external (nonFJ) waits, and the rest a count of
146 <     * waiting FJ threads.  (This representation relies on
147 <     * ForkJoinPool max thread limits). Completion of a stolen task
148 <     * with SIGNAL_MASK bits set awakens waiter via notifyAll. Even
149 <     * though suboptimal for some purposes, we use basic builtin
150 <     * wait/notify to take advantage of "monitor inflation" in JVMs
151 <     * that we would otherwise need to emulate to avoid adding further
152 <     * per-task bookkeeping overhead. Note that bits 16-28 are
153 <     * currently unused. Also value 0x80000000 is available as spare
154 <     * completion value.
138 >    /*
139 >     * See the internal documentation of class ForkJoinPool for a
140 >     * general implementation overview.  ForkJoinTasks are mainly
141 >     * responsible for maintaining their "status" field amidst relays
142 >     * to methods in ForkJoinWorkerThread and ForkJoinPool. The
143 >     * methods of this class are more-or-less layered into (1) basic
144 >     * status maintenance (2) execution and awaiting completion (3)
145 >     * user-level methods that additionally report results. This is
146 >     * sometimes hard to see because this file orders exported methods
147 >     * in a way that flows well in javadocs. In particular, most
148 >     * join mechanics are in method quietlyJoin, below.
149 >     */
150 >
151 >    /*
152 >     * The status field holds run control status bits packed into a
153 >     * single int to minimize footprint and to ensure atomicity (via
154 >     * CAS).  Status is initially zero, and takes on nonnegative
155 >     * values until completed, upon which status holds value
156 >     * COMPLETED. CANCELLED, or EXCEPTIONAL. Tasks undergoing blocking
157 >     * waits by other threads have the SIGNAL bit set.  Completion of
158 >     * a stolen task with SIGNAL set awakens any waiters via
159 >     * notifyAll. Even though suboptimal for some purposes, we use
160 >     * basic builtin wait/notify to take advantage of "monitor
161 >     * inflation" in JVMs that we would otherwise need to emulate to
162 >     * avoid adding further per-task bookkeeping overhead.  We want
163 >     * these monitors to be "fat", i.e., not use biasing or thin-lock
164 >     * techniques, so use some odd coding idioms that tend to avoid
165 >     * them.
166       */
167 +
168 +    /** The run status of this task */
169      volatile int status; // accessed directly by pool and workers
170  
171 <    static final int COMPLETION_MASK      = 0xe0000000;
172 <    static final int NORMAL               = 0xe0000000; // == mask
173 <    static final int CANCELLED            = 0xc0000000;
174 <    static final int EXCEPTIONAL          = 0xa0000000;
166 <    static final int SIGNAL_MASK          = 0x0000ffff;
167 <    static final int INTERNAL_SIGNAL_MASK = 0x00007fff;
168 <    static final int EXTERNAL_SIGNAL      = 0x00008000; // top bit of low word
171 >    private static final int NORMAL      = -1;
172 >    private static final int CANCELLED   = -2;
173 >    private static final int EXCEPTIONAL = -3;
174 >    private static final int SIGNAL      =  1;
175  
176      /**
177       * Table of exceptions thrown by tasks, to enable reporting by
# Line 179 | Line 185 | public abstract class ForkJoinTask<V> im
185          Collections.synchronizedMap
186          (new WeakHashMap<ForkJoinTask<?>, Throwable>());
187  
188 <    // within-package utilities
188 >    // Maintaining completion status
189  
190      /**
191 <     * Gets current worker thread, or null if not a worker thread.
192 <     */
187 <    static ForkJoinWorkerThread getWorker() {
188 <        Thread t = Thread.currentThread();
189 <        return ((t instanceof ForkJoinWorkerThread) ?
190 <                (ForkJoinWorkerThread) t : null);
191 <    }
192 <
193 <    final boolean casStatus(int cmp, int val) {
194 <        return UNSAFE.compareAndSwapInt(this, statusOffset, cmp, val);
195 <    }
196 <
197 <    /**
198 <     * Workaround for not being able to rethrow unchecked exceptions.
199 <     */
200 <    static void rethrowException(Throwable ex) {
201 <        if (ex != null)
202 <            UNSAFE.throwException(ex);
203 <    }
204 <
205 <    // Setting completion status
206 <
207 <    /**
208 <     * Marks completion and wakes up threads waiting to join this task.
191 >     * Marks completion and wakes up threads waiting to join this task,
192 >     * also clearing signal request bits.
193       *
194       * @param completion one of NORMAL, CANCELLED, EXCEPTIONAL
195       */
196 <    final void setCompletion(int completion) {
197 <        ForkJoinPool pool = getPool();
198 <        if (pool != null) {
199 <            int s; // Clear signal bits while setting completion status
200 <            do {} while ((s = status) >= 0 && !casStatus(s, completion));
201 <
202 <            if ((s & SIGNAL_MASK) != 0) {
219 <                if ((s &= INTERNAL_SIGNAL_MASK) != 0)
220 <                    pool.updateRunningCount(s);
221 <                synchronized (this) { notifyAll(); }
196 >    private void setCompletion(int completion) {
197 >        int s;
198 >        while ((s = status) >= 0) {
199 >            if (UNSAFE.compareAndSwapInt(this, statusOffset, s, completion)) {
200 >                if (s != 0)
201 >                    synchronized (this) { notifyAll(); }
202 >                break;
203              }
204          }
224        else
225            externallySetCompletion(completion);
226    }
227
228    /**
229     * Version of setCompletion for non-FJ threads.  Leaves signal
230     * bits for unblocked threads to adjust, and always notifies.
231     */
232    private void externallySetCompletion(int completion) {
233        int s;
234        do {} while ((s = status) >= 0 &&
235                     !casStatus(s, (s & SIGNAL_MASK) | completion));
236        synchronized (this) { notifyAll(); }
205      }
206  
207      /**
208 <     * Sets status to indicate normal completion.
208 >     * Record exception and set exceptional completion
209 >     * @return status on exit
210       */
211 <    final void setNormalCompletion() {
212 <        // Try typical fast case -- single CAS, no signal, not already done.
213 <        // Manually expand casStatus to improve chances of inlining it
245 <        if (!UNSAFE.compareAndSwapInt(this, statusOffset, 0, NORMAL))
246 <            setCompletion(NORMAL);
247 <    }
248 <
249 <    // internal waiting and notification
250 <
251 <    /**
252 <     * Performs the actual monitor wait for awaitDone.
253 <     */
254 <    private void doAwaitDone() {
255 <        // Minimize lock bias and in/de-flation effects by maximizing
256 <        // chances of waiting inside sync
257 <        try {
258 <            while (status >= 0)
259 <                synchronized (this) { if (status >= 0) wait(); }
260 <        } catch (InterruptedException ie) {
261 <            onInterruptedWait();
262 <        }
211 >    private void setExceptionalCompletion(Throwable rex) {
212 >        exceptionMap.put(this, rex);
213 >        setCompletion(EXCEPTIONAL);
214      }
215  
216      /**
217 <     * Performs the actual timed monitor wait for awaitDone.
217 >     * Blocks a worker thread until completion. Called only by pool.
218       */
219 <    private void doAwaitDone(long startTime, long nanos) {
220 <        synchronized (this) {
219 >    final void internalAwaitDone() {
220 >        int s;         // the odd construction reduces lock bias effects
221 >        while ((s = status) >= 0) {
222              try {
223 <                while (status >= 0) {
224 <                    long nt = nanos - (System.nanoTime() - startTime);
225 <                    if (nt <= 0)
274 <                        break;
275 <                    wait(nt / 1000000, (int) (nt % 1000000));
223 >                synchronized(this) {
224 >                    if (UNSAFE.compareAndSwapInt(this, statusOffset, s,SIGNAL))
225 >                        wait();
226                  }
227              } catch (InterruptedException ie) {
228 <                onInterruptedWait();
279 <            }
280 <        }
281 <    }
282 <
283 <    // Awaiting completion
284 <
285 <    /**
286 <     * Sets status to indicate there is joiner, then waits for join,
287 <     * surrounded with pool notifications.
288 <     *
289 <     * @return status upon exit
290 <     */
291 <    private int awaitDone(ForkJoinWorkerThread w,
292 <                          boolean maintainParallelism) {
293 <        ForkJoinPool pool = (w == null) ? null : w.pool;
294 <        int s;
295 <        while ((s = status) >= 0) {
296 <            if (casStatus(s, (pool == null) ? s|EXTERNAL_SIGNAL : s+1)) {
297 <                if (pool == null || !pool.preJoin(this, maintainParallelism))
298 <                    doAwaitDone();
299 <                if (((s = status) & INTERNAL_SIGNAL_MASK) != 0)
300 <                    adjustPoolCountsOnUnblock(pool);
301 <                break;
228 >                cancelIfTerminating();
229              }
230          }
304        return s;
231      }
232  
233      /**
234 <     * Timed version of awaitDone
309 <     *
310 <     * @return status upon exit
234 >     * Blocks a non-worker-thread until completion.
235       */
236 <    private int awaitDone(ForkJoinWorkerThread w, long nanos) {
313 <        ForkJoinPool pool = (w == null) ? null : w.pool;
236 >    private void externalAwaitDone() {
237          int s;
238          while ((s = status) >= 0) {
239 <            if (casStatus(s, (pool == null) ? s|EXTERNAL_SIGNAL : s+1)) {
240 <                long startTime = System.nanoTime();
241 <                if (pool == null || !pool.preJoin(this, false))
242 <                    doAwaitDone(startTime, nanos);
243 <                if ((s = status) >= 0) {
244 <                    adjustPoolCountsOnCancelledWait(pool);
245 <                    s = status;
246 <                }
247 <                if (s < 0 && (s & INTERNAL_SIGNAL_MASK) != 0)
248 <                    adjustPoolCountsOnUnblock(pool);
249 <                break;
250 <            }
328 <        }
329 <        return s;
330 <    }
331 <
332 <    /**
333 <     * Notifies pool that thread is unblocked. Called by signalled
334 <     * threads when woken by non-FJ threads (which is atypical).
335 <     */
336 <    private void adjustPoolCountsOnUnblock(ForkJoinPool pool) {
337 <        int s;
338 <        do {} while ((s = status) < 0 && !casStatus(s, s & COMPLETION_MASK));
339 <        if (pool != null && (s &= INTERNAL_SIGNAL_MASK) != 0)
340 <            pool.updateRunningCount(s);
341 <    }
342 <
343 <    /**
344 <     * Notifies pool to adjust counts on cancelled or timed out wait.
345 <     */
346 <    private void adjustPoolCountsOnCancelledWait(ForkJoinPool pool) {
347 <        if (pool != null) {
348 <            int s;
349 <            while ((s = status) >= 0 && (s & INTERNAL_SIGNAL_MASK) != 0) {
350 <                if (casStatus(s, s - 1)) {
351 <                    pool.updateRunningCount(1);
239 >            synchronized(this) {
240 >                if (UNSAFE.compareAndSwapInt(this, statusOffset, s, SIGNAL)){
241 >                    boolean interrupted = false;
242 >                    while (status >= 0) {
243 >                        try {
244 >                            wait();
245 >                        } catch (InterruptedException ie) {
246 >                            interrupted = true;
247 >                        }
248 >                    }
249 >                    if (interrupted)
250 >                        Thread.currentThread().interrupt();
251                      break;
252                  }
253              }
# Line 356 | Line 255 | public abstract class ForkJoinTask<V> im
255      }
256  
257      /**
258 <     * Handles interruptions during waits.
259 <     */
260 <    private void onInterruptedWait() {
362 <        ForkJoinWorkerThread w = getWorker();
363 <        if (w == null)
364 <            Thread.currentThread().interrupt(); // re-interrupt
365 <        else if (w.isTerminating())
366 <            cancelIgnoringExceptions();
367 <        // else if FJworker, ignore interrupt
368 <    }
369 <
370 <    // Recording and reporting exceptions
371 <
372 <    private void setDoneExceptionally(Throwable rex) {
373 <        exceptionMap.put(this, rex);
374 <        setCompletion(EXCEPTIONAL);
375 <    }
376 <
377 <    /**
378 <     * Throws the exception associated with status s.
379 <     *
380 <     * @throws the exception
381 <     */
382 <    private void reportException(int s) {
383 <        if ((s &= COMPLETION_MASK) < NORMAL) {
384 <            if (s == CANCELLED)
385 <                throw new CancellationException();
386 <            else
387 <                rethrowException(exceptionMap.get(this));
388 <        }
389 <    }
390 <
391 <    /**
392 <     * Returns result or throws exception using j.u.c.Future conventions.
393 <     * Only call when {@code isDone} known to be true or thread known
394 <     * to be interrupted.
395 <     */
396 <    private V reportFutureResult()
397 <        throws InterruptedException, ExecutionException {
398 <        if (Thread.interrupted())
399 <            throw new InterruptedException();
400 <        int s = status & COMPLETION_MASK;
401 <        if (s < NORMAL) {
402 <            Throwable ex;
403 <            if (s == CANCELLED)
404 <                throw new CancellationException();
405 <            if (s == EXCEPTIONAL && (ex = exceptionMap.get(this)) != null)
406 <                throw new ExecutionException(ex);
407 <        }
408 <        return getRawResult();
409 <    }
410 <
411 <    /**
412 <     * Returns result or throws exception using j.u.c.Future conventions
413 <     * with timeouts.
414 <     */
415 <    private V reportTimedFutureResult()
416 <        throws InterruptedException, ExecutionException, TimeoutException {
417 <        if (Thread.interrupted())
418 <            throw new InterruptedException();
419 <        Throwable ex;
420 <        int s = status & COMPLETION_MASK;
421 <        if (s == NORMAL)
422 <            return getRawResult();
423 <        else if (s == CANCELLED)
424 <            throw new CancellationException();
425 <        else if (s == EXCEPTIONAL && (ex = exceptionMap.get(this)) != null)
426 <            throw new ExecutionException(ex);
427 <        else
428 <            throw new TimeoutException();
429 <    }
430 <
431 <    // internal execution methods
432 <
433 <    /**
434 <     * Calls exec, recording completion, and rethrowing exception if
435 <     * encountered. Caller should normally check status before calling.
436 <     *
437 <     * @return true if completed normally
438 <     */
439 <    private boolean tryExec() {
440 <        try { // try block must contain only call to exec
441 <            if (!exec())
442 <                return false;
443 <        } catch (Throwable rex) {
444 <            setDoneExceptionally(rex);
445 <            rethrowException(rex);
446 <            return false; // not reached
447 <        }
448 <        setNormalCompletion();
449 <        return true;
450 <    }
451 <
452 <    /**
453 <     * Main execution method used by worker threads. Invokes
454 <     * base computation unless already complete.
258 >     * Unless done, calls exec and records status if completed, but
259 >     * doesn't wait for completion otherwise. Primary execution method
260 >     * for ForkJoinWorkerThread.
261       */
262      final void quietlyExec() {
457        if (status >= 0) {
458            try {
459                if (!exec())
460                    return;
461            } catch (Throwable rex) {
462                setDoneExceptionally(rex);
463                return;
464            }
465            setNormalCompletion();
466        }
467    }
468
469    /**
470     * Calls exec(), recording but not rethrowing exception.
471     * Caller should normally check status before calling.
472     *
473     * @return true if completed normally
474     */
475    private boolean tryQuietlyInvoke() {
263          try {
264 <            if (!exec())
265 <                return false;
264 >            if (status < 0 || !exec())
265 >                return;
266          } catch (Throwable rex) {
267 <            setDoneExceptionally(rex);
268 <            return false;
482 <        }
483 <        setNormalCompletion();
484 <        return true;
485 <    }
486 <
487 <    /**
488 <     * Cancels, ignoring any exceptions it throws.
489 <     */
490 <    final void cancelIgnoringExceptions() {
491 <        try {
492 <            cancel(false);
493 <        } catch (Throwable ignore) {
267 >            setExceptionalCompletion(rex);
268 >            return;
269          }
270 <    }
496 <
497 <    /**
498 <     * Main implementation of helpJoin
499 <     */
500 <    private int busyJoin(ForkJoinWorkerThread w) {
501 <        int s;
502 <        ForkJoinTask<?> t;
503 <        while ((s = status) >= 0 && (t = w.scanWhileJoining(this)) != null)
504 <            t.quietlyExec();
505 <        return (s >= 0) ? awaitDone(w, false) : s; // block if no work
270 >        setCompletion(NORMAL); // must be outside try block
271      }
272  
273      // public methods
# Line 540 | Line 305 | public abstract class ForkJoinTask<V> im
305       * @return the computed result
306       */
307      public final V join() {
308 <        ForkJoinWorkerThread w = getWorker();
309 <        if (w == null || status < 0 || !w.unpushTask(this) || !tryExec())
310 <            reportException(awaitDone(w, true));
308 >        quietlyJoin();
309 >        Throwable ex;
310 >        if (status < NORMAL && (ex = getException()) != null)
311 >            UNSAFE.throwException(ex);
312          return getRawResult();
313      }
314  
# Line 554 | Line 320 | public abstract class ForkJoinTask<V> im
320       * @return the computed result
321       */
322      public final V invoke() {
323 <        if (status >= 0 && tryExec())
324 <            return getRawResult();
325 <        else
326 <            return join();
323 >        quietlyInvoke();
324 >        Throwable ex;
325 >        if (status < NORMAL && (ex = getException()) != null)
326 >            UNSAFE.throwException(ex);
327 >        return getRawResult();
328      }
329  
330      /**
# Line 617 | Line 384 | public abstract class ForkJoinTask<V> im
384                  t.fork();
385              else {
386                  t.quietlyInvoke();
387 <                if (ex == null)
387 >                if (ex == null && t.status < NORMAL)
388                      ex = t.getException();
389              }
390          }
# Line 628 | Line 395 | public abstract class ForkJoinTask<V> im
395                      t.cancel(false);
396                  else {
397                      t.quietlyJoin();
398 <                    if (ex == null)
398 >                    if (ex == null && t.status < NORMAL)
399                          ex = t.getException();
400                  }
401              }
402          }
403          if (ex != null)
404 <            rethrowException(ex);
404 >            UNSAFE.throwException(ex);
405      }
406  
407      /**
# Line 679 | Line 446 | public abstract class ForkJoinTask<V> im
446                  t.fork();
447              else {
448                  t.quietlyInvoke();
449 <                if (ex == null)
449 >                if (ex == null && t.status < NORMAL)
450                      ex = t.getException();
451              }
452          }
# Line 690 | Line 457 | public abstract class ForkJoinTask<V> im
457                      t.cancel(false);
458                  else {
459                      t.quietlyJoin();
460 <                    if (ex == null)
460 >                    if (ex == null && t.status < NORMAL)
461                          ex = t.getException();
462                  }
463              }
464          }
465          if (ex != null)
466 <            rethrowException(ex);
466 >            UNSAFE.throwException(ex);
467          return tasks;
468      }
469  
# Line 726 | Line 493 | public abstract class ForkJoinTask<V> im
493       */
494      public boolean cancel(boolean mayInterruptIfRunning) {
495          setCompletion(CANCELLED);
496 <        return (status & COMPLETION_MASK) == CANCELLED;
496 >        return status == CANCELLED;
497 >    }
498 >
499 >    /**
500 >     * Cancels, ignoring any exceptions thrown by cancel. Used during
501 >     * worker and pool shutdown. Cancel is spec'ed not to throw any
502 >     * exceptions, but if it does anyway, we have no recourse during
503 >     * shutdown, so guard against this case.
504 >     */
505 >    final void cancelIgnoringExceptions() {
506 >        try {
507 >            cancel(false);
508 >        } catch (Throwable ignore) {
509 >        }
510 >    }
511 >
512 >    /**
513 >     * Cancels ignoring exceptions if worker is terminating
514 >     */
515 >    final void cancelIfTerminating() {
516 >        Thread t = Thread.currentThread();
517 >        if ((t instanceof ForkJoinWorkerThread) &&
518 >            ((ForkJoinWorkerThread) t).isTerminating()) {
519 >            try {
520 >                cancel(false);
521 >            } catch (Throwable ignore) {
522 >            }
523 >        }
524      }
525  
526      public final boolean isDone() {
# Line 734 | Line 528 | public abstract class ForkJoinTask<V> im
528      }
529  
530      public final boolean isCancelled() {
531 <        return (status & COMPLETION_MASK) == CANCELLED;
531 >        return status == CANCELLED;
532      }
533  
534      /**
# Line 743 | Line 537 | public abstract class ForkJoinTask<V> im
537       * @return {@code true} if this task threw an exception or was cancelled
538       */
539      public final boolean isCompletedAbnormally() {
540 <        return (status & COMPLETION_MASK) < NORMAL;
540 >        return status < NORMAL;
541      }
542  
543      /**
# Line 754 | Line 548 | public abstract class ForkJoinTask<V> im
548       * exception and was not cancelled
549       */
550      public final boolean isCompletedNormally() {
551 <        return (status & COMPLETION_MASK) == NORMAL;
551 >        return status == NORMAL;
552      }
553  
554      /**
# Line 765 | Line 559 | public abstract class ForkJoinTask<V> im
559       * @return the exception, or {@code null} if none
560       */
561      public final Throwable getException() {
562 <        int s = status & COMPLETION_MASK;
562 >        int s = status;
563          return ((s >= NORMAL)    ? null :
564                  (s == CANCELLED) ? new CancellationException() :
565                  exceptionMap.get(this));
# Line 786 | Line 580 | public abstract class ForkJoinTask<V> im
580       * thrown will be a {@code RuntimeException} with cause {@code ex}.
581       */
582      public void completeExceptionally(Throwable ex) {
583 <        setDoneExceptionally((ex instanceof RuntimeException) ||
584 <                             (ex instanceof Error) ? ex :
585 <                             new RuntimeException(ex));
583 >        setExceptionalCompletion((ex instanceof RuntimeException) ||
584 >                                 (ex instanceof Error) ? ex :
585 >                                 new RuntimeException(ex));
586      }
587  
588      /**
# Line 807 | Line 601 | public abstract class ForkJoinTask<V> im
601          try {
602              setRawResult(value);
603          } catch (Throwable rex) {
604 <            setDoneExceptionally(rex);
604 >            setExceptionalCompletion(rex);
605              return;
606          }
607 <        setNormalCompletion();
607 >        setCompletion(NORMAL);
608      }
609  
610      public final V get() throws InterruptedException, ExecutionException {
611 <        ForkJoinWorkerThread w = getWorker();
612 <        if (w == null || status < 0 || !w.unpushTask(this) || !tryQuietlyInvoke())
613 <            awaitDone(w, true);
614 <        return reportFutureResult();
611 >        quietlyJoin();
612 >        if (Thread.interrupted())
613 >            throw new InterruptedException();
614 >        int s = status;
615 >        if (s < NORMAL) {
616 >            Throwable ex;
617 >            if (s == CANCELLED)
618 >                throw new CancellationException();
619 >            if (s == EXCEPTIONAL && (ex = exceptionMap.get(this)) != null)
620 >                throw new ExecutionException(ex);
621 >        }
622 >        return getRawResult();
623      }
624  
625      public final V get(long timeout, TimeUnit unit)
626          throws InterruptedException, ExecutionException, TimeoutException {
627 <        long nanos = unit.toNanos(timeout);
628 <        ForkJoinWorkerThread w = getWorker();
629 <        if (w == null || status < 0 || !w.unpushTask(this) || !tryQuietlyInvoke())
630 <            awaitDone(w, nanos);
631 <        return reportTimedFutureResult();
632 <    }
633 <
634 <    /**
635 <     * Possibly executes other tasks until this task {@link #isDone is
636 <     * done}, then returns the result of the computation.  This method
637 <     * may be more efficient than {@code join}, but is only applicable
638 <     * when there are no potential dependencies between continuation
639 <     * of the current task and that of any other task that might be
640 <     * executed while helping. (This usually holds for pure
641 <     * divide-and-conquer tasks).
642 <     *
643 <     * <p>This method may be invoked only from within {@code
644 <     * ForkJoinTask} computations (as may be determined using method
645 <     * {@link #inForkJoinPool}).  Attempts to invoke in other contexts
646 <     * result in exceptions or errors, possibly including {@code
647 <     * ClassCastException}.
648 <     *
649 <     * @return the computed result
650 <     */
651 <    public final V helpJoin() {
652 <        ForkJoinWorkerThread w = (ForkJoinWorkerThread) Thread.currentThread();
653 <        if (status < 0 || !w.unpushTask(this) || !tryExec())
654 <            reportException(busyJoin(w));
655 <        return getRawResult();
656 <    }
657 <
658 <    /**
659 <     * Possibly executes other tasks until this task {@link #isDone is
660 <     * done}.  This method may be useful when processing collections
661 <     * of tasks when some have been cancelled or otherwise known to
662 <     * have aborted.
663 <     *
664 <     * <p>This method may be invoked only from within {@code
665 <     * ForkJoinTask} computations (as may be determined using method
666 <     * {@link #inForkJoinPool}).  Attempts to invoke in other contexts
667 <     * result in exceptions or errors, possibly including {@code
668 <     * ClassCastException}.
669 <     */
670 <    public final void quietlyHelpJoin() {
671 <        if (status >= 0) {
672 <            ForkJoinWorkerThread w =
673 <                (ForkJoinWorkerThread) Thread.currentThread();
674 <            if (!w.unpushTask(this) || !tryQuietlyInvoke())
675 <                busyJoin(w);
627 >        Thread t = Thread.currentThread();
628 >        ForkJoinPool pool;
629 >        if (t instanceof ForkJoinWorkerThread) {
630 >            ForkJoinWorkerThread w = (ForkJoinWorkerThread) t;
631 >            if (status >= 0 && w.unpushTask(this))
632 >                quietlyExec();
633 >            pool = w.pool;
634 >        }
635 >        else
636 >            pool = null;
637 >        /*
638 >         * Timed wait loop intermixes cases for FJ (pool != null) and
639 >         * non FJ threads. For FJ, decrement pool count but don't try
640 >         * for replacement; increment count on completion. For non-FJ,
641 >         * deal with interrupts. This is messy, but a little less so
642 >         * than is splitting the FJ and nonFJ cases.
643 >         */
644 >        boolean interrupted = false;
645 >        boolean dec = false; // true if pool count decremented
646 >        for (;;) {
647 >            if (Thread.interrupted() && pool == null) {
648 >                interrupted = true;
649 >                break;
650 >            }
651 >            int s = status;
652 >            if (s < 0)
653 >                break;
654 >            if (UNSAFE.compareAndSwapInt(this, statusOffset, s, SIGNAL)) {
655 >                long startTime = System.nanoTime();
656 >                long nanos = unit.toNanos(timeout);
657 >                long nt; // wait time
658 >                while (status >= 0 &&
659 >                       (nt = nanos - (System.nanoTime() - startTime)) > 0) {
660 >                    if (pool != null && !dec)
661 >                        dec = pool.tryDecrementRunningCount();
662 >                    else {
663 >                        long ms = nt / 1000000;
664 >                        int ns = (int) (nt % 1000000);
665 >                        try {
666 >                            synchronized(this) {
667 >                                if (status >= 0)
668 >                                    wait(ms, ns);
669 >                            }
670 >                        } catch (InterruptedException ie) {
671 >                            if (pool != null)
672 >                                cancelIfTerminating();
673 >                            else {
674 >                                interrupted = true;
675 >                                break;
676 >                            }
677 >                        }
678 >                    }
679 >                }
680 >                break;
681 >            }
682 >        }
683 >        if (pool != null && dec)
684 >            pool.incrementRunningCount();
685 >        if (interrupted)
686 >            throw new InterruptedException();
687 >        int es = status;
688 >        if (es != NORMAL) {
689 >            Throwable ex;
690 >            if (es == CANCELLED)
691 >                throw new CancellationException();
692 >            if (es == EXCEPTIONAL && (ex = exceptionMap.get(this)) != null)
693 >                throw new ExecutionException(ex);
694 >            throw new TimeoutException();
695          }
696 +        return getRawResult();
697      }
698  
699      /**
700 <     * Joins this task, without returning its result or throwing an
700 >     * Joins this task, without returning its result or throwing its
701       * exception. This method may be useful when processing
702       * collections of tasks when some have been cancelled or otherwise
703       * known to have aborted.
704       */
705      public final void quietlyJoin() {
706 <        if (status >= 0) {
707 <            ForkJoinWorkerThread w = getWorker();
708 <            if (w == null || !w.unpushTask(this) || !tryQuietlyInvoke())
709 <                awaitDone(w, true);
706 >        Thread t;
707 >        if ((t = Thread.currentThread()) instanceof ForkJoinWorkerThread) {
708 >            ForkJoinWorkerThread w = (ForkJoinWorkerThread) t;
709 >            if (status >= 0) {
710 >                if (w.unpushTask(this)) {
711 >                    boolean completed;
712 >                    try {
713 >                        completed = exec();
714 >                    } catch (Throwable rex) {
715 >                        setExceptionalCompletion(rex);
716 >                        return;
717 >                    }
718 >                    if (completed) {
719 >                        setCompletion(NORMAL);
720 >                        return;
721 >                    }
722 >                }
723 >                w.joinTask(this);
724 >            }
725          }
726 +        else
727 +            externalAwaitDone();
728      }
729  
730      /**
731       * Commences performing this task and awaits its completion if
732 <     * necessary, without returning its result or throwing an
732 >     * necessary, without returning its result or throwing its
733       * exception. This method may be useful when processing
734       * collections of tasks when some have been cancelled or otherwise
735       * known to have aborted.
736       */
737      public final void quietlyInvoke() {
738 <        if (status >= 0 && !tryQuietlyInvoke())
739 <            quietlyJoin();
738 >        if (status >= 0) {
739 >            boolean completed;
740 >            try {
741 >                completed = exec();
742 >            } catch (Throwable rex) {
743 >                setExceptionalCompletion(rex);
744 >                return;
745 >            }
746 >            if (completed)
747 >                setCompletion(NORMAL);
748 >            else
749 >                quietlyJoin();
750 >        }
751      }
752  
753      /**
# Line 929 | Line 779 | public abstract class ForkJoinTask<V> im
779       * pre-constructed trees of subtasks in loops.
780       */
781      public void reinitialize() {
782 <        if ((status & COMPLETION_MASK) == EXCEPTIONAL)
782 >        if (status == EXCEPTIONAL)
783              exceptionMap.remove(this);
784          status = 0;
785      }
# Line 1219 | Line 1069 | public abstract class ForkJoinTask<V> im
1069      private static final long serialVersionUID = -7721805057305804111L;
1070  
1071      /**
1072 <     * Save the state to a stream.
1072 >     * Saves the state to a stream.
1073       *
1074       * @serialData the current run status and the exception thrown
1075       * during execution, or {@code null} if none
# Line 1232 | Line 1082 | public abstract class ForkJoinTask<V> im
1082      }
1083  
1084      /**
1085 <     * Reconstitute the instance from a stream.
1085 >     * Reconstitutes the instance from a stream.
1086       *
1087       * @param s the stream
1088       */
1089      private void readObject(java.io.ObjectInputStream s)
1090          throws java.io.IOException, ClassNotFoundException {
1091          s.defaultReadObject();
1242        status &= ~INTERNAL_SIGNAL_MASK; // clear internal signal counts
1243        status |= EXTERNAL_SIGNAL; // conservatively set external signal
1092          Object ex = s.readObject();
1093          if (ex != null)
1094 <            setDoneExceptionally((Throwable) ex);
1094 >            setExceptionalCompletion((Throwable) ex);
1095      }
1096  
1097      // Unsafe mechanics

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines