ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/jsr166y/Phaser.java
(Generate patch)

Comparing jsr166/src/jsr166y/Phaser.java (file contents):
Revision 1.11 by jsr166, Thu Mar 19 04:49:44 2009 UTC vs.
Revision 1.44 by dl, Tue Aug 25 16:32:28 2009 UTC

# Line 7 | Line 7
7   package jsr166y;
8  
9   import java.util.concurrent.*;
10 < import java.util.concurrent.atomic.*;
10 >
11 > import java.util.concurrent.atomic.AtomicReference;
12   import java.util.concurrent.locks.LockSupport;
12 import sun.misc.Unsafe;
13 import java.lang.reflect.*;
13  
14   /**
15 < * A reusable synchronization barrier, similar in functionality to a
15 > * A reusable synchronization barrier, similar in functionality to
16   * {@link java.util.concurrent.CyclicBarrier CyclicBarrier} and
17   * {@link java.util.concurrent.CountDownLatch CountDownLatch}
18   * but supporting more flexible usage.
19   *
20 < * <ul>
21 < *
22 < * <li> The number of parties synchronizing on a phaser may vary over
23 < * time.  A task may register to be a party at any time, and may
24 < * deregister upon arriving at the barrier.  As is the case with most
25 < * basic synchronization constructs, registration and deregistration
26 < * affect only internal counts; they do not establish any further
27 < * internal bookkeeping, so tasks cannot query whether they are
28 < * registered. (However, you can introduce such bookkeeping by
29 < * subclassing this class.)
30 < *
31 < * <li> Each generation has an associated phase value, starting at
32 < * zero, and advancing when all parties reach the barrier (wrapping
33 < * around to zero after reaching {@code Integer.MAX_VALUE}).
34 < *
35 < * <li> Like a CyclicBarrier, a Phaser may be repeatedly awaited.
36 < * Method {@code arriveAndAwaitAdvance} has effect analogous to
37 < * {@code CyclicBarrier.await}.  However, Phasers separate two
38 < * aspects of coordination, that may also be invoked independently:
20 > * <p> <b>Registration.</b> Unlike the case for other barriers, the
21 > * number of parties <em>registered</em> to synchronize on a phaser
22 > * may vary over time.  Tasks may be registered at any time (using
23 > * methods {@link #register}, {@link #bulkRegister}, or forms of
24 > * constructors establishing initial numbers of parties), and
25 > * optionally deregistered upon any arrival (using {@link
26 > * #arriveAndDeregister}).  As is the case with most basic
27 > * synchronization constructs, registration and deregistration affect
28 > * only internal counts; they do not establish any further internal
29 > * bookkeeping, so tasks cannot query whether they are registered.
30 > * (However, you can introduce such bookkeeping by subclassing this
31 > * class.)
32 > *
33 > * <p> <b>Synchronization.</b> Like a {@code CyclicBarrier}, a {@code
34 > * Phaser} may be repeatedly awaited.  Method {@link
35 > * #arriveAndAwaitAdvance} has effect analogous to {@link
36 > * java.util.concurrent.CyclicBarrier#await CyclicBarrier.await}. Each
37 > * generation of a {@code Phaser} has an associated phase number. The
38 > * phase number starts at zero, and advances when all parties arrive
39 > * at the barrier, wrapping around to zero after reaching {@code
40 > * Integer.MAX_VALUE}. The use of phase numbers enables independent
41 > * control of actions upon arrival at a barrier and upon awaiting
42 > * others, via two kinds of methods that may be invoked by any
43 > * registered party:
44   *
45   * <ul>
46   *
47 < *   <li> Arriving at a barrier. Methods {@code arrive} and
48 < *       {@code arriveAndDeregister} do not block, but return
49 < *       the phase value current upon entry to the method.
50 < *
51 < *   <li> Awaiting others. Method {@code awaitAdvance} requires an
52 < *       argument indicating the entry phase, and returns when the
53 < *       barrier advances to a new phase.
54 < * </ul>
47 > *   <li> <b>Arrival.</b> Methods {@link #arrive} and
48 > *       {@link #arriveAndDeregister} record arrival at a
49 > *       barrier. These methods do not block, but return an associated
50 > *       <em>arrival phase number</em>; that is, the phase number of
51 > *       the barrier to which the arrival applied. When the final
52 > *       party for a given phase arrives, an optional barrier action
53 > *       is performed and the phase advances.  Barrier actions,
54 > *       performed by the party triggering a phase advance, are
55 > *       arranged by overriding method {@link #onAdvance(int, int)},
56 > *       which also controls termination. Overriding this method is
57 > *       similar to, but more flexible than, providing a barrier
58 > *       action to a {@code CyclicBarrier}.
59 > *
60 > *   <li> <b>Waiting.</b> Method {@link #awaitAdvance} requires an
61 > *       argument indicating an arrival phase number, and returns when
62 > *       the barrier advances to (or is already at) a different phase.
63 > *       Unlike similar constructions using {@code CyclicBarrier},
64 > *       method {@code awaitAdvance} continues to wait even if the
65 > *       waiting thread is interrupted. Interruptible and timeout
66 > *       versions are also available, but exceptions encountered while
67 > *       tasks wait interruptibly or with timeout do not change the
68 > *       state of the barrier. If necessary, you can perform any
69 > *       associated recovery within handlers of those exceptions,
70 > *       often after invoking {@code forceTermination}.  Phasers may
71 > *       also be used by tasks executing in a {@link ForkJoinPool},
72 > *       which will ensure sufficient parallelism to execute tasks
73 > *       when others are blocked waiting for a phase to advance.
74   *
75 + * </ul>
76   *
77 < * <li> Barrier actions, performed by the task triggering a phase
78 < * advance while others may be waiting, are arranged by overriding
79 < * method {@code onAdvance}, that also controls termination.
80 < * Overriding this method may be used to similar but more flexible
81 < * effect as providing a barrier action to a CyclicBarrier.
82 < *
83 < * <li> Phasers may enter a <em>termination</em> state in which all
84 < * actions immediately return without updating phaser state or waiting
85 < * for advance, and indicating (via a negative phase value) that
86 < * execution is complete.  Termination is triggered by executing the
87 < * overridable {@code onAdvance} method that is invoked each time the
64 < * barrier is about to be tripped. When a Phaser is controlling an
65 < * action with a fixed number of iterations, it is often convenient to
66 < * override this method to cause termination when the current phase
67 < * number reaches a threshold. Method {@code forceTermination} is also
68 < * available to abruptly release waiting threads and allow them to
69 < * terminate.
77 > * <p> <b>Termination.</b> A {@code Phaser} may enter a
78 > * <em>termination</em> state in which all synchronization methods
79 > * immediately return without updating phaser state or waiting for
80 > * advance, and indicating (via a negative phase value) that execution
81 > * is complete.  Termination is triggered when an invocation of {@code
82 > * onAdvance} returns {@code true}.  As illustrated below, when
83 > * phasers control actions with a fixed number of iterations, it is
84 > * often convenient to override this method to cause termination when
85 > * the current phase number reaches a threshold. Method {@link
86 > * #forceTermination} is also available to abruptly release waiting
87 > * threads and allow them to terminate.
88   *
89 < * <li> Phasers may be tiered to reduce contention. Phasers with large
89 > * <p> <b>Tiering.</b> Phasers may be <em>tiered</em> (i.e., arranged
90 > * in tree structures) to reduce contention. Phasers with large
91   * numbers of parties that would otherwise experience heavy
92 < * synchronization contention costs may instead be arranged in trees.
93 < * This will typically greatly increase throughput even though it
94 < * incurs somewhat greater per-operation overhead.
95 < *
96 < * <li> By default, {@code awaitAdvance} continues to wait even if
97 < * the waiting thread is interrupted. And unlike the case in
98 < * CyclicBarriers, exceptions encountered while tasks wait
99 < * interruptibly or with timeout do not change the state of the
100 < * barrier. If necessary, you can perform any associated recovery
101 < * within handlers of those exceptions, often after invoking
102 < * {@code forceTermination}.
103 < *
104 < * <li>Phasers ensure lack of starvation when used by ForkJoinTasks.
105 < *
106 < * </ul>
92 > * synchronization contention costs may instead be set up so that
93 > * groups of sub-phasers share a common parent.  This may greatly
94 > * increase throughput even though it incurs greater per-operation
95 > * overhead.
96 > *
97 > * <p><b>Monitoring.</b> While synchronization methods may be invoked
98 > * only by registered parties, the current state of a phaser may be
99 > * monitored by any caller.  At any given moment there are {@link
100 > * #getRegisteredParties} parties in total, of which {@link
101 > * #getArrivedParties} have arrived at the current phase ({@link
102 > * #getPhase}).  When the remaining ({@link #getUnarrivedParties})
103 > * parties arrive, the phase advances.  The values returned by these
104 > * methods may reflect transient states and so are not in general
105 > * useful for synchronization control.  Method {@link #toString}
106 > * returns snapshots of these state queries in a form convenient for
107 > * informal monitoring.
108   *
109   * <p><b>Sample usages:</b>
110   *
111 < * <p>A Phaser may be used instead of a {@code CountDownLatch} to control
112 < * a one-shot action serving a variable number of parties. The typical
113 < * idiom is for the method setting this up to first register, then
114 < * start the actions, then deregister, as in:
115 < *
116 < * <pre>
117 < *  void runTasks(List&lt;Runnable&gt; list) {
118 < *    final Phaser phaser = new Phaser(1); // "1" to register self
119 < *    for (Runnable r : list) {
120 < *      phaser.register();
121 < *      new Thread() {
122 < *        public void run() {
123 < *          phaser.arriveAndAwaitAdvance(); // await all creation
124 < *          r.run();
125 < *          phaser.arriveAndDeregister();   // signal completion
126 < *        }
127 < *      }.start();
111 > * <p>A {@code Phaser} may be used instead of a {@code CountDownLatch}
112 > * to control a one-shot action serving a variable number of
113 > * parties. The typical idiom is for the method setting this up to
114 > * first register, then start the actions, then deregister, as in:
115 > *
116 > *  <pre> {@code
117 > * void runTasks(List<Runnable> tasks) {
118 > *   final Phaser phaser = new Phaser(1); // "1" to register self
119 > *   // create and start threads
120 > *   for (Runnable task : tasks) {
121 > *     phaser.register();
122 > *     new Thread() {
123 > *       public void run() {
124 > *         phaser.arriveAndAwaitAdvance(); // await all creation
125 > *         task.run();
126 > *       }
127 > *     }.start();
128   *   }
129   *
130 < *   doSomethingOnBehalfOfWorkers();
131 < *   phaser.arrive(); // allow threads to start
132 < *   int p = phaser.arriveAndDeregister(); // deregister self  ...
113 < *   p = phaser.awaitAdvance(p); // ... and await arrival
114 < *   otherActions(); // do other things while tasks execute
115 < *   phaser.awaitAdvance(p); // await final completion
116 < * }
117 < * </pre>
130 > *   // allow threads to start and deregister self
131 > *   phaser.arriveAndDeregister();
132 > * }}</pre>
133   *
134   * <p>One way to cause a set of threads to repeatedly perform actions
135   * for a given number of iterations is to override {@code onAdvance}:
136   *
137 < * <pre>
138 < *  void startTasks(List&lt;Runnable&gt; list, final int iterations) {
139 < *    final Phaser phaser = new Phaser() {
140 < *       public boolean onAdvance(int phase, int registeredParties) {
141 < *         return phase &gt;= iterations || registeredParties == 0;
137 > *  <pre> {@code
138 > * void startTasks(List<Runnable> tasks, final int iterations) {
139 > *   final Phaser phaser = new Phaser() {
140 > *     protected boolean onAdvance(int phase, int registeredParties) {
141 > *       return phase >= iterations || registeredParties == 0;
142 > *     }
143 > *   };
144 > *   phaser.register();
145 > *   for (Runnable task : tasks) {
146 > *     phaser.register();
147 > *     new Thread() {
148 > *       public void run() {
149 > *         do {
150 > *           task.run();
151 > *           phaser.arriveAndAwaitAdvance();
152 > *         } while(!phaser.isTerminated();
153   *       }
154 < *    };
129 < *    phaser.register();
130 < *    for (Runnable r : list) {
131 < *      phaser.register();
132 < *      new Thread() {
133 < *        public void run() {
134 < *           do {
135 < *             r.run();
136 < *             phaser.arriveAndAwaitAdvance();
137 < *           } while(!phaser.isTerminated();
138 < *        }
139 < *      }.start();
154 > *     }.start();
155   *   }
156   *   phaser.arriveAndDeregister(); // deregister self, don't wait
157 < * }
143 < * </pre>
157 > * }}</pre>
158   *
159 < * <p> To create a set of tasks using a tree of Phasers,
159 > * If the main task must later await termination, it
160 > * may re-register and then execute a similar loop:
161 > * <pre> {@code
162 > *   // ...
163 > *   phaser.register();
164 > *   while (!phaser.isTerminated())
165 > *     phaser.arriveAndAwaitAdvance();
166 > * }</pre>
167 > *
168 > * Related constructions may be used to await particular phase numbers
169 > * in contexts where you are sure that the phase will never wrap around
170 > * {@code Integer.MAX_VALUE}. For example:
171 > *
172 > * <pre> {@code
173 > *   void awaitPhase(Phaser phaser, int phase) {
174 > *     int p = phaser.register(); // assumes caller not already registered
175 > *     while (p < phase) {
176 > *       if (phaser.isTerminated())
177 > *         // ... deal with unexpected termination
178 > *       else
179 > *         p = phaser.arriveAndAwaitAdvance();
180 > *     }
181 > *     phaser.arriveAndDeregister();
182 > *   }
183 > * }</pre>
184 > *
185 > *
186 > * <p>To create a set of tasks using a tree of phasers,
187   * you could use code of the following form, assuming a
188 < * Task class with a constructor accepting a Phaser that
188 > * Task class with a constructor accepting a phaser that
189   * it registers for upon construction:
190 < * <pre>
191 < *  void build(Task[] actions, int lo, int hi, Phaser b) {
192 < *    int step = (hi - lo) / TASKS_PER_PHASER;
193 < *    if (step &gt; 1) {
194 < *       int i = lo;
195 < *       while (i &lt; hi) {
196 < *         int r = Math.min(i + step, hi);
197 < *         build(actions, i, r, new Phaser(b));
198 < *         i = r;
199 < *       }
200 < *    }
201 < *    else {
202 < *      for (int i = lo; i &lt; hi; ++i)
203 < *        actions[i] = new Task(b);
204 < *        // assumes new Task(b) performs b.register()
164 < *    }
165 < *  }
166 < *  // .. initially called, for n tasks via
167 < *  build(new Task[n], 0, n, new Phaser());
168 < * </pre>
190 > *  <pre> {@code
191 > * void build(Task[] actions, int lo, int hi, Phaser ph) {
192 > *   if (hi - lo > TASKS_PER_PHASER) {
193 > *     for (int i = lo; i < hi; i += TASKS_PER_PHASER) {
194 > *       int j = Math.min(i + TASKS_PER_PHASER, hi);
195 > *       build(actions, i, j, new Phaser(ph));
196 > *     }
197 > *   } else {
198 > *     for (int i = lo; i < hi; ++i)
199 > *       actions[i] = new Task(ph);
200 > *       // assumes new Task(ph) performs ph.register()
201 > *   }
202 > * }
203 > * // .. initially called, for n tasks via
204 > * build(new Task[n], 0, n, new Phaser());}</pre>
205   *
206   * The best value of {@code TASKS_PER_PHASER} depends mainly on
207   * expected barrier synchronization rates. A value as low as four may
# Line 176 | Line 212 | import java.lang.reflect.*;
212   *
213   * <p><b>Implementation notes</b>: This implementation restricts the
214   * maximum number of parties to 65535. Attempts to register additional
215 < * parties result in IllegalStateExceptions. However, you can and
215 > * parties result in {@code IllegalStateException}. However, you can and
216   * should create tiered phasers to accommodate arbitrarily large sets
217   * of participants.
218 + *
219 + * @since 1.7
220 + * @author Doug Lea
221   */
222   public class Phaser {
223      /*
# Line 207 | Line 246 | public class Phaser {
246       */
247      private volatile long state;
248  
210    private static final int ushortBits = 16;
249      private static final int ushortMask = 0xffff;
250      private static final int phaseMask  = 0x7fffffff;
251  
252      private static int unarrivedOf(long s) {
253 <        return (int)(s & ushortMask);
253 >        return (int) (s & ushortMask);
254      }
255  
256      private static int partiesOf(long s) {
257 <        return ((int)s) >>> 16;
257 >        return ((int) s) >>> 16;
258      }
259  
260      private static int phaseOf(long s) {
261 <        return (int)(s >>> 32);
261 >        return (int) (s >>> 32);
262      }
263  
264      private static int arrivedOf(long s) {
# Line 228 | Line 266 | public class Phaser {
266      }
267  
268      private static long stateFor(int phase, int parties, int unarrived) {
269 <        return ((((long)phase) << 32) | (((long)parties) << 16) |
270 <                (long)unarrived);
269 >        return ((((long) phase) << 32) | (((long) parties) << 16) |
270 >                (long) unarrived);
271      }
272  
273      private static long trippedStateFor(int phase, int parties) {
274 <        long lp = (long)parties;
275 <        return (((long)phase) << 32) | (lp << 16) | lp;
274 >        long lp = (long) parties;
275 >        return (((long) phase) << 32) | (lp << 16) | lp;
276      }
277  
278      /**
279 <     * Returns message string for bad bounds exceptions
279 >     * Returns message string for bad bounds exceptions.
280       */
281      private static String badBounds(int parties, int unarrived) {
282          return ("Attempt to set " + unarrived +
# Line 251 | Line 289 | public class Phaser {
289      private final Phaser parent;
290  
291      /**
292 <     * The root of Phaser tree. Equals this if not in a tree.  Used to
292 >     * The root of phaser tree. Equals this if not in a tree.  Used to
293       * support faster state push-down.
294       */
295      private final Phaser root;
# Line 267 | Line 305 | public class Phaser {
305      private final AtomicReference<QNode> oddQ  = new AtomicReference<QNode>();
306  
307      private AtomicReference<QNode> queueFor(int phase) {
308 <        return (phase & 1) == 0? evenQ : oddQ;
308 >        return ((phase & 1) == 0) ? evenQ : oddQ;
309      }
310  
311      /**
# Line 275 | Line 313 | public class Phaser {
313       * root if necessary.
314       */
315      private long getReconciledState() {
316 <        return parent == null? state : reconcileState();
316 >        return (parent == null) ? state : reconcileState();
317      }
318  
319      /**
# Line 302 | Line 340 | public class Phaser {
340      }
341  
342      /**
343 <     * Creates a new Phaser without any initially registered parties,
343 >     * Creates a new phaser without any initially registered parties,
344       * initial phase number 0, and no parent. Any thread using this
345 <     * Phaser will need to first register for it.
345 >     * phaser will need to first register for it.
346       */
347      public Phaser() {
348          this(null);
349      }
350  
351      /**
352 <     * Creates a new Phaser with the given numbers of registered
352 >     * Creates a new phaser with the given numbers of registered
353       * unarrived parties, initial phase number 0, and no parent.
354 <     * @param parties the number of parties required to trip barrier.
354 >     *
355 >     * @param parties the number of parties required to trip barrier
356       * @throws IllegalArgumentException if parties less than zero
357 <     * or greater than the maximum number of parties supported.
357 >     * or greater than the maximum number of parties supported
358       */
359      public Phaser(int parties) {
360          this(null, parties);
361      }
362  
363      /**
364 <     * Creates a new Phaser with the given parent, without any
364 >     * Creates a new phaser with the given parent, without any
365       * initially registered parties. If parent is non-null this phaser
366       * is registered with the parent and its initial phase number is
367       * the same as that of parent phaser.
368 <     * @param parent the parent phaser.
368 >     *
369 >     * @param parent the parent phaser
370       */
371      public Phaser(Phaser parent) {
372          int phase = 0;
# Line 341 | Line 381 | public class Phaser {
381      }
382  
383      /**
384 <     * Creates a new Phaser with the given parent and numbers of
385 <     * registered unarrived parties. If parent is non-null this phaser
384 >     * Creates a new phaser with the given parent and numbers of
385 >     * registered unarrived parties. If parent is non-null, this phaser
386       * is registered with the parent and its initial phase number is
387       * the same as that of parent phaser.
388 <     * @param parent the parent phaser.
389 <     * @param parties the number of parties required to trip barrier.
388 >     *
389 >     * @param parent the parent phaser
390 >     * @param parties the number of parties required to trip barrier
391       * @throws IllegalArgumentException if parties less than zero
392 <     * or greater than the maximum number of parties supported.
392 >     * or greater than the maximum number of parties supported
393       */
394      public Phaser(Phaser parent, int parties) {
395          if (parties < 0 || parties > ushortMask)
# Line 366 | Line 407 | public class Phaser {
407  
408      /**
409       * Adds a new unarrived party to this phaser.
410 <     * @return the current barrier phase number upon registration
410 >     *
411 >     * @return the arrival phase number to which this registration applied
412       * @throws IllegalStateException if attempting to register more
413 <     * than the maximum supported number of parties.
413 >     * than the maximum supported number of parties
414       */
415      public int register() {
416          return doRegister(1);
# Line 376 | Line 418 | public class Phaser {
418  
419      /**
420       * Adds the given number of new unarrived parties to this phaser.
421 <     * @param parties the number of parties required to trip barrier.
422 <     * @return the current barrier phase number upon registration
421 >     *
422 >     * @param parties the number of parties required to trip barrier
423 >     * @return the arrival phase number to which this registration applied
424       * @throws IllegalStateException if attempting to register more
425 <     * than the maximum supported number of parties.
425 >     * than the maximum supported number of parties
426       */
427      public int bulkRegister(int parties) {
428          if (parties < 0)
# Line 399 | Line 442 | public class Phaser {
442              phase = phaseOf(s);
443              int unarrived = unarrivedOf(s) + registrations;
444              int parties = partiesOf(s) + registrations;
445 <            if (phase < 0)
445 >            if (phase < 0)
446                  break;
447              if (parties > ushortMask || unarrived > ushortMask)
448                  throw new IllegalStateException(badBounds(parties, unarrived));
# Line 412 | Line 455 | public class Phaser {
455  
456      /**
457       * Arrives at the barrier, but does not wait for others.  (You can
458 <     * in turn wait for others via {@link #awaitAdvance}).
458 >     * in turn wait for others via {@link #awaitAdvance}).  It is an
459 >     * unenforced usage error for an unregistered party to invoke this
460 >     * method.
461       *
462 <     * @return the barrier phase number upon entry to this method, or a
418 <     * negative value if terminated;
462 >     * @return the arrival phase number, or a negative value if terminated
463       * @throws IllegalStateException if not terminated and the number
464 <     * of unarrived parties would become negative.
464 >     * of unarrived parties would become negative
465       */
466      public int arrive() {
467          int phase;
# Line 437 | Line 481 | public class Phaser {
481                  if (par == null) {      // directly trip
482                      if (casState
483                          (s,
484 <                         trippedStateFor(onAdvance(phase, parties)? -1 :
484 >                         trippedStateFor(onAdvance(phase, parties) ? -1 :
485                                           ((phase + 1) & phaseMask), parties))) {
486                          releaseWaiters(phase);
487                          break;
# Line 460 | Line 504 | public class Phaser {
504      }
505  
506      /**
507 <     * Arrives at the barrier, and deregisters from it, without
508 <     * waiting for others. Deregistration reduces number of parties
507 >     * Arrives at the barrier and deregisters from it without waiting
508 >     * for others. Deregistration reduces the number of parties
509       * required to trip the barrier in future phases.  If this phaser
510       * has a parent, and deregistration causes this phaser to have
511 <     * zero parties, this phaser is also deregistered from its parent.
511 >     * zero parties, this phaser also arrives at and is deregistered
512 >     * from its parent.  It is an unenforced usage error for an
513 >     * unregistered party to invoke this method.
514       *
515 <     * @return the current barrier phase number upon entry to
470 <     * this method, or a negative value if terminated;
515 >     * @return the arrival phase number, or a negative value if terminated
516       * @throws IllegalStateException if not terminated and the number
517 <     * of registered or unarrived parties would become negative.
517 >     * of registered or unarrived parties would become negative
518       */
519      public int arriveAndDeregister() {
520          // similar code to arrive, but too different to merge
# Line 498 | Line 543 | public class Phaser {
543                  if (unarrived == 0) {
544                      if (casState
545                          (s,
546 <                         trippedStateFor(onAdvance(phase, parties)? -1 :
546 >                         trippedStateFor(onAdvance(phase, parties) ? -1 :
547                                           ((phase + 1) & phaseMask), parties))) {
548                          releaseWaiters(phase);
549                          break;
# Line 517 | Line 562 | public class Phaser {
562  
563      /**
564       * Arrives at the barrier and awaits others. Equivalent in effect
565 <     * to {@code awaitAdvance(arrive())}.  If you instead need to
566 <     * await with interruption of timeout, and/or deregister upon
567 <     * arrival, you can arrange them using analogous constructions.
568 <     * @return the phase on entry to this method
565 >     * to {@code awaitAdvance(arrive())}.  If you need to await with
566 >     * interruption or timeout, you can arrange this with an analogous
567 >     * construction using one of the other forms of the awaitAdvance
568 >     * method.  If instead you need to deregister upon arrival use
569 >     * {@code arriveAndDeregister}. It is an unenforced usage error
570 >     * for an unregistered party to invoke this method.
571 >     *
572 >     * @return the arrival phase number, or a negative number if terminated
573       * @throws IllegalStateException if not terminated and the number
574 <     * of unarrived parties would become negative.
574 >     * of unarrived parties would become negative
575       */
576      public int arriveAndAwaitAdvance() {
577          return awaitAdvance(arrive());
578      }
579  
580      /**
581 <     * Awaits the phase of the barrier to advance from the given
582 <     * value, or returns immediately if argument is negative or this
583 <     * barrier is terminated.
584 <     * @param phase the phase on entry to this method
585 <     * @return the phase on exit from this method
581 >     * Awaits the phase of the barrier to advance from the given phase
582 >     * value, returning immediately if the current phase of the
583 >     * barrier is not equal to the given phase value or this barrier
584 >     * is terminated.  It is an unenforced usage error for an
585 >     * unregistered party to invoke this method.
586 >     *
587 >     * @param phase an arrival phase number, or negative value if
588 >     * terminated; this argument is normally the value returned by a
589 >     * previous call to {@code arrive} or its variants
590 >     * @return the next arrival phase number, or a negative value
591 >     * if terminated or argument is negative
592       */
593      public int awaitAdvance(int phase) {
594          if (phase < 0)
# Line 549 | Line 604 | public class Phaser {
604      }
605  
606      /**
607 <     * Awaits the phase of the barrier to advance from the given
608 <     * value, or returns immediately if argument is negative or this
609 <     * barrier is terminated, or throws InterruptedException if
610 <     * interrupted while waiting.
611 <     * @param phase the phase on entry to this method
612 <     * @return the phase on exit from this method
607 >     * Awaits the phase of the barrier to advance from the given phase
608 >     * value, throwing {@code InterruptedException} if interrupted
609 >     * while waiting, or returning immediately if the current phase of
610 >     * the barrier is not equal to the given phase value or this
611 >     * barrier is terminated. It is an unenforced usage error for an
612 >     * unregistered party to invoke this method.
613 >     *
614 >     * @param phase an arrival phase number, or negative value if
615 >     * terminated; this argument is normally the value returned by a
616 >     * previous call to {@code arrive} or its variants
617 >     * @return the next arrival phase number, or a negative value
618 >     * if terminated or argument is negative
619       * @throws InterruptedException if thread interrupted while waiting
620       */
621 <    public int awaitAdvanceInterruptibly(int phase)
621 >    public int awaitAdvanceInterruptibly(int phase)
622          throws InterruptedException {
623          if (phase < 0)
624              return phase;
# Line 571 | Line 632 | public class Phaser {
632      }
633  
634      /**
635 <     * Awaits the phase of the barrier to advance from the given value
636 <     * or the given timeout elapses, or returns immediately if
637 <     * argument is negative or this barrier is terminated.
638 <     * @param phase the phase on entry to this method
639 <     * @return the phase on exit from this method
635 >     * Awaits the phase of the barrier to advance from the given phase
636 >     * value or the given timeout to elapse, throwing {@code
637 >     * InterruptedException} if interrupted while waiting, or
638 >     * returning immediately if the current phase of the barrier is
639 >     * not equal to the given phase value or this barrier is
640 >     * terminated.  It is an unenforced usage error for an
641 >     * unregistered party to invoke this method.
642 >     *
643 >     * @param phase an arrival phase number, or negative value if
644 >     * terminated; this argument is normally the value returned by a
645 >     * previous call to {@code arrive} or its variants
646 >     * @param timeout how long to wait before giving up, in units of
647 >     *        {@code unit}
648 >     * @param unit a {@code TimeUnit} determining how to interpret the
649 >     *        {@code timeout} parameter
650 >     * @return the next arrival phase number, or a negative value
651 >     * if terminated or argument is negative
652       * @throws InterruptedException if thread interrupted while waiting
653       * @throws TimeoutException if timed out while waiting
654       */
655 <    public int awaitAdvanceInterruptibly(int phase, long timeout, TimeUnit unit)
655 >    public int awaitAdvanceInterruptibly(int phase,
656 >                                         long timeout, TimeUnit unit)
657          throws InterruptedException, TimeoutException {
658          if (phase < 0)
659              return phase;
# Line 620 | Line 694 | public class Phaser {
694       * Returns the current phase number. The maximum phase number is
695       * {@code Integer.MAX_VALUE}, after which it restarts at
696       * zero. Upon termination, the phase number is negative.
697 +     *
698       * @return the phase number, or a negative value if terminated
699       */
700      public final int getPhase() {
# Line 627 | Line 702 | public class Phaser {
702      }
703  
704      /**
630     * Returns {@code true} if the current phase number equals the given phase.
631     * @param phase the phase
632     * @return {@code true} if the current phase number equals the given phase
633     */
634    public final boolean hasPhase(int phase) {
635        return phaseOf(getReconciledState()) == phase;
636    }
637
638    /**
705       * Returns the number of parties registered at this barrier.
706 +     *
707       * @return the number of parties
708       */
709      public int getRegisteredParties() {
# Line 644 | Line 711 | public class Phaser {
711      }
712  
713      /**
714 <     * Returns the number of parties that have arrived at the current
715 <     * phase of this barrier.
714 >     * Returns the number of registered parties that have arrived at
715 >     * the current phase of this barrier.
716 >     *
717       * @return the number of arrived parties
718       */
719      public int getArrivedParties() {
# Line 655 | Line 723 | public class Phaser {
723      /**
724       * Returns the number of registered parties that have not yet
725       * arrived at the current phase of this barrier.
726 +     *
727       * @return the number of unarrived parties
728       */
729      public int getUnarrivedParties() {
# Line 662 | Line 731 | public class Phaser {
731      }
732  
733      /**
734 <     * Returns the parent of this phaser, or null if none.
735 <     * @return the parent of this phaser, or null if none
734 >     * Returns the parent of this phaser, or {@code null} if none.
735 >     *
736 >     * @return the parent of this phaser, or {@code null} if none
737       */
738      public Phaser getParent() {
739          return parent;
# Line 672 | Line 742 | public class Phaser {
742      /**
743       * Returns the root ancestor of this phaser, which is the same as
744       * this phaser if it has no parent.
745 +     *
746       * @return the root ancestor of this phaser
747       */
748      public Phaser getRoot() {
# Line 680 | Line 751 | public class Phaser {
751  
752      /**
753       * Returns {@code true} if this barrier has been terminated.
754 +     *
755       * @return {@code true} if this barrier has been terminated
756       */
757      public boolean isTerminated() {
# Line 687 | Line 759 | public class Phaser {
759      }
760  
761      /**
762 <     * Overridable method to perform an action upon phase advance, and
763 <     * to control termination. This method is invoked whenever the
764 <     * barrier is tripped (and thus all other waiting parties are
765 <     * dormant). If it returns true, then, rather than advance the
766 <     * phase number, this barrier will be set to a final termination
767 <     * state, and subsequent calls to {@code isTerminated} will
768 <     * return true.
762 >     * Overridable method to perform an action upon impending phase
763 >     * advance, and to control termination. This method is invoked
764 >     * upon arrival of the party tripping the barrier (when all other
765 >     * waiting parties are dormant).  If this method returns {@code
766 >     * true}, then, rather than advance the phase number, this barrier
767 >     * will be set to a final termination state, and subsequent calls
768 >     * to {@link #isTerminated} will return true. Any (unchecked)
769 >     * Exception or Error thrown by an invocation of this method is
770 >     * propagated to the party attempting to trip the barrier, in
771 >     * which case no advance occurs.
772 >     *
773 >     * <p>The arguments to this method provide the state of the phaser
774 >     * prevailing for the current transition. (When called from within
775 >     * an implementation of {@code onAdvance} the values returned by
776 >     * methods such as {@code getPhase} may or may not reliably
777 >     * indicate the state to which this transition applies.)
778       *
779 <     * <p> The default version returns true when the number of
779 >     * <p>The default version returns {@code true} when the number of
780       * registered parties is zero. Normally, overrides that arrange
781       * termination for other reasons should also preserve this
782       * property.
783       *
784 <     * <p> You may override this method to perform an action with side
785 <     * effects visible to participating tasks, but it is in general
786 <     * only sensible to do so in designs where all parties register
787 <     * before any arrive, and all {@code awaitAdvance} at each phase.
788 <     * Otherwise, you cannot ensure lack of interference. In
789 <     * particular, this method may be invoked more than once per
790 <     * transition if other parties successfully register while the
710 <     * invocation of this method is in progress, thus postponing the
711 <     * transition until those parties also arrive, re-triggering this
712 <     * method.
784 >     * <p>You may override this method to perform an action with side
785 >     * effects visible to participating tasks, but doing so requires
786 >     * care: Method {@code onAdvance} may be invoked more than once
787 >     * per transition.  Further, unless all parties register before
788 >     * any arrive, and all {@link #awaitAdvance} at each phase, then
789 >     * you cannot ensure lack of interference from other parties
790 >     * during the invocation of this method.
791       *
792       * @param phase the phase number on entering the barrier
793       * @param registeredParties the current number of registered parties
# Line 795 | Line 873 | public class Phaser {
873                  try {
874                      ForkJoinPool.managedBlock(this, false);
875                  } catch (InterruptedException ie) {
876 <                }
876 >                }
877              }
878              return wasInterrupted;
879          }
# Line 803 | Line 881 | public class Phaser {
881      }
882  
883      /**
884 <     * Removes and signals waiting threads from wait queue
884 >     * Removes and signals waiting threads from wait queue.
885       */
886      private void releaseWaiters(int phase) {
887          AtomicReference<QNode> head = queueFor(phase);
# Line 815 | Line 893 | public class Phaser {
893      }
894  
895      /**
896 <     * Tries to enqueue given node in the appropriate wait queue
896 >     * Tries to enqueue given node in the appropriate wait queue.
897 >     *
898       * @return true if successful
899       */
900      private boolean tryEnqueue(QNode node) {
# Line 825 | Line 904 | public class Phaser {
904  
905      /**
906       * Enqueues node and waits unless aborted or signalled.
907 +     *
908       * @return current phase
909       */
910      private int untimedWait(int phase) {
# Line 912 | Line 992 | public class Phaser {
992          return p;
993      }
994  
995 <    // Temporary Unsafe mechanics for preliminary release
916 <    private static Unsafe getUnsafe() throws Throwable {
917 <        try {
918 <            return Unsafe.getUnsafe();
919 <        } catch (SecurityException se) {
920 <            try {
921 <                return java.security.AccessController.doPrivileged
922 <                    (new java.security.PrivilegedExceptionAction<Unsafe>() {
923 <                        public Unsafe run() throws Exception {
924 <                            return getUnsafePrivileged();
925 <                        }});
926 <            } catch (java.security.PrivilegedActionException e) {
927 <                throw e.getCause();
928 <            }
929 <        }
930 <    }
995 >    // Unsafe mechanics
996  
997 <    private static Unsafe getUnsafePrivileged()
998 <            throws NoSuchFieldException, IllegalAccessException {
999 <        Field f = Unsafe.class.getDeclaredField("theUnsafe");
935 <        f.setAccessible(true);
936 <        return (Unsafe)f.get(null);
937 <    }
997 >    private static final sun.misc.Unsafe UNSAFE = getUnsafe();
998 >    private static final long stateOffset =
999 >        objectFieldOffset("state", Phaser.class);
1000  
1001 <    private static long fieldOffset(String fieldName)
1002 <            throws NoSuchFieldException {
941 <        return _unsafe.objectFieldOffset
942 <            (Phaser.class.getDeclaredField(fieldName));
1001 >    private final boolean casState(long cmp, long val) {
1002 >        return UNSAFE.compareAndSwapLong(this, stateOffset, cmp, val);
1003      }
1004  
1005 <    static final Unsafe _unsafe;
946 <    static final long stateOffset;
947 <
948 <    static {
1005 >    private static long objectFieldOffset(String field, Class<?> klazz) {
1006          try {
1007 <            _unsafe = getUnsafe();
1008 <            stateOffset = fieldOffset("state");
1009 <        } catch (Exception e) {
1010 <            throw new RuntimeException("Could not initialize intrinsics", e);
1007 >            return UNSAFE.objectFieldOffset(klazz.getDeclaredField(field));
1008 >        } catch (NoSuchFieldException e) {
1009 >            // Convert Exception to corresponding Error
1010 >            NoSuchFieldError error = new NoSuchFieldError(field);
1011 >            error.initCause(e);
1012 >            throw error;
1013          }
1014      }
1015  
1016 <    final boolean casState(long cmp, long val) {
1017 <        return _unsafe.compareAndSwapLong(this, stateOffset, cmp, val);
1016 >    /**
1017 >     * Returns a sun.misc.Unsafe.  Suitable for use in a 3rd party package.
1018 >     * Replace with a simple call to Unsafe.getUnsafe when integrating
1019 >     * into a jdk.
1020 >     *
1021 >     * @return a sun.misc.Unsafe
1022 >     */
1023 >    private static sun.misc.Unsafe getUnsafe() {
1024 >        try {
1025 >            return sun.misc.Unsafe.getUnsafe();
1026 >        } catch (SecurityException se) {
1027 >            try {
1028 >                return java.security.AccessController.doPrivileged
1029 >                    (new java.security
1030 >                     .PrivilegedExceptionAction<sun.misc.Unsafe>() {
1031 >                        public sun.misc.Unsafe run() throws Exception {
1032 >                            java.lang.reflect.Field f = sun.misc
1033 >                                .Unsafe.class.getDeclaredField("theUnsafe");
1034 >                            f.setAccessible(true);
1035 >                            return (sun.misc.Unsafe) f.get(null);
1036 >                        }});
1037 >            } catch (java.security.PrivilegedActionException e) {
1038 >                throw new RuntimeException("Could not initialize intrinsics",
1039 >                                           e.getCause());
1040 >            }
1041 >        }
1042      }
1043   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines