--- jsr166/src/jsr166y/Phaser.java 2010/11/06 16:12:10 1.50 +++ jsr166/src/jsr166y/Phaser.java 2010/12/01 19:12:53 1.66 @@ -6,7 +6,8 @@ package jsr166y; -import java.util.concurrent.*; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.locks.LockSupport; @@ -33,38 +34,38 @@ import java.util.concurrent.locks.LockSu * Phaser} may be repeatedly awaited. Method {@link * #arriveAndAwaitAdvance} has effect analogous to {@link * java.util.concurrent.CyclicBarrier#await CyclicBarrier.await}. Each - * generation of a {@code Phaser} has an associated phase number. The - * phase number starts at zero, and advances when all parties arrive - * at the barrier, wrapping around to zero after reaching {@code + * generation of a phaser has an associated phase number. The phase + * number starts at zero, and advances when all parties arrive at the + * phaser, wrapping around to zero after reaching {@code * Integer.MAX_VALUE}. The use of phase numbers enables independent - * control of actions upon arrival at a barrier and upon awaiting + * control of actions upon arrival at a phaser and upon awaiting * others, via two kinds of methods that may be invoked by any * registered party: * *
Termination. A {@code Phaser} may enter a - * termination state in which all synchronization methods - * immediately return without updating phaser state or waiting for - * advance, and indicating (via a negative phase value) that execution - * is complete. Termination is triggered when an invocation of {@code - * onAdvance} returns {@code true}. As illustrated below, when - * phasers control actions with a fixed number of iterations, it is - * often convenient to override this method to cause termination when - * the current phase number reaches a threshold. Method {@link - * #forceTermination} is also available to abruptly release waiting - * threads and allow them to terminate. - * - *
Tiering. Phasers may be tiered (i.e., arranged - * in tree structures) to reduce contention. Phasers with large - * numbers of parties that would otherwise experience heavy + *
Termination. A phaser may enter a termination + * state in which all synchronization methods immediately return + * without updating phaser state or waiting for advance, and + * indicating (via a negative phase value) that execution is complete. + * Termination is triggered when an invocation of {@code onAdvance} + * returns {@code true}. The default implementation returns {@code + * true} if a deregistration has caused the number of registered + * parties to become zero. As illustrated below, when phasers control + * actions with a fixed number of iterations, it is often convenient + * to override this method to cause termination when the current phase + * number reaches a threshold. Method {@link #forceTermination} is + * also available to abruptly release waiting threads and allow them + * to terminate. + * + *
Tiering. Phasers may be tiered (i.e., + * constructed in tree structures) to reduce contention. Phasers with + * large numbers of parties that would otherwise experience heavy * synchronization contention costs may instead be set up so that * groups of sub-phasers share a common parent. This may greatly * increase throughput even though it incurs greater per-operation @@ -180,30 +183,30 @@ import java.util.concurrent.locks.LockSu * }} * * - *
To create a set of tasks using a tree of phasers, - * you could use code of the following form, assuming a - * Task class with a constructor accepting a phaser that - * it registers with upon construction: + *
To create a set of {@code n} tasks using a tree of phasers, you + * could use code of the following form, assuming a Task class with a + * constructor accepting a {@code Phaser} that it registers with upon + * construction. After invocation of {@code build(new Task[n], 0, n, + * new Phaser())}, these tasks could then be started, for example by + * submitting to a pool: * *
{@code - * void build(Task[] actions, int lo, int hi, Phaser ph) { + * void build(Task[] tasks, int lo, int hi, Phaser ph) { * if (hi - lo > TASKS_PER_PHASER) { * for (int i = lo; i < hi; i += TASKS_PER_PHASER) { * int j = Math.min(i + TASKS_PER_PHASER, hi); - * build(actions, i, j, new Phaser(ph)); + * build(tasks, i, j, new Phaser(ph)); * } * } else { * for (int i = lo; i < hi; ++i) - * actions[i] = new Task(ph); + * tasks[i] = new Task(ph); * // assumes new Task(ph) performs ph.register() * } - * } - * // .. initially called, for n tasks via - * build(new Task[n], 0, n, new Phaser());}+ * }} * * The best value of {@code TASKS_PER_PHASER} depends mainly on - * expected barrier synchronization rates. A value as low as four may - * be appropriate for extremely small per-barrier task bodies (thus + * expected synchronization rates. A value as low as four may + * be appropriate for extremely small per-phase task bodies (thus * high rates), or up to hundreds for extremely large ones. * *
Implementation notes: This implementation restricts the
@@ -223,60 +226,69 @@ public class Phaser {
*/
/**
- * Barrier state representation. Conceptually, a barrier contains
- * four values:
- *
- * * parties -- the number of parties to wait (16 bits)
- * * unarrived -- the number of parties yet to hit barrier (16 bits)
- * * phase -- the generation of the barrier (31 bits)
- * * terminated -- set if barrier is terminated (1 bit)
- *
- * However, to efficiently maintain atomicity, these values are
- * packed into a single (atomic) long. Termination uses the sign
- * bit of 32 bit representation of phase, so phase is set to -1 on
- * termination. Good performance relies on keeping state decoding
- * and encoding simple, and keeping race windows short.
+ * Primary state representation, holding four fields:
*
- * Note: there are some cheats in arrive() that rely on unarrived
- * count being lowest 16 bits.
+ * * unarrived -- the number of parties yet to hit barrier (bits 0-15)
+ * * parties -- the number of parties to wait (bits 16-31)
+ * * phase -- the generation of the barrier (bits 32-62)
+ * * terminated -- set if barrier is terminated (bit 63 / sign)
+ *
+ * Except that a phaser with no registered parties is
+ * distinguished with the otherwise illegal state of having zero
+ * parties and one unarrived parties (encoded as EMPTY below).
+ *
+ * To efficiently maintain atomicity, these values are packed into
+ * a single (atomic) long. Good performance relies on keeping
+ * state decoding and encoding simple, and keeping race windows
+ * short.
+ *
+ * All state updates are performed via CAS except initial
+ * registration of a sub-phaser (i.e., one with a non-null
+ * parent). In this (relatively rare) case, we use built-in
+ * synchronization to lock while first registering with its
+ * parent.
+ *
+ * The phase of a subphaser is allowed to lag that of its
+ * ancestors until it is actually accessed. Method reconcileState
+ * is usually attempted only only when the number of unarrived
+ * parties appears to be zero, which indicates a potential lag in
+ * updating phase after the root advanced.
*/
private volatile long state;
- private static final int ushortMask = 0xffff;
- private static final int phaseMask = 0x7fffffff;
+ private static final int MAX_PARTIES = 0xffff;
+ private static final int MAX_PHASE = 0x7fffffff;
+ private static final int PARTIES_SHIFT = 16;
+ private static final int PHASE_SHIFT = 32;
+ private static final int UNARRIVED_MASK = 0xffff; // to mask ints
+ private static final long PARTIES_MASK = 0xffff0000L; // to mask longs
+ private static final long TERMINATION_BIT = 1L << 63;
+
+ // some special values
+ private static final int ONE_ARRIVAL = 1;
+ private static final int ONE_PARTY = 1 << PARTIES_SHIFT;
+ private static final int EMPTY = 1;
+
+ // The following unpacking methods are usually manually inlined
private static int unarrivedOf(long s) {
- return (int) (s & ushortMask);
+ int counts = (int)s;
+ return (counts == EMPTY) ? 0 : counts & UNARRIVED_MASK;
}
private static int partiesOf(long s) {
- return ((int) s) >>> 16;
+ int counts = (int)s;
+ return (counts == EMPTY) ? 0 : counts >>> PARTIES_SHIFT;
}
private static int phaseOf(long s) {
- return (int) (s >>> 32);
+ return (int) (s >>> PHASE_SHIFT);
}
private static int arrivedOf(long s) {
- return partiesOf(s) - unarrivedOf(s);
- }
-
- private static long stateFor(int phase, int parties, int unarrived) {
- return ((((long) phase) << 32) | (((long) parties) << 16) |
- (long) unarrived);
- }
-
- private static long trippedStateFor(int phase, int parties) {
- long lp = (long) parties;
- return (((long) phase) << 32) | (lp << 16) | lp;
- }
-
- /**
- * Returns message string for bad bounds exceptions.
- */
- private static String badBounds(int parties, int unarrived) {
- return ("Attempt to set " + unarrived +
- " unarrived of " + parties + " parties");
+ int counts = (int)s;
+ return (counts == EMPTY) ? 0 :
+ (counts >>> PARTIES_SHIFT) - (counts & UNARRIVED_MASK);
}
/**
@@ -285,13 +297,10 @@ public class Phaser {
private final Phaser parent;
/**
- * The root of phaser tree. Equals this if not in a tree. Used to
- * support faster state push-down.
+ * The root of phaser tree. Equals this if not in a tree.
*/
private final Phaser root;
- // Wait queues
-
/**
* Heads of Treiber stacks for waiting threads. To eliminate
* contention when releasing some threads while adding others, we
@@ -306,39 +315,151 @@ public class Phaser {
}
/**
- * Returns current state, first resolving lagged propagation from
- * root if necessary.
+ * Returns message string for bounds exceptions on arrival.
*/
- private long getReconciledState() {
- return (parent == null) ? state : reconcileState();
+ private String badArrive(long s) {
+ return "Attempted arrival of unregistered party for " +
+ stateToString(s);
}
/**
- * Recursively resolves state.
+ * Returns message string for bounds exceptions on registration.
*/
- private long reconcileState() {
+ private String badRegister(long s) {
+ return "Attempt to register more than " +
+ MAX_PARTIES + " parties for " + stateToString(s);
+ }
+
+ /**
+ * Main implementation for methods arrive and arriveAndDeregister.
+ * Manually tuned to speed up and minimize race windows for the
+ * common case of just decrementing unarrived field.
+ *
+ * @param deregister false for arrive, true for arriveAndDeregister
+ */
+ private int doArrive(boolean deregister) {
+ int adj = deregister ? ONE_ARRIVAL|ONE_PARTY : ONE_ARRIVAL;
+ long s;
+ int phase;
+ while ((phase = (int)((s = state) >>> PHASE_SHIFT)) >= 0) {
+ int counts = (int)s;
+ int unarrived = counts & UNARRIVED_MASK;
+ if (counts == EMPTY || unarrived == 0) {
+ if (reconcileState() == s)
+ throw new IllegalStateException(badArrive(s));
+ }
+ else if (UNSAFE.compareAndSwapLong(this, stateOffset, s, s-=adj)) {
+ if (unarrived == 1) {
+ long n = s & PARTIES_MASK; // unshifted parties field
+ int u = ((int)n) >>> PARTIES_SHIFT;
+ Phaser par = parent;
+ if (par != null) {
+ par.doArrive(u == 0);
+ reconcileState();
+ }
+ else {
+ n |= (((long)((phase+1) & MAX_PHASE)) << PHASE_SHIFT);
+ if (onAdvance(phase, u))
+ n |= TERMINATION_BIT;
+ else if (u == 0)
+ n |= EMPTY; // reset to unregistered
+ else
+ n |= (long)u; // reset unarr to parties
+ // assert state == s || isTerminated();
+ UNSAFE.compareAndSwapLong(this, stateOffset, s, n);
+ releaseWaiters(phase);
+ }
+ }
+ break;
+ }
+ }
+ return phase;
+ }
+
+ /**
+ * Implementation of register, bulkRegister
+ *
+ * @param registrations number to add to both parties and
+ * unarrived fields. Must be greater than zero.
+ */
+ private int doRegister(int registrations) {
+ // adjustment to state
+ long adj = ((long)registrations << PARTIES_SHIFT) | registrations;
Phaser par = parent;
+ int phase;
+ for (;;) {
+ long s = state;
+ int counts = (int)s;
+ int parties = counts >>> PARTIES_SHIFT;
+ int unarrived = counts & UNARRIVED_MASK;
+ if (registrations > MAX_PARTIES - parties)
+ throw new IllegalStateException(badRegister(s));
+ else if ((phase = (int)(s >>> PHASE_SHIFT)) < 0)
+ break;
+ else if (counts != EMPTY) { // not 1st registration
+ if (par == null || reconcileState() == s) {
+ if (unarrived == 0) // wait out advance
+ root.internalAwaitAdvance(phase, null);
+ else if (UNSAFE.compareAndSwapLong(this, stateOffset,
+ s, s + adj))
+ break;
+ }
+ }
+ else if (par == null) { // 1st root registration
+ long next = (((long) phase) << PHASE_SHIFT) | adj;
+ if (UNSAFE.compareAndSwapLong(this, stateOffset, s, next))
+ break;
+ }
+ else {
+ synchronized (this) { // 1st sub registration
+ if (state == s) { // recheck under lock
+ par.doRegister(1);
+ do { // force current phase
+ phase = (int)(root.state >>> PHASE_SHIFT);
+ // assert phase < 0 || (int)state == EMPTY;
+ } while (!UNSAFE.compareAndSwapLong
+ (this, stateOffset, state,
+ (((long) phase) << PHASE_SHIFT) | adj));
+ break;
+ }
+ }
+ }
+ }
+ return phase;
+ }
+
+ /**
+ * Resolves lagged phase propagation from root if necessary.
+ */
+ private long reconcileState() {
+ Phaser rt = root;
long s = state;
- if (par != null) {
- int phase, rootPhase;
- while ((phase = phaseOf(s)) >= 0 &&
- (rootPhase = phaseOf(root.state)) != phase &&
- (rootPhase < 0 || unarrivedOf(s) == 0)) {
- int parentPhase = phaseOf(par.getReconciledState());
- if (parentPhase != phase) {
- long next = trippedStateFor(parentPhase, partiesOf(s));
- if (state == s)
- UNSAFE.compareAndSwapLong(this, stateOffset, s, next);
+ if (rt != this) {
+ int phase;
+ while ((phase = (int)(rt.state >>> PHASE_SHIFT)) !=
+ (int)(s >>> PHASE_SHIFT)) {
+ // assert phase < 0 || unarrivedOf(s) == 0
+ long t; // to reread s
+ long p = s & PARTIES_MASK; // unshifted parties field
+ long n = (((long) phase) << PHASE_SHIFT) | p;
+ if (phase >= 0) {
+ if (p == 0L)
+ n |= EMPTY; // reset to empty
+ else
+ n |= p >>> PARTIES_SHIFT; // set unarr to parties
}
- s = state;
+ if ((t = state) == s &&
+ UNSAFE.compareAndSwapLong(this, stateOffset, s, s = n))
+ break;
+ s = t;
}
}
return s;
}
/**
- * Creates a new phaser without any initially registered parties,
- * initial phase number 0, and no parent. Any thread using this
+ * Creates a new phaser with no initially registered parties, no
+ * parent, and initial phase number 0. Any thread using this
* phaser will need to first register for it.
*/
public Phaser() {
@@ -347,9 +468,10 @@ public class Phaser {
/**
* Creates a new phaser with the given number of registered
- * unarrived parties, initial phase number 0, and no parent.
+ * unarrived parties, no parent, and initial phase number 0.
*
- * @param parties the number of parties required to trip barrier
+ * @param parties the number of parties required to advance to the
+ * next phase
* @throws IllegalArgumentException if parties less than zero
* or greater than the maximum number of parties supported
*/
@@ -358,10 +480,7 @@ public class Phaser {
}
/**
- * Creates a new phaser with the given parent, without any
- * initially registered parties. If parent is non-null this phaser
- * is registered with the parent and its initial phase number is
- * the same as that of parent phaser.
+ * Equivalent to {@link #Phaser(Phaser, int) Phaser(parent, 0)}.
*
* @param parent the parent phaser
*/
@@ -371,40 +490,52 @@ public class Phaser {
/**
* Creates a new phaser with the given parent and number of
- * registered unarrived parties. If parent is non-null, this phaser
- * is registered with the parent and its initial phase number is
- * the same as that of parent phaser.
+ * registered unarrived parties. Registration and deregistration
+ * of this child phaser with its parent are managed automatically.
+ * If the given parent is non-null, whenever this child phaser has
+ * any registered parties (as established in this constructor,
+ * {@link #register}, or {@link #bulkRegister}), this child phaser
+ * is registered with its parent. Whenever the number of
+ * registered parties becomes zero as the result of an invocation
+ * of {@link #arriveAndDeregister}, this child phaser is
+ * deregistered from its parent.
*
* @param parent the parent phaser
- * @param parties the number of parties required to trip barrier
+ * @param parties the number of parties required to advance to the
+ * next phase
* @throws IllegalArgumentException if parties less than zero
* or greater than the maximum number of parties supported
*/
public Phaser(Phaser parent, int parties) {
- if (parties < 0 || parties > ushortMask)
+ if (parties >>> PARTIES_SHIFT != 0)
throw new IllegalArgumentException("Illegal number of parties");
- int phase;
+ int phase = 0;
this.parent = parent;
if (parent != null) {
Phaser r = parent.root;
this.root = r;
this.evenQ = r.evenQ;
this.oddQ = r.oddQ;
- phase = parent.register();
+ if (parties != 0)
+ phase = parent.doRegister(1);
}
else {
this.root = this;
this.evenQ = new AtomicReference It is a usage error for an unregistered party to invoke this
+ * method. However, this error may result in an {@code
+ * IllegalStateException} only upon some subsequent operation on
+ * this phaser, if ever.
*
* @return the arrival phase number, or a negative value if terminated
* @throws IllegalStateException if not terminated and the number
* of unarrived parties would become negative
*/
public int arrive() {
- Phaser par = parent;
- long s;
- int phase;
- while ((phase = phaseOf(s = par==null? state:reconcileState())) >= 0) {
- int parties = partiesOf(s);
- int unarrived = unarrivedOf(s) - 1;
- if (unarrived > 0) { // Not the last arrival
- if (UNSAFE.compareAndSwapLong(this, stateOffset, s, s - 1))
- break; // s-1 adds one arrival
- }
- else if (unarrived < 0)
- throw new IllegalStateException(badBounds(parties, unarrived));
- else if (par == null) { // directly trip
- long next = trippedStateFor(onAdvance(phase, parties) ? -1 :
- ((phase + 1) & phaseMask),
- parties);
- if (UNSAFE.compareAndSwapLong(this, stateOffset, s, next)) {
- releaseWaiters(phase);
- break;
- }
- }
- else if (phaseOf(root.state) == phase &&
- UNSAFE.compareAndSwapLong(this, stateOffset, s, s - 1)) {
- par.arrive(); // cascade to parent
- reconcileState();
- break;
- }
- }
- return phase;
+ return doArrive(false);
}
/**
- * Arrives at the barrier and deregisters from it without waiting
- * for others. Deregistration reduces the number of parties
- * required to trip the barrier in future phases. If this phaser
+ * Arrives at this phaser and deregisters from it without waiting
+ * for others to arrive. Deregistration reduces the number of
+ * parties required to advance in future phases. If this phaser
* has a parent, and deregistration causes this phaser to have
- * zero parties, this phaser also arrives at and is deregistered
- * from its parent. It is an unenforced usage error for an
- * unregistered party to invoke this method.
+ * zero parties, this phaser is also deregistered from its parent.
+ *
+ * It is a usage error for an unregistered party to invoke this
+ * method. However, this error may result in an {@code
+ * IllegalStateException} only upon some subsequent operation on
+ * this phaser, if ever.
*
* @return the arrival phase number, or a negative value if terminated
* @throws IllegalStateException if not terminated and the number
* of registered or unarrived parties would become negative
*/
public int arriveAndDeregister() {
- // similar to arrive, but too different to merge
- Phaser par = parent;
- long s;
- int phase;
- while ((phase = phaseOf(s = par==null? state:reconcileState())) >= 0) {
- int parties = partiesOf(s) - 1;
- int unarrived = unarrivedOf(s) - 1;
- if (unarrived > 0) {
- long next = stateFor(phase, parties, unarrived);
- if (UNSAFE.compareAndSwapLong(this, stateOffset, s, next))
- break;
- }
- else if (unarrived < 0)
- throw new IllegalStateException(badBounds(parties, unarrived));
- else if (par == null) {
- long next = trippedStateFor(onAdvance(phase, parties)? -1:
- (phase + 1) & phaseMask,
- parties);
- if (UNSAFE.compareAndSwapLong(this, stateOffset, s, next)) {
- releaseWaiters(phase);
- break;
- }
- }
- else if (phaseOf(root.state) == phase) {
- long next = stateFor(phase, parties, 0);
- if (UNSAFE.compareAndSwapLong(this, stateOffset, s, next)) {
- if (parties == 0)
- par.arriveAndDeregister();
- else
- par.arrive();
- reconcileState();
- break;
- }
- }
- }
- return phase;
+ return doArrive(true);
}
/**
- * Arrives at the barrier and awaits others. Equivalent in effect
+ * Arrives at this phaser and awaits others. Equivalent in effect
* to {@code awaitAdvance(arrive())}. If you need to await with
* interruption or timeout, you can arrange this with an analogous
* construction using one of the other forms of the {@code
* awaitAdvance} method. If instead you need to deregister upon
- * arrival, use {@link #arriveAndDeregister}. It is an unenforced
- * usage error for an unregistered party to invoke this method.
+ * arrival, use {@code awaitAdvance(arriveAndDeregister())}.
+ *
+ * It is a usage error for an unregistered party to invoke this
+ * method. However, this error may result in an {@code
+ * IllegalStateException} only upon some subsequent operation on
+ * this phaser, if ever.
*
* @return the arrival phase number, or a negative number if terminated
* @throws IllegalStateException if not terminated and the number
* of unarrived parties would become negative
*/
public int arriveAndAwaitAdvance() {
- return awaitAdvance(arrive());
+ return awaitAdvance(doArrive(false));
}
/**
- * Awaits the phase of the barrier to advance from the given phase
- * value, returning immediately if the current phase of the
- * barrier is not equal to the given phase value or this barrier
- * is terminated.
+ * Awaits the phase of this phaser to advance from the given phase
+ * value, returning immediately if the current phase is not equal
+ * to the given phase value or this phaser is terminated.
*
* @param phase an arrival phase number, or negative value if
* terminated; this argument is normally the value returned by a
- * previous call to {@code arrive} or its variants
+ * previous call to {@code arrive} or {@code arriveAndDeregister}.
* @return the next arrival phase number, or a negative value
* if terminated or argument is negative
*/
public int awaitAdvance(int phase) {
+ Phaser rt;
+ int p = (int)(state >>> PHASE_SHIFT);
if (phase < 0)
return phase;
- int p = getPhase();
- if (p != phase)
- return p;
- return untimedWait(phase);
+ if (p == phase) {
+ if ((p = (int)((rt = root).state >>> PHASE_SHIFT)) == phase)
+ return rt.internalAwaitAdvance(phase, null);
+ reconcileState();
+ }
+ return p;
}
/**
- * Awaits the phase of the barrier to advance from the given phase
+ * Awaits the phase of this phaser to advance from the given phase
* value, throwing {@code InterruptedException} if interrupted
- * while waiting, or returning immediately if the current phase of
- * the barrier is not equal to the given phase value or this
- * barrier is terminated.
+ * while waiting, or returning immediately if the current phase is
+ * not equal to the given phase value or this phaser is
+ * terminated.
*
* @param phase an arrival phase number, or negative value if
* terminated; this argument is normally the value returned by a
- * previous call to {@code arrive} or its variants
+ * previous call to {@code arrive} or {@code arriveAndDeregister}.
* @return the next arrival phase number, or a negative value
* if terminated or argument is negative
* @throws InterruptedException if thread interrupted while waiting
*/
public int awaitAdvanceInterruptibly(int phase)
throws InterruptedException {
+ Phaser rt;
+ int p = (int)(state >>> PHASE_SHIFT);
if (phase < 0)
return phase;
- int p = getPhase();
- if (p != phase)
- return p;
- return interruptibleWait(phase);
+ if (p == phase) {
+ if ((p = (int)((rt = root).state >>> PHASE_SHIFT)) == phase) {
+ QNode node = new QNode(this, phase, true, false, 0L);
+ p = rt.internalAwaitAdvance(phase, node);
+ if (node.wasInterrupted)
+ throw new InterruptedException();
+ }
+ else
+ reconcileState();
+ }
+ return p;
}
/**
- * Awaits the phase of the barrier to advance from the given phase
+ * Awaits the phase of this phaser to advance from the given phase
* value or the given timeout to elapse, throwing {@code
* InterruptedException} if interrupted while waiting, or
- * returning immediately if the current phase of the barrier is
- * not equal to the given phase value or this barrier is
- * terminated.
+ * returning immediately if the current phase is not equal to the
+ * given phase value or this phaser is terminated.
*
* @param phase an arrival phase number, or negative value if
* terminated; this argument is normally the value returned by a
- * previous call to {@code arrive} or its variants
+ * previous call to {@code arrive} or {@code arriveAndDeregister}.
* @param timeout how long to wait before giving up, in units of
* {@code unit}
* @param unit a {@code TimeUnit} determining how to interpret the
@@ -638,71 +705,88 @@ public class Phaser {
long timeout, TimeUnit unit)
throws InterruptedException, TimeoutException {
long nanos = unit.toNanos(timeout);
+ Phaser rt;
+ int p = (int)(state >>> PHASE_SHIFT);
if (phase < 0)
return phase;
- int p = getPhase();
- if (p != phase)
- return p;
- return timedWait(phase, nanos);
+ if (p == phase) {
+ if ((p = (int)((rt = root).state >>> PHASE_SHIFT)) == phase) {
+ QNode node = new QNode(this, phase, true, true, nanos);
+ p = rt.internalAwaitAdvance(phase, node);
+ if (node.wasInterrupted)
+ throw new InterruptedException();
+ else if (p == phase)
+ throw new TimeoutException();
+ }
+ else
+ reconcileState();
+ }
+ return p;
}
/**
- * Forces this barrier to enter termination state. Counts of
- * arrived and registered parties are unaffected. If this phaser
- * has a parent, it too is terminated. This method may be useful
- * for coordinating recovery after one or more tasks encounter
+ * Forces this phaser to enter termination state. Counts of
+ * registered parties are unaffected. If this phaser is a member
+ * of a tiered set of phasers, then all of the phasers in the set
+ * are terminated. If this phaser is already terminated, this
+ * method has no effect. This method may be useful for
+ * coordinating recovery after one or more tasks encounter
* unexpected exceptions.
*/
public void forceTermination() {
- Phaser r = root; // force at root then reconcile
+ // Only need to change root state
+ final Phaser root = this.root;
long s;
- while (phaseOf(s = r.state) >= 0)
- UNSAFE.compareAndSwapLong(r, stateOffset, s,
- stateFor(-1, partiesOf(s),
- unarrivedOf(s)));
- reconcileState();
- releaseWaiters(0); // ensure wakeups on both queues
- releaseWaiters(1);
+ while ((s = root.state) >= 0) {
+ long next = (s & ~(long)(MAX_PARTIES)) | TERMINATION_BIT;
+ if (UNSAFE.compareAndSwapLong(root, stateOffset, s, next)) {
+ releaseWaiters(0); // signal all threads
+ releaseWaiters(1);
+ return;
+ }
+ }
}
/**
* Returns the current phase number. The maximum phase number is
* {@code Integer.MAX_VALUE}, after which it restarts at
- * zero. Upon termination, the phase number is negative.
+ * zero. Upon termination, the phase number is negative,
+ * in which case the prevailing phase prior to termination
+ * may be obtained via {@code getPhase() + Integer.MIN_VALUE}.
*
* @return the phase number, or a negative value if terminated
*/
public final int getPhase() {
- return phaseOf(getReconciledState());
+ return (int)(root.state >>> PHASE_SHIFT);
}
/**
- * Returns the number of parties registered at this barrier.
+ * Returns the number of parties registered at this phaser.
*
* @return the number of parties
*/
public int getRegisteredParties() {
- return partiesOf(getReconciledState());
+ return partiesOf(state);
}
/**
* Returns the number of registered parties that have arrived at
- * the current phase of this barrier.
+ * the current phase of this phaser.
*
* @return the number of arrived parties
*/
public int getArrivedParties() {
- return arrivedOf(getReconciledState());
+ return arrivedOf(reconcileState());
}
/**
* Returns the number of registered parties that have not yet
- * arrived at the current phase of this barrier.
+ * arrived at the current phase of this phaser.
*
* @return the number of unarrived parties
*/
public int getUnarrivedParties() {
- return unarrivedOf(getReconciledState());
+ return unarrivedOf(reconcileState());
}
/**
@@ -725,48 +809,56 @@ public class Phaser {
}
/**
- * Returns {@code true} if this barrier has been terminated.
+ * Returns {@code true} if this phaser has been terminated.
*
- * @return {@code true} if this barrier has been terminated
+ * @return {@code true} if this phaser has been terminated
*/
public boolean isTerminated() {
- return getPhase() < 0;
+ return root.state < 0L;
}
/**
* Overridable method to perform an action upon impending phase
* advance, and to control termination. This method is invoked
- * upon arrival of the party tripping the barrier (when all other
+ * upon arrival of the party advancing this phaser (when all other
* waiting parties are dormant). If this method returns {@code
- * true}, then, rather than advance the phase number, this barrier
- * will be set to a final termination state, and subsequent calls
- * to {@link #isTerminated} will return true. Any (unchecked)
- * Exception or Error thrown by an invocation of this method is
- * propagated to the party attempting to trip the barrier, in
- * which case no advance occurs.
+ * true}, this phaser will be set to a final termination state
+ * upon advance, and subsequent calls to {@link #isTerminated}
+ * will return true. Any (unchecked) Exception or Error thrown by
+ * an invocation of this method is propagated to the party
+ * attempting to advance this phaser, in which case no advance
+ * occurs.
*
* The arguments to this method provide the state of the phaser
- * prevailing for the current transition. The results and effects
- * of invoking phase-related methods (including {@code getPhase}
- * as well as arrival, registration, and waiting methods) from
+ * prevailing for the current transition. The effects of invoking
+ * arrival, registration, and waiting methods on this phaser from
* within {@code onAdvance} are unspecified and should not be
- * relied on. Similarly, while it is possible to override this
- * method to produce side-effects visible to participating tasks,
- * it is in general safe to do so only in designs in which all
- * parties register before any arrive, and all {@link
- * #awaitAdvance} at each phase.
- *
- * The default version returns {@code true} when the number of
- * registered parties is zero. Normally, overrides that arrange
- * termination for other reasons should also preserve this
- * property.
+ * relied on.
*
- * @param phase the phase number on entering the barrier
+ * If this phaser is a member of a tiered set of phasers, then
+ * {@code onAdvance} is invoked only for its root phaser on each
+ * advance.
+ *
+ * To support the most common use cases, the default
+ * implementation of this method returns {@code true} when the
+ * number of registered parties has become zero as the result of a
+ * party invoking {@code arriveAndDeregister}. You can disable
+ * this behavior, thus enabling continuation upon future
+ * registrations, by overriding this method to always return
+ * {@code false}:
+ *
+ * {@code
+ * Phaser phaser = new Phaser() {
+ * protected boolean onAdvance(int phase, int parties) { return false; }
+ * }}
+ *
+ * @param phase the current phase number on entry to this method,
+ * before this phaser is advanced
* @param registeredParties the current number of registered parties
- * @return {@code true} if this barrier should terminate
+ * @return {@code true} if this phaser should terminate
*/
protected boolean onAdvance(int phase, int registeredParties) {
- return registeredParties <= 0;
+ return registeredParties == 0;
}
/**
@@ -776,17 +868,116 @@ public class Phaser {
* followed by the number of registered parties, and {@code
* "arrived = "} followed by the number of arrived parties.
*
- * @return a string identifying this barrier, as well as its state
+ * @return a string identifying this phaser, as well as its state
*/
public String toString() {
- long s = getReconciledState();
+ return stateToString(reconcileState());
+ }
+
+ /**
+ * Implementation of toString and string-based error messages
+ */
+ private String stateToString(long s) {
return super.toString() +
"[phase = " + phaseOf(s) +
" parties = " + partiesOf(s) +
" arrived = " + arrivedOf(s) + "]";
}
- // methods for waiting
+ // Waiting mechanics
+
+ /**
+ * Removes and signals threads from queue for phase.
+ */
+ private void releaseWaiters(int phase) {
+ QNode q; // first element of queue
+ int p; // its phase
+ Thread t; // its thread
+ // assert phase != phaseOf(root.state);
+ AtomicReference