ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/main/java/util/ArrayDeque.java
(Generate patch)

Comparing jsr166/src/main/java/util/ArrayDeque.java (file contents):
Revision 1.78 by jsr166, Tue Oct 18 17:31:18 2016 UTC vs.
Revision 1.109 by jsr166, Sat Nov 5 16:21:06 2016 UTC

# Line 60 | Line 60 | import java.util.function.UnaryOperator;
60   public class ArrayDeque<E> extends AbstractCollection<E>
61                             implements Deque<E>, Cloneable, Serializable
62   {
63 +    /*
64 +     * VMs excel at optimizing simple array loops where indices are
65 +     * incrementing or decrementing over a valid slice, e.g.
66 +     *
67 +     * for (int i = start; i < end; i++) ... elements[i]
68 +     *
69 +     * Because in a circular array, elements are in general stored in
70 +     * two disjoint such slices, we help the VM by writing unusual
71 +     * nested loops for all traversals over the elements.
72 +     */
73 +
74      /**
75       * The array in which the elements of the deque are stored.
76       * We guarantee that all array cells not holding deque elements
# Line 70 | Line 81 | public class ArrayDeque<E> extends Abstr
81      /**
82       * The index of the element at the head of the deque (which is the
83       * element that would be removed by remove() or pop()); or an
84 <     * arbitrary number 0 <= head < elements.length if the deque is empty.
84 >     * arbitrary number 0 <= head < elements.length equal to tail if
85 >     * the deque is empty.
86       */
87      transient int head;
88  
89 <    /** Number of elements in this collection. */
90 <    transient int size;
89 >    /**
90 >     * The index at which the next element would be added to the tail
91 >     * of the deque (via addLast(E), add(E), or push(E)).
92 >     */
93 >    transient int tail;
94  
95      /**
96       * The maximum size of array to allocate.
# Line 92 | Line 107 | public class ArrayDeque<E> extends Abstr
107       */
108      private void grow(int needed) {
109          // overflow-conscious code
110 <        // checkInvariants();
96 <        int oldCapacity = elements.length;
110 >        final int oldCapacity = elements.length;
111          int newCapacity;
112 <        // Double size if small; else grow by 50%
112 >        // Double capacity if small; else grow by 50%
113          int jump = (oldCapacity < 64) ? (oldCapacity + 2) : (oldCapacity >> 1);
114          if (jump < needed
115              || (newCapacity = (oldCapacity + jump)) - MAX_ARRAY_SIZE > 0)
116              newCapacity = newCapacity(needed, jump);
117          elements = Arrays.copyOf(elements, newCapacity);
118 <        if (oldCapacity - head < size) {
118 >        // Exceptionally, here tail == head needs to be disambiguated
119 >        if (tail < head || (tail == head && elements[head] != null)) {
120              // wrap around; slide first leg forward to end of array
121              int newSpace = newCapacity - oldCapacity;
122              System.arraycopy(elements, head,
# Line 115 | Line 130 | public class ArrayDeque<E> extends Abstr
130  
131      /** Capacity calculation for edge conditions, especially overflow. */
132      private int newCapacity(int needed, int jump) {
133 <        int oldCapacity = elements.length;
119 <        int minCapacity;
133 >        final int oldCapacity = elements.length, minCapacity;
134          if ((minCapacity = oldCapacity + needed) - MAX_ARRAY_SIZE > 0) {
135              if (minCapacity < 0)
136                  throw new IllegalStateException("Sorry, deque too big");
# Line 134 | Line 148 | public class ArrayDeque<E> extends Abstr
148       * to ensure that it can hold at least the given number of elements.
149       *
150       * @param minCapacity the desired minimum capacity
151 <     * @since 9
151 >     * @since TBD
152       */
153 <    public void ensureCapacity(int minCapacity) {
154 <        if (minCapacity > elements.length)
155 <            grow(minCapacity - elements.length);
153 >    /* public */ void ensureCapacity(int minCapacity) {
154 >        int needed;
155 >        if ((needed = (minCapacity + 1 - elements.length)) > 0)
156 >            grow(needed);
157          // checkInvariants();
158      }
159  
160      /**
161       * Minimizes the internal storage of this collection.
162       *
163 <     * @since 9
163 >     * @since TBD
164       */
165 <    public void trimToSize() {
166 <        if (size < elements.length) {
167 <            elements = toArray();
165 >    /* public */ void trimToSize() {
166 >        int size;
167 >        if ((size = size()) + 1 < elements.length) {
168 >            elements = toArray(new Object[size + 1]);
169              head = 0;
170 +            tail = size;
171          }
172          // checkInvariants();
173      }
# Line 170 | Line 187 | public class ArrayDeque<E> extends Abstr
187       * @param numElements lower bound on initial capacity of the deque
188       */
189      public ArrayDeque(int numElements) {
190 <        elements = new Object[numElements];
190 >        elements = new Object[Math.max(1, numElements + 1)];
191      }
192  
193      /**
# Line 184 | Line 201 | public class ArrayDeque<E> extends Abstr
201       * @throws NullPointerException if the specified collection is null
202       */
203      public ArrayDeque(Collection<? extends E> c) {
204 <        Object[] elements = c.toArray();
205 <        // defend against c.toArray (incorrectly) not returning Object[]
189 <        // (see e.g. https://bugs.openjdk.java.net/browse/JDK-6260652)
190 <        if (elements.getClass() != Object[].class)
191 <            elements = Arrays.copyOf(elements, size, Object[].class);
192 <        for (Object obj : elements)
193 <            Objects.requireNonNull(obj);
194 <        size = elements.length;
195 <        this.elements = elements;
204 >        elements = new Object[c.size() + 1];
205 >        addAll(c);
206      }
207  
208      /**
209 <     * Returns the array index of the last element.
210 <     * May return invalid index -1 if there are no elements.
209 >     * Increments i, mod modulus.
210 >     * Precondition and postcondition: 0 <= i < modulus.
211       */
212 <    final int tail() {
213 <        return add(head, size - 1, elements.length);
212 >    static final int inc(int i, int modulus) {
213 >        if (++i >= modulus) i = 0;
214 >        return i;
215      }
216  
217      /**
218 <     * Adds i and j, mod modulus.
219 <     * Precondition and postcondition: 0 <= i < modulus, 0 <= j <= modulus.
218 >     * Decrements i, mod modulus.
219 >     * Precondition and postcondition: 0 <= i < modulus.
220       */
221 <    static final int add(int i, int j, int modulus) {
222 <        if ((i += j) - modulus >= 0) i -= modulus;
221 >    static final int dec(int i, int modulus) {
222 >        if (--i < 0) i = modulus - 1;
223          return i;
224      }
225  
226      /**
227 <     * Increments i, mod modulus.
228 <     * Precondition and postcondition: 0 <= i < modulus.
227 >     * Adds i and j, mod modulus.
228 >     * Precondition and postcondition: 0 <= i < modulus, 0 <= j <= modulus.
229       */
230 <    static final int inc(int i, int modulus) {
231 <        if (++i == modulus) i = 0;
230 >    static final int add(int i, int j, int modulus) {
231 >        if ((i += j) - modulus >= 0) i -= modulus;
232          return i;
233      }
234  
235      /**
236 <     * Decrements i, mod modulus.
237 <     * Precondition and postcondition: 0 <= i < modulus.
236 >     * Subtracts j from i, mod modulus.
237 >     * Index i must be logically ahead of j.
238 >     * Returns the "circular distance" from j to i.
239 >     * Precondition and postcondition: 0 <= i < modulus, 0 <= j < modulus.
240       */
241 <    static final int dec(int i, int modulus) {
242 <        if (--i < 0) i += modulus;
241 >    static final int sub(int i, int j, int modulus) {
242 >        if ((i -= j) < 0) i += modulus;
243          return i;
244      }
245  
246      /**
247       * Returns element at array index i.
248 +     * This is a slight abuse of generics, accepted by javac.
249       */
250      @SuppressWarnings("unchecked")
251 <    final E elementAt(int i) {
252 <        return (E) elements[i];
251 >    static final <E> E elementAt(Object[] es, int i) {
252 >        return (E) es[i];
253      }
254  
255      /**
# Line 243 | Line 257 | public class ArrayDeque<E> extends Abstr
257       * This check doesn't catch all possible comodifications,
258       * but does catch ones that corrupt traversal.
259       */
260 <    E checkedElementAt(Object[] elements, int i) {
261 <        @SuppressWarnings("unchecked") E e = (E) elements[i];
260 >    static final <E> E nonNullElementAt(Object[] es, int i) {
261 >        @SuppressWarnings("unchecked") E e = (E) es[i];
262          if (e == null)
263              throw new ConcurrentModificationException();
264          return e;
# Line 261 | Line 275 | public class ArrayDeque<E> extends Abstr
275       * @throws NullPointerException if the specified element is null
276       */
277      public void addFirst(E e) {
278 <        // checkInvariants();
279 <        Objects.requireNonNull(e);
280 <        Object[] elements;
281 <        int capacity, s = size;
282 <        while (s == (capacity = (elements = this.elements).length))
278 >        if (e == null)
279 >            throw new NullPointerException();
280 >        final Object[] es = elements;
281 >        es[head = dec(head, es.length)] = e;
282 >        if (head == tail)
283              grow(1);
284 <        elements[head = dec(head, capacity)] = e;
271 <        size = s + 1;
284 >        // checkInvariants();
285      }
286  
287      /**
# Line 280 | Line 293 | public class ArrayDeque<E> extends Abstr
293       * @throws NullPointerException if the specified element is null
294       */
295      public void addLast(E e) {
296 <        // checkInvariants();
297 <        Objects.requireNonNull(e);
298 <        Object[] elements;
299 <        int capacity, s = size;
300 <        while (s == (capacity = (elements = this.elements).length))
296 >        if (e == null)
297 >            throw new NullPointerException();
298 >        final Object[] es = elements;
299 >        es[tail] = e;
300 >        if (head == (tail = inc(tail, es.length)))
301              grow(1);
302 <        elements[add(head, s, capacity)] = e;
290 <        size = s + 1;
302 >        // checkInvariants();
303      }
304  
305      /**
# Line 301 | Line 313 | public class ArrayDeque<E> extends Abstr
313       * @throws NullPointerException if the specified collection or any
314       *         of its elements are null
315       */
304    @Override
316      public boolean addAll(Collection<? extends E> c) {
317 +        final int s = size(), needed;
318 +        if ((needed = s + c.size() - elements.length + 1) > 0)
319 +            grow(needed);
320 +        c.forEach((e) -> addLast(e));
321          // checkInvariants();
322 <        Object[] a, elements;
308 <        int len, capacity, s = size;
309 <        if ((len = (a = c.toArray()).length) == 0)
310 <            return false;
311 <        while ((capacity = (elements = this.elements).length) - s < len)
312 <            grow(len - (capacity - s));
313 <        int i = add(head, s, capacity);
314 <        for (Object x : a) {
315 <            Objects.requireNonNull(x);
316 <            elements[i] = x;
317 <            i = inc(i, capacity);
318 <            size++;
319 <        }
320 <        return true;
322 >        return size() > s;
323      }
324  
325      /**
# Line 348 | Line 350 | public class ArrayDeque<E> extends Abstr
350       * @throws NoSuchElementException {@inheritDoc}
351       */
352      public E removeFirst() {
353 <        // checkInvariants();
354 <        E x = pollFirst();
353 <        if (x == null)
353 >        E e = pollFirst();
354 >        if (e == null)
355              throw new NoSuchElementException();
356 <        return x;
356 >        // checkInvariants();
357 >        return e;
358      }
359  
360      /**
361       * @throws NoSuchElementException {@inheritDoc}
362       */
363      public E removeLast() {
364 <        // checkInvariants();
365 <        E x = pollLast();
364 <        if (x == null)
364 >        E e = pollLast();
365 >        if (e == null)
366              throw new NoSuchElementException();
367 <        return x;
367 >        // checkInvariants();
368 >        return e;
369      }
370  
371      public E pollFirst() {
372 +        final Object[] es;
373 +        final int h;
374 +        E e = elementAt(es = elements, h = head);
375 +        if (e != null) {
376 +            es[h] = null;
377 +            head = inc(h, es.length);
378 +        }
379          // checkInvariants();
371        final int s, h;
372        if ((s = size) == 0)
373            return null;
374        final Object[] elements = this.elements;
375        @SuppressWarnings("unchecked") E e = (E) elements[h = head];
376        elements[h] = null;
377        head = inc(h, elements.length);
378        size = s - 1;
380          return e;
381      }
382  
383      public E pollLast() {
384 +        final Object[] es;
385 +        final int t;
386 +        E e = elementAt(es = elements, t = dec(tail, es.length));
387 +        if (e != null)
388 +            es[tail = t] = null;
389          // checkInvariants();
384        final int s, tail;
385        if ((s = size) == 0)
386            return null;
387        final Object[] elements = this.elements;
388        @SuppressWarnings("unchecked")
389        E e = (E) elements[tail = add(head, s - 1, elements.length)];
390        elements[tail] = null;
391        size = s - 1;
390          return e;
391      }
392  
# Line 396 | Line 394 | public class ArrayDeque<E> extends Abstr
394       * @throws NoSuchElementException {@inheritDoc}
395       */
396      public E getFirst() {
397 +        E e = elementAt(elements, head);
398 +        if (e == null)
399 +            throw new NoSuchElementException();
400          // checkInvariants();
401 <        if (size == 0) throw new NoSuchElementException();
401 <        return elementAt(head);
401 >        return e;
402      }
403  
404      /**
405       * @throws NoSuchElementException {@inheritDoc}
406       */
407      public E getLast() {
408 +        final Object[] es = elements;
409 +        E e = elementAt(es, dec(tail, es.length));
410 +        if (e == null)
411 +            throw new NoSuchElementException();
412          // checkInvariants();
413 <        if (size == 0) throw new NoSuchElementException();
410 <        return elementAt(tail());
413 >        return e;
414      }
415  
416      public E peekFirst() {
417          // checkInvariants();
418 <        return (size == 0) ? null : elementAt(head);
418 >        return elementAt(elements, head);
419      }
420  
421      public E peekLast() {
422          // checkInvariants();
423 <        return (size == 0) ? null : elementAt(tail());
423 >        final Object[] es;
424 >        return elementAt(es = elements, dec(tail, es.length));
425      }
426  
427      /**
# Line 433 | Line 437 | public class ArrayDeque<E> extends Abstr
437       * @return {@code true} if the deque contained the specified element
438       */
439      public boolean removeFirstOccurrence(Object o) {
436        // checkInvariants();
440          if (o != null) {
441 <            final Object[] elements = this.elements;
442 <            final int capacity = elements.length;
443 <            for (int k = size, i = head; --k >= 0; i = inc(i, capacity)) {
444 <                if (o.equals(elements[i])) {
445 <                    delete(i);
446 <                    return true;
447 <                }
441 >            final Object[] es = elements;
442 >            for (int i = head, end = tail, to = (i <= end) ? end : es.length;
443 >                 ; i = 0, to = end) {
444 >                for (; i < to; i++)
445 >                    if (o.equals(es[i])) {
446 >                        delete(i);
447 >                        return true;
448 >                    }
449 >                if (to == end) break;
450              }
451          }
452          return false;
# Line 461 | Line 466 | public class ArrayDeque<E> extends Abstr
466       */
467      public boolean removeLastOccurrence(Object o) {
468          if (o != null) {
469 <            final Object[] elements = this.elements;
470 <            final int capacity = elements.length;
471 <            for (int k = size, i = add(head, k - 1, capacity);
472 <                 --k >= 0; i = dec(i, capacity)) {
473 <                if (o.equals(elements[i])) {
474 <                    delete(i);
475 <                    return true;
476 <                }
469 >            final Object[] es = elements;
470 >            for (int i = tail, end = head, to = (i >= end) ? end : 0;
471 >                 ; i = es.length, to = end) {
472 >                while (--i >= to)
473 >                    if (o.equals(es[i])) {
474 >                        delete(i);
475 >                        return true;
476 >                    }
477 >                if (to == end) break;
478              }
479          }
480          return false;
# Line 596 | Line 602 | public class ArrayDeque<E> extends Abstr
602       * <p>This method is called delete rather than remove to emphasize
603       * that its semantics differ from those of {@link List#remove(int)}.
604       *
605 <     * @return true if elements moved backwards
605 >     * @return true if elements near tail moved backwards
606       */
607      boolean delete(int i) {
608          // checkInvariants();
609 <        final Object[] elements = this.elements;
610 <        final int capacity = elements.length;
609 >        final Object[] es = elements;
610 >        final int capacity = es.length;
611          final int h = head;
612 <        int front;              // number of elements before to-be-deleted elt
613 <        if ((front = i - h) < 0) front += capacity;
614 <        final int back = size - front - 1; // number of elements after
612 >        // number of elements before to-be-deleted elt
613 >        final int front = sub(i, h, capacity);
614 >        final int back = size() - front - 1; // number of elements after
615          if (front < back) {
616              // move front elements forwards
617              if (h <= i) {
618 <                System.arraycopy(elements, h, elements, h + 1, front);
618 >                System.arraycopy(es, h, es, h + 1, front);
619              } else { // Wrap around
620 <                System.arraycopy(elements, 0, elements, 1, i);
621 <                elements[0] = elements[capacity - 1];
622 <                System.arraycopy(elements, h, elements, h + 1, front - (i + 1));
620 >                System.arraycopy(es, 0, es, 1, i);
621 >                es[0] = es[capacity - 1];
622 >                System.arraycopy(es, h, es, h + 1, front - (i + 1));
623              }
624 <            elements[h] = null;
624 >            es[h] = null;
625              head = inc(h, capacity);
620            size--;
626              // checkInvariants();
627              return false;
628          } else {
629              // move back elements backwards
630 <            int tail = tail();
630 >            tail = dec(tail, capacity);
631              if (i <= tail) {
632 <                System.arraycopy(elements, i + 1, elements, i, back);
632 >                System.arraycopy(es, i + 1, es, i, back);
633              } else { // Wrap around
634                  int firstLeg = capacity - (i + 1);
635 <                System.arraycopy(elements, i + 1, elements, i, firstLeg);
636 <                elements[capacity - 1] = elements[0];
637 <                System.arraycopy(elements, 1, elements, 0, back - firstLeg - 1);
635 >                System.arraycopy(es, i + 1, es, i, firstLeg);
636 >                es[capacity - 1] = es[0];
637 >                System.arraycopy(es, 1, es, 0, back - firstLeg - 1);
638              }
639 <            elements[tail] = null;
635 <            size--;
639 >            es[tail] = null;
640              // checkInvariants();
641              return true;
642          }
# Line 646 | Line 650 | public class ArrayDeque<E> extends Abstr
650       * @return the number of elements in this deque
651       */
652      public int size() {
653 <        return size;
653 >        return sub(tail, head, elements.length);
654      }
655  
656      /**
# Line 655 | Line 659 | public class ArrayDeque<E> extends Abstr
659       * @return {@code true} if this deque contains no elements
660       */
661      public boolean isEmpty() {
662 <        return size == 0;
662 >        return head == tail;
663      }
664  
665      /**
# Line 679 | Line 683 | public class ArrayDeque<E> extends Abstr
683          int cursor;
684  
685          /** Number of elements yet to be returned. */
686 <        int remaining = size;
686 >        int remaining = size();
687  
688          /**
689           * Index of element returned by most recent call to next.
# Line 689 | Line 693 | public class ArrayDeque<E> extends Abstr
693  
694          DeqIterator() { cursor = head; }
695  
692        int advance(int i, int modulus) {
693            return inc(i, modulus);
694        }
695
696        void doRemove() {
697            if (delete(lastRet))
698                // if left-shifted, undo advance in next()
699                cursor = dec(cursor, elements.length);
700        }
701
696          public final boolean hasNext() {
697              return remaining > 0;
698          }
699  
700 <        public final E next() {
701 <            if (remaining == 0)
700 >        public E next() {
701 >            if (remaining <= 0)
702                  throw new NoSuchElementException();
703 <            E e = checkedElementAt(elements, cursor);
703 >            final Object[] es = elements;
704 >            E e = nonNullElementAt(es, cursor);
705              lastRet = cursor;
706 <            cursor = advance(cursor, elements.length);
706 >            cursor = inc(cursor, es.length);
707              remaining--;
708              return e;
709          }
710  
711 +        void postDelete(boolean leftShifted) {
712 +            if (leftShifted)
713 +                cursor = dec(cursor, elements.length);
714 +        }
715 +
716          public final void remove() {
717              if (lastRet < 0)
718                  throw new IllegalStateException();
719 <            doRemove();
719 >            postDelete(delete(lastRet));
720              lastRet = -1;
721          }
722  
723 <        public final void forEachRemaining(Consumer<? super E> action) {
723 >        public void forEachRemaining(Consumer<? super E> action) {
724              Objects.requireNonNull(action);
725 <            final Object[] elements = ArrayDeque.this.elements;
726 <            final int capacity = elements.length;
727 <            int k = remaining;
725 >            int r;
726 >            if ((r = remaining) <= 0)
727 >                return;
728              remaining = 0;
729 <            for (int i = cursor; --k >= 0; i = advance(i, capacity))
730 <                action.accept(checkedElementAt(elements, i));
729 >            final Object[] es = elements;
730 >            if (es[cursor] == null || sub(tail, cursor, es.length) != r)
731 >                throw new ConcurrentModificationException();
732 >            for (int i = cursor, end = tail, to = (i <= end) ? end : es.length;
733 >                 ; i = 0, to = end) {
734 >                for (; i < to; i++)
735 >                    action.accept(elementAt(es, i));
736 >                if (to == end) {
737 >                    if (end != tail)
738 >                        throw new ConcurrentModificationException();
739 >                    lastRet = dec(end, es.length);
740 >                    break;
741 >                }
742 >            }
743          }
744      }
745  
746      private class DescendingIterator extends DeqIterator {
747 <        DescendingIterator() { cursor = tail(); }
747 >        DescendingIterator() { cursor = dec(tail, elements.length); }
748  
749 <        @Override int advance(int i, int modulus) {
750 <            return dec(i, modulus);
749 >        public final E next() {
750 >            if (remaining <= 0)
751 >                throw new NoSuchElementException();
752 >            final Object[] es = elements;
753 >            E e = nonNullElementAt(es, cursor);
754 >            lastRet = cursor;
755 >            cursor = dec(cursor, es.length);
756 >            remaining--;
757 >            return e;
758          }
759  
760 <        @Override void doRemove() {
761 <            if (!delete(lastRet))
743 <                // if right-shifted, undo advance in next
760 >        void postDelete(boolean leftShifted) {
761 >            if (!leftShifted)
762                  cursor = inc(cursor, elements.length);
763          }
764 +
765 +        public final void forEachRemaining(Consumer<? super E> action) {
766 +            Objects.requireNonNull(action);
767 +            int r;
768 +            if ((r = remaining) <= 0)
769 +                return;
770 +            remaining = 0;
771 +            final Object[] es = elements;
772 +            if (es[cursor] == null || sub(cursor, head, es.length) + 1 != r)
773 +                throw new ConcurrentModificationException();
774 +            for (int i = cursor, end = head, to = (i >= end) ? end : 0;
775 +                 ; i = es.length - 1, to = end) {
776 +                for (; i >= to; i--)
777 +                    action.accept(elementAt(es, i));
778 +                if (to == end) {
779 +                    if (end != head)
780 +                        throw new ConcurrentModificationException();
781 +                    lastRet = head;
782 +                    break;
783 +                }
784 +            }
785 +        }
786      }
787  
788      /**
# Line 759 | Line 799 | public class ArrayDeque<E> extends Abstr
799       * @since 1.8
800       */
801      public Spliterator<E> spliterator() {
802 <        return new ArrayDequeSpliterator();
802 >        return new DeqSpliterator();
803      }
804  
805 <    final class ArrayDequeSpliterator implements Spliterator<E> {
806 <        private int cursor;
807 <        private int remaining; // -1 until late-binding first use
805 >    final class DeqSpliterator implements Spliterator<E> {
806 >        private int fence;      // -1 until first use
807 >        private int cursor;     // current index, modified on traverse/split
808  
809          /** Constructs late-binding spliterator over all elements. */
810 <        ArrayDequeSpliterator() {
811 <            this.remaining = -1;
810 >        DeqSpliterator() {
811 >            this.fence = -1;
812          }
813  
814 <        /** Constructs spliterator over the given slice. */
815 <        ArrayDequeSpliterator(int cursor, int count) {
816 <            this.cursor = cursor;
817 <            this.remaining = count;
814 >        /** Constructs spliterator over the given range. */
815 >        DeqSpliterator(int origin, int fence) {
816 >            this.cursor = origin;
817 >            this.fence = fence;
818          }
819  
820 <        /** Ensures late-binding initialization; then returns remaining. */
821 <        private int remaining() {
822 <            if (remaining < 0) {
820 >        /** Ensures late-binding initialization; then returns fence. */
821 >        private int getFence() { // force initialization
822 >            int t;
823 >            if ((t = fence) < 0) {
824 >                t = fence = tail;
825                  cursor = head;
784                remaining = size;
826              }
827 <            return remaining;
827 >            return t;
828          }
829  
830 <        public ArrayDequeSpliterator trySplit() {
831 <            final int mid;
832 <            if ((mid = remaining() >> 1) > 0) {
833 <                int oldCursor = cursor;
834 <                cursor = add(cursor, mid, elements.length);
835 <                remaining -= mid;
795 <                return new ArrayDequeSpliterator(oldCursor, mid);
796 <            }
797 <            return null;
830 >        public DeqSpliterator trySplit() {
831 >            final Object[] es = elements;
832 >            final int i, n;
833 >            return ((n = sub(getFence(), i = cursor, es.length) >> 1) <= 0)
834 >                ? null
835 >                : new DeqSpliterator(i, cursor = add(i, n, es.length));
836          }
837  
838          public void forEachRemaining(Consumer<? super E> action) {
839 <            Objects.requireNonNull(action);
840 <            final Object[] elements = ArrayDeque.this.elements;
841 <            final int capacity = elements.length;
842 <            int k = remaining();
843 <            remaining = 0;
844 <            for (int i = cursor; --k >= 0; i = inc(i, capacity))
845 <                action.accept(checkedElementAt(elements, i));
839 >            if (action == null)
840 >                throw new NullPointerException();
841 >            final int end = getFence(), cursor = this.cursor;
842 >            final Object[] es = elements;
843 >            if (cursor != end) {
844 >                this.cursor = end;
845 >                // null check at both ends of range is sufficient
846 >                if (es[cursor] == null || es[dec(end, es.length)] == null)
847 >                    throw new ConcurrentModificationException();
848 >                for (int i = cursor, to = (i <= end) ? end : es.length;
849 >                     ; i = 0, to = end) {
850 >                    for (; i < to; i++)
851 >                        action.accept(elementAt(es, i));
852 >                    if (to == end) break;
853 >                }
854 >            }
855          }
856  
857          public boolean tryAdvance(Consumer<? super E> action) {
858 <            Objects.requireNonNull(action);
859 <            if (remaining() == 0)
858 >            if (action == null)
859 >                throw new NullPointerException();
860 >            int t, i;
861 >            if ((t = fence) < 0) t = getFence();
862 >            if (t == (i = cursor))
863                  return false;
864 <            action.accept(checkedElementAt(elements, cursor));
865 <            cursor = inc(cursor, elements.length);
866 <            remaining--;
864 >            final Object[] es;
865 >            action.accept(nonNullElementAt(es = elements, i));
866 >            cursor = inc(i, es.length);
867              return true;
868          }
869  
870          public long estimateSize() {
871 <            return remaining();
871 >            return sub(getFence(), cursor, elements.length);
872          }
873  
874          public int characteristics() {
# Line 829 | Line 879 | public class ArrayDeque<E> extends Abstr
879          }
880      }
881  
832    @Override
882      public void forEach(Consumer<? super E> action) {
834        // checkInvariants();
883          Objects.requireNonNull(action);
884 <        final Object[] elements = this.elements;
885 <        final int capacity = elements.length;
886 <        for (int k = size, i = head; --k >= 0; i = inc(i, capacity))
887 <            action.accept(elementAt(i));
884 >        final Object[] es = elements;
885 >        for (int i = head, end = tail, to = (i <= end) ? end : es.length;
886 >             ; i = 0, to = end) {
887 >            for (; i < to; i++)
888 >                action.accept(elementAt(es, i));
889 >            if (to == end) {
890 >                if (end != tail) throw new ConcurrentModificationException();
891 >                break;
892 >            }
893 >        }
894          // checkInvariants();
895      }
896  
# Line 845 | Line 899 | public class ArrayDeque<E> extends Abstr
899       * operator to that element, as specified by {@link List#replaceAll}.
900       *
901       * @param operator the operator to apply to each element
902 <     * @since 9
902 >     * @since TBD
903       */
904 <    public void replaceAll(UnaryOperator<E> operator) {
904 >    /* public */ void replaceAll(UnaryOperator<E> operator) {
905          Objects.requireNonNull(operator);
906 <        final Object[] elements = this.elements;
907 <        final int capacity = elements.length;
908 <        for (int k = size, i = head; --k >= 0; i = inc(i, capacity))
909 <            elements[i] = operator.apply(elementAt(i));
906 >        final Object[] es = elements;
907 >        for (int i = head, end = tail, to = (i <= end) ? end : es.length;
908 >             ; i = 0, to = end) {
909 >            for (; i < to; i++)
910 >                es[i] = operator.apply(elementAt(es, i));
911 >            if (to == end) {
912 >                if (end != tail) throw new ConcurrentModificationException();
913 >                break;
914 >            }
915 >        }
916          // checkInvariants();
917      }
918  
919      /**
920       * @throws NullPointerException {@inheritDoc}
921       */
862    @Override
922      public boolean removeIf(Predicate<? super E> filter) {
923          Objects.requireNonNull(filter);
924          return bulkRemove(filter);
# Line 868 | Line 927 | public class ArrayDeque<E> extends Abstr
927      /**
928       * @throws NullPointerException {@inheritDoc}
929       */
871    @Override
930      public boolean removeAll(Collection<?> c) {
931          Objects.requireNonNull(c);
932          return bulkRemove(e -> c.contains(e));
# Line 877 | Line 935 | public class ArrayDeque<E> extends Abstr
935      /**
936       * @throws NullPointerException {@inheritDoc}
937       */
880    @Override
938      public boolean retainAll(Collection<?> c) {
939          Objects.requireNonNull(c);
940          return bulkRemove(e -> !c.contains(e));
# Line 886 | Line 943 | public class ArrayDeque<E> extends Abstr
943      /** Implementation of bulk remove methods. */
944      private boolean bulkRemove(Predicate<? super E> filter) {
945          // checkInvariants();
946 <        final Object[] elements = this.elements;
947 <        final int capacity = elements.length;
948 <        int i = head, j = i, remaining = size, deleted = 0;
946 >        final Object[] es = elements;
947 >        // Optimize for initial run of survivors
948 >        for (int i = head, end = tail, to = (i <= end) ? end : es.length;
949 >             ; i = 0, to = end) {
950 >            for (; i < to; i++)
951 >                if (filter.test(elementAt(es, i)))
952 >                    return bulkRemoveModified(filter, i, to);
953 >            if (to == end) {
954 >                if (end != tail) throw new ConcurrentModificationException();
955 >                break;
956 >            }
957 >        }
958 >        return false;
959 >    }
960 >
961 >    /**
962 >     * Helper for bulkRemove, in case of at least one deletion.
963 >     * @param i valid index of first element to be deleted
964 >     */
965 >    private boolean bulkRemoveModified(
966 >        Predicate<? super E> filter, int i, int to) {
967 >        final Object[] es = elements;
968 >        final int capacity = es.length;
969 >        // a two-finger algorithm, with hare i reading, tortoise j writing
970 >        int j = i++;
971 >        final int end = tail;
972          try {
973 <            for (; remaining > 0; remaining--, i = inc(i, capacity)) {
974 <                @SuppressWarnings("unchecked") E e = (E) elements[i];
975 <                if (filter.test(e))
976 <                    deleted++;
977 <                else {
978 <                    if (j != i)
979 <                        elements[j] = e;
980 <                    j = inc(j, capacity);
973 >            for (;; j = 0) {    // j rejoins i on second leg
974 >                E e;
975 >                // In this loop, i and j are on the same leg, with i > j
976 >                for (; i < to; i++)
977 >                    if (!filter.test(e = elementAt(es, i)))
978 >                        es[j++] = e;
979 >                if (to == end) break;
980 >                // In this loop, j is on the first leg, i on the second
981 >                for (i = 0, to = end; i < to && j < capacity; i++)
982 >                    if (!filter.test(e = elementAt(es, i)))
983 >                        es[j++] = e;
984 >                if (i >= to) {
985 >                    if (j == capacity) j = 0; // "corner" case
986 >                    break;
987                  }
988              }
989 <            return deleted > 0;
989 >            return true;
990          } catch (Throwable ex) {
991 <            if (deleted > 0)
992 <                for (; remaining > 0;
993 <                     remaining--, i = inc(i, capacity), j = inc(j, capacity))
908 <                    elements[j] = elements[i];
991 >            // copy remaining elements
992 >            for (; i != end; i = inc(i, capacity), j = inc(j, capacity))
993 >                es[j] = es[i];
994              throw ex;
995          } finally {
996 <            size -= deleted;
997 <            for (; --deleted >= 0; j = inc(j, capacity))
913 <                elements[j] = null;
996 >            if (end != tail) throw new ConcurrentModificationException();
997 >            circularClear(es, tail = j, end);
998              // checkInvariants();
999          }
1000      }
# Line 925 | Line 1009 | public class ArrayDeque<E> extends Abstr
1009       */
1010      public boolean contains(Object o) {
1011          if (o != null) {
1012 <            final Object[] elements = this.elements;
1013 <            final int capacity = elements.length;
1014 <            for (int k = size, i = head; --k >= 0; i = inc(i, capacity))
1015 <                if (o.equals(elements[i]))
1016 <                    return true;
1012 >            final Object[] es = elements;
1013 >            for (int i = head, end = tail, to = (i <= end) ? end : es.length;
1014 >                 ; i = 0, to = end) {
1015 >                for (; i < to; i++)
1016 >                    if (o.equals(es[i]))
1017 >                        return true;
1018 >                if (to == end) break;
1019 >            }
1020          }
1021          return false;
1022      }
# Line 956 | Line 1043 | public class ArrayDeque<E> extends Abstr
1043       * The deque will be empty after this call returns.
1044       */
1045      public void clear() {
1046 <        final Object[] elements = this.elements;
1047 <        final int capacity = elements.length;
961 <        final int h = this.head;
962 <        final int s = size;
963 <        if (capacity - h >= s)
964 <            Arrays.fill(elements, h, h + s, null);
965 <        else {
966 <            Arrays.fill(elements, h, capacity, null);
967 <            Arrays.fill(elements, 0, s - capacity + h, null);
968 <        }
969 <        size = head = 0;
1046 >        circularClear(elements, head, tail);
1047 >        head = tail = 0;
1048          // checkInvariants();
1049      }
1050  
1051      /**
1052 +     * Nulls out slots starting at array index i, upto index end.
1053 +     */
1054 +    private static void circularClear(Object[] es, int i, int end) {
1055 +        for (int to = (i <= end) ? end : es.length;
1056 +             ; i = 0, to = end) {
1057 +            Arrays.fill(es, i, to, null);
1058 +            if (to == end) break;
1059 +        }
1060 +    }
1061 +
1062 +    /**
1063       * Returns an array containing all of the elements in this deque
1064       * in proper sequence (from first to last element).
1065       *
# Line 984 | Line 1073 | public class ArrayDeque<E> extends Abstr
1073       * @return an array containing all of the elements in this deque
1074       */
1075      public Object[] toArray() {
1076 <        final int head = this.head;
1077 <        final int firstLeg;
1078 <        Object[] a = Arrays.copyOfRange(elements, head, head + size);
1079 <        if ((firstLeg = elements.length - head) < size)
1080 <            System.arraycopy(elements, 0, a, firstLeg, size - firstLeg);
1076 >        return toArray(Object[].class);
1077 >    }
1078 >
1079 >    private <T> T[] toArray(Class<T[]> klazz) {
1080 >        final Object[] es = elements;
1081 >        final T[] a;
1082 >        final int size = size(), head = this.head, end;
1083 >        final int len = Math.min(size, es.length - head);
1084 >        if ((end = head + size) >= 0) {
1085 >            a = Arrays.copyOfRange(es, head, end, klazz);
1086 >        } else {
1087 >            // integer overflow!
1088 >            a = Arrays.copyOfRange(es, 0, size, klazz);
1089 >            System.arraycopy(es, head, a, 0, len);
1090 >        }
1091 >        if (tail < head)
1092 >            System.arraycopy(es, 0, a, len, tail);
1093          return a;
1094      }
1095  
# Line 1030 | Line 1131 | public class ArrayDeque<E> extends Abstr
1131       */
1132      @SuppressWarnings("unchecked")
1133      public <T> T[] toArray(T[] a) {
1134 <        final Object[] elements = this.elements;
1135 <        final int head = this.head;
1136 <        final int firstLeg;
1137 <        boolean wrap = (firstLeg = elements.length - head) < size;
1138 <        if (size > a.length) {
1139 <            a = (T[]) Arrays.copyOfRange(elements, head, head + size,
1140 <                                         a.getClass());
1141 <        } else {
1041 <            System.arraycopy(elements, head, a, 0, wrap ? firstLeg : size);
1042 <            if (size < a.length)
1043 <                a[size] = null;
1134 >        final int size;
1135 >        if ((size = size()) > a.length)
1136 >            return toArray((Class<T[]>) a.getClass());
1137 >        final Object[] es = elements;
1138 >        for (int i = head, j = 0, len = Math.min(size, es.length - i);
1139 >             ; i = 0, len = tail) {
1140 >            System.arraycopy(es, i, a, j, len);
1141 >            if ((j += len) == size) break;
1142          }
1143 <        if (wrap)
1144 <            System.arraycopy(elements, 0, a, firstLeg, size - firstLeg);
1143 >        if (size < a.length)
1144 >            a[size] = null;
1145          return a;
1146      }
1147  
# Line 1081 | Line 1179 | public class ArrayDeque<E> extends Abstr
1179          s.defaultWriteObject();
1180  
1181          // Write out size
1182 <        s.writeInt(size);
1182 >        s.writeInt(size());
1183  
1184          // Write out elements in order.
1185 <        final Object[] elements = this.elements;
1186 <        final int capacity = elements.length;
1187 <        for (int k = size, i = head; --k >= 0; i = inc(i, capacity))
1188 <            s.writeObject(elements[i]);
1185 >        final Object[] es = elements;
1186 >        for (int i = head, end = tail, to = (i <= end) ? end : es.length;
1187 >             ; i = 0, to = end) {
1188 >            for (; i < to; i++)
1189 >                s.writeObject(es[i]);
1190 >            if (to == end) break;
1191 >        }
1192      }
1193  
1194      /**
# Line 1102 | Line 1203 | public class ArrayDeque<E> extends Abstr
1203          s.defaultReadObject();
1204  
1205          // Read in size and allocate array
1206 <        elements = new Object[size = s.readInt()];
1206 >        int size = s.readInt();
1207 >        elements = new Object[size + 1];
1208 >        this.tail = size;
1209  
1210          // Read in all elements in the proper order.
1211          for (int i = 0; i < size; i++)
# Line 1110 | Line 1213 | public class ArrayDeque<E> extends Abstr
1213      }
1214  
1215      /** debugging */
1216 <    private void checkInvariants() {
1216 >    void checkInvariants() {
1217          try {
1218              int capacity = elements.length;
1219 <            assert size >= 0 && size <= capacity;
1220 <            assert head >= 0 && ((capacity == 0 && head == 0 && size == 0)
1221 <                                 || head < capacity);
1222 <            assert size == 0
1223 <                || (elements[head] != null && elements[tail()] != null);
1224 <            assert size == capacity
1225 <                || (elements[dec(head, capacity)] == null
1123 <                    && elements[inc(tail(), capacity)] == null);
1219 >            // assert head >= 0 && head < capacity;
1220 >            // assert tail >= 0 && tail < capacity;
1221 >            // assert capacity > 0;
1222 >            // assert size() < capacity;
1223 >            // assert head == tail || elements[head] != null;
1224 >            // assert elements[tail] == null;
1225 >            // assert head == tail || elements[dec(tail, capacity)] != null;
1226          } catch (Throwable t) {
1227 <            System.err.printf("head=%d size=%d capacity=%d%n",
1228 <                              head, size, elements.length);
1227 >            System.err.printf("head=%d tail=%d capacity=%d%n",
1228 >                              head, tail, elements.length);
1229              System.err.printf("elements=%s%n",
1230                                Arrays.toString(elements));
1231              throw t;

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines