ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/main/java/util/ArrayList.java

Comparing jsr166/src/main/java/util/ArrayList.java (file contents):
Revision 1.39 by jsr166, Sun Nov 13 02:10:09 2016 UTC vs.
Revision 1.46 by jsr166, Fri Dec 2 06:41:08 2016 UTC

#	Line 501 | Line 501 | public class ArrayList<E> extends Abstra
501		s - index);
502		elementData[index] = element;
503		size = s + 1;
504	+	// checkInvariants();
505		}
506
507		/**
#	Line 524 | Line 525 | public class ArrayList<E> extends Abstra
525		numMoved);
526		elementData[--size] = null; // clear to let GC do its work
527
528	+	// checkInvariants();
529		return oldValue;
530		}
531
#	Line 557 | Line 559 | public class ArrayList<E> extends Abstra
559		return false;
560		}
561
562	<	/*
562	>	/**
563		* Private remove method that skips bounds checking and does not
564		* return the value removed.
565		*/
#	Line 576 | Line 578 | public class ArrayList<E> extends Abstra
578		*/
579		public void clear() {
580		modCount++;
581	<
580	<	// clear to let GC do its work
581	<	for (int i = 0; i < size; i++)
582	<	elementData[i] = null;
583	<
581	>	Arrays.fill(elementData, 0, size, null);
582		size = 0;
583		}
584
#	Line 609 | Line 607 | public class ArrayList<E> extends Abstra
607		elementData = grow(s + numNew);
608		System.arraycopy(a, 0, elementData, s, numNew);
609		size = s + numNew;
610	+	// checkInvariants();
611		return true;
612		}
613
#	Line 647 | Line 646 | public class ArrayList<E> extends Abstra
646		numMoved);
647		System.arraycopy(a, 0, elementData, index, numNew);
648		size = s + numNew;
649	+	// checkInvariants();
650		return true;
651		}
652
#	Line 669 | Line 669 | public class ArrayList<E> extends Abstra
669		outOfBoundsMsg(fromIndex, toIndex));
670		}
671		modCount++;
672	<	int numMoved = size - toIndex;
673	<	System.arraycopy(elementData, toIndex, elementData, fromIndex,
674	<	numMoved);
675	<
676	<	// clear to let GC do its work
677	<	int newSize = size - (toIndex-fromIndex);
678	<	for (int i = newSize; i < size; i++) {
679	<	elementData[i] = null;
680	<	}
681	<	size = newSize;
672	>	final Object[] es = elementData;
673	>	final int oldSize = size;
674	>	System.arraycopy(es, toIndex, es, fromIndex, oldSize - toIndex);
675	>	Arrays.fill(es, size -= (toIndex - fromIndex), oldSize, null);
676	>	// checkInvariants();
677		}
678
679		/**
#	Line 721 | Line 716 | public class ArrayList<E> extends Abstra
716		* @see Collection#contains(Object)
717		*/
718		public boolean removeAll(Collection<?> c) {
719	<	return batchRemove(c, false);
719	>	return batchRemove(c, false, 0, size);
720		}
721
722		/**
#	Line 741 | Line 736 | public class ArrayList<E> extends Abstra
736		* @see Collection#contains(Object)
737		*/
738		public boolean retainAll(Collection<?> c) {
739	<	return batchRemove(c, true);
739	>	return batchRemove(c, true, 0, size);
740		}
741
742	<	private boolean batchRemove(Collection<?> c, boolean complement) {
742	>	boolean batchRemove(Collection<?> c, boolean complement,
743	>	final int from, final int end) {
744		Objects.requireNonNull(c);
745		final Object[] es = elementData;
750	–	final int end = size;
746		final boolean modified;
747		int r;
748		// Optimize for initial run of survivors
749	<	for (r = 0; r < end && c.contains(es[r]) == complement; r++)
749	>	for (r = from; r < end && c.contains(es[r]) == complement; r++)
750		;
751		if (modified = (r < end)) {
752		int w = r++;
#	Line 766 | Line 761 | public class ArrayList<E> extends Abstra
761		w += end - r;
762		throw ex;
763		} finally {
764	<	modCount += end - w;
765	<	Arrays.fill(es, size = w, end, null);
764	>	final int oldSize = size, deleted = end - w;
765	>	modCount += deleted;
766	>	System.arraycopy(es, end, es, w, oldSize - end);
767	>	Arrays.fill(es, size -= deleted, oldSize, null);
768		}
769		}
770	+	// checkInvariants();
771		return modified;
772		}
773
774		/**
775	<	* Save the state of the {@code ArrayList} instance to a stream (that
776	<	* is, serialize it).
775	>	* Saves the state of the {@code ArrayList} instance to a stream
776	>	* (that is, serializes it).
777		*
778	+	* @param s the stream
779	+	* @throws java.io.IOException if an I/O error occurs
780		* @serialData The length of the array backing the {@code ArrayList}
781		*             instance is emitted (int), followed by all of its elements
782		*             (each an {@code Object}) in the proper order.
783		*/
784		private void writeObject(java.io.ObjectOutputStream s)
785	<	throws java.io.IOException{
785	>	throws java.io.IOException {
786		// Write out element count, and any hidden stuff
787		int expectedModCount = modCount;
788		s.defaultWriteObject();
#	Line 801 | Line 801 | public class ArrayList<E> extends Abstra
801		}
802
803		/**
804	<	* Reconstitute the {@code ArrayList} instance from a stream (that is,
805	<	* deserialize it).
804	>	* Reconstitutes the {@code ArrayList} instance from a stream (that is,
805	>	* deserializes it).
806	>	* @param s the stream
807	>	* @throws ClassNotFoundException if the class of a serialized object
808	>	*         could not be found
809	>	* @throws java.io.IOException if an I/O error occurs
810		*/
811		private void readObject(java.io.ObjectInputStream s)
812		throws java.io.IOException, ClassNotFoundException {
#	Line 914 | Line 918 | public class ArrayList<E> extends Abstra
918		}
919
920		@Override
921	<	@SuppressWarnings("unchecked")
922	<	public void forEachRemaining(Consumer<? super E> consumer) {
919	<	Objects.requireNonNull(consumer);
921	>	public void forEachRemaining(Consumer<? super E> action) {
922	>	Objects.requireNonNull(action);
923		final int size = ArrayList.this.size;
924		int i = cursor;
925	<	if (i >= size) {
926	<	return;
927	<	}
928	<	final Object[] elementData = ArrayList.this.elementData;
929	<	if (i >= elementData.length) {
930	<	throw new ConcurrentModificationException();
931	<	}
932	<	while (i != size && modCount == expectedModCount) {
933	<	consumer.accept((E) elementData[i++]);
925	>	if (i < size) {
926	>	final Object[] es = elementData;
927	>	if (i >= es.length)
928	>	throw new ConcurrentModificationException();
929	>	for (; i < size && modCount == expectedModCount; i++)
930	>	action.accept(elementAt(es, i));
931	>	// update once at end to reduce heap write traffic
932	>	cursor = i;
933	>	lastRet = i - 1;
934	>	checkForComodification();
935		}
932	–	// update once at end of iteration to reduce heap write traffic
933	–	cursor = i;
934	–	lastRet = i - 1;
935	–	checkForComodification();
936		}
937
938		final void checkForComodification() {
#	Line 1119 | Line 1119 | public class ArrayList<E> extends Abstra
1119		return true;
1120		}
1121
1122	+	public boolean removeAll(Collection<?> c) {
1123	+	return batchRemove(c, false);
1124	+	}
1125	+
1126	+	public boolean retainAll(Collection<?> c) {
1127	+	return batchRemove(c, true);
1128	+	}
1129	+
1130	+	private boolean batchRemove(Collection<?> c, boolean complement) {
1131	+	checkForComodification();
1132	+	int oldSize = root.size;
1133	+	boolean modified =
1134	+	root.batchRemove(c, complement, offset, offset + size);
1135	+	if (modified)
1136	+	updateSizeAndModCount(root.size - oldSize);
1137	+	return modified;
1138	+	}
1139	+
1140	+	public boolean removeIf(Predicate<? super E> filter) {
1141	+	checkForComodification();
1142	+	int oldSize = root.size;
1143	+	boolean modified = root.removeIf(filter, offset, offset + size);
1144	+	if (modified)
1145	+	updateSizeAndModCount(root.size - oldSize);
1146	+	return modified;
1147	+	}
1148	+
1149		public Iterator<E> iterator() {
1150		return listIterator();
1151		}
#	Line 1166 | Line 1193 | public class ArrayList<E> extends Abstra
1193		return (E) elementData[offset + (lastRet = i)];
1194		}
1195
1196	<	@SuppressWarnings("unchecked")
1197	<	public void forEachRemaining(Consumer<? super E> consumer) {
1171	<	Objects.requireNonNull(consumer);
1196	>	public void forEachRemaining(Consumer<? super E> action) {
1197	>	Objects.requireNonNull(action);
1198		final int size = SubList.this.size;
1199		int i = cursor;
1200	<	if (i >= size) {
1201	<	return;
1202	<	}
1203	<	final Object[] elementData = root.elementData;
1204	<	if (offset + i >= elementData.length) {
1205	<	throw new ConcurrentModificationException();
1206	<	}
1207	<	while (i != size && modCount == expectedModCount) {
1208	<	consumer.accept((E) elementData[offset + (i++)]);
1200	>	if (i < size) {
1201	>	final Object[] es = root.elementData;
1202	>	if (offset + i >= es.length)
1203	>	throw new ConcurrentModificationException();
1204	>	for (; i < size && modCount == expectedModCount; i++)
1205	>	action.accept(elementAt(es, offset + i));
1206	>	// update once at end to reduce heap write traffic
1207	>	cursor = i;
1208	>	lastRet = i - 1;
1209	>	checkForComodification();
1210		}
1184	–	// update once at end of iteration to reduce heap write traffic
1185	–	lastRet = cursor = i;
1186	–	checkForComodification();
1211		}
1212
1213		public int nextIndex() {
#	Line 1273 | Line 1297 | public class ArrayList<E> extends Abstra
1297		public Spliterator<E> spliterator() {
1298		checkForComodification();
1299
1300	<	// ArrayListSpliterator is not used because late-binding logic
1301	<	// is different here
1278	<	return new Spliterator<>() {
1300	>	// ArrayListSpliterator not used here due to late-binding
1301	>	return new Spliterator<E>() {
1302		private int index = offset; // current index, modified on advance/split
1303		private int fence = -1; // -1 until used; then one past last index
1304		private int expectedModCount; // initialized when fence set
#	Line 1289 | Line 1312 | public class ArrayList<E> extends Abstra
1312		return hi;
1313		}
1314
1315	<	public ArrayListSpliterator<E> trySplit() {
1315	>	public ArrayList<E>.ArrayListSpliterator trySplit() {
1316		int hi = getFence(), lo = index, mid = (lo + hi) >>> 1;
1317	<	// ArrayListSpliterator could be used here as the source is already bound
1317	>	// ArrayListSpliterator can be used here as the source is already bound
1318		return (lo >= mid) ? null : // divide range in half unless too small
1319	<	new ArrayListSpliterator<>(root, lo, index = mid,
1297	<	expectedModCount);
1319	>	root.new ArrayListSpliterator(lo, index = mid, expectedModCount);
1320		}
1321
1322		public boolean tryAdvance(Consumer<? super E> action) {
#	Line 1336 | Line 1358 | public class ArrayList<E> extends Abstra
1358		}
1359
1360		public long estimateSize() {
1361	<	return (long) (getFence() - index);
1361	>	return getFence() - index;
1362		}
1363
1364		public int characteristics() {
#	Line 1352 | Line 1374 | public class ArrayList<E> extends Abstra
1374		final int expectedModCount = modCount;
1375		final Object[] es = elementData;
1376		final int size = this.size;
1377	<	for (int i = 0; modCount == expectedModCount && i < size; i++) {
1377	>	for (int i = 0; modCount == expectedModCount && i < size; i++)
1378		action.accept(elementAt(es, i));
1379	<	}
1358	<	if (modCount != expectedModCount) {
1379	>	if (modCount != expectedModCount)
1380		throw new ConcurrentModificationException();
1360	–	}
1381		}
1382
1383		/**
#	Line 1375 | Line 1395 | public class ArrayList<E> extends Abstra
1395		*/
1396		@Override
1397		public Spliterator<E> spliterator() {
1398	<	return new ArrayListSpliterator<>(this, 0, -1, 0);
1398	>	return new ArrayListSpliterator(0, -1, 0);
1399		}
1400
1401		/** Index-based split-by-two, lazily initialized Spliterator */
1402	<	static final class ArrayListSpliterator<E> implements Spliterator<E> {
1402	>	final class ArrayListSpliterator implements Spliterator<E> {
1403
1404		/*
1405		* If ArrayLists were immutable, or structurally immutable (no
#	Line 1413 | Line 1433 | public class ArrayList<E> extends Abstra
1433		* these streamlinings.
1434		*/
1435
1416	–	private final ArrayList<E> list;
1436		private int index; // current index, modified on advance/split
1437		private int fence; // -1 until used; then one past last index
1438		private int expectedModCount; // initialized when fence set
1439
1440	<	/** Create new spliterator covering the given  range */
1441	<	ArrayListSpliterator(ArrayList<E> list, int origin, int fence,
1423	<	int expectedModCount) {
1424	<	this.list = list; // OK if null unless traversed
1440	>	/** Create new spliterator covering the given range */
1441	>	ArrayListSpliterator(int origin, int fence, int expectedModCount) {
1442		this.index = origin;
1443		this.fence = fence;
1444		this.expectedModCount = expectedModCount;
#	Line 1429 | Line 1446 | public class ArrayList<E> extends Abstra
1446
1447		private int getFence() { // initialize fence to size on first use
1448		int hi; // (a specialized variant appears in method forEach)
1432	–	ArrayList<E> lst;
1449		if ((hi = fence) < 0) {
1450	<	if ((lst = list) == null)
1451	<	hi = fence = 0;
1436	<	else {
1437	<	expectedModCount = lst.modCount;
1438	<	hi = fence = lst.size;
1439	<	}
1450	>	expectedModCount = modCount;
1451	>	hi = fence = size;
1452		}
1453		return hi;
1454		}
1455
1456	<	public ArrayListSpliterator<E> trySplit() {
1456	>	public ArrayListSpliterator trySplit() {
1457		int hi = getFence(), lo = index, mid = (lo + hi) >>> 1;
1458		return (lo >= mid) ? null : // divide range in half unless too small
1459	<	new ArrayListSpliterator<>(list, lo, index = mid,
1448	<	expectedModCount);
1459	>	new ArrayListSpliterator(lo, index = mid, expectedModCount);
1460		}
1461
1462		public boolean tryAdvance(Consumer<? super E> action) {
#	Line 1454 | Line 1465 | public class ArrayList<E> extends Abstra
1465		int hi = getFence(), i = index;
1466		if (i < hi) {
1467		index = i + 1;
1468	<	@SuppressWarnings("unchecked") E e = (E)list.elementData[i];
1468	>	@SuppressWarnings("unchecked") E e = (E)elementData[i];
1469		action.accept(e);
1470	<	if (list.modCount != expectedModCount)
1470	>	if (modCount != expectedModCount)
1471		throw new ConcurrentModificationException();
1472		return true;
1473		}
#	Line 1465 | Line 1476 | public class ArrayList<E> extends Abstra
1476
1477		public void forEachRemaining(Consumer<? super E> action) {
1478		int i, hi, mc; // hoist accesses and checks from loop
1479	<	ArrayList<E> lst; Object[] a;
1479	>	Object[] a;
1480		if (action == null)
1481		throw new NullPointerException();
1482	<	if ((lst = list) != null && (a = lst.elementData) != null) {
1482	>	if ((a = elementData) != null) {
1483		if ((hi = fence) < 0) {
1484	<	mc = lst.modCount;
1485	<	hi = lst.size;
1484	>	mc = modCount;
1485	>	hi = size;
1486		}
1487		else
1488		mc = expectedModCount;
#	Line 1480 | Line 1491 | public class ArrayList<E> extends Abstra
1491		@SuppressWarnings("unchecked") E e = (E) a[i];
1492		action.accept(e);
1493		}
1494	<	if (lst.modCount == mc)
1494	>	if (modCount == mc)
1495		return;
1496		}
1497		}
#	Line 1488 | Line 1499 | public class ArrayList<E> extends Abstra
1499		}
1500
1501		public long estimateSize() {
1502	<	return (long) (getFence() - index);
1502	>	return getFence() - index;
1503		}
1504
1505		public int characteristics() {
#	Line 1509 | Line 1520 | public class ArrayList<E> extends Abstra
1520		}
1521
1522		@Override
1523	<	public boolean removeIf(Predicate<? super E> filter) {
1523	>	public boolean removeIf(Predicate<? super E> filter) {
1524	>	return removeIf(filter, 0, size);
1525	>	}
1526	>
1527	>	/**
1528	>	* Removes all elements satisfying the given predicate, from index
1529	>	* i (inclusive) to index end (exclusive).
1530	>	*/
1531	>	boolean removeIf(Predicate<? super E> filter, int i, final int end) {
1532		Objects.requireNonNull(filter);
1533		int expectedModCount = modCount;
1534		final Object[] es = elementData;
1516	–	final int end = size;
1517	–	final boolean modified;
1518	–	int i;
1535		// Optimize for initial run of survivors
1536	<	for (i = 0; i < end && !filter.test(elementAt(es, i)); i++)
1536	>	for (; i < end && !filter.test(elementAt(es, i)); i++)
1537		;
1538		// Tolerate predicates that reentrantly access the collection for
1539		// read (but writers still get CME), so traverse once to find
1540		// elements to delete, a second pass to physically expunge.
1541	<	if (modified = (i < end)) {
1526	<	expectedModCount++;
1527	<	modCount++;
1541	>	if (i < end) {
1542		final int beg = i;
1543		final long[] deathRow = nBits(end - beg);
1544		deathRow[0] = 1L;   // set bit 0
1545		for (i = beg + 1; i < end; i++)
1546		if (filter.test(elementAt(es, i)))
1547		setBit(deathRow, i - beg);
1548	+	if (modCount != expectedModCount)
1549	+	throw new ConcurrentModificationException();
1550	+	expectedModCount++;
1551	+	modCount++;
1552		int w = beg;
1553		for (i = beg; i < end; i++)
1554		if (isClear(deathRow, i - beg))
1555		es[w++] = es[i];
1556	<	Arrays.fill(es, size = w, end, null);
1556	>	final int oldSize = size;
1557	>	System.arraycopy(es, end, es, w, oldSize - end);
1558	>	Arrays.fill(es, size -= (end - w), oldSize, null);
1559	>	// checkInvariants();
1560	>	return true;
1561	>	} else {
1562	>	if (modCount != expectedModCount)
1563	>	throw new ConcurrentModificationException();
1564	>	// checkInvariants();
1565	>	return false;
1566		}
1540	–	if (modCount != expectedModCount)
1541	–	throw new ConcurrentModificationException();
1542	–	return modified;
1567		}
1568
1569		@Override
#	Line 1548 | Line 1572 | public class ArrayList<E> extends Abstra
1572		final int expectedModCount = modCount;
1573		final Object[] es = elementData;
1574		final int size = this.size;
1575	<	for (int i=0; modCount == expectedModCount && i < size; i++) {
1575	>	for (int i = 0; modCount == expectedModCount && i < size; i++)
1576		es[i] = operator.apply(elementAt(es, i));
1577	<	}
1554	<	if (modCount != expectedModCount) {
1577	>	if (modCount != expectedModCount)
1578		throw new ConcurrentModificationException();
1556	–	}
1579		modCount++;
1580	+	// checkInvariants();
1581		}
1582
1583		@Override
#	Line 1562 | Line 1585 | public class ArrayList<E> extends Abstra
1585		public void sort(Comparator<? super E> c) {
1586		final int expectedModCount = modCount;
1587		Arrays.sort((E[]) elementData, 0, size, c);
1588	<	if (modCount != expectedModCount) {
1588	>	if (modCount != expectedModCount)
1589		throw new ConcurrentModificationException();
1567	–	}
1590		modCount++;
1591	+	// checkInvariants();
1592	+	}
1593	+
1594	+	void checkInvariants() {
1595	+	// assert size >= 0;
1596	+	// assert size == elementData.length || elementData[size] == null;
1597		}
1598		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines