--- jsr166/src/main/java/util/PriorityQueue.java 2016/11/30 03:31:47 1.113 +++ jsr166/src/main/java/util/PriorityQueue.java 2016/12/29 23:14:34 1.118 @@ -522,6 +522,8 @@ public class PriorityQueue extends Ab */ private int expectedModCount = modCount; + Itr() {} // prevent access constructor creation + public boolean hasNext() { return cursor < size || (forgetMeNot != null && !forgetMeNot.isEmpty()); @@ -631,7 +633,7 @@ public class PriorityQueue extends Ab * promoting x up the tree until it is greater than or equal to * its parent, or is the root. * - * To simplify and speed up coercions and comparisons. the + * To simplify and speed up coercions and comparisons, the * Comparable and Comparator versions are separated into different * methods that are otherwise identical. (Similarly for siftDown.) * @@ -731,8 +733,14 @@ public class PriorityQueue extends Ab */ @SuppressWarnings("unchecked") private void heapify() { - for (int i = (size >>> 1) - 1; i >= 0; i--) - siftDown(i, (E) queue[i]); + final Object[] es = queue; + int i = (size >>> 1) - 1; + if (comparator == null) + for (; i >= 0; i--) + siftDownComparable(i, (E) es[i]); + else + for (; i >= 0; i--) + siftDownUsingComparator(i, (E) es[i]); } /** @@ -817,10 +825,6 @@ public class PriorityQueue extends Ab } final class PriorityQueueSpliterator implements Spliterator { - /* - * This is very similar to ArrayList Spliterator, except for - * extra null checks. - */ private int index; // current index, modified on advance/split private int fence; // -1 until first use private int expectedModCount; // initialized when fence set @@ -849,46 +853,33 @@ public class PriorityQueue extends Ab @SuppressWarnings("unchecked") public void forEachRemaining(Consumer action) { - int i, hi, mc; // hoist accesses and checks from loop - final Object[] a; if (action == null) throw new NullPointerException(); - if ((a = queue) != null) { - if ((hi = fence) < 0) { - mc = modCount; - hi = size; - } - else - mc = expectedModCount; - if ((i = index) >= 0 && (index = hi) <= a.length) { - for (E e;; ++i) { - if (i < hi) { - if ((e = (E) a[i]) == null) // must be CME - break; - action.accept(e); - } - else if (modCount != mc) - break; - else - return; - } - } + if (fence < 0) { fence = size; expectedModCount = modCount; } + final Object[] a = queue; + int i, hi; E e; + for (i = index, index = hi = fence; i < hi; i++) { + if ((e = (E) a[i]) == null) + break; // must be CME + action.accept(e); } - throw new ConcurrentModificationException(); + if (modCount != expectedModCount) + throw new ConcurrentModificationException(); } + @SuppressWarnings("unchecked") public boolean tryAdvance(Consumer action) { if (action == null) throw new NullPointerException(); - int hi = getFence(), lo = index; - if (lo >= 0 && lo < hi) { - index = lo + 1; - @SuppressWarnings("unchecked") E e = (E)queue[lo]; - if (e == null) + if (fence < 0) { fence = size; expectedModCount = modCount; } + int i; + if ((i = index) < fence) { + index = i + 1; + E e; + if ((e = (E) queue[i]) == null + || modCount != expectedModCount) throw new ConcurrentModificationException(); action.accept(e); - if (modCount != expectedModCount) - throw new ConcurrentModificationException(); return true; } return false;