ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/main/java/util/Vector.java
(Generate patch)

Comparing jsr166/src/main/java/util/Vector.java (file contents):
Revision 1.37 by jsr166, Wed Nov 30 03:31:47 2016 UTC vs.
Revision 1.41 by jsr166, Thu Dec 8 05:01:42 2016 UTC

# Line 306 | Line 306 | public class Vector<E>
306          modCount++;
307          if (newSize > elementData.length)
308              grow(newSize);
309 <        for (int i = newSize; i < elementCount; i++)
310 <            elementData[i] = null;
311 <        elementCount = newSize;
309 >        final Object[] es = elementData;
310 >        for (int to = elementCount, i = elementCount = newSize; i < to; i++)
311 >            es[i] = null;
312      }
313  
314      /**
# Line 676 | Line 676 | public class Vector<E>
676       * method (which is part of the {@link List} interface).
677       */
678      public synchronized void removeAllElements() {
679 <        Arrays.fill(elementData, 0, elementCount, null);
679 >        final Object[] es = elementData;
680 >        for (int to = elementCount, i = elementCount = 0; i < to; i++)
681 >            es[i] = null;
682          modCount++;
681 –        elementCount = 0;
683      }
684  
685      /**
# Line 984 | Line 985 | public class Vector<E>
985          return bulkRemove(e -> !c.contains(e));
986      }
987  
988 +    /**
989 +     * @throws NullPointerException {@inheritDoc}
990 +     */
991      @Override
992      public boolean removeIf(Predicate<? super E> filter) {
993          Objects.requireNonNull(filter);
# Line 1028 | Line 1032 | public class Vector<E>
1032              for (i = beg; i < end; i++)
1033                  if (isClear(deathRow, i - beg))
1034                      es[w++] = es[i];
1035 <            Arrays.fill(es, elementCount = w, end, null);
1035 >            for (i = elementCount = w; i < end; i++)
1036 >                es[i] = null;
1037              // checkInvariants();
1038              return true;
1039          } else {
# Line 1159 | Line 1164 | public class Vector<E>
1164       * (If {@code toIndex==fromIndex}, this operation has no effect.)
1165       */
1166      protected synchronized void removeRange(int fromIndex, int toIndex) {
1162 –        final Object[] es = elementData;
1163 –        final int oldSize = elementCount;
1164 –        System.arraycopy(es, toIndex, es, fromIndex, oldSize - toIndex);
1165 –
1167          modCount++;
1168 <        Arrays.fill(es, elementCount -= (toIndex - fromIndex), oldSize, null);
1168 >        shiftTailOverGap(elementData, fromIndex, toIndex);
1169          // checkInvariants();
1170      }
1171  
1172 +    /** Erases the gap from lo to hi, by sliding down following elements. */
1173 +    private void shiftTailOverGap(Object[] es, int lo, int hi) {
1174 +        System.arraycopy(es, hi, es, lo, elementCount - hi);
1175 +        for (int to = elementCount, i = (elementCount -= hi - lo); i < to; i++)
1176 +            es[i] = null;
1177 +    }
1178 +
1179      /**
1180 <     * Save the state of the {@code Vector} instance to a stream (that
1181 <     * is, serialize it).
1180 >     * Saves the state of the {@code Vector} instance to a stream
1181 >     * (that is, serializes it).
1182       * This method performs synchronization to ensure the consistency
1183       * of the serialized data.
1184 +     *
1185 +     * @param s the stream
1186 +     * @throws java.io.IOException if an I/O error occurs
1187       */
1188      private void writeObject(java.io.ObjectOutputStream s)
1189              throws java.io.IOException {
# Line 1345 | Line 1356 | public class Vector<E>
1356          }
1357      }
1358  
1359 +    /**
1360 +     * @throws NullPointerException {@inheritDoc}
1361 +     */
1362      @Override
1363      public synchronized void forEach(Consumer<? super E> action) {
1364          Objects.requireNonNull(action);
# Line 1358 | Line 1372 | public class Vector<E>
1372          // checkInvariants();
1373      }
1374  
1375 +    /**
1376 +     * @throws NullPointerException {@inheritDoc}
1377 +     */
1378      @Override
1379      public synchronized void replaceAll(UnaryOperator<E> operator) {
1380          Objects.requireNonNull(operator);
# Line 1452 | Line 1469 | public class Vector<E>
1469  
1470          @SuppressWarnings("unchecked")
1471          public void forEachRemaining(Consumer<? super E> action) {
1455 –            int i, hi; // hoist accesses and checks from loop
1456 –            Object[] a;
1472              if (action == null)
1473                  throw new NullPointerException();
1474 <            if ((hi = fence) < 0) {
1475 <                synchronized (Vector.this) {
1476 <                    expectedModCount = modCount;
1477 <                    a = array = elementData;
1478 <                    hi = fence = elementCount;
1479 <                }
1480 <            }
1466 <            else
1467 <                a = array;
1468 <            if (a != null && (i = index) >= 0 && (index = hi) <= a.length) {
1469 <                while (i < hi)
1470 <                    action.accept((E) a[i++]);
1471 <                if (modCount == expectedModCount)
1472 <                    return;
1473 <            }
1474 <            throw new ConcurrentModificationException();
1474 >            final int hi = getFence();
1475 >            final Object[] a = array;
1476 >            int i;
1477 >            for (i = index, index = hi; i < hi; i++)
1478 >                action.accept((E) a[i]);
1479 >            if (modCount != expectedModCount)
1480 >                throw new ConcurrentModificationException();
1481          }
1482  
1483          public long estimateSize() {

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines