ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/AbstractExecutorServiceTest.java
(Generate patch)

Comparing jsr166/src/test/tck/AbstractExecutorServiceTest.java (file contents):
Revision 1.19 by jsr166, Fri Nov 20 05:25:10 2009 UTC vs.
Revision 1.44 by jsr166, Thu Oct 8 03:08:37 2015 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 + import static java.util.concurrent.TimeUnit.MILLISECONDS;
10  
11 < import junit.framework.*;
12 < import java.util.*;
13 < import java.util.concurrent.*;
14 < import java.math.BigInteger;
15 < import java.security.*;
11 > import java.security.PrivilegedAction;
12 > import java.security.PrivilegedExceptionAction;
13 > import java.util.ArrayList;
14 > import java.util.Collections;
15 > import java.util.List;
16 > import java.util.concurrent.AbstractExecutorService;
17 > import java.util.concurrent.ArrayBlockingQueue;
18 > import java.util.concurrent.Callable;
19 > import java.util.concurrent.CancellationException;
20 > import java.util.concurrent.CountDownLatch;
21 > import java.util.concurrent.ExecutionException;
22 > import java.util.concurrent.Executors;
23 > import java.util.concurrent.ExecutorService;
24 > import java.util.concurrent.Future;
25 > import java.util.concurrent.ThreadPoolExecutor;
26 > import java.util.concurrent.TimeUnit;
27 > import java.util.concurrent.atomic.AtomicBoolean;
28 >
29 > import junit.framework.Test;
30 > import junit.framework.TestSuite;
31  
32   public class AbstractExecutorServiceTest extends JSR166TestCase {
33      public static void main(String[] args) {
34 <        junit.textui.TestRunner.run (suite());
34 >        main(suite(), args);
35      }
36      public static Test suite() {
37          return new TestSuite(AbstractExecutorServiceTest.class);
# Line 28 | Line 44 | public class AbstractExecutorServiceTest
44      static class DirectExecutorService extends AbstractExecutorService {
45          public void execute(Runnable r) { r.run(); }
46          public void shutdown() { shutdown = true; }
47 <        public List<Runnable> shutdownNow() { shutdown = true; return Collections.EMPTY_LIST; }
47 >        public List<Runnable> shutdownNow() {
48 >            shutdown = true;
49 >            return Collections.EMPTY_LIST;
50 >        }
51          public boolean isShutdown() { return shutdown; }
52          public boolean isTerminated() { return isShutdown(); }
53 <        public boolean awaitTermination(long timeout, TimeUnit unit) { return isShutdown(); }
53 >        public boolean awaitTermination(long timeout, TimeUnit unit) {
54 >            return isShutdown();
55 >        }
56          private volatile boolean shutdown = false;
57      }
58  
# Line 40 | Line 61 | public class AbstractExecutorServiceTest
61       */
62      public void testExecuteRunnable() throws Exception {
63          ExecutorService e = new DirectExecutorService();
64 <        TrackedShortRunnable task = new TrackedShortRunnable();
65 <        assertFalse(task.done);
66 <        Future<?> future = e.submit(task);
67 <        future.get();
68 <        assertTrue(task.done);
64 >        final AtomicBoolean done = new AtomicBoolean(false);
65 >        Future<?> future = e.submit(new CheckedRunnable() {
66 >            public void realRun() {
67 >                done.set(true);
68 >            }});
69 >        assertNull(future.get());
70 >        assertNull(future.get(0, MILLISECONDS));
71 >        assertTrue(done.get());
72 >        assertTrue(future.isDone());
73 >        assertFalse(future.isCancelled());
74      }
75  
50
76      /**
77       * Completed submit(callable) returns result
78       */
# Line 78 | Line 103 | public class AbstractExecutorServiceTest
103          assertSame(TEST_STRING, result);
104      }
105  
81
106      /**
107 <     * A submitted privileged action to completion
107 >     * A submitted privileged action runs to completion
108       */
109      public void testSubmitPrivilegedAction() throws Exception {
110 <        Policy savedPolicy = null;
111 <        try {
112 <            savedPolicy = Policy.getPolicy();
113 <            AdjustablePolicy policy = new AdjustablePolicy();
90 <            policy.addPermission(new RuntimePermission("getContextClassLoader"));
91 <            policy.addPermission(new RuntimePermission("setContextClassLoader"));
92 <            Policy.setPolicy(policy);
93 <        } catch (AccessControlException ok) {
94 <            return;
95 <        }
96 <        try {
97 <            ExecutorService e = new DirectExecutorService();
98 <            Future future = e.submit(Executors.callable(new PrivilegedAction() {
110 >        Runnable r = new CheckedRunnable() {
111 >            public void realRun() throws Exception {
112 >                ExecutorService e = new DirectExecutorService();
113 >                Future future = e.submit(Executors.callable(new PrivilegedAction() {
114                      public Object run() {
115                          return TEST_STRING;
116                      }}));
117  
118 <            Object result = future.get();
119 <            assertSame(TEST_STRING, result);
120 <        }
121 <        finally {
122 <            try {
123 <                Policy.setPolicy(savedPolicy);
124 <            } catch (AccessControlException ok) {
110 <                return;
111 <            }
112 <        }
118 >                assertSame(TEST_STRING, future.get());
119 >            }};
120 >
121 >        runWithPermissions(r,
122 >                           new RuntimePermission("getClassLoader"),
123 >                           new RuntimePermission("setContextClassLoader"),
124 >                           new RuntimePermission("modifyThread"));
125      }
126  
127      /**
128 <     * A submitted a privileged exception action runs to completion
128 >     * A submitted privileged exception action runs to completion
129       */
130      public void testSubmitPrivilegedExceptionAction() throws Exception {
131 <        Policy savedPolicy = null;
132 <        try {
133 <            savedPolicy = Policy.getPolicy();
134 <            AdjustablePolicy policy = new AdjustablePolicy();
123 <            policy.addPermission(new RuntimePermission("getContextClassLoader"));
124 <            policy.addPermission(new RuntimePermission("setContextClassLoader"));
125 <            Policy.setPolicy(policy);
126 <        } catch (AccessControlException ok) {
127 <            return;
128 <        }
129 <
130 <        try {
131 <            ExecutorService e = new DirectExecutorService();
132 <            Future future = e.submit(Executors.callable(new PrivilegedExceptionAction() {
131 >        Runnable r = new CheckedRunnable() {
132 >            public void realRun() throws Exception {
133 >                ExecutorService e = new DirectExecutorService();
134 >                Future future = e.submit(Executors.callable(new PrivilegedExceptionAction() {
135                      public Object run() {
136                          return TEST_STRING;
137                      }}));
138  
139 <            Object result = future.get();
140 <            assertSame(TEST_STRING, result);
141 <        }
142 <        finally {
141 <            Policy.setPolicy(savedPolicy);
142 <        }
139 >                assertSame(TEST_STRING, future.get());
140 >            }};
141 >
142 >        runWithPermissions(r);
143      }
144  
145      /**
146       * A submitted failed privileged exception action reports exception
147       */
148      public void testSubmitFailedPrivilegedExceptionAction() throws Exception {
149 <        Policy savedPolicy = null;
150 <        try {
151 <            savedPolicy = Policy.getPolicy();
152 <            AdjustablePolicy policy = new AdjustablePolicy();
153 <            policy.addPermission(new RuntimePermission("getContextClassLoader"));
154 <            policy.addPermission(new RuntimePermission("setContextClassLoader"));
155 <            Policy.setPolicy(policy);
156 <        } catch (AccessControlException ok) {
157 <            return;
158 <        }
159 <
160 <        try {
161 <            ExecutorService e = new DirectExecutorService();
162 <            Future future = e.submit(Executors.callable(new PrivilegedExceptionAction() {
149 >        Runnable r = new CheckedRunnable() {
150 >            public void realRun() throws Exception {
151 >                ExecutorService e = new DirectExecutorService();
152 >                Future future = e.submit(Executors.callable(new PrivilegedExceptionAction() {
153                      public Object run() throws Exception {
154                          throw new IndexOutOfBoundsException();
155                      }}));
156  
157 <            future.get();
158 <            shouldThrow();
159 <        } catch (ExecutionException success) {
160 <            assertTrue(success.getCause() instanceof IndexOutOfBoundsException);
161 <        }
162 <        finally {
163 <            Policy.setPolicy(savedPolicy);
164 <        }
157 >                try {
158 >                    future.get();
159 >                    shouldThrow();
160 >                } catch (ExecutionException success) {
161 >                    assertTrue(success.getCause() instanceof IndexOutOfBoundsException);
162 >                }}};
163 >
164 >        runWithPermissions(r);
165      }
166  
167      /**
168       * execute(null runnable) throws NPE
169       */
170      public void testExecuteNullRunnable() {
171 +        ExecutorService e = new DirectExecutorService();
172          try {
182            ExecutorService e = new DirectExecutorService();
173              e.submit((Runnable) null);
174              shouldThrow();
175          } catch (NullPointerException success) {}
176      }
177  
188
178      /**
179       * submit(null callable) throws NPE
180       */
181      public void testSubmitNullCallable() {
182 +        ExecutorService e = new DirectExecutorService();
183          try {
194            ExecutorService e = new DirectExecutorService();
184              e.submit((Callable) null);
185              shouldThrow();
186          } catch (NullPointerException success) {}
187      }
188  
189      /**
190 <     * submit(runnable) throws RejectedExecutionException if
202 <     * executor is saturated.
203 <     */
204 <    public void testExecute1() {
205 <        ThreadPoolExecutor p =
206 <            new ThreadPoolExecutor(1, 1,
207 <                                   60, TimeUnit.SECONDS,
208 <                                   new ArrayBlockingQueue<Runnable>(1));
209 <        try {
210 <            for (int i = 0; i < 2; ++i)
211 <                p.submit(new MediumRunnable());
212 <            for (int i = 0; i < 2; ++i) {
213 <                try {
214 <                    p.submit(new MediumRunnable());
215 <                    shouldThrow();
216 <                } catch (RejectedExecutionException success) {}
217 <            }
218 <        } finally {
219 <            joinPool(p);
220 <        }
221 <    }
222 <
223 <    /**
224 <     * submit(callable) throws RejectedExecutionException
225 <     * if executor is saturated.
226 <     */
227 <    public void testExecute2() {
228 <        ThreadPoolExecutor p =
229 <            new ThreadPoolExecutor(1, 1,
230 <                                   60, TimeUnit.SECONDS,
231 <                                   new ArrayBlockingQueue<Runnable>(1));
232 <        try {
233 <            for (int i = 0; i < 2; ++i)
234 <                p.submit(new MediumRunnable());
235 <            for (int i = 0; i < 2; ++i) {
236 <                try {
237 <                    p.submit(new SmallCallable());
238 <                    shouldThrow();
239 <                } catch (RejectedExecutionException success) {}
240 <            }
241 <        } finally {
242 <            joinPool(p);
243 <        }
244 <    }
245 <
246 <
247 <    /**
248 <     *  Blocking on submit(callable) throws InterruptedException if
249 <     *  caller interrupted.
190 >     * submit(callable).get() throws InterruptedException if interrupted
191       */
192      public void testInterruptedSubmit() throws InterruptedException {
193 <        final ThreadPoolExecutor p = new ThreadPoolExecutor(1,1,60, TimeUnit.SECONDS, new ArrayBlockingQueue<Runnable>(10));
194 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
195 <            public void realRun() throws Exception {
196 <                p.submit(new CheckedCallable<Object>() {
197 <                             public Object realCall()
198 <                                 throws InterruptedException {
199 <                                 Thread.sleep(SMALL_DELAY_MS);
200 <                                 return null;
201 <                             }}).get();
202 <            }});
203 <
204 <        t.start();
205 <        Thread.sleep(SHORT_DELAY_MS);
206 <        t.interrupt();
207 <        joinPool(p);
208 <    }
209 <
269 <    /**
270 <     *  get of submitted callable throws InterruptedException if callable
271 <     *  interrupted
272 <     */
273 <    public void testSubmitIE() throws InterruptedException {
274 <        final ThreadPoolExecutor p =
275 <            new ThreadPoolExecutor(1, 1,
276 <                                   60, TimeUnit.SECONDS,
277 <                                   new ArrayBlockingQueue<Runnable>(10));
278 <
279 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
280 <            public void realRun() throws Exception {
281 <                p.submit(new SmallCallable()).get();
282 <            }});
193 >        final CountDownLatch submitted    = new CountDownLatch(1);
194 >        final CountDownLatch quittingTime = new CountDownLatch(1);
195 >        final Callable<Void> awaiter = new CheckedCallable<Void>() {
196 >            public Void realCall() throws InterruptedException {
197 >                assertTrue(quittingTime.await(2*LONG_DELAY_MS, MILLISECONDS));
198 >                return null;
199 >            }};
200 >        final ExecutorService p
201 >            = new ThreadPoolExecutor(1,1,60, TimeUnit.SECONDS,
202 >                                     new ArrayBlockingQueue<Runnable>(10));
203 >        try (PoolCleaner cleaner = cleaner(p, quittingTime)) {
204 >            Thread t = newStartedThread(new CheckedInterruptedRunnable() {
205 >                public void realRun() throws Exception {
206 >                    Future<Void> future = p.submit(awaiter);
207 >                    submitted.countDown();
208 >                    future.get();
209 >                }});
210  
211 <        t.start();
212 <        Thread.sleep(SHORT_DELAY_MS);
213 <        t.interrupt();
214 <        t.join();
288 <        joinPool(p);
211 >            await(submitted);
212 >            t.interrupt();
213 >            awaitTermination(t);
214 >        }
215      }
216  
217      /**
218 <     *  get of submit(callable) throws ExecutionException if callable
219 <     *  throws exception
218 >     * get of submit(callable) throws ExecutionException if callable
219 >     * throws exception
220       */
221      public void testSubmitEE() throws InterruptedException {
222 <        ThreadPoolExecutor p =
222 >        final ThreadPoolExecutor p =
223              new ThreadPoolExecutor(1, 1,
224                                     60, TimeUnit.SECONDS,
225                                     new ArrayBlockingQueue<Runnable>(10));
226 <
227 <        Callable c = new Callable() {
228 <            public Object call() { return 5/0; }};
229 <
230 <        try {
231 <            p.submit(c).get();
232 <            shouldThrow();
233 <        } catch (ExecutionException success) {
234 <            assertTrue(success.getCause() instanceof ArithmeticException);
226 >        try (PoolCleaner cleaner = cleaner(p)) {
227 >            Callable c = new Callable() {
228 >                public Object call() { throw new ArithmeticException(); }};
229 >            try {
230 >                p.submit(c).get();
231 >                shouldThrow();
232 >            } catch (ExecutionException success) {
233 >                assertTrue(success.getCause() instanceof ArithmeticException);
234 >            }
235          }
310        joinPool(p);
236      }
237  
238      /**
239       * invokeAny(null) throws NPE
240       */
241 <    public void testInvokeAny1()
242 <        throws InterruptedException, ExecutionException {
243 <        ExecutorService e = new DirectExecutorService();
244 <        try {
245 <            e.invokeAny(null);
246 <            shouldThrow();
247 <        } catch (NullPointerException success) {
323 <        } finally {
324 <            joinPool(e);
241 >    public void testInvokeAny1() throws Exception {
242 >        final ExecutorService e = new DirectExecutorService();
243 >        try (PoolCleaner cleaner = cleaner(e)) {
244 >            try {
245 >                e.invokeAny(null);
246 >                shouldThrow();
247 >            } catch (NullPointerException success) {}
248          }
249      }
250  
251      /**
252       * invokeAny(empty collection) throws IAE
253       */
254 <    public void testInvokeAny2()
255 <        throws InterruptedException, ExecutionException {
256 <        ExecutorService e = new DirectExecutorService();
257 <        try {
258 <            e.invokeAny(new ArrayList<Callable<String>>());
259 <            shouldThrow();
260 <        } catch (IllegalArgumentException success) {
338 <        } finally {
339 <            joinPool(e);
254 >    public void testInvokeAny2() throws Exception {
255 >        final ExecutorService e = new DirectExecutorService();
256 >        try (PoolCleaner cleaner = cleaner(e)) {
257 >            try {
258 >                e.invokeAny(new ArrayList<Callable<String>>());
259 >                shouldThrow();
260 >            } catch (IllegalArgumentException success) {}
261          }
262      }
263  
# Line 344 | Line 265 | public class AbstractExecutorServiceTest
265       * invokeAny(c) throws NPE if c has null elements
266       */
267      public void testInvokeAny3() throws Exception {
268 <        final CountDownLatch latch = new CountDownLatch(1);
269 <        ExecutorService e = new DirectExecutorService();
270 <        try {
271 <            ArrayList<Callable<Integer>> l
272 <                = new ArrayList<Callable<Integer>>();
352 <            l.add(new Callable<Integer>() {
353 <                      public Integer call() { return 5/0; }});
268 >        final ExecutorService e = new DirectExecutorService();
269 >        try (PoolCleaner cleaner = cleaner(e)) {
270 >            List<Callable<Long>> l = new ArrayList<Callable<Long>>();
271 >            l.add(new Callable<Long>() {
272 >                      public Long call() { throw new ArithmeticException(); }});
273              l.add(null);
274 <            e.invokeAny(l);
275 <            shouldThrow();
276 <        } catch (NullPointerException success) {
277 <        } finally {
359 <            latch.countDown();
360 <            joinPool(e);
274 >            try {
275 >                e.invokeAny(l);
276 >                shouldThrow();
277 >            } catch (NullPointerException success) {}
278          }
279      }
280  
# Line 365 | Line 282 | public class AbstractExecutorServiceTest
282       * invokeAny(c) throws ExecutionException if no task in c completes
283       */
284      public void testInvokeAny4() throws InterruptedException {
285 <        ExecutorService e = new DirectExecutorService();
286 <        try {
287 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
285 >        final ExecutorService e = new DirectExecutorService();
286 >        try (PoolCleaner cleaner = cleaner(e)) {
287 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
288              l.add(new NPETask());
289 <            e.invokeAny(l);
290 <            shouldThrow();
291 <        } catch (ExecutionException success) {
292 <            assertTrue(success.getCause() instanceof NullPointerException);
293 <        } finally {
294 <            joinPool(e);
289 >            try {
290 >                e.invokeAny(l);
291 >                shouldThrow();
292 >            } catch (ExecutionException success) {
293 >                assertTrue(success.getCause() instanceof NullPointerException);
294 >            }
295          }
296      }
297  
# Line 382 | Line 299 | public class AbstractExecutorServiceTest
299       * invokeAny(c) returns result of some task in c if at least one completes
300       */
301      public void testInvokeAny5() throws Exception {
302 <        ExecutorService e = new DirectExecutorService();
303 <        try {
304 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
302 >        final ExecutorService e = new DirectExecutorService();
303 >        try (PoolCleaner cleaner = cleaner(e)) {
304 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
305              l.add(new StringTask());
306              l.add(new StringTask());
307              String result = e.invokeAny(l);
308              assertSame(TEST_STRING, result);
392        } finally {
393            joinPool(e);
309          }
310      }
311  
# Line 398 | Line 313 | public class AbstractExecutorServiceTest
313       * invokeAll(null) throws NPE
314       */
315      public void testInvokeAll1() throws InterruptedException {
316 <        ExecutorService e = new DirectExecutorService();
317 <        try {
318 <            e.invokeAll(null);
319 <            shouldThrow();
320 <        } catch (NullPointerException success) {
321 <        } finally {
407 <            joinPool(e);
316 >        final ExecutorService e = new DirectExecutorService();
317 >        try (PoolCleaner cleaner = cleaner(e)) {
318 >            try {
319 >                e.invokeAll(null);
320 >                shouldThrow();
321 >            } catch (NullPointerException success) {}
322          }
323      }
324  
# Line 412 | Line 326 | public class AbstractExecutorServiceTest
326       * invokeAll(empty collection) returns empty collection
327       */
328      public void testInvokeAll2() throws InterruptedException {
329 <        ExecutorService e = new DirectExecutorService();
330 <        try {
329 >        final ExecutorService e = new DirectExecutorService();
330 >        try (PoolCleaner cleaner = cleaner(e)) {
331              List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>());
332              assertTrue(r.isEmpty());
419        } finally {
420            joinPool(e);
333          }
334      }
335  
# Line 425 | Line 337 | public class AbstractExecutorServiceTest
337       * invokeAll(c) throws NPE if c has null elements
338       */
339      public void testInvokeAll3() throws InterruptedException {
340 <        ExecutorService e = new DirectExecutorService();
341 <        try {
342 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
340 >        final ExecutorService e = new DirectExecutorService();
341 >        try (PoolCleaner cleaner = cleaner(e)) {
342 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
343              l.add(new StringTask());
344              l.add(null);
345 <            e.invokeAll(l);
346 <            shouldThrow();
347 <        } catch (NullPointerException success) {
348 <        } finally {
437 <            joinPool(e);
345 >            try {
346 >                e.invokeAll(l);
347 >                shouldThrow();
348 >            } catch (NullPointerException success) {}
349          }
350      }
351  
# Line 442 | Line 353 | public class AbstractExecutorServiceTest
353       * get of returned element of invokeAll(c) throws exception on failed task
354       */
355      public void testInvokeAll4() throws Exception {
356 <        ExecutorService e = new DirectExecutorService();
357 <        try {
358 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
356 >        final ExecutorService e = new DirectExecutorService();
357 >        try (PoolCleaner cleaner = cleaner(e)) {
358 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
359              l.add(new NPETask());
360 <            List<Future<String>> result = e.invokeAll(l);
361 <            assertEquals(1, result.size());
362 <            for (Future<String> future : result) {
363 <                try {
364 <                    future.get();
365 <                    shouldThrow();
366 <                } catch (ExecutionException success) {
456 <                    Throwable cause = success.getCause();
457 <                    assertTrue(cause instanceof NullPointerException);
458 <                }
360 >            List<Future<String>> futures = e.invokeAll(l);
361 >            assertEquals(1, futures.size());
362 >            try {
363 >                futures.get(0).get();
364 >                shouldThrow();
365 >            } catch (ExecutionException success) {
366 >                assertTrue(success.getCause() instanceof NullPointerException);
367              }
460        } finally {
461            joinPool(e);
368          }
369      }
370  
# Line 466 | Line 372 | public class AbstractExecutorServiceTest
372       * invokeAll(c) returns results of all completed tasks in c
373       */
374      public void testInvokeAll5() throws Exception {
375 <        ExecutorService e = new DirectExecutorService();
376 <        try {
377 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
375 >        final ExecutorService e = new DirectExecutorService();
376 >        try (PoolCleaner cleaner = cleaner(e)) {
377 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
378              l.add(new StringTask());
379              l.add(new StringTask());
380 <            List<Future<String>> result = e.invokeAll(l);
381 <            assertEquals(2, result.size());
382 <            for (Future<String> future : result)
380 >            List<Future<String>> futures = e.invokeAll(l);
381 >            assertEquals(2, futures.size());
382 >            for (Future<String> future : futures)
383                  assertSame(TEST_STRING, future.get());
478        } finally {
479            joinPool(e);
384          }
385      }
386  
483
387      /**
388       * timed invokeAny(null) throws NPE
389       */
390      public void testTimedInvokeAny1() throws Exception {
391 <        ExecutorService e = new DirectExecutorService();
392 <        try {
393 <            e.invokeAny(null, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
394 <            shouldThrow();
395 <        } catch (NullPointerException success) {
396 <        } finally {
494 <            joinPool(e);
391 >        final ExecutorService e = new DirectExecutorService();
392 >        try (PoolCleaner cleaner = cleaner(e)) {
393 >            try {
394 >                e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
395 >                shouldThrow();
396 >            } catch (NullPointerException success) {}
397          }
398      }
399  
# Line 499 | Line 401 | public class AbstractExecutorServiceTest
401       * timed invokeAny(null time unit) throws NPE
402       */
403      public void testTimedInvokeAnyNullTimeUnit() throws Exception {
404 <        ExecutorService e = new DirectExecutorService();
405 <        try {
406 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
404 >        final ExecutorService e = new DirectExecutorService();
405 >        try (PoolCleaner cleaner = cleaner(e)) {
406 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
407              l.add(new StringTask());
408 <            e.invokeAny(l, MEDIUM_DELAY_MS, null);
409 <            shouldThrow();
410 <        } catch (NullPointerException success) {
411 <        } finally {
510 <            joinPool(e);
408 >            try {
409 >                e.invokeAny(l, MEDIUM_DELAY_MS, null);
410 >                shouldThrow();
411 >            } catch (NullPointerException success) {}
412          }
413      }
414  
# Line 515 | Line 416 | public class AbstractExecutorServiceTest
416       * timed invokeAny(empty collection) throws IAE
417       */
418      public void testTimedInvokeAny2() throws Exception {
419 <        ExecutorService e = new DirectExecutorService();
420 <        try {
421 <            e.invokeAny(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
422 <            shouldThrow();
423 <        } catch (IllegalArgumentException success) {
424 <        } finally {
425 <            joinPool(e);
419 >        final ExecutorService e = new DirectExecutorService();
420 >        try (PoolCleaner cleaner = cleaner(e)) {
421 >            try {
422 >                e.invokeAny(new ArrayList<Callable<String>>(),
423 >                            MEDIUM_DELAY_MS, MILLISECONDS);
424 >                shouldThrow();
425 >            } catch (IllegalArgumentException success) {}
426          }
427      }
428  
# Line 529 | Line 430 | public class AbstractExecutorServiceTest
430       * timed invokeAny(c) throws NPE if c has null elements
431       */
432      public void testTimedInvokeAny3() throws Exception {
433 <        final CountDownLatch latch = new CountDownLatch(1);
434 <        ExecutorService e = new DirectExecutorService();
435 <        try {
436 <            ArrayList<Callable<Integer>> l
437 <                = new ArrayList<Callable<Integer>>();
537 <            l.add(new Callable<Integer>() {
538 <                      public Integer call() { return 5/0; }});
433 >        final ExecutorService e = new DirectExecutorService();
434 >        try (PoolCleaner cleaner = cleaner(e)) {
435 >            List<Callable<Long>> l = new ArrayList<Callable<Long>>();
436 >            l.add(new Callable<Long>() {
437 >                      public Long call() { throw new ArithmeticException(); }});
438              l.add(null);
439 <            e.invokeAny(l, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
440 <            shouldThrow();
441 <        } catch (NullPointerException success) {
442 <        } finally {
544 <            latch.countDown();
545 <            joinPool(e);
439 >            try {
440 >                e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
441 >                shouldThrow();
442 >            } catch (NullPointerException success) {}
443          }
444      }
445  
# Line 550 | Line 447 | public class AbstractExecutorServiceTest
447       * timed invokeAny(c) throws ExecutionException if no task completes
448       */
449      public void testTimedInvokeAny4() throws Exception {
450 <        ExecutorService e = new DirectExecutorService();
451 <        try {
452 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
450 >        final ExecutorService e = new DirectExecutorService();
451 >        try (PoolCleaner cleaner = cleaner(e)) {
452 >            long startTime = System.nanoTime();
453 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
454              l.add(new NPETask());
455 <            e.invokeAny(l, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
456 <            shouldThrow();
457 <        } catch (ExecutionException success) {
458 <            assertTrue(success.getCause() instanceof NullPointerException);
459 <        } finally {
460 <            joinPool(e);
455 >            try {
456 >                e.invokeAny(l, LONG_DELAY_MS, MILLISECONDS);
457 >                shouldThrow();
458 >            } catch (ExecutionException success) {
459 >                assertTrue(success.getCause() instanceof NullPointerException);
460 >            }
461 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
462          }
463      }
464  
# Line 567 | Line 466 | public class AbstractExecutorServiceTest
466       * timed invokeAny(c) returns result of some task in c
467       */
468      public void testTimedInvokeAny5() throws Exception {
469 <        ExecutorService e = new DirectExecutorService();
470 <        try {
471 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
469 >        final ExecutorService e = new DirectExecutorService();
470 >        try (PoolCleaner cleaner = cleaner(e)) {
471 >            long startTime = System.nanoTime();
472 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
473              l.add(new StringTask());
474              l.add(new StringTask());
475 <            String result = e.invokeAny(l, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
475 >            String result = e.invokeAny(l, LONG_DELAY_MS, MILLISECONDS);
476              assertSame(TEST_STRING, result);
477 <        } finally {
578 <            joinPool(e);
477 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
478          }
479      }
480  
# Line 583 | Line 482 | public class AbstractExecutorServiceTest
482       * timed invokeAll(null) throws NPE
483       */
484      public void testTimedInvokeAll1() throws InterruptedException {
485 <        ExecutorService e = new DirectExecutorService();
486 <        try {
487 <            e.invokeAll(null, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
488 <            shouldThrow();
489 <        } catch (NullPointerException success) {
490 <        } finally {
592 <            joinPool(e);
485 >        final ExecutorService e = new DirectExecutorService();
486 >        try (PoolCleaner cleaner = cleaner(e)) {
487 >            try {
488 >                e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
489 >                shouldThrow();
490 >            } catch (NullPointerException success) {}
491          }
492      }
493  
# Line 597 | Line 495 | public class AbstractExecutorServiceTest
495       * timed invokeAll(null time unit) throws NPE
496       */
497      public void testTimedInvokeAllNullTimeUnit() throws InterruptedException {
498 <        ExecutorService e = new DirectExecutorService();
499 <        try {
500 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
498 >        final ExecutorService e = new DirectExecutorService();
499 >        try (PoolCleaner cleaner = cleaner(e)) {
500 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
501              l.add(new StringTask());
502 <            e.invokeAll(l, MEDIUM_DELAY_MS, null);
503 <            shouldThrow();
504 <        } catch (NullPointerException success) {
505 <        } finally {
608 <            joinPool(e);
502 >            try {
503 >                e.invokeAll(l, MEDIUM_DELAY_MS, null);
504 >                shouldThrow();
505 >            } catch (NullPointerException success) {}
506          }
507      }
508  
# Line 613 | Line 510 | public class AbstractExecutorServiceTest
510       * timed invokeAll(empty collection) returns empty collection
511       */
512      public void testTimedInvokeAll2() throws InterruptedException {
513 <        ExecutorService e = new DirectExecutorService();
514 <        try {
515 <            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
513 >        final ExecutorService e = new DirectExecutorService();
514 >        try (PoolCleaner cleaner = cleaner(e)) {
515 >            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
516              assertTrue(r.isEmpty());
620        } finally {
621            joinPool(e);
517          }
518      }
519  
# Line 626 | Line 521 | public class AbstractExecutorServiceTest
521       * timed invokeAll(c) throws NPE if c has null elements
522       */
523      public void testTimedInvokeAll3() throws InterruptedException {
524 <        ExecutorService e = new DirectExecutorService();
525 <        try {
526 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
524 >        final ExecutorService e = new DirectExecutorService();
525 >        try (PoolCleaner cleaner = cleaner(e)) {
526 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
527              l.add(new StringTask());
528              l.add(null);
529 <            e.invokeAll(l, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
530 <            shouldThrow();
531 <        } catch (NullPointerException success) {
532 <        } finally {
638 <            joinPool(e);
529 >            try {
530 >                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
531 >                shouldThrow();
532 >            } catch (NullPointerException success) {}
533          }
534      }
535  
# Line 643 | Line 537 | public class AbstractExecutorServiceTest
537       * get of returned element of invokeAll(c) throws exception on failed task
538       */
539      public void testTimedInvokeAll4() throws Exception {
540 <        ExecutorService e = new DirectExecutorService();
541 <        try {
542 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
540 >        final ExecutorService e = new DirectExecutorService();
541 >        try (PoolCleaner cleaner = cleaner(e)) {
542 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
543              l.add(new NPETask());
544 <            List<Future<String>> result = e.invokeAll(l, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
545 <            assertEquals(1, result.size());
546 <            for (Future<String> future : result) {
547 <                try {
548 <                    future.get();
549 <                } catch (ExecutionException success) {
550 <                    assertTrue(success.getCause() instanceof NullPointerException);
551 <                }
544 >            List<Future<String>> futures =
545 >                e.invokeAll(l, LONG_DELAY_MS, MILLISECONDS);
546 >            assertEquals(1, futures.size());
547 >            try {
548 >                futures.get(0).get();
549 >                shouldThrow();
550 >            } catch (ExecutionException success) {
551 >                assertTrue(success.getCause() instanceof NullPointerException);
552              }
659        } finally {
660            joinPool(e);
553          }
554      }
555  
# Line 665 | Line 557 | public class AbstractExecutorServiceTest
557       * timed invokeAll(c) returns results of all completed tasks in c
558       */
559      public void testTimedInvokeAll5() throws Exception {
560 <        ExecutorService e = new DirectExecutorService();
561 <        try {
562 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
560 >        final ExecutorService e = new DirectExecutorService();
561 >        try (PoolCleaner cleaner = cleaner(e)) {
562 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
563              l.add(new StringTask());
564              l.add(new StringTask());
565 <            List<Future<String>> result = e.invokeAll(l, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
566 <            assertEquals(2, result.size());
567 <            for (Future<String> future : result)
565 >            List<Future<String>> futures =
566 >                e.invokeAll(l, LONG_DELAY_MS, MILLISECONDS);
567 >            assertEquals(2, futures.size());
568 >            for (Future<String> future : futures)
569                  assertSame(TEST_STRING, future.get());
677        } finally {
678            joinPool(e);
570          }
571      }
572  
573      /**
574       * timed invokeAll cancels tasks not completed by timeout
575       */
576 <    public void testTimedInvokeAll6() throws InterruptedException {
577 <        ExecutorService e = new DirectExecutorService();
578 <        try {
579 <            ArrayList<Callable<String>> l = new ArrayList<Callable<String>>();
580 <            l.add(new StringTask());
581 <            l.add(Executors.callable(new MediumPossiblyInterruptedRunnable(), TEST_STRING));
582 <            l.add(new StringTask());
583 <            List<Future<String>> result = e.invokeAll(l, SMALL_DELAY_MS, TimeUnit.MILLISECONDS);
584 <            assertEquals(3, result.size());
585 <            Iterator<Future<String>> it = result.iterator();
586 <            Future<String> f1 = it.next();
587 <            Future<String> f2 = it.next();
588 <            Future<String> f3 = it.next();
589 <            assertTrue(f1.isDone());
590 <            assertFalse(f1.isCancelled());
591 <            assertTrue(f2.isDone());
592 <            assertTrue(f3.isDone());
593 <            assertTrue(f3.isCancelled());
594 <        } finally {
595 <            joinPool(e);
576 >    public void testTimedInvokeAll6() throws Exception {
577 >        final ExecutorService e = new DirectExecutorService();
578 >        try (PoolCleaner cleaner = cleaner(e)) {
579 >            for (long timeout = timeoutMillis();;) {
580 >                List<Callable<String>> tasks = new ArrayList<>();
581 >                tasks.add(new StringTask("0"));
582 >                tasks.add(Executors.callable(possiblyInterruptedRunnable(timeout),
583 >                                             TEST_STRING));
584 >                tasks.add(new StringTask("2"));
585 >                long startTime = System.nanoTime();
586 >                List<Future<String>> futures =
587 >                    e.invokeAll(tasks, timeout, MILLISECONDS);
588 >                assertEquals(tasks.size(), futures.size());
589 >                assertTrue(millisElapsedSince(startTime) >= timeout);
590 >                for (Future future : futures)
591 >                    assertTrue(future.isDone());
592 >                try {
593 >                    assertEquals("0", futures.get(0).get());
594 >                    assertEquals(TEST_STRING, futures.get(1).get());
595 >                } catch (CancellationException retryWithLongerTimeout) {
596 >                    // unusual delay before starting second task
597 >                    timeout *= 2;
598 >                    if (timeout >= LONG_DELAY_MS / 2)
599 >                        fail("expected exactly one task to be cancelled");
600 >                    continue;
601 >                }
602 >                assertTrue(futures.get(2).isCancelled());
603 >                break;
604 >            }
605          }
606      }
607  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines