[ViewVC] Diff of: jsr166/jsr166/src/test/tck/AbstractQueuedLongSynchronizerTest.java

Comparing jsr166/src/test/tck/AbstractQueuedLongSynchronizerTest.java (file contents):
Revision 1.42 by jsr166, Fri Sep 29 19:34:37 2017 UTC vs.
Revision 1.53 by jsr166, Fri Aug 16 02:32:26 2019 UTC

+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
-+
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.locks.AbstractQueuedLongSynchronizer;
+import java.util.concurrent.locks.AbstractQueuedLongSynchronizer.ConditionObject;
-–
+import junit.framework.AssertionFailedError;
+import junit.framework.Test;
+import junit.framework.TestSuite;
+        long startTime = System.nanoTime();
+        while (!sync.isQueued(t)) {
+            if (millisElapsedSince(startTime) > LONG_DELAY_MS)
-<
+                throw new AssertionFailedError("timed out");
->
+                throw new AssertionError("timed out");
+            Thread.yield();
+        assertTrue(t.isAlive());
+            assertTrue(c.await(timeoutMillis, MILLISECONDS));
+            break;
+        case awaitNanos:
-<
+            long nanosTimeout = MILLISECONDS.toNanos(timeoutMillis);
-<
+            long nanosRemaining = c.awaitNanos(nanosTimeout);
->
+            long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis);
->
+            long nanosRemaining = c.awaitNanos(timeoutNanos);
+            assertTrue(nanosRemaining > 0);
+            break;
+        case awaitUntil:
+                break;
+            case awaitNanos:
+                startTime = System.nanoTime();
-<
+                long nanosTimeout = MILLISECONDS.toNanos(timeoutMillis);
-<
+                long nanosRemaining = c.awaitNanos(nanosTimeout);
->
+                long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis);
->
+                long nanosRemaining = c.awaitNanos(timeoutNanos);
+                assertTrue(nanosRemaining <= 0);
+                assertTrue(nanosRemaining > -MILLISECONDS.toNanos(LONG_DELAY_MS));
+                assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
+        sync.release();
-+
+    /**
-+
+     * Tests scenario for
-+
+     * JDK-8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire methods throw
-+
+     * ant -Djsr166.tckTestClass=AbstractQueuedLongSynchronizerTest -Djsr166.methodFilter=testInterruptedFailingAcquire -Djsr166.runsPerTest=10000 tck
-+
+     */
-+
+    public void testInterruptedFailingAcquire() throws Throwable {
-+
+        class PleaseThrow extends RuntimeException {}
-+
+        final PleaseThrow ex = new PleaseThrow();
-+
+        final AtomicBoolean thrown = new AtomicBoolean();
-+
-+
+        // A synchronizer only offering a choice of failure modes
-+
+        class Sync extends AbstractQueuedLongSynchronizer {
-+
+            volatile boolean pleaseThrow;
-+
+            void maybeThrow() {
-+
+                if (pleaseThrow) {
-+
+                    // assert: tryAcquire methods can throw at most once
-+
+                    if (! thrown.compareAndSet(false, true))
-+
+                        throw new AssertionError();
-+
+                    throw ex;
-+
+                }
-+
+            }
-+
-+
+            @Override protected boolean tryAcquire(long ignored) {
-+
+                maybeThrow();
-+
+                return false;
-+
+            }
-+
+            @Override protected long tryAcquireShared(long ignored) {
-+
+                maybeThrow();
-+
+                return -1;
-+
+            }
-+
+            @Override protected boolean tryRelease(long ignored) {
-+
+                return true;
-+
+            }
-+
+            @Override protected boolean tryReleaseShared(long ignored) {
-+
+                return true;
-+
+            }
-+
+        }
-+
-+
+        final Sync s = new Sync();
-+
+        final boolean acquireInterruptibly = randomBoolean();
-+
+        final Action[] uninterruptibleAcquireActions = {
-+
+            () -> s.acquire(1),
-+
+            () -> s.acquireShared(1),
-+
+        };
-+
+        final long nanosTimeout = MILLISECONDS.toNanos(2 * LONG_DELAY_MS);
-+
+        final Action[] interruptibleAcquireActions = {
-+
+            () -> s.acquireInterruptibly(1),
-+
+            () -> s.acquireSharedInterruptibly(1),
-+
+            () -> s.tryAcquireNanos(1, nanosTimeout),
-+
+            () -> s.tryAcquireSharedNanos(1, nanosTimeout),
-+
+        };
-+
+        final Action[] releaseActions = {
-+
+            () -> s.release(1),
-+
+            () -> s.releaseShared(1),
-+
+        };
-+
+        final Action acquireAction = acquireInterruptibly
-+
+            ? chooseRandomly(interruptibleAcquireActions)
-+
+            : chooseRandomly(uninterruptibleAcquireActions);
-+
+        final Action releaseAction
-+
+            = chooseRandomly(releaseActions);
-+
-+
+        // From os_posix.cpp:
-+
+        //
-+
+        // NOTE that since there is no "lock" around the interrupt and
-+
+        // is_interrupted operations, there is the possibility that the
-+
+        // interrupted flag (in osThread) will be "false" but that the
-+
+        // low-level events will be in the signaled state. This is
-+
+        // intentional. The effect of this is that Object.wait() and
-+
+        // LockSupport.park() will appear to have a spurious wakeup, which
-+
+        // is allowed and not harmful, and the possibility is so rare that
-+
+        // it is not worth the added complexity to add yet another lock.
-+
+        final Thread thread = newStartedThread(new CheckedRunnable() {
-+
+            public void realRun() throws Throwable {
-+
+                try {
-+
+                    acquireAction.run();
-+
+                    shouldThrow();
-+
+                } catch (InterruptedException possible) {
-+
+                    assertTrue(acquireInterruptibly);
-+
+                    assertFalse(Thread.interrupted());
-+
+                } catch (PleaseThrow possible) {
-+
+                    awaitInterrupted();
-+
+                }
-+
+            }});
-+
+        for (long startTime = 0L;; ) {
-+
+            waitForThreadToEnterWaitState(thread);
-+
+            if (s.getFirstQueuedThread() == thread
-+
+                && s.hasQueuedPredecessors()
-+
+                && s.hasQueuedThreads()
-+
+                && s.getQueueLength() == 1
-+
+                && s.hasContended())
-+
+                break;
-+
+            if (startTime == 0L)
-+
+                startTime = System.nanoTime();
-+
+            else if (millisElapsedSince(startTime) > LONG_DELAY_MS)
-+
+                fail("timed out waiting for AQS state: "
-+
+                     + "thread state=" + thread.getState()
-+
+                     + ", queued threads=" + s.getQueuedThreads());
-+
+            Thread.yield();
-+
+        }
-+
-+
+        s.pleaseThrow = true;
-+
+        // release and interrupt, in random order
-+
+        if (randomBoolean()) {
-+
+            thread.interrupt();
-+
+            releaseAction.run();
-+
+        } else {
-+
+            releaseAction.run();
-+
+            thread.interrupt();
-+
+        }
-+
+        awaitTermination(thread);
-+
-+
+        if (! acquireInterruptibly)
-+
+            assertTrue(thrown.get());
-+
-+
+        assertNull(s.getFirstQueuedThread());
-+
+        assertFalse(s.hasQueuedPredecessors());
-+
+        assertFalse(s.hasQueuedThreads());
-+
+        assertEquals(0, s.getQueueLength());
-+
+        assertTrue(s.getQueuedThreads().isEmpty());
-+
+        assertTrue(s.hasContended());
-+
+    }
-+

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing jsr166/src/test/tck/AbstractQueuedLongSynchronizerTest.java (file contents): Revision 1.42 by jsr166, Fri Sep 29 19:34:37 2017 UTC vs. Revision 1.53 by jsr166, Fri Aug 16 02:32:26 2019 UTC

Diff Legend

Comparing jsr166/src/test/tck/AbstractQueuedLongSynchronizerTest.java (file contents):
Revision 1.42 by jsr166, Fri Sep 29 19:34:37 2017 UTC vs.
Revision 1.53 by jsr166, Fri Aug 16 02:32:26 2019 UTC