12 |
|
import java.util.Arrays; |
13 |
|
import java.util.Collection; |
14 |
|
import java.util.HashSet; |
15 |
– |
import java.util.concurrent.ThreadLocalRandom; |
15 |
|
import java.util.concurrent.locks.AbstractQueuedLongSynchronizer; |
16 |
|
import java.util.concurrent.locks.AbstractQueuedLongSynchronizer.ConditionObject; |
17 |
|
|
19 |
– |
import junit.framework.AssertionFailedError; |
18 |
|
import junit.framework.Test; |
19 |
|
import junit.framework.TestSuite; |
20 |
|
|
139 |
|
long startTime = System.nanoTime(); |
140 |
|
while (!sync.isQueued(t)) { |
141 |
|
if (millisElapsedSince(startTime) > LONG_DELAY_MS) |
142 |
< |
throw new AssertionFailedError("timed out"); |
142 |
> |
throw new AssertionError("timed out"); |
143 |
|
Thread.yield(); |
144 |
|
} |
145 |
|
assertTrue(t.isAlive()); |
223 |
|
assertTrue(c.await(timeoutMillis, MILLISECONDS)); |
224 |
|
break; |
225 |
|
case awaitNanos: |
226 |
< |
long nanosTimeout = MILLISECONDS.toNanos(timeoutMillis); |
227 |
< |
long nanosRemaining = c.awaitNanos(nanosTimeout); |
226 |
> |
long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
227 |
> |
long nanosRemaining = c.awaitNanos(timeoutNanos); |
228 |
|
assertTrue(nanosRemaining > 0); |
229 |
|
break; |
230 |
|
case awaitUntil: |
251 |
|
break; |
252 |
|
case awaitNanos: |
253 |
|
startTime = System.nanoTime(); |
254 |
< |
long nanosTimeout = MILLISECONDS.toNanos(timeoutMillis); |
255 |
< |
long nanosRemaining = c.awaitNanos(nanosTimeout); |
254 |
> |
long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
255 |
> |
long nanosRemaining = c.awaitNanos(timeoutNanos); |
256 |
|
assertTrue(nanosRemaining <= 0); |
257 |
|
assertTrue(nanosRemaining > -MILLISECONDS.toNanos(LONG_DELAY_MS)); |
258 |
|
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
1258 |
|
/** |
1259 |
|
* Tests scenario for |
1260 |
|
* JDK-8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire methods throw |
1261 |
+ |
* ant -Djsr166.tckTestClass=AbstractQueuedLongSynchronizerTest -Djsr166.methodFilter=testInterruptedFailingAcquire -Djsr166.runsPerTest=10000 tck |
1262 |
|
*/ |
1263 |
< |
public void testInterruptedFailingAcquire() throws InterruptedException { |
1264 |
< |
final RuntimeException ex = new RuntimeException(); |
1263 |
> |
public void testInterruptedFailingAcquire() throws Throwable { |
1264 |
> |
class PleaseThrow extends RuntimeException {} |
1265 |
> |
final PleaseThrow ex = new PleaseThrow(); |
1266 |
|
|
1267 |
|
// A synchronizer only offering a choice of failure modes |
1268 |
|
class Sync extends AbstractQueuedLongSynchronizer { |
1269 |
< |
boolean pleaseThrow; |
1269 |
> |
volatile boolean pleaseThrow; |
1270 |
|
@Override protected boolean tryAcquire(long ignored) { |
1271 |
|
if (pleaseThrow) throw ex; |
1272 |
|
return false; |
1284 |
|
} |
1285 |
|
|
1286 |
|
final Sync s = new Sync(); |
1287 |
< |
|
1287 |
> |
final boolean acquireInterruptibly = randomBoolean(); |
1288 |
> |
final Action[] uninterruptibleAcquireActions = { |
1289 |
> |
() -> s.acquire(1), |
1290 |
> |
() -> s.acquireShared(1), |
1291 |
> |
}; |
1292 |
> |
final long nanosTimeout = MILLISECONDS.toNanos(2 * LONG_DELAY_MS); |
1293 |
> |
final Action[] interruptibleAcquireActions = { |
1294 |
> |
() -> s.acquireInterruptibly(1), |
1295 |
> |
() -> s.acquireSharedInterruptibly(1), |
1296 |
> |
() -> s.tryAcquireNanos(1, nanosTimeout), |
1297 |
> |
() -> s.tryAcquireSharedNanos(1, nanosTimeout), |
1298 |
> |
}; |
1299 |
> |
final Action[] releaseActions = { |
1300 |
> |
() -> s.release(1), |
1301 |
> |
() -> s.releaseShared(1), |
1302 |
> |
}; |
1303 |
> |
final Action acquireAction = acquireInterruptibly |
1304 |
> |
? chooseRandomly(interruptibleAcquireActions) |
1305 |
> |
: chooseRandomly(uninterruptibleAcquireActions); |
1306 |
> |
final Action releaseAction |
1307 |
> |
= chooseRandomly(releaseActions); |
1308 |
> |
|
1309 |
> |
// From os_posix.cpp: |
1310 |
> |
// |
1311 |
> |
// NOTE that since there is no "lock" around the interrupt and |
1312 |
> |
// is_interrupted operations, there is the possibility that the |
1313 |
> |
// interrupted flag (in osThread) will be "false" but that the |
1314 |
> |
// low-level events will be in the signaled state. This is |
1315 |
> |
// intentional. The effect of this is that Object.wait() and |
1316 |
> |
// LockSupport.park() will appear to have a spurious wakeup, which |
1317 |
> |
// is allowed and not harmful, and the possibility is so rare that |
1318 |
> |
// it is not worth the added complexity to add yet another lock. |
1319 |
|
final Thread thread = newStartedThread(new CheckedRunnable() { |
1320 |
< |
public void realRun() { |
1320 |
> |
public void realRun() throws Throwable { |
1321 |
|
try { |
1322 |
< |
if (ThreadLocalRandom.current().nextBoolean()) |
1292 |
< |
s.acquire(1); |
1293 |
< |
else |
1294 |
< |
s.acquireShared(1); |
1322 |
> |
acquireAction.run(); |
1323 |
|
shouldThrow(); |
1324 |
< |
} catch (Throwable t) { |
1325 |
< |
assertSame(ex, t); |
1326 |
< |
assertTrue(Thread.interrupted()); |
1324 |
> |
} catch (InterruptedException possible) { |
1325 |
> |
assertTrue(acquireInterruptibly); |
1326 |
> |
assertFalse(Thread.interrupted()); |
1327 |
> |
} catch (PleaseThrow possible) { |
1328 |
> |
awaitInterrupted(); |
1329 |
|
} |
1330 |
|
}}); |
1331 |
< |
waitForThreadToEnterWaitState(thread); |
1332 |
< |
assertSame(thread, s.getFirstQueuedThread()); |
1333 |
< |
assertTrue(s.hasQueuedPredecessors()); |
1334 |
< |
assertTrue(s.hasQueuedThreads()); |
1335 |
< |
assertEquals(1, s.getQueueLength()); |
1331 |
> |
for (long startTime = 0L;; ) { |
1332 |
> |
waitForThreadToEnterWaitState(thread); |
1333 |
> |
if (s.getFirstQueuedThread() == thread |
1334 |
> |
&& s.hasQueuedPredecessors() |
1335 |
> |
&& s.hasQueuedThreads() |
1336 |
> |
&& s.getQueueLength() == 1 |
1337 |
> |
&& s.hasContended()) |
1338 |
> |
break; |
1339 |
> |
if (startTime == 0L) |
1340 |
> |
startTime = System.nanoTime(); |
1341 |
> |
else if (millisElapsedSince(startTime) > LONG_DELAY_MS) |
1342 |
> |
fail("timed out waiting for AQS state: " |
1343 |
> |
+ "thread state=" + thread.getState() |
1344 |
> |
+ ", queued threads=" + s.getQueuedThreads()); |
1345 |
> |
Thread.yield(); |
1346 |
> |
} |
1347 |
|
|
1348 |
|
s.pleaseThrow = true; |
1349 |
< |
thread.interrupt(); |
1350 |
< |
s.release(1); |
1349 |
> |
// release and interrupt, in random order |
1350 |
> |
if (randomBoolean()) { |
1351 |
> |
thread.interrupt(); |
1352 |
> |
releaseAction.run(); |
1353 |
> |
} else { |
1354 |
> |
releaseAction.run(); |
1355 |
> |
thread.interrupt(); |
1356 |
> |
} |
1357 |
|
awaitTermination(thread); |
1358 |
+ |
|
1359 |
+ |
assertNull(s.getFirstQueuedThread()); |
1360 |
+ |
assertFalse(s.hasQueuedPredecessors()); |
1361 |
+ |
assertFalse(s.hasQueuedThreads()); |
1362 |
+ |
assertEquals(0, s.getQueueLength()); |
1363 |
+ |
assertTrue(s.getQueuedThreads().isEmpty()); |
1364 |
+ |
assertTrue(s.hasContended()); |
1365 |
|
} |
1366 |
|
|
1367 |
|
} |