12 |
|
import java.util.Arrays; |
13 |
|
import java.util.Collection; |
14 |
|
import java.util.HashSet; |
15 |
+ |
import java.util.concurrent.atomic.AtomicBoolean; |
16 |
|
import java.util.concurrent.locks.AbstractQueuedLongSynchronizer; |
17 |
|
import java.util.concurrent.locks.AbstractQueuedLongSynchronizer.ConditionObject; |
18 |
|
|
18 |
– |
import junit.framework.AssertionFailedError; |
19 |
|
import junit.framework.Test; |
20 |
|
import junit.framework.TestSuite; |
21 |
|
|
22 |
+ |
@SuppressWarnings("WaitNotInLoop") // we implement spurious-wakeup freedom |
23 |
|
public class AbstractQueuedLongSynchronizerTest extends JSR166TestCase { |
24 |
|
public static void main(String[] args) { |
25 |
|
main(suite(), args); |
31 |
|
/** |
32 |
|
* A simple mutex class, adapted from the class javadoc. Exclusive |
33 |
|
* acquire tests exercise this as a sample user extension. |
34 |
+ |
* |
35 |
+ |
* Unlike the javadoc sample, we don't track owner thread via |
36 |
+ |
* AbstractOwnableSynchronizer methods. |
37 |
|
*/ |
38 |
|
static class Mutex extends AbstractQueuedLongSynchronizer { |
39 |
|
/** An eccentric value > 32 bits for locked synchronizer state. */ |
41 |
|
|
42 |
|
static final long UNLOCKED = 0; |
43 |
|
|
44 |
< |
public boolean isHeldExclusively() { |
44 |
> |
/** Owner thread is untracked, so this is really just isLocked(). */ |
45 |
> |
@Override public boolean isHeldExclusively() { |
46 |
|
long state = getState(); |
47 |
|
assertTrue(state == UNLOCKED || state == LOCKED); |
48 |
|
return state == LOCKED; |
49 |
|
} |
50 |
|
|
51 |
< |
public boolean tryAcquire(long acquires) { |
51 |
> |
@Override protected boolean tryAcquire(long acquires) { |
52 |
|
assertEquals(LOCKED, acquires); |
53 |
|
return compareAndSetState(UNLOCKED, LOCKED); |
54 |
|
} |
55 |
|
|
56 |
< |
public boolean tryRelease(long releases) { |
56 |
> |
@Override protected boolean tryRelease(long releases) { |
57 |
|
if (getState() != LOCKED) throw new IllegalMonitorStateException(); |
58 |
|
setState(UNLOCKED); |
59 |
|
return true; |
83 |
|
release(LOCKED); |
84 |
|
} |
85 |
|
|
86 |
+ |
/** Faux-Implements Lock.newCondition(). */ |
87 |
|
public ConditionObject newCondition() { |
88 |
|
return new ConditionObject(); |
89 |
|
} |
90 |
|
} |
91 |
|
|
92 |
|
/** |
93 |
< |
* A simple latch class, to test shared mode. |
93 |
> |
* A minimal latch class, to test shared mode. |
94 |
|
*/ |
95 |
|
static class BooleanLatch extends AbstractQueuedLongSynchronizer { |
96 |
|
public boolean isSignalled() { return getState() != 0; } |
140 |
|
long startTime = System.nanoTime(); |
141 |
|
while (!sync.isQueued(t)) { |
142 |
|
if (millisElapsedSince(startTime) > LONG_DELAY_MS) |
143 |
< |
throw new AssertionFailedError("timed out"); |
143 |
> |
throw new AssertionError("timed out"); |
144 |
|
Thread.yield(); |
145 |
|
} |
146 |
|
assertTrue(t.isAlive()); |
224 |
|
assertTrue(c.await(timeoutMillis, MILLISECONDS)); |
225 |
|
break; |
226 |
|
case awaitNanos: |
227 |
< |
long nanosTimeout = MILLISECONDS.toNanos(timeoutMillis); |
228 |
< |
long nanosRemaining = c.awaitNanos(nanosTimeout); |
227 |
> |
long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
228 |
> |
long nanosRemaining = c.awaitNanos(timeoutNanos); |
229 |
|
assertTrue(nanosRemaining > 0); |
230 |
|
break; |
231 |
|
case awaitUntil: |
252 |
|
break; |
253 |
|
case awaitNanos: |
254 |
|
startTime = System.nanoTime(); |
255 |
< |
long nanosTimeout = MILLISECONDS.toNanos(timeoutMillis); |
256 |
< |
long nanosRemaining = c.awaitNanos(nanosTimeout); |
255 |
> |
long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
256 |
> |
long nanosRemaining = c.awaitNanos(timeoutNanos); |
257 |
|
assertTrue(nanosRemaining <= 0); |
258 |
|
assertTrue(nanosRemaining > -MILLISECONDS.toNanos(LONG_DELAY_MS)); |
259 |
|
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
1162 |
|
|
1163 |
|
waitForQueuedThread(l, t); |
1164 |
|
assertFalse(l.isSignalled()); |
1165 |
< |
assertThreadStaysAlive(t); |
1165 |
> |
assertThreadBlocks(t, Thread.State.TIMED_WAITING); |
1166 |
|
assertTrue(l.releaseShared(0)); |
1167 |
|
assertTrue(l.isSignalled()); |
1168 |
|
awaitTermination(t); |
1256 |
|
sync.release(); |
1257 |
|
} |
1258 |
|
|
1259 |
+ |
/** |
1260 |
+ |
* Tests scenario for |
1261 |
+ |
* JDK-8191937: Lost interrupt in AbstractQueuedSynchronizer when tryAcquire methods throw |
1262 |
+ |
* ant -Djsr166.tckTestClass=AbstractQueuedLongSynchronizerTest -Djsr166.methodFilter=testInterruptedFailingAcquire -Djsr166.runsPerTest=10000 tck |
1263 |
+ |
*/ |
1264 |
+ |
public void testInterruptedFailingAcquire() throws Throwable { |
1265 |
+ |
class PleaseThrow extends RuntimeException {} |
1266 |
+ |
final PleaseThrow ex = new PleaseThrow(); |
1267 |
+ |
final AtomicBoolean thrown = new AtomicBoolean(); |
1268 |
+ |
|
1269 |
+ |
// A synchronizer only offering a choice of failure modes |
1270 |
+ |
class Sync extends AbstractQueuedLongSynchronizer { |
1271 |
+ |
volatile boolean pleaseThrow; |
1272 |
+ |
void maybeThrow() { |
1273 |
+ |
if (pleaseThrow) { |
1274 |
+ |
// assert: tryAcquire methods can throw at most once |
1275 |
+ |
if (! thrown.compareAndSet(false, true)) |
1276 |
+ |
throw new AssertionError(); |
1277 |
+ |
throw ex; |
1278 |
+ |
} |
1279 |
+ |
} |
1280 |
+ |
|
1281 |
+ |
@Override protected boolean tryAcquire(long ignored) { |
1282 |
+ |
maybeThrow(); |
1283 |
+ |
return false; |
1284 |
+ |
} |
1285 |
+ |
@Override protected long tryAcquireShared(long ignored) { |
1286 |
+ |
maybeThrow(); |
1287 |
+ |
return -1; |
1288 |
+ |
} |
1289 |
+ |
@Override protected boolean tryRelease(long ignored) { |
1290 |
+ |
return true; |
1291 |
+ |
} |
1292 |
+ |
@Override protected boolean tryReleaseShared(long ignored) { |
1293 |
+ |
return true; |
1294 |
+ |
} |
1295 |
+ |
} |
1296 |
+ |
|
1297 |
+ |
final Sync s = new Sync(); |
1298 |
+ |
final boolean acquireInterruptibly = randomBoolean(); |
1299 |
+ |
final Action[] uninterruptibleAcquireActions = { |
1300 |
+ |
() -> s.acquire(1), |
1301 |
+ |
() -> s.acquireShared(1), |
1302 |
+ |
}; |
1303 |
+ |
final long nanosTimeout = MILLISECONDS.toNanos(2 * LONG_DELAY_MS); |
1304 |
+ |
final Action[] interruptibleAcquireActions = { |
1305 |
+ |
() -> s.acquireInterruptibly(1), |
1306 |
+ |
() -> s.acquireSharedInterruptibly(1), |
1307 |
+ |
() -> s.tryAcquireNanos(1, nanosTimeout), |
1308 |
+ |
() -> s.tryAcquireSharedNanos(1, nanosTimeout), |
1309 |
+ |
}; |
1310 |
+ |
final Action[] releaseActions = { |
1311 |
+ |
() -> s.release(1), |
1312 |
+ |
() -> s.releaseShared(1), |
1313 |
+ |
}; |
1314 |
+ |
final Action acquireAction = acquireInterruptibly |
1315 |
+ |
? chooseRandomly(interruptibleAcquireActions) |
1316 |
+ |
: chooseRandomly(uninterruptibleAcquireActions); |
1317 |
+ |
final Action releaseAction |
1318 |
+ |
= chooseRandomly(releaseActions); |
1319 |
+ |
|
1320 |
+ |
// From os_posix.cpp: |
1321 |
+ |
// |
1322 |
+ |
// NOTE that since there is no "lock" around the interrupt and |
1323 |
+ |
// is_interrupted operations, there is the possibility that the |
1324 |
+ |
// interrupted flag (in osThread) will be "false" but that the |
1325 |
+ |
// low-level events will be in the signaled state. This is |
1326 |
+ |
// intentional. The effect of this is that Object.wait() and |
1327 |
+ |
// LockSupport.park() will appear to have a spurious wakeup, which |
1328 |
+ |
// is allowed and not harmful, and the possibility is so rare that |
1329 |
+ |
// it is not worth the added complexity to add yet another lock. |
1330 |
+ |
final Thread thread = newStartedThread(new CheckedRunnable() { |
1331 |
+ |
public void realRun() throws Throwable { |
1332 |
+ |
try { |
1333 |
+ |
acquireAction.run(); |
1334 |
+ |
shouldThrow(); |
1335 |
+ |
} catch (InterruptedException possible) { |
1336 |
+ |
assertTrue(acquireInterruptibly); |
1337 |
+ |
assertFalse(Thread.interrupted()); |
1338 |
+ |
} catch (PleaseThrow possible) { |
1339 |
+ |
awaitInterrupted(); |
1340 |
+ |
} |
1341 |
+ |
}}); |
1342 |
+ |
for (long startTime = 0L;; ) { |
1343 |
+ |
waitForThreadToEnterWaitState(thread); |
1344 |
+ |
if (s.getFirstQueuedThread() == thread |
1345 |
+ |
&& s.hasQueuedPredecessors() |
1346 |
+ |
&& s.hasQueuedThreads() |
1347 |
+ |
&& s.getQueueLength() == 1 |
1348 |
+ |
&& s.hasContended()) |
1349 |
+ |
break; |
1350 |
+ |
if (startTime == 0L) |
1351 |
+ |
startTime = System.nanoTime(); |
1352 |
+ |
else if (millisElapsedSince(startTime) > LONG_DELAY_MS) |
1353 |
+ |
fail("timed out waiting for AQS state: " |
1354 |
+ |
+ "thread state=" + thread.getState() |
1355 |
+ |
+ ", queued threads=" + s.getQueuedThreads()); |
1356 |
+ |
Thread.yield(); |
1357 |
+ |
} |
1358 |
+ |
|
1359 |
+ |
s.pleaseThrow = true; |
1360 |
+ |
// release and interrupt, in random order |
1361 |
+ |
if (randomBoolean()) { |
1362 |
+ |
thread.interrupt(); |
1363 |
+ |
releaseAction.run(); |
1364 |
+ |
} else { |
1365 |
+ |
releaseAction.run(); |
1366 |
+ |
thread.interrupt(); |
1367 |
+ |
} |
1368 |
+ |
awaitTermination(thread); |
1369 |
+ |
|
1370 |
+ |
if (! acquireInterruptibly) |
1371 |
+ |
assertTrue(thrown.get()); |
1372 |
+ |
|
1373 |
+ |
assertNull(s.getFirstQueuedThread()); |
1374 |
+ |
assertFalse(s.hasQueuedPredecessors()); |
1375 |
+ |
assertFalse(s.hasQueuedThreads()); |
1376 |
+ |
assertEquals(0, s.getQueueLength()); |
1377 |
+ |
assertTrue(s.getQueuedThreads().isEmpty()); |
1378 |
+ |
assertTrue(s.hasContended()); |
1379 |
+ |
} |
1380 |
+ |
|
1381 |
|
} |