ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ArrayBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ArrayBlockingQueueTest.java (file contents):
Revision 1.80 by jsr166, Sun Nov 6 04:16:52 2016 UTC vs.
Revision 1.93 by jsr166, Sun Aug 11 22:29:26 2019 UTC

# Line 103 | Line 103 | public class ArrayBlockingQueueTest exte
103      }
104  
105      /**
106 <     * Constructor throws IAE if capacity argument nonpositive
106 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
107       */
108      public void testConstructor_nonPositiveCapacity() {
109          for (int i : new int[] { 0, -1, Integer.MIN_VALUE }) {
# Line 156 | Line 156 | public class ArrayBlockingQueueTest exte
156      }
157  
158      /**
159 <     * Initializing from too large collection throws IAE
159 >     * Initializing from too large collection throws IllegalArgumentException
160       */
161      public void testConstructor_collectionTooLarge() {
162          // just barely fits - succeeds
# Line 227 | Line 227 | public class ArrayBlockingQueueTest exte
227      }
228  
229      /**
230 <     * add succeeds if not full; throws ISE if full
230 >     * add succeeds if not full; throws IllegalStateException if full
231       */
232      public void testAdd() {
233          ArrayBlockingQueue q = new ArrayBlockingQueue(SIZE);
# Line 240 | Line 240 | public class ArrayBlockingQueueTest exte
240      }
241  
242      /**
243 <     * addAll(this) throws IAE
243 >     * addAll(this) throws IllegalArgumentException
244       */
245      public void testAddAllSelf() {
246          ArrayBlockingQueue q = populatedQueue(SIZE);
# Line 266 | Line 266 | public class ArrayBlockingQueueTest exte
266      }
267  
268      /**
269 <     * addAll throws ISE if not enough room
269 >     * addAll throws IllegalStateException if not enough room
270       */
271      public void testAddAll_insufficientSpace() {
272          int size = ThreadLocalRandom.current().nextInt(1, SIZE);
# Line 340 | Line 340 | public class ArrayBlockingQueueTest exte
340              }});
341  
342          await(pleaseInterrupt);
343 <        assertThreadStaysAlive(t);
343 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
344          t.interrupt();
345          awaitTermination(t);
346          assertEquals(SIZE, q.size());
# Line 362 | Line 362 | public class ArrayBlockingQueueTest exte
362                  pleaseTake.countDown();
363                  q.put(86);
364  
365 +                Thread.currentThread().interrupt();
366 +                try {
367 +                    q.put(99);
368 +                    shouldThrow();
369 +                } catch (InterruptedException success) {}
370 +                assertFalse(Thread.interrupted());
371 +
372                  pleaseInterrupt.countDown();
373                  try {
374                      q.put(99);
# Line 375 | Line 382 | public class ArrayBlockingQueueTest exte
382          assertEquals(0, q.take());
383  
384          await(pleaseInterrupt);
385 <        assertThreadStaysAlive(t);
385 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
386          t.interrupt();
387          awaitTermination(t);
388          assertEquals(0, q.remainingCapacity());
# Line 384 | Line 391 | public class ArrayBlockingQueueTest exte
391      /**
392       * timed offer times out if full and elements not taken
393       */
394 <    public void testTimedOffer() throws InterruptedException {
394 >    public void testTimedOffer() {
395          final ArrayBlockingQueue q = new ArrayBlockingQueue(2);
396          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
397          Thread t = newStartedThread(new CheckedRunnable() {
# Line 394 | Line 401 | public class ArrayBlockingQueueTest exte
401                  long startTime = System.nanoTime();
402                  assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
403                  assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
404 +
405 +                Thread.currentThread().interrupt();
406 +                try {
407 +                    q.offer(new Object(), randomTimeout(), randomTimeUnit());
408 +                    shouldThrow();
409 +                } catch (InterruptedException success) {}
410 +                assertFalse(Thread.interrupted());
411 +
412                  pleaseInterrupt.countDown();
413                  try {
414 <                    q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
414 >                    q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
415                      shouldThrow();
416                  } catch (InterruptedException success) {}
417 +                assertFalse(Thread.interrupted());
418 +
419 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
420              }});
421  
422          await(pleaseInterrupt);
423 <        assertThreadStaysAlive(t);
423 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
424          t.interrupt();
425          awaitTermination(t);
426      }
# Line 425 | Line 443 | public class ArrayBlockingQueueTest exte
443          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
444          Thread t = newStartedThread(new CheckedRunnable() {
445              public void realRun() throws InterruptedException {
446 <                for (int i = 0; i < SIZE; ++i) {
429 <                    assertEquals(i, q.take());
430 <                }
446 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
447  
448                  Thread.currentThread().interrupt();
449                  try {
# Line 445 | Line 461 | public class ArrayBlockingQueueTest exte
461              }});
462  
463          await(pleaseInterrupt);
464 <        assertThreadStaysAlive(t);
464 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
465          t.interrupt();
466          awaitTermination(t);
467      }
# Line 495 | Line 511 | public class ArrayBlockingQueueTest exte
511       */
512      public void testInterruptedTimedPoll() throws InterruptedException {
513          final BlockingQueue<Integer> q = populatedQueue(SIZE);
514 <        final CountDownLatch aboutToWait = new CountDownLatch(1);
514 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
515          Thread t = newStartedThread(new CheckedRunnable() {
516              public void realRun() throws InterruptedException {
517                  long startTime = System.nanoTime();
518 <                for (int i = 0; i < SIZE; ++i) {
518 >                for (int i = 0; i < SIZE; i++)
519                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
520 <                }
521 <                aboutToWait.countDown();
520 >
521 >                Thread.currentThread().interrupt();
522 >                try {
523 >                    q.poll(randomTimeout(), randomTimeUnit());
524 >                    shouldThrow();
525 >                } catch (InterruptedException success) {}
526 >                assertFalse(Thread.interrupted());
527 >
528 >                pleaseInterrupt.countDown();
529                  try {
530                      q.poll(LONG_DELAY_MS, MILLISECONDS);
531                      shouldThrow();
532 <                } catch (InterruptedException success) {
533 <                    assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
534 <                }
532 >                } catch (InterruptedException success) {}
533 >                assertFalse(Thread.interrupted());
534 >
535 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
536              }});
537  
538 <        await(aboutToWait);
539 <        waitForThreadToEnterWaitState(t);
538 >        await(pleaseInterrupt);
539 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
540          t.interrupt();
541          awaitTermination(t);
542          checkEmpty(q);
# Line 579 | Line 603 | public class ArrayBlockingQueueTest exte
603       * clear removes all elements
604       */
605      public void testClear() {
606 <        ArrayBlockingQueue q = populatedQueue(SIZE);
606 >        int size = ThreadLocalRandom.current().nextInt(1, 5);
607 >        ArrayBlockingQueue q = populatedQueue(size, size, 2 * size, false);
608 >        int capacity = size + q.remainingCapacity();
609          q.clear();
610          assertTrue(q.isEmpty());
611          assertEquals(0, q.size());
612 <        assertEquals(SIZE, q.remainingCapacity());
612 >        assertEquals(capacity, q.remainingCapacity());
613          q.add(one);
614          assertFalse(q.isEmpty());
615          assertTrue(q.contains(one));
# Line 852 | Line 878 | public class ArrayBlockingQueueTest exte
878      }
879  
880      /**
881 <     * A deserialized serialized queue has same elements in same order
881 >     * A deserialized/reserialized queue has same elements in same order
882       */
883      public void testSerialization() throws Exception {
884          Queue x = populatedQueue(SIZE);

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines