ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ArrayBlockingQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ArrayBlockingQueueTest.java (file contents):
Revision 1.73 by jsr166, Mon Oct 17 01:52:04 2016 UTC vs.
Revision 1.95 by jsr166, Thu Sep 5 20:54:24 2019 UTC

# Line 11 | Line 11 | import static java.util.concurrent.TimeU
11   import java.util.ArrayList;
12   import java.util.Arrays;
13   import java.util.Collection;
14 + import java.util.Collections;
15   import java.util.Iterator;
16   import java.util.NoSuchElementException;
17   import java.util.Queue;
# Line 19 | Line 20 | import java.util.concurrent.BlockingQueu
20   import java.util.concurrent.CountDownLatch;
21   import java.util.concurrent.Executors;
22   import java.util.concurrent.ExecutorService;
23 + import java.util.concurrent.ThreadLocalRandom;
24  
25   import junit.framework.Test;
26  
27   public class ArrayBlockingQueueTest extends JSR166TestCase {
28  
27    public static class Fair extends BlockingQueueTest {
28        protected BlockingQueue emptyCollection() {
29            return new ArrayBlockingQueue(SIZE, true);
30        }
31    }
32
33    public static class NonFair extends BlockingQueueTest {
34        protected BlockingQueue emptyCollection() {
35            return new ArrayBlockingQueue(SIZE, false);
36        }
37    }
38
29      public static void main(String[] args) {
30          main(suite(), args);
31      }
# Line 43 | Line 33 | public class ArrayBlockingQueueTest exte
33      public static Test suite() {
34          class Implementation implements CollectionImplementation {
35              public Class<?> klazz() { return ArrayBlockingQueue.class; }
36 <            public Collection emptyCollection() { return new ArrayBlockingQueue(SIZE, false); }
36 >            public Collection emptyCollection() {
37 >                boolean fair = randomBoolean();
38 >                return populatedQueue(0, SIZE, 2 * SIZE, fair);
39 >            }
40              public Object makeElement(int i) { return i; }
41              public boolean isConcurrent() { return true; }
42              public boolean permitsNulls() { return false; }
43          }
44 <        return newTestSuite(ArrayBlockingQueueTest.class,
45 <                            new Fair().testSuite(),
46 <                            new NonFair().testSuite(),
47 <                            CollectionTest.testSuite(new Implementation()));
44 >
45 >        return newTestSuite(
46 >            ArrayBlockingQueueTest.class,
47 >            new Fair().testSuite(),
48 >            new NonFair().testSuite(),
49 >            CollectionTest.testSuite(new Implementation()));
50 >    }
51 >
52 >    public static class Fair extends BlockingQueueTest {
53 >        protected BlockingQueue emptyCollection() {
54 >            return populatedQueue(0, SIZE, 2 * SIZE, true);
55 >        }
56 >    }
57 >
58 >    public static class NonFair extends BlockingQueueTest {
59 >        protected BlockingQueue emptyCollection() {
60 >            return populatedQueue(0, SIZE, 2 * SIZE, false);
61 >        }
62      }
63  
64      /**
65       * Returns a new queue of given size containing consecutive
66       * Integers 0 ... n - 1.
67       */
68 <    private ArrayBlockingQueue<Integer> populatedQueue(int n) {
69 <        ArrayBlockingQueue<Integer> q = new ArrayBlockingQueue<Integer>(n);
68 >    static ArrayBlockingQueue<Integer> populatedQueue(int n) {
69 >        return populatedQueue(n, n, n, false);
70 >    }
71 >
72 >    /**
73 >     * Returns a new queue of given size containing consecutive
74 >     * Integers 0 ... n - 1, with given capacity range and fairness.
75 >     */
76 >    static ArrayBlockingQueue<Integer> populatedQueue(
77 >        int size, int minCapacity, int maxCapacity, boolean fair) {
78 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
79 >        int capacity = rnd.nextInt(minCapacity, maxCapacity + 1);
80 >        ArrayBlockingQueue<Integer> q = new ArrayBlockingQueue<>(capacity);
81          assertTrue(q.isEmpty());
82 <        for (int i = 0; i < n; i++)
83 <            assertTrue(q.offer(new Integer(i)));
84 <        assertFalse(q.isEmpty());
85 <        assertEquals(0, q.remainingCapacity());
86 <        assertEquals(n, q.size());
87 <        assertEquals((Integer) 0, q.peek());
82 >        // shuffle circular array elements so they wrap
83 >        {
84 >            int n = rnd.nextInt(capacity);
85 >            for (int i = 0; i < n; i++) q.add(42);
86 >            for (int i = 0; i < n; i++) q.remove();
87 >        }
88 >        for (int i = 0; i < size; i++)
89 >            assertTrue(q.offer((Integer) i));
90 >        assertEquals(size == 0, q.isEmpty());
91 >        assertEquals(capacity - size, q.remainingCapacity());
92 >        assertEquals(size, q.size());
93 >        if (size > 0)
94 >            assertEquals((Integer) 0, q.peek());
95          return q;
96      }
97  
# Line 78 | Line 103 | public class ArrayBlockingQueueTest exte
103      }
104  
105      /**
106 <     * Constructor throws IAE if capacity argument nonpositive
106 >     * Constructor throws IllegalArgumentException if capacity argument nonpositive
107       */
108 <    public void testConstructor2() {
109 <        try {
110 <            new ArrayBlockingQueue(0);
111 <            shouldThrow();
112 <        } catch (IllegalArgumentException success) {}
108 >    public void testConstructor_nonPositiveCapacity() {
109 >        for (int i : new int[] { 0, -1, Integer.MIN_VALUE }) {
110 >            try {
111 >                new ArrayBlockingQueue(i);
112 >                shouldThrow();
113 >            } catch (IllegalArgumentException success) {}
114 >            for (boolean fair : new boolean[] { true, false }) {
115 >                try {
116 >                    new ArrayBlockingQueue(i, fair);
117 >                    shouldThrow();
118 >                } catch (IllegalArgumentException success) {}
119 >            }
120 >        }
121      }
122  
123      /**
124       * Initializing from null Collection throws NPE
125       */
126 <    public void testConstructor3() {
126 >    public void testConstructor_nullCollection() {
127          try {
128              new ArrayBlockingQueue(1, true, null);
129              shouldThrow();
# Line 123 | Line 156 | public class ArrayBlockingQueueTest exte
156      }
157  
158      /**
159 <     * Initializing from too large collection throws IAE
159 >     * Initializing from too large collection throws IllegalArgumentException
160       */
161 <    public void testConstructor6() {
162 <        Integer[] ints = new Integer[SIZE];
163 <        for (int i = 0; i < SIZE; ++i)
164 <            ints[i] = i;
132 <        Collection<Integer> elements = Arrays.asList(ints);
161 >    public void testConstructor_collectionTooLarge() {
162 >        // just barely fits - succeeds
163 >        new ArrayBlockingQueue(SIZE, false,
164 >                               Collections.nCopies(SIZE, ""));
165          try {
166 <            new ArrayBlockingQueue(SIZE - 1, false, elements);
166 >            new ArrayBlockingQueue(SIZE - 1, false,
167 >                                   Collections.nCopies(SIZE, ""));
168              shouldThrow();
169          } catch (IllegalArgumentException success) {}
170      }
# Line 153 | Line 186 | public class ArrayBlockingQueueTest exte
186       * Queue transitions from empty to full when elements added
187       */
188      public void testEmptyFull() {
189 <        ArrayBlockingQueue q = new ArrayBlockingQueue(2);
189 >        BlockingQueue q = populatedQueue(0, 2, 2, false);
190          assertTrue(q.isEmpty());
191          assertEquals(2, q.remainingCapacity());
192          q.add(one);
193          assertFalse(q.isEmpty());
194 <        q.add(two);
194 >        assertTrue(q.offer(two));
195          assertFalse(q.isEmpty());
196          assertEquals(0, q.remainingCapacity());
197          assertFalse(q.offer(three));
# Line 168 | Line 201 | public class ArrayBlockingQueueTest exte
201       * remainingCapacity decreases on add, increases on remove
202       */
203      public void testRemainingCapacity() {
204 <        BlockingQueue q = populatedQueue(SIZE);
205 <        for (int i = 0; i < SIZE; ++i) {
206 <            assertEquals(i, q.remainingCapacity());
207 <            assertEquals(SIZE, q.size() + q.remainingCapacity());
204 >        int size = ThreadLocalRandom.current().nextInt(1, SIZE);
205 >        BlockingQueue q = populatedQueue(size, size, 2 * size, false);
206 >        int spare = q.remainingCapacity();
207 >        int capacity = spare + size;
208 >        for (int i = 0; i < size; i++) {
209 >            assertEquals(spare + i, q.remainingCapacity());
210 >            assertEquals(capacity, q.size() + q.remainingCapacity());
211              assertEquals(i, q.remove());
212          }
213 <        for (int i = 0; i < SIZE; ++i) {
214 <            assertEquals(SIZE - i, q.remainingCapacity());
215 <            assertEquals(SIZE, q.size() + q.remainingCapacity());
213 >        for (int i = 0; i < size; i++) {
214 >            assertEquals(capacity - i, q.remainingCapacity());
215 >            assertEquals(capacity, q.size() + q.remainingCapacity());
216              assertTrue(q.add(i));
217          }
218      }
# Line 191 | Line 227 | public class ArrayBlockingQueueTest exte
227      }
228  
229      /**
230 <     * add succeeds if not full; throws ISE if full
230 >     * add succeeds if not full; throws IllegalStateException if full
231       */
232      public void testAdd() {
233          ArrayBlockingQueue q = new ArrayBlockingQueue(SIZE);
234 <        for (int i = 0; i < SIZE; ++i) {
199 <            assertTrue(q.add(new Integer(i)));
200 <        }
234 >        for (int i = 0; i < SIZE; i++) assertTrue(q.add((Integer) i));
235          assertEquals(0, q.remainingCapacity());
236          try {
237 <            q.add(new Integer(SIZE));
237 >            q.add((Integer) SIZE);
238              shouldThrow();
239          } catch (IllegalStateException success) {}
240      }
241  
242      /**
243 <     * addAll(this) throws IAE
243 >     * addAll(this) throws IllegalArgumentException
244       */
245      public void testAddAllSelf() {
246          ArrayBlockingQueue q = populatedQueue(SIZE);
# Line 232 | Line 266 | public class ArrayBlockingQueueTest exte
266      }
267  
268      /**
269 <     * addAll throws ISE if not enough room
269 >     * addAll throws IllegalStateException if not enough room
270       */
271 <    public void testAddAll4() {
272 <        ArrayBlockingQueue q = new ArrayBlockingQueue(1);
273 <        Integer[] ints = new Integer[SIZE];
274 <        for (int i = 0; i < SIZE; ++i)
275 <            ints[i] = new Integer(i);
271 >    public void testAddAll_insufficientSpace() {
272 >        int size = ThreadLocalRandom.current().nextInt(1, SIZE);
273 >        ArrayBlockingQueue q = populatedQueue(0, size, size, false);
274 >        // Just fits:
275 >        q.addAll(populatedQueue(size, size, 2 * size, false));
276 >        assertEquals(0, q.remainingCapacity());
277 >        assertEquals(size, q.size());
278 >        assertEquals(0, q.peek());
279          try {
280 <            q.addAll(Arrays.asList(ints));
280 >            q = populatedQueue(0, size, size, false);
281 >            q.addAll(Collections.nCopies(size + 1, 42));
282              shouldThrow();
283          } catch (IllegalStateException success) {}
284      }
# Line 302 | Line 340 | public class ArrayBlockingQueueTest exte
340              }});
341  
342          await(pleaseInterrupt);
343 <        assertThreadStaysAlive(t);
343 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
344          t.interrupt();
345          awaitTermination(t);
346          assertEquals(SIZE, q.size());
# Line 324 | Line 362 | public class ArrayBlockingQueueTest exte
362                  pleaseTake.countDown();
363                  q.put(86);
364  
365 +                Thread.currentThread().interrupt();
366 +                try {
367 +                    q.put(99);
368 +                    shouldThrow();
369 +                } catch (InterruptedException success) {}
370 +                assertFalse(Thread.interrupted());
371 +
372                  pleaseInterrupt.countDown();
373                  try {
374                      q.put(99);
# Line 337 | Line 382 | public class ArrayBlockingQueueTest exte
382          assertEquals(0, q.take());
383  
384          await(pleaseInterrupt);
385 <        assertThreadStaysAlive(t);
385 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
386          t.interrupt();
387          awaitTermination(t);
388          assertEquals(0, q.remainingCapacity());
# Line 346 | Line 391 | public class ArrayBlockingQueueTest exte
391      /**
392       * timed offer times out if full and elements not taken
393       */
394 <    public void testTimedOffer() throws InterruptedException {
394 >    public void testTimedOffer() {
395          final ArrayBlockingQueue q = new ArrayBlockingQueue(2);
396          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
397          Thread t = newStartedThread(new CheckedRunnable() {
# Line 356 | Line 401 | public class ArrayBlockingQueueTest exte
401                  long startTime = System.nanoTime();
402                  assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
403                  assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
404 +
405 +                Thread.currentThread().interrupt();
406 +                try {
407 +                    q.offer(new Object(), randomTimeout(), randomTimeUnit());
408 +                    shouldThrow();
409 +                } catch (InterruptedException success) {}
410 +                assertFalse(Thread.interrupted());
411 +
412                  pleaseInterrupt.countDown();
413                  try {
414 <                    q.offer(new Object(), 2 * LONG_DELAY_MS, MILLISECONDS);
414 >                    q.offer(new Object(), LONGER_DELAY_MS, MILLISECONDS);
415                      shouldThrow();
416                  } catch (InterruptedException success) {}
417 +                assertFalse(Thread.interrupted());
418              }});
419  
420          await(pleaseInterrupt);
421 <        assertThreadStaysAlive(t);
421 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
422          t.interrupt();
423          awaitTermination(t);
424      }
# Line 387 | Line 441 | public class ArrayBlockingQueueTest exte
441          final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
442          Thread t = newStartedThread(new CheckedRunnable() {
443              public void realRun() throws InterruptedException {
444 <                for (int i = 0; i < SIZE; ++i) {
391 <                    assertEquals(i, q.take());
392 <                }
444 >                for (int i = 0; i < SIZE; i++) assertEquals(i, q.take());
445  
446                  Thread.currentThread().interrupt();
447                  try {
# Line 407 | Line 459 | public class ArrayBlockingQueueTest exte
459              }});
460  
461          await(pleaseInterrupt);
462 <        assertThreadStaysAlive(t);
462 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
463          t.interrupt();
464          awaitTermination(t);
465      }
# Line 457 | Line 509 | public class ArrayBlockingQueueTest exte
509       */
510      public void testInterruptedTimedPoll() throws InterruptedException {
511          final BlockingQueue<Integer> q = populatedQueue(SIZE);
512 <        final CountDownLatch aboutToWait = new CountDownLatch(1);
512 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
513          Thread t = newStartedThread(new CheckedRunnable() {
514              public void realRun() throws InterruptedException {
515                  long startTime = System.nanoTime();
516 <                for (int i = 0; i < SIZE; ++i) {
516 >                for (int i = 0; i < SIZE; i++)
517                      assertEquals(i, (int) q.poll(LONG_DELAY_MS, MILLISECONDS));
518 <                }
519 <                aboutToWait.countDown();
518 >
519 >                Thread.currentThread().interrupt();
520 >                try {
521 >                    q.poll(randomTimeout(), randomTimeUnit());
522 >                    shouldThrow();
523 >                } catch (InterruptedException success) {}
524 >                assertFalse(Thread.interrupted());
525 >
526 >                pleaseInterrupt.countDown();
527                  try {
528                      q.poll(LONG_DELAY_MS, MILLISECONDS);
529                      shouldThrow();
530 <                } catch (InterruptedException success) {
531 <                    assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
532 <                }
530 >                } catch (InterruptedException success) {}
531 >                assertFalse(Thread.interrupted());
532 >
533 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
534              }});
535  
536 <        await(aboutToWait);
537 <        waitForThreadToEnterWaitState(t);
536 >        await(pleaseInterrupt);
537 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
538          t.interrupt();
539          awaitTermination(t);
540          checkEmpty(q);
# Line 527 | Line 587 | public class ArrayBlockingQueueTest exte
587       * contains(x) reports true when elements added but not yet removed
588       */
589      public void testContains() {
590 <        ArrayBlockingQueue q = populatedQueue(SIZE);
591 <        for (int i = 0; i < SIZE; ++i) {
590 >        int size = ThreadLocalRandom.current().nextInt(1, SIZE);
591 >        ArrayBlockingQueue q = populatedQueue(size, size, 2 * size, false);
592 >        assertFalse(q.contains(null));
593 >        for (int i = 0; i < size; ++i) {
594              assertTrue(q.contains(new Integer(i)));
595              assertEquals(i, q.poll());
596              assertFalse(q.contains(new Integer(i)));
# Line 539 | Line 601 | public class ArrayBlockingQueueTest exte
601       * clear removes all elements
602       */
603      public void testClear() {
604 <        ArrayBlockingQueue q = populatedQueue(SIZE);
604 >        int size = ThreadLocalRandom.current().nextInt(1, 5);
605 >        ArrayBlockingQueue q = populatedQueue(size, size, 2 * size, false);
606 >        int capacity = size + q.remainingCapacity();
607          q.clear();
608          assertTrue(q.isEmpty());
609          assertEquals(0, q.size());
610 <        assertEquals(SIZE, q.remainingCapacity());
610 >        assertEquals(capacity, q.remainingCapacity());
611          q.add(one);
612          assertFalse(q.isEmpty());
613          assertTrue(q.contains(one));
# Line 600 | Line 664 | public class ArrayBlockingQueueTest exte
664          }
665      }
666  
667 <    void checkToArray(ArrayBlockingQueue q) {
667 >    void checkToArray(ArrayBlockingQueue<Integer> q) {
668          int size = q.size();
669 <        Object[] o = q.toArray();
670 <        assertEquals(size, o.length);
669 >        Object[] a1 = q.toArray();
670 >        assertEquals(size, a1.length);
671 >        Integer[] a2 = q.toArray(new Integer[0]);
672 >        assertEquals(size, a2.length);
673 >        Integer[] a3 = q.toArray(new Integer[Math.max(0, size - 1)]);
674 >        assertEquals(size, a3.length);
675 >        Integer[] a4 = new Integer[size];
676 >        assertSame(a4, q.toArray(a4));
677 >        Integer[] a5 = new Integer[size + 1];
678 >        Arrays.fill(a5, 42);
679 >        assertSame(a5, q.toArray(a5));
680 >        Integer[] a6 = new Integer[size + 2];
681 >        Arrays.fill(a6, 42);
682 >        assertSame(a6, q.toArray(a6));
683 >        Object[][] as = { a1, a2, a3, a4, a5, a6 };
684 >        for (Object[] a : as) {
685 >            if (a.length > size) assertNull(a[size]);
686 >            if (a.length > size + 1) assertEquals(42, a[size + 1]);
687 >        }
688          Iterator it = q.iterator();
689 +        Integer s = q.peek();
690          for (int i = 0; i < size; i++) {
691              Integer x = (Integer) it.next();
692 <            assertEquals((Integer)o[0] + i, (int) x);
693 <            assertSame(o[i], x);
692 >            assertEquals(s + i, (int) x);
693 >            for (Object[] a : as)
694 >                assertSame(a1[i], x);
695          }
696      }
697  
698      /**
699 <     * toArray() contains all elements in FIFO order
699 >     * toArray() and toArray(a) contain all elements in FIFO order
700       */
701      public void testToArray() {
702 <        ArrayBlockingQueue q = new ArrayBlockingQueue(SIZE);
703 <        for (int i = 0; i < SIZE; i++) {
702 >        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
703 >        final int size = rnd.nextInt(6);
704 >        final int capacity = Math.max(1, size + rnd.nextInt(size + 1));
705 >        ArrayBlockingQueue<Integer> q = new ArrayBlockingQueue<>(capacity);
706 >        for (int i = 0; i < size; i++) {
707              checkToArray(q);
708              q.add(i);
709          }
710          // Provoke wraparound
711 <        for (int i = 0; i < SIZE; i++) {
712 <            checkToArray(q);
627 <            assertEquals(i, q.poll());
628 <            checkToArray(q);
629 <            q.add(SIZE + i);
630 <        }
631 <        for (int i = 0; i < SIZE; i++) {
711 >        int added = size * 2;
712 >        for (int i = 0; i < added; i++) {
713              checkToArray(q);
714 <            assertEquals(SIZE + i, q.poll());
714 >            assertEquals((Integer) i, q.poll());
715 >            q.add(size + i);
716          }
635    }
636
637    void checkToArray2(ArrayBlockingQueue q) {
638        int size = q.size();
639        Integer[] a1 = (size == 0) ? null : new Integer[size - 1];
640        Integer[] a2 = new Integer[size];
641        Integer[] a3 = new Integer[size + 2];
642        if (size > 0) Arrays.fill(a1, 42);
643        Arrays.fill(a2, 42);
644        Arrays.fill(a3, 42);
645        Integer[] b1 = (size == 0) ? null : (Integer[]) q.toArray(a1);
646        Integer[] b2 = (Integer[]) q.toArray(a2);
647        Integer[] b3 = (Integer[]) q.toArray(a3);
648        assertSame(a2, b2);
649        assertSame(a3, b3);
650        Iterator it = q.iterator();
717          for (int i = 0; i < size; i++) {
718 <            Integer x = (Integer) it.next();
719 <            assertSame(b1[i], x);
654 <            assertEquals(b1[0] + i, (int) x);
655 <            assertSame(b2[i], x);
656 <            assertSame(b3[i], x);
657 <        }
658 <        assertNull(a3[size]);
659 <        assertEquals(42, (int) a3[size + 1]);
660 <        if (size > 0) {
661 <            assertNotSame(a1, b1);
662 <            assertEquals(size, b1.length);
663 <            for (int i = 0; i < a1.length; i++) {
664 <                assertEquals(42, (int) a1[i]);
665 <            }
666 <        }
667 <    }
668 <
669 <    /**
670 <     * toArray(a) contains all elements in FIFO order
671 <     */
672 <    public void testToArray2() {
673 <        ArrayBlockingQueue q = new ArrayBlockingQueue(SIZE);
674 <        for (int i = 0; i < SIZE; i++) {
675 <            checkToArray2(q);
676 <            q.add(i);
677 <        }
678 <        // Provoke wraparound
679 <        for (int i = 0; i < SIZE; i++) {
680 <            checkToArray2(q);
681 <            assertEquals(i, q.poll());
682 <            checkToArray2(q);
683 <            q.add(SIZE + i);
684 <        }
685 <        for (int i = 0; i < SIZE; i++) {
686 <            checkToArray2(q);
687 <            assertEquals(SIZE + i, q.poll());
718 >            checkToArray(q);
719 >            assertEquals((Integer) (added + i), q.poll());
720          }
721      }
722  
723      /**
724       * toArray(incompatible array type) throws ArrayStoreException
725       */
726 <    public void testToArray1_BadArg() {
726 >    public void testToArray_incompatibleArrayType() {
727          ArrayBlockingQueue q = populatedQueue(SIZE);
728          try {
729              q.toArray(new String[10]);
730              shouldThrow();
731          } catch (ArrayStoreException success) {}
732 +        try {
733 +            q.toArray(new String[0]);
734 +            shouldThrow();
735 +        } catch (ArrayStoreException success) {}
736      }
737  
738      /**
# Line 840 | Line 876 | public class ArrayBlockingQueueTest exte
876      }
877  
878      /**
879 <     * A deserialized serialized queue has same elements in same order
879 >     * A deserialized/reserialized queue has same elements in same order
880       */
881      public void testSerialization() throws Exception {
882          Queue x = populatedQueue(SIZE);
# Line 925 | Line 961 | public class ArrayBlockingQueueTest exte
961       */
962      public void testNeverContainsNull() {
963          Collection<?>[] qs = {
964 <            new ArrayBlockingQueue<Object>(10),
965 <            populatedQueue(2),
964 >            populatedQueue(0, 1, 10, false),
965 >            populatedQueue(2, 2, 10, true),
966          };
967  
968          for (Collection<?> q : qs) {

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines