--- jsr166/src/test/tck/ArrayDequeTest.java 2016/10/17 01:57:00 1.45 +++ jsr166/src/test/tck/ArrayDequeTest.java 2016/10/17 15:48:01 1.48 @@ -14,6 +14,7 @@ import java.util.Iterator; import java.util.NoSuchElementException; import java.util.Queue; import java.util.Random; +import java.util.Spliterator; import java.util.concurrent.ThreadLocalRandom; import junit.framework.Test; @@ -989,6 +990,34 @@ public class ArrayDequeTest extends JSR1 } /** + * Spliterator characteristics are as advertised + */ + public void testSpliterator_characteristics() { + ArrayDeque q = new ArrayDeque(); + Spliterator s = q.spliterator(); + int characteristics = s.characteristics(); + int required = Spliterator.NONNULL + | Spliterator.ORDERED + | Spliterator.SIZED + | Spliterator.SUBSIZED; + assertEquals(required, characteristics & required); + assertTrue(s.hasCharacteristics(required)); + assertEquals(0, characteristics + & (Spliterator.CONCURRENT + | Spliterator.DISTINCT + | Spliterator.IMMUTABLE + | Spliterator.SORTED)); + } + + /** + * Spliterator.getComparator always throws IllegalStateException + */ + public void testSpliterator_getComparator() { + assertThrows(IllegalStateException.class, + () -> new ArrayDeque().spliterator().getComparator()); + } + + /** * Handle capacities near Integer.MAX_VALUE. * ant -Dvmoptions=-Xmx24g -Djsr166.expensiveTests=true -Djsr166.tckTestClass=ArrayDequeTest -Djsr166.methodFilter=testHuge tck */ @@ -1006,7 +1035,7 @@ public class ArrayDequeTest extends JSR1 () -> new ArrayDeque<>(Integer.MAX_VALUE)); q = populatedDeque(0); - q.addAll(Collections.nCopies(maxSize - 2, (Integer) 42)); + assertTrue(q.addAll(Collections.nCopies(maxSize - 2, (Integer) 42))); assertEquals((Integer) 42, q.peekFirst()); assertEquals((Integer) 42, q.peekLast()); assertEquals(maxSize - 2, q.size());