--- jsr166/src/test/tck/AtomicBooleanTest.java	2003/09/07 20:39:11	1.2
+++ jsr166/src/test/tck/AtomicBooleanTest.java	2011/06/10 20:01:21	1.20
@@ -1,90 +1,140 @@
 /*
- * Written by members of JCP JSR-166 Expert Group and released to the
- * public domain. Use, modify, and redistribute this code in any way
- * without acknowledgement. Other contributors include Andrew Wright,
- * Jeffrey Hayes, Pat Fischer, Mike Judd.
+ * Written by Doug Lea with assistance from members of JCP JSR-166
+ * Expert Group and released to the public domain, as explained at
+ * http://creativecommons.org/publicdomain/zero/1.0/
+ * Other contributors include Andrew Wright, Jeffrey Hayes,
+ * Pat Fisher, Mike Judd.
  */
 
 import junit.framework.*;
-import java.util.concurrent.atomic.*;
-import java.io.*;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-public class AtomicBooleanTest extends TestCase {
-    public static void main (String[] args) {
-        junit.textui.TestRunner.run (suite());
+public class AtomicBooleanTest extends JSR166TestCase {
+    public static void main(String[] args) {
+        junit.textui.TestRunner.run(suite());
     }
     public static Test suite() {
         return new TestSuite(AtomicBooleanTest.class);
     }
 
-    public void testConstructor(){
-        AtomicBoolean ai = new AtomicBoolean(true);
-	assertEquals(true,ai.get());
+    /**
+     * constructor initializes to given value
+     */
+    public void testConstructor() {
+        assertTrue(new AtomicBoolean(true).get());
+        assertFalse(new AtomicBoolean(false).get());
     }
 
-    public void testConstructor2(){
+    /**
+     * default constructed initializes to false
+     */
+    public void testConstructor2() {
         AtomicBoolean ai = new AtomicBoolean();
-	assertEquals(false,ai.get());
+        assertFalse(ai.get());
     }
 
-    public void testGetSet(){
+    /**
+     * get returns the last value set
+     */
+    public void testGetSet() {
         AtomicBoolean ai = new AtomicBoolean(true);
-	assertEquals(true,ai.get());
-	ai.set(false);
-	assertEquals(false,ai.get());
-	ai.set(true);
-	assertEquals(true,ai.get());
-	
+        assertTrue(ai.get());
+        ai.set(false);
+        assertFalse(ai.get());
+        ai.set(true);
+        assertTrue(ai.get());
     }
-    public void testCompareAndSet(){
+
+    /**
+     * get returns the last value lazySet in same thread
+     */
+    public void testGetLazySet() {
         AtomicBoolean ai = new AtomicBoolean(true);
-	assertTrue(ai.compareAndSet(true,false));
-	assertEquals(false,ai.get());
-	assertTrue(ai.compareAndSet(false,false));
-	assertEquals(false,ai.get());
-	assertFalse(ai.compareAndSet(true,false));
-	assertFalse((ai.get()));
-	assertTrue(ai.compareAndSet(false,true));
-	assertEquals(true,ai.get());
+        assertTrue(ai.get());
+        ai.lazySet(false);
+        assertFalse(ai.get());
+        ai.lazySet(true);
+        assertTrue(ai.get());
     }
 
-    public void testWeakCompareAndSet(){
+    /**
+     * compareAndSet succeeds in changing value if equal to expected else fails
+     */
+    public void testCompareAndSet() {
+        AtomicBoolean ai = new AtomicBoolean(true);
+        assertTrue(ai.compareAndSet(true, false));
+        assertFalse(ai.get());
+        assertTrue(ai.compareAndSet(false, false));
+        assertFalse(ai.get());
+        assertFalse(ai.compareAndSet(true, false));
+        assertFalse(ai.get());
+        assertTrue(ai.compareAndSet(false, true));
+        assertTrue(ai.get());
+    }
+
+    /**
+     * compareAndSet in one thread enables another waiting for value
+     * to succeed
+     */
+    public void testCompareAndSetInMultipleThreads() throws Exception {
+        final AtomicBoolean ai = new AtomicBoolean(true);
+        Thread t = new Thread(new CheckedRunnable() {
+            public void realRun() {
+                while (!ai.compareAndSet(false, true)) Thread.yield();
+            }});
+
+        t.start();
+        assertTrue(ai.compareAndSet(true, false));
+        t.join(LONG_DELAY_MS);
+        assertFalse(t.isAlive());
+    }
+
+    /**
+     * repeated weakCompareAndSet succeeds in changing value when equal
+     * to expected
+     */
+    public void testWeakCompareAndSet() {
         AtomicBoolean ai = new AtomicBoolean(true);
-	while(!ai.weakCompareAndSet(true,false));
-	assertEquals(false,ai.get());
-	while(!ai.weakCompareAndSet(false,false));
-        assertEquals(false,ai.get());
-        while(!ai.weakCompareAndSet(false,true));
-	assertEquals(true,ai.get());
+        while (!ai.weakCompareAndSet(true, false));
+        assertFalse(ai.get());
+        while (!ai.weakCompareAndSet(false, false));
+        assertFalse(ai.get());
+        while (!ai.weakCompareAndSet(false, true));
+        assertTrue(ai.get());
     }
 
-    public void testGetAndSet(){
+    /**
+     * getAndSet returns previous value and sets to given value
+     */
+    public void testGetAndSet() {
         AtomicBoolean ai = new AtomicBoolean(true);
-	assertEquals(true,ai.getAndSet(false));
-	assertEquals(false,ai.getAndSet(false));
-	assertEquals(false,ai.getAndSet(true));
-	assertEquals(true,ai.get());
-    }
-
-    public void testSerialization() {
-        AtomicBoolean l = new AtomicBoolean();
-
-        try {
-            l.set(true);
-            ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
-            ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
-            out.writeObject(l);
-            out.close();
-
-            ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
-            ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
-            AtomicBoolean r = (AtomicBoolean) in.readObject();
-            assertEquals(l.get(), r.get());
-        } catch(Exception e){
-            e.printStackTrace();
-            fail("unexpected exception");
-        }
+        assertEquals(true, ai.getAndSet(false));
+        assertEquals(false, ai.getAndSet(false));
+        assertEquals(false, ai.getAndSet(true));
+        assertTrue(ai.get());
+    }
+
+    /**
+     * a deserialized serialized atomic holds same value
+     */
+    public void testSerialization() throws Exception {
+        AtomicBoolean x = new AtomicBoolean();
+        AtomicBoolean y = serialClone(x);
+        x.set(true);
+        AtomicBoolean z = serialClone(x);
+        assertTrue(x.get());
+        assertFalse(y.get());
+        assertTrue(z.get());
+    }
+
+    /**
+     * toString returns current value.
+     */
+    public void testToString() {
+        AtomicBoolean ai = new AtomicBoolean();
+        assertEquals(ai.toString(), Boolean.toString(false));
+        ai.set(true);
+        assertEquals(ai.toString(), Boolean.toString(true));
     }
 
-
 }