--- jsr166/src/test/tck/AtomicReferenceFieldUpdaterTest.java 2009/11/17 03:12:51 1.14 +++ jsr166/src/test/tck/AtomicReferenceFieldUpdaterTest.java 2010/10/09 19:30:34 1.20 @@ -31,8 +31,7 @@ public class AtomicReferenceFieldUpdater a = AtomicReferenceFieldUpdater.newUpdater (AtomicReferenceFieldUpdaterTest.class, Integer.class, "y"); shouldThrow(); - } - catch (RuntimeException rt) {} + } catch (RuntimeException success) {} } @@ -45,8 +44,7 @@ public class AtomicReferenceFieldUpdater a = AtomicReferenceFieldUpdater.newUpdater (AtomicReferenceFieldUpdaterTest.class, Integer.class, "z"); shouldThrow(); - } - catch (RuntimeException rt) {} + } catch (RuntimeException success) {} } /** @@ -58,12 +56,11 @@ public class AtomicReferenceFieldUpdater a = AtomicReferenceFieldUpdater.newUpdater (AtomicReferenceFieldUpdaterTest.class, Integer.class, "w"); shouldThrow(); - } - catch (RuntimeException rt) {} + } catch (RuntimeException success) {} } /** - * get returns the last value set or assigned + * get returns the last value set or assigned */ public void testGetSet() { AtomicReferenceFieldUpdatera; @@ -73,15 +70,15 @@ public class AtomicReferenceFieldUpdater return; } x = one; - assertEquals(one,a.get(this)); - a.set(this,two); - assertEquals(two,a.get(this)); - a.set(this,m3); - assertEquals(m3,a.get(this)); + assertSame(one,a.get(this)); + a.set(this,two); + assertSame(two,a.get(this)); + a.set(this,m3); + assertSame(m3,a.get(this)); } /** - * get returns the last value lazySet by same thread + * get returns the last value lazySet by same thread */ public void testGetLazySet() { AtomicReferenceFieldUpdatera; @@ -91,11 +88,11 @@ public class AtomicReferenceFieldUpdater return; } x = one; - assertEquals(one,a.get(this)); - a.lazySet(this,two); - assertEquals(two,a.get(this)); - a.lazySet(this,m3); - assertEquals(m3,a.get(this)); + assertSame(one,a.get(this)); + a.lazySet(this,two); + assertSame(two,a.get(this)); + a.lazySet(this,m3); + assertSame(m3,a.get(this)); } /** @@ -109,13 +106,13 @@ public class AtomicReferenceFieldUpdater return; } x = one; - assertTrue(a.compareAndSet(this,one,two)); - assertTrue(a.compareAndSet(this,two,m4)); - assertEquals(m4,a.get(this)); - assertFalse(a.compareAndSet(this,m5,seven)); - assertFalse((seven == a.get(this))); - assertTrue(a.compareAndSet(this,m4,seven)); - assertEquals(seven,a.get(this)); + assertTrue(a.compareAndSet(this, one, two)); + assertTrue(a.compareAndSet(this, two, m4)); + assertSame(m4, a.get(this)); + assertFalse(a.compareAndSet(this, m5, seven)); + assertFalse(seven == a.get(this)); + assertTrue(a.compareAndSet(this, m4, seven)); + assertSame(seven,a.get(this)); } /** @@ -131,16 +128,17 @@ public class AtomicReferenceFieldUpdater return; } - Thread t = new Thread(new Runnable() { - public void run() { - while (!a.compareAndSet(AtomicReferenceFieldUpdaterTest.this, two, three)) Thread.yield(); - }}); + Thread t = new Thread(new CheckedRunnable() { + public void realRun() { + while (!a.compareAndSet(AtomicReferenceFieldUpdaterTest.this, two, three)) + Thread.yield(); + }}); t.start(); assertTrue(a.compareAndSet(this, one, two)); t.join(LONG_DELAY_MS); assertFalse(t.isAlive()); - assertEquals(a.get(this), three); + assertSame(a.get(this), three); } /** @@ -155,11 +153,11 @@ public class AtomicReferenceFieldUpdater return; } x = one; - while (!a.weakCompareAndSet(this,one,two)); - while (!a.weakCompareAndSet(this,two,m4)); - assertEquals(m4,a.get(this)); - while (!a.weakCompareAndSet(this,m4,seven)); - assertEquals(seven,a.get(this)); + while (!a.weakCompareAndSet(this,one,two)); + while (!a.weakCompareAndSet(this,two,m4)); + assertSame(m4,a.get(this)); + while (!a.weakCompareAndSet(this,m4,seven)); + assertSame(seven,a.get(this)); } /** @@ -173,9 +171,9 @@ public class AtomicReferenceFieldUpdater return; } x = one; - assertEquals(one,a.getAndSet(this, zero)); - assertEquals(zero,a.getAndSet(this,m10)); - assertEquals(m10,a.getAndSet(this,1)); + assertSame(one,a.getAndSet(this, zero)); + assertSame(zero,a.getAndSet(this,m10)); + assertSame(m10,a.getAndSet(this,1)); } }