--- jsr166/src/test/tck/AtomicReferenceTest.java 2011/06/10 20:01:21 1.19 +++ jsr166/src/test/tck/AtomicReferenceTest.java 2016/06/17 19:00:48 1.27 @@ -6,12 +6,14 @@ * Pat Fisher, Mike Judd. */ -import junit.framework.*; import java.util.concurrent.atomic.AtomicReference; +import junit.framework.Test; +import junit.framework.TestSuite; + public class AtomicReferenceTest extends JSR166TestCase { public static void main(String[] args) { - junit.textui.TestRunner.run(suite()); + main(suite(), args); } public static Test suite() { return new TestSuite(AtomicReferenceTest.class); @@ -87,7 +89,7 @@ public class AtomicReferenceTest extends assertTrue(ai.compareAndSet(one, two)); t.join(LONG_DELAY_MS); assertFalse(t.isAlive()); - assertSame(ai.get(), three); + assertSame(three, ai.get()); } /** @@ -96,10 +98,10 @@ public class AtomicReferenceTest extends */ public void testWeakCompareAndSet() { AtomicReference ai = new AtomicReference(one); - while (!ai.weakCompareAndSet(one, two)); - while (!ai.weakCompareAndSet(two, m4)); + do {} while (!ai.weakCompareAndSet(one, two)); + do {} while (!ai.weakCompareAndSet(two, m4)); assertSame(m4, ai.get()); - while (!ai.weakCompareAndSet(m4, seven)); + do {} while (!ai.weakCompareAndSet(m4, seven)); assertSame(seven, ai.get()); } @@ -119,9 +121,10 @@ public class AtomicReferenceTest extends public void testSerialization() throws Exception { AtomicReference x = new AtomicReference(); AtomicReference y = serialClone(x); - assertTrue(x != y); + assertNotSame(x, y); x.set(one); AtomicReference z = serialClone(x); + assertNotSame(y, z); assertEquals(one, x.get()); assertEquals(null, y.get()); assertEquals(one, z.get()); @@ -131,10 +134,10 @@ public class AtomicReferenceTest extends * toString returns current value. */ public void testToString() { - AtomicReference ai = new AtomicReference(one); - assertEquals(ai.toString(), one.toString()); + AtomicReference ai = new AtomicReference<>(one); + assertEquals(one.toString(), ai.toString()); ai.set(two); - assertEquals(ai.toString(), two.toString()); + assertEquals(two.toString(), ai.toString()); } }