--- jsr166/src/test/tck/BlockingQueueTest.java 2017/05/13 21:43:50 1.18 +++ jsr166/src/test/tck/BlockingQueueTest.java 2018/01/10 14:41:52 1.21 @@ -106,7 +106,7 @@ public abstract class BlockingQueueTest } /** - * put(null) throws NullPointerException + * addAll(null) throws NullPointerException */ public void testAddAllNull() throws InterruptedException { final Collection q = emptyCollection(); @@ -189,18 +189,20 @@ public abstract class BlockingQueueTest public void testDrainToNonPositiveMaxElements() { final BlockingQueue q = emptyCollection(); final int[] ns = { 0, -1, -42, Integer.MIN_VALUE }; - for (int n : ns) - assertEquals(0, q.drainTo(new ArrayList(), n)); + final ArrayList sink = new ArrayList(); + for (int n : ns) { + assertEquals(0, q.drainTo(sink, n)); + assertTrue(sink.isEmpty()); + } if (q.remainingCapacity() > 0) { // Not SynchronousQueue, that is Object one = makeElement(1); q.add(one); - ArrayList c = new ArrayList(); for (int n : ns) - assertEquals(0, q.drainTo(new ArrayList(), n)); + assertEquals(0, q.drainTo(sink, n)); assertEquals(1, q.size()); assertSame(one, q.poll()); - assertTrue(c.isEmpty()); + assertTrue(sink.isEmpty()); } } @@ -245,7 +247,7 @@ public abstract class BlockingQueueTest assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS); barrier.await(); - assertThreadStaysAlive(t); + assertThreadBlocks(t, Thread.State.TIMED_WAITING); t.interrupt(); awaitTermination(t); }