ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/Collection8Test.java

Comparing jsr166/src/test/tck/Collection8Test.java (file contents):
Revision 1.29 by jsr166, Tue Nov 22 01:08:14 2016 UTC vs.
Revision 1.51 by jsr166, Thu Apr 5 03:36:54 2018 UTC

#	Line 8 | Line 8
8		import static java.util.concurrent.TimeUnit.HOURS;
9		import static java.util.concurrent.TimeUnit.MILLISECONDS;
10
11	+	import java.util.ArrayDeque;
12		import java.util.ArrayList;
13		import java.util.Arrays;
14		import java.util.Collection;
15		import java.util.Collections;
16	+	import java.util.ConcurrentModificationException;
17		import java.util.Deque;
18		import java.util.HashSet;
19		import java.util.Iterator;
20		import java.util.List;
21		import java.util.NoSuchElementException;
22		import java.util.Queue;
23	+	import java.util.Set;
24		import java.util.Spliterator;
25		import java.util.concurrent.BlockingDeque;
26		import java.util.concurrent.BlockingQueue;
27	+	import java.util.concurrent.ConcurrentLinkedQueue;
28		import java.util.concurrent.CountDownLatch;
29		import java.util.concurrent.Executors;
30		import java.util.concurrent.ExecutorService;
#	Line 57 | Line 61 | public class Collection8Test extends JSR
61
62		Object bomb() {
63		return new Object() {
64	<	public boolean equals(Object x) { throw new AssertionError(); }
65	<	public int hashCode() { throw new AssertionError(); }
66	<	};
64	>	@Override public boolean equals(Object x) { throw new AssertionError(); }
65	>	@Override public int hashCode() { throw new AssertionError(); }
66	>	@Override public String toString() { throw new AssertionError(); }
67	>	};
68		}
69
70		/** Checks properties of empty collections. */
#	Line 90 | Line 95 | public class Collection8Test extends JSR
95		assertTrue(c.isEmpty());
96		assertEquals(0, c.size());
97		assertEquals("[]", c.toString());
98	+	if (c instanceof List<?>) {
99	+	List x = (List) c;
100	+	assertEquals(1, x.hashCode());
101	+	assertEquals(x, Collections.emptyList());
102	+	assertEquals(Collections.emptyList(), x);
103	+	assertEquals(-1, x.indexOf(impl.makeElement(86)));
104	+	assertEquals(-1, x.lastIndexOf(impl.makeElement(99)));
105	+	assertThrows(
106	+	IndexOutOfBoundsException.class,
107	+	() -> x.get(0),
108	+	() -> x.set(0, impl.makeElement(42)));
109	+	}
110	+	else if (c instanceof Set<?>) {
111	+	assertEquals(0, c.hashCode());
112	+	assertEquals(c, Collections.emptySet());
113	+	assertEquals(Collections.emptySet(), c);
114	+	}
115		{
116		Object[] a = c.toArray();
117		assertEquals(0, a.length);
#	Line 138 | Line 160 | public class Collection8Test extends JSR
160		}
161		if (c instanceof BlockingQueue) {
162		BlockingQueue q = (BlockingQueue) c;
163	<	assertNull(q.poll(0L, MILLISECONDS));
163	>	assertNull(q.poll(randomExpiredTimeout(), randomTimeUnit()));
164		}
165		if (c instanceof BlockingDeque) {
166		BlockingDeque q = (BlockingDeque) c;
167	<	assertNull(q.pollFirst(0L, MILLISECONDS));
168	<	assertNull(q.pollLast(0L, MILLISECONDS));
167	>	assertNull(q.pollFirst(randomExpiredTimeout(), randomTimeUnit()));
168	>	assertNull(q.pollLast(randomExpiredTimeout(), randomTimeUnit()));
169		}
170		}
171
#	Line 250 | Line 272 | public class Collection8Test extends JSR
272		() -> d.pop(),
273		() -> d.descendingIterator().next());
274		}
275	+	if (c instanceof List) {
276	+	List x = (List) c;
277	+	assertThrows(
278	+	NoSuchElementException.class,
279	+	() -> x.iterator().next(),
280	+	() -> x.listIterator().next(),
281	+	() -> x.listIterator(0).next(),
282	+	() -> x.listIterator().previous(),
283	+	() -> x.listIterator(0).previous());
284	+	}
285		}
286
287		public void testRemoveIf() {
#	Line 341 | Line 373 | public class Collection8Test extends JSR
373		}
374
375		/**
376	+	* All elements removed in the middle of CONCURRENT traversal.
377	+	*/
378	+	public void testElementRemovalDuringTraversal() {
379	+	Collection c = impl.emptyCollection();
380	+	ThreadLocalRandom rnd = ThreadLocalRandom.current();
381	+	int n = rnd.nextInt(6);
382	+	ArrayList copy = new ArrayList();
383	+	for (int i = 0; i < n; i++) {
384	+	Object x = impl.makeElement(i);
385	+	copy.add(x);
386	+	c.add(x);
387	+	}
388	+	ArrayList iterated = new ArrayList();
389	+	ArrayList spliterated = new ArrayList();
390	+	Spliterator s = c.spliterator();
391	+	Iterator it = c.iterator();
392	+	for (int i = rnd.nextInt(n + 1); --i >= 0; ) {
393	+	assertTrue(s.tryAdvance(spliterated::add));
394	+	if (rnd.nextBoolean()) assertTrue(it.hasNext());
395	+	iterated.add(it.next());
396	+	}
397	+	Consumer alwaysThrows = e -> { throw new AssertionError(); };
398	+	if (s.hasCharacteristics(Spliterator.CONCURRENT)) {
399	+	c.clear();          // TODO: many more removal methods
400	+	if (testImplementationDetails
401	+	&& !(c instanceof java.util.concurrent.ArrayBlockingQueue)) {
402	+	if (rnd.nextBoolean())
403	+	assertFalse(s.tryAdvance(alwaysThrows));
404	+	else
405	+	s.forEachRemaining(alwaysThrows);
406	+	}
407	+	if (it.hasNext()) iterated.add(it.next());
408	+	if (rnd.nextBoolean()) assertIteratorExhausted(it);
409	+	}
410	+	assertTrue(copy.containsAll(iterated));
411	+	assertTrue(copy.containsAll(spliterated));
412	+	}
413	+
414	+	/**
415	+	* Some elements randomly disappear in the middle of traversal.
416	+	*/
417	+	public void testRandomElementRemovalDuringTraversal() {
418	+	Collection c = impl.emptyCollection();
419	+	ThreadLocalRandom rnd = ThreadLocalRandom.current();
420	+	int n = rnd.nextInt(6);
421	+	ArrayList copy = new ArrayList();
422	+	for (int i = 0; i < n; i++) {
423	+	Object x = impl.makeElement(i);
424	+	copy.add(x);
425	+	c.add(x);
426	+	}
427	+	ArrayList iterated = new ArrayList();
428	+	ArrayList spliterated = new ArrayList();
429	+	ArrayList removed = new ArrayList();
430	+	Spliterator s = c.spliterator();
431	+	Iterator it = c.iterator();
432	+	if (! (s.hasCharacteristics(Spliterator.CONCURRENT) ||
433	+	s.hasCharacteristics(Spliterator.IMMUTABLE)))
434	+	return;
435	+	for (int i = rnd.nextInt(n + 1); --i >= 0; ) {
436	+	assertTrue(s.tryAdvance(e -> {}));
437	+	if (rnd.nextBoolean()) assertTrue(it.hasNext());
438	+	it.next();
439	+	}
440	+	Consumer alwaysThrows = e -> { throw new AssertionError(); };
441	+	// TODO: many more removal methods
442	+	if (rnd.nextBoolean()) {
443	+	for (Iterator z = c.iterator(); z.hasNext(); ) {
444	+	Object e = z.next();
445	+	if (rnd.nextBoolean()) {
446	+	try {
447	+	z.remove();
448	+	} catch (UnsupportedOperationException ok) { return; }
449	+	removed.add(e);
450	+	}
451	+	}
452	+	} else {
453	+	Predicate randomlyRemove = e -> {
454	+	if (rnd.nextBoolean()) { removed.add(e); return true; }
455	+	else return false;
456	+	};
457	+	c.removeIf(randomlyRemove);
458	+	}
459	+	s.forEachRemaining(spliterated::add);
460	+	while (it.hasNext())
461	+	iterated.add(it.next());
462	+	assertTrue(copy.containsAll(iterated));
463	+	assertTrue(copy.containsAll(spliterated));
464	+	assertTrue(copy.containsAll(removed));
465	+	if (s.hasCharacteristics(Spliterator.CONCURRENT)) {
466	+	ArrayList iteratedAndRemoved = new ArrayList(iterated);
467	+	ArrayList spliteratedAndRemoved = new ArrayList(spliterated);
468	+	iteratedAndRemoved.retainAll(removed);
469	+	spliteratedAndRemoved.retainAll(removed);
470	+	assertTrue(iteratedAndRemoved.size() <= 1);
471	+	assertTrue(spliteratedAndRemoved.size() <= 1);
472	+	if (testImplementationDetails
473	+	&& !(c instanceof java.util.concurrent.ArrayBlockingQueue))
474	+	assertTrue(spliteratedAndRemoved.isEmpty());
475	+	}
476	+	}
477	+
478	+	/**
479		* Various ways of traversing a collection yield same elements
480		*/
481	<	public void testIteratorEquivalence() {
481	>	public void testTraversalEquivalence() {
482		Collection c = impl.emptyCollection();
483		ThreadLocalRandom rnd = ThreadLocalRandom.current();
484		int n = rnd.nextInt(6);
#	Line 352 | Line 487 | public class Collection8Test extends JSR
487		ArrayList iteratedForEachRemaining = new ArrayList();
488		ArrayList tryAdvanced = new ArrayList();
489		ArrayList spliterated = new ArrayList();
490	+	ArrayList splitonced = new ArrayList();
491		ArrayList forEached = new ArrayList();
492	+	ArrayList streamForEached = new ArrayList();
493	+	ConcurrentLinkedQueue parallelStreamForEached = new ConcurrentLinkedQueue();
494		ArrayList removeIfed = new ArrayList();
495		for (Object x : c) iterated.add(x);
496		c.iterator().forEachRemaining(iteratedForEachRemaining::add);
497		for (Spliterator s = c.spliterator();
498		s.tryAdvance(tryAdvanced::add); ) {}
499		c.spliterator().forEachRemaining(spliterated::add);
500	+	{                       // trySplit returns "strict prefix"
501	+	Spliterator s1 = c.spliterator(), s2 = s1.trySplit();
502	+	if (s2 != null) s2.forEachRemaining(splitonced::add);
503	+	s1.forEachRemaining(splitonced::add);
504	+	}
505		c.forEach(forEached::add);
506	+	c.stream().forEach(streamForEached::add);
507	+	c.parallelStream().forEach(parallelStreamForEached::add);
508		c.removeIf(e -> { removeIfed.add(e); return false; });
509		boolean ordered =
510		c.spliterator().hasCharacteristics(Spliterator.ORDERED);
511		if (c instanceof List || c instanceof Deque)
512		assertTrue(ordered);
513	+	HashSet cset = new HashSet(c);
514	+	assertEquals(cset, new HashSet(parallelStreamForEached));
515		if (ordered) {
516		assertEquals(iterated, iteratedForEachRemaining);
517		assertEquals(iterated, tryAdvanced);
518		assertEquals(iterated, spliterated);
519	+	assertEquals(iterated, splitonced);
520		assertEquals(iterated, forEached);
521	+	assertEquals(iterated, streamForEached);
522		assertEquals(iterated, removeIfed);
523		} else {
375	–	HashSet cset = new HashSet(c);
524		assertEquals(cset, new HashSet(iterated));
525		assertEquals(cset, new HashSet(iteratedForEachRemaining));
526		assertEquals(cset, new HashSet(tryAdvanced));
527		assertEquals(cset, new HashSet(spliterated));
528	+	assertEquals(cset, new HashSet(splitonced));
529		assertEquals(cset, new HashSet(forEached));
530	+	assertEquals(cset, new HashSet(streamForEached));
531		assertEquals(cset, new HashSet(removeIfed));
532		}
533		if (c instanceof Deque) {
#	Line 396 | Line 546 | public class Collection8Test extends JSR
546		}
547
548		/**
549	+	* Iterator.forEachRemaining has same behavior as Iterator's
550	+	* default implementation.
551	+	*/
552	+	public void testForEachRemainingConsistentWithDefaultImplementation() {
553	+	Collection c = impl.emptyCollection();
554	+	if (!testImplementationDetails
555	+	|| c.getClass() == java.util.LinkedList.class)
556	+	return;
557	+	ThreadLocalRandom rnd = ThreadLocalRandom.current();
558	+	int n = 1 + rnd.nextInt(3);
559	+	for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
560	+	ArrayList iterated = new ArrayList();
561	+	ArrayList iteratedForEachRemaining = new ArrayList();
562	+	Iterator it1 = c.iterator();
563	+	Iterator it2 = c.iterator();
564	+	assertTrue(it1.hasNext());
565	+	assertTrue(it2.hasNext());
566	+	c.clear();
567	+	Object r1, r2;
568	+	try {
569	+	while (it1.hasNext()) iterated.add(it1.next());
570	+	r1 = iterated;
571	+	} catch (ConcurrentModificationException ex) {
572	+	r1 = ConcurrentModificationException.class;
573	+	assertFalse(impl.isConcurrent());
574	+	}
575	+	try {
576	+	it2.forEachRemaining(iteratedForEachRemaining::add);
577	+	r2 = iteratedForEachRemaining;
578	+	} catch (ConcurrentModificationException ex) {
579	+	r2 = ConcurrentModificationException.class;
580	+	assertFalse(impl.isConcurrent());
581	+	}
582	+	assertEquals(r1, r2);
583	+	}
584	+
585	+	/**
586		* Calling Iterator#remove() after Iterator#forEachRemaining
587		* should (maybe) remove last element
588		*/
#	Line 534 | Line 721 | public class Collection8Test extends JSR
721		assertTrue(found.isEmpty());
722		}
723
724	+	/** TODO: promote to a common utility */
725	+	static <T> T chooseOne(T ... ts) {
726	+	return ts[ThreadLocalRandom.current().nextInt(ts.length)];
727	+	}
728	+
729	+	/** TODO: more random adders and removers */
730	+	static <E> Runnable adderRemover(Collection<E> c, E e) {
731	+	return chooseOne(
732	+	() -> {
733	+	assertTrue(c.add(e));
734	+	assertTrue(c.contains(e));
735	+	assertTrue(c.remove(e));
736	+	assertFalse(c.contains(e));
737	+	},
738	+	() -> {
739	+	assertTrue(c.add(e));
740	+	assertTrue(c.contains(e));
741	+	assertTrue(c.removeIf(x -> x == e));
742	+	assertFalse(c.contains(e));
743	+	},
744	+	() -> {
745	+	assertTrue(c.add(e));
746	+	assertTrue(c.contains(e));
747	+	for (Iterator it = c.iterator();; )
748	+	if (it.next() == e) {
749	+	try { it.remove(); }
750	+	catch (UnsupportedOperationException ok) {
751	+	c.remove(e);
752	+	}
753	+	break;
754	+	}
755	+	assertFalse(c.contains(e));
756	+	});
757	+	}
758	+
759	+	/**
760	+	* Concurrent Spliterators, once exhausted, stay exhausted.
761	+	*/
762	+	public void testStickySpliteratorExhaustion() throws Throwable {
763	+	if (!impl.isConcurrent()) return;
764	+	if (!testImplementationDetails) return;
765	+	final ThreadLocalRandom rnd = ThreadLocalRandom.current();
766	+	final Consumer alwaysThrows = e -> { throw new AssertionError(); };
767	+	final Collection c = impl.emptyCollection();
768	+	final Spliterator s = c.spliterator();
769	+	if (rnd.nextBoolean()) {
770	+	assertFalse(s.tryAdvance(alwaysThrows));
771	+	} else {
772	+	s.forEachRemaining(alwaysThrows);
773	+	}
774	+	final Object one = impl.makeElement(1);
775	+	// Spliterator should not notice added element
776	+	c.add(one);
777	+	if (rnd.nextBoolean()) {
778	+	assertFalse(s.tryAdvance(alwaysThrows));
779	+	} else {
780	+	s.forEachRemaining(alwaysThrows);
781	+	}
782	+	}
783	+
784		/**
785		* Motley crew of threads concurrently randomly hammer the collection.
786		*/
#	Line 541 | Line 788 | public class Collection8Test extends JSR
788		if (!impl.isConcurrent()) return;
789		final ThreadLocalRandom rnd = ThreadLocalRandom.current();
790		final Collection c = impl.emptyCollection();
791	<	final long testDurationMillis = timeoutMillis();
791	>	final long testDurationMillis
792	>	= expensiveTests ? LONG_DELAY_MS : timeoutMillis();
793		final AtomicBoolean done = new AtomicBoolean(false);
794		final Object one = impl.makeElement(1);
795		final Object two = impl.makeElement(2);
796	+	final Consumer checkSanity = x -> assertTrue(x == one || x == two);
797	+	final Consumer<Object[]> checkArraySanity = array -> {
798	+	// assertTrue(array.length <= 2); // duplicates are permitted
799	+	for (Object x : array) assertTrue(x == one || x == two);
800	+	};
801		final Object[] emptyArray =
802		(Object[]) java.lang.reflect.Array.newInstance(one.getClass(), 0);
803		final List<Future<?>> futures;
804		final Phaser threadsStarted = new Phaser(1); // register this thread
805		final Runnable[] frobbers = {
806	<	() -> c.forEach(x -> assertTrue(x == one || x == two)),
807	<	() -> c.stream().forEach(x -> assertTrue(x == one || x == two)),
806	>	() -> c.forEach(checkSanity),
807	>	() -> c.stream().forEach(checkSanity),
808	>	() -> c.parallelStream().forEach(checkSanity),
809		() -> c.spliterator().trySplit(),
810		() -> {
811		Spliterator s = c.spliterator();
812	<	s.tryAdvance(x -> assertTrue(x == one || x == two));
812	>	s.tryAdvance(checkSanity);
813		s.trySplit();
814		},
815		() -> {
816		Spliterator s = c.spliterator();
817	<	do {} while (s.tryAdvance(x -> assertTrue(x == one || x == two)));
564	<	},
565	<	() -> {
566	<	for (Object x : c) assertTrue(x == one || x == two);
567	<	},
568	<	() -> {
569	<	for (Object x : c.toArray()) assertTrue(x == one || x == two);
570	<	},
571	<	() -> {
572	<	for (Object x : c.toArray(emptyArray)) assertTrue(x == one || x == two);
817	>	do {} while (s.tryAdvance(checkSanity));
818		},
819	+	() -> { for (Object x : c) checkSanity.accept(x); },
820	+	() -> checkArraySanity.accept(c.toArray()),
821	+	() -> checkArraySanity.accept(c.toArray(emptyArray)),
822		() -> {
823	<	assertTrue(c.add(one));
824	<	assertTrue(c.contains(one));
825	<	assertTrue(c.remove(one));
826	<	assertFalse(c.contains(one));
827	<	},
828	<	() -> {
829	<	assertTrue(c.add(two));
830	<	assertTrue(c.contains(two));
831	<	assertTrue(c.remove(two));
832	<	assertFalse(c.contains(two));
833	<	},
823	>	Object[] a = new Object[5];
824	>	Object three = impl.makeElement(3);
825	>	Arrays.fill(a, 0, a.length, three);
826	>	Object[] x = c.toArray(a);
827	>	if (x == a)
828	>	for (int i = 0; i < a.length && a[i] != null; i++)
829	>	checkSanity.accept(a[i]);
830	>	// A careful reading of the spec does not support:
831	>	// for (i++; i < a.length; i++) assertSame(three, a[i]);
832	>	else
833	>	checkArraySanity.accept(x);
834	>	},
835	>	adderRemover(c, one),
836	>	adderRemover(c, two),
837		};
838		final List<Runnable> tasks =
839		Arrays.stream(frobbers)
#	Line 606 | Line 857 | public class Collection8Test extends JSR
857		assertNull(future.get(0L, MILLISECONDS));
858		}
859
860	+	/**
861	+	* Spliterators are either IMMUTABLE or truly late-binding or, if
862	+	* concurrent, use the same "late-binding style" of returning
863	+	* elements added between creation and first use.
864	+	*/
865	+	public void testLateBindingStyle() {
866	+	if (!testImplementationDetails) return;
867	+	if (impl.klazz() == ArrayList.class) return; // for jdk8
868	+	// Immutable (snapshot) spliterators are exempt
869	+	if (impl.emptyCollection().spliterator()
870	+	.hasCharacteristics(Spliterator.IMMUTABLE))
871	+	return;
872	+	final Object one = impl.makeElement(1);
873	+	{
874	+	final Collection c = impl.emptyCollection();
875	+	final Spliterator split = c.spliterator();
876	+	c.add(one);
877	+	assertTrue(split.tryAdvance(e -> { assertSame(e, one); }));
878	+	assertFalse(split.tryAdvance(e -> { throw new AssertionError(); }));
879	+	assertTrue(c.contains(one));
880	+	}
881	+	{
882	+	final AtomicLong count = new AtomicLong(0);
883	+	final Collection c = impl.emptyCollection();
884	+	final Spliterator split = c.spliterator();
885	+	c.add(one);
886	+	split.forEachRemaining(
887	+	e -> { assertSame(e, one); count.getAndIncrement(); });
888	+	assertEquals(1L, count.get());
889	+	assertFalse(split.tryAdvance(e -> { throw new AssertionError(); }));
890	+	assertTrue(c.contains(one));
891	+	}
892	+	}
893	+
894	+	/**
895	+	* Spliterator.getComparator throws IllegalStateException iff the
896	+	* spliterator does not report SORTED.
897	+	*/
898	+	public void testGetComparator_IllegalStateException() {
899	+	Collection c = impl.emptyCollection();
900	+	Spliterator s = c.spliterator();
901	+	boolean reportsSorted = s.hasCharacteristics(Spliterator.SORTED);
902	+	try {
903	+	s.getComparator();
904	+	assertTrue(reportsSorted);
905	+	} catch (IllegalStateException ex) {
906	+	assertFalse(reportsSorted);
907	+	}
908	+	}
909	+
910	+	public void testCollectionCopies() throws Exception {
911	+	ThreadLocalRandom rnd = ThreadLocalRandom.current();
912	+	Collection c = impl.emptyCollection();
913	+	for (int n = rnd.nextInt(4); n--> 0; )
914	+	c.add(impl.makeElement(rnd.nextInt()));
915	+	assertEquals(c, c);
916	+	if (c instanceof List)
917	+	assertCollectionsEquals(c, new ArrayList(c));
918	+	else if (c instanceof Set)
919	+	assertCollectionsEquals(c, new HashSet(c));
920	+	else if (c instanceof Deque)
921	+	assertCollectionsEquivalent(c, new ArrayDeque(c));
922	+
923	+	Collection clone = cloneableClone(c);
924	+	if (clone != null) {
925	+	assertSame(c.getClass(), clone.getClass());
926	+	assertCollectionsEquivalent(c, clone);
927	+	}
928	+	try {
929	+	Collection serialClone = serialClonePossiblyFailing(c);
930	+	assertSame(c.getClass(), serialClone.getClass());
931	+	assertCollectionsEquivalent(c, serialClone);
932	+	} catch (java.io.NotSerializableException acceptable) {}
933	+	}
934	+
935		//     public void testCollection8DebugFail() {
936		//         fail(impl.klazz().getSimpleName());
937		//     }

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines