[ViewVC] Diff of: jsr166/jsr166/src/test/tck/Collection8Test.java

Comparing jsr166/src/test/tck/Collection8Test.java (file contents):
Revision 1.24 by jsr166, Mon Nov 14 23:52:22 2016 UTC vs.
Revision 1.45 by jsr166, Mon Dec 26 19:54:46 2016 UTC

+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
-+
+import java.util.ConcurrentModificationException;
+import java.util.Deque;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Spliterator;
+import java.util.concurrent.BlockingDeque;
+import java.util.concurrent.BlockingQueue;
-+
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
-+
+import java.util.concurrent.Phaser;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Consumer;
+import java.util.function.Predicate;
-+
+import java.util.stream.Collectors;
+import junit.framework.Test;
+            switch (rnd.nextInt(4)) {
+            case 0: survivors.addAll(c); break;
+            case 1: survivors.addAll(Arrays.asList(c.toArray())); break;
-<
+            case 2: c.forEach(e -> survivors.add(e)); break;
->
+            case 2: c.forEach(survivors::add); break;
+            case 3: for (Object e : c) survivors.add(e); break;
+            assertTrue(orig.containsAll(accepts));
+    /**
-+
+     * All elements removed in the middle of CONCURRENT traversal.
-+
+     */
-+
+    public void testElementRemovalDuringTraversal() {
-+
+        Collection c = impl.emptyCollection();
-+
+        ThreadLocalRandom rnd = ThreadLocalRandom.current();
-+
+        int n = rnd.nextInt(6);
-+
+        ArrayList copy = new ArrayList();
-+
+        for (int i = 0; i < n; i++) {
-+
+            Object x = impl.makeElement(i);
-+
+            copy.add(x);
-+
+            c.add(x);
-+
+        }
-+
+        ArrayList iterated = new ArrayList();
-+
+        ArrayList spliterated = new ArrayList();
-+
+        Spliterator s = c.spliterator();
-+
+        Iterator it = c.iterator();
-+
+        for (int i = rnd.nextInt(n + 1); --i >= 0; ) {
-+
+            assertTrue(s.tryAdvance(spliterated::add));
-+
+            if (rnd.nextBoolean()) assertTrue(it.hasNext());
-+
+            iterated.add(it.next());
-+
+        }
-+
+        Consumer alwaysThrows = e -> { throw new AssertionError(); };
-+
+        if (s.hasCharacteristics(Spliterator.CONCURRENT)) {
-+
+            c.clear();          // TODO: many more removal methods
-+
+            if (testImplementationDetails
-+
+                && !(c instanceof java.util.concurrent.ArrayBlockingQueue)) {
-+
+                if (rnd.nextBoolean())
-+
+                    assertFalse(s.tryAdvance(alwaysThrows));
-+
+                else
-+
+                    s.forEachRemaining(alwaysThrows);
-+
+            }
-+
+            if (it.hasNext()) iterated.add(it.next());
-+
+            if (rnd.nextBoolean()) assertIteratorExhausted(it);
-+
+        }
-+
+        assertTrue(copy.containsAll(iterated));
-+
+        assertTrue(copy.containsAll(spliterated));
-+
+    }
-+
-+
+    /**
-+
+     * Some elements randomly disappear in the middle of traversal.
-+
+     */
-+
+    public void testRandomElementRemovalDuringTraversal() {
-+
+        Collection c = impl.emptyCollection();
-+
+        ThreadLocalRandom rnd = ThreadLocalRandom.current();
-+
+        int n = rnd.nextInt(6);
-+
+        ArrayList copy = new ArrayList();
-+
+        for (int i = 0; i < n; i++) {
-+
+            Object x = impl.makeElement(i);
-+
+            copy.add(x);
-+
+            c.add(x);
-+
+        }
-+
+        ArrayList iterated = new ArrayList();
-+
+        ArrayList spliterated = new ArrayList();
-+
+        ArrayList removed = new ArrayList();
-+
+        Spliterator s = c.spliterator();
-+
+        Iterator it = c.iterator();
-+
+        if (! (s.hasCharacteristics(Spliterator.CONCURRENT) ||
-+
+               s.hasCharacteristics(Spliterator.IMMUTABLE)))
-+
+            return;
-+
+        for (int i = rnd.nextInt(n + 1); --i >= 0; ) {
-+
+            assertTrue(s.tryAdvance(e -> {}));
-+
+            if (rnd.nextBoolean()) assertTrue(it.hasNext());
-+
+            it.next();
-+
+        }
-+
+        Consumer alwaysThrows = e -> { throw new AssertionError(); };
-+
+        // TODO: many more removal methods
-+
+        if (rnd.nextBoolean()) {
-+
+            for (Iterator z = c.iterator(); z.hasNext(); ) {
-+
+                Object e = z.next();
-+
+                if (rnd.nextBoolean()) {
-+
+                    try {
-+
+                        z.remove();
-+
+                    } catch (UnsupportedOperationException ok) { return; }
-+
+                    removed.add(e);
-+
+                }
-+
+            }
-+
+        } else {
-+
+            Predicate randomlyRemove = e -> {
-+
+                if (rnd.nextBoolean()) { removed.add(e); return true; }
-+
+                else return false;
-+
+            };
-+
+            c.removeIf(randomlyRemove);
-+
+        }
-+
+        s.forEachRemaining(spliterated::add);
-+
+        while (it.hasNext())
-+
+            iterated.add(it.next());
-+
+        assertTrue(copy.containsAll(iterated));
-+
+        assertTrue(copy.containsAll(spliterated));
-+
+        assertTrue(copy.containsAll(removed));
-+
+        if (s.hasCharacteristics(Spliterator.CONCURRENT)) {
-+
+            ArrayList iteratedAndRemoved = new ArrayList(iterated);
-+
+            ArrayList spliteratedAndRemoved = new ArrayList(spliterated);
-+
+            iteratedAndRemoved.retainAll(removed);
-+
+            spliteratedAndRemoved.retainAll(removed);
-+
+            assertTrue(iteratedAndRemoved.size() <= 1);
-+
+            assertTrue(spliteratedAndRemoved.size() <= 1);
-+
+            if (testImplementationDetails
-+
+                && !(c instanceof java.util.concurrent.ArrayBlockingQueue))
-+
+                assertTrue(spliteratedAndRemoved.isEmpty());
-+
+        }
-+
+    }
-+
-+
+    /**
+     * Various ways of traversing a collection yield same elements
+     */
-<
+    public void testIteratorEquivalence() {
->
+    public void testTraversalEquivalence() {
+        Collection c = impl.emptyCollection();
+        ThreadLocalRandom rnd = ThreadLocalRandom.current();
+        int n = rnd.nextInt(6);
+        ArrayList iteratedForEachRemaining = new ArrayList();
+        ArrayList tryAdvanced = new ArrayList();
+        ArrayList spliterated = new ArrayList();
-+
+        ArrayList splitonced = new ArrayList();
+        ArrayList forEached = new ArrayList();
-+
+        ArrayList streamForEached = new ArrayList();
-+
+        ConcurrentLinkedQueue parallelStreamForEached = new ConcurrentLinkedQueue();
+        ArrayList removeIfed = new ArrayList();
+        for (Object x : c) iterated.add(x);
-<
+        c.iterator().forEachRemaining(e -> iteratedForEachRemaining.add(e));
->
+        c.iterator().forEachRemaining(iteratedForEachRemaining::add);
+        for (Spliterator s = c.spliterator();
-<
+             s.tryAdvance(e -> tryAdvanced.add(e)); ) {}
-<
+        c.spliterator().forEachRemaining(e -> spliterated.add(e));
-<
+        c.forEach(e -> forEached.add(e));
->
+             s.tryAdvance(tryAdvanced::add); ) {}
->
+        c.spliterator().forEachRemaining(spliterated::add);
->
+        {                       // trySplit returns "strict prefix"
->
+            Spliterator s1 = c.spliterator(), s2 = s1.trySplit();
->
+            if (s2 != null) s2.forEachRemaining(splitonced::add);
->
+            s1.forEachRemaining(splitonced::add);
->
+        }
->
+        c.forEach(forEached::add);
->
+        c.stream().forEach(streamForEached::add);
->
+        c.parallelStream().forEach(parallelStreamForEached::add);
+        c.removeIf(e -> { removeIfed.add(e); return false; });
+        boolean ordered =
+            c.spliterator().hasCharacteristics(Spliterator.ORDERED);
+        if (c instanceof List || c instanceof Deque)
+            assertTrue(ordered);
-+
+        HashSet cset = new HashSet(c);
-+
+        assertEquals(cset, new HashSet(parallelStreamForEached));
+        if (ordered) {
+            assertEquals(iterated, iteratedForEachRemaining);
+            assertEquals(iterated, tryAdvanced);
+            assertEquals(iterated, spliterated);
-+
+            assertEquals(iterated, splitonced);
+            assertEquals(iterated, forEached);
-+
+            assertEquals(iterated, streamForEached);
+            assertEquals(iterated, removeIfed);
+        } else {
-–
+            HashSet cset = new HashSet(c);
+            assertEquals(cset, new HashSet(iterated));
+            assertEquals(cset, new HashSet(iteratedForEachRemaining));
+            assertEquals(cset, new HashSet(tryAdvanced));
+            assertEquals(cset, new HashSet(spliterated));
-+
+            assertEquals(cset, new HashSet(splitonced));
+            assertEquals(cset, new HashSet(forEached));
-+
+            assertEquals(cset, new HashSet(streamForEached));
+            assertEquals(cset, new HashSet(removeIfed));
+        if (c instanceof Deque) {
+    /**
-+
+     * Iterator.forEachRemaining has same behavior as Iterator's
-+
+     * default implementation.
-+
+     */
-+
+    public void testForEachRemainingConsistentWithDefaultImplementation() {
-+
+        Collection c = impl.emptyCollection();
-+
+        if (!testImplementationDetails
-+
+            || c.getClass() == java.util.LinkedList.class)
-+
+            return;
-+
+        ThreadLocalRandom rnd = ThreadLocalRandom.current();
-+
+        int n = 1 + rnd.nextInt(3);
-+
+        for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
-+
+        ArrayList iterated = new ArrayList();
-+
+        ArrayList iteratedForEachRemaining = new ArrayList();
-+
+        Iterator it1 = c.iterator();
-+
+        Iterator it2 = c.iterator();
-+
+        assertTrue(it1.hasNext());
-+
+        assertTrue(it2.hasNext());
-+
+        c.clear();
-+
+        Object r1, r2;
-+
+        try {
-+
+            while (it1.hasNext()) iterated.add(it1.next());
-+
+            r1 = iterated;
-+
+        } catch (ConcurrentModificationException ex) {
-+
+            r1 = ConcurrentModificationException.class;
-+
+            assertFalse(impl.isConcurrent());
-+
+        }
-+
+        try {
-+
+            it2.forEachRemaining(iteratedForEachRemaining::add);
-+
+            r2 = iteratedForEachRemaining;
-+
+        } catch (ConcurrentModificationException ex) {
-+
+            r2 = ConcurrentModificationException.class;
-+
+            assertFalse(impl.isConcurrent());
-+
+        }
-+
+        assertEquals(r1, r2);
-+
+    }
-+
-+
+    /**
+     * Calling Iterator#remove() after Iterator#forEachRemaining
+     * should (maybe) remove last element
+     */
+    public void testRemoveAfterForEachRemaining() {
+        Collection c = impl.emptyCollection();
+        ThreadLocalRandom rnd = ThreadLocalRandom.current();
-<
+        {
->
+        testCollection: {
+            int n = 3 + rnd.nextInt(2);
+            for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
+            Iterator it = c.iterator();
+                if (c instanceof java.util.concurrent.ArrayBlockingQueue) {
+                    assertIteratorExhausted(it);
+                } else {
-<
+                    it.remove();
->
+                    try { it.remove(); }
->
+                    catch (UnsupportedOperationException ok) {
->
+                        break testCollection;
->
+                    }
+                    assertEquals(n - 1, c.size());
+                    for (int i = 0; i < n - 1; i++)
+                        assertTrue(c.contains(impl.makeElement(i)));
+        assertTrue(found.isEmpty());
-<
+    public void testForEachConcurrentStressTest() throws Throwable {
->
+    /** TODO: promote to a common utility */
->
+    static <T> T chooseOne(T ... ts) {
->
+        return ts[ThreadLocalRandom.current().nextInt(ts.length)];
->
+    }
->
->
+    /** TODO: more random adders and removers */
->
+    static <E> Runnable adderRemover(Collection<E> c, E e) {
->
+        return chooseOne(
->
+            () -> {
->
+                assertTrue(c.add(e));
->
+                assertTrue(c.contains(e));
->
+                assertTrue(c.remove(e));
->
+                assertFalse(c.contains(e));
->
+            },
->
+            () -> {
->
+                assertTrue(c.add(e));
->
+                assertTrue(c.contains(e));
->
+                assertTrue(c.removeIf(x -> x == e));
->
+                assertFalse(c.contains(e));
->
+            },
->
+            () -> {
->
+                assertTrue(c.add(e));
->
+                assertTrue(c.contains(e));
->
+                for (Iterator it = c.iterator();; )
->
+                    if (it.next() == e) {
->
+                        try { it.remove(); }
->
+                        catch (UnsupportedOperationException ok) {
->
+                            c.remove(e);
->
+                        }
->
+                        break;
->
+                    }
->
+                assertFalse(c.contains(e));
->
+            });
->
+    }
->
->
+    /**
->
+     * Concurrent Spliterators, once exhausted, stay exhausted.
->
+     */
->
+    public void testStickySpliteratorExhaustion() throws Throwable {
+        if (!impl.isConcurrent()) return;
-+
+        if (!testImplementationDetails) return;
-+
+        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
-+
+        final Consumer alwaysThrows = e -> { throw new AssertionError(); };
+        final Collection c = impl.emptyCollection();
-<
+        final long testDurationMillis = timeoutMillis();
->
+        final Spliterator s = c.spliterator();
->
+        if (rnd.nextBoolean()) {
->
+            assertFalse(s.tryAdvance(alwaysThrows));
->
+        } else {
->
+            s.forEachRemaining(alwaysThrows);
->
+        }
->
+        final Object one = impl.makeElement(1);
->
+        // Spliterator should not notice added element
->
+        c.add(one);
->
+        if (rnd.nextBoolean()) {
->
+            assertFalse(s.tryAdvance(alwaysThrows));
->
+        } else {
->
+            s.forEachRemaining(alwaysThrows);
->
+        }
->
+    }
->
->
+    /**
->
+     * Motley crew of threads concurrently randomly hammer the collection.
->
+     */
->
+    public void testDetectRaces() throws Throwable {
->
+        if (!impl.isConcurrent()) return;
->
+        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
->
+        final Collection c = impl.emptyCollection();
->
+        final long testDurationMillis
->
+            = expensiveTests ? LONG_DELAY_MS : timeoutMillis();
+        final AtomicBoolean done = new AtomicBoolean(false);
-<
+        final Object elt = impl.makeElement(1);
-<
+        final Future<?> f1, f2;
->
+        final Object one = impl.makeElement(1);
->
+        final Object two = impl.makeElement(2);
->
+        final Consumer checkSanity = x -> assertTrue(x == one || x == two);
->
+        final Consumer<Object[]> checkArraySanity = array -> {
->
+            // assertTrue(array.length <= 2); // duplicates are permitted
->
+            for (Object x : array) assertTrue(x == one || x == two);
->
+        };
->
+        final Object[] emptyArray =
->
+            (Object[]) java.lang.reflect.Array.newInstance(one.getClass(), 0);
->
+        final List<Future<?>> futures;
->
+        final Phaser threadsStarted = new Phaser(1); // register this thread
->
+        final Runnable[] frobbers = {
->
+            () -> c.forEach(checkSanity),
->
+            () -> c.stream().forEach(checkSanity),
->
+            () -> c.parallelStream().forEach(checkSanity),
->
+            () -> c.spliterator().trySplit(),
->
+            () -> {
->
+                Spliterator s = c.spliterator();
->
+                s.tryAdvance(checkSanity);
->
+                s.trySplit();
->
+            },
->
+            () -> {
->
+                Spliterator s = c.spliterator();
->
+                do {} while (s.tryAdvance(checkSanity));
->
+            },
->
+            () -> { for (Object x : c) checkSanity.accept(x); },
->
+            () -> checkArraySanity.accept(c.toArray()),
->
+            () -> checkArraySanity.accept(c.toArray(emptyArray)),
->
+            () -> {
->
+                Object[] a = new Object[5];
->
+                Object three = impl.makeElement(3);
->
+                Arrays.fill(a, 0, a.length, three);
->
+                Object[] x = c.toArray(a);
->
+                if (x == a)
->
+                    for (int i = 0; i < a.length && a[i] != null; i++)
->
+                        checkSanity.accept(a[i]);
->
+                    // A careful reading of the spec does not support:
->
+                    // for (i++; i < a.length; i++) assertSame(three, a[i]);
->
+                else
->
+                    checkArraySanity.accept(x);
->
+                },
->
+            adderRemover(c, one),
->
+            adderRemover(c, two),
->
+        };
->
+        final List<Runnable> tasks =
->
+            Arrays.stream(frobbers)
->
+            .filter(task -> rnd.nextBoolean()) // random subset
->
+            .map(task -> (Runnable) () -> {
->
+                     threadsStarted.arriveAndAwaitAdvance();
->
+                     while (!done.get())
->
+                         task.run();
->
+                 })
->
+            .collect(Collectors.toList());
+        final ExecutorService pool = Executors.newCachedThreadPool();
+        try (PoolCleaner cleaner = cleaner(pool, done)) {
-<
+            final CountDownLatch threadsStarted = new CountDownLatch(2);
-<
+            Runnable checkElt = () -> {
-<
+                threadsStarted.countDown();
-<
+                while (!done.get())
-<
+                    c.forEach(x -> assertSame(x, elt)); };
-<
+            Runnable addRemove = () -> {
-<
+                threadsStarted.countDown();
-<
+                while (!done.get()) {
-<
+                    assertTrue(c.add(elt));
-<
+                    assertTrue(c.remove(elt));
-<
+                }};
-<
+            f1 = pool.submit(checkElt);
-<
+            f2 = pool.submit(addRemove);
->
+            threadsStarted.bulkRegister(tasks.size());
->
+            futures = tasks.stream()
->
+                .map(pool::submit)
->
+                .collect(Collectors.toList());
->
+            threadsStarted.arriveAndDeregister();
+            Thread.sleep(testDurationMillis);
-<
+        assertNull(f1.get(0L, MILLISECONDS));
-<
+        assertNull(f2.get(0L, MILLISECONDS));
->
+        for (Future future : futures)
->
+            assertNull(future.get(0L, MILLISECONDS));
->
+    }
->
->
+    /**
->
+     * Spliterators are either IMMUTABLE or truly late-binding or, if
->
+     * concurrent, use the same "late-binding style" of returning
->
+     * elements added between creation and first use.
->
+     */
->
+    public void testLateBindingStyle() {
->
+        if (!testImplementationDetails) return;
->
+        if (impl.klazz() == ArrayList.class) return; // for jdk8
->
+        // Immutable (snapshot) spliterators are exempt
->
+        if (impl.emptyCollection().spliterator()
->
+            .hasCharacteristics(Spliterator.IMMUTABLE))
->
+            return;
->
+        final Object one = impl.makeElement(1);
->
+        {
->
+            final Collection c = impl.emptyCollection();
->
+            final Spliterator split = c.spliterator();
->
+            c.add(one);
->
+            assertTrue(split.tryAdvance(e -> { assertSame(e, one); }));
->
+            assertFalse(split.tryAdvance(e -> { throw new AssertionError(); }));
->
+            assertTrue(c.contains(one));
->
+        }
->
+        {
->
+            final AtomicLong count = new AtomicLong(0);
->
+            final Collection c = impl.emptyCollection();
->
+            final Spliterator split = c.spliterator();
->
+            c.add(one);
->
+            split.forEachRemaining(
->
+                e -> { assertSame(e, one); count.getAndIncrement(); });
->
+            assertEquals(1L, count.get());
->
+            assertFalse(split.tryAdvance(e -> { throw new AssertionError(); }));
->
+            assertTrue(c.contains(one));
->
+        }
->
+    }
->
->
+    /**
->
+     * Spliterator.getComparator throws IllegalStateException iff the
->
+     * spliterator does not report SORTED.
->
+     */
->
+    public void testGetComparator_IllegalStateException() {
->
+        Collection c = impl.emptyCollection();
->
+        Spliterator s = c.spliterator();
->
+        boolean reportsSorted = s.hasCharacteristics(Spliterator.SORTED);
->
+        try {
->
+            s.getComparator();
->
+            assertTrue(reportsSorted);
->
+        } catch (IllegalStateException ex) {
->
+            assertFalse(reportsSorted);
->
+        }
+//     public void testCollection8DebugFail() {

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing jsr166/src/test/tck/Collection8Test.java (file contents): Revision 1.24 by jsr166, Mon Nov 14 23:52:22 2016 UTC vs. Revision 1.45 by jsr166, Mon Dec 26 19:54:46 2016 UTC

Diff Legend

Comparing jsr166/src/test/tck/Collection8Test.java (file contents):
Revision 1.24 by jsr166, Mon Nov 14 23:52:22 2016 UTC vs.
Revision 1.45 by jsr166, Mon Dec 26 19:54:46 2016 UTC