ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/Collection8Test.java

Comparing jsr166/src/test/tck/Collection8Test.java (file contents):
Revision 1.5 by jsr166, Tue Oct 25 01:32:55 2016 UTC vs.
Revision 1.45 by jsr166, Mon Dec 26 19:54:46 2016 UTC

#	Line 5 | Line 5
5		* http://creativecommons.org/publicdomain/zero/1.0/
6		*/
7
8	+	import static java.util.concurrent.TimeUnit.HOURS;
9		import static java.util.concurrent.TimeUnit.MILLISECONDS;
10
11		import java.util.ArrayList;
12	+	import java.util.Arrays;
13		import java.util.Collection;
14		import java.util.Collections;
15	+	import java.util.ConcurrentModificationException;
16		import java.util.Deque;
17		import java.util.HashSet;
18		import java.util.Iterator;
#	Line 17 | Line 20 | import java.util.List;
20		import java.util.NoSuchElementException;
21		import java.util.Queue;
22		import java.util.Spliterator;
23	+	import java.util.concurrent.BlockingDeque;
24	+	import java.util.concurrent.BlockingQueue;
25	+	import java.util.concurrent.ConcurrentLinkedQueue;
26		import java.util.concurrent.CountDownLatch;
27		import java.util.concurrent.Executors;
28		import java.util.concurrent.ExecutorService;
29		import java.util.concurrent.Future;
30	+	import java.util.concurrent.Phaser;
31		import java.util.concurrent.ThreadLocalRandom;
32		import java.util.concurrent.atomic.AtomicBoolean;
33		import java.util.concurrent.atomic.AtomicLong;
34		import java.util.concurrent.atomic.AtomicReference;
35		import java.util.function.Consumer;
36		import java.util.function.Predicate;
37	+	import java.util.stream.Collectors;
38
39		import junit.framework.Test;
40
#	Line 49 | Line 57 | public class Collection8Test extends JSR
57		impl);
58		}
59
60	+	Object bomb() {
61	+	return new Object() {
62	+	public boolean equals(Object x) { throw new AssertionError(); }
63	+	public int hashCode() { throw new AssertionError(); }
64	+	};
65	+	}
66	+
67		/** Checks properties of empty collections. */
68	<	public void testEmptyMeansEmpty() {
68	>	public void testEmptyMeansEmpty() throws Throwable {
69		Collection c = impl.emptyCollection();
70	+	emptyMeansEmpty(c);
71	+
72	+	if (c instanceof java.io.Serializable) {
73	+	try {
74	+	emptyMeansEmpty(serialClonePossiblyFailing(c));
75	+	} catch (java.io.NotSerializableException ex) {
76	+	// excusable when we have a serializable wrapper around
77	+	// a non-serializable collection, as can happen with:
78	+	// Vector.subList() => wrapped AbstractList$RandomAccessSubList
79	+	if (testImplementationDetails
80	+	&& (! c.getClass().getName().matches(
81	+	"java.util.Collections.*")))
82	+	throw ex;
83	+	}
84	+	}
85	+
86	+	Collection clone = cloneableClone(c);
87	+	if (clone != null)
88	+	emptyMeansEmpty(clone);
89	+	}
90	+
91	+	void emptyMeansEmpty(Collection c) throws InterruptedException {
92		assertTrue(c.isEmpty());
93		assertEquals(0, c.size());
94		assertEquals("[]", c.toString());
#	Line 76 | Line 113 | public class Collection8Test extends JSR
113		assertSame(3, a[2]);
114		}
115		assertIteratorExhausted(c.iterator());
116	<	Consumer alwaysThrows = (e) -> { throw new AssertionError(); };
116	>	Consumer alwaysThrows = e -> { throw new AssertionError(); };
117		c.forEach(alwaysThrows);
118		c.iterator().forEachRemaining(alwaysThrows);
119		c.spliterator().forEachRemaining(alwaysThrows);
120		assertFalse(c.spliterator().tryAdvance(alwaysThrows));
121	<	if (Queue.class.isAssignableFrom(impl.klazz())) {
121	>	if (c.spliterator().hasCharacteristics(Spliterator.SIZED))
122	>	assertEquals(0, c.spliterator().estimateSize());
123	>	assertFalse(c.contains(bomb()));
124	>	assertFalse(c.remove(bomb()));
125	>	if (c instanceof Queue) {
126		Queue q = (Queue) c;
127		assertNull(q.peek());
128		assertNull(q.poll());
129		}
130	<	if (Deque.class.isAssignableFrom(impl.klazz())) {
130	>	if (c instanceof Deque) {
131		Deque d = (Deque) c;
132		assertNull(d.peekFirst());
133		assertNull(d.peekLast());
134		assertNull(d.pollFirst());
135		assertNull(d.pollLast());
136		assertIteratorExhausted(d.descendingIterator());
137	+	d.descendingIterator().forEachRemaining(alwaysThrows);
138	+	assertFalse(d.removeFirstOccurrence(bomb()));
139	+	assertFalse(d.removeLastOccurrence(bomb()));
140	+	}
141	+	if (c instanceof BlockingQueue) {
142	+	BlockingQueue q = (BlockingQueue) c;
143	+	assertNull(q.poll(0L, MILLISECONDS));
144	+	}
145	+	if (c instanceof BlockingDeque) {
146	+	BlockingDeque q = (BlockingDeque) c;
147	+	assertNull(q.pollFirst(0L, MILLISECONDS));
148	+	assertNull(q.pollLast(0L, MILLISECONDS));
149		}
150		}
151
152	<	public void testNullPointerExceptions() {
152	>	public void testNullPointerExceptions() throws InterruptedException {
153		Collection c = impl.emptyCollection();
154		assertThrows(
155		NullPointerException.class,
#	Line 105 | Line 158 | public class Collection8Test extends JSR
158		() -> c.retainAll(null),
159		() -> c.removeAll(null),
160		() -> c.removeIf(null),
161	+	() -> c.forEach(null),
162	+	() -> c.iterator().forEachRemaining(null),
163	+	() -> c.spliterator().forEachRemaining(null),
164	+	() -> c.spliterator().tryAdvance(null),
165		() -> c.toArray(null));
166
167		if (!impl.permitsNulls()) {
#	Line 112 | Line 169 | public class Collection8Test extends JSR
169		NullPointerException.class,
170		() -> c.add(null));
171		}
172	<	if (!impl.permitsNulls()
116	<	&& Queue.class.isAssignableFrom(impl.klazz())) {
172	>	if (!impl.permitsNulls() && c instanceof Queue) {
173		Queue q = (Queue) c;
174		assertThrows(
175		NullPointerException.class,
176		() -> q.offer(null));
177		}
178	<	if (!impl.permitsNulls()
123	<	&& Deque.class.isAssignableFrom(impl.klazz())) {
178	>	if (!impl.permitsNulls() && c instanceof Deque) {
179		Deque d = (Deque) c;
180		assertThrows(
181		NullPointerException.class,
#	Line 128 | Line 183 | public class Collection8Test extends JSR
183		() -> d.addLast(null),
184		() -> d.offerFirst(null),
185		() -> d.offerLast(null),
186	<	() -> d.push(null));
186	>	() -> d.push(null),
187	>	() -> d.descendingIterator().forEachRemaining(null));
188	>	}
189	>	if (c instanceof BlockingQueue) {
190	>	BlockingQueue q = (BlockingQueue) c;
191	>	assertThrows(
192	>	NullPointerException.class,
193	>	() -> {
194	>	try { q.offer(null, 1L, HOURS); }
195	>	catch (InterruptedException ex) {
196	>	throw new AssertionError(ex);
197	>	}},
198	>	() -> {
199	>	try { q.put(null); }
200	>	catch (InterruptedException ex) {
201	>	throw new AssertionError(ex);
202	>	}});
203	>	}
204	>	if (c instanceof BlockingDeque) {
205	>	BlockingDeque q = (BlockingDeque) c;
206	>	assertThrows(
207	>	NullPointerException.class,
208	>	() -> {
209	>	try { q.offerFirst(null, 1L, HOURS); }
210	>	catch (InterruptedException ex) {
211	>	throw new AssertionError(ex);
212	>	}},
213	>	() -> {
214	>	try { q.offerLast(null, 1L, HOURS); }
215	>	catch (InterruptedException ex) {
216	>	throw new AssertionError(ex);
217	>	}},
218	>	() -> {
219	>	try { q.putFirst(null); }
220	>	catch (InterruptedException ex) {
221	>	throw new AssertionError(ex);
222	>	}},
223	>	() -> {
224	>	try { q.putLast(null); }
225	>	catch (InterruptedException ex) {
226	>	throw new AssertionError(ex);
227	>	}});
228		}
229		}
230
#	Line 138 | Line 234 | public class Collection8Test extends JSR
234		NoSuchElementException.class,
235		() -> c.iterator().next());
236
237	<	if (Queue.class.isAssignableFrom(impl.klazz())) {
237	>	if (c instanceof Queue) {
238		Queue q = (Queue) c;
239		assertThrows(
240		NoSuchElementException.class,
241		() -> q.element(),
242		() -> q.remove());
243		}
244	<	if (Deque.class.isAssignableFrom(impl.klazz())) {
244	>	if (c instanceof Deque) {
245		Deque d = (Deque) c;
246		assertThrows(
247		NoSuchElementException.class,
#	Line 160 | Line 256 | public class Collection8Test extends JSR
256
257		public void testRemoveIf() {
258		Collection c = impl.emptyCollection();
259	+	boolean ordered =
260	+	c.spliterator().hasCharacteristics(Spliterator.ORDERED);
261		ThreadLocalRandom rnd = ThreadLocalRandom.current();
262		int n = rnd.nextInt(6);
263		for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
264		AtomicReference threwAt = new AtomicReference(null);
265	<	ArrayList survivors = new ArrayList(c);
265	>	List orig = rnd.nextBoolean()
266	>	? new ArrayList(c)
267	>	: Arrays.asList(c.toArray());
268	>
269	>	// Merely creating an iterator can change ArrayBlockingQueue behavior
270	>	Iterator it = rnd.nextBoolean() ? c.iterator() : null;
271	>
272	>	ArrayList survivors = new ArrayList();
273		ArrayList accepts = new ArrayList();
274		ArrayList rejects = new ArrayList();
275	<	Predicate randomPredicate = (e) -> {
275	>
276	>	Predicate randomPredicate = e -> {
277		assertNull(threwAt.get());
278		switch (rnd.nextInt(3)) {
279		case 0: accepts.add(e); return true;
#	Line 177 | Line 283 | public class Collection8Test extends JSR
283		}
284		};
285		try {
286	<	boolean modified = c.removeIf(randomPredicate);
287	<	if (!modified) {
286	>	try {
287	>	boolean modified = c.removeIf(randomPredicate);
288		assertNull(threwAt.get());
289	<	assertEquals(n, rejects.size());
290	<	assertEquals(0, accepts.size());
289	>	assertEquals(modified, accepts.size() > 0);
290	>	assertEquals(modified, rejects.size() != n);
291	>	assertEquals(accepts.size() + rejects.size(), n);
292	>	if (ordered) {
293	>	assertEquals(rejects,
294	>	Arrays.asList(c.toArray()));
295	>	} else {
296	>	assertEquals(new HashSet(rejects),
297	>	new HashSet(Arrays.asList(c.toArray())));
298	>	}
299	>	} catch (ArithmeticException ok) {
300	>	assertNotNull(threwAt.get());
301	>	assertTrue(c.contains(threwAt.get()));
302	>	}
303	>	if (it != null && impl.isConcurrent())
304	>	// check for weakly consistent iterator
305	>	while (it.hasNext()) assertTrue(orig.contains(it.next()));
306	>	switch (rnd.nextInt(4)) {
307	>	case 0: survivors.addAll(c); break;
308	>	case 1: survivors.addAll(Arrays.asList(c.toArray())); break;
309	>	case 2: c.forEach(survivors::add); break;
310	>	case 3: for (Object e : c) survivors.add(e); break;
311		}
312	<	} catch (ArithmeticException ok) {}
313	<	survivors.removeAll(accepts);
314	<	if (n - accepts.size() != c.size()) {
312	>	assertTrue(orig.containsAll(accepts));
313	>	assertTrue(orig.containsAll(rejects));
314	>	assertTrue(orig.containsAll(survivors));
315	>	assertTrue(orig.containsAll(c));
316	>	assertTrue(c.containsAll(rejects));
317	>	assertTrue(c.containsAll(survivors));
318	>	assertTrue(survivors.containsAll(rejects));
319	>	if (threwAt.get() == null) {
320	>	assertEquals(n - accepts.size(), c.size());
321	>	for (Object x : accepts) assertFalse(c.contains(x));
322	>	} else {
323	>	// Two acceptable behaviors: entire removeIf call is one
324	>	// transaction, or each element processed is one transaction.
325	>	assertTrue(n == c.size() || n == c.size() + accepts.size());
326	>	int k = 0;
327	>	for (Object x : accepts) if (c.contains(x)) k++;
328	>	assertTrue(k == accepts.size() || k == 0);
329	>	}
330	>	} catch (Throwable ex) {
331		System.err.println(impl.klazz());
332	<	System.err.println(c);
333	<	System.err.println(accepts);
334	<	System.err.println(rejects);
335	<	System.err.println(survivors);
336	<	System.err.println(threwAt.get());
337	<	}
338	<	assertEquals(n - accepts.size(), c.size());
339	<	assertTrue(c.containsAll(survivors));
340	<	assertTrue(survivors.containsAll(rejects));
341	<	for (Object x : accepts) assertFalse(c.contains(x));
342	<	if (threwAt.get() == null)
343	<	assertEquals(accepts.size() + rejects.size(), n);
332	>	// c is at risk of corruption if we got here, so be lenient
333	>	try { System.err.printf("c=%s%n", c); }
334	>	catch (Throwable t) { t.printStackTrace(); }
335	>	System.err.printf("n=%d%n", n);
336	>	System.err.printf("orig=%s%n", orig);
337	>	System.err.printf("accepts=%s%n", accepts);
338	>	System.err.printf("rejects=%s%n", rejects);
339	>	System.err.printf("survivors=%s%n", survivors);
340	>	System.err.printf("threwAt=%s%n", threwAt.get());
341	>	throw ex;
342	>	}
343	>	}
344	>
345	>	/**
346	>	* All elements removed in the middle of CONCURRENT traversal.
347	>	*/
348	>	public void testElementRemovalDuringTraversal() {
349	>	Collection c = impl.emptyCollection();
350	>	ThreadLocalRandom rnd = ThreadLocalRandom.current();
351	>	int n = rnd.nextInt(6);
352	>	ArrayList copy = new ArrayList();
353	>	for (int i = 0; i < n; i++) {
354	>	Object x = impl.makeElement(i);
355	>	copy.add(x);
356	>	c.add(x);
357	>	}
358	>	ArrayList iterated = new ArrayList();
359	>	ArrayList spliterated = new ArrayList();
360	>	Spliterator s = c.spliterator();
361	>	Iterator it = c.iterator();
362	>	for (int i = rnd.nextInt(n + 1); --i >= 0; ) {
363	>	assertTrue(s.tryAdvance(spliterated::add));
364	>	if (rnd.nextBoolean()) assertTrue(it.hasNext());
365	>	iterated.add(it.next());
366	>	}
367	>	Consumer alwaysThrows = e -> { throw new AssertionError(); };
368	>	if (s.hasCharacteristics(Spliterator.CONCURRENT)) {
369	>	c.clear();          // TODO: many more removal methods
370	>	if (testImplementationDetails
371	>	&& !(c instanceof java.util.concurrent.ArrayBlockingQueue)) {
372	>	if (rnd.nextBoolean())
373	>	assertFalse(s.tryAdvance(alwaysThrows));
374	>	else
375	>	s.forEachRemaining(alwaysThrows);
376	>	}
377	>	if (it.hasNext()) iterated.add(it.next());
378	>	if (rnd.nextBoolean()) assertIteratorExhausted(it);
379	>	}
380	>	assertTrue(copy.containsAll(iterated));
381	>	assertTrue(copy.containsAll(spliterated));
382	>	}
383	>
384	>	/**
385	>	* Some elements randomly disappear in the middle of traversal.
386	>	*/
387	>	public void testRandomElementRemovalDuringTraversal() {
388	>	Collection c = impl.emptyCollection();
389	>	ThreadLocalRandom rnd = ThreadLocalRandom.current();
390	>	int n = rnd.nextInt(6);
391	>	ArrayList copy = new ArrayList();
392	>	for (int i = 0; i < n; i++) {
393	>	Object x = impl.makeElement(i);
394	>	copy.add(x);
395	>	c.add(x);
396	>	}
397	>	ArrayList iterated = new ArrayList();
398	>	ArrayList spliterated = new ArrayList();
399	>	ArrayList removed = new ArrayList();
400	>	Spliterator s = c.spliterator();
401	>	Iterator it = c.iterator();
402	>	if (! (s.hasCharacteristics(Spliterator.CONCURRENT) ||
403	>	s.hasCharacteristics(Spliterator.IMMUTABLE)))
404	>	return;
405	>	for (int i = rnd.nextInt(n + 1); --i >= 0; ) {
406	>	assertTrue(s.tryAdvance(e -> {}));
407	>	if (rnd.nextBoolean()) assertTrue(it.hasNext());
408	>	it.next();
409	>	}
410	>	Consumer alwaysThrows = e -> { throw new AssertionError(); };
411	>	// TODO: many more removal methods
412	>	if (rnd.nextBoolean()) {
413	>	for (Iterator z = c.iterator(); z.hasNext(); ) {
414	>	Object e = z.next();
415	>	if (rnd.nextBoolean()) {
416	>	try {
417	>	z.remove();
418	>	} catch (UnsupportedOperationException ok) { return; }
419	>	removed.add(e);
420	>	}
421	>	}
422	>	} else {
423	>	Predicate randomlyRemove = e -> {
424	>	if (rnd.nextBoolean()) { removed.add(e); return true; }
425	>	else return false;
426	>	};
427	>	c.removeIf(randomlyRemove);
428	>	}
429	>	s.forEachRemaining(spliterated::add);
430	>	while (it.hasNext())
431	>	iterated.add(it.next());
432	>	assertTrue(copy.containsAll(iterated));
433	>	assertTrue(copy.containsAll(spliterated));
434	>	assertTrue(copy.containsAll(removed));
435	>	if (s.hasCharacteristics(Spliterator.CONCURRENT)) {
436	>	ArrayList iteratedAndRemoved = new ArrayList(iterated);
437	>	ArrayList spliteratedAndRemoved = new ArrayList(spliterated);
438	>	iteratedAndRemoved.retainAll(removed);
439	>	spliteratedAndRemoved.retainAll(removed);
440	>	assertTrue(iteratedAndRemoved.size() <= 1);
441	>	assertTrue(spliteratedAndRemoved.size() <= 1);
442	>	if (testImplementationDetails
443	>	&& !(c instanceof java.util.concurrent.ArrayBlockingQueue))
444	>	assertTrue(spliteratedAndRemoved.isEmpty());
445	>	}
446		}
447
448		/**
449		* Various ways of traversing a collection yield same elements
450		*/
451	<	public void testIteratorEquivalence() {
451	>	public void testTraversalEquivalence() {
452		Collection c = impl.emptyCollection();
453		ThreadLocalRandom rnd = ThreadLocalRandom.current();
454		int n = rnd.nextInt(6);
455		for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
456		ArrayList iterated = new ArrayList();
457		ArrayList iteratedForEachRemaining = new ArrayList();
458	+	ArrayList tryAdvanced = new ArrayList();
459		ArrayList spliterated = new ArrayList();
460	<	ArrayList foreached = new ArrayList();
460	>	ArrayList splitonced = new ArrayList();
461	>	ArrayList forEached = new ArrayList();
462	>	ArrayList streamForEached = new ArrayList();
463	>	ConcurrentLinkedQueue parallelStreamForEached = new ConcurrentLinkedQueue();
464	>	ArrayList removeIfed = new ArrayList();
465		for (Object x : c) iterated.add(x);
466	<	c.iterator().forEachRemaining(e -> iteratedForEachRemaining.add(e));
467	<	c.spliterator().forEachRemaining(e -> spliterated.add(e));
468	<	c.forEach(e -> foreached.add(e));
466	>	c.iterator().forEachRemaining(iteratedForEachRemaining::add);
467	>	for (Spliterator s = c.spliterator();
468	>	s.tryAdvance(tryAdvanced::add); ) {}
469	>	c.spliterator().forEachRemaining(spliterated::add);
470	>	{                       // trySplit returns "strict prefix"
471	>	Spliterator s1 = c.spliterator(), s2 = s1.trySplit();
472	>	if (s2 != null) s2.forEachRemaining(splitonced::add);
473	>	s1.forEachRemaining(splitonced::add);
474	>	}
475	>	c.forEach(forEached::add);
476	>	c.stream().forEach(streamForEached::add);
477	>	c.parallelStream().forEach(parallelStreamForEached::add);
478	>	c.removeIf(e -> { removeIfed.add(e); return false; });
479		boolean ordered =
480		c.spliterator().hasCharacteristics(Spliterator.ORDERED);
481		if (c instanceof List || c instanceof Deque)
482		assertTrue(ordered);
483	+	HashSet cset = new HashSet(c);
484	+	assertEquals(cset, new HashSet(parallelStreamForEached));
485		if (ordered) {
486		assertEquals(iterated, iteratedForEachRemaining);
487	+	assertEquals(iterated, tryAdvanced);
488		assertEquals(iterated, spliterated);
489	<	assertEquals(iterated, foreached);
489	>	assertEquals(iterated, splitonced);
490	>	assertEquals(iterated, forEached);
491	>	assertEquals(iterated, streamForEached);
492	>	assertEquals(iterated, removeIfed);
493		} else {
229	–	HashSet cset = new HashSet(c);
494		assertEquals(cset, new HashSet(iterated));
495		assertEquals(cset, new HashSet(iteratedForEachRemaining));
496	+	assertEquals(cset, new HashSet(tryAdvanced));
497		assertEquals(cset, new HashSet(spliterated));
498	<	assertEquals(cset, new HashSet(foreached));
498	>	assertEquals(cset, new HashSet(splitonced));
499	>	assertEquals(cset, new HashSet(forEached));
500	>	assertEquals(cset, new HashSet(streamForEached));
501	>	assertEquals(cset, new HashSet(removeIfed));
502		}
503		if (c instanceof Deque) {
504		Deque d = (Deque) c;
#	Line 248 | Line 516 | public class Collection8Test extends JSR
516		}
517
518		/**
519	+	* Iterator.forEachRemaining has same behavior as Iterator's
520	+	* default implementation.
521	+	*/
522	+	public void testForEachRemainingConsistentWithDefaultImplementation() {
523	+	Collection c = impl.emptyCollection();
524	+	if (!testImplementationDetails
525	+	|| c.getClass() == java.util.LinkedList.class)
526	+	return;
527	+	ThreadLocalRandom rnd = ThreadLocalRandom.current();
528	+	int n = 1 + rnd.nextInt(3);
529	+	for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
530	+	ArrayList iterated = new ArrayList();
531	+	ArrayList iteratedForEachRemaining = new ArrayList();
532	+	Iterator it1 = c.iterator();
533	+	Iterator it2 = c.iterator();
534	+	assertTrue(it1.hasNext());
535	+	assertTrue(it2.hasNext());
536	+	c.clear();
537	+	Object r1, r2;
538	+	try {
539	+	while (it1.hasNext()) iterated.add(it1.next());
540	+	r1 = iterated;
541	+	} catch (ConcurrentModificationException ex) {
542	+	r1 = ConcurrentModificationException.class;
543	+	assertFalse(impl.isConcurrent());
544	+	}
545	+	try {
546	+	it2.forEachRemaining(iteratedForEachRemaining::add);
547	+	r2 = iteratedForEachRemaining;
548	+	} catch (ConcurrentModificationException ex) {
549	+	r2 = ConcurrentModificationException.class;
550	+	assertFalse(impl.isConcurrent());
551	+	}
552	+	assertEquals(r1, r2);
553	+	}
554	+
555	+	/**
556		* Calling Iterator#remove() after Iterator#forEachRemaining
557	<	* should remove last element
557	>	* should (maybe) remove last element
558		*/
559		public void testRemoveAfterForEachRemaining() {
560		Collection c = impl.emptyCollection();
561		ThreadLocalRandom rnd = ThreadLocalRandom.current();
562	<	{
562	>	testCollection: {
563		int n = 3 + rnd.nextInt(2);
564		for (int i = 0; i < n; i++) c.add(impl.makeElement(i));
565		Iterator it = c.iterator();
#	Line 262 | Line 567 | public class Collection8Test extends JSR
567		assertEquals(impl.makeElement(0), it.next());
568		assertTrue(it.hasNext());
569		assertEquals(impl.makeElement(1), it.next());
570	<	it.forEachRemaining((e) -> {});
571	<	it.remove();
572	<	assertEquals(n - 1, c.size());
573	<	for (int i = 0; i < n - 1; i++)
574	<	assertTrue(c.contains(impl.makeElement(i)));
575	<	assertFalse(c.contains(impl.makeElement(n - 1)));
570	>	it.forEachRemaining(e -> assertTrue(c.contains(e)));
571	>	if (testImplementationDetails) {
572	>	if (c instanceof java.util.concurrent.ArrayBlockingQueue) {
573	>	assertIteratorExhausted(it);
574	>	} else {
575	>	try { it.remove(); }
576	>	catch (UnsupportedOperationException ok) {
577	>	break testCollection;
578	>	}
579	>	assertEquals(n - 1, c.size());
580	>	for (int i = 0; i < n - 1; i++)
581	>	assertTrue(c.contains(impl.makeElement(i)));
582	>	assertFalse(c.contains(impl.makeElement(n - 1)));
583	>	}
584	>	}
585		}
586		if (c instanceof Deque) {
587		Deque d = (Deque) impl.emptyCollection();
#	Line 278 | Line 592 | public class Collection8Test extends JSR
592		assertEquals(impl.makeElement(n - 1), it.next());
593		assertTrue(it.hasNext());
594		assertEquals(impl.makeElement(n - 2), it.next());
595	<	it.forEachRemaining((e) -> {});
596	<	it.remove();
597	<	assertEquals(n - 1, d.size());
598	<	for (int i = 1; i < n; i++)
599	<	assertTrue(d.contains(impl.makeElement(i)));
600	<	assertFalse(d.contains(impl.makeElement(0)));
595	>	it.forEachRemaining(e -> assertTrue(c.contains(e)));
596	>	if (testImplementationDetails) {
597	>	it.remove();
598	>	assertEquals(n - 1, d.size());
599	>	for (int i = 1; i < n; i++)
600	>	assertTrue(d.contains(impl.makeElement(i)));
601	>	assertFalse(d.contains(impl.makeElement(0)));
602	>	}
603		}
604		}
605
#	Line 296 | Line 612 | public class Collection8Test extends JSR
612		final Object x = impl.makeElement(1);
613		final Object y = impl.makeElement(2);
614		final ArrayList found = new ArrayList();
615	<	Consumer<Object> spy = (o) -> { found.add(o); };
615	>	Consumer<Object> spy = o -> found.add(o);
616		c.stream().forEach(spy);
617		assertTrue(found.isEmpty());
618
#	Line 330 | Line 646 | public class Collection8Test extends JSR
646		Runnable checkElt = () -> {
647		threadsStarted.countDown();
648		while (!done.get())
649	<	c.stream().forEach((x) -> { assertSame(x, elt); }); };
649	>	c.stream().forEach(x -> assertSame(x, elt)); };
650		Runnable addRemove = () -> {
651		threadsStarted.countDown();
652		while (!done.get()) {
#	Line 354 | Line 670 | public class Collection8Test extends JSR
670		final Object x = impl.makeElement(1);
671		final Object y = impl.makeElement(2);
672		final ArrayList found = new ArrayList();
673	<	Consumer<Object> spy = (o) -> { found.add(o); };
673	>	Consumer<Object> spy = o -> found.add(o);
674		c.forEach(spy);
675		assertTrue(found.isEmpty());
676
#	Line 375 | Line 691 | public class Collection8Test extends JSR
691		assertTrue(found.isEmpty());
692		}
693
694	<	public void testForEachConcurrentStressTest() throws Throwable {
694	>	/** TODO: promote to a common utility */
695	>	static <T> T chooseOne(T ... ts) {
696	>	return ts[ThreadLocalRandom.current().nextInt(ts.length)];
697	>	}
698	>
699	>	/** TODO: more random adders and removers */
700	>	static <E> Runnable adderRemover(Collection<E> c, E e) {
701	>	return chooseOne(
702	>	() -> {
703	>	assertTrue(c.add(e));
704	>	assertTrue(c.contains(e));
705	>	assertTrue(c.remove(e));
706	>	assertFalse(c.contains(e));
707	>	},
708	>	() -> {
709	>	assertTrue(c.add(e));
710	>	assertTrue(c.contains(e));
711	>	assertTrue(c.removeIf(x -> x == e));
712	>	assertFalse(c.contains(e));
713	>	},
714	>	() -> {
715	>	assertTrue(c.add(e));
716	>	assertTrue(c.contains(e));
717	>	for (Iterator it = c.iterator();; )
718	>	if (it.next() == e) {
719	>	try { it.remove(); }
720	>	catch (UnsupportedOperationException ok) {
721	>	c.remove(e);
722	>	}
723	>	break;
724	>	}
725	>	assertFalse(c.contains(e));
726	>	});
727	>	}
728	>
729	>	/**
730	>	* Concurrent Spliterators, once exhausted, stay exhausted.
731	>	*/
732	>	public void testStickySpliteratorExhaustion() throws Throwable {
733		if (!impl.isConcurrent()) return;
734	+	if (!testImplementationDetails) return;
735	+	final ThreadLocalRandom rnd = ThreadLocalRandom.current();
736	+	final Consumer alwaysThrows = e -> { throw new AssertionError(); };
737		final Collection c = impl.emptyCollection();
738	<	final long testDurationMillis = timeoutMillis();
738	>	final Spliterator s = c.spliterator();
739	>	if (rnd.nextBoolean()) {
740	>	assertFalse(s.tryAdvance(alwaysThrows));
741	>	} else {
742	>	s.forEachRemaining(alwaysThrows);
743	>	}
744	>	final Object one = impl.makeElement(1);
745	>	// Spliterator should not notice added element
746	>	c.add(one);
747	>	if (rnd.nextBoolean()) {
748	>	assertFalse(s.tryAdvance(alwaysThrows));
749	>	} else {
750	>	s.forEachRemaining(alwaysThrows);
751	>	}
752	>	}
753	>
754	>	/**
755	>	* Motley crew of threads concurrently randomly hammer the collection.
756	>	*/
757	>	public void testDetectRaces() throws Throwable {
758	>	if (!impl.isConcurrent()) return;
759	>	final ThreadLocalRandom rnd = ThreadLocalRandom.current();
760	>	final Collection c = impl.emptyCollection();
761	>	final long testDurationMillis
762	>	= expensiveTests ? LONG_DELAY_MS : timeoutMillis();
763		final AtomicBoolean done = new AtomicBoolean(false);
764	<	final Object elt = impl.makeElement(1);
765	<	final Future<?> f1, f2;
764	>	final Object one = impl.makeElement(1);
765	>	final Object two = impl.makeElement(2);
766	>	final Consumer checkSanity = x -> assertTrue(x == one || x == two);
767	>	final Consumer<Object[]> checkArraySanity = array -> {
768	>	// assertTrue(array.length <= 2); // duplicates are permitted
769	>	for (Object x : array) assertTrue(x == one || x == two);
770	>	};
771	>	final Object[] emptyArray =
772	>	(Object[]) java.lang.reflect.Array.newInstance(one.getClass(), 0);
773	>	final List<Future<?>> futures;
774	>	final Phaser threadsStarted = new Phaser(1); // register this thread
775	>	final Runnable[] frobbers = {
776	>	() -> c.forEach(checkSanity),
777	>	() -> c.stream().forEach(checkSanity),
778	>	() -> c.parallelStream().forEach(checkSanity),
779	>	() -> c.spliterator().trySplit(),
780	>	() -> {
781	>	Spliterator s = c.spliterator();
782	>	s.tryAdvance(checkSanity);
783	>	s.trySplit();
784	>	},
785	>	() -> {
786	>	Spliterator s = c.spliterator();
787	>	do {} while (s.tryAdvance(checkSanity));
788	>	},
789	>	() -> { for (Object x : c) checkSanity.accept(x); },
790	>	() -> checkArraySanity.accept(c.toArray()),
791	>	() -> checkArraySanity.accept(c.toArray(emptyArray)),
792	>	() -> {
793	>	Object[] a = new Object[5];
794	>	Object three = impl.makeElement(3);
795	>	Arrays.fill(a, 0, a.length, three);
796	>	Object[] x = c.toArray(a);
797	>	if (x == a)
798	>	for (int i = 0; i < a.length && a[i] != null; i++)
799	>	checkSanity.accept(a[i]);
800	>	// A careful reading of the spec does not support:
801	>	// for (i++; i < a.length; i++) assertSame(three, a[i]);
802	>	else
803	>	checkArraySanity.accept(x);
804	>	},
805	>	adderRemover(c, one),
806	>	adderRemover(c, two),
807	>	};
808	>	final List<Runnable> tasks =
809	>	Arrays.stream(frobbers)
810	>	.filter(task -> rnd.nextBoolean()) // random subset
811	>	.map(task -> (Runnable) () -> {
812	>	threadsStarted.arriveAndAwaitAdvance();
813	>	while (!done.get())
814	>	task.run();
815	>	})
816	>	.collect(Collectors.toList());
817		final ExecutorService pool = Executors.newCachedThreadPool();
818		try (PoolCleaner cleaner = cleaner(pool, done)) {
819	<	final CountDownLatch threadsStarted = new CountDownLatch(2);
820	<	Runnable checkElt = () -> {
821	<	threadsStarted.countDown();
822	<	while (!done.get())
823	<	c.forEach((x) -> { assertSame(x, elt); }); };
392	<	Runnable addRemove = () -> {
393	<	threadsStarted.countDown();
394	<	while (!done.get()) {
395	<	assertTrue(c.add(elt));
396	<	assertTrue(c.remove(elt));
397	<	}};
398	<	f1 = pool.submit(checkElt);
399	<	f2 = pool.submit(addRemove);
819	>	threadsStarted.bulkRegister(tasks.size());
820	>	futures = tasks.stream()
821	>	.map(pool::submit)
822	>	.collect(Collectors.toList());
823	>	threadsStarted.arriveAndDeregister();
824		Thread.sleep(testDurationMillis);
825		}
826	<	assertNull(f1.get(0L, MILLISECONDS));
827	<	assertNull(f2.get(0L, MILLISECONDS));
826	>	for (Future future : futures)
827	>	assertNull(future.get(0L, MILLISECONDS));
828	>	}
829	>
830	>	/**
831	>	* Spliterators are either IMMUTABLE or truly late-binding or, if
832	>	* concurrent, use the same "late-binding style" of returning
833	>	* elements added between creation and first use.
834	>	*/
835	>	public void testLateBindingStyle() {
836	>	if (!testImplementationDetails) return;
837	>	if (impl.klazz() == ArrayList.class) return; // for jdk8
838	>	// Immutable (snapshot) spliterators are exempt
839	>	if (impl.emptyCollection().spliterator()
840	>	.hasCharacteristics(Spliterator.IMMUTABLE))
841	>	return;
842	>	final Object one = impl.makeElement(1);
843	>	{
844	>	final Collection c = impl.emptyCollection();
845	>	final Spliterator split = c.spliterator();
846	>	c.add(one);
847	>	assertTrue(split.tryAdvance(e -> { assertSame(e, one); }));
848	>	assertFalse(split.tryAdvance(e -> { throw new AssertionError(); }));
849	>	assertTrue(c.contains(one));
850	>	}
851	>	{
852	>	final AtomicLong count = new AtomicLong(0);
853	>	final Collection c = impl.emptyCollection();
854	>	final Spliterator split = c.spliterator();
855	>	c.add(one);
856	>	split.forEachRemaining(
857	>	e -> { assertSame(e, one); count.getAndIncrement(); });
858	>	assertEquals(1L, count.get());
859	>	assertFalse(split.tryAdvance(e -> { throw new AssertionError(); }));
860	>	assertTrue(c.contains(one));
861	>	}
862	>	}
863	>
864	>	/**
865	>	* Spliterator.getComparator throws IllegalStateException iff the
866	>	* spliterator does not report SORTED.
867	>	*/
868	>	public void testGetComparator_IllegalStateException() {
869	>	Collection c = impl.emptyCollection();
870	>	Spliterator s = c.spliterator();
871	>	boolean reportsSorted = s.hasCharacteristics(Spliterator.SORTED);
872	>	try {
873	>	s.getComparator();
874	>	assertTrue(reportsSorted);
875	>	} catch (IllegalStateException ex) {
876	>	assertFalse(reportsSorted);
877	>	}
878		}
879
880		//     public void testCollection8DebugFail() {

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines