ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.41 by jsr166, Mon Jun 2 01:46:11 2014 UTC vs.
Revision 1.72 by jsr166, Fri Jun 6 21:10:34 2014 UTC

# Line 17 | Line 17 | import java.util.concurrent.Future;
17   import java.util.concurrent.CompletableFuture;
18   import java.util.concurrent.CompletionException;
19   import java.util.concurrent.CompletionStage;
20 + import java.util.concurrent.ForkJoinPool;
21 + import java.util.concurrent.ForkJoinTask;
22   import java.util.concurrent.TimeoutException;
23   import java.util.concurrent.atomic.AtomicInteger;
24   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 103 | Line 105 | public class CompletableFutureTest exten
105          assertTrue(f.toString().contains("[Completed exceptionally]"));
106      }
107  
108 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
109 <                                              CFException ex) {
108 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
109 >                                                      Throwable ex) {
110          try {
111              f.get(LONG_DELAY_MS, MILLISECONDS);
112              shouldThrow();
# Line 129 | Line 131 | public class CompletableFutureTest exten
131          } catch (ExecutionException success) {
132              assertSame(ex, success.getCause());
133          } catch (Throwable fail) { threadUnexpectedException(fail); }
134 +                                                            
135          assertTrue(f.isDone());
136          assertFalse(f.isCancelled());
137          assertTrue(f.toString().contains("[Completed exceptionally]"));
138      }
139  
140 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
141 +                                                Throwable ex) {
142 +        checkCompletedExceptionallyWithRootCause(f, ex);
143 +        try {
144 +            CompletableFuture<Throwable> spy = f.handle
145 +                ((U u, Throwable t) -> t);
146 +            assertTrue(spy.join() instanceof CompletionException);
147 +            assertSame(ex, spy.join().getCause());
148 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
149 +    }
150 +
151 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
152 +        checkCompletedExceptionallyWithRootCause(f, ex);
153 +        try {
154 +            CompletableFuture<Throwable> spy = f.handle
155 +                ((U u, Throwable t) -> t);
156 +            assertSame(ex, spy.join());
157 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
158 +    }
159 +
160      void checkCancelled(CompletableFuture<?> f) {
161          try {
162              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 216 | Line 239 | public class CompletableFutureTest exten
239       */
240      public void testCompleteExceptionally() {
241          CompletableFuture<Integer> f = new CompletableFuture<>();
242 +        CFException ex = new CFException();
243          checkIncomplete(f);
244 <        f.completeExceptionally(new CFException());
245 <        checkCompletedWithWrappedCFException(f);
244 >        f.completeExceptionally(ex);
245 >        checkCompletedExceptionally(f, ex);
246      }
247  
248      /**
# Line 247 | Line 271 | public class CompletableFutureTest exten
271          f = new CompletableFuture<>();
272          f.obtrudeValue(three);
273          checkCompletedNormally(f, three);
274 +        f.obtrudeValue(null);
275 +        checkCompletedNormally(f, null);
276          f = new CompletableFuture<>();
277          f.completeExceptionally(new CFException());
278          f.obtrudeValue(four);
# Line 257 | Line 283 | public class CompletableFutureTest exten
283       * obtrudeException forces completion with given exception
284       */
285      public void testObtrudeException() {
286 <        CompletableFuture<Integer> f = new CompletableFuture<>();
287 <        checkIncomplete(f);
288 <        f.complete(one);
289 <        checkCompletedNormally(f, one);
290 <        f.obtrudeException(new CFException());
265 <        checkCompletedWithWrappedCFException(f);
286 >        for (Integer v1 : new Integer[] { 1, null })
287 >    {
288 >        CFException ex;
289 >        CompletableFuture<Integer> f;
290 >
291          f = new CompletableFuture<>();
292 <        f.obtrudeException(new CFException());
293 <        checkCompletedWithWrappedCFException(f);
292 >        f.complete(v1);
293 >        for (int i = 0; i < 2; i++) {
294 >            f.obtrudeException(ex = new CFException());
295 >            checkCompletedExceptionally(f, ex);
296 >        }
297 >
298          f = new CompletableFuture<>();
299 +        for (int i = 0; i < 2; i++) {
300 +            f.obtrudeException(ex = new CFException());
301 +            checkCompletedExceptionally(f, ex);
302 +        }
303 +
304 +        f = new CompletableFuture<>();
305 +        f.completeExceptionally(ex = new CFException());
306 +        f.obtrudeValue(v1);
307 +        checkCompletedNormally(f, v1);
308 +        f.obtrudeException(ex = new CFException());
309 +        checkCompletedExceptionally(f, ex);
310          f.completeExceptionally(new CFException());
311 <        f.obtrudeValue(four);
312 <        checkCompletedNormally(f, four);
313 <        f.obtrudeException(new CFException());
314 <        checkCompletedWithWrappedCFException(f);
275 <    }
311 >        checkCompletedExceptionally(f, ex);
312 >        f.complete(v1);
313 >        checkCompletedExceptionally(f, ex);
314 >    }}
315  
316      /**
317       * getNumberOfDependents returns number of dependent tasks
318       */
319      public void testGetNumberOfDependents() {
320          CompletableFuture<Integer> f = new CompletableFuture<>();
321 <        assertEquals(f.getNumberOfDependents(), 0);
322 <        CompletableFuture g = f.thenRun(new Noop());
323 <        assertEquals(f.getNumberOfDependents(), 1);
324 <        assertEquals(g.getNumberOfDependents(), 0);
325 <        CompletableFuture h = f.thenRun(new Noop());
326 <        assertEquals(f.getNumberOfDependents(), 2);
321 >        assertEquals(0, f.getNumberOfDependents());
322 >        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
323 >        assertEquals(1, f.getNumberOfDependents());
324 >        assertEquals(0, g.getNumberOfDependents());
325 >        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
326 >        assertEquals(2, f.getNumberOfDependents());
327          f.complete(1);
328          checkCompletedNormally(g, null);
329 <        assertEquals(f.getNumberOfDependents(), 0);
330 <        assertEquals(g.getNumberOfDependents(), 0);
329 >        assertEquals(0, f.getNumberOfDependents());
330 >        assertEquals(0, g.getNumberOfDependents());
331      }
332  
333      /**
# Line 316 | Line 355 | public class CompletableFutureTest exten
355          checkCompletedNormally(f, "test");
356      }
357  
358 <    // Choose non-commutative actions for better coverage
358 >    abstract class CheckedAction {
359 >        int invocationCount = 0;
360 >        final ExecutionMode m;
361 >        CheckedAction(ExecutionMode m) { this.m = m; }
362 >        void invoked() {
363 >            m.checkExecutionMode();
364 >            assertEquals(0, invocationCount++);
365 >        }
366 >        void assertNotInvoked() { assertEquals(0, invocationCount); }
367 >        void assertInvoked() { assertEquals(1, invocationCount); }
368 >    }
369  
370 <    // A non-commutative function that handles and produces null values as well.
371 <    static Integer subtract(Integer x, Integer y) {
372 <        return (x == null && y == null) ? null :
373 <            ((x == null) ? 42 : x.intValue())
374 <            - ((y == null) ? 99 : y.intValue());
370 >    abstract class CheckedIntegerAction extends CheckedAction {
371 >        Integer value;
372 >        CheckedIntegerAction(ExecutionMode m) { super(m); }
373 >        void assertValue(Integer expected) {
374 >            assertInvoked();
375 >            assertEquals(expected, value);
376 >        }
377 >    }
378 >
379 >    class IntegerSupplier extends CheckedAction
380 >        implements Supplier<Integer>
381 >    {
382 >        final Integer value;
383 >        IntegerSupplier(ExecutionMode m, Integer value) {
384 >            super(m);
385 >            this.value = value;
386 >        }
387 >        public Integer get() {
388 >            invoked();
389 >            return value;
390 >        }
391      }
392  
393      // A function that handles and produces null values as well.
# Line 330 | Line 395 | public class CompletableFutureTest exten
395          return (x == null) ? null : x + 1;
396      }
397  
398 <    static final Supplier<Integer> supplyOne =
399 <        () -> Integer.valueOf(1);
400 <    static final Function<Integer, Integer> inc =
401 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
337 <    static final BiFunction<Integer, Integer, Integer> subtract =
338 <        (Integer x, Integer y) -> subtract(x, y);
339 <    static final class IncAction implements Consumer<Integer> {
340 <        int invocationCount = 0;
341 <        Integer value;
342 <        public boolean ran() { return invocationCount == 1; }
398 >    class NoopConsumer extends CheckedIntegerAction
399 >        implements Consumer<Integer>
400 >    {
401 >        NoopConsumer(ExecutionMode m) { super(m); }
402          public void accept(Integer x) {
403 <            invocationCount++;
404 <            value = inc(x);
403 >            invoked();
404 >            value = x;
405          }
406      }
407 <    static final class IncFunction implements Function<Integer,Integer> {
408 <        int invocationCount = 0;
409 <        Integer value;
410 <        public boolean ran() { return invocationCount == 1; }
407 >
408 >    class IncFunction extends CheckedIntegerAction
409 >        implements Function<Integer,Integer>
410 >    {
411 >        IncFunction(ExecutionMode m) { super(m); }
412          public Integer apply(Integer x) {
413 <            invocationCount++;
413 >            invoked();
414              return value = inc(x);
415          }
416      }
417 <    static final class SubtractAction implements BiConsumer<Integer, Integer> {
418 <        int invocationCount = 0;
419 <        Integer value;
420 <        // Check this action was invoked exactly once when result is computed.
421 <        public boolean ran() { return invocationCount == 1; }
417 >
418 >    // Choose non-commutative actions for better coverage
419 >    // A non-commutative function that handles and produces null values as well.
420 >    static Integer subtract(Integer x, Integer y) {
421 >        return (x == null && y == null) ? null :
422 >            ((x == null) ? 42 : x.intValue())
423 >            - ((y == null) ? 99 : y.intValue());
424 >    }
425 >
426 >    class SubtractAction extends CheckedIntegerAction
427 >        implements BiConsumer<Integer, Integer>
428 >    {
429 >        SubtractAction(ExecutionMode m) { super(m); }
430          public void accept(Integer x, Integer y) {
431 <            invocationCount++;
431 >            invoked();
432              value = subtract(x, y);
433          }
434      }
435 <    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
436 <        int invocationCount = 0;
437 <        Integer value;
438 <        // Check this action was invoked exactly once when result is computed.
439 <        public boolean ran() { return invocationCount == 1; }
435 >
436 >    class SubtractFunction extends CheckedIntegerAction
437 >        implements BiFunction<Integer, Integer, Integer>
438 >    {
439 >        SubtractFunction(ExecutionMode m) { super(m); }
440          public Integer apply(Integer x, Integer y) {
441 <            invocationCount++;
441 >            invoked();
442              return value = subtract(x, y);
443          }
444      }
445 <    static final class Noop implements Runnable {
446 <        int invocationCount = 0;
447 <        boolean ran;
445 >
446 >    class Noop extends CheckedAction implements Runnable {
447 >        Noop(ExecutionMode m) { super(m); }
448          public void run() {
449 <            invocationCount++;
382 <            ran = true;
449 >            invoked();
450          }
451      }
452  
453 <    static final class FailingSupplier implements Supplier<Integer> {
454 <        boolean ran;
455 <        public Integer get() { ran = true; throw new CFException(); }
453 >    class FailingSupplier extends CheckedAction
454 >        implements Supplier<Integer>
455 >    {
456 >        FailingSupplier(ExecutionMode m) { super(m); }
457 >        public Integer get() {
458 >            invoked();
459 >            throw new CFException();
460 >        }
461      }
462 <    static final class FailingConsumer implements Consumer<Integer> {
463 <        boolean ran;
464 <        public void accept(Integer x) { ran = true; throw new CFException(); }
462 >
463 >    class FailingConsumer extends CheckedIntegerAction
464 >        implements Consumer<Integer>
465 >    {
466 >        FailingConsumer(ExecutionMode m) { super(m); }
467 >        public void accept(Integer x) {
468 >            invoked();
469 >            value = x;
470 >            throw new CFException();
471 >        }
472      }
473 <    static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
474 <        boolean ran;
475 <        public void accept(Integer x, Integer y) { ran = true; throw new CFException(); }
473 >
474 >    class FailingBiConsumer extends CheckedIntegerAction
475 >        implements BiConsumer<Integer, Integer>
476 >    {
477 >        FailingBiConsumer(ExecutionMode m) { super(m); }
478 >        public void accept(Integer x, Integer y) {
479 >            invoked();
480 >            value = subtract(x, y);
481 >            throw new CFException();
482 >        }
483      }
484 <    static final class FailingFunction implements Function<Integer, Integer> {
485 <        boolean ran;
486 <        public Integer apply(Integer x) { ran = true; throw new CFException(); }
484 >
485 >    class FailingFunction extends CheckedIntegerAction
486 >        implements Function<Integer, Integer>
487 >    {
488 >        FailingFunction(ExecutionMode m) { super(m); }
489 >        public Integer apply(Integer x) {
490 >            invoked();
491 >            value = x;
492 >            throw new CFException();
493 >        }
494      }
495 <    static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
496 <        boolean ran;
497 <        public Integer apply(Integer x, Integer y) { ran = true; throw new CFException(); }
495 >
496 >    class FailingBiFunction extends CheckedIntegerAction
497 >        implements BiFunction<Integer, Integer, Integer>
498 >    {
499 >        FailingBiFunction(ExecutionMode m) { super(m); }
500 >        public Integer apply(Integer x, Integer y) {
501 >            invoked();
502 >            value = subtract(x, y);
503 >            throw new CFException();
504 >        }
505      }
506 <    static final class FailingNoop implements Runnable {
507 <        boolean ran;
508 <        public void run() { ran = true; throw new CFException(); }
506 >
507 >    class FailingRunnable extends CheckedAction implements Runnable {
508 >        FailingRunnable(ExecutionMode m) { super(m); }
509 >        public void run() {
510 >            invoked();
511 >            throw new CFException();
512 >        }
513      }
514  
515 <    static final class CompletableFutureInc
516 <        implements Function<Integer, CompletableFuture<Integer>> {
517 <        boolean ran;
515 >
516 >    class CompletableFutureInc extends CheckedIntegerAction
517 >        implements Function<Integer, CompletableFuture<Integer>>
518 >    {
519 >        CompletableFutureInc(ExecutionMode m) { super(m); }
520          public CompletableFuture<Integer> apply(Integer x) {
521 <            ran = true;
521 >            invoked();
522 >            value = x;
523              CompletableFuture<Integer> f = new CompletableFuture<>();
524 <            f.complete(Integer.valueOf(x.intValue() + 1));
524 >            f.complete(inc(x));
525              return f;
526          }
527      }
528  
529 <    static final class FailingCompletableFutureFunction
530 <        implements Function<Integer, CompletableFuture<Integer>> {
531 <        boolean ran;
529 >    class FailingCompletableFutureFunction extends CheckedIntegerAction
530 >        implements Function<Integer, CompletableFuture<Integer>>
531 >    {
532 >        FailingCompletableFutureFunction(ExecutionMode m) { super(m); }
533          public CompletableFuture<Integer> apply(Integer x) {
534 <            ran = true; throw new CFException();
534 >            invoked();
535 >            value = x;
536 >            throw new CFException();
537          }
538      }
539  
540      // Used for explicit executor tests
541      static final class ThreadExecutor implements Executor {
542 <        AtomicInteger count = new AtomicInteger(0);
542 >        final AtomicInteger count = new AtomicInteger(0);
543 >        static final ThreadGroup tg = new ThreadGroup("ThreadExecutor");
544 >        static boolean startedCurrentThread() {
545 >            return Thread.currentThread().getThreadGroup() == tg;
546 >        }
547  
548          public void execute(Runnable r) {
549              count.getAndIncrement();
550 <            new Thread(r).start();
437 <        }
438 <    }
439 <
440 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
441 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
442 <    }
443 <
444 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
445 <        boolean ran;
446 <        public Integer apply(Integer x, Throwable t) {
447 <            ran = true;
448 <            return (t == null) ? two : three;
550 >            new Thread(tg, r).start();
551          }
552      }
553  
554      /**
555       * Permits the testing of parallel code for the 3 different
556 <     * execution modes without repeating all the testing code.
556 >     * execution modes without copy/pasting all the test methods.
557       */
558      enum ExecutionMode {
559          DEFAULT {
560 +            public void checkExecutionMode() {
561 +                assertFalse(ThreadExecutor.startedCurrentThread());
562 +                assertNull(ForkJoinTask.getPool());
563 +            }
564 +            public CompletableFuture<Void> runAsync(Runnable a) {
565 +                throw new UnsupportedOperationException();
566 +            }
567 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
568 +                throw new UnsupportedOperationException();
569 +            }
570 +            public <T> CompletableFuture<Void> thenRun
571 +                (CompletableFuture<T> f, Runnable a) {
572 +                return f.thenRun(a);
573 +            }
574 +            public <T> CompletableFuture<Void> thenAccept
575 +                (CompletableFuture<T> f, Consumer<? super T> a) {
576 +                return f.thenAccept(a);
577 +            }
578 +            public <T,U> CompletableFuture<U> thenApply
579 +                (CompletableFuture<T> f, Function<? super T,U> a) {
580 +                return f.thenApply(a);
581 +            }
582 +            public <T,U> CompletableFuture<U> thenCompose
583 +                (CompletableFuture<T> f,
584 +                 Function<? super T,? extends CompletionStage<U>> a) {
585 +                return f.thenCompose(a);
586 +            }
587 +            public <T,U> CompletableFuture<U> handle
588 +                (CompletableFuture<T> f,
589 +                 BiFunction<? super T,Throwable,? extends U> a) {
590 +                return f.handle(a);
591 +            }
592 +            public <T> CompletableFuture<T> whenComplete
593 +                (CompletableFuture<T> f,
594 +                 BiConsumer<? super T,? super Throwable> a) {
595 +                return f.whenComplete(a);
596 +            }
597              public <T,U> CompletableFuture<Void> runAfterBoth
598                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
599                  return f.runAfterBoth(g, a);
# Line 471 | Line 610 | public class CompletableFutureTest exten
610                   BiFunction<? super T,? super U,? extends V> a) {
611                  return f.thenCombine(g, a);
612              }
613 <            public <T,U> CompletableFuture<U> applyToEither
613 >            public <T> CompletableFuture<Void> runAfterEither
614                  (CompletableFuture<T> f,
615 <                 CompletionStage<? extends T> g,
616 <                 Function<? super T,U> a) {
617 <                return f.applyToEither(g, a);
615 >                 CompletionStage<?> g,
616 >                 java.lang.Runnable a) {
617 >                return f.runAfterEither(g, a);
618              }
619              public <T> CompletableFuture<Void> acceptEither
620                  (CompletableFuture<T> f,
# Line 483 | Line 622 | public class CompletableFutureTest exten
622                   Consumer<? super T> a) {
623                  return f.acceptEither(g, a);
624              }
625 <            public <T> CompletableFuture<Void> runAfterEither
625 >            public <T,U> CompletableFuture<U> applyToEither
626                  (CompletableFuture<T> f,
627 <                 CompletionStage<?> g,
628 <                 java.lang.Runnable a) {
629 <                return f.runAfterEither(g, a);
627 >                 CompletionStage<? extends T> g,
628 >                 Function<? super T,U> a) {
629 >                return f.applyToEither(g, a);
630 >            }
631 >        },
632 >
633 >        ASYNC {
634 >            public void checkExecutionMode() {
635 >                assertSame(ForkJoinPool.commonPool(),
636 >                           ForkJoinTask.getPool());
637 >            }
638 >            public CompletableFuture<Void> runAsync(Runnable a) {
639 >                return CompletableFuture.runAsync(a);
640 >            }
641 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
642 >                return CompletableFuture.supplyAsync(a);
643 >            }
644 >            public <T> CompletableFuture<Void> thenRun
645 >                (CompletableFuture<T> f, Runnable a) {
646 >                return f.thenRunAsync(a);
647 >            }
648 >            public <T> CompletableFuture<Void> thenAccept
649 >                (CompletableFuture<T> f, Consumer<? super T> a) {
650 >                return f.thenAcceptAsync(a);
651 >            }
652 >            public <T,U> CompletableFuture<U> thenApply
653 >                (CompletableFuture<T> f, Function<? super T,U> a) {
654 >                return f.thenApplyAsync(a);
655              }
656              public <T,U> CompletableFuture<U> thenCompose
657                  (CompletableFuture<T> f,
658                   Function<? super T,? extends CompletionStage<U>> a) {
659 <                return f.thenCompose(a);
659 >                return f.thenComposeAsync(a);
660 >            }
661 >            public <T,U> CompletableFuture<U> handle
662 >                (CompletableFuture<T> f,
663 >                 BiFunction<? super T,Throwable,? extends U> a) {
664 >                return f.handleAsync(a);
665              }
666              public <T> CompletableFuture<T> whenComplete
667                  (CompletableFuture<T> f,
668                   BiConsumer<? super T,? super Throwable> a) {
669 <                return f.whenComplete(a);
669 >                return f.whenCompleteAsync(a);
670              }
502        },
503
504 //             /** Experimental way to do more testing */
505 //         REVERSE_DEFAULT {
506 //             public <T,U> CompletableFuture<Void> runAfterBoth
507 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
508 //                 return g.runAfterBoth(f, a);
509 //             }
510 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
511 //                 (CompletableFuture<T> f,
512 //                  CompletionStage<? extends U> g,
513 //                  BiConsumer<? super T,? super U> a) {
514 //                 return DEFAULT.thenAcceptBoth(f, g, a);
515 //             }
516 //         },
517
518        DEFAULT_ASYNC {
671              public <T,U> CompletableFuture<Void> runAfterBoth
672                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
673                  return f.runAfterBothAsync(g, a);
# Line 532 | Line 684 | public class CompletableFutureTest exten
684                   BiFunction<? super T,? super U,? extends V> a) {
685                  return f.thenCombineAsync(g, a);
686              }
687 <            public <T,U> CompletableFuture<U> applyToEither
687 >            public <T> CompletableFuture<Void> runAfterEither
688                  (CompletableFuture<T> f,
689 <                 CompletionStage<? extends T> g,
690 <                 Function<? super T,U> a) {
691 <                return f.applyToEitherAsync(g, a);
689 >                 CompletionStage<?> g,
690 >                 java.lang.Runnable a) {
691 >                return f.runAfterEitherAsync(g, a);
692              }
693              public <T> CompletableFuture<Void> acceptEither
694                  (CompletableFuture<T> f,
# Line 544 | Line 696 | public class CompletableFutureTest exten
696                   Consumer<? super T> a) {
697                  return f.acceptEitherAsync(g, a);
698              }
699 <            public <T> CompletableFuture<Void> runAfterEither
699 >            public <T,U> CompletableFuture<U> applyToEither
700                  (CompletableFuture<T> f,
701 <                 CompletionStage<?> g,
702 <                 java.lang.Runnable a) {
703 <                return f.runAfterEitherAsync(g, a);
701 >                 CompletionStage<? extends T> g,
702 >                 Function<? super T,U> a) {
703 >                return f.applyToEitherAsync(g, a);
704 >            }
705 >        },
706 >
707 >        EXECUTOR {
708 >            public void checkExecutionMode() {
709 >                assertTrue(ThreadExecutor.startedCurrentThread());
710 >            }
711 >            public CompletableFuture<Void> runAsync(Runnable a) {
712 >                return CompletableFuture.runAsync(a, new ThreadExecutor());
713 >            }
714 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
715 >                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
716 >            }
717 >            public <T> CompletableFuture<Void> thenRun
718 >                (CompletableFuture<T> f, Runnable a) {
719 >                return f.thenRunAsync(a, new ThreadExecutor());
720 >            }
721 >            public <T> CompletableFuture<Void> thenAccept
722 >                (CompletableFuture<T> f, Consumer<? super T> a) {
723 >                return f.thenAcceptAsync(a, new ThreadExecutor());
724 >            }
725 >            public <T,U> CompletableFuture<U> thenApply
726 >                (CompletableFuture<T> f, Function<? super T,U> a) {
727 >                return f.thenApplyAsync(a, new ThreadExecutor());
728              }
729              public <T,U> CompletableFuture<U> thenCompose
730                  (CompletableFuture<T> f,
731                   Function<? super T,? extends CompletionStage<U>> a) {
732 <                return f.thenComposeAsync(a);
732 >                return f.thenComposeAsync(a, new ThreadExecutor());
733 >            }
734 >            public <T,U> CompletableFuture<U> handle
735 >                (CompletableFuture<T> f,
736 >                 BiFunction<? super T,Throwable,? extends U> a) {
737 >                return f.handleAsync(a, new ThreadExecutor());
738              }
739              public <T> CompletableFuture<T> whenComplete
740                  (CompletableFuture<T> f,
741                   BiConsumer<? super T,? super Throwable> a) {
742 <                return f.whenCompleteAsync(a);
742 >                return f.whenCompleteAsync(a, new ThreadExecutor());
743              }
563        },
564
565 //         REVERSE_DEFAULT_ASYNC {
566 //             public <T,U> CompletableFuture<Void> runAfterBoth
567 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
568 //                 return f.runAfterBothAsync(g, a);
569 //             }
570 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
571 //                 (CompletableFuture<T> f,
572 //                  CompletionStage<? extends U> g,
573 //                  BiConsumer<? super T,? super U> a) {
574 //                 return DEFAULT_ASYNC.thenAcceptBoth(f, g, a);
575 //             }
576 //         },
577
578        EXECUTOR {
744              public <T,U> CompletableFuture<Void> runAfterBoth
745                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
746                  return f.runAfterBothAsync(g, a, new ThreadExecutor());
# Line 592 | Line 757 | public class CompletableFutureTest exten
757                   BiFunction<? super T,? super U,? extends V> a) {
758                  return f.thenCombineAsync(g, a, new ThreadExecutor());
759              }
595            public <T,U> CompletableFuture<U> applyToEither
596                (CompletableFuture<T> f,
597                 CompletionStage<? extends T> g,
598                 Function<? super T,U> a) {
599                return f.applyToEitherAsync(g, a, new ThreadExecutor());
600            }
601            public <T> CompletableFuture<Void> acceptEither
602                (CompletableFuture<T> f,
603                 CompletionStage<? extends T> g,
604                 Consumer<? super T> a) {
605                return f.acceptEitherAsync(g, a, new ThreadExecutor());
606            }
760              public <T> CompletableFuture<Void> runAfterEither
761                  (CompletableFuture<T> f,
762                   CompletionStage<?> g,
763                   java.lang.Runnable a) {
764                  return f.runAfterEitherAsync(g, a, new ThreadExecutor());
765              }
766 <            public <T,U> CompletableFuture<U> thenCompose
766 >            public <T> CompletableFuture<Void> acceptEither
767                  (CompletableFuture<T> f,
768 <                 Function<? super T,? extends CompletionStage<U>> a) {
769 <                return f.thenComposeAsync(a, new ThreadExecutor());
768 >                 CompletionStage<? extends T> g,
769 >                 Consumer<? super T> a) {
770 >                return f.acceptEitherAsync(g, a, new ThreadExecutor());
771              }
772 <            public <T> CompletableFuture<T> whenComplete
772 >            public <T,U> CompletableFuture<U> applyToEither
773                  (CompletableFuture<T> f,
774 <                 BiConsumer<? super T,? super Throwable> a) {
775 <                return f.whenCompleteAsync(a, new ThreadExecutor());
774 >                 CompletionStage<? extends T> g,
775 >                 Function<? super T,U> a) {
776 >                return f.applyToEitherAsync(g, a, new ThreadExecutor());
777              }
778          };
779  
780 +        public abstract void checkExecutionMode();
781 +        public abstract CompletableFuture<Void> runAsync(Runnable a);
782 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
783 +        public abstract <T> CompletableFuture<Void> thenRun
784 +            (CompletableFuture<T> f, Runnable a);
785 +        public abstract <T> CompletableFuture<Void> thenAccept
786 +            (CompletableFuture<T> f, Consumer<? super T> a);
787 +        public abstract <T,U> CompletableFuture<U> thenApply
788 +            (CompletableFuture<T> f, Function<? super T,U> a);
789 +        public abstract <T,U> CompletableFuture<U> thenCompose
790 +            (CompletableFuture<T> f,
791 +             Function<? super T,? extends CompletionStage<U>> a);
792 +        public abstract <T,U> CompletableFuture<U> handle
793 +            (CompletableFuture<T> f,
794 +             BiFunction<? super T,Throwable,? extends U> a);
795 +        public abstract <T> CompletableFuture<T> whenComplete
796 +            (CompletableFuture<T> f,
797 +             BiConsumer<? super T,? super Throwable> a);
798          public abstract <T,U> CompletableFuture<Void> runAfterBoth
799              (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
800          public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
# Line 632 | Line 805 | public class CompletableFutureTest exten
805              (CompletableFuture<T> f,
806               CompletionStage<? extends U> g,
807               BiFunction<? super T,? super U,? extends V> a);
635        public abstract <T,U> CompletableFuture<U> applyToEither
636            (CompletableFuture<T> f,
637             CompletionStage<? extends T> g,
638             Function<? super T,U> a);
639        public abstract <T> CompletableFuture<Void> acceptEither
640            (CompletableFuture<T> f,
641             CompletionStage<? extends T> g,
642             Consumer<? super T> a);
808          public abstract <T> CompletableFuture<Void> runAfterEither
809              (CompletableFuture<T> f,
810               CompletionStage<?> g,
811               java.lang.Runnable a);
812 <        public abstract <T,U> CompletableFuture<U> thenCompose
812 >        public abstract <T> CompletableFuture<Void> acceptEither
813              (CompletableFuture<T> f,
814 <             Function<? super T,? extends CompletionStage<U>> a);
815 <        public abstract <T> CompletableFuture<T> whenComplete
814 >             CompletionStage<? extends T> g,
815 >             Consumer<? super T> a);
816 >        public abstract <T,U> CompletableFuture<U> applyToEither
817              (CompletableFuture<T> f,
818 <             BiConsumer<? super T,? super Throwable> a);
818 >             CompletionStage<? extends T> g,
819 >             Function<? super T,U> a);
820 >    }
821  
822 +    /**
823 +     * exceptionally action is not invoked when source completes
824 +     * normally, and source result is propagated
825 +     */
826 +    public void testExceptionally_normalCompletion() {
827 +        for (boolean createIncomplete : new boolean[] { true, false })
828 +        for (Integer v1 : new Integer[] { 1, null })
829 +    {
830 +        final AtomicInteger a = new AtomicInteger(0);
831 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
832 +        if (!createIncomplete) f.complete(v1);
833 +        final CompletableFuture<Integer> g = f.exceptionally
834 +            ((Throwable t) -> {
835 +                // Should not be called
836 +                a.getAndIncrement();
837 +                throw new AssertionError();
838 +            });
839 +        if (createIncomplete) f.complete(v1);
840 +
841 +        checkCompletedNormally(g, v1);
842 +        checkCompletedNormally(f, v1);
843 +        assertEquals(0, a.get());
844 +    }}
845  
655    }
846  
847      /**
848       * exceptionally action completes with function value on source
849 <     * exception; otherwise with source value
849 >     * exception
850       */
851 <    public void testExceptionally() {
852 <        CompletableFuture<Integer> f = new CompletableFuture<>();
853 <        ExceptionToInteger r = new ExceptionToInteger();
854 <        CompletableFuture<Integer> g = f.exceptionally(r);
855 <        f.completeExceptionally(new CFException());
856 <        checkCompletedNormally(g, three);
851 >    public void testExceptionally_exceptionalCompletion() {
852 >        for (boolean createIncomplete : new boolean[] { true, false })
853 >        for (Integer v1 : new Integer[] { 1, null })
854 >    {
855 >        final AtomicInteger a = new AtomicInteger(0);
856 >        final CFException ex = new CFException();
857 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
858 >        if (!createIncomplete) f.completeExceptionally(ex);
859 >        final CompletableFuture<Integer> g = f.exceptionally
860 >            ((Throwable t) -> {
861 >                ExecutionMode.DEFAULT.checkExecutionMode();
862 >                threadAssertSame(t, ex);
863 >                a.getAndIncrement();
864 >                return v1;
865 >            });
866 >        if (createIncomplete) f.completeExceptionally(ex);
867  
868 <        f = new CompletableFuture<>();
869 <        r = new ExceptionToInteger();
870 <        g = f.exceptionally(r);
871 <        f.complete(one);
872 <        checkCompletedNormally(g, one);
873 <    }
868 >        checkCompletedNormally(g, v1);
869 >        assertEquals(1, a.get());
870 >    }}
871 >
872 >    public void testExceptionally_exceptionalCompletionActionFailed() {
873 >        for (boolean createIncomplete : new boolean[] { true, false })
874 >        for (Integer v1 : new Integer[] { 1, null })
875 >    {
876 >        final AtomicInteger a = new AtomicInteger(0);
877 >        final CFException ex1 = new CFException();
878 >        final CFException ex2 = new CFException();
879 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
880 >        if (!createIncomplete) f.completeExceptionally(ex1);
881 >        final CompletableFuture<Integer> g = f.exceptionally
882 >            ((Throwable t) -> {
883 >                ExecutionMode.DEFAULT.checkExecutionMode();
884 >                threadAssertSame(t, ex1);
885 >                a.getAndIncrement();
886 >                throw ex2;
887 >            });
888 >        if (createIncomplete) f.completeExceptionally(ex1);
889 >
890 >        checkCompletedWithWrappedException(g, ex2);
891 >        assertEquals(1, a.get());
892 >    }}
893  
894      /**
895 <     * handle action completes normally with function value on either
896 <     * normal or exceptional completion of source
895 >     * handle action completes normally with function value on normal
896 >     * completion of source
897       */
898 <    public void testHandle() {
899 <        CompletableFuture<Integer> f, g;
900 <        IntegerHandler r;
898 >    public void testHandle_normalCompletion() {
899 >        for (ExecutionMode m : ExecutionMode.values())
900 >        for (boolean createIncomplete : new boolean[] { true, false })
901 >        for (Integer v1 : new Integer[] { 1, null })
902 >    {
903 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
904 >        final AtomicInteger a = new AtomicInteger(0);
905 >        if (!createIncomplete) f.complete(v1);
906 >        final CompletableFuture<Integer> g = m.handle
907 >            (f,
908 >             (Integer x, Throwable t) -> {
909 >                m.checkExecutionMode();
910 >                threadAssertSame(x, v1);
911 >                threadAssertNull(t);
912 >                a.getAndIncrement();
913 >                return inc(v1);
914 >            });
915 >        if (createIncomplete) f.complete(v1);
916  
917 <        f = new CompletableFuture<>();
918 <        f.completeExceptionally(new CFException());
919 <        g = f.handle(r = new IntegerHandler());
920 <        assertTrue(r.ran);
687 <        checkCompletedNormally(g, three);
917 >        checkCompletedNormally(g, inc(v1));
918 >        checkCompletedNormally(f, v1);
919 >        assertEquals(1, a.get());
920 >    }}
921  
922 <        f = new CompletableFuture<>();
923 <        g = f.handle(r = new IntegerHandler());
924 <        assertFalse(r.ran);
925 <        f.completeExceptionally(new CFException());
926 <        checkCompletedNormally(g, three);
927 <        assertTrue(r.ran);
922 >    /**
923 >     * handle action completes normally with function value on
924 >     * exceptional completion of source
925 >     */
926 >    public void testHandle_exceptionalCompletion() {
927 >        for (ExecutionMode m : ExecutionMode.values())
928 >        for (boolean createIncomplete : new boolean[] { true, false })
929 >        for (Integer v1 : new Integer[] { 1, null })
930 >    {
931 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
932 >        final AtomicInteger a = new AtomicInteger(0);
933 >        final CFException ex = new CFException();
934 >        if (!createIncomplete) f.completeExceptionally(ex);
935 >        final CompletableFuture<Integer> g = m.handle
936 >            (f,
937 >             (Integer x, Throwable t) -> {
938 >                m.checkExecutionMode();
939 >                threadAssertNull(x);
940 >                threadAssertSame(t, ex);
941 >                a.getAndIncrement();
942 >                return v1;
943 >            });
944 >        if (createIncomplete) f.completeExceptionally(ex);
945  
946 <        f = new CompletableFuture<>();
947 <        f.complete(one);
948 <        g = f.handle(r = new IntegerHandler());
949 <        assertTrue(r.ran);
700 <        checkCompletedNormally(g, two);
946 >        checkCompletedNormally(g, v1);
947 >        checkCompletedExceptionally(f, ex);
948 >        assertEquals(1, a.get());
949 >    }}
950  
951 <        f = new CompletableFuture<>();
952 <        g = f.handle(r = new IntegerHandler());
953 <        assertFalse(r.ran);
954 <        f.complete(one);
955 <        assertTrue(r.ran);
956 <        checkCompletedNormally(g, two);
957 <    }
951 >    /**
952 >     * handle action completes normally with function value on
953 >     * cancelled source
954 >     */
955 >    public void testHandle_sourceCancelled() {
956 >        for (ExecutionMode m : ExecutionMode.values())
957 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
958 >        for (boolean createIncomplete : new boolean[] { true, false })
959 >        for (Integer v1 : new Integer[] { 1, null })
960 >    {
961 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
962 >        final AtomicInteger a = new AtomicInteger(0);
963 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
964 >        final CompletableFuture<Integer> g = m.handle
965 >            (f,
966 >             (Integer x, Throwable t) -> {
967 >                m.checkExecutionMode();
968 >                threadAssertNull(x);
969 >                threadAssertTrue(t instanceof CancellationException);
970 >                a.getAndIncrement();
971 >                return v1;
972 >            });
973 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
974 >
975 >        checkCompletedNormally(g, v1);
976 >        checkCancelled(f);
977 >        assertEquals(1, a.get());
978 >    }}
979  
980      /**
981 <     * runAsync completes after running Runnable
981 >     * handle result completes exceptionally if action does
982       */
983 <    public void testRunAsync() {
984 <        Noop r = new Noop();
985 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
986 <        assertNull(f.join());
987 <        assertTrue(r.ran);
988 <        checkCompletedNormally(f, null);
989 <    }
983 >    public void testHandle_sourceFailedActionFailed() {
984 >        for (ExecutionMode m : ExecutionMode.values())
985 >        for (boolean createIncomplete : new boolean[] { true, false })
986 >    {
987 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
988 >        final AtomicInteger a = new AtomicInteger(0);
989 >        final CFException ex1 = new CFException();
990 >        final CFException ex2 = new CFException();
991 >        if (!createIncomplete) f.completeExceptionally(ex1);
992 >        final CompletableFuture<Integer> g = m.handle
993 >            (f,
994 >             (Integer x, Throwable t) -> {
995 >                m.checkExecutionMode();
996 >                threadAssertNull(x);
997 >                threadAssertSame(ex1, t);
998 >                a.getAndIncrement();
999 >                throw ex2;
1000 >            });
1001 >        if (createIncomplete) f.completeExceptionally(ex1);
1002 >
1003 >        checkCompletedWithWrappedException(g, ex2);
1004 >        checkCompletedExceptionally(f, ex1);
1005 >        assertEquals(1, a.get());
1006 >    }}
1007 >
1008 >    public void testHandle_sourceCompletedNormallyActionFailed() {
1009 >        for (ExecutionMode m : ExecutionMode.values())
1010 >        for (boolean createIncomplete : new boolean[] { true, false })
1011 >        for (Integer v1 : new Integer[] { 1, null })
1012 >    {
1013 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1014 >        final AtomicInteger a = new AtomicInteger(0);
1015 >        final CFException ex = new CFException();
1016 >        if (!createIncomplete) f.complete(v1);
1017 >        final CompletableFuture<Integer> g = m.handle
1018 >            (f,
1019 >             (Integer x, Throwable t) -> {
1020 >                m.checkExecutionMode();
1021 >                threadAssertSame(x, v1);
1022 >                threadAssertNull(t);
1023 >                a.getAndIncrement();
1024 >                throw ex;
1025 >            });
1026 >        if (createIncomplete) f.complete(v1);
1027 >
1028 >        checkCompletedWithWrappedException(g, ex);
1029 >        checkCompletedNormally(f, v1);
1030 >        assertEquals(1, a.get());
1031 >    }}
1032  
1033      /**
1034 <     * runAsync with executor completes after running Runnable
1034 >     * runAsync completes after running Runnable
1035       */
1036 <    public void testRunAsync2() {
1037 <        Noop r = new Noop();
1038 <        ThreadExecutor exec = new ThreadExecutor();
1039 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
1036 >    public void testRunAsync_normalCompletion() {
1037 >        ExecutionMode[] executionModes = {
1038 >            ExecutionMode.ASYNC,
1039 >            ExecutionMode.EXECUTOR,
1040 >        };
1041 >        for (ExecutionMode m : executionModes)
1042 >    {
1043 >        final Noop r = new Noop(m);
1044 >        final CompletableFuture<Void> f = m.runAsync(r);
1045          assertNull(f.join());
729        assertTrue(r.ran);
1046          checkCompletedNormally(f, null);
1047 <        assertEquals(1, exec.count.get());
1048 <    }
1047 >        r.assertInvoked();
1048 >    }}
1049  
1050      /**
1051       * failing runAsync completes exceptionally after running Runnable
1052       */
1053 <    public void testRunAsync3() {
1054 <        FailingNoop r = new FailingNoop();
1055 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1053 >    public void testRunAsync_exceptionalCompletion() {
1054 >        ExecutionMode[] executionModes = {
1055 >            ExecutionMode.ASYNC,
1056 >            ExecutionMode.EXECUTOR,
1057 >        };
1058 >        for (ExecutionMode m : executionModes)
1059 >    {
1060 >        final FailingRunnable r = new FailingRunnable(m);
1061 >        final CompletableFuture<Void> f = m.runAsync(r);
1062          checkCompletedWithWrappedCFException(f);
1063 <        assertTrue(r.ran);
1064 <    }
1063 >        r.assertInvoked();
1064 >    }}
1065  
1066      /**
1067       * supplyAsync completes with result of supplier
1068       */
1069 <    public void testSupplyAsync() {
1070 <        CompletableFuture<Integer> f;
1071 <        f = CompletableFuture.supplyAsync(supplyOne);
1072 <        assertEquals(f.join(), one);
1073 <        checkCompletedNormally(f, one);
1074 <    }
1075 <
1076 <    /**
1077 <     * supplyAsync with executor completes with result of supplier
1078 <     */
1079 <    public void testSupplyAsync2() {
1080 <        CompletableFuture<Integer> f;
1081 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
1082 <        assertEquals(f.join(), one);
761 <        checkCompletedNormally(f, one);
762 <    }
1069 >    public void testSupplyAsync_normalCompletion() {
1070 >        ExecutionMode[] executionModes = {
1071 >            ExecutionMode.ASYNC,
1072 >            ExecutionMode.EXECUTOR,
1073 >        };
1074 >        for (ExecutionMode m : executionModes)
1075 >        for (Integer v1 : new Integer[] { 1, null })
1076 >    {
1077 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1078 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1079 >        assertSame(v1, f.join());
1080 >        checkCompletedNormally(f, v1);
1081 >        r.assertInvoked();
1082 >    }}
1083  
1084      /**
1085       * Failing supplyAsync completes exceptionally
1086       */
1087 <    public void testSupplyAsync3() {
1088 <        FailingSupplier r = new FailingSupplier();
1089 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1087 >    public void testSupplyAsync_exceptionalCompletion() {
1088 >        ExecutionMode[] executionModes = {
1089 >            ExecutionMode.ASYNC,
1090 >            ExecutionMode.EXECUTOR,
1091 >        };
1092 >        for (ExecutionMode m : executionModes)
1093 >    {
1094 >        FailingSupplier r = new FailingSupplier(m);
1095 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1096          checkCompletedWithWrappedCFException(f);
1097 <        assertTrue(r.ran);
1098 <    }
1097 >        r.assertInvoked();
1098 >    }}
1099  
1100      // seq completion methods
1101  
1102      /**
1103       * thenRun result completes normally after normal completion of source
1104       */
1105 <    public void testThenRun() {
1106 <        CompletableFuture<Integer> f;
1107 <        CompletableFuture<Void> g;
1108 <        Noop r;
1109 <
1110 <        f = new CompletableFuture<>();
1111 <        g = f.thenRun(r = new Noop());
1112 <        f.complete(null);
1113 <        checkCompletedNormally(g, null);
1114 <        assertTrue(r.ran);
1105 >    public void testThenRun_normalCompletion() {
1106 >        for (ExecutionMode m : ExecutionMode.values())
1107 >        for (boolean createIncomplete : new boolean[] { true, false })
1108 >        for (Integer v1 : new Integer[] { 1, null })
1109 >    {
1110 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1111 >        final Noop r = new Noop(m);
1112 >        if (!createIncomplete) f.complete(v1);
1113 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1114 >        if (createIncomplete) {
1115 >            checkIncomplete(g);
1116 >            f.complete(v1);
1117 >        }
1118  
790        f = new CompletableFuture<>();
791        f.complete(null);
792        g = f.thenRun(r = new Noop());
1119          checkCompletedNormally(g, null);
1120 <        assertTrue(r.ran);
1121 <    }
1120 >        checkCompletedNormally(f, v1);
1121 >        r.assertInvoked();
1122 >    }}
1123  
1124      /**
1125       * thenRun result completes exceptionally after exceptional
1126       * completion of source
1127       */
1128 <    public void testThenRun2() {
1129 <        CompletableFuture<Integer> f;
1130 <        CompletableFuture<Void> g;
1131 <        Noop r;
1132 <
1133 <        f = new CompletableFuture<>();
1134 <        g = f.thenRun(r = new Noop());
1135 <        f.completeExceptionally(new CFException());
1136 <        checkCompletedWithWrappedCFException(g);
1137 <        assertFalse(r.ran);
1138 <
1139 <        f = new CompletableFuture<>();
1140 <        f.completeExceptionally(new CFException());
814 <        g = f.thenRun(r = new Noop());
815 <        checkCompletedWithWrappedCFException(g);
816 <        assertFalse(r.ran);
817 <    }
818 <
819 <    /**
820 <     * thenRun result completes exceptionally if action does
821 <     */
822 <    public void testThenRun3() {
823 <        CompletableFuture<Integer> f;
824 <        CompletableFuture<Void> g;
825 <        FailingNoop r;
826 <
827 <        f = new CompletableFuture<>();
828 <        g = f.thenRun(r = new FailingNoop());
829 <        f.complete(null);
830 <        checkCompletedWithWrappedCFException(g);
1128 >    public void testThenRun_exceptionalCompletion() {
1129 >        for (ExecutionMode m : ExecutionMode.values())
1130 >        for (boolean createIncomplete : new boolean[] { true, false })
1131 >    {
1132 >        final CFException ex = new CFException();
1133 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1134 >        final Noop r = new Noop(m);
1135 >        if (!createIncomplete) f.completeExceptionally(ex);
1136 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1137 >        if (createIncomplete) {
1138 >            checkIncomplete(g);
1139 >            f.completeExceptionally(ex);
1140 >        }
1141  
1142 <        f = new CompletableFuture<>();
1143 <        f.complete(null);
1144 <        g = f.thenRun(r = new FailingNoop());
1145 <        checkCompletedWithWrappedCFException(g);
836 <    }
1142 >        checkCompletedWithWrappedException(g, ex);
1143 >        checkCompletedExceptionally(f, ex);
1144 >        r.assertNotInvoked();
1145 >    }}
1146  
1147      /**
1148       * thenRun result completes exceptionally if source cancelled
1149       */
1150 <    public void testThenRun4() {
1151 <        CompletableFuture<Integer> f;
1152 <        CompletableFuture<Void> g;
1153 <        Noop r;
1154 <
1155 <        f = new CompletableFuture<>();
1156 <        g = f.thenRun(r = new Noop());
1157 <        assertTrue(f.cancel(true));
1158 <        checkCompletedWithWrappedCancellationException(g);
1159 <
1160 <        f = new CompletableFuture<>();
1161 <        assertTrue(f.cancel(true));
1162 <        g = f.thenRun(r = new Noop());
854 <        checkCompletedWithWrappedCancellationException(g);
855 <    }
856 <
857 <    /**
858 <     * thenApply result completes normally after normal completion of source
859 <     */
860 <    public void testThenApply() {
861 <        CompletableFuture<Integer> f = new CompletableFuture<>();
862 <        CompletableFuture<Integer> g = f.thenApply(inc);
863 <        f.complete(one);
864 <        checkCompletedNormally(g, two);
865 <    }
866 <
867 <    /**
868 <     * thenApply result completes exceptionally after exceptional
869 <     * completion of source
870 <     */
871 <    public void testThenApply2() {
872 <        CompletableFuture<Integer> f = new CompletableFuture<>();
873 <        CompletableFuture<Integer> g = f.thenApply(inc);
874 <        f.completeExceptionally(new CFException());
875 <        checkCompletedWithWrappedCFException(g);
876 <    }
877 <
878 <    /**
879 <     * thenApply result completes exceptionally if action does
880 <     */
881 <    public void testThenApply3() {
882 <        CompletableFuture<Integer> f = new CompletableFuture<>();
883 <        CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
884 <        f.complete(one);
885 <        checkCompletedWithWrappedCFException(g);
886 <    }
887 <
888 <    /**
889 <     * thenApply result completes exceptionally if source cancelled
890 <     */
891 <    public void testThenApply4() {
892 <        CompletableFuture<Integer> f = new CompletableFuture<>();
893 <        CompletableFuture<Integer> g = f.thenApply(inc);
894 <        assertTrue(f.cancel(true));
895 <        checkCompletedWithWrappedCancellationException(g);
896 <    }
897 <
898 <    /**
899 <     * thenAccept result completes normally after normal completion of source
900 <     */
901 <    public void testThenAccept() {
902 <        CompletableFuture<Integer> f = new CompletableFuture<>();
903 <        IncAction r = new IncAction();
904 <        CompletableFuture<Void> g = f.thenAccept(r);
905 <        f.complete(one);
906 <        checkCompletedNormally(g, null);
907 <        assertEquals(r.value, (Integer) 2);
908 <    }
909 <
910 <    /**
911 <     * thenAccept result completes exceptionally after exceptional
912 <     * completion of source
913 <     */
914 <    public void testThenAccept2() {
915 <        CompletableFuture<Integer> f = new CompletableFuture<>();
916 <        IncAction r = new IncAction();
917 <        CompletableFuture<Void> g = f.thenAccept(r);
918 <        f.completeExceptionally(new CFException());
919 <        checkCompletedWithWrappedCFException(g);
920 <    }
921 <
922 <    /**
923 <     * thenAccept result completes exceptionally if action does
924 <     */
925 <    public void testThenAccept3() {
926 <        CompletableFuture<Integer> f = new CompletableFuture<>();
927 <        FailingConsumer r = new FailingConsumer();
928 <        CompletableFuture<Void> g = f.thenAccept(r);
929 <        f.complete(one);
930 <        checkCompletedWithWrappedCFException(g);
931 <        assertTrue(r.ran);
932 <    }
1150 >    public void testThenRun_sourceCancelled() {
1151 >        for (ExecutionMode m : ExecutionMode.values())
1152 >        for (boolean createIncomplete : new boolean[] { true, false })
1153 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1154 >    {
1155 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1156 >        final Noop r = new Noop(m);
1157 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1158 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1159 >        if (createIncomplete) {
1160 >            checkIncomplete(g);
1161 >            assertTrue(f.cancel(mayInterruptIfRunning));
1162 >        }
1163  
934    /**
935     * thenAccept result completes exceptionally if source cancelled
936     */
937    public void testThenAccept4() {
938        CompletableFuture<Integer> f = new CompletableFuture<>();
939        IncAction r = new IncAction();
940        CompletableFuture<Void> g = f.thenAccept(r);
941        assertTrue(f.cancel(true));
1164          checkCompletedWithWrappedCancellationException(g);
1165 <    }
1165 >        checkCancelled(f);
1166 >        r.assertNotInvoked();
1167 >    }}
1168  
1169      /**
1170 <     * thenCombine result completes normally after normal completion
947 <     * of sources
1170 >     * thenRun result completes exceptionally if action does
1171       */
1172 <    public void testThenCombine_normalCompletion1() {
1172 >    public void testThenRun_actionFailed() {
1173          for (ExecutionMode m : ExecutionMode.values())
1174 +        for (boolean createIncomplete : new boolean[] { true, false })
1175          for (Integer v1 : new Integer[] { 1, null })
1176 <        for (Integer v2 : new Integer[] { 2, null }) {
953 <
1176 >    {
1177          final CompletableFuture<Integer> f = new CompletableFuture<>();
1178 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1179 <        final SubtractFunction r = new SubtractFunction();
1180 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1181 <
1182 <        f.complete(v1);
1183 <        checkIncomplete(h);
961 <        assertEquals(r.invocationCount, 0);
962 <        g.complete(v2);
963 <
964 <        checkCompletedNormally(h, subtract(v1, v2));
965 <        checkCompletedNormally(f, v1);
966 <        checkCompletedNormally(g, v2);
967 <        assertEquals(r.invocationCount, 1);
1178 >        final FailingRunnable r = new FailingRunnable(m);
1179 >        if (!createIncomplete) f.complete(v1);
1180 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1181 >        if (createIncomplete) {
1182 >            checkIncomplete(g);
1183 >            f.complete(v1);
1184          }
969    }
970
971    public void testThenCombine_normalCompletion2() {
972        for (ExecutionMode m : ExecutionMode.values())
973        for (Integer v1 : new Integer[] { 1, null })
974        for (Integer v2 : new Integer[] { 2, null }) {
1185  
1186 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
977 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
978 <        final SubtractFunction r = new SubtractFunction();
979 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
980 <
981 <        g.complete(v2);
982 <        checkIncomplete(h);
983 <        assertEquals(r.invocationCount, 0);
984 <        f.complete(v1);
985 <
986 <        checkCompletedNormally(h, subtract(v1, v2));
1186 >        checkCompletedWithWrappedCFException(g);
1187          checkCompletedNormally(f, v1);
1188 <        checkCompletedNormally(g, v2);
989 <        assertEquals(r.invocationCount, 1);
990 <        }
991 <    }
1188 >    }}
1189  
1190 <    public void testThenCombine_normalCompletion3() {
1190 >    /**
1191 >     * thenApply result completes normally after normal completion of source
1192 >     */
1193 >    public void testThenApply_normalCompletion() {
1194          for (ExecutionMode m : ExecutionMode.values())
1195 +        for (boolean createIncomplete : new boolean[] { true, false })
1196          for (Integer v1 : new Integer[] { 1, null })
1197 <        for (Integer v2 : new Integer[] { 2, null }) {
997 <
1197 >    {
1198          final CompletableFuture<Integer> f = new CompletableFuture<>();
1199 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1200 <        final SubtractFunction r = new SubtractFunction();
1201 <
1202 <        g.complete(v2);
1203 <        f.complete(v1);
1204 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1005 <
1006 <        checkCompletedNormally(h, subtract(v1, v2));
1007 <        checkCompletedNormally(f, v1);
1008 <        checkCompletedNormally(g, v2);
1009 <        assertEquals(r.invocationCount, 1);
1199 >        final IncFunction r = new IncFunction(m);
1200 >        if (!createIncomplete) f.complete(v1);
1201 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1202 >        if (createIncomplete) {
1203 >            checkIncomplete(g);
1204 >            f.complete(v1);
1205          }
1011    }
1206  
1207 <    public void testThenCombine_normalCompletion4() {
1014 <        for (ExecutionMode m : ExecutionMode.values())
1015 <        for (Integer v1 : new Integer[] { 1, null })
1016 <        for (Integer v2 : new Integer[] { 2, null }) {
1017 <
1018 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1019 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1020 <        final SubtractFunction r = new SubtractFunction();
1021 <
1022 <        f.complete(v1);
1023 <        g.complete(v2);
1024 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1025 <
1026 <        checkCompletedNormally(h, subtract(v1, v2));
1207 >        checkCompletedNormally(g, inc(v1));
1208          checkCompletedNormally(f, v1);
1209 <        checkCompletedNormally(g, v2);
1210 <        assertEquals(r.invocationCount, 1);
1030 <        }
1031 <    }
1209 >        r.assertValue(inc(v1));
1210 >    }}
1211  
1212      /**
1213 <     * thenCombine result completes exceptionally after exceptional
1214 <     * completion of either source
1213 >     * thenApply result completes exceptionally after exceptional
1214 >     * completion of source
1215       */
1216 <    public void testThenCombine_exceptionalCompletion1() {
1216 >    public void testThenApply_exceptionalCompletion() {
1217          for (ExecutionMode m : ExecutionMode.values())
1218 <        for (Integer v1 : new Integer[] { 1, null }) {
1219 <
1041 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1042 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1043 <        final SubtractFunction r = new SubtractFunction();
1044 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1218 >        for (boolean createIncomplete : new boolean[] { true, false })
1219 >    {
1220          final CFException ex = new CFException();
1046
1047        f.completeExceptionally(ex);
1048        checkIncomplete(h);
1049        g.complete(v1);
1050
1051        checkCompletedWithWrappedCFException(h, ex);
1052        checkCompletedWithWrappedCFException(f, ex);
1053        assertEquals(r.invocationCount, 0);
1054        checkCompletedNormally(g, v1);
1055        }
1056    }
1057
1058    public void testThenCombine_exceptionalCompletion2() {
1059        for (ExecutionMode m : ExecutionMode.values())
1060        for (Integer v1 : new Integer[] { 1, null }) {
1061
1221          final CompletableFuture<Integer> f = new CompletableFuture<>();
1222 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1223 <        final SubtractFunction r = new SubtractFunction();
1224 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1225 <        final CFException ex = new CFException();
1226 <
1227 <        g.completeExceptionally(ex);
1069 <        checkIncomplete(h);
1070 <        f.complete(v1);
1071 <
1072 <        checkCompletedWithWrappedCFException(h, ex);
1073 <        checkCompletedWithWrappedCFException(g, ex);
1074 <        assertEquals(r.invocationCount, 0);
1075 <        checkCompletedNormally(f, v1);
1222 >        final IncFunction r = new IncFunction(m);
1223 >        if (!createIncomplete) f.completeExceptionally(ex);
1224 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1225 >        if (createIncomplete) {
1226 >            checkIncomplete(g);
1227 >            f.completeExceptionally(ex);
1228          }
1077    }
1229  
1230 <    public void testThenCombine_exceptionalCompletion3() {
1231 <        for (ExecutionMode m : ExecutionMode.values())
1232 <        for (Integer v1 : new Integer[] { 1, null }) {
1233 <
1083 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1084 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1085 <        final SubtractFunction r = new SubtractFunction();
1086 <        final CFException ex = new CFException();
1087 <
1088 <        g.completeExceptionally(ex);
1089 <        f.complete(v1);
1090 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1230 >        checkCompletedWithWrappedException(g, ex);
1231 >        checkCompletedExceptionally(f, ex);
1232 >        r.assertNotInvoked();
1233 >    }}
1234  
1235 <        checkCompletedWithWrappedCFException(h, ex);
1236 <        checkCompletedWithWrappedCFException(g, ex);
1237 <        assertEquals(r.invocationCount, 0);
1238 <        checkCompletedNormally(f, v1);
1096 <        }
1097 <    }
1098 <
1099 <    public void testThenCombine_exceptionalCompletion4() {
1235 >    /**
1236 >     * thenApply result completes exceptionally if source cancelled
1237 >     */
1238 >    public void testThenApply_sourceCancelled() {
1239          for (ExecutionMode m : ExecutionMode.values())
1240 <        for (Integer v1 : new Integer[] { 1, null }) {
1241 <
1240 >        for (boolean createIncomplete : new boolean[] { true, false })
1241 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1242 >    {
1243          final CompletableFuture<Integer> f = new CompletableFuture<>();
1244 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1245 <        final SubtractFunction r = new SubtractFunction();
1246 <        final CFException ex = new CFException();
1247 <
1248 <        f.completeExceptionally(ex);
1249 <        g.complete(v1);
1110 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1111 <
1112 <        checkCompletedWithWrappedCFException(h, ex);
1113 <        checkCompletedWithWrappedCFException(f, ex);
1114 <        assertEquals(r.invocationCount, 0);
1115 <        checkCompletedNormally(g, v1);
1244 >        final IncFunction r = new IncFunction(m);
1245 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1246 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1247 >        if (createIncomplete) {
1248 >            checkIncomplete(g);
1249 >            assertTrue(f.cancel(mayInterruptIfRunning));
1250          }
1251 <    }
1251 >
1252 >        checkCompletedWithWrappedCancellationException(g);
1253 >        checkCancelled(f);
1254 >        r.assertNotInvoked();
1255 >    }}
1256  
1257      /**
1258 <     * thenCombine result completes exceptionally if action does
1258 >     * thenApply result completes exceptionally if action does
1259       */
1260 <    public void testThenCombine_actionFailed1() {
1260 >    public void testThenApply_actionFailed() {
1261          for (ExecutionMode m : ExecutionMode.values())
1262 +        for (boolean createIncomplete : new boolean[] { true, false })
1263          for (Integer v1 : new Integer[] { 1, null })
1264 <        for (Integer v2 : new Integer[] { 2, null }) {
1126 <
1264 >    {
1265          final CompletableFuture<Integer> f = new CompletableFuture<>();
1266 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1267 <        final FailingBiFunction r = new FailingBiFunction();
1268 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1269 <
1270 <        f.complete(v1);
1271 <        checkIncomplete(h);
1272 <        g.complete(v2);
1266 >        final FailingFunction r = new FailingFunction(m);
1267 >        if (!createIncomplete) f.complete(v1);
1268 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1269 >        if (createIncomplete) {
1270 >            checkIncomplete(g);
1271 >            f.complete(v1);
1272 >        }
1273  
1274 <        checkCompletedWithWrappedCFException(h);
1274 >        checkCompletedWithWrappedCFException(g);
1275          checkCompletedNormally(f, v1);
1276 <        checkCompletedNormally(g, v2);
1139 <        }
1140 <    }
1276 >    }}
1277  
1278 <    public void testThenCombine_actionFailed2() {
1278 >    /**
1279 >     * thenAccept result completes normally after normal completion of source
1280 >     */
1281 >    public void testThenAccept_normalCompletion() {
1282          for (ExecutionMode m : ExecutionMode.values())
1283 +        for (boolean createIncomplete : new boolean[] { true, false })
1284          for (Integer v1 : new Integer[] { 1, null })
1285 <        for (Integer v2 : new Integer[] { 2, null }) {
1146 <
1285 >    {
1286          final CompletableFuture<Integer> f = new CompletableFuture<>();
1287 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1288 <        final FailingBiFunction r = new FailingBiFunction();
1289 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1290 <
1291 <        g.complete(v2);
1292 <        checkIncomplete(h);
1293 <        f.complete(v1);
1287 >        final NoopConsumer r = new NoopConsumer(m);
1288 >        if (!createIncomplete) f.complete(v1);
1289 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1290 >        if (createIncomplete) {
1291 >            checkIncomplete(g);
1292 >            f.complete(v1);
1293 >        }
1294  
1295 <        checkCompletedWithWrappedCFException(h);
1295 >        checkCompletedNormally(g, null);
1296 >        r.assertValue(v1);
1297          checkCompletedNormally(f, v1);
1298 <        checkCompletedNormally(g, v2);
1159 <        }
1160 <    }
1298 >    }}
1299  
1300      /**
1301 <     * thenCombine result completes exceptionally if either source cancelled
1301 >     * thenAccept result completes exceptionally after exceptional
1302 >     * completion of source
1303       */
1304 <    public void testThenCombine_sourceCancelled1() {
1304 >    public void testThenAccept_exceptionalCompletion() {
1305          for (ExecutionMode m : ExecutionMode.values())
1306 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1307 <        for (Integer v1 : new Integer[] { 1, null }) {
1308 <
1306 >        for (boolean createIncomplete : new boolean[] { true, false })
1307 >    {
1308 >        final CFException ex = new CFException();
1309          final CompletableFuture<Integer> f = new CompletableFuture<>();
1310 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1311 <        final SubtractFunction r = new SubtractFunction();
1312 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1313 <
1314 <        assertTrue(f.cancel(mayInterruptIfRunning));
1315 <        checkIncomplete(h);
1177 <        g.complete(v1);
1178 <
1179 <        checkCompletedWithWrappedCancellationException(h);
1180 <        checkCancelled(f);
1181 <        assertEquals(r.invocationCount, 0);
1182 <        checkCompletedNormally(g, v1);
1310 >        final NoopConsumer r = new NoopConsumer(m);
1311 >        if (!createIncomplete) f.completeExceptionally(ex);
1312 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1313 >        if (createIncomplete) {
1314 >            checkIncomplete(g);
1315 >            f.completeExceptionally(ex);
1316          }
1184    }
1317  
1318 <    public void testThenCombine_sourceCancelled2() {
1319 <        for (ExecutionMode m : ExecutionMode.values())
1320 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1321 <        for (Integer v1 : new Integer[] { 1, null }) {
1318 >        checkCompletedWithWrappedException(g, ex);
1319 >        checkCompletedExceptionally(f, ex);
1320 >        r.assertNotInvoked();
1321 >    }}
1322  
1323 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1324 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1325 <        final SubtractFunction r = new SubtractFunction();
1326 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1195 <
1196 <        assertTrue(g.cancel(mayInterruptIfRunning));
1197 <        checkIncomplete(h);
1198 <        f.complete(v1);
1199 <
1200 <        checkCompletedWithWrappedCancellationException(h);
1201 <        checkCancelled(g);
1202 <        assertEquals(r.invocationCount, 0);
1203 <        checkCompletedNormally(f, v1);
1204 <        }
1205 <    }
1206 <
1207 <    public void testThenCombine_sourceCancelled3() {
1323 >    /**
1324 >     * thenAccept result completes exceptionally if source cancelled
1325 >     */
1326 >    public void testThenAccept_sourceCancelled() {
1327          for (ExecutionMode m : ExecutionMode.values())
1328 +        for (boolean createIncomplete : new boolean[] { true, false })
1329          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1330 <        for (Integer v1 : new Integer[] { 1, null }) {
1211 <
1330 >    {
1331          final CompletableFuture<Integer> f = new CompletableFuture<>();
1332 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1333 <        final SubtractFunction r = new SubtractFunction();
1334 <
1335 <        assertTrue(g.cancel(mayInterruptIfRunning));
1336 <        f.complete(v1);
1337 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1219 <
1220 <        checkCompletedWithWrappedCancellationException(h);
1221 <        checkCancelled(g);
1222 <        assertEquals(r.invocationCount, 0);
1223 <        checkCompletedNormally(f, v1);
1332 >        final NoopConsumer r = new NoopConsumer(m);
1333 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1334 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1335 >        if (createIncomplete) {
1336 >            checkIncomplete(g);
1337 >            assertTrue(f.cancel(mayInterruptIfRunning));
1338          }
1225    }
1339  
1340 <    public void testThenCombine_sourceCancelled4() {
1228 <        for (ExecutionMode m : ExecutionMode.values())
1229 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1230 <        for (Integer v1 : new Integer[] { 1, null }) {
1231 <
1232 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1233 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1234 <        final SubtractFunction r = new SubtractFunction();
1235 <
1236 <        assertTrue(f.cancel(mayInterruptIfRunning));
1237 <        g.complete(v1);
1238 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1239 <
1240 <        checkCompletedWithWrappedCancellationException(h);
1340 >        checkCompletedWithWrappedCancellationException(g);
1341          checkCancelled(f);
1342 <        assertEquals(r.invocationCount, 0);
1343 <        checkCompletedNormally(g, v1);
1244 <        }
1245 <    }
1342 >        r.assertNotInvoked();
1343 >    }}
1344  
1345      /**
1346 <     * thenAcceptBoth result completes normally after normal
1249 <     * completion of sources
1346 >     * thenAccept result completes exceptionally if action does
1347       */
1348 <    public void testThenAcceptBoth_normalCompletion1() {
1348 >    public void testThenAccept_actionFailed() {
1349          for (ExecutionMode m : ExecutionMode.values())
1350 +        for (boolean createIncomplete : new boolean[] { true, false })
1351          for (Integer v1 : new Integer[] { 1, null })
1352 <        for (Integer v2 : new Integer[] { 2, null }) {
1255 <
1352 >    {
1353          final CompletableFuture<Integer> f = new CompletableFuture<>();
1354 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1355 <        final SubtractAction r = new SubtractAction();
1356 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1357 <
1358 <        f.complete(v1);
1359 <        checkIncomplete(h);
1263 <        assertFalse(r.ran());
1264 <        g.complete(v2);
1265 <
1266 <        checkCompletedNormally(h, null);
1267 <        assertEquals(r.value, subtract(v1, v2));
1268 <        checkCompletedNormally(f, v1);
1269 <        checkCompletedNormally(g, v2);
1354 >        final FailingConsumer r = new FailingConsumer(m);
1355 >        if (!createIncomplete) f.complete(v1);
1356 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1357 >        if (createIncomplete) {
1358 >            checkIncomplete(g);
1359 >            f.complete(v1);
1360          }
1271    }
1272
1273    public void testThenAcceptBoth_normalCompletion2() {
1274        for (ExecutionMode m : ExecutionMode.values())
1275        for (Integer v1 : new Integer[] { 1, null })
1276        for (Integer v2 : new Integer[] { 2, null }) {
1361  
1362 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1279 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1280 <        final SubtractAction r = new SubtractAction();
1281 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1282 <
1283 <        g.complete(v2);
1284 <        checkIncomplete(h);
1285 <        assertFalse(r.ran());
1286 <        f.complete(v1);
1287 <
1288 <        checkCompletedNormally(h, null);
1289 <        assertEquals(r.value, subtract(v1, v2));
1362 >        checkCompletedWithWrappedCFException(g);
1363          checkCompletedNormally(f, v1);
1364 <        checkCompletedNormally(g, v2);
1292 <        }
1293 <    }
1364 >    }}
1365  
1366 <    public void testThenAcceptBoth_normalCompletion3() {
1366 >    /**
1367 >     * thenCombine result completes normally after normal completion
1368 >     * of sources
1369 >     */
1370 >    public void testThenCombine_normalCompletion() {
1371          for (ExecutionMode m : ExecutionMode.values())
1372 +        for (boolean createIncomplete : new boolean[] { true, false })
1373 +        for (boolean fFirst : new boolean[] { true, false })
1374          for (Integer v1 : new Integer[] { 1, null })
1375 <        for (Integer v2 : new Integer[] { 2, null }) {
1376 <
1375 >        for (Integer v2 : new Integer[] { 2, null })
1376 >    {
1377          final CompletableFuture<Integer> f = new CompletableFuture<>();
1378          final CompletableFuture<Integer> g = new CompletableFuture<>();
1379 <        final SubtractAction r = new SubtractAction();
1379 >        final SubtractFunction r = new SubtractFunction(m);
1380  
1381 <        g.complete(v2);
1382 <        f.complete(v1);
1383 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1384 <
1385 <        checkCompletedNormally(h, null);
1386 <        assertEquals(r.value, subtract(v1, v2));
1387 <        checkCompletedNormally(f, v1);
1388 <        checkCompletedNormally(g, v2);
1381 >        if (fFirst) f.complete(v1); else g.complete(v2);
1382 >        if (!createIncomplete)
1383 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1384 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1385 >        if (createIncomplete) {
1386 >            checkIncomplete(h);
1387 >            r.assertNotInvoked();
1388 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1389          }
1313    }
1314
1315    public void testThenAcceptBoth_normalCompletion4() {
1316        for (ExecutionMode m : ExecutionMode.values())
1317        for (Integer v1 : new Integer[] { 1, null })
1318        for (Integer v2 : new Integer[] { 2, null }) {
1319
1320        final CompletableFuture<Integer> f = new CompletableFuture<>();
1321        final CompletableFuture<Integer> g = new CompletableFuture<>();
1322        final SubtractAction r = new SubtractAction();
1390  
1391 <        f.complete(v1);
1325 <        g.complete(v2);
1326 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1327 <
1328 <        checkCompletedNormally(h, null);
1329 <        assertEquals(r.value, subtract(v1, v2));
1391 >        checkCompletedNormally(h, subtract(v1, v2));
1392          checkCompletedNormally(f, v1);
1393          checkCompletedNormally(g, v2);
1394 <        }
1395 <    }
1394 >        r.assertValue(subtract(v1, v2));
1395 >    }}
1396  
1397      /**
1398 <     * thenAcceptBoth result completes exceptionally after exceptional
1398 >     * thenCombine result completes exceptionally after exceptional
1399       * completion of either source
1400       */
1401 <    public void testThenAcceptBoth_exceptionalCompletion1() {
1401 >    public void testThenCombine_exceptionalCompletion() {
1402          for (ExecutionMode m : ExecutionMode.values())
1403 <        for (Integer v1 : new Integer[] { 1, null }) {
1404 <
1403 >        for (boolean createIncomplete : new boolean[] { true, false })
1404 >        for (boolean fFirst : new boolean[] { true, false })
1405 >        for (Integer v1 : new Integer[] { 1, null })
1406 >    {
1407          final CompletableFuture<Integer> f = new CompletableFuture<>();
1408          final CompletableFuture<Integer> g = new CompletableFuture<>();
1345        final SubtractAction r = new SubtractAction();
1346        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1409          final CFException ex = new CFException();
1410 +        final SubtractFunction r = new SubtractFunction(m);
1411  
1412 <        f.completeExceptionally(ex);
1413 <        checkIncomplete(h);
1414 <        g.complete(v1);
1415 <
1416 <        checkCompletedWithWrappedCFException(h, ex);
1417 <        checkCompletedWithWrappedCFException(f, ex);
1418 <        assertEquals(r.invocationCount, 0);
1356 <        checkCompletedNormally(g, v1);
1412 >        (fFirst ? f : g).complete(v1);
1413 >        if (!createIncomplete)
1414 >            (!fFirst ? f : g).completeExceptionally(ex);
1415 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1416 >        if (createIncomplete) {
1417 >            checkIncomplete(h);
1418 >            (!fFirst ? f : g).completeExceptionally(ex);
1419          }
1358    }
1420  
1421 <    public void testThenAcceptBoth_exceptionalCompletion2() {
1422 <        for (ExecutionMode m : ExecutionMode.values())
1423 <        for (Integer v1 : new Integer[] { 1, null }) {
1421 >        checkCompletedWithWrappedException(h, ex);
1422 >        r.assertNotInvoked();
1423 >        checkCompletedNormally(fFirst ? f : g, v1);
1424 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1425 >    }}
1426  
1427 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1428 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1429 <        final SubtractAction r = new SubtractAction();
1430 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1368 <        final CFException ex = new CFException();
1369 <
1370 <        g.completeExceptionally(ex);
1371 <        checkIncomplete(h);
1372 <        f.complete(v1);
1373 <
1374 <        checkCompletedWithWrappedCFException(h, ex);
1375 <        checkCompletedWithWrappedCFException(g, ex);
1376 <        assertEquals(r.invocationCount, 0);
1377 <        checkCompletedNormally(f, v1);
1378 <        }
1379 <    }
1380 <
1381 <    public void testThenAcceptBoth_exceptionalCompletion3() {
1427 >    /**
1428 >     * thenCombine result completes exceptionally if either source cancelled
1429 >     */
1430 >    public void testThenCombine_sourceCancelled() {
1431          for (ExecutionMode m : ExecutionMode.values())
1432 <        for (Integer v1 : new Integer[] { 1, null }) {
1433 <
1432 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1433 >        for (boolean createIncomplete : new boolean[] { true, false })
1434 >        for (boolean fFirst : new boolean[] { true, false })
1435 >        for (Integer v1 : new Integer[] { 1, null })
1436 >    {
1437          final CompletableFuture<Integer> f = new CompletableFuture<>();
1438          final CompletableFuture<Integer> g = new CompletableFuture<>();
1439 <        final SubtractAction r = new SubtractAction();
1388 <        final CFException ex = new CFException();
1389 <
1390 <        g.completeExceptionally(ex);
1391 <        f.complete(v1);
1392 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1439 >        final SubtractFunction r = new SubtractFunction(m);
1440  
1441 <        checkCompletedWithWrappedCFException(h, ex);
1442 <        checkCompletedWithWrappedCFException(g, ex);
1443 <        assertEquals(r.invocationCount, 0);
1444 <        checkCompletedNormally(f, v1);
1441 >        (fFirst ? f : g).complete(v1);
1442 >        if (!createIncomplete)
1443 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1444 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1445 >        if (createIncomplete) {
1446 >            checkIncomplete(h);
1447 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1448          }
1399    }
1400
1401    public void testThenAcceptBoth_exceptionalCompletion4() {
1402        for (ExecutionMode m : ExecutionMode.values())
1403        for (Integer v1 : new Integer[] { 1, null }) {
1404
1405        final CompletableFuture<Integer> f = new CompletableFuture<>();
1406        final CompletableFuture<Integer> g = new CompletableFuture<>();
1407        final SubtractAction r = new SubtractAction();
1408        final CFException ex = new CFException();
1409
1410        f.completeExceptionally(ex);
1411        g.complete(v1);
1412        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1449  
1450 <        checkCompletedWithWrappedCFException(h, ex);
1451 <        checkCompletedWithWrappedCFException(f, ex);
1452 <        assertFalse(r.ran());
1453 <        checkCompletedNormally(g, v1);
1454 <        }
1419 <    }
1450 >        checkCompletedWithWrappedCancellationException(h);
1451 >        checkCancelled(!fFirst ? f : g);
1452 >        r.assertNotInvoked();
1453 >        checkCompletedNormally(fFirst ? f : g, v1);
1454 >    }}
1455  
1456      /**
1457 <     * thenAcceptBoth result completes exceptionally if action does
1457 >     * thenCombine result completes exceptionally if action does
1458       */
1459 <    public void testThenAcceptBoth_actionFailed1() {
1459 >    public void testThenCombine_actionFailed() {
1460          for (ExecutionMode m : ExecutionMode.values())
1461 +        for (boolean fFirst : new boolean[] { true, false })
1462          for (Integer v1 : new Integer[] { 1, null })
1463 <        for (Integer v2 : new Integer[] { 2, null }) {
1464 <
1463 >        for (Integer v2 : new Integer[] { 2, null })
1464 >    {
1465          final CompletableFuture<Integer> f = new CompletableFuture<>();
1466          final CompletableFuture<Integer> g = new CompletableFuture<>();
1467 <        final FailingBiConsumer r = new FailingBiConsumer();
1468 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1467 >        final FailingBiFunction r = new FailingBiFunction(m);
1468 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1469  
1470 <        f.complete(v1);
1471 <        checkIncomplete(h);
1472 <        g.complete(v2);
1470 >        if (fFirst) {
1471 >            f.complete(v1);
1472 >            g.complete(v2);
1473 >        } else {
1474 >            g.complete(v2);
1475 >            f.complete(v1);
1476 >        }
1477  
1478          checkCompletedWithWrappedCFException(h);
1479          checkCompletedNormally(f, v1);
1480          checkCompletedNormally(g, v2);
1481 <        }
1442 <    }
1481 >    }}
1482  
1483 <    public void testThenAcceptBoth_actionFailed2() {
1483 >    /**
1484 >     * thenAcceptBoth result completes normally after normal
1485 >     * completion of sources
1486 >     */
1487 >    public void testThenAcceptBoth_normalCompletion() {
1488          for (ExecutionMode m : ExecutionMode.values())
1489 +        for (boolean createIncomplete : new boolean[] { true, false })
1490 +        for (boolean fFirst : new boolean[] { true, false })
1491          for (Integer v1 : new Integer[] { 1, null })
1492 <        for (Integer v2 : new Integer[] { 2, null }) {
1493 <
1492 >        for (Integer v2 : new Integer[] { 2, null })
1493 >    {
1494          final CompletableFuture<Integer> f = new CompletableFuture<>();
1495          final CompletableFuture<Integer> g = new CompletableFuture<>();
1496 <        final FailingBiConsumer r = new FailingBiConsumer();
1452 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1496 >        final SubtractAction r = new SubtractAction(m);
1497  
1498 <        g.complete(v2);
1499 <        checkIncomplete(h);
1500 <        f.complete(v1);
1498 >        if (fFirst) f.complete(v1); else g.complete(v2);
1499 >        if (!createIncomplete)
1500 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1501 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1502 >        if (createIncomplete) {
1503 >            checkIncomplete(h);
1504 >            r.assertNotInvoked();
1505 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1506 >        }
1507  
1508 <        checkCompletedWithWrappedCFException(h);
1508 >        checkCompletedNormally(h, null);
1509 >        r.assertValue(subtract(v1, v2));
1510          checkCompletedNormally(f, v1);
1511          checkCompletedNormally(g, v2);
1512 <        }
1462 <    }
1512 >    }}
1513  
1514      /**
1515 <     * thenAcceptBoth result completes exceptionally if either source cancelled
1515 >     * thenAcceptBoth result completes exceptionally after exceptional
1516 >     * completion of either source
1517       */
1518 <    public void testThenAcceptBoth_sourceCancelled1() {
1518 >    public void testThenAcceptBoth_exceptionalCompletion() {
1519          for (ExecutionMode m : ExecutionMode.values())
1520 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1521 <        for (Integer v1 : new Integer[] { 1, null }) {
1522 <
1520 >        for (boolean createIncomplete : new boolean[] { true, false })
1521 >        for (boolean fFirst : new boolean[] { true, false })
1522 >        for (Integer v1 : new Integer[] { 1, null })
1523 >    {
1524          final CompletableFuture<Integer> f = new CompletableFuture<>();
1525          final CompletableFuture<Integer> g = new CompletableFuture<>();
1526 <        final SubtractAction r = new SubtractAction();
1527 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1476 <
1477 <        assertTrue(f.cancel(mayInterruptIfRunning));
1478 <        checkIncomplete(h);
1479 <        g.complete(v1);
1480 <
1481 <        checkCompletedWithWrappedCancellationException(h);
1482 <        checkCancelled(f);
1483 <        assertEquals(r.invocationCount, 0);
1484 <        checkCompletedNormally(g, v1);
1485 <        }
1486 <    }
1487 <
1488 <    public void testThenAcceptBoth_sourceCancelled2() {
1489 <        for (ExecutionMode m : ExecutionMode.values())
1490 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1491 <        for (Integer v1 : new Integer[] { 1, null }) {
1526 >        final CFException ex = new CFException();
1527 >        final SubtractAction r = new SubtractAction(m);
1528  
1529 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1530 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1531 <        final SubtractAction r = new SubtractAction();
1529 >        (fFirst ? f : g).complete(v1);
1530 >        if (!createIncomplete)
1531 >            (!fFirst ? f : g).completeExceptionally(ex);
1532          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1533 <
1534 <        assertTrue(g.cancel(mayInterruptIfRunning));
1535 <        checkIncomplete(h);
1500 <        f.complete(v1);
1501 <
1502 <        checkCompletedWithWrappedCancellationException(h);
1503 <        checkCancelled(g);
1504 <        assertEquals(r.invocationCount, 0);
1505 <        checkCompletedNormally(f, v1);
1533 >        if (createIncomplete) {
1534 >            checkIncomplete(h);
1535 >            (!fFirst ? f : g).completeExceptionally(ex);
1536          }
1507    }
1537  
1538 <    public void testThenAcceptBoth_sourceCancelled3() {
1539 <        for (ExecutionMode m : ExecutionMode.values())
1540 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1541 <        for (Integer v1 : new Integer[] { 1, null }) {
1542 <
1514 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1515 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1516 <        final SubtractAction r = new SubtractAction();
1517 <
1518 <        assertTrue(g.cancel(mayInterruptIfRunning));
1519 <        f.complete(v1);
1520 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1538 >        checkCompletedWithWrappedException(h, ex);
1539 >        r.assertNotInvoked();
1540 >        checkCompletedNormally(fFirst ? f : g, v1);
1541 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1542 >    }}
1543  
1544 <        checkCompletedWithWrappedCancellationException(h);
1545 <        checkCancelled(g);
1546 <        assertEquals(r.invocationCount, 0);
1547 <        checkCompletedNormally(f, v1);
1526 <        }
1527 <    }
1528 <
1529 <    public void testThenAcceptBoth_sourceCancelled4() {
1544 >    /**
1545 >     * thenAcceptBoth result completes exceptionally if either source cancelled
1546 >     */
1547 >    public void testThenAcceptBoth_sourceCancelled() {
1548          for (ExecutionMode m : ExecutionMode.values())
1549          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1550 <        for (Integer v1 : new Integer[] { 1, null }) {
1551 <
1550 >        for (boolean createIncomplete : new boolean[] { true, false })
1551 >        for (boolean fFirst : new boolean[] { true, false })
1552 >        for (Integer v1 : new Integer[] { 1, null })
1553 >    {
1554          final CompletableFuture<Integer> f = new CompletableFuture<>();
1555          final CompletableFuture<Integer> g = new CompletableFuture<>();
1556 <        final SubtractAction r = new SubtractAction();
1556 >        final SubtractAction r = new SubtractAction(m);
1557  
1558 <        assertTrue(f.cancel(mayInterruptIfRunning));
1559 <        g.complete(v1);
1558 >        (fFirst ? f : g).complete(v1);
1559 >        if (!createIncomplete)
1560 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1561          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1562 +        if (createIncomplete) {
1563 +            checkIncomplete(h);
1564 +            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1565 +        }
1566  
1567          checkCompletedWithWrappedCancellationException(h);
1568 <        checkCancelled(f);
1569 <        assertEquals(r.invocationCount, 0);
1570 <        checkCompletedNormally(g, v1);
1571 <        }
1547 <    }
1568 >        checkCancelled(!fFirst ? f : g);
1569 >        r.assertNotInvoked();
1570 >        checkCompletedNormally(fFirst ? f : g, v1);
1571 >    }}
1572  
1573      /**
1574 <     * runAfterBoth result completes normally after normal
1551 <     * completion of sources
1574 >     * thenAcceptBoth result completes exceptionally if action does
1575       */
1576 <    public void testRunAfterBoth_normalCompletion1() {
1576 >    public void testThenAcceptBoth_actionFailed() {
1577          for (ExecutionMode m : ExecutionMode.values())
1578 +        for (boolean fFirst : new boolean[] { true, false })
1579          for (Integer v1 : new Integer[] { 1, null })
1580 <        for (Integer v2 : new Integer[] { 2, null }) {
1581 <
1580 >        for (Integer v2 : new Integer[] { 2, null })
1581 >    {
1582          final CompletableFuture<Integer> f = new CompletableFuture<>();
1583          final CompletableFuture<Integer> g = new CompletableFuture<>();
1584 <        final Noop r = new Noop();
1585 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1562 <
1563 <        f.complete(v1);
1564 <        checkIncomplete(h);
1565 <        assertFalse(r.ran);
1566 <        g.complete(v2);
1584 >        final FailingBiConsumer r = new FailingBiConsumer(m);
1585 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1586  
1587 <        checkCompletedNormally(h, null);
1588 <        assertEquals(r.invocationCount, 1);
1589 <        checkCompletedNormally(f, v1);
1590 <        checkCompletedNormally(g, v2);
1587 >        if (fFirst) {
1588 >            f.complete(v1);
1589 >            g.complete(v2);
1590 >        } else {
1591 >            g.complete(v2);
1592 >            f.complete(v1);
1593          }
1573    }
1574
1575    public void testRunAfterBoth_normalCompletion2() {
1576        for (ExecutionMode m : ExecutionMode.values())
1577        for (Integer v1 : new Integer[] { 1, null })
1578        for (Integer v2 : new Integer[] { 2, null }) {
1579
1580        final CompletableFuture<Integer> f = new CompletableFuture<>();
1581        final CompletableFuture<Integer> g = new CompletableFuture<>();
1582        final Noop r = new Noop();
1583        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1594  
1595 <        g.complete(v2);
1586 <        checkIncomplete(h);
1587 <        assertFalse(r.ran);
1588 <        f.complete(v1);
1589 <
1590 <        checkCompletedNormally(h, null);
1591 <        assertEquals(r.invocationCount, 1);
1595 >        checkCompletedWithWrappedCFException(h);
1596          checkCompletedNormally(f, v1);
1597          checkCompletedNormally(g, v2);
1598 <        }
1595 <    }
1598 >    }}
1599  
1600 <    public void testRunAfterBoth_normalCompletion3() {
1600 >    /**
1601 >     * runAfterBoth result completes normally after normal
1602 >     * completion of sources
1603 >     */
1604 >    public void testRunAfterBoth_normalCompletion() {
1605          for (ExecutionMode m : ExecutionMode.values())
1606 +        for (boolean createIncomplete : new boolean[] { true, false })
1607 +        for (boolean fFirst : new boolean[] { true, false })
1608          for (Integer v1 : new Integer[] { 1, null })
1609 <        for (Integer v2 : new Integer[] { 2, null }) {
1610 <
1609 >        for (Integer v2 : new Integer[] { 2, null })
1610 >    {
1611          final CompletableFuture<Integer> f = new CompletableFuture<>();
1612          final CompletableFuture<Integer> g = new CompletableFuture<>();
1613 <        final Noop r = new Noop();
1613 >        final Noop r = new Noop(m);
1614  
1615 <        g.complete(v2);
1616 <        f.complete(v1);
1615 >        if (fFirst) f.complete(v1); else g.complete(v2);
1616 >        if (!createIncomplete)
1617 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1618          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1619 <
1620 <        checkCompletedNormally(h, null);
1621 <        assertTrue(r.ran);
1622 <        checkCompletedNormally(f, v1);
1613 <        checkCompletedNormally(g, v2);
1619 >        if (createIncomplete) {
1620 >            checkIncomplete(h);
1621 >            r.assertNotInvoked();
1622 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1623          }
1615    }
1616
1617    public void testRunAfterBoth_normalCompletion4() {
1618        for (ExecutionMode m : ExecutionMode.values())
1619        for (Integer v1 : new Integer[] { 1, null })
1620        for (Integer v2 : new Integer[] { 2, null }) {
1621
1622        final CompletableFuture<Integer> f = new CompletableFuture<>();
1623        final CompletableFuture<Integer> g = new CompletableFuture<>();
1624        final Noop r = new Noop();
1625
1626        f.complete(v1);
1627        g.complete(v2);
1628        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1624  
1625          checkCompletedNormally(h, null);
1626 <        assertEquals(r.invocationCount, 1);
1626 >        r.assertInvoked();
1627          checkCompletedNormally(f, v1);
1628          checkCompletedNormally(g, v2);
1629 <        }
1635 <    }
1629 >    }}
1630  
1631      /**
1632       * runAfterBoth result completes exceptionally after exceptional
1633       * completion of either source
1634       */
1635 <    public void testRunAfterBoth_exceptionalCompletion1() {
1635 >    public void testRunAfterBoth_exceptionalCompletion() {
1636          for (ExecutionMode m : ExecutionMode.values())
1637 <        for (Integer v1 : new Integer[] { 1, null }) {
1638 <
1639 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1640 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1647 <        final Noop r = new Noop();
1648 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1649 <        final CFException ex = new CFException();
1650 <
1651 <        f.completeExceptionally(ex);
1652 <        checkIncomplete(h);
1653 <        g.complete(v1);
1654 <
1655 <        checkCompletedWithWrappedCFException(h, ex);
1656 <        checkCompletedWithWrappedCFException(f, ex);
1657 <        assertEquals(r.invocationCount, 0);
1658 <        checkCompletedNormally(g, v1);
1659 <        }
1660 <    }
1661 <
1662 <    public void testRunAfterBoth_exceptionalCompletion2() {
1663 <        for (ExecutionMode m : ExecutionMode.values())
1664 <        for (Integer v1 : new Integer[] { 1, null }) {
1665 <
1666 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1667 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1668 <        final Noop r = new Noop();
1669 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1670 <        final CFException ex = new CFException();
1671 <
1672 <        g.completeExceptionally(ex);
1673 <        checkIncomplete(h);
1674 <        f.complete(v1);
1675 <
1676 <        checkCompletedWithWrappedCFException(h, ex);
1677 <        checkCompletedWithWrappedCFException(g, ex);
1678 <        assertEquals(r.invocationCount, 0);
1679 <        checkCompletedNormally(f, v1);
1680 <        }
1681 <    }
1682 <
1683 <    public void testRunAfterBoth_exceptionalCompletion3() {
1684 <        for (ExecutionMode m : ExecutionMode.values())
1685 <        for (Integer v1 : new Integer[] { 1, null }) {
1686 <
1637 >        for (boolean createIncomplete : new boolean[] { true, false })
1638 >        for (boolean fFirst : new boolean[] { true, false })
1639 >        for (Integer v1 : new Integer[] { 1, null })
1640 >    {
1641          final CompletableFuture<Integer> f = new CompletableFuture<>();
1642          final CompletableFuture<Integer> g = new CompletableFuture<>();
1689        final Noop r = new Noop();
1643          final CFException ex = new CFException();
1644 +        final Noop r = new Noop(m);
1645  
1646 <        g.completeExceptionally(ex);
1647 <        f.complete(v1);
1646 >        (fFirst ? f : g).complete(v1);
1647 >        if (!createIncomplete)
1648 >            (!fFirst ? f : g).completeExceptionally(ex);
1649          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1650 <
1651 <        checkCompletedWithWrappedCFException(h, ex);
1652 <        checkCompletedWithWrappedCFException(g, ex);
1698 <        assertEquals(r.invocationCount, 0);
1699 <        checkCompletedNormally(f, v1);
1650 >        if (createIncomplete) {
1651 >            checkIncomplete(h);
1652 >            (!fFirst ? f : g).completeExceptionally(ex);
1653          }
1701    }
1702
1703    public void testRunAfterBoth_exceptionalCompletion4() {
1704        for (ExecutionMode m : ExecutionMode.values())
1705        for (Integer v1 : new Integer[] { 1, null }) {
1706
1707        final CompletableFuture<Integer> f = new CompletableFuture<>();
1708        final CompletableFuture<Integer> g = new CompletableFuture<>();
1709        final Noop r = new Noop();
1710        final CFException ex = new CFException();
1711
1712        f.completeExceptionally(ex);
1713        g.complete(v1);
1714        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1654  
1655 <        checkCompletedWithWrappedCFException(h, ex);
1656 <        checkCompletedWithWrappedCFException(f, ex);
1657 <        assertEquals(r.invocationCount, 0);
1658 <        checkCompletedNormally(g, v1);
1659 <        }
1721 <    }
1655 >        checkCompletedWithWrappedException(h, ex);
1656 >        r.assertNotInvoked();
1657 >        checkCompletedNormally(fFirst ? f : g, v1);
1658 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1659 >    }}
1660  
1661      /**
1662 <     * runAfterBoth result completes exceptionally if action does
1662 >     * runAfterBoth result completes exceptionally if either source cancelled
1663       */
1664 <    public void testRunAfterBoth_actionFailed1() {
1664 >    public void testRunAfterBoth_sourceCancelled() {
1665          for (ExecutionMode m : ExecutionMode.values())
1666 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1667 +        for (boolean createIncomplete : new boolean[] { true, false })
1668 +        for (boolean fFirst : new boolean[] { true, false })
1669          for (Integer v1 : new Integer[] { 1, null })
1670 <        for (Integer v2 : new Integer[] { 2, null }) {
1730 <
1670 >    {
1671          final CompletableFuture<Integer> f = new CompletableFuture<>();
1672          final CompletableFuture<Integer> g = new CompletableFuture<>();
1673 <        final FailingNoop r = new FailingNoop();
1734 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1735 <
1736 <        f.complete(v1);
1737 <        checkIncomplete(h);
1738 <        g.complete(v2);
1739 <
1740 <        checkCompletedWithWrappedCFException(h);
1741 <        checkCompletedNormally(f, v1);
1742 <        checkCompletedNormally(g, v2);
1743 <        }
1744 <    }
1673 >        final Noop r = new Noop(m);
1674  
1746    public void testRunAfterBoth_actionFailed2() {
1747        for (ExecutionMode m : ExecutionMode.values())
1748        for (Integer v1 : new Integer[] { 1, null })
1749        for (Integer v2 : new Integer[] { 2, null }) {
1675  
1676 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1677 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1678 <        final FailingNoop r = new FailingNoop();
1676 >        (fFirst ? f : g).complete(v1);
1677 >        if (!createIncomplete)
1678 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1679          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1680 <
1681 <        g.complete(v2);
1682 <        checkIncomplete(h);
1758 <        f.complete(v1);
1759 <
1760 <        checkCompletedWithWrappedCFException(h);
1761 <        checkCompletedNormally(f, v1);
1762 <        checkCompletedNormally(g, v2);
1680 >        if (createIncomplete) {
1681 >            checkIncomplete(h);
1682 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1683          }
1684 <    }
1684 >
1685 >        checkCompletedWithWrappedCancellationException(h);
1686 >        checkCancelled(!fFirst ? f : g);
1687 >        r.assertNotInvoked();
1688 >        checkCompletedNormally(fFirst ? f : g, v1);
1689 >    }}
1690  
1691      /**
1692 <     * runAfterBoth result completes exceptionally if either source cancelled
1692 >     * runAfterBoth result completes exceptionally if action does
1693       */
1694 <    public void testRunAfterBoth_sourceCancelled1() {
1694 >    public void testRunAfterBoth_actionFailed() {
1695          for (ExecutionMode m : ExecutionMode.values())
1696 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1697 <        for (Integer v1 : new Integer[] { 1, null }) {
1698 <
1696 >        for (boolean fFirst : new boolean[] { true, false })
1697 >        for (Integer v1 : new Integer[] { 1, null })
1698 >        for (Integer v2 : new Integer[] { 2, null })
1699 >    {
1700          final CompletableFuture<Integer> f = new CompletableFuture<>();
1701          final CompletableFuture<Integer> g = new CompletableFuture<>();
1702 <        final Noop r = new Noop();
1703 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1702 >        final FailingRunnable r1 = new FailingRunnable(m);
1703 >        final FailingRunnable r2 = new FailingRunnable(m);
1704  
1705 <        assertTrue(f.cancel(mayInterruptIfRunning));
1706 <        checkIncomplete(h);
1707 <        g.complete(v1);
1708 <
1709 <        checkCompletedWithWrappedCancellationException(h);
1710 <        checkCancelled(f);
1711 <        assertEquals(r.invocationCount, 0);
1786 <        checkCompletedNormally(g, v1);
1705 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1706 >        if (fFirst) {
1707 >            f.complete(v1);
1708 >            g.complete(v2);
1709 >        } else {
1710 >            g.complete(v2);
1711 >            f.complete(v1);
1712          }
1713 <    }
1713 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1714  
1715 <    public void testRunAfterBoth_sourceCancelled2() {
1716 <        for (ExecutionMode m : ExecutionMode.values())
1792 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1793 <        for (Integer v1 : new Integer[] { 1, null }) {
1794 <
1795 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1796 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1797 <        final Noop r = new Noop();
1798 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1799 <
1800 <        assertTrue(g.cancel(mayInterruptIfRunning));
1801 <        checkIncomplete(h);
1802 <        f.complete(v1);
1803 <
1804 <        checkCompletedWithWrappedCancellationException(h);
1805 <        checkCancelled(g);
1806 <        assertEquals(r.invocationCount, 0);
1715 >        checkCompletedWithWrappedCFException(h1);
1716 >        checkCompletedWithWrappedCFException(h2);
1717          checkCompletedNormally(f, v1);
1718 <        }
1719 <    }
1810 <
1811 <    public void testRunAfterBoth_sourceCancelled3() {
1812 <        for (ExecutionMode m : ExecutionMode.values())
1813 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1814 <        for (Integer v1 : new Integer[] { 1, null }) {
1815 <
1816 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1817 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1818 <        final Noop r = new Noop();
1819 <
1820 <        assertTrue(g.cancel(mayInterruptIfRunning));
1821 <        f.complete(v1);
1822 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1823 <
1824 <        checkCompletedWithWrappedCancellationException(h);
1825 <        checkCancelled(g);
1826 <        assertEquals(r.invocationCount, 0);
1827 <        checkCompletedNormally(f, v1);
1828 <        }
1829 <    }
1830 <
1831 <    public void testRunAfterBoth_sourceCancelled4() {
1832 <        for (ExecutionMode m : ExecutionMode.values())
1833 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1834 <        for (Integer v1 : new Integer[] { 1, null }) {
1835 <
1836 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1837 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1838 <        final Noop r = new Noop();
1839 <
1840 <        assertTrue(f.cancel(mayInterruptIfRunning));
1841 <        g.complete(v1);
1842 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1843 <
1844 <        checkCompletedWithWrappedCancellationException(h);
1845 <        checkCancelled(f);
1846 <        assertEquals(r.invocationCount, 0);
1847 <        checkCompletedNormally(g, v1);
1848 <        }
1849 <    }
1718 >        checkCompletedNormally(g, v2);
1719 >    }}
1720  
1721      /**
1722       * applyToEither result completes normally after normal completion
1723       * of either source
1724       */
1725 <    public void testApplyToEither_normalCompletion1() {
1725 >    public void testApplyToEither_normalCompletion() {
1726          for (ExecutionMode m : ExecutionMode.values())
1727          for (Integer v1 : new Integer[] { 1, null })
1728 <        for (Integer v2 : new Integer[] { 2, null }) {
1729 <
1728 >        for (Integer v2 : new Integer[] { 2, null })
1729 >    {
1730          final CompletableFuture<Integer> f = new CompletableFuture<>();
1731          final CompletableFuture<Integer> g = new CompletableFuture<>();
1732 <        final IncFunction r = new IncFunction();
1733 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1732 >        final IncFunction[] rs = new IncFunction[6];
1733 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1734  
1735 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1736 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1737 +        checkIncomplete(h0);
1738 +        checkIncomplete(h1);
1739 +        rs[0].assertNotInvoked();
1740 +        rs[1].assertNotInvoked();
1741          f.complete(v1);
1742 <        checkCompletedNormally(h, inc(v1));
1742 >        checkCompletedNormally(h0, inc(v1));
1743 >        checkCompletedNormally(h1, inc(v1));
1744 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1745 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1746 >        checkCompletedNormally(h2, inc(v1));
1747 >        checkCompletedNormally(h3, inc(v1));
1748          g.complete(v2);
1749  
1750 <        checkCompletedNormally(f, v1);
1751 <        checkCompletedNormally(g, v2);
1752 <        checkCompletedNormally(h, inc(v1));
1753 <        }
1754 <    }
1755 <
1756 <    public void testApplyToEither_normalCompletion2() {
1757 <        for (ExecutionMode m : ExecutionMode.values())
1758 <        for (Integer v1 : new Integer[] { 1, null })
1878 <        for (Integer v2 : new Integer[] { 2, null }) {
1879 <
1880 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1881 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1882 <        final IncFunction r = new IncFunction();
1883 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1884 <
1885 <        g.complete(v2);
1886 <        checkCompletedNormally(h, inc(v2));
1887 <        f.complete(v1);
1750 >        // unspecified behavior - both source completions available
1751 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1752 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1753 >        rs[4].assertValue(h4.join());
1754 >        rs[5].assertValue(h5.join());
1755 >        assertTrue(Objects.equals(inc(v1), h4.join()) ||
1756 >                   Objects.equals(inc(v2), h4.join()));
1757 >        assertTrue(Objects.equals(inc(v1), h5.join()) ||
1758 >                   Objects.equals(inc(v2), h5.join()));
1759  
1760          checkCompletedNormally(f, v1);
1761          checkCompletedNormally(g, v2);
1762 <        checkCompletedNormally(h, inc(v2));
1763 <        }
1764 <    }
1765 <    public void testApplyToEither_normalCompletion3() {
1766 <        for (ExecutionMode m : ExecutionMode.values())
1767 <        for (Integer v1 : new Integer[] { 1, null })
1897 <        for (Integer v2 : new Integer[] { 2, null }) {
1898 <
1899 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1900 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1901 <        final IncFunction r = new IncFunction();
1902 <
1903 <        f.complete(v1);
1904 <        g.complete(v2);
1905 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1906 <
1907 <        checkCompletedNormally(f, v1);
1908 <        checkCompletedNormally(g, v2);
1909 <
1910 <        // unspecified behavior
1911 <        assertTrue(Objects.equals(h.join(), inc(v1)) ||
1912 <                   Objects.equals(h.join(), inc(v2)));
1913 <        assertEquals(r.invocationCount, 1);
1914 <        }
1915 <    }
1762 >        checkCompletedNormally(h0, inc(v1));
1763 >        checkCompletedNormally(h1, inc(v1));
1764 >        checkCompletedNormally(h2, inc(v1));
1765 >        checkCompletedNormally(h3, inc(v1));
1766 >        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
1767 >    }}
1768  
1769      /**
1770       * applyToEither result completes exceptionally after exceptional
1771       * completion of either source
1772       */
1773 <    public void testApplyToEither_exceptionalCompletion1() {
1773 >    public void testApplyToEither_exceptionalCompletion() {
1774          for (ExecutionMode m : ExecutionMode.values())
1775 <        for (Integer v1 : new Integer[] { 1, null }) {
1776 <
1775 >        for (Integer v1 : new Integer[] { 1, null })
1776 >    {
1777          final CompletableFuture<Integer> f = new CompletableFuture<>();
1778          final CompletableFuture<Integer> g = new CompletableFuture<>();
1927        final IncFunction r = new IncFunction();
1928        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1779          final CFException ex = new CFException();
1780 +        final IncFunction[] rs = new IncFunction[6];
1781 +        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1782  
1783 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1784 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1785 +        checkIncomplete(h0);
1786 +        checkIncomplete(h1);
1787 +        rs[0].assertNotInvoked();
1788 +        rs[1].assertNotInvoked();
1789          f.completeExceptionally(ex);
1790 <        checkCompletedWithWrappedCFException(h, ex);
1790 >        checkCompletedWithWrappedException(h0, ex);
1791 >        checkCompletedWithWrappedException(h1, ex);
1792 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1793 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1794 >        checkCompletedWithWrappedException(h2, ex);
1795 >        checkCompletedWithWrappedException(h3, ex);
1796          g.complete(v1);
1797  
1798 <        assertEquals(r.invocationCount, 0);
1799 <        checkCompletedNormally(g, v1);
1800 <        checkCompletedWithWrappedCFException(f, ex);
1801 <        checkCompletedWithWrappedCFException(h, ex);
1798 >        // unspecified behavior - both source completions available
1799 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1800 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1801 >        try {
1802 >            assertEquals(inc(v1), h4.join());
1803 >            rs[4].assertValue(inc(v1));
1804 >        } catch (CompletionException ok) {
1805 >            checkCompletedWithWrappedException(h4, ex);
1806 >            rs[4].assertNotInvoked();
1807          }
1808 <    }
1808 >        try {
1809 >            assertEquals(inc(v1), h5.join());
1810 >            rs[5].assertValue(inc(v1));
1811 >        } catch (CompletionException ok) {
1812 >            checkCompletedWithWrappedException(h5, ex);
1813 >            rs[5].assertNotInvoked();
1814 >        }
1815 >
1816 >        checkCompletedExceptionally(f, ex);
1817 >        checkCompletedNormally(g, v1);
1818 >        checkCompletedWithWrappedException(h0, ex);
1819 >        checkCompletedWithWrappedException(h1, ex);
1820 >        checkCompletedWithWrappedException(h2, ex);
1821 >        checkCompletedWithWrappedException(h3, ex);
1822 >        checkCompletedWithWrappedException(h4, ex);
1823 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1824 >    }}
1825  
1826      public void testApplyToEither_exceptionalCompletion2() {
1827          for (ExecutionMode m : ExecutionMode.values())
1828 <        for (Integer v1 : new Integer[] { 1, null }) {
1829 <
1828 >        for (boolean fFirst : new boolean[] { true, false })
1829 >        for (Integer v1 : new Integer[] { 1, null })
1830 >    {
1831          final CompletableFuture<Integer> f = new CompletableFuture<>();
1832          final CompletableFuture<Integer> g = new CompletableFuture<>();
1948        final IncFunction r = new IncFunction();
1949        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1833          final CFException ex = new CFException();
1834 +        final IncFunction[] rs = new IncFunction[6];
1835 +        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1836  
1837 <        g.completeExceptionally(ex);
1838 <        checkCompletedWithWrappedCFException(h, ex);
1839 <        f.complete(v1);
1840 <
1841 <        assertEquals(r.invocationCount, 0);
1842 <        checkCompletedNormally(f, v1);
1843 <        checkCompletedWithWrappedCFException(g, ex);
1844 <        checkCompletedWithWrappedCFException(h, ex);
1837 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1838 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1839 >        if (fFirst) {
1840 >            f.complete(v1);
1841 >            g.completeExceptionally(ex);
1842 >        } else {
1843 >            g.completeExceptionally(ex);
1844 >            f.complete(v1);
1845          }
1846 <    }
1847 <
1963 <    public void testApplyToEither_exceptionalCompletion3() {
1964 <        for (ExecutionMode m : ExecutionMode.values())
1965 <        for (Integer v1 : new Integer[] { 1, null }) {
1966 <
1967 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1968 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1969 <        final IncFunction r = new IncFunction();
1970 <        final CFException ex = new CFException();
1846 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1847 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1848  
1849 <        g.completeExceptionally(ex);
1973 <        f.complete(v1);
1974 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1975 <
1976 <        // unspecified behavior
1977 <        Integer v;
1849 >        // unspecified behavior - both source completions available
1850          try {
1851 <            assertEquals(h.join(), inc(v1));
1852 <            assertEquals(r.invocationCount, 1);
1851 >            assertEquals(inc(v1), h0.join());
1852 >            rs[0].assertValue(inc(v1));
1853          } catch (CompletionException ok) {
1854 <            checkCompletedWithWrappedCFException(h, ex);
1855 <            assertEquals(r.invocationCount, 0);
1854 >            checkCompletedWithWrappedException(h0, ex);
1855 >            rs[0].assertNotInvoked();
1856          }
1985
1986        checkCompletedWithWrappedCFException(g, ex);
1987        checkCompletedNormally(f, v1);
1988        }
1989    }
1990
1991    public void testApplyToEither_exceptionalCompletion4() {
1992        for (ExecutionMode m : ExecutionMode.values())
1993        for (Integer v1 : new Integer[] { 1, null }) {
1994
1995        final CompletableFuture<Integer> f = new CompletableFuture<>();
1996        final CompletableFuture<Integer> g = new CompletableFuture<>();
1997        final IncFunction r = new IncFunction();
1998        final CFException ex = new CFException();
1999
2000        f.completeExceptionally(ex);
2001        g.complete(v1);
2002        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2003
2004        // unspecified behavior
2005        Integer v;
1857          try {
1858 <            assertEquals(h.join(), inc(v1));
1859 <            assertEquals(r.invocationCount, 1);
1858 >            assertEquals(inc(v1), h1.join());
1859 >            rs[1].assertValue(inc(v1));
1860          } catch (CompletionException ok) {
1861 <            checkCompletedWithWrappedCFException(h, ex);
1862 <            assertEquals(r.invocationCount, 0);
1861 >            checkCompletedWithWrappedException(h1, ex);
1862 >            rs[1].assertNotInvoked();
1863          }
1864 <
1865 <        checkCompletedWithWrappedCFException(f, ex);
1866 <        checkCompletedNormally(g, v1);
1864 >        try {
1865 >            assertEquals(inc(v1), h2.join());
1866 >            rs[2].assertValue(inc(v1));
1867 >        } catch (CompletionException ok) {
1868 >            checkCompletedWithWrappedException(h2, ex);
1869 >            rs[2].assertNotInvoked();
1870          }
1871 <    }
1872 <
1873 <    /**
1874 <     * applyToEither result completes exceptionally if action does
1875 <     */
1876 <    public void testApplyToEither_actionFailed1() {
2023 <        for (ExecutionMode m : ExecutionMode.values())
2024 <        for (Integer v1 : new Integer[] { 1, null })
2025 <        for (Integer v2 : new Integer[] { 2, null }) {
2026 <
2027 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2028 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2029 <        final FailingFunction r = new FailingFunction();
2030 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2031 <
2032 <        f.complete(v1);
2033 <        checkCompletedWithWrappedCFException(h);
2034 <        g.complete(v2);
2035 <        checkCompletedNormally(f, v1);
2036 <        checkCompletedNormally(g, v2);
1871 >        try {
1872 >            assertEquals(inc(v1), h3.join());
1873 >            rs[3].assertValue(inc(v1));
1874 >        } catch (CompletionException ok) {
1875 >            checkCompletedWithWrappedException(h3, ex);
1876 >            rs[3].assertNotInvoked();
1877          }
2038    }
2039
2040    public void testApplyToEither_actionFailed2() {
2041        for (ExecutionMode m : ExecutionMode.values())
2042        for (Integer v1 : new Integer[] { 1, null })
2043        for (Integer v2 : new Integer[] { 2, null }) {
1878  
2045        final CompletableFuture<Integer> f = new CompletableFuture<>();
2046        final CompletableFuture<Integer> g = new CompletableFuture<>();
2047        final FailingFunction r = new FailingFunction();
2048        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2049
2050        g.complete(v2);
2051        checkCompletedWithWrappedCFException(h);
2052        f.complete(v1);
1879          checkCompletedNormally(f, v1);
1880 <        checkCompletedNormally(g, v2);
1881 <        }
2056 <    }
1880 >        checkCompletedExceptionally(g, ex);
1881 >    }}
1882  
1883      /**
1884       * applyToEither result completes exceptionally if either source cancelled
1885       */
1886 <    public void testApplyToEither_sourceCancelled1() {
1886 >    public void testApplyToEither_sourceCancelled() {
1887          for (ExecutionMode m : ExecutionMode.values())
1888          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1889 <        for (Integer v1 : new Integer[] { 1, null }) {
1890 <
1889 >        for (Integer v1 : new Integer[] { 1, null })
1890 >    {
1891          final CompletableFuture<Integer> f = new CompletableFuture<>();
1892          final CompletableFuture<Integer> g = new CompletableFuture<>();
1893 <        final IncFunction r = new IncFunction();
1894 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1893 >        final IncFunction[] rs = new IncFunction[6];
1894 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1895  
1896 <        assertTrue(f.cancel(mayInterruptIfRunning));
1897 <        checkCompletedWithWrappedCancellationException(h);
1896 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1897 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1898 >        checkIncomplete(h0);
1899 >        checkIncomplete(h1);
1900 >        rs[0].assertNotInvoked();
1901 >        rs[1].assertNotInvoked();
1902 >        f.cancel(mayInterruptIfRunning);
1903 >        checkCompletedWithWrappedCancellationException(h0);
1904 >        checkCompletedWithWrappedCancellationException(h1);
1905 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1906 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1907 >        checkCompletedWithWrappedCancellationException(h2);
1908 >        checkCompletedWithWrappedCancellationException(h3);
1909          g.complete(v1);
1910  
1911 +        // unspecified behavior - both source completions available
1912 +        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1913 +        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1914 +        try {
1915 +            assertEquals(inc(v1), h4.join());
1916 +            rs[4].assertValue(inc(v1));
1917 +        } catch (CompletionException ok) {
1918 +            checkCompletedWithWrappedCancellationException(h4);
1919 +            rs[4].assertNotInvoked();
1920 +        }
1921 +        try {
1922 +            assertEquals(inc(v1), h5.join());
1923 +            rs[5].assertValue(inc(v1));
1924 +        } catch (CompletionException ok) {
1925 +            checkCompletedWithWrappedCancellationException(h5);
1926 +            rs[5].assertNotInvoked();
1927 +        }
1928 +
1929          checkCancelled(f);
2076        assertEquals(r.invocationCount, 0);
1930          checkCompletedNormally(g, v1);
1931 <        checkCompletedWithWrappedCancellationException(h);
1932 <        }
1933 <    }
1931 >        checkCompletedWithWrappedCancellationException(h0);
1932 >        checkCompletedWithWrappedCancellationException(h1);
1933 >        checkCompletedWithWrappedCancellationException(h2);
1934 >        checkCompletedWithWrappedCancellationException(h3);
1935 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1936 >    }}
1937  
1938      public void testApplyToEither_sourceCancelled2() {
1939          for (ExecutionMode m : ExecutionMode.values())
1940          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1941 <        for (Integer v1 : new Integer[] { 1, null }) {
1942 <
1941 >        for (boolean fFirst : new boolean[] { true, false })
1942 >        for (Integer v1 : new Integer[] { 1, null })
1943 >    {
1944          final CompletableFuture<Integer> f = new CompletableFuture<>();
1945          final CompletableFuture<Integer> g = new CompletableFuture<>();
1946 <        final IncFunction r = new IncFunction();
1947 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1946 >        final IncFunction[] rs = new IncFunction[6];
1947 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1948  
1949 <        assertTrue(g.cancel(mayInterruptIfRunning));
1950 <        checkCompletedWithWrappedCancellationException(h);
1951 <        f.complete(v1);
1952 <
1953 <        checkCancelled(g);
1954 <        assertEquals(r.invocationCount, 0);
1955 <        checkCompletedNormally(f, v1);
1956 <        checkCompletedWithWrappedCancellationException(h);
1949 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1950 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1951 >        if (fFirst) {
1952 >            f.complete(v1);
1953 >            g.cancel(mayInterruptIfRunning);
1954 >        } else {
1955 >            g.cancel(mayInterruptIfRunning);
1956 >            f.complete(v1);
1957          }
1958 <    }
1959 <
2103 <    public void testApplyToEither_sourceCancelled3() {
2104 <        for (ExecutionMode m : ExecutionMode.values())
2105 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2106 <        for (Integer v1 : new Integer[] { 1, null }) {
2107 <
2108 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2109 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2110 <        final IncFunction r = new IncFunction();
2111 <
2112 <        assertTrue(g.cancel(mayInterruptIfRunning));
2113 <        f.complete(v1);
2114 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1958 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1959 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1960  
1961 <        // unspecified behavior
2117 <        Integer v;
1961 >        // unspecified behavior - both source completions available
1962          try {
1963 <            assertEquals(h.join(), inc(v1));
1964 <            assertEquals(r.invocationCount, 1);
1963 >            assertEquals(inc(v1), h0.join());
1964 >            rs[0].assertValue(inc(v1));
1965          } catch (CompletionException ok) {
1966 <            checkCompletedWithWrappedCancellationException(h);
1967 <            assertEquals(r.invocationCount, 0);
1966 >            checkCompletedWithWrappedCancellationException(h0);
1967 >            rs[0].assertNotInvoked();
1968          }
1969 <
1970 <        checkCancelled(g);
1971 <        checkCompletedNormally(f, v1);
1969 >        try {
1970 >            assertEquals(inc(v1), h1.join());
1971 >            rs[1].assertValue(inc(v1));
1972 >        } catch (CompletionException ok) {
1973 >            checkCompletedWithWrappedCancellationException(h1);
1974 >            rs[1].assertNotInvoked();
1975          }
2129    }
2130
2131    public void testApplyToEither_sourceCancelled4() {
2132        for (ExecutionMode m : ExecutionMode.values())
2133        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2134        for (Integer v1 : new Integer[] { 1, null }) {
2135
2136        final CompletableFuture<Integer> f = new CompletableFuture<>();
2137        final CompletableFuture<Integer> g = new CompletableFuture<>();
2138        final IncFunction r = new IncFunction();
2139
2140        assertTrue(f.cancel(mayInterruptIfRunning));
2141        g.complete(v1);
2142        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2143
2144        // unspecified behavior
2145        Integer v;
1976          try {
1977 <            assertEquals(h.join(), inc(v1));
1978 <            assertEquals(r.invocationCount, 1);
1977 >            assertEquals(inc(v1), h2.join());
1978 >            rs[2].assertValue(inc(v1));
1979          } catch (CompletionException ok) {
1980 <            checkCompletedWithWrappedCancellationException(h);
1981 <            assertEquals(r.invocationCount, 0);
1980 >            checkCompletedWithWrappedCancellationException(h2);
1981 >            rs[2].assertNotInvoked();
1982          }
1983 <
1984 <        checkCancelled(f);
1985 <        checkCompletedNormally(g, v1);
1983 >        try {
1984 >            assertEquals(inc(v1), h3.join());
1985 >            rs[3].assertValue(inc(v1));
1986 >        } catch (CompletionException ok) {
1987 >            checkCompletedWithWrappedCancellationException(h3);
1988 >            rs[3].assertNotInvoked();
1989          }
1990 <    }
1990 >
1991 >        checkCompletedNormally(f, v1);
1992 >        checkCancelled(g);
1993 >    }}
1994  
1995      /**
1996 <     * acceptEither result completes normally after normal completion
2161 <     * of either source
1996 >     * applyToEither result completes exceptionally if action does
1997       */
1998 <    public void testAcceptEither_normalCompletion1() {
1998 >    public void testApplyToEither_actionFailed() {
1999          for (ExecutionMode m : ExecutionMode.values())
2000          for (Integer v1 : new Integer[] { 1, null })
2001 <        for (Integer v2 : new Integer[] { 2, null }) {
2002 <
2001 >        for (Integer v2 : new Integer[] { 2, null })
2002 >    {
2003          final CompletableFuture<Integer> f = new CompletableFuture<>();
2004          final CompletableFuture<Integer> g = new CompletableFuture<>();
2005 <        final IncAction r = new IncAction();
2006 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2005 >        final FailingFunction[] rs = new FailingFunction[6];
2006 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
2007  
2008 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2009 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2010          f.complete(v1);
2011 <        checkCompletedNormally(h, null);
2012 <        assertEquals(r.value, inc(v1));
2013 <        g.complete(v2);
2014 <
2015 <        checkCompletedNormally(f, v1);
2016 <        checkCompletedNormally(g, v2);
2017 <        checkCompletedNormally(h, null);
2181 <        }
2182 <    }
2011 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2012 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2013 >        checkCompletedWithWrappedCFException(h0);
2014 >        checkCompletedWithWrappedCFException(h1);
2015 >        checkCompletedWithWrappedCFException(h2);
2016 >        checkCompletedWithWrappedCFException(h3);
2017 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2018  
2019 <    public void testAcceptEither_normalCompletion2() {
2185 <        for (ExecutionMode m : ExecutionMode.values())
2186 <        for (Integer v1 : new Integer[] { 1, null })
2187 <        for (Integer v2 : new Integer[] { 2, null }) {
2019 >        g.complete(v2);
2020  
2021 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2022 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2023 <        final IncAction r = new IncAction();
2192 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2021 >        // unspecified behavior - both source completions available
2022 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2023 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2024  
2025 <        g.complete(v2);
2026 <        checkCompletedNormally(h, null);
2027 <        assertEquals(r.value, inc(v2));
2028 <        f.complete(v1);
2025 >        checkCompletedWithWrappedCFException(h4);
2026 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2027 >                   Objects.equals(v2, rs[4].value));
2028 >        checkCompletedWithWrappedCFException(h5);
2029 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2030 >                   Objects.equals(v2, rs[5].value));
2031  
2032          checkCompletedNormally(f, v1);
2033          checkCompletedNormally(g, v2);
2034 <        checkCompletedNormally(h, null);
2035 <        }
2036 <    }
2037 <    public void testAcceptEither_normalCompletion3() {
2034 >    }}
2035 >
2036 >    /**
2037 >     * acceptEither result completes normally after normal completion
2038 >     * of either source
2039 >     */
2040 >    public void testAcceptEither_normalCompletion() {
2041          for (ExecutionMode m : ExecutionMode.values())
2042          for (Integer v1 : new Integer[] { 1, null })
2043 <        for (Integer v2 : new Integer[] { 2, null }) {
2044 <
2043 >        for (Integer v2 : new Integer[] { 2, null })
2044 >    {
2045          final CompletableFuture<Integer> f = new CompletableFuture<>();
2046          final CompletableFuture<Integer> g = new CompletableFuture<>();
2047 <        final IncAction r = new IncAction();
2048 <
2049 <        f.complete(v1);
2050 <        g.complete(v2);
2051 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2047 >        final NoopConsumer[] rs = new NoopConsumer[6];
2048 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2049 >
2050 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2051 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2052 >        checkIncomplete(h0);
2053 >        checkIncomplete(h1);
2054 >        rs[0].assertNotInvoked();
2055 >        rs[1].assertNotInvoked();
2056 >        f.complete(v1);
2057 >        checkCompletedNormally(h0, null);
2058 >        checkCompletedNormally(h1, null);
2059 >        rs[0].assertValue(v1);
2060 >        rs[1].assertValue(v1);
2061 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2062 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2063 >        checkCompletedNormally(h2, null);
2064 >        checkCompletedNormally(h3, null);
2065 >        rs[2].assertValue(v1);
2066 >        rs[3].assertValue(v1);
2067 >        g.complete(v2);
2068 >
2069 >        // unspecified behavior - both source completions available
2070 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2071 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2072 >        checkCompletedNormally(h4, null);
2073 >        checkCompletedNormally(h5, null);
2074 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2075 >                   Objects.equals(v2, rs[4].value));
2076 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2077 >                   Objects.equals(v2, rs[5].value));
2078  
2217        checkCompletedNormally(h, null);
2079          checkCompletedNormally(f, v1);
2080          checkCompletedNormally(g, v2);
2081 <
2082 <        // unspecified behavior
2083 <        assertTrue(Objects.equals(r.value, inc(v1)) ||
2084 <                   Objects.equals(r.value, inc(v2)));
2085 <        }
2086 <    }
2081 >        checkCompletedNormally(h0, null);
2082 >        checkCompletedNormally(h1, null);
2083 >        checkCompletedNormally(h2, null);
2084 >        checkCompletedNormally(h3, null);
2085 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2086 >    }}
2087  
2088      /**
2089       * acceptEither result completes exceptionally after exceptional
2090       * completion of either source
2091       */
2092 <    public void testAcceptEither_exceptionalCompletion1() {
2092 >    public void testAcceptEither_exceptionalCompletion() {
2093          for (ExecutionMode m : ExecutionMode.values())
2094 <        for (Integer v1 : new Integer[] { 1, null }) {
2095 <
2094 >        for (Integer v1 : new Integer[] { 1, null })
2095 >    {
2096          final CompletableFuture<Integer> f = new CompletableFuture<>();
2097          final CompletableFuture<Integer> g = new CompletableFuture<>();
2237        final IncAction r = new IncAction();
2238        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2098          final CFException ex = new CFException();
2099 +        final NoopConsumer[] rs = new NoopConsumer[6];
2100 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2101  
2102 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2103 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2104 +        checkIncomplete(h0);
2105 +        checkIncomplete(h1);
2106 +        rs[0].assertNotInvoked();
2107 +        rs[1].assertNotInvoked();
2108          f.completeExceptionally(ex);
2109 <        checkCompletedWithWrappedCFException(h, ex);
2109 >        checkCompletedWithWrappedException(h0, ex);
2110 >        checkCompletedWithWrappedException(h1, ex);
2111 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2112 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2113 >        checkCompletedWithWrappedException(h2, ex);
2114 >        checkCompletedWithWrappedException(h3, ex);
2115 >
2116          g.complete(v1);
2117  
2118 <        assertEquals(r.invocationCount, 0);
2119 <        checkCompletedNormally(g, v1);
2120 <        checkCompletedWithWrappedCFException(f, ex);
2121 <        checkCompletedWithWrappedCFException(h, ex);
2118 >        // unspecified behavior - both source completions available
2119 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2120 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2121 >        try {
2122 >            assertNull(h4.join());
2123 >            rs[4].assertValue(v1);
2124 >        } catch (CompletionException ok) {
2125 >            checkCompletedWithWrappedException(h4, ex);
2126 >            rs[4].assertNotInvoked();
2127 >        }
2128 >        try {
2129 >            assertNull(h5.join());
2130 >            rs[5].assertValue(v1);
2131 >        } catch (CompletionException ok) {
2132 >            checkCompletedWithWrappedException(h5, ex);
2133 >            rs[5].assertNotInvoked();
2134          }
2135 <    }
2135 >
2136 >        checkCompletedExceptionally(f, ex);
2137 >        checkCompletedNormally(g, v1);
2138 >        checkCompletedWithWrappedException(h0, ex);
2139 >        checkCompletedWithWrappedException(h1, ex);
2140 >        checkCompletedWithWrappedException(h2, ex);
2141 >        checkCompletedWithWrappedException(h3, ex);
2142 >        checkCompletedWithWrappedException(h4, ex);
2143 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2144 >    }}
2145  
2146      public void testAcceptEither_exceptionalCompletion2() {
2147          for (ExecutionMode m : ExecutionMode.values())
2148 <        for (Integer v1 : new Integer[] { 1, null }) {
2149 <
2148 >        for (boolean fFirst : new boolean[] { true, false })
2149 >        for (Integer v1 : new Integer[] { 1, null })
2150 >    {
2151          final CompletableFuture<Integer> f = new CompletableFuture<>();
2152          final CompletableFuture<Integer> g = new CompletableFuture<>();
2258        final IncAction r = new IncAction();
2259        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2153          final CFException ex = new CFException();
2154 +        final NoopConsumer[] rs = new NoopConsumer[6];
2155 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2156  
2157 <        g.completeExceptionally(ex);
2158 <        checkCompletedWithWrappedCFException(h, ex);
2159 <        f.complete(v1);
2160 <
2161 <        assertEquals(r.invocationCount, 0);
2162 <        checkCompletedNormally(f, v1);
2163 <        checkCompletedWithWrappedCFException(g, ex);
2164 <        checkCompletedWithWrappedCFException(h, ex);
2157 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2158 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2159 >        if (fFirst) {
2160 >            f.complete(v1);
2161 >            g.completeExceptionally(ex);
2162 >        } else {
2163 >            g.completeExceptionally(ex);
2164 >            f.complete(v1);
2165          }
2166 <    }
2167 <
2273 <    public void testAcceptEither_exceptionalCompletion3() {
2274 <        for (ExecutionMode m : ExecutionMode.values())
2275 <        for (Integer v1 : new Integer[] { 1, null }) {
2166 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2167 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2168  
2169 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2278 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2279 <        final IncAction r = new IncAction();
2280 <        final CFException ex = new CFException();
2281 <
2282 <        g.completeExceptionally(ex);
2283 <        f.complete(v1);
2284 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2285 <
2286 <        // unspecified behavior
2287 <        Integer v;
2169 >        // unspecified behavior - both source completions available
2170          try {
2171 <            assertEquals(h.join(), null);
2172 <            assertEquals(r.invocationCount, 1);
2291 <            assertEquals(inc(v1), r.value);
2171 >            assertEquals(null, h0.join());
2172 >            rs[0].assertValue(v1);
2173          } catch (CompletionException ok) {
2174 <            checkCompletedWithWrappedCFException(h, ex);
2175 <            assertEquals(r.invocationCount, 0);
2295 <        }
2296 <
2297 <        checkCompletedWithWrappedCFException(g, ex);
2298 <        checkCompletedNormally(f, v1);
2174 >            checkCompletedWithWrappedException(h0, ex);
2175 >            rs[0].assertNotInvoked();
2176          }
2300    }
2301
2302    public void testAcceptEither_exceptionalCompletion4() {
2303        for (ExecutionMode m : ExecutionMode.values())
2304        for (Integer v1 : new Integer[] { 1, null }) {
2305
2306        final CompletableFuture<Integer> f = new CompletableFuture<>();
2307        final CompletableFuture<Integer> g = new CompletableFuture<>();
2308        final IncAction r = new IncAction();
2309        final CFException ex = new CFException();
2310
2311        f.completeExceptionally(ex);
2312        g.complete(v1);
2313        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2314
2315        // unspecified behavior
2316        Integer v;
2177          try {
2178 <            assertEquals(h.join(), null);
2179 <            assertEquals(r.invocationCount, 1);
2320 <            assertEquals(inc(v1), r.value);
2178 >            assertEquals(null, h1.join());
2179 >            rs[1].assertValue(v1);
2180          } catch (CompletionException ok) {
2181 <            checkCompletedWithWrappedCFException(h, ex);
2182 <            assertEquals(r.invocationCount, 0);
2181 >            checkCompletedWithWrappedException(h1, ex);
2182 >            rs[1].assertNotInvoked();
2183          }
2184 <
2185 <        checkCompletedWithWrappedCFException(f, ex);
2186 <        checkCompletedNormally(g, v1);
2184 >        try {
2185 >            assertEquals(null, h2.join());
2186 >            rs[2].assertValue(v1);
2187 >        } catch (CompletionException ok) {
2188 >            checkCompletedWithWrappedException(h2, ex);
2189 >            rs[2].assertNotInvoked();
2190          }
2191 <    }
2192 <
2193 <    /**
2194 <     * acceptEither result completes exceptionally if action does
2195 <     */
2196 <    public void testAcceptEither_actionFailed1() {
2335 <        for (ExecutionMode m : ExecutionMode.values())
2336 <        for (Integer v1 : new Integer[] { 1, null })
2337 <        for (Integer v2 : new Integer[] { 2, null }) {
2338 <
2339 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2340 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2341 <        final FailingConsumer r = new FailingConsumer();
2342 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2343 <
2344 <        f.complete(v1);
2345 <        checkCompletedWithWrappedCFException(h);
2346 <        g.complete(v2);
2347 <        checkCompletedNormally(f, v1);
2348 <        checkCompletedNormally(g, v2);
2191 >        try {
2192 >            assertEquals(null, h3.join());
2193 >            rs[3].assertValue(v1);
2194 >        } catch (CompletionException ok) {
2195 >            checkCompletedWithWrappedException(h3, ex);
2196 >            rs[3].assertNotInvoked();
2197          }
2350    }
2351
2352    public void testAcceptEither_actionFailed2() {
2353        for (ExecutionMode m : ExecutionMode.values())
2354        for (Integer v1 : new Integer[] { 1, null })
2355        for (Integer v2 : new Integer[] { 2, null }) {
2356
2357        final CompletableFuture<Integer> f = new CompletableFuture<>();
2358        final CompletableFuture<Integer> g = new CompletableFuture<>();
2359        final FailingConsumer r = new FailingConsumer();
2360        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2198  
2362        g.complete(v2);
2363        checkCompletedWithWrappedCFException(h);
2364        f.complete(v1);
2199          checkCompletedNormally(f, v1);
2200 <        checkCompletedNormally(g, v2);
2201 <        }
2368 <    }
2200 >        checkCompletedExceptionally(g, ex);
2201 >    }}
2202  
2203      /**
2204       * acceptEither result completes exceptionally if either source cancelled
2205       */
2206 <    public void testAcceptEither_sourceCancelled1() {
2374 <        for (ExecutionMode m : ExecutionMode.values())
2375 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2376 <        for (Integer v1 : new Integer[] { 1, null }) {
2377 <
2378 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2379 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2380 <        final IncAction r = new IncAction();
2381 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2382 <
2383 <        assertTrue(f.cancel(mayInterruptIfRunning));
2384 <        checkCompletedWithWrappedCancellationException(h);
2385 <        g.complete(v1);
2386 <
2387 <        checkCancelled(f);
2388 <        assertEquals(r.invocationCount, 0);
2389 <        checkCompletedNormally(g, v1);
2390 <        checkCompletedWithWrappedCancellationException(h);
2391 <        }
2392 <    }
2393 <
2394 <    public void testAcceptEither_sourceCancelled2() {
2206 >    public void testAcceptEither_sourceCancelled() {
2207          for (ExecutionMode m : ExecutionMode.values())
2208          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2209 <        for (Integer v1 : new Integer[] { 1, null }) {
2210 <
2209 >        for (Integer v1 : new Integer[] { 1, null })
2210 >    {
2211          final CompletableFuture<Integer> f = new CompletableFuture<>();
2212          final CompletableFuture<Integer> g = new CompletableFuture<>();
2213 <        final IncAction r = new IncAction();
2214 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2213 >        final NoopConsumer[] rs = new NoopConsumer[6];
2214 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2215  
2216 <        assertTrue(g.cancel(mayInterruptIfRunning));
2217 <        checkCompletedWithWrappedCancellationException(h);
2218 <        f.complete(v1);
2216 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2217 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2218 >        checkIncomplete(h0);
2219 >        checkIncomplete(h1);
2220 >        rs[0].assertNotInvoked();
2221 >        rs[1].assertNotInvoked();
2222 >        f.cancel(mayInterruptIfRunning);
2223 >        checkCompletedWithWrappedCancellationException(h0);
2224 >        checkCompletedWithWrappedCancellationException(h1);
2225 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2226 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2227 >        checkCompletedWithWrappedCancellationException(h2);
2228 >        checkCompletedWithWrappedCancellationException(h3);
2229  
2230 <        checkCancelled(g);
2409 <        assertEquals(r.invocationCount, 0);
2410 <        checkCompletedNormally(f, v1);
2411 <        checkCompletedWithWrappedCancellationException(h);
2412 <        }
2413 <    }
2414 <
2415 <    public void testAcceptEither_sourceCancelled3() {
2416 <        for (ExecutionMode m : ExecutionMode.values())
2417 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2418 <        for (Integer v1 : new Integer[] { 1, null }) {
2419 <
2420 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2421 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2422 <        final IncAction r = new IncAction();
2423 <
2424 <        assertTrue(g.cancel(mayInterruptIfRunning));
2425 <        f.complete(v1);
2426 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2230 >        g.complete(v1);
2231  
2232 <        // unspecified behavior
2233 <        Integer v;
2232 >        // unspecified behavior - both source completions available
2233 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2234 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2235          try {
2236 <            assertEquals(h.join(), null);
2237 <            assertEquals(r.invocationCount, 1);
2433 <            assertEquals(inc(v1), r.value);
2236 >            assertNull(h4.join());
2237 >            rs[4].assertValue(v1);
2238          } catch (CompletionException ok) {
2239 <            checkCompletedWithWrappedCancellationException(h);
2240 <            assertEquals(r.invocationCount, 0);
2239 >            checkCompletedWithWrappedCancellationException(h4);
2240 >            rs[4].assertNotInvoked();
2241          }
2438
2439        checkCancelled(g);
2440        checkCompletedNormally(f, v1);
2441        }
2442    }
2443
2444    public void testAcceptEither_sourceCancelled4() {
2445        for (ExecutionMode m : ExecutionMode.values())
2446        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2447        for (Integer v1 : new Integer[] { 1, null }) {
2448
2449        final CompletableFuture<Integer> f = new CompletableFuture<>();
2450        final CompletableFuture<Integer> g = new CompletableFuture<>();
2451        final IncAction r = new IncAction();
2452
2453        assertTrue(f.cancel(mayInterruptIfRunning));
2454        g.complete(v1);
2455        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2456
2457        // unspecified behavior
2458        Integer v;
2242          try {
2243 <            assertEquals(h.join(), null);
2244 <            assertEquals(r.invocationCount, 1);
2462 <            assertEquals(inc(v1), r.value);
2243 >            assertNull(h5.join());
2244 >            rs[5].assertValue(v1);
2245          } catch (CompletionException ok) {
2246 <            checkCompletedWithWrappedCancellationException(h);
2247 <            assertEquals(r.invocationCount, 0);
2246 >            checkCompletedWithWrappedCancellationException(h5);
2247 >            rs[5].assertNotInvoked();
2248          }
2249  
2250          checkCancelled(f);
2251          checkCompletedNormally(g, v1);
2252 <        }
2253 <    }
2252 >        checkCompletedWithWrappedCancellationException(h0);
2253 >        checkCompletedWithWrappedCancellationException(h1);
2254 >        checkCompletedWithWrappedCancellationException(h2);
2255 >        checkCompletedWithWrappedCancellationException(h3);
2256 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2257 >    }}
2258  
2259      /**
2260 <     * runAfterEither result completes normally after normal completion
2475 <     * of either source
2260 >     * acceptEither result completes exceptionally if action does
2261       */
2262 <    public void testRunAfterEither_normalCompletion1() {
2262 >    public void testAcceptEither_actionFailed() {
2263          for (ExecutionMode m : ExecutionMode.values())
2264          for (Integer v1 : new Integer[] { 1, null })
2265 <        for (Integer v2 : new Integer[] { 2, null }) {
2266 <
2265 >        for (Integer v2 : new Integer[] { 2, null })
2266 >    {
2267          final CompletableFuture<Integer> f = new CompletableFuture<>();
2268          final CompletableFuture<Integer> g = new CompletableFuture<>();
2269 <        final Noop r = new Noop();
2270 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2269 >        final FailingConsumer[] rs = new FailingConsumer[6];
2270 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
2271  
2272 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2273 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2274          f.complete(v1);
2275 <        checkCompletedNormally(h, null);
2276 <        assertEquals(r.invocationCount, 1);
2277 <        g.complete(v2);
2278 <
2279 <        checkCompletedNormally(f, v1);
2280 <        checkCompletedNormally(g, v2);
2281 <        checkCompletedNormally(h, null);
2495 <        assertEquals(r.invocationCount, 1);
2496 <        }
2497 <    }
2275 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2276 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2277 >        checkCompletedWithWrappedCFException(h0);
2278 >        checkCompletedWithWrappedCFException(h1);
2279 >        checkCompletedWithWrappedCFException(h2);
2280 >        checkCompletedWithWrappedCFException(h3);
2281 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2282  
2283 <    public void testRunAfterEither_normalCompletion2() {
2500 <        for (ExecutionMode m : ExecutionMode.values())
2501 <        for (Integer v1 : new Integer[] { 1, null })
2502 <        for (Integer v2 : new Integer[] { 2, null }) {
2283 >        g.complete(v2);
2284  
2285 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2286 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2287 <        final Noop r = new Noop();
2507 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2285 >        // unspecified behavior - both source completions available
2286 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2287 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2288  
2289 <        g.complete(v2);
2290 <        checkCompletedNormally(h, null);
2291 <        assertEquals(r.invocationCount, 1);
2292 <        f.complete(v1);
2289 >        checkCompletedWithWrappedCFException(h4);
2290 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2291 >                   Objects.equals(v2, rs[4].value));
2292 >        checkCompletedWithWrappedCFException(h5);
2293 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2294 >                   Objects.equals(v2, rs[5].value));
2295  
2296          checkCompletedNormally(f, v1);
2297          checkCompletedNormally(g, v2);
2298 <        checkCompletedNormally(h, null);
2299 <        assertEquals(r.invocationCount, 1);
2300 <        }
2301 <    }
2302 <    public void testRunAfterEither_normalCompletion3() {
2298 >    }}
2299 >
2300 >    /**
2301 >     * runAfterEither result completes normally after normal completion
2302 >     * of either source
2303 >     */
2304 >    public void testRunAfterEither_normalCompletion() {
2305          for (ExecutionMode m : ExecutionMode.values())
2306          for (Integer v1 : new Integer[] { 1, null })
2307 <        for (Integer v2 : new Integer[] { 2, null }) {
2308 <
2307 >        for (Integer v2 : new Integer[] { 2, null })
2308 >    {
2309          final CompletableFuture<Integer> f = new CompletableFuture<>();
2310          final CompletableFuture<Integer> g = new CompletableFuture<>();
2311 <        final Noop r = new Noop();
2311 >        final Noop[] rs = new Noop[6];
2312 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2313  
2314 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2315 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2316 +        checkIncomplete(h0);
2317 +        checkIncomplete(h1);
2318 +        rs[0].assertNotInvoked();
2319 +        rs[1].assertNotInvoked();
2320          f.complete(v1);
2321 +        checkCompletedNormally(h0, null);
2322 +        checkCompletedNormally(h1, null);
2323 +        rs[0].assertInvoked();
2324 +        rs[1].assertInvoked();
2325 +        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2326 +        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2327 +        checkCompletedNormally(h2, null);
2328 +        checkCompletedNormally(h3, null);
2329 +        rs[2].assertInvoked();
2330 +        rs[3].assertInvoked();
2331 +
2332          g.complete(v2);
2531        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2333  
2334 <        checkCompletedNormally(h, null);
2334 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2335 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2336 >
2337          checkCompletedNormally(f, v1);
2338          checkCompletedNormally(g, v2);
2339 <        assertEquals(r.invocationCount, 1);
2340 <        }
2341 <    }
2339 >        checkCompletedNormally(h0, null);
2340 >        checkCompletedNormally(h1, null);
2341 >        checkCompletedNormally(h2, null);
2342 >        checkCompletedNormally(h3, null);
2343 >        checkCompletedNormally(h4, null);
2344 >        checkCompletedNormally(h5, null);
2345 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2346 >    }}
2347  
2348      /**
2349       * runAfterEither result completes exceptionally after exceptional
2350       * completion of either source
2351       */
2352 <    public void testRunAfterEither_exceptionalCompletion1() {
2352 >    public void testRunAfterEither_exceptionalCompletion() {
2353          for (ExecutionMode m : ExecutionMode.values())
2354 <        for (Integer v1 : new Integer[] { 1, null }) {
2355 <
2354 >        for (Integer v1 : new Integer[] { 1, null })
2355 >    {
2356          final CompletableFuture<Integer> f = new CompletableFuture<>();
2357          final CompletableFuture<Integer> g = new CompletableFuture<>();
2550        final Noop r = new Noop();
2551        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2358          final CFException ex = new CFException();
2359 +        final Noop[] rs = new Noop[6];
2360 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2361  
2362 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2363 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2364 +        checkIncomplete(h0);
2365 +        checkIncomplete(h1);
2366 +        rs[0].assertNotInvoked();
2367 +        rs[1].assertNotInvoked();
2368          f.completeExceptionally(ex);
2369 <        checkCompletedWithWrappedCFException(h, ex);
2369 >        checkCompletedWithWrappedException(h0, ex);
2370 >        checkCompletedWithWrappedException(h1, ex);
2371 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2372 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2373 >        checkCompletedWithWrappedException(h2, ex);
2374 >        checkCompletedWithWrappedException(h3, ex);
2375 >
2376          g.complete(v1);
2377  
2378 <        assertEquals(r.invocationCount, 0);
2379 <        checkCompletedNormally(g, v1);
2380 <        checkCompletedWithWrappedCFException(f, ex);
2381 <        checkCompletedWithWrappedCFException(h, ex);
2378 >        // unspecified behavior - both source completions available
2379 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2380 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2381 >        try {
2382 >            assertNull(h4.join());
2383 >            rs[4].assertInvoked();
2384 >        } catch (CompletionException ok) {
2385 >            checkCompletedWithWrappedException(h4, ex);
2386 >            rs[4].assertNotInvoked();
2387 >        }
2388 >        try {
2389 >            assertNull(h5.join());
2390 >            rs[5].assertInvoked();
2391 >        } catch (CompletionException ok) {
2392 >            checkCompletedWithWrappedException(h5, ex);
2393 >            rs[5].assertNotInvoked();
2394          }
2395 <    }
2395 >
2396 >        checkCompletedExceptionally(f, ex);
2397 >        checkCompletedNormally(g, v1);
2398 >        checkCompletedWithWrappedException(h0, ex);
2399 >        checkCompletedWithWrappedException(h1, ex);
2400 >        checkCompletedWithWrappedException(h2, ex);
2401 >        checkCompletedWithWrappedException(h3, ex);
2402 >        checkCompletedWithWrappedException(h4, ex);
2403 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2404 >    }}
2405  
2406      public void testRunAfterEither_exceptionalCompletion2() {
2407          for (ExecutionMode m : ExecutionMode.values())
2408 <        for (Integer v1 : new Integer[] { 1, null }) {
2409 <
2408 >        for (boolean fFirst : new boolean[] { true, false })
2409 >        for (Integer v1 : new Integer[] { 1, null })
2410 >    {
2411          final CompletableFuture<Integer> f = new CompletableFuture<>();
2412          final CompletableFuture<Integer> g = new CompletableFuture<>();
2571        final Noop r = new Noop();
2572        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2413          final CFException ex = new CFException();
2414 +        final Noop[] rs = new Noop[6];
2415 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2416  
2417 <        g.completeExceptionally(ex);
2418 <        checkCompletedWithWrappedCFException(h, ex);
2419 <        f.complete(v1);
2420 <
2421 <        assertEquals(r.invocationCount, 0);
2422 <        checkCompletedNormally(f, v1);
2423 <        checkCompletedWithWrappedCFException(g, ex);
2424 <        checkCompletedWithWrappedCFException(h, ex);
2417 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2418 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2419 >        if (fFirst) {
2420 >            f.complete(v1);
2421 >            g.completeExceptionally(ex);
2422 >        } else {
2423 >            g.completeExceptionally(ex);
2424 >            f.complete(v1);
2425          }
2426 <    }
2426 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2427 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2428  
2429 <    public void testRunAfterEither_exceptionalCompletion3() {
2430 <        for (ExecutionMode m : ExecutionMode.values())
2431 <        for (Integer v1 : new Integer[] { 1, null }) {
2432 <
2433 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2434 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2435 <        final Noop r = new Noop();
2436 <        final CFException ex = new CFException();
2437 <
2438 <        g.completeExceptionally(ex);
2439 <        f.complete(v1);
2440 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2441 <
2442 <        // unspecified behavior
2443 <        Integer v;
2429 >        // unspecified behavior - both source completions available
2430 >        try {
2431 >            assertEquals(null, h0.join());
2432 >            rs[0].assertInvoked();
2433 >        } catch (CompletionException ok) {
2434 >            checkCompletedWithWrappedException(h0, ex);
2435 >            rs[0].assertNotInvoked();
2436 >        }
2437 >        try {
2438 >            assertEquals(null, h1.join());
2439 >            rs[1].assertInvoked();
2440 >        } catch (CompletionException ok) {
2441 >            checkCompletedWithWrappedException(h1, ex);
2442 >            rs[1].assertNotInvoked();
2443 >        }
2444          try {
2445 <            assertEquals(h.join(), null);
2446 <            assertEquals(r.invocationCount, 1);
2445 >            assertEquals(null, h2.join());
2446 >            rs[2].assertInvoked();
2447          } catch (CompletionException ok) {
2448 <            checkCompletedWithWrappedCFException(h, ex);
2449 <            assertEquals(r.invocationCount, 0);
2448 >            checkCompletedWithWrappedException(h2, ex);
2449 >            rs[2].assertNotInvoked();
2450 >        }
2451 >        try {
2452 >            assertEquals(null, h3.join());
2453 >            rs[3].assertInvoked();
2454 >        } catch (CompletionException ok) {
2455 >            checkCompletedWithWrappedException(h3, ex);
2456 >            rs[3].assertNotInvoked();
2457          }
2458  
2609        checkCompletedWithWrappedCFException(g, ex);
2459          checkCompletedNormally(f, v1);
2460 <        }
2461 <    }
2460 >        checkCompletedExceptionally(g, ex);
2461 >    }}
2462  
2463 <    public void testRunAfterEither_exceptionalCompletion4() {
2463 >    /**
2464 >     * runAfterEither result completes exceptionally if either source cancelled
2465 >     */
2466 >    public void testRunAfterEither_sourceCancelled() {
2467          for (ExecutionMode m : ExecutionMode.values())
2468 <        for (Integer v1 : new Integer[] { 1, null }) {
2469 <
2468 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2469 >        for (Integer v1 : new Integer[] { 1, null })
2470 >    {
2471          final CompletableFuture<Integer> f = new CompletableFuture<>();
2472          final CompletableFuture<Integer> g = new CompletableFuture<>();
2473 <        final Noop r = new Noop();
2474 <        final CFException ex = new CFException();
2473 >        final Noop[] rs = new Noop[6];
2474 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2475 >
2476 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2477 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2478 >        checkIncomplete(h0);
2479 >        checkIncomplete(h1);
2480 >        rs[0].assertNotInvoked();
2481 >        rs[1].assertNotInvoked();
2482 >        f.cancel(mayInterruptIfRunning);
2483 >        checkCompletedWithWrappedCancellationException(h0);
2484 >        checkCompletedWithWrappedCancellationException(h1);
2485 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2486 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2487 >        checkCompletedWithWrappedCancellationException(h2);
2488 >        checkCompletedWithWrappedCancellationException(h3);
2489  
2623        f.completeExceptionally(ex);
2490          g.complete(v1);
2625        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2491  
2492 <        // unspecified behavior
2493 <        Integer v;
2492 >        // unspecified behavior - both source completions available
2493 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2494 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2495 >        try {
2496 >            assertNull(h4.join());
2497 >            rs[4].assertInvoked();
2498 >        } catch (CompletionException ok) {
2499 >            checkCompletedWithWrappedCancellationException(h4);
2500 >            rs[4].assertNotInvoked();
2501 >        }
2502          try {
2503 <            assertEquals(h.join(), null);
2504 <            assertEquals(r.invocationCount, 1);
2503 >            assertNull(h5.join());
2504 >            rs[5].assertInvoked();
2505          } catch (CompletionException ok) {
2506 <            checkCompletedWithWrappedCFException(h, ex);
2507 <            assertEquals(r.invocationCount, 0);
2506 >            checkCompletedWithWrappedCancellationException(h5);
2507 >            rs[5].assertNotInvoked();
2508          }
2509  
2510 <        checkCompletedWithWrappedCFException(f, ex);
2510 >        checkCancelled(f);
2511          checkCompletedNormally(g, v1);
2512 <        }
2513 <    }
2512 >        checkCompletedWithWrappedCancellationException(h0);
2513 >        checkCompletedWithWrappedCancellationException(h1);
2514 >        checkCompletedWithWrappedCancellationException(h2);
2515 >        checkCompletedWithWrappedCancellationException(h3);
2516 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2517 >    }}
2518  
2519      /**
2520       * runAfterEither result completes exceptionally if action does
2521       */
2522 <    public void testRunAfterEither_actionFailed1() {
2522 >    public void testRunAfterEither_actionFailed() {
2523          for (ExecutionMode m : ExecutionMode.values())
2524          for (Integer v1 : new Integer[] { 1, null })
2525 <        for (Integer v2 : new Integer[] { 2, null }) {
2526 <
2525 >        for (Integer v2 : new Integer[] { 2, null })
2526 >    {
2527          final CompletableFuture<Integer> f = new CompletableFuture<>();
2528          final CompletableFuture<Integer> g = new CompletableFuture<>();
2529 <        final FailingNoop r = new FailingNoop();
2530 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2529 >        final FailingRunnable[] rs = new FailingRunnable[6];
2530 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2531  
2532 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2533 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2534          f.complete(v1);
2535 <        checkCompletedWithWrappedCFException(h);
2535 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2536 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2537 >        checkCompletedWithWrappedCFException(h0);
2538 >        checkCompletedWithWrappedCFException(h1);
2539 >        checkCompletedWithWrappedCFException(h2);
2540 >        checkCompletedWithWrappedCFException(h3);
2541 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2542          g.complete(v2);
2543 <        checkCompletedNormally(f, v1);
2544 <        checkCompletedNormally(g, v2);
2545 <        }
2546 <    }
2543 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2544 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2545 >        checkCompletedWithWrappedCFException(h4);
2546 >        checkCompletedWithWrappedCFException(h5);
2547  
2663    public void testRunAfterEither_actionFailed2() {
2664        for (ExecutionMode m : ExecutionMode.values())
2665        for (Integer v1 : new Integer[] { 1, null })
2666        for (Integer v2 : new Integer[] { 2, null }) {
2667
2668        final CompletableFuture<Integer> f = new CompletableFuture<>();
2669        final CompletableFuture<Integer> g = new CompletableFuture<>();
2670        final FailingNoop r = new FailingNoop();
2671        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2672
2673        g.complete(v2);
2674        checkCompletedWithWrappedCFException(h);
2675        f.complete(v1);
2548          checkCompletedNormally(f, v1);
2549          checkCompletedNormally(g, v2);
2550 <        }
2551 <    }
2550 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2551 >    }}
2552  
2553      /**
2554 <     * runAfterEither result completes exceptionally if either source cancelled
2554 >     * thenCompose result completes normally after normal completion of source
2555       */
2556 <    public void testRunAfterEither_sourceCancelled1() {
2556 >    public void testThenCompose_normalCompletion() {
2557          for (ExecutionMode m : ExecutionMode.values())
2558 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2559 <        for (Integer v1 : new Integer[] { 1, null }) {
2560 <
2689 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2690 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2691 <        final Noop r = new Noop();
2692 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2693 <
2694 <        assertTrue(f.cancel(mayInterruptIfRunning));
2695 <        checkCompletedWithWrappedCancellationException(h);
2696 <        g.complete(v1);
2697 <
2698 <        checkCancelled(f);
2699 <        assertEquals(r.invocationCount, 0);
2700 <        checkCompletedNormally(g, v1);
2701 <        checkCompletedWithWrappedCancellationException(h);
2702 <        }
2703 <    }
2704 <
2705 <    public void testRunAfterEither_sourceCancelled2() {
2706 <        for (ExecutionMode m : ExecutionMode.values())
2707 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2708 <        for (Integer v1 : new Integer[] { 1, null }) {
2709 <
2710 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2711 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2712 <        final Noop r = new Noop();
2713 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2714 <
2715 <        assertTrue(g.cancel(mayInterruptIfRunning));
2716 <        checkCompletedWithWrappedCancellationException(h);
2717 <        f.complete(v1);
2718 <
2719 <        checkCancelled(g);
2720 <        assertEquals(r.invocationCount, 0);
2721 <        checkCompletedNormally(f, v1);
2722 <        checkCompletedWithWrappedCancellationException(h);
2723 <        }
2724 <    }
2725 <
2726 <    public void testRunAfterEither_sourceCancelled3() {
2727 <        for (ExecutionMode m : ExecutionMode.values())
2728 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2729 <        for (Integer v1 : new Integer[] { 1, null }) {
2730 <
2558 >        for (boolean createIncomplete : new boolean[] { true, false })
2559 >        for (Integer v1 : new Integer[] { 1, null })
2560 >    {
2561          final CompletableFuture<Integer> f = new CompletableFuture<>();
2562 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2563 <        final Noop r = new Noop();
2564 <
2565 <        assertTrue(g.cancel(mayInterruptIfRunning));
2736 <        f.complete(v1);
2737 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2738 <
2739 <        // unspecified behavior
2740 <        Integer v;
2741 <        try {
2742 <            assertEquals(h.join(), null);
2743 <            assertEquals(r.invocationCount, 1);
2744 <        } catch (CompletionException ok) {
2745 <            checkCompletedWithWrappedCancellationException(h);
2746 <            assertEquals(r.invocationCount, 0);
2747 <        }
2562 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2563 >        if (!createIncomplete) f.complete(v1);
2564 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2565 >        if (createIncomplete) f.complete(v1);
2566  
2567 <        checkCancelled(g);
2567 >        checkCompletedNormally(g, inc(v1));
2568          checkCompletedNormally(f, v1);
2569 <        }
2570 <    }
2753 <
2754 <    public void testRunAfterEither_sourceCancelled4() {
2755 <        for (ExecutionMode m : ExecutionMode.values())
2756 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2757 <        for (Integer v1 : new Integer[] { 1, null }) {
2758 <
2759 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2760 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2761 <        final Noop r = new Noop();
2762 <
2763 <        assertTrue(f.cancel(mayInterruptIfRunning));
2764 <        g.complete(v1);
2765 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2766 <
2767 <        // unspecified behavior
2768 <        Integer v;
2769 <        try {
2770 <            assertEquals(h.join(), null);
2771 <            assertEquals(r.invocationCount, 1);
2772 <        } catch (CompletionException ok) {
2773 <            checkCompletedWithWrappedCancellationException(h);
2774 <            assertEquals(r.invocationCount, 0);
2775 <        }
2776 <
2777 <        checkCancelled(f);
2778 <        checkCompletedNormally(g, v1);
2779 <        }
2780 <    }
2781 <
2782 <    /**
2783 <     * thenCompose result completes normally after normal completion of source
2784 <     */
2785 <    public void testThenCompose() {
2786 <        CompletableFuture<Integer> f, g;
2787 <        CompletableFutureInc r;
2788 <
2789 <        f = new CompletableFuture<>();
2790 <        g = f.thenCompose(r = new CompletableFutureInc());
2791 <        f.complete(one);
2792 <        checkCompletedNormally(g, two);
2793 <        assertTrue(r.ran);
2794 <
2795 <        f = new CompletableFuture<>();
2796 <        f.complete(one);
2797 <        g = f.thenCompose(r = new CompletableFutureInc());
2798 <        checkCompletedNormally(g, two);
2799 <        assertTrue(r.ran);
2800 <    }
2569 >        r.assertValue(v1);
2570 >    }}
2571  
2572      /**
2573       * thenCompose result completes exceptionally after exceptional
2574       * completion of source
2575       */
2576 <    public void testThenCompose2() {
2577 <        CompletableFuture<Integer> f, g;
2578 <        CompletableFutureInc r;
2579 <
2580 <        f = new CompletableFuture<>();
2581 <        g = f.thenCompose(r = new CompletableFutureInc());
2582 <        f.completeExceptionally(new CFException());
2583 <        checkCompletedWithWrappedCFException(g);
2576 >    public void testThenCompose_exceptionalCompletion() {
2577 >        for (ExecutionMode m : ExecutionMode.values())
2578 >        for (boolean createIncomplete : new boolean[] { true, false })
2579 >    {
2580 >        final CFException ex = new CFException();
2581 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2582 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2583 >        if (!createIncomplete) f.completeExceptionally(ex);
2584 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2585 >        if (createIncomplete) f.completeExceptionally(ex);
2586  
2587 <        f = new CompletableFuture<>();
2588 <        f.completeExceptionally(new CFException());
2589 <        g = f.thenCompose(r = new CompletableFutureInc());
2590 <        checkCompletedWithWrappedCFException(g);
2819 <    }
2587 >        checkCompletedWithWrappedException(g, ex);
2588 >        checkCompletedExceptionally(f, ex);
2589 >        r.assertNotInvoked();
2590 >    }}
2591  
2592      /**
2593       * thenCompose result completes exceptionally if action does
2594       */
2595 <    public void testThenCompose3() {
2596 <        CompletableFuture<Integer> f, g;
2597 <        FailingCompletableFutureFunction r;
2598 <
2599 <        f = new CompletableFuture<>();
2600 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2601 <        f.complete(one);
2602 <        checkCompletedWithWrappedCFException(g);
2595 >    public void testThenCompose_actionFailed() {
2596 >        for (ExecutionMode m : ExecutionMode.values())
2597 >        for (boolean createIncomplete : new boolean[] { true, false })
2598 >        for (Integer v1 : new Integer[] { 1, null })
2599 >    {
2600 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2601 >        final FailingCompletableFutureFunction r
2602 >            = new FailingCompletableFutureFunction(m);
2603 >        if (!createIncomplete) f.complete(v1);
2604 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2605 >        if (createIncomplete) f.complete(v1);
2606  
2833        f = new CompletableFuture<>();
2834        f.complete(one);
2835        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2607          checkCompletedWithWrappedCFException(g);
2608 <    }
2608 >        checkCompletedNormally(f, v1);
2609 >    }}
2610  
2611      /**
2612       * thenCompose result completes exceptionally if source cancelled
2613       */
2614 <    public void testThenCompose4() {
2615 <        CompletableFuture<Integer> f, g;
2616 <        CompletableFutureInc r;
2617 <
2618 <        f = new CompletableFuture<>();
2619 <        g = f.thenCompose(r = new CompletableFutureInc());
2620 <        assertTrue(f.cancel(true));
2621 <        checkCompletedWithWrappedCancellationException(g);
2622 <
2623 <        f = new CompletableFuture<>();
2624 <        assertTrue(f.cancel(true));
2625 <        g = f.thenCompose(r = new CompletableFutureInc());
2626 <        checkCompletedWithWrappedCancellationException(g);
2855 <    }
2856 <
2857 <    // asyncs
2858 <
2859 <    /**
2860 <     * thenRunAsync result completes normally after normal completion of source
2861 <     */
2862 <    public void testThenRunAsync() {
2863 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2864 <        Noop r = new Noop();
2865 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2866 <        f.complete(null);
2867 <        checkCompletedNormally(g, null);
2868 <
2869 <        // reordered version
2870 <        f = new CompletableFuture<>();
2871 <        f.complete(null);
2872 <        r = new Noop();
2873 <        g = f.thenRunAsync(r);
2874 <        checkCompletedNormally(g, null);
2875 <    }
2876 <
2877 <    /**
2878 <     * thenRunAsync result completes exceptionally after exceptional
2879 <     * completion of source
2880 <     */
2881 <    public void testThenRunAsync2() {
2882 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2883 <        Noop r = new Noop();
2884 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2885 <        f.completeExceptionally(new CFException());
2886 <        try {
2887 <            g.join();
2888 <            shouldThrow();
2889 <        } catch (CompletionException success) {}
2890 <        checkCompletedWithWrappedCFException(g);
2891 <    }
2892 <
2893 <    /**
2894 <     * thenRunAsync result completes exceptionally if action does
2895 <     */
2896 <    public void testThenRunAsync3() {
2897 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2898 <        FailingNoop r = new FailingNoop();
2899 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2900 <        f.complete(null);
2901 <        checkCompletedWithWrappedCFException(g);
2902 <    }
2903 <
2904 <    /**
2905 <     * thenRunAsync result completes exceptionally if source cancelled
2906 <     */
2907 <    public void testThenRunAsync4() {
2908 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2909 <        Noop r = new Noop();
2910 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2911 <        assertTrue(f.cancel(true));
2912 <        checkCompletedWithWrappedCancellationException(g);
2913 <    }
2914 <
2915 <    /**
2916 <     * thenApplyAsync result completes normally after normal completion of source
2917 <     */
2918 <    public void testThenApplyAsync() {
2919 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2920 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2921 <        f.complete(one);
2922 <        checkCompletedNormally(g, two);
2923 <    }
2924 <
2925 <    /**
2926 <     * thenApplyAsync result completes exceptionally after exceptional
2927 <     * completion of source
2928 <     */
2929 <    public void testThenApplyAsync2() {
2930 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2931 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2932 <        f.completeExceptionally(new CFException());
2933 <        checkCompletedWithWrappedCFException(g);
2934 <    }
2935 <
2936 <    /**
2937 <     * thenApplyAsync result completes exceptionally if action does
2938 <     */
2939 <    public void testThenApplyAsync3() {
2940 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2941 <        FailingFunction r = new FailingFunction();
2942 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
2943 <        f.complete(null);
2944 <        checkCompletedWithWrappedCFException(g);
2945 <    }
2946 <
2947 <    /**
2948 <     * thenApplyAsync result completes exceptionally if source cancelled
2949 <     */
2950 <    public void testThenApplyAsync4() {
2951 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2952 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2953 <        assertTrue(f.cancel(true));
2954 <        checkCompletedWithWrappedCancellationException(g);
2955 <    }
2956 <
2957 <    /**
2958 <     * thenAcceptAsync result completes normally after normal
2959 <     * completion of source
2960 <     */
2961 <    public void testThenAcceptAsync() {
2962 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2963 <        IncAction r = new IncAction();
2964 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2965 <        f.complete(one);
2966 <        checkCompletedNormally(g, null);
2967 <        assertEquals(r.value, (Integer) 2);
2968 <    }
2969 <
2970 <    /**
2971 <     * thenAcceptAsync result completes exceptionally after exceptional
2972 <     * completion of source
2973 <     */
2974 <    public void testThenAcceptAsync2() {
2975 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2976 <        IncAction r = new IncAction();
2977 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2978 <        f.completeExceptionally(new CFException());
2979 <        checkCompletedWithWrappedCFException(g);
2980 <    }
2981 <
2982 <    /**
2983 <     * thenAcceptAsync result completes exceptionally if action does
2984 <     */
2985 <    public void testThenAcceptAsync3() {
2986 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2987 <        FailingConsumer r = new FailingConsumer();
2988 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2989 <        f.complete(null);
2990 <        checkCompletedWithWrappedCFException(g);
2991 <    }
2992 <
2993 <    /**
2994 <     * thenAcceptAsync result completes exceptionally if source cancelled
2995 <     */
2996 <    public void testThenAcceptAsync4() {
2997 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2998 <        IncAction r = new IncAction();
2999 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
3000 <        assertTrue(f.cancel(true));
3001 <        checkCompletedWithWrappedCancellationException(g);
3002 <    }
3003 <
3004 <    /**
3005 <     * thenComposeAsync result completes normally after normal
3006 <     * completion of source
3007 <     */
3008 <    public void testThenComposeAsync() {
3009 <        CompletableFuture<Integer> f, g;
3010 <        CompletableFutureInc r;
3011 <
3012 <        f = new CompletableFuture<>();
3013 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3014 <        f.complete(one);
3015 <        checkCompletedNormally(g, two);
3016 <
3017 <        f = new CompletableFuture<>();
3018 <        f.complete(one);
3019 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3020 <        checkCompletedNormally(g, two);
3021 <    }
3022 <
3023 <    /**
3024 <     * thenComposeAsync result completes exceptionally after
3025 <     * exceptional completion of source
3026 <     */
3027 <    public void testThenComposeAsync2() {
3028 <        CompletableFuture<Integer> f, g;
3029 <        CompletableFutureInc r;
3030 <
3031 <        f = new CompletableFuture<>();
3032 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3033 <        f.completeExceptionally(new CFException());
3034 <        checkCompletedWithWrappedCFException(g);
3035 <        assertFalse(r.ran);
3036 <
3037 <        f = new CompletableFuture<>();
3038 <        f.completeExceptionally(new CFException());
3039 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3040 <        checkCompletedWithWrappedCFException(g);
3041 <        assertFalse(r.ran);
3042 <    }
3043 <
3044 <    /**
3045 <     * thenComposeAsync result completes exceptionally if action does
3046 <     */
3047 <    public void testThenComposeAsync3() {
3048 <        CompletableFuture<Integer> f, g;
3049 <        FailingCompletableFutureFunction r;
3050 <
3051 <        f = new CompletableFuture<>();
3052 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
3053 <        f.complete(one);
3054 <        checkCompletedWithWrappedCFException(g);
3055 <
3056 <        f = new CompletableFuture<>();
3057 <        f.complete(one);
3058 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
3059 <        checkCompletedWithWrappedCFException(g);
3060 <    }
3061 <
3062 <    /**
3063 <     * thenComposeAsync result completes exceptionally if source cancelled
3064 <     */
3065 <    public void testThenComposeAsync4() {
3066 <        CompletableFuture<Integer> f, g;
3067 <        CompletableFutureInc r;
3068 <
3069 <        f = new CompletableFuture<>();
3070 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3071 <        assertTrue(f.cancel(true));
3072 <        checkCompletedWithWrappedCancellationException(g);
3073 <
3074 <        f = new CompletableFuture<>();
3075 <        assertTrue(f.cancel(true));
3076 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3077 <        checkCompletedWithWrappedCancellationException(g);
3078 <    }
3079 <
3080 <    // async with explicit executors
3081 <
3082 <    /**
3083 <     * thenRunAsync result completes normally after normal completion of source
3084 <     */
3085 <    public void testThenRunAsyncE() {
3086 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3087 <        Noop r = new Noop();
3088 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3089 <        f.complete(null);
3090 <        checkCompletedNormally(g, null);
3091 <
3092 <        // reordered version
3093 <        f = new CompletableFuture<>();
3094 <        f.complete(null);
3095 <        r = new Noop();
3096 <        g = f.thenRunAsync(r, new ThreadExecutor());
3097 <        checkCompletedNormally(g, null);
3098 <    }
3099 <
3100 <    /**
3101 <     * thenRunAsync result completes exceptionally after exceptional
3102 <     * completion of source
3103 <     */
3104 <    public void testThenRunAsync2E() {
3105 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3106 <        Noop r = new Noop();
3107 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3108 <        f.completeExceptionally(new CFException());
3109 <        try {
3110 <            g.join();
3111 <            shouldThrow();
3112 <        } catch (CompletionException success) {}
3113 <        checkCompletedWithWrappedCFException(g);
3114 <    }
3115 <
3116 <    /**
3117 <     * thenRunAsync result completes exceptionally if action does
3118 <     */
3119 <    public void testThenRunAsync3E() {
3120 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3121 <        FailingNoop r = new FailingNoop();
3122 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3123 <        f.complete(null);
3124 <        checkCompletedWithWrappedCFException(g);
3125 <    }
3126 <
3127 <    /**
3128 <     * thenRunAsync result completes exceptionally if source cancelled
3129 <     */
3130 <    public void testThenRunAsync4E() {
3131 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3132 <        Noop r = new Noop();
3133 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3134 <        assertTrue(f.cancel(true));
3135 <        checkCompletedWithWrappedCancellationException(g);
3136 <    }
3137 <
3138 <    /**
3139 <     * thenApplyAsync result completes normally after normal completion of source
3140 <     */
3141 <    public void testThenApplyAsyncE() {
3142 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3143 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3144 <        f.complete(one);
3145 <        checkCompletedNormally(g, two);
3146 <    }
3147 <
3148 <    /**
3149 <     * thenApplyAsync result completes exceptionally after exceptional
3150 <     * completion of source
3151 <     */
3152 <    public void testThenApplyAsync2E() {
3153 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3154 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3155 <        f.completeExceptionally(new CFException());
3156 <        checkCompletedWithWrappedCFException(g);
3157 <    }
3158 <
3159 <    /**
3160 <     * thenApplyAsync result completes exceptionally if action does
3161 <     */
3162 <    public void testThenApplyAsync3E() {
3163 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3164 <        FailingFunction r = new FailingFunction();
3165 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
3166 <        f.complete(null);
3167 <        checkCompletedWithWrappedCFException(g);
3168 <    }
3169 <
3170 <    /**
3171 <     * thenApplyAsync result completes exceptionally if source cancelled
3172 <     */
3173 <    public void testThenApplyAsync4E() {
3174 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3175 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3176 <        assertTrue(f.cancel(true));
3177 <        checkCompletedWithWrappedCancellationException(g);
3178 <    }
3179 <
3180 <    /**
3181 <     * thenAcceptAsync result completes normally after normal
3182 <     * completion of source
3183 <     */
3184 <    public void testThenAcceptAsyncE() {
3185 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3186 <        IncAction r = new IncAction();
3187 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3188 <        f.complete(one);
3189 <        checkCompletedNormally(g, null);
3190 <        assertEquals(r.value, (Integer) 2);
3191 <    }
3192 <
3193 <    /**
3194 <     * thenAcceptAsync result completes exceptionally after exceptional
3195 <     * completion of source
3196 <     */
3197 <    public void testThenAcceptAsync2E() {
3198 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3199 <        IncAction r = new IncAction();
3200 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3201 <        f.completeExceptionally(new CFException());
3202 <        checkCompletedWithWrappedCFException(g);
3203 <    }
3204 <
3205 <    /**
3206 <     * thenAcceptAsync result completes exceptionally if action does
3207 <     */
3208 <    public void testThenAcceptAsync3E() {
3209 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3210 <        FailingConsumer r = new FailingConsumer();
3211 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3212 <        f.complete(null);
3213 <        checkCompletedWithWrappedCFException(g);
3214 <    }
3215 <
3216 <    /**
3217 <     * thenAcceptAsync result completes exceptionally if source cancelled
3218 <     */
3219 <    public void testThenAcceptAsync4E() {
3220 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3221 <        IncAction r = new IncAction();
3222 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3223 <        assertTrue(f.cancel(true));
3224 <        checkCompletedWithWrappedCancellationException(g);
3225 <    }
3226 <
3227 <    /**
3228 <     * thenComposeAsync result completes normally after normal
3229 <     * completion of source
3230 <     */
3231 <    public void testThenComposeAsyncE() {
3232 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3233 <        CompletableFutureInc r = new CompletableFutureInc();
3234 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3235 <        f.complete(one);
3236 <        checkCompletedNormally(g, two);
3237 <    }
3238 <
3239 <    /**
3240 <     * thenComposeAsync result completes exceptionally after
3241 <     * exceptional completion of source
3242 <     */
3243 <    public void testThenComposeAsync2E() {
3244 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3245 <        CompletableFutureInc r = new CompletableFutureInc();
3246 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3247 <        f.completeExceptionally(new CFException());
3248 <        checkCompletedWithWrappedCFException(g);
3249 <    }
3250 <
3251 <    /**
3252 <     * thenComposeAsync result completes exceptionally if action does
3253 <     */
3254 <    public void testThenComposeAsync3E() {
3255 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3256 <        FailingCompletableFutureFunction r = new FailingCompletableFutureFunction();
3257 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3258 <        f.complete(one);
3259 <        checkCompletedWithWrappedCFException(g);
3260 <    }
2614 >    public void testThenCompose_sourceCancelled() {
2615 >        for (ExecutionMode m : ExecutionMode.values())
2616 >        for (boolean createIncomplete : new boolean[] { true, false })
2617 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2618 >    {
2619 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2620 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2621 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2622 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2623 >        if (createIncomplete) {
2624 >            checkIncomplete(g);
2625 >            assertTrue(f.cancel(mayInterruptIfRunning));
2626 >        }
2627  
3262    /**
3263     * thenComposeAsync result completes exceptionally if source cancelled
3264     */
3265    public void testThenComposeAsync4E() {
3266        CompletableFuture<Integer> f = new CompletableFuture<>();
3267        CompletableFutureInc r = new CompletableFutureInc();
3268        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3269        assertTrue(f.cancel(true));
2628          checkCompletedWithWrappedCancellationException(g);
2629 <    }
2629 >        checkCancelled(f);
2630 >    }}
2631  
2632      // other static methods
2633  
# Line 3287 | Line 2646 | public class CompletableFutureTest exten
2646       */
2647      public void testAllOf_normal() throws Exception {
2648          for (int k = 1; k < 20; ++k) {
2649 <            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2649 >            CompletableFuture<Integer>[] fs
2650 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2651              for (int i = 0; i < k; ++i)
2652                  fs[i] = new CompletableFuture<>();
2653              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
# Line 3301 | Line 2661 | public class CompletableFutureTest exten
2661          }
2662      }
2663  
2664 +    public void testAllOf_backwards() throws Exception {
2665 +        for (int k = 1; k < 20; ++k) {
2666 +            CompletableFuture<Integer>[] fs
2667 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2668 +            for (int i = 0; i < k; ++i)
2669 +                fs[i] = new CompletableFuture<>();
2670 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
2671 +            for (int i = k - 1; i >= 0; i--) {
2672 +                checkIncomplete(f);
2673 +                checkIncomplete(CompletableFuture.allOf(fs));
2674 +                fs[i].complete(one);
2675 +            }
2676 +            checkCompletedNormally(f, null);
2677 +            checkCompletedNormally(CompletableFuture.allOf(fs), null);
2678 +        }
2679 +    }
2680 +
2681      /**
2682       * anyOf(no component futures) returns an incomplete future
2683       */
# Line 3359 | Line 2736 | public class CompletableFutureTest exten
2736          Runnable[] throwingActions = {
2737              () -> CompletableFuture.supplyAsync(null),
2738              () -> CompletableFuture.supplyAsync(null, exec),
2739 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
2739 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
2740  
2741              () -> CompletableFuture.runAsync(null),
2742              () -> CompletableFuture.runAsync(null, exec),
# Line 3432 | Line 2809 | public class CompletableFutureTest exten
2809  
2810              () -> f.thenCompose(null),
2811              () -> f.thenComposeAsync(null),
2812 <            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
2812 >            () -> f.thenComposeAsync(new CompletableFutureInc(ExecutionMode.EXECUTOR), null),
2813              () -> f.thenComposeAsync(null, exec),
2814  
2815              () -> f.exceptionally(null),
# Line 3468 | Line 2845 | public class CompletableFutureTest exten
2845       * whenComplete action executes on normal completion, propagating
2846       * source result.
2847       */
2848 <    public void testWhenComplete1() {
2849 <        final AtomicInteger a = new AtomicInteger();
2850 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2851 <        CompletableFuture<Integer> g =
2852 <            f.whenComplete((Integer x, Throwable t) -> a.getAndIncrement());
2853 <        f.complete(three);
2854 <        checkCompletedNormally(f, three);
2855 <        checkCompletedNormally(g, three);
2856 <        assertEquals(a.get(), 1);
2857 <    }
2848 >    public void testWhenComplete_normalCompletion1() {
2849 >        for (ExecutionMode m : ExecutionMode.values())
2850 >        for (boolean createIncomplete : new boolean[] { true, false })
2851 >        for (Integer v1 : new Integer[] { 1, null })
2852 >    {
2853 >        final AtomicInteger a = new AtomicInteger(0);
2854 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2855 >        if (!createIncomplete) f.complete(v1);
2856 >        final CompletableFuture<Integer> g = m.whenComplete
2857 >            (f,
2858 >             (Integer x, Throwable t) -> {
2859 >                m.checkExecutionMode();
2860 >                threadAssertSame(x, v1);
2861 >                threadAssertNull(t);
2862 >                a.getAndIncrement();
2863 >            });
2864 >        if (createIncomplete) f.complete(v1);
2865 >
2866 >        checkCompletedNormally(g, v1);
2867 >        checkCompletedNormally(f, v1);
2868 >        assertEquals(1, a.get());
2869 >    }}
2870  
2871      /**
2872       * whenComplete action executes on exceptional completion, propagating
2873       * source result.
2874       */
2875 <    public void testWhenComplete2() {
2876 <        final AtomicInteger a = new AtomicInteger();
2877 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2878 <        CompletableFuture<Integer> g =
2879 <            f.whenComplete((Integer x, Throwable t) -> a.getAndIncrement());
2880 <        f.completeExceptionally(new CFException());
2881 <        assertTrue(f.isCompletedExceptionally());
2882 <        assertTrue(g.isCompletedExceptionally());
2883 <        assertEquals(a.get(), 1);
2884 <    }
2875 >    public void testWhenComplete_exceptionalCompletion() {
2876 >        for (ExecutionMode m : ExecutionMode.values())
2877 >        for (boolean createIncomplete : new boolean[] { true, false })
2878 >        for (Integer v1 : new Integer[] { 1, null })
2879 >    {
2880 >        final AtomicInteger a = new AtomicInteger(0);
2881 >        final CFException ex = new CFException();
2882 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2883 >        if (!createIncomplete) f.completeExceptionally(ex);
2884 >        final CompletableFuture<Integer> g = m.whenComplete
2885 >            (f,
2886 >             (Integer x, Throwable t) -> {
2887 >                m.checkExecutionMode();
2888 >                threadAssertNull(x);
2889 >                threadAssertSame(t, ex);
2890 >                a.getAndIncrement();
2891 >            });
2892 >        if (createIncomplete) f.completeExceptionally(ex);
2893 >        checkCompletedExceptionally(f, ex);
2894 >        checkCompletedWithWrappedException(g, ex);
2895 >        assertEquals(1, a.get());
2896 >    }}
2897 >
2898 >    /**
2899 >     * whenComplete action executes on cancelled source, propagating
2900 >     * CancellationException.
2901 >     */
2902 >    public void testWhenComplete_sourceCancelled() {
2903 >        for (ExecutionMode m : ExecutionMode.values())
2904 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2905 >        for (boolean createIncomplete : new boolean[] { true, false })
2906 >    {
2907 >        final AtomicInteger a = new AtomicInteger(0);
2908 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2909 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2910 >        final CompletableFuture<Integer> g = m.whenComplete
2911 >            (f,
2912 >             (Integer x, Throwable t) -> {
2913 >                m.checkExecutionMode();
2914 >                threadAssertNull(x);
2915 >                threadAssertTrue(t instanceof CancellationException);
2916 >                a.getAndIncrement();
2917 >            });
2918 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2919 >
2920 >        checkCompletedWithWrappedCancellationException(g);
2921 >        checkCancelled(f);
2922 >        assertEquals(1, a.get());
2923 >    }}
2924  
2925      /**
2926       * If a whenComplete action throws an exception when triggered by
2927       * a normal completion, it completes exceptionally
2928       */
2929 <    public void testWhenComplete3() {
2930 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2931 <        CompletableFuture<Integer> g =
2932 <            f.whenComplete((Integer x, Throwable t) ->
2933 <                           { throw new CFException(); } );
2934 <        f.complete(three);
2935 <        checkCompletedNormally(f, three);
2936 <        assertTrue(g.isCompletedExceptionally());
2937 <        checkCompletedWithWrappedCFException(g);
2938 <    }
2939 <
2940 <    /**
2941 <     * whenCompleteAsync action executes on normal completion, propagating
2942 <     * source result.
2943 <     */
2944 <    public void testWhenCompleteAsync1() {
2945 <        final AtomicInteger a = new AtomicInteger();
2946 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2947 <        CompletableFuture<Integer> g =
2948 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement());
2949 <        f.complete(three);
2950 <        checkCompletedNormally(f, three);
2951 <        checkCompletedNormally(g, three);
3524 <        assertEquals(a.get(), 1);
3525 <    }
3526 <
3527 <    /**
3528 <     * whenCompleteAsync action executes on exceptional completion, propagating
3529 <     * source result.
3530 <     */
3531 <    public void testWhenCompleteAsync2() {
3532 <        final AtomicInteger a = new AtomicInteger();
3533 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3534 <        CompletableFuture<Integer> g =
3535 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement());
3536 <        f.completeExceptionally(new CFException());
3537 <        checkCompletedWithWrappedCFException(f);
3538 <        checkCompletedWithWrappedCFException(g);
3539 <    }
3540 <
3541 <    /**
3542 <     * If a whenCompleteAsync action throws an exception when
3543 <     * triggered by a normal completion, it completes exceptionally
3544 <     */
3545 <    public void testWhenCompleteAsync3() {
3546 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3547 <        CompletableFuture<Integer> g =
3548 <            f.whenCompleteAsync((Integer x, Throwable t) ->
3549 <                           { throw new CFException(); } );
3550 <        f.complete(three);
3551 <        checkCompletedNormally(f, three);
3552 <        checkCompletedWithWrappedCFException(g);
3553 <    }
3554 <
3555 <    /**
3556 <     * whenCompleteAsync action executes on normal completion, propagating
3557 <     * source result.
3558 <     */
3559 <    public void testWhenCompleteAsync1e() {
3560 <        final AtomicInteger a = new AtomicInteger();
3561 <        ThreadExecutor exec = new ThreadExecutor();
3562 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3563 <        CompletableFuture<Integer> g =
3564 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement(),
3565 <                                exec);
3566 <        f.complete(three);
3567 <        checkCompletedNormally(f, three);
3568 <        checkCompletedNormally(g, three);
3569 <        assertEquals(a.get(), 1);
3570 <    }
3571 <
3572 <    /**
3573 <     * whenCompleteAsync action executes on exceptional completion, propagating
3574 <     * source result.
3575 <     */
3576 <    public void testWhenCompleteAsync2e() {
3577 <        final AtomicInteger a = new AtomicInteger();
3578 <        ThreadExecutor exec = new ThreadExecutor();
3579 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3580 <        CompletableFuture<Integer> g =
3581 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement(),
3582 <                                exec);
3583 <        f.completeExceptionally(new CFException());
3584 <        checkCompletedWithWrappedCFException(f);
3585 <        checkCompletedWithWrappedCFException(g);
3586 <    }
3587 <
3588 <    /**
3589 <     * If a whenCompleteAsync action throws an exception when triggered
3590 <     * by a normal completion, it completes exceptionally
3591 <     */
3592 <    public void testWhenCompleteAsync3e() {
3593 <        ThreadExecutor exec = new ThreadExecutor();
3594 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3595 <        CompletableFuture<Integer> g =
3596 <            f.whenCompleteAsync((Integer x, Throwable t) ->
3597 <                                { throw new CFException(); },
3598 <                                exec);
3599 <        f.complete(three);
3600 <        checkCompletedNormally(f, three);
3601 <        checkCompletedWithWrappedCFException(g);
3602 <    }
3603 <
3604 <    /**
3605 <     * handleAsync action completes normally with function value on
3606 <     * either normal or exceptional completion of source
3607 <     */
3608 <    public void testHandleAsync() {
3609 <        CompletableFuture<Integer> f, g;
3610 <        IntegerHandler r;
3611 <
3612 <        f = new CompletableFuture<>();
3613 <        g = f.handleAsync(r = new IntegerHandler());
3614 <        assertFalse(r.ran);
3615 <        f.completeExceptionally(new CFException());
3616 <        checkCompletedWithWrappedCFException(f);
3617 <        checkCompletedNormally(g, three);
3618 <        assertTrue(r.ran);
3619 <
3620 <        f = new CompletableFuture<>();
3621 <        g = f.handleAsync(r = new IntegerHandler());
3622 <        assertFalse(r.ran);
3623 <        f.completeExceptionally(new CFException());
3624 <        checkCompletedWithWrappedCFException(f);
3625 <        checkCompletedNormally(g, three);
3626 <        assertTrue(r.ran);
3627 <
3628 <        f = new CompletableFuture<>();
3629 <        g = f.handleAsync(r = new IntegerHandler());
3630 <        assertFalse(r.ran);
3631 <        f.complete(one);
3632 <        checkCompletedNormally(f, one);
3633 <        checkCompletedNormally(g, two);
3634 <        assertTrue(r.ran);
3635 <
3636 <        f = new CompletableFuture<>();
3637 <        g = f.handleAsync(r = new IntegerHandler());
3638 <        assertFalse(r.ran);
3639 <        f.complete(one);
3640 <        checkCompletedNormally(f, one);
3641 <        checkCompletedNormally(g, two);
3642 <        assertTrue(r.ran);
3643 <    }
2929 >    public void testWhenComplete_actionFailed() {
2930 >        for (boolean createIncomplete : new boolean[] { true, false })
2931 >        for (ExecutionMode m : ExecutionMode.values())
2932 >        for (Integer v1 : new Integer[] { 1, null })
2933 >    {
2934 >        final AtomicInteger a = new AtomicInteger(0);
2935 >        final CFException ex = new CFException();
2936 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2937 >        if (!createIncomplete) f.complete(v1);
2938 >        final CompletableFuture<Integer> g = m.whenComplete
2939 >            (f,
2940 >             (Integer x, Throwable t) -> {
2941 >                m.checkExecutionMode();
2942 >                threadAssertSame(x, v1);
2943 >                threadAssertNull(t);
2944 >                a.getAndIncrement();
2945 >                throw ex;
2946 >            });
2947 >        if (createIncomplete) f.complete(v1);
2948 >        checkCompletedNormally(f, v1);
2949 >        checkCompletedWithWrappedException(g, ex);
2950 >        assertEquals(1, a.get());
2951 >    }}
2952  
2953      /**
2954 <     * handleAsync action with Executor completes normally with
2955 <     * function value on either normal or exceptional completion of
2956 <     * source
2954 >     * If a whenComplete action throws an exception when triggered by
2955 >     * a source completion that also throws an exception, the source
2956 >     * exception takes precedence.
2957       */
2958 <    public void testHandleAsync2() {
2959 <        CompletableFuture<Integer> f, g;
2960 <        ThreadExecutor exec = new ThreadExecutor();
2961 <        IntegerHandler r;
2962 <
2963 <        f = new CompletableFuture<>();
2964 <        g = f.handleAsync(r = new IntegerHandler(), exec);
2965 <        assertFalse(r.ran);
2966 <        f.completeExceptionally(new CFException());
2967 <        checkCompletedWithWrappedCFException(f);
2968 <        checkCompletedNormally(g, three);
2969 <        assertTrue(r.ran);
2970 <
2971 <        f = new CompletableFuture<>();
2972 <        g = f.handleAsync(r = new IntegerHandler(), exec);
2973 <        assertFalse(r.ran);
2974 <        f.completeExceptionally(new CFException());
2975 <        checkCompletedWithWrappedCFException(f);
2976 <        checkCompletedNormally(g, three);
2977 <        assertTrue(r.ran);
2978 <
2979 <        f = new CompletableFuture<>();
2980 <        g = f.handleAsync(r = new IntegerHandler(), exec);
2981 <        assertFalse(r.ran);
2982 <        f.complete(one);
2983 <        checkCompletedNormally(f, one);
3676 <        checkCompletedNormally(g, two);
3677 <        assertTrue(r.ran);
3678 <
3679 <        f = new CompletableFuture<>();
3680 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3681 <        assertFalse(r.ran);
3682 <        f.complete(one);
3683 <        checkCompletedNormally(f, one);
3684 <        checkCompletedNormally(g, two);
3685 <        assertTrue(r.ran);
3686 <    }
2958 >    public void testWhenComplete_actionFailedSourceFailed() {
2959 >        for (boolean createIncomplete : new boolean[] { true, false })
2960 >        for (ExecutionMode m : ExecutionMode.values())
2961 >        for (Integer v1 : new Integer[] { 1, null })
2962 >    {
2963 >        final AtomicInteger a = new AtomicInteger(0);
2964 >        final CFException ex1 = new CFException();
2965 >        final CFException ex2 = new CFException();
2966 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2967 >
2968 >        if (!createIncomplete) f.completeExceptionally(ex1);
2969 >        final CompletableFuture<Integer> g = m.whenComplete
2970 >            (f,
2971 >             (Integer x, Throwable t) -> {
2972 >                m.checkExecutionMode();
2973 >                threadAssertSame(t, ex1);
2974 >                threadAssertNull(x);
2975 >                a.getAndIncrement();
2976 >                throw ex2;
2977 >            });
2978 >        if (createIncomplete) f.completeExceptionally(ex1);
2979 >
2980 >        checkCompletedExceptionally(f, ex1);
2981 >        checkCompletedWithWrappedException(g, ex1);
2982 >        assertEquals(1, a.get());
2983 >    }}
2984  
2985   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines