ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.117 by jsr166, Sat Sep 5 15:35:47 2015 UTC vs.
Revision 1.133 by jsr166, Sun Nov 15 19:39:25 2015 UTC

# Line 7 | Line 7
7  
8   import static java.util.concurrent.TimeUnit.MILLISECONDS;
9   import static java.util.concurrent.TimeUnit.SECONDS;
10 + import static java.util.concurrent.CompletableFuture.completedFuture;
11 + import static java.util.concurrent.CompletableFuture.failedFuture;
12 +
13 + import java.lang.reflect.Method;
14 + import java.lang.reflect.Modifier;
15 +
16 + import java.util.stream.Collectors;
17 + import java.util.stream.Stream;
18  
19   import java.util.ArrayList;
20 + import java.util.Arrays;
21   import java.util.List;
22   import java.util.Objects;
23 + import java.util.Set;
24   import java.util.concurrent.Callable;
25   import java.util.concurrent.CancellationException;
26   import java.util.concurrent.CompletableFuture;
# Line 28 | Line 38 | import java.util.function.BiConsumer;
38   import java.util.function.BiFunction;
39   import java.util.function.Consumer;
40   import java.util.function.Function;
41 + import java.util.function.Predicate;
42   import java.util.function.Supplier;
43  
44 + import junit.framework.AssertionFailedError;
45   import junit.framework.Test;
46   import junit.framework.TestSuite;
47  
# Line 77 | Line 89 | public class CompletableFutureTest exten
89          assertTrue(f.toString().contains("[Completed normally]"));
90      }
91  
92 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f) {
93 <        long startTime = System.nanoTime();
94 <        long timeoutMillis = LONG_DELAY_MS;
95 <        try {
96 <            f.get(timeoutMillis, MILLISECONDS);
97 <            shouldThrow();
98 <        } catch (ExecutionException success) {
99 <            assertTrue(success.getCause() instanceof CFException);
100 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
101 <        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
102 <
103 <        try {
104 <            f.join();
105 <            shouldThrow();
106 <        } catch (CompletionException success) {
107 <            assertTrue(success.getCause() instanceof CFException);
108 <        }
97 <        try {
98 <            f.getNow(null);
99 <            shouldThrow();
100 <        } catch (CompletionException success) {
101 <            assertTrue(success.getCause() instanceof CFException);
92 >    /**
93 >     * Returns the "raw" internal exceptional completion of f,
94 >     * without any additional wrapping with CompletionException.
95 >     */
96 >    <U> Throwable exceptionalCompletion(CompletableFuture<U> f) {
97 >        // handle (and whenComplete) can distinguish between "direct"
98 >        // and "wrapped" exceptional completion
99 >        return f.handle((U u, Throwable t) -> t).join();
100 >    }
101 >
102 >    void checkCompletedExceptionally(CompletableFuture<?> f,
103 >                                     boolean wrapped,
104 >                                     Consumer<Throwable> checker) {
105 >        Throwable cause = exceptionalCompletion(f);
106 >        if (wrapped) {
107 >            assertTrue(cause instanceof CompletionException);
108 >            cause = cause.getCause();
109          }
110 <        try {
104 <            f.get();
105 <            shouldThrow();
106 <        } catch (ExecutionException success) {
107 <            assertTrue(success.getCause() instanceof CFException);
108 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
109 <        assertTrue(f.isDone());
110 <        assertFalse(f.isCancelled());
111 <        assertTrue(f.toString().contains("[Completed exceptionally]"));
112 <    }
110 >        checker.accept(cause);
111  
114    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
115                                                      Throwable ex) {
112          long startTime = System.nanoTime();
117        long timeoutMillis = LONG_DELAY_MS;
113          try {
114 <            f.get(timeoutMillis, MILLISECONDS);
114 >            f.get(LONG_DELAY_MS, MILLISECONDS);
115              shouldThrow();
116          } catch (ExecutionException success) {
117 <            assertSame(ex, success.getCause());
117 >            assertSame(cause, success.getCause());
118          } catch (Throwable fail) { threadUnexpectedException(fail); }
119 <        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
119 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
120  
121          try {
122              f.join();
123              shouldThrow();
124          } catch (CompletionException success) {
125 <            assertSame(ex, success.getCause());
126 <        }
125 >            assertSame(cause, success.getCause());
126 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
127 >
128          try {
129              f.getNow(null);
130              shouldThrow();
131          } catch (CompletionException success) {
132 <            assertSame(ex, success.getCause());
133 <        }
132 >            assertSame(cause, success.getCause());
133 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
134 >
135          try {
136              f.get();
137              shouldThrow();
138          } catch (ExecutionException success) {
139 <            assertSame(ex, success.getCause());
139 >            assertSame(cause, success.getCause());
140          } catch (Throwable fail) { threadUnexpectedException(fail); }
141  
145        assertTrue(f.isDone());
142          assertFalse(f.isCancelled());
143 +        assertTrue(f.isDone());
144 +        assertTrue(f.isCompletedExceptionally());
145          assertTrue(f.toString().contains("[Completed exceptionally]"));
146      }
147  
148 <    <U> void checkCompletedExceptionallyWithTimeout(CompletableFuture<U> f) {
149 <        long startTime = System.nanoTime();
150 <        long timeoutMillis = LONG_DELAY_MS;
151 <        try {
154 <            f.get(timeoutMillis, MILLISECONDS);
155 <            shouldThrow();
156 <        } catch (ExecutionException ex) {
157 <            assertTrue(ex.getCause() instanceof TimeoutException);
158 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
159 <        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
160 <
161 <        try {
162 <            f.join();
163 <            shouldThrow();
164 <        } catch (Throwable ex) {
165 <            assertTrue(ex.getCause() instanceof TimeoutException);
166 <        }
167 <
168 <        try {
169 <            f.getNow(null);
170 <            shouldThrow();
171 <        } catch (Throwable ex) {
172 <            assertTrue(ex.getCause() instanceof TimeoutException);
173 <        }
148 >    void checkCompletedWithWrappedCFException(CompletableFuture<?> f) {
149 >        checkCompletedExceptionally(f, true,
150 >            (t) -> assertTrue(t instanceof CFException));
151 >    }
152  
153 <        try {
154 <            f.get();
155 <            shouldThrow();
156 <        } catch (ExecutionException ex) {
179 <            assertTrue(ex.getCause() instanceof TimeoutException);
180 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
153 >    void checkCompletedWithWrappedCancellationException(CompletableFuture<?> f) {
154 >        checkCompletedExceptionally(f, true,
155 >            (t) -> assertTrue(t instanceof CancellationException));
156 >    }
157  
158 <        assertTrue(f.isDone());
159 <        assertFalse(f.isCancelled());
160 <        assertTrue(f.toString().contains("[Completed exceptionally]"));
158 >    void checkCompletedWithTimeoutException(CompletableFuture<?> f) {
159 >        checkCompletedExceptionally(f, false,
160 >            (t) -> assertTrue(t instanceof TimeoutException));
161      }
162  
163 <    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
164 <                                                Throwable ex) {
165 <        checkCompletedExceptionallyWithRootCause(f, ex);
190 <        try {
191 <            CompletableFuture<Throwable> spy = f.handle
192 <                ((U u, Throwable t) -> t);
193 <            assertTrue(spy.join() instanceof CompletionException);
194 <            assertSame(ex, spy.join().getCause());
195 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
163 >    void checkCompletedWithWrappedException(CompletableFuture<?> f,
164 >                                            Throwable ex) {
165 >        checkCompletedExceptionally(f, true, (t) -> assertSame(t, ex));
166      }
167  
168 <    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
169 <        checkCompletedExceptionallyWithRootCause(f, ex);
200 <        try {
201 <            CompletableFuture<Throwable> spy = f.handle
202 <                ((U u, Throwable t) -> t);
203 <            assertSame(ex, spy.join());
204 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
168 >    void checkCompletedExceptionally(CompletableFuture<?> f, Throwable ex) {
169 >        checkCompletedExceptionally(f, false, (t) -> assertSame(t, ex));
170      }
171  
172      void checkCancelled(CompletableFuture<?> f) {
173          long startTime = System.nanoTime();
209        long timeoutMillis = LONG_DELAY_MS;
174          try {
175 <            f.get(timeoutMillis, MILLISECONDS);
175 >            f.get(LONG_DELAY_MS, MILLISECONDS);
176              shouldThrow();
177          } catch (CancellationException success) {
178          } catch (Throwable fail) { threadUnexpectedException(fail); }
179 <        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
179 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
180  
181          try {
182              f.join();
# Line 227 | Line 191 | public class CompletableFutureTest exten
191              shouldThrow();
192          } catch (CancellationException success) {
193          } catch (Throwable fail) { threadUnexpectedException(fail); }
230        assertTrue(f.isDone());
231        assertTrue(f.isCompletedExceptionally());
232        assertTrue(f.isCancelled());
233        assertTrue(f.toString().contains("[Completed exceptionally]"));
234    }
194  
195 <    void checkCompletedWithWrappedCancellationException(CompletableFuture<?> f) {
237 <        long startTime = System.nanoTime();
238 <        long timeoutMillis = LONG_DELAY_MS;
239 <        try {
240 <            f.get(timeoutMillis, MILLISECONDS);
241 <            shouldThrow();
242 <        } catch (ExecutionException success) {
243 <            assertTrue(success.getCause() instanceof CancellationException);
244 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
245 <        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
195 >        assertTrue(exceptionalCompletion(f) instanceof CancellationException);
196  
247        try {
248            f.join();
249            shouldThrow();
250        } catch (CompletionException success) {
251            assertTrue(success.getCause() instanceof CancellationException);
252        }
253        try {
254            f.getNow(null);
255            shouldThrow();
256        } catch (CompletionException success) {
257            assertTrue(success.getCause() instanceof CancellationException);
258        }
259        try {
260            f.get();
261            shouldThrow();
262        } catch (ExecutionException success) {
263            assertTrue(success.getCause() instanceof CancellationException);
264        } catch (Throwable fail) { threadUnexpectedException(fail); }
197          assertTrue(f.isDone());
266        assertFalse(f.isCancelled());
198          assertTrue(f.isCompletedExceptionally());
199 +        assertTrue(f.isCancelled());
200          assertTrue(f.toString().contains("[Completed exceptionally]"));
201      }
202  
# Line 908 | Line 840 | public class CompletableFutureTest exten
840          if (!createIncomplete) assertTrue(f.complete(v1));
841          final CompletableFuture<Integer> g = f.exceptionally
842              ((Throwable t) -> {
911                // Should not be called
843                  a.getAndIncrement();
844 <                throw new AssertionError();
844 >                threadFail("should not be called");
845 >                return null;            // unreached
846              });
847          if (createIncomplete) assertTrue(f.complete(v1));
848  
# Line 969 | Line 901 | public class CompletableFutureTest exten
901       * whenComplete action executes on normal completion, propagating
902       * source result.
903       */
904 <    public void testWhenComplete_normalCompletion1() {
904 >    public void testWhenComplete_normalCompletion() {
905          for (ExecutionMode m : ExecutionMode.values())
906          for (boolean createIncomplete : new boolean[] { true, false })
907          for (Integer v1 : new Integer[] { 1, null })
# Line 1050 | Line 982 | public class CompletableFutureTest exten
982       * If a whenComplete action throws an exception when triggered by
983       * a normal completion, it completes exceptionally
984       */
985 <    public void testWhenComplete_actionFailed() {
985 >    public void testWhenComplete_sourceCompletedNormallyActionFailed() {
986          for (boolean createIncomplete : new boolean[] { true, false })
987          for (ExecutionMode m : ExecutionMode.values())
988          for (Integer v1 : new Integer[] { 1, null })
# Line 1220 | Line 1152 | public class CompletableFutureTest exten
1152          assertEquals(1, a.get());
1153      }}
1154  
1155 +    /**
1156 +     * If a "handle action" throws an exception when triggered by
1157 +     * a normal completion, it completes exceptionally
1158 +     */
1159      public void testHandle_sourceCompletedNormallyActionFailed() {
1160          for (ExecutionMode m : ExecutionMode.values())
1161          for (boolean createIncomplete : new boolean[] { true, false })
# Line 3142 | Line 3078 | public class CompletableFutureTest exten
3078              for (int i = 0; i < k; i++) {
3079                  checkIncomplete(f);
3080                  checkIncomplete(CompletableFuture.allOf(fs));
3081 <                if (i != k/2) {
3081 >                if (i != k / 2) {
3082                      fs[i].complete(i);
3083                      checkCompletedNormally(fs[i], i);
3084                  } else {
# Line 3352 | Line 3288 | public class CompletableFutureTest exten
3288  
3289              () -> f.orTimeout(1L, null),
3290              () -> f.completeOnTimeout(42, 1L, null),
3291 +
3292 +            () -> CompletableFuture.failedFuture(null),
3293 +            () -> CompletableFuture.failedStage(null),
3294          };
3295  
3296          assertThrows(NullPointerException.class, throwingActions);
# Line 3390 | Line 3329 | public class CompletableFutureTest exten
3329       * completedStage returns a completed CompletionStage
3330       */
3331      public void testCompletedStage() {
3332 <        AtomicInteger x = new AtomicInteger();
3332 >        AtomicInteger x = new AtomicInteger(0);
3333          AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3334          CompletionStage<Integer> f = CompletableFuture.completedStage(1);
3335          f.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
# Line 3419 | Line 3358 | public class CompletableFutureTest exten
3358      public void testFailedFuture() {
3359          CFException ex = new CFException();
3360          CompletableFuture<Integer> f = CompletableFuture.failedFuture(ex);
3361 <        checkCompletedExceptionallyWithRootCause(f, ex);
3361 >        checkCompletedExceptionally(f, ex);
3362      }
3363  
3364      /**
3365       * failedFuture(null) throws NPE
3366       */
3367 <    public void testFailedFuture2() {
3367 >    public void testFailedFuture_null() {
3368          try {
3369              CompletableFuture<Integer> f = CompletableFuture.failedFuture(null);
3370              shouldThrow();
# Line 3458 | Line 3397 | public class CompletableFutureTest exten
3397          CFException ex = new CFException();
3398          f.completeExceptionally(ex);
3399          checkCompletedExceptionally(f, ex);
3400 <        checkCompletedWithWrappedCFException(g);
3400 >        checkCompletedWithWrappedException(g, ex);
3401      }
3402  
3403      /**
# Line 3468 | Line 3407 | public class CompletableFutureTest exten
3407      public void testMinimalCompletionStage() {
3408          CompletableFuture<Integer> f = new CompletableFuture<>();
3409          CompletionStage<Integer> g = f.minimalCompletionStage();
3410 <        AtomicInteger x = new AtomicInteger();
3410 >        AtomicInteger x = new AtomicInteger(0);
3411          AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3412          checkIncomplete(f);
3413          g.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
# Line 3485 | Line 3424 | public class CompletableFutureTest exten
3424      public void testMinimalCompletionStage2() {
3425          CompletableFuture<Integer> f = new CompletableFuture<>();
3426          CompletionStage<Integer> g = f.minimalCompletionStage();
3427 <        AtomicInteger x = new AtomicInteger();
3427 >        AtomicInteger x = new AtomicInteger(0);
3428          AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3429          g.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3430          checkIncomplete(f);
# Line 3503 | Line 3442 | public class CompletableFutureTest exten
3442      public void testFailedStage() {
3443          CFException ex = new CFException();
3444          CompletionStage<Integer> f = CompletableFuture.failedStage(ex);
3445 <        AtomicInteger x = new AtomicInteger();
3445 >        AtomicInteger x = new AtomicInteger(0);
3446          AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3447          f.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3448          assertEquals(x.get(), 0);
3449 <        assertEquals(r.get().getCause(), ex);
3449 >        assertEquals(r.get(), ex);
3450      }
3451  
3452      /**
3453       * completeAsync completes with value of given supplier
3454       */
3455      public void testCompleteAsync() {
3456 +        for (Integer v1 : new Integer[] { 1, null })
3457 +    {
3458          CompletableFuture<Integer> f = new CompletableFuture<>();
3459 <        f.completeAsync(() -> 1);
3459 >        f.completeAsync(() -> v1);
3460          f.join();
3461 <        checkCompletedNormally(f, 1);
3462 <    }
3461 >        checkCompletedNormally(f, v1);
3462 >    }}
3463  
3464      /**
3465       * completeAsync completes exceptionally if given supplier throws
# Line 3530 | Line 3471 | public class CompletableFutureTest exten
3471          try {
3472              f.join();
3473              shouldThrow();
3474 <        } catch (Exception success) {}
3475 <        checkCompletedWithWrappedCFException(f);
3474 >        } catch (CompletionException success) {}
3475 >        checkCompletedWithWrappedException(f, ex);
3476      }
3477  
3478      /**
3479       * completeAsync with given executor completes with value of given supplier
3480       */
3481      public void testCompleteAsync3() {
3482 +        for (Integer v1 : new Integer[] { 1, null })
3483 +    {
3484          CompletableFuture<Integer> f = new CompletableFuture<>();
3485 <        f.completeAsync(() -> 1, new ThreadExecutor());
3486 <        f.join();
3487 <        checkCompletedNormally(f, 1);
3488 <    }
3485 >        ThreadExecutor executor = new ThreadExecutor();
3486 >        f.completeAsync(() -> v1, executor);
3487 >        assertSame(v1, f.join());
3488 >        checkCompletedNormally(f, v1);
3489 >        assertEquals(1, executor.count.get());
3490 >    }}
3491  
3492      /**
3493       * completeAsync with given executor completes exceptionally if
# Line 3551 | Line 3496 | public class CompletableFutureTest exten
3496      public void testCompleteAsync4() {
3497          CompletableFuture<Integer> f = new CompletableFuture<>();
3498          CFException ex = new CFException();
3499 <        f.completeAsync(() -> {if (true) throw ex; return 1;}, new ThreadExecutor());
3499 >        ThreadExecutor executor = new ThreadExecutor();
3500 >        f.completeAsync(() -> {if (true) throw ex; return 1;}, executor);
3501          try {
3502              f.join();
3503              shouldThrow();
3504 <        } catch (Exception success) {}
3505 <        checkCompletedWithWrappedCFException(f);
3504 >        } catch (CompletionException success) {}
3505 >        checkCompletedWithWrappedException(f, ex);
3506 >        assertEquals(1, executor.count.get());
3507      }
3508  
3509      /**
3510       * orTimeout completes with TimeoutException if not complete
3511       */
3512 <    public void testOrTimeout() {
3512 >    public void testOrTimeout_timesOut() {
3513 >        long timeoutMillis = timeoutMillis();
3514          CompletableFuture<Integer> f = new CompletableFuture<>();
3515 <        f.orTimeout(SHORT_DELAY_MS, MILLISECONDS);
3516 <        checkCompletedExceptionallyWithTimeout(f);
3515 >        long startTime = System.nanoTime();
3516 >        f.orTimeout(timeoutMillis, MILLISECONDS);
3517 >        checkCompletedWithTimeoutException(f);
3518 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
3519      }
3520  
3521      /**
3522       * orTimeout completes normally if completed before timeout
3523       */
3524 <    public void testOrTimeout2() {
3524 >    public void testOrTimeout_completed() {
3525 >        for (Integer v1 : new Integer[] { 1, null })
3526 >    {
3527          CompletableFuture<Integer> f = new CompletableFuture<>();
3528 <        f.complete(1);
3529 <        f.orTimeout(SHORT_DELAY_MS, MILLISECONDS);
3530 <        checkCompletedNormally(f, 1);
3531 <    }
3528 >        CompletableFuture<Integer> g = new CompletableFuture<>();
3529 >        long startTime = System.nanoTime();
3530 >        f.complete(v1);
3531 >        f.orTimeout(LONG_DELAY_MS, MILLISECONDS);
3532 >        g.orTimeout(LONG_DELAY_MS, MILLISECONDS);
3533 >        g.complete(v1);
3534 >        checkCompletedNormally(f, v1);
3535 >        checkCompletedNormally(g, v1);
3536 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
3537 >    }}
3538  
3539      /**
3540       * completeOnTimeout completes with given value if not complete
3541       */
3542 <    public void testCompleteOnTimeout() {
3542 >    public void testCompleteOnTimeout_timesOut() {
3543 >        testInParallel(() -> testCompleteOnTimeout_timesOut(42),
3544 >                       () -> testCompleteOnTimeout_timesOut(null));
3545 >    }
3546 >
3547 >    public void testCompleteOnTimeout_timesOut(Integer v) {
3548 >        long timeoutMillis = timeoutMillis();
3549          CompletableFuture<Integer> f = new CompletableFuture<>();
3550 <        f.completeOnTimeout(-1, SHORT_DELAY_MS, MILLISECONDS);
3551 <        f.join();
3552 <        checkCompletedNormally(f, -1);
3550 >        long startTime = System.nanoTime();
3551 >        f.completeOnTimeout(v, timeoutMillis, MILLISECONDS);
3552 >        assertSame(v, f.join());
3553 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
3554 >        f.complete(99);         // should have no effect
3555 >        checkCompletedNormally(f, v);
3556      }
3557  
3558      /**
3559       * completeOnTimeout has no effect if completed within timeout
3560       */
3561 <    public void testCompleteOnTimeout2() {
3561 >    public void testCompleteOnTimeout_completed() {
3562 >        for (Integer v1 : new Integer[] { 1, null })
3563 >    {
3564          CompletableFuture<Integer> f = new CompletableFuture<>();
3565 <        f.complete(1);
3566 <        f.completeOnTimeout(-1, SHORT_DELAY_MS, MILLISECONDS);
3567 <        checkCompletedNormally(f, 1);
3568 <    }
3565 >        CompletableFuture<Integer> g = new CompletableFuture<>();
3566 >        long startTime = System.nanoTime();
3567 >        f.complete(v1);
3568 >        f.completeOnTimeout(-1, LONG_DELAY_MS, MILLISECONDS);
3569 >        g.completeOnTimeout(-1, LONG_DELAY_MS, MILLISECONDS);
3570 >        g.complete(v1);
3571 >        checkCompletedNormally(f, v1);
3572 >        checkCompletedNormally(g, v1);
3573 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
3574 >    }}
3575  
3576      /**
3577       * delayedExecutor returns an executor that delays submission
3578       */
3579 <    public void testDelayedExecutor() throws Exception {
3580 <        long timeoutMillis = SMALL_DELAY_MS;
3581 <        Executor d = CompletableFuture.delayedExecutor(timeoutMillis,
3582 <                                                       MILLISECONDS);
3579 >    public void testDelayedExecutor() {
3580 >        testInParallel(() -> testDelayedExecutor(null, null),
3581 >                       () -> testDelayedExecutor(null, 1),
3582 >                       () -> testDelayedExecutor(new ThreadExecutor(), 1),
3583 >                       () -> testDelayedExecutor(new ThreadExecutor(), 1));
3584 >    }
3585 >
3586 >    public void testDelayedExecutor(Executor executor, Integer v) throws Exception {
3587 >        long timeoutMillis = timeoutMillis();
3588 >        // Use an "unreasonably long" long timeout to catch lingering threads
3589 >        long longTimeoutMillis = 1000 * 60 * 60 * 24;
3590 >        final Executor delayer, longDelayer;
3591 >        if (executor == null) {
3592 >            delayer = CompletableFuture.delayedExecutor(timeoutMillis, MILLISECONDS);
3593 >            longDelayer = CompletableFuture.delayedExecutor(longTimeoutMillis, MILLISECONDS);
3594 >        } else {
3595 >            delayer = CompletableFuture.delayedExecutor(timeoutMillis, MILLISECONDS, executor);
3596 >            longDelayer = CompletableFuture.delayedExecutor(longTimeoutMillis, MILLISECONDS, executor);
3597 >        }
3598          long startTime = System.nanoTime();
3599 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(() -> 1, d);
3600 <        assertNull(f.getNow(null));
3601 <        assertEquals(1, (int) f.get(LONG_DELAY_MS, MILLISECONDS));
3602 <        assertTrue(millisElapsedSince(startTime) > timeoutMillis/2);
3603 <        checkCompletedNormally(f, 1);
3604 <    }
3599 >        CompletableFuture<Integer> f =
3600 >            CompletableFuture.supplyAsync(() -> v, delayer);
3601 >        CompletableFuture<Integer> g =
3602 >            CompletableFuture.supplyAsync(() -> v, longDelayer);
3603 >
3604 >        assertNull(g.getNow(null));
3605 >
3606 >        assertSame(v, f.get(LONG_DELAY_MS, MILLISECONDS));
3607 >        long millisElapsed = millisElapsedSince(startTime);
3608 >        assertTrue(millisElapsed >= timeoutMillis);
3609 >        assertTrue(millisElapsed < LONG_DELAY_MS / 2);
3610  
3611 <    /**
3612 <     * delayedExecutor for a given executor returns an executor that
3613 <     * delays submission
3614 <     */
3620 <    public void testDelayedExecutor2() throws Exception {
3621 <        long timeoutMillis = SMALL_DELAY_MS;
3622 <        Executor d = CompletableFuture.delayedExecutor(timeoutMillis,
3623 <                                                       MILLISECONDS,
3624 <                                                       new ThreadExecutor());
3625 <        long startTime = System.nanoTime();
3626 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(() -> 1, d);
3627 <        assertNull(f.getNow(null));
3628 <        assertEquals(1, (int) f.get(LONG_DELAY_MS, MILLISECONDS));
3629 <        assertTrue(millisElapsedSince(startTime) > timeoutMillis/2);
3630 <        checkCompletedNormally(f, 1);
3611 >        checkCompletedNormally(f, v);
3612 >
3613 >        checkIncomplete(g);
3614 >        assertTrue(g.cancel(true));
3615      }
3616  
3617      //--- tests of implementation details; not part of official tck ---
# Line 3720 | Line 3704 | public class CompletableFutureTest exten
3704          }
3705      }}
3706  
3707 +    /**
3708 +     * Minimal completion stages throw UOE for all non-CompletionStage methods
3709 +     */
3710 +    public void testMinimalCompletionStage_minimality() {
3711 +        if (!testImplementationDetails) return;
3712 +        Function<Method, String> toSignature =
3713 +            (method) -> method.getName() + Arrays.toString(method.getParameterTypes());
3714 +        Predicate<Method> isNotStatic =
3715 +            (method) -> (method.getModifiers() & Modifier.STATIC) == 0;
3716 +        List<Method> minimalMethods =
3717 +            Stream.of(Object.class, CompletionStage.class)
3718 +            .flatMap((klazz) -> Stream.of(klazz.getMethods()))
3719 +            .filter(isNotStatic)
3720 +            .collect(Collectors.toList());
3721 +        // Methods from CompletableFuture permitted NOT to throw UOE
3722 +        String[] signatureWhitelist = {
3723 +            "newIncompleteFuture[]",
3724 +            "defaultExecutor[]",
3725 +            "minimalCompletionStage[]",
3726 +            "copy[]",
3727 +        };
3728 +        Set<String> permittedMethodSignatures =
3729 +            Stream.concat(minimalMethods.stream().map(toSignature),
3730 +                          Stream.of(signatureWhitelist))
3731 +            .collect(Collectors.toSet());
3732 +        List<Method> allMethods = Stream.of(CompletableFuture.class.getMethods())
3733 +            .filter(isNotStatic)
3734 +            .filter((method) -> !permittedMethodSignatures.contains(toSignature.apply(method)))
3735 +            .collect(Collectors.toList());
3736 +
3737 +        CompletionStage<Integer> minimalStage =
3738 +            new CompletableFuture<Integer>().minimalCompletionStage();
3739 +
3740 +        List<Method> bugs = new ArrayList<>();
3741 +        for (Method method : allMethods) {
3742 +            Class<?>[] parameterTypes = method.getParameterTypes();
3743 +            Object[] args = new Object[parameterTypes.length];
3744 +            // Manufacture boxed primitives for primitive params
3745 +            for (int i = 0; i < args.length; i++) {
3746 +                Class<?> type = parameterTypes[i];
3747 +                if (parameterTypes[i] == boolean.class)
3748 +                    args[i] = false;
3749 +                else if (parameterTypes[i] == int.class)
3750 +                    args[i] = 0;
3751 +                else if (parameterTypes[i] == long.class)
3752 +                    args[i] = 0L;
3753 +            }
3754 +            try {
3755 +                method.invoke(minimalStage, args);
3756 +                bugs.add(method);
3757 +            }
3758 +            catch (java.lang.reflect.InvocationTargetException expected) {
3759 +                if (! (expected.getCause() instanceof UnsupportedOperationException)) {
3760 +                    bugs.add(method);
3761 +                    // expected.getCause().printStackTrace();
3762 +                }
3763 +            }
3764 +            catch (ReflectiveOperationException bad) { throw new Error(bad); }
3765 +        }
3766 +        if (!bugs.isEmpty())
3767 +            throw new Error("Methods did not throw UOE: " + bugs.toString());
3768 +    }
3769 +
3770 +    static class Monad {
3771 +        static class ZeroException extends RuntimeException {
3772 +            public ZeroException() { super("monadic zero"); }
3773 +        }
3774 +        // "return", "unit"
3775 +        static <T> CompletableFuture<T> unit(T value) {
3776 +            return completedFuture(value);
3777 +        }
3778 +        // monadic zero ?
3779 +        static <T> CompletableFuture<T> zero() {
3780 +            return failedFuture(new ZeroException());
3781 +        }
3782 +        // >=>
3783 +        static <T,U,V> Function<T, CompletableFuture<V>> compose
3784 +            (Function<T, CompletableFuture<U>> f,
3785 +             Function<U, CompletableFuture<V>> g) {
3786 +            return (x) -> f.apply(x).thenCompose(g);
3787 +        }
3788 +
3789 +        static void assertZero(CompletableFuture<?> f) {
3790 +            try {
3791 +                f.getNow(null);
3792 +                throw new AssertionFailedError("should throw");
3793 +            } catch (CompletionException success) {
3794 +                assertTrue(success.getCause() instanceof ZeroException);
3795 +            }
3796 +        }
3797 +
3798 +        static <T> void assertFutureEquals(CompletableFuture<T> f,
3799 +                                           CompletableFuture<T> g) {
3800 +            T fval = null, gval = null;
3801 +            Throwable fex = null, gex = null;
3802 +
3803 +            try { fval = f.get(); }
3804 +            catch (ExecutionException ex) { fex = ex.getCause(); }
3805 +            catch (Throwable ex) { fex = ex; }
3806 +
3807 +            try { gval = g.get(); }
3808 +            catch (ExecutionException ex) { gex = ex.getCause(); }
3809 +            catch (Throwable ex) { gex = ex; }
3810 +
3811 +            if (fex != null || gex != null)
3812 +                assertSame(fex.getClass(), gex.getClass());
3813 +            else
3814 +                assertEquals(fval, gval);
3815 +        }
3816 +
3817 +        static class PlusFuture<T> extends CompletableFuture<T> {
3818 +            AtomicReference<Throwable> firstFailure = new AtomicReference<>(null);
3819 +        }
3820 +
3821 +        // Monadic "plus"
3822 +        static <T> CompletableFuture<T> plus(CompletableFuture<? extends T> f,
3823 +                                             CompletableFuture<? extends T> g) {
3824 +            PlusFuture<T> plus = new PlusFuture<T>();
3825 +            BiConsumer<T, Throwable> action = (T result, Throwable ex) -> {
3826 +                if (ex == null) {
3827 +                    if (plus.complete(result))
3828 +                        if (plus.firstFailure.get() != null)
3829 +                            plus.firstFailure.set(null);
3830 +                }
3831 +                else if (plus.firstFailure.compareAndSet(null, ex)) {
3832 +                    if (plus.isDone())
3833 +                        plus.firstFailure.set(null);
3834 +                }
3835 +                else {
3836 +                    // first failure has precedence
3837 +                    Throwable first = plus.firstFailure.getAndSet(null);
3838 +
3839 +                    // may fail with "Self-suppression not permitted"
3840 +                    try { first.addSuppressed(ex); }
3841 +                    catch (Exception ignored) {}
3842 +
3843 +                    plus.completeExceptionally(first);
3844 +                }
3845 +            };
3846 +            f.whenComplete(action);
3847 +            g.whenComplete(action);
3848 +            return plus;
3849 +        }
3850 +    }
3851 +
3852 +    /**
3853 +     * CompletableFuture is an additive monad - sort of.
3854 +     * https://en.wikipedia.org/wiki/Monad_(functional_programming)#Additive_monads
3855 +     */
3856 +    public void testAdditiveMonad() throws Throwable {
3857 +        Function<Long, CompletableFuture<Long>> unit = Monad::unit;
3858 +        CompletableFuture<Long> zero = Monad.zero();
3859 +
3860 +        // Some mutually non-commutative functions
3861 +        Function<Long, CompletableFuture<Long>> triple
3862 +            = (x) -> Monad.unit(3 * x);
3863 +        Function<Long, CompletableFuture<Long>> inc
3864 +            = (x) -> Monad.unit(x + 1);
3865 +
3866 +        // unit is a right identity: m >>= unit === m
3867 +        Monad.assertFutureEquals(inc.apply(5L).thenCompose(unit),
3868 +                                 inc.apply(5L));
3869 +        // unit is a left identity: (unit x) >>= f === f x
3870 +        Monad.assertFutureEquals(unit.apply(5L).thenCompose(inc),
3871 +                                 inc.apply(5L));
3872 +
3873 +        // associativity: (m >>= f) >>= g === m >>= ( \x -> (f x >>= g) )
3874 +        Monad.assertFutureEquals(
3875 +            unit.apply(5L).thenCompose(inc).thenCompose(triple),
3876 +            unit.apply(5L).thenCompose((x) -> inc.apply(x).thenCompose(triple)));
3877 +
3878 +        // The case for CompletableFuture as an additive monad is weaker...
3879 +
3880 +        // zero is a monadic zero
3881 +        Monad.assertZero(zero);
3882 +
3883 +        // left zero: zero >>= f === zero
3884 +        Monad.assertZero(zero.thenCompose(inc));
3885 +        // right zero: f >>= (\x -> zero) === zero
3886 +        Monad.assertZero(inc.apply(5L).thenCompose((x) -> zero));
3887 +
3888 +        // f plus zero === f
3889 +        Monad.assertFutureEquals(Monad.unit(5L),
3890 +                                 Monad.plus(Monad.unit(5L), zero));
3891 +        // zero plus f === f
3892 +        Monad.assertFutureEquals(Monad.unit(5L),
3893 +                                 Monad.plus(zero, Monad.unit(5L)));
3894 +        // zero plus zero === zero
3895 +        Monad.assertZero(Monad.plus(zero, zero));
3896 +        {
3897 +            CompletableFuture<Long> f = Monad.plus(Monad.unit(5L),
3898 +                                                   Monad.unit(8L));
3899 +            // non-determinism
3900 +            assertTrue(f.get() == 5L || f.get() == 8L);
3901 +        }
3902 +
3903 +        CompletableFuture<Long> godot = new CompletableFuture<>();
3904 +        // f plus godot === f (doesn't wait for godot)
3905 +        Monad.assertFutureEquals(Monad.unit(5L),
3906 +                                 Monad.plus(Monad.unit(5L), godot));
3907 +        // godot plus f === f (doesn't wait for godot)
3908 +        Monad.assertFutureEquals(Monad.unit(5L),
3909 +                                 Monad.plus(godot, Monad.unit(5L)));
3910 +    }
3911 +
3912 + //     static <U> U join(CompletionStage<U> stage) {
3913 + //         CompletableFuture<U> f = new CompletableFuture<>();
3914 + //         stage.whenComplete((v, ex) -> {
3915 + //             if (ex != null) f.completeExceptionally(ex); else f.complete(v);
3916 + //         });
3917 + //         return f.join();
3918 + //     }
3919 +
3920 + //     static <U> boolean isDone(CompletionStage<U> stage) {
3921 + //         CompletableFuture<U> f = new CompletableFuture<>();
3922 + //         stage.whenComplete((v, ex) -> {
3923 + //             if (ex != null) f.completeExceptionally(ex); else f.complete(v);
3924 + //         });
3925 + //         return f.isDone();
3926 + //     }
3927 +
3928 + //     static <U> U join2(CompletionStage<U> stage) {
3929 + //         return stage.toCompletableFuture().copy().join();
3930 + //     }
3931 +
3932 + //     static <U> boolean isDone2(CompletionStage<U> stage) {
3933 + //         return stage.toCompletableFuture().copy().isDone();
3934 + //     }
3935 +
3936   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines