ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.70 by jsr166, Fri Jun 6 19:48:38 2014 UTC vs.
Revision 1.120 by jsr166, Sun Sep 6 16:47:24 2015 UTC

# Line 5 | Line 5
5   * http://creativecommons.org/publicdomain/zero/1.0/
6   */
7  
8 < import junit.framework.*;
8 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
9 > import static java.util.concurrent.TimeUnit.SECONDS;
10 >
11 > import java.util.ArrayList;
12 > import java.util.List;
13 > import java.util.Objects;
14   import java.util.concurrent.Callable;
10 import java.util.concurrent.Executor;
11 import java.util.concurrent.ExecutorService;
12 import java.util.concurrent.Executors;
15   import java.util.concurrent.CancellationException;
14 import java.util.concurrent.CountDownLatch;
15 import java.util.concurrent.ExecutionException;
16 import java.util.concurrent.Future;
16   import java.util.concurrent.CompletableFuture;
17   import java.util.concurrent.CompletionException;
18   import java.util.concurrent.CompletionStage;
19 + import java.util.concurrent.ExecutionException;
20 + import java.util.concurrent.Executor;
21   import java.util.concurrent.ForkJoinPool;
22   import java.util.concurrent.ForkJoinTask;
23   import java.util.concurrent.TimeoutException;
24 + import java.util.concurrent.TimeUnit;
25   import java.util.concurrent.atomic.AtomicInteger;
26 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
25 < import static java.util.concurrent.TimeUnit.SECONDS;
26 < import java.util.*;
27 < import java.util.function.Supplier;
28 < import java.util.function.Consumer;
26 > import java.util.concurrent.atomic.AtomicReference;
27   import java.util.function.BiConsumer;
30 import java.util.function.Function;
28   import java.util.function.BiFunction;
29 + import java.util.function.Consumer;
30 + import java.util.function.Function;
31 + import java.util.function.Supplier;
32 +
33 + import junit.framework.Test;
34 + import junit.framework.TestSuite;
35  
36   public class CompletableFutureTest extends JSR166TestCase {
37  
38      public static void main(String[] args) {
39 <        junit.textui.TestRunner.run(suite());
39 >        main(suite(), args);
40      }
41      public static Test suite() {
42          return new TestSuite(CompletableFutureTest.class);
# Line 44 | Line 47 | public class CompletableFutureTest exten
47      void checkIncomplete(CompletableFuture<?> f) {
48          assertFalse(f.isDone());
49          assertFalse(f.isCancelled());
50 <        assertTrue(f.toString().contains("[Not completed]"));
50 >        assertTrue(f.toString().contains("Not completed"));
51          try {
52              assertNull(f.getNow(null));
53          } catch (Throwable fail) { threadUnexpectedException(fail); }
# Line 57 | Line 60 | public class CompletableFutureTest exten
60      }
61  
62      <T> void checkCompletedNormally(CompletableFuture<T> f, T value) {
63 <        try {
64 <            assertEquals(value, f.get(LONG_DELAY_MS, MILLISECONDS));
62 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
63 >        checkTimedGet(f, value);
64 >
65          try {
66              assertEquals(value, f.join());
67          } catch (Throwable fail) { threadUnexpectedException(fail); }
# Line 76 | Line 78 | public class CompletableFutureTest exten
78      }
79  
80      void checkCompletedWithWrappedCFException(CompletableFuture<?> f) {
81 +        long startTime = System.nanoTime();
82 +        long timeoutMillis = LONG_DELAY_MS;
83          try {
84 <            f.get(LONG_DELAY_MS, MILLISECONDS);
84 >            f.get(timeoutMillis, MILLISECONDS);
85              shouldThrow();
86          } catch (ExecutionException success) {
87              assertTrue(success.getCause() instanceof CFException);
88          } catch (Throwable fail) { threadUnexpectedException(fail); }
89 +        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
90 +
91          try {
92              f.join();
93              shouldThrow();
# Line 105 | Line 111 | public class CompletableFutureTest exten
111          assertTrue(f.toString().contains("[Completed exceptionally]"));
112      }
113  
114 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
115 <                                              CFException ex) {
114 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
115 >                                                      Throwable ex) {
116 >        long startTime = System.nanoTime();
117 >        long timeoutMillis = LONG_DELAY_MS;
118          try {
119 <            f.get(LONG_DELAY_MS, MILLISECONDS);
119 >            f.get(timeoutMillis, MILLISECONDS);
120              shouldThrow();
121          } catch (ExecutionException success) {
122              assertSame(ex, success.getCause());
123          } catch (Throwable fail) { threadUnexpectedException(fail); }
124 +        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
125 +
126          try {
127              f.join();
128              shouldThrow();
# Line 131 | Line 141 | public class CompletableFutureTest exten
141          } catch (ExecutionException success) {
142              assertSame(ex, success.getCause());
143          } catch (Throwable fail) { threadUnexpectedException(fail); }
144 +
145 +        assertTrue(f.isDone());
146 +        assertFalse(f.isCancelled());
147 +        assertTrue(f.toString().contains("[Completed exceptionally]"));
148 +    }
149 +
150 +    <U> void checkCompletedExceptionallyWithTimeout(CompletableFuture<U> f) {
151 +        long startTime = System.nanoTime();
152 +        long timeoutMillis = LONG_DELAY_MS;
153 +        try {
154 +            f.get(timeoutMillis, MILLISECONDS);
155 +            shouldThrow();
156 +        } catch (ExecutionException ex) {
157 +            assertTrue(ex.getCause() instanceof TimeoutException);
158 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
159 +        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
160 +
161 +        try {
162 +            f.join();
163 +            shouldThrow();
164 +        } catch (Throwable ex) {
165 +            assertTrue(ex.getCause() instanceof TimeoutException);
166 +        }
167 +
168 +        try {
169 +            f.getNow(null);
170 +            shouldThrow();
171 +        } catch (Throwable ex) {
172 +            assertTrue(ex.getCause() instanceof TimeoutException);
173 +        }
174 +
175 +        try {
176 +            f.get();
177 +            shouldThrow();
178 +        } catch (ExecutionException ex) {
179 +            assertTrue(ex.getCause() instanceof TimeoutException);
180 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
181 +
182          assertTrue(f.isDone());
183          assertFalse(f.isCancelled());
184          assertTrue(f.toString().contains("[Completed exceptionally]"));
185      }
186  
187 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
188 +                                                Throwable ex) {
189 +        checkCompletedExceptionallyWithRootCause(f, ex);
190 +        try {
191 +            CompletableFuture<Throwable> spy = f.handle
192 +                ((U u, Throwable t) -> t);
193 +            assertTrue(spy.join() instanceof CompletionException);
194 +            assertSame(ex, spy.join().getCause());
195 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
196 +    }
197 +
198 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
199 +        checkCompletedExceptionallyWithRootCause(f, ex);
200 +        try {
201 +            CompletableFuture<Throwable> spy = f.handle
202 +                ((U u, Throwable t) -> t);
203 +            assertSame(ex, spy.join());
204 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
205 +    }
206 +
207      void checkCancelled(CompletableFuture<?> f) {
208 +        long startTime = System.nanoTime();
209 +        long timeoutMillis = LONG_DELAY_MS;
210          try {
211 <            f.get(LONG_DELAY_MS, MILLISECONDS);
211 >            f.get(timeoutMillis, MILLISECONDS);
212              shouldThrow();
213          } catch (CancellationException success) {
214          } catch (Throwable fail) { threadUnexpectedException(fail); }
215 +        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
216 +
217          try {
218              f.join();
219              shouldThrow();
# Line 162 | Line 234 | public class CompletableFutureTest exten
234      }
235  
236      void checkCompletedWithWrappedCancellationException(CompletableFuture<?> f) {
237 +        long startTime = System.nanoTime();
238 +        long timeoutMillis = LONG_DELAY_MS;
239          try {
240 <            f.get(LONG_DELAY_MS, MILLISECONDS);
240 >            f.get(timeoutMillis, MILLISECONDS);
241              shouldThrow();
242          } catch (ExecutionException success) {
243              assertTrue(success.getCause() instanceof CancellationException);
244          } catch (Throwable fail) { threadUnexpectedException(fail); }
245 +        assertTrue(millisElapsedSince(startTime) < timeoutMillis/2);
246 +
247          try {
248              f.join();
249              shouldThrow();
# Line 206 | Line 282 | public class CompletableFutureTest exten
282       * isCancelled, join, get, and getNow
283       */
284      public void testComplete() {
285 +        for (Integer v1 : new Integer[] { 1, null })
286 +    {
287          CompletableFuture<Integer> f = new CompletableFuture<>();
288          checkIncomplete(f);
289 <        f.complete(one);
290 <        checkCompletedNormally(f, one);
291 <    }
289 >        assertTrue(f.complete(v1));
290 >        assertFalse(f.complete(v1));
291 >        checkCompletedNormally(f, v1);
292 >    }}
293  
294      /**
295       * completeExceptionally completes exceptionally, as indicated by
# Line 218 | Line 297 | public class CompletableFutureTest exten
297       */
298      public void testCompleteExceptionally() {
299          CompletableFuture<Integer> f = new CompletableFuture<>();
300 +        CFException ex = new CFException();
301          checkIncomplete(f);
302 <        f.completeExceptionally(new CFException());
303 <        checkCompletedWithWrappedCFException(f);
302 >        f.completeExceptionally(ex);
303 >        checkCompletedExceptionally(f, ex);
304      }
305  
306      /**
# Line 228 | Line 308 | public class CompletableFutureTest exten
308       * methods isDone, isCancelled, join, get, and getNow
309       */
310      public void testCancel() {
311 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
312 +    {
313          CompletableFuture<Integer> f = new CompletableFuture<>();
314          checkIncomplete(f);
315 <        assertTrue(f.cancel(true));
315 >        assertTrue(f.cancel(mayInterruptIfRunning));
316 >        assertTrue(f.cancel(mayInterruptIfRunning));
317 >        assertTrue(f.cancel(!mayInterruptIfRunning));
318          checkCancelled(f);
319 <    }
319 >    }}
320  
321      /**
322       * obtrudeValue forces completion with given value
# Line 240 | Line 324 | public class CompletableFutureTest exten
324      public void testObtrudeValue() {
325          CompletableFuture<Integer> f = new CompletableFuture<>();
326          checkIncomplete(f);
327 <        f.complete(one);
327 >        assertTrue(f.complete(one));
328          checkCompletedNormally(f, one);
329          f.obtrudeValue(three);
330          checkCompletedNormally(f, three);
# Line 261 | Line 345 | public class CompletableFutureTest exten
345       * obtrudeException forces completion with given exception
346       */
347      public void testObtrudeException() {
348 <        CompletableFuture<Integer> f = new CompletableFuture<>();
349 <        checkIncomplete(f);
350 <        f.complete(one);
351 <        checkCompletedNormally(f, one);
352 <        f.obtrudeException(new CFException());
269 <        checkCompletedWithWrappedCFException(f);
348 >        for (Integer v1 : new Integer[] { 1, null })
349 >    {
350 >        CFException ex;
351 >        CompletableFuture<Integer> f;
352 >
353          f = new CompletableFuture<>();
354 <        f.obtrudeException(new CFException());
355 <        checkCompletedWithWrappedCFException(f);
354 >        assertTrue(f.complete(v1));
355 >        for (int i = 0; i < 2; i++) {
356 >            f.obtrudeException(ex = new CFException());
357 >            checkCompletedExceptionally(f, ex);
358 >        }
359 >
360 >        f = new CompletableFuture<>();
361 >        for (int i = 0; i < 2; i++) {
362 >            f.obtrudeException(ex = new CFException());
363 >            checkCompletedExceptionally(f, ex);
364 >        }
365 >
366          f = new CompletableFuture<>();
367 +        f.completeExceptionally(ex = new CFException());
368 +        f.obtrudeValue(v1);
369 +        checkCompletedNormally(f, v1);
370 +        f.obtrudeException(ex = new CFException());
371 +        checkCompletedExceptionally(f, ex);
372          f.completeExceptionally(new CFException());
373 <        f.obtrudeValue(four);
374 <        checkCompletedNormally(f, four);
375 <        f.obtrudeException(new CFException());
376 <        checkCompletedWithWrappedCFException(f);
279 <    }
373 >        checkCompletedExceptionally(f, ex);
374 >        assertFalse(f.complete(v1));
375 >        checkCompletedExceptionally(f, ex);
376 >    }}
377  
378      /**
379       * getNumberOfDependents returns number of dependent tasks
380       */
381      public void testGetNumberOfDependents() {
382 +        for (ExecutionMode m : ExecutionMode.values())
383 +        for (Integer v1 : new Integer[] { 1, null })
384 +    {
385          CompletableFuture<Integer> f = new CompletableFuture<>();
386          assertEquals(0, f.getNumberOfDependents());
387 <        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
387 >        final CompletableFuture<Void> g = m.thenRun(f, new Noop(m));
388          assertEquals(1, f.getNumberOfDependents());
389          assertEquals(0, g.getNumberOfDependents());
390 <        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
390 >        final CompletableFuture<Void> h = m.thenRun(f, new Noop(m));
391          assertEquals(2, f.getNumberOfDependents());
392 <        f.complete(1);
392 >        assertEquals(0, h.getNumberOfDependents());
393 >        assertTrue(f.complete(v1));
394          checkCompletedNormally(g, null);
395 +        checkCompletedNormally(h, null);
396          assertEquals(0, f.getNumberOfDependents());
397          assertEquals(0, g.getNumberOfDependents());
398 <    }
398 >        assertEquals(0, h.getNumberOfDependents());
399 >    }}
400  
401      /**
402       * toString indicates current completion state
# Line 304 | Line 407 | public class CompletableFutureTest exten
407          f = new CompletableFuture<String>();
408          assertTrue(f.toString().contains("[Not completed]"));
409  
410 <        f.complete("foo");
410 >        assertTrue(f.complete("foo"));
411          assertTrue(f.toString().contains("[Completed normally]"));
412  
413          f = new CompletableFuture<String>();
414 <        f.completeExceptionally(new IndexOutOfBoundsException());
414 >        assertTrue(f.completeExceptionally(new IndexOutOfBoundsException()));
415          assertTrue(f.toString().contains("[Completed exceptionally]"));
416 +
417 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
418 +            f = new CompletableFuture<String>();
419 +            assertTrue(f.cancel(mayInterruptIfRunning));
420 +            assertTrue(f.toString().contains("[Completed exceptionally]"));
421 +        }
422      }
423  
424      /**
# Line 477 | Line 586 | public class CompletableFutureTest exten
586          }
587      }
588  
480
589      class CompletableFutureInc extends CheckedIntegerAction
590          implements Function<Integer, CompletableFuture<Integer>>
591      {
# Line 486 | Line 594 | public class CompletableFutureTest exten
594              invoked();
595              value = x;
596              CompletableFuture<Integer> f = new CompletableFuture<>();
597 <            f.complete(inc(x));
597 >            assertTrue(f.complete(inc(x)));
598              return f;
599          }
600      }
# Line 516 | Line 624 | public class CompletableFutureTest exten
624          }
625      }
626  
627 +    static final boolean defaultExecutorIsCommonPool
628 +        = ForkJoinPool.getCommonPoolParallelism() > 1;
629 +
630      /**
631       * Permits the testing of parallel code for the 3 different
632       * execution modes without copy/pasting all the test methods.
633       */
634      enum ExecutionMode {
635 <        DEFAULT {
635 >        SYNC {
636              public void checkExecutionMode() {
637                  assertFalse(ThreadExecutor.startedCurrentThread());
638                  assertNull(ForkJoinTask.getPool());
# Line 597 | Line 708 | public class CompletableFutureTest exten
708  
709          ASYNC {
710              public void checkExecutionMode() {
711 <                assertSame(ForkJoinPool.commonPool(),
712 <                           ForkJoinTask.getPool());
711 >                assertEquals(defaultExecutorIsCommonPool,
712 >                             (ForkJoinPool.commonPool() == ForkJoinTask.getPool()));
713              }
714              public CompletableFuture<Void> runAsync(Runnable a) {
715                  return CompletableFuture.runAsync(a);
# Line 794 | Line 905 | public class CompletableFutureTest exten
905      {
906          final AtomicInteger a = new AtomicInteger(0);
907          final CompletableFuture<Integer> f = new CompletableFuture<>();
908 <        if (!createIncomplete) f.complete(v1);
908 >        if (!createIncomplete) assertTrue(f.complete(v1));
909          final CompletableFuture<Integer> g = f.exceptionally
910              ((Throwable t) -> {
911                  // Should not be called
912                  a.getAndIncrement();
913                  throw new AssertionError();
914              });
915 <        if (createIncomplete) f.complete(v1);
915 >        if (createIncomplete) assertTrue(f.complete(v1));
916  
917          checkCompletedNormally(g, v1);
918          checkCompletedNormally(f, v1);
919          assertEquals(0, a.get());
920      }}
921  
811
922      /**
923       * exceptionally action completes with function value on source
924       * exception
# Line 823 | Line 933 | public class CompletableFutureTest exten
933          if (!createIncomplete) f.completeExceptionally(ex);
934          final CompletableFuture<Integer> g = f.exceptionally
935              ((Throwable t) -> {
936 <                ExecutionMode.DEFAULT.checkExecutionMode();
936 >                ExecutionMode.SYNC.checkExecutionMode();
937                  threadAssertSame(t, ex);
938                  a.getAndIncrement();
939                  return v1;
# Line 836 | Line 946 | public class CompletableFutureTest exten
946  
947      public void testExceptionally_exceptionalCompletionActionFailed() {
948          for (boolean createIncomplete : new boolean[] { true, false })
839        for (Integer v1 : new Integer[] { 1, null })
949      {
950          final AtomicInteger a = new AtomicInteger(0);
951          final CFException ex1 = new CFException();
# Line 845 | Line 954 | public class CompletableFutureTest exten
954          if (!createIncomplete) f.completeExceptionally(ex1);
955          final CompletableFuture<Integer> g = f.exceptionally
956              ((Throwable t) -> {
957 <                ExecutionMode.DEFAULT.checkExecutionMode();
957 >                ExecutionMode.SYNC.checkExecutionMode();
958 >                threadAssertSame(t, ex1);
959 >                a.getAndIncrement();
960 >                throw ex2;
961 >            });
962 >        if (createIncomplete) f.completeExceptionally(ex1);
963 >
964 >        checkCompletedWithWrappedException(g, ex2);
965 >        assertEquals(1, a.get());
966 >    }}
967 >
968 >    /**
969 >     * whenComplete action executes on normal completion, propagating
970 >     * source result.
971 >     */
972 >    public void testWhenComplete_normalCompletion1() {
973 >        for (ExecutionMode m : ExecutionMode.values())
974 >        for (boolean createIncomplete : new boolean[] { true, false })
975 >        for (Integer v1 : new Integer[] { 1, null })
976 >    {
977 >        final AtomicInteger a = new AtomicInteger(0);
978 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
979 >        if (!createIncomplete) assertTrue(f.complete(v1));
980 >        final CompletableFuture<Integer> g = m.whenComplete
981 >            (f,
982 >             (Integer x, Throwable t) -> {
983 >                m.checkExecutionMode();
984 >                threadAssertSame(x, v1);
985 >                threadAssertNull(t);
986 >                a.getAndIncrement();
987 >            });
988 >        if (createIncomplete) assertTrue(f.complete(v1));
989 >
990 >        checkCompletedNormally(g, v1);
991 >        checkCompletedNormally(f, v1);
992 >        assertEquals(1, a.get());
993 >    }}
994 >
995 >    /**
996 >     * whenComplete action executes on exceptional completion, propagating
997 >     * source result.
998 >     */
999 >    public void testWhenComplete_exceptionalCompletion() {
1000 >        for (ExecutionMode m : ExecutionMode.values())
1001 >        for (boolean createIncomplete : new boolean[] { true, false })
1002 >    {
1003 >        final AtomicInteger a = new AtomicInteger(0);
1004 >        final CFException ex = new CFException();
1005 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1006 >        if (!createIncomplete) f.completeExceptionally(ex);
1007 >        final CompletableFuture<Integer> g = m.whenComplete
1008 >            (f,
1009 >             (Integer x, Throwable t) -> {
1010 >                m.checkExecutionMode();
1011 >                threadAssertNull(x);
1012 >                threadAssertSame(t, ex);
1013 >                a.getAndIncrement();
1014 >            });
1015 >        if (createIncomplete) f.completeExceptionally(ex);
1016 >
1017 >        checkCompletedWithWrappedException(g, ex);
1018 >        checkCompletedExceptionally(f, ex);
1019 >        assertEquals(1, a.get());
1020 >    }}
1021 >
1022 >    /**
1023 >     * whenComplete action executes on cancelled source, propagating
1024 >     * CancellationException.
1025 >     */
1026 >    public void testWhenComplete_sourceCancelled() {
1027 >        for (ExecutionMode m : ExecutionMode.values())
1028 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1029 >        for (boolean createIncomplete : new boolean[] { true, false })
1030 >    {
1031 >        final AtomicInteger a = new AtomicInteger(0);
1032 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1033 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1034 >        final CompletableFuture<Integer> g = m.whenComplete
1035 >            (f,
1036 >             (Integer x, Throwable t) -> {
1037 >                m.checkExecutionMode();
1038 >                threadAssertNull(x);
1039 >                threadAssertTrue(t instanceof CancellationException);
1040 >                a.getAndIncrement();
1041 >            });
1042 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1043 >
1044 >        checkCompletedWithWrappedCancellationException(g);
1045 >        checkCancelled(f);
1046 >        assertEquals(1, a.get());
1047 >    }}
1048 >
1049 >    /**
1050 >     * If a whenComplete action throws an exception when triggered by
1051 >     * a normal completion, it completes exceptionally
1052 >     */
1053 >    public void testWhenComplete_actionFailed() {
1054 >        for (boolean createIncomplete : new boolean[] { true, false })
1055 >        for (ExecutionMode m : ExecutionMode.values())
1056 >        for (Integer v1 : new Integer[] { 1, null })
1057 >    {
1058 >        final AtomicInteger a = new AtomicInteger(0);
1059 >        final CFException ex = new CFException();
1060 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1061 >        if (!createIncomplete) assertTrue(f.complete(v1));
1062 >        final CompletableFuture<Integer> g = m.whenComplete
1063 >            (f,
1064 >             (Integer x, Throwable t) -> {
1065 >                m.checkExecutionMode();
1066 >                threadAssertSame(x, v1);
1067 >                threadAssertNull(t);
1068 >                a.getAndIncrement();
1069 >                throw ex;
1070 >            });
1071 >        if (createIncomplete) assertTrue(f.complete(v1));
1072 >
1073 >        checkCompletedWithWrappedException(g, ex);
1074 >        checkCompletedNormally(f, v1);
1075 >        assertEquals(1, a.get());
1076 >    }}
1077 >
1078 >    /**
1079 >     * If a whenComplete action throws an exception when triggered by
1080 >     * a source completion that also throws an exception, the source
1081 >     * exception takes precedence.
1082 >     */
1083 >    public void testWhenComplete_actionFailedSourceFailed() {
1084 >        for (boolean createIncomplete : new boolean[] { true, false })
1085 >        for (ExecutionMode m : ExecutionMode.values())
1086 >    {
1087 >        final AtomicInteger a = new AtomicInteger(0);
1088 >        final CFException ex1 = new CFException();
1089 >        final CFException ex2 = new CFException();
1090 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1091 >
1092 >        if (!createIncomplete) f.completeExceptionally(ex1);
1093 >        final CompletableFuture<Integer> g = m.whenComplete
1094 >            (f,
1095 >             (Integer x, Throwable t) -> {
1096 >                m.checkExecutionMode();
1097                  threadAssertSame(t, ex1);
1098 +                threadAssertNull(x);
1099                  a.getAndIncrement();
1100                  throw ex2;
1101              });
1102          if (createIncomplete) f.completeExceptionally(ex1);
1103  
1104 <        checkCompletedWithWrappedCFException(g, ex2);
1104 >        checkCompletedWithWrappedException(g, ex1);
1105 >        checkCompletedExceptionally(f, ex1);
1106          assertEquals(1, a.get());
1107      }}
1108  
# Line 867 | Line 1117 | public class CompletableFutureTest exten
1117      {
1118          final CompletableFuture<Integer> f = new CompletableFuture<>();
1119          final AtomicInteger a = new AtomicInteger(0);
1120 <        if (!createIncomplete) f.complete(v1);
1120 >        if (!createIncomplete) assertTrue(f.complete(v1));
1121          final CompletableFuture<Integer> g = m.handle
1122              (f,
1123               (Integer x, Throwable t) -> {
# Line 877 | Line 1127 | public class CompletableFutureTest exten
1127                  a.getAndIncrement();
1128                  return inc(v1);
1129              });
1130 <        if (createIncomplete) f.complete(v1);
1130 >        if (createIncomplete) assertTrue(f.complete(v1));
1131  
1132          checkCompletedNormally(g, inc(v1));
1133          checkCompletedNormally(f, v1);
# Line 909 | Line 1159 | public class CompletableFutureTest exten
1159          if (createIncomplete) f.completeExceptionally(ex);
1160  
1161          checkCompletedNormally(g, v1);
1162 <        checkCompletedWithWrappedCFException(f, ex);
1162 >        checkCompletedExceptionally(f, ex);
1163          assertEquals(1, a.get());
1164      }}
1165  
# Line 965 | Line 1215 | public class CompletableFutureTest exten
1215              });
1216          if (createIncomplete) f.completeExceptionally(ex1);
1217  
1218 <        checkCompletedWithWrappedCFException(g, ex2);
1219 <        checkCompletedWithWrappedCFException(f, ex1);
1218 >        checkCompletedWithWrappedException(g, ex2);
1219 >        checkCompletedExceptionally(f, ex1);
1220          assertEquals(1, a.get());
1221      }}
1222  
# Line 978 | Line 1228 | public class CompletableFutureTest exten
1228          final CompletableFuture<Integer> f = new CompletableFuture<>();
1229          final AtomicInteger a = new AtomicInteger(0);
1230          final CFException ex = new CFException();
1231 <        if (!createIncomplete) f.complete(v1);
1231 >        if (!createIncomplete) assertTrue(f.complete(v1));
1232          final CompletableFuture<Integer> g = m.handle
1233              (f,
1234               (Integer x, Throwable t) -> {
# Line 988 | Line 1238 | public class CompletableFutureTest exten
1238                  a.getAndIncrement();
1239                  throw ex;
1240              });
1241 <        if (createIncomplete) f.complete(v1);
1241 >        if (createIncomplete) assertTrue(f.complete(v1));
1242  
1243 <        checkCompletedWithWrappedCFException(g, ex);
1243 >        checkCompletedWithWrappedException(g, ex);
1244          checkCompletedNormally(f, v1);
1245          assertEquals(1, a.get());
1246      }}
# Line 1069 | Line 1319 | public class CompletableFutureTest exten
1319       */
1320      public void testThenRun_normalCompletion() {
1321          for (ExecutionMode m : ExecutionMode.values())
1072        for (boolean createIncomplete : new boolean[] { true, false })
1322          for (Integer v1 : new Integer[] { 1, null })
1323      {
1324          final CompletableFuture<Integer> f = new CompletableFuture<>();
1325 <        final Noop r = new Noop(m);
1326 <        if (!createIncomplete) f.complete(v1);
1078 <        final CompletableFuture<Void> g = m.thenRun(f, r);
1079 <        if (createIncomplete) {
1080 <            checkIncomplete(g);
1081 <            f.complete(v1);
1082 <        }
1325 >        final Noop[] rs = new Noop[6];
1326 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
1327  
1328 <        checkCompletedNormally(g, null);
1328 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1329 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1330 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1331 >        checkIncomplete(h0);
1332 >        checkIncomplete(h1);
1333 >        checkIncomplete(h2);
1334 >        assertTrue(f.complete(v1));
1335 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1336 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1337 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1338 >
1339 >        checkCompletedNormally(h0, null);
1340 >        checkCompletedNormally(h1, null);
1341 >        checkCompletedNormally(h2, null);
1342 >        checkCompletedNormally(h3, null);
1343 >        checkCompletedNormally(h4, null);
1344 >        checkCompletedNormally(h5, null);
1345          checkCompletedNormally(f, v1);
1346 <        r.assertInvoked();
1346 >        for (Noop r : rs) r.assertInvoked();
1347      }}
1348  
1349      /**
# Line 1092 | Line 1352 | public class CompletableFutureTest exten
1352       */
1353      public void testThenRun_exceptionalCompletion() {
1354          for (ExecutionMode m : ExecutionMode.values())
1095        for (boolean createIncomplete : new boolean[] { true, false })
1355      {
1356          final CFException ex = new CFException();
1357          final CompletableFuture<Integer> f = new CompletableFuture<>();
1358 <        final Noop r = new Noop(m);
1359 <        if (!createIncomplete) f.completeExceptionally(ex);
1101 <        final CompletableFuture<Void> g = m.thenRun(f, r);
1102 <        if (createIncomplete) {
1103 <            checkIncomplete(g);
1104 <            f.completeExceptionally(ex);
1105 <        }
1358 >        final Noop[] rs = new Noop[6];
1359 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
1360  
1361 <        checkCompletedWithWrappedCFException(g, ex);
1362 <        checkCompletedWithWrappedCFException(f, ex);
1363 <        r.assertNotInvoked();
1361 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1362 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1363 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1364 >        checkIncomplete(h0);
1365 >        checkIncomplete(h1);
1366 >        checkIncomplete(h2);
1367 >        assertTrue(f.completeExceptionally(ex));
1368 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1369 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1370 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1371 >
1372 >        checkCompletedWithWrappedException(h0, ex);
1373 >        checkCompletedWithWrappedException(h1, ex);
1374 >        checkCompletedWithWrappedException(h2, ex);
1375 >        checkCompletedWithWrappedException(h3, ex);
1376 >        checkCompletedWithWrappedException(h4, ex);
1377 >        checkCompletedWithWrappedException(h5, ex);
1378 >        checkCompletedExceptionally(f, ex);
1379 >        for (Noop r : rs) r.assertNotInvoked();
1380      }}
1381  
1382      /**
# Line 1114 | Line 1384 | public class CompletableFutureTest exten
1384       */
1385      public void testThenRun_sourceCancelled() {
1386          for (ExecutionMode m : ExecutionMode.values())
1117        for (boolean createIncomplete : new boolean[] { true, false })
1387          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1388      {
1389          final CompletableFuture<Integer> f = new CompletableFuture<>();
1390 <        final Noop r = new Noop(m);
1391 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1123 <        final CompletableFuture<Void> g = m.thenRun(f, r);
1124 <        if (createIncomplete) {
1125 <            checkIncomplete(g);
1126 <            assertTrue(f.cancel(mayInterruptIfRunning));
1127 <        }
1390 >        final Noop[] rs = new Noop[6];
1391 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
1392  
1393 <        checkCompletedWithWrappedCancellationException(g);
1393 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1394 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1395 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1396 >        checkIncomplete(h0);
1397 >        checkIncomplete(h1);
1398 >        checkIncomplete(h2);
1399 >        assertTrue(f.cancel(mayInterruptIfRunning));
1400 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1401 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1402 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1403 >
1404 >        checkCompletedWithWrappedCancellationException(h0);
1405 >        checkCompletedWithWrappedCancellationException(h1);
1406 >        checkCompletedWithWrappedCancellationException(h2);
1407 >        checkCompletedWithWrappedCancellationException(h3);
1408 >        checkCompletedWithWrappedCancellationException(h4);
1409 >        checkCompletedWithWrappedCancellationException(h5);
1410          checkCancelled(f);
1411 <        r.assertNotInvoked();
1411 >        for (Noop r : rs) r.assertNotInvoked();
1412      }}
1413  
1414      /**
# Line 1136 | Line 1416 | public class CompletableFutureTest exten
1416       */
1417      public void testThenRun_actionFailed() {
1418          for (ExecutionMode m : ExecutionMode.values())
1139        for (boolean createIncomplete : new boolean[] { true, false })
1419          for (Integer v1 : new Integer[] { 1, null })
1420      {
1421          final CompletableFuture<Integer> f = new CompletableFuture<>();
1422 <        final FailingRunnable r = new FailingRunnable(m);
1423 <        if (!createIncomplete) f.complete(v1);
1145 <        final CompletableFuture<Void> g = m.thenRun(f, r);
1146 <        if (createIncomplete) {
1147 <            checkIncomplete(g);
1148 <            f.complete(v1);
1149 <        }
1422 >        final FailingRunnable[] rs = new FailingRunnable[6];
1423 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
1424  
1425 <        checkCompletedWithWrappedCFException(g);
1425 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1426 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1427 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1428 >        assertTrue(f.complete(v1));
1429 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1430 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1431 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1432 >
1433 >        checkCompletedWithWrappedCFException(h0);
1434 >        checkCompletedWithWrappedCFException(h1);
1435 >        checkCompletedWithWrappedCFException(h2);
1436 >        checkCompletedWithWrappedCFException(h3);
1437 >        checkCompletedWithWrappedCFException(h4);
1438 >        checkCompletedWithWrappedCFException(h5);
1439          checkCompletedNormally(f, v1);
1440      }}
1441  
# Line 1157 | Line 1444 | public class CompletableFutureTest exten
1444       */
1445      public void testThenApply_normalCompletion() {
1446          for (ExecutionMode m : ExecutionMode.values())
1160        for (boolean createIncomplete : new boolean[] { true, false })
1447          for (Integer v1 : new Integer[] { 1, null })
1448      {
1449          final CompletableFuture<Integer> f = new CompletableFuture<>();
1450 <        final IncFunction r = new IncFunction(m);
1451 <        if (!createIncomplete) f.complete(v1);
1166 <        final CompletableFuture<Integer> g = m.thenApply(f, r);
1167 <        if (createIncomplete) {
1168 <            checkIncomplete(g);
1169 <            f.complete(v1);
1170 <        }
1450 >        final IncFunction[] rs = new IncFunction[4];
1451 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1452  
1453 <        checkCompletedNormally(g, inc(v1));
1453 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1454 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1455 >        checkIncomplete(h0);
1456 >        checkIncomplete(h1);
1457 >        assertTrue(f.complete(v1));
1458 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1459 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1460 >
1461 >        checkCompletedNormally(h0, inc(v1));
1462 >        checkCompletedNormally(h1, inc(v1));
1463 >        checkCompletedNormally(h2, inc(v1));
1464 >        checkCompletedNormally(h3, inc(v1));
1465          checkCompletedNormally(f, v1);
1466 <        r.assertValue(inc(v1));
1466 >        for (IncFunction r : rs) r.assertValue(inc(v1));
1467      }}
1468  
1469      /**
# Line 1180 | Line 1472 | public class CompletableFutureTest exten
1472       */
1473      public void testThenApply_exceptionalCompletion() {
1474          for (ExecutionMode m : ExecutionMode.values())
1183        for (boolean createIncomplete : new boolean[] { true, false })
1475      {
1476          final CFException ex = new CFException();
1477          final CompletableFuture<Integer> f = new CompletableFuture<>();
1478 <        final IncFunction r = new IncFunction(m);
1479 <        if (!createIncomplete) f.completeExceptionally(ex);
1189 <        final CompletableFuture<Integer> g = m.thenApply(f, r);
1190 <        if (createIncomplete) {
1191 <            checkIncomplete(g);
1192 <            f.completeExceptionally(ex);
1193 <        }
1478 >        final IncFunction[] rs = new IncFunction[4];
1479 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1480  
1481 <        checkCompletedWithWrappedCFException(g, ex);
1482 <        checkCompletedWithWrappedCFException(f, ex);
1483 <        r.assertNotInvoked();
1481 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1482 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1483 >        assertTrue(f.completeExceptionally(ex));
1484 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1485 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1486 >
1487 >        checkCompletedWithWrappedException(h0, ex);
1488 >        checkCompletedWithWrappedException(h1, ex);
1489 >        checkCompletedWithWrappedException(h2, ex);
1490 >        checkCompletedWithWrappedException(h3, ex);
1491 >        checkCompletedExceptionally(f, ex);
1492 >        for (IncFunction r : rs) r.assertNotInvoked();
1493      }}
1494  
1495      /**
# Line 1202 | Line 1497 | public class CompletableFutureTest exten
1497       */
1498      public void testThenApply_sourceCancelled() {
1499          for (ExecutionMode m : ExecutionMode.values())
1205        for (boolean createIncomplete : new boolean[] { true, false })
1500          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1501      {
1502          final CompletableFuture<Integer> f = new CompletableFuture<>();
1503 <        final IncFunction r = new IncFunction(m);
1504 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1211 <        final CompletableFuture<Integer> g = m.thenApply(f, r);
1212 <        if (createIncomplete) {
1213 <            checkIncomplete(g);
1214 <            assertTrue(f.cancel(mayInterruptIfRunning));
1215 <        }
1503 >        final IncFunction[] rs = new IncFunction[4];
1504 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1505  
1506 <        checkCompletedWithWrappedCancellationException(g);
1506 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1507 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1508 >        assertTrue(f.cancel(mayInterruptIfRunning));
1509 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1510 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1511 >
1512 >        checkCompletedWithWrappedCancellationException(h0);
1513 >        checkCompletedWithWrappedCancellationException(h1);
1514 >        checkCompletedWithWrappedCancellationException(h2);
1515 >        checkCompletedWithWrappedCancellationException(h3);
1516          checkCancelled(f);
1517 <        r.assertNotInvoked();
1517 >        for (IncFunction r : rs) r.assertNotInvoked();
1518      }}
1519  
1520      /**
# Line 1224 | Line 1522 | public class CompletableFutureTest exten
1522       */
1523      public void testThenApply_actionFailed() {
1524          for (ExecutionMode m : ExecutionMode.values())
1227        for (boolean createIncomplete : new boolean[] { true, false })
1525          for (Integer v1 : new Integer[] { 1, null })
1526      {
1527          final CompletableFuture<Integer> f = new CompletableFuture<>();
1528 <        final FailingFunction r = new FailingFunction(m);
1529 <        if (!createIncomplete) f.complete(v1);
1233 <        final CompletableFuture<Integer> g = m.thenApply(f, r);
1234 <        if (createIncomplete) {
1235 <            checkIncomplete(g);
1236 <            f.complete(v1);
1237 <        }
1528 >        final FailingFunction[] rs = new FailingFunction[4];
1529 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
1530  
1531 <        checkCompletedWithWrappedCFException(g);
1531 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1532 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1533 >        assertTrue(f.complete(v1));
1534 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1535 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1536 >
1537 >        checkCompletedWithWrappedCFException(h0);
1538 >        checkCompletedWithWrappedCFException(h1);
1539 >        checkCompletedWithWrappedCFException(h2);
1540 >        checkCompletedWithWrappedCFException(h3);
1541          checkCompletedNormally(f, v1);
1542      }}
1543  
# Line 1245 | Line 1546 | public class CompletableFutureTest exten
1546       */
1547      public void testThenAccept_normalCompletion() {
1548          for (ExecutionMode m : ExecutionMode.values())
1248        for (boolean createIncomplete : new boolean[] { true, false })
1549          for (Integer v1 : new Integer[] { 1, null })
1550      {
1551          final CompletableFuture<Integer> f = new CompletableFuture<>();
1552 <        final NoopConsumer r = new NoopConsumer(m);
1553 <        if (!createIncomplete) f.complete(v1);
1254 <        final CompletableFuture<Void> g = m.thenAccept(f, r);
1255 <        if (createIncomplete) {
1256 <            checkIncomplete(g);
1257 <            f.complete(v1);
1258 <        }
1552 >        final NoopConsumer[] rs = new NoopConsumer[4];
1553 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
1554  
1555 <        checkCompletedNormally(g, null);
1556 <        r.assertValue(v1);
1555 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1556 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1557 >        checkIncomplete(h0);
1558 >        checkIncomplete(h1);
1559 >        assertTrue(f.complete(v1));
1560 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1561 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1562 >
1563 >        checkCompletedNormally(h0, null);
1564 >        checkCompletedNormally(h1, null);
1565 >        checkCompletedNormally(h2, null);
1566 >        checkCompletedNormally(h3, null);
1567          checkCompletedNormally(f, v1);
1568 +        for (NoopConsumer r : rs) r.assertValue(v1);
1569      }}
1570  
1571      /**
# Line 1268 | Line 1574 | public class CompletableFutureTest exten
1574       */
1575      public void testThenAccept_exceptionalCompletion() {
1576          for (ExecutionMode m : ExecutionMode.values())
1271        for (boolean createIncomplete : new boolean[] { true, false })
1577      {
1578          final CFException ex = new CFException();
1579          final CompletableFuture<Integer> f = new CompletableFuture<>();
1580 <        final NoopConsumer r = new NoopConsumer(m);
1581 <        if (!createIncomplete) f.completeExceptionally(ex);
1277 <        final CompletableFuture<Void> g = m.thenAccept(f, r);
1278 <        if (createIncomplete) {
1279 <            checkIncomplete(g);
1280 <            f.completeExceptionally(ex);
1281 <        }
1580 >        final NoopConsumer[] rs = new NoopConsumer[4];
1581 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
1582  
1583 <        checkCompletedWithWrappedCFException(g, ex);
1584 <        checkCompletedWithWrappedCFException(f, ex);
1585 <        r.assertNotInvoked();
1583 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1584 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1585 >        assertTrue(f.completeExceptionally(ex));
1586 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1587 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1588 >
1589 >        checkCompletedWithWrappedException(h0, ex);
1590 >        checkCompletedWithWrappedException(h1, ex);
1591 >        checkCompletedWithWrappedException(h2, ex);
1592 >        checkCompletedWithWrappedException(h3, ex);
1593 >        checkCompletedExceptionally(f, ex);
1594 >        for (NoopConsumer r : rs) r.assertNotInvoked();
1595      }}
1596  
1597      /**
# Line 1290 | Line 1599 | public class CompletableFutureTest exten
1599       */
1600      public void testThenAccept_sourceCancelled() {
1601          for (ExecutionMode m : ExecutionMode.values())
1293        for (boolean createIncomplete : new boolean[] { true, false })
1602          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1603      {
1604          final CompletableFuture<Integer> f = new CompletableFuture<>();
1605 <        final NoopConsumer r = new NoopConsumer(m);
1606 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1299 <        final CompletableFuture<Void> g = m.thenAccept(f, r);
1300 <        if (createIncomplete) {
1301 <            checkIncomplete(g);
1302 <            assertTrue(f.cancel(mayInterruptIfRunning));
1303 <        }
1605 >        final NoopConsumer[] rs = new NoopConsumer[4];
1606 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
1607  
1608 <        checkCompletedWithWrappedCancellationException(g);
1608 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1609 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1610 >        assertTrue(f.cancel(mayInterruptIfRunning));
1611 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1612 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1613 >
1614 >        checkCompletedWithWrappedCancellationException(h0);
1615 >        checkCompletedWithWrappedCancellationException(h1);
1616 >        checkCompletedWithWrappedCancellationException(h2);
1617 >        checkCompletedWithWrappedCancellationException(h3);
1618          checkCancelled(f);
1619 <        r.assertNotInvoked();
1619 >        for (NoopConsumer r : rs) r.assertNotInvoked();
1620      }}
1621  
1622      /**
# Line 1312 | Line 1624 | public class CompletableFutureTest exten
1624       */
1625      public void testThenAccept_actionFailed() {
1626          for (ExecutionMode m : ExecutionMode.values())
1315        for (boolean createIncomplete : new boolean[] { true, false })
1627          for (Integer v1 : new Integer[] { 1, null })
1628      {
1629          final CompletableFuture<Integer> f = new CompletableFuture<>();
1630 <        final FailingConsumer r = new FailingConsumer(m);
1631 <        if (!createIncomplete) f.complete(v1);
1321 <        final CompletableFuture<Void> g = m.thenAccept(f, r);
1322 <        if (createIncomplete) {
1323 <            checkIncomplete(g);
1324 <            f.complete(v1);
1325 <        }
1630 >        final FailingConsumer[] rs = new FailingConsumer[4];
1631 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
1632  
1633 <        checkCompletedWithWrappedCFException(g);
1633 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1634 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1635 >        assertTrue(f.complete(v1));
1636 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1637 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1638 >
1639 >        checkCompletedWithWrappedCFException(h0);
1640 >        checkCompletedWithWrappedCFException(h1);
1641 >        checkCompletedWithWrappedCFException(h2);
1642 >        checkCompletedWithWrappedCFException(h3);
1643          checkCompletedNormally(f, v1);
1644      }}
1645  
# Line 1334 | Line 1649 | public class CompletableFutureTest exten
1649       */
1650      public void testThenCombine_normalCompletion() {
1651          for (ExecutionMode m : ExecutionMode.values())
1337        for (boolean createIncomplete : new boolean[] { true, false })
1652          for (boolean fFirst : new boolean[] { true, false })
1653          for (Integer v1 : new Integer[] { 1, null })
1654          for (Integer v2 : new Integer[] { 2, null })
1655      {
1656          final CompletableFuture<Integer> f = new CompletableFuture<>();
1657          final CompletableFuture<Integer> g = new CompletableFuture<>();
1658 <        final SubtractFunction r = new SubtractFunction(m);
1658 >        final SubtractFunction[] rs = new SubtractFunction[6];
1659 >        for (int i = 0; i < rs.length; i++) rs[i] = new SubtractFunction(m);
1660  
1661 <        if (fFirst) f.complete(v1); else g.complete(v2);
1662 <        if (!createIncomplete)
1663 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1664 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1665 <        if (createIncomplete) {
1666 <            checkIncomplete(h);
1667 <            r.assertNotInvoked();
1668 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1669 <        }
1661 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1662 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1663 >        final Integer w1 =  fFirst ? v1 : v2;
1664 >        final Integer w2 = !fFirst ? v1 : v2;
1665 >
1666 >        final CompletableFuture<Integer> h0 = m.thenCombine(f, g, rs[0]);
1667 >        final CompletableFuture<Integer> h1 = m.thenCombine(fst, fst, rs[1]);
1668 >        assertTrue(fst.complete(w1));
1669 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, rs[2]);
1670 >        final CompletableFuture<Integer> h3 = m.thenCombine(fst, fst, rs[3]);
1671 >        checkIncomplete(h0); rs[0].assertNotInvoked();
1672 >        checkIncomplete(h2); rs[2].assertNotInvoked();
1673 >        checkCompletedNormally(h1, subtract(w1, w1));
1674 >        checkCompletedNormally(h3, subtract(w1, w1));
1675 >        rs[1].assertValue(subtract(w1, w1));
1676 >        rs[3].assertValue(subtract(w1, w1));
1677 >        assertTrue(snd.complete(w2));
1678 >        final CompletableFuture<Integer> h4 = m.thenCombine(f, g, rs[4]);
1679 >
1680 >        checkCompletedNormally(h0, subtract(v1, v2));
1681 >        checkCompletedNormally(h2, subtract(v1, v2));
1682 >        checkCompletedNormally(h4, subtract(v1, v2));
1683 >        rs[0].assertValue(subtract(v1, v2));
1684 >        rs[2].assertValue(subtract(v1, v2));
1685 >        rs[4].assertValue(subtract(v1, v2));
1686  
1356        checkCompletedNormally(h, subtract(v1, v2));
1687          checkCompletedNormally(f, v1);
1688          checkCompletedNormally(g, v2);
1359        r.assertValue(subtract(v1, v2));
1689      }}
1690  
1691      /**
1692       * thenCombine result completes exceptionally after exceptional
1693       * completion of either source
1694       */
1695 <    public void testThenCombine_exceptionalCompletion() {
1695 >    public void testThenCombine_exceptionalCompletion() throws Throwable {
1696          for (ExecutionMode m : ExecutionMode.values())
1368        for (boolean createIncomplete : new boolean[] { true, false })
1697          for (boolean fFirst : new boolean[] { true, false })
1698 +        for (boolean failFirst : new boolean[] { true, false })
1699          for (Integer v1 : new Integer[] { 1, null })
1700      {
1701          final CompletableFuture<Integer> f = new CompletableFuture<>();
1702          final CompletableFuture<Integer> g = new CompletableFuture<>();
1703          final CFException ex = new CFException();
1704 <        final SubtractFunction r = new SubtractFunction(m);
1705 <
1706 <        (fFirst ? f : g).complete(v1);
1707 <        if (!createIncomplete)
1708 <            (!fFirst ? f : g).completeExceptionally(ex);
1709 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1710 <        if (createIncomplete) {
1711 <            checkIncomplete(h);
1712 <            (!fFirst ? f : g).completeExceptionally(ex);
1713 <        }
1714 <
1715 <        checkCompletedWithWrappedCFException(h, ex);
1716 <        r.assertNotInvoked();
1717 <        checkCompletedNormally(fFirst ? f : g, v1);
1718 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1704 >        final SubtractFunction r1 = new SubtractFunction(m);
1705 >        final SubtractFunction r2 = new SubtractFunction(m);
1706 >        final SubtractFunction r3 = new SubtractFunction(m);
1707 >
1708 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1709 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1710 >        final Callable<Boolean> complete1 = failFirst ?
1711 >            () -> fst.completeExceptionally(ex) :
1712 >            () -> fst.complete(v1);
1713 >        final Callable<Boolean> complete2 = failFirst ?
1714 >            () -> snd.complete(v1) :
1715 >            () -> snd.completeExceptionally(ex);
1716 >
1717 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1718 >        assertTrue(complete1.call());
1719 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1720 >        checkIncomplete(h1);
1721 >        checkIncomplete(h2);
1722 >        assertTrue(complete2.call());
1723 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1724 >
1725 >        checkCompletedWithWrappedException(h1, ex);
1726 >        checkCompletedWithWrappedException(h2, ex);
1727 >        checkCompletedWithWrappedException(h3, ex);
1728 >        r1.assertNotInvoked();
1729 >        r2.assertNotInvoked();
1730 >        r3.assertNotInvoked();
1731 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1732 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1733      }}
1734  
1735      /**
1736       * thenCombine result completes exceptionally if either source cancelled
1737       */
1738 <    public void testThenCombine_sourceCancelled() {
1738 >    public void testThenCombine_sourceCancelled() throws Throwable {
1739          for (ExecutionMode m : ExecutionMode.values())
1740          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1398        for (boolean createIncomplete : new boolean[] { true, false })
1741          for (boolean fFirst : new boolean[] { true, false })
1742 +        for (boolean failFirst : new boolean[] { true, false })
1743          for (Integer v1 : new Integer[] { 1, null })
1744      {
1745          final CompletableFuture<Integer> f = new CompletableFuture<>();
1746          final CompletableFuture<Integer> g = new CompletableFuture<>();
1747 <        final SubtractFunction r = new SubtractFunction(m);
1747 >        final SubtractFunction r1 = new SubtractFunction(m);
1748 >        final SubtractFunction r2 = new SubtractFunction(m);
1749 >        final SubtractFunction r3 = new SubtractFunction(m);
1750  
1751 <        (fFirst ? f : g).complete(v1);
1752 <        if (!createIncomplete)
1753 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1754 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1755 <        if (createIncomplete) {
1756 <            checkIncomplete(h);
1757 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1758 <        }
1751 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1752 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1753 >        final Callable<Boolean> complete1 = failFirst ?
1754 >            () -> fst.cancel(mayInterruptIfRunning) :
1755 >            () -> fst.complete(v1);
1756 >        final Callable<Boolean> complete2 = failFirst ?
1757 >            () -> snd.complete(v1) :
1758 >            () -> snd.cancel(mayInterruptIfRunning);
1759  
1760 <        checkCompletedWithWrappedCancellationException(h);
1761 <        checkCancelled(!fFirst ? f : g);
1762 <        r.assertNotInvoked();
1763 <        checkCompletedNormally(fFirst ? f : g, v1);
1760 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1761 >        assertTrue(complete1.call());
1762 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1763 >        checkIncomplete(h1);
1764 >        checkIncomplete(h2);
1765 >        assertTrue(complete2.call());
1766 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1767 >
1768 >        checkCompletedWithWrappedCancellationException(h1);
1769 >        checkCompletedWithWrappedCancellationException(h2);
1770 >        checkCompletedWithWrappedCancellationException(h3);
1771 >        r1.assertNotInvoked();
1772 >        r2.assertNotInvoked();
1773 >        r3.assertNotInvoked();
1774 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1775 >        checkCancelled(failFirst ? fst : snd);
1776      }}
1777  
1778      /**
# Line 1429 | Line 1786 | public class CompletableFutureTest exten
1786      {
1787          final CompletableFuture<Integer> f = new CompletableFuture<>();
1788          final CompletableFuture<Integer> g = new CompletableFuture<>();
1789 <        final FailingBiFunction r = new FailingBiFunction(m);
1790 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1791 <
1792 <        if (fFirst) {
1793 <            f.complete(v1);
1794 <            g.complete(v2);
1795 <        } else {
1796 <            g.complete(v2);
1797 <            f.complete(v1);
1798 <        }
1789 >        final FailingBiFunction r1 = new FailingBiFunction(m);
1790 >        final FailingBiFunction r2 = new FailingBiFunction(m);
1791 >        final FailingBiFunction r3 = new FailingBiFunction(m);
1792 >
1793 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1794 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1795 >        final Integer w1 =  fFirst ? v1 : v2;
1796 >        final Integer w2 = !fFirst ? v1 : v2;
1797 >
1798 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1799 >        assertTrue(fst.complete(w1));
1800 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1801 >        assertTrue(snd.complete(w2));
1802 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1803  
1804 <        checkCompletedWithWrappedCFException(h);
1804 >        checkCompletedWithWrappedCFException(h1);
1805 >        checkCompletedWithWrappedCFException(h2);
1806 >        checkCompletedWithWrappedCFException(h3);
1807 >        r1.assertInvoked();
1808 >        r2.assertInvoked();
1809 >        r3.assertInvoked();
1810          checkCompletedNormally(f, v1);
1811          checkCompletedNormally(g, v2);
1812      }}
# Line 1451 | Line 1817 | public class CompletableFutureTest exten
1817       */
1818      public void testThenAcceptBoth_normalCompletion() {
1819          for (ExecutionMode m : ExecutionMode.values())
1454        for (boolean createIncomplete : new boolean[] { true, false })
1820          for (boolean fFirst : new boolean[] { true, false })
1821          for (Integer v1 : new Integer[] { 1, null })
1822          for (Integer v2 : new Integer[] { 2, null })
1823      {
1824          final CompletableFuture<Integer> f = new CompletableFuture<>();
1825          final CompletableFuture<Integer> g = new CompletableFuture<>();
1826 <        final SubtractAction r = new SubtractAction(m);
1827 <
1828 <        if (fFirst) f.complete(v1); else g.complete(v2);
1829 <        if (!createIncomplete)
1830 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1831 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1832 <        if (createIncomplete) {
1833 <            checkIncomplete(h);
1834 <            r.assertNotInvoked();
1835 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1836 <        }
1826 >        final SubtractAction r1 = new SubtractAction(m);
1827 >        final SubtractAction r2 = new SubtractAction(m);
1828 >        final SubtractAction r3 = new SubtractAction(m);
1829 >
1830 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1831 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1832 >        final Integer w1 =  fFirst ? v1 : v2;
1833 >        final Integer w2 = !fFirst ? v1 : v2;
1834 >
1835 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1836 >        assertTrue(fst.complete(w1));
1837 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1838 >        checkIncomplete(h1);
1839 >        checkIncomplete(h2);
1840 >        r1.assertNotInvoked();
1841 >        r2.assertNotInvoked();
1842 >        assertTrue(snd.complete(w2));
1843 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1844  
1845 <        checkCompletedNormally(h, null);
1846 <        r.assertValue(subtract(v1, v2));
1845 >        checkCompletedNormally(h1, null);
1846 >        checkCompletedNormally(h2, null);
1847 >        checkCompletedNormally(h3, null);
1848 >        r1.assertValue(subtract(v1, v2));
1849 >        r2.assertValue(subtract(v1, v2));
1850 >        r3.assertValue(subtract(v1, v2));
1851          checkCompletedNormally(f, v1);
1852          checkCompletedNormally(g, v2);
1853      }}
# Line 1480 | Line 1856 | public class CompletableFutureTest exten
1856       * thenAcceptBoth result completes exceptionally after exceptional
1857       * completion of either source
1858       */
1859 <    public void testThenAcceptBoth_exceptionalCompletion() {
1859 >    public void testThenAcceptBoth_exceptionalCompletion() throws Throwable {
1860          for (ExecutionMode m : ExecutionMode.values())
1485        for (boolean createIncomplete : new boolean[] { true, false })
1861          for (boolean fFirst : new boolean[] { true, false })
1862 +        for (boolean failFirst : new boolean[] { true, false })
1863          for (Integer v1 : new Integer[] { 1, null })
1864      {
1865          final CompletableFuture<Integer> f = new CompletableFuture<>();
1866          final CompletableFuture<Integer> g = new CompletableFuture<>();
1867          final CFException ex = new CFException();
1868 <        final SubtractAction r = new SubtractAction(m);
1869 <
1870 <        (fFirst ? f : g).complete(v1);
1871 <        if (!createIncomplete)
1872 <            (!fFirst ? f : g).completeExceptionally(ex);
1873 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1874 <        if (createIncomplete) {
1875 <            checkIncomplete(h);
1876 <            (!fFirst ? f : g).completeExceptionally(ex);
1877 <        }
1878 <
1879 <        checkCompletedWithWrappedCFException(h, ex);
1880 <        r.assertNotInvoked();
1881 <        checkCompletedNormally(fFirst ? f : g, v1);
1882 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1868 >        final SubtractAction r1 = new SubtractAction(m);
1869 >        final SubtractAction r2 = new SubtractAction(m);
1870 >        final SubtractAction r3 = new SubtractAction(m);
1871 >
1872 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1873 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1874 >        final Callable<Boolean> complete1 = failFirst ?
1875 >            () -> fst.completeExceptionally(ex) :
1876 >            () -> fst.complete(v1);
1877 >        final Callable<Boolean> complete2 = failFirst ?
1878 >            () -> snd.complete(v1) :
1879 >            () -> snd.completeExceptionally(ex);
1880 >
1881 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1882 >        assertTrue(complete1.call());
1883 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1884 >        checkIncomplete(h1);
1885 >        checkIncomplete(h2);
1886 >        assertTrue(complete2.call());
1887 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1888 >
1889 >        checkCompletedWithWrappedException(h1, ex);
1890 >        checkCompletedWithWrappedException(h2, ex);
1891 >        checkCompletedWithWrappedException(h3, ex);
1892 >        r1.assertNotInvoked();
1893 >        r2.assertNotInvoked();
1894 >        r3.assertNotInvoked();
1895 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1896 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1897      }}
1898  
1899      /**
1900       * thenAcceptBoth result completes exceptionally if either source cancelled
1901       */
1902 <    public void testThenAcceptBoth_sourceCancelled() {
1902 >    public void testThenAcceptBoth_sourceCancelled() throws Throwable {
1903          for (ExecutionMode m : ExecutionMode.values())
1904          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1515        for (boolean createIncomplete : new boolean[] { true, false })
1905          for (boolean fFirst : new boolean[] { true, false })
1906 +        for (boolean failFirst : new boolean[] { true, false })
1907          for (Integer v1 : new Integer[] { 1, null })
1908      {
1909          final CompletableFuture<Integer> f = new CompletableFuture<>();
1910          final CompletableFuture<Integer> g = new CompletableFuture<>();
1911 <        final SubtractAction r = new SubtractAction(m);
1911 >        final SubtractAction r1 = new SubtractAction(m);
1912 >        final SubtractAction r2 = new SubtractAction(m);
1913 >        final SubtractAction r3 = new SubtractAction(m);
1914  
1915 <        (fFirst ? f : g).complete(v1);
1916 <        if (!createIncomplete)
1917 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1918 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1919 <        if (createIncomplete) {
1920 <            checkIncomplete(h);
1921 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1922 <        }
1915 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1916 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1917 >        final Callable<Boolean> complete1 = failFirst ?
1918 >            () -> fst.cancel(mayInterruptIfRunning) :
1919 >            () -> fst.complete(v1);
1920 >        final Callable<Boolean> complete2 = failFirst ?
1921 >            () -> snd.complete(v1) :
1922 >            () -> snd.cancel(mayInterruptIfRunning);
1923  
1924 <        checkCompletedWithWrappedCancellationException(h);
1925 <        checkCancelled(!fFirst ? f : g);
1926 <        r.assertNotInvoked();
1927 <        checkCompletedNormally(fFirst ? f : g, v1);
1924 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1925 >        assertTrue(complete1.call());
1926 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1927 >        checkIncomplete(h1);
1928 >        checkIncomplete(h2);
1929 >        assertTrue(complete2.call());
1930 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1931 >
1932 >        checkCompletedWithWrappedCancellationException(h1);
1933 >        checkCompletedWithWrappedCancellationException(h2);
1934 >        checkCompletedWithWrappedCancellationException(h3);
1935 >        r1.assertNotInvoked();
1936 >        r2.assertNotInvoked();
1937 >        r3.assertNotInvoked();
1938 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1939 >        checkCancelled(failFirst ? fst : snd);
1940      }}
1941  
1942      /**
# Line 1546 | Line 1950 | public class CompletableFutureTest exten
1950      {
1951          final CompletableFuture<Integer> f = new CompletableFuture<>();
1952          final CompletableFuture<Integer> g = new CompletableFuture<>();
1953 <        final FailingBiConsumer r = new FailingBiConsumer(m);
1954 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1955 <
1956 <        if (fFirst) {
1957 <            f.complete(v1);
1958 <            g.complete(v2);
1959 <        } else {
1960 <            g.complete(v2);
1961 <            f.complete(v1);
1962 <        }
1953 >        final FailingBiConsumer r1 = new FailingBiConsumer(m);
1954 >        final FailingBiConsumer r2 = new FailingBiConsumer(m);
1955 >        final FailingBiConsumer r3 = new FailingBiConsumer(m);
1956 >
1957 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1958 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1959 >        final Integer w1 =  fFirst ? v1 : v2;
1960 >        final Integer w2 = !fFirst ? v1 : v2;
1961 >
1962 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1963 >        assertTrue(fst.complete(w1));
1964 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1965 >        assertTrue(snd.complete(w2));
1966 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1967  
1968 <        checkCompletedWithWrappedCFException(h);
1968 >        checkCompletedWithWrappedCFException(h1);
1969 >        checkCompletedWithWrappedCFException(h2);
1970 >        checkCompletedWithWrappedCFException(h3);
1971 >        r1.assertInvoked();
1972 >        r2.assertInvoked();
1973 >        r3.assertInvoked();
1974          checkCompletedNormally(f, v1);
1975          checkCompletedNormally(g, v2);
1976      }}
# Line 1568 | Line 1981 | public class CompletableFutureTest exten
1981       */
1982      public void testRunAfterBoth_normalCompletion() {
1983          for (ExecutionMode m : ExecutionMode.values())
1571        for (boolean createIncomplete : new boolean[] { true, false })
1984          for (boolean fFirst : new boolean[] { true, false })
1985          for (Integer v1 : new Integer[] { 1, null })
1986          for (Integer v2 : new Integer[] { 2, null })
1987      {
1988          final CompletableFuture<Integer> f = new CompletableFuture<>();
1989          final CompletableFuture<Integer> g = new CompletableFuture<>();
1990 <        final Noop r = new Noop(m);
1991 <
1992 <        if (fFirst) f.complete(v1); else g.complete(v2);
1993 <        if (!createIncomplete)
1994 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1995 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1996 <        if (createIncomplete) {
1997 <            checkIncomplete(h);
1998 <            r.assertNotInvoked();
1999 <            if (!fFirst) f.complete(v1); else g.complete(v2);
2000 <        }
1990 >        final Noop r1 = new Noop(m);
1991 >        final Noop r2 = new Noop(m);
1992 >        final Noop r3 = new Noop(m);
1993 >
1994 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1995 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1996 >        final Integer w1 =  fFirst ? v1 : v2;
1997 >        final Integer w2 = !fFirst ? v1 : v2;
1998 >
1999 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2000 >        assertTrue(fst.complete(w1));
2001 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2002 >        checkIncomplete(h1);
2003 >        checkIncomplete(h2);
2004 >        r1.assertNotInvoked();
2005 >        r2.assertNotInvoked();
2006 >        assertTrue(snd.complete(w2));
2007 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2008  
2009 <        checkCompletedNormally(h, null);
2010 <        r.assertInvoked();
2009 >        checkCompletedNormally(h1, null);
2010 >        checkCompletedNormally(h2, null);
2011 >        checkCompletedNormally(h3, null);
2012 >        r1.assertInvoked();
2013 >        r2.assertInvoked();
2014 >        r3.assertInvoked();
2015          checkCompletedNormally(f, v1);
2016          checkCompletedNormally(g, v2);
2017      }}
# Line 1597 | Line 2020 | public class CompletableFutureTest exten
2020       * runAfterBoth result completes exceptionally after exceptional
2021       * completion of either source
2022       */
2023 <    public void testRunAfterBoth_exceptionalCompletion() {
2023 >    public void testRunAfterBoth_exceptionalCompletion() throws Throwable {
2024          for (ExecutionMode m : ExecutionMode.values())
1602        for (boolean createIncomplete : new boolean[] { true, false })
2025          for (boolean fFirst : new boolean[] { true, false })
2026 +        for (boolean failFirst : new boolean[] { true, false })
2027          for (Integer v1 : new Integer[] { 1, null })
2028      {
2029          final CompletableFuture<Integer> f = new CompletableFuture<>();
2030          final CompletableFuture<Integer> g = new CompletableFuture<>();
2031          final CFException ex = new CFException();
2032 <        final Noop r = new Noop(m);
2033 <
2034 <        (fFirst ? f : g).complete(v1);
2035 <        if (!createIncomplete)
2036 <            (!fFirst ? f : g).completeExceptionally(ex);
2037 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2038 <        if (createIncomplete) {
2039 <            checkIncomplete(h);
2040 <            (!fFirst ? f : g).completeExceptionally(ex);
2041 <        }
2042 <
2043 <        checkCompletedWithWrappedCFException(h, ex);
2044 <        r.assertNotInvoked();
2045 <        checkCompletedNormally(fFirst ? f : g, v1);
2046 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
2032 >        final Noop r1 = new Noop(m);
2033 >        final Noop r2 = new Noop(m);
2034 >        final Noop r3 = new Noop(m);
2035 >
2036 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
2037 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
2038 >        final Callable<Boolean> complete1 = failFirst ?
2039 >            () -> fst.completeExceptionally(ex) :
2040 >            () -> fst.complete(v1);
2041 >        final Callable<Boolean> complete2 = failFirst ?
2042 >            () -> snd.complete(v1) :
2043 >            () -> snd.completeExceptionally(ex);
2044 >
2045 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2046 >        assertTrue(complete1.call());
2047 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2048 >        checkIncomplete(h1);
2049 >        checkIncomplete(h2);
2050 >        assertTrue(complete2.call());
2051 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2052 >
2053 >        checkCompletedWithWrappedException(h1, ex);
2054 >        checkCompletedWithWrappedException(h2, ex);
2055 >        checkCompletedWithWrappedException(h3, ex);
2056 >        r1.assertNotInvoked();
2057 >        r2.assertNotInvoked();
2058 >        r3.assertNotInvoked();
2059 >        checkCompletedNormally(failFirst ? snd : fst, v1);
2060 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
2061      }}
2062  
2063      /**
2064       * runAfterBoth result completes exceptionally if either source cancelled
2065       */
2066 <    public void testRunAfterBoth_sourceCancelled() {
2066 >    public void testRunAfterBoth_sourceCancelled() throws Throwable {
2067          for (ExecutionMode m : ExecutionMode.values())
2068          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1632        for (boolean createIncomplete : new boolean[] { true, false })
2069          for (boolean fFirst : new boolean[] { true, false })
2070 +        for (boolean failFirst : new boolean[] { true, false })
2071          for (Integer v1 : new Integer[] { 1, null })
2072      {
2073          final CompletableFuture<Integer> f = new CompletableFuture<>();
2074          final CompletableFuture<Integer> g = new CompletableFuture<>();
2075 <        final Noop r = new Noop(m);
2075 >        final Noop r1 = new Noop(m);
2076 >        final Noop r2 = new Noop(m);
2077 >        final Noop r3 = new Noop(m);
2078  
2079 +        final CompletableFuture<Integer> fst =  fFirst ? f : g;
2080 +        final CompletableFuture<Integer> snd = !fFirst ? f : g;
2081 +        final Callable<Boolean> complete1 = failFirst ?
2082 +            () -> fst.cancel(mayInterruptIfRunning) :
2083 +            () -> fst.complete(v1);
2084 +        final Callable<Boolean> complete2 = failFirst ?
2085 +            () -> snd.complete(v1) :
2086 +            () -> snd.cancel(mayInterruptIfRunning);
2087  
2088 <        (fFirst ? f : g).complete(v1);
2089 <        if (!createIncomplete)
2090 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
2091 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2092 <        if (createIncomplete) {
2093 <            checkIncomplete(h);
2094 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1648 <        }
2088 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2089 >        assertTrue(complete1.call());
2090 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2091 >        checkIncomplete(h1);
2092 >        checkIncomplete(h2);
2093 >        assertTrue(complete2.call());
2094 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2095  
2096 <        checkCompletedWithWrappedCancellationException(h);
2097 <        checkCancelled(!fFirst ? f : g);
2098 <        r.assertNotInvoked();
2099 <        checkCompletedNormally(fFirst ? f : g, v1);
2096 >        checkCompletedWithWrappedCancellationException(h1);
2097 >        checkCompletedWithWrappedCancellationException(h2);
2098 >        checkCompletedWithWrappedCancellationException(h3);
2099 >        r1.assertNotInvoked();
2100 >        r2.assertNotInvoked();
2101 >        r3.assertNotInvoked();
2102 >        checkCompletedNormally(failFirst ? snd : fst, v1);
2103 >        checkCancelled(failFirst ? fst : snd);
2104      }}
2105  
2106      /**
# Line 1666 | Line 2116 | public class CompletableFutureTest exten
2116          final CompletableFuture<Integer> g = new CompletableFuture<>();
2117          final FailingRunnable r1 = new FailingRunnable(m);
2118          final FailingRunnable r2 = new FailingRunnable(m);
2119 +        final FailingRunnable r3 = new FailingRunnable(m);
2120  
2121 <        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2122 <        if (fFirst) {
2123 <            f.complete(v1);
2124 <            g.complete(v2);
2125 <        } else {
2126 <            g.complete(v2);
2127 <            f.complete(v1);
2128 <        }
2129 <        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2121 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
2122 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
2123 >        final Integer w1 =  fFirst ? v1 : v2;
2124 >        final Integer w2 = !fFirst ? v1 : v2;
2125 >
2126 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2127 >        assertTrue(fst.complete(w1));
2128 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2129 >        assertTrue(snd.complete(w2));
2130 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2131  
2132          checkCompletedWithWrappedCFException(h1);
2133          checkCompletedWithWrappedCFException(h2);
2134 +        checkCompletedWithWrappedCFException(h3);
2135 +        r1.assertInvoked();
2136 +        r2.assertInvoked();
2137 +        r3.assertInvoked();
2138          checkCompletedNormally(f, v1);
2139          checkCompletedNormally(g, v2);
2140      }}
# Line 1752 | Line 2208 | public class CompletableFutureTest exten
2208          rs[0].assertNotInvoked();
2209          rs[1].assertNotInvoked();
2210          f.completeExceptionally(ex);
2211 <        checkCompletedWithWrappedCFException(h0, ex);
2212 <        checkCompletedWithWrappedCFException(h1, ex);
2211 >        checkCompletedWithWrappedException(h0, ex);
2212 >        checkCompletedWithWrappedException(h1, ex);
2213          final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2214          final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2215 <        checkCompletedWithWrappedCFException(h2, ex);
2216 <        checkCompletedWithWrappedCFException(h3, ex);
2215 >        checkCompletedWithWrappedException(h2, ex);
2216 >        checkCompletedWithWrappedException(h3, ex);
2217          g.complete(v1);
2218  
2219          // unspecified behavior - both source completions available
# Line 1767 | Line 2223 | public class CompletableFutureTest exten
2223              assertEquals(inc(v1), h4.join());
2224              rs[4].assertValue(inc(v1));
2225          } catch (CompletionException ok) {
2226 <            checkCompletedWithWrappedCFException(h4, ex);
2226 >            checkCompletedWithWrappedException(h4, ex);
2227              rs[4].assertNotInvoked();
2228          }
2229          try {
2230              assertEquals(inc(v1), h5.join());
2231              rs[5].assertValue(inc(v1));
2232          } catch (CompletionException ok) {
2233 <            checkCompletedWithWrappedCFException(h5, ex);
2233 >            checkCompletedWithWrappedException(h5, ex);
2234              rs[5].assertNotInvoked();
2235          }
2236  
2237 <        checkCompletedWithWrappedCFException(f, ex);
2237 >        checkCompletedExceptionally(f, ex);
2238          checkCompletedNormally(g, v1);
2239 <        checkCompletedWithWrappedCFException(h0, ex);
2240 <        checkCompletedWithWrappedCFException(h1, ex);
2241 <        checkCompletedWithWrappedCFException(h2, ex);
2242 <        checkCompletedWithWrappedCFException(h3, ex);
2243 <        checkCompletedWithWrappedCFException(h4, ex);
2239 >        checkCompletedWithWrappedException(h0, ex);
2240 >        checkCompletedWithWrappedException(h1, ex);
2241 >        checkCompletedWithWrappedException(h2, ex);
2242 >        checkCompletedWithWrappedException(h3, ex);
2243 >        checkCompletedWithWrappedException(h4, ex);
2244          for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2245      }}
2246  
# Line 1801 | Line 2257 | public class CompletableFutureTest exten
2257  
2258          final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2259          final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2260 <        if (fFirst) {
2261 <            f.complete(v1);
1806 <            g.completeExceptionally(ex);
1807 <        } else {
1808 <            g.completeExceptionally(ex);
1809 <            f.complete(v1);
1810 <        }
2260 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2261 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2262          final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2263          final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2264  
# Line 1816 | Line 2267 | public class CompletableFutureTest exten
2267              assertEquals(inc(v1), h0.join());
2268              rs[0].assertValue(inc(v1));
2269          } catch (CompletionException ok) {
2270 <            checkCompletedWithWrappedCFException(h0, ex);
2270 >            checkCompletedWithWrappedException(h0, ex);
2271              rs[0].assertNotInvoked();
2272          }
2273          try {
2274              assertEquals(inc(v1), h1.join());
2275              rs[1].assertValue(inc(v1));
2276          } catch (CompletionException ok) {
2277 <            checkCompletedWithWrappedCFException(h1, ex);
2277 >            checkCompletedWithWrappedException(h1, ex);
2278              rs[1].assertNotInvoked();
2279          }
2280          try {
2281              assertEquals(inc(v1), h2.join());
2282              rs[2].assertValue(inc(v1));
2283          } catch (CompletionException ok) {
2284 <            checkCompletedWithWrappedCFException(h2, ex);
2284 >            checkCompletedWithWrappedException(h2, ex);
2285              rs[2].assertNotInvoked();
2286          }
2287          try {
2288              assertEquals(inc(v1), h3.join());
2289              rs[3].assertValue(inc(v1));
2290          } catch (CompletionException ok) {
2291 <            checkCompletedWithWrappedCFException(h3, ex);
2291 >            checkCompletedWithWrappedException(h3, ex);
2292              rs[3].assertNotInvoked();
2293          }
2294  
2295          checkCompletedNormally(f, v1);
2296 <        checkCompletedWithWrappedCFException(g, ex);
2296 >        checkCompletedExceptionally(g, ex);
2297      }}
2298  
2299      /**
# Line 1913 | Line 2364 | public class CompletableFutureTest exten
2364  
2365          final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2366          final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2367 <        if (fFirst) {
2368 <            f.complete(v1);
1918 <            g.cancel(mayInterruptIfRunning);
1919 <        } else {
1920 <            g.cancel(mayInterruptIfRunning);
1921 <            f.complete(v1);
1922 <        }
2367 >        assertTrue(fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2368 >        assertTrue(!fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2369          final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2370          final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2371  
# Line 2071 | Line 2517 | public class CompletableFutureTest exten
2517          rs[0].assertNotInvoked();
2518          rs[1].assertNotInvoked();
2519          f.completeExceptionally(ex);
2520 <        checkCompletedWithWrappedCFException(h0, ex);
2521 <        checkCompletedWithWrappedCFException(h1, ex);
2520 >        checkCompletedWithWrappedException(h0, ex);
2521 >        checkCompletedWithWrappedException(h1, ex);
2522          final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2523          final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2524 <        checkCompletedWithWrappedCFException(h2, ex);
2525 <        checkCompletedWithWrappedCFException(h3, ex);
2524 >        checkCompletedWithWrappedException(h2, ex);
2525 >        checkCompletedWithWrappedException(h3, ex);
2526  
2527          g.complete(v1);
2528  
# Line 2087 | Line 2533 | public class CompletableFutureTest exten
2533              assertNull(h4.join());
2534              rs[4].assertValue(v1);
2535          } catch (CompletionException ok) {
2536 <            checkCompletedWithWrappedCFException(h4, ex);
2536 >            checkCompletedWithWrappedException(h4, ex);
2537              rs[4].assertNotInvoked();
2538          }
2539          try {
2540              assertNull(h5.join());
2541              rs[5].assertValue(v1);
2542          } catch (CompletionException ok) {
2543 <            checkCompletedWithWrappedCFException(h5, ex);
2543 >            checkCompletedWithWrappedException(h5, ex);
2544              rs[5].assertNotInvoked();
2545          }
2546  
2547 <        checkCompletedWithWrappedCFException(f, ex);
2547 >        checkCompletedExceptionally(f, ex);
2548          checkCompletedNormally(g, v1);
2549 <        checkCompletedWithWrappedCFException(h0, ex);
2550 <        checkCompletedWithWrappedCFException(h1, ex);
2551 <        checkCompletedWithWrappedCFException(h2, ex);
2552 <        checkCompletedWithWrappedCFException(h3, ex);
2553 <        checkCompletedWithWrappedCFException(h4, ex);
2549 >        checkCompletedWithWrappedException(h0, ex);
2550 >        checkCompletedWithWrappedException(h1, ex);
2551 >        checkCompletedWithWrappedException(h2, ex);
2552 >        checkCompletedWithWrappedException(h3, ex);
2553 >        checkCompletedWithWrappedException(h4, ex);
2554          for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2555      }}
2556  
# Line 2121 | Line 2567 | public class CompletableFutureTest exten
2567  
2568          final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2569          final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2570 <        if (fFirst) {
2571 <            f.complete(v1);
2126 <            g.completeExceptionally(ex);
2127 <        } else {
2128 <            g.completeExceptionally(ex);
2129 <            f.complete(v1);
2130 <        }
2570 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2571 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2572          final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2573          final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2574  
# Line 2136 | Line 2577 | public class CompletableFutureTest exten
2577              assertEquals(null, h0.join());
2578              rs[0].assertValue(v1);
2579          } catch (CompletionException ok) {
2580 <            checkCompletedWithWrappedCFException(h0, ex);
2580 >            checkCompletedWithWrappedException(h0, ex);
2581              rs[0].assertNotInvoked();
2582          }
2583          try {
2584              assertEquals(null, h1.join());
2585              rs[1].assertValue(v1);
2586          } catch (CompletionException ok) {
2587 <            checkCompletedWithWrappedCFException(h1, ex);
2587 >            checkCompletedWithWrappedException(h1, ex);
2588              rs[1].assertNotInvoked();
2589          }
2590          try {
2591              assertEquals(null, h2.join());
2592              rs[2].assertValue(v1);
2593          } catch (CompletionException ok) {
2594 <            checkCompletedWithWrappedCFException(h2, ex);
2594 >            checkCompletedWithWrappedException(h2, ex);
2595              rs[2].assertNotInvoked();
2596          }
2597          try {
2598              assertEquals(null, h3.join());
2599              rs[3].assertValue(v1);
2600          } catch (CompletionException ok) {
2601 <            checkCompletedWithWrappedCFException(h3, ex);
2601 >            checkCompletedWithWrappedException(h3, ex);
2602              rs[3].assertNotInvoked();
2603          }
2604  
2605          checkCompletedNormally(f, v1);
2606 <        checkCompletedWithWrappedCFException(g, ex);
2606 >        checkCompletedExceptionally(g, ex);
2607      }}
2608  
2609      /**
# Line 2330 | Line 2771 | public class CompletableFutureTest exten
2771          checkIncomplete(h1);
2772          rs[0].assertNotInvoked();
2773          rs[1].assertNotInvoked();
2774 <        f.completeExceptionally(ex);
2775 <        checkCompletedWithWrappedCFException(h0, ex);
2776 <        checkCompletedWithWrappedCFException(h1, ex);
2774 >        assertTrue(f.completeExceptionally(ex));
2775 >        checkCompletedWithWrappedException(h0, ex);
2776 >        checkCompletedWithWrappedException(h1, ex);
2777          final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2778          final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2779 <        checkCompletedWithWrappedCFException(h2, ex);
2780 <        checkCompletedWithWrappedCFException(h3, ex);
2779 >        checkCompletedWithWrappedException(h2, ex);
2780 >        checkCompletedWithWrappedException(h3, ex);
2781  
2782 <        g.complete(v1);
2782 >        assertTrue(g.complete(v1));
2783  
2784          // unspecified behavior - both source completions available
2785          final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
# Line 2347 | Line 2788 | public class CompletableFutureTest exten
2788              assertNull(h4.join());
2789              rs[4].assertInvoked();
2790          } catch (CompletionException ok) {
2791 <            checkCompletedWithWrappedCFException(h4, ex);
2791 >            checkCompletedWithWrappedException(h4, ex);
2792              rs[4].assertNotInvoked();
2793          }
2794          try {
2795              assertNull(h5.join());
2796              rs[5].assertInvoked();
2797          } catch (CompletionException ok) {
2798 <            checkCompletedWithWrappedCFException(h5, ex);
2798 >            checkCompletedWithWrappedException(h5, ex);
2799              rs[5].assertNotInvoked();
2800          }
2801  
2802 <        checkCompletedWithWrappedCFException(f, ex);
2802 >        checkCompletedExceptionally(f, ex);
2803          checkCompletedNormally(g, v1);
2804 <        checkCompletedWithWrappedCFException(h0, ex);
2805 <        checkCompletedWithWrappedCFException(h1, ex);
2806 <        checkCompletedWithWrappedCFException(h2, ex);
2807 <        checkCompletedWithWrappedCFException(h3, ex);
2808 <        checkCompletedWithWrappedCFException(h4, ex);
2804 >        checkCompletedWithWrappedException(h0, ex);
2805 >        checkCompletedWithWrappedException(h1, ex);
2806 >        checkCompletedWithWrappedException(h2, ex);
2807 >        checkCompletedWithWrappedException(h3, ex);
2808 >        checkCompletedWithWrappedException(h4, ex);
2809          for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2810      }}
2811  
# Line 2381 | Line 2822 | public class CompletableFutureTest exten
2822  
2823          final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2824          final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2825 <        if (fFirst) {
2826 <            f.complete(v1);
2386 <            g.completeExceptionally(ex);
2387 <        } else {
2388 <            g.completeExceptionally(ex);
2389 <            f.complete(v1);
2390 <        }
2825 >        assertTrue( fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2826 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2827          final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2828          final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2829  
# Line 2396 | Line 2832 | public class CompletableFutureTest exten
2832              assertEquals(null, h0.join());
2833              rs[0].assertInvoked();
2834          } catch (CompletionException ok) {
2835 <            checkCompletedWithWrappedCFException(h0, ex);
2835 >            checkCompletedWithWrappedException(h0, ex);
2836              rs[0].assertNotInvoked();
2837          }
2838          try {
2839              assertEquals(null, h1.join());
2840              rs[1].assertInvoked();
2841          } catch (CompletionException ok) {
2842 <            checkCompletedWithWrappedCFException(h1, ex);
2842 >            checkCompletedWithWrappedException(h1, ex);
2843              rs[1].assertNotInvoked();
2844          }
2845          try {
2846              assertEquals(null, h2.join());
2847              rs[2].assertInvoked();
2848          } catch (CompletionException ok) {
2849 <            checkCompletedWithWrappedCFException(h2, ex);
2849 >            checkCompletedWithWrappedException(h2, ex);
2850              rs[2].assertNotInvoked();
2851          }
2852          try {
2853              assertEquals(null, h3.join());
2854              rs[3].assertInvoked();
2855          } catch (CompletionException ok) {
2856 <            checkCompletedWithWrappedCFException(h3, ex);
2856 >            checkCompletedWithWrappedException(h3, ex);
2857              rs[3].assertNotInvoked();
2858          }
2859  
2860          checkCompletedNormally(f, v1);
2861 <        checkCompletedWithWrappedCFException(g, ex);
2861 >        checkCompletedExceptionally(g, ex);
2862      }}
2863  
2864      /**
# Line 2452 | Line 2888 | public class CompletableFutureTest exten
2888          checkCompletedWithWrappedCancellationException(h2);
2889          checkCompletedWithWrappedCancellationException(h3);
2890  
2891 <        g.complete(v1);
2891 >        assertTrue(g.complete(v1));
2892  
2893          // unspecified behavior - both source completions available
2894          final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
# Line 2496 | Line 2932 | public class CompletableFutureTest exten
2932  
2933          final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2934          final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2935 <        f.complete(v1);
2935 >        assertTrue(f.complete(v1));
2936          final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2937          final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2938          checkCompletedWithWrappedCFException(h0);
# Line 2504 | Line 2940 | public class CompletableFutureTest exten
2940          checkCompletedWithWrappedCFException(h2);
2941          checkCompletedWithWrappedCFException(h3);
2942          for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2943 <        g.complete(v2);
2943 >        assertTrue(g.complete(v2));
2944          final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2945          final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2946          checkCompletedWithWrappedCFException(h4);
# Line 2525 | Line 2961 | public class CompletableFutureTest exten
2961      {
2962          final CompletableFuture<Integer> f = new CompletableFuture<>();
2963          final CompletableFutureInc r = new CompletableFutureInc(m);
2964 <        if (!createIncomplete) f.complete(v1);
2964 >        if (!createIncomplete) assertTrue(f.complete(v1));
2965          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2966 <        if (createIncomplete) f.complete(v1);
2966 >        if (createIncomplete) assertTrue(f.complete(v1));
2967  
2968          checkCompletedNormally(g, inc(v1));
2969          checkCompletedNormally(f, v1);
# Line 2549 | Line 2985 | public class CompletableFutureTest exten
2985          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2986          if (createIncomplete) f.completeExceptionally(ex);
2987  
2988 <        checkCompletedWithWrappedCFException(g, ex);
2989 <        checkCompletedWithWrappedCFException(f, ex);
2988 >        checkCompletedWithWrappedException(g, ex);
2989 >        checkCompletedExceptionally(f, ex);
2990          r.assertNotInvoked();
2991      }}
2992  
# Line 2565 | Line 3001 | public class CompletableFutureTest exten
3001          final CompletableFuture<Integer> f = new CompletableFuture<>();
3002          final FailingCompletableFutureFunction r
3003              = new FailingCompletableFutureFunction(m);
3004 <        if (!createIncomplete) f.complete(v1);
3004 >        if (!createIncomplete) assertTrue(f.complete(v1));
3005          final CompletableFuture<Integer> g = m.thenCompose(f, r);
3006 <        if (createIncomplete) f.complete(v1);
3006 >        if (createIncomplete) assertTrue(f.complete(v1));
3007  
3008          checkCompletedWithWrappedCFException(g);
3009          checkCompletedNormally(f, v1);
# Line 2594 | Line 3030 | public class CompletableFutureTest exten
3030          checkCancelled(f);
3031      }}
3032  
3033 +    /**
3034 +     * thenCompose result completes exceptionally if the result of the action does
3035 +     */
3036 +    public void testThenCompose_actionReturnsFailingFuture() {
3037 +        for (ExecutionMode m : ExecutionMode.values())
3038 +        for (int order = 0; order < 6; order++)
3039 +        for (Integer v1 : new Integer[] { 1, null })
3040 +    {
3041 +        final CFException ex = new CFException();
3042 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
3043 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
3044 +        final CompletableFuture<Integer> h;
3045 +        // Test all permutations of orders
3046 +        switch (order) {
3047 +        case 0:
3048 +            assertTrue(f.complete(v1));
3049 +            assertTrue(g.completeExceptionally(ex));
3050 +            h = m.thenCompose(f, (x -> g));
3051 +            break;
3052 +        case 1:
3053 +            assertTrue(f.complete(v1));
3054 +            h = m.thenCompose(f, (x -> g));
3055 +            assertTrue(g.completeExceptionally(ex));
3056 +            break;
3057 +        case 2:
3058 +            assertTrue(g.completeExceptionally(ex));
3059 +            assertTrue(f.complete(v1));
3060 +            h = m.thenCompose(f, (x -> g));
3061 +            break;
3062 +        case 3:
3063 +            assertTrue(g.completeExceptionally(ex));
3064 +            h = m.thenCompose(f, (x -> g));
3065 +            assertTrue(f.complete(v1));
3066 +            break;
3067 +        case 4:
3068 +            h = m.thenCompose(f, (x -> g));
3069 +            assertTrue(f.complete(v1));
3070 +            assertTrue(g.completeExceptionally(ex));
3071 +            break;
3072 +        case 5:
3073 +            h = m.thenCompose(f, (x -> g));
3074 +            assertTrue(f.complete(v1));
3075 +            assertTrue(g.completeExceptionally(ex));
3076 +            break;
3077 +        default: throw new AssertionError();
3078 +        }
3079 +
3080 +        checkCompletedExceptionally(g, ex);
3081 +        checkCompletedWithWrappedException(h, ex);
3082 +        checkCompletedNormally(f, v1);
3083 +    }}
3084 +
3085      // other static methods
3086  
3087      /**
# Line 2610 | Line 3098 | public class CompletableFutureTest exten
3098       * when all components complete normally
3099       */
3100      public void testAllOf_normal() throws Exception {
3101 <        for (int k = 1; k < 20; ++k) {
3101 >        for (int k = 1; k < 10; k++) {
3102              CompletableFuture<Integer>[] fs
3103                  = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3104 <            for (int i = 0; i < k; ++i)
3104 >            for (int i = 0; i < k; i++)
3105                  fs[i] = new CompletableFuture<>();
3106              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3107 <            for (int i = 0; i < k; ++i) {
3107 >            for (int i = 0; i < k; i++) {
3108                  checkIncomplete(f);
3109                  checkIncomplete(CompletableFuture.allOf(fs));
3110                  fs[i].complete(one);
# Line 2627 | Line 3115 | public class CompletableFutureTest exten
3115      }
3116  
3117      public void testAllOf_backwards() throws Exception {
3118 <        for (int k = 1; k < 20; ++k) {
3118 >        for (int k = 1; k < 10; k++) {
3119              CompletableFuture<Integer>[] fs
3120                  = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3121 <            for (int i = 0; i < k; ++i)
3121 >            for (int i = 0; i < k; i++)
3122                  fs[i] = new CompletableFuture<>();
3123              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3124              for (int i = k - 1; i >= 0; i--) {
# Line 2643 | Line 3131 | public class CompletableFutureTest exten
3131          }
3132      }
3133  
3134 +    public void testAllOf_exceptional() throws Exception {
3135 +        for (int k = 1; k < 10; k++) {
3136 +            CompletableFuture<Integer>[] fs
3137 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3138 +            CFException ex = new CFException();
3139 +            for (int i = 0; i < k; i++)
3140 +                fs[i] = new CompletableFuture<>();
3141 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3142 +            for (int i = 0; i < k; i++) {
3143 +                checkIncomplete(f);
3144 +                checkIncomplete(CompletableFuture.allOf(fs));
3145 +                if (i != k/2) {
3146 +                    fs[i].complete(i);
3147 +                    checkCompletedNormally(fs[i], i);
3148 +                } else {
3149 +                    fs[i].completeExceptionally(ex);
3150 +                    checkCompletedExceptionally(fs[i], ex);
3151 +                }
3152 +            }
3153 +            checkCompletedWithWrappedException(f, ex);
3154 +            checkCompletedWithWrappedException(CompletableFuture.allOf(fs), ex);
3155 +        }
3156 +    }
3157 +
3158      /**
3159       * anyOf(no component futures) returns an incomplete future
3160       */
3161      public void testAnyOf_empty() throws Exception {
3162 +        for (Integer v1 : new Integer[] { 1, null })
3163 +    {
3164          CompletableFuture<Object> f = CompletableFuture.anyOf();
3165          checkIncomplete(f);
3166 <    }
3166 >
3167 >        f.complete(v1);
3168 >        checkCompletedNormally(f, v1);
3169 >    }}
3170  
3171      /**
3172       * anyOf returns a future completed normally with a value when
3173       * a component future does
3174       */
3175      public void testAnyOf_normal() throws Exception {
3176 <        for (int k = 0; k < 10; ++k) {
3176 >        for (int k = 0; k < 10; k++) {
3177              CompletableFuture[] fs = new CompletableFuture[k];
3178 <            for (int i = 0; i < k; ++i)
3178 >            for (int i = 0; i < k; i++)
3179                  fs[i] = new CompletableFuture<>();
3180              CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3181              checkIncomplete(f);
3182 <            for (int i = 0; i < k; ++i) {
3183 <                fs[i].complete(one);
3184 <                checkCompletedNormally(f, one);
3185 <                checkCompletedNormally(CompletableFuture.anyOf(fs), one);
3182 >            for (int i = 0; i < k; i++) {
3183 >                fs[i].complete(i);
3184 >                checkCompletedNormally(f, 0);
3185 >                int x = (int) CompletableFuture.anyOf(fs).join();
3186 >                assertTrue(0 <= x && x <= i);
3187 >            }
3188 >        }
3189 >    }
3190 >    public void testAnyOf_normal_backwards() throws Exception {
3191 >        for (int k = 0; k < 10; k++) {
3192 >            CompletableFuture[] fs = new CompletableFuture[k];
3193 >            for (int i = 0; i < k; i++)
3194 >                fs[i] = new CompletableFuture<>();
3195 >            CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3196 >            checkIncomplete(f);
3197 >            for (int i = k - 1; i >= 0; i--) {
3198 >                fs[i].complete(i);
3199 >                checkCompletedNormally(f, k - 1);
3200 >                int x = (int) CompletableFuture.anyOf(fs).join();
3201 >                assertTrue(i <= x && x <= k - 1);
3202              }
3203          }
3204      }
# Line 2674 | Line 3207 | public class CompletableFutureTest exten
3207       * anyOf result completes exceptionally when any component does.
3208       */
3209      public void testAnyOf_exceptional() throws Exception {
3210 <        for (int k = 0; k < 10; ++k) {
3210 >        for (int k = 0; k < 10; k++) {
3211 >            CompletableFuture[] fs = new CompletableFuture[k];
3212 >            CFException[] exs = new CFException[k];
3213 >            for (int i = 0; i < k; i++) {
3214 >                fs[i] = new CompletableFuture<>();
3215 >                exs[i] = new CFException();
3216 >            }
3217 >            CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3218 >            checkIncomplete(f);
3219 >            for (int i = 0; i < k; i++) {
3220 >                fs[i].completeExceptionally(exs[i]);
3221 >                checkCompletedWithWrappedException(f, exs[0]);
3222 >                checkCompletedWithWrappedCFException(CompletableFuture.anyOf(fs));
3223 >            }
3224 >        }
3225 >    }
3226 >
3227 >    public void testAnyOf_exceptional_backwards() throws Exception {
3228 >        for (int k = 0; k < 10; k++) {
3229              CompletableFuture[] fs = new CompletableFuture[k];
3230 <            for (int i = 0; i < k; ++i)
3230 >            CFException[] exs = new CFException[k];
3231 >            for (int i = 0; i < k; i++) {
3232                  fs[i] = new CompletableFuture<>();
3233 +                exs[i] = new CFException();
3234 +            }
3235              CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3236              checkIncomplete(f);
3237 <            for (int i = 0; i < k; ++i) {
3238 <                fs[i].completeExceptionally(new CFException());
3239 <                checkCompletedWithWrappedCFException(f);
3237 >            for (int i = k - 1; i >= 0; i--) {
3238 >                fs[i].completeExceptionally(exs[i]);
3239 >                checkCompletedWithWrappedException(f, exs[k - 1]);
3240                  checkCompletedWithWrappedCFException(CompletableFuture.anyOf(fs));
3241              }
3242          }
# Line 2695 | Line 3249 | public class CompletableFutureTest exten
3249          CompletableFuture<Integer> f = new CompletableFuture<>();
3250          CompletableFuture<Integer> g = new CompletableFuture<>();
3251          CompletableFuture<Integer> nullFuture = (CompletableFuture<Integer>)null;
2698        CompletableFuture<?> h;
3252          ThreadExecutor exec = new ThreadExecutor();
3253  
3254          Runnable[] throwingActions = {
3255              () -> CompletableFuture.supplyAsync(null),
3256              () -> CompletableFuture.supplyAsync(null, exec),
3257 <            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
3257 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.SYNC, 42), null),
3258  
3259              () -> CompletableFuture.runAsync(null),
3260              () -> CompletableFuture.runAsync(null, exec),
# Line 2792 | Line 3345 | public class CompletableFutureTest exten
3345              () -> CompletableFuture.anyOf(null, f),
3346  
3347              () -> f.obtrudeException(null),
3348 +
3349 +            () -> CompletableFuture.delayedExecutor(1L, SECONDS, null),
3350 +            () -> CompletableFuture.delayedExecutor(1L, null, new ThreadExecutor()),
3351 +            () -> CompletableFuture.delayedExecutor(1L, null),
3352 +
3353 +            () -> f.orTimeout(1L, null),
3354 +            () -> f.completeOnTimeout(42, 1L, null),
3355          };
3356  
3357          assertThrows(NullPointerException.class, throwingActions);
# Line 2806 | Line 3366 | public class CompletableFutureTest exten
3366          assertSame(f, f.toCompletableFuture());
3367      }
3368  
3369 +    // jdk9
3370 +
3371      /**
3372 <     * whenComplete action executes on normal completion, propagating
2811 <     * source result.
3372 >     * newIncompleteFuture returns an incomplete CompletableFuture
3373       */
3374 <    public void testWhenComplete_normalCompletion1() {
2814 <        for (ExecutionMode m : ExecutionMode.values())
2815 <        for (boolean createIncomplete : new boolean[] { true, false })
3374 >    public void testNewIncompleteFuture() {
3375          for (Integer v1 : new Integer[] { 1, null })
3376      {
3377 <        final AtomicInteger a = new AtomicInteger(0);
3378 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
3379 <        if (!createIncomplete) f.complete(v1);
3380 <        final CompletableFuture<Integer> g = m.whenComplete
3381 <            (f,
2823 <             (Integer x, Throwable t) -> {
2824 <                threadAssertSame(x, v1);
2825 <                threadAssertNull(t);
2826 <                a.getAndIncrement();
2827 <            });
2828 <        if (createIncomplete) f.complete(v1);
2829 <
2830 <        checkCompletedNormally(g, v1);
3377 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3378 >        CompletableFuture<Integer> g = f.newIncompleteFuture();
3379 >        checkIncomplete(f);
3380 >        checkIncomplete(g);
3381 >        f.complete(v1);
3382          checkCompletedNormally(f, v1);
3383 <        assertEquals(1, a.get());
3383 >        checkIncomplete(g);
3384 >        g.complete(v1);
3385 >        checkCompletedNormally(g, v1);
3386 >        assertSame(g.getClass(), CompletableFuture.class);
3387      }}
3388  
3389      /**
3390 <     * whenComplete action executes on exceptional completion, propagating
2837 <     * source result.
3390 >     * completedStage returns a completed CompletionStage
3391       */
3392 <    public void testWhenComplete_exceptionalCompletion() {
3393 <        for (ExecutionMode m : ExecutionMode.values())
3394 <        for (boolean createIncomplete : new boolean[] { true, false })
3395 <        for (Integer v1 : new Integer[] { 1, null })
3396 <    {
3397 <        final AtomicInteger a = new AtomicInteger(0);
3398 <        final CFException ex = new CFException();
3399 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2847 <        if (!createIncomplete) f.completeExceptionally(ex);
2848 <        final CompletableFuture<Integer> g = m.whenComplete
2849 <            (f,
2850 <             (Integer x, Throwable t) -> {
2851 <                threadAssertNull(x);
2852 <                threadAssertSame(t, ex);
2853 <                a.getAndIncrement();
2854 <            });
2855 <        if (createIncomplete) f.completeExceptionally(ex);
2856 <        checkCompletedWithWrappedCFException(f, ex);
2857 <        checkCompletedWithWrappedCFException(g, ex);
2858 <        assertEquals(1, a.get());
2859 <    }}
3392 >    public void testCompletedStage() {
3393 >        AtomicInteger x = new AtomicInteger(0);
3394 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3395 >        CompletionStage<Integer> f = CompletableFuture.completedStage(1);
3396 >        f.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3397 >        assertEquals(x.get(), 1);
3398 >        assertNull(r.get());
3399 >    }
3400  
3401      /**
3402 <     * whenComplete action executes on cancelled source, propagating
3403 <     * CancellationException.
3402 >     * defaultExecutor by default returns the commonPool if
3403 >     * it supports more than one thread.
3404       */
3405 <    public void testWhenComplete_sourceCancelled() {
3406 <        for (ExecutionMode m : ExecutionMode.values())
3407 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3408 <        for (boolean createIncomplete : new boolean[] { true, false })
3409 <    {
3410 <        final AtomicInteger a = new AtomicInteger(0);
3411 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
3412 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
3413 <        final CompletableFuture<Integer> g = m.whenComplete
2874 <            (f,
2875 <             (Integer x, Throwable t) -> {
2876 <                threadAssertNull(x);
2877 <                threadAssertTrue(t instanceof CancellationException);
2878 <                a.getAndIncrement();
2879 <            });
2880 <        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
3405 >    public void testDefaultExecutor() {
3406 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3407 >        Executor e = f.defaultExecutor();
3408 >        Executor c = ForkJoinPool.commonPool();
3409 >        if (ForkJoinPool.getCommonPoolParallelism() > 1)
3410 >            assertSame(e, c);
3411 >        else
3412 >            assertNotSame(e, c);
3413 >    }
3414  
3415 <        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
3416 <        checkCompletedWithWrappedCancellationException(g);
3417 <        checkCancelled(f);
3418 <        assertEquals(1, a.get());
3419 <    }}
3415 >    /**
3416 >     * failedFuture returns a CompletableFuture completed
3417 >     * exceptionally with the given Exception
3418 >     */
3419 >    public void testFailedFuture() {
3420 >        CFException ex = new CFException();
3421 >        CompletableFuture<Integer> f = CompletableFuture.failedFuture(ex);
3422 >        checkCompletedExceptionally(f, ex);
3423 >    }
3424  
3425      /**
3426 <     * If a whenComplete action throws an exception when triggered by
2890 <     * a normal completion, it completes exceptionally
3426 >     * failedFuture(null) throws NPE
3427       */
3428 <    public void testWhenComplete_actionFailed() {
3429 <        for (boolean createIncomplete : new boolean[] { true, false })
3430 <        for (ExecutionMode m : ExecutionMode.values())
3431 <        for (Integer v1 : new Integer[] { 1, null })
3432 <    {
3433 <        final AtomicInteger a = new AtomicInteger(0);
2898 <        final CFException ex = new CFException();
2899 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2900 <        if (!createIncomplete) f.complete(v1);
2901 <        final CompletableFuture<Integer> g = m.whenComplete
2902 <            (f,
2903 <             (Integer x, Throwable t) -> {
2904 <                threadAssertSame(x, v1);
2905 <                threadAssertNull(t);
2906 <                a.getAndIncrement();
2907 <                throw ex;
2908 <            });
2909 <        if (createIncomplete) f.complete(v1);
2910 <        checkCompletedNormally(f, v1);
2911 <        checkCompletedWithWrappedCFException(g, ex);
2912 <        assertEquals(1, a.get());
2913 <    }}
3428 >    public void testFailedFuture_null() {
3429 >        try {
3430 >            CompletableFuture<Integer> f = CompletableFuture.failedFuture(null);
3431 >            shouldThrow();
3432 >        } catch (NullPointerException success) {}
3433 >    }
3434  
3435      /**
3436 <     * If a whenComplete action throws an exception when triggered by
3437 <     * a source completion that also throws an exception, the source
2918 <     * exception takes precedence.
3436 >     * copy returns a CompletableFuture that is completed normally,
3437 >     * with the same value, when source is.
3438       */
3439 <    public void testWhenComplete_actionFailedSourceFailed() {
3440 <        for (boolean createIncomplete : new boolean[] { true, false })
3439 >    public void testCopy() {
3440 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3441 >        CompletableFuture<Integer> g = f.copy();
3442 >        checkIncomplete(f);
3443 >        checkIncomplete(g);
3444 >        f.complete(1);
3445 >        checkCompletedNormally(f, 1);
3446 >        checkCompletedNormally(g, 1);
3447 >    }
3448 >
3449 >    /**
3450 >     * copy returns a CompletableFuture that is completed exceptionally
3451 >     * when source is.
3452 >     */
3453 >    public void testCopy2() {
3454 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3455 >        CompletableFuture<Integer> g = f.copy();
3456 >        checkIncomplete(f);
3457 >        checkIncomplete(g);
3458 >        CFException ex = new CFException();
3459 >        f.completeExceptionally(ex);
3460 >        checkCompletedExceptionally(f, ex);
3461 >        checkCompletedWithWrappedCFException(g);
3462 >    }
3463 >
3464 >    /**
3465 >     * minimalCompletionStage returns a CompletableFuture that is
3466 >     * completed normally, with the same value, when source is.
3467 >     */
3468 >    public void testMinimalCompletionStage() {
3469 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3470 >        CompletionStage<Integer> g = f.minimalCompletionStage();
3471 >        AtomicInteger x = new AtomicInteger(0);
3472 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3473 >        checkIncomplete(f);
3474 >        g.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3475 >        f.complete(1);
3476 >        checkCompletedNormally(f, 1);
3477 >        assertEquals(x.get(), 1);
3478 >        assertNull(r.get());
3479 >    }
3480 >
3481 >    /**
3482 >     * minimalCompletionStage returns a CompletableFuture that is
3483 >     * completed exceptionally when source is.
3484 >     */
3485 >    public void testMinimalCompletionStage2() {
3486 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3487 >        CompletionStage<Integer> g = f.minimalCompletionStage();
3488 >        AtomicInteger x = new AtomicInteger(0);
3489 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3490 >        g.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3491 >        checkIncomplete(f);
3492 >        CFException ex = new CFException();
3493 >        f.completeExceptionally(ex);
3494 >        checkCompletedExceptionally(f, ex);
3495 >        assertEquals(x.get(), 0);
3496 >        assertEquals(r.get().getCause(), ex);
3497 >    }
3498 >
3499 >    /**
3500 >     * failedStage returns a CompletionStage completed
3501 >     * exceptionally with the given Exception
3502 >     */
3503 >    public void testFailedStage() {
3504 >        CFException ex = new CFException();
3505 >        CompletionStage<Integer> f = CompletableFuture.failedStage(ex);
3506 >        AtomicInteger x = new AtomicInteger(0);
3507 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3508 >        f.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3509 >        assertEquals(x.get(), 0);
3510 >        assertEquals(r.get(), ex);
3511 >    }
3512 >
3513 >    /**
3514 >     * completeAsync completes with value of given supplier
3515 >     */
3516 >    public void testCompleteAsync() {
3517 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3518 >        f.completeAsync(() -> 1);
3519 >        f.join();
3520 >        checkCompletedNormally(f, 1);
3521 >    }
3522 >
3523 >    /**
3524 >     * completeAsync completes exceptionally if given supplier throws
3525 >     */
3526 >    public void testCompleteAsync2() {
3527 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3528 >        CFException ex = new CFException();
3529 >        f.completeAsync(() -> {if (true) throw ex; return 1;});
3530 >        try {
3531 >            f.join();
3532 >            shouldThrow();
3533 >        } catch (Exception success) {}
3534 >        checkCompletedWithWrappedCFException(f);
3535 >    }
3536 >
3537 >    /**
3538 >     * completeAsync with given executor completes with value of given supplier
3539 >     */
3540 >    public void testCompleteAsync3() {
3541 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3542 >        f.completeAsync(() -> 1, new ThreadExecutor());
3543 >        f.join();
3544 >        checkCompletedNormally(f, 1);
3545 >    }
3546 >
3547 >    /**
3548 >     * completeAsync with given executor completes exceptionally if
3549 >     * given supplier throws
3550 >     */
3551 >    public void testCompleteAsync4() {
3552 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3553 >        CFException ex = new CFException();
3554 >        f.completeAsync(() -> {if (true) throw ex; return 1;}, new ThreadExecutor());
3555 >        try {
3556 >            f.join();
3557 >            shouldThrow();
3558 >        } catch (Exception success) {}
3559 >        checkCompletedWithWrappedCFException(f);
3560 >    }
3561 >
3562 >    /**
3563 >     * orTimeout completes with TimeoutException if not complete
3564 >     */
3565 >    public void testOrTimeout() {
3566 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3567 >        f.orTimeout(SHORT_DELAY_MS, MILLISECONDS);
3568 >        checkCompletedExceptionallyWithTimeout(f);
3569 >    }
3570 >
3571 >    /**
3572 >     * orTimeout completes normally if completed before timeout
3573 >     */
3574 >    public void testOrTimeout2() {
3575 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3576 >        f.complete(1);
3577 >        f.orTimeout(SHORT_DELAY_MS, MILLISECONDS);
3578 >        checkCompletedNormally(f, 1);
3579 >    }
3580 >
3581 >    /**
3582 >     * completeOnTimeout completes with given value if not complete
3583 >     */
3584 >    public void testCompleteOnTimeout() {
3585 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3586 >        f.completeOnTimeout(-1, SHORT_DELAY_MS, MILLISECONDS);
3587 >        f.join();
3588 >        checkCompletedNormally(f, -1);
3589 >    }
3590 >
3591 >    /**
3592 >     * completeOnTimeout has no effect if completed within timeout
3593 >     */
3594 >    public void testCompleteOnTimeout2() {
3595 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3596 >        f.complete(1);
3597 >        f.completeOnTimeout(-1, SHORT_DELAY_MS, MILLISECONDS);
3598 >        checkCompletedNormally(f, 1);
3599 >    }
3600 >
3601 >    /**
3602 >     * delayedExecutor returns an executor that delays submission
3603 >     */
3604 >    public void testDelayedExecutor() throws Exception {
3605 >        long timeoutMillis = SMALL_DELAY_MS;
3606 >        Executor d = CompletableFuture.delayedExecutor(timeoutMillis,
3607 >                                                       MILLISECONDS);
3608 >        long startTime = System.nanoTime();
3609 >        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(() -> 1, d);
3610 >        assertNull(f.getNow(null));
3611 >        assertEquals(1, (int) f.get(LONG_DELAY_MS, MILLISECONDS));
3612 >        assertTrue(millisElapsedSince(startTime) > timeoutMillis/2);
3613 >        checkCompletedNormally(f, 1);
3614 >    }
3615 >
3616 >    /**
3617 >     * delayedExecutor for a given executor returns an executor that
3618 >     * delays submission
3619 >     */
3620 >    public void testDelayedExecutor2() throws Exception {
3621 >        long timeoutMillis = SMALL_DELAY_MS;
3622 >        Executor d = CompletableFuture.delayedExecutor(timeoutMillis,
3623 >                                                       MILLISECONDS,
3624 >                                                       new ThreadExecutor());
3625 >        long startTime = System.nanoTime();
3626 >        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(() -> 1, d);
3627 >        assertNull(f.getNow(null));
3628 >        assertEquals(1, (int) f.get(LONG_DELAY_MS, MILLISECONDS));
3629 >        assertTrue(millisElapsedSince(startTime) > timeoutMillis/2);
3630 >        checkCompletedNormally(f, 1);
3631 >    }
3632 >
3633 >    //--- tests of implementation details; not part of official tck ---
3634 >
3635 >    Object resultOf(CompletableFuture<?> f) {
3636 >        try {
3637 >            java.lang.reflect.Field resultField
3638 >                = CompletableFuture.class.getDeclaredField("result");
3639 >            resultField.setAccessible(true);
3640 >            return resultField.get(f);
3641 >        } catch (Throwable t) { throw new AssertionError(t); }
3642 >    }
3643 >
3644 >    public void testExceptionPropagationReusesResultObject() {
3645 >        if (!testImplementationDetails) return;
3646          for (ExecutionMode m : ExecutionMode.values())
2923        for (Integer v1 : new Integer[] { 1, null })
3647      {
3648 <        final AtomicInteger a = new AtomicInteger(0);
3649 <        final CFException ex1 = new CFException();
3650 <        final CFException ex2 = new CFException();
2928 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
3648 >        final CFException ex = new CFException();
3649 >        final CompletableFuture<Integer> v42 = CompletableFuture.completedFuture(42);
3650 >        final CompletableFuture<Integer> incomplete = new CompletableFuture<>();
3651  
3652 <        if (!createIncomplete) f.completeExceptionally(ex1);
3653 <        final CompletableFuture<Integer> g = m.whenComplete
2932 <            (f,
2933 <             (Integer x, Throwable t) -> {
2934 <                threadAssertSame(t, ex1);
2935 <                threadAssertNull(x);
2936 <                a.getAndIncrement();
2937 <                throw ex2;
2938 <            });
2939 <        if (createIncomplete) f.completeExceptionally(ex1);
3652 >        List<Function<CompletableFuture<Integer>, CompletableFuture<?>>> funs
3653 >            = new ArrayList<>();
3654  
3655 <        checkCompletedWithWrappedCFException(f, ex1);
3656 <        checkCompletedWithWrappedCFException(g, ex1);
3657 <        assertEquals(1, a.get());
3655 >        funs.add((y) -> m.thenRun(y, new Noop(m)));
3656 >        funs.add((y) -> m.thenAccept(y, new NoopConsumer(m)));
3657 >        funs.add((y) -> m.thenApply(y, new IncFunction(m)));
3658 >
3659 >        funs.add((y) -> m.runAfterEither(y, incomplete, new Noop(m)));
3660 >        funs.add((y) -> m.acceptEither(y, incomplete, new NoopConsumer(m)));
3661 >        funs.add((y) -> m.applyToEither(y, incomplete, new IncFunction(m)));
3662 >
3663 >        funs.add((y) -> m.runAfterBoth(y, v42, new Noop(m)));
3664 >        funs.add((y) -> m.thenAcceptBoth(y, v42, new SubtractAction(m)));
3665 >        funs.add((y) -> m.thenCombine(y, v42, new SubtractFunction(m)));
3666 >
3667 >        funs.add((y) -> m.whenComplete(y, (Integer x, Throwable t) -> {}));
3668 >
3669 >        funs.add((y) -> m.thenCompose(y, new CompletableFutureInc(m)));
3670 >
3671 >        funs.add((y) -> CompletableFuture.allOf(new CompletableFuture<?>[] {y, v42}));
3672 >        funs.add((y) -> CompletableFuture.anyOf(new CompletableFuture<?>[] {y, incomplete}));
3673 >
3674 >        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3675 >                 fun : funs) {
3676 >            CompletableFuture<Integer> f = new CompletableFuture<>();
3677 >            f.completeExceptionally(ex);
3678 >            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3679 >            checkCompletedWithWrappedException(src, ex);
3680 >            CompletableFuture<?> dep = fun.apply(src);
3681 >            checkCompletedWithWrappedException(dep, ex);
3682 >            assertSame(resultOf(src), resultOf(dep));
3683 >        }
3684 >
3685 >        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3686 >                 fun : funs) {
3687 >            CompletableFuture<Integer> f = new CompletableFuture<>();
3688 >            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3689 >            CompletableFuture<?> dep = fun.apply(src);
3690 >            f.completeExceptionally(ex);
3691 >            checkCompletedWithWrappedException(src, ex);
3692 >            checkCompletedWithWrappedException(dep, ex);
3693 >            assertSame(resultOf(src), resultOf(dep));
3694 >        }
3695 >
3696 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3697 >        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3698 >                 fun : funs) {
3699 >            CompletableFuture<Integer> f = new CompletableFuture<>();
3700 >            f.cancel(mayInterruptIfRunning);
3701 >            checkCancelled(f);
3702 >            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3703 >            checkCompletedWithWrappedCancellationException(src);
3704 >            CompletableFuture<?> dep = fun.apply(src);
3705 >            checkCompletedWithWrappedCancellationException(dep);
3706 >            assertSame(resultOf(src), resultOf(dep));
3707 >        }
3708 >
3709 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3710 >        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3711 >                 fun : funs) {
3712 >            CompletableFuture<Integer> f = new CompletableFuture<>();
3713 >            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3714 >            CompletableFuture<?> dep = fun.apply(src);
3715 >            f.cancel(mayInterruptIfRunning);
3716 >            checkCancelled(f);
3717 >            checkCompletedWithWrappedCancellationException(src);
3718 >            checkCompletedWithWrappedCancellationException(dep);
3719 >            assertSame(resultOf(src), resultOf(dep));
3720 >        }
3721      }}
3722  
3723   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines