ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.34 by jsr166, Sun Jun 1 21:17:05 2014 UTC vs.
Revision 1.54 by jsr166, Mon Jun 2 21:32:24 2014 UTC

# Line 16 | Line 16 | import java.util.concurrent.ExecutionExc
16   import java.util.concurrent.Future;
17   import java.util.concurrent.CompletableFuture;
18   import java.util.concurrent.CompletionException;
19 + import java.util.concurrent.CompletionStage;
20 + import java.util.concurrent.ForkJoinPool;
21 + import java.util.concurrent.ForkJoinTask;
22   import java.util.concurrent.TimeoutException;
23   import java.util.concurrent.atomic.AtomicInteger;
24   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 246 | Line 249 | public class CompletableFutureTest exten
249          f = new CompletableFuture<>();
250          f.obtrudeValue(three);
251          checkCompletedNormally(f, three);
252 +        f.obtrudeValue(null);
253 +        checkCompletedNormally(f, null);
254          f = new CompletableFuture<>();
255          f.completeExceptionally(new CFException());
256          f.obtrudeValue(four);
# Line 278 | Line 283 | public class CompletableFutureTest exten
283       */
284      public void testGetNumberOfDependents() {
285          CompletableFuture<Integer> f = new CompletableFuture<>();
286 <        assertEquals(f.getNumberOfDependents(), 0);
286 >        assertEquals(0, f.getNumberOfDependents());
287          CompletableFuture g = f.thenRun(new Noop());
288 <        assertEquals(f.getNumberOfDependents(), 1);
289 <        assertEquals(g.getNumberOfDependents(), 0);
288 >        assertEquals(1, f.getNumberOfDependents());
289 >        assertEquals(0, g.getNumberOfDependents());
290          CompletableFuture h = f.thenRun(new Noop());
291 <        assertEquals(f.getNumberOfDependents(), 2);
291 >        assertEquals(2, f.getNumberOfDependents());
292          f.complete(1);
293          checkCompletedNormally(g, null);
294 <        assertEquals(f.getNumberOfDependents(), 0);
295 <        assertEquals(g.getNumberOfDependents(), 0);
294 >        assertEquals(0, f.getNumberOfDependents());
295 >        assertEquals(0, g.getNumberOfDependents());
296      }
297  
298      /**
# Line 317 | Line 322 | public class CompletableFutureTest exten
322  
323      // Choose non-commutative actions for better coverage
324  
325 +    // A non-commutative function that handles and produces null values as well.
326 +    static Integer subtract(Integer x, Integer y) {
327 +        return (x == null && y == null) ? null :
328 +            ((x == null) ? 42 : x.intValue())
329 +            - ((y == null) ? 99 : y.intValue());
330 +    }
331 +
332 +    // A function that handles and produces null values as well.
333 +    static Integer inc(Integer x) {
334 +        return (x == null) ? null : x + 1;
335 +    }
336 +
337      static final Supplier<Integer> supplyOne =
338          () -> Integer.valueOf(1);
339      static final Function<Integer, Integer> inc =
340          (Integer x) -> Integer.valueOf(x.intValue() + 1);
341      static final BiFunction<Integer, Integer, Integer> subtract =
342 <        (Integer x, Integer y) -> Integer.valueOf(x.intValue() - y.intValue());
342 >        (Integer x, Integer y) -> subtract(x, y);
343      static final class IncAction implements Consumer<Integer> {
344 <        int value;
345 <        public void accept(Integer x) { value = x.intValue() + 1; }
344 >        int invocationCount = 0;
345 >        Integer value;
346 >        public void accept(Integer x) {
347 >            invocationCount++;
348 >            value = inc(x);
349 >        }
350 >    }
351 >    static final class IncFunction implements Function<Integer,Integer> {
352 >        int invocationCount = 0;
353 >        Integer value;
354 >        public Integer apply(Integer x) {
355 >            invocationCount++;
356 >            return value = inc(x);
357 >        }
358      }
359      static final class SubtractAction implements BiConsumer<Integer, Integer> {
360 <        int value;
360 >        int invocationCount = 0;
361 >        Integer value;
362 >        // Check this action was invoked exactly once when result is computed.
363          public void accept(Integer x, Integer y) {
364 <            value = x.intValue() - y.intValue();
364 >            invocationCount++;
365 >            value = subtract(x, y);
366 >        }
367 >    }
368 >    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
369 >        int invocationCount = 0;
370 >        Integer value;
371 >        // Check this action was invoked exactly once when result is computed.
372 >        public Integer apply(Integer x, Integer y) {
373 >            invocationCount++;
374 >            return value = subtract(x, y);
375          }
376      }
377      static final class Noop implements Runnable {
378 <        boolean ran;
379 <        public void run() { ran = true; }
378 >        int invocationCount = 0;
379 >        public void run() {
380 >            invocationCount++;
381 >        }
382      }
383  
384      static final class FailingSupplier implements Supplier<Integer> {
385 <        boolean ran;
386 <        public Integer get() { ran = true; throw new CFException(); }
385 >        int invocationCount = 0;
386 >        public Integer get() {
387 >            invocationCount++;
388 >            throw new CFException();
389 >        }
390      }
391      static final class FailingConsumer implements Consumer<Integer> {
392 <        boolean ran;
393 <        public void accept(Integer x) { ran = true; throw new CFException(); }
392 >        int invocationCount = 0;
393 >        public void accept(Integer x) {
394 >            invocationCount++;
395 >            throw new CFException();
396 >        }
397      }
398      static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
399 <        boolean ran;
400 <        public void accept(Integer x, Integer y) { ran = true; throw new CFException(); }
399 >        int invocationCount = 0;
400 >        public void accept(Integer x, Integer y) {
401 >            invocationCount++;
402 >            throw new CFException();
403 >        }
404      }
405      static final class FailingFunction implements Function<Integer, Integer> {
406 <        boolean ran;
407 <        public Integer apply(Integer x) { ran = true; throw new CFException(); }
406 >        int invocationCount = 0;
407 >        public Integer apply(Integer x) {
408 >            invocationCount++;
409 >            throw new CFException();
410 >        }
411      }
412      static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
413 <        boolean ran;
414 <        public Integer apply(Integer x, Integer y) { ran = true; throw new CFException(); }
413 >        int invocationCount = 0;
414 >        public Integer apply(Integer x, Integer y) {
415 >            invocationCount++;
416 >            throw new CFException();
417 >        }
418      }
419 <    static final class FailingNoop implements Runnable {
420 <        boolean ran;
421 <        public void run() { ran = true; throw new CFException(); }
419 >    static final class FailingRunnable implements Runnable {
420 >        int invocationCount = 0;
421 >        public void run() {
422 >            invocationCount++;
423 >            throw new CFException();
424 >        }
425      }
426  
427      static final class CompletableFutureInc
428          implements Function<Integer, CompletableFuture<Integer>> {
429 <        boolean ran;
429 >        int invocationCount = 0;
430          public CompletableFuture<Integer> apply(Integer x) {
431 <            ran = true;
431 >            invocationCount++;
432              CompletableFuture<Integer> f = new CompletableFuture<>();
433 <            f.complete(Integer.valueOf(x.intValue() + 1));
433 >            f.complete(inc(x));
434              return f;
435          }
436      }
437  
438      static final class FailingCompletableFutureFunction
439          implements Function<Integer, CompletableFuture<Integer>> {
440 <        boolean ran;
440 >        int invocationCount = 0;
441          public CompletableFuture<Integer> apply(Integer x) {
442 <            ran = true; throw new CFException();
442 >            invocationCount++;
443 >            throw new CFException();
444          }
445      }
446  
# Line 392 | Line 454 | public class CompletableFutureTest exten
454          }
455      }
456  
457 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
458 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
459 <    }
457 >    /**
458 >     * Permits the testing of parallel code for the 3 different
459 >     * execution modes without repeating all the testing code.
460 >     */
461 >    enum ExecutionMode {
462 >        DEFAULT {
463 >            public void checkExecutionMode() {
464 >                assertNull(ForkJoinTask.getPool());
465 >            }
466 >            public <T> CompletableFuture<Void> thenRun
467 >                (CompletableFuture<T> f, Runnable a) {
468 >                return f.thenRun(a);
469 >            }
470 >            public <T> CompletableFuture<Void> thenAccept
471 >                (CompletableFuture<T> f, Consumer<? super T> a) {
472 >                return f.thenAccept(a);
473 >            }
474 >            public <T,U> CompletableFuture<U> thenApply
475 >                (CompletableFuture<T> f, Function<? super T,U> a) {
476 >                return f.thenApply(a);
477 >            }
478 >            public <T,U> CompletableFuture<U> thenCompose
479 >                (CompletableFuture<T> f,
480 >                 Function<? super T,? extends CompletionStage<U>> a) {
481 >                return f.thenCompose(a);
482 >            }
483 >            public <T,U> CompletableFuture<U> handle
484 >                (CompletableFuture<T> f,
485 >                 BiFunction<? super T,Throwable,? extends U> a) {
486 >                return f.handle(a);
487 >            }
488 >            public <T> CompletableFuture<T> whenComplete
489 >                (CompletableFuture<T> f,
490 >                 BiConsumer<? super T,? super Throwable> a) {
491 >                return f.whenComplete(a);
492 >            }
493 >            public <T,U> CompletableFuture<Void> runAfterBoth
494 >                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
495 >                return f.runAfterBoth(g, a);
496 >            }
497 >            public <T,U> CompletableFuture<Void> thenAcceptBoth
498 >                (CompletableFuture<T> f,
499 >                 CompletionStage<? extends U> g,
500 >                 BiConsumer<? super T,? super U> a) {
501 >                return f.thenAcceptBoth(g, a);
502 >            }
503 >            public <T,U,V> CompletableFuture<V> thenCombine
504 >                (CompletableFuture<T> f,
505 >                 CompletionStage<? extends U> g,
506 >                 BiFunction<? super T,? super U,? extends V> a) {
507 >                return f.thenCombine(g, a);
508 >            }
509 >            public <T> CompletableFuture<Void> runAfterEither
510 >                (CompletableFuture<T> f,
511 >                 CompletionStage<?> g,
512 >                 java.lang.Runnable a) {
513 >                return f.runAfterEither(g, a);
514 >            }
515 >            public <T> CompletableFuture<Void> acceptEither
516 >                (CompletableFuture<T> f,
517 >                 CompletionStage<? extends T> g,
518 >                 Consumer<? super T> a) {
519 >                return f.acceptEither(g, a);
520 >            }
521 >            public <T,U> CompletableFuture<U> applyToEither
522 >                (CompletableFuture<T> f,
523 >                 CompletionStage<? extends T> g,
524 >                 Function<? super T,U> a) {
525 >                return f.applyToEither(g, a);
526 >            }
527 >        },
528  
529 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
530 <        boolean ran;
531 <        public Integer apply(Integer x, Throwable t) {
532 <            ran = true;
533 <            return (t == null) ? two : three;
534 <        }
529 >        ASYNC {
530 >            public void checkExecutionMode() {
531 >                assertSame(ForkJoinPool.commonPool(),
532 >                           ForkJoinTask.getPool());
533 >            }
534 >            public <T> CompletableFuture<Void> thenRun
535 >                (CompletableFuture<T> f, Runnable a) {
536 >                return f.thenRunAsync(a);
537 >            }
538 >            public <T> CompletableFuture<Void> thenAccept
539 >                (CompletableFuture<T> f, Consumer<? super T> a) {
540 >                return f.thenAcceptAsync(a);
541 >            }
542 >            public <T,U> CompletableFuture<U> thenApply
543 >                (CompletableFuture<T> f, Function<? super T,U> a) {
544 >                return f.thenApplyAsync(a);
545 >            }
546 >            public <T,U> CompletableFuture<U> thenCompose
547 >                (CompletableFuture<T> f,
548 >                 Function<? super T,? extends CompletionStage<U>> a) {
549 >                return f.thenComposeAsync(a);
550 >            }
551 >            public <T,U> CompletableFuture<U> handle
552 >                (CompletableFuture<T> f,
553 >                 BiFunction<? super T,Throwable,? extends U> a) {
554 >                return f.handleAsync(a);
555 >            }
556 >            public <T> CompletableFuture<T> whenComplete
557 >                (CompletableFuture<T> f,
558 >                 BiConsumer<? super T,? super Throwable> a) {
559 >                return f.whenCompleteAsync(a);
560 >            }
561 >            public <T,U> CompletableFuture<Void> runAfterBoth
562 >                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
563 >                return f.runAfterBothAsync(g, a);
564 >            }
565 >            public <T,U> CompletableFuture<Void> thenAcceptBoth
566 >                (CompletableFuture<T> f,
567 >                 CompletionStage<? extends U> g,
568 >                 BiConsumer<? super T,? super U> a) {
569 >                return f.thenAcceptBothAsync(g, a);
570 >            }
571 >            public <T,U,V> CompletableFuture<V> thenCombine
572 >                (CompletableFuture<T> f,
573 >                 CompletionStage<? extends U> g,
574 >                 BiFunction<? super T,? super U,? extends V> a) {
575 >                return f.thenCombineAsync(g, a);
576 >            }
577 >            public <T> CompletableFuture<Void> runAfterEither
578 >                (CompletableFuture<T> f,
579 >                 CompletionStage<?> g,
580 >                 java.lang.Runnable a) {
581 >                return f.runAfterEitherAsync(g, a);
582 >            }
583 >            public <T> CompletableFuture<Void> acceptEither
584 >                (CompletableFuture<T> f,
585 >                 CompletionStage<? extends T> g,
586 >                 Consumer<? super T> a) {
587 >                return f.acceptEitherAsync(g, a);
588 >            }
589 >            public <T,U> CompletableFuture<U> applyToEither
590 >                (CompletableFuture<T> f,
591 >                 CompletionStage<? extends T> g,
592 >                 Function<? super T,U> a) {
593 >                return f.applyToEitherAsync(g, a);
594 >            }
595 >        },
596 >
597 >        EXECUTOR {
598 >            public void checkExecutionMode() {
599 >                //TODO
600 >            }
601 >            public <T> CompletableFuture<Void> thenRun
602 >                (CompletableFuture<T> f, Runnable a) {
603 >                return f.thenRunAsync(a, new ThreadExecutor());
604 >            }
605 >            public <T> CompletableFuture<Void> thenAccept
606 >                (CompletableFuture<T> f, Consumer<? super T> a) {
607 >                return f.thenAcceptAsync(a, new ThreadExecutor());
608 >            }
609 >            public <T,U> CompletableFuture<U> thenApply
610 >                (CompletableFuture<T> f, Function<? super T,U> a) {
611 >                return f.thenApplyAsync(a, new ThreadExecutor());
612 >            }
613 >            public <T,U> CompletableFuture<U> thenCompose
614 >                (CompletableFuture<T> f,
615 >                 Function<? super T,? extends CompletionStage<U>> a) {
616 >                return f.thenComposeAsync(a, new ThreadExecutor());
617 >            }
618 >            public <T,U> CompletableFuture<U> handle
619 >                (CompletableFuture<T> f,
620 >                 BiFunction<? super T,Throwable,? extends U> a) {
621 >                return f.handleAsync(a, new ThreadExecutor());
622 >            }
623 >            public <T> CompletableFuture<T> whenComplete
624 >                (CompletableFuture<T> f,
625 >                 BiConsumer<? super T,? super Throwable> a) {
626 >                return f.whenCompleteAsync(a, new ThreadExecutor());
627 >            }
628 >            public <T,U> CompletableFuture<Void> runAfterBoth
629 >                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
630 >                return f.runAfterBothAsync(g, a, new ThreadExecutor());
631 >            }
632 >            public <T,U> CompletableFuture<Void> thenAcceptBoth
633 >                (CompletableFuture<T> f,
634 >                 CompletionStage<? extends U> g,
635 >                 BiConsumer<? super T,? super U> a) {
636 >                return f.thenAcceptBothAsync(g, a, new ThreadExecutor());
637 >            }
638 >            public <T,U,V> CompletableFuture<V> thenCombine
639 >                (CompletableFuture<T> f,
640 >                 CompletionStage<? extends U> g,
641 >                 BiFunction<? super T,? super U,? extends V> a) {
642 >                return f.thenCombineAsync(g, a, new ThreadExecutor());
643 >            }
644 >            public <T> CompletableFuture<Void> runAfterEither
645 >                (CompletableFuture<T> f,
646 >                 CompletionStage<?> g,
647 >                 java.lang.Runnable a) {
648 >                return f.runAfterEitherAsync(g, a, new ThreadExecutor());
649 >            }
650 >            public <T> CompletableFuture<Void> acceptEither
651 >                (CompletableFuture<T> f,
652 >                 CompletionStage<? extends T> g,
653 >                 Consumer<? super T> a) {
654 >                return f.acceptEitherAsync(g, a, new ThreadExecutor());
655 >            }
656 >            public <T,U> CompletableFuture<U> applyToEither
657 >                (CompletableFuture<T> f,
658 >                 CompletionStage<? extends T> g,
659 >                 Function<? super T,U> a) {
660 >                return f.applyToEitherAsync(g, a, new ThreadExecutor());
661 >            }
662 >        };
663 >
664 >        public abstract void checkExecutionMode();
665 >        public abstract <T> CompletableFuture<Void> thenRun
666 >            (CompletableFuture<T> f, Runnable a);
667 >        public abstract <T> CompletableFuture<Void> thenAccept
668 >            (CompletableFuture<T> f, Consumer<? super T> a);
669 >        public abstract <T,U> CompletableFuture<U> thenApply
670 >            (CompletableFuture<T> f, Function<? super T,U> a);
671 >        public abstract <T,U> CompletableFuture<U> thenCompose
672 >            (CompletableFuture<T> f,
673 >             Function<? super T,? extends CompletionStage<U>> a);
674 >        public abstract <T,U> CompletableFuture<U> handle
675 >            (CompletableFuture<T> f,
676 >             BiFunction<? super T,Throwable,? extends U> a);
677 >        public abstract <T> CompletableFuture<T> whenComplete
678 >            (CompletableFuture<T> f,
679 >             BiConsumer<? super T,? super Throwable> a);
680 >        public abstract <T,U> CompletableFuture<Void> runAfterBoth
681 >            (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
682 >        public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
683 >            (CompletableFuture<T> f,
684 >             CompletionStage<? extends U> g,
685 >             BiConsumer<? super T,? super U> a);
686 >        public abstract <T,U,V> CompletableFuture<V> thenCombine
687 >            (CompletableFuture<T> f,
688 >             CompletionStage<? extends U> g,
689 >             BiFunction<? super T,? super U,? extends V> a);
690 >        public abstract <T> CompletableFuture<Void> runAfterEither
691 >            (CompletableFuture<T> f,
692 >             CompletionStage<?> g,
693 >             java.lang.Runnable a);
694 >        public abstract <T> CompletableFuture<Void> acceptEither
695 >            (CompletableFuture<T> f,
696 >             CompletionStage<? extends T> g,
697 >             Consumer<? super T> a);
698 >        public abstract <T,U> CompletableFuture<U> applyToEither
699 >            (CompletableFuture<T> f,
700 >             CompletionStage<? extends T> g,
701 >             Function<? super T,U> a);
702      }
703  
704      /**
705 +     * exceptionally action is not invoked when source completes
706 +     * normally, and source result is propagated
707 +     */
708 +    public void testExceptionally_normalCompletion() {
709 +        for (boolean createIncomplete : new boolean[] { true, false })
710 +        for (Integer v1 : new Integer[] { 1, null })
711 +    {
712 +        final AtomicInteger a = new AtomicInteger(0);
713 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
714 +        if (!createIncomplete) f.complete(v1);
715 +        final CompletableFuture<Integer> g = f.exceptionally
716 +            ((Throwable t) -> {
717 +                // Should not be called
718 +                a.getAndIncrement();
719 +                throw new AssertionError();
720 +            });
721 +        if (createIncomplete) f.complete(v1);
722 +
723 +        checkCompletedNormally(g, v1);
724 +        checkCompletedNormally(f, v1);
725 +        assertEquals(0, a.get());
726 +    }}
727 +
728 +
729 +    /**
730       * exceptionally action completes with function value on source
731 <     * exception; otherwise with source value
731 >     * exception
732       */
733 <    public void testExceptionally() {
734 <        CompletableFuture<Integer> f = new CompletableFuture<>();
735 <        ExceptionToInteger r = new ExceptionToInteger();
736 <        CompletableFuture<Integer> g = f.exceptionally(r);
737 <        f.completeExceptionally(new CFException());
738 <        checkCompletedNormally(g, three);
733 >    public void testExceptionally_exceptionalCompletion() {
734 >        for (boolean createIncomplete : new boolean[] { true, false })
735 >        for (Integer v1 : new Integer[] { 1, null })
736 >    {
737 >        final AtomicInteger a = new AtomicInteger(0);
738 >        final CFException ex = new CFException();
739 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
740 >        if (!createIncomplete) f.completeExceptionally(ex);
741 >        final CompletableFuture<Integer> g = f.exceptionally
742 >            ((Throwable t) -> {
743 >                threadAssertSame(t, ex);
744 >                a.getAndIncrement();
745 >                return v1;
746 >            });
747 >        if (createIncomplete) f.completeExceptionally(ex);
748  
749 <        f = new CompletableFuture<>();
750 <        r = new ExceptionToInteger();
751 <        g = f.exceptionally(r);
752 <        f.complete(one);
753 <        checkCompletedNormally(g, one);
754 <    }
749 >        checkCompletedNormally(g, v1);
750 >        assertEquals(1, a.get());
751 >    }}
752 >
753 >    public void testExceptionally_exceptionalCompletionActionFailed() {
754 >        for (boolean createIncomplete : new boolean[] { true, false })
755 >        for (Integer v1 : new Integer[] { 1, null })
756 >    {
757 >        final AtomicInteger a = new AtomicInteger(0);
758 >        final CFException ex1 = new CFException();
759 >        final CFException ex2 = new CFException();
760 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
761 >        if (!createIncomplete) f.completeExceptionally(ex1);
762 >        final CompletableFuture<Integer> g = f.exceptionally
763 >            ((Throwable t) -> {
764 >                threadAssertSame(t, ex1);
765 >                a.getAndIncrement();
766 >                throw ex2;
767 >            });
768 >        if (createIncomplete) f.completeExceptionally(ex1);
769 >
770 >        checkCompletedWithWrappedCFException(g, ex2);
771 >        assertEquals(1, a.get());
772 >    }}
773  
774      /**
775 <     * handle action completes normally with function value on either
776 <     * normal or exceptional completion of source
775 >     * handle action completes normally with function value on normal
776 >     * completion of source
777       */
778 <    public void testHandle() {
779 <        CompletableFuture<Integer> f, g;
780 <        IntegerHandler r;
778 >    public void testHandle_normalCompletion() {
779 >        for (ExecutionMode m : ExecutionMode.values())
780 >        for (boolean createIncomplete : new boolean[] { true, false })
781 >        for (Integer v1 : new Integer[] { 1, null })
782 >    {
783 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
784 >        final AtomicInteger a = new AtomicInteger(0);
785 >        if (!createIncomplete) f.complete(v1);
786 >        final CompletableFuture<Integer> g = m.handle
787 >            (f,
788 >             (Integer x, Throwable t) -> {
789 >                threadAssertSame(x, v1);
790 >                threadAssertNull(t);
791 >                a.getAndIncrement();
792 >                return inc(v1);
793 >            });
794 >        if (createIncomplete) f.complete(v1);
795  
796 <        f = new CompletableFuture<>();
797 <        f.completeExceptionally(new CFException());
798 <        g = f.handle(r = new IntegerHandler());
799 <        assertTrue(r.ran);
437 <        checkCompletedNormally(g, three);
796 >        checkCompletedNormally(g, inc(v1));
797 >        checkCompletedNormally(f, v1);
798 >        assertEquals(1, a.get());
799 >    }}
800  
801 <        f = new CompletableFuture<>();
802 <        g = f.handle(r = new IntegerHandler());
803 <        assertFalse(r.ran);
804 <        f.completeExceptionally(new CFException());
805 <        checkCompletedNormally(g, three);
806 <        assertTrue(r.ran);
801 >    /**
802 >     * handle action completes normally with function value on
803 >     * exceptional completion of source
804 >     */
805 >    public void testHandle_exceptionalCompletion() {
806 >        for (ExecutionMode m : ExecutionMode.values())
807 >        for (boolean createIncomplete : new boolean[] { true, false })
808 >        for (Integer v1 : new Integer[] { 1, null })
809 >    {
810 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
811 >        final AtomicInteger a = new AtomicInteger(0);
812 >        final CFException ex = new CFException();
813 >        if (!createIncomplete) f.completeExceptionally(ex);
814 >        final CompletableFuture<Integer> g = m.handle
815 >            (f,
816 >             (Integer x, Throwable t) -> {
817 >                threadAssertNull(x);
818 >                threadAssertSame(t, ex);
819 >                a.getAndIncrement();
820 >                return v1;
821 >            });
822 >        if (createIncomplete) f.completeExceptionally(ex);
823  
824 <        f = new CompletableFuture<>();
825 <        f.complete(one);
826 <        g = f.handle(r = new IntegerHandler());
827 <        assertTrue(r.ran);
450 <        checkCompletedNormally(g, two);
824 >        checkCompletedNormally(g, v1);
825 >        checkCompletedWithWrappedCFException(f, ex);
826 >        assertEquals(1, a.get());
827 >    }}
828  
829 <        f = new CompletableFuture<>();
830 <        g = f.handle(r = new IntegerHandler());
831 <        assertFalse(r.ran);
832 <        f.complete(one);
833 <        assertTrue(r.ran);
834 <        checkCompletedNormally(g, two);
835 <    }
829 >    /**
830 >     * handle action completes normally with function value on
831 >     * cancelled source
832 >     */
833 >    public void testHandle_sourceCancelled() {
834 >        for (ExecutionMode m : ExecutionMode.values())
835 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
836 >        for (boolean createIncomplete : new boolean[] { true, false })
837 >        for (Integer v1 : new Integer[] { 1, null })
838 >    {
839 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
840 >        final AtomicInteger a = new AtomicInteger(0);
841 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
842 >        final CompletableFuture<Integer> g = m.handle
843 >            (f,
844 >             (Integer x, Throwable t) -> {
845 >                threadAssertNull(x);
846 >                threadAssertTrue(t instanceof CancellationException);
847 >                a.getAndIncrement();
848 >                return v1;
849 >            });
850 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
851 >
852 >        checkCompletedNormally(g, v1);
853 >        checkCancelled(f);
854 >        assertEquals(1, a.get());
855 >    }}
856 >
857 >    /**
858 >     * handle result completes exceptionally if action does
859 >     */
860 >    public void testHandle_sourceFailedActionFailed() {
861 >        for (ExecutionMode m : ExecutionMode.values())
862 >        for (boolean createIncomplete : new boolean[] { true, false })
863 >    {
864 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
865 >        final AtomicInteger a = new AtomicInteger(0);
866 >        final CFException ex1 = new CFException();
867 >        final CFException ex2 = new CFException();
868 >        if (!createIncomplete) f.completeExceptionally(ex1);
869 >        final CompletableFuture<Integer> g = m.handle
870 >            (f,
871 >             (Integer x, Throwable t) -> {
872 >                threadAssertNull(x);
873 >                threadAssertSame(ex1, t);
874 >                a.getAndIncrement();
875 >                throw ex2;
876 >            });
877 >        if (createIncomplete) f.completeExceptionally(ex1);
878 >
879 >        checkCompletedWithWrappedCFException(g, ex2);
880 >        checkCompletedWithWrappedCFException(f, ex1);
881 >        assertEquals(1, a.get());
882 >    }}
883 >
884 >    public void testHandle_sourceCompletedNormallyActionFailed() {
885 >        for (ExecutionMode m : ExecutionMode.values())
886 >        for (boolean createIncomplete : new boolean[] { true, false })
887 >        for (Integer v1 : new Integer[] { 1, null })
888 >    {
889 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
890 >        final AtomicInteger a = new AtomicInteger(0);
891 >        final CFException ex = new CFException();
892 >        if (!createIncomplete) f.complete(v1);
893 >        final CompletableFuture<Integer> g = m.handle
894 >            (f,
895 >             (Integer x, Throwable t) -> {
896 >                threadAssertSame(x, v1);
897 >                threadAssertNull(t);
898 >                a.getAndIncrement();
899 >                throw ex;
900 >            });
901 >        if (createIncomplete) f.complete(v1);
902 >
903 >        checkCompletedWithWrappedCFException(g, ex);
904 >        checkCompletedNormally(f, v1);
905 >        assertEquals(1, a.get());
906 >    }}
907  
908      /**
909       * runAsync completes after running Runnable
# Line 464 | Line 912 | public class CompletableFutureTest exten
912          Noop r = new Noop();
913          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
914          assertNull(f.join());
915 <        assertTrue(r.ran);
915 >        assertEquals(1, r.invocationCount);
916          checkCompletedNormally(f, null);
917      }
918  
# Line 476 | Line 924 | public class CompletableFutureTest exten
924          ThreadExecutor exec = new ThreadExecutor();
925          CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
926          assertNull(f.join());
927 <        assertTrue(r.ran);
927 >        assertEquals(1, r.invocationCount);
928          checkCompletedNormally(f, null);
929          assertEquals(1, exec.count.get());
930      }
# Line 485 | Line 933 | public class CompletableFutureTest exten
933       * failing runAsync completes exceptionally after running Runnable
934       */
935      public void testRunAsync3() {
936 <        FailingNoop r = new FailingNoop();
936 >        FailingRunnable r = new FailingRunnable();
937          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
938          checkCompletedWithWrappedCFException(f);
939 <        assertTrue(r.ran);
939 >        assertEquals(1, r.invocationCount);
940      }
941  
942      /**
# Line 518 | Line 966 | public class CompletableFutureTest exten
966          FailingSupplier r = new FailingSupplier();
967          CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
968          checkCompletedWithWrappedCFException(f);
969 <        assertTrue(r.ran);
969 >        assertEquals(1, r.invocationCount);
970      }
971  
972      // seq completion methods
# Line 526 | Line 974 | public class CompletableFutureTest exten
974      /**
975       * thenRun result completes normally after normal completion of source
976       */
977 <    public void testThenRun() {
978 <        CompletableFuture<Integer> f;
979 <        CompletableFuture<Void> g;
980 <        Noop r;
981 <
982 <        f = new CompletableFuture<>();
983 <        g = f.thenRun(r = new Noop());
984 <        f.complete(null);
985 <        checkCompletedNormally(g, null);
986 <        assertTrue(r.ran);
977 >    public void testThenRun_normalCompletion() {
978 >        for (ExecutionMode m : ExecutionMode.values())
979 >        for (boolean createIncomplete : new boolean[] { true, false })
980 >        for (Integer v1 : new Integer[] { 1, null })
981 >    {
982 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
983 >        final Noop r = new Noop();
984 >        if (!createIncomplete) f.complete(v1);
985 >        final CompletableFuture<Void> g = m.thenRun(f, r);
986 >        if (createIncomplete) {
987 >            checkIncomplete(g);
988 >            f.complete(v1);
989 >        }
990  
540        f = new CompletableFuture<>();
541        f.complete(null);
542        g = f.thenRun(r = new Noop());
991          checkCompletedNormally(g, null);
992 <        assertTrue(r.ran);
993 <    }
992 >        checkCompletedNormally(f, v1);
993 >        assertEquals(1, r.invocationCount);
994 >    }}
995  
996      /**
997       * thenRun result completes exceptionally after exceptional
998       * completion of source
999       */
1000 <    public void testThenRun2() {
1001 <        CompletableFuture<Integer> f;
1002 <        CompletableFuture<Void> g;
1003 <        Noop r;
1004 <
1005 <        f = new CompletableFuture<>();
1006 <        g = f.thenRun(r = new Noop());
1007 <        f.completeExceptionally(new CFException());
1008 <        checkCompletedWithWrappedCFException(g);
1009 <        assertFalse(r.ran);
1000 >    public void testThenRun_exceptionalCompletion() {
1001 >        for (ExecutionMode m : ExecutionMode.values())
1002 >        for (boolean createIncomplete : new boolean[] { true, false })
1003 >    {
1004 >        final CFException ex = new CFException();
1005 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1006 >        final Noop r = new Noop();
1007 >        if (!createIncomplete) f.completeExceptionally(ex);
1008 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1009 >        if (createIncomplete) {
1010 >            checkIncomplete(g);
1011 >            f.completeExceptionally(ex);
1012 >        }
1013  
1014 <        f = new CompletableFuture<>();
1015 <        f.completeExceptionally(new CFException());
1016 <        g = f.thenRun(r = new Noop());
1017 <        checkCompletedWithWrappedCFException(g);
566 <        assertFalse(r.ran);
567 <    }
1014 >        checkCompletedWithWrappedCFException(g, ex);
1015 >        checkCompletedWithWrappedCFException(f, ex);
1016 >        assertEquals(0, r.invocationCount);
1017 >    }}
1018  
1019      /**
1020 <     * thenRun result completes exceptionally if action does
1020 >     * thenRun result completes exceptionally if source cancelled
1021       */
1022 <    public void testThenRun3() {
1023 <        CompletableFuture<Integer> f;
1024 <        CompletableFuture<Void> g;
1025 <        FailingNoop r;
1026 <
1027 <        f = new CompletableFuture<>();
1028 <        g = f.thenRun(r = new FailingNoop());
1029 <        f.complete(null);
1030 <        checkCompletedWithWrappedCFException(g);
1022 >    public void testThenRun_sourceCancelled() {
1023 >        for (ExecutionMode m : ExecutionMode.values())
1024 >        for (boolean createIncomplete : new boolean[] { true, false })
1025 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1026 >    {
1027 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1028 >        final Noop r = new Noop();
1029 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1030 >        final CompletableFuture<Void> g = f.thenRun(r);
1031 >        if (createIncomplete) {
1032 >            checkIncomplete(g);
1033 >            assertTrue(f.cancel(mayInterruptIfRunning));
1034 >        }
1035  
1036 <        f = new CompletableFuture<>();
1037 <        f.complete(null);
1038 <        g = f.thenRun(r = new FailingNoop());
1039 <        checkCompletedWithWrappedCFException(g);
586 <    }
1036 >        checkCompletedWithWrappedCancellationException(g);
1037 >        checkCancelled(f);
1038 >        assertEquals(0, r.invocationCount);
1039 >    }}
1040  
1041      /**
1042 <     * thenRun result completes exceptionally if source cancelled
1042 >     * thenRun result completes exceptionally if action does
1043       */
1044 <    public void testThenRun4() {
1045 <        CompletableFuture<Integer> f;
1046 <        CompletableFuture<Void> g;
1047 <        Noop r;
1048 <
1049 <        f = new CompletableFuture<>();
1050 <        g = f.thenRun(r = new Noop());
1051 <        assertTrue(f.cancel(true));
1052 <        checkCompletedWithWrappedCancellationException(g);
1044 >    public void testThenRun_actionFailed() {
1045 >        for (ExecutionMode m : ExecutionMode.values())
1046 >        for (boolean createIncomplete : new boolean[] { true, false })
1047 >        for (Integer v1 : new Integer[] { 1, null })
1048 >    {
1049 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1050 >        final FailingRunnable r = new FailingRunnable();
1051 >        if (!createIncomplete) f.complete(v1);
1052 >        final CompletableFuture<Void> g = f.thenRun(r);
1053 >        if (createIncomplete) {
1054 >            checkIncomplete(g);
1055 >            f.complete(v1);
1056 >        }
1057  
1058 <        f = new CompletableFuture<>();
1059 <        assertTrue(f.cancel(true));
1060 <        g = f.thenRun(r = new Noop());
604 <        checkCompletedWithWrappedCancellationException(g);
605 <    }
1058 >        checkCompletedWithWrappedCFException(g);
1059 >        checkCompletedNormally(f, v1);
1060 >    }}
1061  
1062      /**
1063       * thenApply result completes normally after normal completion of source
1064       */
1065 <    public void testThenApply() {
1066 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1067 <        CompletableFuture<Integer> g = f.thenApply(inc);
1068 <        f.complete(one);
1069 <        checkCompletedNormally(g, two);
1070 <    }
1065 >    public void testThenApply_normalCompletion() {
1066 >        for (ExecutionMode m : ExecutionMode.values())
1067 >        for (boolean createIncomplete : new boolean[] { true, false })
1068 >        for (Integer v1 : new Integer[] { 1, null })
1069 >    {
1070 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1071 >        final IncFunction r = new IncFunction();
1072 >        if (!createIncomplete) f.complete(v1);
1073 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1074 >        if (createIncomplete) {
1075 >            checkIncomplete(g);
1076 >            f.complete(v1);
1077 >        }
1078 >
1079 >        checkCompletedNormally(g, inc(v1));
1080 >        checkCompletedNormally(f, v1);
1081 >        assertEquals(1, r.invocationCount);
1082 >    }}
1083  
1084      /**
1085       * thenApply result completes exceptionally after exceptional
1086       * completion of source
1087       */
1088 <    public void testThenApply2() {
1089 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1090 <        CompletableFuture<Integer> g = f.thenApply(inc);
1091 <        f.completeExceptionally(new CFException());
1092 <        checkCompletedWithWrappedCFException(g);
1093 <    }
1088 >    public void testThenApply_exceptionalCompletion() {
1089 >        for (ExecutionMode m : ExecutionMode.values())
1090 >        for (boolean createIncomplete : new boolean[] { true, false })
1091 >    {
1092 >        final CFException ex = new CFException();
1093 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1094 >        final IncFunction r = new IncFunction();
1095 >        if (!createIncomplete) f.completeExceptionally(ex);
1096 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1097 >        if (createIncomplete) {
1098 >            checkIncomplete(g);
1099 >            f.completeExceptionally(ex);
1100 >        }
1101  
1102 <    /**
1103 <     * thenApply result completes exceptionally if action does
1104 <     */
1105 <    public void testThenApply3() {
632 <        CompletableFuture<Integer> f = new CompletableFuture<>();
633 <        CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
634 <        f.complete(one);
635 <        checkCompletedWithWrappedCFException(g);
636 <    }
1102 >        checkCompletedWithWrappedCFException(g, ex);
1103 >        checkCompletedWithWrappedCFException(f, ex);
1104 >        assertEquals(0, r.invocationCount);
1105 >    }}
1106  
1107      /**
1108       * thenApply result completes exceptionally if source cancelled
1109       */
1110 <    public void testThenApply4() {
1111 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1112 <        CompletableFuture<Integer> g = f.thenApply(inc);
1113 <        assertTrue(f.cancel(true));
1110 >    public void testThenApply_sourceCancelled() {
1111 >        for (ExecutionMode m : ExecutionMode.values())
1112 >        for (boolean createIncomplete : new boolean[] { true, false })
1113 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1114 >    {
1115 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1116 >        final IncFunction r = new IncFunction();
1117 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1118 >        final CompletableFuture<Integer> g = f.thenApply(r);
1119 >        if (createIncomplete) {
1120 >            checkIncomplete(g);
1121 >            assertTrue(f.cancel(mayInterruptIfRunning));
1122 >        }
1123 >
1124          checkCompletedWithWrappedCancellationException(g);
1125 <    }
1125 >        checkCancelled(f);
1126 >        assertEquals(0, r.invocationCount);
1127 >    }}
1128 >
1129 >    /**
1130 >     * thenApply result completes exceptionally if action does
1131 >     */
1132 >    public void testThenApply_actionFailed() {
1133 >        for (ExecutionMode m : ExecutionMode.values())
1134 >        for (boolean createIncomplete : new boolean[] { true, false })
1135 >        for (Integer v1 : new Integer[] { 1, null })
1136 >    {
1137 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1138 >        final FailingFunction r = new FailingFunction();
1139 >        if (!createIncomplete) f.complete(v1);
1140 >        final CompletableFuture<Integer> g = f.thenApply(r);
1141 >        if (createIncomplete) {
1142 >            checkIncomplete(g);
1143 >            f.complete(v1);
1144 >        }
1145 >
1146 >        checkCompletedWithWrappedCFException(g);
1147 >        checkCompletedNormally(f, v1);
1148 >    }}
1149  
1150      /**
1151       * thenAccept result completes normally after normal completion of source
1152       */
1153 <    public void testThenAccept() {
1154 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1155 <        IncAction r = new IncAction();
1156 <        CompletableFuture<Void> g = f.thenAccept(r);
1157 <        f.complete(one);
1153 >    public void testThenAccept_normalCompletion() {
1154 >        for (ExecutionMode m : ExecutionMode.values())
1155 >        for (boolean createIncomplete : new boolean[] { true, false })
1156 >        for (Integer v1 : new Integer[] { 1, null })
1157 >    {
1158 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1159 >        final IncAction r = new IncAction();
1160 >        if (!createIncomplete) f.complete(v1);
1161 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1162 >        if (createIncomplete) {
1163 >            checkIncomplete(g);
1164 >            f.complete(v1);
1165 >        }
1166 >
1167          checkCompletedNormally(g, null);
1168 <        assertEquals(r.value, 2);
1169 <    }
1168 >        checkCompletedNormally(f, v1);
1169 >        assertEquals(1, r.invocationCount);
1170 >        assertEquals(inc(v1), r.value);
1171 >    }}
1172  
1173      /**
1174       * thenAccept result completes exceptionally after exceptional
1175       * completion of source
1176       */
1177 <    public void testThenAccept2() {
1178 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1179 <        IncAction r = new IncAction();
1180 <        CompletableFuture<Void> g = f.thenAccept(r);
1181 <        f.completeExceptionally(new CFException());
1182 <        checkCompletedWithWrappedCFException(g);
1183 <    }
1177 >    public void testThenAccept_exceptionalCompletion() {
1178 >        for (ExecutionMode m : ExecutionMode.values())
1179 >        for (boolean createIncomplete : new boolean[] { true, false })
1180 >    {
1181 >        final CFException ex = new CFException();
1182 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1183 >        final IncAction r = new IncAction();
1184 >        if (!createIncomplete) f.completeExceptionally(ex);
1185 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1186 >        if (createIncomplete) {
1187 >            checkIncomplete(g);
1188 >            f.completeExceptionally(ex);
1189 >        }
1190 >
1191 >        checkCompletedWithWrappedCFException(g, ex);
1192 >        checkCompletedWithWrappedCFException(f, ex);
1193 >        assertEquals(0, r.invocationCount);
1194 >    }}
1195  
1196      /**
1197       * thenAccept result completes exceptionally if action does
1198       */
1199 <    public void testThenAccept3() {
1200 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1201 <        FailingConsumer r = new FailingConsumer();
1202 <        CompletableFuture<Void> g = f.thenAccept(r);
1203 <        f.complete(one);
1199 >    public void testThenAccept_actionFailed() {
1200 >        for (ExecutionMode m : ExecutionMode.values())
1201 >        for (boolean createIncomplete : new boolean[] { true, false })
1202 >        for (Integer v1 : new Integer[] { 1, null })
1203 >    {
1204 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1205 >        final FailingConsumer r = new FailingConsumer();
1206 >        if (!createIncomplete) f.complete(v1);
1207 >        final CompletableFuture<Void> g = f.thenAccept(r);
1208 >        if (createIncomplete) {
1209 >            checkIncomplete(g);
1210 >            f.complete(v1);
1211 >        }
1212 >
1213          checkCompletedWithWrappedCFException(g);
1214 <        assertTrue(r.ran);
1215 <    }
1214 >        checkCompletedNormally(f, v1);
1215 >    }}
1216  
1217      /**
1218       * thenAccept result completes exceptionally if source cancelled
1219       */
1220 <    public void testThenAccept4() {
1221 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1222 <        IncAction r = new IncAction();
1223 <        CompletableFuture<Void> g = f.thenAccept(r);
1224 <        assertTrue(f.cancel(true));
1220 >    public void testThenAccept_sourceCancelled() {
1221 >        for (ExecutionMode m : ExecutionMode.values())
1222 >        for (boolean createIncomplete : new boolean[] { true, false })
1223 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1224 >    {
1225 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1226 >        final IncAction r = new IncAction();
1227 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1228 >        final CompletableFuture<Void> g = f.thenAccept(r);
1229 >        if (createIncomplete) {
1230 >            checkIncomplete(g);
1231 >            assertTrue(f.cancel(mayInterruptIfRunning));
1232 >        }
1233 >
1234          checkCompletedWithWrappedCancellationException(g);
1235 <    }
1235 >        checkCancelled(f);
1236 >        assertEquals(0, r.invocationCount);
1237 >    }}
1238  
1239      /**
1240       * thenCombine result completes normally after normal completion
1241       * of sources
1242       */
1243 <    public void testThenCombine() {
1244 <        CompletableFuture<Integer> f, g, h;
1245 <
1246 <        f = new CompletableFuture<>();
1247 <        g = new CompletableFuture<>();
1248 <        h = f.thenCombine(g, subtract);
1249 <        f.complete(3);
1250 <        checkIncomplete(h);
1251 <        g.complete(1);
1252 <        checkCompletedNormally(h, 2);
1243 >    public void testThenCombine_normalCompletion() {
1244 >        for (ExecutionMode m : ExecutionMode.values())
1245 >        for (boolean createIncomplete : new boolean[] { true, false })
1246 >        for (boolean fFirst : new boolean[] { true, false })
1247 >        for (Integer v1 : new Integer[] { 1, null })
1248 >        for (Integer v2 : new Integer[] { 2, null })
1249 >    {
1250 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1251 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1252 >        final SubtractFunction r = new SubtractFunction();
1253  
1254 <        f = new CompletableFuture<>();
1255 <        g = new CompletableFuture<>();
1256 <        h = f.thenCombine(g, subtract);
1257 <        g.complete(1);
1258 <        checkIncomplete(h);
1259 <        f.complete(3);
1260 <        checkCompletedNormally(h, 2);
1254 >        if (fFirst) f.complete(v1); else g.complete(v2);
1255 >        if (!createIncomplete)
1256 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1257 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1258 >        if (createIncomplete) {
1259 >            checkIncomplete(h);
1260 >            assertEquals(0, r.invocationCount);
1261 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1262 >        }
1263  
1264 <        f = new CompletableFuture<>();
1265 <        g = new CompletableFuture<>();
1266 <        g.complete(1);
1267 <        f.complete(3);
1268 <        h = f.thenCombine(g, subtract);
723 <        checkCompletedNormally(h, 2);
724 <    }
1264 >        checkCompletedNormally(h, subtract(v1, v2));
1265 >        checkCompletedNormally(f, v1);
1266 >        checkCompletedNormally(g, v2);
1267 >        assertEquals(1, r.invocationCount);
1268 >    }}
1269  
1270      /**
1271       * thenCombine result completes exceptionally after exceptional
1272       * completion of either source
1273       */
1274 <    public void testThenCombine2() {
1275 <        CompletableFuture<Integer> f, g, h;
1276 <
1277 <        f = new CompletableFuture<>();
1278 <        g = new CompletableFuture<>();
1279 <        h = f.thenCombine(g, subtract);
1280 <        f.completeExceptionally(new CFException());
1281 <        checkIncomplete(h);
1282 <        g.complete(1);
1283 <        checkCompletedWithWrappedCFException(h);
740 <
741 <        f = new CompletableFuture<>();
742 <        g = new CompletableFuture<>();
743 <        h = f.thenCombine(g, subtract);
744 <        g.completeExceptionally(new CFException());
745 <        checkIncomplete(h);
746 <        f.complete(3);
747 <        checkCompletedWithWrappedCFException(h);
1274 >    public void testThenCombine_exceptionalCompletion() {
1275 >        for (ExecutionMode m : ExecutionMode.values())
1276 >        for (boolean createIncomplete : new boolean[] { true, false })
1277 >        for (boolean fFirst : new boolean[] { true, false })
1278 >        for (Integer v1 : new Integer[] { 1, null })
1279 >    {
1280 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1281 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1282 >        final CFException ex = new CFException();
1283 >        final SubtractFunction r = new SubtractFunction();
1284  
1285 <        f = new CompletableFuture<>();
1286 <        g = new CompletableFuture<>();
1287 <        f.complete(3);
1288 <        g.completeExceptionally(new CFException());
1289 <        h = f.thenCombine(g, subtract);
1290 <        checkCompletedWithWrappedCFException(h);
1285 >        (fFirst ? f : g).complete(v1);
1286 >        if (!createIncomplete)
1287 >            (!fFirst ? f : g).completeExceptionally(ex);
1288 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1289 >        if (createIncomplete) {
1290 >            checkIncomplete(h);
1291 >            (!fFirst ? f : g).completeExceptionally(ex);
1292 >        }
1293  
1294 <        f = new CompletableFuture<>();
1295 <        g = new CompletableFuture<>();
1296 <        f.completeExceptionally(new CFException());
1297 <        g.complete(3);
1298 <        h = f.thenCombine(g, subtract);
761 <        checkCompletedWithWrappedCFException(h);
762 <    }
1294 >        checkCompletedWithWrappedCFException(h, ex);
1295 >        assertEquals(0, r.invocationCount);
1296 >        checkCompletedNormally(fFirst ? f : g, v1);
1297 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1298 >    }}
1299  
1300      /**
1301       * thenCombine result completes exceptionally if action does
1302       */
1303 <    public void testThenCombine3() {
1304 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1305 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1306 <        FailingBiFunction r = new FailingBiFunction();
1307 <        CompletableFuture<Integer> g = f.thenCombine(f2, r);
1308 <        f.complete(one);
1309 <        checkIncomplete(g);
1310 <        assertFalse(r.ran);
1311 <        f2.complete(two);
1312 <        checkCompletedWithWrappedCFException(g);
1313 <        assertTrue(r.ran);
1314 <    }
1303 >    public void testThenCombine_actionFailed() {
1304 >        for (ExecutionMode m : ExecutionMode.values())
1305 >        for (boolean fFirst : new boolean[] { true, false })
1306 >        for (Integer v1 : new Integer[] { 1, null })
1307 >        for (Integer v2 : new Integer[] { 2, null })
1308 >    {
1309 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1310 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1311 >        final FailingBiFunction r = new FailingBiFunction();
1312 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1313 >
1314 >        if (fFirst) {
1315 >            f.complete(v1);
1316 >            g.complete(v2);
1317 >        } else {
1318 >            g.complete(v2);
1319 >            f.complete(v1);
1320 >        }
1321 >
1322 >        checkCompletedWithWrappedCFException(h);
1323 >        checkCompletedNormally(f, v1);
1324 >        checkCompletedNormally(g, v2);
1325 >    }}
1326  
1327      /**
1328       * thenCombine result completes exceptionally if either source cancelled
1329       */
1330 <    public void testThenCombine4() {
1331 <        CompletableFuture<Integer> f, g, h;
1332 <
1333 <        f = new CompletableFuture<>();
1334 <        g = new CompletableFuture<>();
1335 <        h = f.thenCombine(g, subtract);
1336 <        assertTrue(f.cancel(true));
1337 <        checkIncomplete(h);
1338 <        g.complete(1);
1339 <        checkCompletedWithWrappedCancellationException(h);
1330 >    public void testThenCombine_sourceCancelled() {
1331 >        for (ExecutionMode m : ExecutionMode.values())
1332 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1333 >        for (boolean createIncomplete : new boolean[] { true, false })
1334 >        for (boolean fFirst : new boolean[] { true, false })
1335 >        for (Integer v1 : new Integer[] { 1, null })
1336 >    {
1337 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1338 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1339 >        final SubtractFunction r = new SubtractFunction();
1340  
1341 <        f = new CompletableFuture<>();
1342 <        g = new CompletableFuture<>();
1343 <        h = f.thenCombine(g, subtract);
1344 <        assertTrue(g.cancel(true));
1345 <        checkIncomplete(h);
1346 <        f.complete(3);
1347 <        checkCompletedWithWrappedCancellationException(h);
1341 >        (fFirst ? f : g).complete(v1);
1342 >        if (!createIncomplete)
1343 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1344 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1345 >        if (createIncomplete) {
1346 >            checkIncomplete(h);
1347 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1348 >        }
1349  
802        f = new CompletableFuture<>();
803        g = new CompletableFuture<>();
804        assertTrue(f.cancel(true));
805        assertTrue(g.cancel(true));
806        h = f.thenCombine(g, subtract);
1350          checkCompletedWithWrappedCancellationException(h);
1351 <    }
1351 >        checkCancelled(!fFirst ? f : g);
1352 >        assertEquals(0, r.invocationCount);
1353 >        checkCompletedNormally(fFirst ? f : g, v1);
1354 >    }}
1355  
1356      /**
1357       * thenAcceptBoth result completes normally after normal
1358       * completion of sources
1359       */
1360 <    public void testThenAcceptBoth() {
1361 <        CompletableFuture<Integer> f, g;
1362 <        CompletableFuture<Void> h;
1363 <        SubtractAction r;
1360 >    public void testThenAcceptBoth_normalCompletion() {
1361 >        for (ExecutionMode m : ExecutionMode.values())
1362 >        for (boolean createIncomplete : new boolean[] { true, false })
1363 >        for (boolean fFirst : new boolean[] { true, false })
1364 >        for (Integer v1 : new Integer[] { 1, null })
1365 >        for (Integer v2 : new Integer[] { 2, null })
1366 >    {
1367 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1368 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1369 >        final SubtractAction r = new SubtractAction();
1370  
1371 <        f = new CompletableFuture<>();
1372 <        g = new CompletableFuture<>();
1373 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
1374 <        f.complete(3);
1375 <        checkIncomplete(h);
1376 <        g.complete(1);
1377 <        checkCompletedNormally(h, null);
1378 <        assertEquals(r.value, 2);
1371 >        if (fFirst) f.complete(v1); else g.complete(v2);
1372 >        if (!createIncomplete)
1373 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1374 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1375 >        if (createIncomplete) {
1376 >            checkIncomplete(h);
1377 >            assertEquals(0, r.invocationCount);
1378 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1379 >        }
1380  
828        f = new CompletableFuture<>();
829        g = new CompletableFuture<>();
830        h = f.thenAcceptBoth(g, r = new SubtractAction());
831        g.complete(1);
832        checkIncomplete(h);
833        f.complete(3);
1381          checkCompletedNormally(h, null);
1382 <        assertEquals(r.value, 2);
1383 <
1384 <        f = new CompletableFuture<>();
1385 <        g = new CompletableFuture<>();
839 <        g.complete(1);
840 <        f.complete(3);
841 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
842 <        checkCompletedNormally(h, null);
843 <        assertEquals(r.value, 2);
844 <    }
1382 >        assertEquals(subtract(v1, v2), r.value);
1383 >        checkCompletedNormally(f, v1);
1384 >        checkCompletedNormally(g, v2);
1385 >    }}
1386  
1387      /**
1388       * thenAcceptBoth result completes exceptionally after exceptional
1389       * completion of either source
1390       */
1391 <    public void testThenAcceptBoth2() {
1392 <        CompletableFuture<Integer> f, g;
1393 <        CompletableFuture<Void> h;
1394 <        SubtractAction r;
1395 <
1396 <        f = new CompletableFuture<>();
1397 <        g = new CompletableFuture<>();
1398 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
1399 <        f.completeExceptionally(new CFException());
1400 <        checkIncomplete(h);
860 <        g.complete(1);
861 <        checkCompletedWithWrappedCFException(h);
862 <
863 <        f = new CompletableFuture<>();
864 <        g = new CompletableFuture<>();
865 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
866 <        g.completeExceptionally(new CFException());
867 <        checkIncomplete(h);
868 <        f.complete(3);
869 <        checkCompletedWithWrappedCFException(h);
1391 >    public void testThenAcceptBoth_exceptionalCompletion() {
1392 >        for (ExecutionMode m : ExecutionMode.values())
1393 >        for (boolean createIncomplete : new boolean[] { true, false })
1394 >        for (boolean fFirst : new boolean[] { true, false })
1395 >        for (Integer v1 : new Integer[] { 1, null })
1396 >    {
1397 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1398 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1399 >        final CFException ex = new CFException();
1400 >        final SubtractAction r = new SubtractAction();
1401  
1402 <        f = new CompletableFuture<>();
1403 <        g = new CompletableFuture<>();
1404 <        f.complete(3);
1405 <        g.completeExceptionally(new CFException());
1406 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
1407 <        checkCompletedWithWrappedCFException(h);
1402 >        (fFirst ? f : g).complete(v1);
1403 >        if (!createIncomplete)
1404 >            (!fFirst ? f : g).completeExceptionally(ex);
1405 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1406 >        if (createIncomplete) {
1407 >            checkIncomplete(h);
1408 >            (!fFirst ? f : g).completeExceptionally(ex);
1409 >        }
1410  
1411 <        f = new CompletableFuture<>();
1412 <        g = new CompletableFuture<>();
1413 <        f.completeExceptionally(new CFException());
1414 <        g.complete(3);
1415 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
883 <        checkCompletedWithWrappedCFException(h);
884 <    }
1411 >        checkCompletedWithWrappedCFException(h, ex);
1412 >        assertEquals(0, r.invocationCount);
1413 >        checkCompletedNormally(fFirst ? f : g, v1);
1414 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1415 >    }}
1416  
1417      /**
1418       * thenAcceptBoth result completes exceptionally if action does
1419       */
1420 <    public void testThenAcceptBoth3() {
1421 <        CompletableFuture<Integer> f, g;
1422 <        CompletableFuture<Void> h;
1423 <        FailingBiConsumer r;
1420 >    public void testThenAcceptBoth_actionFailed() {
1421 >        for (ExecutionMode m : ExecutionMode.values())
1422 >        for (boolean fFirst : new boolean[] { true, false })
1423 >        for (Integer v1 : new Integer[] { 1, null })
1424 >        for (Integer v2 : new Integer[] { 2, null })
1425 >    {
1426 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1427 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1428 >        final FailingBiConsumer r = new FailingBiConsumer();
1429 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1430  
1431 <        f = new CompletableFuture<>();
1432 <        g = new CompletableFuture<>();
1433 <        h = f.thenAcceptBoth(g, r = new FailingBiConsumer());
1434 <        f.complete(3);
1435 <        checkIncomplete(h);
1436 <        g.complete(1);
1437 <        checkCompletedWithWrappedCFException(h);
1431 >        if (fFirst) {
1432 >            f.complete(v1);
1433 >            g.complete(v2);
1434 >        } else {
1435 >            g.complete(v2);
1436 >            f.complete(v1);
1437 >        }
1438  
902        f = new CompletableFuture<>();
903        g = new CompletableFuture<>();
904        f.complete(3);
905        g.complete(1);
906        h = f.thenAcceptBoth(g, r = new FailingBiConsumer());
1439          checkCompletedWithWrappedCFException(h);
1440 <    }
1440 >        checkCompletedNormally(f, v1);
1441 >        checkCompletedNormally(g, v2);
1442 >    }}
1443  
1444      /**
1445       * thenAcceptBoth result completes exceptionally if either source cancelled
1446       */
1447 <    public void testThenAcceptBoth4() {
1448 <        CompletableFuture<Integer> f, g;
1449 <        CompletableFuture<Void> h;
1450 <        SubtractAction r;
1451 <
1452 <        f = new CompletableFuture<>();
1453 <        g = new CompletableFuture<>();
1454 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
1455 <        assertTrue(f.cancel(true));
1456 <        checkIncomplete(h);
923 <        g.complete(1);
924 <        checkCompletedWithWrappedCancellationException(h);
925 <
926 <        f = new CompletableFuture<>();
927 <        g = new CompletableFuture<>();
928 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
929 <        assertTrue(g.cancel(true));
930 <        checkIncomplete(h);
931 <        f.complete(3);
932 <        checkCompletedWithWrappedCancellationException(h);
1447 >    public void testThenAcceptBoth_sourceCancelled() {
1448 >        for (ExecutionMode m : ExecutionMode.values())
1449 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1450 >        for (boolean createIncomplete : new boolean[] { true, false })
1451 >        for (boolean fFirst : new boolean[] { true, false })
1452 >        for (Integer v1 : new Integer[] { 1, null })
1453 >    {
1454 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1455 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1456 >        final SubtractAction r = new SubtractAction();
1457  
1458 <        f = new CompletableFuture<>();
1459 <        g = new CompletableFuture<>();
1460 <        f.complete(3);
1461 <        assertTrue(g.cancel(true));
1462 <        h = f.thenAcceptBoth(g, r = new SubtractAction());
1463 <        checkCompletedWithWrappedCancellationException(h);
1458 >        (fFirst ? f : g).complete(v1);
1459 >        if (!createIncomplete)
1460 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1461 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1462 >        if (createIncomplete) {
1463 >            checkIncomplete(h);
1464 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1465 >        }
1466  
941        f = new CompletableFuture<>();
942        g = new CompletableFuture<>();
943        assertTrue(f.cancel(true));
944        g.complete(3);
945        h = f.thenAcceptBoth(g, r = new SubtractAction());
1467          checkCompletedWithWrappedCancellationException(h);
1468 <    }
1469 <
1470 <    /**
1471 <     * Permits the testing of parallel code for the 3 different
951 <     * execution modes without repeating all the testing code.
952 <     */
953 <    enum ExecutionMode {
954 <        DEFAULT {
955 <            public <T,U> CompletableFuture<Void> runAfterBoth
956 <                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable r) {
957 <                return f.runAfterBoth(g, r);
958 <            }
959 <        },
960 <
961 <        DEFAULT_ASYNC {
962 <            public <T,U> CompletableFuture<Void> runAfterBoth
963 <                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable r) {
964 <                return f.runAfterBothAsync(g, r);
965 <            }
966 <        },
967 <
968 <        EXECUTOR {
969 <            public <T,U> CompletableFuture<Void> runAfterBoth
970 <                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable r) {
971 <                return f.runAfterBothAsync(g, r, new ThreadExecutor());
972 <            }
973 <        };
974 <
975 <        public abstract <T,U> CompletableFuture<Void> runAfterBoth
976 <            (CompletableFuture<T> f, CompletableFuture<U> g, Runnable r);
977 <    }
1468 >        checkCancelled(!fFirst ? f : g);
1469 >        assertEquals(0, r.invocationCount);
1470 >        checkCompletedNormally(fFirst ? f : g, v1);
1471 >    }}
1472  
1473      /**
1474       * runAfterBoth result completes normally after normal
1475       * completion of sources
1476       */
1477 <    public void testRunAfterBoth_normalCompletion1() {
1477 >    public void testRunAfterBoth_normalCompletion() {
1478          for (ExecutionMode m : ExecutionMode.values())
1479 +        for (boolean createIncomplete : new boolean[] { true, false })
1480 +        for (boolean fFirst : new boolean[] { true, false })
1481          for (Integer v1 : new Integer[] { 1, null })
1482 <        for (Integer v2 : new Integer[] { 2, null }) {
1483 <
1482 >        for (Integer v2 : new Integer[] { 2, null })
1483 >    {
1484          final CompletableFuture<Integer> f = new CompletableFuture<>();
1485          final CompletableFuture<Integer> g = new CompletableFuture<>();
1486          final Noop r = new Noop();
991        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1487  
1488 <        f.complete(v1);
1489 <        checkIncomplete(h);
1490 <        assertFalse(r.ran);
1491 <        g.complete(v2);
1488 >        if (fFirst) f.complete(v1); else g.complete(v2);
1489 >        if (!createIncomplete)
1490 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1491 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1492 >        if (createIncomplete) {
1493 >            checkIncomplete(h);
1494 >            assertEquals(0, r.invocationCount);
1495 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1496 >        }
1497  
1498          checkCompletedNormally(h, null);
1499 <        assertTrue(r.ran);
1499 >        assertEquals(1, r.invocationCount);
1500          checkCompletedNormally(f, v1);
1501          checkCompletedNormally(g, v2);
1502 <        }
1003 <    }
1502 >    }}
1503  
1504 <    public void testRunAfterBoth_normalCompletion2() {
1504 >    /**
1505 >     * runAfterBoth result completes exceptionally after exceptional
1506 >     * completion of either source
1507 >     */
1508 >    public void testRunAfterBoth_exceptionalCompletion() {
1509          for (ExecutionMode m : ExecutionMode.values())
1510 +        for (boolean createIncomplete : new boolean[] { true, false })
1511 +        for (boolean fFirst : new boolean[] { true, false })
1512          for (Integer v1 : new Integer[] { 1, null })
1513 <        for (Integer v2 : new Integer[] { 2, null }) {
1009 <
1513 >    {
1514          final CompletableFuture<Integer> f = new CompletableFuture<>();
1515          final CompletableFuture<Integer> g = new CompletableFuture<>();
1516 +        final CFException ex = new CFException();
1517          final Noop r = new Noop();
1013        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1014
1015        g.complete(v2);
1016        checkIncomplete(h);
1017        assertFalse(r.ran);
1018        f.complete(v1);
1518  
1519 <        checkCompletedNormally(h, null);
1520 <        assertTrue(r.ran);
1521 <        checkCompletedNormally(f, v1);
1522 <        checkCompletedNormally(g, v2);
1519 >        (fFirst ? f : g).complete(v1);
1520 >        if (!createIncomplete)
1521 >            (!fFirst ? f : g).completeExceptionally(ex);
1522 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1523 >        if (createIncomplete) {
1524 >            checkIncomplete(h);
1525 >            (!fFirst ? f : g).completeExceptionally(ex);
1526          }
1025    }
1527  
1528 <    public void testRunAfterBoth_normalCompletion3() {
1528 >        checkCompletedWithWrappedCFException(h, ex);
1529 >        assertEquals(0, r.invocationCount);
1530 >        checkCompletedNormally(fFirst ? f : g, v1);
1531 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1532 >    }}
1533 >
1534 >    /**
1535 >     * runAfterBoth result completes exceptionally if action does
1536 >     */
1537 >    public void testRunAfterBoth_actionFailed() {
1538          for (ExecutionMode m : ExecutionMode.values())
1539 +        for (boolean fFirst : new boolean[] { true, false })
1540          for (Integer v1 : new Integer[] { 1, null })
1541 <        for (Integer v2 : new Integer[] { 2, null }) {
1542 <
1541 >        for (Integer v2 : new Integer[] { 2, null })
1542 >    {
1543          final CompletableFuture<Integer> f = new CompletableFuture<>();
1544          final CompletableFuture<Integer> g = new CompletableFuture<>();
1545 <        final Noop r = new Noop();
1545 >        final FailingRunnable r = new FailingRunnable();
1546  
1547 <        g.complete(v2);
1548 <        f.complete(v1);
1549 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1547 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1548 >        if (fFirst) {
1549 >            f.complete(v1);
1550 >            g.complete(v2);
1551 >        } else {
1552 >            g.complete(v2);
1553 >            f.complete(v1);
1554 >        }
1555 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1556  
1557 <        checkCompletedNormally(h, null);
1558 <        assertTrue(r.ran);
1557 >        checkCompletedWithWrappedCFException(h1);
1558 >        checkCompletedWithWrappedCFException(h2);
1559          checkCompletedNormally(f, v1);
1560          checkCompletedNormally(g, v2);
1561 <        }
1045 <    }
1561 >    }}
1562  
1563 <    public void testRunAfterBoth_normalCompletion4() {
1563 >    /**
1564 >     * runAfterBoth result completes exceptionally if either source cancelled
1565 >     */
1566 >    public void testRunAfterBoth_sourceCancelled() {
1567          for (ExecutionMode m : ExecutionMode.values())
1568 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1569 +        for (boolean createIncomplete : new boolean[] { true, false })
1570 +        for (boolean fFirst : new boolean[] { true, false })
1571          for (Integer v1 : new Integer[] { 1, null })
1572 <        for (Integer v2 : new Integer[] { 2, null }) {
1051 <
1572 >    {
1573          final CompletableFuture<Integer> f = new CompletableFuture<>();
1574          final CompletableFuture<Integer> g = new CompletableFuture<>();
1575          final Noop r = new Noop();
1576  
1056        f.complete(v1);
1057        g.complete(v2);
1058        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1577  
1578 <        checkCompletedNormally(h, null);
1579 <        assertTrue(r.ran);
1580 <        checkCompletedNormally(f, v1);
1581 <        checkCompletedNormally(g, v2);
1578 >        (fFirst ? f : g).complete(v1);
1579 >        if (!createIncomplete)
1580 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1581 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1582 >        if (createIncomplete) {
1583 >            checkIncomplete(h);
1584 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1585          }
1586 <    }
1586 >
1587 >        checkCompletedWithWrappedCancellationException(h);
1588 >        checkCancelled(!fFirst ? f : g);
1589 >        assertEquals(0, r.invocationCount);
1590 >        checkCompletedNormally(fFirst ? f : g, v1);
1591 >    }}
1592  
1593      /**
1594 <     * runAfterBoth result completes exceptionally after exceptional
1595 <     * completion of either source
1594 >     * applyToEither result completes normally after normal completion
1595 >     * of either source
1596       */
1597 <    public void testRunAfterBoth_exceptionalCompletion1() {
1597 >    public void testApplyToEither_normalCompletion() {
1598          for (ExecutionMode m : ExecutionMode.values())
1599 <        for (Integer v1 : new Integer[] { 1, null }) {
1600 <
1599 >        for (boolean createIncomplete : new boolean[] { true, false })
1600 >        for (boolean fFirst : new boolean[] { true, false })
1601 >        for (Integer v1 : new Integer[] { 1, null })
1602 >        for (Integer v2 : new Integer[] { 2, null })
1603 >    {
1604          final CompletableFuture<Integer> f = new CompletableFuture<>();
1605          final CompletableFuture<Integer> g = new CompletableFuture<>();
1606 <        final Noop r = new Noop();
1078 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1079 <        final CFException ex = new CFException();
1606 >        final IncFunction r = new IncFunction();
1607  
1608 <        f.completeExceptionally(ex);
1609 <        checkIncomplete(h);
1610 <        g.complete(v1);
1611 <
1612 <        checkCompletedWithWrappedCFException(h, ex);
1613 <        checkCompletedWithWrappedCFException(f, ex);
1614 <        assertFalse(r.ran);
1088 <        checkCompletedNormally(g, v1);
1608 >        if (!createIncomplete)
1609 >            if (fFirst) f.complete(v1); else g.complete(v2);
1610 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1611 >        if (createIncomplete) {
1612 >            checkIncomplete(h);
1613 >            assertEquals(0, r.invocationCount);
1614 >            if (fFirst) f.complete(v1); else g.complete(v2);
1615          }
1616 <    }
1616 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1617 >        if (!fFirst) f.complete(v1); else g.complete(v2);
1618  
1619 <    public void testRunAfterBoth_exceptionalCompletion2() {
1620 <        for (ExecutionMode m : ExecutionMode.values())
1621 <        for (Integer v1 : new Integer[] { 1, null }) {
1619 >        checkCompletedNormally(f, v1);
1620 >        checkCompletedNormally(g, v2);
1621 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1622 >    }}
1623  
1624 +    public void testApplyToEither_normalCompletionBothAvailable() {
1625 +        for (ExecutionMode m : ExecutionMode.values())
1626 +        for (boolean fFirst : new boolean[] { true, false })
1627 +        for (Integer v1 : new Integer[] { 1, null })
1628 +        for (Integer v2 : new Integer[] { 2, null })
1629 +    {
1630          final CompletableFuture<Integer> f = new CompletableFuture<>();
1631          final CompletableFuture<Integer> g = new CompletableFuture<>();
1632 <        final Noop r = new Noop();
1099 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1100 <        final CFException ex = new CFException();
1632 >        final IncFunction r = new IncFunction();
1633  
1634 <        g.completeExceptionally(ex);
1635 <        checkIncomplete(h);
1636 <        f.complete(v1);
1634 >        if (fFirst) {
1635 >            f.complete(v1);
1636 >            g.complete(v2);
1637 >        } else {
1638 >            g.complete(v2);
1639 >            f.complete(v1);
1640 >        }
1641 >
1642 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1643  
1106        checkCompletedWithWrappedCFException(h, ex);
1107        checkCompletedWithWrappedCFException(g, ex);
1108        assertFalse(r.ran);
1644          checkCompletedNormally(f, v1);
1645 <        }
1111 <    }
1645 >        checkCompletedNormally(g, v2);
1646  
1647 <    public void testRunAfterBoth_exceptionalCompletion3() {
1648 <        for (ExecutionMode m : ExecutionMode.values())
1649 <        for (Integer v1 : new Integer[] { 1, null }) {
1647 >        // unspecified behavior
1648 >        assertTrue(Objects.equals(h.join(), inc(v1)) ||
1649 >                   Objects.equals(h.join(), inc(v2)));
1650 >        assertEquals(1, r.invocationCount);
1651 >    }}
1652  
1653 +    /**
1654 +     * applyToEither result completes exceptionally after exceptional
1655 +     * completion of either source
1656 +     */
1657 +    public void testApplyToEither_exceptionalCompletion1() {
1658 +        for (ExecutionMode m : ExecutionMode.values())
1659 +        for (boolean createIncomplete : new boolean[] { true, false })
1660 +        for (boolean fFirst : new boolean[] { true, false })
1661 +        for (Integer v1 : new Integer[] { 1, null })
1662 +    {
1663          final CompletableFuture<Integer> f = new CompletableFuture<>();
1664          final CompletableFuture<Integer> g = new CompletableFuture<>();
1119        final Noop r = new Noop();
1665          final CFException ex = new CFException();
1666 +        final IncFunction r = new IncFunction();
1667  
1668 <        g.completeExceptionally(ex);
1669 <        f.complete(v1);
1670 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1668 >        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1669 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1670 >        if (createIncomplete) {
1671 >            checkIncomplete(h);
1672 >            assertEquals(0, r.invocationCount);
1673 >            (fFirst ? f : g).completeExceptionally(ex);
1674 >        }
1675  
1676          checkCompletedWithWrappedCFException(h, ex);
1677 <        checkCompletedWithWrappedCFException(g, ex);
1128 <        assertFalse(r.ran);
1129 <        checkCompletedNormally(f, v1);
1130 <        }
1131 <    }
1677 >        (!fFirst ? f : g).complete(v1);
1678  
1679 <    public void testRunAfterBoth_exceptionalCompletion4() {
1680 <        for (ExecutionMode m : ExecutionMode.values())
1681 <        for (Integer v1 : new Integer[] { 1, null }) {
1679 >        assertEquals(0, r.invocationCount);
1680 >        checkCompletedNormally(!fFirst ? f : g, v1);
1681 >        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1682 >        checkCompletedWithWrappedCFException(h, ex);
1683 >    }}
1684  
1685 +    public void testApplyToEither_exceptionalCompletion2() {
1686 +        for (ExecutionMode m : ExecutionMode.values())
1687 +        for (boolean reverseArgs : new boolean[] { true, false })
1688 +        for (boolean fFirst : new boolean[] { true, false })
1689 +        for (Integer v1 : new Integer[] { 1, null })
1690 +    {
1691          final CompletableFuture<Integer> f = new CompletableFuture<>();
1692          final CompletableFuture<Integer> g = new CompletableFuture<>();
1693 <        final Noop r = new Noop();
1693 >        final IncFunction r1 = new IncFunction();
1694 >        final IncFunction r2 = new IncFunction();
1695          final CFException ex = new CFException();
1696 +        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1697 +        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1698 +        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1699 +        if (fFirst) {
1700 +            f.complete(v1);
1701 +            g.completeExceptionally(ex);
1702 +        } else {
1703 +            g.completeExceptionally(ex);
1704 +            f.complete(v1);
1705 +        }
1706 +        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1707 +
1708 +        // unspecified behavior
1709 +        try {
1710 +            assertEquals(inc(v1), h1.join());
1711 +            assertEquals(1, r1.invocationCount);
1712 +        } catch (CompletionException ok) {
1713 +            checkCompletedWithWrappedCFException(h1, ex);
1714 +            assertEquals(0, r1.invocationCount);
1715 +        }
1716  
1717 <        f.completeExceptionally(ex);
1718 <        g.complete(v1);
1719 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1720 <
1721 <        checkCompletedWithWrappedCFException(h, ex);
1722 <        checkCompletedWithWrappedCFException(f, ex);
1148 <        assertFalse(r.ran);
1149 <        checkCompletedNormally(g, v1);
1717 >        try {
1718 >            assertEquals(inc(v1), h2.join());
1719 >            assertEquals(1, r2.invocationCount);
1720 >        } catch (CompletionException ok) {
1721 >            checkCompletedWithWrappedCFException(h2, ex);
1722 >            assertEquals(0, r2.invocationCount);
1723          }
1724 <    }
1724 >
1725 >        checkCompletedWithWrappedCFException(g, ex);
1726 >        checkCompletedNormally(f, v1);
1727 >    }}
1728  
1729      /**
1730 <     * runAfterBoth result completes exceptionally if action does
1730 >     * applyToEither result completes exceptionally if action does
1731       */
1732 <    public void testRunAfterBoth_actionFailed1() {
1732 >    public void testApplyToEither_actionFailed1() {
1733          for (ExecutionMode m : ExecutionMode.values())
1734          for (Integer v1 : new Integer[] { 1, null })
1735 <        for (Integer v2 : new Integer[] { 2, null }) {
1736 <
1735 >        for (Integer v2 : new Integer[] { 2, null })
1736 >    {
1737          final CompletableFuture<Integer> f = new CompletableFuture<>();
1738          final CompletableFuture<Integer> g = new CompletableFuture<>();
1739 <        final FailingNoop r = new FailingNoop();
1740 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1739 >        final FailingFunction r = new FailingFunction();
1740 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1741  
1742          f.complete(v1);
1167        checkIncomplete(h);
1168        g.complete(v2);
1169
1743          checkCompletedWithWrappedCFException(h);
1744 +        g.complete(v2);
1745          checkCompletedNormally(f, v1);
1746          checkCompletedNormally(g, v2);
1747 <        }
1174 <    }
1747 >    }}
1748  
1749 <    public void testRunAfterBoth_actionFailed2() {
1749 >    public void testApplyToEither_actionFailed2() {
1750          for (ExecutionMode m : ExecutionMode.values())
1751          for (Integer v1 : new Integer[] { 1, null })
1752 <        for (Integer v2 : new Integer[] { 2, null }) {
1753 <
1752 >        for (Integer v2 : new Integer[] { 2, null })
1753 >    {
1754          final CompletableFuture<Integer> f = new CompletableFuture<>();
1755          final CompletableFuture<Integer> g = new CompletableFuture<>();
1756 <        final FailingNoop r = new FailingNoop();
1757 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1756 >        final FailingFunction r = new FailingFunction();
1757 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1758  
1759          g.complete(v2);
1187        checkIncomplete(h);
1188        f.complete(v1);
1189
1760          checkCompletedWithWrappedCFException(h);
1761 +        f.complete(v1);
1762          checkCompletedNormally(f, v1);
1763          checkCompletedNormally(g, v2);
1764 <        }
1194 <    }
1764 >    }}
1765  
1766      /**
1767 <     * runAfterBoth result completes exceptionally if either source cancelled
1767 >     * applyToEither result completes exceptionally if either source cancelled
1768       */
1769 <    public void testRunAfterBoth_sourceCancelled1() {
1769 >    public void testApplyToEither_sourceCancelled1() {
1770          for (ExecutionMode m : ExecutionMode.values())
1771          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1772 <        for (Integer v1 : new Integer[] { 1, null }) {
1773 <
1772 >        for (boolean createIncomplete : new boolean[] { true, false })
1773 >        for (boolean fFirst : new boolean[] { true, false })
1774 >        for (Integer v1 : new Integer[] { 1, null })
1775 >    {
1776          final CompletableFuture<Integer> f = new CompletableFuture<>();
1777          final CompletableFuture<Integer> g = new CompletableFuture<>();
1778 <        final Noop r = new Noop();
1207 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1778 >        final IncFunction r = new IncFunction();
1779  
1780 <        assertTrue(f.cancel(mayInterruptIfRunning));
1781 <        checkIncomplete(h);
1782 <        g.complete(v1);
1780 >        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1781 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1782 >        if (createIncomplete) {
1783 >            checkIncomplete(h);
1784 >            assertEquals(0, r.invocationCount);
1785 >            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1786 >        }
1787  
1788          checkCompletedWithWrappedCancellationException(h);
1789 <        checkCancelled(f);
1790 <        assertFalse(r.ran);
1791 <        checkCompletedNormally(g, v1);
1792 <        }
1793 <    }
1789 >        (!fFirst ? f : g).complete(v1);
1790 >
1791 >        assertEquals(0, r.invocationCount);
1792 >        checkCompletedNormally(!fFirst ? f : g, v1);
1793 >        checkCancelled(fFirst ? f : g);
1794 >        checkCompletedWithWrappedCancellationException(h);
1795 >    }}
1796  
1797 <    public void testRunAfterBoth_sourceCancelled2() {
1797 >    public void testApplyToEither_sourceCancelled2() {
1798          for (ExecutionMode m : ExecutionMode.values())
1799          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1800 <        for (Integer v1 : new Integer[] { 1, null }) {
1801 <
1800 >        for (boolean reverseArgs : new boolean[] { true, false })
1801 >        for (boolean fFirst : new boolean[] { true, false })
1802 >        for (Integer v1 : new Integer[] { 1, null })
1803 >    {
1804          final CompletableFuture<Integer> f = new CompletableFuture<>();
1805          final CompletableFuture<Integer> g = new CompletableFuture<>();
1806 <        final Noop r = new Noop();
1807 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1806 >        final IncFunction r1 = new IncFunction();
1807 >        final IncFunction r2 = new IncFunction();
1808 >        final CFException ex = new CFException();
1809 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1810 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1811  
1812 <        assertTrue(g.cancel(mayInterruptIfRunning));
1813 <        checkIncomplete(h);
1814 <        f.complete(v1);
1812 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1813 >        if (fFirst) {
1814 >            f.complete(v1);
1815 >            assertTrue(g.cancel(mayInterruptIfRunning));
1816 >        } else {
1817 >            assertTrue(g.cancel(mayInterruptIfRunning));
1818 >            f.complete(v1);
1819 >        }
1820 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1821 >
1822 >        // unspecified behavior
1823 >        try {
1824 >            assertEquals(inc(v1), h1.join());
1825 >            assertEquals(1, r1.invocationCount);
1826 >        } catch (CompletionException ok) {
1827 >            checkCompletedWithWrappedCancellationException(h1);
1828 >            assertEquals(0, r1.invocationCount);
1829 >        }
1830 >
1831 >        try {
1832 >            assertEquals(inc(v1), h2.join());
1833 >            assertEquals(1, r2.invocationCount);
1834 >        } catch (CompletionException ok) {
1835 >            checkCompletedWithWrappedCancellationException(h2);
1836 >            assertEquals(0, r2.invocationCount);
1837 >        }
1838  
1234        checkCompletedWithWrappedCancellationException(h);
1839          checkCancelled(g);
1236        assertFalse(r.ran);
1840          checkCompletedNormally(f, v1);
1841 <        }
1239 <    }
1841 >    }}
1842  
1843 <    public void testRunAfterBoth_sourceCancelled3() {
1843 >    /**
1844 >     * acceptEither result completes normally after normal completion
1845 >     * of either source
1846 >     */
1847 >    public void testAcceptEither_normalCompletion1() {
1848          for (ExecutionMode m : ExecutionMode.values())
1849 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1850 <        for (Integer v1 : new Integer[] { 1, null }) {
1851 <
1849 >        for (Integer v1 : new Integer[] { 1, null })
1850 >        for (Integer v2 : new Integer[] { 2, null })
1851 >    {
1852          final CompletableFuture<Integer> f = new CompletableFuture<>();
1853          final CompletableFuture<Integer> g = new CompletableFuture<>();
1854 <        final Noop r = new Noop();
1854 >        final IncAction r = new IncAction();
1855 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1856  
1250        assertTrue(g.cancel(mayInterruptIfRunning));
1857          f.complete(v1);
1858 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1858 >        checkCompletedNormally(h, null);
1859 >        assertEquals(inc(v1), r.value);
1860 >        g.complete(v2);
1861  
1254        checkCompletedWithWrappedCancellationException(h);
1255        checkCancelled(g);
1256        assertFalse(r.ran);
1862          checkCompletedNormally(f, v1);
1863 <        }
1864 <    }
1863 >        checkCompletedNormally(g, v2);
1864 >        checkCompletedNormally(h, null);
1865 >    }}
1866  
1867 <    public void testRunAfterBoth_sourceCancelled4() {
1867 >    public void testAcceptEither_normalCompletion2() {
1868          for (ExecutionMode m : ExecutionMode.values())
1869 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1870 <        for (Integer v1 : new Integer[] { 1, null }) {
1871 <
1869 >        for (Integer v1 : new Integer[] { 1, null })
1870 >        for (Integer v2 : new Integer[] { 2, null })
1871 >    {
1872          final CompletableFuture<Integer> f = new CompletableFuture<>();
1873          final CompletableFuture<Integer> g = new CompletableFuture<>();
1874 <        final Noop r = new Noop();
1875 <
1270 <        assertTrue(f.cancel(mayInterruptIfRunning));
1271 <        g.complete(v1);
1272 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1273 <
1274 <        checkCompletedWithWrappedCancellationException(h);
1275 <        checkCancelled(f);
1276 <        assertFalse(r.ran);
1277 <        checkCompletedNormally(g, v1);
1278 <        }
1279 <    }
1874 >        final IncAction r = new IncAction();
1875 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1876  
1877 <    /**
1878 <     * applyToEither result completes normally after normal completion
1879 <     * of either source
1880 <     */
1285 <    public void testApplyToEither() {
1286 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1287 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1288 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1289 <        f.complete(one);
1290 <        checkCompletedNormally(g, two);
1291 <        f2.complete(one);
1292 <        checkCompletedNormally(g, two);
1293 <
1294 <        f = new CompletableFuture<>();
1295 <        f.complete(one);
1296 <        f2 = new CompletableFuture<>();
1297 <        g = f.applyToEither(f2, inc);
1298 <        checkCompletedNormally(g, two);
1299 <    }
1300 <
1301 <    /**
1302 <     * applyToEither result completes exceptionally after exceptional
1303 <     * completion of either source
1304 <     */
1305 <    public void testApplyToEither2() {
1306 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1307 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1308 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1309 <        f.completeExceptionally(new CFException());
1310 <        f2.complete(one);
1311 <        checkCompletedWithWrappedCFException(g);
1877 >        g.complete(v2);
1878 >        checkCompletedNormally(h, null);
1879 >        assertEquals(inc(v2), r.value);
1880 >        f.complete(v1);
1881  
1882 <        f = new CompletableFuture<>();
1883 <        f2 = new CompletableFuture<>();
1884 <        f2.completeExceptionally(new CFException());
1885 <        g = f.applyToEither(f2, inc);
1317 <        checkCompletedWithWrappedCFException(g);
1318 <    }
1882 >        checkCompletedNormally(f, v1);
1883 >        checkCompletedNormally(g, v2);
1884 >        checkCompletedNormally(h, null);
1885 >    }}
1886  
1887 <    /**
1888 <     * applyToEither result completes exceptionally if action does
1889 <     */
1890 <    public void testApplyToEither3() {
1891 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1892 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1893 <        FailingFunction r = new FailingFunction();
1894 <        CompletableFuture<Integer> g = f.applyToEither(f2, r);
1328 <        f2.complete(two);
1329 <        checkCompletedWithWrappedCFException(g);
1330 <    }
1887 >    public void testAcceptEither_normalCompletion3() {
1888 >        for (ExecutionMode m : ExecutionMode.values())
1889 >        for (Integer v1 : new Integer[] { 1, null })
1890 >        for (Integer v2 : new Integer[] { 2, null })
1891 >    {
1892 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1893 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1894 >        final IncAction r = new IncAction();
1895  
1896 <    /**
1897 <     * applyToEither result completes exceptionally if either source cancelled
1898 <     */
1335 <    public void testApplyToEither4() {
1336 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1337 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1338 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1339 <        assertTrue(f.cancel(true));
1340 <        checkCompletedWithWrappedCancellationException(g);
1341 <        f = new CompletableFuture<>();
1342 <        f2 = new CompletableFuture<>();
1343 <        assertTrue(f2.cancel(true));
1344 <        checkCompletedWithWrappedCancellationException(g);
1345 <    }
1896 >        f.complete(v1);
1897 >        g.complete(v2);
1898 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1899  
1900 <    /**
1901 <     * acceptEither result completes normally after normal completion
1902 <     * of either source
1350 <     */
1351 <    public void testAcceptEither() {
1352 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1353 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1354 <        IncAction r = new IncAction();
1355 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1356 <        f.complete(one);
1357 <        checkCompletedNormally(g, null);
1358 <        f2.complete(one);
1359 <        checkCompletedNormally(g, null);
1360 <        assertEquals(r.value, 2);
1900 >        checkCompletedNormally(h, null);
1901 >        checkCompletedNormally(f, v1);
1902 >        checkCompletedNormally(g, v2);
1903  
1904 <        r = new IncAction();
1905 <        f = new CompletableFuture<>();
1906 <        f.complete(one);
1907 <        f2 = new CompletableFuture<>();
1366 <        g = f.acceptEither(f2, r);
1367 <        checkCompletedNormally(g, null);
1368 <        assertEquals(r.value, 2);
1369 <    }
1904 >        // unspecified behavior
1905 >        assertTrue(Objects.equals(r.value, inc(v1)) ||
1906 >                   Objects.equals(r.value, inc(v2)));
1907 >    }}
1908  
1909      /**
1910       * acceptEither result completes exceptionally after exceptional
1911       * completion of either source
1912       */
1913 <    public void testAcceptEither2() {
1914 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1915 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1916 <        IncAction r = new IncAction();
1917 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1918 <        f.completeExceptionally(new CFException());
1919 <        f2.complete(one);
1920 <        checkCompletedWithWrappedCFException(g);
1921 <
1384 <        r = new IncAction();
1385 <        f = new CompletableFuture<>();
1386 <        f2 = new CompletableFuture<>();
1387 <        f2.completeExceptionally(new CFException());
1388 <        g = f.acceptEither(f2, r);
1389 <        checkCompletedWithWrappedCFException(g);
1390 <    }
1391 <
1392 <    /**
1393 <     * acceptEither result completes exceptionally if action does
1394 <     */
1395 <    public void testAcceptEither3() {
1396 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1397 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1398 <        FailingConsumer r = new FailingConsumer();
1399 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1400 <        f2.complete(two);
1401 <        checkCompletedWithWrappedCFException(g);
1402 <    }
1403 <
1404 <    /**
1405 <     * acceptEither result completes exceptionally if either source cancelled
1406 <     */
1407 <    public void testAcceptEither4() {
1408 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1409 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1410 <        IncAction r = new IncAction();
1411 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1412 <        assertTrue(f.cancel(true));
1413 <        checkCompletedWithWrappedCancellationException(g);
1414 <        f = new CompletableFuture<>();
1415 <        f2 = new CompletableFuture<>();
1416 <        assertTrue(f2.cancel(true));
1417 <        checkCompletedWithWrappedCancellationException(g);
1418 <    }
1419 <
1420 <    /**
1421 <     * runAfterEither result completes normally after normal completion
1422 <     * of either source
1423 <     */
1424 <    public void testRunAfterEither() {
1425 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1426 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1427 <        Noop r = new Noop();
1428 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1429 <        f.complete(one);
1430 <        checkCompletedNormally(g, null);
1431 <        f2.complete(one);
1432 <        checkCompletedNormally(g, null);
1433 <        assertTrue(r.ran);
1434 <
1435 <        r = new Noop();
1436 <        f = new CompletableFuture<>();
1437 <        f.complete(one);
1438 <        f2 = new CompletableFuture<>();
1439 <        g = f.runAfterEither(f2, r);
1440 <        checkCompletedNormally(g, null);
1441 <        assertTrue(r.ran);
1442 <    }
1443 <
1444 <    /**
1445 <     * runAfterEither result completes exceptionally after exceptional
1446 <     * completion of either source
1447 <     */
1448 <    public void testRunAfterEither2() {
1449 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1450 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1451 <        Noop r = new Noop();
1452 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1453 <        f.completeExceptionally(new CFException());
1454 <        f2.complete(one);
1455 <        checkCompletedWithWrappedCFException(g);
1456 <
1457 <        r = new Noop();
1458 <        f = new CompletableFuture<>();
1459 <        f2 = new CompletableFuture<>();
1460 <        f2.completeExceptionally(new CFException());
1461 <        g = f.runAfterEither(f2, r);
1462 <        checkCompletedWithWrappedCFException(g);
1463 <    }
1464 <
1465 <    /**
1466 <     * runAfterEither result completes exceptionally if action does
1467 <     */
1468 <    public void testRunAfterEither3() {
1469 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1470 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1471 <        FailingNoop r = new FailingNoop();
1472 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1473 <        f2.complete(two);
1474 <        checkCompletedWithWrappedCFException(g);
1475 <    }
1476 <
1477 <    /**
1478 <     * runAfterEither result completes exceptionally if either source cancelled
1479 <     */
1480 <    public void testRunAfterEither4() {
1481 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1482 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1483 <        Noop r = new Noop();
1484 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1485 <        assertTrue(f.cancel(true));
1486 <        checkCompletedWithWrappedCancellationException(g);
1487 <        f = new CompletableFuture<>();
1488 <        f2 = new CompletableFuture<>();
1489 <        assertTrue(f2.cancel(true));
1490 <        checkCompletedWithWrappedCancellationException(g);
1491 <    }
1492 <
1493 <    /**
1494 <     * thenCompose result completes normally after normal completion of source
1495 <     */
1496 <    public void testThenCompose() {
1497 <        CompletableFuture<Integer> f, g;
1498 <        CompletableFutureInc r;
1499 <
1500 <        f = new CompletableFuture<>();
1501 <        g = f.thenCompose(r = new CompletableFutureInc());
1502 <        f.complete(one);
1503 <        checkCompletedNormally(g, two);
1504 <        assertTrue(r.ran);
1505 <
1506 <        f = new CompletableFuture<>();
1507 <        f.complete(one);
1508 <        g = f.thenCompose(r = new CompletableFutureInc());
1509 <        checkCompletedNormally(g, two);
1510 <        assertTrue(r.ran);
1511 <    }
1512 <
1513 <    /**
1514 <     * thenCompose result completes exceptionally after exceptional
1515 <     * completion of source
1516 <     */
1517 <    public void testThenCompose2() {
1518 <        CompletableFuture<Integer> f, g;
1519 <        CompletableFutureInc r;
1520 <
1521 <        f = new CompletableFuture<>();
1522 <        g = f.thenCompose(r = new CompletableFutureInc());
1523 <        f.completeExceptionally(new CFException());
1524 <        checkCompletedWithWrappedCFException(g);
1525 <
1526 <        f = new CompletableFuture<>();
1527 <        f.completeExceptionally(new CFException());
1528 <        g = f.thenCompose(r = new CompletableFutureInc());
1529 <        checkCompletedWithWrappedCFException(g);
1530 <    }
1531 <
1532 <    /**
1533 <     * thenCompose result completes exceptionally if action does
1534 <     */
1535 <    public void testThenCompose3() {
1536 <        CompletableFuture<Integer> f, g;
1537 <        FailingCompletableFutureFunction r;
1538 <
1539 <        f = new CompletableFuture<>();
1540 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
1541 <        f.complete(one);
1542 <        checkCompletedWithWrappedCFException(g);
1913 >    public void testAcceptEither_exceptionalCompletion1() {
1914 >        for (ExecutionMode m : ExecutionMode.values())
1915 >        for (Integer v1 : new Integer[] { 1, null })
1916 >    {
1917 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1918 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1919 >        final IncAction r = new IncAction();
1920 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1921 >        final CFException ex = new CFException();
1922  
1923 <        f = new CompletableFuture<>();
1924 <        f.complete(one);
1925 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
1547 <        checkCompletedWithWrappedCFException(g);
1548 <    }
1923 >        f.completeExceptionally(ex);
1924 >        checkCompletedWithWrappedCFException(h, ex);
1925 >        g.complete(v1);
1926  
1927 <    /**
1928 <     * thenCompose result completes exceptionally if source cancelled
1929 <     */
1930 <    public void testThenCompose4() {
1931 <        CompletableFuture<Integer> f, g;
1555 <        CompletableFutureInc r;
1927 >        assertEquals(0, r.invocationCount);
1928 >        checkCompletedNormally(g, v1);
1929 >        checkCompletedWithWrappedCFException(f, ex);
1930 >        checkCompletedWithWrappedCFException(h, ex);
1931 >    }}
1932  
1933 <        f = new CompletableFuture<>();
1934 <        g = f.thenCompose(r = new CompletableFutureInc());
1935 <        assertTrue(f.cancel(true));
1936 <        checkCompletedWithWrappedCancellationException(g);
1933 >    public void testAcceptEither_exceptionalCompletion2() {
1934 >        for (ExecutionMode m : ExecutionMode.values())
1935 >        for (Integer v1 : new Integer[] { 1, null })
1936 >    {
1937 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1938 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1939 >        final IncAction r = new IncAction();
1940 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1941 >        final CFException ex = new CFException();
1942  
1943 <        f = new CompletableFuture<>();
1944 <        assertTrue(f.cancel(true));
1945 <        g = f.thenCompose(r = new CompletableFutureInc());
1565 <        checkCompletedWithWrappedCancellationException(g);
1566 <    }
1943 >        g.completeExceptionally(ex);
1944 >        checkCompletedWithWrappedCFException(h, ex);
1945 >        f.complete(v1);
1946  
1947 <    // asyncs
1947 >        assertEquals(0, r.invocationCount);
1948 >        checkCompletedNormally(f, v1);
1949 >        checkCompletedWithWrappedCFException(g, ex);
1950 >        checkCompletedWithWrappedCFException(h, ex);
1951 >    }}
1952  
1953 <    /**
1954 <     * thenRunAsync result completes normally after normal completion of source
1955 <     */
1956 <    public void testThenRunAsync() {
1957 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1958 <        Noop r = new Noop();
1959 <        CompletableFuture<Void> g = f.thenRunAsync(r);
1960 <        f.complete(null);
1578 <        checkCompletedNormally(g, null);
1953 >    public void testAcceptEither_exceptionalCompletion3() {
1954 >        for (ExecutionMode m : ExecutionMode.values())
1955 >        for (Integer v1 : new Integer[] { 1, null })
1956 >    {
1957 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1958 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1959 >        final IncAction r = new IncAction();
1960 >        final CFException ex = new CFException();
1961  
1962 <        // reordered version
1963 <        f = new CompletableFuture<>();
1964 <        f.complete(null);
1583 <        r = new Noop();
1584 <        g = f.thenRunAsync(r);
1585 <        checkCompletedNormally(g, null);
1586 <    }
1962 >        g.completeExceptionally(ex);
1963 >        f.complete(v1);
1964 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1965  
1966 <    /**
1967 <     * thenRunAsync result completes exceptionally after exceptional
1590 <     * completion of source
1591 <     */
1592 <    public void testThenRunAsync2() {
1593 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1594 <        Noop r = new Noop();
1595 <        CompletableFuture<Void> g = f.thenRunAsync(r);
1596 <        f.completeExceptionally(new CFException());
1966 >        // unspecified behavior
1967 >        Integer v;
1968          try {
1969 <            g.join();
1970 <            shouldThrow();
1971 <        } catch (CompletionException success) {}
1972 <        checkCompletedWithWrappedCFException(g);
1973 <    }
1974 <
1975 <    /**
1605 <     * thenRunAsync result completes exceptionally if action does
1606 <     */
1607 <    public void testThenRunAsync3() {
1608 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1609 <        FailingNoop r = new FailingNoop();
1610 <        CompletableFuture<Void> g = f.thenRunAsync(r);
1611 <        f.complete(null);
1612 <        checkCompletedWithWrappedCFException(g);
1613 <    }
1614 <
1615 <    /**
1616 <     * thenRunAsync result completes exceptionally if source cancelled
1617 <     */
1618 <    public void testThenRunAsync4() {
1619 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1620 <        Noop r = new Noop();
1621 <        CompletableFuture<Void> g = f.thenRunAsync(r);
1622 <        assertTrue(f.cancel(true));
1623 <        checkCompletedWithWrappedCancellationException(g);
1624 <    }
1625 <
1626 <    /**
1627 <     * thenApplyAsync result completes normally after normal completion of source
1628 <     */
1629 <    public void testThenApplyAsync() {
1630 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1631 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
1632 <        f.complete(one);
1633 <        checkCompletedNormally(g, two);
1634 <    }
1635 <
1636 <    /**
1637 <     * thenApplyAsync result completes exceptionally after exceptional
1638 <     * completion of source
1639 <     */
1640 <    public void testThenApplyAsync2() {
1641 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1642 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
1643 <        f.completeExceptionally(new CFException());
1644 <        checkCompletedWithWrappedCFException(g);
1645 <    }
1646 <
1647 <    /**
1648 <     * thenApplyAsync result completes exceptionally if action does
1649 <     */
1650 <    public void testThenApplyAsync3() {
1651 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1652 <        FailingFunction r = new FailingFunction();
1653 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
1654 <        f.complete(null);
1655 <        checkCompletedWithWrappedCFException(g);
1656 <    }
1657 <
1658 <    /**
1659 <     * thenApplyAsync result completes exceptionally if source cancelled
1660 <     */
1661 <    public void testThenApplyAsync4() {
1662 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1663 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
1664 <        assertTrue(f.cancel(true));
1665 <        checkCompletedWithWrappedCancellationException(g);
1666 <    }
1667 <
1668 <    /**
1669 <     * thenAcceptAsync result completes normally after normal
1670 <     * completion of source
1671 <     */
1672 <    public void testThenAcceptAsync() {
1673 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1674 <        IncAction r = new IncAction();
1675 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
1676 <        f.complete(one);
1677 <        checkCompletedNormally(g, null);
1678 <        assertEquals(r.value, 2);
1679 <    }
1680 <
1681 <    /**
1682 <     * thenAcceptAsync result completes exceptionally after exceptional
1683 <     * completion of source
1684 <     */
1685 <    public void testThenAcceptAsync2() {
1686 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1687 <        IncAction r = new IncAction();
1688 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
1689 <        f.completeExceptionally(new CFException());
1690 <        checkCompletedWithWrappedCFException(g);
1691 <    }
1692 <
1693 <    /**
1694 <     * thenAcceptAsync result completes exceptionally if action does
1695 <     */
1696 <    public void testThenAcceptAsync3() {
1697 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1698 <        FailingConsumer r = new FailingConsumer();
1699 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
1700 <        f.complete(null);
1701 <        checkCompletedWithWrappedCFException(g);
1702 <    }
1969 >            assertNull(h.join());
1970 >            assertEquals(1, r.invocationCount);
1971 >            assertEquals(inc(v1), r.value);
1972 >        } catch (CompletionException ok) {
1973 >            checkCompletedWithWrappedCFException(h, ex);
1974 >            assertEquals(0, r.invocationCount);
1975 >        }
1976  
1977 <    /**
1978 <     * thenAcceptAsync result completes exceptionally if source cancelled
1979 <     */
1707 <    public void testThenAcceptAsync4() {
1708 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1709 <        IncAction r = new IncAction();
1710 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
1711 <        assertTrue(f.cancel(true));
1712 <        checkCompletedWithWrappedCancellationException(g);
1713 <    }
1977 >        checkCompletedWithWrappedCFException(g, ex);
1978 >        checkCompletedNormally(f, v1);
1979 >    }}
1980  
1981 <    /**
1982 <     * thenCombineAsync result completes normally after normal
1983 <     * completion of sources
1984 <     */
1985 <    public void testThenCombineAsync() {
1986 <        CompletableFuture<Integer> f, g, h;
1981 >    public void testAcceptEither_exceptionalCompletion4() {
1982 >        for (ExecutionMode m : ExecutionMode.values())
1983 >        for (Integer v1 : new Integer[] { 1, null })
1984 >    {
1985 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1986 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1987 >        final IncAction r = new IncAction();
1988 >        final CFException ex = new CFException();
1989  
1990 <        f = new CompletableFuture<>();
1991 <        g = new CompletableFuture<>();
1992 <        h = f.thenCombineAsync(g, subtract);
1725 <        f.complete(3);
1726 <        checkIncomplete(h);
1727 <        g.complete(1);
1728 <        checkCompletedNormally(h, 2);
1990 >        f.completeExceptionally(ex);
1991 >        g.complete(v1);
1992 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1993  
1994 <        f = new CompletableFuture<>();
1995 <        g = new CompletableFuture<>();
1996 <        h = f.thenCombineAsync(g, subtract);
1997 <        g.complete(1);
1998 <        checkIncomplete(h);
1999 <        f.complete(3);
2000 <        checkCompletedNormally(h, 2);
1994 >        // unspecified behavior
1995 >        Integer v;
1996 >        try {
1997 >            assertNull(h.join());
1998 >            assertEquals(1, r.invocationCount);
1999 >            assertEquals(inc(v1), r.value);
2000 >        } catch (CompletionException ok) {
2001 >            checkCompletedWithWrappedCFException(h, ex);
2002 >            assertEquals(0, r.invocationCount);
2003 >        }
2004  
2005 <        f = new CompletableFuture<>();
2006 <        g = new CompletableFuture<>();
2007 <        g.complete(1);
1741 <        f.complete(3);
1742 <        h = f.thenCombineAsync(g, subtract);
1743 <        checkCompletedNormally(h, 2);
1744 <    }
2005 >        checkCompletedWithWrappedCFException(f, ex);
2006 >        checkCompletedNormally(g, v1);
2007 >    }}
2008  
2009      /**
2010 <     * thenCombineAsync result completes exceptionally after exceptional
1748 <     * completion of either source
2010 >     * acceptEither result completes exceptionally if action does
2011       */
2012 <    public void testThenCombineAsync2() {
2013 <        CompletableFuture<Integer> f, g, h;
2012 >    public void testAcceptEither_actionFailed1() {
2013 >        for (ExecutionMode m : ExecutionMode.values())
2014 >        for (Integer v1 : new Integer[] { 1, null })
2015 >        for (Integer v2 : new Integer[] { 2, null })
2016 >    {
2017 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2018 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2019 >        final FailingConsumer r = new FailingConsumer();
2020 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2021  
2022 <        f = new CompletableFuture<>();
1754 <        g = new CompletableFuture<>();
1755 <        h = f.thenCombineAsync(g, subtract);
1756 <        f.completeExceptionally(new CFException());
1757 <        checkIncomplete(h);
1758 <        g.complete(1);
2022 >        f.complete(v1);
2023          checkCompletedWithWrappedCFException(h);
2024 +        g.complete(v2);
2025 +        checkCompletedNormally(f, v1);
2026 +        checkCompletedNormally(g, v2);
2027 +    }}
2028  
2029 <        f = new CompletableFuture<>();
2030 <        g = new CompletableFuture<>();
2031 <        h = f.thenCombineAsync(g, subtract);
2032 <        g.completeExceptionally(new CFException());
2033 <        checkIncomplete(h);
2034 <        f.complete(3);
2035 <        checkCompletedWithWrappedCFException(h);
2029 >    public void testAcceptEither_actionFailed2() {
2030 >        for (ExecutionMode m : ExecutionMode.values())
2031 >        for (Integer v1 : new Integer[] { 1, null })
2032 >        for (Integer v2 : new Integer[] { 2, null })
2033 >    {
2034 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2035 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2036 >        final FailingConsumer r = new FailingConsumer();
2037 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2038  
2039 <        f = new CompletableFuture<>();
1770 <        g = new CompletableFuture<>();
1771 <        g.completeExceptionally(new CFException());
1772 <        f.complete(3);
1773 <        h = f.thenCombineAsync(g, subtract);
2039 >        g.complete(v2);
2040          checkCompletedWithWrappedCFException(h);
2041 <    }
2042 <
2043 <    /**
2044 <     * thenCombineAsync result completes exceptionally if action does
1779 <     */
1780 <    public void testThenCombineAsync3() {
1781 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1782 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1783 <        FailingBiFunction r = new FailingBiFunction();
1784 <        CompletableFuture<Integer> g = f.thenCombineAsync(f2, r);
1785 <        f.complete(one);
1786 <        checkIncomplete(g);
1787 <        assertFalse(r.ran);
1788 <        f2.complete(two);
1789 <        checkCompletedWithWrappedCFException(g);
1790 <        assertTrue(r.ran);
1791 <    }
2041 >        f.complete(v1);
2042 >        checkCompletedNormally(f, v1);
2043 >        checkCompletedNormally(g, v2);
2044 >    }}
2045  
2046      /**
2047 <     * thenCombineAsync result completes exceptionally if either source cancelled
2047 >     * acceptEither result completes exceptionally if either source cancelled
2048       */
2049 <    public void testThenCombineAsync4() {
2050 <        CompletableFuture<Integer> f, g, h;
2051 <
2052 <        f = new CompletableFuture<>();
2053 <        g = new CompletableFuture<>();
2054 <        h = f.thenCombineAsync(g, subtract);
2055 <        assertTrue(f.cancel(true));
2056 <        checkIncomplete(h);
2057 <        g.complete(1);
1805 <        checkCompletedWithWrappedCancellationException(h);
1806 <
1807 <        f = new CompletableFuture<>();
1808 <        g = new CompletableFuture<>();
1809 <        h = f.thenCombineAsync(g, subtract);
1810 <        assertTrue(g.cancel(true));
1811 <        checkIncomplete(h);
1812 <        f.complete(3);
1813 <        checkCompletedWithWrappedCancellationException(h);
1814 <
1815 <        f = new CompletableFuture<>();
1816 <        g = new CompletableFuture<>();
1817 <        g.complete(3);
1818 <        assertTrue(f.cancel(true));
1819 <        h = f.thenCombineAsync(g, subtract);
1820 <        checkCompletedWithWrappedCancellationException(h);
2049 >    public void testAcceptEither_sourceCancelled1() {
2050 >        for (ExecutionMode m : ExecutionMode.values())
2051 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2052 >        for (Integer v1 : new Integer[] { 1, null })
2053 >    {
2054 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2055 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2056 >        final IncAction r = new IncAction();
2057 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2058  
2059 <        f = new CompletableFuture<>();
1823 <        g = new CompletableFuture<>();
1824 <        f.complete(3);
1825 <        assertTrue(g.cancel(true));
1826 <        h = f.thenCombineAsync(g, subtract);
2059 >        assertTrue(f.cancel(mayInterruptIfRunning));
2060          checkCompletedWithWrappedCancellationException(h);
2061 <    }
1829 <
1830 <    /**
1831 <     * thenAcceptBothAsync result completes normally after normal
1832 <     * completion of sources
1833 <     */
1834 <    public void testThenAcceptBothAsync() {
1835 <        CompletableFuture<Integer> f, g;
1836 <        CompletableFuture<Void> h;
1837 <        SubtractAction r;
1838 <
1839 <        f = new CompletableFuture<>();
1840 <        g = new CompletableFuture<>();
1841 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1842 <        f.complete(3);
1843 <        checkIncomplete(h);
1844 <        g.complete(1);
1845 <        checkCompletedNormally(h, null);
1846 <        assertEquals(r.value, 2);
1847 <
1848 <        f = new CompletableFuture<>();
1849 <        g = new CompletableFuture<>();
1850 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1851 <        g.complete(1);
1852 <        checkIncomplete(h);
1853 <        f.complete(3);
1854 <        checkCompletedNormally(h, null);
1855 <        assertEquals(r.value, 2);
1856 <
1857 <        f = new CompletableFuture<>();
1858 <        g = new CompletableFuture<>();
1859 <        g.complete(1);
1860 <        f.complete(3);
1861 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1862 <        checkCompletedNormally(h, null);
1863 <        assertEquals(r.value, 2);
1864 <    }
1865 <
1866 <    /**
1867 <     * thenAcceptBothAsync result completes exceptionally after exceptional
1868 <     * completion of source
1869 <     */
1870 <    public void testThenAcceptBothAsync2() {
1871 <        CompletableFuture<Integer> f, g;
1872 <        CompletableFuture<Void> h;
1873 <        SubtractAction r;
1874 <
1875 <        f = new CompletableFuture<>();
1876 <        g = new CompletableFuture<>();
1877 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1878 <        f.completeExceptionally(new CFException());
1879 <        checkIncomplete(h);
1880 <        g.complete(1);
1881 <        checkCompletedWithWrappedCFException(h);
1882 <
1883 <        f = new CompletableFuture<>();
1884 <        g = new CompletableFuture<>();
1885 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1886 <        g.completeExceptionally(new CFException());
1887 <        checkIncomplete(h);
1888 <        f.complete(3);
1889 <        checkCompletedWithWrappedCFException(h);
1890 <
1891 <        f = new CompletableFuture<>();
1892 <        g = new CompletableFuture<>();
1893 <        f.complete(3);
1894 <        g.completeExceptionally(new CFException());
1895 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1896 <        checkCompletedWithWrappedCFException(h);
1897 <
1898 <        f = new CompletableFuture<>();
1899 <        g = new CompletableFuture<>();
1900 <        f.completeExceptionally(new CFException());
1901 <        g.complete(3);
1902 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1903 <        checkCompletedWithWrappedCFException(h);
1904 <    }
1905 <
1906 <    /**
1907 <     * thenAcceptBothAsync result completes exceptionally if action does
1908 <     */
1909 <    public void testThenAcceptBothAsync3() {
1910 <        CompletableFuture<Integer> f, g;
1911 <        CompletableFuture<Void> h;
1912 <        FailingBiConsumer r;
1913 <
1914 <        f = new CompletableFuture<>();
1915 <        g = new CompletableFuture<>();
1916 <        h = f.thenAcceptBothAsync(g, r = new FailingBiConsumer());
1917 <        f.complete(3);
1918 <        checkIncomplete(h);
1919 <        g.complete(1);
1920 <        checkCompletedWithWrappedCFException(h);
1921 <
1922 <        f = new CompletableFuture<>();
1923 <        g = new CompletableFuture<>();
1924 <        f.complete(3);
1925 <        g.complete(1);
1926 <        h = f.thenAcceptBothAsync(g, r = new FailingBiConsumer());
1927 <        checkCompletedWithWrappedCFException(h);
1928 <    }
1929 <
1930 <    /**
1931 <     * thenAcceptBothAsync result completes exceptionally if either source cancelled
1932 <     */
1933 <    public void testThenAcceptBothAsync4() {
1934 <        CompletableFuture<Integer> f, g;
1935 <        CompletableFuture<Void> h;
1936 <        SubtractAction r;
2061 >        g.complete(v1);
2062  
2063 <        f = new CompletableFuture<>();
2064 <        g = new CompletableFuture<>();
2065 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
1941 <        assertTrue(f.cancel(true));
1942 <        checkIncomplete(h);
1943 <        g.complete(1);
2063 >        checkCancelled(f);
2064 >        assertEquals(0, r.invocationCount);
2065 >        checkCompletedNormally(g, v1);
2066          checkCompletedWithWrappedCancellationException(h);
2067 +    }}
2068  
2069 <        f = new CompletableFuture<>();
2070 <        g = new CompletableFuture<>();
2071 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
2072 <        assertTrue(g.cancel(true));
2073 <        checkIncomplete(h);
2074 <        f.complete(3);
2075 <        checkCompletedWithWrappedCancellationException(h);
2069 >    public void testAcceptEither_sourceCancelled2() {
2070 >        for (ExecutionMode m : ExecutionMode.values())
2071 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2072 >        for (Integer v1 : new Integer[] { 1, null })
2073 >    {
2074 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2075 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2076 >        final IncAction r = new IncAction();
2077 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2078  
2079 <        f = new CompletableFuture<>();
1955 <        g = new CompletableFuture<>();
1956 <        f.complete(3);
1957 <        assertTrue(g.cancel(true));
1958 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
2079 >        assertTrue(g.cancel(mayInterruptIfRunning));
2080          checkCompletedWithWrappedCancellationException(h);
2081 +        f.complete(v1);
2082  
2083 <        f = new CompletableFuture<>();
2084 <        g = new CompletableFuture<>();
2085 <        assertTrue(f.cancel(true));
1964 <        g.complete(3);
1965 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction());
2083 >        checkCancelled(g);
2084 >        assertEquals(0, r.invocationCount);
2085 >        checkCompletedNormally(f, v1);
2086          checkCompletedWithWrappedCancellationException(h);
2087 <    }
1968 <
1969 <    /**
1970 <     * applyToEitherAsync result completes normally after normal
1971 <     * completion of sources
1972 <     */
1973 <    public void testApplyToEitherAsync() {
1974 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1975 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1976 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
1977 <        f.complete(one);
1978 <        checkCompletedNormally(g, two);
1979 <
1980 <        f = new CompletableFuture<>();
1981 <        f.complete(one);
1982 <        f2 = new CompletableFuture<>();
1983 <        g = f.applyToEitherAsync(f2, inc);
1984 <        checkCompletedNormally(g, two);
1985 <    }
1986 <
1987 <    /**
1988 <     * applyToEitherAsync result completes exceptionally after exceptional
1989 <     * completion of source
1990 <     */
1991 <    public void testApplyToEitherAsync2() {
1992 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1993 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1994 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
1995 <        f.completeExceptionally(new CFException());
1996 <        checkCompletedWithWrappedCFException(g);
1997 <
1998 <        f = new CompletableFuture<>();
1999 <        f2 = new CompletableFuture<>();
2000 <        f2.completeExceptionally(new CFException());
2001 <        g = f.applyToEitherAsync(f2, inc);
2002 <        f.complete(one);
2003 <        checkCompletedWithWrappedCFException(g);
2004 <    }
2005 <
2006 <    /**
2007 <     * applyToEitherAsync result completes exceptionally if action does
2008 <     */
2009 <    public void testApplyToEitherAsync3() {
2010 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2011 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2012 <        FailingFunction r = new FailingFunction();
2013 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, r);
2014 <        f.complete(one);
2015 <        checkCompletedWithWrappedCFException(g);
2016 <    }
2017 <
2018 <    /**
2019 <     * applyToEitherAsync result completes exceptionally if either source cancelled
2020 <     */
2021 <    public void testApplyToEitherAsync4() {
2022 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2023 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2024 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2025 <        assertTrue(f.cancel(true));
2026 <        checkCompletedWithWrappedCancellationException(g);
2027 <
2028 <        f = new CompletableFuture<>();
2029 <        f2 = new CompletableFuture<>();
2030 <        assertTrue(f2.cancel(true));
2031 <        g = f.applyToEitherAsync(f2, inc);
2032 <        checkCompletedWithWrappedCancellationException(g);
2033 <    }
2087 >    }}
2088  
2089 <    /**
2090 <     * acceptEitherAsync result completes normally after normal
2091 <     * completion of sources
2092 <     */
2093 <    public void testAcceptEitherAsync() {
2094 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2095 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2096 <        IncAction r = new IncAction();
2043 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2044 <        f.complete(one);
2045 <        checkCompletedNormally(g, null);
2046 <        assertEquals(r.value, 2);
2047 <
2048 <        r = new IncAction();
2049 <        f = new CompletableFuture<>();
2050 <        f.complete(one);
2051 <        f2 = new CompletableFuture<>();
2052 <        g = f.acceptEitherAsync(f2, r);
2053 <        checkCompletedNormally(g, null);
2054 <        assertEquals(r.value, 2);
2055 <    }
2056 <
2057 <    /**
2058 <     * acceptEitherAsync result completes exceptionally after exceptional
2059 <     * completion of source
2060 <     */
2061 <    public void testAcceptEitherAsync2() {
2062 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2063 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2064 <        IncAction r = new IncAction();
2065 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2066 <        f.completeExceptionally(new CFException());
2067 <        checkCompletedWithWrappedCFException(g);
2068 <
2069 <        r = new IncAction();
2070 <        f = new CompletableFuture<>();
2071 <        f2 = new CompletableFuture<>();
2072 <        f2.completeExceptionally(new CFException());
2073 <        g = f.acceptEitherAsync(f2, r);
2074 <        f.complete(one);
2075 <        checkCompletedWithWrappedCFException(g);
2076 <    }
2077 <
2078 <    /**
2079 <     * acceptEitherAsync result completes exceptionally if action does
2080 <     */
2081 <    public void testAcceptEitherAsync3() {
2082 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2083 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2084 <        FailingConsumer r = new FailingConsumer();
2085 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2086 <        f.complete(one);
2087 <        checkCompletedWithWrappedCFException(g);
2088 <    }
2089 <
2090 <    /**
2091 <     * acceptEitherAsync result completes exceptionally if either
2092 <     * source cancelled
2093 <     */
2094 <    public void testAcceptEitherAsync4() {
2095 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2096 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2097 <        IncAction r = new IncAction();
2098 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2099 <        assertTrue(f.cancel(true));
2100 <        checkCompletedWithWrappedCancellationException(g);
2101 <
2102 <        r = new IncAction();
2103 <        f = new CompletableFuture<>();
2104 <        f2 = new CompletableFuture<>();
2105 <        assertTrue(f2.cancel(true));
2106 <        g = f.acceptEitherAsync(f2, r);
2107 <        checkCompletedWithWrappedCancellationException(g);
2108 <    }
2109 <
2110 <    /**
2111 <     * runAfterEitherAsync result completes normally after normal
2112 <     * completion of sources
2113 <     */
2114 <    public void testRunAfterEitherAsync() {
2115 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2116 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2117 <        Noop r = new Noop();
2118 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2119 <        f.complete(one);
2120 <        checkCompletedNormally(g, null);
2121 <        assertTrue(r.ran);
2122 <
2123 <        r = new Noop();
2124 <        f = new CompletableFuture<>();
2125 <        f.complete(one);
2126 <        f2 = new CompletableFuture<>();
2127 <        g = f.runAfterEitherAsync(f2, r);
2128 <        checkCompletedNormally(g, null);
2129 <        assertTrue(r.ran);
2130 <    }
2131 <
2132 <    /**
2133 <     * runAfterEitherAsync result completes exceptionally after exceptional
2134 <     * completion of source
2135 <     */
2136 <    public void testRunAfterEitherAsync2() {
2137 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2138 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2139 <        Noop r = new Noop();
2140 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2141 <        f.completeExceptionally(new CFException());
2142 <        checkCompletedWithWrappedCFException(g);
2143 <
2144 <        r = new Noop();
2145 <        f = new CompletableFuture<>();
2146 <        f2 = new CompletableFuture<>();
2147 <        f2.completeExceptionally(new CFException());
2148 <        g = f.runAfterEitherAsync(f2, r);
2149 <        f.complete(one);
2150 <        checkCompletedWithWrappedCFException(g);
2151 <    }
2152 <
2153 <    /**
2154 <     * runAfterEitherAsync result completes exceptionally if action does
2155 <     */
2156 <    public void testRunAfterEitherAsync3() {
2157 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2158 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2159 <        FailingNoop r = new FailingNoop();
2160 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2161 <        f.complete(one);
2162 <        checkCompletedWithWrappedCFException(g);
2163 <    }
2164 <
2165 <    /**
2166 <     * runAfterEitherAsync result completes exceptionally if either
2167 <     * source cancelled
2168 <     */
2169 <    public void testRunAfterEitherAsync4() {
2170 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2171 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2172 <        Noop r = new Noop();
2173 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2174 <        assertTrue(f.cancel(true));
2175 <        checkCompletedWithWrappedCancellationException(g);
2176 <
2177 <        r = new Noop();
2178 <        f = new CompletableFuture<>();
2179 <        f2 = new CompletableFuture<>();
2180 <        assertTrue(f2.cancel(true));
2181 <        g = f.runAfterEitherAsync(f2, r);
2182 <        checkCompletedWithWrappedCancellationException(g);
2183 <    }
2184 <
2185 <    /**
2186 <     * thenComposeAsync result completes normally after normal
2187 <     * completion of source
2188 <     */
2189 <    public void testThenComposeAsync() {
2190 <        CompletableFuture<Integer> f, g;
2191 <        CompletableFutureInc r;
2192 <
2193 <        f = new CompletableFuture<>();
2194 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2195 <        f.complete(one);
2196 <        checkCompletedNormally(g, two);
2197 <
2198 <        f = new CompletableFuture<>();
2199 <        f.complete(one);
2200 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2201 <        checkCompletedNormally(g, two);
2202 <    }
2203 <
2204 <    /**
2205 <     * thenComposeAsync result completes exceptionally after
2206 <     * exceptional completion of source
2207 <     */
2208 <    public void testThenComposeAsync2() {
2209 <        CompletableFuture<Integer> f, g;
2210 <        CompletableFutureInc r;
2211 <
2212 <        f = new CompletableFuture<>();
2213 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2214 <        f.completeExceptionally(new CFException());
2215 <        checkCompletedWithWrappedCFException(g);
2216 <        assertFalse(r.ran);
2217 <
2218 <        f = new CompletableFuture<>();
2219 <        f.completeExceptionally(new CFException());
2220 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2221 <        checkCompletedWithWrappedCFException(g);
2222 <        assertFalse(r.ran);
2223 <    }
2224 <
2225 <    /**
2226 <     * thenComposeAsync result completes exceptionally if action does
2227 <     */
2228 <    public void testThenComposeAsync3() {
2229 <        CompletableFuture<Integer> f, g;
2230 <        FailingCompletableFutureFunction r;
2231 <
2232 <        f = new CompletableFuture<>();
2233 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
2234 <        f.complete(one);
2235 <        checkCompletedWithWrappedCFException(g);
2236 <
2237 <        f = new CompletableFuture<>();
2238 <        f.complete(one);
2239 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
2240 <        checkCompletedWithWrappedCFException(g);
2241 <    }
2242 <
2243 <    /**
2244 <     * thenComposeAsync result completes exceptionally if source cancelled
2245 <     */
2246 <    public void testThenComposeAsync4() {
2247 <        CompletableFuture<Integer> f, g;
2248 <        CompletableFutureInc r;
2249 <
2250 <        f = new CompletableFuture<>();
2251 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2252 <        assertTrue(f.cancel(true));
2253 <        checkCompletedWithWrappedCancellationException(g);
2254 <
2255 <        f = new CompletableFuture<>();
2256 <        assertTrue(f.cancel(true));
2257 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2258 <        checkCompletedWithWrappedCancellationException(g);
2259 <    }
2260 <
2261 <    // async with explicit executors
2262 <
2263 <    /**
2264 <     * thenRunAsync result completes normally after normal completion of source
2265 <     */
2266 <    public void testThenRunAsyncE() {
2267 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2268 <        Noop r = new Noop();
2269 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2270 <        f.complete(null);
2271 <        checkCompletedNormally(g, null);
2089 >    public void testAcceptEither_sourceCancelled3() {
2090 >        for (ExecutionMode m : ExecutionMode.values())
2091 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2092 >        for (Integer v1 : new Integer[] { 1, null })
2093 >    {
2094 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2095 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2096 >        final IncAction r = new IncAction();
2097  
2098 <        // reordered version
2099 <        f = new CompletableFuture<>();
2100 <        f.complete(null);
2276 <        r = new Noop();
2277 <        g = f.thenRunAsync(r, new ThreadExecutor());
2278 <        checkCompletedNormally(g, null);
2279 <    }
2098 >        assertTrue(g.cancel(mayInterruptIfRunning));
2099 >        f.complete(v1);
2100 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2101  
2102 <    /**
2103 <     * thenRunAsync result completes exceptionally after exceptional
2283 <     * completion of source
2284 <     */
2285 <    public void testThenRunAsync2E() {
2286 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2287 <        Noop r = new Noop();
2288 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2289 <        f.completeExceptionally(new CFException());
2102 >        // unspecified behavior
2103 >        Integer v;
2104          try {
2105 <            g.join();
2106 <            shouldThrow();
2107 <        } catch (CompletionException success) {}
2108 <        checkCompletedWithWrappedCFException(g);
2109 <    }
2105 >            assertNull(h.join());
2106 >            assertEquals(1, r.invocationCount);
2107 >            assertEquals(inc(v1), r.value);
2108 >        } catch (CompletionException ok) {
2109 >            checkCompletedWithWrappedCancellationException(h);
2110 >            assertEquals(0, r.invocationCount);
2111 >        }
2112  
2113 <    /**
2114 <     * thenRunAsync result completes exceptionally if action does
2115 <     */
2300 <    public void testThenRunAsync3E() {
2301 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2302 <        FailingNoop r = new FailingNoop();
2303 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2304 <        f.complete(null);
2305 <        checkCompletedWithWrappedCFException(g);
2306 <    }
2113 >        checkCancelled(g);
2114 >        checkCompletedNormally(f, v1);
2115 >    }}
2116  
2117 <    /**
2118 <     * thenRunAsync result completes exceptionally if source cancelled
2119 <     */
2120 <    public void testThenRunAsync4E() {
2121 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2122 <        Noop r = new Noop();
2123 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2124 <        assertTrue(f.cancel(true));
2316 <        checkCompletedWithWrappedCancellationException(g);
2317 <    }
2117 >    public void testAcceptEither_sourceCancelled4() {
2118 >        for (ExecutionMode m : ExecutionMode.values())
2119 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2120 >        for (Integer v1 : new Integer[] { 1, null })
2121 >    {
2122 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2123 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2124 >        final IncAction r = new IncAction();
2125  
2126 <    /**
2127 <     * thenApplyAsync result completes normally after normal completion of source
2128 <     */
2322 <    public void testThenApplyAsyncE() {
2323 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2324 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
2325 <        f.complete(one);
2326 <        checkCompletedNormally(g, two);
2327 <    }
2126 >        assertTrue(f.cancel(mayInterruptIfRunning));
2127 >        g.complete(v1);
2128 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2129  
2130 <    /**
2131 <     * thenApplyAsync result completes exceptionally after exceptional
2132 <     * completion of source
2133 <     */
2134 <    public void testThenApplyAsync2E() {
2135 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2136 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
2137 <        f.completeExceptionally(new CFException());
2138 <        checkCompletedWithWrappedCFException(g);
2139 <    }
2130 >        // unspecified behavior
2131 >        Integer v;
2132 >        try {
2133 >            assertNull(h.join());
2134 >            assertEquals(1, r.invocationCount);
2135 >            assertEquals(inc(v1), r.value);
2136 >        } catch (CompletionException ok) {
2137 >            checkCompletedWithWrappedCancellationException(h);
2138 >            assertEquals(0, r.invocationCount);
2139 >        }
2140  
2141 <    /**
2142 <     * thenApplyAsync result completes exceptionally if action does
2143 <     */
2343 <    public void testThenApplyAsync3E() {
2344 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2345 <        FailingFunction r = new FailingFunction();
2346 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
2347 <        f.complete(null);
2348 <        checkCompletedWithWrappedCFException(g);
2349 <    }
2141 >        checkCancelled(f);
2142 >        checkCompletedNormally(g, v1);
2143 >    }}
2144  
2145      /**
2146 <     * thenApplyAsync result completes exceptionally if source cancelled
2146 >     * runAfterEither result completes normally after normal completion
2147 >     * of either source
2148       */
2149 <    public void testThenApplyAsync4E() {
2150 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2151 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
2152 <        assertTrue(f.cancel(true));
2153 <        checkCompletedWithWrappedCancellationException(g);
2154 <    }
2149 >    public void testRunAfterEither_normalCompletion1() {
2150 >        for (ExecutionMode m : ExecutionMode.values())
2151 >        for (Integer v1 : new Integer[] { 1, null })
2152 >        for (Integer v2 : new Integer[] { 2, null })
2153 >    {
2154 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2155 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2156 >        final Noop r = new Noop();
2157 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2158  
2159 <    /**
2160 <     * thenAcceptAsync result completes normally after normal
2161 <     * completion of source
2162 <     */
2365 <    public void testThenAcceptAsyncE() {
2366 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2367 <        IncAction r = new IncAction();
2368 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2369 <        f.complete(one);
2370 <        checkCompletedNormally(g, null);
2371 <        assertEquals(r.value, 2);
2372 <    }
2159 >        f.complete(v1);
2160 >        checkCompletedNormally(h, null);
2161 >        assertEquals(1, r.invocationCount);
2162 >        g.complete(v2);
2163  
2164 <    /**
2165 <     * thenAcceptAsync result completes exceptionally after exceptional
2166 <     * completion of source
2167 <     */
2168 <    public void testThenAcceptAsync2E() {
2379 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2380 <        IncAction r = new IncAction();
2381 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2382 <        f.completeExceptionally(new CFException());
2383 <        checkCompletedWithWrappedCFException(g);
2384 <    }
2164 >        checkCompletedNormally(f, v1);
2165 >        checkCompletedNormally(g, v2);
2166 >        checkCompletedNormally(h, null);
2167 >        assertEquals(1, r.invocationCount);
2168 >    }}
2169  
2170 <    /**
2171 <     * thenAcceptAsync result completes exceptionally if action does
2172 <     */
2173 <    public void testThenAcceptAsync3E() {
2174 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2175 <        FailingConsumer r = new FailingConsumer();
2176 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2177 <        f.complete(null);
2178 <        checkCompletedWithWrappedCFException(g);
2395 <    }
2170 >    public void testRunAfterEither_normalCompletion2() {
2171 >        for (ExecutionMode m : ExecutionMode.values())
2172 >        for (Integer v1 : new Integer[] { 1, null })
2173 >        for (Integer v2 : new Integer[] { 2, null })
2174 >    {
2175 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2176 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2177 >        final Noop r = new Noop();
2178 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2179  
2180 <    /**
2181 <     * thenAcceptAsync result completes exceptionally if source cancelled
2182 <     */
2183 <    public void testThenAcceptAsync4E() {
2401 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2402 <        IncAction r = new IncAction();
2403 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2404 <        assertTrue(f.cancel(true));
2405 <        checkCompletedWithWrappedCancellationException(g);
2406 <    }
2180 >        g.complete(v2);
2181 >        checkCompletedNormally(h, null);
2182 >        assertEquals(1, r.invocationCount);
2183 >        f.complete(v1);
2184  
2185 <    /**
2186 <     * thenCombineAsync result completes normally after normal
2187 <     * completion of sources
2188 <     */
2189 <    public void testThenCombineAsyncE() {
2413 <        CompletableFuture<Integer> f, g, h;
2414 <        ThreadExecutor e = new ThreadExecutor();
2415 <        int count = 0;
2185 >        checkCompletedNormally(f, v1);
2186 >        checkCompletedNormally(g, v2);
2187 >        checkCompletedNormally(h, null);
2188 >        assertEquals(1, r.invocationCount);
2189 >        }}
2190  
2191 <        f = new CompletableFuture<>();
2192 <        g = new CompletableFuture<>();
2193 <        h = f.thenCombineAsync(g, subtract, e);
2194 <        f.complete(3);
2195 <        checkIncomplete(h);
2196 <        g.complete(1);
2197 <        checkCompletedNormally(h, 2);
2198 <        assertEquals(++count, e.count.get());
2191 >    public void testRunAfterEither_normalCompletion3() {
2192 >        for (ExecutionMode m : ExecutionMode.values())
2193 >        for (Integer v1 : new Integer[] { 1, null })
2194 >        for (Integer v2 : new Integer[] { 2, null })
2195 >    {
2196 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2197 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2198 >        final Noop r = new Noop();
2199  
2200 <        f = new CompletableFuture<>();
2201 <        g = new CompletableFuture<>();
2202 <        h = f.thenCombineAsync(g, subtract, e);
2429 <        g.complete(1);
2430 <        checkIncomplete(h);
2431 <        f.complete(3);
2432 <        checkCompletedNormally(h, 2);
2433 <        assertEquals(++count, e.count.get());
2200 >        f.complete(v1);
2201 >        g.complete(v2);
2202 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2203  
2204 <        f = new CompletableFuture<>();
2205 <        g = new CompletableFuture<>();
2206 <        g.complete(1);
2207 <        f.complete(3);
2208 <        h = f.thenCombineAsync(g, subtract, e);
2440 <        checkCompletedNormally(h, 2);
2441 <        assertEquals(++count, e.count.get());
2442 <    }
2204 >        checkCompletedNormally(h, null);
2205 >        checkCompletedNormally(f, v1);
2206 >        checkCompletedNormally(g, v2);
2207 >        assertEquals(1, r.invocationCount);
2208 >    }}
2209  
2210      /**
2211 <     * thenCombineAsync result completes exceptionally after exceptional
2211 >     * runAfterEither result completes exceptionally after exceptional
2212       * completion of either source
2213       */
2214 <    public void testThenCombineAsync2E() {
2215 <        CompletableFuture<Integer> f, g, h;
2216 <        ThreadExecutor e = new ThreadExecutor();
2217 <        int count = 0;
2218 <
2219 <        f = new CompletableFuture<>();
2220 <        g = new CompletableFuture<>();
2221 <        h = f.thenCombineAsync(g, subtract, e);
2222 <        f.completeExceptionally(new CFException());
2457 <        checkIncomplete(h);
2458 <        g.complete(1);
2459 <        checkCompletedWithWrappedCFException(h);
2460 <
2461 <        f = new CompletableFuture<>();
2462 <        g = new CompletableFuture<>();
2463 <        h = f.thenCombineAsync(g, subtract, e);
2464 <        g.completeExceptionally(new CFException());
2465 <        checkIncomplete(h);
2466 <        f.complete(3);
2467 <        checkCompletedWithWrappedCFException(h);
2468 <
2469 <        f = new CompletableFuture<>();
2470 <        g = new CompletableFuture<>();
2471 <        g.completeExceptionally(new CFException());
2472 <        h = f.thenCombineAsync(g, subtract, e);
2473 <        checkIncomplete(h);
2474 <        f.complete(3);
2475 <        checkCompletedWithWrappedCFException(h);
2214 >    public void testRunAfterEither_exceptionalCompletion1() {
2215 >        for (ExecutionMode m : ExecutionMode.values())
2216 >        for (Integer v1 : new Integer[] { 1, null })
2217 >    {
2218 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2219 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2220 >        final Noop r = new Noop();
2221 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2222 >        final CFException ex = new CFException();
2223  
2224 <        assertEquals(0, e.count.get());
2225 <    }
2224 >        f.completeExceptionally(ex);
2225 >        checkCompletedWithWrappedCFException(h, ex);
2226 >        g.complete(v1);
2227  
2228 <    /**
2229 <     * thenCombineAsync result completes exceptionally if action does
2230 <     */
2231 <    public void testThenCombineAsync3E() {
2232 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2485 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2486 <        FailingBiFunction r = new FailingBiFunction();
2487 <        CompletableFuture<Integer> g = f.thenCombineAsync(f2, r, new ThreadExecutor());
2488 <        f.complete(one);
2489 <        checkIncomplete(g);
2490 <        assertFalse(r.ran);
2491 <        f2.complete(two);
2492 <        checkCompletedWithWrappedCFException(g);
2493 <        assertTrue(r.ran);
2494 <    }
2228 >        assertEquals(0, r.invocationCount);
2229 >        checkCompletedNormally(g, v1);
2230 >        checkCompletedWithWrappedCFException(f, ex);
2231 >        checkCompletedWithWrappedCFException(h, ex);
2232 >    }}
2233  
2234 <    /**
2235 <     * thenCombineAsync result completes exceptionally if either source cancelled
2236 <     */
2237 <    public void testThenCombineAsync4E() {
2238 <        CompletableFuture<Integer> f, g, h;
2239 <        ThreadExecutor e = new ThreadExecutor();
2234 >    public void testRunAfterEither_exceptionalCompletion2() {
2235 >        for (ExecutionMode m : ExecutionMode.values())
2236 >        for (Integer v1 : new Integer[] { 1, null })
2237 >    {
2238 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2239 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2240 >        final Noop r = new Noop();
2241 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2242 >        final CFException ex = new CFException();
2243  
2244 <        f = new CompletableFuture<>();
2245 <        g = new CompletableFuture<>();
2246 <        h = f.thenCombineAsync(g, subtract, e);
2506 <        assertTrue(f.cancel(true));
2507 <        checkIncomplete(h);
2508 <        g.complete(1);
2509 <        checkCompletedWithWrappedCancellationException(h);
2244 >        g.completeExceptionally(ex);
2245 >        checkCompletedWithWrappedCFException(h, ex);
2246 >        f.complete(v1);
2247  
2248 <        f = new CompletableFuture<>();
2249 <        g = new CompletableFuture<>();
2250 <        h = f.thenCombineAsync(g, subtract, e);
2251 <        assertTrue(g.cancel(true));
2252 <        checkIncomplete(h);
2516 <        f.complete(3);
2517 <        checkCompletedWithWrappedCancellationException(h);
2248 >        assertEquals(0, r.invocationCount);
2249 >        checkCompletedNormally(f, v1);
2250 >        checkCompletedWithWrappedCFException(g, ex);
2251 >        checkCompletedWithWrappedCFException(h, ex);
2252 >    }}
2253  
2254 <        f = new CompletableFuture<>();
2255 <        g = new CompletableFuture<>();
2256 <        assertTrue(g.cancel(true));
2257 <        h = f.thenCombineAsync(g, subtract, e);
2258 <        checkIncomplete(h);
2259 <        f.complete(3);
2260 <        checkCompletedWithWrappedCancellationException(h);
2254 >    public void testRunAfterEither_exceptionalCompletion3() {
2255 >        for (ExecutionMode m : ExecutionMode.values())
2256 >        for (Integer v1 : new Integer[] { 1, null })
2257 >    {
2258 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2259 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2260 >        final Noop r = new Noop();
2261 >        final CFException ex = new CFException();
2262  
2263 <        f = new CompletableFuture<>();
2264 <        g = new CompletableFuture<>();
2265 <        assertTrue(f.cancel(true));
2530 <        assertTrue(g.cancel(true));
2531 <        h = f.thenCombineAsync(g, subtract, e);
2532 <        checkCompletedWithWrappedCancellationException(h);
2263 >        g.completeExceptionally(ex);
2264 >        f.complete(v1);
2265 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2266  
2267 <        assertEquals(0, e.count.get());
2268 <    }
2267 >        // unspecified behavior
2268 >        Integer v;
2269 >        try {
2270 >            assertNull(h.join());
2271 >            assertEquals(1, r.invocationCount);
2272 >        } catch (CompletionException ok) {
2273 >            checkCompletedWithWrappedCFException(h, ex);
2274 >            assertEquals(0, r.invocationCount);
2275 >        }
2276  
2277 <    /**
2278 <     * thenAcceptBothAsync result completes normally after normal
2279 <     * completion of sources
2540 <     */
2541 <    public void testThenAcceptBothAsyncE() {
2542 <        CompletableFuture<Integer> f, g;
2543 <        CompletableFuture<Void> h;
2544 <        SubtractAction r;
2545 <        ThreadExecutor e = new ThreadExecutor();
2277 >        checkCompletedWithWrappedCFException(g, ex);
2278 >        checkCompletedNormally(f, v1);
2279 >    }}
2280  
2281 <        f = new CompletableFuture<>();
2282 <        g = new CompletableFuture<>();
2283 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2284 <        f.complete(3);
2285 <        checkIncomplete(h);
2286 <        g.complete(1);
2287 <        checkCompletedNormally(h, null);
2288 <        assertEquals(r.value, 2);
2281 >    public void testRunAfterEither_exceptionalCompletion4() {
2282 >        for (ExecutionMode m : ExecutionMode.values())
2283 >        for (Integer v1 : new Integer[] { 1, null })
2284 >    {
2285 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2286 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2287 >        final Noop r = new Noop();
2288 >        final CFException ex = new CFException();
2289  
2290 <        f = new CompletableFuture<>();
2291 <        g = new CompletableFuture<>();
2292 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2559 <        g.complete(1);
2560 <        checkIncomplete(h);
2561 <        f.complete(3);
2562 <        checkCompletedNormally(h, null);
2563 <        assertEquals(r.value, 2);
2290 >        f.completeExceptionally(ex);
2291 >        g.complete(v1);
2292 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2293  
2294 <        f = new CompletableFuture<>();
2295 <        g = new CompletableFuture<>();
2296 <        g.complete(1);
2297 <        f.complete(3);
2298 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2299 <        checkCompletedNormally(h, null);
2300 <        assertEquals(r.value, 2);
2294 >        // unspecified behavior
2295 >        Integer v;
2296 >        try {
2297 >            assertNull(h.join());
2298 >            assertEquals(1, r.invocationCount);
2299 >        } catch (CompletionException ok) {
2300 >            checkCompletedWithWrappedCFException(h, ex);
2301 >            assertEquals(0, r.invocationCount);
2302 >        }
2303  
2304 <        assertEquals(3, e.count.get());
2305 <    }
2304 >        checkCompletedWithWrappedCFException(f, ex);
2305 >        checkCompletedNormally(g, v1);
2306 >    }}
2307  
2308      /**
2309 <     * thenAcceptBothAsync result completes exceptionally after exceptional
2578 <     * completion of source
2309 >     * runAfterEither result completes exceptionally if action does
2310       */
2311 <    public void testThenAcceptBothAsync2E() {
2312 <        CompletableFuture<Integer> f, g;
2313 <        CompletableFuture<Void> h;
2314 <        SubtractAction r;
2315 <        ThreadExecutor e = new ThreadExecutor();
2316 <
2317 <        f = new CompletableFuture<>();
2318 <        g = new CompletableFuture<>();
2319 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2589 <        f.completeExceptionally(new CFException());
2590 <        checkIncomplete(h);
2591 <        g.complete(1);
2592 <        checkCompletedWithWrappedCFException(h);
2593 <
2594 <        f = new CompletableFuture<>();
2595 <        g = new CompletableFuture<>();
2596 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2597 <        g.completeExceptionally(new CFException());
2598 <        checkIncomplete(h);
2599 <        f.complete(3);
2600 <        checkCompletedWithWrappedCFException(h);
2601 <
2602 <        f = new CompletableFuture<>();
2603 <        g = new CompletableFuture<>();
2604 <        f.complete(3);
2605 <        g.completeExceptionally(new CFException());
2606 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2607 <        checkCompletedWithWrappedCFException(h);
2311 >    public void testRunAfterEither_actionFailed1() {
2312 >        for (ExecutionMode m : ExecutionMode.values())
2313 >        for (Integer v1 : new Integer[] { 1, null })
2314 >        for (Integer v2 : new Integer[] { 2, null })
2315 >    {
2316 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2317 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2318 >        final FailingRunnable r = new FailingRunnable();
2319 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2320  
2321 <        f = new CompletableFuture<>();
2610 <        g = new CompletableFuture<>();
2611 <        f.completeExceptionally(new CFException());
2612 <        g.complete(3);
2613 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2321 >        f.complete(v1);
2322          checkCompletedWithWrappedCFException(h);
2323 +        g.complete(v2);
2324 +        checkCompletedNormally(f, v1);
2325 +        checkCompletedNormally(g, v2);
2326 +    }}
2327  
2328 <        assertEquals(0, e.count.get());
2329 <    }
2330 <
2331 <    /**
2332 <     * thenAcceptBothAsync result completes exceptionally if action does
2333 <     */
2334 <    public void testThenAcceptBothAsync3E() {
2335 <        CompletableFuture<Integer> f, g;
2336 <        CompletableFuture<Void> h;
2625 <        FailingBiConsumer r;
2626 <        ThreadExecutor e = new ThreadExecutor();
2627 <
2628 <        f = new CompletableFuture<>();
2629 <        g = new CompletableFuture<>();
2630 <        h = f.thenAcceptBothAsync(g, r = new FailingBiConsumer(), e);
2631 <        f.complete(3);
2632 <        checkIncomplete(h);
2633 <        g.complete(1);
2634 <        checkCompletedWithWrappedCFException(h);
2328 >    public void testRunAfterEither_actionFailed2() {
2329 >        for (ExecutionMode m : ExecutionMode.values())
2330 >        for (Integer v1 : new Integer[] { 1, null })
2331 >        for (Integer v2 : new Integer[] { 2, null })
2332 >    {
2333 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2334 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2335 >        final FailingRunnable r = new FailingRunnable();
2336 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2337  
2338 <        f = new CompletableFuture<>();
2637 <        g = new CompletableFuture<>();
2638 <        f.complete(3);
2639 <        g.complete(1);
2640 <        h = f.thenAcceptBothAsync(g, r = new FailingBiConsumer(), e);
2338 >        g.complete(v2);
2339          checkCompletedWithWrappedCFException(h);
2340 <
2341 <        assertEquals(2, e.count.get());
2342 <    }
2340 >        f.complete(v1);
2341 >        checkCompletedNormally(f, v1);
2342 >        checkCompletedNormally(g, v2);
2343 >    }}
2344  
2345      /**
2346 <     * thenAcceptBothAsync result completes exceptionally if either source cancelled
2346 >     * runAfterEither result completes exceptionally if either source cancelled
2347       */
2348 <    public void testThenAcceptBothAsync4E() {
2349 <        CompletableFuture<Integer> f, g;
2350 <        CompletableFuture<Void> h;
2351 <        SubtractAction r;
2352 <        ThreadExecutor e = new ThreadExecutor();
2348 >    public void testRunAfterEither_sourceCancelled1() {
2349 >        for (ExecutionMode m : ExecutionMode.values())
2350 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2351 >        for (Integer v1 : new Integer[] { 1, null })
2352 >    {
2353 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2354 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2355 >        final Noop r = new Noop();
2356 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2357  
2358 <        f = new CompletableFuture<>();
2656 <        g = new CompletableFuture<>();
2657 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2658 <        assertTrue(f.cancel(true));
2659 <        checkIncomplete(h);
2660 <        g.complete(1);
2358 >        assertTrue(f.cancel(mayInterruptIfRunning));
2359          checkCompletedWithWrappedCancellationException(h);
2360 +        g.complete(v1);
2361  
2362 <        f = new CompletableFuture<>();
2363 <        g = new CompletableFuture<>();
2364 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2666 <        assertTrue(g.cancel(true));
2667 <        checkIncomplete(h);
2668 <        f.complete(3);
2362 >        checkCancelled(f);
2363 >        assertEquals(0, r.invocationCount);
2364 >        checkCompletedNormally(g, v1);
2365          checkCompletedWithWrappedCancellationException(h);
2366 +    }}
2367  
2368 <        f = new CompletableFuture<>();
2369 <        g = new CompletableFuture<>();
2370 <        f.complete(3);
2371 <        assertTrue(g.cancel(true));
2372 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2373 <        checkCompletedWithWrappedCancellationException(h);
2368 >    public void testRunAfterEither_sourceCancelled2() {
2369 >        for (ExecutionMode m : ExecutionMode.values())
2370 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2371 >        for (Integer v1 : new Integer[] { 1, null })
2372 >    {
2373 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2374 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2375 >        final Noop r = new Noop();
2376 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2377  
2378 <        f = new CompletableFuture<>();
2679 <        g = new CompletableFuture<>();
2680 <        assertTrue(f.cancel(true));
2681 <        g.complete(3);
2682 <        h = f.thenAcceptBothAsync(g, r = new SubtractAction(), e);
2378 >        assertTrue(g.cancel(mayInterruptIfRunning));
2379          checkCompletedWithWrappedCancellationException(h);
2380 +        f.complete(v1);
2381  
2382 <        assertEquals(0, e.count.get());
2383 <    }
2384 <
2385 <    /**
2386 <     * applyToEitherAsync result completes normally after normal
2690 <     * completion of sources
2691 <     */
2692 <    public void testApplyToEitherAsyncE() {
2693 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2694 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2695 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2696 <        f.complete(one);
2697 <        checkCompletedNormally(g, two);
2698 <
2699 <        f = new CompletableFuture<>();
2700 <        f.complete(one);
2701 <        f2 = new CompletableFuture<>();
2702 <        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2703 <        checkCompletedNormally(g, two);
2704 <    }
2705 <
2706 <    /**
2707 <     * applyToEitherAsync result completes exceptionally after exceptional
2708 <     * completion of source
2709 <     */
2710 <    public void testApplyToEitherAsync2E() {
2711 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2712 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2713 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2714 <        f.completeExceptionally(new CFException());
2715 <        checkCompletedWithWrappedCFException(g);
2716 <
2717 <        f = new CompletableFuture<>();
2718 <        f2 = new CompletableFuture<>();
2719 <        f2.completeExceptionally(new CFException());
2720 <        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2721 <        f.complete(one);
2722 <        checkCompletedWithWrappedCFException(g);
2723 <    }
2724 <
2725 <    /**
2726 <     * applyToEitherAsync result completes exceptionally if action does
2727 <     */
2728 <    public void testApplyToEitherAsync3E() {
2729 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2730 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2731 <        FailingFunction r = new FailingFunction();
2732 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, r, new ThreadExecutor());
2733 <        f.complete(one);
2734 <        checkCompletedWithWrappedCFException(g);
2735 <    }
2736 <
2737 <    /**
2738 <     * applyToEitherAsync result completes exceptionally if either source cancelled
2739 <     */
2740 <    public void testApplyToEitherAsync4E() {
2741 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2742 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2743 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2744 <        assertTrue(f.cancel(true));
2745 <        checkCompletedWithWrappedCancellationException(g);
2382 >        checkCancelled(g);
2383 >        assertEquals(0, r.invocationCount);
2384 >        checkCompletedNormally(f, v1);
2385 >        checkCompletedWithWrappedCancellationException(h);
2386 >    }}
2387  
2388 <        f = new CompletableFuture<>();
2389 <        f2 = new CompletableFuture<>();
2390 <        assertTrue(f2.cancel(true));
2391 <        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2392 <        checkCompletedWithWrappedCancellationException(g);
2393 <    }
2388 >    public void testRunAfterEither_sourceCancelled3() {
2389 >        for (ExecutionMode m : ExecutionMode.values())
2390 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2391 >        for (Integer v1 : new Integer[] { 1, null })
2392 >    {
2393 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2394 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2395 >        final Noop r = new Noop();
2396  
2397 <    /**
2398 <     * acceptEitherAsync result completes normally after normal
2399 <     * completion of sources
2757 <     */
2758 <    public void testAcceptEitherAsyncE() {
2759 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2760 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2761 <        IncAction r = new IncAction();
2762 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2763 <        f.complete(one);
2764 <        checkCompletedNormally(g, null);
2765 <        assertEquals(r.value, 2);
2397 >        assertTrue(g.cancel(mayInterruptIfRunning));
2398 >        f.complete(v1);
2399 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2400  
2401 <        r = new IncAction();
2402 <        f = new CompletableFuture<>();
2403 <        f.complete(one);
2404 <        f2 = new CompletableFuture<>();
2405 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2406 <        checkCompletedNormally(g, null);
2407 <        assertEquals(r.value, 2);
2408 <    }
2401 >        // unspecified behavior
2402 >        Integer v;
2403 >        try {
2404 >            assertNull(h.join());
2405 >            assertEquals(1, r.invocationCount);
2406 >        } catch (CompletionException ok) {
2407 >            checkCompletedWithWrappedCancellationException(h);
2408 >            assertEquals(0, r.invocationCount);
2409 >        }
2410  
2411 <    /**
2412 <     * acceptEitherAsync result completes exceptionally after exceptional
2413 <     * completion of source
2779 <     */
2780 <    public void testAcceptEitherAsync2E() {
2781 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2782 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2783 <        IncAction r = new IncAction();
2784 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2785 <        f.completeExceptionally(new CFException());
2786 <        checkCompletedWithWrappedCFException(g);
2411 >        checkCancelled(g);
2412 >        checkCompletedNormally(f, v1);
2413 >    }}
2414  
2415 <        r = new IncAction();
2416 <        f = new CompletableFuture<>();
2417 <        f2 = new CompletableFuture<>();
2418 <        f2.completeExceptionally(new CFException());
2419 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2420 <        f.complete(one);
2421 <        checkCompletedWithWrappedCFException(g);
2422 <    }
2415 >    public void testRunAfterEither_sourceCancelled4() {
2416 >        for (ExecutionMode m : ExecutionMode.values())
2417 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2418 >        for (Integer v1 : new Integer[] { 1, null })
2419 >    {
2420 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2421 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2422 >        final Noop r = new Noop();
2423  
2424 <    /**
2425 <     * acceptEitherAsync result completes exceptionally if action does
2426 <     */
2800 <    public void testAcceptEitherAsync3E() {
2801 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2802 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2803 <        FailingConsumer r = new FailingConsumer();
2804 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2805 <        f.complete(one);
2806 <        checkCompletedWithWrappedCFException(g);
2807 <    }
2424 >        assertTrue(f.cancel(mayInterruptIfRunning));
2425 >        g.complete(v1);
2426 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2427  
2428 <    /**
2429 <     * acceptEitherAsync result completes exceptionally if either
2430 <     * source cancelled
2431 <     */
2432 <    public void testAcceptEitherAsync4E() {
2433 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2434 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2435 <        IncAction r = new IncAction();
2436 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2818 <        assertTrue(f.cancel(true));
2819 <        checkCompletedWithWrappedCancellationException(g);
2428 >        // unspecified behavior
2429 >        Integer v;
2430 >        try {
2431 >            assertNull(h.join());
2432 >            assertEquals(1, r.invocationCount);
2433 >        } catch (CompletionException ok) {
2434 >            checkCompletedWithWrappedCancellationException(h);
2435 >            assertEquals(0, r.invocationCount);
2436 >        }
2437  
2438 <        r = new IncAction();
2439 <        f = new CompletableFuture<>();
2440 <        f2 = new CompletableFuture<>();
2824 <        assertTrue(f2.cancel(true));
2825 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2826 <        checkCompletedWithWrappedCancellationException(g);
2827 <    }
2438 >        checkCancelled(f);
2439 >        checkCompletedNormally(g, v1);
2440 >    }}
2441  
2442      /**
2443 <     * runAfterEitherAsync result completes normally after normal
2831 <     * completion of sources
2443 >     * thenCompose result completes normally after normal completion of source
2444       */
2445 <    public void testRunAfterEitherAsyncE() {
2446 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2447 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2448 <        Noop r = new Noop();
2449 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2450 <        f.complete(one);
2451 <        checkCompletedNormally(g, null);
2452 <        assertTrue(r.ran);
2445 >    public void testThenCompose_normalCompletion() {
2446 >        for (ExecutionMode m : ExecutionMode.values())
2447 >        for (boolean createIncomplete : new boolean[] { true, false })
2448 >        for (Integer v1 : new Integer[] { 1, null })
2449 >    {
2450 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2451 >        final CompletableFutureInc r = new CompletableFutureInc();
2452 >        if (!createIncomplete) f.complete(v1);
2453 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2454 >        if (createIncomplete) f.complete(v1);
2455  
2456 <        r = new Noop();
2457 <        f = new CompletableFuture<>();
2458 <        f.complete(one);
2459 <        f2 = new CompletableFuture<>();
2846 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2847 <        checkCompletedNormally(g, null);
2848 <        assertTrue(r.ran);
2849 <    }
2456 >        checkCompletedNormally(g, inc(v1));
2457 >        checkCompletedNormally(f, v1);
2458 >        assertEquals(1, r.invocationCount);
2459 >    }}
2460  
2461      /**
2462 <     * runAfterEitherAsync result completes exceptionally after exceptional
2462 >     * thenCompose result completes exceptionally after exceptional
2463       * completion of source
2464       */
2465 <    public void testRunAfterEitherAsync2E() {
2466 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2467 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2468 <        Noop r = new Noop();
2469 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2470 <        f.completeExceptionally(new CFException());
2471 <        checkCompletedWithWrappedCFException(g);
2472 <
2473 <        r = new Noop();
2474 <        f = new CompletableFuture<>();
2865 <        f2 = new CompletableFuture<>();
2866 <        f2.completeExceptionally(new CFException());
2867 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2868 <        f.complete(one);
2869 <        checkCompletedWithWrappedCFException(g);
2870 <    }
2871 <
2872 <    /**
2873 <     * runAfterEitherAsync result completes exceptionally if action does
2874 <     */
2875 <    public void testRunAfterEitherAsync3E() {
2876 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2877 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2878 <        FailingNoop r = new FailingNoop();
2879 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2880 <        f.complete(one);
2881 <        checkCompletedWithWrappedCFException(g);
2882 <    }
2883 <
2884 <    /**
2885 <     * runAfterEitherAsync result completes exceptionally if either
2886 <     * source cancelled
2887 <     */
2888 <    public void testRunAfterEitherAsync4E() {
2889 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2890 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2891 <        Noop r = new Noop();
2892 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2893 <        assertTrue(f.cancel(true));
2894 <        checkCompletedWithWrappedCancellationException(g);
2465 >    public void testThenCompose_exceptionalCompletion() {
2466 >        for (ExecutionMode m : ExecutionMode.values())
2467 >        for (boolean createIncomplete : new boolean[] { true, false })
2468 >    {
2469 >        final CFException ex = new CFException();
2470 >        final CompletableFutureInc r = new CompletableFutureInc();
2471 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2472 >        if (!createIncomplete) f.completeExceptionally(ex);
2473 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2474 >        if (createIncomplete) f.completeExceptionally(ex);
2475  
2476 <        r = new Noop();
2477 <        f = new CompletableFuture<>();
2478 <        f2 = new CompletableFuture<>();
2479 <        assertTrue(f2.cancel(true));
2900 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2901 <        checkCompletedWithWrappedCancellationException(g);
2902 <    }
2476 >        checkCompletedWithWrappedCFException(g, ex);
2477 >        checkCompletedWithWrappedCFException(f, ex);
2478 >        assertEquals(0, r.invocationCount);
2479 >    }}
2480  
2481      /**
2482 <     * thenComposeAsync result completes normally after normal
2906 <     * completion of source
2482 >     * thenCompose result completes exceptionally if action does
2483       */
2484 <    public void testThenComposeAsyncE() {
2485 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2486 <        CompletableFutureInc r = new CompletableFutureInc();
2487 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2488 <        f.complete(one);
2489 <        checkCompletedNormally(g, two);
2490 <    }
2484 >    public void testThenCompose_actionFailed() {
2485 >        for (ExecutionMode m : ExecutionMode.values())
2486 >        for (boolean createIncomplete : new boolean[] { true, false })
2487 >        for (Integer v1 : new Integer[] { 1, null })
2488 >    {
2489 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2490 >        final FailingCompletableFutureFunction r
2491 >            = new FailingCompletableFutureFunction();
2492 >        if (!createIncomplete) f.complete(v1);
2493 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2494 >        if (createIncomplete) f.complete(v1);
2495  
2916    /**
2917     * thenComposeAsync result completes exceptionally after
2918     * exceptional completion of source
2919     */
2920    public void testThenComposeAsync2E() {
2921        CompletableFuture<Integer> f = new CompletableFuture<>();
2922        CompletableFutureInc r = new CompletableFutureInc();
2923        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2924        f.completeExceptionally(new CFException());
2496          checkCompletedWithWrappedCFException(g);
2497 <    }
2497 >        checkCompletedNormally(f, v1);
2498 >    }}
2499  
2500      /**
2501 <     * thenComposeAsync result completes exceptionally if action does
2501 >     * thenCompose result completes exceptionally if source cancelled
2502       */
2503 <    public void testThenComposeAsync3E() {
2504 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2505 <        FailingCompletableFutureFunction r = new FailingCompletableFutureFunction();
2506 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2507 <        f.complete(one);
2508 <        checkCompletedWithWrappedCFException(g);
2509 <    }
2503 >    public void testThenCompose_sourceCancelled() {
2504 >        for (ExecutionMode m : ExecutionMode.values())
2505 >        for (boolean createIncomplete : new boolean[] { true, false })
2506 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2507 >    {
2508 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2509 >        final CompletableFutureInc r = new CompletableFutureInc();
2510 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2511 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2512 >        if (createIncomplete) {
2513 >            checkIncomplete(g);
2514 >            assertTrue(f.cancel(mayInterruptIfRunning));
2515 >        }
2516  
2939    /**
2940     * thenComposeAsync result completes exceptionally if source cancelled
2941     */
2942    public void testThenComposeAsync4E() {
2943        CompletableFuture<Integer> f = new CompletableFuture<>();
2944        CompletableFutureInc r = new CompletableFutureInc();
2945        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2946        assertTrue(f.cancel(true));
2517          checkCompletedWithWrappedCancellationException(g);
2518 <    }
2518 >        checkCancelled(f);
2519 >    }}
2520  
2521      // other static methods
2522  
# Line 3145 | Line 2716 | public class CompletableFutureTest exten
2716       * whenComplete action executes on normal completion, propagating
2717       * source result.
2718       */
2719 <    public void testWhenComplete1() {
2720 <        final AtomicInteger a = new AtomicInteger();
2721 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2722 <        CompletableFuture<Integer> g =
2723 <            f.whenComplete((Integer x, Throwable t) -> a.getAndIncrement());
2724 <        f.complete(three);
2725 <        checkCompletedNormally(f, three);
2726 <        checkCompletedNormally(g, three);
2727 <        assertEquals(a.get(), 1);
2728 <    }
2729 <
2730 <    /**
2731 <     * whenComplete action executes on exceptional completion, propagating
2732 <     * source result.
2733 <     */
2734 <    public void testWhenComplete2() {
3164 <        final AtomicInteger a = new AtomicInteger();
3165 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3166 <        CompletableFuture<Integer> g =
3167 <            f.whenComplete((Integer x, Throwable t) -> a.getAndIncrement());
3168 <        f.completeExceptionally(new CFException());
3169 <        assertTrue(f.isCompletedExceptionally());
3170 <        assertTrue(g.isCompletedExceptionally());
3171 <        assertEquals(a.get(), 1);
3172 <    }
3173 <
3174 <    /**
3175 <     * If a whenComplete action throws an exception when triggered by
3176 <     * a normal completion, it completes exceptionally
3177 <     */
3178 <    public void testWhenComplete3() {
3179 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3180 <        CompletableFuture<Integer> g =
3181 <            f.whenComplete((Integer x, Throwable t) ->
3182 <                           { throw new CFException(); } );
3183 <        f.complete(three);
3184 <        checkCompletedNormally(f, three);
3185 <        assertTrue(g.isCompletedExceptionally());
3186 <        checkCompletedWithWrappedCFException(g);
3187 <    }
3188 <
3189 <    /**
3190 <     * whenCompleteAsync action executes on normal completion, propagating
3191 <     * source result.
3192 <     */
3193 <    public void testWhenCompleteAsync1() {
3194 <        final AtomicInteger a = new AtomicInteger();
3195 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3196 <        CompletableFuture<Integer> g =
3197 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement());
3198 <        f.complete(three);
3199 <        checkCompletedNormally(f, three);
3200 <        checkCompletedNormally(g, three);
3201 <        assertEquals(a.get(), 1);
3202 <    }
3203 <
3204 <    /**
3205 <     * whenCompleteAsync action executes on exceptional completion, propagating
3206 <     * source result.
3207 <     */
3208 <    public void testWhenCompleteAsync2() {
3209 <        final AtomicInteger a = new AtomicInteger();
3210 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3211 <        CompletableFuture<Integer> g =
3212 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement());
3213 <        f.completeExceptionally(new CFException());
3214 <        checkCompletedWithWrappedCFException(f);
3215 <        checkCompletedWithWrappedCFException(g);
3216 <    }
2719 >    public void testWhenComplete_normalCompletion1() {
2720 >        for (ExecutionMode m : ExecutionMode.values())
2721 >        for (boolean createIncomplete : new boolean[] { true, false })
2722 >        for (Integer v1 : new Integer[] { 1, null })
2723 >    {
2724 >        final AtomicInteger a = new AtomicInteger(0);
2725 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2726 >        if (!createIncomplete) f.complete(v1);
2727 >        final CompletableFuture<Integer> g = m.whenComplete
2728 >            (f,
2729 >             (Integer x, Throwable t) -> {
2730 >                threadAssertSame(x, v1);
2731 >                threadAssertNull(t);
2732 >                a.getAndIncrement();
2733 >            });
2734 >        if (createIncomplete) f.complete(v1);
2735  
2736 <    /**
2737 <     * If a whenCompleteAsync action throws an exception when
2738 <     * triggered by a normal completion, it completes exceptionally
2739 <     */
3222 <    public void testWhenCompleteAsync3() {
3223 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3224 <        CompletableFuture<Integer> g =
3225 <            f.whenCompleteAsync((Integer x, Throwable t) ->
3226 <                           { throw new CFException(); } );
3227 <        f.complete(three);
3228 <        checkCompletedNormally(f, three);
3229 <        checkCompletedWithWrappedCFException(g);
3230 <    }
2736 >        checkCompletedNormally(g, v1);
2737 >        checkCompletedNormally(f, v1);
2738 >        assertEquals(1, a.get());
2739 >    }}
2740  
2741      /**
2742 <     * whenCompleteAsync action executes on normal completion, propagating
2742 >     * whenComplete action executes on exceptional completion, propagating
2743       * source result.
2744       */
2745 <    public void testWhenCompleteAsync1e() {
2746 <        final AtomicInteger a = new AtomicInteger();
2747 <        ThreadExecutor exec = new ThreadExecutor();
2748 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2749 <        CompletableFuture<Integer> g =
2750 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement(),
2751 <                                exec);
2752 <        f.complete(three);
2753 <        checkCompletedNormally(f, three);
2754 <        checkCompletedNormally(g, three);
2755 <        assertEquals(a.get(), 1);
2756 <    }
2745 >    public void testWhenComplete_exceptionalCompletion() {
2746 >        for (ExecutionMode m : ExecutionMode.values())
2747 >        for (boolean createIncomplete : new boolean[] { true, false })
2748 >        for (Integer v1 : new Integer[] { 1, null })
2749 >    {
2750 >        final AtomicInteger a = new AtomicInteger(0);
2751 >        final CFException ex = new CFException();
2752 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2753 >        if (!createIncomplete) f.completeExceptionally(ex);
2754 >        final CompletableFuture<Integer> g = m.whenComplete
2755 >            (f,
2756 >             (Integer x, Throwable t) -> {
2757 >                threadAssertNull(x);
2758 >                threadAssertSame(t, ex);
2759 >                a.getAndIncrement();
2760 >            });
2761 >        if (createIncomplete) f.completeExceptionally(ex);
2762 >        checkCompletedWithWrappedCFException(f, ex);
2763 >        checkCompletedWithWrappedCFException(g, ex);
2764 >        assertEquals(1, a.get());
2765 >    }}
2766  
2767      /**
2768 <     * whenCompleteAsync action executes on exceptional completion, propagating
2769 <     * source result.
2768 >     * whenComplete action executes on cancelled source, propagating
2769 >     * CancellationException.
2770       */
2771 <    public void testWhenCompleteAsync2e() {
2772 <        final AtomicInteger a = new AtomicInteger();
2773 <        ThreadExecutor exec = new ThreadExecutor();
2774 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2775 <        CompletableFuture<Integer> g =
2776 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement(),
2777 <                                exec);
2778 <        f.completeExceptionally(new CFException());
2779 <        checkCompletedWithWrappedCFException(f);
2780 <        checkCompletedWithWrappedCFException(g);
2781 <    }
2771 >    public void testWhenComplete_sourceCancelled() {
2772 >        for (ExecutionMode m : ExecutionMode.values())
2773 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2774 >        for (boolean createIncomplete : new boolean[] { true, false })
2775 >    {
2776 >        final AtomicInteger a = new AtomicInteger(0);
2777 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2778 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2779 >        final CompletableFuture<Integer> g = m.whenComplete
2780 >            (f,
2781 >             (Integer x, Throwable t) -> {
2782 >                threadAssertNull(x);
2783 >                threadAssertTrue(t instanceof CancellationException);
2784 >                a.getAndIncrement();
2785 >            });
2786 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2787  
2788 <    /**
2789 <     * If a whenCompleteAsync action throws an exception when triggered
2790 <     * by a normal completion, it completes exceptionally
2791 <     */
2792 <    public void testWhenCompleteAsync3e() {
3270 <        ThreadExecutor exec = new ThreadExecutor();
3271 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3272 <        CompletableFuture<Integer> g =
3273 <            f.whenCompleteAsync((Integer x, Throwable t) ->
3274 <                                { throw new CFException(); },
3275 <                                exec);
3276 <        f.complete(three);
3277 <        checkCompletedNormally(f, three);
3278 <        checkCompletedWithWrappedCFException(g);
3279 <    }
2788 >        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2789 >        checkCompletedWithWrappedCancellationException(g);
2790 >        checkCancelled(f);
2791 >        assertEquals(1, a.get());
2792 >    }}
2793  
2794      /**
2795 <     * handleAsync action completes normally with function value on
2796 <     * either normal or exceptional completion of source
2795 >     * If a whenComplete action throws an exception when triggered by
2796 >     * a normal completion, it completes exceptionally
2797       */
2798 <    public void testHandleAsync() {
2799 <        CompletableFuture<Integer> f, g;
2800 <        IntegerHandler r;
2801 <
2802 <        f = new CompletableFuture<>();
2803 <        g = f.handleAsync(r = new IntegerHandler());
2804 <        assertFalse(r.ran);
2805 <        f.completeExceptionally(new CFException());
2806 <        checkCompletedWithWrappedCFException(f);
2807 <        checkCompletedNormally(g, three);
2808 <        assertTrue(r.ran);
2809 <
2810 <        f = new CompletableFuture<>();
2811 <        g = f.handleAsync(r = new IntegerHandler());
2812 <        assertFalse(r.ran);
2813 <        f.completeExceptionally(new CFException());
2814 <        checkCompletedWithWrappedCFException(f);
2815 <        checkCompletedNormally(g, three);
2816 <        assertTrue(r.ran);
2817 <
2818 <        f = new CompletableFuture<>();
2819 <        g = f.handleAsync(r = new IntegerHandler());
3307 <        assertFalse(r.ran);
3308 <        f.complete(one);
3309 <        checkCompletedNormally(f, one);
3310 <        checkCompletedNormally(g, two);
3311 <        assertTrue(r.ran);
3312 <
3313 <        f = new CompletableFuture<>();
3314 <        g = f.handleAsync(r = new IntegerHandler());
3315 <        assertFalse(r.ran);
3316 <        f.complete(one);
3317 <        checkCompletedNormally(f, one);
3318 <        checkCompletedNormally(g, two);
3319 <        assertTrue(r.ran);
3320 <    }
2798 >    public void testWhenComplete_actionFailed() {
2799 >        for (boolean createIncomplete : new boolean[] { true, false })
2800 >        for (ExecutionMode m : ExecutionMode.values())
2801 >        for (Integer v1 : new Integer[] { 1, null })
2802 >    {
2803 >        final AtomicInteger a = new AtomicInteger(0);
2804 >        final CFException ex = new CFException();
2805 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2806 >        if (!createIncomplete) f.complete(v1);
2807 >        final CompletableFuture<Integer> g = m.whenComplete
2808 >            (f,
2809 >             (Integer x, Throwable t) -> {
2810 >                threadAssertSame(x, v1);
2811 >                threadAssertNull(t);
2812 >                a.getAndIncrement();
2813 >                throw ex;
2814 >            });
2815 >        if (createIncomplete) f.complete(v1);
2816 >        checkCompletedNormally(f, v1);
2817 >        checkCompletedWithWrappedCFException(g, ex);
2818 >        assertEquals(1, a.get());
2819 >    }}
2820  
2821      /**
2822 <     * handleAsync action with Executor completes normally with
2823 <     * function value on either normal or exceptional completion of
2824 <     * source
2822 >     * If a whenComplete action throws an exception when triggered by
2823 >     * a source completion that also throws an exception, the source
2824 >     * exception takes precedence.
2825       */
2826 <    public void testHandleAsync2() {
2827 <        CompletableFuture<Integer> f, g;
2828 <        ThreadExecutor exec = new ThreadExecutor();
2829 <        IntegerHandler r;
2830 <
2831 <        f = new CompletableFuture<>();
2832 <        g = f.handleAsync(r = new IntegerHandler(), exec);
2833 <        assertFalse(r.ran);
2834 <        f.completeExceptionally(new CFException());
3336 <        checkCompletedWithWrappedCFException(f);
3337 <        checkCompletedNormally(g, three);
3338 <        assertTrue(r.ran);
3339 <
3340 <        f = new CompletableFuture<>();
3341 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3342 <        assertFalse(r.ran);
3343 <        f.completeExceptionally(new CFException());
3344 <        checkCompletedWithWrappedCFException(f);
3345 <        checkCompletedNormally(g, three);
3346 <        assertTrue(r.ran);
3347 <
3348 <        f = new CompletableFuture<>();
3349 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3350 <        assertFalse(r.ran);
3351 <        f.complete(one);
3352 <        checkCompletedNormally(f, one);
3353 <        checkCompletedNormally(g, two);
3354 <        assertTrue(r.ran);
2826 >    public void testWhenComplete_actionFailedSourceFailed() {
2827 >        for (boolean createIncomplete : new boolean[] { true, false })
2828 >        for (ExecutionMode m : ExecutionMode.values())
2829 >        for (Integer v1 : new Integer[] { 1, null })
2830 >    {
2831 >        final AtomicInteger a = new AtomicInteger(0);
2832 >        final CFException ex1 = new CFException();
2833 >        final CFException ex2 = new CFException();
2834 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2835  
2836 <        f = new CompletableFuture<>();
2837 <        g = f.handleAsync(r = new IntegerHandler(), exec);
2838 <        assertFalse(r.ran);
2839 <        f.complete(one);
2840 <        checkCompletedNormally(f, one);
2841 <        checkCompletedNormally(g, two);
2842 <        assertTrue(r.ran);
2843 <    }
2836 >        if (!createIncomplete) f.completeExceptionally(ex1);
2837 >        final CompletableFuture<Integer> g = m.whenComplete
2838 >            (f,
2839 >             (Integer x, Throwable t) -> {
2840 >                threadAssertSame(t, ex1);
2841 >                threadAssertNull(x);
2842 >                a.getAndIncrement();
2843 >                throw ex2;
2844 >            });
2845 >        if (createIncomplete) f.completeExceptionally(ex1);
2846 >
2847 >        checkCompletedWithWrappedCFException(f, ex1);
2848 >        checkCompletedWithWrappedCFException(g, ex1);
2849 >        assertEquals(1, a.get());
2850 >    }}
2851  
2852   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines