ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.36 by jsr166, Sun Jun 1 23:12:45 2014 UTC vs.
Revision 1.151 by jsr166, Sun Jun 26 17:45:35 2016 UTC

# Line 5 | Line 5
5   * http://creativecommons.org/publicdomain/zero/1.0/
6   */
7  
8 < import junit.framework.*;
8 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
9 > import static java.util.concurrent.TimeUnit.SECONDS;
10 > import static java.util.concurrent.CompletableFuture.completedFuture;
11 > import static java.util.concurrent.CompletableFuture.failedFuture;
12 >
13 > import java.lang.reflect.Method;
14 > import java.lang.reflect.Modifier;
15 >
16 > import java.util.stream.Collectors;
17 > import java.util.stream.Stream;
18 >
19 > import java.util.ArrayList;
20 > import java.util.Arrays;
21 > import java.util.List;
22 > import java.util.Objects;
23 > import java.util.Set;
24   import java.util.concurrent.Callable;
10 import java.util.concurrent.Executor;
11 import java.util.concurrent.ExecutorService;
12 import java.util.concurrent.Executors;
25   import java.util.concurrent.CancellationException;
14 import java.util.concurrent.CountDownLatch;
15 import java.util.concurrent.ExecutionException;
16 import java.util.concurrent.Future;
26   import java.util.concurrent.CompletableFuture;
27   import java.util.concurrent.CompletionException;
28   import java.util.concurrent.CompletionStage;
29 + import java.util.concurrent.ExecutionException;
30 + import java.util.concurrent.Executor;
31 + import java.util.concurrent.ForkJoinPool;
32 + import java.util.concurrent.ForkJoinTask;
33   import java.util.concurrent.TimeoutException;
34 + import java.util.concurrent.TimeUnit;
35   import java.util.concurrent.atomic.AtomicInteger;
36 < import static java.util.concurrent.TimeUnit.MILLISECONDS;
23 < import static java.util.concurrent.TimeUnit.SECONDS;
24 < import java.util.*;
25 < import java.util.function.Supplier;
26 < import java.util.function.Consumer;
36 > import java.util.concurrent.atomic.AtomicReference;
37   import java.util.function.BiConsumer;
28 import java.util.function.Function;
38   import java.util.function.BiFunction;
39 + import java.util.function.Consumer;
40 + import java.util.function.Function;
41 + import java.util.function.Predicate;
42 + import java.util.function.Supplier;
43 +
44 + import junit.framework.AssertionFailedError;
45 + import junit.framework.Test;
46 + import junit.framework.TestSuite;
47  
48   public class CompletableFutureTest extends JSR166TestCase {
49  
50      public static void main(String[] args) {
51 <        junit.textui.TestRunner.run(suite());
51 >        main(suite(), args);
52      }
53      public static Test suite() {
54          return new TestSuite(CompletableFutureTest.class);
# Line 42 | Line 59 | public class CompletableFutureTest exten
59      void checkIncomplete(CompletableFuture<?> f) {
60          assertFalse(f.isDone());
61          assertFalse(f.isCancelled());
62 <        assertTrue(f.toString().contains("[Not completed]"));
62 >        assertTrue(f.toString().contains("Not completed"));
63          try {
64              assertNull(f.getNow(null));
65          } catch (Throwable fail) { threadUnexpectedException(fail); }
# Line 55 | Line 72 | public class CompletableFutureTest exten
72      }
73  
74      <T> void checkCompletedNormally(CompletableFuture<T> f, T value) {
75 <        try {
76 <            assertEquals(value, f.get(LONG_DELAY_MS, MILLISECONDS));
60 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
75 >        checkTimedGet(f, value);
76 >
77          try {
78              assertEquals(value, f.join());
79          } catch (Throwable fail) { threadUnexpectedException(fail); }
# Line 73 | Line 89 | public class CompletableFutureTest exten
89          assertTrue(f.toString().contains("[Completed normally]"));
90      }
91  
92 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f) {
93 <        try {
94 <            f.get(LONG_DELAY_MS, MILLISECONDS);
95 <            shouldThrow();
96 <        } catch (ExecutionException success) {
97 <            assertTrue(success.getCause() instanceof CFException);
98 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
99 <        try {
100 <            f.join();
101 <            shouldThrow();
102 <        } catch (CompletionException success) {
103 <            assertTrue(success.getCause() instanceof CFException);
104 <        }
105 <        try {
106 <            f.getNow(null);
107 <            shouldThrow();
108 <        } catch (CompletionException success) {
93 <            assertTrue(success.getCause() instanceof CFException);
92 >    /**
93 >     * Returns the "raw" internal exceptional completion of f,
94 >     * without any additional wrapping with CompletionException.
95 >     */
96 >    <U> Throwable exceptionalCompletion(CompletableFuture<U> f) {
97 >        // handle (and whenComplete) can distinguish between "direct"
98 >        // and "wrapped" exceptional completion
99 >        return f.handle((U u, Throwable t) -> t).join();
100 >    }
101 >
102 >    void checkCompletedExceptionally(CompletableFuture<?> f,
103 >                                     boolean wrapped,
104 >                                     Consumer<Throwable> checker) {
105 >        Throwable cause = exceptionalCompletion(f);
106 >        if (wrapped) {
107 >            assertTrue(cause instanceof CompletionException);
108 >            cause = cause.getCause();
109          }
110 <        try {
96 <            f.get();
97 <            shouldThrow();
98 <        } catch (ExecutionException success) {
99 <            assertTrue(success.getCause() instanceof CFException);
100 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
101 <        assertTrue(f.isDone());
102 <        assertFalse(f.isCancelled());
103 <        assertTrue(f.toString().contains("[Completed exceptionally]"));
104 <    }
110 >        checker.accept(cause);
111  
112 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
107 <                                              CFException ex) {
112 >        long startTime = System.nanoTime();
113          try {
114              f.get(LONG_DELAY_MS, MILLISECONDS);
115              shouldThrow();
116          } catch (ExecutionException success) {
117 <            assertSame(ex, success.getCause());
117 >            assertSame(cause, success.getCause());
118          } catch (Throwable fail) { threadUnexpectedException(fail); }
119 +        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
120 +
121          try {
122              f.join();
123              shouldThrow();
124          } catch (CompletionException success) {
125 <            assertSame(ex, success.getCause());
126 <        }
125 >            assertSame(cause, success.getCause());
126 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
127 >
128          try {
129              f.getNow(null);
130              shouldThrow();
131          } catch (CompletionException success) {
132 <            assertSame(ex, success.getCause());
133 <        }
132 >            assertSame(cause, success.getCause());
133 >        } catch (Throwable fail) { threadUnexpectedException(fail); }
134 >
135          try {
136              f.get();
137              shouldThrow();
138          } catch (ExecutionException success) {
139 <            assertSame(ex, success.getCause());
139 >            assertSame(cause, success.getCause());
140          } catch (Throwable fail) { threadUnexpectedException(fail); }
141 <        assertTrue(f.isDone());
141 >
142          assertFalse(f.isCancelled());
143 +        assertTrue(f.isDone());
144 +        assertTrue(f.isCompletedExceptionally());
145          assertTrue(f.toString().contains("[Completed exceptionally]"));
146      }
147  
148 +    void checkCompletedWithWrappedCFException(CompletableFuture<?> f) {
149 +        checkCompletedExceptionally(f, true,
150 +            (t) -> assertTrue(t instanceof CFException));
151 +    }
152 +
153 +    void checkCompletedWithWrappedCancellationException(CompletableFuture<?> f) {
154 +        checkCompletedExceptionally(f, true,
155 +            (t) -> assertTrue(t instanceof CancellationException));
156 +    }
157 +
158 +    void checkCompletedWithTimeoutException(CompletableFuture<?> f) {
159 +        checkCompletedExceptionally(f, false,
160 +            (t) -> assertTrue(t instanceof TimeoutException));
161 +    }
162 +
163 +    void checkCompletedWithWrappedException(CompletableFuture<?> f,
164 +                                            Throwable ex) {
165 +        checkCompletedExceptionally(f, true, (t) -> assertSame(t, ex));
166 +    }
167 +
168 +    void checkCompletedExceptionally(CompletableFuture<?> f, Throwable ex) {
169 +        checkCompletedExceptionally(f, false, (t) -> assertSame(t, ex));
170 +    }
171 +
172      void checkCancelled(CompletableFuture<?> f) {
173 +        long startTime = System.nanoTime();
174          try {
175              f.get(LONG_DELAY_MS, MILLISECONDS);
176              shouldThrow();
177          } catch (CancellationException success) {
178          } catch (Throwable fail) { threadUnexpectedException(fail); }
179 +        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
180 +
181          try {
182              f.join();
183              shouldThrow();
# Line 153 | Line 191 | public class CompletableFutureTest exten
191              shouldThrow();
192          } catch (CancellationException success) {
193          } catch (Throwable fail) { threadUnexpectedException(fail); }
156        assertTrue(f.isDone());
157        assertTrue(f.isCompletedExceptionally());
158        assertTrue(f.isCancelled());
159        assertTrue(f.toString().contains("[Completed exceptionally]"));
160    }
194  
195 <    void checkCompletedWithWrappedCancellationException(CompletableFuture<?> f) {
196 <        try {
164 <            f.get(LONG_DELAY_MS, MILLISECONDS);
165 <            shouldThrow();
166 <        } catch (ExecutionException success) {
167 <            assertTrue(success.getCause() instanceof CancellationException);
168 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
169 <        try {
170 <            f.join();
171 <            shouldThrow();
172 <        } catch (CompletionException success) {
173 <            assertTrue(success.getCause() instanceof CancellationException);
174 <        }
175 <        try {
176 <            f.getNow(null);
177 <            shouldThrow();
178 <        } catch (CompletionException success) {
179 <            assertTrue(success.getCause() instanceof CancellationException);
180 <        }
181 <        try {
182 <            f.get();
183 <            shouldThrow();
184 <        } catch (ExecutionException success) {
185 <            assertTrue(success.getCause() instanceof CancellationException);
186 <        } catch (Throwable fail) { threadUnexpectedException(fail); }
195 >        assertTrue(exceptionalCompletion(f) instanceof CancellationException);
196 >
197          assertTrue(f.isDone());
188        assertFalse(f.isCancelled());
198          assertTrue(f.isCompletedExceptionally());
199 +        assertTrue(f.isCancelled());
200          assertTrue(f.toString().contains("[Completed exceptionally]"));
201      }
202  
# Line 204 | Line 214 | public class CompletableFutureTest exten
214       * isCancelled, join, get, and getNow
215       */
216      public void testComplete() {
217 +        for (Integer v1 : new Integer[] { 1, null })
218 +    {
219          CompletableFuture<Integer> f = new CompletableFuture<>();
220          checkIncomplete(f);
221 <        f.complete(one);
222 <        checkCompletedNormally(f, one);
223 <    }
221 >        assertTrue(f.complete(v1));
222 >        assertFalse(f.complete(v1));
223 >        checkCompletedNormally(f, v1);
224 >    }}
225  
226      /**
227       * completeExceptionally completes exceptionally, as indicated by
# Line 216 | Line 229 | public class CompletableFutureTest exten
229       */
230      public void testCompleteExceptionally() {
231          CompletableFuture<Integer> f = new CompletableFuture<>();
232 +        CFException ex = new CFException();
233          checkIncomplete(f);
234 <        f.completeExceptionally(new CFException());
235 <        checkCompletedWithWrappedCFException(f);
234 >        f.completeExceptionally(ex);
235 >        checkCompletedExceptionally(f, ex);
236      }
237  
238      /**
# Line 226 | Line 240 | public class CompletableFutureTest exten
240       * methods isDone, isCancelled, join, get, and getNow
241       */
242      public void testCancel() {
243 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
244 +    {
245          CompletableFuture<Integer> f = new CompletableFuture<>();
246          checkIncomplete(f);
247 <        assertTrue(f.cancel(true));
247 >        assertTrue(f.cancel(mayInterruptIfRunning));
248 >        assertTrue(f.cancel(mayInterruptIfRunning));
249 >        assertTrue(f.cancel(!mayInterruptIfRunning));
250          checkCancelled(f);
251 <    }
251 >    }}
252  
253      /**
254       * obtrudeValue forces completion with given value
# Line 238 | Line 256 | public class CompletableFutureTest exten
256      public void testObtrudeValue() {
257          CompletableFuture<Integer> f = new CompletableFuture<>();
258          checkIncomplete(f);
259 <        f.complete(one);
259 >        assertTrue(f.complete(one));
260          checkCompletedNormally(f, one);
261          f.obtrudeValue(three);
262          checkCompletedNormally(f, three);
# Line 247 | Line 265 | public class CompletableFutureTest exten
265          f = new CompletableFuture<>();
266          f.obtrudeValue(three);
267          checkCompletedNormally(f, three);
268 +        f.obtrudeValue(null);
269 +        checkCompletedNormally(f, null);
270          f = new CompletableFuture<>();
271          f.completeExceptionally(new CFException());
272          f.obtrudeValue(four);
# Line 257 | Line 277 | public class CompletableFutureTest exten
277       * obtrudeException forces completion with given exception
278       */
279      public void testObtrudeException() {
280 <        CompletableFuture<Integer> f = new CompletableFuture<>();
281 <        checkIncomplete(f);
282 <        f.complete(one);
283 <        checkCompletedNormally(f, one);
284 <        f.obtrudeException(new CFException());
265 <        checkCompletedWithWrappedCFException(f);
280 >        for (Integer v1 : new Integer[] { 1, null })
281 >    {
282 >        CFException ex;
283 >        CompletableFuture<Integer> f;
284 >
285          f = new CompletableFuture<>();
286 <        f.obtrudeException(new CFException());
287 <        checkCompletedWithWrappedCFException(f);
286 >        assertTrue(f.complete(v1));
287 >        for (int i = 0; i < 2; i++) {
288 >            f.obtrudeException(ex = new CFException());
289 >            checkCompletedExceptionally(f, ex);
290 >        }
291 >
292          f = new CompletableFuture<>();
293 +        for (int i = 0; i < 2; i++) {
294 +            f.obtrudeException(ex = new CFException());
295 +            checkCompletedExceptionally(f, ex);
296 +        }
297 +
298 +        f = new CompletableFuture<>();
299 +        f.completeExceptionally(ex = new CFException());
300 +        f.obtrudeValue(v1);
301 +        checkCompletedNormally(f, v1);
302 +        f.obtrudeException(ex = new CFException());
303 +        checkCompletedExceptionally(f, ex);
304          f.completeExceptionally(new CFException());
305 <        f.obtrudeValue(four);
306 <        checkCompletedNormally(f, four);
307 <        f.obtrudeException(new CFException());
308 <        checkCompletedWithWrappedCFException(f);
275 <    }
305 >        checkCompletedExceptionally(f, ex);
306 >        assertFalse(f.complete(v1));
307 >        checkCompletedExceptionally(f, ex);
308 >    }}
309  
310      /**
311       * getNumberOfDependents returns number of dependent tasks
312       */
313      public void testGetNumberOfDependents() {
314 +        for (ExecutionMode m : ExecutionMode.values())
315 +        for (Integer v1 : new Integer[] { 1, null })
316 +    {
317          CompletableFuture<Integer> f = new CompletableFuture<>();
318 <        assertEquals(f.getNumberOfDependents(), 0);
319 <        CompletableFuture g = f.thenRun(new Noop());
320 <        assertEquals(f.getNumberOfDependents(), 1);
321 <        assertEquals(g.getNumberOfDependents(), 0);
322 <        CompletableFuture h = f.thenRun(new Noop());
323 <        assertEquals(f.getNumberOfDependents(), 2);
324 <        f.complete(1);
318 >        assertEquals(0, f.getNumberOfDependents());
319 >        final CompletableFuture<Void> g = m.thenRun(f, new Noop(m));
320 >        assertEquals(1, f.getNumberOfDependents());
321 >        assertEquals(0, g.getNumberOfDependents());
322 >        final CompletableFuture<Void> h = m.thenRun(f, new Noop(m));
323 >        assertEquals(2, f.getNumberOfDependents());
324 >        assertEquals(0, h.getNumberOfDependents());
325 >        assertTrue(f.complete(v1));
326          checkCompletedNormally(g, null);
327 <        assertEquals(f.getNumberOfDependents(), 0);
328 <        assertEquals(g.getNumberOfDependents(), 0);
329 <    }
327 >        checkCompletedNormally(h, null);
328 >        assertEquals(0, f.getNumberOfDependents());
329 >        assertEquals(0, g.getNumberOfDependents());
330 >        assertEquals(0, h.getNumberOfDependents());
331 >    }}
332  
333      /**
334       * toString indicates current completion state
# Line 300 | Line 339 | public class CompletableFutureTest exten
339          f = new CompletableFuture<String>();
340          assertTrue(f.toString().contains("[Not completed]"));
341  
342 <        f.complete("foo");
342 >        assertTrue(f.complete("foo"));
343          assertTrue(f.toString().contains("[Completed normally]"));
344  
345          f = new CompletableFuture<String>();
346 <        f.completeExceptionally(new IndexOutOfBoundsException());
346 >        assertTrue(f.completeExceptionally(new IndexOutOfBoundsException()));
347          assertTrue(f.toString().contains("[Completed exceptionally]"));
348 +
349 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
350 +            f = new CompletableFuture<String>();
351 +            assertTrue(f.cancel(mayInterruptIfRunning));
352 +            assertTrue(f.toString().contains("[Completed exceptionally]"));
353 +        }
354      }
355  
356      /**
# Line 316 | Line 361 | public class CompletableFutureTest exten
361          checkCompletedNormally(f, "test");
362      }
363  
364 <    // Choose non-commutative actions for better coverage
364 >    abstract class CheckedAction {
365 >        int invocationCount = 0;
366 >        final ExecutionMode m;
367 >        CheckedAction(ExecutionMode m) { this.m = m; }
368 >        void invoked() {
369 >            m.checkExecutionMode();
370 >            assertEquals(0, invocationCount++);
371 >        }
372 >        void assertNotInvoked() { assertEquals(0, invocationCount); }
373 >        void assertInvoked() { assertEquals(1, invocationCount); }
374 >    }
375 >
376 >    abstract class CheckedIntegerAction extends CheckedAction {
377 >        Integer value;
378 >        CheckedIntegerAction(ExecutionMode m) { super(m); }
379 >        void assertValue(Integer expected) {
380 >            assertInvoked();
381 >            assertEquals(expected, value);
382 >        }
383 >    }
384 >
385 >    class IntegerSupplier extends CheckedAction
386 >        implements Supplier<Integer>
387 >    {
388 >        final Integer value;
389 >        IntegerSupplier(ExecutionMode m, Integer value) {
390 >            super(m);
391 >            this.value = value;
392 >        }
393 >        public Integer get() {
394 >            invoked();
395 >            return value;
396 >        }
397 >    }
398 >
399 >    // A function that handles and produces null values as well.
400 >    static Integer inc(Integer x) {
401 >        return (x == null) ? null : x + 1;
402 >    }
403 >
404 >    class NoopConsumer extends CheckedIntegerAction
405 >        implements Consumer<Integer>
406 >    {
407 >        NoopConsumer(ExecutionMode m) { super(m); }
408 >        public void accept(Integer x) {
409 >            invoked();
410 >            value = x;
411 >        }
412 >    }
413  
414 <    // A non-commutative function that handles null values as well
415 <    public static int subtract(Integer x, Integer y) {
416 <        return ((x == null) ? 42 : x.intValue())
414 >    class IncFunction extends CheckedIntegerAction
415 >        implements Function<Integer,Integer>
416 >    {
417 >        IncFunction(ExecutionMode m) { super(m); }
418 >        public Integer apply(Integer x) {
419 >            invoked();
420 >            return value = inc(x);
421 >        }
422 >    }
423 >
424 >    // Choose non-commutative actions for better coverage
425 >    // A non-commutative function that handles and produces null values as well.
426 >    static Integer subtract(Integer x, Integer y) {
427 >        return (x == null && y == null) ? null :
428 >            ((x == null) ? 42 : x.intValue())
429              - ((y == null) ? 99 : y.intValue());
430      }
431  
432 <    static final Supplier<Integer> supplyOne =
433 <        () -> Integer.valueOf(1);
434 <    static final Function<Integer, Integer> inc =
435 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
331 <    static final BiFunction<Integer, Integer, Integer> subtract =
332 <        (Integer x, Integer y) -> subtract(x, y);
333 <    static final class IncAction implements Consumer<Integer> {
334 <        int value;
335 <        public void accept(Integer x) { value = x.intValue() + 1; }
336 <    }
337 <    static final class SubtractAction implements BiConsumer<Integer, Integer> {
338 <        volatile int invocationCount = 0;
339 <        int value;
340 <        // Check this action was invoked exactly once when result is computed.
341 <        public boolean ran() { return invocationCount == 1; }
432 >    class SubtractAction extends CheckedIntegerAction
433 >        implements BiConsumer<Integer, Integer>
434 >    {
435 >        SubtractAction(ExecutionMode m) { super(m); }
436          public void accept(Integer x, Integer y) {
437 <            invocationCount++;
437 >            invoked();
438              value = subtract(x, y);
439          }
440      }
441 <    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
442 <        volatile int invocationCount = 0;
443 <        int value;
444 <        // Check this action was invoked exactly once when result is computed.
445 <        public boolean ran() { return invocationCount == 1; }
441 >
442 >    class SubtractFunction extends CheckedIntegerAction
443 >        implements BiFunction<Integer, Integer, Integer>
444 >    {
445 >        SubtractFunction(ExecutionMode m) { super(m); }
446          public Integer apply(Integer x, Integer y) {
447 <            invocationCount++;
448 <            return subtract(x, y);
447 >            invoked();
448 >            return value = subtract(x, y);
449          }
450      }
451 <    static final class Noop implements Runnable {
452 <        boolean ran;
453 <        public void run() { ran = true; }
451 >
452 >    class Noop extends CheckedAction implements Runnable {
453 >        Noop(ExecutionMode m) { super(m); }
454 >        public void run() {
455 >            invoked();
456 >        }
457      }
458  
459 <    static final class FailingSupplier implements Supplier<Integer> {
460 <        boolean ran;
461 <        public Integer get() { ran = true; throw new CFException(); }
459 >    class FailingSupplier extends CheckedAction
460 >        implements Supplier<Integer>
461 >    {
462 >        final CFException ex;
463 >        FailingSupplier(ExecutionMode m) { super(m); ex = new CFException(); }
464 >        public Integer get() {
465 >            invoked();
466 >            throw ex;
467 >        }
468      }
469 <    static final class FailingConsumer implements Consumer<Integer> {
470 <        boolean ran;
471 <        public void accept(Integer x) { ran = true; throw new CFException(); }
469 >
470 >    class FailingConsumer extends CheckedIntegerAction
471 >        implements Consumer<Integer>
472 >    {
473 >        final CFException ex;
474 >        FailingConsumer(ExecutionMode m) { super(m); ex = new CFException(); }
475 >        public void accept(Integer x) {
476 >            invoked();
477 >            value = x;
478 >            throw ex;
479 >        }
480      }
481 <    static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
482 <        boolean ran;
483 <        public void accept(Integer x, Integer y) { ran = true; throw new CFException(); }
481 >
482 >    class FailingBiConsumer extends CheckedIntegerAction
483 >        implements BiConsumer<Integer, Integer>
484 >    {
485 >        final CFException ex;
486 >        FailingBiConsumer(ExecutionMode m) { super(m); ex = new CFException(); }
487 >        public void accept(Integer x, Integer y) {
488 >            invoked();
489 >            value = subtract(x, y);
490 >            throw ex;
491 >        }
492      }
493 <    static final class FailingFunction implements Function<Integer, Integer> {
494 <        boolean ran;
495 <        public Integer apply(Integer x) { ran = true; throw new CFException(); }
493 >
494 >    class FailingFunction extends CheckedIntegerAction
495 >        implements Function<Integer, Integer>
496 >    {
497 >        final CFException ex;
498 >        FailingFunction(ExecutionMode m) { super(m); ex = new CFException(); }
499 >        public Integer apply(Integer x) {
500 >            invoked();
501 >            value = x;
502 >            throw ex;
503 >        }
504      }
505 <    static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
506 <        boolean ran;
507 <        public Integer apply(Integer x, Integer y) { ran = true; throw new CFException(); }
505 >
506 >    class FailingBiFunction extends CheckedIntegerAction
507 >        implements BiFunction<Integer, Integer, Integer>
508 >    {
509 >        final CFException ex;
510 >        FailingBiFunction(ExecutionMode m) { super(m); ex = new CFException(); }
511 >        public Integer apply(Integer x, Integer y) {
512 >            invoked();
513 >            value = subtract(x, y);
514 >            throw ex;
515 >        }
516      }
517 <    static final class FailingNoop implements Runnable {
518 <        boolean ran;
519 <        public void run() { ran = true; throw new CFException(); }
517 >
518 >    class FailingRunnable extends CheckedAction implements Runnable {
519 >        final CFException ex;
520 >        FailingRunnable(ExecutionMode m) { super(m); ex = new CFException(); }
521 >        public void run() {
522 >            invoked();
523 >            throw ex;
524 >        }
525      }
526  
527 <    static final class CompletableFutureInc
528 <        implements Function<Integer, CompletableFuture<Integer>> {
529 <        boolean ran;
527 >    class CompletableFutureInc extends CheckedIntegerAction
528 >        implements Function<Integer, CompletableFuture<Integer>>
529 >    {
530 >        CompletableFutureInc(ExecutionMode m) { super(m); }
531          public CompletableFuture<Integer> apply(Integer x) {
532 <            ran = true;
532 >            invoked();
533 >            value = x;
534              CompletableFuture<Integer> f = new CompletableFuture<>();
535 <            f.complete(Integer.valueOf(x.intValue() + 1));
535 >            assertTrue(f.complete(inc(x)));
536              return f;
537          }
538      }
539  
540 <    static final class FailingCompletableFutureFunction
541 <        implements Function<Integer, CompletableFuture<Integer>> {
542 <        boolean ran;
540 >    class FailingCompletableFutureFunction extends CheckedIntegerAction
541 >        implements Function<Integer, CompletableFuture<Integer>>
542 >    {
543 >        final CFException ex;
544 >        FailingCompletableFutureFunction(ExecutionMode m) { super(m); ex = new CFException(); }
545          public CompletableFuture<Integer> apply(Integer x) {
546 <            ran = true; throw new CFException();
546 >            invoked();
547 >            value = x;
548 >            throw ex;
549          }
550      }
551  
552      // Used for explicit executor tests
553      static final class ThreadExecutor implements Executor {
554 <        AtomicInteger count = new AtomicInteger(0);
554 >        final AtomicInteger count = new AtomicInteger(0);
555 >        static final ThreadGroup tg = new ThreadGroup("ThreadExecutor");
556 >        static boolean startedCurrentThread() {
557 >            return Thread.currentThread().getThreadGroup() == tg;
558 >        }
559  
560          public void execute(Runnable r) {
561              count.getAndIncrement();
562 <            new Thread(r).start();
562 >            new Thread(tg, r).start();
563          }
564      }
565  
566 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
567 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
418 <    }
419 <
420 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
421 <        boolean ran;
422 <        public Integer apply(Integer x, Throwable t) {
423 <            ran = true;
424 <            return (t == null) ? two : three;
425 <        }
426 <    }
566 >    static final boolean defaultExecutorIsCommonPool
567 >        = ForkJoinPool.getCommonPoolParallelism() > 1;
568  
569      /**
570       * Permits the testing of parallel code for the 3 different
571 <     * execution modes without repeating all the testing code.
571 >     * execution modes without copy/pasting all the test methods.
572       */
573      enum ExecutionMode {
574 <        DEFAULT {
574 >        SYNC {
575 >            public void checkExecutionMode() {
576 >                assertFalse(ThreadExecutor.startedCurrentThread());
577 >                assertNull(ForkJoinTask.getPool());
578 >            }
579 >            public CompletableFuture<Void> runAsync(Runnable a) {
580 >                throw new UnsupportedOperationException();
581 >            }
582 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
583 >                throw new UnsupportedOperationException();
584 >            }
585 >            public <T> CompletableFuture<Void> thenRun
586 >                (CompletableFuture<T> f, Runnable a) {
587 >                return f.thenRun(a);
588 >            }
589 >            public <T> CompletableFuture<Void> thenAccept
590 >                (CompletableFuture<T> f, Consumer<? super T> a) {
591 >                return f.thenAccept(a);
592 >            }
593 >            public <T,U> CompletableFuture<U> thenApply
594 >                (CompletableFuture<T> f, Function<? super T,U> a) {
595 >                return f.thenApply(a);
596 >            }
597 >            public <T,U> CompletableFuture<U> thenCompose
598 >                (CompletableFuture<T> f,
599 >                 Function<? super T,? extends CompletionStage<U>> a) {
600 >                return f.thenCompose(a);
601 >            }
602 >            public <T,U> CompletableFuture<U> handle
603 >                (CompletableFuture<T> f,
604 >                 BiFunction<? super T,Throwable,? extends U> a) {
605 >                return f.handle(a);
606 >            }
607 >            public <T> CompletableFuture<T> whenComplete
608 >                (CompletableFuture<T> f,
609 >                 BiConsumer<? super T,? super Throwable> a) {
610 >                return f.whenComplete(a);
611 >            }
612              public <T,U> CompletableFuture<Void> runAfterBoth
613                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
614                  return f.runAfterBoth(g, a);
# Line 447 | Line 625 | public class CompletableFutureTest exten
625                   BiFunction<? super T,? super U,? extends V> a) {
626                  return f.thenCombine(g, a);
627              }
628 +            public <T> CompletableFuture<Void> runAfterEither
629 +                (CompletableFuture<T> f,
630 +                 CompletionStage<?> g,
631 +                 java.lang.Runnable a) {
632 +                return f.runAfterEither(g, a);
633 +            }
634 +            public <T> CompletableFuture<Void> acceptEither
635 +                (CompletableFuture<T> f,
636 +                 CompletionStage<? extends T> g,
637 +                 Consumer<? super T> a) {
638 +                return f.acceptEither(g, a);
639 +            }
640 +            public <T,U> CompletableFuture<U> applyToEither
641 +                (CompletableFuture<T> f,
642 +                 CompletionStage<? extends T> g,
643 +                 Function<? super T,U> a) {
644 +                return f.applyToEither(g, a);
645 +            }
646          },
647  
648 < //             /** Experimental way to do more testing */
649 < //         REVERSE_DEFAULT {
650 < //             public <T,U> CompletableFuture<Void> runAfterBoth
651 < //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
652 < //                 return g.runAfterBoth(f, a);
653 < //             }
654 < //             public <T,U> CompletableFuture<Void> thenAcceptBoth
655 < //                 (CompletableFuture<T> f,
656 < //                  CompletionStage<? extends U> g,
657 < //                  BiConsumer<? super T,? super U> a) {
658 < //                 return DEFAULT.thenAcceptBoth(f, g, a);
659 < //             }
660 < //         },
661 <
662 <        DEFAULT_ASYNC {
648 >        ASYNC {
649 >            public void checkExecutionMode() {
650 >                assertEquals(defaultExecutorIsCommonPool,
651 >                             (ForkJoinPool.commonPool() == ForkJoinTask.getPool()));
652 >            }
653 >            public CompletableFuture<Void> runAsync(Runnable a) {
654 >                return CompletableFuture.runAsync(a);
655 >            }
656 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
657 >                return CompletableFuture.supplyAsync(a);
658 >            }
659 >            public <T> CompletableFuture<Void> thenRun
660 >                (CompletableFuture<T> f, Runnable a) {
661 >                return f.thenRunAsync(a);
662 >            }
663 >            public <T> CompletableFuture<Void> thenAccept
664 >                (CompletableFuture<T> f, Consumer<? super T> a) {
665 >                return f.thenAcceptAsync(a);
666 >            }
667 >            public <T,U> CompletableFuture<U> thenApply
668 >                (CompletableFuture<T> f, Function<? super T,U> a) {
669 >                return f.thenApplyAsync(a);
670 >            }
671 >            public <T,U> CompletableFuture<U> thenCompose
672 >                (CompletableFuture<T> f,
673 >                 Function<? super T,? extends CompletionStage<U>> a) {
674 >                return f.thenComposeAsync(a);
675 >            }
676 >            public <T,U> CompletableFuture<U> handle
677 >                (CompletableFuture<T> f,
678 >                 BiFunction<? super T,Throwable,? extends U> a) {
679 >                return f.handleAsync(a);
680 >            }
681 >            public <T> CompletableFuture<T> whenComplete
682 >                (CompletableFuture<T> f,
683 >                 BiConsumer<? super T,? super Throwable> a) {
684 >                return f.whenCompleteAsync(a);
685 >            }
686              public <T,U> CompletableFuture<Void> runAfterBoth
687                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
688                  return f.runAfterBothAsync(g, a);
# Line 480 | Line 699 | public class CompletableFutureTest exten
699                   BiFunction<? super T,? super U,? extends V> a) {
700                  return f.thenCombineAsync(g, a);
701              }
702 +            public <T> CompletableFuture<Void> runAfterEither
703 +                (CompletableFuture<T> f,
704 +                 CompletionStage<?> g,
705 +                 java.lang.Runnable a) {
706 +                return f.runAfterEitherAsync(g, a);
707 +            }
708 +            public <T> CompletableFuture<Void> acceptEither
709 +                (CompletableFuture<T> f,
710 +                 CompletionStage<? extends T> g,
711 +                 Consumer<? super T> a) {
712 +                return f.acceptEitherAsync(g, a);
713 +            }
714 +            public <T,U> CompletableFuture<U> applyToEither
715 +                (CompletableFuture<T> f,
716 +                 CompletionStage<? extends T> g,
717 +                 Function<? super T,U> a) {
718 +                return f.applyToEitherAsync(g, a);
719 +            }
720          },
721  
485 //         REVERSE_DEFAULT_ASYNC {
486 //             public <T,U> CompletableFuture<Void> runAfterBoth
487 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
488 //                 return f.runAfterBothAsync(g, a);
489 //             }
490 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
491 //                 (CompletableFuture<T> f,
492 //                  CompletionStage<? extends U> g,
493 //                  BiConsumer<? super T,? super U> a) {
494 //                 return DEFAULT_ASYNC.thenAcceptBoth(f, g, a);
495 //             }
496 //         },
497
722          EXECUTOR {
723 +            public void checkExecutionMode() {
724 +                assertTrue(ThreadExecutor.startedCurrentThread());
725 +            }
726 +            public CompletableFuture<Void> runAsync(Runnable a) {
727 +                return CompletableFuture.runAsync(a, new ThreadExecutor());
728 +            }
729 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
730 +                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
731 +            }
732 +            public <T> CompletableFuture<Void> thenRun
733 +                (CompletableFuture<T> f, Runnable a) {
734 +                return f.thenRunAsync(a, new ThreadExecutor());
735 +            }
736 +            public <T> CompletableFuture<Void> thenAccept
737 +                (CompletableFuture<T> f, Consumer<? super T> a) {
738 +                return f.thenAcceptAsync(a, new ThreadExecutor());
739 +            }
740 +            public <T,U> CompletableFuture<U> thenApply
741 +                (CompletableFuture<T> f, Function<? super T,U> a) {
742 +                return f.thenApplyAsync(a, new ThreadExecutor());
743 +            }
744 +            public <T,U> CompletableFuture<U> thenCompose
745 +                (CompletableFuture<T> f,
746 +                 Function<? super T,? extends CompletionStage<U>> a) {
747 +                return f.thenComposeAsync(a, new ThreadExecutor());
748 +            }
749 +            public <T,U> CompletableFuture<U> handle
750 +                (CompletableFuture<T> f,
751 +                 BiFunction<? super T,Throwable,? extends U> a) {
752 +                return f.handleAsync(a, new ThreadExecutor());
753 +            }
754 +            public <T> CompletableFuture<T> whenComplete
755 +                (CompletableFuture<T> f,
756 +                 BiConsumer<? super T,? super Throwable> a) {
757 +                return f.whenCompleteAsync(a, new ThreadExecutor());
758 +            }
759              public <T,U> CompletableFuture<Void> runAfterBoth
760                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
761                  return f.runAfterBothAsync(g, a, new ThreadExecutor());
# Line 512 | Line 772 | public class CompletableFutureTest exten
772                   BiFunction<? super T,? super U,? extends V> a) {
773                  return f.thenCombineAsync(g, a, new ThreadExecutor());
774              }
775 +            public <T> CompletableFuture<Void> runAfterEither
776 +                (CompletableFuture<T> f,
777 +                 CompletionStage<?> g,
778 +                 java.lang.Runnable a) {
779 +                return f.runAfterEitherAsync(g, a, new ThreadExecutor());
780 +            }
781 +            public <T> CompletableFuture<Void> acceptEither
782 +                (CompletableFuture<T> f,
783 +                 CompletionStage<? extends T> g,
784 +                 Consumer<? super T> a) {
785 +                return f.acceptEitherAsync(g, a, new ThreadExecutor());
786 +            }
787 +            public <T,U> CompletableFuture<U> applyToEither
788 +                (CompletableFuture<T> f,
789 +                 CompletionStage<? extends T> g,
790 +                 Function<? super T,U> a) {
791 +                return f.applyToEitherAsync(g, a, new ThreadExecutor());
792 +            }
793          };
794  
795 +        public abstract void checkExecutionMode();
796 +        public abstract CompletableFuture<Void> runAsync(Runnable a);
797 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
798 +        public abstract <T> CompletableFuture<Void> thenRun
799 +            (CompletableFuture<T> f, Runnable a);
800 +        public abstract <T> CompletableFuture<Void> thenAccept
801 +            (CompletableFuture<T> f, Consumer<? super T> a);
802 +        public abstract <T,U> CompletableFuture<U> thenApply
803 +            (CompletableFuture<T> f, Function<? super T,U> a);
804 +        public abstract <T,U> CompletableFuture<U> thenCompose
805 +            (CompletableFuture<T> f,
806 +             Function<? super T,? extends CompletionStage<U>> a);
807 +        public abstract <T,U> CompletableFuture<U> handle
808 +            (CompletableFuture<T> f,
809 +             BiFunction<? super T,Throwable,? extends U> a);
810 +        public abstract <T> CompletableFuture<T> whenComplete
811 +            (CompletableFuture<T> f,
812 +             BiConsumer<? super T,? super Throwable> a);
813          public abstract <T,U> CompletableFuture<Void> runAfterBoth
814              (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
815          public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
# Line 524 | Line 820 | public class CompletableFutureTest exten
820              (CompletableFuture<T> f,
821               CompletionStage<? extends U> g,
822               BiFunction<? super T,? super U,? extends V> a);
823 +        public abstract <T> CompletableFuture<Void> runAfterEither
824 +            (CompletableFuture<T> f,
825 +             CompletionStage<?> g,
826 +             java.lang.Runnable a);
827 +        public abstract <T> CompletableFuture<Void> acceptEither
828 +            (CompletableFuture<T> f,
829 +             CompletionStage<? extends T> g,
830 +             Consumer<? super T> a);
831 +        public abstract <T,U> CompletableFuture<U> applyToEither
832 +            (CompletableFuture<T> f,
833 +             CompletionStage<? extends T> g,
834 +             Function<? super T,U> a);
835      }
836  
837      /**
838 <     * exceptionally action completes with function value on source
839 <     * exception; otherwise with source value
838 >     * exceptionally action is not invoked when source completes
839 >     * normally, and source result is propagated
840       */
841 <    public void testExceptionally() {
842 <        CompletableFuture<Integer> f = new CompletableFuture<>();
843 <        ExceptionToInteger r = new ExceptionToInteger();
844 <        CompletableFuture<Integer> g = f.exceptionally(r);
845 <        f.completeExceptionally(new CFException());
846 <        checkCompletedNormally(g, three);
841 >    public void testExceptionally_normalCompletion() {
842 >        for (boolean createIncomplete : new boolean[] { true, false })
843 >        for (Integer v1 : new Integer[] { 1, null })
844 >    {
845 >        final AtomicInteger a = new AtomicInteger(0);
846 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
847 >        if (!createIncomplete) assertTrue(f.complete(v1));
848 >        final CompletableFuture<Integer> g = f.exceptionally
849 >            ((Throwable t) -> {
850 >                a.getAndIncrement();
851 >                threadFail("should not be called");
852 >                return null;            // unreached
853 >            });
854 >        if (createIncomplete) assertTrue(f.complete(v1));
855  
856 <        f = new CompletableFuture<>();
857 <        r = new ExceptionToInteger();
858 <        g = f.exceptionally(r);
859 <        f.complete(one);
544 <        checkCompletedNormally(g, one);
545 <    }
856 >        checkCompletedNormally(g, v1);
857 >        checkCompletedNormally(f, v1);
858 >        assertEquals(0, a.get());
859 >    }}
860  
861      /**
862 <     * handle action completes normally with function value on either
863 <     * normal or exceptional completion of source
862 >     * exceptionally action completes with function value on source
863 >     * exception
864       */
865 <    public void testHandle() {
866 <        CompletableFuture<Integer> f, g;
867 <        IntegerHandler r;
868 <
869 <        f = new CompletableFuture<>();
870 <        f.completeExceptionally(new CFException());
871 <        g = f.handle(r = new IntegerHandler());
872 <        assertTrue(r.ran);
873 <        checkCompletedNormally(g, three);
874 <
875 <        f = new CompletableFuture<>();
876 <        g = f.handle(r = new IntegerHandler());
877 <        assertFalse(r.ran);
878 <        f.completeExceptionally(new CFException());
879 <        checkCompletedNormally(g, three);
880 <        assertTrue(r.ran);
567 <
568 <        f = new CompletableFuture<>();
569 <        f.complete(one);
570 <        g = f.handle(r = new IntegerHandler());
571 <        assertTrue(r.ran);
572 <        checkCompletedNormally(g, two);
865 >    public void testExceptionally_exceptionalCompletion() {
866 >        for (boolean createIncomplete : new boolean[] { true, false })
867 >        for (Integer v1 : new Integer[] { 1, null })
868 >    {
869 >        final AtomicInteger a = new AtomicInteger(0);
870 >        final CFException ex = new CFException();
871 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
872 >        if (!createIncomplete) f.completeExceptionally(ex);
873 >        final CompletableFuture<Integer> g = f.exceptionally
874 >            ((Throwable t) -> {
875 >                ExecutionMode.SYNC.checkExecutionMode();
876 >                threadAssertSame(t, ex);
877 >                a.getAndIncrement();
878 >                return v1;
879 >            });
880 >        if (createIncomplete) f.completeExceptionally(ex);
881  
882 <        f = new CompletableFuture<>();
883 <        g = f.handle(r = new IntegerHandler());
884 <        assertFalse(r.ran);
577 <        f.complete(one);
578 <        assertTrue(r.ran);
579 <        checkCompletedNormally(g, two);
580 <    }
882 >        checkCompletedNormally(g, v1);
883 >        assertEquals(1, a.get());
884 >    }}
885  
886      /**
887 <     * runAsync completes after running Runnable
887 >     * If an "exceptionally action" throws an exception, it completes
888 >     * exceptionally with that exception
889       */
890 <    public void testRunAsync() {
891 <        Noop r = new Noop();
892 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
893 <        assertNull(f.join());
894 <        assertTrue(r.ran);
895 <        checkCompletedNormally(f, null);
896 <    }
890 >    public void testExceptionally_exceptionalCompletionActionFailed() {
891 >        for (boolean createIncomplete : new boolean[] { true, false })
892 >    {
893 >        final AtomicInteger a = new AtomicInteger(0);
894 >        final CFException ex1 = new CFException();
895 >        final CFException ex2 = new CFException();
896 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
897 >        if (!createIncomplete) f.completeExceptionally(ex1);
898 >        final CompletableFuture<Integer> g = f.exceptionally
899 >            ((Throwable t) -> {
900 >                ExecutionMode.SYNC.checkExecutionMode();
901 >                threadAssertSame(t, ex1);
902 >                a.getAndIncrement();
903 >                throw ex2;
904 >            });
905 >        if (createIncomplete) f.completeExceptionally(ex1);
906 >
907 >        checkCompletedWithWrappedException(g, ex2);
908 >        checkCompletedExceptionally(f, ex1);
909 >        assertEquals(1, a.get());
910 >    }}
911  
912      /**
913 <     * runAsync with executor completes after running Runnable
913 >     * whenComplete action executes on normal completion, propagating
914 >     * source result.
915       */
916 <    public void testRunAsync2() {
917 <        Noop r = new Noop();
918 <        ThreadExecutor exec = new ThreadExecutor();
919 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
920 <        assertNull(f.join());
921 <        assertTrue(r.ran);
922 <        checkCompletedNormally(f, null);
923 <        assertEquals(1, exec.count.get());
924 <    }
916 >    public void testWhenComplete_normalCompletion() {
917 >        for (ExecutionMode m : ExecutionMode.values())
918 >        for (boolean createIncomplete : new boolean[] { true, false })
919 >        for (Integer v1 : new Integer[] { 1, null })
920 >    {
921 >        final AtomicInteger a = new AtomicInteger(0);
922 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
923 >        if (!createIncomplete) assertTrue(f.complete(v1));
924 >        final CompletableFuture<Integer> g = m.whenComplete
925 >            (f,
926 >             (Integer result, Throwable t) -> {
927 >                m.checkExecutionMode();
928 >                threadAssertSame(result, v1);
929 >                threadAssertNull(t);
930 >                a.getAndIncrement();
931 >            });
932 >        if (createIncomplete) assertTrue(f.complete(v1));
933  
934 <    /**
935 <     * failing runAsync completes exceptionally after running Runnable
936 <     */
937 <    public void testRunAsync3() {
610 <        FailingNoop r = new FailingNoop();
611 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
612 <        checkCompletedWithWrappedCFException(f);
613 <        assertTrue(r.ran);
614 <    }
934 >        checkCompletedNormally(g, v1);
935 >        checkCompletedNormally(f, v1);
936 >        assertEquals(1, a.get());
937 >    }}
938  
939      /**
940 <     * supplyAsync completes with result of supplier
940 >     * whenComplete action executes on exceptional completion, propagating
941 >     * source result.
942       */
943 <    public void testSupplyAsync() {
944 <        CompletableFuture<Integer> f;
945 <        f = CompletableFuture.supplyAsync(supplyOne);
946 <        assertEquals(f.join(), one);
947 <        checkCompletedNormally(f, one);
948 <    }
943 >    public void testWhenComplete_exceptionalCompletion() {
944 >        for (ExecutionMode m : ExecutionMode.values())
945 >        for (boolean createIncomplete : new boolean[] { true, false })
946 >    {
947 >        final AtomicInteger a = new AtomicInteger(0);
948 >        final CFException ex = new CFException();
949 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
950 >        if (!createIncomplete) f.completeExceptionally(ex);
951 >        final CompletableFuture<Integer> g = m.whenComplete
952 >            (f,
953 >             (Integer result, Throwable t) -> {
954 >                m.checkExecutionMode();
955 >                threadAssertNull(result);
956 >                threadAssertSame(t, ex);
957 >                a.getAndIncrement();
958 >            });
959 >        if (createIncomplete) f.completeExceptionally(ex);
960 >
961 >        checkCompletedWithWrappedException(g, ex);
962 >        checkCompletedExceptionally(f, ex);
963 >        assertEquals(1, a.get());
964 >    }}
965  
966      /**
967 <     * supplyAsync with executor completes with result of supplier
967 >     * whenComplete action executes on cancelled source, propagating
968 >     * CancellationException.
969       */
970 <    public void testSupplyAsync2() {
971 <        CompletableFuture<Integer> f;
972 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
973 <        assertEquals(f.join(), one);
974 <        checkCompletedNormally(f, one);
975 <    }
970 >    public void testWhenComplete_sourceCancelled() {
971 >        for (ExecutionMode m : ExecutionMode.values())
972 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
973 >        for (boolean createIncomplete : new boolean[] { true, false })
974 >    {
975 >        final AtomicInteger a = new AtomicInteger(0);
976 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
977 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
978 >        final CompletableFuture<Integer> g = m.whenComplete
979 >            (f,
980 >             (Integer result, Throwable t) -> {
981 >                m.checkExecutionMode();
982 >                threadAssertNull(result);
983 >                threadAssertTrue(t instanceof CancellationException);
984 >                a.getAndIncrement();
985 >            });
986 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
987 >
988 >        checkCompletedWithWrappedCancellationException(g);
989 >        checkCancelled(f);
990 >        assertEquals(1, a.get());
991 >    }}
992  
993      /**
994 <     * Failing supplyAsync completes exceptionally
994 >     * If a whenComplete action throws an exception when triggered by
995 >     * a normal completion, it completes exceptionally
996       */
997 <    public void testSupplyAsync3() {
998 <        FailingSupplier r = new FailingSupplier();
999 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1000 <        checkCompletedWithWrappedCFException(f);
1001 <        assertTrue(r.ran);
1002 <    }
997 >    public void testWhenComplete_sourceCompletedNormallyActionFailed() {
998 >        for (boolean createIncomplete : new boolean[] { true, false })
999 >        for (ExecutionMode m : ExecutionMode.values())
1000 >        for (Integer v1 : new Integer[] { 1, null })
1001 >    {
1002 >        final AtomicInteger a = new AtomicInteger(0);
1003 >        final CFException ex = new CFException();
1004 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1005 >        if (!createIncomplete) assertTrue(f.complete(v1));
1006 >        final CompletableFuture<Integer> g = m.whenComplete
1007 >            (f,
1008 >             (Integer result, Throwable t) -> {
1009 >                m.checkExecutionMode();
1010 >                threadAssertSame(result, v1);
1011 >                threadAssertNull(t);
1012 >                a.getAndIncrement();
1013 >                throw ex;
1014 >            });
1015 >        if (createIncomplete) assertTrue(f.complete(v1));
1016  
1017 <    // seq completion methods
1017 >        checkCompletedWithWrappedException(g, ex);
1018 >        checkCompletedNormally(f, v1);
1019 >        assertEquals(1, a.get());
1020 >    }}
1021  
1022      /**
1023 <     * thenRun result completes normally after normal completion of source
1023 >     * If a whenComplete action throws an exception when triggered by
1024 >     * a source completion that also throws an exception, the source
1025 >     * exception takes precedence (unlike handle)
1026       */
1027 <    public void testThenRun() {
1028 <        CompletableFuture<Integer> f;
1029 <        CompletableFuture<Void> g;
1030 <        Noop r;
1031 <
1032 <        f = new CompletableFuture<>();
1033 <        g = f.thenRun(r = new Noop());
1034 <        f.complete(null);
1035 <        checkCompletedNormally(g, null);
1036 <        assertTrue(r.ran);
1037 <
1038 <        f = new CompletableFuture<>();
1039 <        f.complete(null);
1040 <        g = f.thenRun(r = new Noop());
1041 <        checkCompletedNormally(g, null);
1042 <        assertTrue(r.ran);
1043 <    }
1027 >    public void testWhenComplete_sourceFailedActionFailed() {
1028 >        for (boolean createIncomplete : new boolean[] { true, false })
1029 >        for (ExecutionMode m : ExecutionMode.values())
1030 >    {
1031 >        final AtomicInteger a = new AtomicInteger(0);
1032 >        final CFException ex1 = new CFException();
1033 >        final CFException ex2 = new CFException();
1034 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1035 >
1036 >        if (!createIncomplete) f.completeExceptionally(ex1);
1037 >        final CompletableFuture<Integer> g = m.whenComplete
1038 >            (f,
1039 >             (Integer result, Throwable t) -> {
1040 >                m.checkExecutionMode();
1041 >                threadAssertSame(t, ex1);
1042 >                threadAssertNull(result);
1043 >                a.getAndIncrement();
1044 >                throw ex2;
1045 >            });
1046 >        if (createIncomplete) f.completeExceptionally(ex1);
1047 >
1048 >        checkCompletedWithWrappedException(g, ex1);
1049 >        checkCompletedExceptionally(f, ex1);
1050 >        if (testImplementationDetails) {
1051 >            assertEquals(1, ex1.getSuppressed().length);
1052 >            assertSame(ex2, ex1.getSuppressed()[0]);
1053 >        }
1054 >        assertEquals(1, a.get());
1055 >    }}
1056  
1057      /**
1058 <     * thenRun result completes exceptionally after exceptional
1058 >     * handle action completes normally with function value on normal
1059       * completion of source
1060       */
1061 <    public void testThenRun2() {
1062 <        CompletableFuture<Integer> f;
1063 <        CompletableFuture<Void> g;
1064 <        Noop r;
1065 <
1066 <        f = new CompletableFuture<>();
1067 <        g = f.thenRun(r = new Noop());
1068 <        f.completeExceptionally(new CFException());
1069 <        checkCompletedWithWrappedCFException(g);
1070 <        assertFalse(r.ran);
1061 >    public void testHandle_normalCompletion() {
1062 >        for (ExecutionMode m : ExecutionMode.values())
1063 >        for (boolean createIncomplete : new boolean[] { true, false })
1064 >        for (Integer v1 : new Integer[] { 1, null })
1065 >    {
1066 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1067 >        final AtomicInteger a = new AtomicInteger(0);
1068 >        if (!createIncomplete) assertTrue(f.complete(v1));
1069 >        final CompletableFuture<Integer> g = m.handle
1070 >            (f,
1071 >             (Integer result, Throwable t) -> {
1072 >                m.checkExecutionMode();
1073 >                threadAssertSame(result, v1);
1074 >                threadAssertNull(t);
1075 >                a.getAndIncrement();
1076 >                return inc(v1);
1077 >            });
1078 >        if (createIncomplete) assertTrue(f.complete(v1));
1079  
1080 <        f = new CompletableFuture<>();
1081 <        f.completeExceptionally(new CFException());
1082 <        g = f.thenRun(r = new Noop());
1083 <        checkCompletedWithWrappedCFException(g);
688 <        assertFalse(r.ran);
689 <    }
1080 >        checkCompletedNormally(g, inc(v1));
1081 >        checkCompletedNormally(f, v1);
1082 >        assertEquals(1, a.get());
1083 >    }}
1084  
1085      /**
1086 <     * thenRun result completes exceptionally if action does
1086 >     * handle action completes normally with function value on
1087 >     * exceptional completion of source
1088       */
1089 <    public void testThenRun3() {
1090 <        CompletableFuture<Integer> f;
1091 <        CompletableFuture<Void> g;
1092 <        FailingNoop r;
1093 <
1094 <        f = new CompletableFuture<>();
1095 <        g = f.thenRun(r = new FailingNoop());
1096 <        f.complete(null);
1097 <        checkCompletedWithWrappedCFException(g);
1089 >    public void testHandle_exceptionalCompletion() {
1090 >        for (ExecutionMode m : ExecutionMode.values())
1091 >        for (boolean createIncomplete : new boolean[] { true, false })
1092 >        for (Integer v1 : new Integer[] { 1, null })
1093 >    {
1094 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1095 >        final AtomicInteger a = new AtomicInteger(0);
1096 >        final CFException ex = new CFException();
1097 >        if (!createIncomplete) f.completeExceptionally(ex);
1098 >        final CompletableFuture<Integer> g = m.handle
1099 >            (f,
1100 >             (Integer result, Throwable t) -> {
1101 >                m.checkExecutionMode();
1102 >                threadAssertNull(result);
1103 >                threadAssertSame(t, ex);
1104 >                a.getAndIncrement();
1105 >                return v1;
1106 >            });
1107 >        if (createIncomplete) f.completeExceptionally(ex);
1108  
1109 <        f = new CompletableFuture<>();
1110 <        f.complete(null);
1111 <        g = f.thenRun(r = new FailingNoop());
1112 <        checkCompletedWithWrappedCFException(g);
708 <    }
1109 >        checkCompletedNormally(g, v1);
1110 >        checkCompletedExceptionally(f, ex);
1111 >        assertEquals(1, a.get());
1112 >    }}
1113  
1114      /**
1115 <     * thenRun result completes exceptionally if source cancelled
1115 >     * handle action completes normally with function value on
1116 >     * cancelled source
1117       */
1118 <    public void testThenRun4() {
1119 <        CompletableFuture<Integer> f;
1120 <        CompletableFuture<Void> g;
1121 <        Noop r;
1122 <
1123 <        f = new CompletableFuture<>();
1124 <        g = f.thenRun(r = new Noop());
1125 <        assertTrue(f.cancel(true));
1126 <        checkCompletedWithWrappedCancellationException(g);
1118 >    public void testHandle_sourceCancelled() {
1119 >        for (ExecutionMode m : ExecutionMode.values())
1120 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1121 >        for (boolean createIncomplete : new boolean[] { true, false })
1122 >        for (Integer v1 : new Integer[] { 1, null })
1123 >    {
1124 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1125 >        final AtomicInteger a = new AtomicInteger(0);
1126 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1127 >        final CompletableFuture<Integer> g = m.handle
1128 >            (f,
1129 >             (Integer result, Throwable t) -> {
1130 >                m.checkExecutionMode();
1131 >                threadAssertNull(result);
1132 >                threadAssertTrue(t instanceof CancellationException);
1133 >                a.getAndIncrement();
1134 >                return v1;
1135 >            });
1136 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1137  
1138 <        f = new CompletableFuture<>();
1139 <        assertTrue(f.cancel(true));
1140 <        g = f.thenRun(r = new Noop());
1141 <        checkCompletedWithWrappedCancellationException(g);
727 <    }
1138 >        checkCompletedNormally(g, v1);
1139 >        checkCancelled(f);
1140 >        assertEquals(1, a.get());
1141 >    }}
1142  
1143      /**
1144 <     * thenApply result completes normally after normal completion of source
1144 >     * If a "handle action" throws an exception when triggered by
1145 >     * a normal completion, it completes exceptionally
1146       */
1147 <    public void testThenApply() {
1148 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1149 <        CompletableFuture<Integer> g = f.thenApply(inc);
1150 <        f.complete(one);
1151 <        checkCompletedNormally(g, two);
1152 <    }
1147 >    public void testHandle_sourceCompletedNormallyActionFailed() {
1148 >        for (ExecutionMode m : ExecutionMode.values())
1149 >        for (boolean createIncomplete : new boolean[] { true, false })
1150 >        for (Integer v1 : new Integer[] { 1, null })
1151 >    {
1152 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1153 >        final AtomicInteger a = new AtomicInteger(0);
1154 >        final CFException ex = new CFException();
1155 >        if (!createIncomplete) assertTrue(f.complete(v1));
1156 >        final CompletableFuture<Integer> g = m.handle
1157 >            (f,
1158 >             (Integer result, Throwable t) -> {
1159 >                m.checkExecutionMode();
1160 >                threadAssertSame(result, v1);
1161 >                threadAssertNull(t);
1162 >                a.getAndIncrement();
1163 >                throw ex;
1164 >            });
1165 >        if (createIncomplete) assertTrue(f.complete(v1));
1166 >
1167 >        checkCompletedWithWrappedException(g, ex);
1168 >        checkCompletedNormally(f, v1);
1169 >        assertEquals(1, a.get());
1170 >    }}
1171 >
1172 >    /**
1173 >     * If a "handle action" throws an exception when triggered by
1174 >     * a source completion that also throws an exception, the action
1175 >     * exception takes precedence (unlike whenComplete)
1176 >     */
1177 >    public void testHandle_sourceFailedActionFailed() {
1178 >        for (boolean createIncomplete : new boolean[] { true, false })
1179 >        for (ExecutionMode m : ExecutionMode.values())
1180 >    {
1181 >        final AtomicInteger a = new AtomicInteger(0);
1182 >        final CFException ex1 = new CFException();
1183 >        final CFException ex2 = new CFException();
1184 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1185 >
1186 >        if (!createIncomplete) f.completeExceptionally(ex1);
1187 >        final CompletableFuture<Integer> g = m.handle
1188 >            (f,
1189 >             (Integer result, Throwable t) -> {
1190 >                m.checkExecutionMode();
1191 >                threadAssertNull(result);
1192 >                threadAssertSame(ex1, t);
1193 >                a.getAndIncrement();
1194 >                throw ex2;
1195 >            });
1196 >        if (createIncomplete) f.completeExceptionally(ex1);
1197 >
1198 >        checkCompletedWithWrappedException(g, ex2);
1199 >        checkCompletedExceptionally(f, ex1);
1200 >        assertEquals(1, a.get());
1201 >    }}
1202  
1203      /**
1204 <     * thenApply result completes exceptionally after exceptional
741 <     * completion of source
1204 >     * runAsync completes after running Runnable
1205       */
1206 <    public void testThenApply2() {
1207 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1208 <        CompletableFuture<Integer> g = f.thenApply(inc);
1209 <        f.completeExceptionally(new CFException());
1210 <        checkCompletedWithWrappedCFException(g);
1211 <    }
1206 >    public void testRunAsync_normalCompletion() {
1207 >        ExecutionMode[] executionModes = {
1208 >            ExecutionMode.ASYNC,
1209 >            ExecutionMode.EXECUTOR,
1210 >        };
1211 >        for (ExecutionMode m : executionModes)
1212 >    {
1213 >        final Noop r = new Noop(m);
1214 >        final CompletableFuture<Void> f = m.runAsync(r);
1215 >        assertNull(f.join());
1216 >        checkCompletedNormally(f, null);
1217 >        r.assertInvoked();
1218 >    }}
1219  
1220      /**
1221 <     * thenApply result completes exceptionally if action does
1221 >     * failing runAsync completes exceptionally after running Runnable
1222       */
1223 <    public void testThenApply3() {
1224 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1225 <        CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
1226 <        f.complete(one);
1227 <        checkCompletedWithWrappedCFException(g);
1228 <    }
1223 >    public void testRunAsync_exceptionalCompletion() {
1224 >        ExecutionMode[] executionModes = {
1225 >            ExecutionMode.ASYNC,
1226 >            ExecutionMode.EXECUTOR,
1227 >        };
1228 >        for (ExecutionMode m : executionModes)
1229 >    {
1230 >        final FailingRunnable r = new FailingRunnable(m);
1231 >        final CompletableFuture<Void> f = m.runAsync(r);
1232 >        checkCompletedWithWrappedException(f, r.ex);
1233 >        r.assertInvoked();
1234 >    }}
1235  
1236      /**
1237 <     * thenApply result completes exceptionally if source cancelled
1237 >     * supplyAsync completes with result of supplier
1238       */
1239 <    public void testThenApply4() {
1240 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1241 <        CompletableFuture<Integer> g = f.thenApply(inc);
1242 <        assertTrue(f.cancel(true));
1243 <        checkCompletedWithWrappedCancellationException(g);
1244 <    }
1239 >    public void testSupplyAsync_normalCompletion() {
1240 >        ExecutionMode[] executionModes = {
1241 >            ExecutionMode.ASYNC,
1242 >            ExecutionMode.EXECUTOR,
1243 >        };
1244 >        for (ExecutionMode m : executionModes)
1245 >        for (Integer v1 : new Integer[] { 1, null })
1246 >    {
1247 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1248 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1249 >        assertSame(v1, f.join());
1250 >        checkCompletedNormally(f, v1);
1251 >        r.assertInvoked();
1252 >    }}
1253  
1254      /**
1255 <     * thenAccept result completes normally after normal completion of source
1255 >     * Failing supplyAsync completes exceptionally
1256       */
1257 <    public void testThenAccept() {
1258 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1259 <        IncAction r = new IncAction();
1260 <        CompletableFuture<Void> g = f.thenAccept(r);
1261 <        f.complete(one);
1262 <        checkCompletedNormally(g, null);
1263 <        assertEquals(r.value, 2);
1264 <    }
1257 >    public void testSupplyAsync_exceptionalCompletion() {
1258 >        ExecutionMode[] executionModes = {
1259 >            ExecutionMode.ASYNC,
1260 >            ExecutionMode.EXECUTOR,
1261 >        };
1262 >        for (ExecutionMode m : executionModes)
1263 >    {
1264 >        FailingSupplier r = new FailingSupplier(m);
1265 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1266 >        checkCompletedWithWrappedException(f, r.ex);
1267 >        r.assertInvoked();
1268 >    }}
1269  
1270 <    /**
783 <     * thenAccept result completes exceptionally after exceptional
784 <     * completion of source
785 <     */
786 <    public void testThenAccept2() {
787 <        CompletableFuture<Integer> f = new CompletableFuture<>();
788 <        IncAction r = new IncAction();
789 <        CompletableFuture<Void> g = f.thenAccept(r);
790 <        f.completeExceptionally(new CFException());
791 <        checkCompletedWithWrappedCFException(g);
792 <    }
1270 >    // seq completion methods
1271  
1272      /**
1273 <     * thenAccept result completes exceptionally if action does
1273 >     * thenRun result completes normally after normal completion of source
1274       */
1275 <    public void testThenAccept3() {
1276 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1277 <        FailingConsumer r = new FailingConsumer();
1278 <        CompletableFuture<Void> g = f.thenAccept(r);
1279 <        f.complete(one);
1280 <        checkCompletedWithWrappedCFException(g);
1281 <        assertTrue(r.ran);
804 <    }
1275 >    public void testThenRun_normalCompletion() {
1276 >        for (ExecutionMode m : ExecutionMode.values())
1277 >        for (Integer v1 : new Integer[] { 1, null })
1278 >    {
1279 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1280 >        final Noop[] rs = new Noop[6];
1281 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
1282  
1283 <    /**
1284 <     * thenAccept result completes exceptionally if source cancelled
1285 <     */
1286 <    public void testThenAccept4() {
1287 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1288 <        IncAction r = new IncAction();
1289 <        CompletableFuture<Void> g = f.thenAccept(r);
1290 <        assertTrue(f.cancel(true));
1291 <        checkCompletedWithWrappedCancellationException(g);
1292 <    }
1283 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1284 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1285 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1286 >        checkIncomplete(h0);
1287 >        checkIncomplete(h1);
1288 >        checkIncomplete(h2);
1289 >        assertTrue(f.complete(v1));
1290 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1291 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1292 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1293 >
1294 >        checkCompletedNormally(h0, null);
1295 >        checkCompletedNormally(h1, null);
1296 >        checkCompletedNormally(h2, null);
1297 >        checkCompletedNormally(h3, null);
1298 >        checkCompletedNormally(h4, null);
1299 >        checkCompletedNormally(h5, null);
1300 >        checkCompletedNormally(f, v1);
1301 >        for (Noop r : rs) r.assertInvoked();
1302 >    }}
1303  
1304      /**
1305 <     * thenCombine result completes normally after normal completion
1306 <     * of sources
1305 >     * thenRun result completes exceptionally after exceptional
1306 >     * completion of source
1307       */
1308 <    public void testThenCombine_normalCompletion1() {
1308 >    public void testThenRun_exceptionalCompletion() {
1309          for (ExecutionMode m : ExecutionMode.values())
1310 <        for (Integer v1 : new Integer[] { 1, null })
1311 <        for (Integer v2 : new Integer[] { 2, null }) {
825 <
1310 >    {
1311 >        final CFException ex = new CFException();
1312          final CompletableFuture<Integer> f = new CompletableFuture<>();
1313 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1314 <        final SubtractFunction r = new SubtractFunction();
829 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1313 >        final Noop[] rs = new Noop[6];
1314 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
1315  
1316 <        f.complete(v1);
1317 <        checkIncomplete(h);
1318 <        assertFalse(r.ran());
1319 <        g.complete(v2);
1320 <
1321 <        checkCompletedNormally(h, subtract(v1, v2));
1322 <        checkCompletedNormally(f, v1);
1323 <        checkCompletedNormally(g, v2);
1324 <        }
1325 <    }
1316 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1317 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1318 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1319 >        checkIncomplete(h0);
1320 >        checkIncomplete(h1);
1321 >        checkIncomplete(h2);
1322 >        assertTrue(f.completeExceptionally(ex));
1323 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1324 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1325 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1326 >
1327 >        checkCompletedWithWrappedException(h0, ex);
1328 >        checkCompletedWithWrappedException(h1, ex);
1329 >        checkCompletedWithWrappedException(h2, ex);
1330 >        checkCompletedWithWrappedException(h3, ex);
1331 >        checkCompletedWithWrappedException(h4, ex);
1332 >        checkCompletedWithWrappedException(h5, ex);
1333 >        checkCompletedExceptionally(f, ex);
1334 >        for (Noop r : rs) r.assertNotInvoked();
1335 >    }}
1336  
1337 <    public void testThenCombine_normalCompletion2() {
1337 >    /**
1338 >     * thenRun result completes exceptionally if source cancelled
1339 >     */
1340 >    public void testThenRun_sourceCancelled() {
1341          for (ExecutionMode m : ExecutionMode.values())
1342 <        for (Integer v1 : new Integer[] { 1, null })
1343 <        for (Integer v2 : new Integer[] { 2, null }) {
846 <
1342 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1343 >    {
1344          final CompletableFuture<Integer> f = new CompletableFuture<>();
1345 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1346 <        final SubtractFunction r = new SubtractFunction();
850 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
851 <
852 <        g.complete(v2);
853 <        checkIncomplete(h);
854 <        assertFalse(r.ran());
855 <        f.complete(v1);
1345 >        final Noop[] rs = new Noop[6];
1346 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
1347  
1348 <        checkCompletedNormally(h, subtract(v1, v2));
1349 <        checkCompletedNormally(f, v1);
1350 <        checkCompletedNormally(g, v2);
1351 <        }
1352 <    }
1348 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1349 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1350 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1351 >        checkIncomplete(h0);
1352 >        checkIncomplete(h1);
1353 >        checkIncomplete(h2);
1354 >        assertTrue(f.cancel(mayInterruptIfRunning));
1355 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1356 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1357 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1358 >
1359 >        checkCompletedWithWrappedCancellationException(h0);
1360 >        checkCompletedWithWrappedCancellationException(h1);
1361 >        checkCompletedWithWrappedCancellationException(h2);
1362 >        checkCompletedWithWrappedCancellationException(h3);
1363 >        checkCompletedWithWrappedCancellationException(h4);
1364 >        checkCompletedWithWrappedCancellationException(h5);
1365 >        checkCancelled(f);
1366 >        for (Noop r : rs) r.assertNotInvoked();
1367 >    }}
1368  
1369 <    public void testThenCombine_normalCompletion3() {
1369 >    /**
1370 >     * thenRun result completes exceptionally if action does
1371 >     */
1372 >    public void testThenRun_actionFailed() {
1373          for (ExecutionMode m : ExecutionMode.values())
1374          for (Integer v1 : new Integer[] { 1, null })
1375 <        for (Integer v2 : new Integer[] { 2, null }) {
867 <
1375 >    {
1376          final CompletableFuture<Integer> f = new CompletableFuture<>();
1377 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1378 <        final SubtractFunction r = new SubtractFunction();
871 <
872 <        g.complete(v2);
873 <        f.complete(v1);
874 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1377 >        final FailingRunnable[] rs = new FailingRunnable[6];
1378 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
1379  
1380 <        checkCompletedNormally(h, subtract(v1, v2));
1380 >        final CompletableFuture<Void> h0 = m.thenRun(f, rs[0]);
1381 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, f, rs[1]);
1382 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, f, rs[2]);
1383 >        assertTrue(f.complete(v1));
1384 >        final CompletableFuture<Void> h3 = m.thenRun(f, rs[3]);
1385 >        final CompletableFuture<Void> h4 = m.runAfterBoth(f, f, rs[4]);
1386 >        final CompletableFuture<Void> h5 = m.runAfterEither(f, f, rs[5]);
1387 >
1388 >        checkCompletedWithWrappedException(h0, rs[0].ex);
1389 >        checkCompletedWithWrappedException(h1, rs[1].ex);
1390 >        checkCompletedWithWrappedException(h2, rs[2].ex);
1391 >        checkCompletedWithWrappedException(h3, rs[3].ex);
1392 >        checkCompletedWithWrappedException(h4, rs[4].ex);
1393 >        checkCompletedWithWrappedException(h5, rs[5].ex);
1394          checkCompletedNormally(f, v1);
1395 <        checkCompletedNormally(g, v2);
879 <        }
880 <    }
1395 >    }}
1396  
1397 <    public void testThenCombine_normalCompletion4() {
1397 >    /**
1398 >     * thenApply result completes normally after normal completion of source
1399 >     */
1400 >    public void testThenApply_normalCompletion() {
1401          for (ExecutionMode m : ExecutionMode.values())
1402          for (Integer v1 : new Integer[] { 1, null })
1403 <        for (Integer v2 : new Integer[] { 2, null }) {
886 <
1403 >    {
1404          final CompletableFuture<Integer> f = new CompletableFuture<>();
1405 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1406 <        final SubtractFunction r = new SubtractFunction();
890 <
891 <        f.complete(v1);
892 <        g.complete(v2);
893 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1405 >        final IncFunction[] rs = new IncFunction[4];
1406 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1407  
1408 <        checkCompletedNormally(h, subtract(v1, v2));
1408 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1409 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1410 >        checkIncomplete(h0);
1411 >        checkIncomplete(h1);
1412 >        assertTrue(f.complete(v1));
1413 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1414 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1415 >
1416 >        checkCompletedNormally(h0, inc(v1));
1417 >        checkCompletedNormally(h1, inc(v1));
1418 >        checkCompletedNormally(h2, inc(v1));
1419 >        checkCompletedNormally(h3, inc(v1));
1420          checkCompletedNormally(f, v1);
1421 <        checkCompletedNormally(g, v2);
1422 <        }
899 <    }
1421 >        for (IncFunction r : rs) r.assertValue(inc(v1));
1422 >    }}
1423  
1424      /**
1425 <     * thenCombine result completes exceptionally after exceptional
1426 <     * completion of either source
1425 >     * thenApply result completes exceptionally after exceptional
1426 >     * completion of source
1427       */
1428 <    public void testThenCombine_exceptionalCompletion1() {
1428 >    public void testThenApply_exceptionalCompletion() {
1429          for (ExecutionMode m : ExecutionMode.values())
1430 <        for (Integer v1 : new Integer[] { 1, null }) {
908 <
909 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
910 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
911 <        final SubtractFunction r = new SubtractFunction();
912 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1430 >    {
1431          final CFException ex = new CFException();
914
915        f.completeExceptionally(ex);
916        checkIncomplete(h);
917        g.complete(v1);
918
919        checkCompletedWithWrappedCFException(h, ex);
920        checkCompletedWithWrappedCFException(f, ex);
921        assertFalse(r.ran());
922        checkCompletedNormally(g, v1);
923        }
924    }
925
926    public void testThenCombine_exceptionalCompletion2() {
927        for (ExecutionMode m : ExecutionMode.values())
928        for (Integer v1 : new Integer[] { 1, null }) {
929
1432          final CompletableFuture<Integer> f = new CompletableFuture<>();
1433 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1434 <        final SubtractFunction r = new SubtractFunction();
933 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, subtract);
934 <        final CFException ex = new CFException();
1433 >        final IncFunction[] rs = new IncFunction[4];
1434 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1435  
1436 <        g.completeExceptionally(ex);
1437 <        checkIncomplete(h);
1438 <        f.complete(v1);
1439 <
1440 <        checkCompletedWithWrappedCFException(h, ex);
1441 <        checkCompletedWithWrappedCFException(g, ex);
1442 <        assertFalse(r.ran());
1443 <        checkCompletedNormally(f, v1);
1444 <        }
1445 <    }
1436 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1437 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1438 >        assertTrue(f.completeExceptionally(ex));
1439 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1440 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1441 >
1442 >        checkCompletedWithWrappedException(h0, ex);
1443 >        checkCompletedWithWrappedException(h1, ex);
1444 >        checkCompletedWithWrappedException(h2, ex);
1445 >        checkCompletedWithWrappedException(h3, ex);
1446 >        checkCompletedExceptionally(f, ex);
1447 >        for (IncFunction r : rs) r.assertNotInvoked();
1448 >    }}
1449  
1450 <    public void testThenCombine_exceptionalCompletion3() {
1450 >    /**
1451 >     * thenApply result completes exceptionally if source cancelled
1452 >     */
1453 >    public void testThenApply_sourceCancelled() {
1454          for (ExecutionMode m : ExecutionMode.values())
1455 <        for (Integer v1 : new Integer[] { 1, null }) {
1456 <
1455 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1456 >    {
1457          final CompletableFuture<Integer> f = new CompletableFuture<>();
1458 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1459 <        final SubtractFunction r = new SubtractFunction();
954 <        final CFException ex = new CFException();
1458 >        final IncFunction[] rs = new IncFunction[4];
1459 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1460  
1461 <        g.completeExceptionally(ex);
1462 <        f.complete(v1);
1463 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1461 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1462 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1463 >        assertTrue(f.cancel(mayInterruptIfRunning));
1464 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1465 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1466  
1467 <        checkCompletedWithWrappedCFException(h, ex);
1468 <        checkCompletedWithWrappedCFException(g, ex);
1469 <        assertFalse(r.ran());
1470 <        checkCompletedNormally(f, v1);
1471 <        }
1472 <    }
1467 >        checkCompletedWithWrappedCancellationException(h0);
1468 >        checkCompletedWithWrappedCancellationException(h1);
1469 >        checkCompletedWithWrappedCancellationException(h2);
1470 >        checkCompletedWithWrappedCancellationException(h3);
1471 >        checkCancelled(f);
1472 >        for (IncFunction r : rs) r.assertNotInvoked();
1473 >    }}
1474  
1475 <    public void testThenCombine_exceptionalCompletion4() {
1475 >    /**
1476 >     * thenApply result completes exceptionally if action does
1477 >     */
1478 >    public void testThenApply_actionFailed() {
1479          for (ExecutionMode m : ExecutionMode.values())
1480 <        for (Integer v1 : new Integer[] { 1, null }) {
1481 <
1480 >        for (Integer v1 : new Integer[] { 1, null })
1481 >    {
1482          final CompletableFuture<Integer> f = new CompletableFuture<>();
1483 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1484 <        final SubtractFunction r = new SubtractFunction();
974 <        final CFException ex = new CFException();
1483 >        final FailingFunction[] rs = new FailingFunction[4];
1484 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
1485  
1486 <        f.completeExceptionally(ex);
1487 <        g.complete(v1);
1488 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, subtract);
1489 <
1490 <        checkCompletedWithWrappedCFException(h, ex);
1491 <        checkCompletedWithWrappedCFException(f, ex);
1492 <        assertFalse(r.ran());
1493 <        checkCompletedNormally(g, v1);
1494 <        }
1495 <    }
1486 >        final CompletableFuture<Integer> h0 = m.thenApply(f, rs[0]);
1487 >        final CompletableFuture<Integer> h1 = m.applyToEither(f, f, rs[1]);
1488 >        assertTrue(f.complete(v1));
1489 >        final CompletableFuture<Integer> h2 = m.thenApply(f, rs[2]);
1490 >        final CompletableFuture<Integer> h3 = m.applyToEither(f, f, rs[3]);
1491 >
1492 >        checkCompletedWithWrappedException(h0, rs[0].ex);
1493 >        checkCompletedWithWrappedException(h1, rs[1].ex);
1494 >        checkCompletedWithWrappedException(h2, rs[2].ex);
1495 >        checkCompletedWithWrappedException(h3, rs[3].ex);
1496 >        checkCompletedNormally(f, v1);
1497 >    }}
1498  
1499      /**
1500 <     * thenCombine result completes exceptionally if action does
1500 >     * thenAccept result completes normally after normal completion of source
1501       */
1502 <    public void testThenCombine_actionFailed1() {
1502 >    public void testThenAccept_normalCompletion() {
1503          for (ExecutionMode m : ExecutionMode.values())
1504          for (Integer v1 : new Integer[] { 1, null })
1505 <        for (Integer v2 : new Integer[] { 2, null }) {
994 <
1505 >    {
1506          final CompletableFuture<Integer> f = new CompletableFuture<>();
1507 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1508 <        final FailingBiFunction r = new FailingBiFunction();
998 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1507 >        final NoopConsumer[] rs = new NoopConsumer[4];
1508 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
1509  
1510 <        f.complete(v1);
1511 <        checkIncomplete(h);
1512 <        g.complete(v2);
1513 <
1514 <        checkCompletedWithWrappedCFException(h);
1510 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1511 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1512 >        checkIncomplete(h0);
1513 >        checkIncomplete(h1);
1514 >        assertTrue(f.complete(v1));
1515 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1516 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1517 >
1518 >        checkCompletedNormally(h0, null);
1519 >        checkCompletedNormally(h1, null);
1520 >        checkCompletedNormally(h2, null);
1521 >        checkCompletedNormally(h3, null);
1522          checkCompletedNormally(f, v1);
1523 <        checkCompletedNormally(g, v2);
1524 <        }
1008 <    }
1523 >        for (NoopConsumer r : rs) r.assertValue(v1);
1524 >    }}
1525  
1526 <    public void testThenCombine_actionFailed2() {
1526 >    /**
1527 >     * thenAccept result completes exceptionally after exceptional
1528 >     * completion of source
1529 >     */
1530 >    public void testThenAccept_exceptionalCompletion() {
1531          for (ExecutionMode m : ExecutionMode.values())
1532 <        for (Integer v1 : new Integer[] { 1, null })
1533 <        for (Integer v2 : new Integer[] { 2, null }) {
1014 <
1532 >    {
1533 >        final CFException ex = new CFException();
1534          final CompletableFuture<Integer> f = new CompletableFuture<>();
1535 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1536 <        final FailingBiFunction r = new FailingBiFunction();
1018 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1535 >        final NoopConsumer[] rs = new NoopConsumer[4];
1536 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
1537  
1538 <        g.complete(v2);
1539 <        checkIncomplete(h);
1540 <        f.complete(v1);
1541 <
1542 <        checkCompletedWithWrappedCFException(h);
1543 <        checkCompletedNormally(f, v1);
1544 <        checkCompletedNormally(g, v2);
1545 <        }
1546 <    }
1538 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1539 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1540 >        assertTrue(f.completeExceptionally(ex));
1541 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1542 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1543 >
1544 >        checkCompletedWithWrappedException(h0, ex);
1545 >        checkCompletedWithWrappedException(h1, ex);
1546 >        checkCompletedWithWrappedException(h2, ex);
1547 >        checkCompletedWithWrappedException(h3, ex);
1548 >        checkCompletedExceptionally(f, ex);
1549 >        for (NoopConsumer r : rs) r.assertNotInvoked();
1550 >    }}
1551  
1552      /**
1553 <     * thenCombine result completes exceptionally if either source cancelled
1553 >     * thenAccept result completes exceptionally if source cancelled
1554       */
1555 <    public void testThenCombine_sourceCancelled1() {
1555 >    public void testThenAccept_sourceCancelled() {
1556          for (ExecutionMode m : ExecutionMode.values())
1557          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1558 <        for (Integer v1 : new Integer[] { 1, null }) {
1037 <
1558 >    {
1559          final CompletableFuture<Integer> f = new CompletableFuture<>();
1560 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1561 <        final SubtractFunction r = new SubtractFunction();
1041 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1560 >        final NoopConsumer[] rs = new NoopConsumer[4];
1561 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
1562  
1563 +        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1564 +        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1565          assertTrue(f.cancel(mayInterruptIfRunning));
1566 <        checkIncomplete(h);
1567 <        g.complete(v1);
1566 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1567 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1568  
1569 <        checkCompletedWithWrappedCancellationException(h);
1569 >        checkCompletedWithWrappedCancellationException(h0);
1570 >        checkCompletedWithWrappedCancellationException(h1);
1571 >        checkCompletedWithWrappedCancellationException(h2);
1572 >        checkCompletedWithWrappedCancellationException(h3);
1573          checkCancelled(f);
1574 <        assertFalse(r.ran());
1575 <        checkCompletedNormally(g, v1);
1051 <        }
1052 <    }
1574 >        for (NoopConsumer r : rs) r.assertNotInvoked();
1575 >    }}
1576  
1577 <    public void testThenCombine_sourceCancelled2() {
1577 >    /**
1578 >     * thenAccept result completes exceptionally if action does
1579 >     */
1580 >    public void testThenAccept_actionFailed() {
1581          for (ExecutionMode m : ExecutionMode.values())
1582 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1583 <        for (Integer v1 : new Integer[] { 1, null }) {
1058 <
1582 >        for (Integer v1 : new Integer[] { 1, null })
1583 >    {
1584          final CompletableFuture<Integer> f = new CompletableFuture<>();
1585 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1586 <        final SubtractFunction r = new SubtractFunction();
1062 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1063 <
1064 <        assertTrue(g.cancel(mayInterruptIfRunning));
1065 <        checkIncomplete(h);
1066 <        f.complete(v1);
1585 >        final FailingConsumer[] rs = new FailingConsumer[4];
1586 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
1587  
1588 <        checkCompletedWithWrappedCancellationException(h);
1589 <        checkCancelled(g);
1590 <        assertFalse(r.ran());
1588 >        final CompletableFuture<Void> h0 = m.thenAccept(f, rs[0]);
1589 >        final CompletableFuture<Void> h1 = m.acceptEither(f, f, rs[1]);
1590 >        assertTrue(f.complete(v1));
1591 >        final CompletableFuture<Void> h2 = m.thenAccept(f, rs[2]);
1592 >        final CompletableFuture<Void> h3 = m.acceptEither(f, f, rs[3]);
1593 >
1594 >        checkCompletedWithWrappedException(h0, rs[0].ex);
1595 >        checkCompletedWithWrappedException(h1, rs[1].ex);
1596 >        checkCompletedWithWrappedException(h2, rs[2].ex);
1597 >        checkCompletedWithWrappedException(h3, rs[3].ex);
1598          checkCompletedNormally(f, v1);
1599 <        }
1073 <    }
1599 >    }}
1600  
1601 <    public void testThenCombine_sourceCancelled3() {
1601 >    /**
1602 >     * thenCombine result completes normally after normal completion
1603 >     * of sources
1604 >     */
1605 >    public void testThenCombine_normalCompletion() {
1606          for (ExecutionMode m : ExecutionMode.values())
1607 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1608 <        for (Integer v1 : new Integer[] { 1, null }) {
1609 <
1607 >        for (boolean fFirst : new boolean[] { true, false })
1608 >        for (Integer v1 : new Integer[] { 1, null })
1609 >        for (Integer v2 : new Integer[] { 2, null })
1610 >    {
1611          final CompletableFuture<Integer> f = new CompletableFuture<>();
1612          final CompletableFuture<Integer> g = new CompletableFuture<>();
1613 <        final SubtractFunction r = new SubtractFunction();
1613 >        final SubtractFunction[] rs = new SubtractFunction[6];
1614 >        for (int i = 0; i < rs.length; i++) rs[i] = new SubtractFunction(m);
1615  
1616 <        assertTrue(g.cancel(mayInterruptIfRunning));
1617 <        f.complete(v1);
1618 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1616 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1617 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1618 >        final Integer w1 =  fFirst ? v1 : v2;
1619 >        final Integer w2 = !fFirst ? v1 : v2;
1620 >
1621 >        final CompletableFuture<Integer> h0 = m.thenCombine(f, g, rs[0]);
1622 >        final CompletableFuture<Integer> h1 = m.thenCombine(fst, fst, rs[1]);
1623 >        assertTrue(fst.complete(w1));
1624 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, rs[2]);
1625 >        final CompletableFuture<Integer> h3 = m.thenCombine(fst, fst, rs[3]);
1626 >        checkIncomplete(h0); rs[0].assertNotInvoked();
1627 >        checkIncomplete(h2); rs[2].assertNotInvoked();
1628 >        checkCompletedNormally(h1, subtract(w1, w1));
1629 >        checkCompletedNormally(h3, subtract(w1, w1));
1630 >        rs[1].assertValue(subtract(w1, w1));
1631 >        rs[3].assertValue(subtract(w1, w1));
1632 >        assertTrue(snd.complete(w2));
1633 >        final CompletableFuture<Integer> h4 = m.thenCombine(f, g, rs[4]);
1634 >
1635 >        checkCompletedNormally(h0, subtract(v1, v2));
1636 >        checkCompletedNormally(h2, subtract(v1, v2));
1637 >        checkCompletedNormally(h4, subtract(v1, v2));
1638 >        rs[0].assertValue(subtract(v1, v2));
1639 >        rs[2].assertValue(subtract(v1, v2));
1640 >        rs[4].assertValue(subtract(v1, v2));
1641  
1088        checkCompletedWithWrappedCancellationException(h);
1089        checkCancelled(g);
1090        assertFalse(r.ran());
1642          checkCompletedNormally(f, v1);
1643 <        }
1644 <    }
1094 <
1095 <    public void testThenCombine_sourceCancelled4() {
1096 <        for (ExecutionMode m : ExecutionMode.values())
1097 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1098 <        for (Integer v1 : new Integer[] { 1, null }) {
1099 <
1100 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1101 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1102 <        final SubtractFunction r = new SubtractFunction();
1103 <
1104 <        assertTrue(f.cancel(mayInterruptIfRunning));
1105 <        g.complete(v1);
1106 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1107 <
1108 <        checkCompletedWithWrappedCancellationException(h);
1109 <        checkCancelled(f);
1110 <        assertFalse(r.ran());
1111 <        checkCompletedNormally(g, v1);
1112 <        }
1113 <    }
1643 >        checkCompletedNormally(g, v2);
1644 >    }}
1645  
1646      /**
1647 <     * thenAcceptBoth result completes normally after normal
1648 <     * completion of sources
1647 >     * thenCombine result completes exceptionally after exceptional
1648 >     * completion of either source
1649       */
1650 <    public void testThenAcceptBoth_normalCompletion1() {
1650 >    public void testThenCombine_exceptionalCompletion() throws Throwable {
1651          for (ExecutionMode m : ExecutionMode.values())
1652 +        for (boolean fFirst : new boolean[] { true, false })
1653 +        for (boolean failFirst : new boolean[] { true, false })
1654          for (Integer v1 : new Integer[] { 1, null })
1655 <        for (Integer v2 : new Integer[] { 2, null }) {
1123 <
1655 >    {
1656          final CompletableFuture<Integer> f = new CompletableFuture<>();
1657          final CompletableFuture<Integer> g = new CompletableFuture<>();
1658 <        final SubtractAction r = new SubtractAction();
1659 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1660 <
1661 <        f.complete(v1);
1662 <        checkIncomplete(h);
1663 <        assertEquals(r.value, 0);
1664 <        g.complete(v2);
1665 <
1666 <        checkCompletedNormally(h, null);
1667 <        assertEquals(r.value, subtract(v1, v2));
1668 <        checkCompletedNormally(f, v1);
1669 <        checkCompletedNormally(g, v2);
1670 <        }
1671 <    }
1658 >        final CFException ex = new CFException();
1659 >        final SubtractFunction r1 = new SubtractFunction(m);
1660 >        final SubtractFunction r2 = new SubtractFunction(m);
1661 >        final SubtractFunction r3 = new SubtractFunction(m);
1662 >
1663 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1664 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1665 >        final Callable<Boolean> complete1 = failFirst ?
1666 >            () -> fst.completeExceptionally(ex) :
1667 >            () -> fst.complete(v1);
1668 >        final Callable<Boolean> complete2 = failFirst ?
1669 >            () -> snd.complete(v1) :
1670 >            () -> snd.completeExceptionally(ex);
1671 >
1672 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1673 >        assertTrue(complete1.call());
1674 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1675 >        checkIncomplete(h1);
1676 >        checkIncomplete(h2);
1677 >        assertTrue(complete2.call());
1678 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1679 >
1680 >        checkCompletedWithWrappedException(h1, ex);
1681 >        checkCompletedWithWrappedException(h2, ex);
1682 >        checkCompletedWithWrappedException(h3, ex);
1683 >        r1.assertNotInvoked();
1684 >        r2.assertNotInvoked();
1685 >        r3.assertNotInvoked();
1686 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1687 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1688 >    }}
1689  
1690 <    public void testThenAcceptBoth_normalCompletion2() {
1690 >    /**
1691 >     * thenCombine result completes exceptionally if either source cancelled
1692 >     */
1693 >    public void testThenCombine_sourceCancelled() throws Throwable {
1694          for (ExecutionMode m : ExecutionMode.values())
1695 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1696 +        for (boolean fFirst : new boolean[] { true, false })
1697 +        for (boolean failFirst : new boolean[] { true, false })
1698          for (Integer v1 : new Integer[] { 1, null })
1699 <        for (Integer v2 : new Integer[] { 2, null }) {
1145 <
1699 >    {
1700          final CompletableFuture<Integer> f = new CompletableFuture<>();
1701          final CompletableFuture<Integer> g = new CompletableFuture<>();
1702 <        final SubtractAction r = new SubtractAction();
1703 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1702 >        final SubtractFunction r1 = new SubtractFunction(m);
1703 >        final SubtractFunction r2 = new SubtractFunction(m);
1704 >        final SubtractFunction r3 = new SubtractFunction(m);
1705 >
1706 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1707 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1708 >        final Callable<Boolean> complete1 = failFirst ?
1709 >            () -> fst.cancel(mayInterruptIfRunning) :
1710 >            () -> fst.complete(v1);
1711 >        final Callable<Boolean> complete2 = failFirst ?
1712 >            () -> snd.complete(v1) :
1713 >            () -> snd.cancel(mayInterruptIfRunning);
1714 >
1715 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1716 >        assertTrue(complete1.call());
1717 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1718 >        checkIncomplete(h1);
1719 >        checkIncomplete(h2);
1720 >        assertTrue(complete2.call());
1721 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1722 >
1723 >        checkCompletedWithWrappedCancellationException(h1);
1724 >        checkCompletedWithWrappedCancellationException(h2);
1725 >        checkCompletedWithWrappedCancellationException(h3);
1726 >        r1.assertNotInvoked();
1727 >        r2.assertNotInvoked();
1728 >        r3.assertNotInvoked();
1729 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1730 >        checkCancelled(failFirst ? fst : snd);
1731 >    }}
1732  
1733 <        g.complete(v2);
1734 <        checkIncomplete(h);
1735 <        assertEquals(r.value, 0);
1736 <        f.complete(v1);
1155 <
1156 <        checkCompletedNormally(h, null);
1157 <        assertEquals(r.value, subtract(v1, v2));
1158 <        checkCompletedNormally(f, v1);
1159 <        checkCompletedNormally(g, v2);
1160 <        }
1161 <    }
1162 <
1163 <    public void testThenAcceptBoth_normalCompletion3() {
1733 >    /**
1734 >     * thenCombine result completes exceptionally if action does
1735 >     */
1736 >    public void testThenCombine_actionFailed() {
1737          for (ExecutionMode m : ExecutionMode.values())
1738 +        for (boolean fFirst : new boolean[] { true, false })
1739          for (Integer v1 : new Integer[] { 1, null })
1740 <        for (Integer v2 : new Integer[] { 2, null }) {
1741 <
1740 >        for (Integer v2 : new Integer[] { 2, null })
1741 >    {
1742          final CompletableFuture<Integer> f = new CompletableFuture<>();
1743          final CompletableFuture<Integer> g = new CompletableFuture<>();
1744 <        final SubtractAction r = new SubtractAction();
1745 <
1746 <        g.complete(v2);
1747 <        f.complete(v1);
1748 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1749 <
1750 <        checkCompletedNormally(h, null);
1751 <        assertEquals(r.value, subtract(v1, v2));
1744 >        final FailingBiFunction r1 = new FailingBiFunction(m);
1745 >        final FailingBiFunction r2 = new FailingBiFunction(m);
1746 >        final FailingBiFunction r3 = new FailingBiFunction(m);
1747 >
1748 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1749 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1750 >        final Integer w1 =  fFirst ? v1 : v2;
1751 >        final Integer w2 = !fFirst ? v1 : v2;
1752 >
1753 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1754 >        assertTrue(fst.complete(w1));
1755 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1756 >        assertTrue(snd.complete(w2));
1757 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1758 >
1759 >        checkCompletedWithWrappedException(h1, r1.ex);
1760 >        checkCompletedWithWrappedException(h2, r2.ex);
1761 >        checkCompletedWithWrappedException(h3, r3.ex);
1762 >        r1.assertInvoked();
1763 >        r2.assertInvoked();
1764 >        r3.assertInvoked();
1765          checkCompletedNormally(f, v1);
1766          checkCompletedNormally(g, v2);
1767 <        }
1181 <    }
1767 >    }}
1768  
1769 <    public void testThenAcceptBoth_normalCompletion4() {
1769 >    /**
1770 >     * thenAcceptBoth result completes normally after normal
1771 >     * completion of sources
1772 >     */
1773 >    public void testThenAcceptBoth_normalCompletion() {
1774          for (ExecutionMode m : ExecutionMode.values())
1775 +        for (boolean fFirst : new boolean[] { true, false })
1776          for (Integer v1 : new Integer[] { 1, null })
1777 <        for (Integer v2 : new Integer[] { 2, null }) {
1778 <
1777 >        for (Integer v2 : new Integer[] { 2, null })
1778 >    {
1779          final CompletableFuture<Integer> f = new CompletableFuture<>();
1780          final CompletableFuture<Integer> g = new CompletableFuture<>();
1781 <        final SubtractAction r = new SubtractAction();
1782 <
1783 <        f.complete(v1);
1784 <        g.complete(v2);
1785 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1786 <
1787 <        checkCompletedNormally(h, null);
1788 <        assertEquals(r.value, subtract(v1, v2));
1781 >        final SubtractAction r1 = new SubtractAction(m);
1782 >        final SubtractAction r2 = new SubtractAction(m);
1783 >        final SubtractAction r3 = new SubtractAction(m);
1784 >
1785 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1786 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1787 >        final Integer w1 =  fFirst ? v1 : v2;
1788 >        final Integer w2 = !fFirst ? v1 : v2;
1789 >
1790 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1791 >        assertTrue(fst.complete(w1));
1792 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1793 >        checkIncomplete(h1);
1794 >        checkIncomplete(h2);
1795 >        r1.assertNotInvoked();
1796 >        r2.assertNotInvoked();
1797 >        assertTrue(snd.complete(w2));
1798 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1799 >
1800 >        checkCompletedNormally(h1, null);
1801 >        checkCompletedNormally(h2, null);
1802 >        checkCompletedNormally(h3, null);
1803 >        r1.assertValue(subtract(v1, v2));
1804 >        r2.assertValue(subtract(v1, v2));
1805 >        r3.assertValue(subtract(v1, v2));
1806          checkCompletedNormally(f, v1);
1807          checkCompletedNormally(g, v2);
1808 <        }
1201 <    }
1808 >    }}
1809  
1810      /**
1811       * thenAcceptBoth result completes exceptionally after exceptional
1812       * completion of either source
1813       */
1814 <    public void testThenAcceptBoth_exceptionalCompletion1() {
1814 >    public void testThenAcceptBoth_exceptionalCompletion() throws Throwable {
1815          for (ExecutionMode m : ExecutionMode.values())
1816 <        for (Integer v1 : new Integer[] { 1, null }) {
1817 <
1816 >        for (boolean fFirst : new boolean[] { true, false })
1817 >        for (boolean failFirst : new boolean[] { true, false })
1818 >        for (Integer v1 : new Integer[] { 1, null })
1819 >    {
1820          final CompletableFuture<Integer> f = new CompletableFuture<>();
1821          final CompletableFuture<Integer> g = new CompletableFuture<>();
1213        final SubtractAction r = new SubtractAction();
1214        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1822          final CFException ex = new CFException();
1823 +        final SubtractAction r1 = new SubtractAction(m);
1824 +        final SubtractAction r2 = new SubtractAction(m);
1825 +        final SubtractAction r3 = new SubtractAction(m);
1826 +
1827 +        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1828 +        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1829 +        final Callable<Boolean> complete1 = failFirst ?
1830 +            () -> fst.completeExceptionally(ex) :
1831 +            () -> fst.complete(v1);
1832 +        final Callable<Boolean> complete2 = failFirst ?
1833 +            () -> snd.complete(v1) :
1834 +            () -> snd.completeExceptionally(ex);
1835 +
1836 +        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1837 +        assertTrue(complete1.call());
1838 +        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1839 +        checkIncomplete(h1);
1840 +        checkIncomplete(h2);
1841 +        assertTrue(complete2.call());
1842 +        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1843 +
1844 +        checkCompletedWithWrappedException(h1, ex);
1845 +        checkCompletedWithWrappedException(h2, ex);
1846 +        checkCompletedWithWrappedException(h3, ex);
1847 +        r1.assertNotInvoked();
1848 +        r2.assertNotInvoked();
1849 +        r3.assertNotInvoked();
1850 +        checkCompletedNormally(failFirst ? snd : fst, v1);
1851 +        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1852 +    }}
1853  
1854 <        f.completeExceptionally(ex);
1855 <        checkIncomplete(h);
1856 <        g.complete(v1);
1857 <
1221 <        checkCompletedWithWrappedCFException(h, ex);
1222 <        checkCompletedWithWrappedCFException(f, ex);
1223 <        assertFalse(r.ran());
1224 <        checkCompletedNormally(g, v1);
1225 <        }
1226 <    }
1227 <
1228 <    public void testThenAcceptBoth_exceptionalCompletion2() {
1854 >    /**
1855 >     * thenAcceptBoth result completes exceptionally if either source cancelled
1856 >     */
1857 >    public void testThenAcceptBoth_sourceCancelled() throws Throwable {
1858          for (ExecutionMode m : ExecutionMode.values())
1859 <        for (Integer v1 : new Integer[] { 1, null }) {
1860 <
1859 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1860 >        for (boolean fFirst : new boolean[] { true, false })
1861 >        for (boolean failFirst : new boolean[] { true, false })
1862 >        for (Integer v1 : new Integer[] { 1, null })
1863 >    {
1864          final CompletableFuture<Integer> f = new CompletableFuture<>();
1865          final CompletableFuture<Integer> g = new CompletableFuture<>();
1866 <        final SubtractAction r = new SubtractAction();
1867 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1868 <        final CFException ex = new CFException();
1866 >        final SubtractAction r1 = new SubtractAction(m);
1867 >        final SubtractAction r2 = new SubtractAction(m);
1868 >        final SubtractAction r3 = new SubtractAction(m);
1869 >
1870 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1871 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1872 >        final Callable<Boolean> complete1 = failFirst ?
1873 >            () -> fst.cancel(mayInterruptIfRunning) :
1874 >            () -> fst.complete(v1);
1875 >        final Callable<Boolean> complete2 = failFirst ?
1876 >            () -> snd.complete(v1) :
1877 >            () -> snd.cancel(mayInterruptIfRunning);
1878 >
1879 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1880 >        assertTrue(complete1.call());
1881 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1882 >        checkIncomplete(h1);
1883 >        checkIncomplete(h2);
1884 >        assertTrue(complete2.call());
1885 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1886 >
1887 >        checkCompletedWithWrappedCancellationException(h1);
1888 >        checkCompletedWithWrappedCancellationException(h2);
1889 >        checkCompletedWithWrappedCancellationException(h3);
1890 >        r1.assertNotInvoked();
1891 >        r2.assertNotInvoked();
1892 >        r3.assertNotInvoked();
1893 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1894 >        checkCancelled(failFirst ? fst : snd);
1895 >    }}
1896  
1897 <        g.completeExceptionally(ex);
1898 <        checkIncomplete(h);
1899 <        f.complete(v1);
1900 <
1901 <        checkCompletedWithWrappedCFException(h, ex);
1902 <        checkCompletedWithWrappedCFException(g, ex);
1903 <        assertFalse(r.ran());
1897 >    /**
1898 >     * thenAcceptBoth result completes exceptionally if action does
1899 >     */
1900 >    public void testThenAcceptBoth_actionFailed() {
1901 >        for (ExecutionMode m : ExecutionMode.values())
1902 >        for (boolean fFirst : new boolean[] { true, false })
1903 >        for (Integer v1 : new Integer[] { 1, null })
1904 >        for (Integer v2 : new Integer[] { 2, null })
1905 >    {
1906 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1907 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1908 >        final FailingBiConsumer r1 = new FailingBiConsumer(m);
1909 >        final FailingBiConsumer r2 = new FailingBiConsumer(m);
1910 >        final FailingBiConsumer r3 = new FailingBiConsumer(m);
1911 >
1912 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1913 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1914 >        final Integer w1 =  fFirst ? v1 : v2;
1915 >        final Integer w2 = !fFirst ? v1 : v2;
1916 >
1917 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1918 >        assertTrue(fst.complete(w1));
1919 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1920 >        assertTrue(snd.complete(w2));
1921 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1922 >
1923 >        checkCompletedWithWrappedException(h1, r1.ex);
1924 >        checkCompletedWithWrappedException(h2, r2.ex);
1925 >        checkCompletedWithWrappedException(h3, r3.ex);
1926 >        r1.assertInvoked();
1927 >        r2.assertInvoked();
1928 >        r3.assertInvoked();
1929          checkCompletedNormally(f, v1);
1930 <        }
1931 <    }
1930 >        checkCompletedNormally(g, v2);
1931 >    }}
1932  
1933 <    public void testThenAcceptBoth_exceptionalCompletion3() {
1933 >    /**
1934 >     * runAfterBoth result completes normally after normal
1935 >     * completion of sources
1936 >     */
1937 >    public void testRunAfterBoth_normalCompletion() {
1938          for (ExecutionMode m : ExecutionMode.values())
1939 <        for (Integer v1 : new Integer[] { 1, null }) {
1940 <
1939 >        for (boolean fFirst : new boolean[] { true, false })
1940 >        for (Integer v1 : new Integer[] { 1, null })
1941 >        for (Integer v2 : new Integer[] { 2, null })
1942 >    {
1943          final CompletableFuture<Integer> f = new CompletableFuture<>();
1944          final CompletableFuture<Integer> g = new CompletableFuture<>();
1945 <        final SubtractAction r = new SubtractAction();
1946 <        final CFException ex = new CFException();
1947 <
1948 <        g.completeExceptionally(ex);
1949 <        f.complete(v1);
1950 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1951 <
1952 <        checkCompletedWithWrappedCFException(h, ex);
1953 <        checkCompletedWithWrappedCFException(g, ex);
1954 <        assertFalse(r.ran());
1945 >        final Noop r1 = new Noop(m);
1946 >        final Noop r2 = new Noop(m);
1947 >        final Noop r3 = new Noop(m);
1948 >
1949 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1950 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1951 >        final Integer w1 =  fFirst ? v1 : v2;
1952 >        final Integer w2 = !fFirst ? v1 : v2;
1953 >
1954 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1955 >        assertTrue(fst.complete(w1));
1956 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1957 >        checkIncomplete(h1);
1958 >        checkIncomplete(h2);
1959 >        r1.assertNotInvoked();
1960 >        r2.assertNotInvoked();
1961 >        assertTrue(snd.complete(w2));
1962 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
1963 >
1964 >        checkCompletedNormally(h1, null);
1965 >        checkCompletedNormally(h2, null);
1966 >        checkCompletedNormally(h3, null);
1967 >        r1.assertInvoked();
1968 >        r2.assertInvoked();
1969 >        r3.assertInvoked();
1970          checkCompletedNormally(f, v1);
1971 <        }
1972 <    }
1971 >        checkCompletedNormally(g, v2);
1972 >    }}
1973  
1974 <    public void testThenAcceptBoth_exceptionalCompletion4() {
1974 >    /**
1975 >     * runAfterBoth result completes exceptionally after exceptional
1976 >     * completion of either source
1977 >     */
1978 >    public void testRunAfterBoth_exceptionalCompletion() throws Throwable {
1979          for (ExecutionMode m : ExecutionMode.values())
1980 <        for (Integer v1 : new Integer[] { 1, null }) {
1981 <
1980 >        for (boolean fFirst : new boolean[] { true, false })
1981 >        for (boolean failFirst : new boolean[] { true, false })
1982 >        for (Integer v1 : new Integer[] { 1, null })
1983 >    {
1984          final CompletableFuture<Integer> f = new CompletableFuture<>();
1985          final CompletableFuture<Integer> g = new CompletableFuture<>();
1275        final SubtractAction r = new SubtractAction();
1986          final CFException ex = new CFException();
1987 <
1988 <        f.completeExceptionally(ex);
1989 <        g.complete(v1);
1990 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1991 <
1992 <        checkCompletedWithWrappedCFException(h, ex);
1993 <        checkCompletedWithWrappedCFException(f, ex);
1994 <        assertFalse(r.ran());
1995 <        checkCompletedNormally(g, v1);
1996 <        }
1997 <    }
1987 >        final Noop r1 = new Noop(m);
1988 >        final Noop r2 = new Noop(m);
1989 >        final Noop r3 = new Noop(m);
1990 >
1991 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1992 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1993 >        final Callable<Boolean> complete1 = failFirst ?
1994 >            () -> fst.completeExceptionally(ex) :
1995 >            () -> fst.complete(v1);
1996 >        final Callable<Boolean> complete2 = failFirst ?
1997 >            () -> snd.complete(v1) :
1998 >            () -> snd.completeExceptionally(ex);
1999 >
2000 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2001 >        assertTrue(complete1.call());
2002 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2003 >        checkIncomplete(h1);
2004 >        checkIncomplete(h2);
2005 >        assertTrue(complete2.call());
2006 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2007 >
2008 >        checkCompletedWithWrappedException(h1, ex);
2009 >        checkCompletedWithWrappedException(h2, ex);
2010 >        checkCompletedWithWrappedException(h3, ex);
2011 >        r1.assertNotInvoked();
2012 >        r2.assertNotInvoked();
2013 >        r3.assertNotInvoked();
2014 >        checkCompletedNormally(failFirst ? snd : fst, v1);
2015 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
2016 >    }}
2017  
2018      /**
2019 <     * thenAcceptBoth result completes exceptionally if action does
2019 >     * runAfterBoth result completes exceptionally if either source cancelled
2020       */
2021 <    public void testThenAcceptBoth_actionFailed1() {
2021 >    public void testRunAfterBoth_sourceCancelled() throws Throwable {
2022          for (ExecutionMode m : ExecutionMode.values())
2023 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2024 +        for (boolean fFirst : new boolean[] { true, false })
2025 +        for (boolean failFirst : new boolean[] { true, false })
2026          for (Integer v1 : new Integer[] { 1, null })
2027 <        for (Integer v2 : new Integer[] { 2, null }) {
1296 <
2027 >    {
2028          final CompletableFuture<Integer> f = new CompletableFuture<>();
2029          final CompletableFuture<Integer> g = new CompletableFuture<>();
2030 <        final FailingBiConsumer r = new FailingBiConsumer();
2031 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
2030 >        final Noop r1 = new Noop(m);
2031 >        final Noop r2 = new Noop(m);
2032 >        final Noop r3 = new Noop(m);
2033 >
2034 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
2035 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
2036 >        final Callable<Boolean> complete1 = failFirst ?
2037 >            () -> fst.cancel(mayInterruptIfRunning) :
2038 >            () -> fst.complete(v1);
2039 >        final Callable<Boolean> complete2 = failFirst ?
2040 >            () -> snd.complete(v1) :
2041 >            () -> snd.cancel(mayInterruptIfRunning);
2042 >
2043 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2044 >        assertTrue(complete1.call());
2045 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2046 >        checkIncomplete(h1);
2047 >        checkIncomplete(h2);
2048 >        assertTrue(complete2.call());
2049 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2050 >
2051 >        checkCompletedWithWrappedCancellationException(h1);
2052 >        checkCompletedWithWrappedCancellationException(h2);
2053 >        checkCompletedWithWrappedCancellationException(h3);
2054 >        r1.assertNotInvoked();
2055 >        r2.assertNotInvoked();
2056 >        r3.assertNotInvoked();
2057 >        checkCompletedNormally(failFirst ? snd : fst, v1);
2058 >        checkCancelled(failFirst ? fst : snd);
2059 >    }}
2060  
2061 <        f.complete(v1);
2062 <        checkIncomplete(h);
2063 <        g.complete(v2);
2064 <
2065 <        checkCompletedWithWrappedCFException(h);
2061 >    /**
2062 >     * runAfterBoth result completes exceptionally if action does
2063 >     */
2064 >    public void testRunAfterBoth_actionFailed() {
2065 >        for (ExecutionMode m : ExecutionMode.values())
2066 >        for (boolean fFirst : new boolean[] { true, false })
2067 >        for (Integer v1 : new Integer[] { 1, null })
2068 >        for (Integer v2 : new Integer[] { 2, null })
2069 >    {
2070 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2071 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2072 >        final FailingRunnable r1 = new FailingRunnable(m);
2073 >        final FailingRunnable r2 = new FailingRunnable(m);
2074 >        final FailingRunnable r3 = new FailingRunnable(m);
2075 >
2076 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
2077 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
2078 >        final Integer w1 =  fFirst ? v1 : v2;
2079 >        final Integer w2 = !fFirst ? v1 : v2;
2080 >
2081 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2082 >        assertTrue(fst.complete(w1));
2083 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2084 >        assertTrue(snd.complete(w2));
2085 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2086 >
2087 >        checkCompletedWithWrappedException(h1, r1.ex);
2088 >        checkCompletedWithWrappedException(h2, r2.ex);
2089 >        checkCompletedWithWrappedException(h3, r3.ex);
2090 >        r1.assertInvoked();
2091 >        r2.assertInvoked();
2092 >        r3.assertInvoked();
2093          checkCompletedNormally(f, v1);
2094          checkCompletedNormally(g, v2);
2095 <        }
1310 <    }
2095 >    }}
2096  
2097 <    public void testThenAcceptBoth_actionFailed2() {
2097 >    /**
2098 >     * applyToEither result completes normally after normal completion
2099 >     * of either source
2100 >     */
2101 >    public void testApplyToEither_normalCompletion() {
2102          for (ExecutionMode m : ExecutionMode.values())
2103          for (Integer v1 : new Integer[] { 1, null })
2104 <        for (Integer v2 : new Integer[] { 2, null }) {
2105 <
2104 >        for (Integer v2 : new Integer[] { 2, null })
2105 >    {
2106          final CompletableFuture<Integer> f = new CompletableFuture<>();
2107          final CompletableFuture<Integer> g = new CompletableFuture<>();
2108 <        final FailingBiConsumer r = new FailingBiConsumer();
2109 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
2108 >        final IncFunction[] rs = new IncFunction[6];
2109 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2110  
2111 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2112 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2113 +        checkIncomplete(h0);
2114 +        checkIncomplete(h1);
2115 +        rs[0].assertNotInvoked();
2116 +        rs[1].assertNotInvoked();
2117 +        f.complete(v1);
2118 +        checkCompletedNormally(h0, inc(v1));
2119 +        checkCompletedNormally(h1, inc(v1));
2120 +        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2121 +        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2122 +        checkCompletedNormally(h2, inc(v1));
2123 +        checkCompletedNormally(h3, inc(v1));
2124          g.complete(v2);
1323        checkIncomplete(h);
1324        f.complete(v1);
2125  
2126 <        checkCompletedWithWrappedCFException(h);
2126 >        // unspecified behavior - both source completions available
2127 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2128 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2129 >        rs[4].assertValue(h4.join());
2130 >        rs[5].assertValue(h5.join());
2131 >        assertTrue(Objects.equals(inc(v1), h4.join()) ||
2132 >                   Objects.equals(inc(v2), h4.join()));
2133 >        assertTrue(Objects.equals(inc(v1), h5.join()) ||
2134 >                   Objects.equals(inc(v2), h5.join()));
2135 >
2136          checkCompletedNormally(f, v1);
2137          checkCompletedNormally(g, v2);
2138 <        }
2139 <    }
2138 >        checkCompletedNormally(h0, inc(v1));
2139 >        checkCompletedNormally(h1, inc(v1));
2140 >        checkCompletedNormally(h2, inc(v1));
2141 >        checkCompletedNormally(h3, inc(v1));
2142 >        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
2143 >    }}
2144  
2145      /**
2146 <     * thenAcceptBoth result completes exceptionally if either source cancelled
2146 >     * applyToEither result completes exceptionally after exceptional
2147 >     * completion of either source
2148       */
2149 <    public void testThenAcceptBoth_sourceCancelled1() {
2149 >    public void testApplyToEither_exceptionalCompletion() {
2150          for (ExecutionMode m : ExecutionMode.values())
2151 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2152 <        for (Integer v1 : new Integer[] { 1, null }) {
1339 <
2151 >        for (Integer v1 : new Integer[] { 1, null })
2152 >    {
2153          final CompletableFuture<Integer> f = new CompletableFuture<>();
2154          final CompletableFuture<Integer> g = new CompletableFuture<>();
2155 <        final SubtractAction r = new SubtractAction();
2156 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
2155 >        final CFException ex = new CFException();
2156 >        final IncFunction[] rs = new IncFunction[6];
2157 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2158  
2159 <        assertTrue(f.cancel(mayInterruptIfRunning));
2160 <        checkIncomplete(h);
2159 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2160 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2161 >        checkIncomplete(h0);
2162 >        checkIncomplete(h1);
2163 >        rs[0].assertNotInvoked();
2164 >        rs[1].assertNotInvoked();
2165 >        f.completeExceptionally(ex);
2166 >        checkCompletedWithWrappedException(h0, ex);
2167 >        checkCompletedWithWrappedException(h1, ex);
2168 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2169 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2170 >        checkCompletedWithWrappedException(h2, ex);
2171 >        checkCompletedWithWrappedException(h3, ex);
2172          g.complete(v1);
2173  
2174 <        checkCompletedWithWrappedCancellationException(h);
2175 <        checkCancelled(f);
2176 <        assertFalse(r.ran());
2177 <        checkCompletedNormally(g, v1);
2174 >        // unspecified behavior - both source completions available
2175 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2176 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2177 >        try {
2178 >            assertEquals(inc(v1), h4.join());
2179 >            rs[4].assertValue(inc(v1));
2180 >        } catch (CompletionException ok) {
2181 >            checkCompletedWithWrappedException(h4, ex);
2182 >            rs[4].assertNotInvoked();
2183 >        }
2184 >        try {
2185 >            assertEquals(inc(v1), h5.join());
2186 >            rs[5].assertValue(inc(v1));
2187 >        } catch (CompletionException ok) {
2188 >            checkCompletedWithWrappedException(h5, ex);
2189 >            rs[5].assertNotInvoked();
2190          }
1354    }
2191  
2192 <    public void testThenAcceptBoth_sourceCancelled2() {
2193 <        for (ExecutionMode m : ExecutionMode.values())
2194 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2195 <        for (Integer v1 : new Integer[] { 1, null }) {
2192 >        checkCompletedExceptionally(f, ex);
2193 >        checkCompletedNormally(g, v1);
2194 >        checkCompletedWithWrappedException(h0, ex);
2195 >        checkCompletedWithWrappedException(h1, ex);
2196 >        checkCompletedWithWrappedException(h2, ex);
2197 >        checkCompletedWithWrappedException(h3, ex);
2198 >        checkCompletedWithWrappedException(h4, ex);
2199 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2200 >    }}
2201  
2202 +    public void testApplyToEither_exceptionalCompletion2() {
2203 +        for (ExecutionMode m : ExecutionMode.values())
2204 +        for (boolean fFirst : new boolean[] { true, false })
2205 +        for (Integer v1 : new Integer[] { 1, null })
2206 +    {
2207          final CompletableFuture<Integer> f = new CompletableFuture<>();
2208          final CompletableFuture<Integer> g = new CompletableFuture<>();
2209 <        final SubtractAction r = new SubtractAction();
2210 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
2209 >        final CFException ex = new CFException();
2210 >        final IncFunction[] rs = new IncFunction[6];
2211 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2212  
2213 <        assertTrue(g.cancel(mayInterruptIfRunning));
2214 <        checkIncomplete(h);
2215 <        f.complete(v1);
2213 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2214 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2215 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2216 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2217 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2218 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2219  
2220 <        checkCompletedWithWrappedCancellationException(h);
2221 <        checkCancelled(g);
2222 <        assertFalse(r.ran());
2223 <        checkCompletedNormally(f, v1);
2220 >        // unspecified behavior - both source completions available
2221 >        try {
2222 >            assertEquals(inc(v1), h0.join());
2223 >            rs[0].assertValue(inc(v1));
2224 >        } catch (CompletionException ok) {
2225 >            checkCompletedWithWrappedException(h0, ex);
2226 >            rs[0].assertNotInvoked();
2227 >        }
2228 >        try {
2229 >            assertEquals(inc(v1), h1.join());
2230 >            rs[1].assertValue(inc(v1));
2231 >        } catch (CompletionException ok) {
2232 >            checkCompletedWithWrappedException(h1, ex);
2233 >            rs[1].assertNotInvoked();
2234 >        }
2235 >        try {
2236 >            assertEquals(inc(v1), h2.join());
2237 >            rs[2].assertValue(inc(v1));
2238 >        } catch (CompletionException ok) {
2239 >            checkCompletedWithWrappedException(h2, ex);
2240 >            rs[2].assertNotInvoked();
2241 >        }
2242 >        try {
2243 >            assertEquals(inc(v1), h3.join());
2244 >            rs[3].assertValue(inc(v1));
2245 >        } catch (CompletionException ok) {
2246 >            checkCompletedWithWrappedException(h3, ex);
2247 >            rs[3].assertNotInvoked();
2248          }
1375    }
1376
1377    public void testThenAcceptBoth_sourceCancelled3() {
1378        for (ExecutionMode m : ExecutionMode.values())
1379        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1380        for (Integer v1 : new Integer[] { 1, null }) {
1381
1382        final CompletableFuture<Integer> f = new CompletableFuture<>();
1383        final CompletableFuture<Integer> g = new CompletableFuture<>();
1384        final SubtractAction r = new SubtractAction();
1385
1386        assertTrue(g.cancel(mayInterruptIfRunning));
1387        f.complete(v1);
1388        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
2249  
1390        checkCompletedWithWrappedCancellationException(h);
1391        checkCancelled(g);
1392        assertFalse(r.ran());
2250          checkCompletedNormally(f, v1);
2251 <        }
2252 <    }
2251 >        checkCompletedExceptionally(g, ex);
2252 >    }}
2253  
2254 <    public void testThenAcceptBoth_sourceCancelled4() {
2254 >    /**
2255 >     * applyToEither result completes exceptionally if either source cancelled
2256 >     */
2257 >    public void testApplyToEither_sourceCancelled() {
2258          for (ExecutionMode m : ExecutionMode.values())
2259          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2260 <        for (Integer v1 : new Integer[] { 1, null }) {
2261 <
2260 >        for (Integer v1 : new Integer[] { 1, null })
2261 >    {
2262          final CompletableFuture<Integer> f = new CompletableFuture<>();
2263          final CompletableFuture<Integer> g = new CompletableFuture<>();
2264 <        final SubtractAction r = new SubtractAction();
2264 >        final IncFunction[] rs = new IncFunction[6];
2265 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2266  
2267 <        assertTrue(f.cancel(mayInterruptIfRunning));
2267 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2268 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2269 >        checkIncomplete(h0);
2270 >        checkIncomplete(h1);
2271 >        rs[0].assertNotInvoked();
2272 >        rs[1].assertNotInvoked();
2273 >        f.cancel(mayInterruptIfRunning);
2274 >        checkCompletedWithWrappedCancellationException(h0);
2275 >        checkCompletedWithWrappedCancellationException(h1);
2276 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2277 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2278 >        checkCompletedWithWrappedCancellationException(h2);
2279 >        checkCompletedWithWrappedCancellationException(h3);
2280          g.complete(v1);
1408        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
2281  
2282 <        checkCompletedWithWrappedCancellationException(h);
2282 >        // unspecified behavior - both source completions available
2283 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2284 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2285 >        try {
2286 >            assertEquals(inc(v1), h4.join());
2287 >            rs[4].assertValue(inc(v1));
2288 >        } catch (CompletionException ok) {
2289 >            checkCompletedWithWrappedCancellationException(h4);
2290 >            rs[4].assertNotInvoked();
2291 >        }
2292 >        try {
2293 >            assertEquals(inc(v1), h5.join());
2294 >            rs[5].assertValue(inc(v1));
2295 >        } catch (CompletionException ok) {
2296 >            checkCompletedWithWrappedCancellationException(h5);
2297 >            rs[5].assertNotInvoked();
2298 >        }
2299 >
2300          checkCancelled(f);
1412        assertFalse(r.ran());
2301          checkCompletedNormally(g, v1);
2302 <        }
2303 <    }
2302 >        checkCompletedWithWrappedCancellationException(h0);
2303 >        checkCompletedWithWrappedCancellationException(h1);
2304 >        checkCompletedWithWrappedCancellationException(h2);
2305 >        checkCompletedWithWrappedCancellationException(h3);
2306 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2307 >    }}
2308  
2309 <    /**
1418 <     * runAfterBoth result completes normally after normal
1419 <     * completion of sources
1420 <     */
1421 <    public void testRunAfterBoth_normalCompletion1() {
2309 >    public void testApplyToEither_sourceCancelled2() {
2310          for (ExecutionMode m : ExecutionMode.values())
2311 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2312 +        for (boolean fFirst : new boolean[] { true, false })
2313          for (Integer v1 : new Integer[] { 1, null })
2314 <        for (Integer v2 : new Integer[] { 2, null }) {
1425 <
2314 >    {
2315          final CompletableFuture<Integer> f = new CompletableFuture<>();
2316          final CompletableFuture<Integer> g = new CompletableFuture<>();
2317 <        final Noop r = new Noop();
2318 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2317 >        final IncFunction[] rs = new IncFunction[6];
2318 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2319  
2320 <        f.complete(v1);
2321 <        checkIncomplete(h);
2322 <        assertFalse(r.ran);
2323 <        g.complete(v2);
2320 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2321 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2322 >        assertTrue(fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2323 >        assertTrue(!fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2324 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2325 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2326  
2327 <        checkCompletedNormally(h, null);
2328 <        assertTrue(r.ran);
2329 <        checkCompletedNormally(f, v1);
2330 <        checkCompletedNormally(g, v2);
2327 >        // unspecified behavior - both source completions available
2328 >        try {
2329 >            assertEquals(inc(v1), h0.join());
2330 >            rs[0].assertValue(inc(v1));
2331 >        } catch (CompletionException ok) {
2332 >            checkCompletedWithWrappedCancellationException(h0);
2333 >            rs[0].assertNotInvoked();
2334 >        }
2335 >        try {
2336 >            assertEquals(inc(v1), h1.join());
2337 >            rs[1].assertValue(inc(v1));
2338 >        } catch (CompletionException ok) {
2339 >            checkCompletedWithWrappedCancellationException(h1);
2340 >            rs[1].assertNotInvoked();
2341 >        }
2342 >        try {
2343 >            assertEquals(inc(v1), h2.join());
2344 >            rs[2].assertValue(inc(v1));
2345 >        } catch (CompletionException ok) {
2346 >            checkCompletedWithWrappedCancellationException(h2);
2347 >            rs[2].assertNotInvoked();
2348 >        }
2349 >        try {
2350 >            assertEquals(inc(v1), h3.join());
2351 >            rs[3].assertValue(inc(v1));
2352 >        } catch (CompletionException ok) {
2353 >            checkCompletedWithWrappedCancellationException(h3);
2354 >            rs[3].assertNotInvoked();
2355          }
1441    }
1442
1443    public void testRunAfterBoth_normalCompletion2() {
1444        for (ExecutionMode m : ExecutionMode.values())
1445        for (Integer v1 : new Integer[] { 1, null })
1446        for (Integer v2 : new Integer[] { 2, null }) {
1447
1448        final CompletableFuture<Integer> f = new CompletableFuture<>();
1449        final CompletableFuture<Integer> g = new CompletableFuture<>();
1450        final Noop r = new Noop();
1451        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1452
1453        g.complete(v2);
1454        checkIncomplete(h);
1455        assertFalse(r.ran);
1456        f.complete(v1);
2356  
1458        checkCompletedNormally(h, null);
1459        assertTrue(r.ran);
2357          checkCompletedNormally(f, v1);
2358 <        checkCompletedNormally(g, v2);
2359 <        }
1463 <    }
2358 >        checkCancelled(g);
2359 >    }}
2360  
2361 <    public void testRunAfterBoth_normalCompletion3() {
2361 >    /**
2362 >     * applyToEither result completes exceptionally if action does
2363 >     */
2364 >    public void testApplyToEither_actionFailed() {
2365          for (ExecutionMode m : ExecutionMode.values())
2366          for (Integer v1 : new Integer[] { 1, null })
2367 <        for (Integer v2 : new Integer[] { 2, null }) {
2368 <
2367 >        for (Integer v2 : new Integer[] { 2, null })
2368 >    {
2369          final CompletableFuture<Integer> f = new CompletableFuture<>();
2370          final CompletableFuture<Integer> g = new CompletableFuture<>();
2371 <        final Noop r = new Noop();
2371 >        final FailingFunction[] rs = new FailingFunction[6];
2372 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
2373 >
2374 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2375 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2376 >        f.complete(v1);
2377 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2378 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2379 >        checkCompletedWithWrappedException(h0, rs[0].ex);
2380 >        checkCompletedWithWrappedException(h1, rs[1].ex);
2381 >        checkCompletedWithWrappedException(h2, rs[2].ex);
2382 >        checkCompletedWithWrappedException(h3, rs[3].ex);
2383 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2384  
2385          g.complete(v2);
1475        f.complete(v1);
1476        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2386  
2387 <        checkCompletedNormally(h, null);
2388 <        assertTrue(r.ran);
2387 >        // unspecified behavior - both source completions available
2388 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2389 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2390 >
2391 >        checkCompletedWithWrappedException(h4, rs[4].ex);
2392 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2393 >                   Objects.equals(v2, rs[4].value));
2394 >        checkCompletedWithWrappedException(h5, rs[5].ex);
2395 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2396 >                   Objects.equals(v2, rs[5].value));
2397 >
2398          checkCompletedNormally(f, v1);
2399          checkCompletedNormally(g, v2);
2400 <        }
1483 <    }
2400 >    }}
2401  
2402 <    public void testRunAfterBoth_normalCompletion4() {
2402 >    /**
2403 >     * acceptEither result completes normally after normal completion
2404 >     * of either source
2405 >     */
2406 >    public void testAcceptEither_normalCompletion() {
2407          for (ExecutionMode m : ExecutionMode.values())
2408          for (Integer v1 : new Integer[] { 1, null })
2409 <        for (Integer v2 : new Integer[] { 2, null }) {
2410 <
2409 >        for (Integer v2 : new Integer[] { 2, null })
2410 >    {
2411          final CompletableFuture<Integer> f = new CompletableFuture<>();
2412          final CompletableFuture<Integer> g = new CompletableFuture<>();
2413 <        final Noop r = new Noop();
2413 >        final NoopConsumer[] rs = new NoopConsumer[6];
2414 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2415  
2416 <        f.complete(v1);
2416 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2417 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2418 >        checkIncomplete(h0);
2419 >        checkIncomplete(h1);
2420 >        rs[0].assertNotInvoked();
2421 >        rs[1].assertNotInvoked();
2422 >        f.complete(v1);
2423 >        checkCompletedNormally(h0, null);
2424 >        checkCompletedNormally(h1, null);
2425 >        rs[0].assertValue(v1);
2426 >        rs[1].assertValue(v1);
2427 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2428 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2429 >        checkCompletedNormally(h2, null);
2430 >        checkCompletedNormally(h3, null);
2431 >        rs[2].assertValue(v1);
2432 >        rs[3].assertValue(v1);
2433          g.complete(v2);
1496        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2434  
2435 <        checkCompletedNormally(h, null);
2436 <        assertTrue(r.ran);
2435 >        // unspecified behavior - both source completions available
2436 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2437 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2438 >        checkCompletedNormally(h4, null);
2439 >        checkCompletedNormally(h5, null);
2440 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2441 >                   Objects.equals(v2, rs[4].value));
2442 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2443 >                   Objects.equals(v2, rs[5].value));
2444 >
2445          checkCompletedNormally(f, v1);
2446          checkCompletedNormally(g, v2);
2447 <        }
2448 <    }
2447 >        checkCompletedNormally(h0, null);
2448 >        checkCompletedNormally(h1, null);
2449 >        checkCompletedNormally(h2, null);
2450 >        checkCompletedNormally(h3, null);
2451 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2452 >    }}
2453  
2454      /**
2455 <     * runAfterBoth result completes exceptionally after exceptional
2455 >     * acceptEither result completes exceptionally after exceptional
2456       * completion of either source
2457       */
2458 <    public void testRunAfterBoth_exceptionalCompletion1() {
2458 >    public void testAcceptEither_exceptionalCompletion() {
2459          for (ExecutionMode m : ExecutionMode.values())
2460 <        for (Integer v1 : new Integer[] { 1, null }) {
2461 <
2460 >        for (Integer v1 : new Integer[] { 1, null })
2461 >    {
2462          final CompletableFuture<Integer> f = new CompletableFuture<>();
2463          final CompletableFuture<Integer> g = new CompletableFuture<>();
1515        final Noop r = new Noop();
1516        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2464          final CFException ex = new CFException();
2465 +        final NoopConsumer[] rs = new NoopConsumer[6];
2466 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2467  
2468 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2469 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2470 +        checkIncomplete(h0);
2471 +        checkIncomplete(h1);
2472 +        rs[0].assertNotInvoked();
2473 +        rs[1].assertNotInvoked();
2474          f.completeExceptionally(ex);
2475 <        checkIncomplete(h);
2475 >        checkCompletedWithWrappedException(h0, ex);
2476 >        checkCompletedWithWrappedException(h1, ex);
2477 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2478 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2479 >        checkCompletedWithWrappedException(h2, ex);
2480 >        checkCompletedWithWrappedException(h3, ex);
2481 >
2482          g.complete(v1);
2483  
2484 <        checkCompletedWithWrappedCFException(h, ex);
2485 <        checkCompletedWithWrappedCFException(f, ex);
2486 <        assertFalse(r.ran);
2487 <        checkCompletedNormally(g, v1);
2484 >        // unspecified behavior - both source completions available
2485 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2486 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2487 >        try {
2488 >            assertNull(h4.join());
2489 >            rs[4].assertValue(v1);
2490 >        } catch (CompletionException ok) {
2491 >            checkCompletedWithWrappedException(h4, ex);
2492 >            rs[4].assertNotInvoked();
2493 >        }
2494 >        try {
2495 >            assertNull(h5.join());
2496 >            rs[5].assertValue(v1);
2497 >        } catch (CompletionException ok) {
2498 >            checkCompletedWithWrappedException(h5, ex);
2499 >            rs[5].assertNotInvoked();
2500          }
1528    }
2501  
2502 <    public void testRunAfterBoth_exceptionalCompletion2() {
2503 <        for (ExecutionMode m : ExecutionMode.values())
2504 <        for (Integer v1 : new Integer[] { 1, null }) {
2502 >        checkCompletedExceptionally(f, ex);
2503 >        checkCompletedNormally(g, v1);
2504 >        checkCompletedWithWrappedException(h0, ex);
2505 >        checkCompletedWithWrappedException(h1, ex);
2506 >        checkCompletedWithWrappedException(h2, ex);
2507 >        checkCompletedWithWrappedException(h3, ex);
2508 >        checkCompletedWithWrappedException(h4, ex);
2509 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2510 >    }}
2511  
2512 +    public void testAcceptEither_exceptionalCompletion2() {
2513 +        for (ExecutionMode m : ExecutionMode.values())
2514 +        for (boolean fFirst : new boolean[] { true, false })
2515 +        for (Integer v1 : new Integer[] { 1, null })
2516 +    {
2517          final CompletableFuture<Integer> f = new CompletableFuture<>();
2518          final CompletableFuture<Integer> g = new CompletableFuture<>();
1536        final Noop r = new Noop();
1537        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2519          final CFException ex = new CFException();
2520 +        final NoopConsumer[] rs = new NoopConsumer[6];
2521 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2522  
2523 <        g.completeExceptionally(ex);
2524 <        checkIncomplete(h);
2525 <        f.complete(v1);
2523 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2524 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2525 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2526 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2527 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2528 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2529  
2530 <        checkCompletedWithWrappedCFException(h, ex);
2531 <        checkCompletedWithWrappedCFException(g, ex);
2532 <        assertFalse(r.ran);
2533 <        checkCompletedNormally(f, v1);
2530 >        // unspecified behavior - both source completions available
2531 >        try {
2532 >            assertEquals(null, h0.join());
2533 >            rs[0].assertValue(v1);
2534 >        } catch (CompletionException ok) {
2535 >            checkCompletedWithWrappedException(h0, ex);
2536 >            rs[0].assertNotInvoked();
2537 >        }
2538 >        try {
2539 >            assertEquals(null, h1.join());
2540 >            rs[1].assertValue(v1);
2541 >        } catch (CompletionException ok) {
2542 >            checkCompletedWithWrappedException(h1, ex);
2543 >            rs[1].assertNotInvoked();
2544 >        }
2545 >        try {
2546 >            assertEquals(null, h2.join());
2547 >            rs[2].assertValue(v1);
2548 >        } catch (CompletionException ok) {
2549 >            checkCompletedWithWrappedException(h2, ex);
2550 >            rs[2].assertNotInvoked();
2551 >        }
2552 >        try {
2553 >            assertEquals(null, h3.join());
2554 >            rs[3].assertValue(v1);
2555 >        } catch (CompletionException ok) {
2556 >            checkCompletedWithWrappedException(h3, ex);
2557 >            rs[3].assertNotInvoked();
2558          }
1549    }
1550
1551    public void testRunAfterBoth_exceptionalCompletion3() {
1552        for (ExecutionMode m : ExecutionMode.values())
1553        for (Integer v1 : new Integer[] { 1, null }) {
1554
1555        final CompletableFuture<Integer> f = new CompletableFuture<>();
1556        final CompletableFuture<Integer> g = new CompletableFuture<>();
1557        final Noop r = new Noop();
1558        final CFException ex = new CFException();
1559
1560        g.completeExceptionally(ex);
1561        f.complete(v1);
1562        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2559  
1564        checkCompletedWithWrappedCFException(h, ex);
1565        checkCompletedWithWrappedCFException(g, ex);
1566        assertFalse(r.ran);
2560          checkCompletedNormally(f, v1);
2561 <        }
2562 <    }
2561 >        checkCompletedExceptionally(g, ex);
2562 >    }}
2563  
2564 <    public void testRunAfterBoth_exceptionalCompletion4() {
2564 >    /**
2565 >     * acceptEither result completes exceptionally if either source cancelled
2566 >     */
2567 >    public void testAcceptEither_sourceCancelled() {
2568          for (ExecutionMode m : ExecutionMode.values())
2569 <        for (Integer v1 : new Integer[] { 1, null }) {
2570 <
2569 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2570 >        for (Integer v1 : new Integer[] { 1, null })
2571 >    {
2572          final CompletableFuture<Integer> f = new CompletableFuture<>();
2573          final CompletableFuture<Integer> g = new CompletableFuture<>();
2574 <        final Noop r = new Noop();
2575 <        final CFException ex = new CFException();
2574 >        final NoopConsumer[] rs = new NoopConsumer[6];
2575 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2576 >
2577 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2578 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2579 >        checkIncomplete(h0);
2580 >        checkIncomplete(h1);
2581 >        rs[0].assertNotInvoked();
2582 >        rs[1].assertNotInvoked();
2583 >        f.cancel(mayInterruptIfRunning);
2584 >        checkCompletedWithWrappedCancellationException(h0);
2585 >        checkCompletedWithWrappedCancellationException(h1);
2586 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2587 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2588 >        checkCompletedWithWrappedCancellationException(h2);
2589 >        checkCompletedWithWrappedCancellationException(h3);
2590  
1580        f.completeExceptionally(ex);
2591          g.complete(v1);
1582        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2592  
2593 <        checkCompletedWithWrappedCFException(h, ex);
2594 <        checkCompletedWithWrappedCFException(f, ex);
2595 <        assertFalse(r.ran);
2596 <        checkCompletedNormally(g, v1);
2593 >        // unspecified behavior - both source completions available
2594 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2595 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2596 >        try {
2597 >            assertNull(h4.join());
2598 >            rs[4].assertValue(v1);
2599 >        } catch (CompletionException ok) {
2600 >            checkCompletedWithWrappedCancellationException(h4);
2601 >            rs[4].assertNotInvoked();
2602 >        }
2603 >        try {
2604 >            assertNull(h5.join());
2605 >            rs[5].assertValue(v1);
2606 >        } catch (CompletionException ok) {
2607 >            checkCompletedWithWrappedCancellationException(h5);
2608 >            rs[5].assertNotInvoked();
2609          }
2610 <    }
2610 >
2611 >        checkCancelled(f);
2612 >        checkCompletedNormally(g, v1);
2613 >        checkCompletedWithWrappedCancellationException(h0);
2614 >        checkCompletedWithWrappedCancellationException(h1);
2615 >        checkCompletedWithWrappedCancellationException(h2);
2616 >        checkCompletedWithWrappedCancellationException(h3);
2617 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2618 >    }}
2619  
2620      /**
2621 <     * runAfterBoth result completes exceptionally if action does
2621 >     * acceptEither result completes exceptionally if action does
2622       */
2623 <    public void testRunAfterBoth_actionFailed1() {
2623 >    public void testAcceptEither_actionFailed() {
2624          for (ExecutionMode m : ExecutionMode.values())
2625          for (Integer v1 : new Integer[] { 1, null })
2626 <        for (Integer v2 : new Integer[] { 2, null }) {
2627 <
2626 >        for (Integer v2 : new Integer[] { 2, null })
2627 >    {
2628          final CompletableFuture<Integer> f = new CompletableFuture<>();
2629          final CompletableFuture<Integer> g = new CompletableFuture<>();
2630 <        final FailingNoop r = new FailingNoop();
2631 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2630 >        final FailingConsumer[] rs = new FailingConsumer[6];
2631 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
2632 >
2633 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2634 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2635 >        f.complete(v1);
2636 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2637 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2638 >        checkCompletedWithWrappedException(h0, rs[0].ex);
2639 >        checkCompletedWithWrappedException(h1, rs[1].ex);
2640 >        checkCompletedWithWrappedException(h2, rs[2].ex);
2641 >        checkCompletedWithWrappedException(h3, rs[3].ex);
2642 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2643  
1604        f.complete(v1);
1605        checkIncomplete(h);
2644          g.complete(v2);
2645  
2646 <        checkCompletedWithWrappedCFException(h);
2646 >        // unspecified behavior - both source completions available
2647 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2648 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2649 >
2650 >        checkCompletedWithWrappedException(h4, rs[4].ex);
2651 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2652 >                   Objects.equals(v2, rs[4].value));
2653 >        checkCompletedWithWrappedException(h5, rs[5].ex);
2654 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2655 >                   Objects.equals(v2, rs[5].value));
2656 >
2657          checkCompletedNormally(f, v1);
2658          checkCompletedNormally(g, v2);
2659 <        }
1612 <    }
2659 >    }}
2660  
2661 <    public void testRunAfterBoth_actionFailed2() {
2661 >    /**
2662 >     * runAfterEither result completes normally after normal completion
2663 >     * of either source
2664 >     */
2665 >    public void testRunAfterEither_normalCompletion() {
2666          for (ExecutionMode m : ExecutionMode.values())
2667          for (Integer v1 : new Integer[] { 1, null })
2668 <        for (Integer v2 : new Integer[] { 2, null }) {
2669 <
2668 >        for (Integer v2 : new Integer[] { 2, null })
2669 >    {
2670          final CompletableFuture<Integer> f = new CompletableFuture<>();
2671          final CompletableFuture<Integer> g = new CompletableFuture<>();
2672 <        final FailingNoop r = new FailingNoop();
2673 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2672 >        final Noop[] rs = new Noop[6];
2673 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2674 >
2675 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2676 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2677 >        checkIncomplete(h0);
2678 >        checkIncomplete(h1);
2679 >        rs[0].assertNotInvoked();
2680 >        rs[1].assertNotInvoked();
2681 >        f.complete(v1);
2682 >        checkCompletedNormally(h0, null);
2683 >        checkCompletedNormally(h1, null);
2684 >        rs[0].assertInvoked();
2685 >        rs[1].assertInvoked();
2686 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2687 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2688 >        checkCompletedNormally(h2, null);
2689 >        checkCompletedNormally(h3, null);
2690 >        rs[2].assertInvoked();
2691 >        rs[3].assertInvoked();
2692  
2693          g.complete(v2);
1625        checkIncomplete(h);
1626        f.complete(v1);
2694  
2695 <        checkCompletedWithWrappedCFException(h);
2695 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2696 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2697 >
2698          checkCompletedNormally(f, v1);
2699          checkCompletedNormally(g, v2);
2700 <        }
2701 <    }
2700 >        checkCompletedNormally(h0, null);
2701 >        checkCompletedNormally(h1, null);
2702 >        checkCompletedNormally(h2, null);
2703 >        checkCompletedNormally(h3, null);
2704 >        checkCompletedNormally(h4, null);
2705 >        checkCompletedNormally(h5, null);
2706 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2707 >    }}
2708  
2709      /**
2710 <     * runAfterBoth result completes exceptionally if either source cancelled
2710 >     * runAfterEither result completes exceptionally after exceptional
2711 >     * completion of either source
2712       */
2713 <    public void testRunAfterBoth_sourceCancelled1() {
2713 >    public void testRunAfterEither_exceptionalCompletion() {
2714          for (ExecutionMode m : ExecutionMode.values())
2715 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2716 <        for (Integer v1 : new Integer[] { 1, null }) {
1641 <
2715 >        for (Integer v1 : new Integer[] { 1, null })
2716 >    {
2717          final CompletableFuture<Integer> f = new CompletableFuture<>();
2718          final CompletableFuture<Integer> g = new CompletableFuture<>();
2719 <        final Noop r = new Noop();
2720 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2719 >        final CFException ex = new CFException();
2720 >        final Noop[] rs = new Noop[6];
2721 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2722  
2723 <        assertTrue(f.cancel(mayInterruptIfRunning));
2724 <        checkIncomplete(h);
2725 <        g.complete(v1);
2723 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2724 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2725 >        checkIncomplete(h0);
2726 >        checkIncomplete(h1);
2727 >        rs[0].assertNotInvoked();
2728 >        rs[1].assertNotInvoked();
2729 >        assertTrue(f.completeExceptionally(ex));
2730 >        checkCompletedWithWrappedException(h0, ex);
2731 >        checkCompletedWithWrappedException(h1, ex);
2732 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2733 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2734 >        checkCompletedWithWrappedException(h2, ex);
2735 >        checkCompletedWithWrappedException(h3, ex);
2736 >
2737 >        assertTrue(g.complete(v1));
2738 >
2739 >        // unspecified behavior - both source completions available
2740 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2741 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2742 >        try {
2743 >            assertNull(h4.join());
2744 >            rs[4].assertInvoked();
2745 >        } catch (CompletionException ok) {
2746 >            checkCompletedWithWrappedException(h4, ex);
2747 >            rs[4].assertNotInvoked();
2748 >        }
2749 >        try {
2750 >            assertNull(h5.join());
2751 >            rs[5].assertInvoked();
2752 >        } catch (CompletionException ok) {
2753 >            checkCompletedWithWrappedException(h5, ex);
2754 >            rs[5].assertNotInvoked();
2755 >        }
2756  
2757 <        checkCompletedWithWrappedCancellationException(h);
1652 <        checkCancelled(f);
1653 <        assertFalse(r.ran);
2757 >        checkCompletedExceptionally(f, ex);
2758          checkCompletedNormally(g, v1);
2759 <        }
2760 <    }
2759 >        checkCompletedWithWrappedException(h0, ex);
2760 >        checkCompletedWithWrappedException(h1, ex);
2761 >        checkCompletedWithWrappedException(h2, ex);
2762 >        checkCompletedWithWrappedException(h3, ex);
2763 >        checkCompletedWithWrappedException(h4, ex);
2764 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2765 >    }}
2766  
2767 <    public void testRunAfterBoth_sourceCancelled2() {
2767 >    public void testRunAfterEither_exceptionalCompletion2() {
2768          for (ExecutionMode m : ExecutionMode.values())
2769 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2770 <        for (Integer v1 : new Integer[] { 1, null }) {
2771 <
2769 >        for (boolean fFirst : new boolean[] { true, false })
2770 >        for (Integer v1 : new Integer[] { 1, null })
2771 >    {
2772          final CompletableFuture<Integer> f = new CompletableFuture<>();
2773          final CompletableFuture<Integer> g = new CompletableFuture<>();
2774 <        final Noop r = new Noop();
2775 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2774 >        final CFException ex = new CFException();
2775 >        final Noop[] rs = new Noop[6];
2776 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2777  
2778 <        assertTrue(g.cancel(mayInterruptIfRunning));
2779 <        checkIncomplete(h);
2780 <        f.complete(v1);
2778 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2779 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2780 >        assertTrue( fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2781 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2782 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2783 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2784  
2785 <        checkCompletedWithWrappedCancellationException(h);
2786 <        checkCancelled(g);
2787 <        assertFalse(r.ran);
2788 <        checkCompletedNormally(f, v1);
2785 >        // unspecified behavior - both source completions available
2786 >        try {
2787 >            assertEquals(null, h0.join());
2788 >            rs[0].assertInvoked();
2789 >        } catch (CompletionException ok) {
2790 >            checkCompletedWithWrappedException(h0, ex);
2791 >            rs[0].assertNotInvoked();
2792 >        }
2793 >        try {
2794 >            assertEquals(null, h1.join());
2795 >            rs[1].assertInvoked();
2796 >        } catch (CompletionException ok) {
2797 >            checkCompletedWithWrappedException(h1, ex);
2798 >            rs[1].assertNotInvoked();
2799 >        }
2800 >        try {
2801 >            assertEquals(null, h2.join());
2802 >            rs[2].assertInvoked();
2803 >        } catch (CompletionException ok) {
2804 >            checkCompletedWithWrappedException(h2, ex);
2805 >            rs[2].assertNotInvoked();
2806 >        }
2807 >        try {
2808 >            assertEquals(null, h3.join());
2809 >            rs[3].assertInvoked();
2810 >        } catch (CompletionException ok) {
2811 >            checkCompletedWithWrappedException(h3, ex);
2812 >            rs[3].assertNotInvoked();
2813          }
1677    }
1678
1679    public void testRunAfterBoth_sourceCancelled3() {
1680        for (ExecutionMode m : ExecutionMode.values())
1681        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1682        for (Integer v1 : new Integer[] { 1, null }) {
1683
1684        final CompletableFuture<Integer> f = new CompletableFuture<>();
1685        final CompletableFuture<Integer> g = new CompletableFuture<>();
1686        final Noop r = new Noop();
1687
1688        assertTrue(g.cancel(mayInterruptIfRunning));
1689        f.complete(v1);
1690        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2814  
1692        checkCompletedWithWrappedCancellationException(h);
1693        checkCancelled(g);
1694        assertFalse(r.ran);
2815          checkCompletedNormally(f, v1);
2816 <        }
2817 <    }
2816 >        checkCompletedExceptionally(g, ex);
2817 >    }}
2818  
2819 <    public void testRunAfterBoth_sourceCancelled4() {
2819 >    /**
2820 >     * runAfterEither result completes exceptionally if either source cancelled
2821 >     */
2822 >    public void testRunAfterEither_sourceCancelled() {
2823          for (ExecutionMode m : ExecutionMode.values())
2824          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2825 <        for (Integer v1 : new Integer[] { 1, null }) {
2826 <
2825 >        for (Integer v1 : new Integer[] { 1, null })
2826 >    {
2827          final CompletableFuture<Integer> f = new CompletableFuture<>();
2828          final CompletableFuture<Integer> g = new CompletableFuture<>();
2829 <        final Noop r = new Noop();
2829 >        final Noop[] rs = new Noop[6];
2830 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2831  
2832 <        assertTrue(f.cancel(mayInterruptIfRunning));
2833 <        g.complete(v1);
2834 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
2832 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2833 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2834 >        checkIncomplete(h0);
2835 >        checkIncomplete(h1);
2836 >        rs[0].assertNotInvoked();
2837 >        rs[1].assertNotInvoked();
2838 >        f.cancel(mayInterruptIfRunning);
2839 >        checkCompletedWithWrappedCancellationException(h0);
2840 >        checkCompletedWithWrappedCancellationException(h1);
2841 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2842 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2843 >        checkCompletedWithWrappedCancellationException(h2);
2844 >        checkCompletedWithWrappedCancellationException(h3);
2845 >
2846 >        assertTrue(g.complete(v1));
2847 >
2848 >        // unspecified behavior - both source completions available
2849 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2850 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2851 >        try {
2852 >            assertNull(h4.join());
2853 >            rs[4].assertInvoked();
2854 >        } catch (CompletionException ok) {
2855 >            checkCompletedWithWrappedCancellationException(h4);
2856 >            rs[4].assertNotInvoked();
2857 >        }
2858 >        try {
2859 >            assertNull(h5.join());
2860 >            rs[5].assertInvoked();
2861 >        } catch (CompletionException ok) {
2862 >            checkCompletedWithWrappedCancellationException(h5);
2863 >            rs[5].assertNotInvoked();
2864 >        }
2865  
1712        checkCompletedWithWrappedCancellationException(h);
2866          checkCancelled(f);
1714        assertFalse(r.ran);
2867          checkCompletedNormally(g, v1);
2868 <        }
2869 <    }
2870 <
2871 <    /**
2872 <     * applyToEither result completes normally after normal completion
2873 <     * of either source
1722 <     */
1723 <    public void testApplyToEither() {
1724 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1725 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1726 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1727 <        f.complete(one);
1728 <        checkCompletedNormally(g, two);
1729 <        f2.complete(one);
1730 <        checkCompletedNormally(g, two);
1731 <
1732 <        f = new CompletableFuture<>();
1733 <        f.complete(one);
1734 <        f2 = new CompletableFuture<>();
1735 <        g = f.applyToEither(f2, inc);
1736 <        checkCompletedNormally(g, two);
1737 <    }
1738 <
1739 <    /**
1740 <     * applyToEither result completes exceptionally after exceptional
1741 <     * completion of either source
1742 <     */
1743 <    public void testApplyToEither2() {
1744 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1745 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1746 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1747 <        f.completeExceptionally(new CFException());
1748 <        f2.complete(one);
1749 <        checkCompletedWithWrappedCFException(g);
1750 <
1751 <        f = new CompletableFuture<>();
1752 <        f2 = new CompletableFuture<>();
1753 <        f2.completeExceptionally(new CFException());
1754 <        g = f.applyToEither(f2, inc);
1755 <        checkCompletedWithWrappedCFException(g);
1756 <    }
1757 <
1758 <    /**
1759 <     * applyToEither result completes exceptionally if action does
1760 <     */
1761 <    public void testApplyToEither3() {
1762 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1763 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1764 <        FailingFunction r = new FailingFunction();
1765 <        CompletableFuture<Integer> g = f.applyToEither(f2, r);
1766 <        f2.complete(two);
1767 <        checkCompletedWithWrappedCFException(g);
1768 <    }
1769 <
1770 <    /**
1771 <     * applyToEither result completes exceptionally if either source cancelled
1772 <     */
1773 <    public void testApplyToEither4() {
1774 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1775 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1776 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1777 <        assertTrue(f.cancel(true));
1778 <        checkCompletedWithWrappedCancellationException(g);
1779 <        f = new CompletableFuture<>();
1780 <        f2 = new CompletableFuture<>();
1781 <        assertTrue(f2.cancel(true));
1782 <        checkCompletedWithWrappedCancellationException(g);
1783 <    }
1784 <
1785 <    /**
1786 <     * acceptEither result completes normally after normal completion
1787 <     * of either source
1788 <     */
1789 <    public void testAcceptEither() {
1790 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1791 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1792 <        IncAction r = new IncAction();
1793 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1794 <        f.complete(one);
1795 <        checkCompletedNormally(g, null);
1796 <        f2.complete(one);
1797 <        checkCompletedNormally(g, null);
1798 <        assertEquals(r.value, 2);
1799 <
1800 <        r = new IncAction();
1801 <        f = new CompletableFuture<>();
1802 <        f.complete(one);
1803 <        f2 = new CompletableFuture<>();
1804 <        g = f.acceptEither(f2, r);
1805 <        checkCompletedNormally(g, null);
1806 <        assertEquals(r.value, 2);
1807 <    }
1808 <
1809 <    /**
1810 <     * acceptEither result completes exceptionally after exceptional
1811 <     * completion of either source
1812 <     */
1813 <    public void testAcceptEither2() {
1814 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1815 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1816 <        IncAction r = new IncAction();
1817 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1818 <        f.completeExceptionally(new CFException());
1819 <        f2.complete(one);
1820 <        checkCompletedWithWrappedCFException(g);
1821 <
1822 <        r = new IncAction();
1823 <        f = new CompletableFuture<>();
1824 <        f2 = new CompletableFuture<>();
1825 <        f2.completeExceptionally(new CFException());
1826 <        g = f.acceptEither(f2, r);
1827 <        checkCompletedWithWrappedCFException(g);
1828 <    }
1829 <
1830 <    /**
1831 <     * acceptEither result completes exceptionally if action does
1832 <     */
1833 <    public void testAcceptEither3() {
1834 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1835 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1836 <        FailingConsumer r = new FailingConsumer();
1837 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1838 <        f2.complete(two);
1839 <        checkCompletedWithWrappedCFException(g);
1840 <    }
1841 <
1842 <    /**
1843 <     * acceptEither result completes exceptionally if either source cancelled
1844 <     */
1845 <    public void testAcceptEither4() {
1846 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1847 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1848 <        IncAction r = new IncAction();
1849 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1850 <        assertTrue(f.cancel(true));
1851 <        checkCompletedWithWrappedCancellationException(g);
1852 <        f = new CompletableFuture<>();
1853 <        f2 = new CompletableFuture<>();
1854 <        assertTrue(f2.cancel(true));
1855 <        checkCompletedWithWrappedCancellationException(g);
1856 <    }
1857 <
1858 <    /**
1859 <     * runAfterEither result completes normally after normal completion
1860 <     * of either source
1861 <     */
1862 <    public void testRunAfterEither() {
1863 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1864 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1865 <        Noop r = new Noop();
1866 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1867 <        f.complete(one);
1868 <        checkCompletedNormally(g, null);
1869 <        f2.complete(one);
1870 <        checkCompletedNormally(g, null);
1871 <        assertTrue(r.ran);
1872 <
1873 <        r = new Noop();
1874 <        f = new CompletableFuture<>();
1875 <        f.complete(one);
1876 <        f2 = new CompletableFuture<>();
1877 <        g = f.runAfterEither(f2, r);
1878 <        checkCompletedNormally(g, null);
1879 <        assertTrue(r.ran);
1880 <    }
1881 <
1882 <    /**
1883 <     * runAfterEither result completes exceptionally after exceptional
1884 <     * completion of either source
1885 <     */
1886 <    public void testRunAfterEither2() {
1887 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1888 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
1889 <        Noop r = new Noop();
1890 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1891 <        f.completeExceptionally(new CFException());
1892 <        f2.complete(one);
1893 <        checkCompletedWithWrappedCFException(g);
1894 <
1895 <        r = new Noop();
1896 <        f = new CompletableFuture<>();
1897 <        f2 = new CompletableFuture<>();
1898 <        f2.completeExceptionally(new CFException());
1899 <        g = f.runAfterEither(f2, r);
1900 <        checkCompletedWithWrappedCFException(g);
1901 <    }
2868 >        checkCompletedWithWrappedCancellationException(h0);
2869 >        checkCompletedWithWrappedCancellationException(h1);
2870 >        checkCompletedWithWrappedCancellationException(h2);
2871 >        checkCompletedWithWrappedCancellationException(h3);
2872 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2873 >    }}
2874  
2875      /**
2876       * runAfterEither result completes exceptionally if action does
2877       */
2878 <    public void testRunAfterEither3() {
2879 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2880 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2881 <        FailingNoop r = new FailingNoop();
2882 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
2883 <        f2.complete(two);
2884 <        checkCompletedWithWrappedCFException(g);
2885 <    }
2878 >    public void testRunAfterEither_actionFailed() {
2879 >        for (ExecutionMode m : ExecutionMode.values())
2880 >        for (Integer v1 : new Integer[] { 1, null })
2881 >        for (Integer v2 : new Integer[] { 2, null })
2882 >    {
2883 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2884 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2885 >        final FailingRunnable[] rs = new FailingRunnable[6];
2886 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2887  
2888 <    /**
2889 <     * runAfterEither result completes exceptionally if either source cancelled
2890 <     */
2891 <    public void testRunAfterEither4() {
2892 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2893 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2894 <        Noop r = new Noop();
2895 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
2896 <        assertTrue(f.cancel(true));
2897 <        checkCompletedWithWrappedCancellationException(g);
2898 <        f = new CompletableFuture<>();
2899 <        f2 = new CompletableFuture<>();
2900 <        assertTrue(f2.cancel(true));
2901 <        checkCompletedWithWrappedCancellationException(g);
2902 <    }
2888 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2889 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2890 >        assertTrue(f.complete(v1));
2891 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2892 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2893 >        checkCompletedWithWrappedException(h0, rs[0].ex);
2894 >        checkCompletedWithWrappedException(h1, rs[1].ex);
2895 >        checkCompletedWithWrappedException(h2, rs[2].ex);
2896 >        checkCompletedWithWrappedException(h3, rs[3].ex);
2897 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2898 >        assertTrue(g.complete(v2));
2899 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2900 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2901 >        checkCompletedWithWrappedException(h4, rs[4].ex);
2902 >        checkCompletedWithWrappedException(h5, rs[5].ex);
2903 >
2904 >        checkCompletedNormally(f, v1);
2905 >        checkCompletedNormally(g, v2);
2906 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2907 >    }}
2908  
2909      /**
2910       * thenCompose result completes normally after normal completion of source
2911       */
2912 <    public void testThenCompose() {
2913 <        CompletableFuture<Integer> f, g;
2914 <        CompletableFutureInc r;
2915 <
2916 <        f = new CompletableFuture<>();
2917 <        g = f.thenCompose(r = new CompletableFutureInc());
2918 <        f.complete(one);
2919 <        checkCompletedNormally(g, two);
2920 <        assertTrue(r.ran);
2912 >    public void testThenCompose_normalCompletion() {
2913 >        for (ExecutionMode m : ExecutionMode.values())
2914 >        for (boolean createIncomplete : new boolean[] { true, false })
2915 >        for (Integer v1 : new Integer[] { 1, null })
2916 >    {
2917 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2918 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2919 >        if (!createIncomplete) assertTrue(f.complete(v1));
2920 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2921 >        if (createIncomplete) assertTrue(f.complete(v1));
2922  
2923 <        f = new CompletableFuture<>();
2924 <        f.complete(one);
2925 <        g = f.thenCompose(r = new CompletableFutureInc());
2926 <        checkCompletedNormally(g, two);
1948 <        assertTrue(r.ran);
1949 <    }
2923 >        checkCompletedNormally(g, inc(v1));
2924 >        checkCompletedNormally(f, v1);
2925 >        r.assertValue(v1);
2926 >    }}
2927  
2928      /**
2929       * thenCompose result completes exceptionally after exceptional
2930       * completion of source
2931       */
2932 <    public void testThenCompose2() {
2933 <        CompletableFuture<Integer> f, g;
2934 <        CompletableFutureInc r;
2935 <
2936 <        f = new CompletableFuture<>();
2937 <        g = f.thenCompose(r = new CompletableFutureInc());
2938 <        f.completeExceptionally(new CFException());
2939 <        checkCompletedWithWrappedCFException(g);
2940 <
2941 <        f = new CompletableFuture<>();
2942 <        f.completeExceptionally(new CFException());
2943 <        g = f.thenCompose(r = new CompletableFutureInc());
2944 <        checkCompletedWithWrappedCFException(g);
2945 <    }
2932 >    public void testThenCompose_exceptionalCompletion() {
2933 >        for (ExecutionMode m : ExecutionMode.values())
2934 >        for (boolean createIncomplete : new boolean[] { true, false })
2935 >    {
2936 >        final CFException ex = new CFException();
2937 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2938 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2939 >        if (!createIncomplete) f.completeExceptionally(ex);
2940 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2941 >        if (createIncomplete) f.completeExceptionally(ex);
2942 >
2943 >        checkCompletedWithWrappedException(g, ex);
2944 >        checkCompletedExceptionally(f, ex);
2945 >        r.assertNotInvoked();
2946 >    }}
2947  
2948      /**
2949       * thenCompose result completes exceptionally if action does
2950       */
2951 <    public void testThenCompose3() {
2952 <        CompletableFuture<Integer> f, g;
2953 <        FailingCompletableFutureFunction r;
2954 <
2955 <        f = new CompletableFuture<>();
2956 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2957 <        f.complete(one);
2958 <        checkCompletedWithWrappedCFException(g);
2951 >    public void testThenCompose_actionFailed() {
2952 >        for (ExecutionMode m : ExecutionMode.values())
2953 >        for (boolean createIncomplete : new boolean[] { true, false })
2954 >        for (Integer v1 : new Integer[] { 1, null })
2955 >    {
2956 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2957 >        final FailingCompletableFutureFunction r
2958 >            = new FailingCompletableFutureFunction(m);
2959 >        if (!createIncomplete) assertTrue(f.complete(v1));
2960 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2961 >        if (createIncomplete) assertTrue(f.complete(v1));
2962  
2963 <        f = new CompletableFuture<>();
2964 <        f.complete(one);
2965 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
1985 <        checkCompletedWithWrappedCFException(g);
1986 <    }
2963 >        checkCompletedWithWrappedException(g, r.ex);
2964 >        checkCompletedNormally(f, v1);
2965 >    }}
2966  
2967      /**
2968       * thenCompose result completes exceptionally if source cancelled
2969       */
2970 <    public void testThenCompose4() {
2971 <        CompletableFuture<Integer> f, g;
2972 <        CompletableFutureInc r;
2973 <
2974 <        f = new CompletableFuture<>();
2975 <        g = f.thenCompose(r = new CompletableFutureInc());
2976 <        assertTrue(f.cancel(true));
2977 <        checkCompletedWithWrappedCancellationException(g);
2978 <
2979 <        f = new CompletableFuture<>();
2980 <        assertTrue(f.cancel(true));
2981 <        g = f.thenCompose(r = new CompletableFutureInc());
2982 <        checkCompletedWithWrappedCancellationException(g);
2004 <    }
2005 <
2006 <    // asyncs
2007 <
2008 <    /**
2009 <     * thenRunAsync result completes normally after normal completion of source
2010 <     */
2011 <    public void testThenRunAsync() {
2012 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2013 <        Noop r = new Noop();
2014 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2015 <        f.complete(null);
2016 <        checkCompletedNormally(g, null);
2017 <
2018 <        // reordered version
2019 <        f = new CompletableFuture<>();
2020 <        f.complete(null);
2021 <        r = new Noop();
2022 <        g = f.thenRunAsync(r);
2023 <        checkCompletedNormally(g, null);
2024 <    }
2025 <
2026 <    /**
2027 <     * thenRunAsync result completes exceptionally after exceptional
2028 <     * completion of source
2029 <     */
2030 <    public void testThenRunAsync2() {
2031 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2032 <        Noop r = new Noop();
2033 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2034 <        f.completeExceptionally(new CFException());
2035 <        try {
2036 <            g.join();
2037 <            shouldThrow();
2038 <        } catch (CompletionException success) {}
2039 <        checkCompletedWithWrappedCFException(g);
2040 <    }
2041 <
2042 <    /**
2043 <     * thenRunAsync result completes exceptionally if action does
2044 <     */
2045 <    public void testThenRunAsync3() {
2046 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2047 <        FailingNoop r = new FailingNoop();
2048 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2049 <        f.complete(null);
2050 <        checkCompletedWithWrappedCFException(g);
2051 <    }
2052 <
2053 <    /**
2054 <     * thenRunAsync result completes exceptionally if source cancelled
2055 <     */
2056 <    public void testThenRunAsync4() {
2057 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2058 <        Noop r = new Noop();
2059 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2060 <        assertTrue(f.cancel(true));
2061 <        checkCompletedWithWrappedCancellationException(g);
2062 <    }
2063 <
2064 <    /**
2065 <     * thenApplyAsync result completes normally after normal completion of source
2066 <     */
2067 <    public void testThenApplyAsync() {
2068 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2069 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2070 <        f.complete(one);
2071 <        checkCompletedNormally(g, two);
2072 <    }
2073 <
2074 <    /**
2075 <     * thenApplyAsync result completes exceptionally after exceptional
2076 <     * completion of source
2077 <     */
2078 <    public void testThenApplyAsync2() {
2079 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2080 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2081 <        f.completeExceptionally(new CFException());
2082 <        checkCompletedWithWrappedCFException(g);
2083 <    }
2084 <
2085 <    /**
2086 <     * thenApplyAsync result completes exceptionally if action does
2087 <     */
2088 <    public void testThenApplyAsync3() {
2089 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2090 <        FailingFunction r = new FailingFunction();
2091 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
2092 <        f.complete(null);
2093 <        checkCompletedWithWrappedCFException(g);
2094 <    }
2095 <
2096 <    /**
2097 <     * thenApplyAsync result completes exceptionally if source cancelled
2098 <     */
2099 <    public void testThenApplyAsync4() {
2100 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2101 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2102 <        assertTrue(f.cancel(true));
2103 <        checkCompletedWithWrappedCancellationException(g);
2104 <    }
2105 <
2106 <    /**
2107 <     * thenAcceptAsync result completes normally after normal
2108 <     * completion of source
2109 <     */
2110 <    public void testThenAcceptAsync() {
2111 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2112 <        IncAction r = new IncAction();
2113 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2114 <        f.complete(one);
2115 <        checkCompletedNormally(g, null);
2116 <        assertEquals(r.value, 2);
2117 <    }
2118 <
2119 <    /**
2120 <     * thenAcceptAsync result completes exceptionally after exceptional
2121 <     * completion of source
2122 <     */
2123 <    public void testThenAcceptAsync2() {
2124 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2125 <        IncAction r = new IncAction();
2126 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2127 <        f.completeExceptionally(new CFException());
2128 <        checkCompletedWithWrappedCFException(g);
2129 <    }
2130 <
2131 <    /**
2132 <     * thenAcceptAsync result completes exceptionally if action does
2133 <     */
2134 <    public void testThenAcceptAsync3() {
2135 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2136 <        FailingConsumer r = new FailingConsumer();
2137 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2138 <        f.complete(null);
2139 <        checkCompletedWithWrappedCFException(g);
2140 <    }
2141 <
2142 <    /**
2143 <     * thenAcceptAsync result completes exceptionally if source cancelled
2144 <     */
2145 <    public void testThenAcceptAsync4() {
2146 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2147 <        IncAction r = new IncAction();
2148 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2149 <        assertTrue(f.cancel(true));
2150 <        checkCompletedWithWrappedCancellationException(g);
2151 <    }
2152 <
2153 <    /**
2154 <     * applyToEitherAsync result completes normally after normal
2155 <     * completion of sources
2156 <     */
2157 <    public void testApplyToEitherAsync() {
2158 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2159 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2160 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2161 <        f.complete(one);
2162 <        checkCompletedNormally(g, two);
2163 <
2164 <        f = new CompletableFuture<>();
2165 <        f.complete(one);
2166 <        f2 = new CompletableFuture<>();
2167 <        g = f.applyToEitherAsync(f2, inc);
2168 <        checkCompletedNormally(g, two);
2169 <    }
2170 <
2171 <    /**
2172 <     * applyToEitherAsync result completes exceptionally after exceptional
2173 <     * completion of source
2174 <     */
2175 <    public void testApplyToEitherAsync2() {
2176 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2177 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2178 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2179 <        f.completeExceptionally(new CFException());
2180 <        checkCompletedWithWrappedCFException(g);
2181 <
2182 <        f = new CompletableFuture<>();
2183 <        f2 = new CompletableFuture<>();
2184 <        f2.completeExceptionally(new CFException());
2185 <        g = f.applyToEitherAsync(f2, inc);
2186 <        f.complete(one);
2187 <        checkCompletedWithWrappedCFException(g);
2188 <    }
2189 <
2190 <    /**
2191 <     * applyToEitherAsync result completes exceptionally if action does
2192 <     */
2193 <    public void testApplyToEitherAsync3() {
2194 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2195 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2196 <        FailingFunction r = new FailingFunction();
2197 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, r);
2198 <        f.complete(one);
2199 <        checkCompletedWithWrappedCFException(g);
2200 <    }
2201 <
2202 <    /**
2203 <     * applyToEitherAsync result completes exceptionally if either source cancelled
2204 <     */
2205 <    public void testApplyToEitherAsync4() {
2206 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2207 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2208 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2209 <        assertTrue(f.cancel(true));
2210 <        checkCompletedWithWrappedCancellationException(g);
2211 <
2212 <        f = new CompletableFuture<>();
2213 <        f2 = new CompletableFuture<>();
2214 <        assertTrue(f2.cancel(true));
2215 <        g = f.applyToEitherAsync(f2, inc);
2216 <        checkCompletedWithWrappedCancellationException(g);
2217 <    }
2218 <
2219 <    /**
2220 <     * acceptEitherAsync result completes normally after normal
2221 <     * completion of sources
2222 <     */
2223 <    public void testAcceptEitherAsync() {
2224 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2225 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2226 <        IncAction r = new IncAction();
2227 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2228 <        f.complete(one);
2229 <        checkCompletedNormally(g, null);
2230 <        assertEquals(r.value, 2);
2231 <
2232 <        r = new IncAction();
2233 <        f = new CompletableFuture<>();
2234 <        f.complete(one);
2235 <        f2 = new CompletableFuture<>();
2236 <        g = f.acceptEitherAsync(f2, r);
2237 <        checkCompletedNormally(g, null);
2238 <        assertEquals(r.value, 2);
2239 <    }
2240 <
2241 <    /**
2242 <     * acceptEitherAsync result completes exceptionally after exceptional
2243 <     * completion of source
2244 <     */
2245 <    public void testAcceptEitherAsync2() {
2246 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2247 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2248 <        IncAction r = new IncAction();
2249 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2250 <        f.completeExceptionally(new CFException());
2251 <        checkCompletedWithWrappedCFException(g);
2252 <
2253 <        r = new IncAction();
2254 <        f = new CompletableFuture<>();
2255 <        f2 = new CompletableFuture<>();
2256 <        f2.completeExceptionally(new CFException());
2257 <        g = f.acceptEitherAsync(f2, r);
2258 <        f.complete(one);
2259 <        checkCompletedWithWrappedCFException(g);
2260 <    }
2261 <
2262 <    /**
2263 <     * acceptEitherAsync result completes exceptionally if action does
2264 <     */
2265 <    public void testAcceptEitherAsync3() {
2266 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2267 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2268 <        FailingConsumer r = new FailingConsumer();
2269 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2270 <        f.complete(one);
2271 <        checkCompletedWithWrappedCFException(g);
2272 <    }
2273 <
2274 <    /**
2275 <     * acceptEitherAsync result completes exceptionally if either
2276 <     * source cancelled
2277 <     */
2278 <    public void testAcceptEitherAsync4() {
2279 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2280 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2281 <        IncAction r = new IncAction();
2282 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2283 <        assertTrue(f.cancel(true));
2284 <        checkCompletedWithWrappedCancellationException(g);
2285 <
2286 <        r = new IncAction();
2287 <        f = new CompletableFuture<>();
2288 <        f2 = new CompletableFuture<>();
2289 <        assertTrue(f2.cancel(true));
2290 <        g = f.acceptEitherAsync(f2, r);
2291 <        checkCompletedWithWrappedCancellationException(g);
2292 <    }
2293 <
2294 <    /**
2295 <     * runAfterEitherAsync result completes normally after normal
2296 <     * completion of sources
2297 <     */
2298 <    public void testRunAfterEitherAsync() {
2299 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2300 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2301 <        Noop r = new Noop();
2302 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2303 <        f.complete(one);
2304 <        checkCompletedNormally(g, null);
2305 <        assertTrue(r.ran);
2306 <
2307 <        r = new Noop();
2308 <        f = new CompletableFuture<>();
2309 <        f.complete(one);
2310 <        f2 = new CompletableFuture<>();
2311 <        g = f.runAfterEitherAsync(f2, r);
2312 <        checkCompletedNormally(g, null);
2313 <        assertTrue(r.ran);
2314 <    }
2315 <
2316 <    /**
2317 <     * runAfterEitherAsync result completes exceptionally after exceptional
2318 <     * completion of source
2319 <     */
2320 <    public void testRunAfterEitherAsync2() {
2321 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2322 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2323 <        Noop r = new Noop();
2324 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2325 <        f.completeExceptionally(new CFException());
2326 <        checkCompletedWithWrappedCFException(g);
2327 <
2328 <        r = new Noop();
2329 <        f = new CompletableFuture<>();
2330 <        f2 = new CompletableFuture<>();
2331 <        f2.completeExceptionally(new CFException());
2332 <        g = f.runAfterEitherAsync(f2, r);
2333 <        f.complete(one);
2334 <        checkCompletedWithWrappedCFException(g);
2335 <    }
2336 <
2337 <    /**
2338 <     * runAfterEitherAsync result completes exceptionally if action does
2339 <     */
2340 <    public void testRunAfterEitherAsync3() {
2341 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2342 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2343 <        FailingNoop r = new FailingNoop();
2344 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2345 <        f.complete(one);
2346 <        checkCompletedWithWrappedCFException(g);
2347 <    }
2348 <
2349 <    /**
2350 <     * runAfterEitherAsync result completes exceptionally if either
2351 <     * source cancelled
2352 <     */
2353 <    public void testRunAfterEitherAsync4() {
2354 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2355 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2356 <        Noop r = new Noop();
2357 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2358 <        assertTrue(f.cancel(true));
2359 <        checkCompletedWithWrappedCancellationException(g);
2360 <
2361 <        r = new Noop();
2362 <        f = new CompletableFuture<>();
2363 <        f2 = new CompletableFuture<>();
2364 <        assertTrue(f2.cancel(true));
2365 <        g = f.runAfterEitherAsync(f2, r);
2366 <        checkCompletedWithWrappedCancellationException(g);
2367 <    }
2368 <
2369 <    /**
2370 <     * thenComposeAsync result completes normally after normal
2371 <     * completion of source
2372 <     */
2373 <    public void testThenComposeAsync() {
2374 <        CompletableFuture<Integer> f, g;
2375 <        CompletableFutureInc r;
2376 <
2377 <        f = new CompletableFuture<>();
2378 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2379 <        f.complete(one);
2380 <        checkCompletedNormally(g, two);
2381 <
2382 <        f = new CompletableFuture<>();
2383 <        f.complete(one);
2384 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2385 <        checkCompletedNormally(g, two);
2386 <    }
2387 <
2388 <    /**
2389 <     * thenComposeAsync result completes exceptionally after
2390 <     * exceptional completion of source
2391 <     */
2392 <    public void testThenComposeAsync2() {
2393 <        CompletableFuture<Integer> f, g;
2394 <        CompletableFutureInc r;
2395 <
2396 <        f = new CompletableFuture<>();
2397 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2398 <        f.completeExceptionally(new CFException());
2399 <        checkCompletedWithWrappedCFException(g);
2400 <        assertFalse(r.ran);
2401 <
2402 <        f = new CompletableFuture<>();
2403 <        f.completeExceptionally(new CFException());
2404 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2405 <        checkCompletedWithWrappedCFException(g);
2406 <        assertFalse(r.ran);
2407 <    }
2408 <
2409 <    /**
2410 <     * thenComposeAsync result completes exceptionally if action does
2411 <     */
2412 <    public void testThenComposeAsync3() {
2413 <        CompletableFuture<Integer> f, g;
2414 <        FailingCompletableFutureFunction r;
2415 <
2416 <        f = new CompletableFuture<>();
2417 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
2418 <        f.complete(one);
2419 <        checkCompletedWithWrappedCFException(g);
2420 <
2421 <        f = new CompletableFuture<>();
2422 <        f.complete(one);
2423 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
2424 <        checkCompletedWithWrappedCFException(g);
2425 <    }
2426 <
2427 <    /**
2428 <     * thenComposeAsync result completes exceptionally if source cancelled
2429 <     */
2430 <    public void testThenComposeAsync4() {
2431 <        CompletableFuture<Integer> f, g;
2432 <        CompletableFutureInc r;
2433 <
2434 <        f = new CompletableFuture<>();
2435 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2436 <        assertTrue(f.cancel(true));
2437 <        checkCompletedWithWrappedCancellationException(g);
2438 <
2439 <        f = new CompletableFuture<>();
2440 <        assertTrue(f.cancel(true));
2441 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2442 <        checkCompletedWithWrappedCancellationException(g);
2443 <    }
2444 <
2445 <    // async with explicit executors
2446 <
2447 <    /**
2448 <     * thenRunAsync result completes normally after normal completion of source
2449 <     */
2450 <    public void testThenRunAsyncE() {
2451 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2452 <        Noop r = new Noop();
2453 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2454 <        f.complete(null);
2455 <        checkCompletedNormally(g, null);
2456 <
2457 <        // reordered version
2458 <        f = new CompletableFuture<>();
2459 <        f.complete(null);
2460 <        r = new Noop();
2461 <        g = f.thenRunAsync(r, new ThreadExecutor());
2462 <        checkCompletedNormally(g, null);
2463 <    }
2464 <
2465 <    /**
2466 <     * thenRunAsync result completes exceptionally after exceptional
2467 <     * completion of source
2468 <     */
2469 <    public void testThenRunAsync2E() {
2470 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2471 <        Noop r = new Noop();
2472 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2473 <        f.completeExceptionally(new CFException());
2474 <        try {
2475 <            g.join();
2476 <            shouldThrow();
2477 <        } catch (CompletionException success) {}
2478 <        checkCompletedWithWrappedCFException(g);
2479 <    }
2480 <
2481 <    /**
2482 <     * thenRunAsync result completes exceptionally if action does
2483 <     */
2484 <    public void testThenRunAsync3E() {
2485 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2486 <        FailingNoop r = new FailingNoop();
2487 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2488 <        f.complete(null);
2489 <        checkCompletedWithWrappedCFException(g);
2490 <    }
2491 <
2492 <    /**
2493 <     * thenRunAsync result completes exceptionally if source cancelled
2494 <     */
2495 <    public void testThenRunAsync4E() {
2496 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2497 <        Noop r = new Noop();
2498 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
2499 <        assertTrue(f.cancel(true));
2500 <        checkCompletedWithWrappedCancellationException(g);
2501 <    }
2502 <
2503 <    /**
2504 <     * thenApplyAsync result completes normally after normal completion of source
2505 <     */
2506 <    public void testThenApplyAsyncE() {
2507 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2508 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
2509 <        f.complete(one);
2510 <        checkCompletedNormally(g, two);
2511 <    }
2512 <
2513 <    /**
2514 <     * thenApplyAsync result completes exceptionally after exceptional
2515 <     * completion of source
2516 <     */
2517 <    public void testThenApplyAsync2E() {
2518 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2519 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
2520 <        f.completeExceptionally(new CFException());
2521 <        checkCompletedWithWrappedCFException(g);
2522 <    }
2523 <
2524 <    /**
2525 <     * thenApplyAsync result completes exceptionally if action does
2526 <     */
2527 <    public void testThenApplyAsync3E() {
2528 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2529 <        FailingFunction r = new FailingFunction();
2530 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
2531 <        f.complete(null);
2532 <        checkCompletedWithWrappedCFException(g);
2533 <    }
2534 <
2535 <    /**
2536 <     * thenApplyAsync result completes exceptionally if source cancelled
2537 <     */
2538 <    public void testThenApplyAsync4E() {
2539 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2540 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
2541 <        assertTrue(f.cancel(true));
2542 <        checkCompletedWithWrappedCancellationException(g);
2543 <    }
2544 <
2545 <    /**
2546 <     * thenAcceptAsync result completes normally after normal
2547 <     * completion of source
2548 <     */
2549 <    public void testThenAcceptAsyncE() {
2550 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2551 <        IncAction r = new IncAction();
2552 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2553 <        f.complete(one);
2554 <        checkCompletedNormally(g, null);
2555 <        assertEquals(r.value, 2);
2556 <    }
2557 <
2558 <    /**
2559 <     * thenAcceptAsync result completes exceptionally after exceptional
2560 <     * completion of source
2561 <     */
2562 <    public void testThenAcceptAsync2E() {
2563 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2564 <        IncAction r = new IncAction();
2565 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2566 <        f.completeExceptionally(new CFException());
2567 <        checkCompletedWithWrappedCFException(g);
2568 <    }
2569 <
2570 <    /**
2571 <     * thenAcceptAsync result completes exceptionally if action does
2572 <     */
2573 <    public void testThenAcceptAsync3E() {
2574 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2575 <        FailingConsumer r = new FailingConsumer();
2576 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2577 <        f.complete(null);
2578 <        checkCompletedWithWrappedCFException(g);
2579 <    }
2580 <
2581 <    /**
2582 <     * thenAcceptAsync result completes exceptionally if source cancelled
2583 <     */
2584 <    public void testThenAcceptAsync4E() {
2585 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2586 <        IncAction r = new IncAction();
2587 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
2588 <        assertTrue(f.cancel(true));
2589 <        checkCompletedWithWrappedCancellationException(g);
2590 <    }
2591 <
2592 <    /**
2593 <     * applyToEitherAsync result completes normally after normal
2594 <     * completion of sources
2595 <     */
2596 <    public void testApplyToEitherAsyncE() {
2597 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2598 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2599 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2600 <        f.complete(one);
2601 <        checkCompletedNormally(g, two);
2602 <
2603 <        f = new CompletableFuture<>();
2604 <        f.complete(one);
2605 <        f2 = new CompletableFuture<>();
2606 <        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2607 <        checkCompletedNormally(g, two);
2608 <    }
2609 <
2610 <    /**
2611 <     * applyToEitherAsync result completes exceptionally after exceptional
2612 <     * completion of source
2613 <     */
2614 <    public void testApplyToEitherAsync2E() {
2615 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2616 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2617 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2618 <        f.completeExceptionally(new CFException());
2619 <        checkCompletedWithWrappedCFException(g);
2620 <
2621 <        f = new CompletableFuture<>();
2622 <        f2 = new CompletableFuture<>();
2623 <        f2.completeExceptionally(new CFException());
2624 <        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2625 <        f.complete(one);
2626 <        checkCompletedWithWrappedCFException(g);
2627 <    }
2628 <
2629 <    /**
2630 <     * applyToEitherAsync result completes exceptionally if action does
2631 <     */
2632 <    public void testApplyToEitherAsync3E() {
2633 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2634 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2635 <        FailingFunction r = new FailingFunction();
2636 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, r, new ThreadExecutor());
2637 <        f.complete(one);
2638 <        checkCompletedWithWrappedCFException(g);
2639 <    }
2640 <
2641 <    /**
2642 <     * applyToEitherAsync result completes exceptionally if either source cancelled
2643 <     */
2644 <    public void testApplyToEitherAsync4E() {
2645 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2646 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2647 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2648 <        assertTrue(f.cancel(true));
2649 <        checkCompletedWithWrappedCancellationException(g);
2650 <
2651 <        f = new CompletableFuture<>();
2652 <        f2 = new CompletableFuture<>();
2653 <        assertTrue(f2.cancel(true));
2654 <        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2655 <        checkCompletedWithWrappedCancellationException(g);
2656 <    }
2657 <
2658 <    /**
2659 <     * acceptEitherAsync result completes normally after normal
2660 <     * completion of sources
2661 <     */
2662 <    public void testAcceptEitherAsyncE() {
2663 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2664 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2665 <        IncAction r = new IncAction();
2666 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2667 <        f.complete(one);
2668 <        checkCompletedNormally(g, null);
2669 <        assertEquals(r.value, 2);
2670 <
2671 <        r = new IncAction();
2672 <        f = new CompletableFuture<>();
2673 <        f.complete(one);
2674 <        f2 = new CompletableFuture<>();
2675 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2676 <        checkCompletedNormally(g, null);
2677 <        assertEquals(r.value, 2);
2678 <    }
2679 <
2680 <    /**
2681 <     * acceptEitherAsync result completes exceptionally after exceptional
2682 <     * completion of source
2683 <     */
2684 <    public void testAcceptEitherAsync2E() {
2685 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2686 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2687 <        IncAction r = new IncAction();
2688 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2689 <        f.completeExceptionally(new CFException());
2690 <        checkCompletedWithWrappedCFException(g);
2691 <
2692 <        r = new IncAction();
2693 <        f = new CompletableFuture<>();
2694 <        f2 = new CompletableFuture<>();
2695 <        f2.completeExceptionally(new CFException());
2696 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2697 <        f.complete(one);
2698 <        checkCompletedWithWrappedCFException(g);
2699 <    }
2700 <
2701 <    /**
2702 <     * acceptEitherAsync result completes exceptionally if action does
2703 <     */
2704 <    public void testAcceptEitherAsync3E() {
2705 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2706 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2707 <        FailingConsumer r = new FailingConsumer();
2708 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2709 <        f.complete(one);
2710 <        checkCompletedWithWrappedCFException(g);
2711 <    }
2712 <
2713 <    /**
2714 <     * acceptEitherAsync result completes exceptionally if either
2715 <     * source cancelled
2716 <     */
2717 <    public void testAcceptEitherAsync4E() {
2718 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2719 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2720 <        IncAction r = new IncAction();
2721 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2722 <        assertTrue(f.cancel(true));
2723 <        checkCompletedWithWrappedCancellationException(g);
2724 <
2725 <        r = new IncAction();
2726 <        f = new CompletableFuture<>();
2727 <        f2 = new CompletableFuture<>();
2728 <        assertTrue(f2.cancel(true));
2729 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2730 <        checkCompletedWithWrappedCancellationException(g);
2731 <    }
2732 <
2733 <    /**
2734 <     * runAfterEitherAsync result completes normally after normal
2735 <     * completion of sources
2736 <     */
2737 <    public void testRunAfterEitherAsyncE() {
2738 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2739 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2740 <        Noop r = new Noop();
2741 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2742 <        f.complete(one);
2743 <        checkCompletedNormally(g, null);
2744 <        assertTrue(r.ran);
2745 <
2746 <        r = new Noop();
2747 <        f = new CompletableFuture<>();
2748 <        f.complete(one);
2749 <        f2 = new CompletableFuture<>();
2750 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2751 <        checkCompletedNormally(g, null);
2752 <        assertTrue(r.ran);
2753 <    }
2754 <
2755 <    /**
2756 <     * runAfterEitherAsync result completes exceptionally after exceptional
2757 <     * completion of source
2758 <     */
2759 <    public void testRunAfterEitherAsync2E() {
2760 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2761 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2762 <        Noop r = new Noop();
2763 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2764 <        f.completeExceptionally(new CFException());
2765 <        checkCompletedWithWrappedCFException(g);
2766 <
2767 <        r = new Noop();
2768 <        f = new CompletableFuture<>();
2769 <        f2 = new CompletableFuture<>();
2770 <        f2.completeExceptionally(new CFException());
2771 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2772 <        f.complete(one);
2773 <        checkCompletedWithWrappedCFException(g);
2774 <    }
2775 <
2776 <    /**
2777 <     * runAfterEitherAsync result completes exceptionally if action does
2778 <     */
2779 <    public void testRunAfterEitherAsync3E() {
2780 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2781 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2782 <        FailingNoop r = new FailingNoop();
2783 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2784 <        f.complete(one);
2785 <        checkCompletedWithWrappedCFException(g);
2786 <    }
2787 <
2788 <    /**
2789 <     * runAfterEitherAsync result completes exceptionally if either
2790 <     * source cancelled
2791 <     */
2792 <    public void testRunAfterEitherAsync4E() {
2793 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2794 <        CompletableFuture<Integer> f2 = new CompletableFuture<>();
2795 <        Noop r = new Noop();
2796 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2797 <        assertTrue(f.cancel(true));
2798 <        checkCompletedWithWrappedCancellationException(g);
2970 >    public void testThenCompose_sourceCancelled() {
2971 >        for (ExecutionMode m : ExecutionMode.values())
2972 >        for (boolean createIncomplete : new boolean[] { true, false })
2973 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2974 >    {
2975 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2976 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2977 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2978 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2979 >        if (createIncomplete) {
2980 >            checkIncomplete(g);
2981 >            assertTrue(f.cancel(mayInterruptIfRunning));
2982 >        }
2983  
2800        r = new Noop();
2801        f = new CompletableFuture<>();
2802        f2 = new CompletableFuture<>();
2803        assertTrue(f2.cancel(true));
2804        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2984          checkCompletedWithWrappedCancellationException(g);
2985 <    }
2986 <
2808 <    /**
2809 <     * thenComposeAsync result completes normally after normal
2810 <     * completion of source
2811 <     */
2812 <    public void testThenComposeAsyncE() {
2813 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2814 <        CompletableFutureInc r = new CompletableFutureInc();
2815 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2816 <        f.complete(one);
2817 <        checkCompletedNormally(g, two);
2818 <    }
2819 <
2820 <    /**
2821 <     * thenComposeAsync result completes exceptionally after
2822 <     * exceptional completion of source
2823 <     */
2824 <    public void testThenComposeAsync2E() {
2825 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2826 <        CompletableFutureInc r = new CompletableFutureInc();
2827 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2828 <        f.completeExceptionally(new CFException());
2829 <        checkCompletedWithWrappedCFException(g);
2830 <    }
2985 >        checkCancelled(f);
2986 >    }}
2987  
2988      /**
2989 <     * thenComposeAsync result completes exceptionally if action does
2989 >     * thenCompose result completes exceptionally if the result of the action does
2990       */
2991 <    public void testThenComposeAsync3E() {
2992 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2993 <        FailingCompletableFutureFunction r = new FailingCompletableFutureFunction();
2994 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2995 <        f.complete(one);
2996 <        checkCompletedWithWrappedCFException(g);
2997 <    }
2991 >    public void testThenCompose_actionReturnsFailingFuture() {
2992 >        for (ExecutionMode m : ExecutionMode.values())
2993 >        for (int order = 0; order < 6; order++)
2994 >        for (Integer v1 : new Integer[] { 1, null })
2995 >    {
2996 >        final CFException ex = new CFException();
2997 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2998 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2999 >        final CompletableFuture<Integer> h;
3000 >        // Test all permutations of orders
3001 >        switch (order) {
3002 >        case 0:
3003 >            assertTrue(f.complete(v1));
3004 >            assertTrue(g.completeExceptionally(ex));
3005 >            h = m.thenCompose(f, (x -> g));
3006 >            break;
3007 >        case 1:
3008 >            assertTrue(f.complete(v1));
3009 >            h = m.thenCompose(f, (x -> g));
3010 >            assertTrue(g.completeExceptionally(ex));
3011 >            break;
3012 >        case 2:
3013 >            assertTrue(g.completeExceptionally(ex));
3014 >            assertTrue(f.complete(v1));
3015 >            h = m.thenCompose(f, (x -> g));
3016 >            break;
3017 >        case 3:
3018 >            assertTrue(g.completeExceptionally(ex));
3019 >            h = m.thenCompose(f, (x -> g));
3020 >            assertTrue(f.complete(v1));
3021 >            break;
3022 >        case 4:
3023 >            h = m.thenCompose(f, (x -> g));
3024 >            assertTrue(f.complete(v1));
3025 >            assertTrue(g.completeExceptionally(ex));
3026 >            break;
3027 >        case 5:
3028 >            h = m.thenCompose(f, (x -> g));
3029 >            assertTrue(f.complete(v1));
3030 >            assertTrue(g.completeExceptionally(ex));
3031 >            break;
3032 >        default: throw new AssertionError();
3033 >        }
3034  
3035 <    /**
3036 <     * thenComposeAsync result completes exceptionally if source cancelled
3037 <     */
3038 <    public void testThenComposeAsync4E() {
2847 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2848 <        CompletableFutureInc r = new CompletableFutureInc();
2849 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2850 <        assertTrue(f.cancel(true));
2851 <        checkCompletedWithWrappedCancellationException(g);
2852 <    }
3035 >        checkCompletedExceptionally(g, ex);
3036 >        checkCompletedWithWrappedException(h, ex);
3037 >        checkCompletedNormally(f, v1);
3038 >    }}
3039  
3040      // other static methods
3041  
# Line 2867 | Line 3053 | public class CompletableFutureTest exten
3053       * when all components complete normally
3054       */
3055      public void testAllOf_normal() throws Exception {
3056 <        for (int k = 1; k < 20; ++k) {
3057 <            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3058 <            for (int i = 0; i < k; ++i)
3056 >        for (int k = 1; k < 10; k++) {
3057 >            CompletableFuture<Integer>[] fs
3058 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3059 >            for (int i = 0; i < k; i++)
3060 >                fs[i] = new CompletableFuture<>();
3061 >            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3062 >            for (int i = 0; i < k; i++) {
3063 >                checkIncomplete(f);
3064 >                checkIncomplete(CompletableFuture.allOf(fs));
3065 >                fs[i].complete(one);
3066 >            }
3067 >            checkCompletedNormally(f, null);
3068 >            checkCompletedNormally(CompletableFuture.allOf(fs), null);
3069 >        }
3070 >    }
3071 >
3072 >    public void testAllOf_normal_backwards() throws Exception {
3073 >        for (int k = 1; k < 10; k++) {
3074 >            CompletableFuture<Integer>[] fs
3075 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3076 >            for (int i = 0; i < k; i++)
3077                  fs[i] = new CompletableFuture<>();
3078              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3079 <            for (int i = 0; i < k; ++i) {
3079 >            for (int i = k - 1; i >= 0; i--) {
3080                  checkIncomplete(f);
3081                  checkIncomplete(CompletableFuture.allOf(fs));
3082                  fs[i].complete(one);
# Line 2882 | Line 3086 | public class CompletableFutureTest exten
3086          }
3087      }
3088  
3089 +    public void testAllOf_exceptional() throws Exception {
3090 +        for (int k = 1; k < 10; k++) {
3091 +            CompletableFuture<Integer>[] fs
3092 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3093 +            CFException ex = new CFException();
3094 +            for (int i = 0; i < k; i++)
3095 +                fs[i] = new CompletableFuture<>();
3096 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3097 +            for (int i = 0; i < k; i++) {
3098 +                checkIncomplete(f);
3099 +                checkIncomplete(CompletableFuture.allOf(fs));
3100 +                if (i != k / 2) {
3101 +                    fs[i].complete(i);
3102 +                    checkCompletedNormally(fs[i], i);
3103 +                } else {
3104 +                    fs[i].completeExceptionally(ex);
3105 +                    checkCompletedExceptionally(fs[i], ex);
3106 +                }
3107 +            }
3108 +            checkCompletedWithWrappedException(f, ex);
3109 +            checkCompletedWithWrappedException(CompletableFuture.allOf(fs), ex);
3110 +        }
3111 +    }
3112 +
3113      /**
3114       * anyOf(no component futures) returns an incomplete future
3115       */
3116      public void testAnyOf_empty() throws Exception {
3117 +        for (Integer v1 : new Integer[] { 1, null })
3118 +    {
3119          CompletableFuture<Object> f = CompletableFuture.anyOf();
3120          checkIncomplete(f);
3121 <    }
3121 >
3122 >        f.complete(v1);
3123 >        checkCompletedNormally(f, v1);
3124 >    }}
3125  
3126      /**
3127       * anyOf returns a future completed normally with a value when
3128       * a component future does
3129       */
3130      public void testAnyOf_normal() throws Exception {
3131 <        for (int k = 0; k < 10; ++k) {
3131 >        for (int k = 0; k < 10; k++) {
3132              CompletableFuture[] fs = new CompletableFuture[k];
3133 <            for (int i = 0; i < k; ++i)
3133 >            for (int i = 0; i < k; i++)
3134                  fs[i] = new CompletableFuture<>();
3135              CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3136              checkIncomplete(f);
3137 <            for (int i = 0; i < k; ++i) {
3138 <                fs[i].complete(one);
3139 <                checkCompletedNormally(f, one);
3140 <                checkCompletedNormally(CompletableFuture.anyOf(fs), one);
3137 >            for (int i = 0; i < k; i++) {
3138 >                fs[i].complete(i);
3139 >                checkCompletedNormally(f, 0);
3140 >                int x = (int) CompletableFuture.anyOf(fs).join();
3141 >                assertTrue(0 <= x && x <= i);
3142 >            }
3143 >        }
3144 >    }
3145 >    public void testAnyOf_normal_backwards() throws Exception {
3146 >        for (int k = 0; k < 10; k++) {
3147 >            CompletableFuture[] fs = new CompletableFuture[k];
3148 >            for (int i = 0; i < k; i++)
3149 >                fs[i] = new CompletableFuture<>();
3150 >            CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3151 >            checkIncomplete(f);
3152 >            for (int i = k - 1; i >= 0; i--) {
3153 >                fs[i].complete(i);
3154 >                checkCompletedNormally(f, k - 1);
3155 >                int x = (int) CompletableFuture.anyOf(fs).join();
3156 >                assertTrue(i <= x && x <= k - 1);
3157              }
3158          }
3159      }
# Line 2913 | Line 3162 | public class CompletableFutureTest exten
3162       * anyOf result completes exceptionally when any component does.
3163       */
3164      public void testAnyOf_exceptional() throws Exception {
3165 <        for (int k = 0; k < 10; ++k) {
3165 >        for (int k = 0; k < 10; k++) {
3166              CompletableFuture[] fs = new CompletableFuture[k];
3167 <            for (int i = 0; i < k; ++i)
3167 >            CFException[] exs = new CFException[k];
3168 >            for (int i = 0; i < k; i++) {
3169                  fs[i] = new CompletableFuture<>();
3170 +                exs[i] = new CFException();
3171 +            }
3172              CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3173              checkIncomplete(f);
3174 <            for (int i = 0; i < k; ++i) {
3175 <                fs[i].completeExceptionally(new CFException());
3176 <                checkCompletedWithWrappedCFException(f);
3174 >            for (int i = 0; i < k; i++) {
3175 >                fs[i].completeExceptionally(exs[i]);
3176 >                checkCompletedWithWrappedException(f, exs[0]);
3177 >                checkCompletedWithWrappedCFException(CompletableFuture.anyOf(fs));
3178 >            }
3179 >        }
3180 >    }
3181 >
3182 >    public void testAnyOf_exceptional_backwards() throws Exception {
3183 >        for (int k = 0; k < 10; k++) {
3184 >            CompletableFuture[] fs = new CompletableFuture[k];
3185 >            CFException[] exs = new CFException[k];
3186 >            for (int i = 0; i < k; i++) {
3187 >                fs[i] = new CompletableFuture<>();
3188 >                exs[i] = new CFException();
3189 >            }
3190 >            CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3191 >            checkIncomplete(f);
3192 >            for (int i = k - 1; i >= 0; i--) {
3193 >                fs[i].completeExceptionally(exs[i]);
3194 >                checkCompletedWithWrappedException(f, exs[k - 1]);
3195                  checkCompletedWithWrappedCFException(CompletableFuture.anyOf(fs));
3196              }
3197          }
# Line 2934 | Line 3204 | public class CompletableFutureTest exten
3204          CompletableFuture<Integer> f = new CompletableFuture<>();
3205          CompletableFuture<Integer> g = new CompletableFuture<>();
3206          CompletableFuture<Integer> nullFuture = (CompletableFuture<Integer>)null;
2937        CompletableFuture<?> h;
3207          ThreadExecutor exec = new ThreadExecutor();
3208  
3209          Runnable[] throwingActions = {
3210              () -> CompletableFuture.supplyAsync(null),
3211              () -> CompletableFuture.supplyAsync(null, exec),
3212 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
3212 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.SYNC, 42), null),
3213  
3214              () -> CompletableFuture.runAsync(null),
3215              () -> CompletableFuture.runAsync(null, exec),
# Line 3013 | Line 3282 | public class CompletableFutureTest exten
3282  
3283              () -> f.thenCompose(null),
3284              () -> f.thenComposeAsync(null),
3285 <            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
3285 >            () -> f.thenComposeAsync(new CompletableFutureInc(ExecutionMode.EXECUTOR), null),
3286              () -> f.thenComposeAsync(null, exec),
3287  
3288              () -> f.exceptionally(null),
# Line 3031 | Line 3300 | public class CompletableFutureTest exten
3300              () -> CompletableFuture.anyOf(null, f),
3301  
3302              () -> f.obtrudeException(null),
3303 +
3304 +            () -> CompletableFuture.delayedExecutor(1L, SECONDS, null),
3305 +            () -> CompletableFuture.delayedExecutor(1L, null, exec),
3306 +            () -> CompletableFuture.delayedExecutor(1L, null),
3307 +
3308 +            () -> f.orTimeout(1L, null),
3309 +            () -> f.completeOnTimeout(42, 1L, null),
3310 +
3311 +            () -> CompletableFuture.failedFuture(null),
3312 +            () -> CompletableFuture.failedStage(null),
3313          };
3314  
3315          assertThrows(NullPointerException.class, throwingActions);
# Line 3045 | Line 3324 | public class CompletableFutureTest exten
3324          assertSame(f, f.toCompletableFuture());
3325      }
3326  
3327 +    // jdk9
3328 +
3329      /**
3330 <     * whenComplete action executes on normal completion, propagating
3050 <     * source result.
3330 >     * newIncompleteFuture returns an incomplete CompletableFuture
3331       */
3332 <    public void testWhenComplete1() {
3333 <        final AtomicInteger a = new AtomicInteger();
3332 >    public void testNewIncompleteFuture() {
3333 >        for (Integer v1 : new Integer[] { 1, null })
3334 >    {
3335          CompletableFuture<Integer> f = new CompletableFuture<>();
3336 <        CompletableFuture<Integer> g =
3337 <            f.whenComplete((Integer x, Throwable t) -> a.getAndIncrement());
3338 <        f.complete(three);
3339 <        checkCompletedNormally(f, three);
3340 <        checkCompletedNormally(g, three);
3341 <        assertEquals(a.get(), 1);
3336 >        CompletableFuture<Integer> g = f.newIncompleteFuture();
3337 >        checkIncomplete(f);
3338 >        checkIncomplete(g);
3339 >        f.complete(v1);
3340 >        checkCompletedNormally(f, v1);
3341 >        checkIncomplete(g);
3342 >        g.complete(v1);
3343 >        checkCompletedNormally(g, v1);
3344 >        assertSame(g.getClass(), CompletableFuture.class);
3345 >    }}
3346 >
3347 >    /**
3348 >     * completedStage returns a completed CompletionStage
3349 >     */
3350 >    public void testCompletedStage() {
3351 >        AtomicInteger x = new AtomicInteger(0);
3352 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3353 >        CompletionStage<Integer> f = CompletableFuture.completedStage(1);
3354 >        f.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3355 >        assertEquals(x.get(), 1);
3356 >        assertNull(r.get());
3357      }
3358  
3359      /**
3360 <     * whenComplete action executes on exceptional completion, propagating
3361 <     * source result.
3360 >     * defaultExecutor by default returns the commonPool if
3361 >     * it supports more than one thread.
3362       */
3363 <    public void testWhenComplete2() {
3068 <        final AtomicInteger a = new AtomicInteger();
3363 >    public void testDefaultExecutor() {
3364          CompletableFuture<Integer> f = new CompletableFuture<>();
3365 <        CompletableFuture<Integer> g =
3366 <            f.whenComplete((Integer x, Throwable t) -> a.getAndIncrement());
3367 <        f.completeExceptionally(new CFException());
3368 <        assertTrue(f.isCompletedExceptionally());
3369 <        assertTrue(g.isCompletedExceptionally());
3370 <        assertEquals(a.get(), 1);
3365 >        Executor e = f.defaultExecutor();
3366 >        Executor c = ForkJoinPool.commonPool();
3367 >        if (ForkJoinPool.getCommonPoolParallelism() > 1)
3368 >            assertSame(e, c);
3369 >        else
3370 >            assertNotSame(e, c);
3371      }
3372  
3373      /**
3374 <     * If a whenComplete action throws an exception when triggered by
3375 <     * a normal completion, it completes exceptionally
3374 >     * failedFuture returns a CompletableFuture completed
3375 >     * exceptionally with the given Exception
3376       */
3377 <    public void testWhenComplete3() {
3378 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3379 <        CompletableFuture<Integer> g =
3380 <            f.whenComplete((Integer x, Throwable t) ->
3086 <                           { throw new CFException(); } );
3087 <        f.complete(three);
3088 <        checkCompletedNormally(f, three);
3089 <        assertTrue(g.isCompletedExceptionally());
3090 <        checkCompletedWithWrappedCFException(g);
3377 >    public void testFailedFuture() {
3378 >        CFException ex = new CFException();
3379 >        CompletableFuture<Integer> f = CompletableFuture.failedFuture(ex);
3380 >        checkCompletedExceptionally(f, ex);
3381      }
3382  
3383      /**
3384 <     * whenCompleteAsync action executes on normal completion, propagating
3095 <     * source result.
3384 >     * failedFuture(null) throws NPE
3385       */
3386 <    public void testWhenCompleteAsync1() {
3387 <        final AtomicInteger a = new AtomicInteger();
3388 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3389 <        CompletableFuture<Integer> g =
3390 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement());
3102 <        f.complete(three);
3103 <        checkCompletedNormally(f, three);
3104 <        checkCompletedNormally(g, three);
3105 <        assertEquals(a.get(), 1);
3386 >    public void testFailedFuture_null() {
3387 >        try {
3388 >            CompletableFuture<Integer> f = CompletableFuture.failedFuture(null);
3389 >            shouldThrow();
3390 >        } catch (NullPointerException success) {}
3391      }
3392  
3393      /**
3394 <     * whenCompleteAsync action executes on exceptional completion, propagating
3395 <     * source result.
3394 >     * copy returns a CompletableFuture that is completed normally,
3395 >     * with the same value, when source is.
3396       */
3397 <    public void testWhenCompleteAsync2() {
3113 <        final AtomicInteger a = new AtomicInteger();
3397 >    public void testCopy() {
3398          CompletableFuture<Integer> f = new CompletableFuture<>();
3399 <        CompletableFuture<Integer> g =
3400 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement());
3401 <        f.completeExceptionally(new CFException());
3402 <        checkCompletedWithWrappedCFException(f);
3403 <        checkCompletedWithWrappedCFException(g);
3399 >        CompletableFuture<Integer> g = f.copy();
3400 >        checkIncomplete(f);
3401 >        checkIncomplete(g);
3402 >        f.complete(1);
3403 >        checkCompletedNormally(f, 1);
3404 >        checkCompletedNormally(g, 1);
3405      }
3406  
3407      /**
3408 <     * If a whenCompleteAsync action throws an exception when
3409 <     * triggered by a normal completion, it completes exceptionally
3408 >     * copy returns a CompletableFuture that is completed exceptionally
3409 >     * when source is.
3410       */
3411 <    public void testWhenCompleteAsync3() {
3411 >    public void testCopy2() {
3412          CompletableFuture<Integer> f = new CompletableFuture<>();
3413 <        CompletableFuture<Integer> g =
3414 <            f.whenCompleteAsync((Integer x, Throwable t) ->
3415 <                           { throw new CFException(); } );
3416 <        f.complete(three);
3417 <        checkCompletedNormally(f, three);
3418 <        checkCompletedWithWrappedCFException(g);
3413 >        CompletableFuture<Integer> g = f.copy();
3414 >        checkIncomplete(f);
3415 >        checkIncomplete(g);
3416 >        CFException ex = new CFException();
3417 >        f.completeExceptionally(ex);
3418 >        checkCompletedExceptionally(f, ex);
3419 >        checkCompletedWithWrappedException(g, ex);
3420      }
3421  
3422      /**
3423 <     * whenCompleteAsync action executes on normal completion, propagating
3424 <     * source result.
3423 >     * minimalCompletionStage returns a CompletableFuture that is
3424 >     * completed normally, with the same value, when source is.
3425       */
3426 <    public void testWhenCompleteAsync1e() {
3141 <        final AtomicInteger a = new AtomicInteger();
3142 <        ThreadExecutor exec = new ThreadExecutor();
3426 >    public void testMinimalCompletionStage() {
3427          CompletableFuture<Integer> f = new CompletableFuture<>();
3428 <        CompletableFuture<Integer> g =
3429 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement(),
3430 <                                exec);
3431 <        f.complete(three);
3432 <        checkCompletedNormally(f, three);
3433 <        checkCompletedNormally(g, three);
3434 <        assertEquals(a.get(), 1);
3428 >        CompletionStage<Integer> g = f.minimalCompletionStage();
3429 >        AtomicInteger x = new AtomicInteger(0);
3430 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3431 >        checkIncomplete(f);
3432 >        g.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3433 >        f.complete(1);
3434 >        checkCompletedNormally(f, 1);
3435 >        assertEquals(x.get(), 1);
3436 >        assertNull(r.get());
3437      }
3438  
3439      /**
3440 <     * whenCompleteAsync action executes on exceptional completion, propagating
3441 <     * source result.
3440 >     * minimalCompletionStage returns a CompletableFuture that is
3441 >     * completed exceptionally when source is.
3442       */
3443 <    public void testWhenCompleteAsync2e() {
3158 <        final AtomicInteger a = new AtomicInteger();
3159 <        ThreadExecutor exec = new ThreadExecutor();
3443 >    public void testMinimalCompletionStage2() {
3444          CompletableFuture<Integer> f = new CompletableFuture<>();
3445 <        CompletableFuture<Integer> g =
3446 <            f.whenCompleteAsync((Integer x, Throwable t) -> a.getAndIncrement(),
3447 <                                exec);
3448 <        f.completeExceptionally(new CFException());
3449 <        checkCompletedWithWrappedCFException(f);
3450 <        checkCompletedWithWrappedCFException(g);
3445 >        CompletionStage<Integer> g = f.minimalCompletionStage();
3446 >        AtomicInteger x = new AtomicInteger(0);
3447 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3448 >        g.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3449 >        checkIncomplete(f);
3450 >        CFException ex = new CFException();
3451 >        f.completeExceptionally(ex);
3452 >        checkCompletedExceptionally(f, ex);
3453 >        assertEquals(x.get(), 0);
3454 >        assertEquals(r.get().getCause(), ex);
3455      }
3456  
3457      /**
3458 <     * If a whenCompleteAsync action throws an exception when triggered
3459 <     * by a normal completion, it completes exceptionally
3458 >     * failedStage returns a CompletionStage completed
3459 >     * exceptionally with the given Exception
3460       */
3461 <    public void testWhenCompleteAsync3e() {
3462 <        ThreadExecutor exec = new ThreadExecutor();
3461 >    public void testFailedStage() {
3462 >        CFException ex = new CFException();
3463 >        CompletionStage<Integer> f = CompletableFuture.failedStage(ex);
3464 >        AtomicInteger x = new AtomicInteger(0);
3465 >        AtomicReference<Throwable> r = new AtomicReference<Throwable>();
3466 >        f.whenComplete((v, e) -> {if (e != null) r.set(e); else x.set(v);});
3467 >        assertEquals(x.get(), 0);
3468 >        assertEquals(r.get(), ex);
3469 >    }
3470 >
3471 >    /**
3472 >     * completeAsync completes with value of given supplier
3473 >     */
3474 >    public void testCompleteAsync() {
3475 >        for (Integer v1 : new Integer[] { 1, null })
3476 >    {
3477          CompletableFuture<Integer> f = new CompletableFuture<>();
3478 <        CompletableFuture<Integer> g =
3479 <            f.whenCompleteAsync((Integer x, Throwable t) ->
3480 <                                { throw new CFException(); },
3481 <                                exec);
3482 <        f.complete(three);
3483 <        checkCompletedNormally(f, three);
3484 <        checkCompletedWithWrappedCFException(g);
3478 >        f.completeAsync(() -> v1);
3479 >        f.join();
3480 >        checkCompletedNormally(f, v1);
3481 >    }}
3482 >
3483 >    /**
3484 >     * completeAsync completes exceptionally if given supplier throws
3485 >     */
3486 >    public void testCompleteAsync2() {
3487 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3488 >        CFException ex = new CFException();
3489 >        f.completeAsync(() -> {if (true) throw ex; return 1;});
3490 >        try {
3491 >            f.join();
3492 >            shouldThrow();
3493 >        } catch (CompletionException success) {}
3494 >        checkCompletedWithWrappedException(f, ex);
3495      }
3496  
3497      /**
3498 <     * handleAsync action completes normally with function value on
3187 <     * either normal or exceptional completion of source
3498 >     * completeAsync with given executor completes with value of given supplier
3499       */
3500 <    public void testHandleAsync() {
3501 <        CompletableFuture<Integer> f, g;
3502 <        IntegerHandler r;
3500 >    public void testCompleteAsync3() {
3501 >        for (Integer v1 : new Integer[] { 1, null })
3502 >    {
3503 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3504 >        ThreadExecutor executor = new ThreadExecutor();
3505 >        f.completeAsync(() -> v1, executor);
3506 >        assertSame(v1, f.join());
3507 >        checkCompletedNormally(f, v1);
3508 >        assertEquals(1, executor.count.get());
3509 >    }}
3510  
3511 <        f = new CompletableFuture<>();
3512 <        g = f.handleAsync(r = new IntegerHandler());
3513 <        assertFalse(r.ran);
3514 <        f.completeExceptionally(new CFException());
3515 <        checkCompletedWithWrappedCFException(f);
3516 <        checkCompletedNormally(g, three);
3517 <        assertTrue(r.ran);
3511 >    /**
3512 >     * completeAsync with given executor completes exceptionally if
3513 >     * given supplier throws
3514 >     */
3515 >    public void testCompleteAsync4() {
3516 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3517 >        CFException ex = new CFException();
3518 >        ThreadExecutor executor = new ThreadExecutor();
3519 >        f.completeAsync(() -> {if (true) throw ex; return 1;}, executor);
3520 >        try {
3521 >            f.join();
3522 >            shouldThrow();
3523 >        } catch (CompletionException success) {}
3524 >        checkCompletedWithWrappedException(f, ex);
3525 >        assertEquals(1, executor.count.get());
3526 >    }
3527  
3528 <        f = new CompletableFuture<>();
3529 <        g = f.handleAsync(r = new IntegerHandler());
3530 <        assertFalse(r.ran);
3531 <        f.completeExceptionally(new CFException());
3532 <        checkCompletedWithWrappedCFException(f);
3533 <        checkCompletedNormally(g, three);
3534 <        assertTrue(r.ran);
3528 >    /**
3529 >     * orTimeout completes with TimeoutException if not complete
3530 >     */
3531 >    public void testOrTimeout_timesOut() {
3532 >        long timeoutMillis = timeoutMillis();
3533 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3534 >        long startTime = System.nanoTime();
3535 >        assertSame(f, f.orTimeout(timeoutMillis, MILLISECONDS));
3536 >        checkCompletedWithTimeoutException(f);
3537 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
3538 >    }
3539  
3540 <        f = new CompletableFuture<>();
3541 <        g = f.handleAsync(r = new IntegerHandler());
3542 <        assertFalse(r.ran);
3543 <        f.complete(one);
3544 <        checkCompletedNormally(f, one);
3545 <        checkCompletedNormally(g, two);
3546 <        assertTrue(r.ran);
3540 >    /**
3541 >     * orTimeout completes normally if completed before timeout
3542 >     */
3543 >    public void testOrTimeout_completed() {
3544 >        for (Integer v1 : new Integer[] { 1, null })
3545 >    {
3546 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3547 >        CompletableFuture<Integer> g = new CompletableFuture<>();
3548 >        long startTime = System.nanoTime();
3549 >        f.complete(v1);
3550 >        assertSame(f, f.orTimeout(LONG_DELAY_MS, MILLISECONDS));
3551 >        assertSame(g, g.orTimeout(LONG_DELAY_MS, MILLISECONDS));
3552 >        g.complete(v1);
3553 >        checkCompletedNormally(f, v1);
3554 >        checkCompletedNormally(g, v1);
3555 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
3556 >    }}
3557  
3558 <        f = new CompletableFuture<>();
3559 <        g = f.handleAsync(r = new IntegerHandler());
3560 <        assertFalse(r.ran);
3561 <        f.complete(one);
3562 <        checkCompletedNormally(f, one);
3563 <        checkCompletedNormally(g, two);
3223 <        assertTrue(r.ran);
3558 >    /**
3559 >     * completeOnTimeout completes with given value if not complete
3560 >     */
3561 >    public void testCompleteOnTimeout_timesOut() {
3562 >        testInParallel(() -> testCompleteOnTimeout_timesOut(42),
3563 >                       () -> testCompleteOnTimeout_timesOut(null));
3564      }
3565  
3566      /**
3567 <     * handleAsync action with Executor completes normally with
3228 <     * function value on either normal or exceptional completion of
3229 <     * source
3567 >     * completeOnTimeout completes with given value if not complete
3568       */
3569 <    public void testHandleAsync2() {
3570 <        CompletableFuture<Integer> f, g;
3571 <        ThreadExecutor exec = new ThreadExecutor();
3572 <        IntegerHandler r;
3569 >    public void testCompleteOnTimeout_timesOut(Integer v) {
3570 >        long timeoutMillis = timeoutMillis();
3571 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3572 >        long startTime = System.nanoTime();
3573 >        assertSame(f, f.completeOnTimeout(v, timeoutMillis, MILLISECONDS));
3574 >        assertSame(v, f.join());
3575 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
3576 >        f.complete(99);         // should have no effect
3577 >        checkCompletedNormally(f, v);
3578 >    }
3579  
3580 <        f = new CompletableFuture<>();
3581 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3582 <        assertFalse(r.ran);
3583 <        f.completeExceptionally(new CFException());
3584 <        checkCompletedWithWrappedCFException(f);
3585 <        checkCompletedNormally(g, three);
3586 <        assertTrue(r.ran);
3580 >    /**
3581 >     * completeOnTimeout has no effect if completed within timeout
3582 >     */
3583 >    public void testCompleteOnTimeout_completed() {
3584 >        for (Integer v1 : new Integer[] { 1, null })
3585 >    {
3586 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3587 >        CompletableFuture<Integer> g = new CompletableFuture<>();
3588 >        long startTime = System.nanoTime();
3589 >        f.complete(v1);
3590 >        assertSame(f, f.completeOnTimeout(-1, LONG_DELAY_MS, MILLISECONDS));
3591 >        assertSame(g, g.completeOnTimeout(-1, LONG_DELAY_MS, MILLISECONDS));
3592 >        g.complete(v1);
3593 >        checkCompletedNormally(f, v1);
3594 >        checkCompletedNormally(g, v1);
3595 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS / 2);
3596 >    }}
3597  
3598 <        f = new CompletableFuture<>();
3599 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3600 <        assertFalse(r.ran);
3601 <        f.completeExceptionally(new CFException());
3602 <        checkCompletedWithWrappedCFException(f);
3603 <        checkCompletedNormally(g, three);
3604 <        assertTrue(r.ran);
3598 >    /**
3599 >     * delayedExecutor returns an executor that delays submission
3600 >     */
3601 >    public void testDelayedExecutor() {
3602 >        testInParallel(() -> testDelayedExecutor(null, null),
3603 >                       () -> testDelayedExecutor(null, 1),
3604 >                       () -> testDelayedExecutor(new ThreadExecutor(), 1),
3605 >                       () -> testDelayedExecutor(new ThreadExecutor(), 1));
3606 >    }
3607 >
3608 >    public void testDelayedExecutor(Executor executor, Integer v) throws Exception {
3609 >        long timeoutMillis = timeoutMillis();
3610 >        // Use an "unreasonably long" long timeout to catch lingering threads
3611 >        long longTimeoutMillis = 1000 * 60 * 60 * 24;
3612 >        final Executor delayer, longDelayer;
3613 >        if (executor == null) {
3614 >            delayer = CompletableFuture.delayedExecutor(timeoutMillis, MILLISECONDS);
3615 >            longDelayer = CompletableFuture.delayedExecutor(longTimeoutMillis, MILLISECONDS);
3616 >        } else {
3617 >            delayer = CompletableFuture.delayedExecutor(timeoutMillis, MILLISECONDS, executor);
3618 >            longDelayer = CompletableFuture.delayedExecutor(longTimeoutMillis, MILLISECONDS, executor);
3619 >        }
3620 >        long startTime = System.nanoTime();
3621 >        CompletableFuture<Integer> f =
3622 >            CompletableFuture.supplyAsync(() -> v, delayer);
3623 >        CompletableFuture<Integer> g =
3624 >            CompletableFuture.supplyAsync(() -> v, longDelayer);
3625  
3626 <        f = new CompletableFuture<>();
3253 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3254 <        assertFalse(r.ran);
3255 <        f.complete(one);
3256 <        checkCompletedNormally(f, one);
3257 <        checkCompletedNormally(g, two);
3258 <        assertTrue(r.ran);
3626 >        assertNull(g.getNow(null));
3627  
3628 <        f = new CompletableFuture<>();
3629 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3630 <        assertFalse(r.ran);
3631 <        f.complete(one);
3632 <        checkCompletedNormally(f, one);
3633 <        checkCompletedNormally(g, two);
3634 <        assertTrue(r.ran);
3628 >        assertSame(v, f.get(LONG_DELAY_MS, MILLISECONDS));
3629 >        long millisElapsed = millisElapsedSince(startTime);
3630 >        assertTrue(millisElapsed >= timeoutMillis);
3631 >        assertTrue(millisElapsed < LONG_DELAY_MS / 2);
3632 >
3633 >        checkCompletedNormally(f, v);
3634 >
3635 >        checkIncomplete(g);
3636 >        assertTrue(g.cancel(true));
3637      }
3638  
3639 +    //--- tests of implementation details; not part of official tck ---
3640 +
3641 +    Object resultOf(CompletableFuture<?> f) {
3642 +        SecurityManager sm = System.getSecurityManager();
3643 +        if (sm != null) {
3644 +            try {
3645 +                System.setSecurityManager(null);
3646 +            } catch (SecurityException giveUp) {
3647 +                return "Reflection not available";
3648 +            }
3649 +        }
3650 +
3651 +        try {
3652 +            java.lang.reflect.Field resultField
3653 +                = CompletableFuture.class.getDeclaredField("result");
3654 +            resultField.setAccessible(true);
3655 +            return resultField.get(f);
3656 +        } catch (Throwable t) {
3657 +            throw new AssertionError(t);
3658 +        } finally {
3659 +            if (sm != null) System.setSecurityManager(sm);
3660 +        }
3661 +    }
3662 +
3663 +    public void testExceptionPropagationReusesResultObject() {
3664 +        if (!testImplementationDetails) return;
3665 +        for (ExecutionMode m : ExecutionMode.values())
3666 +    {
3667 +        final CFException ex = new CFException();
3668 +        final CompletableFuture<Integer> v42 = CompletableFuture.completedFuture(42);
3669 +        final CompletableFuture<Integer> incomplete = new CompletableFuture<>();
3670 +
3671 +        List<Function<CompletableFuture<Integer>, CompletableFuture<?>>> funs
3672 +            = new ArrayList<>();
3673 +
3674 +        funs.add((y) -> m.thenRun(y, new Noop(m)));
3675 +        funs.add((y) -> m.thenAccept(y, new NoopConsumer(m)));
3676 +        funs.add((y) -> m.thenApply(y, new IncFunction(m)));
3677 +
3678 +        funs.add((y) -> m.runAfterEither(y, incomplete, new Noop(m)));
3679 +        funs.add((y) -> m.acceptEither(y, incomplete, new NoopConsumer(m)));
3680 +        funs.add((y) -> m.applyToEither(y, incomplete, new IncFunction(m)));
3681 +
3682 +        funs.add((y) -> m.runAfterBoth(y, v42, new Noop(m)));
3683 +        funs.add((y) -> m.runAfterBoth(v42, y, new Noop(m)));
3684 +        funs.add((y) -> m.thenAcceptBoth(y, v42, new SubtractAction(m)));
3685 +        funs.add((y) -> m.thenAcceptBoth(v42, y, new SubtractAction(m)));
3686 +        funs.add((y) -> m.thenCombine(y, v42, new SubtractFunction(m)));
3687 +        funs.add((y) -> m.thenCombine(v42, y, new SubtractFunction(m)));
3688 +
3689 +        funs.add((y) -> m.whenComplete(y, (Integer r, Throwable t) -> {}));
3690 +
3691 +        funs.add((y) -> m.thenCompose(y, new CompletableFutureInc(m)));
3692 +
3693 +        funs.add((y) -> CompletableFuture.allOf(new CompletableFuture<?>[] {y}));
3694 +        funs.add((y) -> CompletableFuture.allOf(new CompletableFuture<?>[] {y, v42}));
3695 +        funs.add((y) -> CompletableFuture.allOf(new CompletableFuture<?>[] {v42, y}));
3696 +        funs.add((y) -> CompletableFuture.anyOf(new CompletableFuture<?>[] {y}));
3697 +        funs.add((y) -> CompletableFuture.anyOf(new CompletableFuture<?>[] {y, incomplete}));
3698 +        funs.add((y) -> CompletableFuture.anyOf(new CompletableFuture<?>[] {incomplete, y}));
3699 +
3700 +        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3701 +                 fun : funs) {
3702 +            CompletableFuture<Integer> f = new CompletableFuture<>();
3703 +            f.completeExceptionally(ex);
3704 +            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3705 +            checkCompletedWithWrappedException(src, ex);
3706 +            CompletableFuture<?> dep = fun.apply(src);
3707 +            checkCompletedWithWrappedException(dep, ex);
3708 +            assertSame(resultOf(src), resultOf(dep));
3709 +        }
3710 +
3711 +        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3712 +                 fun : funs) {
3713 +            CompletableFuture<Integer> f = new CompletableFuture<>();
3714 +            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3715 +            CompletableFuture<?> dep = fun.apply(src);
3716 +            f.completeExceptionally(ex);
3717 +            checkCompletedWithWrappedException(src, ex);
3718 +            checkCompletedWithWrappedException(dep, ex);
3719 +            assertSame(resultOf(src), resultOf(dep));
3720 +        }
3721 +
3722 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3723 +        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3724 +                 fun : funs) {
3725 +            CompletableFuture<Integer> f = new CompletableFuture<>();
3726 +            f.cancel(mayInterruptIfRunning);
3727 +            checkCancelled(f);
3728 +            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3729 +            checkCompletedWithWrappedCancellationException(src);
3730 +            CompletableFuture<?> dep = fun.apply(src);
3731 +            checkCompletedWithWrappedCancellationException(dep);
3732 +            assertSame(resultOf(src), resultOf(dep));
3733 +        }
3734 +
3735 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3736 +        for (Function<CompletableFuture<Integer>, CompletableFuture<?>>
3737 +                 fun : funs) {
3738 +            CompletableFuture<Integer> f = new CompletableFuture<>();
3739 +            CompletableFuture<Integer> src = m.thenApply(f, new IncFunction(m));
3740 +            CompletableFuture<?> dep = fun.apply(src);
3741 +            f.cancel(mayInterruptIfRunning);
3742 +            checkCancelled(f);
3743 +            checkCompletedWithWrappedCancellationException(src);
3744 +            checkCompletedWithWrappedCancellationException(dep);
3745 +            assertSame(resultOf(src), resultOf(dep));
3746 +        }
3747 +    }}
3748 +
3749 +    /**
3750 +     * Minimal completion stages throw UOE for all non-CompletionStage methods
3751 +     */
3752 +    public void testMinimalCompletionStage_minimality() {
3753 +        if (!testImplementationDetails) return;
3754 +        Function<Method, String> toSignature =
3755 +            (method) -> method.getName() + Arrays.toString(method.getParameterTypes());
3756 +        Predicate<Method> isNotStatic =
3757 +            (method) -> (method.getModifiers() & Modifier.STATIC) == 0;
3758 +        List<Method> minimalMethods =
3759 +            Stream.of(Object.class, CompletionStage.class)
3760 +            .flatMap((klazz) -> Stream.of(klazz.getMethods()))
3761 +            .filter(isNotStatic)
3762 +            .collect(Collectors.toList());
3763 +        // Methods from CompletableFuture permitted NOT to throw UOE
3764 +        String[] signatureWhitelist = {
3765 +            "newIncompleteFuture[]",
3766 +            "defaultExecutor[]",
3767 +            "minimalCompletionStage[]",
3768 +            "copy[]",
3769 +        };
3770 +        Set<String> permittedMethodSignatures =
3771 +            Stream.concat(minimalMethods.stream().map(toSignature),
3772 +                          Stream.of(signatureWhitelist))
3773 +            .collect(Collectors.toSet());
3774 +        List<Method> allMethods = Stream.of(CompletableFuture.class.getMethods())
3775 +            .filter(isNotStatic)
3776 +            .filter((method) -> !permittedMethodSignatures.contains(toSignature.apply(method)))
3777 +            .collect(Collectors.toList());
3778 +
3779 +        CompletionStage<Integer> minimalStage =
3780 +            new CompletableFuture<Integer>().minimalCompletionStage();
3781 +
3782 +        List<Method> bugs = new ArrayList<>();
3783 +        for (Method method : allMethods) {
3784 +            Class<?>[] parameterTypes = method.getParameterTypes();
3785 +            Object[] args = new Object[parameterTypes.length];
3786 +            // Manufacture boxed primitives for primitive params
3787 +            for (int i = 0; i < args.length; i++) {
3788 +                Class<?> type = parameterTypes[i];
3789 +                if (parameterTypes[i] == boolean.class)
3790 +                    args[i] = false;
3791 +                else if (parameterTypes[i] == int.class)
3792 +                    args[i] = 0;
3793 +                else if (parameterTypes[i] == long.class)
3794 +                    args[i] = 0L;
3795 +            }
3796 +            try {
3797 +                method.invoke(minimalStage, args);
3798 +                bugs.add(method);
3799 +            }
3800 +            catch (java.lang.reflect.InvocationTargetException expected) {
3801 +                if (! (expected.getCause() instanceof UnsupportedOperationException)) {
3802 +                    bugs.add(method);
3803 +                    // expected.getCause().printStackTrace();
3804 +                }
3805 +            }
3806 +            catch (ReflectiveOperationException bad) { throw new Error(bad); }
3807 +        }
3808 +        if (!bugs.isEmpty())
3809 +            throw new Error("Methods did not throw UOE: " + bugs.toString());
3810 +    }
3811 +
3812 +    static class Monad {
3813 +        static class ZeroException extends RuntimeException {
3814 +            public ZeroException() { super("monadic zero"); }
3815 +        }
3816 +        // "return", "unit"
3817 +        static <T> CompletableFuture<T> unit(T value) {
3818 +            return completedFuture(value);
3819 +        }
3820 +        // monadic zero ?
3821 +        static <T> CompletableFuture<T> zero() {
3822 +            return failedFuture(new ZeroException());
3823 +        }
3824 +        // >=>
3825 +        static <T,U,V> Function<T, CompletableFuture<V>> compose
3826 +            (Function<T, CompletableFuture<U>> f,
3827 +             Function<U, CompletableFuture<V>> g) {
3828 +            return (x) -> f.apply(x).thenCompose(g);
3829 +        }
3830 +
3831 +        static void assertZero(CompletableFuture<?> f) {
3832 +            try {
3833 +                f.getNow(null);
3834 +                throw new AssertionFailedError("should throw");
3835 +            } catch (CompletionException success) {
3836 +                assertTrue(success.getCause() instanceof ZeroException);
3837 +            }
3838 +        }
3839 +
3840 +        static <T> void assertFutureEquals(CompletableFuture<T> f,
3841 +                                           CompletableFuture<T> g) {
3842 +            T fval = null, gval = null;
3843 +            Throwable fex = null, gex = null;
3844 +
3845 +            try { fval = f.get(); }
3846 +            catch (ExecutionException ex) { fex = ex.getCause(); }
3847 +            catch (Throwable ex) { fex = ex; }
3848 +
3849 +            try { gval = g.get(); }
3850 +            catch (ExecutionException ex) { gex = ex.getCause(); }
3851 +            catch (Throwable ex) { gex = ex; }
3852 +
3853 +            if (fex != null || gex != null)
3854 +                assertSame(fex.getClass(), gex.getClass());
3855 +            else
3856 +                assertEquals(fval, gval);
3857 +        }
3858 +
3859 +        static class PlusFuture<T> extends CompletableFuture<T> {
3860 +            AtomicReference<Throwable> firstFailure = new AtomicReference<>(null);
3861 +        }
3862 +
3863 +        /** Implements "monadic plus". */
3864 +        static <T> CompletableFuture<T> plus(CompletableFuture<? extends T> f,
3865 +                                             CompletableFuture<? extends T> g) {
3866 +            PlusFuture<T> plus = new PlusFuture<T>();
3867 +            BiConsumer<T, Throwable> action = (T result, Throwable ex) -> {
3868 +                try {
3869 +                    if (ex == null) {
3870 +                        if (plus.complete(result))
3871 +                            if (plus.firstFailure.get() != null)
3872 +                                plus.firstFailure.set(null);
3873 +                    }
3874 +                    else if (plus.firstFailure.compareAndSet(null, ex)) {
3875 +                        if (plus.isDone())
3876 +                            plus.firstFailure.set(null);
3877 +                    }
3878 +                    else {
3879 +                        // first failure has precedence
3880 +                        Throwable first = plus.firstFailure.getAndSet(null);
3881 +
3882 +                        // may fail with "Self-suppression not permitted"
3883 +                        try { first.addSuppressed(ex); }
3884 +                        catch (Exception ignored) {}
3885 +
3886 +                        plus.completeExceptionally(first);
3887 +                    }
3888 +                } catch (Throwable unexpected) {
3889 +                    plus.completeExceptionally(unexpected);
3890 +                }
3891 +            };
3892 +            f.whenComplete(action);
3893 +            g.whenComplete(action);
3894 +            return plus;
3895 +        }
3896 +    }
3897 +
3898 +    /**
3899 +     * CompletableFuture is an additive monad - sort of.
3900 +     * https://en.wikipedia.org/wiki/Monad_(functional_programming)#Additive_monads
3901 +     */
3902 +    public void testAdditiveMonad() throws Throwable {
3903 +        Function<Long, CompletableFuture<Long>> unit = Monad::unit;
3904 +        CompletableFuture<Long> zero = Monad.zero();
3905 +
3906 +        // Some mutually non-commutative functions
3907 +        Function<Long, CompletableFuture<Long>> triple
3908 +            = (x) -> Monad.unit(3 * x);
3909 +        Function<Long, CompletableFuture<Long>> inc
3910 +            = (x) -> Monad.unit(x + 1);
3911 +
3912 +        // unit is a right identity: m >>= unit === m
3913 +        Monad.assertFutureEquals(inc.apply(5L).thenCompose(unit),
3914 +                                 inc.apply(5L));
3915 +        // unit is a left identity: (unit x) >>= f === f x
3916 +        Monad.assertFutureEquals(unit.apply(5L).thenCompose(inc),
3917 +                                 inc.apply(5L));
3918 +
3919 +        // associativity: (m >>= f) >>= g === m >>= ( \x -> (f x >>= g) )
3920 +        Monad.assertFutureEquals(
3921 +            unit.apply(5L).thenCompose(inc).thenCompose(triple),
3922 +            unit.apply(5L).thenCompose((x) -> inc.apply(x).thenCompose(triple)));
3923 +
3924 +        // The case for CompletableFuture as an additive monad is weaker...
3925 +
3926 +        // zero is a monadic zero
3927 +        Monad.assertZero(zero);
3928 +
3929 +        // left zero: zero >>= f === zero
3930 +        Monad.assertZero(zero.thenCompose(inc));
3931 +        // right zero: f >>= (\x -> zero) === zero
3932 +        Monad.assertZero(inc.apply(5L).thenCompose((x) -> zero));
3933 +
3934 +        // f plus zero === f
3935 +        Monad.assertFutureEquals(Monad.unit(5L),
3936 +                                 Monad.plus(Monad.unit(5L), zero));
3937 +        // zero plus f === f
3938 +        Monad.assertFutureEquals(Monad.unit(5L),
3939 +                                 Monad.plus(zero, Monad.unit(5L)));
3940 +        // zero plus zero === zero
3941 +        Monad.assertZero(Monad.plus(zero, zero));
3942 +        {
3943 +            CompletableFuture<Long> f = Monad.plus(Monad.unit(5L),
3944 +                                                   Monad.unit(8L));
3945 +            // non-determinism
3946 +            assertTrue(f.get() == 5L || f.get() == 8L);
3947 +        }
3948 +
3949 +        CompletableFuture<Long> godot = new CompletableFuture<>();
3950 +        // f plus godot === f (doesn't wait for godot)
3951 +        Monad.assertFutureEquals(Monad.unit(5L),
3952 +                                 Monad.plus(Monad.unit(5L), godot));
3953 +        // godot plus f === f (doesn't wait for godot)
3954 +        Monad.assertFutureEquals(Monad.unit(5L),
3955 +                                 Monad.plus(godot, Monad.unit(5L)));
3956 +    }
3957 +
3958 +    /**
3959 +     * A single CompletableFuture with many dependents.
3960 +     * A demo of scalability - runtime is O(n).
3961 +     */
3962 +    public void testManyDependents() throws Throwable {
3963 +        final int n = 1_000;
3964 +        final CompletableFuture<Void> head = new CompletableFuture<>();
3965 +        final CompletableFuture<Void> complete = CompletableFuture.completedFuture((Void)null);
3966 +        final AtomicInteger count = new AtomicInteger(0);
3967 +        for (int i = 0; i < n; i++) {
3968 +            head.thenRun(() -> count.getAndIncrement());
3969 +            head.thenAccept((x) -> count.getAndIncrement());
3970 +            head.thenApply((x) -> count.getAndIncrement());
3971 +
3972 +            head.runAfterBoth(complete, () -> count.getAndIncrement());
3973 +            head.thenAcceptBoth(complete, (x, y) -> count.getAndIncrement());
3974 +            head.thenCombine(complete, (x, y) -> count.getAndIncrement());
3975 +            complete.runAfterBoth(head, () -> count.getAndIncrement());
3976 +            complete.thenAcceptBoth(head, (x, y) -> count.getAndIncrement());
3977 +            complete.thenCombine(head, (x, y) -> count.getAndIncrement());
3978 +
3979 +            head.runAfterEither(new CompletableFuture<Void>(), () -> count.getAndIncrement());
3980 +            head.acceptEither(new CompletableFuture<Void>(), (x) -> count.getAndIncrement());
3981 +            head.applyToEither(new CompletableFuture<Void>(), (x) -> count.getAndIncrement());
3982 +            new CompletableFuture<Void>().runAfterEither(head, () -> count.getAndIncrement());
3983 +            new CompletableFuture<Void>().acceptEither(head, (x) -> count.getAndIncrement());
3984 +            new CompletableFuture<Void>().applyToEither(head, (x) -> count.getAndIncrement());
3985 +        }
3986 +        head.complete(null);
3987 +        assertEquals(5 * 3 * n, count.get());
3988 +    }
3989 +
3990 + //     static <U> U join(CompletionStage<U> stage) {
3991 + //         CompletableFuture<U> f = new CompletableFuture<>();
3992 + //         stage.whenComplete((v, ex) -> {
3993 + //             if (ex != null) f.completeExceptionally(ex); else f.complete(v);
3994 + //         });
3995 + //         return f.join();
3996 + //     }
3997 +
3998 + //     static <U> boolean isDone(CompletionStage<U> stage) {
3999 + //         CompletableFuture<U> f = new CompletableFuture<>();
4000 + //         stage.whenComplete((v, ex) -> {
4001 + //             if (ex != null) f.completeExceptionally(ex); else f.complete(v);
4002 + //         });
4003 + //         return f.isDone();
4004 + //     }
4005 +
4006 + //     static <U> U join2(CompletionStage<U> stage) {
4007 + //         return stage.toCompletableFuture().copy().join();
4008 + //     }
4009 +
4010 + //     static <U> boolean isDone2(CompletionStage<U> stage) {
4011 + //         return stage.toCompletableFuture().copy().isDone();
4012 + //     }
4013 +
4014   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines