ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.21 by jsr166, Mon Apr 8 16:58:17 2013 UTC vs.
Revision 1.46 by jsr166, Mon Jun 2 17:41:22 2014 UTC

# Line 16 | Line 16 | import java.util.concurrent.ExecutionExc
16   import java.util.concurrent.Future;
17   import java.util.concurrent.CompletableFuture;
18   import java.util.concurrent.CompletionException;
19 + import java.util.concurrent.CompletionStage;
20   import java.util.concurrent.TimeoutException;
21   import java.util.concurrent.atomic.AtomicInteger;
22   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 68 | Line 69 | public class CompletableFutureTest exten
69          } catch (Throwable fail) { threadUnexpectedException(fail); }
70          assertTrue(f.isDone());
71          assertFalse(f.isCancelled());
72 +        assertFalse(f.isCompletedExceptionally());
73          assertTrue(f.toString().contains("[Completed normally]"));
74      }
75  
# Line 101 | Line 103 | public class CompletableFutureTest exten
103          assertTrue(f.toString().contains("[Completed exceptionally]"));
104      }
105  
106 +    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
107 +                                              CFException ex) {
108 +        try {
109 +            f.get(LONG_DELAY_MS, MILLISECONDS);
110 +            shouldThrow();
111 +        } catch (ExecutionException success) {
112 +            assertSame(ex, success.getCause());
113 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
114 +        try {
115 +            f.join();
116 +            shouldThrow();
117 +        } catch (CompletionException success) {
118 +            assertSame(ex, success.getCause());
119 +        }
120 +        try {
121 +            f.getNow(null);
122 +            shouldThrow();
123 +        } catch (CompletionException success) {
124 +            assertSame(ex, success.getCause());
125 +        }
126 +        try {
127 +            f.get();
128 +            shouldThrow();
129 +        } catch (ExecutionException success) {
130 +            assertSame(ex, success.getCause());
131 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
132 +        assertTrue(f.isDone());
133 +        assertFalse(f.isCancelled());
134 +        assertTrue(f.toString().contains("[Completed exceptionally]"));
135 +    }
136 +
137      void checkCancelled(CompletableFuture<?> f) {
138          try {
139              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 121 | Line 154 | public class CompletableFutureTest exten
154          } catch (CancellationException success) {
155          } catch (Throwable fail) { threadUnexpectedException(fail); }
156          assertTrue(f.isDone());
157 +        assertTrue(f.isCompletedExceptionally());
158          assertTrue(f.isCancelled());
159          assertTrue(f.toString().contains("[Completed exceptionally]"));
160      }
# Line 152 | Line 186 | public class CompletableFutureTest exten
186          } catch (Throwable fail) { threadUnexpectedException(fail); }
187          assertTrue(f.isDone());
188          assertFalse(f.isCancelled());
189 +        assertTrue(f.isCompletedExceptionally());
190          assertTrue(f.toString().contains("[Completed exceptionally]"));
191      }
192  
# Line 160 | Line 195 | public class CompletableFutureTest exten
195       * by methods isDone, isCancelled, and getNow
196       */
197      public void testConstructor() {
198 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
198 >        CompletableFuture<Integer> f = new CompletableFuture<>();
199          checkIncomplete(f);
200      }
201  
# Line 169 | Line 204 | public class CompletableFutureTest exten
204       * isCancelled, join, get, and getNow
205       */
206      public void testComplete() {
207 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
207 >        CompletableFuture<Integer> f = new CompletableFuture<>();
208          checkIncomplete(f);
209          f.complete(one);
210          checkCompletedNormally(f, one);
# Line 180 | Line 215 | public class CompletableFutureTest exten
215       * methods isDone, isCancelled, join, get, and getNow
216       */
217      public void testCompleteExceptionally() {
218 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
218 >        CompletableFuture<Integer> f = new CompletableFuture<>();
219          checkIncomplete(f);
220          f.completeExceptionally(new CFException());
221          checkCompletedWithWrappedCFException(f);
# Line 191 | Line 226 | public class CompletableFutureTest exten
226       * methods isDone, isCancelled, join, get, and getNow
227       */
228      public void testCancel() {
229 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
229 >        CompletableFuture<Integer> f = new CompletableFuture<>();
230          checkIncomplete(f);
231          assertTrue(f.cancel(true));
232          checkCancelled(f);
# Line 201 | Line 236 | public class CompletableFutureTest exten
236       * obtrudeValue forces completion with given value
237       */
238      public void testObtrudeValue() {
239 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
239 >        CompletableFuture<Integer> f = new CompletableFuture<>();
240          checkIncomplete(f);
241          f.complete(one);
242          checkCompletedNormally(f, one);
# Line 209 | Line 244 | public class CompletableFutureTest exten
244          checkCompletedNormally(f, three);
245          f.obtrudeValue(two);
246          checkCompletedNormally(f, two);
247 <        f = new CompletableFuture<Integer>();
247 >        f = new CompletableFuture<>();
248          f.obtrudeValue(three);
249          checkCompletedNormally(f, three);
250 <        f = new CompletableFuture<Integer>();
250 >        f.obtrudeValue(null);
251 >        checkCompletedNormally(f, null);
252 >        f = new CompletableFuture<>();
253          f.completeExceptionally(new CFException());
254          f.obtrudeValue(four);
255          checkCompletedNormally(f, four);
# Line 222 | Line 259 | public class CompletableFutureTest exten
259       * obtrudeException forces completion with given exception
260       */
261      public void testObtrudeException() {
262 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
262 >        CompletableFuture<Integer> f = new CompletableFuture<>();
263          checkIncomplete(f);
264          f.complete(one);
265          checkCompletedNormally(f, one);
266          f.obtrudeException(new CFException());
267          checkCompletedWithWrappedCFException(f);
268 <        f = new CompletableFuture<Integer>();
268 >        f = new CompletableFuture<>();
269          f.obtrudeException(new CFException());
270          checkCompletedWithWrappedCFException(f);
271 <        f = new CompletableFuture<Integer>();
271 >        f = new CompletableFuture<>();
272          f.completeExceptionally(new CFException());
273          f.obtrudeValue(four);
274          checkCompletedNormally(f, four);
# Line 243 | Line 280 | public class CompletableFutureTest exten
280       * getNumberOfDependents returns number of dependent tasks
281       */
282      public void testGetNumberOfDependents() {
283 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
284 <        assertEquals(f.getNumberOfDependents(), 0);
283 >        CompletableFuture<Integer> f = new CompletableFuture<>();
284 >        assertEquals(0, f.getNumberOfDependents());
285          CompletableFuture g = f.thenRun(new Noop());
286 <        assertEquals(f.getNumberOfDependents(), 1);
287 <        assertEquals(g.getNumberOfDependents(), 0);
286 >        assertEquals(1, f.getNumberOfDependents());
287 >        assertEquals(0, g.getNumberOfDependents());
288          CompletableFuture h = f.thenRun(new Noop());
289 <        assertEquals(f.getNumberOfDependents(), 2);
289 >        assertEquals(2, f.getNumberOfDependents());
290          f.complete(1);
291          checkCompletedNormally(g, null);
292 <        assertEquals(f.getNumberOfDependents(), 0);
293 <        assertEquals(g.getNumberOfDependents(), 0);
292 >        assertEquals(0, f.getNumberOfDependents());
293 >        assertEquals(0, g.getNumberOfDependents());
294      }
295  
259
296      /**
297       * toString indicates current completion state
298       */
# Line 284 | Line 320 | public class CompletableFutureTest exten
320  
321      // Choose non-commutative actions for better coverage
322  
323 +    // A non-commutative function that handles and produces null values as well.
324 +    static Integer subtract(Integer x, Integer y) {
325 +        return (x == null && y == null) ? null :
326 +            ((x == null) ? 42 : x.intValue())
327 +            - ((y == null) ? 99 : y.intValue());
328 +    }
329 +
330 +    // A function that handles and produces null values as well.
331 +    static Integer inc(Integer x) {
332 +        return (x == null) ? null : x + 1;
333 +    }
334 +
335      static final Supplier<Integer> supplyOne =
336          () -> Integer.valueOf(1);
337      static final Function<Integer, Integer> inc =
338          (Integer x) -> Integer.valueOf(x.intValue() + 1);
339      static final BiFunction<Integer, Integer, Integer> subtract =
340 <        (Integer x, Integer y) -> Integer.valueOf(x.intValue() - y.intValue());
340 >        (Integer x, Integer y) -> subtract(x, y);
341      static final class IncAction implements Consumer<Integer> {
342 <        int value;
343 <        public void accept(Integer x) { value = x.intValue() + 1; }
342 >        int invocationCount = 0;
343 >        Integer value;
344 >        public void accept(Integer x) {
345 >            invocationCount++;
346 >            value = inc(x);
347 >        }
348      }
349 <    static final class AddAction implements BiConsumer<Integer, Integer> {
350 <        int value;
349 >    static final class IncFunction implements Function<Integer,Integer> {
350 >        int invocationCount = 0;
351 >        Integer value;
352 >        public Integer apply(Integer x) {
353 >            invocationCount++;
354 >            return value = inc(x);
355 >        }
356 >    }
357 >    static final class SubtractAction implements BiConsumer<Integer, Integer> {
358 >        int invocationCount = 0;
359 >        Integer value;
360 >        // Check this action was invoked exactly once when result is computed.
361          public void accept(Integer x, Integer y) {
362 <            value = x.intValue() + y.intValue();
362 >            invocationCount++;
363 >            value = subtract(x, y);
364 >        }
365 >    }
366 >    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
367 >        int invocationCount = 0;
368 >        Integer value;
369 >        // Check this action was invoked exactly once when result is computed.
370 >        public Integer apply(Integer x, Integer y) {
371 >            invocationCount++;
372 >            return value = subtract(x, y);
373          }
374      }
375      static final class Noop implements Runnable {
376 <        boolean ran;
377 <        public void run() { ran = true; }
376 >        int invocationCount = 0;
377 >        public void run() {
378 >            invocationCount++;
379 >        }
380      }
381  
382      static final class FailingSupplier implements Supplier<Integer> {
383 <        boolean ran;
384 <        public Integer get() { ran = true; throw new CFException(); }
383 >        int invocationCount = 0;
384 >        public Integer get() {
385 >            invocationCount++;
386 >            throw new CFException();
387 >        }
388      }
389      static final class FailingConsumer implements Consumer<Integer> {
390 <        boolean ran;
391 <        public void accept(Integer x) { ran = true; throw new CFException(); }
390 >        int invocationCount = 0;
391 >        public void accept(Integer x) {
392 >            invocationCount++;
393 >            throw new CFException();
394 >        }
395      }
396      static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
397 <        boolean ran;
398 <        public void accept(Integer x, Integer y) { ran = true; throw new CFException(); }
397 >        int invocationCount = 0;
398 >        public void accept(Integer x, Integer y) {
399 >            invocationCount++;
400 >            throw new CFException();
401 >        }
402      }
403      static final class FailingFunction implements Function<Integer, Integer> {
404 <        boolean ran;
405 <        public Integer apply(Integer x) { ran = true; throw new CFException(); }
404 >        int invocationCount = 0;
405 >        public Integer apply(Integer x) {
406 >            invocationCount++;
407 >            throw new CFException();
408 >        }
409      }
410      static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
411 <        boolean ran;
412 <        public Integer apply(Integer x, Integer y) { ran = true; throw new CFException(); }
411 >        int invocationCount = 0;
412 >        public Integer apply(Integer x, Integer y) {
413 >            invocationCount++;
414 >            throw new CFException();
415 >        }
416      }
417      static final class FailingNoop implements Runnable {
418 <        boolean ran;
419 <        public void run() { ran = true; throw new CFException(); }
418 >        int invocationCount = 0;
419 >        public void run() {
420 >            invocationCount++;
421 >            throw new CFException();
422 >        }
423      }
424  
425      static final class CompletableFutureInc
426          implements Function<Integer, CompletableFuture<Integer>> {
427 <        boolean ran;
427 >        int invocationCount = 0;
428          public CompletableFuture<Integer> apply(Integer x) {
429 <            ran = true;
430 <            CompletableFuture<Integer> f = new CompletableFuture<Integer>();
431 <            f.complete(Integer.valueOf(x.intValue() + 1));
429 >            invocationCount++;
430 >            CompletableFuture<Integer> f = new CompletableFuture<>();
431 >            f.complete(inc(x));
432              return f;
433          }
434      }
435  
436      static final class FailingCompletableFutureFunction
437          implements Function<Integer, CompletableFuture<Integer>> {
438 <        boolean ran;
438 >        int invocationCount = 0;
439          public CompletableFuture<Integer> apply(Integer x) {
440 <            ran = true; throw new CFException();
440 >            invocationCount++;
441 >            throw new CFException();
442          }
443      }
444  
# Line 359 | Line 452 | public class CompletableFutureTest exten
452          }
453      }
454  
455 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
456 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
457 <    }
455 >    /**
456 >     * Permits the testing of parallel code for the 3 different
457 >     * execution modes without repeating all the testing code.
458 >     */
459 >    enum ExecutionMode {
460 >        DEFAULT {
461 >            public <T> CompletableFuture<Void> thenRun
462 >                (CompletableFuture<T> f, Runnable a) {
463 >                return f.thenRun(a);
464 >            }
465 >            public <T> CompletableFuture<Void> thenAccept
466 >                (CompletableFuture<T> f, Consumer<? super T> a) {
467 >                return f.thenAccept(a);
468 >            }
469 >            public <T,U> CompletableFuture<U> thenApply
470 >                (CompletableFuture<T> f, Function<? super T,U> a) {
471 >                return f.thenApply(a);
472 >            }
473 >            public <T,U> CompletableFuture<U> thenCompose
474 >                (CompletableFuture<T> f,
475 >                 Function<? super T,? extends CompletionStage<U>> a) {
476 >                return f.thenCompose(a);
477 >            }
478 >            public <T,U> CompletableFuture<U> handle
479 >                (CompletableFuture<T> f,
480 >                 BiFunction<? super T,Throwable,? extends U> a) {
481 >                return f.handle(a);
482 >            }
483 >            public <T> CompletableFuture<T> whenComplete
484 >                (CompletableFuture<T> f,
485 >                 BiConsumer<? super T,? super Throwable> a) {
486 >                return f.whenComplete(a);
487 >            }
488 >            public <T,U> CompletableFuture<Void> runAfterBoth
489 >                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
490 >                return f.runAfterBoth(g, a);
491 >            }
492 >            public <T,U> CompletableFuture<Void> thenAcceptBoth
493 >                (CompletableFuture<T> f,
494 >                 CompletionStage<? extends U> g,
495 >                 BiConsumer<? super T,? super U> a) {
496 >                return f.thenAcceptBoth(g, a);
497 >            }
498 >            public <T,U,V> CompletableFuture<V> thenCombine
499 >                (CompletableFuture<T> f,
500 >                 CompletionStage<? extends U> g,
501 >                 BiFunction<? super T,? super U,? extends V> a) {
502 >                return f.thenCombine(g, a);
503 >            }
504 >            public <T> CompletableFuture<Void> runAfterEither
505 >                (CompletableFuture<T> f,
506 >                 CompletionStage<?> g,
507 >                 java.lang.Runnable a) {
508 >                return f.runAfterEither(g, a);
509 >            }
510 >            public <T> CompletableFuture<Void> acceptEither
511 >                (CompletableFuture<T> f,
512 >                 CompletionStage<? extends T> g,
513 >                 Consumer<? super T> a) {
514 >                return f.acceptEither(g, a);
515 >            }
516 >            public <T,U> CompletableFuture<U> applyToEither
517 >                (CompletableFuture<T> f,
518 >                 CompletionStage<? extends T> g,
519 >                 Function<? super T,U> a) {
520 >                return f.applyToEither(g, a);
521 >            }
522 >        },
523  
524 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
525 <        boolean ran;
526 <        public Integer apply(Integer x, Throwable t) {
527 <            ran = true;
528 <            return (t == null) ? two : three;
529 <        }
524 >        DEFAULT_ASYNC {
525 >            public <T> CompletableFuture<Void> thenRun
526 >                (CompletableFuture<T> f, Runnable a) {
527 >                return f.thenRunAsync(a);
528 >            }
529 >            public <T> CompletableFuture<Void> thenAccept
530 >                (CompletableFuture<T> f, Consumer<? super T> a) {
531 >                return f.thenAcceptAsync(a);
532 >            }
533 >            public <T,U> CompletableFuture<U> thenApply
534 >                (CompletableFuture<T> f, Function<? super T,U> a) {
535 >                return f.thenApplyAsync(a);
536 >            }
537 >            public <T,U> CompletableFuture<U> thenCompose
538 >                (CompletableFuture<T> f,
539 >                 Function<? super T,? extends CompletionStage<U>> a) {
540 >                return f.thenComposeAsync(a);
541 >            }
542 >            public <T,U> CompletableFuture<U> handle
543 >                (CompletableFuture<T> f,
544 >                 BiFunction<? super T,Throwable,? extends U> a) {
545 >                return f.handleAsync(a);
546 >            }
547 >            public <T> CompletableFuture<T> whenComplete
548 >                (CompletableFuture<T> f,
549 >                 BiConsumer<? super T,? super Throwable> a) {
550 >                return f.whenCompleteAsync(a);
551 >            }
552 >            public <T,U> CompletableFuture<Void> runAfterBoth
553 >                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
554 >                return f.runAfterBothAsync(g, a);
555 >            }
556 >            public <T,U> CompletableFuture<Void> thenAcceptBoth
557 >                (CompletableFuture<T> f,
558 >                 CompletionStage<? extends U> g,
559 >                 BiConsumer<? super T,? super U> a) {
560 >                return f.thenAcceptBothAsync(g, a);
561 >            }
562 >            public <T,U,V> CompletableFuture<V> thenCombine
563 >                (CompletableFuture<T> f,
564 >                 CompletionStage<? extends U> g,
565 >                 BiFunction<? super T,? super U,? extends V> a) {
566 >                return f.thenCombineAsync(g, a);
567 >            }
568 >            public <T> CompletableFuture<Void> runAfterEither
569 >                (CompletableFuture<T> f,
570 >                 CompletionStage<?> g,
571 >                 java.lang.Runnable a) {
572 >                return f.runAfterEitherAsync(g, a);
573 >            }
574 >            public <T> CompletableFuture<Void> acceptEither
575 >                (CompletableFuture<T> f,
576 >                 CompletionStage<? extends T> g,
577 >                 Consumer<? super T> a) {
578 >                return f.acceptEitherAsync(g, a);
579 >            }
580 >            public <T,U> CompletableFuture<U> applyToEither
581 >                (CompletableFuture<T> f,
582 >                 CompletionStage<? extends T> g,
583 >                 Function<? super T,U> a) {
584 >                return f.applyToEitherAsync(g, a);
585 >            }
586 >        },
587 >
588 >        EXECUTOR {
589 >            public <T> CompletableFuture<Void> thenRun
590 >                (CompletableFuture<T> f, Runnable a) {
591 >                return f.thenRunAsync(a, new ThreadExecutor());
592 >            }
593 >            public <T> CompletableFuture<Void> thenAccept
594 >                (CompletableFuture<T> f, Consumer<? super T> a) {
595 >                return f.thenAcceptAsync(a, new ThreadExecutor());
596 >            }
597 >            public <T,U> CompletableFuture<U> thenApply
598 >                (CompletableFuture<T> f, Function<? super T,U> a) {
599 >                return f.thenApplyAsync(a, new ThreadExecutor());
600 >            }
601 >            public <T,U> CompletableFuture<U> thenCompose
602 >                (CompletableFuture<T> f,
603 >                 Function<? super T,? extends CompletionStage<U>> a) {
604 >                return f.thenComposeAsync(a, new ThreadExecutor());
605 >            }
606 >            public <T,U> CompletableFuture<U> handle
607 >                (CompletableFuture<T> f,
608 >                 BiFunction<? super T,Throwable,? extends U> a) {
609 >                return f.handleAsync(a, new ThreadExecutor());
610 >            }
611 >            public <T> CompletableFuture<T> whenComplete
612 >                (CompletableFuture<T> f,
613 >                 BiConsumer<? super T,? super Throwable> a) {
614 >                return f.whenCompleteAsync(a, new ThreadExecutor());
615 >            }
616 >            public <T,U> CompletableFuture<Void> runAfterBoth
617 >                (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
618 >                return f.runAfterBothAsync(g, a, new ThreadExecutor());
619 >            }
620 >            public <T,U> CompletableFuture<Void> thenAcceptBoth
621 >                (CompletableFuture<T> f,
622 >                 CompletionStage<? extends U> g,
623 >                 BiConsumer<? super T,? super U> a) {
624 >                return f.thenAcceptBothAsync(g, a, new ThreadExecutor());
625 >            }
626 >            public <T,U,V> CompletableFuture<V> thenCombine
627 >                (CompletableFuture<T> f,
628 >                 CompletionStage<? extends U> g,
629 >                 BiFunction<? super T,? super U,? extends V> a) {
630 >                return f.thenCombineAsync(g, a, new ThreadExecutor());
631 >            }
632 >            public <T> CompletableFuture<Void> runAfterEither
633 >                (CompletableFuture<T> f,
634 >                 CompletionStage<?> g,
635 >                 java.lang.Runnable a) {
636 >                return f.runAfterEitherAsync(g, a, new ThreadExecutor());
637 >            }
638 >            public <T> CompletableFuture<Void> acceptEither
639 >                (CompletableFuture<T> f,
640 >                 CompletionStage<? extends T> g,
641 >                 Consumer<? super T> a) {
642 >                return f.acceptEitherAsync(g, a, new ThreadExecutor());
643 >            }
644 >            public <T,U> CompletableFuture<U> applyToEither
645 >                (CompletableFuture<T> f,
646 >                 CompletionStage<? extends T> g,
647 >                 Function<? super T,U> a) {
648 >                return f.applyToEitherAsync(g, a, new ThreadExecutor());
649 >            }
650 >        };
651 >
652 >        public abstract <T> CompletableFuture<Void> thenRun
653 >            (CompletableFuture<T> f, Runnable a);
654 >        public abstract <T> CompletableFuture<Void> thenAccept
655 >            (CompletableFuture<T> f, Consumer<? super T> a);
656 >        public abstract <T,U> CompletableFuture<U> thenApply
657 >            (CompletableFuture<T> f, Function<? super T,U> a);
658 >        public abstract <T,U> CompletableFuture<U> thenCompose
659 >            (CompletableFuture<T> f,
660 >             Function<? super T,? extends CompletionStage<U>> a);
661 >        public abstract <T,U> CompletableFuture<U> handle
662 >            (CompletableFuture<T> f,
663 >             BiFunction<? super T,Throwable,? extends U> a);
664 >        public abstract <T> CompletableFuture<T> whenComplete
665 >            (CompletableFuture<T> f,
666 >             BiConsumer<? super T,? super Throwable> a);
667 >        public abstract <T,U> CompletableFuture<Void> runAfterBoth
668 >            (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
669 >        public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
670 >            (CompletableFuture<T> f,
671 >             CompletionStage<? extends U> g,
672 >             BiConsumer<? super T,? super U> a);
673 >        public abstract <T,U,V> CompletableFuture<V> thenCombine
674 >            (CompletableFuture<T> f,
675 >             CompletionStage<? extends U> g,
676 >             BiFunction<? super T,? super U,? extends V> a);
677 >        public abstract <T> CompletableFuture<Void> runAfterEither
678 >            (CompletableFuture<T> f,
679 >             CompletionStage<?> g,
680 >             java.lang.Runnable a);
681 >        public abstract <T> CompletableFuture<Void> acceptEither
682 >            (CompletableFuture<T> f,
683 >             CompletionStage<? extends T> g,
684 >             Consumer<? super T> a);
685 >        public abstract <T,U> CompletableFuture<U> applyToEither
686 >            (CompletableFuture<T> f,
687 >             CompletionStage<? extends T> g,
688 >             Function<? super T,U> a);
689      }
690  
691 +    /**
692 +     * exceptionally action is not invoked when source completes
693 +     * normally, and source result is propagated
694 +     */
695 +    public void testExceptionally_normalCompletion() {
696 +        for (boolean createIncomplete : new boolean[] { true, false })
697 +        for (Integer v1 : new Integer[] { 1, null })
698 +    {
699 +        final AtomicInteger a = new AtomicInteger(0);
700 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
701 +        if (!createIncomplete) f.complete(v1);
702 +        final CompletableFuture<Integer> g = f.exceptionally
703 +            ((Throwable t) -> {
704 +                // Should not be called
705 +                a.getAndIncrement();
706 +                throw new AssertionError();
707 +            });
708 +        if (createIncomplete) f.complete(v1);
709 +
710 +        checkCompletedNormally(g, v1);
711 +        checkCompletedNormally(f, v1);
712 +        assertEquals(0, a.get());
713 +    }}
714 +
715  
716      /**
717       * exceptionally action completes with function value on source
718 <     * exception;  otherwise with source value
718 >     * exception
719       */
720 <    public void testExceptionally() {
721 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
722 <        ExceptionToInteger r = new ExceptionToInteger();
723 <        CompletableFuture<Integer> g = f.exceptionally(r);
724 <        f.completeExceptionally(new CFException());
725 <        checkCompletedNormally(g, three);
726 <
727 <        f = new CompletableFuture<Integer>();
728 <        r = new ExceptionToInteger();
729 <        g = f.exceptionally(r);
730 <        f.complete(one);
731 <        checkCompletedNormally(g, one);
732 <    }
720 >    public void testExceptionally_exceptionalCompletion() {
721 >        for (boolean createIncomplete : new boolean[] { true, false })
722 >        for (Integer v1 : new Integer[] { 1, null })
723 >    {
724 >        final AtomicInteger a = new AtomicInteger(0);
725 >        final CFException ex = new CFException();
726 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
727 >        if (!createIncomplete) f.completeExceptionally(ex);
728 >        final CompletableFuture<Integer> g = f.exceptionally
729 >            ((Throwable t) -> {
730 >                threadAssertSame(t, ex);
731 >                a.getAndIncrement();
732 >                return v1;
733 >            });
734 >        if (createIncomplete) f.completeExceptionally(ex);
735 >
736 >        checkCompletedNormally(g, v1);
737 >        assertEquals(1, a.get());
738 >    }}
739 >
740 >    public void testExceptionally_exceptionalCompletionActionFailed() {
741 >        for (boolean createIncomplete : new boolean[] { true, false })
742 >        for (Integer v1 : new Integer[] { 1, null })
743 >    {
744 >        final AtomicInteger a = new AtomicInteger(0);
745 >        final CFException ex1 = new CFException();
746 >        final CFException ex2 = new CFException();
747 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
748 >        if (!createIncomplete) f.completeExceptionally(ex1);
749 >        final CompletableFuture<Integer> g = f.exceptionally
750 >            ((Throwable t) -> {
751 >                threadAssertSame(t, ex1);
752 >                a.getAndIncrement();
753 >                throw ex2;
754 >            });
755 >        if (createIncomplete) f.completeExceptionally(ex1);
756 >
757 >        checkCompletedWithWrappedCFException(g, ex2);
758 >        assertEquals(1, a.get());
759 >    }}
760 >
761 >    /**
762 >     * handle action completes normally with function value on normal
763 >     * completion of source
764 >     */
765 >    public void testHandle_normalCompletion() {
766 >        for (ExecutionMode m : ExecutionMode.values())
767 >        for (boolean createIncomplete : new boolean[] { true, false })
768 >        for (Integer v1 : new Integer[] { 1, null })
769 >    {
770 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
771 >        final AtomicInteger a = new AtomicInteger(0);
772 >        if (!createIncomplete) f.complete(v1);
773 >        final CompletableFuture<Integer> g = m.handle
774 >            (f,
775 >             (Integer x, Throwable t) -> {
776 >                threadAssertSame(x, v1);
777 >                threadAssertNull(t);
778 >                a.getAndIncrement();
779 >                return inc(v1);
780 >            });
781 >        if (createIncomplete) f.complete(v1);
782 >
783 >        checkCompletedNormally(g, inc(v1));
784 >        checkCompletedNormally(f, v1);
785 >        assertEquals(1, a.get());
786 >    }}
787  
788      /**
789 <     * handle action completes normally with function value on either
790 <     * normal or exceptional completion of source
789 >     * handle action completes normally with function value on
790 >     * exceptional completion of source
791       */
792 <    public void testHandle() {
793 <        CompletableFuture<Integer> f, g;
794 <        IntegerHandler r;
792 >    public void testHandle_exceptionalCompletion() {
793 >        for (ExecutionMode m : ExecutionMode.values())
794 >        for (boolean createIncomplete : new boolean[] { true, false })
795 >        for (Integer v1 : new Integer[] { 1, null })
796 >    {
797 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
798 >        final AtomicInteger a = new AtomicInteger(0);
799 >        final CFException ex = new CFException();
800 >        if (!createIncomplete) f.completeExceptionally(ex);
801 >        final CompletableFuture<Integer> g = m.handle
802 >            (f,
803 >             (Integer x, Throwable t) -> {
804 >                threadAssertNull(x);
805 >                threadAssertSame(t, ex);
806 >                a.getAndIncrement();
807 >                return v1;
808 >            });
809 >        if (createIncomplete) f.completeExceptionally(ex);
810 >
811 >        checkCompletedNormally(g, v1);
812 >        checkCompletedWithWrappedCFException(f, ex);
813 >        assertEquals(1, a.get());
814 >    }}
815 >
816 >    /**
817 >     * handle action completes normally with function value on
818 >     * cancelled source
819 >     */
820 >    public void testHandle_sourceCancelled() {
821 >        for (ExecutionMode m : ExecutionMode.values())
822 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
823 >        for (boolean createIncomplete : new boolean[] { true, false })
824 >        for (Integer v1 : new Integer[] { 1, null })
825 >    {
826 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
827 >        final AtomicInteger a = new AtomicInteger(0);
828 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
829 >        final CompletableFuture<Integer> g = m.handle
830 >            (f,
831 >             (Integer x, Throwable t) -> {
832 >                threadAssertNull(x);
833 >                threadAssertTrue(t instanceof CancellationException);
834 >                a.getAndIncrement();
835 >                return v1;
836 >            });
837 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
838  
839 <        f = new CompletableFuture<Integer>();
840 <        f.completeExceptionally(new CFException());
841 <        g = f.handle(r = new IntegerHandler());
842 <        assertTrue(r.ran);
405 <        checkCompletedNormally(g, three);
406 <
407 <        f = new CompletableFuture<Integer>();
408 <        g = f.handle(r = new IntegerHandler());
409 <        assertFalse(r.ran);
410 <        f.completeExceptionally(new CFException());
411 <        checkCompletedNormally(g, three);
412 <        assertTrue(r.ran);
413 <
414 <        f = new CompletableFuture<Integer>();
415 <        f.complete(one);
416 <        g = f.handle(r = new IntegerHandler());
417 <        assertTrue(r.ran);
418 <        checkCompletedNormally(g, two);
839 >        checkCompletedNormally(g, v1);
840 >        checkCancelled(f);
841 >        assertEquals(1, a.get());
842 >    }}
843  
844 <        f = new CompletableFuture<Integer>();
845 <        g = f.handle(r = new IntegerHandler());
846 <        assertFalse(r.ran);
847 <        f.complete(one);
848 <        assertTrue(r.ran);
849 <        checkCompletedNormally(g, two);
850 <    }
844 >    /**
845 >     * handle result completes exceptionally if action does
846 >     */
847 >    public void testHandle_sourceFailedActionFailed() {
848 >        for (ExecutionMode m : ExecutionMode.values())
849 >        for (boolean createIncomplete : new boolean[] { true, false })
850 >    {
851 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
852 >        final AtomicInteger a = new AtomicInteger(0);
853 >        final CFException ex1 = new CFException();
854 >        final CFException ex2 = new CFException();
855 >        if (!createIncomplete) f.completeExceptionally(ex1);
856 >        final CompletableFuture<Integer> g = m.handle
857 >            (f,
858 >             (Integer x, Throwable t) -> {
859 >                threadAssertNull(x);
860 >                threadAssertSame(ex1, t);
861 >                a.getAndIncrement();
862 >                throw ex2;
863 >            });
864 >        if (createIncomplete) f.completeExceptionally(ex1);
865 >
866 >        checkCompletedWithWrappedCFException(g, ex2);
867 >        checkCompletedWithWrappedCFException(f, ex1);
868 >        assertEquals(1, a.get());
869 >    }}
870 >
871 >    public void testHandle_sourceCompletedNormallyActionFailed() {
872 >        for (ExecutionMode m : ExecutionMode.values())
873 >        for (boolean createIncomplete : new boolean[] { true, false })
874 >        for (Integer v1 : new Integer[] { 1, null })
875 >    {
876 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
877 >        final AtomicInteger a = new AtomicInteger(0);
878 >        final CFException ex = new CFException();
879 >        if (!createIncomplete) f.complete(v1);
880 >        final CompletableFuture<Integer> g = m.handle
881 >            (f,
882 >             (Integer x, Throwable t) -> {
883 >                threadAssertSame(x, v1);
884 >                threadAssertNull(t);
885 >                a.getAndIncrement();
886 >                throw ex;
887 >            });
888 >        if (createIncomplete) f.complete(v1);
889 >
890 >        checkCompletedWithWrappedCFException(g, ex);
891 >        checkCompletedNormally(f, v1);
892 >        assertEquals(1, a.get());
893 >    }}
894  
895      /**
896       * runAsync completes after running Runnable
# Line 432 | Line 899 | public class CompletableFutureTest exten
899          Noop r = new Noop();
900          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
901          assertNull(f.join());
902 <        assertTrue(r.ran);
902 >        assertEquals(1, r.invocationCount);
903          checkCompletedNormally(f, null);
904      }
905  
# Line 444 | Line 911 | public class CompletableFutureTest exten
911          ThreadExecutor exec = new ThreadExecutor();
912          CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
913          assertNull(f.join());
914 <        assertTrue(r.ran);
914 >        assertEquals(1, r.invocationCount);
915          checkCompletedNormally(f, null);
916          assertEquals(1, exec.count.get());
917      }
# Line 456 | Line 923 | public class CompletableFutureTest exten
923          FailingNoop r = new FailingNoop();
924          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
925          checkCompletedWithWrappedCFException(f);
926 <        assertTrue(r.ran);
926 >        assertEquals(1, r.invocationCount);
927      }
928  
929      /**
# Line 486 | Line 953 | public class CompletableFutureTest exten
953          FailingSupplier r = new FailingSupplier();
954          CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
955          checkCompletedWithWrappedCFException(f);
956 <        assertTrue(r.ran);
956 >        assertEquals(1, r.invocationCount);
957      }
958  
959      // seq completion methods
# Line 495 | Line 962 | public class CompletableFutureTest exten
962       * thenRun result completes normally after normal completion of source
963       */
964      public void testThenRun() {
965 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
966 <        Noop r = new Noop();
967 <        CompletableFuture<Void> g = f.thenRun(r);
965 >        CompletableFuture<Integer> f;
966 >        CompletableFuture<Void> g;
967 >        Noop r;
968 >
969 >        f = new CompletableFuture<>();
970 >        g = f.thenRun(r = new Noop());
971          f.complete(null);
972          checkCompletedNormally(g, null);
973 <        // reordered version
974 <        f = new CompletableFuture<Integer>();
973 >        assertEquals(1, r.invocationCount);
974 >
975 >        f = new CompletableFuture<>();
976          f.complete(null);
977 <        r = new Noop();
507 <        g = f.thenRun(r);
977 >        g = f.thenRun(r = new Noop());
978          checkCompletedNormally(g, null);
979 +        assertEquals(1, r.invocationCount);
980      }
981  
982      /**
# Line 513 | Line 984 | public class CompletableFutureTest exten
984       * completion of source
985       */
986      public void testThenRun2() {
987 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
988 <        Noop r = new Noop();
989 <        CompletableFuture<Void> g = f.thenRun(r);
987 >        CompletableFuture<Integer> f;
988 >        CompletableFuture<Void> g;
989 >        Noop r;
990 >
991 >        f = new CompletableFuture<>();
992 >        g = f.thenRun(r = new Noop());
993 >        f.completeExceptionally(new CFException());
994 >        checkCompletedWithWrappedCFException(g);
995 >        assertEquals(0, r.invocationCount);
996 >
997 >        f = new CompletableFuture<>();
998          f.completeExceptionally(new CFException());
999 +        g = f.thenRun(r = new Noop());
1000          checkCompletedWithWrappedCFException(g);
1001 +        assertEquals(0, r.invocationCount);
1002      }
1003  
1004      /**
1005       * thenRun result completes exceptionally if action does
1006       */
1007      public void testThenRun3() {
1008 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1009 <        FailingNoop r = new FailingNoop();
1010 <        CompletableFuture<Void> g = f.thenRun(r);
1008 >        CompletableFuture<Integer> f;
1009 >        CompletableFuture<Void> g;
1010 >        FailingNoop r;
1011 >
1012 >        f = new CompletableFuture<>();
1013 >        g = f.thenRun(r = new FailingNoop());
1014          f.complete(null);
1015          checkCompletedWithWrappedCFException(g);
1016 +
1017 +        f = new CompletableFuture<>();
1018 +        f.complete(null);
1019 +        g = f.thenRun(r = new FailingNoop());
1020 +        checkCompletedWithWrappedCFException(g);
1021      }
1022  
1023      /**
1024       * thenRun result completes exceptionally if source cancelled
1025       */
1026      public void testThenRun4() {
1027 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1028 <        Noop r = new Noop();
1029 <        CompletableFuture<Void> g = f.thenRun(r);
1027 >        CompletableFuture<Integer> f;
1028 >        CompletableFuture<Void> g;
1029 >        Noop r;
1030 >
1031 >        f = new CompletableFuture<>();
1032 >        g = f.thenRun(r = new Noop());
1033          assertTrue(f.cancel(true));
1034          checkCompletedWithWrappedCancellationException(g);
1035 +
1036 +        f = new CompletableFuture<>();
1037 +        assertTrue(f.cancel(true));
1038 +        g = f.thenRun(r = new Noop());
1039 +        checkCompletedWithWrappedCancellationException(g);
1040      }
1041  
1042      /**
1043       * thenApply result completes normally after normal completion of source
1044       */
1045      public void testThenApply() {
1046 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1046 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1047          CompletableFuture<Integer> g = f.thenApply(inc);
1048          f.complete(one);
1049          checkCompletedNormally(g, two);
# Line 557 | Line 1054 | public class CompletableFutureTest exten
1054       * completion of source
1055       */
1056      public void testThenApply2() {
1057 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1057 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1058          CompletableFuture<Integer> g = f.thenApply(inc);
1059          f.completeExceptionally(new CFException());
1060          checkCompletedWithWrappedCFException(g);
# Line 567 | Line 1064 | public class CompletableFutureTest exten
1064       * thenApply result completes exceptionally if action does
1065       */
1066      public void testThenApply3() {
1067 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1067 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1068          CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
1069          f.complete(one);
1070          checkCompletedWithWrappedCFException(g);
# Line 577 | Line 1074 | public class CompletableFutureTest exten
1074       * thenApply result completes exceptionally if source cancelled
1075       */
1076      public void testThenApply4() {
1077 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1077 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1078          CompletableFuture<Integer> g = f.thenApply(inc);
1079          assertTrue(f.cancel(true));
1080          checkCompletedWithWrappedCancellationException(g);
# Line 587 | Line 1084 | public class CompletableFutureTest exten
1084       * thenAccept result completes normally after normal completion of source
1085       */
1086      public void testThenAccept() {
1087 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1087 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1088          IncAction r = new IncAction();
1089          CompletableFuture<Void> g = f.thenAccept(r);
1090          f.complete(one);
1091          checkCompletedNormally(g, null);
1092 <        assertEquals(r.value, 2);
1092 >        assertEquals(r.value, (Integer) 2);
1093      }
1094  
1095      /**
# Line 600 | Line 1097 | public class CompletableFutureTest exten
1097       * completion of source
1098       */
1099      public void testThenAccept2() {
1100 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1100 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1101          IncAction r = new IncAction();
1102          CompletableFuture<Void> g = f.thenAccept(r);
1103          f.completeExceptionally(new CFException());
# Line 611 | Line 1108 | public class CompletableFutureTest exten
1108       * thenAccept result completes exceptionally if action does
1109       */
1110      public void testThenAccept3() {
1111 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1111 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1112          FailingConsumer r = new FailingConsumer();
1113          CompletableFuture<Void> g = f.thenAccept(r);
1114          f.complete(one);
1115          checkCompletedWithWrappedCFException(g);
1116 <        assertTrue(r.ran);
1116 >        assertEquals(1, r.invocationCount);
1117      }
1118  
1119      /**
1120       * thenAccept result completes exceptionally if source cancelled
1121       */
1122      public void testThenAccept4() {
1123 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1123 >        CompletableFuture<Integer> f = new CompletableFuture<>();
1124          IncAction r = new IncAction();
1125          CompletableFuture<Void> g = f.thenAccept(r);
1126          assertTrue(f.cancel(true));
1127          checkCompletedWithWrappedCancellationException(g);
1128      }
1129  
633
1130      /**
1131       * thenCombine result completes normally after normal completion
1132       * of sources
1133       */
1134 <    public void testThenCombine() {
1135 <        CompletableFuture<Integer> f, g, h;
1136 <
1137 <        f = new CompletableFuture<Integer>();
1138 <        g = new CompletableFuture<Integer>();
1139 <        h = f.thenCombine(g, subtract);
1140 <        f.complete(3);
1141 <        checkIncomplete(h);
1142 <        g.complete(1);
1143 <        checkCompletedNormally(h, 2);
1144 <
1145 <        f = new CompletableFuture<Integer>();
1146 <        g = new CompletableFuture<Integer>();
1147 <        h = f.thenCombine(g, subtract);
1148 <        g.complete(1);
1149 <        checkIncomplete(h);
1150 <        f.complete(3);
1151 <        checkCompletedNormally(h, 2);
1152 <
1153 <        f = new CompletableFuture<Integer>();
1154 <        g = new CompletableFuture<Integer>();
1155 <        g.complete(1);
1156 <        f.complete(3);
1157 <        h = f.thenCombine(g, subtract);
1158 <        checkCompletedNormally(h, 2);
1134 >    public void testThenCombine_normalCompletion1() {
1135 >        for (boolean createIncomplete : new boolean[] { true, false })
1136 >        for (boolean fFirst : new boolean[] { true, false })
1137 >        for (ExecutionMode m : ExecutionMode.values())
1138 >        for (Integer v1 : new Integer[] { 1, null })
1139 >        for (Integer v2 : new Integer[] { 2, null }) {
1140 >
1141 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1142 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1143 >        final SubtractFunction r = new SubtractFunction();
1144 >        CompletableFuture<Integer> h = null;
1145 >        if (createIncomplete) h = m.thenCombine(f, g, r);
1146 >
1147 >        if (fFirst)
1148 >            f.complete(v1);
1149 >        else
1150 >            g.complete(v2);
1151 >        if (createIncomplete) checkIncomplete(h);
1152 >        assertEquals(0, r.invocationCount);
1153 >        if (!fFirst)
1154 >            f.complete(v1);
1155 >        else
1156 >            g.complete(v2);
1157 >        if (!createIncomplete) h = m.thenCombine(f, g, r);
1158 >
1159 >        checkCompletedNormally(h, subtract(v1, v2));
1160 >        checkCompletedNormally(f, v1);
1161 >        checkCompletedNormally(g, v2);
1162 >        assertEquals(1, r.invocationCount);
1163 >        }
1164      }
1165  
1166      /**
1167       * thenCombine result completes exceptionally after exceptional
1168       * completion of either source
1169       */
1170 <    public void testThenCombine2() {
1171 <        CompletableFuture<Integer> f, g, h;
1170 >    public void testThenCombine_exceptionalCompletion1() {
1171 >        for (ExecutionMode m : ExecutionMode.values())
1172 >        for (Integer v1 : new Integer[] { 1, null }) {
1173 >
1174 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1175 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1176 >        final SubtractFunction r = new SubtractFunction();
1177 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1178 >        final CFException ex = new CFException();
1179  
1180 <        f = new CompletableFuture<Integer>();
673 <        g = new CompletableFuture<Integer>();
674 <        h = f.thenCombine(g, subtract);
675 <        f.completeExceptionally(new CFException());
1180 >        f.completeExceptionally(ex);
1181          checkIncomplete(h);
1182 <        g.complete(1);
1183 <        checkCompletedWithWrappedCFException(h);
1182 >        g.complete(v1);
1183 >
1184 >        checkCompletedWithWrappedCFException(h, ex);
1185 >        checkCompletedWithWrappedCFException(f, ex);
1186 >        assertEquals(0, r.invocationCount);
1187 >        checkCompletedNormally(g, v1);
1188 >        }
1189 >    }
1190 >
1191 >    public void testThenCombine_exceptionalCompletion2() {
1192 >        for (ExecutionMode m : ExecutionMode.values())
1193 >        for (Integer v1 : new Integer[] { 1, null }) {
1194 >
1195 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1196 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1197 >        final SubtractFunction r = new SubtractFunction();
1198 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1199 >        final CFException ex = new CFException();
1200  
1201 <        f = new CompletableFuture<Integer>();
681 <        g = new CompletableFuture<Integer>();
682 <        h = f.thenCombine(g, subtract);
683 <        g.completeExceptionally(new CFException());
1201 >        g.completeExceptionally(ex);
1202          checkIncomplete(h);
1203 <        f.complete(3);
686 <        checkCompletedWithWrappedCFException(h);
1203 >        f.complete(v1);
1204  
1205 <        f = new CompletableFuture<Integer>();
1206 <        g = new CompletableFuture<Integer>();
1207 <        f.complete(3);
1208 <        g.completeExceptionally(new CFException());
1209 <        h = f.thenCombine(g, subtract);
1210 <        checkCompletedWithWrappedCFException(h);
1205 >        checkCompletedWithWrappedCFException(h, ex);
1206 >        checkCompletedWithWrappedCFException(g, ex);
1207 >        assertEquals(0, r.invocationCount);
1208 >        checkCompletedNormally(f, v1);
1209 >        }
1210 >    }
1211  
1212 <        f = new CompletableFuture<Integer>();
1213 <        g = new CompletableFuture<Integer>();
1214 <        f.completeExceptionally(new CFException());
1215 <        g.complete(3);
1216 <        h = f.thenCombine(g, subtract);
1217 <        checkCompletedWithWrappedCFException(h);
1212 >    public void testThenCombine_exceptionalCompletion3() {
1213 >        for (ExecutionMode m : ExecutionMode.values())
1214 >        for (Integer v1 : new Integer[] { 1, null }) {
1215 >
1216 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1217 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1218 >        final SubtractFunction r = new SubtractFunction();
1219 >        final CFException ex = new CFException();
1220 >
1221 >        g.completeExceptionally(ex);
1222 >        f.complete(v1);
1223 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1224 >
1225 >        checkCompletedWithWrappedCFException(h, ex);
1226 >        checkCompletedWithWrappedCFException(g, ex);
1227 >        assertEquals(0, r.invocationCount);
1228 >        checkCompletedNormally(f, v1);
1229 >        }
1230 >    }
1231 >
1232 >    public void testThenCombine_exceptionalCompletion4() {
1233 >        for (ExecutionMode m : ExecutionMode.values())
1234 >        for (Integer v1 : new Integer[] { 1, null }) {
1235 >
1236 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1237 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1238 >        final SubtractFunction r = new SubtractFunction();
1239 >        final CFException ex = new CFException();
1240 >
1241 >        f.completeExceptionally(ex);
1242 >        g.complete(v1);
1243 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1244 >
1245 >        checkCompletedWithWrappedCFException(h, ex);
1246 >        checkCompletedWithWrappedCFException(f, ex);
1247 >        assertEquals(0, r.invocationCount);
1248 >        checkCompletedNormally(g, v1);
1249 >        }
1250      }
1251  
1252      /**
1253       * thenCombine result completes exceptionally if action does
1254       */
1255 <    public void testThenCombine3() {
1256 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1257 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1258 <        FailingBiFunction r = new FailingBiFunction();
1259 <        CompletableFuture<Integer> g = f.thenCombine(f2, r);
1260 <        f.complete(one);
1261 <        checkIncomplete(g);
1262 <        assertFalse(r.ran);
1263 <        f2.complete(two);
1264 <        checkCompletedWithWrappedCFException(g);
1265 <        assertTrue(r.ran);
1255 >    public void testThenCombine_actionFailed1() {
1256 >        for (ExecutionMode m : ExecutionMode.values())
1257 >        for (Integer v1 : new Integer[] { 1, null })
1258 >        for (Integer v2 : new Integer[] { 2, null }) {
1259 >
1260 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1261 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1262 >        final FailingBiFunction r = new FailingBiFunction();
1263 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1264 >
1265 >        f.complete(v1);
1266 >        checkIncomplete(h);
1267 >        g.complete(v2);
1268 >
1269 >        checkCompletedWithWrappedCFException(h);
1270 >        checkCompletedNormally(f, v1);
1271 >        checkCompletedNormally(g, v2);
1272 >        }
1273 >    }
1274 >
1275 >    public void testThenCombine_actionFailed2() {
1276 >        for (ExecutionMode m : ExecutionMode.values())
1277 >        for (Integer v1 : new Integer[] { 1, null })
1278 >        for (Integer v2 : new Integer[] { 2, null }) {
1279 >
1280 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1281 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1282 >        final FailingBiFunction r = new FailingBiFunction();
1283 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1284 >
1285 >        g.complete(v2);
1286 >        checkIncomplete(h);
1287 >        f.complete(v1);
1288 >
1289 >        checkCompletedWithWrappedCFException(h);
1290 >        checkCompletedNormally(f, v1);
1291 >        checkCompletedNormally(g, v2);
1292 >        }
1293      }
1294  
1295      /**
1296       * thenCombine result completes exceptionally if either source cancelled
1297       */
1298 <    public void testThenCombine4() {
1299 <        CompletableFuture<Integer> f, g, h;
1298 >    public void testThenCombine_sourceCancelled1() {
1299 >        for (ExecutionMode m : ExecutionMode.values())
1300 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1301 >        for (Integer v1 : new Integer[] { 1, null }) {
1302 >
1303 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1304 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1305 >        final SubtractFunction r = new SubtractFunction();
1306 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1307  
1308 <        f = new CompletableFuture<Integer>();
726 <        g = new CompletableFuture<Integer>();
727 <        h = f.thenCombine(g, subtract);
728 <        assertTrue(f.cancel(true));
1308 >        assertTrue(f.cancel(mayInterruptIfRunning));
1309          checkIncomplete(h);
1310 <        g.complete(1);
1310 >        g.complete(v1);
1311 >
1312          checkCompletedWithWrappedCancellationException(h);
1313 +        checkCancelled(f);
1314 +        assertEquals(0, r.invocationCount);
1315 +        checkCompletedNormally(g, v1);
1316 +        }
1317 +    }
1318  
1319 <        f = new CompletableFuture<Integer>();
1320 <        g = new CompletableFuture<Integer>();
1321 <        h = f.thenCombine(g, subtract);
1322 <        assertTrue(g.cancel(true));
1319 >    public void testThenCombine_sourceCancelled2() {
1320 >        for (ExecutionMode m : ExecutionMode.values())
1321 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1322 >        for (Integer v1 : new Integer[] { 1, null }) {
1323 >
1324 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1325 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1326 >        final SubtractFunction r = new SubtractFunction();
1327 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1328 >
1329 >        assertTrue(g.cancel(mayInterruptIfRunning));
1330          checkIncomplete(h);
1331 <        f.complete(3);
1331 >        f.complete(v1);
1332 >
1333 >        checkCompletedWithWrappedCancellationException(h);
1334 >        checkCancelled(g);
1335 >        assertEquals(0, r.invocationCount);
1336 >        checkCompletedNormally(f, v1);
1337 >        }
1338 >    }
1339 >
1340 >    public void testThenCombine_sourceCancelled3() {
1341 >        for (ExecutionMode m : ExecutionMode.values())
1342 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1343 >        for (Integer v1 : new Integer[] { 1, null }) {
1344 >
1345 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1346 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1347 >        final SubtractFunction r = new SubtractFunction();
1348 >
1349 >        assertTrue(g.cancel(mayInterruptIfRunning));
1350 >        f.complete(v1);
1351 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1352 >
1353          checkCompletedWithWrappedCancellationException(h);
1354 +        checkCancelled(g);
1355 +        assertEquals(0, r.invocationCount);
1356 +        checkCompletedNormally(f, v1);
1357 +        }
1358 +    }
1359 +
1360 +    public void testThenCombine_sourceCancelled4() {
1361 +        for (ExecutionMode m : ExecutionMode.values())
1362 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1363 +        for (Integer v1 : new Integer[] { 1, null }) {
1364 +
1365 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1366 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1367 +        final SubtractFunction r = new SubtractFunction();
1368 +
1369 +        assertTrue(f.cancel(mayInterruptIfRunning));
1370 +        g.complete(v1);
1371 +        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1372  
741        f = new CompletableFuture<Integer>();
742        g = new CompletableFuture<Integer>();
743        assertTrue(f.cancel(true));
744        assertTrue(g.cancel(true));
745        h = f.thenCombine(g, subtract);
1373          checkCompletedWithWrappedCancellationException(h);
1374 +        checkCancelled(f);
1375 +        assertEquals(0, r.invocationCount);
1376 +        checkCompletedNormally(g, v1);
1377 +        }
1378      }
1379  
1380      /**
1381       * thenAcceptBoth result completes normally after normal
1382       * completion of sources
1383       */
1384 <    public void testThenAcceptBoth() {
1385 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1386 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1387 <        AddAction r = new AddAction();
1388 <        CompletableFuture<Void> g = f.thenAcceptBoth(f2, r);
1389 <        f.complete(one);
1390 <        checkIncomplete(g);
1391 <        f2.complete(two);
1392 <        checkCompletedNormally(g, null);
762 <        assertEquals(r.value, 3);
1384 >    public void testThenAcceptBoth_normalCompletion1() {
1385 >        for (ExecutionMode m : ExecutionMode.values())
1386 >        for (Integer v1 : new Integer[] { 1, null })
1387 >        for (Integer v2 : new Integer[] { 2, null }) {
1388 >
1389 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1390 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1391 >        final SubtractAction r = new SubtractAction();
1392 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1393  
1394 <        r = new AddAction();
1395 <        f = new CompletableFuture<Integer>();
1396 <        f.complete(one);
1397 <        f2 = new CompletableFuture<Integer>();
1398 <        g = f.thenAcceptBoth(f2, r);
1399 <        checkIncomplete(g);
1400 <        f2.complete(two);
1401 <        checkCompletedNormally(g, null);
1402 <        assertEquals(r.value, 3);
1394 >        f.complete(v1);
1395 >        checkIncomplete(h);
1396 >        assertEquals(0, r.invocationCount);
1397 >        g.complete(v2);
1398 >
1399 >        checkCompletedNormally(h, null);
1400 >        assertEquals(subtract(v1, v2), r.value);
1401 >        checkCompletedNormally(f, v1);
1402 >        checkCompletedNormally(g, v2);
1403 >        }
1404      }
1405  
1406 <    /**
1407 <     * thenAcceptBoth result completes exceptionally after exceptional
1408 <     * completion of either source
1409 <     */
1410 <    public void testThenAcceptBoth2() {
1411 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1412 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1413 <        AddAction r = new AddAction();
1414 <        CompletableFuture<Void> g = f.thenAcceptBoth(f2, r);
784 <        f.completeExceptionally(new CFException());
785 <        f2.complete(two);
786 <        checkCompletedWithWrappedCFException(g);
1406 >    public void testThenAcceptBoth_normalCompletion2() {
1407 >        for (ExecutionMode m : ExecutionMode.values())
1408 >        for (Integer v1 : new Integer[] { 1, null })
1409 >        for (Integer v2 : new Integer[] { 2, null }) {
1410 >
1411 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1412 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1413 >        final SubtractAction r = new SubtractAction();
1414 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1415  
1416 <        r = new AddAction();
1417 <        f = new CompletableFuture<Integer>();
1418 <        f.complete(one);
1419 <        f2 = new CompletableFuture<Integer>();
1420 <        g = f.thenAcceptBoth(f2, r);
1421 <        f2.completeExceptionally(new CFException());
1422 <        checkCompletedWithWrappedCFException(g);
1416 >        g.complete(v2);
1417 >        checkIncomplete(h);
1418 >        assertEquals(0, r.invocationCount);
1419 >        f.complete(v1);
1420 >
1421 >        checkCompletedNormally(h, null);
1422 >        assertEquals(subtract(v1, v2), r.value);
1423 >        checkCompletedNormally(f, v1);
1424 >        checkCompletedNormally(g, v2);
1425 >        }
1426      }
1427  
1428 <    /**
1429 <     * thenAcceptBoth result completes exceptionally if action does
1430 <     */
1431 <    public void testThenAcceptBoth3() {
1432 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1433 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1434 <        FailingBiConsumer r = new FailingBiConsumer();
1435 <        CompletableFuture<Void> g = f.thenAcceptBoth(f2, r);
1436 <        f.complete(one);
1437 <        checkIncomplete(g);
1438 <        f2.complete(two);
1439 <        checkCompletedWithWrappedCFException(g);
1428 >    public void testThenAcceptBoth_normalCompletion3() {
1429 >        for (ExecutionMode m : ExecutionMode.values())
1430 >        for (Integer v1 : new Integer[] { 1, null })
1431 >        for (Integer v2 : new Integer[] { 2, null }) {
1432 >
1433 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1434 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1435 >        final SubtractAction r = new SubtractAction();
1436 >
1437 >        g.complete(v2);
1438 >        f.complete(v1);
1439 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1440 >
1441 >        checkCompletedNormally(h, null);
1442 >        assertEquals(subtract(v1, v2), r.value);
1443 >        checkCompletedNormally(f, v1);
1444 >        checkCompletedNormally(g, v2);
1445 >        }
1446      }
1447  
1448 <    /**
1449 <     * thenAcceptBoth result completes exceptionally if either source cancelled
1450 <     */
1451 <    public void testThenAcceptBoth4() {
1452 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1453 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1454 <        AddAction r = new AddAction();
1455 <        CompletableFuture<Void> g = f.thenAcceptBoth(f2, r);
1456 <        assertTrue(f.cancel(true));
1457 <        f2.complete(two);
1458 <        checkCompletedWithWrappedCancellationException(g);
1459 <        f = new CompletableFuture<Integer>();
1460 <        f2 = new CompletableFuture<Integer>();
1461 <        r = new AddAction();
1462 <        g = f.thenAcceptBoth(f2, r);
1463 <        f.complete(one);
1464 <        assertTrue(f2.cancel(true));
1465 <        checkCompletedWithWrappedCancellationException(g);
1448 >    public void testThenAcceptBoth_normalCompletion4() {
1449 >        for (ExecutionMode m : ExecutionMode.values())
1450 >        for (Integer v1 : new Integer[] { 1, null })
1451 >        for (Integer v2 : new Integer[] { 2, null }) {
1452 >
1453 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1454 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1455 >        final SubtractAction r = new SubtractAction();
1456 >
1457 >        f.complete(v1);
1458 >        g.complete(v2);
1459 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1460 >
1461 >        checkCompletedNormally(h, null);
1462 >        assertEquals(subtract(v1, v2), r.value);
1463 >        checkCompletedNormally(f, v1);
1464 >        checkCompletedNormally(g, v2);
1465 >        }
1466      }
1467  
1468      /**
1469 <     * runAfterBoth result completes normally after normal
1470 <     * completion of sources
1469 >     * thenAcceptBoth result completes exceptionally after exceptional
1470 >     * completion of either source
1471       */
1472 <    public void testRunAfterBoth() {
1473 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1474 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1475 <        Noop r = new Noop();
1476 <        CompletableFuture<Void> g = f.runAfterBoth(f2, r);
1477 <        f.complete(one);
1478 <        checkIncomplete(g);
1479 <        f2.complete(two);
1480 <        checkCompletedNormally(g, null);
844 <        assertTrue(r.ran);
1472 >    public void testThenAcceptBoth_exceptionalCompletion1() {
1473 >        for (ExecutionMode m : ExecutionMode.values())
1474 >        for (Integer v1 : new Integer[] { 1, null }) {
1475 >
1476 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1477 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1478 >        final SubtractAction r = new SubtractAction();
1479 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1480 >        final CFException ex = new CFException();
1481  
1482 <        r = new Noop();
1483 <        f = new CompletableFuture<Integer>();
1484 <        f.complete(one);
1485 <        f2 = new CompletableFuture<Integer>();
1486 <        g = f.runAfterBoth(f2, r);
1487 <        checkIncomplete(g);
1488 <        f2.complete(two);
1489 <        checkCompletedNormally(g, null);
1490 <        assertTrue(r.ran);
1482 >        f.completeExceptionally(ex);
1483 >        checkIncomplete(h);
1484 >        g.complete(v1);
1485 >
1486 >        checkCompletedWithWrappedCFException(h, ex);
1487 >        checkCompletedWithWrappedCFException(f, ex);
1488 >        assertEquals(0, r.invocationCount);
1489 >        checkCompletedNormally(g, v1);
1490 >        }
1491      }
1492  
1493 <    /**
1494 <     * runAfterBoth result completes exceptionally after exceptional
1495 <     * completion of either source
1496 <     */
1497 <    public void testRunAfterBoth2() {
1498 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1499 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1500 <        Noop r = new Noop();
1501 <        CompletableFuture<Void> g = f.runAfterBoth(f2, r);
866 <        f.completeExceptionally(new CFException());
867 <        f2.complete(two);
868 <        checkCompletedWithWrappedCFException(g);
1493 >    public void testThenAcceptBoth_exceptionalCompletion2() {
1494 >        for (ExecutionMode m : ExecutionMode.values())
1495 >        for (Integer v1 : new Integer[] { 1, null }) {
1496 >
1497 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1498 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1499 >        final SubtractAction r = new SubtractAction();
1500 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1501 >        final CFException ex = new CFException();
1502  
1503 <        r = new Noop();
1504 <        f = new CompletableFuture<Integer>();
1505 <        f.complete(one);
1506 <        f2 = new CompletableFuture<Integer>();
1507 <        g = f.runAfterBoth(f2, r);
1508 <        f2.completeExceptionally(new CFException());
1509 <        checkCompletedWithWrappedCFException(g);
1503 >        g.completeExceptionally(ex);
1504 >        checkIncomplete(h);
1505 >        f.complete(v1);
1506 >
1507 >        checkCompletedWithWrappedCFException(h, ex);
1508 >        checkCompletedWithWrappedCFException(g, ex);
1509 >        assertEquals(0, r.invocationCount);
1510 >        checkCompletedNormally(f, v1);
1511 >        }
1512      }
1513  
1514 <    /**
1515 <     * runAfterBoth result completes exceptionally if action does
1516 <     */
1517 <    public void testRunAfterBoth3() {
1518 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1519 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1520 <        FailingNoop r = new FailingNoop();
1521 <        CompletableFuture<Void> g = f.runAfterBoth(f2, r);
1522 <        f.complete(one);
1523 <        checkIncomplete(g);
1524 <        f2.complete(two);
1525 <        checkCompletedWithWrappedCFException(g);
1514 >    public void testThenAcceptBoth_exceptionalCompletion3() {
1515 >        for (ExecutionMode m : ExecutionMode.values())
1516 >        for (Integer v1 : new Integer[] { 1, null }) {
1517 >
1518 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1519 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1520 >        final SubtractAction r = new SubtractAction();
1521 >        final CFException ex = new CFException();
1522 >
1523 >        g.completeExceptionally(ex);
1524 >        f.complete(v1);
1525 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1526 >
1527 >        checkCompletedWithWrappedCFException(h, ex);
1528 >        checkCompletedWithWrappedCFException(g, ex);
1529 >        assertEquals(0, r.invocationCount);
1530 >        checkCompletedNormally(f, v1);
1531 >        }
1532      }
1533  
1534 <    /**
1535 <     * runAfterBoth result completes exceptionally if either source cancelled
1536 <     */
1537 <    public void testRunAfterBoth4() {
1538 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1539 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1540 <        Noop r = new Noop();
1541 <        CompletableFuture<Void> g = f.runAfterBoth(f2, r);
1542 <        assertTrue(f.cancel(true));
1543 <        f2.complete(two);
1544 <        checkCompletedWithWrappedCancellationException(g);
1545 <        f = new CompletableFuture<Integer>();
1546 <        f2 = new CompletableFuture<Integer>();
1547 <        r = new Noop();
1548 <        g = f.runAfterBoth(f2, r);
1549 <        f.complete(one);
1550 <        assertTrue(f2.cancel(true));
1551 <        checkCompletedWithWrappedCancellationException(g);
1534 >    public void testThenAcceptBoth_exceptionalCompletion4() {
1535 >        for (ExecutionMode m : ExecutionMode.values())
1536 >        for (Integer v1 : new Integer[] { 1, null }) {
1537 >
1538 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1539 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1540 >        final SubtractAction r = new SubtractAction();
1541 >        final CFException ex = new CFException();
1542 >
1543 >        f.completeExceptionally(ex);
1544 >        g.complete(v1);
1545 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1546 >
1547 >        checkCompletedWithWrappedCFException(h, ex);
1548 >        checkCompletedWithWrappedCFException(f, ex);
1549 >        assertEquals(0, r.invocationCount);
1550 >        checkCompletedNormally(g, v1);
1551 >        }
1552      }
1553  
1554      /**
1555 <     * applyToEither result completes normally after normal completion
915 <     * of either source
1555 >     * thenAcceptBoth result completes exceptionally if action does
1556       */
1557 <    public void testApplyToEither() {
1558 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1559 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1560 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1561 <        f.complete(one);
1562 <        checkCompletedNormally(g, two);
1563 <        f2.complete(one);
1564 <        checkCompletedNormally(g, two);
1557 >    public void testThenAcceptBoth_actionFailed1() {
1558 >        for (ExecutionMode m : ExecutionMode.values())
1559 >        for (Integer v1 : new Integer[] { 1, null })
1560 >        for (Integer v2 : new Integer[] { 2, null }) {
1561 >
1562 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1563 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1564 >        final FailingBiConsumer r = new FailingBiConsumer();
1565 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1566  
1567 <        f = new CompletableFuture<Integer>();
1568 <        f.complete(one);
1569 <        f2 = new CompletableFuture<Integer>();
1570 <        g = f.applyToEither(f2, inc);
1571 <        checkCompletedNormally(g, two);
1567 >        f.complete(v1);
1568 >        checkIncomplete(h);
1569 >        g.complete(v2);
1570 >
1571 >        checkCompletedWithWrappedCFException(h);
1572 >        checkCompletedNormally(f, v1);
1573 >        checkCompletedNormally(g, v2);
1574 >        }
1575      }
1576  
1577 <    /**
1578 <     * applyToEither result completes exceptionally after exceptional
1579 <     * completion of either source
1580 <     */
1581 <    public void testApplyToEither2() {
1582 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1583 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1584 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1585 <        f.completeExceptionally(new CFException());
942 <        f2.complete(one);
943 <        checkCompletedWithWrappedCFException(g);
1577 >    public void testThenAcceptBoth_actionFailed2() {
1578 >        for (ExecutionMode m : ExecutionMode.values())
1579 >        for (Integer v1 : new Integer[] { 1, null })
1580 >        for (Integer v2 : new Integer[] { 2, null }) {
1581 >
1582 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1583 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1584 >        final FailingBiConsumer r = new FailingBiConsumer();
1585 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1586  
1587 <        f = new CompletableFuture<Integer>();
1588 <        f2 = new CompletableFuture<Integer>();
1589 <        f2.completeExceptionally(new CFException());
948 <        g = f.applyToEither(f2, inc);
949 <        checkCompletedWithWrappedCFException(g);
950 <    }
1587 >        g.complete(v2);
1588 >        checkIncomplete(h);
1589 >        f.complete(v1);
1590  
1591 <    /**
1592 <     * applyToEither result completes exceptionally if action does
1593 <     */
1594 <    public void testApplyToEither3() {
956 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
957 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
958 <        FailingFunction r = new FailingFunction();
959 <        CompletableFuture<Integer> g = f.applyToEither(f2, r);
960 <        f2.complete(two);
961 <        checkCompletedWithWrappedCFException(g);
1591 >        checkCompletedWithWrappedCFException(h);
1592 >        checkCompletedNormally(f, v1);
1593 >        checkCompletedNormally(g, v2);
1594 >        }
1595      }
1596  
1597      /**
1598 <     * applyToEither result completes exceptionally if either source cancelled
1598 >     * thenAcceptBoth result completes exceptionally if either source cancelled
1599       */
1600 <    public void testApplyToEither4() {
1601 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1602 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1603 <        CompletableFuture<Integer> g = f.applyToEither(f2, inc);
1604 <        assertTrue(f.cancel(true));
1605 <        checkCompletedWithWrappedCancellationException(g);
1606 <        f = new CompletableFuture<Integer>();
1607 <        f2 = new CompletableFuture<Integer>();
1608 <        assertTrue(f2.cancel(true));
1609 <        checkCompletedWithWrappedCancellationException(g);
1600 >    public void testThenAcceptBoth_sourceCancelled1() {
1601 >        for (ExecutionMode m : ExecutionMode.values())
1602 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1603 >        for (Integer v1 : new Integer[] { 1, null }) {
1604 >
1605 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1606 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1607 >        final SubtractAction r = new SubtractAction();
1608 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1609 >
1610 >        assertTrue(f.cancel(mayInterruptIfRunning));
1611 >        checkIncomplete(h);
1612 >        g.complete(v1);
1613 >
1614 >        checkCompletedWithWrappedCancellationException(h);
1615 >        checkCancelled(f);
1616 >        assertEquals(0, r.invocationCount);
1617 >        checkCompletedNormally(g, v1);
1618 >        }
1619      }
1620  
1621 <    /**
1622 <     * acceptEither result completes normally after normal completion
1623 <     * of either source
1624 <     */
1625 <    public void testAcceptEither() {
1626 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1627 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1628 <        IncAction r = new IncAction();
1629 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
988 <        f.complete(one);
989 <        checkCompletedNormally(g, null);
990 <        f2.complete(one);
991 <        checkCompletedNormally(g, null);
992 <        assertEquals(r.value, 2);
1621 >    public void testThenAcceptBoth_sourceCancelled2() {
1622 >        for (ExecutionMode m : ExecutionMode.values())
1623 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1624 >        for (Integer v1 : new Integer[] { 1, null }) {
1625 >
1626 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1627 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1628 >        final SubtractAction r = new SubtractAction();
1629 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1630  
1631 <        r = new IncAction();
1632 <        f = new CompletableFuture<Integer>();
1633 <        f.complete(one);
1634 <        f2 = new CompletableFuture<Integer>();
1635 <        g = f.acceptEither(f2, r);
1636 <        checkCompletedNormally(g, null);
1637 <        assertEquals(r.value, 2);
1631 >        assertTrue(g.cancel(mayInterruptIfRunning));
1632 >        checkIncomplete(h);
1633 >        f.complete(v1);
1634 >
1635 >        checkCompletedWithWrappedCancellationException(h);
1636 >        checkCancelled(g);
1637 >        assertEquals(0, r.invocationCount);
1638 >        checkCompletedNormally(f, v1);
1639 >        }
1640      }
1641  
1642 <    /**
1643 <     * acceptEither result completes exceptionally after exceptional
1644 <     * completion of either source
1645 <     */
1646 <    public void testAcceptEither2() {
1647 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1648 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1649 <        IncAction r = new IncAction();
1650 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1651 <        f.completeExceptionally(new CFException());
1652 <        f2.complete(one);
1653 <        checkCompletedWithWrappedCFException(g);
1642 >    public void testThenAcceptBoth_sourceCancelled3() {
1643 >        for (ExecutionMode m : ExecutionMode.values())
1644 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1645 >        for (Integer v1 : new Integer[] { 1, null }) {
1646 >
1647 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1648 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1649 >        final SubtractAction r = new SubtractAction();
1650 >
1651 >        assertTrue(g.cancel(mayInterruptIfRunning));
1652 >        f.complete(v1);
1653 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1654  
1655 <        r = new IncAction();
1656 <        f = new CompletableFuture<Integer>();
1657 <        f2 = new CompletableFuture<Integer>();
1658 <        f2.completeExceptionally(new CFException());
1659 <        g = f.acceptEither(f2, r);
1021 <        checkCompletedWithWrappedCFException(g);
1655 >        checkCompletedWithWrappedCancellationException(h);
1656 >        checkCancelled(g);
1657 >        assertEquals(0, r.invocationCount);
1658 >        checkCompletedNormally(f, v1);
1659 >        }
1660      }
1661  
1662 <    /**
1663 <     * acceptEither result completes exceptionally if action does
1664 <     */
1665 <    public void testAcceptEither3() {
1666 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1667 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1668 <        FailingConsumer r = new FailingConsumer();
1669 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1670 <        f2.complete(two);
1671 <        checkCompletedWithWrappedCFException(g);
1662 >    public void testThenAcceptBoth_sourceCancelled4() {
1663 >        for (ExecutionMode m : ExecutionMode.values())
1664 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1665 >        for (Integer v1 : new Integer[] { 1, null }) {
1666 >
1667 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1668 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1669 >        final SubtractAction r = new SubtractAction();
1670 >
1671 >        assertTrue(f.cancel(mayInterruptIfRunning));
1672 >        g.complete(v1);
1673 >        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1674 >
1675 >        checkCompletedWithWrappedCancellationException(h);
1676 >        checkCancelled(f);
1677 >        assertEquals(0, r.invocationCount);
1678 >        checkCompletedNormally(g, v1);
1679 >        }
1680      }
1681  
1682      /**
1683 <     * acceptEither result completes exceptionally if either source cancelled
1683 >     * runAfterBoth result completes normally after normal
1684 >     * completion of sources
1685       */
1686 <    public void testAcceptEither4() {
1687 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1688 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1689 <        IncAction r = new IncAction();
1690 <        CompletableFuture<Void> g = f.acceptEither(f2, r);
1691 <        assertTrue(f.cancel(true));
1692 <        checkCompletedWithWrappedCancellationException(g);
1693 <        f = new CompletableFuture<Integer>();
1694 <        f2 = new CompletableFuture<Integer>();
1695 <        assertTrue(f2.cancel(true));
1696 <        checkCompletedWithWrappedCancellationException(g);
1686 >    public void testRunAfterBoth_normalCompletion1() {
1687 >        for (ExecutionMode m : ExecutionMode.values())
1688 >        for (Integer v1 : new Integer[] { 1, null })
1689 >        for (Integer v2 : new Integer[] { 2, null }) {
1690 >
1691 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1692 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1693 >        final Noop r = new Noop();
1694 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1695 >
1696 >        f.complete(v1);
1697 >        checkIncomplete(h);
1698 >        assertEquals(0, r.invocationCount);
1699 >        g.complete(v2);
1700 >
1701 >        checkCompletedNormally(h, null);
1702 >        assertEquals(1, r.invocationCount);
1703 >        checkCompletedNormally(f, v1);
1704 >        checkCompletedNormally(g, v2);
1705 >        }
1706      }
1707  
1708 +    public void testRunAfterBoth_normalCompletion2() {
1709 +        for (ExecutionMode m : ExecutionMode.values())
1710 +        for (Integer v1 : new Integer[] { 1, null })
1711 +        for (Integer v2 : new Integer[] { 2, null }) {
1712 +
1713 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1714 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1715 +        final Noop r = new Noop();
1716 +        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1717  
1718 <    /**
1719 <     * runAfterEither result completes normally after normal completion
1720 <     * of either source
1721 <     */
1057 <    public void testRunAfterEither() {
1058 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1059 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1060 <        Noop r = new Noop();
1061 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1062 <        f.complete(one);
1063 <        checkCompletedNormally(g, null);
1064 <        f2.complete(one);
1065 <        checkCompletedNormally(g, null);
1066 <        assertTrue(r.ran);
1718 >        g.complete(v2);
1719 >        checkIncomplete(h);
1720 >        assertEquals(0, r.invocationCount);
1721 >        f.complete(v1);
1722  
1723 <        r = new Noop();
1724 <        f = new CompletableFuture<Integer>();
1725 <        f.complete(one);
1726 <        f2 = new CompletableFuture<Integer>();
1727 <        g = f.runAfterEither(f2, r);
1728 <        checkCompletedNormally(g, null);
1729 <        assertTrue(r.ran);
1723 >        checkCompletedNormally(h, null);
1724 >        assertEquals(1, r.invocationCount);
1725 >        checkCompletedNormally(f, v1);
1726 >        checkCompletedNormally(g, v2);
1727 >        }
1728 >    }
1729 >
1730 >    public void testRunAfterBoth_normalCompletion3() {
1731 >        for (ExecutionMode m : ExecutionMode.values())
1732 >        for (Integer v1 : new Integer[] { 1, null })
1733 >        for (Integer v2 : new Integer[] { 2, null }) {
1734 >
1735 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1736 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1737 >        final Noop r = new Noop();
1738 >
1739 >        g.complete(v2);
1740 >        f.complete(v1);
1741 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1742 >
1743 >        checkCompletedNormally(h, null);
1744 >        assertEquals(1, r.invocationCount);
1745 >        checkCompletedNormally(f, v1);
1746 >        checkCompletedNormally(g, v2);
1747 >        }
1748 >    }
1749 >
1750 >    public void testRunAfterBoth_normalCompletion4() {
1751 >        for (ExecutionMode m : ExecutionMode.values())
1752 >        for (Integer v1 : new Integer[] { 1, null })
1753 >        for (Integer v2 : new Integer[] { 2, null }) {
1754 >
1755 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1756 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1757 >        final Noop r = new Noop();
1758 >
1759 >        f.complete(v1);
1760 >        g.complete(v2);
1761 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1762 >
1763 >        checkCompletedNormally(h, null);
1764 >        assertEquals(1, r.invocationCount);
1765 >        checkCompletedNormally(f, v1);
1766 >        checkCompletedNormally(g, v2);
1767 >        }
1768      }
1769  
1770      /**
1771 <     * runAfterEither result completes exceptionally after exceptional
1771 >     * runAfterBoth result completes exceptionally after exceptional
1772       * completion of either source
1773       */
1774 <    public void testRunAfterEither2() {
1775 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1776 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1777 <        Noop r = new Noop();
1778 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1779 <        f.completeExceptionally(new CFException());
1780 <        f2.complete(one);
1781 <        checkCompletedWithWrappedCFException(g);
1774 >    public void testRunAfterBoth_exceptionalCompletion1() {
1775 >        for (ExecutionMode m : ExecutionMode.values())
1776 >        for (Integer v1 : new Integer[] { 1, null }) {
1777 >
1778 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1779 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1780 >        final Noop r = new Noop();
1781 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1782 >        final CFException ex = new CFException();
1783  
1784 <        r = new Noop();
1785 <        f = new CompletableFuture<Integer>();
1786 <        f2 = new CompletableFuture<Integer>();
1787 <        f2.completeExceptionally(new CFException());
1788 <        g = f.runAfterEither(f2, r);
1789 <        checkCompletedWithWrappedCFException(g);
1784 >        f.completeExceptionally(ex);
1785 >        checkIncomplete(h);
1786 >        g.complete(v1);
1787 >
1788 >        checkCompletedWithWrappedCFException(h, ex);
1789 >        checkCompletedWithWrappedCFException(f, ex);
1790 >        assertEquals(0, r.invocationCount);
1791 >        checkCompletedNormally(g, v1);
1792 >        }
1793      }
1794  
1795 <    /**
1796 <     * runAfterEither result completes exceptionally if action does
1797 <     */
1798 <    public void testRunAfterEither3() {
1799 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1800 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1801 <        FailingNoop r = new FailingNoop();
1802 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1803 <        f2.complete(two);
1804 <        checkCompletedWithWrappedCFException(g);
1795 >    public void testRunAfterBoth_exceptionalCompletion2() {
1796 >        for (ExecutionMode m : ExecutionMode.values())
1797 >        for (Integer v1 : new Integer[] { 1, null }) {
1798 >
1799 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1800 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1801 >        final Noop r = new Noop();
1802 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1803 >        final CFException ex = new CFException();
1804 >
1805 >        g.completeExceptionally(ex);
1806 >        checkIncomplete(h);
1807 >        f.complete(v1);
1808 >
1809 >        checkCompletedWithWrappedCFException(h, ex);
1810 >        checkCompletedWithWrappedCFException(g, ex);
1811 >        assertEquals(0, r.invocationCount);
1812 >        checkCompletedNormally(f, v1);
1813 >        }
1814      }
1815  
1816 <    /**
1817 <     * runAfterEither result completes exceptionally if either source cancelled
1818 <     */
1819 <    public void testRunAfterEither4() {
1820 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1821 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1822 <        Noop r = new Noop();
1823 <        CompletableFuture<Void> g = f.runAfterEither(f2, r);
1824 <        assertTrue(f.cancel(true));
1825 <        checkCompletedWithWrappedCancellationException(g);
1826 <        f = new CompletableFuture<Integer>();
1827 <        f2 = new CompletableFuture<Integer>();
1828 <        assertTrue(f2.cancel(true));
1829 <        checkCompletedWithWrappedCancellationException(g);
1816 >    public void testRunAfterBoth_exceptionalCompletion3() {
1817 >        for (ExecutionMode m : ExecutionMode.values())
1818 >        for (Integer v1 : new Integer[] { 1, null }) {
1819 >
1820 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1821 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1822 >        final Noop r = new Noop();
1823 >        final CFException ex = new CFException();
1824 >
1825 >        g.completeExceptionally(ex);
1826 >        f.complete(v1);
1827 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1828 >
1829 >        checkCompletedWithWrappedCFException(h, ex);
1830 >        checkCompletedWithWrappedCFException(g, ex);
1831 >        assertEquals(0, r.invocationCount);
1832 >        checkCompletedNormally(f, v1);
1833 >        }
1834 >    }
1835 >
1836 >    public void testRunAfterBoth_exceptionalCompletion4() {
1837 >        for (ExecutionMode m : ExecutionMode.values())
1838 >        for (Integer v1 : new Integer[] { 1, null }) {
1839 >
1840 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1841 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1842 >        final Noop r = new Noop();
1843 >        final CFException ex = new CFException();
1844 >
1845 >        f.completeExceptionally(ex);
1846 >        g.complete(v1);
1847 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1848 >
1849 >        checkCompletedWithWrappedCFException(h, ex);
1850 >        checkCompletedWithWrappedCFException(f, ex);
1851 >        assertEquals(0, r.invocationCount);
1852 >        checkCompletedNormally(g, v1);
1853 >        }
1854      }
1855  
1856      /**
1857 <     * thenCompose result completes normally after normal completion of source
1857 >     * runAfterBoth result completes exceptionally if action does
1858       */
1859 <    public void testThenCompose() {
1860 <        CompletableFuture<Integer> f, g;
1861 <        CompletableFutureInc r;
1859 >    public void testRunAfterBoth_actionFailed1() {
1860 >        for (ExecutionMode m : ExecutionMode.values())
1861 >        for (Integer v1 : new Integer[] { 1, null })
1862 >        for (Integer v2 : new Integer[] { 2, null }) {
1863 >
1864 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1865 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1866 >        final FailingNoop r = new FailingNoop();
1867 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1868  
1869 <        f = new CompletableFuture<Integer>();
1870 <        g = f.thenCompose(r = new CompletableFutureInc());
1871 <        f.complete(one);
1136 <        checkCompletedNormally(g, two);
1137 <        assertTrue(r.ran);
1869 >        f.complete(v1);
1870 >        checkIncomplete(h);
1871 >        g.complete(v2);
1872  
1873 <        f = new CompletableFuture<Integer>();
1874 <        f.complete(one);
1875 <        g = f.thenCompose(r = new CompletableFutureInc());
1876 <        checkCompletedNormally(g, two);
1143 <        assertTrue(r.ran);
1873 >        checkCompletedWithWrappedCFException(h);
1874 >        checkCompletedNormally(f, v1);
1875 >        checkCompletedNormally(g, v2);
1876 >        }
1877      }
1878  
1879 <    /**
1880 <     * thenCompose result completes exceptionally after exceptional
1881 <     * completion of source
1882 <     */
1883 <    public void testThenCompose2() {
1884 <        CompletableFuture<Integer> f, g;
1885 <        CompletableFutureInc r;
1879 >    public void testRunAfterBoth_actionFailed2() {
1880 >        for (ExecutionMode m : ExecutionMode.values())
1881 >        for (Integer v1 : new Integer[] { 1, null })
1882 >        for (Integer v2 : new Integer[] { 2, null }) {
1883 >
1884 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1885 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1886 >        final FailingNoop r = new FailingNoop();
1887 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1888  
1889 <        f = new CompletableFuture<Integer>();
1890 <        g = f.thenCompose(r = new CompletableFutureInc());
1891 <        f.completeExceptionally(new CFException());
1157 <        checkCompletedWithWrappedCFException(g);
1889 >        g.complete(v2);
1890 >        checkIncomplete(h);
1891 >        f.complete(v1);
1892  
1893 <        f = new CompletableFuture<Integer>();
1894 <        f.completeExceptionally(new CFException());
1895 <        g = f.thenCompose(r = new CompletableFutureInc());
1896 <        checkCompletedWithWrappedCFException(g);
1893 >        checkCompletedWithWrappedCFException(h);
1894 >        checkCompletedNormally(f, v1);
1895 >        checkCompletedNormally(g, v2);
1896 >        }
1897      }
1898  
1899      /**
1900 <     * thenCompose result completes exceptionally if action does
1900 >     * runAfterBoth result completes exceptionally if either source cancelled
1901       */
1902 <    public void testThenCompose3() {
1903 <        CompletableFuture<Integer> f, g;
1904 <        FailingCompletableFutureFunction r;
1902 >    public void testRunAfterBoth_sourceCancelled1() {
1903 >        for (ExecutionMode m : ExecutionMode.values())
1904 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1905 >        for (Integer v1 : new Integer[] { 1, null }) {
1906 >
1907 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1908 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1909 >        final Noop r = new Noop();
1910 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1911  
1912 <        f = new CompletableFuture<Integer>();
1913 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
1914 <        f.complete(one);
1175 <        checkCompletedWithWrappedCFException(g);
1912 >        assertTrue(f.cancel(mayInterruptIfRunning));
1913 >        checkIncomplete(h);
1914 >        g.complete(v1);
1915  
1916 <        f = new CompletableFuture<Integer>();
1917 <        f.complete(one);
1918 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
1919 <        checkCompletedWithWrappedCFException(g);
1916 >        checkCompletedWithWrappedCancellationException(h);
1917 >        checkCancelled(f);
1918 >        assertEquals(0, r.invocationCount);
1919 >        checkCompletedNormally(g, v1);
1920 >        }
1921      }
1922  
1923 <    /**
1924 <     * thenCompose result completes exceptionally if source cancelled
1925 <     */
1926 <    public void testThenCompose4() {
1927 <        CompletableFuture<Integer> f, g;
1928 <        CompletableFutureInc r;
1923 >    public void testRunAfterBoth_sourceCancelled2() {
1924 >        for (ExecutionMode m : ExecutionMode.values())
1925 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1926 >        for (Integer v1 : new Integer[] { 1, null }) {
1927 >
1928 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1929 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1930 >        final Noop r = new Noop();
1931 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1932  
1933 <        f = new CompletableFuture<Integer>();
1934 <        g = f.thenCompose(r = new CompletableFutureInc());
1935 <        assertTrue(f.cancel(true));
1193 <        checkCompletedWithWrappedCancellationException(g);
1933 >        assertTrue(g.cancel(mayInterruptIfRunning));
1934 >        checkIncomplete(h);
1935 >        f.complete(v1);
1936  
1937 <        f = new CompletableFuture<Integer>();
1938 <        assertTrue(f.cancel(true));
1939 <        g = f.thenCompose(r = new CompletableFutureInc());
1940 <        checkCompletedWithWrappedCancellationException(g);
1937 >        checkCompletedWithWrappedCancellationException(h);
1938 >        checkCancelled(g);
1939 >        assertEquals(0, r.invocationCount);
1940 >        checkCompletedNormally(f, v1);
1941 >        }
1942      }
1943  
1944 +    public void testRunAfterBoth_sourceCancelled3() {
1945 +        for (ExecutionMode m : ExecutionMode.values())
1946 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1947 +        for (Integer v1 : new Integer[] { 1, null }) {
1948 +
1949 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1950 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1951 +        final Noop r = new Noop();
1952 +
1953 +        assertTrue(g.cancel(mayInterruptIfRunning));
1954 +        f.complete(v1);
1955 +        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1956  
1957 <    // asyncs
1957 >        checkCompletedWithWrappedCancellationException(h);
1958 >        checkCancelled(g);
1959 >        assertEquals(0, r.invocationCount);
1960 >        checkCompletedNormally(f, v1);
1961 >        }
1962 >    }
1963 >
1964 >    public void testRunAfterBoth_sourceCancelled4() {
1965 >        for (ExecutionMode m : ExecutionMode.values())
1966 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1967 >        for (Integer v1 : new Integer[] { 1, null }) {
1968 >
1969 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1970 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1971 >        final Noop r = new Noop();
1972 >
1973 >        assertTrue(f.cancel(mayInterruptIfRunning));
1974 >        g.complete(v1);
1975 >        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1976 >
1977 >        checkCompletedWithWrappedCancellationException(h);
1978 >        checkCancelled(f);
1979 >        assertEquals(0, r.invocationCount);
1980 >        checkCompletedNormally(g, v1);
1981 >        }
1982 >    }
1983  
1984      /**
1985 <     * thenRunAsync result completes normally after normal completion of source
1985 >     * applyToEither result completes normally after normal completion
1986 >     * of either source
1987       */
1988 <    public void testThenRunAsync() {
1989 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1990 <        Noop r = new Noop();
1991 <        CompletableFuture<Void> g = f.thenRunAsync(r);
1992 <        f.complete(null);
1993 <        checkCompletedNormally(g, null);
1988 >    public void testApplyToEither_normalCompletion1() {
1989 >        for (ExecutionMode m : ExecutionMode.values())
1990 >        for (Integer v1 : new Integer[] { 1, null })
1991 >        for (Integer v2 : new Integer[] { 2, null }) {
1992 >
1993 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1994 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
1995 >        final IncFunction r = new IncFunction();
1996 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1997 >
1998 >        f.complete(v1);
1999 >        checkCompletedNormally(h, inc(v1));
2000 >        g.complete(v2);
2001 >
2002 >        checkCompletedNormally(f, v1);
2003 >        checkCompletedNormally(g, v2);
2004 >        checkCompletedNormally(h, inc(v1));
2005 >        }
2006 >    }
2007  
2008 <        // reordered version
2009 <        f = new CompletableFuture<Integer>();
2010 <        f.complete(null);
2011 <        r = new Noop();
2012 <        g = f.thenRunAsync(r);
2013 <        checkCompletedNormally(g, null);
2008 >    public void testApplyToEither_normalCompletion2() {
2009 >        for (ExecutionMode m : ExecutionMode.values())
2010 >        for (Integer v1 : new Integer[] { 1, null })
2011 >        for (Integer v2 : new Integer[] { 2, null }) {
2012 >
2013 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2014 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2015 >        final IncFunction r = new IncFunction();
2016 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2017 >
2018 >        g.complete(v2);
2019 >        checkCompletedNormally(h, inc(v2));
2020 >        f.complete(v1);
2021 >
2022 >        checkCompletedNormally(f, v1);
2023 >        checkCompletedNormally(g, v2);
2024 >        checkCompletedNormally(h, inc(v2));
2025 >        }
2026 >    }
2027 >    public void testApplyToEither_normalCompletion3() {
2028 >        for (ExecutionMode m : ExecutionMode.values())
2029 >        for (Integer v1 : new Integer[] { 1, null })
2030 >        for (Integer v2 : new Integer[] { 2, null }) {
2031 >
2032 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2033 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2034 >        final IncFunction r = new IncFunction();
2035 >
2036 >        f.complete(v1);
2037 >        g.complete(v2);
2038 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2039 >
2040 >        checkCompletedNormally(f, v1);
2041 >        checkCompletedNormally(g, v2);
2042 >
2043 >        // unspecified behavior
2044 >        assertTrue(Objects.equals(h.join(), inc(v1)) ||
2045 >                   Objects.equals(h.join(), inc(v2)));
2046 >        assertEquals(1, r.invocationCount);
2047 >        }
2048      }
2049  
2050      /**
2051 <     * thenRunAsync result completes exceptionally after exceptional
2052 <     * completion of source
2051 >     * applyToEither result completes exceptionally after exceptional
2052 >     * completion of either source
2053       */
2054 <    public void testThenRunAsync2() {
2055 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2056 <        Noop r = new Noop();
2057 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2058 <        f.completeExceptionally(new CFException());
2054 >    public void testApplyToEither_exceptionalCompletion1() {
2055 >        for (ExecutionMode m : ExecutionMode.values())
2056 >        for (Integer v1 : new Integer[] { 1, null }) {
2057 >
2058 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2059 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2060 >        final IncFunction r = new IncFunction();
2061 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2062 >        final CFException ex = new CFException();
2063 >
2064 >        f.completeExceptionally(ex);
2065 >        checkCompletedWithWrappedCFException(h, ex);
2066 >        g.complete(v1);
2067 >
2068 >        assertEquals(0, r.invocationCount);
2069 >        checkCompletedNormally(g, v1);
2070 >        checkCompletedWithWrappedCFException(f, ex);
2071 >        checkCompletedWithWrappedCFException(h, ex);
2072 >        }
2073 >    }
2074 >
2075 >    public void testApplyToEither_exceptionalCompletion2() {
2076 >        for (ExecutionMode m : ExecutionMode.values())
2077 >        for (Integer v1 : new Integer[] { 1, null }) {
2078 >
2079 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2080 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2081 >        final IncFunction r = new IncFunction();
2082 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2083 >        final CFException ex = new CFException();
2084 >
2085 >        g.completeExceptionally(ex);
2086 >        checkCompletedWithWrappedCFException(h, ex);
2087 >        f.complete(v1);
2088 >
2089 >        assertEquals(0, r.invocationCount);
2090 >        checkCompletedNormally(f, v1);
2091 >        checkCompletedWithWrappedCFException(g, ex);
2092 >        checkCompletedWithWrappedCFException(h, ex);
2093 >        }
2094 >    }
2095 >
2096 >    public void testApplyToEither_exceptionalCompletion3() {
2097 >        for (ExecutionMode m : ExecutionMode.values())
2098 >        for (Integer v1 : new Integer[] { 1, null }) {
2099 >
2100 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2101 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2102 >        final IncFunction r = new IncFunction();
2103 >        final CFException ex = new CFException();
2104 >
2105 >        g.completeExceptionally(ex);
2106 >        f.complete(v1);
2107 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2108 >
2109 >        // unspecified behavior
2110 >        Integer v;
2111          try {
2112 <            g.join();
2113 <            shouldThrow();
2114 <        } catch (Exception ok) {
2112 >            assertEquals(inc(v1), h.join());
2113 >            assertEquals(1, r.invocationCount);
2114 >        } catch (CompletionException ok) {
2115 >            checkCompletedWithWrappedCFException(h, ex);
2116 >            assertEquals(0, r.invocationCount);
2117 >        }
2118 >
2119 >        checkCompletedWithWrappedCFException(g, ex);
2120 >        checkCompletedNormally(f, v1);
2121          }
1236        checkCompletedWithWrappedCFException(g);
2122      }
2123  
2124 <    /**
2125 <     * thenRunAsync result completes exceptionally if action does
2126 <     */
2127 <    public void testThenRunAsync3() {
2128 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2129 <        FailingNoop r = new FailingNoop();
2130 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2131 <        f.complete(null);
2132 <        checkCompletedWithWrappedCFException(g);
2124 >    public void testApplyToEither_exceptionalCompletion4() {
2125 >        for (ExecutionMode m : ExecutionMode.values())
2126 >        for (Integer v1 : new Integer[] { 1, null }) {
2127 >
2128 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2129 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2130 >        final IncFunction r = new IncFunction();
2131 >        final CFException ex = new CFException();
2132 >
2133 >        f.completeExceptionally(ex);
2134 >        g.complete(v1);
2135 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2136 >
2137 >        // unspecified behavior
2138 >        Integer v;
2139 >        try {
2140 >            assertEquals(inc(v1), h.join());
2141 >            assertEquals(1, r.invocationCount);
2142 >        } catch (CompletionException ok) {
2143 >            checkCompletedWithWrappedCFException(h, ex);
2144 >            assertEquals(0, r.invocationCount);
2145 >        }
2146 >
2147 >        checkCompletedWithWrappedCFException(f, ex);
2148 >        checkCompletedNormally(g, v1);
2149 >        }
2150      }
2151  
2152      /**
2153 <     * thenRunAsync result completes exceptionally if source cancelled
2153 >     * applyToEither result completes exceptionally if action does
2154       */
2155 <    public void testThenRunAsync4() {
2156 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2157 <        Noop r = new Noop();
2158 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2159 <        assertTrue(f.cancel(true));
2160 <        checkCompletedWithWrappedCancellationException(g);
2155 >    public void testApplyToEither_actionFailed1() {
2156 >        for (ExecutionMode m : ExecutionMode.values())
2157 >        for (Integer v1 : new Integer[] { 1, null })
2158 >        for (Integer v2 : new Integer[] { 2, null }) {
2159 >
2160 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2161 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2162 >        final FailingFunction r = new FailingFunction();
2163 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2164 >
2165 >        f.complete(v1);
2166 >        checkCompletedWithWrappedCFException(h);
2167 >        g.complete(v2);
2168 >        checkCompletedNormally(f, v1);
2169 >        checkCompletedNormally(g, v2);
2170 >        }
2171      }
2172  
2173 <    /**
2174 <     * thenApplyAsync result completes normally after normal completion of source
2175 <     */
2176 <    public void testThenApplyAsync() {
2177 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2178 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2179 <        f.complete(one);
2180 <        checkCompletedNormally(g, two);
2173 >    public void testApplyToEither_actionFailed2() {
2174 >        for (ExecutionMode m : ExecutionMode.values())
2175 >        for (Integer v1 : new Integer[] { 1, null })
2176 >        for (Integer v2 : new Integer[] { 2, null }) {
2177 >
2178 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2179 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2180 >        final FailingFunction r = new FailingFunction();
2181 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2182 >
2183 >        g.complete(v2);
2184 >        checkCompletedWithWrappedCFException(h);
2185 >        f.complete(v1);
2186 >        checkCompletedNormally(f, v1);
2187 >        checkCompletedNormally(g, v2);
2188 >        }
2189      }
2190  
2191      /**
2192 <     * thenApplyAsync result completes exceptionally after exceptional
1273 <     * completion of source
2192 >     * applyToEither result completes exceptionally if either source cancelled
2193       */
2194 <    public void testThenApplyAsync2() {
2195 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2196 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2197 <        f.completeExceptionally(new CFException());
2198 <        checkCompletedWithWrappedCFException(g);
2194 >    public void testApplyToEither_sourceCancelled1() {
2195 >        for (ExecutionMode m : ExecutionMode.values())
2196 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2197 >        for (Integer v1 : new Integer[] { 1, null }) {
2198 >
2199 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2200 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2201 >        final IncFunction r = new IncFunction();
2202 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2203 >
2204 >        assertTrue(f.cancel(mayInterruptIfRunning));
2205 >        checkCompletedWithWrappedCancellationException(h);
2206 >        g.complete(v1);
2207 >
2208 >        checkCancelled(f);
2209 >        assertEquals(0, r.invocationCount);
2210 >        checkCompletedNormally(g, v1);
2211 >        checkCompletedWithWrappedCancellationException(h);
2212 >        }
2213      }
2214  
2215 <    /**
2216 <     * thenApplyAsync result completes exceptionally if action does
2217 <     */
2218 <    public void testThenApplyAsync3() {
2219 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2220 <        FailingFunction r = new FailingFunction();
2221 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
2222 <        f.complete(null);
2223 <        checkCompletedWithWrappedCFException(g);
2215 >    public void testApplyToEither_sourceCancelled2() {
2216 >        for (ExecutionMode m : ExecutionMode.values())
2217 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2218 >        for (Integer v1 : new Integer[] { 1, null }) {
2219 >
2220 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2221 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2222 >        final IncFunction r = new IncFunction();
2223 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2224 >
2225 >        assertTrue(g.cancel(mayInterruptIfRunning));
2226 >        checkCompletedWithWrappedCancellationException(h);
2227 >        f.complete(v1);
2228 >
2229 >        checkCancelled(g);
2230 >        assertEquals(0, r.invocationCount);
2231 >        checkCompletedNormally(f, v1);
2232 >        checkCompletedWithWrappedCancellationException(h);
2233 >        }
2234      }
2235  
2236 <    /**
2237 <     * thenApplyAsync result completes exceptionally if source cancelled
2238 <     */
2239 <    public void testThenApplyAsync4() {
2240 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2241 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2242 <        assertTrue(f.cancel(true));
2243 <        checkCompletedWithWrappedCancellationException(g);
2236 >    public void testApplyToEither_sourceCancelled3() {
2237 >        for (ExecutionMode m : ExecutionMode.values())
2238 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2239 >        for (Integer v1 : new Integer[] { 1, null }) {
2240 >
2241 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2242 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2243 >        final IncFunction r = new IncFunction();
2244 >
2245 >        assertTrue(g.cancel(mayInterruptIfRunning));
2246 >        f.complete(v1);
2247 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2248 >
2249 >        // unspecified behavior
2250 >        Integer v;
2251 >        try {
2252 >            assertEquals(inc(v1), h.join());
2253 >            assertEquals(1, r.invocationCount);
2254 >        } catch (CompletionException ok) {
2255 >            checkCompletedWithWrappedCancellationException(h);
2256 >            assertEquals(0, r.invocationCount);
2257 >        }
2258 >
2259 >        checkCancelled(g);
2260 >        checkCompletedNormally(f, v1);
2261 >        }
2262      }
2263  
2264 <    /**
2265 <     * thenAcceptAsync result completes normally after normal
2266 <     * completion of source
2267 <     */
2268 <    public void testThenAcceptAsync() {
2269 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2270 <        IncAction r = new IncAction();
2271 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2272 <        f.complete(one);
2273 <        checkCompletedNormally(g, null);
2274 <        assertEquals(r.value, 2);
2264 >    public void testApplyToEither_sourceCancelled4() {
2265 >        for (ExecutionMode m : ExecutionMode.values())
2266 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2267 >        for (Integer v1 : new Integer[] { 1, null }) {
2268 >
2269 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2270 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2271 >        final IncFunction r = new IncFunction();
2272 >
2273 >        assertTrue(f.cancel(mayInterruptIfRunning));
2274 >        g.complete(v1);
2275 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2276 >
2277 >        // unspecified behavior
2278 >        Integer v;
2279 >        try {
2280 >            assertEquals(inc(v1), h.join());
2281 >            assertEquals(1, r.invocationCount);
2282 >        } catch (CompletionException ok) {
2283 >            checkCompletedWithWrappedCancellationException(h);
2284 >            assertEquals(0, r.invocationCount);
2285 >        }
2286 >
2287 >        checkCancelled(f);
2288 >        checkCompletedNormally(g, v1);
2289 >        }
2290      }
2291  
2292      /**
2293 <     * thenAcceptAsync result completes exceptionally after exceptional
2294 <     * completion of source
2293 >     * acceptEither result completes normally after normal completion
2294 >     * of either source
2295       */
2296 <    public void testThenAcceptAsync2() {
2297 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2298 <        IncAction r = new IncAction();
2299 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2300 <        f.completeExceptionally(new CFException());
2301 <        checkCompletedWithWrappedCFException(g);
2296 >    public void testAcceptEither_normalCompletion1() {
2297 >        for (ExecutionMode m : ExecutionMode.values())
2298 >        for (Integer v1 : new Integer[] { 1, null })
2299 >        for (Integer v2 : new Integer[] { 2, null }) {
2300 >
2301 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2302 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2303 >        final IncAction r = new IncAction();
2304 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2305 >
2306 >        f.complete(v1);
2307 >        checkCompletedNormally(h, null);
2308 >        assertEquals(inc(v1), r.value);
2309 >        g.complete(v2);
2310 >
2311 >        checkCompletedNormally(f, v1);
2312 >        checkCompletedNormally(g, v2);
2313 >        checkCompletedNormally(h, null);
2314 >        }
2315      }
2316  
2317 <    /**
2318 <     * thenAcceptAsync result completes exceptionally if action does
2319 <     */
2320 <    public void testThenAcceptAsync3() {
2321 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2322 <        FailingConsumer r = new FailingConsumer();
2323 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2324 <        f.complete(null);
2325 <        checkCompletedWithWrappedCFException(g);
2317 >    public void testAcceptEither_normalCompletion2() {
2318 >        for (ExecutionMode m : ExecutionMode.values())
2319 >        for (Integer v1 : new Integer[] { 1, null })
2320 >        for (Integer v2 : new Integer[] { 2, null }) {
2321 >
2322 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2323 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2324 >        final IncAction r = new IncAction();
2325 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2326 >
2327 >        g.complete(v2);
2328 >        checkCompletedNormally(h, null);
2329 >        assertEquals(inc(v2), r.value);
2330 >        f.complete(v1);
2331 >
2332 >        checkCompletedNormally(f, v1);
2333 >        checkCompletedNormally(g, v2);
2334 >        checkCompletedNormally(h, null);
2335 >        }
2336 >    }
2337 >    public void testAcceptEither_normalCompletion3() {
2338 >        for (ExecutionMode m : ExecutionMode.values())
2339 >        for (Integer v1 : new Integer[] { 1, null })
2340 >        for (Integer v2 : new Integer[] { 2, null }) {
2341 >
2342 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2343 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2344 >        final IncAction r = new IncAction();
2345 >
2346 >        f.complete(v1);
2347 >        g.complete(v2);
2348 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2349 >
2350 >        checkCompletedNormally(h, null);
2351 >        checkCompletedNormally(f, v1);
2352 >        checkCompletedNormally(g, v2);
2353 >
2354 >        // unspecified behavior
2355 >        assertTrue(Objects.equals(r.value, inc(v1)) ||
2356 >                   Objects.equals(r.value, inc(v2)));
2357 >        }
2358      }
2359  
2360      /**
2361 <     * thenAcceptAsync result completes exceptionally if source cancelled
2361 >     * acceptEither result completes exceptionally after exceptional
2362 >     * completion of either source
2363       */
2364 <    public void testThenAcceptAsync4() {
2365 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2366 <        IncAction r = new IncAction();
2367 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2368 <        assertTrue(f.cancel(true));
2369 <        checkCompletedWithWrappedCancellationException(g);
2364 >    public void testAcceptEither_exceptionalCompletion1() {
2365 >        for (ExecutionMode m : ExecutionMode.values())
2366 >        for (Integer v1 : new Integer[] { 1, null }) {
2367 >
2368 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2369 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2370 >        final IncAction r = new IncAction();
2371 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2372 >        final CFException ex = new CFException();
2373 >
2374 >        f.completeExceptionally(ex);
2375 >        checkCompletedWithWrappedCFException(h, ex);
2376 >        g.complete(v1);
2377 >
2378 >        assertEquals(0, r.invocationCount);
2379 >        checkCompletedNormally(g, v1);
2380 >        checkCompletedWithWrappedCFException(f, ex);
2381 >        checkCompletedWithWrappedCFException(h, ex);
2382 >        }
2383      }
2384  
2385 <    /**
2386 <     * thenCombineAsync result completes normally after normal
2387 <     * completion of sources
2388 <     */
2389 <    public void testThenCombineAsync() {
2390 <        CompletableFuture<Integer> f, g, h;
2385 >    public void testAcceptEither_exceptionalCompletion2() {
2386 >        for (ExecutionMode m : ExecutionMode.values())
2387 >        for (Integer v1 : new Integer[] { 1, null }) {
2388 >
2389 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2390 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2391 >        final IncAction r = new IncAction();
2392 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2393 >        final CFException ex = new CFException();
2394 >
2395 >        g.completeExceptionally(ex);
2396 >        checkCompletedWithWrappedCFException(h, ex);
2397 >        f.complete(v1);
2398 >
2399 >        assertEquals(0, r.invocationCount);
2400 >        checkCompletedNormally(f, v1);
2401 >        checkCompletedWithWrappedCFException(g, ex);
2402 >        checkCompletedWithWrappedCFException(h, ex);
2403 >        }
2404 >    }
2405  
2406 <        f = new CompletableFuture<Integer>();
2407 <        g = new CompletableFuture<Integer>();
2408 <        h = f.thenCombineAsync(g, subtract);
2409 <        f.complete(3);
2410 <        checkIncomplete(h);
2411 <        g.complete(1);
2412 <        checkCompletedNormally(h, 2);
2406 >    public void testAcceptEither_exceptionalCompletion3() {
2407 >        for (ExecutionMode m : ExecutionMode.values())
2408 >        for (Integer v1 : new Integer[] { 1, null }) {
2409 >
2410 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2411 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2412 >        final IncAction r = new IncAction();
2413 >        final CFException ex = new CFException();
2414 >
2415 >        g.completeExceptionally(ex);
2416 >        f.complete(v1);
2417 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2418  
2419 <        f = new CompletableFuture<Integer>();
2420 <        g = new CompletableFuture<Integer>();
2421 <        h = f.thenCombineAsync(g, subtract);
2422 <        g.complete(1);
2423 <        checkIncomplete(h);
2424 <        f.complete(3);
2425 <        checkCompletedNormally(h, 2);
2419 >        // unspecified behavior
2420 >        Integer v;
2421 >        try {
2422 >            assertNull(h.join());
2423 >            assertEquals(1, r.invocationCount);
2424 >            assertEquals(inc(v1), r.value);
2425 >        } catch (CompletionException ok) {
2426 >            checkCompletedWithWrappedCFException(h, ex);
2427 >            assertEquals(0, r.invocationCount);
2428 >        }
2429 >
2430 >        checkCompletedWithWrappedCFException(g, ex);
2431 >        checkCompletedNormally(f, v1);
2432 >        }
2433 >    }
2434 >
2435 >    public void testAcceptEither_exceptionalCompletion4() {
2436 >        for (ExecutionMode m : ExecutionMode.values())
2437 >        for (Integer v1 : new Integer[] { 1, null }) {
2438 >
2439 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2440 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2441 >        final IncAction r = new IncAction();
2442 >        final CFException ex = new CFException();
2443 >
2444 >        f.completeExceptionally(ex);
2445 >        g.complete(v1);
2446 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2447  
2448 <        f = new CompletableFuture<Integer>();
2449 <        g = new CompletableFuture<Integer>();
2450 <        g.complete(1);
2451 <        f.complete(3);
2452 <        h = f.thenCombineAsync(g, subtract);
2453 <        checkCompletedNormally(h, 2);
2448 >        // unspecified behavior
2449 >        Integer v;
2450 >        try {
2451 >            assertNull(h.join());
2452 >            assertEquals(1, r.invocationCount);
2453 >            assertEquals(inc(v1), r.value);
2454 >        } catch (CompletionException ok) {
2455 >            checkCompletedWithWrappedCFException(h, ex);
2456 >            assertEquals(0, r.invocationCount);
2457 >        }
2458 >
2459 >        checkCompletedWithWrappedCFException(f, ex);
2460 >        checkCompletedNormally(g, v1);
2461 >        }
2462      }
2463  
2464      /**
2465 <     * thenCombineAsync result completes exceptionally after exceptional
1383 <     * completion of either source
2465 >     * acceptEither result completes exceptionally if action does
2466       */
2467 <    public void testThenCombineAsync2() {
2468 <        CompletableFuture<Integer> f, g, h;
2467 >    public void testAcceptEither_actionFailed1() {
2468 >        for (ExecutionMode m : ExecutionMode.values())
2469 >        for (Integer v1 : new Integer[] { 1, null })
2470 >        for (Integer v2 : new Integer[] { 2, null }) {
2471 >
2472 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2473 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2474 >        final FailingConsumer r = new FailingConsumer();
2475 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2476  
2477 <        f = new CompletableFuture<Integer>();
1389 <        g = new CompletableFuture<Integer>();
1390 <        h = f.thenCombineAsync(g, subtract);
1391 <        f.completeExceptionally(new CFException());
1392 <        checkIncomplete(h);
1393 <        g.complete(1);
2477 >        f.complete(v1);
2478          checkCompletedWithWrappedCFException(h);
2479 +        g.complete(v2);
2480 +        checkCompletedNormally(f, v1);
2481 +        checkCompletedNormally(g, v2);
2482 +        }
2483 +    }
2484  
2485 <        f = new CompletableFuture<Integer>();
2486 <        g = new CompletableFuture<Integer>();
2487 <        h = f.thenCombineAsync(g, subtract);
2488 <        g.completeExceptionally(new CFException());
2489 <        checkIncomplete(h);
2490 <        f.complete(3);
2491 <        checkCompletedWithWrappedCFException(h);
2485 >    public void testAcceptEither_actionFailed2() {
2486 >        for (ExecutionMode m : ExecutionMode.values())
2487 >        for (Integer v1 : new Integer[] { 1, null })
2488 >        for (Integer v2 : new Integer[] { 2, null }) {
2489 >
2490 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2491 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2492 >        final FailingConsumer r = new FailingConsumer();
2493 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2494  
2495 <        f = new CompletableFuture<Integer>();
1405 <        g = new CompletableFuture<Integer>();
1406 <        g.completeExceptionally(new CFException());
1407 <        f.complete(3);
1408 <        h = f.thenCombineAsync(g, subtract);
2495 >        g.complete(v2);
2496          checkCompletedWithWrappedCFException(h);
2497 +        f.complete(v1);
2498 +        checkCompletedNormally(f, v1);
2499 +        checkCompletedNormally(g, v2);
2500 +        }
2501      }
2502  
2503      /**
2504 <     * thenCombineAsync result completes exceptionally if action does
1414 <     */
1415 <    public void testThenCombineAsync3() {
1416 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1417 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1418 <        FailingBiFunction r = new FailingBiFunction();
1419 <        CompletableFuture<Integer> g = f.thenCombineAsync(f2, r);
1420 <        f.complete(one);
1421 <        checkIncomplete(g);
1422 <        assertFalse(r.ran);
1423 <        f2.complete(two);
1424 <        checkCompletedWithWrappedCFException(g);
1425 <        assertTrue(r.ran);
1426 <    }
1427 <
1428 <    /**
1429 <     * thenCombineAsync result completes exceptionally if either source cancelled
2504 >     * acceptEither result completes exceptionally if either source cancelled
2505       */
2506 <    public void testThenCombineAsync4() {
2507 <        CompletableFuture<Integer> f, g, h;
2506 >    public void testAcceptEither_sourceCancelled1() {
2507 >        for (ExecutionMode m : ExecutionMode.values())
2508 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2509 >        for (Integer v1 : new Integer[] { 1, null }) {
2510 >
2511 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2512 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2513 >        final IncAction r = new IncAction();
2514 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2515  
2516 <        f = new CompletableFuture<Integer>();
1435 <        g = new CompletableFuture<Integer>();
1436 <        h = f.thenCombineAsync(g, subtract);
1437 <        assertTrue(f.cancel(true));
1438 <        checkIncomplete(h);
1439 <        g.complete(1);
2516 >        assertTrue(f.cancel(mayInterruptIfRunning));
2517          checkCompletedWithWrappedCancellationException(h);
2518 +        g.complete(v1);
2519  
2520 <        f = new CompletableFuture<Integer>();
2521 <        g = new CompletableFuture<Integer>();
2522 <        h = f.thenCombineAsync(g, subtract);
1445 <        assertTrue(g.cancel(true));
1446 <        checkIncomplete(h);
1447 <        f.complete(3);
2520 >        checkCancelled(f);
2521 >        assertEquals(0, r.invocationCount);
2522 >        checkCompletedNormally(g, v1);
2523          checkCompletedWithWrappedCancellationException(h);
2524 +        }
2525 +    }
2526  
2527 <        f = new CompletableFuture<Integer>();
2528 <        g = new CompletableFuture<Integer>();
2529 <        g.complete(3);
2530 <        assertTrue(f.cancel(true));
2531 <        h = f.thenCombineAsync(g, subtract);
2527 >    public void testAcceptEither_sourceCancelled2() {
2528 >        for (ExecutionMode m : ExecutionMode.values())
2529 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2530 >        for (Integer v1 : new Integer[] { 1, null }) {
2531 >
2532 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2533 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2534 >        final IncAction r = new IncAction();
2535 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2536 >
2537 >        assertTrue(g.cancel(mayInterruptIfRunning));
2538          checkCompletedWithWrappedCancellationException(h);
2539 +        f.complete(v1);
2540  
2541 <        f = new CompletableFuture<Integer>();
2542 <        g = new CompletableFuture<Integer>();
2543 <        f.complete(3);
1460 <        assertTrue(g.cancel(true));
1461 <        h = f.thenCombineAsync(g, subtract);
2541 >        checkCancelled(g);
2542 >        assertEquals(0, r.invocationCount);
2543 >        checkCompletedNormally(f, v1);
2544          checkCompletedWithWrappedCancellationException(h);
2545 +        }
2546      }
2547  
2548 <    /**
2549 <     * thenAcceptBothAsync result completes normally after normal
2550 <     * completion of sources
2551 <     */
2552 <    public void testThenAcceptBothAsync() {
2553 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2554 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2555 <        AddAction r = new AddAction();
2556 <        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r);
2557 <        f.complete(one);
2558 <        checkIncomplete(g);
2559 <        f2.complete(two);
1477 <        checkCompletedNormally(g, null);
1478 <        assertEquals(r.value, 3);
1479 <    }
2548 >    public void testAcceptEither_sourceCancelled3() {
2549 >        for (ExecutionMode m : ExecutionMode.values())
2550 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2551 >        for (Integer v1 : new Integer[] { 1, null }) {
2552 >
2553 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2554 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2555 >        final IncAction r = new IncAction();
2556 >
2557 >        assertTrue(g.cancel(mayInterruptIfRunning));
2558 >        f.complete(v1);
2559 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2560  
2561 <    /**
2562 <     * thenAcceptBothAsync result completes exceptionally after exceptional
2563 <     * completion of source
2564 <     */
2565 <    public void testThenAcceptBothAsync2() {
2566 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2567 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2568 <        AddAction r = new AddAction();
2569 <        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r);
2570 <        f.completeExceptionally(new CFException());
1491 <        f2.complete(two);
1492 <        checkCompletedWithWrappedCFException(g);
2561 >        // unspecified behavior
2562 >        Integer v;
2563 >        try {
2564 >            assertNull(h.join());
2565 >            assertEquals(1, r.invocationCount);
2566 >            assertEquals(inc(v1), r.value);
2567 >        } catch (CompletionException ok) {
2568 >            checkCompletedWithWrappedCancellationException(h);
2569 >            assertEquals(0, r.invocationCount);
2570 >        }
2571  
2572 <        r = new AddAction();
2573 <        f = new CompletableFuture<Integer>();
2574 <        f2 = new CompletableFuture<Integer>();
1497 <        g = f.thenAcceptBothAsync(f2, r);
1498 <        f.complete(one);
1499 <        f2.completeExceptionally(new CFException());
1500 <        checkCompletedWithWrappedCFException(g);
2572 >        checkCancelled(g);
2573 >        checkCompletedNormally(f, v1);
2574 >        }
2575      }
2576  
2577 <    /**
2578 <     * thenAcceptBothAsync result completes exceptionally if action does
2579 <     */
2580 <    public void testThenAcceptBothAsync3() {
2581 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2582 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2583 <        FailingBiConsumer r = new FailingBiConsumer();
2584 <        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r);
2585 <        f.complete(one);
2586 <        checkIncomplete(g);
2587 <        f2.complete(two);
2588 <        checkCompletedWithWrappedCFException(g);
1515 <    }
2577 >    public void testAcceptEither_sourceCancelled4() {
2578 >        for (ExecutionMode m : ExecutionMode.values())
2579 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2580 >        for (Integer v1 : new Integer[] { 1, null }) {
2581 >
2582 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2583 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2584 >        final IncAction r = new IncAction();
2585 >
2586 >        assertTrue(f.cancel(mayInterruptIfRunning));
2587 >        g.complete(v1);
2588 >        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2589  
2590 <    /**
2591 <     * thenAcceptBothAsync result completes exceptionally if either source cancelled
2592 <     */
2593 <    public void testThenAcceptBothAsync4() {
2594 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2595 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2596 <        AddAction r = new AddAction();
2597 <        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r);
2598 <        assertTrue(f.cancel(true));
2599 <        f2.complete(two);
1527 <        checkCompletedWithWrappedCancellationException(g);
2590 >        // unspecified behavior
2591 >        Integer v;
2592 >        try {
2593 >            assertNull(h.join());
2594 >            assertEquals(1, r.invocationCount);
2595 >            assertEquals(inc(v1), r.value);
2596 >        } catch (CompletionException ok) {
2597 >            checkCompletedWithWrappedCancellationException(h);
2598 >            assertEquals(0, r.invocationCount);
2599 >        }
2600  
2601 <        r = new AddAction();
2602 <        f = new CompletableFuture<Integer>();
2603 <        f2 = new CompletableFuture<Integer>();
1532 <        g = f.thenAcceptBothAsync(f2, r);
1533 <        f.complete(one);
1534 <        assertTrue(f2.cancel(true));
1535 <        checkCompletedWithWrappedCancellationException(g);
2601 >        checkCancelled(f);
2602 >        checkCompletedNormally(g, v1);
2603 >        }
2604      }
2605  
2606      /**
2607 <     * runAfterBothAsync result completes normally after normal
2608 <     * completion of sources
2607 >     * runAfterEither result completes normally after normal completion
2608 >     * of either source
2609       */
2610 <    public void testRunAfterBothAsync() {
2611 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2612 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2613 <        Noop r = new Noop();
2614 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r);
2615 <        f.complete(one);
2616 <        checkIncomplete(g);
2617 <        f2.complete(two);
2618 <        checkCompletedNormally(g, null);
2619 <        assertTrue(r.ran);
2610 >    public void testRunAfterEither_normalCompletion1() {
2611 >        for (ExecutionMode m : ExecutionMode.values())
2612 >        for (Integer v1 : new Integer[] { 1, null })
2613 >        for (Integer v2 : new Integer[] { 2, null }) {
2614 >
2615 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2616 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2617 >        final Noop r = new Noop();
2618 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2619 >
2620 >        f.complete(v1);
2621 >        checkCompletedNormally(h, null);
2622 >        assertEquals(1, r.invocationCount);
2623 >        g.complete(v2);
2624 >
2625 >        checkCompletedNormally(f, v1);
2626 >        checkCompletedNormally(g, v2);
2627 >        checkCompletedNormally(h, null);
2628 >        assertEquals(1, r.invocationCount);
2629 >        }
2630      }
2631  
2632 <    /**
2633 <     * runAfterBothAsync result completes exceptionally after exceptional
2634 <     * completion of source
2635 <     */
2636 <    public void testRunAfterBothAsync2() {
2637 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2638 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2639 <        Noop r = new Noop();
2640 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r);
2641 <        f.completeExceptionally(new CFException());
2642 <        f2.complete(two);
2643 <        checkCompletedWithWrappedCFException(g);
2644 <
2645 <        r = new Noop();
2646 <        f = new CompletableFuture<Integer>();
2647 <        f2 = new CompletableFuture<Integer>();
2648 <        g = f.runAfterBothAsync(f2, r);
2649 <        f.complete(one);
2650 <        f2.completeExceptionally(new CFException());
2651 <        checkCompletedWithWrappedCFException(g);
2632 >    public void testRunAfterEither_normalCompletion2() {
2633 >        for (ExecutionMode m : ExecutionMode.values())
2634 >        for (Integer v1 : new Integer[] { 1, null })
2635 >        for (Integer v2 : new Integer[] { 2, null }) {
2636 >
2637 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2638 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2639 >        final Noop r = new Noop();
2640 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2641 >
2642 >        g.complete(v2);
2643 >        checkCompletedNormally(h, null);
2644 >        assertEquals(1, r.invocationCount);
2645 >        f.complete(v1);
2646 >
2647 >        checkCompletedNormally(f, v1);
2648 >        checkCompletedNormally(g, v2);
2649 >        checkCompletedNormally(h, null);
2650 >        assertEquals(1, r.invocationCount);
2651 >        }
2652      }
2653 <
2654 <    /**
2655 <     * runAfterBothAsync result completes exceptionally if action does
2656 <     */
2657 <    public void testRunAfterBothAsync3() {
2658 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2659 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2660 <        FailingNoop r = new FailingNoop();
2661 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r);
2662 <        f.complete(one);
2663 <        checkIncomplete(g);
2664 <        f2.complete(two);
2665 <        checkCompletedWithWrappedCFException(g);
2653 >    public void testRunAfterEither_normalCompletion3() {
2654 >        for (ExecutionMode m : ExecutionMode.values())
2655 >        for (Integer v1 : new Integer[] { 1, null })
2656 >        for (Integer v2 : new Integer[] { 2, null }) {
2657 >
2658 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2659 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2660 >        final Noop r = new Noop();
2661 >
2662 >        f.complete(v1);
2663 >        g.complete(v2);
2664 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2665 >
2666 >        checkCompletedNormally(h, null);
2667 >        checkCompletedNormally(f, v1);
2668 >        checkCompletedNormally(g, v2);
2669 >        assertEquals(1, r.invocationCount);
2670 >        }
2671      }
2672  
2673      /**
2674 <     * runAfterBothAsync result completes exceptionally if either source cancelled
2674 >     * runAfterEither result completes exceptionally after exceptional
2675 >     * completion of either source
2676       */
2677 <    public void testRunAfterBothAsync4() {
2678 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2679 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2680 <        Noop r = new Noop();
2681 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r);
2682 <        assertTrue(f.cancel(true));
2683 <        f2.complete(two);
2684 <        checkCompletedWithWrappedCancellationException(g);
2677 >    public void testRunAfterEither_exceptionalCompletion1() {
2678 >        for (ExecutionMode m : ExecutionMode.values())
2679 >        for (Integer v1 : new Integer[] { 1, null }) {
2680 >
2681 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2682 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2683 >        final Noop r = new Noop();
2684 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2685 >        final CFException ex = new CFException();
2686 >
2687 >        f.completeExceptionally(ex);
2688 >        checkCompletedWithWrappedCFException(h, ex);
2689 >        g.complete(v1);
2690 >
2691 >        assertEquals(0, r.invocationCount);
2692 >        checkCompletedNormally(g, v1);
2693 >        checkCompletedWithWrappedCFException(f, ex);
2694 >        checkCompletedWithWrappedCFException(h, ex);
2695 >        }
2696 >    }
2697  
2698 <        r = new Noop();
2699 <        f = new CompletableFuture<Integer>();
2700 <        f2 = new CompletableFuture<Integer>();
2701 <        g = f.runAfterBothAsync(f2, r);
2702 <        f.complete(one);
2703 <        assertTrue(f2.cancel(true));
2704 <        checkCompletedWithWrappedCancellationException(g);
2698 >    public void testRunAfterEither_exceptionalCompletion2() {
2699 >        for (ExecutionMode m : ExecutionMode.values())
2700 >        for (Integer v1 : new Integer[] { 1, null }) {
2701 >
2702 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2703 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2704 >        final Noop r = new Noop();
2705 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2706 >        final CFException ex = new CFException();
2707 >
2708 >        g.completeExceptionally(ex);
2709 >        checkCompletedWithWrappedCFException(h, ex);
2710 >        f.complete(v1);
2711 >
2712 >        assertEquals(0, r.invocationCount);
2713 >        checkCompletedNormally(f, v1);
2714 >        checkCompletedWithWrappedCFException(g, ex);
2715 >        checkCompletedWithWrappedCFException(h, ex);
2716 >        }
2717      }
2718  
2719 <    /**
2720 <     * applyToEitherAsync result completes normally after normal
2721 <     * completion of sources
2722 <     */
2723 <    public void testApplyToEitherAsync() {
2724 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2725 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2726 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2727 <        f.complete(one);
2728 <        checkCompletedNormally(g, two);
2719 >    public void testRunAfterEither_exceptionalCompletion3() {
2720 >        for (ExecutionMode m : ExecutionMode.values())
2721 >        for (Integer v1 : new Integer[] { 1, null }) {
2722 >
2723 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2724 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2725 >        final Noop r = new Noop();
2726 >        final CFException ex = new CFException();
2727 >
2728 >        g.completeExceptionally(ex);
2729 >        f.complete(v1);
2730 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2731  
2732 <        f = new CompletableFuture<Integer>();
2733 <        f.complete(one);
2734 <        f2 = new CompletableFuture<Integer>();
2735 <        g = f.applyToEitherAsync(f2, inc);
2736 <        checkCompletedNormally(g, two);
2732 >        // unspecified behavior
2733 >        Integer v;
2734 >        try {
2735 >            assertNull(h.join());
2736 >            assertEquals(1, r.invocationCount);
2737 >        } catch (CompletionException ok) {
2738 >            checkCompletedWithWrappedCFException(h, ex);
2739 >            assertEquals(0, r.invocationCount);
2740 >        }
2741 >
2742 >        checkCompletedWithWrappedCFException(g, ex);
2743 >        checkCompletedNormally(f, v1);
2744 >        }
2745      }
2746  
2747 <    /**
2748 <     * applyToEitherAsync result completes exceptionally after exceptional
2749 <     * completion of source
2750 <     */
2751 <    public void testApplyToEitherAsync2() {
2752 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2753 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2754 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2755 <        f.completeExceptionally(new CFException());
2756 <        checkCompletedWithWrappedCFException(g);
2747 >    public void testRunAfterEither_exceptionalCompletion4() {
2748 >        for (ExecutionMode m : ExecutionMode.values())
2749 >        for (Integer v1 : new Integer[] { 1, null }) {
2750 >
2751 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2752 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2753 >        final Noop r = new Noop();
2754 >        final CFException ex = new CFException();
2755 >
2756 >        f.completeExceptionally(ex);
2757 >        g.complete(v1);
2758 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2759  
2760 <        f = new CompletableFuture<Integer>();
2761 <        f2 = new CompletableFuture<Integer>();
2762 <        f2.completeExceptionally(new CFException());
2763 <        g = f.applyToEitherAsync(f2, inc);
2764 <        f.complete(one);
2765 <        checkCompletedWithWrappedCFException(g);
2766 <    }
2760 >        // unspecified behavior
2761 >        Integer v;
2762 >        try {
2763 >            assertNull(h.join());
2764 >            assertEquals(1, r.invocationCount);
2765 >        } catch (CompletionException ok) {
2766 >            checkCompletedWithWrappedCFException(h, ex);
2767 >            assertEquals(0, r.invocationCount);
2768 >        }
2769  
2770 <    /**
2771 <     * applyToEitherAsync result completes exceptionally if action does
2772 <     */
1651 <    public void testApplyToEitherAsync3() {
1652 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1653 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1654 <        FailingFunction r = new FailingFunction();
1655 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, r);
1656 <        f.complete(one);
1657 <        checkCompletedWithWrappedCFException(g);
2770 >        checkCompletedWithWrappedCFException(f, ex);
2771 >        checkCompletedNormally(g, v1);
2772 >        }
2773      }
2774  
2775      /**
2776 <     * applyToEitherAsync result completes exceptionally if either source cancelled
2776 >     * runAfterEither result completes exceptionally if action does
2777       */
2778 <    public void testApplyToEitherAsync4() {
2779 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2780 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2781 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc);
2782 <        assertTrue(f.cancel(true));
2783 <        checkCompletedWithWrappedCancellationException(g);
2778 >    public void testRunAfterEither_actionFailed1() {
2779 >        for (ExecutionMode m : ExecutionMode.values())
2780 >        for (Integer v1 : new Integer[] { 1, null })
2781 >        for (Integer v2 : new Integer[] { 2, null }) {
2782 >
2783 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2784 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2785 >        final FailingNoop r = new FailingNoop();
2786 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2787  
2788 <        f = new CompletableFuture<Integer>();
2789 <        f2 = new CompletableFuture<Integer>();
2790 <        assertTrue(f2.cancel(true));
2791 <        g = f.applyToEitherAsync(f2, inc);
2792 <        checkCompletedWithWrappedCancellationException(g);
2788 >        f.complete(v1);
2789 >        checkCompletedWithWrappedCFException(h);
2790 >        g.complete(v2);
2791 >        checkCompletedNormally(f, v1);
2792 >        checkCompletedNormally(g, v2);
2793 >        }
2794      }
2795  
2796 <    /**
2797 <     * acceptEitherAsync result completes normally after normal
2798 <     * completion of sources
2799 <     */
2800 <    public void testAcceptEitherAsync() {
2801 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2802 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2803 <        IncAction r = new IncAction();
2804 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
1686 <        f.complete(one);
1687 <        checkCompletedNormally(g, null);
1688 <        assertEquals(r.value, 2);
2796 >    public void testRunAfterEither_actionFailed2() {
2797 >        for (ExecutionMode m : ExecutionMode.values())
2798 >        for (Integer v1 : new Integer[] { 1, null })
2799 >        for (Integer v2 : new Integer[] { 2, null }) {
2800 >
2801 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2802 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2803 >        final FailingNoop r = new FailingNoop();
2804 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2805  
2806 <        r = new IncAction();
2807 <        f = new CompletableFuture<Integer>();
2808 <        f.complete(one);
2809 <        f2 = new CompletableFuture<Integer>();
2810 <        g = f.acceptEitherAsync(f2, r);
2811 <        checkCompletedNormally(g, null);
1696 <        assertEquals(r.value, 2);
2806 >        g.complete(v2);
2807 >        checkCompletedWithWrappedCFException(h);
2808 >        f.complete(v1);
2809 >        checkCompletedNormally(f, v1);
2810 >        checkCompletedNormally(g, v2);
2811 >        }
2812      }
2813  
2814      /**
2815 <     * acceptEitherAsync result completes exceptionally after exceptional
1701 <     * completion of source
2815 >     * runAfterEither result completes exceptionally if either source cancelled
2816       */
2817 <    public void testAcceptEitherAsync2() {
2818 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2819 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2820 <        IncAction r = new IncAction();
2821 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
2822 <        f.completeExceptionally(new CFException());
2823 <        checkCompletedWithWrappedCFException(g);
2817 >    public void testRunAfterEither_sourceCancelled1() {
2818 >        for (ExecutionMode m : ExecutionMode.values())
2819 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2820 >        for (Integer v1 : new Integer[] { 1, null }) {
2821 >
2822 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2823 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2824 >        final Noop r = new Noop();
2825 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2826  
2827 <        r = new IncAction();
2828 <        f = new CompletableFuture<Integer>();
2829 <        f2 = new CompletableFuture<Integer>();
1714 <        f2.completeExceptionally(new CFException());
1715 <        g = f.acceptEitherAsync(f2, r);
1716 <        f.complete(one);
1717 <        checkCompletedWithWrappedCFException(g);
1718 <    }
2827 >        assertTrue(f.cancel(mayInterruptIfRunning));
2828 >        checkCompletedWithWrappedCancellationException(h);
2829 >        g.complete(v1);
2830  
2831 <    /**
2832 <     * acceptEitherAsync result completes exceptionally if action does
2833 <     */
2834 <    public void testAcceptEitherAsync3() {
2835 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1725 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1726 <        FailingConsumer r = new FailingConsumer();
1727 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
1728 <        f.complete(one);
1729 <        checkCompletedWithWrappedCFException(g);
2831 >        checkCancelled(f);
2832 >        assertEquals(0, r.invocationCount);
2833 >        checkCompletedNormally(g, v1);
2834 >        checkCompletedWithWrappedCancellationException(h);
2835 >        }
2836      }
2837  
2838 <    /**
2839 <     * acceptEitherAsync result completes exceptionally if either
2840 <     * source cancelled
2841 <     */
2842 <    public void testAcceptEitherAsync4() {
2843 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2844 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2845 <        IncAction r = new IncAction();
2846 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r);
1741 <        assertTrue(f.cancel(true));
1742 <        checkCompletedWithWrappedCancellationException(g);
2838 >    public void testRunAfterEither_sourceCancelled2() {
2839 >        for (ExecutionMode m : ExecutionMode.values())
2840 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2841 >        for (Integer v1 : new Integer[] { 1, null }) {
2842 >
2843 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2844 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2845 >        final Noop r = new Noop();
2846 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2847  
2848 <        r = new IncAction();
2849 <        f = new CompletableFuture<Integer>();
2850 <        f2 = new CompletableFuture<Integer>();
2851 <        assertTrue(f2.cancel(true));
2852 <        g = f.acceptEitherAsync(f2, r);
2853 <        checkCompletedWithWrappedCancellationException(g);
2848 >        assertTrue(g.cancel(mayInterruptIfRunning));
2849 >        checkCompletedWithWrappedCancellationException(h);
2850 >        f.complete(v1);
2851 >
2852 >        checkCancelled(g);
2853 >        assertEquals(0, r.invocationCount);
2854 >        checkCompletedNormally(f, v1);
2855 >        checkCompletedWithWrappedCancellationException(h);
2856 >        }
2857      }
2858  
2859 <    /**
2860 <     * runAfterEitherAsync result completes normally after normal
2861 <     * completion of sources
2862 <     */
2863 <    public void testRunAfterEitherAsync() {
2864 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2865 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2866 <        Noop r = new Noop();
2867 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2868 <        f.complete(one);
2869 <        checkCompletedNormally(g, null);
2870 <        assertTrue(r.ran);
2859 >    public void testRunAfterEither_sourceCancelled3() {
2860 >        for (ExecutionMode m : ExecutionMode.values())
2861 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2862 >        for (Integer v1 : new Integer[] { 1, null }) {
2863 >
2864 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2865 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2866 >        final Noop r = new Noop();
2867 >
2868 >        assertTrue(g.cancel(mayInterruptIfRunning));
2869 >        f.complete(v1);
2870 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2871  
2872 <        r = new Noop();
2873 <        f = new CompletableFuture<Integer>();
2874 <        f.complete(one);
2875 <        f2 = new CompletableFuture<Integer>();
2876 <        g = f.runAfterEitherAsync(f2, r);
2877 <        checkCompletedNormally(g, null);
2878 <        assertTrue(r.ran);
2872 >        // unspecified behavior
2873 >        Integer v;
2874 >        try {
2875 >            assertNull(h.join());
2876 >            assertEquals(1, r.invocationCount);
2877 >        } catch (CompletionException ok) {
2878 >            checkCompletedWithWrappedCancellationException(h);
2879 >            assertEquals(0, r.invocationCount);
2880 >        }
2881 >
2882 >        checkCancelled(g);
2883 >        checkCompletedNormally(f, v1);
2884 >        }
2885      }
2886  
2887 <    /**
2888 <     * runAfterEitherAsync result completes exceptionally after exceptional
2889 <     * completion of source
2890 <     */
2891 <    public void testRunAfterEitherAsync2() {
2892 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2893 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2894 <        Noop r = new Noop();
2895 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2896 <        f.completeExceptionally(new CFException());
2897 <        checkCompletedWithWrappedCFException(g);
2887 >    public void testRunAfterEither_sourceCancelled4() {
2888 >        for (ExecutionMode m : ExecutionMode.values())
2889 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2890 >        for (Integer v1 : new Integer[] { 1, null }) {
2891 >
2892 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2893 >        final CompletableFuture<Integer> g = new CompletableFuture<>();
2894 >        final Noop r = new Noop();
2895 >
2896 >        assertTrue(f.cancel(mayInterruptIfRunning));
2897 >        g.complete(v1);
2898 >        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2899  
2900 <        r = new Noop();
2901 <        f = new CompletableFuture<Integer>();
2902 <        f2 = new CompletableFuture<Integer>();
2903 <        f2.completeExceptionally(new CFException());
2904 <        g = f.runAfterEitherAsync(f2, r);
2905 <        f.complete(one);
2906 <        checkCompletedWithWrappedCFException(g);
2907 <    }
2900 >        // unspecified behavior
2901 >        Integer v;
2902 >        try {
2903 >            assertNull(h.join());
2904 >            assertEquals(1, r.invocationCount);
2905 >        } catch (CompletionException ok) {
2906 >            checkCompletedWithWrappedCancellationException(h);
2907 >            assertEquals(0, r.invocationCount);
2908 >        }
2909  
2910 <    /**
2911 <     * runAfterEitherAsync result completes exceptionally if action does
2912 <     */
1798 <    public void testRunAfterEitherAsync3() {
1799 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
1800 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
1801 <        FailingNoop r = new FailingNoop();
1802 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
1803 <        f.complete(one);
1804 <        checkCompletedWithWrappedCFException(g);
2910 >        checkCancelled(f);
2911 >        checkCompletedNormally(g, v1);
2912 >        }
2913      }
2914  
2915      /**
2916 <     * runAfterEitherAsync result completes exceptionally if either
1809 <     * source cancelled
2916 >     * thenCompose result completes normally after normal completion of source
2917       */
2918 <    public void testRunAfterEitherAsync4() {
2919 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2920 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2921 <        Noop r = new Noop();
2922 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r);
2923 <        assertTrue(f.cancel(true));
2924 <        checkCompletedWithWrappedCancellationException(g);
2918 >    public void testThenCompose_normalCompletion1() {
2919 >        for (ExecutionMode m : ExecutionMode.values())
2920 >        for (Integer v1 : new Integer[] { 1, null }) {
2921 >
2922 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2923 >        final CompletableFutureInc r = new CompletableFutureInc();
2924 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2925 >        f.complete(v1);
2926 >        checkCompletedNormally(g, inc(v1));
2927 >        checkCompletedNormally(f, v1);
2928 >        assertEquals(1, r.invocationCount);
2929 >        }
2930 >    }
2931  
2932 <        r = new Noop();
2933 <        f = new CompletableFuture<Integer>();
2934 <        f2 = new CompletableFuture<Integer>();
2935 <        assertTrue(f2.cancel(true));
2936 <        g = f.runAfterEitherAsync(f2, r);
2937 <        checkCompletedWithWrappedCancellationException(g);
2932 >    public void testThenCompose_normalCompletion2() {
2933 >        for (ExecutionMode m : ExecutionMode.values())
2934 >        for (Integer v1 : new Integer[] { 1, null }) {
2935 >
2936 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2937 >        final CompletableFutureInc r = new CompletableFutureInc();
2938 >        f.complete(v1);
2939 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2940 >        checkCompletedNormally(g, inc(v1));
2941 >        checkCompletedNormally(f, v1);
2942 >        assertEquals(1, r.invocationCount);
2943 >        }
2944      }
2945  
2946      /**
2947 <     * thenComposeAsync result completes normally after normal
2947 >     * thenCompose result completes exceptionally after exceptional
2948       * completion of source
2949       */
2950 <    public void testThenComposeAsync() {
2951 <        CompletableFuture<Integer> f, g;
1833 <        CompletableFutureInc r;
2950 >    public void testThenCompose_exceptionalCompletion1() {
2951 >        for (ExecutionMode m : ExecutionMode.values()) {
2952  
2953 <        f = new CompletableFuture<Integer>();
2954 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2955 <        f.complete(one);
2956 <        checkCompletedNormally(g, two);
2957 <
2958 <        f = new CompletableFuture<Integer>();
2959 <        f.complete(one);
2960 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
1843 <        checkCompletedNormally(g, two);
2953 >        final CFException ex = new CFException();
2954 >        final CompletableFutureInc r = new CompletableFutureInc();
2955 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2956 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2957 >        f.completeExceptionally(ex);
2958 >        checkCompletedWithWrappedCFException(g, ex);
2959 >        checkCompletedWithWrappedCFException(f, ex);
2960 >        }
2961      }
2962  
2963 <    /**
2964 <     * thenComposeAsync result completes exceptionally after
1848 <     * exceptional completion of source
1849 <     */
1850 <    public void testThenComposeAsync2() {
1851 <        CompletableFuture<Integer> f, g;
1852 <        CompletableFutureInc r;
2963 >    public void testThenCompose_exceptionalCompletion2() {
2964 >        for (ExecutionMode m : ExecutionMode.values()) {
2965  
2966 <        f = new CompletableFuture<Integer>();
2967 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2968 <        f.completeExceptionally(new CFException());
2969 <        checkCompletedWithWrappedCFException(g);
2970 <        assertFalse(r.ran);
2971 <
2972 <        f = new CompletableFuture<Integer>();
2973 <        f.completeExceptionally(new CFException());
1862 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
1863 <        checkCompletedWithWrappedCFException(g);
1864 <        assertFalse(r.ran);
2966 >        final CFException ex = new CFException();
2967 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2968 >        f.completeExceptionally(ex);
2969 >        final CompletableFutureInc r = new CompletableFutureInc();
2970 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2971 >        checkCompletedWithWrappedCFException(g, ex);
2972 >        checkCompletedWithWrappedCFException(f, ex);
2973 >        }
2974      }
2975  
2976      /**
2977 <     * thenComposeAsync result completes exceptionally if action does
2977 >     * thenCompose result completes exceptionally if action does
2978       */
2979 <    public void testThenComposeAsync3() {
2980 <        CompletableFuture<Integer> f, g;
2981 <        FailingCompletableFutureFunction r;
2982 <
2983 <        f = new CompletableFuture<Integer>();
2984 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
2985 <        f.complete(one);
2979 >    public void testThenCompose_actionFailed1() {
2980 >        for (ExecutionMode m : ExecutionMode.values())
2981 >        for (Integer v1 : new Integer[] { 1, null }) {
2982 >
2983 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2984 >        final FailingCompletableFutureFunction r
2985 >            = new FailingCompletableFutureFunction();
2986 >        final CompletableFuture<Integer> g = f.thenCompose(r);
2987 >        f.complete(v1);
2988          checkCompletedWithWrappedCFException(g);
2989 +        checkCompletedNormally(f, v1);
2990 +        }
2991 +    }
2992  
2993 <        f = new CompletableFuture<Integer>();
2994 <        f.complete(one);
2995 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
2993 >    public void testThenCompose_actionFailed2() {
2994 >        for (ExecutionMode m : ExecutionMode.values())
2995 >        for (Integer v1 : new Integer[] { 1, null }) {
2996 >
2997 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2998 >        f.complete(v1);
2999 >        final FailingCompletableFutureFunction r
3000 >            = new FailingCompletableFutureFunction();
3001 >        final CompletableFuture<Integer> g = f.thenCompose(r);
3002          checkCompletedWithWrappedCFException(g);
3003 +        checkCompletedNormally(f, v1);
3004 +        }
3005      }
3006  
3007      /**
3008 <     * thenComposeAsync result completes exceptionally if source cancelled
3008 >     * thenCompose result completes exceptionally if source cancelled
3009       */
3010 <    public void testThenComposeAsync4() {
3011 <        CompletableFuture<Integer> f, g;
3012 <        CompletableFutureInc r;
3013 <
3014 <        f = new CompletableFuture<Integer>();
3015 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3016 <        assertTrue(f.cancel(true));
3010 >    public void testThenCompose_sourceCancelled1() {
3011 >        for (ExecutionMode m : ExecutionMode.values())
3012 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
3013 >
3014 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
3015 >        final CompletableFutureInc r = new CompletableFutureInc();
3016 >        final CompletableFuture<Integer> g = f.thenCompose(r);
3017 >        assertTrue(f.cancel(mayInterruptIfRunning));
3018          checkCompletedWithWrappedCancellationException(g);
3019 +        checkCancelled(f);
3020 +        }
3021 +    }
3022  
3023 <        f = new CompletableFuture<Integer>();
3024 <        assertTrue(f.cancel(true));
3025 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3023 >    public void testThenCompose_sourceCancelled2() {
3024 >        for (ExecutionMode m : ExecutionMode.values())
3025 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
3026 >
3027 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
3028 >        assertTrue(f.cancel(mayInterruptIfRunning));
3029 >        final CompletableFutureInc r = new CompletableFutureInc();
3030 >        final CompletableFuture<Integer> g = f.thenCompose(r);
3031          checkCompletedWithWrappedCancellationException(g);
3032 +        checkCancelled(f);
3033 +        }
3034      }
3035  
3036 <
1904 <    // async with explicit executors
3036 >    // asyncs
3037  
3038      /**
3039       * thenRunAsync result completes normally after normal completion of source
3040       */
3041 <    public void testThenRunAsyncE() {
3042 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3041 >    public void testThenRunAsync() {
3042 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3043          Noop r = new Noop();
3044 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3044 >        CompletableFuture<Void> g = f.thenRunAsync(r);
3045          f.complete(null);
3046          checkCompletedNormally(g, null);
3047  
3048          // reordered version
3049 <        f = new CompletableFuture<Integer>();
3049 >        f = new CompletableFuture<>();
3050          f.complete(null);
3051          r = new Noop();
3052 <        g = f.thenRunAsync(r, new ThreadExecutor());
3052 >        g = f.thenRunAsync(r);
3053          checkCompletedNormally(g, null);
3054      }
3055  
# Line 1925 | Line 3057 | public class CompletableFutureTest exten
3057       * thenRunAsync result completes exceptionally after exceptional
3058       * completion of source
3059       */
3060 <    public void testThenRunAsync2E() {
3061 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3060 >    public void testThenRunAsync2() {
3061 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3062          Noop r = new Noop();
3063 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3063 >        CompletableFuture<Void> g = f.thenRunAsync(r);
3064          f.completeExceptionally(new CFException());
3065          try {
3066              g.join();
3067              shouldThrow();
3068 <        } catch (Exception ok) {
1937 <        }
3068 >        } catch (CompletionException success) {}
3069          checkCompletedWithWrappedCFException(g);
3070      }
3071  
3072      /**
3073       * thenRunAsync result completes exceptionally if action does
3074       */
3075 <    public void testThenRunAsync3E() {
3076 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3075 >    public void testThenRunAsync3() {
3076 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3077          FailingNoop r = new FailingNoop();
3078 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3078 >        CompletableFuture<Void> g = f.thenRunAsync(r);
3079          f.complete(null);
3080          checkCompletedWithWrappedCFException(g);
3081      }
# Line 1952 | Line 3083 | public class CompletableFutureTest exten
3083      /**
3084       * thenRunAsync result completes exceptionally if source cancelled
3085       */
3086 <    public void testThenRunAsync4E() {
3087 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3086 >    public void testThenRunAsync4() {
3087 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3088          Noop r = new Noop();
3089 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3089 >        CompletableFuture<Void> g = f.thenRunAsync(r);
3090          assertTrue(f.cancel(true));
3091          checkCompletedWithWrappedCancellationException(g);
3092      }
# Line 1963 | Line 3094 | public class CompletableFutureTest exten
3094      /**
3095       * thenApplyAsync result completes normally after normal completion of source
3096       */
3097 <    public void testThenApplyAsyncE() {
3098 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3099 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3097 >    public void testThenApplyAsync() {
3098 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3099 >        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
3100          f.complete(one);
3101          checkCompletedNormally(g, two);
3102      }
# Line 1974 | Line 3105 | public class CompletableFutureTest exten
3105       * thenApplyAsync result completes exceptionally after exceptional
3106       * completion of source
3107       */
3108 <    public void testThenApplyAsync2E() {
3109 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3110 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3108 >    public void testThenApplyAsync2() {
3109 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3110 >        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
3111          f.completeExceptionally(new CFException());
3112          checkCompletedWithWrappedCFException(g);
3113      }
# Line 1984 | Line 3115 | public class CompletableFutureTest exten
3115      /**
3116       * thenApplyAsync result completes exceptionally if action does
3117       */
3118 <    public void testThenApplyAsync3E() {
3119 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3118 >    public void testThenApplyAsync3() {
3119 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3120          FailingFunction r = new FailingFunction();
3121 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
3121 >        CompletableFuture<Integer> g = f.thenApplyAsync(r);
3122          f.complete(null);
3123          checkCompletedWithWrappedCFException(g);
3124      }
# Line 1995 | Line 3126 | public class CompletableFutureTest exten
3126      /**
3127       * thenApplyAsync result completes exceptionally if source cancelled
3128       */
3129 <    public void testThenApplyAsync4E() {
3130 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3131 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3129 >    public void testThenApplyAsync4() {
3130 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3131 >        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
3132          assertTrue(f.cancel(true));
3133          checkCompletedWithWrappedCancellationException(g);
3134      }
# Line 2006 | Line 3137 | public class CompletableFutureTest exten
3137       * thenAcceptAsync result completes normally after normal
3138       * completion of source
3139       */
3140 <    public void testThenAcceptAsyncE() {
3141 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3140 >    public void testThenAcceptAsync() {
3141 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3142          IncAction r = new IncAction();
3143 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3143 >        CompletableFuture<Void> g = f.thenAcceptAsync(r);
3144          f.complete(one);
3145          checkCompletedNormally(g, null);
3146 <        assertEquals(r.value, 2);
3146 >        assertEquals(r.value, (Integer) 2);
3147      }
3148  
3149      /**
3150       * thenAcceptAsync result completes exceptionally after exceptional
3151       * completion of source
3152       */
3153 <    public void testThenAcceptAsync2E() {
3154 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3153 >    public void testThenAcceptAsync2() {
3154 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3155          IncAction r = new IncAction();
3156 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3156 >        CompletableFuture<Void> g = f.thenAcceptAsync(r);
3157          f.completeExceptionally(new CFException());
3158          checkCompletedWithWrappedCFException(g);
3159      }
# Line 2030 | Line 3161 | public class CompletableFutureTest exten
3161      /**
3162       * thenAcceptAsync result completes exceptionally if action does
3163       */
3164 <    public void testThenAcceptAsync3E() {
3165 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3164 >    public void testThenAcceptAsync3() {
3165 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3166          FailingConsumer r = new FailingConsumer();
3167 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3167 >        CompletableFuture<Void> g = f.thenAcceptAsync(r);
3168          f.complete(null);
3169          checkCompletedWithWrappedCFException(g);
3170      }
# Line 2041 | Line 3172 | public class CompletableFutureTest exten
3172      /**
3173       * thenAcceptAsync result completes exceptionally if source cancelled
3174       */
3175 <    public void testThenAcceptAsync4E() {
3176 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3175 >    public void testThenAcceptAsync4() {
3176 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3177          IncAction r = new IncAction();
3178 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3178 >        CompletableFuture<Void> g = f.thenAcceptAsync(r);
3179          assertTrue(f.cancel(true));
3180          checkCompletedWithWrappedCancellationException(g);
3181      }
3182  
3183 <    /**
2053 <     * thenCombineAsync result completes normally after normal
2054 <     * completion of sources
2055 <     */
2056 <    public void testThenCombineAsyncE() {
2057 <        CompletableFuture<Integer> f, g, h;
2058 <        ThreadExecutor e = new ThreadExecutor();
2059 <        int count = 0;
2060 <
2061 <        f = new CompletableFuture<Integer>();
2062 <        g = new CompletableFuture<Integer>();
2063 <        h = f.thenCombineAsync(g, subtract, e);
2064 <        f.complete(3);
2065 <        checkIncomplete(h);
2066 <        g.complete(1);
2067 <        checkCompletedNormally(h, 2);
2068 <        assertEquals(++count, e.count.get());
2069 <
2070 <        f = new CompletableFuture<Integer>();
2071 <        g = new CompletableFuture<Integer>();
2072 <        h = f.thenCombineAsync(g, subtract, e);
2073 <        g.complete(1);
2074 <        checkIncomplete(h);
2075 <        f.complete(3);
2076 <        checkCompletedNormally(h, 2);
2077 <        assertEquals(++count, e.count.get());
2078 <
2079 <        f = new CompletableFuture<Integer>();
2080 <        g = new CompletableFuture<Integer>();
2081 <        g.complete(1);
2082 <        f.complete(3);
2083 <        h = f.thenCombineAsync(g, subtract, e);
2084 <        checkCompletedNormally(h, 2);
2085 <        assertEquals(++count, e.count.get());
2086 <    }
2087 <
2088 <    /**
2089 <     * thenCombineAsync result completes exceptionally after exceptional
2090 <     * completion of either source
2091 <     */
2092 <    public void testThenCombineAsync2E() {
2093 <        CompletableFuture<Integer> f, g, h;
2094 <        ThreadExecutor e = new ThreadExecutor();
2095 <        int count = 0;
2096 <
2097 <        f = new CompletableFuture<Integer>();
2098 <        g = new CompletableFuture<Integer>();
2099 <        h = f.thenCombineAsync(g, subtract, e);
2100 <        f.completeExceptionally(new CFException());
2101 <        checkIncomplete(h);
2102 <        g.complete(1);
2103 <        checkCompletedWithWrappedCFException(h);
2104 <
2105 <        f = new CompletableFuture<Integer>();
2106 <        g = new CompletableFuture<Integer>();
2107 <        h = f.thenCombineAsync(g, subtract, e);
2108 <        g.completeExceptionally(new CFException());
2109 <        checkIncomplete(h);
2110 <        f.complete(3);
2111 <        checkCompletedWithWrappedCFException(h);
2112 <
2113 <        f = new CompletableFuture<Integer>();
2114 <        g = new CompletableFuture<Integer>();
2115 <        g.completeExceptionally(new CFException());
2116 <        h = f.thenCombineAsync(g, subtract, e);
2117 <        checkIncomplete(h);
2118 <        f.complete(3);
2119 <        checkCompletedWithWrappedCFException(h);
2120 <
2121 <        assertEquals(0, e.count.get());
2122 <    }
2123 <
2124 <    /**
2125 <     * thenCombineAsync result completes exceptionally if action does
2126 <     */
2127 <    public void testThenCombineAsync3E() {
2128 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2129 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2130 <        FailingBiFunction r = new FailingBiFunction();
2131 <        CompletableFuture<Integer> g = f.thenCombineAsync(f2, r, new ThreadExecutor());
2132 <        f.complete(one);
2133 <        checkIncomplete(g);
2134 <        assertFalse(r.ran);
2135 <        f2.complete(two);
2136 <        checkCompletedWithWrappedCFException(g);
2137 <        assertTrue(r.ran);
2138 <    }
2139 <
2140 <    /**
2141 <     * thenCombineAsync result completes exceptionally if either source cancelled
2142 <     */
2143 <    public void testThenCombineAsync4E() {
2144 <        CompletableFuture<Integer> f, g, h;
2145 <        ThreadExecutor e = new ThreadExecutor();
2146 <
2147 <        f = new CompletableFuture<Integer>();
2148 <        g = new CompletableFuture<Integer>();
2149 <        h = f.thenCombineAsync(g, subtract, e);
2150 <        assertTrue(f.cancel(true));
2151 <        checkIncomplete(h);
2152 <        g.complete(1);
2153 <        checkCompletedWithWrappedCancellationException(h);
2154 <
2155 <        f = new CompletableFuture<Integer>();
2156 <        g = new CompletableFuture<Integer>();
2157 <        h = f.thenCombineAsync(g, subtract, e);
2158 <        assertTrue(g.cancel(true));
2159 <        checkIncomplete(h);
2160 <        f.complete(3);
2161 <        checkCompletedWithWrappedCancellationException(h);
2162 <
2163 <        f = new CompletableFuture<Integer>();
2164 <        g = new CompletableFuture<Integer>();
2165 <        assertTrue(g.cancel(true));
2166 <        h = f.thenCombineAsync(g, subtract, e);
2167 <        checkIncomplete(h);
2168 <        f.complete(3);
2169 <        checkCompletedWithWrappedCancellationException(h);
2170 <
2171 <        f = new CompletableFuture<Integer>();
2172 <        g = new CompletableFuture<Integer>();
2173 <        assertTrue(f.cancel(true));
2174 <        assertTrue(g.cancel(true));
2175 <        h = f.thenCombineAsync(g, subtract, e);
2176 <        checkCompletedWithWrappedCancellationException(h);
2177 <
2178 <        assertEquals(0, e.count.get());
2179 <    }
3183 >    // async with explicit executors
3184  
3185      /**
3186 <     * thenAcceptBothAsync result completes normally after normal
2183 <     * completion of sources
3186 >     * thenRunAsync result completes normally after normal completion of source
3187       */
3188 <    public void testThenAcceptBothAsyncE() {
3189 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3190 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3191 <        AddAction r = new AddAction();
3192 <        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r, new ThreadExecutor());
2190 <        f.complete(one);
2191 <        checkIncomplete(g);
2192 <        f2.complete(two);
3188 >    public void testThenRunAsyncE() {
3189 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3190 >        Noop r = new Noop();
3191 >        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3192 >        f.complete(null);
3193          checkCompletedNormally(g, null);
2194        assertEquals(r.value, 3);
2195    }
2196
2197    /**
2198     * thenAcceptBothAsync result completes exceptionally after exceptional
2199     * completion of source
2200     */
2201    public void testThenAcceptBothAsync2E() {
2202        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2203        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2204        AddAction r = new AddAction();
2205        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r, new ThreadExecutor());
2206        f.completeExceptionally(new CFException());
2207        f2.complete(two);
2208        checkCompletedWithWrappedCFException(g);
2209
2210        r = new AddAction();
2211        f = new CompletableFuture<Integer>();
2212        f2 = new CompletableFuture<Integer>();
2213        g = f.thenAcceptBothAsync(f2, r, new ThreadExecutor());
2214        f.complete(one);
2215        f2.completeExceptionally(new CFException());
2216        checkCompletedWithWrappedCFException(g);
2217    }
2218
2219    /**
2220     * thenAcceptBothAsync result completes exceptionally if action does
2221     */
2222    public void testThenAcceptBothAsync3E() {
2223        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2224        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2225        FailingBiConsumer r = new FailingBiConsumer();
2226        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r, new ThreadExecutor());
2227        f.complete(one);
2228        checkIncomplete(g);
2229        f2.complete(two);
2230        checkCompletedWithWrappedCFException(g);
2231    }
2232
2233    /**
2234     * thenAcceptBothAsync result completes exceptionally if either source cancelled
2235     */
2236    public void testThenAcceptBothAsync4E() {
2237        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2238        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2239        AddAction r = new AddAction();
2240        CompletableFuture<Void> g = f.thenAcceptBothAsync(f2, r, new ThreadExecutor());
2241        assertTrue(f.cancel(true));
2242        f2.complete(two);
2243        checkCompletedWithWrappedCancellationException(g);
2244
2245        r = new AddAction();
2246        f = new CompletableFuture<Integer>();
2247        f2 = new CompletableFuture<Integer>();
2248        g = f.thenAcceptBothAsync(f2, r, new ThreadExecutor());
2249        f.complete(one);
2250        assertTrue(f2.cancel(true));
2251        checkCompletedWithWrappedCancellationException(g);
2252    }
3194  
3195 <    /**
3196 <     * runAfterBothAsync result completes normally after normal
3197 <     * completion of sources
3198 <     */
3199 <    public void testRunAfterBothAsyncE() {
2259 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2260 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2261 <        Noop r = new Noop();
2262 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r, new ThreadExecutor());
2263 <        f.complete(one);
2264 <        checkIncomplete(g);
2265 <        f2.complete(two);
3195 >        // reordered version
3196 >        f = new CompletableFuture<>();
3197 >        f.complete(null);
3198 >        r = new Noop();
3199 >        g = f.thenRunAsync(r, new ThreadExecutor());
3200          checkCompletedNormally(g, null);
2267        assertTrue(r.ran);
3201      }
3202  
3203      /**
3204 <     * runAfterBothAsync result completes exceptionally after exceptional
3204 >     * thenRunAsync result completes exceptionally after exceptional
3205       * completion of source
3206       */
3207 <    public void testRunAfterBothAsync2E() {
3208 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2276 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3207 >    public void testThenRunAsync2E() {
3208 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3209          Noop r = new Noop();
3210 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r, new ThreadExecutor());
3210 >        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3211          f.completeExceptionally(new CFException());
3212 <        f2.complete(two);
3213 <        checkCompletedWithWrappedCFException(g);
3214 <
3215 <        r = new Noop();
2284 <        f = new CompletableFuture<Integer>();
2285 <        f2 = new CompletableFuture<Integer>();
2286 <        g = f.runAfterBothAsync(f2, r, new ThreadExecutor());
2287 <        f.complete(one);
2288 <        f2.completeExceptionally(new CFException());
3212 >        try {
3213 >            g.join();
3214 >            shouldThrow();
3215 >        } catch (CompletionException success) {}
3216          checkCompletedWithWrappedCFException(g);
3217      }
3218  
3219      /**
3220 <     * runAfterBothAsync result completes exceptionally if action does
3220 >     * thenRunAsync result completes exceptionally if action does
3221       */
3222 <    public void testRunAfterBothAsync3E() {
3223 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2297 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3222 >    public void testThenRunAsync3E() {
3223 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3224          FailingNoop r = new FailingNoop();
3225 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r, new ThreadExecutor());
3226 <        f.complete(one);
2301 <        checkIncomplete(g);
2302 <        f2.complete(two);
3225 >        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3226 >        f.complete(null);
3227          checkCompletedWithWrappedCFException(g);
3228      }
3229  
3230      /**
3231 <     * runAfterBothAsync result completes exceptionally if either source cancelled
3231 >     * thenRunAsync result completes exceptionally if source cancelled
3232       */
3233 <    public void testRunAfterBothAsync4E() {
3234 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2311 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3233 >    public void testThenRunAsync4E() {
3234 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3235          Noop r = new Noop();
3236 <        CompletableFuture<Void> g = f.runAfterBothAsync(f2, r, new ThreadExecutor());
3236 >        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3237          assertTrue(f.cancel(true));
2315        f2.complete(two);
2316        checkCompletedWithWrappedCancellationException(g);
2317
2318        r = new Noop();
2319        f = new CompletableFuture<Integer>();
2320        f2 = new CompletableFuture<Integer>();
2321        g = f.runAfterBothAsync(f2, r, new ThreadExecutor());
2322        f.complete(one);
2323        assertTrue(f2.cancel(true));
3238          checkCompletedWithWrappedCancellationException(g);
3239      }
3240  
3241      /**
3242 <     * applyToEitherAsync result completes normally after normal
2329 <     * completion of sources
3242 >     * thenApplyAsync result completes normally after normal completion of source
3243       */
3244 <    public void testApplyToEitherAsyncE() {
3245 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3246 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2334 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2335 <        f.complete(one);
2336 <        checkCompletedNormally(g, two);
2337 <
2338 <        f = new CompletableFuture<Integer>();
3244 >    public void testThenApplyAsyncE() {
3245 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3246 >        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3247          f.complete(one);
2340        f2 = new CompletableFuture<Integer>();
2341        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
3248          checkCompletedNormally(g, two);
3249      }
3250  
3251      /**
3252 <     * applyToEitherAsync result completes exceptionally after exceptional
3252 >     * thenApplyAsync result completes exceptionally after exceptional
3253       * completion of source
3254       */
3255 <    public void testApplyToEitherAsync2E() {
3256 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3257 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2352 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
3255 >    public void testThenApplyAsync2E() {
3256 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3257 >        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3258          f.completeExceptionally(new CFException());
3259          checkCompletedWithWrappedCFException(g);
2355
2356        f = new CompletableFuture<Integer>();
2357        f2 = new CompletableFuture<Integer>();
2358        f2.completeExceptionally(new CFException());
2359        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2360        f.complete(one);
2361        checkCompletedWithWrappedCFException(g);
3260      }
3261  
3262      /**
3263 <     * applyToEitherAsync result completes exceptionally if action does
3263 >     * thenApplyAsync result completes exceptionally if action does
3264       */
3265 <    public void testApplyToEitherAsync3E() {
3266 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2369 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3265 >    public void testThenApplyAsync3E() {
3266 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3267          FailingFunction r = new FailingFunction();
3268 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, r, new ThreadExecutor());
3269 <        f.complete(one);
3268 >        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
3269 >        f.complete(null);
3270          checkCompletedWithWrappedCFException(g);
3271      }
3272  
3273      /**
3274 <     * applyToEitherAsync result completes exceptionally if either source cancelled
3274 >     * thenApplyAsync result completes exceptionally if source cancelled
3275       */
3276 <    public void testApplyToEitherAsync4E() {
3277 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3278 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2382 <        CompletableFuture<Integer> g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
3276 >    public void testThenApplyAsync4E() {
3277 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3278 >        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3279          assertTrue(f.cancel(true));
3280          checkCompletedWithWrappedCancellationException(g);
2385
2386        f = new CompletableFuture<Integer>();
2387        f2 = new CompletableFuture<Integer>();
2388        assertTrue(f2.cancel(true));
2389        g = f.applyToEitherAsync(f2, inc, new ThreadExecutor());
2390        checkCompletedWithWrappedCancellationException(g);
3281      }
3282  
3283      /**
3284 <     * acceptEitherAsync result completes normally after normal
3285 <     * completion of sources
3284 >     * thenAcceptAsync result completes normally after normal
3285 >     * completion of source
3286       */
3287 <    public void testAcceptEitherAsyncE() {
3288 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2399 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3287 >    public void testThenAcceptAsyncE() {
3288 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3289          IncAction r = new IncAction();
3290 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2402 <        f.complete(one);
2403 <        checkCompletedNormally(g, null);
2404 <        assertEquals(r.value, 2);
2405 <
2406 <        r = new IncAction();
2407 <        f = new CompletableFuture<Integer>();
3290 >        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3291          f.complete(one);
2409        f2 = new CompletableFuture<Integer>();
2410        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
3292          checkCompletedNormally(g, null);
3293 <        assertEquals(r.value, 2);
3293 >        assertEquals(r.value, (Integer) 2);
3294      }
3295  
3296      /**
3297 <     * acceptEitherAsync result completes exceptionally after exceptional
3297 >     * thenAcceptAsync result completes exceptionally after exceptional
3298       * completion of source
3299       */
3300 <    public void testAcceptEitherAsync2E() {
3301 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2421 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3300 >    public void testThenAcceptAsync2E() {
3301 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3302          IncAction r = new IncAction();
3303 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
3303 >        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3304          f.completeExceptionally(new CFException());
3305          checkCompletedWithWrappedCFException(g);
2426
2427        r = new IncAction();
2428        f = new CompletableFuture<Integer>();
2429        f2 = new CompletableFuture<Integer>();
2430        f2.completeExceptionally(new CFException());
2431        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2432        f.complete(one);
2433        checkCompletedWithWrappedCFException(g);
3306      }
3307  
3308      /**
3309 <     * acceptEitherAsync result completes exceptionally if action does
3309 >     * thenAcceptAsync result completes exceptionally if action does
3310       */
3311 <    public void testAcceptEitherAsync3E() {
3312 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2441 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3311 >    public void testThenAcceptAsync3E() {
3312 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3313          FailingConsumer r = new FailingConsumer();
3314 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
3315 <        f.complete(one);
3314 >        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3315 >        f.complete(null);
3316          checkCompletedWithWrappedCFException(g);
3317      }
3318  
3319      /**
3320 <     * acceptEitherAsync result completes exceptionally if either
2450 <     * source cancelled
3320 >     * thenAcceptAsync result completes exceptionally if source cancelled
3321       */
3322 <    public void testAcceptEitherAsync4E() {
3323 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2454 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
3322 >    public void testThenAcceptAsync4E() {
3323 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3324          IncAction r = new IncAction();
3325 <        CompletableFuture<Void> g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2457 <        assertTrue(f.cancel(true));
2458 <        checkCompletedWithWrappedCancellationException(g);
2459 <
2460 <        r = new IncAction();
2461 <        f = new CompletableFuture<Integer>();
2462 <        f2 = new CompletableFuture<Integer>();
2463 <        assertTrue(f2.cancel(true));
2464 <        g = f.acceptEitherAsync(f2, r, new ThreadExecutor());
2465 <        checkCompletedWithWrappedCancellationException(g);
2466 <    }
2467 <
2468 <    /**
2469 <     * runAfterEitherAsync result completes normally after normal
2470 <     * completion of sources
2471 <     */
2472 <    public void testRunAfterEitherAsyncE() {
2473 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2474 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2475 <        Noop r = new Noop();
2476 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2477 <        f.complete(one);
2478 <        checkCompletedNormally(g, null);
2479 <        assertTrue(r.ran);
2480 <
2481 <        r = new Noop();
2482 <        f = new CompletableFuture<Integer>();
2483 <        f.complete(one);
2484 <        f2 = new CompletableFuture<Integer>();
2485 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2486 <        checkCompletedNormally(g, null);
2487 <        assertTrue(r.ran);
2488 <    }
2489 <
2490 <    /**
2491 <     * runAfterEitherAsync result completes exceptionally after exceptional
2492 <     * completion of source
2493 <     */
2494 <    public void testRunAfterEitherAsync2E() {
2495 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2496 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2497 <        Noop r = new Noop();
2498 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2499 <        f.completeExceptionally(new CFException());
2500 <        checkCompletedWithWrappedCFException(g);
2501 <
2502 <        r = new Noop();
2503 <        f = new CompletableFuture<Integer>();
2504 <        f2 = new CompletableFuture<Integer>();
2505 <        f2.completeExceptionally(new CFException());
2506 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2507 <        f.complete(one);
2508 <        checkCompletedWithWrappedCFException(g);
2509 <    }
2510 <
2511 <    /**
2512 <     * runAfterEitherAsync result completes exceptionally if action does
2513 <     */
2514 <    public void testRunAfterEitherAsync3E() {
2515 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2516 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2517 <        FailingNoop r = new FailingNoop();
2518 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2519 <        f.complete(one);
2520 <        checkCompletedWithWrappedCFException(g);
2521 <    }
2522 <
2523 <    /**
2524 <     * runAfterEitherAsync result completes exceptionally if either
2525 <     * source cancelled
2526 <     */
2527 <    public void testRunAfterEitherAsync4E() {
2528 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2529 <        CompletableFuture<Integer> f2 = new CompletableFuture<Integer>();
2530 <        Noop r = new Noop();
2531 <        CompletableFuture<Void> g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2532 <        assertTrue(f.cancel(true));
2533 <        checkCompletedWithWrappedCancellationException(g);
2534 <
2535 <        r = new Noop();
2536 <        f = new CompletableFuture<Integer>();
2537 <        f2 = new CompletableFuture<Integer>();
2538 <        assertTrue(f2.cancel(true));
2539 <        g = f.runAfterEitherAsync(f2, r, new ThreadExecutor());
2540 <        checkCompletedWithWrappedCancellationException(g);
2541 <    }
2542 <
2543 <    /**
2544 <     * thenComposeAsync result completes normally after normal
2545 <     * completion of source
2546 <     */
2547 <    public void testThenComposeAsyncE() {
2548 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2549 <        CompletableFutureInc r = new CompletableFutureInc();
2550 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2551 <        f.complete(one);
2552 <        checkCompletedNormally(g, two);
2553 <    }
2554 <
2555 <    /**
2556 <     * thenComposeAsync result completes exceptionally after
2557 <     * exceptional completion of source
2558 <     */
2559 <    public void testThenComposeAsync2E() {
2560 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2561 <        CompletableFutureInc r = new CompletableFutureInc();
2562 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2563 <        f.completeExceptionally(new CFException());
2564 <        checkCompletedWithWrappedCFException(g);
2565 <    }
2566 <
2567 <    /**
2568 <     * thenComposeAsync result completes exceptionally if action does
2569 <     */
2570 <    public void testThenComposeAsync3E() {
2571 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2572 <        FailingCompletableFutureFunction r = new FailingCompletableFutureFunction();
2573 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
2574 <        f.complete(one);
2575 <        checkCompletedWithWrappedCFException(g);
2576 <    }
2577 <
2578 <    /**
2579 <     * thenComposeAsync result completes exceptionally if source cancelled
2580 <     */
2581 <    public void testThenComposeAsync4E() {
2582 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
2583 <        CompletableFutureInc r = new CompletableFutureInc();
2584 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3325 >        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3326          assertTrue(f.cancel(true));
3327          checkCompletedWithWrappedCancellationException(g);
3328      }
# Line 2593 | Line 3334 | public class CompletableFutureTest exten
3334       * with the value null
3335       */
3336      public void testAllOf_empty() throws Exception {
3337 <        CompletableFuture<?> f = CompletableFuture.allOf();
3337 >        CompletableFuture<Void> f = CompletableFuture.allOf();
3338          checkCompletedNormally(f, null);
3339      }
3340  
3341      /**
3342 <     * allOf returns a future completed when all components complete
3342 >     * allOf returns a future completed normally with the value null
3343 >     * when all components complete normally
3344       */
3345 <    public void testAllOf() throws Exception {
3345 >    public void testAllOf_normal() throws Exception {
3346          for (int k = 1; k < 20; ++k) {
3347 <            CompletableFuture[] fs = new CompletableFuture[k];
3347 >            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
3348              for (int i = 0; i < k; ++i)
3349 <                fs[i] = new CompletableFuture<Integer>();
3349 >                fs[i] = new CompletableFuture<>();
3350              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
3351              for (int i = 0; i < k; ++i) {
3352                  checkIncomplete(f);
3353 +                checkIncomplete(CompletableFuture.allOf(fs));
3354                  fs[i].complete(one);
3355              }
3356              checkCompletedNormally(f, null);
3357 +            checkCompletedNormally(CompletableFuture.allOf(fs), null);
3358          }
3359      }
3360  
# Line 2618 | Line 3362 | public class CompletableFutureTest exten
3362       * anyOf(no component futures) returns an incomplete future
3363       */
3364      public void testAnyOf_empty() throws Exception {
3365 <        CompletableFuture<?> f = CompletableFuture.anyOf();
3365 >        CompletableFuture<Object> f = CompletableFuture.anyOf();
3366          checkIncomplete(f);
3367      }
3368  
3369      /**
3370 <     * anyOf returns a future completed when any components complete
3370 >     * anyOf returns a future completed normally with a value when
3371 >     * a component future does
3372       */
3373 <    public void testAnyOf() throws Exception {
3374 <        for (int k = 1; k < 20; ++k) {
3373 >    public void testAnyOf_normal() throws Exception {
3374 >        for (int k = 0; k < 10; ++k) {
3375              CompletableFuture[] fs = new CompletableFuture[k];
3376              for (int i = 0; i < k; ++i)
3377 <                fs[i] = new CompletableFuture<Integer>();
3377 >                fs[i] = new CompletableFuture<>();
3378              CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3379              checkIncomplete(f);
3380              for (int i = 0; i < k; ++i) {
3381                  fs[i].complete(one);
3382                  checkCompletedNormally(f, one);
3383 +                checkCompletedNormally(CompletableFuture.anyOf(fs), one);
3384 +            }
3385 +        }
3386 +    }
3387 +
3388 +    /**
3389 +     * anyOf result completes exceptionally when any component does.
3390 +     */
3391 +    public void testAnyOf_exceptional() throws Exception {
3392 +        for (int k = 0; k < 10; ++k) {
3393 +            CompletableFuture[] fs = new CompletableFuture[k];
3394 +            for (int i = 0; i < k; ++i)
3395 +                fs[i] = new CompletableFuture<>();
3396 +            CompletableFuture<Object> f = CompletableFuture.anyOf(fs);
3397 +            checkIncomplete(f);
3398 +            for (int i = 0; i < k; ++i) {
3399 +                fs[i].completeExceptionally(new CFException());
3400 +                checkCompletedWithWrappedCFException(f);
3401 +                checkCompletedWithWrappedCFException(CompletableFuture.anyOf(fs));
3402              }
3403          }
3404      }
# Line 2643 | Line 3407 | public class CompletableFutureTest exten
3407       * Completion methods throw NullPointerException with null arguments
3408       */
3409      public void testNPE() {
3410 <        CompletableFuture<Integer> f = new CompletableFuture<Integer>();
3411 <        CompletableFuture<Integer> g = new CompletableFuture<Integer>();
3410 >        CompletableFuture<Integer> f = new CompletableFuture<>();
3411 >        CompletableFuture<Integer> g = new CompletableFuture<>();
3412          CompletableFuture<Integer> nullFuture = (CompletableFuture<Integer>)null;
3413          CompletableFuture<?> h;
3414          ThreadExecutor exec = new ThreadExecutor();
3415  
3416          Runnable[] throwingActions = {
3417 <            () -> { CompletableFuture.supplyAsync(null); },
3418 <            () -> { CompletableFuture.supplyAsync(null, exec); },
3419 <            () -> { CompletableFuture.supplyAsync(supplyOne, null); },
3420 <
3421 <            () -> { CompletableFuture.runAsync(null); },
3422 <            () -> { CompletableFuture.runAsync(null, exec); },
3423 <            () -> { CompletableFuture.runAsync(() -> {}, null); },
3424 <
3425 <            () -> { f.completeExceptionally(null); },
3426 <
3427 <            () -> { f.thenApply(null); },
3428 <            () -> { f.thenApplyAsync(null); },
3429 <            () -> { f.thenApplyAsync((x) -> x, null); },
3430 <            () -> { f.thenApplyAsync(null, exec); },
3431 <
3432 <            () -> { f.thenAccept(null); },
3433 <            () -> { f.thenAcceptAsync(null); },
3434 <            () -> { f.thenAcceptAsync((x) -> { ; }, null); },
3435 <            () -> { f.thenAcceptAsync(null, exec); },
3436 <
3437 <            () -> { f.thenRun(null); },
3438 <            () -> { f.thenRunAsync(null); },
3439 <            () -> { f.thenRunAsync(() -> { ; }, null); },
3440 <            () -> { f.thenRunAsync(null, exec); },
3441 <
3442 <            () -> { f.thenCombine(g, null); },
3443 <            () -> { f.thenCombineAsync(g, null); },
3444 <            () -> { f.thenCombineAsync(g, null, exec); },
3445 <            () -> { f.thenCombine(nullFuture, (x, y) -> x); },
3446 <            () -> { f.thenCombineAsync(nullFuture, (x, y) -> x); },
3447 <            () -> { f.thenCombineAsync(nullFuture, (x, y) -> x, exec); },
3448 <            () -> { f.thenCombineAsync(g, (x, y) -> x, null); },
3449 <
3450 <            () -> { f.thenAcceptBoth(g, null); },
3451 <            () -> { f.thenAcceptBothAsync(g, null); },
3452 <            () -> { f.thenAcceptBothAsync(g, null, exec); },
3453 <            () -> { f.thenAcceptBoth(nullFuture, (x, y) -> {}); },
3454 <            () -> { f.thenAcceptBothAsync(nullFuture, (x, y) -> {}); },
3455 <            () -> { f.thenAcceptBothAsync(nullFuture, (x, y) -> {}, exec); },
3456 <            () -> { f.thenAcceptBothAsync(g, (x, y) -> {}, null); },
3457 <
3458 <            () -> { f.runAfterBoth(g, null); },
3459 <            () -> { f.runAfterBothAsync(g, null); },
3460 <            () -> { f.runAfterBothAsync(g, null, exec); },
3461 <            () -> { f.runAfterBoth(nullFuture, () -> {}); },
3462 <            () -> { f.runAfterBothAsync(nullFuture, () -> {}); },
3463 <            () -> { f.runAfterBothAsync(nullFuture, () -> {}, exec); },
3464 <            () -> { f.runAfterBothAsync(g, () -> {}, null); },
3465 <
3466 <            () -> { f.applyToEither(g, null); },
3467 <            () -> { f.applyToEitherAsync(g, null); },
3468 <            () -> { f.applyToEitherAsync(g, null, exec); },
3469 <            () -> { f.applyToEither(nullFuture, (x) -> x); },
3470 <            () -> { f.applyToEitherAsync(nullFuture, (x) -> x); },
3471 <            () -> { f.applyToEitherAsync(nullFuture, (x) -> x, exec); },
3472 <            () -> { f.applyToEitherAsync(g, (x) -> x, null); },
3473 <
3474 <            () -> { f.acceptEither(g, null); },
3475 <            () -> { f.acceptEitherAsync(g, null); },
3476 <            () -> { f.acceptEitherAsync(g, null, exec); },
3477 <            () -> { f.acceptEither(nullFuture, (x) -> {}); },
3478 <            () -> { f.acceptEitherAsync(nullFuture, (x) -> {}); },
3479 <            () -> { f.acceptEitherAsync(nullFuture, (x) -> {}, exec); },
3480 <            () -> { f.acceptEitherAsync(g, (x) -> {}, null); },
3481 <
3482 <            () -> { f.runAfterEither(g, null); },
3483 <            () -> { f.runAfterEitherAsync(g, null); },
3484 <            () -> { f.runAfterEitherAsync(g, null, exec); },
3485 <            () -> { f.runAfterEither(nullFuture, () -> {}); },
3486 <            () -> { f.runAfterEitherAsync(nullFuture, () -> {}); },
3487 <            () -> { f.runAfterEitherAsync(nullFuture, () -> {}, exec); },
3488 <            () -> { f.runAfterEitherAsync(g, () -> {}, null); },
3489 <
3490 <            () -> { f.thenCompose(null); },
3491 <            () -> { f.thenComposeAsync(null); },
3492 <            () -> { f.thenComposeAsync(new CompletableFutureInc(), null); },
3493 <            () -> { f.thenComposeAsync(null, exec); },
3494 <
3495 <            () -> { f.exceptionally(null); },
3496 <
3497 <            () -> { f.handle(null); },
3498 <
3499 <            () -> { CompletableFuture.allOf((CompletableFuture<?>)null); },
3500 <            () -> { CompletableFuture.allOf((CompletableFuture<?>[])null); },
3501 <            () -> { CompletableFuture.allOf(f, null); },
3502 <            () -> { CompletableFuture.allOf(null, f); },
3503 <
3504 <            () -> { CompletableFuture.anyOf((CompletableFuture<?>)null); },
3505 <            () -> { CompletableFuture.anyOf((CompletableFuture<?>[])null); },
3506 <            () -> { CompletableFuture.anyOf(f, null); },
3507 <            () -> { CompletableFuture.anyOf(null, f); },
3417 >            () -> CompletableFuture.supplyAsync(null),
3418 >            () -> CompletableFuture.supplyAsync(null, exec),
3419 >            () -> CompletableFuture.supplyAsync(supplyOne, null),
3420 >
3421 >            () -> CompletableFuture.runAsync(null),
3422 >            () -> CompletableFuture.runAsync(null, exec),
3423 >            () -> CompletableFuture.runAsync(() -> {}, null),
3424 >
3425 >            () -> f.completeExceptionally(null),
3426 >
3427 >            () -> f.thenApply(null),
3428 >            () -> f.thenApplyAsync(null),
3429 >            () -> f.thenApplyAsync((x) -> x, null),
3430 >            () -> f.thenApplyAsync(null, exec),
3431 >
3432 >            () -> f.thenAccept(null),
3433 >            () -> f.thenAcceptAsync(null),
3434 >            () -> f.thenAcceptAsync((x) -> {} , null),
3435 >            () -> f.thenAcceptAsync(null, exec),
3436 >
3437 >            () -> f.thenRun(null),
3438 >            () -> f.thenRunAsync(null),
3439 >            () -> f.thenRunAsync(() -> {} , null),
3440 >            () -> f.thenRunAsync(null, exec),
3441 >
3442 >            () -> f.thenCombine(g, null),
3443 >            () -> f.thenCombineAsync(g, null),
3444 >            () -> f.thenCombineAsync(g, null, exec),
3445 >            () -> f.thenCombine(nullFuture, (x, y) -> x),
3446 >            () -> f.thenCombineAsync(nullFuture, (x, y) -> x),
3447 >            () -> f.thenCombineAsync(nullFuture, (x, y) -> x, exec),
3448 >            () -> f.thenCombineAsync(g, (x, y) -> x, null),
3449 >
3450 >            () -> f.thenAcceptBoth(g, null),
3451 >            () -> f.thenAcceptBothAsync(g, null),
3452 >            () -> f.thenAcceptBothAsync(g, null, exec),
3453 >            () -> f.thenAcceptBoth(nullFuture, (x, y) -> {}),
3454 >            () -> f.thenAcceptBothAsync(nullFuture, (x, y) -> {}),
3455 >            () -> f.thenAcceptBothAsync(nullFuture, (x, y) -> {}, exec),
3456 >            () -> f.thenAcceptBothAsync(g, (x, y) -> {}, null),
3457 >
3458 >            () -> f.runAfterBoth(g, null),
3459 >            () -> f.runAfterBothAsync(g, null),
3460 >            () -> f.runAfterBothAsync(g, null, exec),
3461 >            () -> f.runAfterBoth(nullFuture, () -> {}),
3462 >            () -> f.runAfterBothAsync(nullFuture, () -> {}),
3463 >            () -> f.runAfterBothAsync(nullFuture, () -> {}, exec),
3464 >            () -> f.runAfterBothAsync(g, () -> {}, null),
3465 >
3466 >            () -> f.applyToEither(g, null),
3467 >            () -> f.applyToEitherAsync(g, null),
3468 >            () -> f.applyToEitherAsync(g, null, exec),
3469 >            () -> f.applyToEither(nullFuture, (x) -> x),
3470 >            () -> f.applyToEitherAsync(nullFuture, (x) -> x),
3471 >            () -> f.applyToEitherAsync(nullFuture, (x) -> x, exec),
3472 >            () -> f.applyToEitherAsync(g, (x) -> x, null),
3473 >
3474 >            () -> f.acceptEither(g, null),
3475 >            () -> f.acceptEitherAsync(g, null),
3476 >            () -> f.acceptEitherAsync(g, null, exec),
3477 >            () -> f.acceptEither(nullFuture, (x) -> {}),
3478 >            () -> f.acceptEitherAsync(nullFuture, (x) -> {}),
3479 >            () -> f.acceptEitherAsync(nullFuture, (x) -> {}, exec),
3480 >            () -> f.acceptEitherAsync(g, (x) -> {}, null),
3481 >
3482 >            () -> f.runAfterEither(g, null),
3483 >            () -> f.runAfterEitherAsync(g, null),
3484 >            () -> f.runAfterEitherAsync(g, null, exec),
3485 >            () -> f.runAfterEither(nullFuture, () -> {}),
3486 >            () -> f.runAfterEitherAsync(nullFuture, () -> {}),
3487 >            () -> f.runAfterEitherAsync(nullFuture, () -> {}, exec),
3488 >            () -> f.runAfterEitherAsync(g, () -> {}, null),
3489 >
3490 >            () -> f.thenCompose(null),
3491 >            () -> f.thenComposeAsync(null),
3492 >            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
3493 >            () -> f.thenComposeAsync(null, exec),
3494 >
3495 >            () -> f.exceptionally(null),
3496 >
3497 >            () -> f.handle(null),
3498 >
3499 >            () -> CompletableFuture.allOf((CompletableFuture<?>)null),
3500 >            () -> CompletableFuture.allOf((CompletableFuture<?>[])null),
3501 >            () -> CompletableFuture.allOf(f, null),
3502 >            () -> CompletableFuture.allOf(null, f),
3503 >
3504 >            () -> CompletableFuture.anyOf((CompletableFuture<?>)null),
3505 >            () -> CompletableFuture.anyOf((CompletableFuture<?>[])null),
3506 >            () -> CompletableFuture.anyOf(f, null),
3507 >            () -> CompletableFuture.anyOf(null, f),
3508 >
3509 >            () -> f.obtrudeException(null),
3510          };
3511  
3512          assertThrows(NullPointerException.class, throwingActions);
3513          assertEquals(0, exec.count.get());
3514      }
3515  
3516 +    /**
3517 +     * toCompletableFuture returns this CompletableFuture.
3518 +     */
3519 +    public void testToCompletableFuture() {
3520 +        CompletableFuture<Integer> f = new CompletableFuture<>();
3521 +        assertSame(f, f.toCompletableFuture());
3522 +    }
3523 +
3524 +    /**
3525 +     * whenComplete action executes on normal completion, propagating
3526 +     * source result.
3527 +     */
3528 +    public void testWhenComplete_normalCompletion1() {
3529 +        for (ExecutionMode m : ExecutionMode.values())
3530 +        for (boolean createIncomplete : new boolean[] { true, false })
3531 +        for (Integer v1 : new Integer[] { 1, null })
3532 +    {
3533 +        final AtomicInteger a = new AtomicInteger(0);
3534 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
3535 +        if (!createIncomplete) f.complete(v1);
3536 +        final CompletableFuture<Integer> g = m.whenComplete
3537 +            (f,
3538 +             (Integer x, Throwable t) -> {
3539 +                threadAssertSame(x, v1);
3540 +                threadAssertNull(t);
3541 +                a.getAndIncrement();
3542 +            });
3543 +        if (createIncomplete) f.complete(v1);
3544 +
3545 +        checkCompletedNormally(g, v1);
3546 +        checkCompletedNormally(f, v1);
3547 +        assertEquals(1, a.get());
3548 +    }}
3549 +
3550 +    /**
3551 +     * whenComplete action executes on exceptional completion, propagating
3552 +     * source result.
3553 +     */
3554 +    public void testWhenComplete_exceptionalCompletion() {
3555 +        for (ExecutionMode m : ExecutionMode.values())
3556 +        for (boolean createIncomplete : new boolean[] { true, false })
3557 +        for (Integer v1 : new Integer[] { 1, null })
3558 +    {
3559 +        final AtomicInteger a = new AtomicInteger(0);
3560 +        final CFException ex = new CFException();
3561 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
3562 +        if (!createIncomplete) f.completeExceptionally(ex);
3563 +        final CompletableFuture<Integer> g = m.whenComplete
3564 +            (f,
3565 +             (Integer x, Throwable t) -> {
3566 +                threadAssertNull(x);
3567 +                threadAssertSame(t, ex);
3568 +                a.getAndIncrement();
3569 +            });
3570 +        if (createIncomplete) f.completeExceptionally(ex);
3571 +        checkCompletedWithWrappedCFException(f, ex);
3572 +        checkCompletedWithWrappedCFException(g, ex);
3573 +        assertEquals(1, a.get());
3574 +    }}
3575 +
3576 +    /**
3577 +     * whenComplete action executes on cancelled source, propagating
3578 +     * CancellationException.
3579 +     */
3580 +    public void testWhenComplete_sourceCancelled() {
3581 +        for (ExecutionMode m : ExecutionMode.values())
3582 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3583 +        for (boolean createIncomplete : new boolean[] { true, false })
3584 +    {
3585 +        final AtomicInteger a = new AtomicInteger(0);
3586 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
3587 +        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
3588 +        final CompletableFuture<Integer> g = m.whenComplete
3589 +            (f,
3590 +             (Integer x, Throwable t) -> {
3591 +                threadAssertNull(x);
3592 +                threadAssertTrue(t instanceof CancellationException);
3593 +                a.getAndIncrement();
3594 +            });
3595 +        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
3596 +
3597 +        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
3598 +        checkCompletedWithWrappedCancellationException(g);
3599 +        checkCancelled(f);
3600 +        assertEquals(1, a.get());
3601 +    }}
3602 +
3603 +    /**
3604 +     * If a whenComplete action throws an exception when triggered by
3605 +     * a normal completion, it completes exceptionally
3606 +     */
3607 +    public void testWhenComplete_actionFailed() {
3608 +        for (boolean createIncomplete : new boolean[] { true, false })
3609 +        for (ExecutionMode m : ExecutionMode.values())
3610 +        for (Integer v1 : new Integer[] { 1, null }) {
3611 +
3612 +        final AtomicInteger a = new AtomicInteger(0);
3613 +        final CFException ex = new CFException();
3614 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
3615 +        if (!createIncomplete) f.complete(v1);
3616 +        final CompletableFuture<Integer> g = m.whenComplete
3617 +            (f,
3618 +             (Integer x, Throwable t) -> {
3619 +                threadAssertSame(x, v1);
3620 +                threadAssertNull(t);
3621 +                a.getAndIncrement();
3622 +                throw ex;
3623 +            });
3624 +        if (createIncomplete) f.complete(v1);
3625 +        checkCompletedNormally(f, v1);
3626 +        checkCompletedWithWrappedCFException(g, ex);
3627 +        assertEquals(1, a.get());
3628 +        }
3629 +    }
3630 +
3631 +    /**
3632 +     * If a whenComplete action throws an exception when triggered by
3633 +     * a source completion that also throws an exception, the source
3634 +     * exception takes precedence.
3635 +     */
3636 +    public void testWhenComplete_actionFailedSourceFailed() {
3637 +        for (boolean createIncomplete : new boolean[] { true, false })
3638 +        for (ExecutionMode m : ExecutionMode.values())
3639 +        for (Integer v1 : new Integer[] { 1, null }) {
3640 +
3641 +        final AtomicInteger a = new AtomicInteger(0);
3642 +        final CFException ex1 = new CFException();
3643 +        final CFException ex2 = new CFException();
3644 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
3645 +
3646 +        if (!createIncomplete) f.completeExceptionally(ex1);
3647 +        final CompletableFuture<Integer> g = m.whenComplete
3648 +            (f,
3649 +             (Integer x, Throwable t) -> {
3650 +                threadAssertSame(t, ex1);
3651 +                threadAssertNull(x);
3652 +                a.getAndIncrement();
3653 +                throw ex2;
3654 +            });
3655 +        if (createIncomplete) f.completeExceptionally(ex1);
3656 +
3657 +        checkCompletedWithWrappedCFException(f, ex1);
3658 +        checkCompletedWithWrappedCFException(g, ex1);
3659 +        assertEquals(1, a.get());
3660 +        }
3661 +    }
3662 +
3663   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines