ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.55 by jsr166, Mon Jun 2 21:41:37 2014 UTC vs.
Revision 1.82 by jsr166, Mon Jun 16 18:04:07 2014 UTC

# Line 105 | Line 105 | public class CompletableFutureTest exten
105          assertTrue(f.toString().contains("[Completed exceptionally]"));
106      }
107  
108 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
109 <                                              CFException ex) {
108 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
109 >                                                      Throwable ex) {
110          try {
111              f.get(LONG_DELAY_MS, MILLISECONDS);
112              shouldThrow();
# Line 131 | Line 131 | public class CompletableFutureTest exten
131          } catch (ExecutionException success) {
132              assertSame(ex, success.getCause());
133          } catch (Throwable fail) { threadUnexpectedException(fail); }
134 +
135          assertTrue(f.isDone());
136          assertFalse(f.isCancelled());
137          assertTrue(f.toString().contains("[Completed exceptionally]"));
138      }
139  
140 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
141 +                                                Throwable ex) {
142 +        checkCompletedExceptionallyWithRootCause(f, ex);
143 +        try {
144 +            CompletableFuture<Throwable> spy = f.handle
145 +                ((U u, Throwable t) -> t);
146 +            assertTrue(spy.join() instanceof CompletionException);
147 +            assertSame(ex, spy.join().getCause());
148 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
149 +    }
150 +
151 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
152 +        checkCompletedExceptionallyWithRootCause(f, ex);
153 +        try {
154 +            CompletableFuture<Throwable> spy = f.handle
155 +                ((U u, Throwable t) -> t);
156 +            assertSame(ex, spy.join());
157 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
158 +    }
159 +
160      void checkCancelled(CompletableFuture<?> f) {
161          try {
162              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 206 | Line 227 | public class CompletableFutureTest exten
227       * isCancelled, join, get, and getNow
228       */
229      public void testComplete() {
230 +        for (Integer v1 : new Integer[] { 1, null })
231 +    {
232          CompletableFuture<Integer> f = new CompletableFuture<>();
233          checkIncomplete(f);
234 <        f.complete(one);
235 <        checkCompletedNormally(f, one);
236 <    }
234 >        assertTrue(f.complete(v1));
235 >        assertFalse(f.complete(v1));
236 >        checkCompletedNormally(f, v1);
237 >    }}
238  
239      /**
240       * completeExceptionally completes exceptionally, as indicated by
# Line 218 | Line 242 | public class CompletableFutureTest exten
242       */
243      public void testCompleteExceptionally() {
244          CompletableFuture<Integer> f = new CompletableFuture<>();
245 +        CFException ex = new CFException();
246          checkIncomplete(f);
247 <        f.completeExceptionally(new CFException());
248 <        checkCompletedWithWrappedCFException(f);
247 >        f.completeExceptionally(ex);
248 >        checkCompletedExceptionally(f, ex);
249      }
250  
251      /**
# Line 228 | Line 253 | public class CompletableFutureTest exten
253       * methods isDone, isCancelled, join, get, and getNow
254       */
255      public void testCancel() {
256 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
257 +    {
258          CompletableFuture<Integer> f = new CompletableFuture<>();
259          checkIncomplete(f);
260          assertTrue(f.cancel(true));
261 +        assertTrue(f.cancel(true));
262          checkCancelled(f);
263 <    }
263 >    }}
264  
265      /**
266       * obtrudeValue forces completion with given value
# Line 240 | Line 268 | public class CompletableFutureTest exten
268      public void testObtrudeValue() {
269          CompletableFuture<Integer> f = new CompletableFuture<>();
270          checkIncomplete(f);
271 <        f.complete(one);
271 >        assertTrue(f.complete(one));
272          checkCompletedNormally(f, one);
273          f.obtrudeValue(three);
274          checkCompletedNormally(f, three);
# Line 261 | Line 289 | public class CompletableFutureTest exten
289       * obtrudeException forces completion with given exception
290       */
291      public void testObtrudeException() {
292 <        CompletableFuture<Integer> f = new CompletableFuture<>();
293 <        checkIncomplete(f);
294 <        f.complete(one);
295 <        checkCompletedNormally(f, one);
296 <        f.obtrudeException(new CFException());
269 <        checkCompletedWithWrappedCFException(f);
292 >        for (Integer v1 : new Integer[] { 1, null })
293 >    {
294 >        CFException ex;
295 >        CompletableFuture<Integer> f;
296 >
297          f = new CompletableFuture<>();
298 <        f.obtrudeException(new CFException());
299 <        checkCompletedWithWrappedCFException(f);
298 >        assertTrue(f.complete(v1));
299 >        for (int i = 0; i < 2; i++) {
300 >            f.obtrudeException(ex = new CFException());
301 >            checkCompletedExceptionally(f, ex);
302 >        }
303 >
304 >        f = new CompletableFuture<>();
305 >        for (int i = 0; i < 2; i++) {
306 >            f.obtrudeException(ex = new CFException());
307 >            checkCompletedExceptionally(f, ex);
308 >        }
309 >
310          f = new CompletableFuture<>();
311 +        f.completeExceptionally(ex = new CFException());
312 +        f.obtrudeValue(v1);
313 +        checkCompletedNormally(f, v1);
314 +        f.obtrudeException(ex = new CFException());
315 +        checkCompletedExceptionally(f, ex);
316          f.completeExceptionally(new CFException());
317 <        f.obtrudeValue(four);
318 <        checkCompletedNormally(f, four);
319 <        f.obtrudeException(new CFException());
320 <        checkCompletedWithWrappedCFException(f);
279 <    }
317 >        checkCompletedExceptionally(f, ex);
318 >        assertFalse(f.complete(v1));
319 >        checkCompletedExceptionally(f, ex);
320 >    }}
321  
322      /**
323       * getNumberOfDependents returns number of dependent tasks
324       */
325      public void testGetNumberOfDependents() {
326 +        for (ExecutionMode m : ExecutionMode.values())
327 +        for (Integer v1 : new Integer[] { 1, null })
328 +    {
329          CompletableFuture<Integer> f = new CompletableFuture<>();
330          assertEquals(0, f.getNumberOfDependents());
331 <        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
331 >        final CompletableFuture<Void> g = m.thenRun(f, new Noop(m));
332          assertEquals(1, f.getNumberOfDependents());
333          assertEquals(0, g.getNumberOfDependents());
334 <        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
334 >        final CompletableFuture<Void> h = m.thenRun(f, new Noop(m));
335          assertEquals(2, f.getNumberOfDependents());
336 <        f.complete(1);
336 >        assertEquals(0, h.getNumberOfDependents());
337 >        assertTrue(f.complete(v1));
338          checkCompletedNormally(g, null);
339 +        checkCompletedNormally(h, null);
340          assertEquals(0, f.getNumberOfDependents());
341          assertEquals(0, g.getNumberOfDependents());
342 <    }
342 >        assertEquals(0, h.getNumberOfDependents());
343 >    }}
344  
345      /**
346       * toString indicates current completion state
# Line 304 | Line 351 | public class CompletableFutureTest exten
351          f = new CompletableFuture<String>();
352          assertTrue(f.toString().contains("[Not completed]"));
353  
354 <        f.complete("foo");
354 >        assertTrue(f.complete("foo"));
355          assertTrue(f.toString().contains("[Completed normally]"));
356  
357          f = new CompletableFuture<String>();
358 <        f.completeExceptionally(new IndexOutOfBoundsException());
358 >        assertTrue(f.completeExceptionally(new IndexOutOfBoundsException()));
359          assertTrue(f.toString().contains("[Completed exceptionally]"));
360 +
361 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
362 +            f = new CompletableFuture<String>();
363 +            assertTrue(f.cancel(mayInterruptIfRunning));
364 +            assertTrue(f.toString().contains("[Completed exceptionally]"));
365 +        }
366      }
367  
368      /**
# Line 320 | Line 373 | public class CompletableFutureTest exten
373          checkCompletedNormally(f, "test");
374      }
375  
376 <    // Choose non-commutative actions for better coverage
376 >    abstract class CheckedAction {
377 >        int invocationCount = 0;
378 >        final ExecutionMode m;
379 >        CheckedAction(ExecutionMode m) { this.m = m; }
380 >        void invoked() {
381 >            m.checkExecutionMode();
382 >            assertEquals(0, invocationCount++);
383 >        }
384 >        void assertNotInvoked() { assertEquals(0, invocationCount); }
385 >        void assertInvoked() { assertEquals(1, invocationCount); }
386 >    }
387  
388 <    // A non-commutative function that handles and produces null values as well.
389 <    static Integer subtract(Integer x, Integer y) {
390 <        return (x == null && y == null) ? null :
391 <            ((x == null) ? 42 : x.intValue())
392 <            - ((y == null) ? 99 : y.intValue());
388 >    abstract class CheckedIntegerAction extends CheckedAction {
389 >        Integer value;
390 >        CheckedIntegerAction(ExecutionMode m) { super(m); }
391 >        void assertValue(Integer expected) {
392 >            assertInvoked();
393 >            assertEquals(expected, value);
394 >        }
395 >    }
396 >
397 >    class IntegerSupplier extends CheckedAction
398 >        implements Supplier<Integer>
399 >    {
400 >        final Integer value;
401 >        IntegerSupplier(ExecutionMode m, Integer value) {
402 >            super(m);
403 >            this.value = value;
404 >        }
405 >        public Integer get() {
406 >            invoked();
407 >            return value;
408 >        }
409      }
410  
411      // A function that handles and produces null values as well.
# Line 334 | Line 413 | public class CompletableFutureTest exten
413          return (x == null) ? null : x + 1;
414      }
415  
416 <    static final Supplier<Integer> supplyOne =
417 <        () -> Integer.valueOf(1);
418 <    static final Function<Integer, Integer> inc =
419 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
341 <    static final BiFunction<Integer, Integer, Integer> subtract =
342 <        (Integer x, Integer y) -> subtract(x, y);
343 <    static final class IncAction implements Consumer<Integer> {
344 <        int invocationCount = 0;
345 <        Integer value;
416 >    class NoopConsumer extends CheckedIntegerAction
417 >        implements Consumer<Integer>
418 >    {
419 >        NoopConsumer(ExecutionMode m) { super(m); }
420          public void accept(Integer x) {
421 <            invocationCount++;
422 <            value = inc(x);
421 >            invoked();
422 >            value = x;
423          }
424      }
425 <    static final class IncFunction implements Function<Integer,Integer> {
426 <        int invocationCount = 0;
427 <        Integer value;
425 >
426 >    class IncFunction extends CheckedIntegerAction
427 >        implements Function<Integer,Integer>
428 >    {
429 >        IncFunction(ExecutionMode m) { super(m); }
430          public Integer apply(Integer x) {
431 <            invocationCount++;
431 >            invoked();
432              return value = inc(x);
433          }
434      }
435 <    static final class SubtractAction implements BiConsumer<Integer, Integer> {
436 <        int invocationCount = 0;
437 <        Integer value;
438 <        // Check this action was invoked exactly once when result is computed.
435 >
436 >    // Choose non-commutative actions for better coverage
437 >    // A non-commutative function that handles and produces null values as well.
438 >    static Integer subtract(Integer x, Integer y) {
439 >        return (x == null && y == null) ? null :
440 >            ((x == null) ? 42 : x.intValue())
441 >            - ((y == null) ? 99 : y.intValue());
442 >    }
443 >
444 >    class SubtractAction extends CheckedIntegerAction
445 >        implements BiConsumer<Integer, Integer>
446 >    {
447 >        SubtractAction(ExecutionMode m) { super(m); }
448          public void accept(Integer x, Integer y) {
449 <            invocationCount++;
449 >            invoked();
450              value = subtract(x, y);
451          }
452      }
453 <    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
454 <        int invocationCount = 0;
455 <        Integer value;
456 <        // Check this action was invoked exactly once when result is computed.
453 >
454 >    class SubtractFunction extends CheckedIntegerAction
455 >        implements BiFunction<Integer, Integer, Integer>
456 >    {
457 >        SubtractFunction(ExecutionMode m) { super(m); }
458          public Integer apply(Integer x, Integer y) {
459 <            invocationCount++;
459 >            invoked();
460              return value = subtract(x, y);
461          }
462      }
463 <    static final class Noop implements Runnable {
464 <        final ExecutionMode m;
465 <        int invocationCount = 0;
380 <        Noop(ExecutionMode m) { this.m = m; }
463 >
464 >    class Noop extends CheckedAction implements Runnable {
465 >        Noop(ExecutionMode m) { super(m); }
466          public void run() {
467 <            m.checkExecutionMode();
383 <            invocationCount++;
467 >            invoked();
468          }
469      }
470  
471 <    static final class FailingSupplier implements Supplier<Integer> {
472 <        int invocationCount = 0;
471 >    class FailingSupplier extends CheckedAction
472 >        implements Supplier<Integer>
473 >    {
474 >        FailingSupplier(ExecutionMode m) { super(m); }
475          public Integer get() {
476 <            invocationCount++;
476 >            invoked();
477              throw new CFException();
478          }
479      }
480 <    static final class FailingConsumer implements Consumer<Integer> {
481 <        int invocationCount = 0;
480 >
481 >    class FailingConsumer extends CheckedIntegerAction
482 >        implements Consumer<Integer>
483 >    {
484 >        FailingConsumer(ExecutionMode m) { super(m); }
485          public void accept(Integer x) {
486 <            invocationCount++;
486 >            invoked();
487 >            value = x;
488              throw new CFException();
489          }
490      }
491 <    static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
492 <        int invocationCount = 0;
491 >
492 >    class FailingBiConsumer extends CheckedIntegerAction
493 >        implements BiConsumer<Integer, Integer>
494 >    {
495 >        FailingBiConsumer(ExecutionMode m) { super(m); }
496          public void accept(Integer x, Integer y) {
497 <            invocationCount++;
497 >            invoked();
498 >            value = subtract(x, y);
499              throw new CFException();
500          }
501      }
502 <    static final class FailingFunction implements Function<Integer, Integer> {
503 <        int invocationCount = 0;
502 >
503 >    class FailingFunction extends CheckedIntegerAction
504 >        implements Function<Integer, Integer>
505 >    {
506 >        FailingFunction(ExecutionMode m) { super(m); }
507          public Integer apply(Integer x) {
508 <            invocationCount++;
508 >            invoked();
509 >            value = x;
510              throw new CFException();
511          }
512      }
513 <    static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
514 <        int invocationCount = 0;
513 >
514 >    class FailingBiFunction extends CheckedIntegerAction
515 >        implements BiFunction<Integer, Integer, Integer>
516 >    {
517 >        FailingBiFunction(ExecutionMode m) { super(m); }
518          public Integer apply(Integer x, Integer y) {
519 <            invocationCount++;
519 >            invoked();
520 >            value = subtract(x, y);
521              throw new CFException();
522          }
523      }
524 <    static final class FailingRunnable implements Runnable {
525 <        int invocationCount = 0;
524 >
525 >    class FailingRunnable extends CheckedAction implements Runnable {
526 >        FailingRunnable(ExecutionMode m) { super(m); }
527          public void run() {
528 <            invocationCount++;
528 >            invoked();
529              throw new CFException();
530          }
531      }
532  
533 <    static final class CompletableFutureInc
534 <        implements Function<Integer, CompletableFuture<Integer>> {
535 <        int invocationCount = 0;
533 >
534 >    class CompletableFutureInc extends CheckedIntegerAction
535 >        implements Function<Integer, CompletableFuture<Integer>>
536 >    {
537 >        CompletableFutureInc(ExecutionMode m) { super(m); }
538          public CompletableFuture<Integer> apply(Integer x) {
539 <            invocationCount++;
539 >            invoked();
540 >            value = x;
541              CompletableFuture<Integer> f = new CompletableFuture<>();
542 <            f.complete(inc(x));
542 >            assertTrue(f.complete(inc(x)));
543              return f;
544          }
545      }
546  
547 <    static final class FailingCompletableFutureFunction
548 <        implements Function<Integer, CompletableFuture<Integer>> {
549 <        int invocationCount = 0;
547 >    class FailingCompletableFutureFunction extends CheckedIntegerAction
548 >        implements Function<Integer, CompletableFuture<Integer>>
549 >    {
550 >        FailingCompletableFutureFunction(ExecutionMode m) { super(m); }
551          public CompletableFuture<Integer> apply(Integer x) {
552 <            invocationCount++;
552 >            invoked();
553 >            value = x;
554              throw new CFException();
555          }
556      }
557  
558      // Used for explicit executor tests
559      static final class ThreadExecutor implements Executor {
560 <        AtomicInteger count = new AtomicInteger(0);
560 >        final AtomicInteger count = new AtomicInteger(0);
561 >        static final ThreadGroup tg = new ThreadGroup("ThreadExecutor");
562 >        static boolean startedCurrentThread() {
563 >            return Thread.currentThread().getThreadGroup() == tg;
564 >        }
565  
566          public void execute(Runnable r) {
567              count.getAndIncrement();
568 <            new Thread(r).start();
568 >            new Thread(tg, r).start();
569          }
570      }
571  
572      /**
573       * Permits the testing of parallel code for the 3 different
574 <     * execution modes without repeating all the testing code.
574 >     * execution modes without copy/pasting all the test methods.
575       */
576      enum ExecutionMode {
577          DEFAULT {
578              public void checkExecutionMode() {
579 +                assertFalse(ThreadExecutor.startedCurrentThread());
580                  assertNull(ForkJoinTask.getPool());
581              }
582 +            public CompletableFuture<Void> runAsync(Runnable a) {
583 +                throw new UnsupportedOperationException();
584 +            }
585 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
586 +                throw new UnsupportedOperationException();
587 +            }
588              public <T> CompletableFuture<Void> thenRun
589                  (CompletableFuture<T> f, Runnable a) {
590                  return f.thenRun(a);
# Line 534 | Line 653 | public class CompletableFutureTest exten
653                  assertSame(ForkJoinPool.commonPool(),
654                             ForkJoinTask.getPool());
655              }
656 +            public CompletableFuture<Void> runAsync(Runnable a) {
657 +                return CompletableFuture.runAsync(a);
658 +            }
659 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
660 +                return CompletableFuture.supplyAsync(a);
661 +            }
662              public <T> CompletableFuture<Void> thenRun
663                  (CompletableFuture<T> f, Runnable a) {
664                  return f.thenRunAsync(a);
# Line 599 | Line 724 | public class CompletableFutureTest exten
724  
725          EXECUTOR {
726              public void checkExecutionMode() {
727 <                //TODO
727 >                assertTrue(ThreadExecutor.startedCurrentThread());
728 >            }
729 >            public CompletableFuture<Void> runAsync(Runnable a) {
730 >                return CompletableFuture.runAsync(a, new ThreadExecutor());
731 >            }
732 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
733 >                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
734              }
735              public <T> CompletableFuture<Void> thenRun
736                  (CompletableFuture<T> f, Runnable a) {
# Line 665 | Line 796 | public class CompletableFutureTest exten
796          };
797  
798          public abstract void checkExecutionMode();
799 +        public abstract CompletableFuture<Void> runAsync(Runnable a);
800 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
801          public abstract <T> CompletableFuture<Void> thenRun
802              (CompletableFuture<T> f, Runnable a);
803          public abstract <T> CompletableFuture<Void> thenAccept
# Line 714 | Line 847 | public class CompletableFutureTest exten
847      {
848          final AtomicInteger a = new AtomicInteger(0);
849          final CompletableFuture<Integer> f = new CompletableFuture<>();
850 <        if (!createIncomplete) f.complete(v1);
850 >        if (!createIncomplete) assertTrue(f.complete(v1));
851          final CompletableFuture<Integer> g = f.exceptionally
852              ((Throwable t) -> {
853                  // Should not be called
854                  a.getAndIncrement();
855                  throw new AssertionError();
856              });
857 <        if (createIncomplete) f.complete(v1);
857 >        if (createIncomplete) assertTrue(f.complete(v1));
858  
859          checkCompletedNormally(g, v1);
860          checkCompletedNormally(f, v1);
861          assertEquals(0, a.get());
862      }}
863  
731
864      /**
865       * exceptionally action completes with function value on source
866       * exception
# Line 743 | Line 875 | public class CompletableFutureTest exten
875          if (!createIncomplete) f.completeExceptionally(ex);
876          final CompletableFuture<Integer> g = f.exceptionally
877              ((Throwable t) -> {
878 +                ExecutionMode.DEFAULT.checkExecutionMode();
879                  threadAssertSame(t, ex);
880                  a.getAndIncrement();
881                  return v1;
# Line 764 | Line 897 | public class CompletableFutureTest exten
897          if (!createIncomplete) f.completeExceptionally(ex1);
898          final CompletableFuture<Integer> g = f.exceptionally
899              ((Throwable t) -> {
900 +                ExecutionMode.DEFAULT.checkExecutionMode();
901 +                threadAssertSame(t, ex1);
902 +                a.getAndIncrement();
903 +                throw ex2;
904 +            });
905 +        if (createIncomplete) f.completeExceptionally(ex1);
906 +
907 +        checkCompletedWithWrappedException(g, ex2);
908 +        assertEquals(1, a.get());
909 +    }}
910 +
911 +    /**
912 +     * whenComplete action executes on normal completion, propagating
913 +     * source result.
914 +     */
915 +    public void testWhenComplete_normalCompletion1() {
916 +        for (ExecutionMode m : ExecutionMode.values())
917 +        for (boolean createIncomplete : new boolean[] { true, false })
918 +        for (Integer v1 : new Integer[] { 1, null })
919 +    {
920 +        final AtomicInteger a = new AtomicInteger(0);
921 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
922 +        if (!createIncomplete) assertTrue(f.complete(v1));
923 +        final CompletableFuture<Integer> g = m.whenComplete
924 +            (f,
925 +             (Integer x, Throwable t) -> {
926 +                m.checkExecutionMode();
927 +                threadAssertSame(x, v1);
928 +                threadAssertNull(t);
929 +                a.getAndIncrement();
930 +            });
931 +        if (createIncomplete) assertTrue(f.complete(v1));
932 +
933 +        checkCompletedNormally(g, v1);
934 +        checkCompletedNormally(f, v1);
935 +        assertEquals(1, a.get());
936 +    }}
937 +
938 +    /**
939 +     * whenComplete action executes on exceptional completion, propagating
940 +     * source result.
941 +     */
942 +    public void testWhenComplete_exceptionalCompletion() {
943 +        for (ExecutionMode m : ExecutionMode.values())
944 +        for (boolean createIncomplete : new boolean[] { true, false })
945 +        for (Integer v1 : new Integer[] { 1, null })
946 +    {
947 +        final AtomicInteger a = new AtomicInteger(0);
948 +        final CFException ex = new CFException();
949 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
950 +        if (!createIncomplete) f.completeExceptionally(ex);
951 +        final CompletableFuture<Integer> g = m.whenComplete
952 +            (f,
953 +             (Integer x, Throwable t) -> {
954 +                m.checkExecutionMode();
955 +                threadAssertNull(x);
956 +                threadAssertSame(t, ex);
957 +                a.getAndIncrement();
958 +            });
959 +        if (createIncomplete) f.completeExceptionally(ex);
960 +
961 +        checkCompletedWithWrappedException(g, ex);
962 +        checkCompletedExceptionally(f, ex);
963 +        assertEquals(1, a.get());
964 +    }}
965 +
966 +    /**
967 +     * whenComplete action executes on cancelled source, propagating
968 +     * CancellationException.
969 +     */
970 +    public void testWhenComplete_sourceCancelled() {
971 +        for (ExecutionMode m : ExecutionMode.values())
972 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
973 +        for (boolean createIncomplete : new boolean[] { true, false })
974 +    {
975 +        final AtomicInteger a = new AtomicInteger(0);
976 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
977 +        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
978 +        final CompletableFuture<Integer> g = m.whenComplete
979 +            (f,
980 +             (Integer x, Throwable t) -> {
981 +                m.checkExecutionMode();
982 +                threadAssertNull(x);
983 +                threadAssertTrue(t instanceof CancellationException);
984 +                a.getAndIncrement();
985 +            });
986 +        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
987 +
988 +        checkCompletedWithWrappedCancellationException(g);
989 +        checkCancelled(f);
990 +        assertEquals(1, a.get());
991 +    }}
992 +
993 +    /**
994 +     * If a whenComplete action throws an exception when triggered by
995 +     * a normal completion, it completes exceptionally
996 +     */
997 +    public void testWhenComplete_actionFailed() {
998 +        for (boolean createIncomplete : new boolean[] { true, false })
999 +        for (ExecutionMode m : ExecutionMode.values())
1000 +        for (Integer v1 : new Integer[] { 1, null })
1001 +    {
1002 +        final AtomicInteger a = new AtomicInteger(0);
1003 +        final CFException ex = new CFException();
1004 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1005 +        if (!createIncomplete) assertTrue(f.complete(v1));
1006 +        final CompletableFuture<Integer> g = m.whenComplete
1007 +            (f,
1008 +             (Integer x, Throwable t) -> {
1009 +                m.checkExecutionMode();
1010 +                threadAssertSame(x, v1);
1011 +                threadAssertNull(t);
1012 +                a.getAndIncrement();
1013 +                throw ex;
1014 +            });
1015 +        if (createIncomplete) assertTrue(f.complete(v1));
1016 +
1017 +        checkCompletedWithWrappedException(g, ex);
1018 +        checkCompletedNormally(f, v1);
1019 +        assertEquals(1, a.get());
1020 +    }}
1021 +
1022 +    /**
1023 +     * If a whenComplete action throws an exception when triggered by
1024 +     * a source completion that also throws an exception, the source
1025 +     * exception takes precedence.
1026 +     */
1027 +    public void testWhenComplete_actionFailedSourceFailed() {
1028 +        for (boolean createIncomplete : new boolean[] { true, false })
1029 +        for (ExecutionMode m : ExecutionMode.values())
1030 +        for (Integer v1 : new Integer[] { 1, null })
1031 +    {
1032 +        final AtomicInteger a = new AtomicInteger(0);
1033 +        final CFException ex1 = new CFException();
1034 +        final CFException ex2 = new CFException();
1035 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1036 +
1037 +        if (!createIncomplete) f.completeExceptionally(ex1);
1038 +        final CompletableFuture<Integer> g = m.whenComplete
1039 +            (f,
1040 +             (Integer x, Throwable t) -> {
1041 +                m.checkExecutionMode();
1042                  threadAssertSame(t, ex1);
1043 +                threadAssertNull(x);
1044                  a.getAndIncrement();
1045                  throw ex2;
1046              });
1047          if (createIncomplete) f.completeExceptionally(ex1);
1048  
1049 <        checkCompletedWithWrappedCFException(g, ex2);
1049 >        checkCompletedWithWrappedException(g, ex1);
1050 >        checkCompletedExceptionally(f, ex1);
1051          assertEquals(1, a.get());
1052      }}
1053  
# Line 785 | Line 1062 | public class CompletableFutureTest exten
1062      {
1063          final CompletableFuture<Integer> f = new CompletableFuture<>();
1064          final AtomicInteger a = new AtomicInteger(0);
1065 <        if (!createIncomplete) f.complete(v1);
1065 >        if (!createIncomplete) assertTrue(f.complete(v1));
1066          final CompletableFuture<Integer> g = m.handle
1067              (f,
1068               (Integer x, Throwable t) -> {
1069 +                m.checkExecutionMode();
1070                  threadAssertSame(x, v1);
1071                  threadAssertNull(t);
1072                  a.getAndIncrement();
1073                  return inc(v1);
1074              });
1075 <        if (createIncomplete) f.complete(v1);
1075 >        if (createIncomplete) assertTrue(f.complete(v1));
1076  
1077          checkCompletedNormally(g, inc(v1));
1078          checkCompletedNormally(f, v1);
# Line 817 | Line 1095 | public class CompletableFutureTest exten
1095          final CompletableFuture<Integer> g = m.handle
1096              (f,
1097               (Integer x, Throwable t) -> {
1098 +                m.checkExecutionMode();
1099                  threadAssertNull(x);
1100                  threadAssertSame(t, ex);
1101                  a.getAndIncrement();
# Line 825 | Line 1104 | public class CompletableFutureTest exten
1104          if (createIncomplete) f.completeExceptionally(ex);
1105  
1106          checkCompletedNormally(g, v1);
1107 <        checkCompletedWithWrappedCFException(f, ex);
1107 >        checkCompletedExceptionally(f, ex);
1108          assertEquals(1, a.get());
1109      }}
1110  
# Line 845 | Line 1124 | public class CompletableFutureTest exten
1124          final CompletableFuture<Integer> g = m.handle
1125              (f,
1126               (Integer x, Throwable t) -> {
1127 +                m.checkExecutionMode();
1128                  threadAssertNull(x);
1129                  threadAssertTrue(t instanceof CancellationException);
1130                  a.getAndIncrement();
# Line 872 | Line 1152 | public class CompletableFutureTest exten
1152          final CompletableFuture<Integer> g = m.handle
1153              (f,
1154               (Integer x, Throwable t) -> {
1155 +                m.checkExecutionMode();
1156                  threadAssertNull(x);
1157                  threadAssertSame(ex1, t);
1158                  a.getAndIncrement();
# Line 879 | Line 1160 | public class CompletableFutureTest exten
1160              });
1161          if (createIncomplete) f.completeExceptionally(ex1);
1162  
1163 <        checkCompletedWithWrappedCFException(g, ex2);
1164 <        checkCompletedWithWrappedCFException(f, ex1);
1163 >        checkCompletedWithWrappedException(g, ex2);
1164 >        checkCompletedExceptionally(f, ex1);
1165          assertEquals(1, a.get());
1166      }}
1167  
# Line 892 | Line 1173 | public class CompletableFutureTest exten
1173          final CompletableFuture<Integer> f = new CompletableFuture<>();
1174          final AtomicInteger a = new AtomicInteger(0);
1175          final CFException ex = new CFException();
1176 <        if (!createIncomplete) f.complete(v1);
1176 >        if (!createIncomplete) assertTrue(f.complete(v1));
1177          final CompletableFuture<Integer> g = m.handle
1178              (f,
1179               (Integer x, Throwable t) -> {
1180 +                m.checkExecutionMode();
1181                  threadAssertSame(x, v1);
1182                  threadAssertNull(t);
1183                  a.getAndIncrement();
1184                  throw ex;
1185              });
1186 <        if (createIncomplete) f.complete(v1);
1186 >        if (createIncomplete) assertTrue(f.complete(v1));
1187  
1188 <        checkCompletedWithWrappedCFException(g, ex);
1188 >        checkCompletedWithWrappedException(g, ex);
1189          checkCompletedNormally(f, v1);
1190          assertEquals(1, a.get());
1191      }}
# Line 911 | Line 1193 | public class CompletableFutureTest exten
1193      /**
1194       * runAsync completes after running Runnable
1195       */
1196 <    public void testRunAsync() {
1197 <        Noop r = new Noop(ExecutionMode.ASYNC);
1198 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1199 <        assertNull(f.join());
1200 <        assertEquals(1, r.invocationCount);
1201 <        checkCompletedNormally(f, null);
1202 <    }
1203 <
1204 <    /**
923 <     * runAsync with executor completes after running Runnable
924 <     */
925 <    public void testRunAsync2() {
926 <        Noop r = new Noop(ExecutionMode.EXECUTOR);
927 <        ThreadExecutor exec = new ThreadExecutor();
928 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
1196 >    public void testRunAsync_normalCompletion() {
1197 >        ExecutionMode[] executionModes = {
1198 >            ExecutionMode.ASYNC,
1199 >            ExecutionMode.EXECUTOR,
1200 >        };
1201 >        for (ExecutionMode m : executionModes)
1202 >    {
1203 >        final Noop r = new Noop(m);
1204 >        final CompletableFuture<Void> f = m.runAsync(r);
1205          assertNull(f.join());
930        assertEquals(1, r.invocationCount);
1206          checkCompletedNormally(f, null);
1207 <        assertEquals(1, exec.count.get());
1208 <    }
1207 >        r.assertInvoked();
1208 >    }}
1209  
1210      /**
1211       * failing runAsync completes exceptionally after running Runnable
1212       */
1213 <    public void testRunAsync3() {
1214 <        FailingRunnable r = new FailingRunnable();
1215 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1213 >    public void testRunAsync_exceptionalCompletion() {
1214 >        ExecutionMode[] executionModes = {
1215 >            ExecutionMode.ASYNC,
1216 >            ExecutionMode.EXECUTOR,
1217 >        };
1218 >        for (ExecutionMode m : executionModes)
1219 >    {
1220 >        final FailingRunnable r = new FailingRunnable(m);
1221 >        final CompletableFuture<Void> f = m.runAsync(r);
1222          checkCompletedWithWrappedCFException(f);
1223 <        assertEquals(1, r.invocationCount);
1224 <    }
1223 >        r.assertInvoked();
1224 >    }}
1225  
1226      /**
1227       * supplyAsync completes with result of supplier
1228       */
1229 <    public void testSupplyAsync() {
1230 <        CompletableFuture<Integer> f;
1231 <        f = CompletableFuture.supplyAsync(supplyOne);
1232 <        assertEquals(f.join(), one);
1233 <        checkCompletedNormally(f, one);
1234 <    }
1235 <
1236 <    /**
1237 <     * supplyAsync with executor completes with result of supplier
1238 <     */
1239 <    public void testSupplyAsync2() {
1240 <        CompletableFuture<Integer> f;
1241 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
1242 <        assertEquals(f.join(), one);
962 <        checkCompletedNormally(f, one);
963 <    }
1229 >    public void testSupplyAsync_normalCompletion() {
1230 >        ExecutionMode[] executionModes = {
1231 >            ExecutionMode.ASYNC,
1232 >            ExecutionMode.EXECUTOR,
1233 >        };
1234 >        for (ExecutionMode m : executionModes)
1235 >        for (Integer v1 : new Integer[] { 1, null })
1236 >    {
1237 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1238 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1239 >        assertSame(v1, f.join());
1240 >        checkCompletedNormally(f, v1);
1241 >        r.assertInvoked();
1242 >    }}
1243  
1244      /**
1245       * Failing supplyAsync completes exceptionally
1246       */
1247 <    public void testSupplyAsync3() {
1248 <        FailingSupplier r = new FailingSupplier();
1249 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1247 >    public void testSupplyAsync_exceptionalCompletion() {
1248 >        ExecutionMode[] executionModes = {
1249 >            ExecutionMode.ASYNC,
1250 >            ExecutionMode.EXECUTOR,
1251 >        };
1252 >        for (ExecutionMode m : executionModes)
1253 >    {
1254 >        FailingSupplier r = new FailingSupplier(m);
1255 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1256          checkCompletedWithWrappedCFException(f);
1257 <        assertEquals(1, r.invocationCount);
1258 <    }
1257 >        r.assertInvoked();
1258 >    }}
1259  
1260      // seq completion methods
1261  
# Line 984 | Line 1269 | public class CompletableFutureTest exten
1269      {
1270          final CompletableFuture<Integer> f = new CompletableFuture<>();
1271          final Noop r = new Noop(m);
1272 <        if (!createIncomplete) f.complete(v1);
1272 >        if (!createIncomplete) assertTrue(f.complete(v1));
1273          final CompletableFuture<Void> g = m.thenRun(f, r);
1274          if (createIncomplete) {
1275              checkIncomplete(g);
1276 <            f.complete(v1);
1276 >            assertTrue(f.complete(v1));
1277          }
1278  
1279          checkCompletedNormally(g, null);
1280          checkCompletedNormally(f, v1);
1281 <        assertEquals(1, r.invocationCount);
1281 >        r.assertInvoked();
1282      }}
1283  
1284      /**
# Line 1014 | Line 1299 | public class CompletableFutureTest exten
1299              f.completeExceptionally(ex);
1300          }
1301  
1302 <        checkCompletedWithWrappedCFException(g, ex);
1303 <        checkCompletedWithWrappedCFException(f, ex);
1304 <        assertEquals(0, r.invocationCount);
1302 >        checkCompletedWithWrappedException(g, ex);
1303 >        checkCompletedExceptionally(f, ex);
1304 >        r.assertNotInvoked();
1305      }}
1306  
1307      /**
# Line 1030 | Line 1315 | public class CompletableFutureTest exten
1315          final CompletableFuture<Integer> f = new CompletableFuture<>();
1316          final Noop r = new Noop(m);
1317          if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1318 <        final CompletableFuture<Void> g = f.thenRun(r);
1318 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1319          if (createIncomplete) {
1320              checkIncomplete(g);
1321              assertTrue(f.cancel(mayInterruptIfRunning));
# Line 1038 | Line 1323 | public class CompletableFutureTest exten
1323  
1324          checkCompletedWithWrappedCancellationException(g);
1325          checkCancelled(f);
1326 <        assertEquals(0, r.invocationCount);
1326 >        r.assertNotInvoked();
1327      }}
1328  
1329      /**
# Line 1050 | Line 1335 | public class CompletableFutureTest exten
1335          for (Integer v1 : new Integer[] { 1, null })
1336      {
1337          final CompletableFuture<Integer> f = new CompletableFuture<>();
1338 <        final FailingRunnable r = new FailingRunnable();
1339 <        if (!createIncomplete) f.complete(v1);
1340 <        final CompletableFuture<Void> g = f.thenRun(r);
1338 >        final FailingRunnable r = new FailingRunnable(m);
1339 >        if (!createIncomplete) assertTrue(f.complete(v1));
1340 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1341          if (createIncomplete) {
1342              checkIncomplete(g);
1343 <            f.complete(v1);
1343 >            assertTrue(f.complete(v1));
1344          }
1345  
1346          checkCompletedWithWrappedCFException(g);
# Line 1071 | Line 1356 | public class CompletableFutureTest exten
1356          for (Integer v1 : new Integer[] { 1, null })
1357      {
1358          final CompletableFuture<Integer> f = new CompletableFuture<>();
1359 <        final IncFunction r = new IncFunction();
1360 <        if (!createIncomplete) f.complete(v1);
1359 >        final IncFunction r = new IncFunction(m);
1360 >        if (!createIncomplete) assertTrue(f.complete(v1));
1361          final CompletableFuture<Integer> g = m.thenApply(f, r);
1362          if (createIncomplete) {
1363              checkIncomplete(g);
1364 <            f.complete(v1);
1364 >            assertTrue(f.complete(v1));
1365          }
1366  
1367          checkCompletedNormally(g, inc(v1));
1368          checkCompletedNormally(f, v1);
1369 <        assertEquals(1, r.invocationCount);
1369 >        r.assertValue(inc(v1));
1370      }}
1371  
1372      /**
# Line 1094 | Line 1379 | public class CompletableFutureTest exten
1379      {
1380          final CFException ex = new CFException();
1381          final CompletableFuture<Integer> f = new CompletableFuture<>();
1382 <        final IncFunction r = new IncFunction();
1382 >        final IncFunction r = new IncFunction(m);
1383          if (!createIncomplete) f.completeExceptionally(ex);
1384          final CompletableFuture<Integer> g = m.thenApply(f, r);
1385          if (createIncomplete) {
# Line 1102 | Line 1387 | public class CompletableFutureTest exten
1387              f.completeExceptionally(ex);
1388          }
1389  
1390 <        checkCompletedWithWrappedCFException(g, ex);
1391 <        checkCompletedWithWrappedCFException(f, ex);
1392 <        assertEquals(0, r.invocationCount);
1390 >        checkCompletedWithWrappedException(g, ex);
1391 >        checkCompletedExceptionally(f, ex);
1392 >        r.assertNotInvoked();
1393      }}
1394  
1395      /**
# Line 1116 | Line 1401 | public class CompletableFutureTest exten
1401          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1402      {
1403          final CompletableFuture<Integer> f = new CompletableFuture<>();
1404 <        final IncFunction r = new IncFunction();
1404 >        final IncFunction r = new IncFunction(m);
1405          if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1406 <        final CompletableFuture<Integer> g = f.thenApply(r);
1406 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1407          if (createIncomplete) {
1408              checkIncomplete(g);
1409              assertTrue(f.cancel(mayInterruptIfRunning));
# Line 1126 | Line 1411 | public class CompletableFutureTest exten
1411  
1412          checkCompletedWithWrappedCancellationException(g);
1413          checkCancelled(f);
1414 <        assertEquals(0, r.invocationCount);
1414 >        r.assertNotInvoked();
1415      }}
1416  
1417      /**
# Line 1138 | Line 1423 | public class CompletableFutureTest exten
1423          for (Integer v1 : new Integer[] { 1, null })
1424      {
1425          final CompletableFuture<Integer> f = new CompletableFuture<>();
1426 <        final FailingFunction r = new FailingFunction();
1427 <        if (!createIncomplete) f.complete(v1);
1428 <        final CompletableFuture<Integer> g = f.thenApply(r);
1426 >        final FailingFunction r = new FailingFunction(m);
1427 >        if (!createIncomplete) assertTrue(f.complete(v1));
1428 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1429          if (createIncomplete) {
1430              checkIncomplete(g);
1431 <            f.complete(v1);
1431 >            assertTrue(f.complete(v1));
1432          }
1433  
1434          checkCompletedWithWrappedCFException(g);
# Line 1159 | Line 1444 | public class CompletableFutureTest exten
1444          for (Integer v1 : new Integer[] { 1, null })
1445      {
1446          final CompletableFuture<Integer> f = new CompletableFuture<>();
1447 <        final IncAction r = new IncAction();
1448 <        if (!createIncomplete) f.complete(v1);
1447 >        final NoopConsumer r = new NoopConsumer(m);
1448 >        if (!createIncomplete) assertTrue(f.complete(v1));
1449          final CompletableFuture<Void> g = m.thenAccept(f, r);
1450          if (createIncomplete) {
1451              checkIncomplete(g);
1452 <            f.complete(v1);
1452 >            assertTrue(f.complete(v1));
1453          }
1454  
1455          checkCompletedNormally(g, null);
1456 +        r.assertValue(v1);
1457          checkCompletedNormally(f, v1);
1172        assertEquals(1, r.invocationCount);
1173        assertEquals(inc(v1), r.value);
1458      }}
1459  
1460      /**
# Line 1183 | Line 1467 | public class CompletableFutureTest exten
1467      {
1468          final CFException ex = new CFException();
1469          final CompletableFuture<Integer> f = new CompletableFuture<>();
1470 <        final IncAction r = new IncAction();
1470 >        final NoopConsumer r = new NoopConsumer(m);
1471          if (!createIncomplete) f.completeExceptionally(ex);
1472          final CompletableFuture<Void> g = m.thenAccept(f, r);
1473          if (createIncomplete) {
# Line 1191 | Line 1475 | public class CompletableFutureTest exten
1475              f.completeExceptionally(ex);
1476          }
1477  
1478 <        checkCompletedWithWrappedCFException(g, ex);
1479 <        checkCompletedWithWrappedCFException(f, ex);
1480 <        assertEquals(0, r.invocationCount);
1478 >        checkCompletedWithWrappedException(g, ex);
1479 >        checkCompletedExceptionally(f, ex);
1480 >        r.assertNotInvoked();
1481      }}
1482  
1483      /**
1484 <     * thenAccept result completes exceptionally if action does
1484 >     * thenAccept result completes exceptionally if source cancelled
1485       */
1486 <    public void testThenAccept_actionFailed() {
1486 >    public void testThenAccept_sourceCancelled() {
1487          for (ExecutionMode m : ExecutionMode.values())
1488          for (boolean createIncomplete : new boolean[] { true, false })
1489 <        for (Integer v1 : new Integer[] { 1, null })
1489 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1490      {
1491          final CompletableFuture<Integer> f = new CompletableFuture<>();
1492 <        final FailingConsumer r = new FailingConsumer();
1493 <        if (!createIncomplete) f.complete(v1);
1494 <        final CompletableFuture<Void> g = f.thenAccept(r);
1492 >        final NoopConsumer r = new NoopConsumer(m);
1493 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1494 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1495          if (createIncomplete) {
1496              checkIncomplete(g);
1497 <            f.complete(v1);
1497 >            assertTrue(f.cancel(mayInterruptIfRunning));
1498          }
1499  
1500 <        checkCompletedWithWrappedCFException(g);
1501 <        checkCompletedNormally(f, v1);
1500 >        checkCompletedWithWrappedCancellationException(g);
1501 >        checkCancelled(f);
1502 >        r.assertNotInvoked();
1503      }}
1504  
1505      /**
1506 <     * thenAccept result completes exceptionally if source cancelled
1506 >     * thenAccept result completes exceptionally if action does
1507       */
1508 <    public void testThenAccept_sourceCancelled() {
1508 >    public void testThenAccept_actionFailed() {
1509          for (ExecutionMode m : ExecutionMode.values())
1510          for (boolean createIncomplete : new boolean[] { true, false })
1511 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1511 >        for (Integer v1 : new Integer[] { 1, null })
1512      {
1513          final CompletableFuture<Integer> f = new CompletableFuture<>();
1514 <        final IncAction r = new IncAction();
1515 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1516 <        final CompletableFuture<Void> g = f.thenAccept(r);
1514 >        final FailingConsumer r = new FailingConsumer(m);
1515 >        if (!createIncomplete) f.complete(v1);
1516 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1517          if (createIncomplete) {
1518              checkIncomplete(g);
1519 <            assertTrue(f.cancel(mayInterruptIfRunning));
1519 >            f.complete(v1);
1520          }
1521  
1522 <        checkCompletedWithWrappedCancellationException(g);
1523 <        checkCancelled(f);
1239 <        assertEquals(0, r.invocationCount);
1522 >        checkCompletedWithWrappedCFException(g);
1523 >        checkCompletedNormally(f, v1);
1524      }}
1525  
1526      /**
# Line 1245 | Line 1529 | public class CompletableFutureTest exten
1529       */
1530      public void testThenCombine_normalCompletion() {
1531          for (ExecutionMode m : ExecutionMode.values())
1248        for (boolean createIncomplete : new boolean[] { true, false })
1532          for (boolean fFirst : new boolean[] { true, false })
1533          for (Integer v1 : new Integer[] { 1, null })
1534          for (Integer v2 : new Integer[] { 2, null })
1535      {
1536          final CompletableFuture<Integer> f = new CompletableFuture<>();
1537          final CompletableFuture<Integer> g = new CompletableFuture<>();
1538 <        final SubtractFunction r = new SubtractFunction();
1539 <
1540 <        if (fFirst) f.complete(v1); else g.complete(v2);
1541 <        if (!createIncomplete)
1542 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1543 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1544 <        if (createIncomplete) {
1545 <            checkIncomplete(h);
1546 <            assertEquals(0, r.invocationCount);
1547 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1548 <        }
1549 <
1550 <        checkCompletedNormally(h, subtract(v1, v2));
1538 >        final SubtractFunction r1 = new SubtractFunction(m);
1539 >        final SubtractFunction r2 = new SubtractFunction(m);
1540 >        final SubtractFunction r3 = new SubtractFunction(m);
1541 >
1542 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1543 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1544 >        final Integer w1 =  fFirst ? v1 : v2;
1545 >        final Integer w2 = !fFirst ? v1 : v2;
1546 >
1547 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1548 >        assertTrue(fst.complete(w1));
1549 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1550 >        checkIncomplete(h1);
1551 >        checkIncomplete(h2);
1552 >        r1.assertNotInvoked();
1553 >        r2.assertNotInvoked();
1554 >        assertTrue(snd.complete(w2));
1555 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1556 >
1557 >        checkCompletedNormally(h1, subtract(v1, v2));
1558 >        checkCompletedNormally(h2, subtract(v1, v2));
1559 >        checkCompletedNormally(h3, subtract(v1, v2));
1560 >        r1.assertValue(subtract(v1, v2));
1561 >        r2.assertValue(subtract(v1, v2));
1562 >        r3.assertValue(subtract(v1, v2));
1563          checkCompletedNormally(f, v1);
1564          checkCompletedNormally(g, v2);
1270        assertEquals(1, r.invocationCount);
1565      }}
1566  
1567      /**
1568       * thenCombine result completes exceptionally after exceptional
1569       * completion of either source
1570       */
1571 <    public void testThenCombine_exceptionalCompletion() {
1571 >    public void testThenCombine_exceptionalCompletion() throws Throwable {
1572          for (ExecutionMode m : ExecutionMode.values())
1279        for (boolean createIncomplete : new boolean[] { true, false })
1573          for (boolean fFirst : new boolean[] { true, false })
1574 +        for (boolean failFirst : new boolean[] { true, false })
1575          for (Integer v1 : new Integer[] { 1, null })
1576      {
1577          final CompletableFuture<Integer> f = new CompletableFuture<>();
1578          final CompletableFuture<Integer> g = new CompletableFuture<>();
1579          final CFException ex = new CFException();
1580 <        final SubtractFunction r = new SubtractFunction();
1581 <
1582 <        (fFirst ? f : g).complete(v1);
1583 <        if (!createIncomplete)
1584 <            (!fFirst ? f : g).completeExceptionally(ex);
1585 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1586 <        if (createIncomplete) {
1587 <            checkIncomplete(h);
1588 <            (!fFirst ? f : g).completeExceptionally(ex);
1589 <        }
1590 <
1591 <        checkCompletedWithWrappedCFException(h, ex);
1592 <        assertEquals(0, r.invocationCount);
1593 <        checkCompletedNormally(fFirst ? f : g, v1);
1594 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1580 >        final SubtractFunction r1 = new SubtractFunction(m);
1581 >        final SubtractFunction r2 = new SubtractFunction(m);
1582 >        final SubtractFunction r3 = new SubtractFunction(m);
1583 >
1584 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1585 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1586 >        final Callable<Boolean> complete1 = failFirst ?
1587 >            () -> fst.completeExceptionally(ex) :
1588 >            () -> fst.complete(v1);
1589 >        final Callable<Boolean> complete2 = failFirst ?
1590 >            () -> snd.complete(v1) :
1591 >            () -> snd.completeExceptionally(ex);
1592 >
1593 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1594 >        assertTrue(complete1.call());
1595 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1596 >        checkIncomplete(h1);
1597 >        checkIncomplete(h2);
1598 >        assertTrue(complete2.call());
1599 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1600 >
1601 >        checkCompletedWithWrappedException(h1, ex);
1602 >        checkCompletedWithWrappedException(h2, ex);
1603 >        checkCompletedWithWrappedException(h3, ex);
1604 >        r1.assertNotInvoked();
1605 >        r2.assertNotInvoked();
1606 >        r3.assertNotInvoked();
1607 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1608 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1609      }}
1610  
1611      /**
1612 <     * thenCombine result completes exceptionally if action does
1612 >     * thenCombine result completes exceptionally if either source cancelled
1613       */
1614 <    public void testThenCombine_actionFailed() {
1614 >    public void testThenCombine_sourceCancelled() throws Throwable {
1615          for (ExecutionMode m : ExecutionMode.values())
1616 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1617          for (boolean fFirst : new boolean[] { true, false })
1618 +        for (boolean failFirst : new boolean[] { true, false })
1619          for (Integer v1 : new Integer[] { 1, null })
1310        for (Integer v2 : new Integer[] { 2, null })
1620      {
1621          final CompletableFuture<Integer> f = new CompletableFuture<>();
1622          final CompletableFuture<Integer> g = new CompletableFuture<>();
1623 <        final FailingBiFunction r = new FailingBiFunction();
1624 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1625 <
1626 <        if (fFirst) {
1627 <            f.complete(v1);
1628 <            g.complete(v2);
1629 <        } else {
1630 <            g.complete(v2);
1631 <            f.complete(v1);
1632 <        }
1633 <
1634 <        checkCompletedWithWrappedCFException(h);
1635 <        checkCompletedNormally(f, v1);
1636 <        checkCompletedNormally(g, v2);
1623 >        final SubtractFunction r1 = new SubtractFunction(m);
1624 >        final SubtractFunction r2 = new SubtractFunction(m);
1625 >        final SubtractFunction r3 = new SubtractFunction(m);
1626 >
1627 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1628 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1629 >        final Callable<Boolean> complete1 = failFirst ?
1630 >            () -> fst.cancel(mayInterruptIfRunning) :
1631 >            () -> fst.complete(v1);
1632 >        final Callable<Boolean> complete2 = failFirst ?
1633 >            () -> snd.complete(v1) :
1634 >            () -> snd.cancel(mayInterruptIfRunning);
1635 >
1636 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1637 >        assertTrue(complete1.call());
1638 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1639 >        checkIncomplete(h1);
1640 >        checkIncomplete(h2);
1641 >        assertTrue(complete2.call());
1642 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1643 >
1644 >        checkCompletedWithWrappedCancellationException(h1);
1645 >        checkCompletedWithWrappedCancellationException(h2);
1646 >        checkCompletedWithWrappedCancellationException(h3);
1647 >        r1.assertNotInvoked();
1648 >        r2.assertNotInvoked();
1649 >        r3.assertNotInvoked();
1650 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1651 >        checkCancelled(failFirst ? fst : snd);
1652      }}
1653  
1654      /**
1655 <     * thenCombine result completes exceptionally if either source cancelled
1655 >     * thenCombine result completes exceptionally if action does
1656       */
1657 <    public void testThenCombine_sourceCancelled() {
1657 >    public void testThenCombine_actionFailed() {
1658          for (ExecutionMode m : ExecutionMode.values())
1335        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1336        for (boolean createIncomplete : new boolean[] { true, false })
1659          for (boolean fFirst : new boolean[] { true, false })
1660          for (Integer v1 : new Integer[] { 1, null })
1661 +        for (Integer v2 : new Integer[] { 2, null })
1662      {
1663          final CompletableFuture<Integer> f = new CompletableFuture<>();
1664          final CompletableFuture<Integer> g = new CompletableFuture<>();
1665 <        final SubtractFunction r = new SubtractFunction();
1665 >        final FailingBiFunction r1 = new FailingBiFunction(m);
1666 >        final FailingBiFunction r2 = new FailingBiFunction(m);
1667 >        final FailingBiFunction r3 = new FailingBiFunction(m);
1668 >
1669 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1670 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1671 >        final Integer w1 =  fFirst ? v1 : v2;
1672 >        final Integer w2 = !fFirst ? v1 : v2;
1673 >
1674 >        final CompletableFuture<Integer> h1 = m.thenCombine(f, g, r1);
1675 >        assertTrue(fst.complete(w1));
1676 >        final CompletableFuture<Integer> h2 = m.thenCombine(f, g, r2);
1677 >        assertTrue(snd.complete(w2));
1678 >        final CompletableFuture<Integer> h3 = m.thenCombine(f, g, r3);
1679  
1680 <        (fFirst ? f : g).complete(v1);
1681 <        if (!createIncomplete)
1682 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1683 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1684 <        if (createIncomplete) {
1685 <            checkIncomplete(h);
1686 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1687 <        }
1352 <
1353 <        checkCompletedWithWrappedCancellationException(h);
1354 <        checkCancelled(!fFirst ? f : g);
1355 <        assertEquals(0, r.invocationCount);
1356 <        checkCompletedNormally(fFirst ? f : g, v1);
1680 >        checkCompletedWithWrappedCFException(h1);
1681 >        checkCompletedWithWrappedCFException(h2);
1682 >        checkCompletedWithWrappedCFException(h3);
1683 >        r1.assertInvoked();
1684 >        r2.assertInvoked();
1685 >        r3.assertInvoked();
1686 >        checkCompletedNormally(f, v1);
1687 >        checkCompletedNormally(g, v2);
1688      }}
1689  
1690      /**
# Line 1362 | Line 1693 | public class CompletableFutureTest exten
1693       */
1694      public void testThenAcceptBoth_normalCompletion() {
1695          for (ExecutionMode m : ExecutionMode.values())
1365        for (boolean createIncomplete : new boolean[] { true, false })
1696          for (boolean fFirst : new boolean[] { true, false })
1697          for (Integer v1 : new Integer[] { 1, null })
1698          for (Integer v2 : new Integer[] { 2, null })
1699      {
1700          final CompletableFuture<Integer> f = new CompletableFuture<>();
1701          final CompletableFuture<Integer> g = new CompletableFuture<>();
1702 <        final SubtractAction r = new SubtractAction();
1703 <
1704 <        if (fFirst) f.complete(v1); else g.complete(v2);
1705 <        if (!createIncomplete)
1706 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1707 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1708 <        if (createIncomplete) {
1709 <            checkIncomplete(h);
1710 <            assertEquals(0, r.invocationCount);
1711 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1712 <        }
1713 <
1714 <        checkCompletedNormally(h, null);
1715 <        assertEquals(subtract(v1, v2), r.value);
1702 >        final SubtractAction r1 = new SubtractAction(m);
1703 >        final SubtractAction r2 = new SubtractAction(m);
1704 >        final SubtractAction r3 = new SubtractAction(m);
1705 >
1706 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1707 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1708 >        final Integer w1 =  fFirst ? v1 : v2;
1709 >        final Integer w2 = !fFirst ? v1 : v2;
1710 >
1711 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1712 >        assertTrue(fst.complete(w1));
1713 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1714 >        checkIncomplete(h1);
1715 >        checkIncomplete(h2);
1716 >        r1.assertNotInvoked();
1717 >        r2.assertNotInvoked();
1718 >        assertTrue(snd.complete(w2));
1719 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1720 >
1721 >        checkCompletedNormally(h1, null);
1722 >        checkCompletedNormally(h2, null);
1723 >        checkCompletedNormally(h3, null);
1724 >        r1.assertValue(subtract(v1, v2));
1725 >        r2.assertValue(subtract(v1, v2));
1726 >        r3.assertValue(subtract(v1, v2));
1727          checkCompletedNormally(f, v1);
1728          checkCompletedNormally(g, v2);
1729      }}
# Line 1391 | Line 1732 | public class CompletableFutureTest exten
1732       * thenAcceptBoth result completes exceptionally after exceptional
1733       * completion of either source
1734       */
1735 <    public void testThenAcceptBoth_exceptionalCompletion() {
1735 >    public void testThenAcceptBoth_exceptionalCompletion() throws Throwable {
1736          for (ExecutionMode m : ExecutionMode.values())
1396        for (boolean createIncomplete : new boolean[] { true, false })
1737          for (boolean fFirst : new boolean[] { true, false })
1738 +        for (boolean failFirst : new boolean[] { true, false })
1739          for (Integer v1 : new Integer[] { 1, null })
1740      {
1741          final CompletableFuture<Integer> f = new CompletableFuture<>();
1742          final CompletableFuture<Integer> g = new CompletableFuture<>();
1743          final CFException ex = new CFException();
1744 <        final SubtractAction r = new SubtractAction();
1745 <
1746 <        (fFirst ? f : g).complete(v1);
1747 <        if (!createIncomplete)
1748 <            (!fFirst ? f : g).completeExceptionally(ex);
1749 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1750 <        if (createIncomplete) {
1751 <            checkIncomplete(h);
1752 <            (!fFirst ? f : g).completeExceptionally(ex);
1753 <        }
1754 <
1755 <        checkCompletedWithWrappedCFException(h, ex);
1756 <        assertEquals(0, r.invocationCount);
1757 <        checkCompletedNormally(fFirst ? f : g, v1);
1758 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1744 >        final SubtractAction r1 = new SubtractAction(m);
1745 >        final SubtractAction r2 = new SubtractAction(m);
1746 >        final SubtractAction r3 = new SubtractAction(m);
1747 >
1748 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1749 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1750 >        final Callable<Boolean> complete1 = failFirst ?
1751 >            () -> fst.completeExceptionally(ex) :
1752 >            () -> fst.complete(v1);
1753 >        final Callable<Boolean> complete2 = failFirst ?
1754 >            () -> snd.complete(v1) :
1755 >            () -> snd.completeExceptionally(ex);
1756 >
1757 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1758 >        assertTrue(complete1.call());
1759 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1760 >        checkIncomplete(h1);
1761 >        checkIncomplete(h2);
1762 >        assertTrue(complete2.call());
1763 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1764 >
1765 >        checkCompletedWithWrappedException(h1, ex);
1766 >        checkCompletedWithWrappedException(h2, ex);
1767 >        checkCompletedWithWrappedException(h3, ex);
1768 >        r1.assertNotInvoked();
1769 >        r2.assertNotInvoked();
1770 >        r3.assertNotInvoked();
1771 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1772 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1773      }}
1774  
1775      /**
1776 <     * thenAcceptBoth result completes exceptionally if action does
1776 >     * thenAcceptBoth result completes exceptionally if either source cancelled
1777       */
1778 <    public void testThenAcceptBoth_actionFailed() {
1778 >    public void testThenAcceptBoth_sourceCancelled() throws Throwable {
1779          for (ExecutionMode m : ExecutionMode.values())
1780 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1781          for (boolean fFirst : new boolean[] { true, false })
1782 +        for (boolean failFirst : new boolean[] { true, false })
1783          for (Integer v1 : new Integer[] { 1, null })
1427        for (Integer v2 : new Integer[] { 2, null })
1784      {
1785          final CompletableFuture<Integer> f = new CompletableFuture<>();
1786          final CompletableFuture<Integer> g = new CompletableFuture<>();
1787 <        final FailingBiConsumer r = new FailingBiConsumer();
1788 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1789 <
1790 <        if (fFirst) {
1791 <            f.complete(v1);
1792 <            g.complete(v2);
1793 <        } else {
1794 <            g.complete(v2);
1795 <            f.complete(v1);
1796 <        }
1797 <
1798 <        checkCompletedWithWrappedCFException(h);
1799 <        checkCompletedNormally(f, v1);
1800 <        checkCompletedNormally(g, v2);
1787 >        final SubtractAction r1 = new SubtractAction(m);
1788 >        final SubtractAction r2 = new SubtractAction(m);
1789 >        final SubtractAction r3 = new SubtractAction(m);
1790 >
1791 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1792 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1793 >        final Callable<Boolean> complete1 = failFirst ?
1794 >            () -> fst.cancel(mayInterruptIfRunning) :
1795 >            () -> fst.complete(v1);
1796 >        final Callable<Boolean> complete2 = failFirst ?
1797 >            () -> snd.complete(v1) :
1798 >            () -> snd.cancel(mayInterruptIfRunning);
1799 >
1800 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1801 >        assertTrue(complete1.call());
1802 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1803 >        checkIncomplete(h1);
1804 >        checkIncomplete(h2);
1805 >        assertTrue(complete2.call());
1806 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1807 >
1808 >        checkCompletedWithWrappedCancellationException(h1);
1809 >        checkCompletedWithWrappedCancellationException(h2);
1810 >        checkCompletedWithWrappedCancellationException(h3);
1811 >        r1.assertNotInvoked();
1812 >        r2.assertNotInvoked();
1813 >        r3.assertNotInvoked();
1814 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1815 >        checkCancelled(failFirst ? fst : snd);
1816      }}
1817  
1818      /**
1819 <     * thenAcceptBoth result completes exceptionally if either source cancelled
1819 >     * thenAcceptBoth result completes exceptionally if action does
1820       */
1821 <    public void testThenAcceptBoth_sourceCancelled() {
1821 >    public void testThenAcceptBoth_actionFailed() {
1822          for (ExecutionMode m : ExecutionMode.values())
1452        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1453        for (boolean createIncomplete : new boolean[] { true, false })
1823          for (boolean fFirst : new boolean[] { true, false })
1824          for (Integer v1 : new Integer[] { 1, null })
1825 +        for (Integer v2 : new Integer[] { 2, null })
1826      {
1827          final CompletableFuture<Integer> f = new CompletableFuture<>();
1828          final CompletableFuture<Integer> g = new CompletableFuture<>();
1829 <        final SubtractAction r = new SubtractAction();
1830 <
1831 <        (fFirst ? f : g).complete(v1);
1832 <        if (!createIncomplete)
1833 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1834 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1835 <        if (createIncomplete) {
1836 <            checkIncomplete(h);
1837 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1838 <        }
1829 >        final FailingBiConsumer r1 = new FailingBiConsumer(m);
1830 >        final FailingBiConsumer r2 = new FailingBiConsumer(m);
1831 >        final FailingBiConsumer r3 = new FailingBiConsumer(m);
1832 >
1833 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1834 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1835 >        final Integer w1 =  fFirst ? v1 : v2;
1836 >        final Integer w2 = !fFirst ? v1 : v2;
1837 >
1838 >        final CompletableFuture<Void> h1 = m.thenAcceptBoth(f, g, r1);
1839 >        assertTrue(fst.complete(w1));
1840 >        final CompletableFuture<Void> h2 = m.thenAcceptBoth(f, g, r2);
1841 >        assertTrue(snd.complete(w2));
1842 >        final CompletableFuture<Void> h3 = m.thenAcceptBoth(f, g, r3);
1843  
1844 <        checkCompletedWithWrappedCancellationException(h);
1845 <        checkCancelled(!fFirst ? f : g);
1846 <        assertEquals(0, r.invocationCount);
1847 <        checkCompletedNormally(fFirst ? f : g, v1);
1844 >        checkCompletedWithWrappedCFException(h1);
1845 >        checkCompletedWithWrappedCFException(h2);
1846 >        checkCompletedWithWrappedCFException(h3);
1847 >        r1.assertInvoked();
1848 >        r2.assertInvoked();
1849 >        r3.assertInvoked();
1850 >        checkCompletedNormally(f, v1);
1851 >        checkCompletedNormally(g, v2);
1852      }}
1853  
1854      /**
# Line 1479 | Line 1857 | public class CompletableFutureTest exten
1857       */
1858      public void testRunAfterBoth_normalCompletion() {
1859          for (ExecutionMode m : ExecutionMode.values())
1482        for (boolean createIncomplete : new boolean[] { true, false })
1860          for (boolean fFirst : new boolean[] { true, false })
1861          for (Integer v1 : new Integer[] { 1, null })
1862          for (Integer v2 : new Integer[] { 2, null })
1863      {
1864          final CompletableFuture<Integer> f = new CompletableFuture<>();
1865          final CompletableFuture<Integer> g = new CompletableFuture<>();
1866 <        final Noop r = new Noop(m);
1867 <
1868 <        if (fFirst) f.complete(v1); else g.complete(v2);
1869 <        if (!createIncomplete)
1870 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1871 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1872 <        if (createIncomplete) {
1873 <            checkIncomplete(h);
1874 <            assertEquals(0, r.invocationCount);
1875 <            if (!fFirst) f.complete(v1); else g.complete(v2);
1876 <        }
1877 <
1878 <        checkCompletedNormally(h, null);
1879 <        assertEquals(1, r.invocationCount);
1866 >        final Noop r1 = new Noop(m);
1867 >        final Noop r2 = new Noop(m);
1868 >        final Noop r3 = new Noop(m);
1869 >
1870 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1871 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1872 >        final Integer w1 =  fFirst ? v1 : v2;
1873 >        final Integer w2 = !fFirst ? v1 : v2;
1874 >
1875 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1876 >        assertTrue(fst.complete(w1));
1877 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1878 >        checkIncomplete(h1);
1879 >        checkIncomplete(h2);
1880 >        r1.assertNotInvoked();
1881 >        r2.assertNotInvoked();
1882 >        assertTrue(snd.complete(w2));
1883 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
1884 >
1885 >        checkCompletedNormally(h1, null);
1886 >        checkCompletedNormally(h2, null);
1887 >        checkCompletedNormally(h3, null);
1888 >        r1.assertInvoked();
1889 >        r2.assertInvoked();
1890 >        r3.assertInvoked();
1891          checkCompletedNormally(f, v1);
1892          checkCompletedNormally(g, v2);
1893      }}
# Line 1508 | Line 1896 | public class CompletableFutureTest exten
1896       * runAfterBoth result completes exceptionally after exceptional
1897       * completion of either source
1898       */
1899 <    public void testRunAfterBoth_exceptionalCompletion() {
1899 >    public void testRunAfterBoth_exceptionalCompletion() throws Throwable {
1900          for (ExecutionMode m : ExecutionMode.values())
1513        for (boolean createIncomplete : new boolean[] { true, false })
1901          for (boolean fFirst : new boolean[] { true, false })
1902 +        for (boolean failFirst : new boolean[] { true, false })
1903          for (Integer v1 : new Integer[] { 1, null })
1904      {
1905          final CompletableFuture<Integer> f = new CompletableFuture<>();
1906          final CompletableFuture<Integer> g = new CompletableFuture<>();
1907          final CFException ex = new CFException();
1908 <        final Noop r = new Noop(m);
1909 <
1910 <        (fFirst ? f : g).complete(v1);
1911 <        if (!createIncomplete)
1912 <            (!fFirst ? f : g).completeExceptionally(ex);
1913 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1914 <        if (createIncomplete) {
1915 <            checkIncomplete(h);
1916 <            (!fFirst ? f : g).completeExceptionally(ex);
1917 <        }
1918 <
1919 <        checkCompletedWithWrappedCFException(h, ex);
1920 <        assertEquals(0, r.invocationCount);
1921 <        checkCompletedNormally(fFirst ? f : g, v1);
1922 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1923 <    }}
1924 <
1925 <    /**
1926 <     * runAfterBoth result completes exceptionally if action does
1927 <     */
1928 <    public void testRunAfterBoth_actionFailed() {
1929 <        for (ExecutionMode m : ExecutionMode.values())
1930 <        for (boolean fFirst : new boolean[] { true, false })
1931 <        for (Integer v1 : new Integer[] { 1, null })
1932 <        for (Integer v2 : new Integer[] { 2, null })
1933 <    {
1934 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1935 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1936 <        final FailingRunnable r = new FailingRunnable();
1549 <
1550 <        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1551 <        if (fFirst) {
1552 <            f.complete(v1);
1553 <            g.complete(v2);
1554 <        } else {
1555 <            g.complete(v2);
1556 <            f.complete(v1);
1557 <        }
1558 <        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1559 <
1560 <        checkCompletedWithWrappedCFException(h1);
1561 <        checkCompletedWithWrappedCFException(h2);
1562 <        checkCompletedNormally(f, v1);
1563 <        checkCompletedNormally(g, v2);
1908 >        final Noop r1 = new Noop(m);
1909 >        final Noop r2 = new Noop(m);
1910 >        final Noop r3 = new Noop(m);
1911 >
1912 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1913 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1914 >        final Callable<Boolean> complete1 = failFirst ?
1915 >            () -> fst.completeExceptionally(ex) :
1916 >            () -> fst.complete(v1);
1917 >        final Callable<Boolean> complete2 = failFirst ?
1918 >            () -> snd.complete(v1) :
1919 >            () -> snd.completeExceptionally(ex);
1920 >
1921 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1922 >        assertTrue(complete1.call());
1923 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1924 >        checkIncomplete(h1);
1925 >        checkIncomplete(h2);
1926 >        assertTrue(complete2.call());
1927 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
1928 >
1929 >        checkCompletedWithWrappedException(h1, ex);
1930 >        checkCompletedWithWrappedException(h2, ex);
1931 >        checkCompletedWithWrappedException(h3, ex);
1932 >        r1.assertNotInvoked();
1933 >        r2.assertNotInvoked();
1934 >        r3.assertNotInvoked();
1935 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1936 >        checkCompletedExceptionally(failFirst ? fst : snd, ex);
1937      }}
1938  
1939      /**
1940       * runAfterBoth result completes exceptionally if either source cancelled
1941       */
1942 <    public void testRunAfterBoth_sourceCancelled() {
1942 >    public void testRunAfterBoth_sourceCancelled() throws Throwable {
1943          for (ExecutionMode m : ExecutionMode.values())
1944          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1572        for (boolean createIncomplete : new boolean[] { true, false })
1945          for (boolean fFirst : new boolean[] { true, false })
1946 +        for (boolean failFirst : new boolean[] { true, false })
1947          for (Integer v1 : new Integer[] { 1, null })
1948      {
1949          final CompletableFuture<Integer> f = new CompletableFuture<>();
1950          final CompletableFuture<Integer> g = new CompletableFuture<>();
1951 <        final Noop r = new Noop(m);
1952 <
1953 <
1954 <        (fFirst ? f : g).complete(v1);
1955 <        if (!createIncomplete)
1956 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1957 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1958 <        if (createIncomplete) {
1959 <            checkIncomplete(h);
1960 <            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1961 <        }
1962 <
1963 <        checkCompletedWithWrappedCancellationException(h);
1964 <        checkCancelled(!fFirst ? f : g);
1965 <        assertEquals(0, r.invocationCount);
1966 <        checkCompletedNormally(fFirst ? f : g, v1);
1951 >        final Noop r1 = new Noop(m);
1952 >        final Noop r2 = new Noop(m);
1953 >        final Noop r3 = new Noop(m);
1954 >
1955 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1956 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1957 >        final Callable<Boolean> complete1 = failFirst ?
1958 >            () -> fst.cancel(mayInterruptIfRunning) :
1959 >            () -> fst.complete(v1);
1960 >        final Callable<Boolean> complete2 = failFirst ?
1961 >            () -> snd.complete(v1) :
1962 >            () -> snd.cancel(mayInterruptIfRunning);
1963 >
1964 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1965 >        assertTrue(complete1.call());
1966 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1967 >        checkIncomplete(h1);
1968 >        checkIncomplete(h2);
1969 >        assertTrue(complete2.call());
1970 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
1971 >
1972 >        checkCompletedWithWrappedCancellationException(h1);
1973 >        checkCompletedWithWrappedCancellationException(h2);
1974 >        checkCompletedWithWrappedCancellationException(h3);
1975 >        r1.assertNotInvoked();
1976 >        r2.assertNotInvoked();
1977 >        r3.assertNotInvoked();
1978 >        checkCompletedNormally(failFirst ? snd : fst, v1);
1979 >        checkCancelled(failFirst ? fst : snd);
1980      }}
1981  
1982      /**
1983 <     * applyToEither result completes normally after normal completion
1598 <     * of either source
1983 >     * runAfterBoth result completes exceptionally if action does
1984       */
1985 <    public void testApplyToEither_normalCompletion() {
1985 >    public void testRunAfterBoth_actionFailed() {
1986          for (ExecutionMode m : ExecutionMode.values())
1602        for (boolean createIncomplete : new boolean[] { true, false })
1987          for (boolean fFirst : new boolean[] { true, false })
1988          for (Integer v1 : new Integer[] { 1, null })
1989          for (Integer v2 : new Integer[] { 2, null })
1990      {
1991          final CompletableFuture<Integer> f = new CompletableFuture<>();
1992          final CompletableFuture<Integer> g = new CompletableFuture<>();
1993 <        final IncFunction r = new IncFunction();
1994 <
1995 <        if (!createIncomplete)
1996 <            if (fFirst) f.complete(v1); else g.complete(v2);
1997 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1998 <        if (createIncomplete) {
1999 <            checkIncomplete(h);
2000 <            assertEquals(0, r.invocationCount);
2001 <            if (fFirst) f.complete(v1); else g.complete(v2);
2002 <        }
2003 <        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
2004 <        if (!fFirst) f.complete(v1); else g.complete(v2);
1993 >        final FailingRunnable r1 = new FailingRunnable(m);
1994 >        final FailingRunnable r2 = new FailingRunnable(m);
1995 >        final FailingRunnable r3 = new FailingRunnable(m);
1996 >
1997 >        final CompletableFuture<Integer> fst =  fFirst ? f : g;
1998 >        final CompletableFuture<Integer> snd = !fFirst ? f : g;
1999 >        final Integer w1 =  fFirst ? v1 : v2;
2000 >        final Integer w2 = !fFirst ? v1 : v2;
2001 >
2002 >        final CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
2003 >        assertTrue(fst.complete(w1));
2004 >        final CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
2005 >        assertTrue(snd.complete(w2));
2006 >        final CompletableFuture<Void> h3 = m.runAfterBoth(f, g, r3);
2007  
2008 +        checkCompletedWithWrappedCFException(h1);
2009 +        checkCompletedWithWrappedCFException(h2);
2010 +        checkCompletedWithWrappedCFException(h3);
2011 +        r1.assertInvoked();
2012 +        r2.assertInvoked();
2013 +        r3.assertInvoked();
2014          checkCompletedNormally(f, v1);
2015          checkCompletedNormally(g, v2);
1624        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
2016      }}
2017  
2018 <    public void testApplyToEither_normalCompletionBothAvailable() {
2018 >    /**
2019 >     * applyToEither result completes normally after normal completion
2020 >     * of either source
2021 >     */
2022 >    public void testApplyToEither_normalCompletion() {
2023          for (ExecutionMode m : ExecutionMode.values())
1629        for (boolean fFirst : new boolean[] { true, false })
2024          for (Integer v1 : new Integer[] { 1, null })
2025          for (Integer v2 : new Integer[] { 2, null })
2026      {
2027          final CompletableFuture<Integer> f = new CompletableFuture<>();
2028          final CompletableFuture<Integer> g = new CompletableFuture<>();
2029 <        final IncFunction r = new IncFunction();
2029 >        final IncFunction[] rs = new IncFunction[6];
2030 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2031  
2032 <        if (fFirst) {
2033 <            f.complete(v1);
2034 <            g.complete(v2);
2035 <        } else {
2036 <            g.complete(v2);
2037 <            f.complete(v1);
2038 <        }
2032 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2033 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2034 >        checkIncomplete(h0);
2035 >        checkIncomplete(h1);
2036 >        rs[0].assertNotInvoked();
2037 >        rs[1].assertNotInvoked();
2038 >        f.complete(v1);
2039 >        checkCompletedNormally(h0, inc(v1));
2040 >        checkCompletedNormally(h1, inc(v1));
2041 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2042 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2043 >        checkCompletedNormally(h2, inc(v1));
2044 >        checkCompletedNormally(h3, inc(v1));
2045 >        g.complete(v2);
2046  
2047 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2047 >        // unspecified behavior - both source completions available
2048 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2049 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2050 >        rs[4].assertValue(h4.join());
2051 >        rs[5].assertValue(h5.join());
2052 >        assertTrue(Objects.equals(inc(v1), h4.join()) ||
2053 >                   Objects.equals(inc(v2), h4.join()));
2054 >        assertTrue(Objects.equals(inc(v1), h5.join()) ||
2055 >                   Objects.equals(inc(v2), h5.join()));
2056  
2057          checkCompletedNormally(f, v1);
2058          checkCompletedNormally(g, v2);
2059 <
2060 <        // unspecified behavior
2061 <        assertTrue(Objects.equals(h.join(), inc(v1)) ||
2062 <                   Objects.equals(h.join(), inc(v2)));
2063 <        assertEquals(1, r.invocationCount);
2059 >        checkCompletedNormally(h0, inc(v1));
2060 >        checkCompletedNormally(h1, inc(v1));
2061 >        checkCompletedNormally(h2, inc(v1));
2062 >        checkCompletedNormally(h3, inc(v1));
2063 >        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
2064      }}
2065  
2066      /**
2067       * applyToEither result completes exceptionally after exceptional
2068       * completion of either source
2069       */
2070 <    public void testApplyToEither_exceptionalCompletion1() {
2070 >    public void testApplyToEither_exceptionalCompletion() {
2071          for (ExecutionMode m : ExecutionMode.values())
1662        for (boolean createIncomplete : new boolean[] { true, false })
1663        for (boolean fFirst : new boolean[] { true, false })
2072          for (Integer v1 : new Integer[] { 1, null })
2073      {
2074          final CompletableFuture<Integer> f = new CompletableFuture<>();
2075          final CompletableFuture<Integer> g = new CompletableFuture<>();
2076          final CFException ex = new CFException();
2077 <        final IncFunction r = new IncFunction();
2077 >        final IncFunction[] rs = new IncFunction[6];
2078 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2079  
2080 <        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
2081 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2082 <        if (createIncomplete) {
2083 <            checkIncomplete(h);
2084 <            assertEquals(0, r.invocationCount);
2085 <            (fFirst ? f : g).completeExceptionally(ex);
2080 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2081 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2082 >        checkIncomplete(h0);
2083 >        checkIncomplete(h1);
2084 >        rs[0].assertNotInvoked();
2085 >        rs[1].assertNotInvoked();
2086 >        f.completeExceptionally(ex);
2087 >        checkCompletedWithWrappedException(h0, ex);
2088 >        checkCompletedWithWrappedException(h1, ex);
2089 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2090 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2091 >        checkCompletedWithWrappedException(h2, ex);
2092 >        checkCompletedWithWrappedException(h3, ex);
2093 >        g.complete(v1);
2094 >
2095 >        // unspecified behavior - both source completions available
2096 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2097 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2098 >        try {
2099 >            assertEquals(inc(v1), h4.join());
2100 >            rs[4].assertValue(inc(v1));
2101 >        } catch (CompletionException ok) {
2102 >            checkCompletedWithWrappedException(h4, ex);
2103 >            rs[4].assertNotInvoked();
2104 >        }
2105 >        try {
2106 >            assertEquals(inc(v1), h5.join());
2107 >            rs[5].assertValue(inc(v1));
2108 >        } catch (CompletionException ok) {
2109 >            checkCompletedWithWrappedException(h5, ex);
2110 >            rs[5].assertNotInvoked();
2111          }
2112  
2113 <        checkCompletedWithWrappedCFException(h, ex);
2114 <        (!fFirst ? f : g).complete(v1);
2115 <
2116 <        assertEquals(0, r.invocationCount);
2117 <        checkCompletedNormally(!fFirst ? f : g, v1);
2118 <        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
2119 <        checkCompletedWithWrappedCFException(h, ex);
2113 >        checkCompletedExceptionally(f, ex);
2114 >        checkCompletedNormally(g, v1);
2115 >        checkCompletedWithWrappedException(h0, ex);
2116 >        checkCompletedWithWrappedException(h1, ex);
2117 >        checkCompletedWithWrappedException(h2, ex);
2118 >        checkCompletedWithWrappedException(h3, ex);
2119 >        checkCompletedWithWrappedException(h4, ex);
2120 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2121      }}
2122  
2123      public void testApplyToEither_exceptionalCompletion2() {
2124          for (ExecutionMode m : ExecutionMode.values())
1690        for (boolean reverseArgs : new boolean[] { true, false })
2125          for (boolean fFirst : new boolean[] { true, false })
2126          for (Integer v1 : new Integer[] { 1, null })
2127      {
2128          final CompletableFuture<Integer> f = new CompletableFuture<>();
2129          final CompletableFuture<Integer> g = new CompletableFuture<>();
1696        final IncFunction r1 = new IncFunction();
1697        final IncFunction r2 = new IncFunction();
2130          final CFException ex = new CFException();
2131 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
2132 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1701 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1702 <        if (fFirst) {
1703 <            f.complete(v1);
1704 <            g.completeExceptionally(ex);
1705 <        } else {
1706 <            g.completeExceptionally(ex);
1707 <            f.complete(v1);
1708 <        }
1709 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
2131 >        final IncFunction[] rs = new IncFunction[6];
2132 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2133  
2134 <        // unspecified behavior
2134 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2135 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2136 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2137 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2138 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2139 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2140 >
2141 >        // unspecified behavior - both source completions available
2142 >        try {
2143 >            assertEquals(inc(v1), h0.join());
2144 >            rs[0].assertValue(inc(v1));
2145 >        } catch (CompletionException ok) {
2146 >            checkCompletedWithWrappedException(h0, ex);
2147 >            rs[0].assertNotInvoked();
2148 >        }
2149          try {
2150              assertEquals(inc(v1), h1.join());
2151 <            assertEquals(1, r1.invocationCount);
2151 >            rs[1].assertValue(inc(v1));
2152          } catch (CompletionException ok) {
2153 <            checkCompletedWithWrappedCFException(h1, ex);
2154 <            assertEquals(0, r1.invocationCount);
2153 >            checkCompletedWithWrappedException(h1, ex);
2154 >            rs[1].assertNotInvoked();
2155          }
1719
2156          try {
2157              assertEquals(inc(v1), h2.join());
2158 <            assertEquals(1, r2.invocationCount);
2158 >            rs[2].assertValue(inc(v1));
2159          } catch (CompletionException ok) {
2160 <            checkCompletedWithWrappedCFException(h2, ex);
2161 <            assertEquals(0, r2.invocationCount);
2160 >            checkCompletedWithWrappedException(h2, ex);
2161 >            rs[2].assertNotInvoked();
2162 >        }
2163 >        try {
2164 >            assertEquals(inc(v1), h3.join());
2165 >            rs[3].assertValue(inc(v1));
2166 >        } catch (CompletionException ok) {
2167 >            checkCompletedWithWrappedException(h3, ex);
2168 >            rs[3].assertNotInvoked();
2169          }
2170  
1728        checkCompletedWithWrappedCFException(g, ex);
1729        checkCompletedNormally(f, v1);
1730    }}
1731
1732    /**
1733     * applyToEither result completes exceptionally if action does
1734     */
1735    public void testApplyToEither_actionFailed1() {
1736        for (ExecutionMode m : ExecutionMode.values())
1737        for (Integer v1 : new Integer[] { 1, null })
1738        for (Integer v2 : new Integer[] { 2, null })
1739    {
1740        final CompletableFuture<Integer> f = new CompletableFuture<>();
1741        final CompletableFuture<Integer> g = new CompletableFuture<>();
1742        final FailingFunction r = new FailingFunction();
1743        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1744
1745        f.complete(v1);
1746        checkCompletedWithWrappedCFException(h);
1747        g.complete(v2);
1748        checkCompletedNormally(f, v1);
1749        checkCompletedNormally(g, v2);
1750    }}
1751
1752    public void testApplyToEither_actionFailed2() {
1753        for (ExecutionMode m : ExecutionMode.values())
1754        for (Integer v1 : new Integer[] { 1, null })
1755        for (Integer v2 : new Integer[] { 2, null })
1756    {
1757        final CompletableFuture<Integer> f = new CompletableFuture<>();
1758        final CompletableFuture<Integer> g = new CompletableFuture<>();
1759        final FailingFunction r = new FailingFunction();
1760        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1761
1762        g.complete(v2);
1763        checkCompletedWithWrappedCFException(h);
1764        f.complete(v1);
2171          checkCompletedNormally(f, v1);
2172 <        checkCompletedNormally(g, v2);
2172 >        checkCompletedExceptionally(g, ex);
2173      }}
2174  
2175      /**
2176       * applyToEither result completes exceptionally if either source cancelled
2177       */
2178 <    public void testApplyToEither_sourceCancelled1() {
2178 >    public void testApplyToEither_sourceCancelled() {
2179          for (ExecutionMode m : ExecutionMode.values())
2180          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1775        for (boolean createIncomplete : new boolean[] { true, false })
1776        for (boolean fFirst : new boolean[] { true, false })
2181          for (Integer v1 : new Integer[] { 1, null })
2182      {
2183          final CompletableFuture<Integer> f = new CompletableFuture<>();
2184          final CompletableFuture<Integer> g = new CompletableFuture<>();
2185 <        final IncFunction r = new IncFunction();
2185 >        final IncFunction[] rs = new IncFunction[6];
2186 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2187  
2188 <        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
2189 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2190 <        if (createIncomplete) {
2191 <            checkIncomplete(h);
2192 <            assertEquals(0, r.invocationCount);
2193 <            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
2188 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2189 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2190 >        checkIncomplete(h0);
2191 >        checkIncomplete(h1);
2192 >        rs[0].assertNotInvoked();
2193 >        rs[1].assertNotInvoked();
2194 >        f.cancel(mayInterruptIfRunning);
2195 >        checkCompletedWithWrappedCancellationException(h0);
2196 >        checkCompletedWithWrappedCancellationException(h1);
2197 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2198 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2199 >        checkCompletedWithWrappedCancellationException(h2);
2200 >        checkCompletedWithWrappedCancellationException(h3);
2201 >        g.complete(v1);
2202 >
2203 >        // unspecified behavior - both source completions available
2204 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2205 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2206 >        try {
2207 >            assertEquals(inc(v1), h4.join());
2208 >            rs[4].assertValue(inc(v1));
2209 >        } catch (CompletionException ok) {
2210 >            checkCompletedWithWrappedCancellationException(h4);
2211 >            rs[4].assertNotInvoked();
2212 >        }
2213 >        try {
2214 >            assertEquals(inc(v1), h5.join());
2215 >            rs[5].assertValue(inc(v1));
2216 >        } catch (CompletionException ok) {
2217 >            checkCompletedWithWrappedCancellationException(h5);
2218 >            rs[5].assertNotInvoked();
2219          }
2220  
2221 <        checkCompletedWithWrappedCancellationException(h);
2222 <        (!fFirst ? f : g).complete(v1);
2223 <
2224 <        assertEquals(0, r.invocationCount);
2225 <        checkCompletedNormally(!fFirst ? f : g, v1);
2226 <        checkCancelled(fFirst ? f : g);
2227 <        checkCompletedWithWrappedCancellationException(h);
2221 >        checkCancelled(f);
2222 >        checkCompletedNormally(g, v1);
2223 >        checkCompletedWithWrappedCancellationException(h0);
2224 >        checkCompletedWithWrappedCancellationException(h1);
2225 >        checkCompletedWithWrappedCancellationException(h2);
2226 >        checkCompletedWithWrappedCancellationException(h3);
2227 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2228      }}
2229  
2230      public void testApplyToEither_sourceCancelled2() {
2231          for (ExecutionMode m : ExecutionMode.values())
2232          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1803        for (boolean reverseArgs : new boolean[] { true, false })
2233          for (boolean fFirst : new boolean[] { true, false })
2234          for (Integer v1 : new Integer[] { 1, null })
2235      {
2236          final CompletableFuture<Integer> f = new CompletableFuture<>();
2237          final CompletableFuture<Integer> g = new CompletableFuture<>();
2238 <        final IncFunction r1 = new IncFunction();
2239 <        final IncFunction r2 = new IncFunction();
1811 <        final CFException ex = new CFException();
1812 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1813 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
2238 >        final IncFunction[] rs = new IncFunction[6];
2239 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2240  
2241 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
2242 <        if (fFirst) {
2243 <            f.complete(v1);
2244 <            assertTrue(g.cancel(mayInterruptIfRunning));
2245 <        } else {
2246 <            assertTrue(g.cancel(mayInterruptIfRunning));
1821 <            f.complete(v1);
1822 <        }
1823 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
2241 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2242 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2243 >        assertTrue(fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2244 >        assertTrue(!fFirst ? f.complete(v1) : g.cancel(mayInterruptIfRunning));
2245 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2246 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2247  
2248 <        // unspecified behavior
2248 >        // unspecified behavior - both source completions available
2249 >        try {
2250 >            assertEquals(inc(v1), h0.join());
2251 >            rs[0].assertValue(inc(v1));
2252 >        } catch (CompletionException ok) {
2253 >            checkCompletedWithWrappedCancellationException(h0);
2254 >            rs[0].assertNotInvoked();
2255 >        }
2256          try {
2257              assertEquals(inc(v1), h1.join());
2258 <            assertEquals(1, r1.invocationCount);
2258 >            rs[1].assertValue(inc(v1));
2259          } catch (CompletionException ok) {
2260              checkCompletedWithWrappedCancellationException(h1);
2261 <            assertEquals(0, r1.invocationCount);
2261 >            rs[1].assertNotInvoked();
2262          }
1833
2263          try {
2264              assertEquals(inc(v1), h2.join());
2265 <            assertEquals(1, r2.invocationCount);
2265 >            rs[2].assertValue(inc(v1));
2266          } catch (CompletionException ok) {
2267              checkCompletedWithWrappedCancellationException(h2);
2268 <            assertEquals(0, r2.invocationCount);
2268 >            rs[2].assertNotInvoked();
2269 >        }
2270 >        try {
2271 >            assertEquals(inc(v1), h3.join());
2272 >            rs[3].assertValue(inc(v1));
2273 >        } catch (CompletionException ok) {
2274 >            checkCompletedWithWrappedCancellationException(h3);
2275 >            rs[3].assertNotInvoked();
2276          }
2277  
1842        checkCancelled(g);
2278          checkCompletedNormally(f, v1);
2279 +        checkCancelled(g);
2280      }}
2281  
2282      /**
2283 <     * acceptEither result completes normally after normal completion
1848 <     * of either source
2283 >     * applyToEither result completes exceptionally if action does
2284       */
2285 <    public void testAcceptEither_normalCompletion1() {
2285 >    public void testApplyToEither_actionFailed() {
2286          for (ExecutionMode m : ExecutionMode.values())
2287          for (Integer v1 : new Integer[] { 1, null })
2288          for (Integer v2 : new Integer[] { 2, null })
2289      {
2290          final CompletableFuture<Integer> f = new CompletableFuture<>();
2291          final CompletableFuture<Integer> g = new CompletableFuture<>();
2292 <        final IncAction r = new IncAction();
2293 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2292 >        final FailingFunction[] rs = new FailingFunction[6];
2293 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
2294  
2295 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2296 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2297          f.complete(v1);
2298 <        checkCompletedNormally(h, null);
2299 <        assertEquals(inc(v1), r.value);
2300 <        g.complete(v2);
2301 <
2302 <        checkCompletedNormally(f, v1);
2303 <        checkCompletedNormally(g, v2);
2304 <        checkCompletedNormally(h, null);
1868 <    }}
1869 <
1870 <    public void testAcceptEither_normalCompletion2() {
1871 <        for (ExecutionMode m : ExecutionMode.values())
1872 <        for (Integer v1 : new Integer[] { 1, null })
1873 <        for (Integer v2 : new Integer[] { 2, null })
1874 <    {
1875 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1876 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1877 <        final IncAction r = new IncAction();
1878 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2298 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2299 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2300 >        checkCompletedWithWrappedCFException(h0);
2301 >        checkCompletedWithWrappedCFException(h1);
2302 >        checkCompletedWithWrappedCFException(h2);
2303 >        checkCompletedWithWrappedCFException(h3);
2304 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2305  
2306          g.complete(v2);
2307 <        checkCompletedNormally(h, null);
2308 <        assertEquals(inc(v2), r.value);
2309 <        f.complete(v1);
2307 >
2308 >        // unspecified behavior - both source completions available
2309 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2310 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2311 >
2312 >        checkCompletedWithWrappedCFException(h4);
2313 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2314 >                   Objects.equals(v2, rs[4].value));
2315 >        checkCompletedWithWrappedCFException(h5);
2316 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2317 >                   Objects.equals(v2, rs[5].value));
2318  
2319          checkCompletedNormally(f, v1);
2320          checkCompletedNormally(g, v2);
1887        checkCompletedNormally(h, null);
2321      }}
2322  
2323 <    public void testAcceptEither_normalCompletion3() {
2323 >    /**
2324 >     * acceptEither result completes normally after normal completion
2325 >     * of either source
2326 >     */
2327 >    public void testAcceptEither_normalCompletion() {
2328          for (ExecutionMode m : ExecutionMode.values())
2329          for (Integer v1 : new Integer[] { 1, null })
2330          for (Integer v2 : new Integer[] { 2, null })
2331      {
2332          final CompletableFuture<Integer> f = new CompletableFuture<>();
2333          final CompletableFuture<Integer> g = new CompletableFuture<>();
2334 <        final IncAction r = new IncAction();
2334 >        final NoopConsumer[] rs = new NoopConsumer[6];
2335 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2336  
2337 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2338 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2339 +        checkIncomplete(h0);
2340 +        checkIncomplete(h1);
2341 +        rs[0].assertNotInvoked();
2342 +        rs[1].assertNotInvoked();
2343          f.complete(v1);
2344 +        checkCompletedNormally(h0, null);
2345 +        checkCompletedNormally(h1, null);
2346 +        rs[0].assertValue(v1);
2347 +        rs[1].assertValue(v1);
2348 +        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2349 +        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2350 +        checkCompletedNormally(h2, null);
2351 +        checkCompletedNormally(h3, null);
2352 +        rs[2].assertValue(v1);
2353 +        rs[3].assertValue(v1);
2354          g.complete(v2);
1901        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2355  
2356 <        checkCompletedNormally(h, null);
2356 >        // unspecified behavior - both source completions available
2357 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2358 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2359 >        checkCompletedNormally(h4, null);
2360 >        checkCompletedNormally(h5, null);
2361 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2362 >                   Objects.equals(v2, rs[4].value));
2363 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2364 >                   Objects.equals(v2, rs[5].value));
2365 >
2366          checkCompletedNormally(f, v1);
2367          checkCompletedNormally(g, v2);
2368 <
2369 <        // unspecified behavior
2370 <        assertTrue(Objects.equals(r.value, inc(v1)) ||
2371 <                   Objects.equals(r.value, inc(v2)));
2368 >        checkCompletedNormally(h0, null);
2369 >        checkCompletedNormally(h1, null);
2370 >        checkCompletedNormally(h2, null);
2371 >        checkCompletedNormally(h3, null);
2372 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2373      }}
2374  
2375      /**
2376       * acceptEither result completes exceptionally after exceptional
2377       * completion of either source
2378       */
2379 <    public void testAcceptEither_exceptionalCompletion1() {
2379 >    public void testAcceptEither_exceptionalCompletion() {
2380          for (ExecutionMode m : ExecutionMode.values())
2381          for (Integer v1 : new Integer[] { 1, null })
2382      {
2383          final CompletableFuture<Integer> f = new CompletableFuture<>();
2384          final CompletableFuture<Integer> g = new CompletableFuture<>();
1922        final IncAction r = new IncAction();
1923        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2385          final CFException ex = new CFException();
2386 +        final NoopConsumer[] rs = new NoopConsumer[6];
2387 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2388  
2389 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2390 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2391 +        checkIncomplete(h0);
2392 +        checkIncomplete(h1);
2393 +        rs[0].assertNotInvoked();
2394 +        rs[1].assertNotInvoked();
2395          f.completeExceptionally(ex);
2396 <        checkCompletedWithWrappedCFException(h, ex);
2396 >        checkCompletedWithWrappedException(h0, ex);
2397 >        checkCompletedWithWrappedException(h1, ex);
2398 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2399 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2400 >        checkCompletedWithWrappedException(h2, ex);
2401 >        checkCompletedWithWrappedException(h3, ex);
2402 >
2403          g.complete(v1);
2404  
2405 <        assertEquals(0, r.invocationCount);
2405 >        // unspecified behavior - both source completions available
2406 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2407 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2408 >        try {
2409 >            assertNull(h4.join());
2410 >            rs[4].assertValue(v1);
2411 >        } catch (CompletionException ok) {
2412 >            checkCompletedWithWrappedException(h4, ex);
2413 >            rs[4].assertNotInvoked();
2414 >        }
2415 >        try {
2416 >            assertNull(h5.join());
2417 >            rs[5].assertValue(v1);
2418 >        } catch (CompletionException ok) {
2419 >            checkCompletedWithWrappedException(h5, ex);
2420 >            rs[5].assertNotInvoked();
2421 >        }
2422 >
2423 >        checkCompletedExceptionally(f, ex);
2424          checkCompletedNormally(g, v1);
2425 <        checkCompletedWithWrappedCFException(f, ex);
2426 <        checkCompletedWithWrappedCFException(h, ex);
2425 >        checkCompletedWithWrappedException(h0, ex);
2426 >        checkCompletedWithWrappedException(h1, ex);
2427 >        checkCompletedWithWrappedException(h2, ex);
2428 >        checkCompletedWithWrappedException(h3, ex);
2429 >        checkCompletedWithWrappedException(h4, ex);
2430 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2431      }}
2432  
2433      public void testAcceptEither_exceptionalCompletion2() {
2434          for (ExecutionMode m : ExecutionMode.values())
2435 +        for (boolean fFirst : new boolean[] { true, false })
2436          for (Integer v1 : new Integer[] { 1, null })
2437      {
2438          final CompletableFuture<Integer> f = new CompletableFuture<>();
2439          final CompletableFuture<Integer> g = new CompletableFuture<>();
1942        final IncAction r = new IncAction();
1943        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1944        final CFException ex = new CFException();
1945
1946        g.completeExceptionally(ex);
1947        checkCompletedWithWrappedCFException(h, ex);
1948        f.complete(v1);
1949
1950        assertEquals(0, r.invocationCount);
1951        checkCompletedNormally(f, v1);
1952        checkCompletedWithWrappedCFException(g, ex);
1953        checkCompletedWithWrappedCFException(h, ex);
1954    }}
1955
1956    public void testAcceptEither_exceptionalCompletion3() {
1957        for (ExecutionMode m : ExecutionMode.values())
1958        for (Integer v1 : new Integer[] { 1, null })
1959    {
1960        final CompletableFuture<Integer> f = new CompletableFuture<>();
1961        final CompletableFuture<Integer> g = new CompletableFuture<>();
1962        final IncAction r = new IncAction();
2440          final CFException ex = new CFException();
2441 +        final NoopConsumer[] rs = new NoopConsumer[6];
2442 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2443  
2444 <        g.completeExceptionally(ex);
2445 <        f.complete(v1);
2446 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2444 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2445 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2446 >        assertTrue(fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2447 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2448 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2449 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2450  
2451 <        // unspecified behavior
1970 <        Integer v;
2451 >        // unspecified behavior - both source completions available
2452          try {
2453 <            assertNull(h.join());
2454 <            assertEquals(1, r.invocationCount);
1974 <            assertEquals(inc(v1), r.value);
2453 >            assertEquals(null, h0.join());
2454 >            rs[0].assertValue(v1);
2455          } catch (CompletionException ok) {
2456 <            checkCompletedWithWrappedCFException(h, ex);
2457 <            assertEquals(0, r.invocationCount);
2456 >            checkCompletedWithWrappedException(h0, ex);
2457 >            rs[0].assertNotInvoked();
2458          }
1979
1980        checkCompletedWithWrappedCFException(g, ex);
1981        checkCompletedNormally(f, v1);
1982    }}
1983
1984    public void testAcceptEither_exceptionalCompletion4() {
1985        for (ExecutionMode m : ExecutionMode.values())
1986        for (Integer v1 : new Integer[] { 1, null })
1987    {
1988        final CompletableFuture<Integer> f = new CompletableFuture<>();
1989        final CompletableFuture<Integer> g = new CompletableFuture<>();
1990        final IncAction r = new IncAction();
1991        final CFException ex = new CFException();
1992
1993        f.completeExceptionally(ex);
1994        g.complete(v1);
1995        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1996
1997        // unspecified behavior
1998        Integer v;
2459          try {
2460 <            assertNull(h.join());
2461 <            assertEquals(1, r.invocationCount);
2002 <            assertEquals(inc(v1), r.value);
2460 >            assertEquals(null, h1.join());
2461 >            rs[1].assertValue(v1);
2462          } catch (CompletionException ok) {
2463 <            checkCompletedWithWrappedCFException(h, ex);
2464 <            assertEquals(0, r.invocationCount);
2463 >            checkCompletedWithWrappedException(h1, ex);
2464 >            rs[1].assertNotInvoked();
2465 >        }
2466 >        try {
2467 >            assertEquals(null, h2.join());
2468 >            rs[2].assertValue(v1);
2469 >        } catch (CompletionException ok) {
2470 >            checkCompletedWithWrappedException(h2, ex);
2471 >            rs[2].assertNotInvoked();
2472 >        }
2473 >        try {
2474 >            assertEquals(null, h3.join());
2475 >            rs[3].assertValue(v1);
2476 >        } catch (CompletionException ok) {
2477 >            checkCompletedWithWrappedException(h3, ex);
2478 >            rs[3].assertNotInvoked();
2479          }
2480  
2008        checkCompletedWithWrappedCFException(f, ex);
2009        checkCompletedNormally(g, v1);
2010    }}
2011
2012    /**
2013     * acceptEither result completes exceptionally if action does
2014     */
2015    public void testAcceptEither_actionFailed1() {
2016        for (ExecutionMode m : ExecutionMode.values())
2017        for (Integer v1 : new Integer[] { 1, null })
2018        for (Integer v2 : new Integer[] { 2, null })
2019    {
2020        final CompletableFuture<Integer> f = new CompletableFuture<>();
2021        final CompletableFuture<Integer> g = new CompletableFuture<>();
2022        final FailingConsumer r = new FailingConsumer();
2023        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2024
2025        f.complete(v1);
2026        checkCompletedWithWrappedCFException(h);
2027        g.complete(v2);
2028        checkCompletedNormally(f, v1);
2029        checkCompletedNormally(g, v2);
2030    }}
2031
2032    public void testAcceptEither_actionFailed2() {
2033        for (ExecutionMode m : ExecutionMode.values())
2034        for (Integer v1 : new Integer[] { 1, null })
2035        for (Integer v2 : new Integer[] { 2, null })
2036    {
2037        final CompletableFuture<Integer> f = new CompletableFuture<>();
2038        final CompletableFuture<Integer> g = new CompletableFuture<>();
2039        final FailingConsumer r = new FailingConsumer();
2040        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2041
2042        g.complete(v2);
2043        checkCompletedWithWrappedCFException(h);
2044        f.complete(v1);
2481          checkCompletedNormally(f, v1);
2482 <        checkCompletedNormally(g, v2);
2482 >        checkCompletedExceptionally(g, ex);
2483      }}
2484  
2485      /**
2486       * acceptEither result completes exceptionally if either source cancelled
2487       */
2488 <    public void testAcceptEither_sourceCancelled1() {
2488 >    public void testAcceptEither_sourceCancelled() {
2489          for (ExecutionMode m : ExecutionMode.values())
2490          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2491          for (Integer v1 : new Integer[] { 1, null })
2492      {
2493          final CompletableFuture<Integer> f = new CompletableFuture<>();
2494          final CompletableFuture<Integer> g = new CompletableFuture<>();
2495 <        final IncAction r = new IncAction();
2496 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2061 <
2062 <        assertTrue(f.cancel(mayInterruptIfRunning));
2063 <        checkCompletedWithWrappedCancellationException(h);
2064 <        g.complete(v1);
2495 >        final NoopConsumer[] rs = new NoopConsumer[6];
2496 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2497  
2498 <        checkCancelled(f);
2499 <        assertEquals(0, r.invocationCount);
2500 <        checkCompletedNormally(g, v1);
2501 <        checkCompletedWithWrappedCancellationException(h);
2502 <    }}
2498 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2499 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2500 >        checkIncomplete(h0);
2501 >        checkIncomplete(h1);
2502 >        rs[0].assertNotInvoked();
2503 >        rs[1].assertNotInvoked();
2504 >        f.cancel(mayInterruptIfRunning);
2505 >        checkCompletedWithWrappedCancellationException(h0);
2506 >        checkCompletedWithWrappedCancellationException(h1);
2507 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2508 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2509 >        checkCompletedWithWrappedCancellationException(h2);
2510 >        checkCompletedWithWrappedCancellationException(h3);
2511  
2512 <    public void testAcceptEither_sourceCancelled2() {
2073 <        for (ExecutionMode m : ExecutionMode.values())
2074 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2075 <        for (Integer v1 : new Integer[] { 1, null })
2076 <    {
2077 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2078 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2079 <        final IncAction r = new IncAction();
2080 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2081 <
2082 <        assertTrue(g.cancel(mayInterruptIfRunning));
2083 <        checkCompletedWithWrappedCancellationException(h);
2084 <        f.complete(v1);
2085 <
2086 <        checkCancelled(g);
2087 <        assertEquals(0, r.invocationCount);
2088 <        checkCompletedNormally(f, v1);
2089 <        checkCompletedWithWrappedCancellationException(h);
2090 <    }}
2091 <
2092 <    public void testAcceptEither_sourceCancelled3() {
2093 <        for (ExecutionMode m : ExecutionMode.values())
2094 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2095 <        for (Integer v1 : new Integer[] { 1, null })
2096 <    {
2097 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2098 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2099 <        final IncAction r = new IncAction();
2100 <
2101 <        assertTrue(g.cancel(mayInterruptIfRunning));
2102 <        f.complete(v1);
2103 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2512 >        g.complete(v1);
2513  
2514 <        // unspecified behavior
2515 <        Integer v;
2514 >        // unspecified behavior - both source completions available
2515 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2516 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2517          try {
2518 <            assertNull(h.join());
2519 <            assertEquals(1, r.invocationCount);
2110 <            assertEquals(inc(v1), r.value);
2518 >            assertNull(h4.join());
2519 >            rs[4].assertValue(v1);
2520          } catch (CompletionException ok) {
2521 <            checkCompletedWithWrappedCancellationException(h);
2522 <            assertEquals(0, r.invocationCount);
2521 >            checkCompletedWithWrappedCancellationException(h4);
2522 >            rs[4].assertNotInvoked();
2523          }
2115
2116        checkCancelled(g);
2117        checkCompletedNormally(f, v1);
2118    }}
2119
2120    public void testAcceptEither_sourceCancelled4() {
2121        for (ExecutionMode m : ExecutionMode.values())
2122        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2123        for (Integer v1 : new Integer[] { 1, null })
2124    {
2125        final CompletableFuture<Integer> f = new CompletableFuture<>();
2126        final CompletableFuture<Integer> g = new CompletableFuture<>();
2127        final IncAction r = new IncAction();
2128
2129        assertTrue(f.cancel(mayInterruptIfRunning));
2130        g.complete(v1);
2131        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2132
2133        // unspecified behavior
2134        Integer v;
2524          try {
2525 <            assertNull(h.join());
2526 <            assertEquals(1, r.invocationCount);
2138 <            assertEquals(inc(v1), r.value);
2525 >            assertNull(h5.join());
2526 >            rs[5].assertValue(v1);
2527          } catch (CompletionException ok) {
2528 <            checkCompletedWithWrappedCancellationException(h);
2529 <            assertEquals(0, r.invocationCount);
2528 >            checkCompletedWithWrappedCancellationException(h5);
2529 >            rs[5].assertNotInvoked();
2530          }
2531  
2532          checkCancelled(f);
2533          checkCompletedNormally(g, v1);
2534 +        checkCompletedWithWrappedCancellationException(h0);
2535 +        checkCompletedWithWrappedCancellationException(h1);
2536 +        checkCompletedWithWrappedCancellationException(h2);
2537 +        checkCompletedWithWrappedCancellationException(h3);
2538 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2539      }}
2540  
2541      /**
2542 <     * runAfterEither result completes normally after normal completion
2150 <     * of either source
2542 >     * acceptEither result completes exceptionally if action does
2543       */
2544 <    public void testRunAfterEither_normalCompletion1() {
2544 >    public void testAcceptEither_actionFailed() {
2545          for (ExecutionMode m : ExecutionMode.values())
2546          for (Integer v1 : new Integer[] { 1, null })
2547          for (Integer v2 : new Integer[] { 2, null })
2548      {
2549          final CompletableFuture<Integer> f = new CompletableFuture<>();
2550          final CompletableFuture<Integer> g = new CompletableFuture<>();
2551 <        final Noop r = new Noop(m);
2552 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2551 >        final FailingConsumer[] rs = new FailingConsumer[6];
2552 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
2553  
2554 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2555 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2556          f.complete(v1);
2557 <        checkCompletedNormally(h, null);
2558 <        assertEquals(1, r.invocationCount);
2557 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2558 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2559 >        checkCompletedWithWrappedCFException(h0);
2560 >        checkCompletedWithWrappedCFException(h1);
2561 >        checkCompletedWithWrappedCFException(h2);
2562 >        checkCompletedWithWrappedCFException(h3);
2563 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2564 >
2565          g.complete(v2);
2566  
2567 +        // unspecified behavior - both source completions available
2568 +        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2569 +        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2570 +
2571 +        checkCompletedWithWrappedCFException(h4);
2572 +        assertTrue(Objects.equals(v1, rs[4].value) ||
2573 +                   Objects.equals(v2, rs[4].value));
2574 +        checkCompletedWithWrappedCFException(h5);
2575 +        assertTrue(Objects.equals(v1, rs[5].value) ||
2576 +                   Objects.equals(v2, rs[5].value));
2577 +
2578          checkCompletedNormally(f, v1);
2579          checkCompletedNormally(g, v2);
2169        checkCompletedNormally(h, null);
2170        assertEquals(1, r.invocationCount);
2580      }}
2581  
2582 <    public void testRunAfterEither_normalCompletion2() {
2582 >    /**
2583 >     * runAfterEither result completes normally after normal completion
2584 >     * of either source
2585 >     */
2586 >    public void testRunAfterEither_normalCompletion() {
2587          for (ExecutionMode m : ExecutionMode.values())
2588          for (Integer v1 : new Integer[] { 1, null })
2589          for (Integer v2 : new Integer[] { 2, null })
2590      {
2591          final CompletableFuture<Integer> f = new CompletableFuture<>();
2592          final CompletableFuture<Integer> g = new CompletableFuture<>();
2593 <        final Noop r = new Noop(m);
2594 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2593 >        final Noop[] rs = new Noop[6];
2594 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2595  
2596 <        g.complete(v2);
2597 <        checkCompletedNormally(h, null);
2598 <        assertEquals(1, r.invocationCount);
2596 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2597 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2598 >        checkIncomplete(h0);
2599 >        checkIncomplete(h1);
2600 >        rs[0].assertNotInvoked();
2601 >        rs[1].assertNotInvoked();
2602          f.complete(v1);
2603 +        checkCompletedNormally(h0, null);
2604 +        checkCompletedNormally(h1, null);
2605 +        rs[0].assertInvoked();
2606 +        rs[1].assertInvoked();
2607 +        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2608 +        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2609 +        checkCompletedNormally(h2, null);
2610 +        checkCompletedNormally(h3, null);
2611 +        rs[2].assertInvoked();
2612 +        rs[3].assertInvoked();
2613  
2188        checkCompletedNormally(f, v1);
2189        checkCompletedNormally(g, v2);
2190        checkCompletedNormally(h, null);
2191        assertEquals(1, r.invocationCount);
2192        }}
2193
2194    public void testRunAfterEither_normalCompletion3() {
2195        for (ExecutionMode m : ExecutionMode.values())
2196        for (Integer v1 : new Integer[] { 1, null })
2197        for (Integer v2 : new Integer[] { 2, null })
2198    {
2199        final CompletableFuture<Integer> f = new CompletableFuture<>();
2200        final CompletableFuture<Integer> g = new CompletableFuture<>();
2201        final Noop r = new Noop(m);
2202
2203        f.complete(v1);
2614          g.complete(v2);
2205        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2615  
2616 <        checkCompletedNormally(h, null);
2616 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2617 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2618 >
2619          checkCompletedNormally(f, v1);
2620          checkCompletedNormally(g, v2);
2621 <        assertEquals(1, r.invocationCount);
2621 >        checkCompletedNormally(h0, null);
2622 >        checkCompletedNormally(h1, null);
2623 >        checkCompletedNormally(h2, null);
2624 >        checkCompletedNormally(h3, null);
2625 >        checkCompletedNormally(h4, null);
2626 >        checkCompletedNormally(h5, null);
2627 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2628      }}
2629  
2630      /**
2631       * runAfterEither result completes exceptionally after exceptional
2632       * completion of either source
2633       */
2634 <    public void testRunAfterEither_exceptionalCompletion1() {
2634 >    public void testRunAfterEither_exceptionalCompletion() {
2635          for (ExecutionMode m : ExecutionMode.values())
2636          for (Integer v1 : new Integer[] { 1, null })
2637      {
2638          final CompletableFuture<Integer> f = new CompletableFuture<>();
2639          final CompletableFuture<Integer> g = new CompletableFuture<>();
2223        final Noop r = new Noop(m);
2224        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2640          final CFException ex = new CFException();
2641 +        final Noop[] rs = new Noop[6];
2642 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2643  
2644 <        f.completeExceptionally(ex);
2645 <        checkCompletedWithWrappedCFException(h, ex);
2646 <        g.complete(v1);
2644 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2645 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2646 >        checkIncomplete(h0);
2647 >        checkIncomplete(h1);
2648 >        rs[0].assertNotInvoked();
2649 >        rs[1].assertNotInvoked();
2650 >        assertTrue(f.completeExceptionally(ex));
2651 >        checkCompletedWithWrappedException(h0, ex);
2652 >        checkCompletedWithWrappedException(h1, ex);
2653 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2654 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2655 >        checkCompletedWithWrappedException(h2, ex);
2656 >        checkCompletedWithWrappedException(h3, ex);
2657  
2658 <        assertEquals(0, r.invocationCount);
2232 <        checkCompletedNormally(g, v1);
2233 <        checkCompletedWithWrappedCFException(f, ex);
2234 <        checkCompletedWithWrappedCFException(h, ex);
2235 <    }}
2658 >        assertTrue(g.complete(v1));
2659  
2660 <    public void testRunAfterEither_exceptionalCompletion2() {
2661 <        for (ExecutionMode m : ExecutionMode.values())
2662 <        for (Integer v1 : new Integer[] { 1, null })
2240 <    {
2241 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2242 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2243 <        final Noop r = new Noop(m);
2244 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2245 <        final CFException ex = new CFException();
2246 <
2247 <        g.completeExceptionally(ex);
2248 <        checkCompletedWithWrappedCFException(h, ex);
2249 <        f.complete(v1);
2250 <
2251 <        assertEquals(0, r.invocationCount);
2252 <        checkCompletedNormally(f, v1);
2253 <        checkCompletedWithWrappedCFException(g, ex);
2254 <        checkCompletedWithWrappedCFException(h, ex);
2255 <    }}
2256 <
2257 <    public void testRunAfterEither_exceptionalCompletion3() {
2258 <        for (ExecutionMode m : ExecutionMode.values())
2259 <        for (Integer v1 : new Integer[] { 1, null })
2260 <    {
2261 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2262 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2263 <        final Noop r = new Noop(m);
2264 <        final CFException ex = new CFException();
2265 <
2266 <        g.completeExceptionally(ex);
2267 <        f.complete(v1);
2268 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2269 <
2270 <        // unspecified behavior
2271 <        Integer v;
2660 >        // unspecified behavior - both source completions available
2661 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2662 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2663          try {
2664 <            assertNull(h.join());
2665 <            assertEquals(1, r.invocationCount);
2664 >            assertNull(h4.join());
2665 >            rs[4].assertInvoked();
2666          } catch (CompletionException ok) {
2667 <            checkCompletedWithWrappedCFException(h, ex);
2668 <            assertEquals(0, r.invocationCount);
2667 >            checkCompletedWithWrappedException(h4, ex);
2668 >            rs[4].assertNotInvoked();
2669          }
2279
2280        checkCompletedWithWrappedCFException(g, ex);
2281        checkCompletedNormally(f, v1);
2282    }}
2283
2284    public void testRunAfterEither_exceptionalCompletion4() {
2285        for (ExecutionMode m : ExecutionMode.values())
2286        for (Integer v1 : new Integer[] { 1, null })
2287    {
2288        final CompletableFuture<Integer> f = new CompletableFuture<>();
2289        final CompletableFuture<Integer> g = new CompletableFuture<>();
2290        final Noop r = new Noop(m);
2291        final CFException ex = new CFException();
2292
2293        f.completeExceptionally(ex);
2294        g.complete(v1);
2295        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2296
2297        // unspecified behavior
2298        Integer v;
2670          try {
2671 <            assertNull(h.join());
2672 <            assertEquals(1, r.invocationCount);
2671 >            assertNull(h5.join());
2672 >            rs[5].assertInvoked();
2673          } catch (CompletionException ok) {
2674 <            checkCompletedWithWrappedCFException(h, ex);
2675 <            assertEquals(0, r.invocationCount);
2674 >            checkCompletedWithWrappedException(h5, ex);
2675 >            rs[5].assertNotInvoked();
2676          }
2677  
2678 <        checkCompletedWithWrappedCFException(f, ex);
2678 >        checkCompletedExceptionally(f, ex);
2679          checkCompletedNormally(g, v1);
2680 +        checkCompletedWithWrappedException(h0, ex);
2681 +        checkCompletedWithWrappedException(h1, ex);
2682 +        checkCompletedWithWrappedException(h2, ex);
2683 +        checkCompletedWithWrappedException(h3, ex);
2684 +        checkCompletedWithWrappedException(h4, ex);
2685 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2686      }}
2687  
2688 <    /**
2312 <     * runAfterEither result completes exceptionally if action does
2313 <     */
2314 <    public void testRunAfterEither_actionFailed1() {
2688 >    public void testRunAfterEither_exceptionalCompletion2() {
2689          for (ExecutionMode m : ExecutionMode.values())
2690 +        for (boolean fFirst : new boolean[] { true, false })
2691          for (Integer v1 : new Integer[] { 1, null })
2317        for (Integer v2 : new Integer[] { 2, null })
2692      {
2693          final CompletableFuture<Integer> f = new CompletableFuture<>();
2694          final CompletableFuture<Integer> g = new CompletableFuture<>();
2695 <        final FailingRunnable r = new FailingRunnable();
2696 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2695 >        final CFException ex = new CFException();
2696 >        final Noop[] rs = new Noop[6];
2697 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2698  
2699 <        f.complete(v1);
2700 <        checkCompletedWithWrappedCFException(h);
2701 <        g.complete(v2);
2702 <        checkCompletedNormally(f, v1);
2703 <        checkCompletedNormally(g, v2);
2704 <    }}
2699 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2700 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2701 >        assertTrue( fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2702 >        assertTrue(!fFirst ? f.complete(v1) : g.completeExceptionally(ex));
2703 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2704 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2705  
2706 <    public void testRunAfterEither_actionFailed2() {
2707 <        for (ExecutionMode m : ExecutionMode.values())
2708 <        for (Integer v1 : new Integer[] { 1, null })
2709 <        for (Integer v2 : new Integer[] { 2, null })
2710 <    {
2711 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2712 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2713 <        final FailingRunnable r = new FailingRunnable();
2714 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2706 >        // unspecified behavior - both source completions available
2707 >        try {
2708 >            assertEquals(null, h0.join());
2709 >            rs[0].assertInvoked();
2710 >        } catch (CompletionException ok) {
2711 >            checkCompletedWithWrappedException(h0, ex);
2712 >            rs[0].assertNotInvoked();
2713 >        }
2714 >        try {
2715 >            assertEquals(null, h1.join());
2716 >            rs[1].assertInvoked();
2717 >        } catch (CompletionException ok) {
2718 >            checkCompletedWithWrappedException(h1, ex);
2719 >            rs[1].assertNotInvoked();
2720 >        }
2721 >        try {
2722 >            assertEquals(null, h2.join());
2723 >            rs[2].assertInvoked();
2724 >        } catch (CompletionException ok) {
2725 >            checkCompletedWithWrappedException(h2, ex);
2726 >            rs[2].assertNotInvoked();
2727 >        }
2728 >        try {
2729 >            assertEquals(null, h3.join());
2730 >            rs[3].assertInvoked();
2731 >        } catch (CompletionException ok) {
2732 >            checkCompletedWithWrappedException(h3, ex);
2733 >            rs[3].assertNotInvoked();
2734 >        }
2735  
2341        g.complete(v2);
2342        checkCompletedWithWrappedCFException(h);
2343        f.complete(v1);
2736          checkCompletedNormally(f, v1);
2737 <        checkCompletedNormally(g, v2);
2737 >        checkCompletedExceptionally(g, ex);
2738      }}
2739  
2740      /**
2741       * runAfterEither result completes exceptionally if either source cancelled
2742       */
2743 <    public void testRunAfterEither_sourceCancelled1() {
2743 >    public void testRunAfterEither_sourceCancelled() {
2744          for (ExecutionMode m : ExecutionMode.values())
2745          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2746          for (Integer v1 : new Integer[] { 1, null })
2747      {
2748          final CompletableFuture<Integer> f = new CompletableFuture<>();
2749          final CompletableFuture<Integer> g = new CompletableFuture<>();
2750 <        final Noop r = new Noop(m);
2751 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2360 <
2361 <        assertTrue(f.cancel(mayInterruptIfRunning));
2362 <        checkCompletedWithWrappedCancellationException(h);
2363 <        g.complete(v1);
2750 >        final Noop[] rs = new Noop[6];
2751 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2752  
2753 <        checkCancelled(f);
2754 <        assertEquals(0, r.invocationCount);
2755 <        checkCompletedNormally(g, v1);
2756 <        checkCompletedWithWrappedCancellationException(h);
2757 <    }}
2758 <
2759 <    public void testRunAfterEither_sourceCancelled2() {
2760 <        for (ExecutionMode m : ExecutionMode.values())
2761 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2762 <        for (Integer v1 : new Integer[] { 1, null })
2763 <    {
2764 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2765 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2766 <        final Noop r = new Noop(m);
2767 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2768 <
2769 <        assertTrue(g.cancel(mayInterruptIfRunning));
2770 <        checkCompletedWithWrappedCancellationException(h);
2771 <        f.complete(v1);
2384 <
2385 <        checkCancelled(g);
2386 <        assertEquals(0, r.invocationCount);
2387 <        checkCompletedNormally(f, v1);
2388 <        checkCompletedWithWrappedCancellationException(h);
2389 <    }}
2390 <
2391 <    public void testRunAfterEither_sourceCancelled3() {
2392 <        for (ExecutionMode m : ExecutionMode.values())
2393 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2394 <        for (Integer v1 : new Integer[] { 1, null })
2395 <    {
2396 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2397 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2398 <        final Noop r = new Noop(m);
2399 <
2400 <        assertTrue(g.cancel(mayInterruptIfRunning));
2401 <        f.complete(v1);
2402 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2403 <
2404 <        // unspecified behavior
2405 <        Integer v;
2753 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2754 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2755 >        checkIncomplete(h0);
2756 >        checkIncomplete(h1);
2757 >        rs[0].assertNotInvoked();
2758 >        rs[1].assertNotInvoked();
2759 >        f.cancel(mayInterruptIfRunning);
2760 >        checkCompletedWithWrappedCancellationException(h0);
2761 >        checkCompletedWithWrappedCancellationException(h1);
2762 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2763 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2764 >        checkCompletedWithWrappedCancellationException(h2);
2765 >        checkCompletedWithWrappedCancellationException(h3);
2766 >
2767 >        assertTrue(g.complete(v1));
2768 >
2769 >        // unspecified behavior - both source completions available
2770 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2771 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2772          try {
2773 <            assertNull(h.join());
2774 <            assertEquals(1, r.invocationCount);
2773 >            assertNull(h4.join());
2774 >            rs[4].assertInvoked();
2775          } catch (CompletionException ok) {
2776 <            checkCompletedWithWrappedCancellationException(h);
2777 <            assertEquals(0, r.invocationCount);
2776 >            checkCompletedWithWrappedCancellationException(h4);
2777 >            rs[4].assertNotInvoked();
2778 >        }
2779 >        try {
2780 >            assertNull(h5.join());
2781 >            rs[5].assertInvoked();
2782 >        } catch (CompletionException ok) {
2783 >            checkCompletedWithWrappedCancellationException(h5);
2784 >            rs[5].assertNotInvoked();
2785          }
2786  
2787 <        checkCancelled(g);
2788 <        checkCompletedNormally(f, v1);
2787 >        checkCancelled(f);
2788 >        checkCompletedNormally(g, v1);
2789 >        checkCompletedWithWrappedCancellationException(h0);
2790 >        checkCompletedWithWrappedCancellationException(h1);
2791 >        checkCompletedWithWrappedCancellationException(h2);
2792 >        checkCompletedWithWrappedCancellationException(h3);
2793 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2794      }}
2795  
2796 <    public void testRunAfterEither_sourceCancelled4() {
2796 >    /**
2797 >     * runAfterEither result completes exceptionally if action does
2798 >     */
2799 >    public void testRunAfterEither_actionFailed() {
2800          for (ExecutionMode m : ExecutionMode.values())
2420        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2801          for (Integer v1 : new Integer[] { 1, null })
2802 +        for (Integer v2 : new Integer[] { 2, null })
2803      {
2804          final CompletableFuture<Integer> f = new CompletableFuture<>();
2805          final CompletableFuture<Integer> g = new CompletableFuture<>();
2806 <        final Noop r = new Noop(m);
2807 <
2427 <        assertTrue(f.cancel(mayInterruptIfRunning));
2428 <        g.complete(v1);
2429 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2806 >        final FailingRunnable[] rs = new FailingRunnable[6];
2807 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2808  
2809 <        // unspecified behavior
2810 <        Integer v;
2811 <        try {
2812 <            assertNull(h.join());
2813 <            assertEquals(1, r.invocationCount);
2814 <        } catch (CompletionException ok) {
2815 <            checkCompletedWithWrappedCancellationException(h);
2816 <            assertEquals(0, r.invocationCount);
2817 <        }
2809 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2810 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2811 >        assertTrue(f.complete(v1));
2812 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2813 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2814 >        checkCompletedWithWrappedCFException(h0);
2815 >        checkCompletedWithWrappedCFException(h1);
2816 >        checkCompletedWithWrappedCFException(h2);
2817 >        checkCompletedWithWrappedCFException(h3);
2818 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2819 >        assertTrue(g.complete(v2));
2820 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2821 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2822 >        checkCompletedWithWrappedCFException(h4);
2823 >        checkCompletedWithWrappedCFException(h5);
2824  
2825 <        checkCancelled(f);
2826 <        checkCompletedNormally(g, v1);
2825 >        checkCompletedNormally(f, v1);
2826 >        checkCompletedNormally(g, v2);
2827 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2828      }}
2829  
2830      /**
# Line 2451 | Line 2836 | public class CompletableFutureTest exten
2836          for (Integer v1 : new Integer[] { 1, null })
2837      {
2838          final CompletableFuture<Integer> f = new CompletableFuture<>();
2839 <        final CompletableFutureInc r = new CompletableFutureInc();
2840 <        if (!createIncomplete) f.complete(v1);
2841 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2842 <        if (createIncomplete) f.complete(v1);
2839 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2840 >        if (!createIncomplete) assertTrue(f.complete(v1));
2841 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2842 >        if (createIncomplete) assertTrue(f.complete(v1));
2843  
2844          checkCompletedNormally(g, inc(v1));
2845          checkCompletedNormally(f, v1);
2846 <        assertEquals(1, r.invocationCount);
2846 >        r.assertValue(v1);
2847      }}
2848  
2849      /**
# Line 2470 | Line 2855 | public class CompletableFutureTest exten
2855          for (boolean createIncomplete : new boolean[] { true, false })
2856      {
2857          final CFException ex = new CFException();
2858 <        final CompletableFutureInc r = new CompletableFutureInc();
2858 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2859          final CompletableFuture<Integer> f = new CompletableFuture<>();
2860          if (!createIncomplete) f.completeExceptionally(ex);
2861 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2861 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2862          if (createIncomplete) f.completeExceptionally(ex);
2863  
2864 <        checkCompletedWithWrappedCFException(g, ex);
2865 <        checkCompletedWithWrappedCFException(f, ex);
2866 <        assertEquals(0, r.invocationCount);
2864 >        checkCompletedWithWrappedException(g, ex);
2865 >        checkCompletedExceptionally(f, ex);
2866 >        r.assertNotInvoked();
2867      }}
2868  
2869      /**
# Line 2491 | Line 2876 | public class CompletableFutureTest exten
2876      {
2877          final CompletableFuture<Integer> f = new CompletableFuture<>();
2878          final FailingCompletableFutureFunction r
2879 <            = new FailingCompletableFutureFunction();
2880 <        if (!createIncomplete) f.complete(v1);
2881 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2882 <        if (createIncomplete) f.complete(v1);
2879 >            = new FailingCompletableFutureFunction(m);
2880 >        if (!createIncomplete) assertTrue(f.complete(v1));
2881 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2882 >        if (createIncomplete) assertTrue(f.complete(v1));
2883  
2884          checkCompletedWithWrappedCFException(g);
2885          checkCompletedNormally(f, v1);
# Line 2509 | Line 2894 | public class CompletableFutureTest exten
2894          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2895      {
2896          final CompletableFuture<Integer> f = new CompletableFuture<>();
2897 <        final CompletableFutureInc r = new CompletableFutureInc();
2897 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2898          if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2899 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2899 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2900          if (createIncomplete) {
2901              checkIncomplete(g);
2902              assertTrue(f.cancel(mayInterruptIfRunning));
# Line 2538 | Line 2923 | public class CompletableFutureTest exten
2923       */
2924      public void testAllOf_normal() throws Exception {
2925          for (int k = 1; k < 20; ++k) {
2926 <            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2926 >            CompletableFuture<Integer>[] fs
2927 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2928              for (int i = 0; i < k; ++i)
2929                  fs[i] = new CompletableFuture<>();
2930              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
# Line 2552 | Line 2938 | public class CompletableFutureTest exten
2938          }
2939      }
2940  
2941 +    public void testAllOf_backwards() throws Exception {
2942 +        for (int k = 1; k < 20; ++k) {
2943 +            CompletableFuture<Integer>[] fs
2944 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2945 +            for (int i = 0; i < k; ++i)
2946 +                fs[i] = new CompletableFuture<>();
2947 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
2948 +            for (int i = k - 1; i >= 0; i--) {
2949 +                checkIncomplete(f);
2950 +                checkIncomplete(CompletableFuture.allOf(fs));
2951 +                fs[i].complete(one);
2952 +            }
2953 +            checkCompletedNormally(f, null);
2954 +            checkCompletedNormally(CompletableFuture.allOf(fs), null);
2955 +        }
2956 +    }
2957 +
2958      /**
2959       * anyOf(no component futures) returns an incomplete future
2960       */
# Line 2610 | Line 3013 | public class CompletableFutureTest exten
3013          Runnable[] throwingActions = {
3014              () -> CompletableFuture.supplyAsync(null),
3015              () -> CompletableFuture.supplyAsync(null, exec),
3016 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
3016 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
3017  
3018              () -> CompletableFuture.runAsync(null),
3019              () -> CompletableFuture.runAsync(null, exec),
# Line 2683 | Line 3086 | public class CompletableFutureTest exten
3086  
3087              () -> f.thenCompose(null),
3088              () -> f.thenComposeAsync(null),
3089 <            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
3089 >            () -> f.thenComposeAsync(new CompletableFutureInc(ExecutionMode.EXECUTOR), null),
3090              () -> f.thenComposeAsync(null, exec),
3091  
3092              () -> f.exceptionally(null),
# Line 2715 | Line 3118 | public class CompletableFutureTest exten
3118          assertSame(f, f.toCompletableFuture());
3119      }
3120  
3121 <    /**
2719 <     * whenComplete action executes on normal completion, propagating
2720 <     * source result.
2721 <     */
2722 <    public void testWhenComplete_normalCompletion1() {
2723 <        for (ExecutionMode m : ExecutionMode.values())
2724 <        for (boolean createIncomplete : new boolean[] { true, false })
2725 <        for (Integer v1 : new Integer[] { 1, null })
2726 <    {
2727 <        final AtomicInteger a = new AtomicInteger(0);
2728 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2729 <        if (!createIncomplete) f.complete(v1);
2730 <        final CompletableFuture<Integer> g = m.whenComplete
2731 <            (f,
2732 <             (Integer x, Throwable t) -> {
2733 <                threadAssertSame(x, v1);
2734 <                threadAssertNull(t);
2735 <                a.getAndIncrement();
2736 <            });
2737 <        if (createIncomplete) f.complete(v1);
2738 <
2739 <        checkCompletedNormally(g, v1);
2740 <        checkCompletedNormally(f, v1);
2741 <        assertEquals(1, a.get());
2742 <    }}
2743 <
2744 <    /**
2745 <     * whenComplete action executes on exceptional completion, propagating
2746 <     * source result.
2747 <     */
2748 <    public void testWhenComplete_exceptionalCompletion() {
2749 <        for (ExecutionMode m : ExecutionMode.values())
2750 <        for (boolean createIncomplete : new boolean[] { true, false })
2751 <        for (Integer v1 : new Integer[] { 1, null })
2752 <    {
2753 <        final AtomicInteger a = new AtomicInteger(0);
2754 <        final CFException ex = new CFException();
2755 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2756 <        if (!createIncomplete) f.completeExceptionally(ex);
2757 <        final CompletableFuture<Integer> g = m.whenComplete
2758 <            (f,
2759 <             (Integer x, Throwable t) -> {
2760 <                threadAssertNull(x);
2761 <                threadAssertSame(t, ex);
2762 <                a.getAndIncrement();
2763 <            });
2764 <        if (createIncomplete) f.completeExceptionally(ex);
2765 <        checkCompletedWithWrappedCFException(f, ex);
2766 <        checkCompletedWithWrappedCFException(g, ex);
2767 <        assertEquals(1, a.get());
2768 <    }}
2769 <
2770 <    /**
2771 <     * whenComplete action executes on cancelled source, propagating
2772 <     * CancellationException.
2773 <     */
2774 <    public void testWhenComplete_sourceCancelled() {
2775 <        for (ExecutionMode m : ExecutionMode.values())
2776 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2777 <        for (boolean createIncomplete : new boolean[] { true, false })
2778 <    {
2779 <        final AtomicInteger a = new AtomicInteger(0);
2780 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2781 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2782 <        final CompletableFuture<Integer> g = m.whenComplete
2783 <            (f,
2784 <             (Integer x, Throwable t) -> {
2785 <                threadAssertNull(x);
2786 <                threadAssertTrue(t instanceof CancellationException);
2787 <                a.getAndIncrement();
2788 <            });
2789 <        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2790 <
2791 <        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2792 <        checkCompletedWithWrappedCancellationException(g);
2793 <        checkCancelled(f);
2794 <        assertEquals(1, a.get());
2795 <    }}
3121 >    //--- tests of implementation details; not part of official tck ---
3122  
3123 <    /**
3124 <     * If a whenComplete action throws an exception when triggered by
3125 <     * a normal completion, it completes exceptionally
3126 <     */
3127 <    public void testWhenComplete_actionFailed() {
3128 <        for (boolean createIncomplete : new boolean[] { true, false })
3129 <        for (ExecutionMode m : ExecutionMode.values())
3130 <        for (Integer v1 : new Integer[] { 1, null })
2805 <    {
2806 <        final AtomicInteger a = new AtomicInteger(0);
2807 <        final CFException ex = new CFException();
2808 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2809 <        if (!createIncomplete) f.complete(v1);
2810 <        final CompletableFuture<Integer> g = m.whenComplete
2811 <            (f,
2812 <             (Integer x, Throwable t) -> {
2813 <                threadAssertSame(x, v1);
2814 <                threadAssertNull(t);
2815 <                a.getAndIncrement();
2816 <                throw ex;
2817 <            });
2818 <        if (createIncomplete) f.complete(v1);
2819 <        checkCompletedNormally(f, v1);
2820 <        checkCompletedWithWrappedCFException(g, ex);
2821 <        assertEquals(1, a.get());
2822 <    }}
3123 >    Object resultOf(CompletableFuture<?> f) {
3124 >        try {
3125 >            java.lang.reflect.Field resultField
3126 >                = CompletableFuture.class.getDeclaredField("result");
3127 >            resultField.setAccessible(true);
3128 >            return resultField.get(f);
3129 >        } catch (Throwable t) { throw new AssertionError(t); }
3130 >    }
3131  
3132 <    /**
3133 <     * If a whenComplete action throws an exception when triggered by
2826 <     * a source completion that also throws an exception, the source
2827 <     * exception takes precedence.
2828 <     */
2829 <    public void testWhenComplete_actionFailedSourceFailed() {
2830 <        for (boolean createIncomplete : new boolean[] { true, false })
3132 >    public void testExceptionPropagationReusesResultObject() {
3133 >        if (!testImplementationDetails) return;
3134          for (ExecutionMode m : ExecutionMode.values())
2832        for (Integer v1 : new Integer[] { 1, null })
3135      {
3136 <        final AtomicInteger a = new AtomicInteger(0);
3137 <        final CFException ex1 = new CFException();
3138 <        final CFException ex2 = new CFException();
3139 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
3140 <
3141 <        if (!createIncomplete) f.completeExceptionally(ex1);
3142 <        final CompletableFuture<Integer> g = m.whenComplete
3143 <            (f,
3144 <             (Integer x, Throwable t) -> {
3145 <                threadAssertSame(t, ex1);
3146 <                threadAssertNull(x);
3147 <                a.getAndIncrement();
3148 <                throw ex2;
3149 <            });
3150 <        if (createIncomplete) f.completeExceptionally(ex1);
3151 <
3152 <        checkCompletedWithWrappedCFException(f, ex1);
3153 <        checkCompletedWithWrappedCFException(g, ex1);
3154 <        assertEquals(1, a.get());
3155 <    }}
3136 >        final CompletableFuture<Void> f = new CompletableFuture<>();
3137 >        CFException ex = new CFException();
3138 >        f.completeExceptionally(ex);
3139 >        final CompletableFuture<Void> g = f.thenRun(new Noop(m));
3140 >        checkCompletedWithWrappedException(g, ex);
3141 >        final CompletableFuture<Void> h = g.thenRun(new Noop(m));
3142 >        checkCompletedWithWrappedException(h, ex);
3143 >        assertSame(resultOf(g), resultOf(h));
3144 >    }}
3145 >
3146 > //     public void testRunAfterEither_resultDeterminedAtTimeOfCreation() {
3147 > //         for (ExecutionMode m : ExecutionMode.values())
3148 > //         for (boolean mayInterruptIfRunning : new boolean[] { true, false })
3149 > //         for (Integer v1 : new Integer[] { 1, null })
3150 > //     {
3151 > //         final CompletableFuture<Integer> f = new CompletableFuture<>();
3152 > //         final CompletableFuture<Integer> g = new CompletableFuture<>();
3153 > //         final Noop[] rs = new Noop[2];
3154 > //         for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
3155 > //         f.complete(v1);
3156 > //         final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
3157 > //         final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
3158 > //         assertTrue(g.cancel(mayInterruptIfRunning));
3159 > //         checkCompletedNormally(h0, null);
3160 > //         checkCompletedNormally(h1, null);
3161 > //         for (Noop r : rs) r.assertInvoked();
3162 > //     }}
3163  
3164   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines