ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.43 by jsr166, Mon Jun 2 04:13:54 2014 UTC vs.
Revision 1.56 by jsr166, Mon Jun 2 22:20:32 2014 UTC

# Line 17 | Line 17 | import java.util.concurrent.Future;
17   import java.util.concurrent.CompletableFuture;
18   import java.util.concurrent.CompletionException;
19   import java.util.concurrent.CompletionStage;
20 + import java.util.concurrent.ForkJoinPool;
21 + import java.util.concurrent.ForkJoinTask;
22   import java.util.concurrent.TimeoutException;
23   import java.util.concurrent.atomic.AtomicInteger;
24   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 247 | Line 249 | public class CompletableFutureTest exten
249          f = new CompletableFuture<>();
250          f.obtrudeValue(three);
251          checkCompletedNormally(f, three);
252 +        f.obtrudeValue(null);
253 +        checkCompletedNormally(f, null);
254          f = new CompletableFuture<>();
255          f.completeExceptionally(new CFException());
256          f.obtrudeValue(four);
# Line 279 | Line 283 | public class CompletableFutureTest exten
283       */
284      public void testGetNumberOfDependents() {
285          CompletableFuture<Integer> f = new CompletableFuture<>();
286 <        assertEquals(f.getNumberOfDependents(), 0);
287 <        CompletableFuture g = f.thenRun(new Noop());
288 <        assertEquals(f.getNumberOfDependents(), 1);
289 <        assertEquals(g.getNumberOfDependents(), 0);
290 <        CompletableFuture h = f.thenRun(new Noop());
291 <        assertEquals(f.getNumberOfDependents(), 2);
286 >        assertEquals(0, f.getNumberOfDependents());
287 >        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
288 >        assertEquals(1, f.getNumberOfDependents());
289 >        assertEquals(0, g.getNumberOfDependents());
290 >        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
291 >        assertEquals(2, f.getNumberOfDependents());
292          f.complete(1);
293          checkCompletedNormally(g, null);
294 <        assertEquals(f.getNumberOfDependents(), 0);
295 <        assertEquals(g.getNumberOfDependents(), 0);
294 >        assertEquals(0, f.getNumberOfDependents());
295 >        assertEquals(0, g.getNumberOfDependents());
296      }
297  
298      /**
# Line 339 | Line 343 | public class CompletableFutureTest exten
343      static final class IncAction implements Consumer<Integer> {
344          int invocationCount = 0;
345          Integer value;
342        public boolean ran() { return invocationCount == 1; }
346          public void accept(Integer x) {
347              invocationCount++;
348              value = inc(x);
349          }
350      }
351      static final class IncFunction implements Function<Integer,Integer> {
352 +        final ExecutionMode m;
353          int invocationCount = 0;
354          Integer value;
355 <        public boolean ran() { return invocationCount == 1; }
355 >        IncFunction(ExecutionMode m) { this.m = m; }
356          public Integer apply(Integer x) {
357 +            m.checkExecutionMode();
358              invocationCount++;
359              return value = inc(x);
360          }
361      }
362      static final class SubtractAction implements BiConsumer<Integer, Integer> {
363 +        final ExecutionMode m;
364          int invocationCount = 0;
365          Integer value;
366          // Check this action was invoked exactly once when result is computed.
367 <        public boolean ran() { return invocationCount == 1; }
367 >        SubtractAction(ExecutionMode m) { this.m = m; }
368          public void accept(Integer x, Integer y) {
369 +            m.checkExecutionMode();
370              invocationCount++;
371              value = subtract(x, y);
372          }
373      }
374      static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
375 +        final ExecutionMode m;
376          int invocationCount = 0;
377          Integer value;
378          // Check this action was invoked exactly once when result is computed.
379 <        public boolean ran() { return invocationCount == 1; }
379 >        SubtractFunction(ExecutionMode m) { this.m = m; }
380          public Integer apply(Integer x, Integer y) {
381 +            m.checkExecutionMode();
382              invocationCount++;
383              return value = subtract(x, y);
384          }
385      }
386      static final class Noop implements Runnable {
387 +        final ExecutionMode m;
388          int invocationCount = 0;
389 <        boolean ran;
389 >        Noop(ExecutionMode m) { this.m = m; }
390          public void run() {
391 +            m.checkExecutionMode();
392              invocationCount++;
382            ran = true;
393          }
394      }
395  
396      static final class FailingSupplier implements Supplier<Integer> {
397 <        boolean ran;
398 <        public Integer get() { ran = true; throw new CFException(); }
397 >        final ExecutionMode m;
398 >        int invocationCount = 0;
399 >        FailingSupplier(ExecutionMode m) { this.m = m; }
400 >        public Integer get() {
401 >            m.checkExecutionMode();
402 >            invocationCount++;
403 >            throw new CFException();
404 >        }
405      }
406      static final class FailingConsumer implements Consumer<Integer> {
407 <        boolean ran;
408 <        public void accept(Integer x) { ran = true; throw new CFException(); }
407 >        final ExecutionMode m;
408 >        int invocationCount = 0;
409 >        FailingConsumer(ExecutionMode m) { this.m = m; }
410 >        public void accept(Integer x) {
411 >            m.checkExecutionMode();
412 >            invocationCount++;
413 >            throw new CFException();
414 >        }
415      }
416      static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
417 <        boolean ran;
418 <        public void accept(Integer x, Integer y) { ran = true; throw new CFException(); }
417 >        final ExecutionMode m;
418 >        int invocationCount = 0;
419 >        FailingBiConsumer(ExecutionMode m) { this.m = m; }
420 >        public void accept(Integer x, Integer y) {
421 >            m.checkExecutionMode();
422 >            invocationCount++;
423 >            throw new CFException();
424 >        }
425      }
426      static final class FailingFunction implements Function<Integer, Integer> {
427 <        boolean ran;
428 <        public Integer apply(Integer x) { ran = true; throw new CFException(); }
427 >        final ExecutionMode m;
428 >        int invocationCount = 0;
429 >        FailingFunction(ExecutionMode m) { this.m = m; }
430 >        public Integer apply(Integer x) {
431 >            m.checkExecutionMode();
432 >            invocationCount++;
433 >            throw new CFException();
434 >        }
435      }
436      static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
437 <        boolean ran;
438 <        public Integer apply(Integer x, Integer y) { ran = true; throw new CFException(); }
437 >        final ExecutionMode m;
438 >        int invocationCount = 0;
439 >        FailingBiFunction(ExecutionMode m) { this.m = m; }
440 >        public Integer apply(Integer x, Integer y) {
441 >            m.checkExecutionMode();
442 >            invocationCount++;
443 >            throw new CFException();
444 >        }
445      }
446 <    static final class FailingNoop implements Runnable {
447 <        boolean ran;
448 <        public void run() { ran = true; throw new CFException(); }
446 >    static final class FailingRunnable implements Runnable {
447 >        final ExecutionMode m;
448 >        int invocationCount = 0;
449 >        FailingRunnable(ExecutionMode m) { this.m = m; }
450 >        public void run() {
451 >            m.checkExecutionMode();
452 >            invocationCount++;
453 >            throw new CFException();
454 >        }
455      }
456  
457      static final class CompletableFutureInc
458          implements Function<Integer, CompletableFuture<Integer>> {
459 <        boolean ran;
459 >        final ExecutionMode m;
460 >        int invocationCount = 0;
461 >        CompletableFutureInc(ExecutionMode m) { this.m = m; }
462          public CompletableFuture<Integer> apply(Integer x) {
463 <            ran = true;
463 >            m.checkExecutionMode();
464 >            invocationCount++;
465              CompletableFuture<Integer> f = new CompletableFuture<>();
466 <            f.complete(Integer.valueOf(x.intValue() + 1));
466 >            f.complete(inc(x));
467              return f;
468          }
469      }
470  
471      static final class FailingCompletableFutureFunction
472          implements Function<Integer, CompletableFuture<Integer>> {
473 <        boolean ran;
473 >        final ExecutionMode m;
474 >        int invocationCount = 0;
475 >        FailingCompletableFutureFunction(ExecutionMode m) { this.m = m; }
476          public CompletableFuture<Integer> apply(Integer x) {
477 <            ran = true; throw new CFException();
477 >            m.checkExecutionMode();
478 >            invocationCount++;
479 >            throw new CFException();
480          }
481      }
482  
483      // Used for explicit executor tests
484      static final class ThreadExecutor implements Executor {
485 <        AtomicInteger count = new AtomicInteger(0);
485 >        final AtomicInteger count = new AtomicInteger(0);
486 >        static final ThreadGroup tg = new ThreadGroup("ThreadExecutor");
487 >        static boolean startedCurrentThread() {
488 >            return Thread.currentThread().getThreadGroup() == tg;
489 >        }
490  
491          public void execute(Runnable r) {
492              count.getAndIncrement();
493 <            new Thread(r).start();
437 <        }
438 <    }
439 <
440 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
441 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
442 <    }
443 <
444 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
445 <        boolean ran;
446 <        public Integer apply(Integer x, Throwable t) {
447 <            ran = true;
448 <            return (t == null) ? two : three;
493 >            new Thread(tg, r).start();
494          }
495      }
496  
# Line 455 | Line 500 | public class CompletableFutureTest exten
500       */
501      enum ExecutionMode {
502          DEFAULT {
503 +            public void checkExecutionMode() {
504 +                assertNull(ForkJoinTask.getPool());
505 +            }
506 +            public <T> CompletableFuture<Void> thenRun
507 +                (CompletableFuture<T> f, Runnable a) {
508 +                return f.thenRun(a);
509 +            }
510 +            public <T> CompletableFuture<Void> thenAccept
511 +                (CompletableFuture<T> f, Consumer<? super T> a) {
512 +                return f.thenAccept(a);
513 +            }
514 +            public <T,U> CompletableFuture<U> thenApply
515 +                (CompletableFuture<T> f, Function<? super T,U> a) {
516 +                return f.thenApply(a);
517 +            }
518 +            public <T,U> CompletableFuture<U> thenCompose
519 +                (CompletableFuture<T> f,
520 +                 Function<? super T,? extends CompletionStage<U>> a) {
521 +                return f.thenCompose(a);
522 +            }
523 +            public <T,U> CompletableFuture<U> handle
524 +                (CompletableFuture<T> f,
525 +                 BiFunction<? super T,Throwable,? extends U> a) {
526 +                return f.handle(a);
527 +            }
528 +            public <T> CompletableFuture<T> whenComplete
529 +                (CompletableFuture<T> f,
530 +                 BiConsumer<? super T,? super Throwable> a) {
531 +                return f.whenComplete(a);
532 +            }
533              public <T,U> CompletableFuture<Void> runAfterBoth
534                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
535                  return f.runAfterBoth(g, a);
# Line 471 | Line 546 | public class CompletableFutureTest exten
546                   BiFunction<? super T,? super U,? extends V> a) {
547                  return f.thenCombine(g, a);
548              }
549 <            public <T,U> CompletableFuture<U> applyToEither
549 >            public <T> CompletableFuture<Void> runAfterEither
550                  (CompletableFuture<T> f,
551 <                 CompletionStage<? extends T> g,
552 <                 Function<? super T,U> a) {
553 <                return f.applyToEither(g, a);
551 >                 CompletionStage<?> g,
552 >                 java.lang.Runnable a) {
553 >                return f.runAfterEither(g, a);
554              }
555              public <T> CompletableFuture<Void> acceptEither
556                  (CompletableFuture<T> f,
# Line 483 | Line 558 | public class CompletableFutureTest exten
558                   Consumer<? super T> a) {
559                  return f.acceptEither(g, a);
560              }
561 <            public <T> CompletableFuture<Void> runAfterEither
561 >            public <T,U> CompletableFuture<U> applyToEither
562                  (CompletableFuture<T> f,
563 <                 CompletionStage<?> g,
564 <                 java.lang.Runnable a) {
565 <                return f.runAfterEither(g, a);
563 >                 CompletionStage<? extends T> g,
564 >                 Function<? super T,U> a) {
565 >                return f.applyToEither(g, a);
566 >            }
567 >        },
568 >
569 >        ASYNC {
570 >            public void checkExecutionMode() {
571 >                assertSame(ForkJoinPool.commonPool(),
572 >                           ForkJoinTask.getPool());
573 >            }
574 >            public <T> CompletableFuture<Void> thenRun
575 >                (CompletableFuture<T> f, Runnable a) {
576 >                return f.thenRunAsync(a);
577 >            }
578 >            public <T> CompletableFuture<Void> thenAccept
579 >                (CompletableFuture<T> f, Consumer<? super T> a) {
580 >                return f.thenAcceptAsync(a);
581 >            }
582 >            public <T,U> CompletableFuture<U> thenApply
583 >                (CompletableFuture<T> f, Function<? super T,U> a) {
584 >                return f.thenApplyAsync(a);
585              }
586              public <T,U> CompletableFuture<U> thenCompose
587                  (CompletableFuture<T> f,
588                   Function<? super T,? extends CompletionStage<U>> a) {
589 <                return f.thenCompose(a);
589 >                return f.thenComposeAsync(a);
590 >            }
591 >            public <T,U> CompletableFuture<U> handle
592 >                (CompletableFuture<T> f,
593 >                 BiFunction<? super T,Throwable,? extends U> a) {
594 >                return f.handleAsync(a);
595              }
596              public <T> CompletableFuture<T> whenComplete
597                  (CompletableFuture<T> f,
598                   BiConsumer<? super T,? super Throwable> a) {
599 <                return f.whenComplete(a);
599 >                return f.whenCompleteAsync(a);
600              }
502        },
503
504 //             /** Experimental way to do more testing */
505 //         REVERSE_DEFAULT {
506 //             public <T,U> CompletableFuture<Void> runAfterBoth
507 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
508 //                 return g.runAfterBoth(f, a);
509 //             }
510 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
511 //                 (CompletableFuture<T> f,
512 //                  CompletionStage<? extends U> g,
513 //                  BiConsumer<? super T,? super U> a) {
514 //                 return DEFAULT.thenAcceptBoth(f, g, a);
515 //             }
516 //         },
517
518        DEFAULT_ASYNC {
601              public <T,U> CompletableFuture<Void> runAfterBoth
602                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
603                  return f.runAfterBothAsync(g, a);
# Line 532 | Line 614 | public class CompletableFutureTest exten
614                   BiFunction<? super T,? super U,? extends V> a) {
615                  return f.thenCombineAsync(g, a);
616              }
617 <            public <T,U> CompletableFuture<U> applyToEither
617 >            public <T> CompletableFuture<Void> runAfterEither
618                  (CompletableFuture<T> f,
619 <                 CompletionStage<? extends T> g,
620 <                 Function<? super T,U> a) {
621 <                return f.applyToEitherAsync(g, a);
619 >                 CompletionStage<?> g,
620 >                 java.lang.Runnable a) {
621 >                return f.runAfterEitherAsync(g, a);
622              }
623              public <T> CompletableFuture<Void> acceptEither
624                  (CompletableFuture<T> f,
# Line 544 | Line 626 | public class CompletableFutureTest exten
626                   Consumer<? super T> a) {
627                  return f.acceptEitherAsync(g, a);
628              }
629 <            public <T> CompletableFuture<Void> runAfterEither
629 >            public <T,U> CompletableFuture<U> applyToEither
630                  (CompletableFuture<T> f,
631 <                 CompletionStage<?> g,
632 <                 java.lang.Runnable a) {
633 <                return f.runAfterEitherAsync(g, a);
631 >                 CompletionStage<? extends T> g,
632 >                 Function<? super T,U> a) {
633 >                return f.applyToEitherAsync(g, a);
634 >            }
635 >        },
636 >
637 >        EXECUTOR {
638 >            public void checkExecutionMode() {
639 >                assertTrue(ThreadExecutor.startedCurrentThread());
640 >            }
641 >            public <T> CompletableFuture<Void> thenRun
642 >                (CompletableFuture<T> f, Runnable a) {
643 >                return f.thenRunAsync(a, new ThreadExecutor());
644 >            }
645 >            public <T> CompletableFuture<Void> thenAccept
646 >                (CompletableFuture<T> f, Consumer<? super T> a) {
647 >                return f.thenAcceptAsync(a, new ThreadExecutor());
648 >            }
649 >            public <T,U> CompletableFuture<U> thenApply
650 >                (CompletableFuture<T> f, Function<? super T,U> a) {
651 >                return f.thenApplyAsync(a, new ThreadExecutor());
652              }
653              public <T,U> CompletableFuture<U> thenCompose
654                  (CompletableFuture<T> f,
655                   Function<? super T,? extends CompletionStage<U>> a) {
656 <                return f.thenComposeAsync(a);
656 >                return f.thenComposeAsync(a, new ThreadExecutor());
657 >            }
658 >            public <T,U> CompletableFuture<U> handle
659 >                (CompletableFuture<T> f,
660 >                 BiFunction<? super T,Throwable,? extends U> a) {
661 >                return f.handleAsync(a, new ThreadExecutor());
662              }
663              public <T> CompletableFuture<T> whenComplete
664                  (CompletableFuture<T> f,
665                   BiConsumer<? super T,? super Throwable> a) {
666 <                return f.whenCompleteAsync(a);
666 >                return f.whenCompleteAsync(a, new ThreadExecutor());
667              }
563        },
564
565 //         REVERSE_DEFAULT_ASYNC {
566 //             public <T,U> CompletableFuture<Void> runAfterBoth
567 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
568 //                 return f.runAfterBothAsync(g, a);
569 //             }
570 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
571 //                 (CompletableFuture<T> f,
572 //                  CompletionStage<? extends U> g,
573 //                  BiConsumer<? super T,? super U> a) {
574 //                 return DEFAULT_ASYNC.thenAcceptBoth(f, g, a);
575 //             }
576 //         },
577
578        EXECUTOR {
668              public <T,U> CompletableFuture<Void> runAfterBoth
669                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
670                  return f.runAfterBothAsync(g, a, new ThreadExecutor());
# Line 592 | Line 681 | public class CompletableFutureTest exten
681                   BiFunction<? super T,? super U,? extends V> a) {
682                  return f.thenCombineAsync(g, a, new ThreadExecutor());
683              }
595            public <T,U> CompletableFuture<U> applyToEither
596                (CompletableFuture<T> f,
597                 CompletionStage<? extends T> g,
598                 Function<? super T,U> a) {
599                return f.applyToEitherAsync(g, a, new ThreadExecutor());
600            }
601            public <T> CompletableFuture<Void> acceptEither
602                (CompletableFuture<T> f,
603                 CompletionStage<? extends T> g,
604                 Consumer<? super T> a) {
605                return f.acceptEitherAsync(g, a, new ThreadExecutor());
606            }
684              public <T> CompletableFuture<Void> runAfterEither
685                  (CompletableFuture<T> f,
686                   CompletionStage<?> g,
687                   java.lang.Runnable a) {
688                  return f.runAfterEitherAsync(g, a, new ThreadExecutor());
689              }
690 <            public <T,U> CompletableFuture<U> thenCompose
690 >            public <T> CompletableFuture<Void> acceptEither
691                  (CompletableFuture<T> f,
692 <                 Function<? super T,? extends CompletionStage<U>> a) {
693 <                return f.thenComposeAsync(a, new ThreadExecutor());
692 >                 CompletionStage<? extends T> g,
693 >                 Consumer<? super T> a) {
694 >                return f.acceptEitherAsync(g, a, new ThreadExecutor());
695              }
696 <            public <T> CompletableFuture<T> whenComplete
696 >            public <T,U> CompletableFuture<U> applyToEither
697                  (CompletableFuture<T> f,
698 <                 BiConsumer<? super T,? super Throwable> a) {
699 <                return f.whenCompleteAsync(a, new ThreadExecutor());
698 >                 CompletionStage<? extends T> g,
699 >                 Function<? super T,U> a) {
700 >                return f.applyToEitherAsync(g, a, new ThreadExecutor());
701              }
702          };
703  
704 +        public abstract void checkExecutionMode();
705 +        public abstract <T> CompletableFuture<Void> thenRun
706 +            (CompletableFuture<T> f, Runnable a);
707 +        public abstract <T> CompletableFuture<Void> thenAccept
708 +            (CompletableFuture<T> f, Consumer<? super T> a);
709 +        public abstract <T,U> CompletableFuture<U> thenApply
710 +            (CompletableFuture<T> f, Function<? super T,U> a);
711 +        public abstract <T,U> CompletableFuture<U> thenCompose
712 +            (CompletableFuture<T> f,
713 +             Function<? super T,? extends CompletionStage<U>> a);
714 +        public abstract <T,U> CompletableFuture<U> handle
715 +            (CompletableFuture<T> f,
716 +             BiFunction<? super T,Throwable,? extends U> a);
717 +        public abstract <T> CompletableFuture<T> whenComplete
718 +            (CompletableFuture<T> f,
719 +             BiConsumer<? super T,? super Throwable> a);
720          public abstract <T,U> CompletableFuture<Void> runAfterBoth
721              (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
722          public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
# Line 632 | Line 727 | public class CompletableFutureTest exten
727              (CompletableFuture<T> f,
728               CompletionStage<? extends U> g,
729               BiFunction<? super T,? super U,? extends V> a);
635        public abstract <T,U> CompletableFuture<U> applyToEither
636            (CompletableFuture<T> f,
637             CompletionStage<? extends T> g,
638             Function<? super T,U> a);
639        public abstract <T> CompletableFuture<Void> acceptEither
640            (CompletableFuture<T> f,
641             CompletionStage<? extends T> g,
642             Consumer<? super T> a);
730          public abstract <T> CompletableFuture<Void> runAfterEither
731              (CompletableFuture<T> f,
732               CompletionStage<?> g,
733               java.lang.Runnable a);
734 <        public abstract <T,U> CompletableFuture<U> thenCompose
734 >        public abstract <T> CompletableFuture<Void> acceptEither
735              (CompletableFuture<T> f,
736 <             Function<? super T,? extends CompletionStage<U>> a);
737 <        public abstract <T> CompletableFuture<T> whenComplete
736 >             CompletionStage<? extends T> g,
737 >             Consumer<? super T> a);
738 >        public abstract <T,U> CompletableFuture<U> applyToEither
739              (CompletableFuture<T> f,
740 <             BiConsumer<? super T,? super Throwable> a);
740 >             CompletionStage<? extends T> g,
741 >             Function<? super T,U> a);
742 >    }
743  
744 +    /**
745 +     * exceptionally action is not invoked when source completes
746 +     * normally, and source result is propagated
747 +     */
748 +    public void testExceptionally_normalCompletion() {
749 +        for (boolean createIncomplete : new boolean[] { true, false })
750 +        for (Integer v1 : new Integer[] { 1, null })
751 +    {
752 +        final AtomicInteger a = new AtomicInteger(0);
753 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
754 +        if (!createIncomplete) f.complete(v1);
755 +        final CompletableFuture<Integer> g = f.exceptionally
756 +            ((Throwable t) -> {
757 +                // Should not be called
758 +                a.getAndIncrement();
759 +                throw new AssertionError();
760 +            });
761 +        if (createIncomplete) f.complete(v1);
762 +
763 +        checkCompletedNormally(g, v1);
764 +        checkCompletedNormally(f, v1);
765 +        assertEquals(0, a.get());
766 +    }}
767  
655    }
768  
769      /**
770       * exceptionally action completes with function value on source
771 <     * exception; otherwise with source value
771 >     * exception
772       */
773 <    public void testExceptionally() {
774 <        CompletableFuture<Integer> f = new CompletableFuture<>();
775 <        ExceptionToInteger r = new ExceptionToInteger();
776 <        CompletableFuture<Integer> g = f.exceptionally(r);
777 <        f.completeExceptionally(new CFException());
778 <        checkCompletedNormally(g, three);
773 >    public void testExceptionally_exceptionalCompletion() {
774 >        for (boolean createIncomplete : new boolean[] { true, false })
775 >        for (Integer v1 : new Integer[] { 1, null })
776 >    {
777 >        final AtomicInteger a = new AtomicInteger(0);
778 >        final CFException ex = new CFException();
779 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
780 >        if (!createIncomplete) f.completeExceptionally(ex);
781 >        final CompletableFuture<Integer> g = f.exceptionally
782 >            ((Throwable t) -> {
783 >                threadAssertSame(t, ex);
784 >                a.getAndIncrement();
785 >                return v1;
786 >            });
787 >        if (createIncomplete) f.completeExceptionally(ex);
788  
789 <        f = new CompletableFuture<>();
790 <        r = new ExceptionToInteger();
791 <        g = f.exceptionally(r);
792 <        f.complete(one);
793 <        checkCompletedNormally(g, one);
794 <    }
789 >        checkCompletedNormally(g, v1);
790 >        assertEquals(1, a.get());
791 >    }}
792 >
793 >    public void testExceptionally_exceptionalCompletionActionFailed() {
794 >        for (boolean createIncomplete : new boolean[] { true, false })
795 >        for (Integer v1 : new Integer[] { 1, null })
796 >    {
797 >        final AtomicInteger a = new AtomicInteger(0);
798 >        final CFException ex1 = new CFException();
799 >        final CFException ex2 = new CFException();
800 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
801 >        if (!createIncomplete) f.completeExceptionally(ex1);
802 >        final CompletableFuture<Integer> g = f.exceptionally
803 >            ((Throwable t) -> {
804 >                threadAssertSame(t, ex1);
805 >                a.getAndIncrement();
806 >                throw ex2;
807 >            });
808 >        if (createIncomplete) f.completeExceptionally(ex1);
809 >
810 >        checkCompletedWithWrappedCFException(g, ex2);
811 >        assertEquals(1, a.get());
812 >    }}
813 >
814 >    /**
815 >     * handle action completes normally with function value on normal
816 >     * completion of source
817 >     */
818 >    public void testHandle_normalCompletion() {
819 >        for (ExecutionMode m : ExecutionMode.values())
820 >        for (boolean createIncomplete : new boolean[] { true, false })
821 >        for (Integer v1 : new Integer[] { 1, null })
822 >    {
823 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
824 >        final AtomicInteger a = new AtomicInteger(0);
825 >        if (!createIncomplete) f.complete(v1);
826 >        final CompletableFuture<Integer> g = m.handle
827 >            (f,
828 >             (Integer x, Throwable t) -> {
829 >                threadAssertSame(x, v1);
830 >                threadAssertNull(t);
831 >                a.getAndIncrement();
832 >                return inc(v1);
833 >            });
834 >        if (createIncomplete) f.complete(v1);
835 >
836 >        checkCompletedNormally(g, inc(v1));
837 >        checkCompletedNormally(f, v1);
838 >        assertEquals(1, a.get());
839 >    }}
840  
841      /**
842 <     * handle action completes normally with function value on either
843 <     * normal or exceptional completion of source
842 >     * handle action completes normally with function value on
843 >     * exceptional completion of source
844       */
845 <    public void testHandle() {
846 <        CompletableFuture<Integer> f, g;
847 <        IntegerHandler r;
845 >    public void testHandle_exceptionalCompletion() {
846 >        for (ExecutionMode m : ExecutionMode.values())
847 >        for (boolean createIncomplete : new boolean[] { true, false })
848 >        for (Integer v1 : new Integer[] { 1, null })
849 >    {
850 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
851 >        final AtomicInteger a = new AtomicInteger(0);
852 >        final CFException ex = new CFException();
853 >        if (!createIncomplete) f.completeExceptionally(ex);
854 >        final CompletableFuture<Integer> g = m.handle
855 >            (f,
856 >             (Integer x, Throwable t) -> {
857 >                threadAssertNull(x);
858 >                threadAssertSame(t, ex);
859 >                a.getAndIncrement();
860 >                return v1;
861 >            });
862 >        if (createIncomplete) f.completeExceptionally(ex);
863  
864 <        f = new CompletableFuture<>();
865 <        f.completeExceptionally(new CFException());
866 <        g = f.handle(r = new IntegerHandler());
867 <        assertTrue(r.ran);
687 <        checkCompletedNormally(g, three);
864 >        checkCompletedNormally(g, v1);
865 >        checkCompletedWithWrappedCFException(f, ex);
866 >        assertEquals(1, a.get());
867 >    }}
868  
869 <        f = new CompletableFuture<>();
870 <        g = f.handle(r = new IntegerHandler());
871 <        assertFalse(r.ran);
872 <        f.completeExceptionally(new CFException());
873 <        checkCompletedNormally(g, three);
874 <        assertTrue(r.ran);
869 >    /**
870 >     * handle action completes normally with function value on
871 >     * cancelled source
872 >     */
873 >    public void testHandle_sourceCancelled() {
874 >        for (ExecutionMode m : ExecutionMode.values())
875 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
876 >        for (boolean createIncomplete : new boolean[] { true, false })
877 >        for (Integer v1 : new Integer[] { 1, null })
878 >    {
879 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
880 >        final AtomicInteger a = new AtomicInteger(0);
881 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
882 >        final CompletableFuture<Integer> g = m.handle
883 >            (f,
884 >             (Integer x, Throwable t) -> {
885 >                threadAssertNull(x);
886 >                threadAssertTrue(t instanceof CancellationException);
887 >                a.getAndIncrement();
888 >                return v1;
889 >            });
890 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
891  
892 <        f = new CompletableFuture<>();
893 <        f.complete(one);
894 <        g = f.handle(r = new IntegerHandler());
895 <        assertTrue(r.ran);
700 <        checkCompletedNormally(g, two);
892 >        checkCompletedNormally(g, v1);
893 >        checkCancelled(f);
894 >        assertEquals(1, a.get());
895 >    }}
896  
897 <        f = new CompletableFuture<>();
898 <        g = f.handle(r = new IntegerHandler());
899 <        assertFalse(r.ran);
900 <        f.complete(one);
901 <        assertTrue(r.ran);
902 <        checkCompletedNormally(g, two);
903 <    }
897 >    /**
898 >     * handle result completes exceptionally if action does
899 >     */
900 >    public void testHandle_sourceFailedActionFailed() {
901 >        for (ExecutionMode m : ExecutionMode.values())
902 >        for (boolean createIncomplete : new boolean[] { true, false })
903 >    {
904 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
905 >        final AtomicInteger a = new AtomicInteger(0);
906 >        final CFException ex1 = new CFException();
907 >        final CFException ex2 = new CFException();
908 >        if (!createIncomplete) f.completeExceptionally(ex1);
909 >        final CompletableFuture<Integer> g = m.handle
910 >            (f,
911 >             (Integer x, Throwable t) -> {
912 >                threadAssertNull(x);
913 >                threadAssertSame(ex1, t);
914 >                a.getAndIncrement();
915 >                throw ex2;
916 >            });
917 >        if (createIncomplete) f.completeExceptionally(ex1);
918 >
919 >        checkCompletedWithWrappedCFException(g, ex2);
920 >        checkCompletedWithWrappedCFException(f, ex1);
921 >        assertEquals(1, a.get());
922 >    }}
923 >
924 >    public void testHandle_sourceCompletedNormallyActionFailed() {
925 >        for (ExecutionMode m : ExecutionMode.values())
926 >        for (boolean createIncomplete : new boolean[] { true, false })
927 >        for (Integer v1 : new Integer[] { 1, null })
928 >    {
929 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
930 >        final AtomicInteger a = new AtomicInteger(0);
931 >        final CFException ex = new CFException();
932 >        if (!createIncomplete) f.complete(v1);
933 >        final CompletableFuture<Integer> g = m.handle
934 >            (f,
935 >             (Integer x, Throwable t) -> {
936 >                threadAssertSame(x, v1);
937 >                threadAssertNull(t);
938 >                a.getAndIncrement();
939 >                throw ex;
940 >            });
941 >        if (createIncomplete) f.complete(v1);
942 >
943 >        checkCompletedWithWrappedCFException(g, ex);
944 >        checkCompletedNormally(f, v1);
945 >        assertEquals(1, a.get());
946 >    }}
947  
948      /**
949       * runAsync completes after running Runnable
950       */
951      public void testRunAsync() {
952 <        Noop r = new Noop();
952 >        Noop r = new Noop(ExecutionMode.ASYNC);
953          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
954          assertNull(f.join());
955 <        assertTrue(r.ran);
955 >        assertEquals(1, r.invocationCount);
956          checkCompletedNormally(f, null);
957      }
958  
# Line 722 | Line 960 | public class CompletableFutureTest exten
960       * runAsync with executor completes after running Runnable
961       */
962      public void testRunAsync2() {
963 <        Noop r = new Noop();
963 >        Noop r = new Noop(ExecutionMode.EXECUTOR);
964          ThreadExecutor exec = new ThreadExecutor();
965          CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
966          assertNull(f.join());
967 <        assertTrue(r.ran);
967 >        assertEquals(1, r.invocationCount);
968          checkCompletedNormally(f, null);
969          assertEquals(1, exec.count.get());
970      }
# Line 735 | Line 973 | public class CompletableFutureTest exten
973       * failing runAsync completes exceptionally after running Runnable
974       */
975      public void testRunAsync3() {
976 <        FailingNoop r = new FailingNoop();
976 >        FailingRunnable r = new FailingRunnable(ExecutionMode.ASYNC);
977          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
978          checkCompletedWithWrappedCFException(f);
979 <        assertTrue(r.ran);
979 >        assertEquals(1, r.invocationCount);
980      }
981  
982      /**
# Line 765 | Line 1003 | public class CompletableFutureTest exten
1003       * Failing supplyAsync completes exceptionally
1004       */
1005      public void testSupplyAsync3() {
1006 <        FailingSupplier r = new FailingSupplier();
1006 >        FailingSupplier r = new FailingSupplier(ExecutionMode.ASYNC);
1007          CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1008          checkCompletedWithWrappedCFException(f);
1009 <        assertTrue(r.ran);
1009 >        assertEquals(1, r.invocationCount);
1010      }
1011  
1012      // seq completion methods
# Line 776 | Line 1014 | public class CompletableFutureTest exten
1014      /**
1015       * thenRun result completes normally after normal completion of source
1016       */
1017 <    public void testThenRun() {
1018 <        CompletableFuture<Integer> f;
1019 <        CompletableFuture<Void> g;
1020 <        Noop r;
1021 <
1022 <        f = new CompletableFuture<>();
1023 <        g = f.thenRun(r = new Noop());
1024 <        f.complete(null);
1025 <        checkCompletedNormally(g, null);
1026 <        assertTrue(r.ran);
1017 >    public void testThenRun_normalCompletion() {
1018 >        for (ExecutionMode m : ExecutionMode.values())
1019 >        for (boolean createIncomplete : new boolean[] { true, false })
1020 >        for (Integer v1 : new Integer[] { 1, null })
1021 >    {
1022 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1023 >        final Noop r = new Noop(m);
1024 >        if (!createIncomplete) f.complete(v1);
1025 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1026 >        if (createIncomplete) {
1027 >            checkIncomplete(g);
1028 >            f.complete(v1);
1029 >        }
1030  
790        f = new CompletableFuture<>();
791        f.complete(null);
792        g = f.thenRun(r = new Noop());
1031          checkCompletedNormally(g, null);
1032 <        assertTrue(r.ran);
1033 <    }
1032 >        checkCompletedNormally(f, v1);
1033 >        assertEquals(1, r.invocationCount);
1034 >    }}
1035  
1036      /**
1037       * thenRun result completes exceptionally after exceptional
1038       * completion of source
1039       */
1040 <    public void testThenRun2() {
1041 <        CompletableFuture<Integer> f;
1042 <        CompletableFuture<Void> g;
1043 <        Noop r;
1044 <
1045 <        f = new CompletableFuture<>();
1046 <        g = f.thenRun(r = new Noop());
1047 <        f.completeExceptionally(new CFException());
1048 <        checkCompletedWithWrappedCFException(g);
1049 <        assertFalse(r.ran);
1040 >    public void testThenRun_exceptionalCompletion() {
1041 >        for (ExecutionMode m : ExecutionMode.values())
1042 >        for (boolean createIncomplete : new boolean[] { true, false })
1043 >    {
1044 >        final CFException ex = new CFException();
1045 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1046 >        final Noop r = new Noop(m);
1047 >        if (!createIncomplete) f.completeExceptionally(ex);
1048 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1049 >        if (createIncomplete) {
1050 >            checkIncomplete(g);
1051 >            f.completeExceptionally(ex);
1052 >        }
1053  
1054 <        f = new CompletableFuture<>();
1055 <        f.completeExceptionally(new CFException());
1056 <        g = f.thenRun(r = new Noop());
1057 <        checkCompletedWithWrappedCFException(g);
816 <        assertFalse(r.ran);
817 <    }
1054 >        checkCompletedWithWrappedCFException(g, ex);
1055 >        checkCompletedWithWrappedCFException(f, ex);
1056 >        assertEquals(0, r.invocationCount);
1057 >    }}
1058  
1059      /**
1060 <     * thenRun result completes exceptionally if action does
1060 >     * thenRun result completes exceptionally if source cancelled
1061       */
1062 <    public void testThenRun3() {
1063 <        CompletableFuture<Integer> f;
1064 <        CompletableFuture<Void> g;
1065 <        FailingNoop r;
1066 <
1067 <        f = new CompletableFuture<>();
1068 <        g = f.thenRun(r = new FailingNoop());
1069 <        f.complete(null);
1070 <        checkCompletedWithWrappedCFException(g);
1062 >    public void testThenRun_sourceCancelled() {
1063 >        for (ExecutionMode m : ExecutionMode.values())
1064 >        for (boolean createIncomplete : new boolean[] { true, false })
1065 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1066 >    {
1067 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1068 >        final Noop r = new Noop(m);
1069 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1070 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1071 >        if (createIncomplete) {
1072 >            checkIncomplete(g);
1073 >            assertTrue(f.cancel(mayInterruptIfRunning));
1074 >        }
1075  
1076 <        f = new CompletableFuture<>();
1077 <        f.complete(null);
1078 <        g = f.thenRun(r = new FailingNoop());
1079 <        checkCompletedWithWrappedCFException(g);
836 <    }
1076 >        checkCompletedWithWrappedCancellationException(g);
1077 >        checkCancelled(f);
1078 >        assertEquals(0, r.invocationCount);
1079 >    }}
1080  
1081      /**
1082 <     * thenRun result completes exceptionally if source cancelled
1082 >     * thenRun result completes exceptionally if action does
1083       */
1084 <    public void testThenRun4() {
1085 <        CompletableFuture<Integer> f;
1086 <        CompletableFuture<Void> g;
1087 <        Noop r;
1088 <
1089 <        f = new CompletableFuture<>();
1090 <        g = f.thenRun(r = new Noop());
1091 <        assertTrue(f.cancel(true));
1092 <        checkCompletedWithWrappedCancellationException(g);
1084 >    public void testThenRun_actionFailed() {
1085 >        for (ExecutionMode m : ExecutionMode.values())
1086 >        for (boolean createIncomplete : new boolean[] { true, false })
1087 >        for (Integer v1 : new Integer[] { 1, null })
1088 >    {
1089 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1090 >        final FailingRunnable r = new FailingRunnable(m);
1091 >        if (!createIncomplete) f.complete(v1);
1092 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1093 >        if (createIncomplete) {
1094 >            checkIncomplete(g);
1095 >            f.complete(v1);
1096 >        }
1097  
1098 <        f = new CompletableFuture<>();
1099 <        assertTrue(f.cancel(true));
1100 <        g = f.thenRun(r = new Noop());
854 <        checkCompletedWithWrappedCancellationException(g);
855 <    }
1098 >        checkCompletedWithWrappedCFException(g);
1099 >        checkCompletedNormally(f, v1);
1100 >    }}
1101  
1102      /**
1103       * thenApply result completes normally after normal completion of source
1104       */
1105 <    public void testThenApply() {
1106 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1107 <        CompletableFuture<Integer> g = f.thenApply(inc);
1108 <        f.complete(one);
1109 <        checkCompletedNormally(g, two);
1110 <    }
1105 >    public void testThenApply_normalCompletion() {
1106 >        for (ExecutionMode m : ExecutionMode.values())
1107 >        for (boolean createIncomplete : new boolean[] { true, false })
1108 >        for (Integer v1 : new Integer[] { 1, null })
1109 >    {
1110 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1111 >        final IncFunction r = new IncFunction(m);
1112 >        if (!createIncomplete) f.complete(v1);
1113 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1114 >        if (createIncomplete) {
1115 >            checkIncomplete(g);
1116 >            f.complete(v1);
1117 >        }
1118 >
1119 >        checkCompletedNormally(g, inc(v1));
1120 >        checkCompletedNormally(f, v1);
1121 >        assertEquals(1, r.invocationCount);
1122 >    }}
1123  
1124      /**
1125       * thenApply result completes exceptionally after exceptional
1126       * completion of source
1127       */
1128 <    public void testThenApply2() {
1129 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1130 <        CompletableFuture<Integer> g = f.thenApply(inc);
1131 <        f.completeExceptionally(new CFException());
1132 <        checkCompletedWithWrappedCFException(g);
1133 <    }
1128 >    public void testThenApply_exceptionalCompletion() {
1129 >        for (ExecutionMode m : ExecutionMode.values())
1130 >        for (boolean createIncomplete : new boolean[] { true, false })
1131 >    {
1132 >        final CFException ex = new CFException();
1133 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1134 >        final IncFunction r = new IncFunction(m);
1135 >        if (!createIncomplete) f.completeExceptionally(ex);
1136 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1137 >        if (createIncomplete) {
1138 >            checkIncomplete(g);
1139 >            f.completeExceptionally(ex);
1140 >        }
1141  
1142 <    /**
1143 <     * thenApply result completes exceptionally if action does
1144 <     */
1145 <    public void testThenApply3() {
882 <        CompletableFuture<Integer> f = new CompletableFuture<>();
883 <        CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
884 <        f.complete(one);
885 <        checkCompletedWithWrappedCFException(g);
886 <    }
1142 >        checkCompletedWithWrappedCFException(g, ex);
1143 >        checkCompletedWithWrappedCFException(f, ex);
1144 >        assertEquals(0, r.invocationCount);
1145 >    }}
1146  
1147      /**
1148       * thenApply result completes exceptionally if source cancelled
1149       */
1150 <    public void testThenApply4() {
1151 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1152 <        CompletableFuture<Integer> g = f.thenApply(inc);
1153 <        assertTrue(f.cancel(true));
1150 >    public void testThenApply_sourceCancelled() {
1151 >        for (ExecutionMode m : ExecutionMode.values())
1152 >        for (boolean createIncomplete : new boolean[] { true, false })
1153 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1154 >    {
1155 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1156 >        final IncFunction r = new IncFunction(m);
1157 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1158 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1159 >        if (createIncomplete) {
1160 >            checkIncomplete(g);
1161 >            assertTrue(f.cancel(mayInterruptIfRunning));
1162 >        }
1163 >
1164          checkCompletedWithWrappedCancellationException(g);
1165 <    }
1165 >        checkCancelled(f);
1166 >        assertEquals(0, r.invocationCount);
1167 >    }}
1168 >
1169 >    /**
1170 >     * thenApply result completes exceptionally if action does
1171 >     */
1172 >    public void testThenApply_actionFailed() {
1173 >        for (ExecutionMode m : ExecutionMode.values())
1174 >        for (boolean createIncomplete : new boolean[] { true, false })
1175 >        for (Integer v1 : new Integer[] { 1, null })
1176 >    {
1177 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1178 >        final FailingFunction r = new FailingFunction(m);
1179 >        if (!createIncomplete) f.complete(v1);
1180 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1181 >        if (createIncomplete) {
1182 >            checkIncomplete(g);
1183 >            f.complete(v1);
1184 >        }
1185 >
1186 >        checkCompletedWithWrappedCFException(g);
1187 >        checkCompletedNormally(f, v1);
1188 >    }}
1189  
1190      /**
1191       * thenAccept result completes normally after normal completion of source
1192       */
1193 <    public void testThenAccept() {
1194 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1195 <        IncAction r = new IncAction();
1196 <        CompletableFuture<Void> g = f.thenAccept(r);
1197 <        f.complete(one);
1193 >    public void testThenAccept_normalCompletion() {
1194 >        for (ExecutionMode m : ExecutionMode.values())
1195 >        for (boolean createIncomplete : new boolean[] { true, false })
1196 >        for (Integer v1 : new Integer[] { 1, null })
1197 >    {
1198 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1199 >        final IncAction r = new IncAction();
1200 >        if (!createIncomplete) f.complete(v1);
1201 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1202 >        if (createIncomplete) {
1203 >            checkIncomplete(g);
1204 >            f.complete(v1);
1205 >        }
1206 >
1207          checkCompletedNormally(g, null);
1208 <        assertEquals(r.value, (Integer) 2);
1209 <    }
1208 >        checkCompletedNormally(f, v1);
1209 >        assertEquals(1, r.invocationCount);
1210 >        assertEquals(inc(v1), r.value);
1211 >    }}
1212  
1213      /**
1214       * thenAccept result completes exceptionally after exceptional
1215       * completion of source
1216       */
1217 <    public void testThenAccept2() {
1218 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1219 <        IncAction r = new IncAction();
1220 <        CompletableFuture<Void> g = f.thenAccept(r);
1221 <        f.completeExceptionally(new CFException());
1222 <        checkCompletedWithWrappedCFException(g);
1223 <    }
1217 >    public void testThenAccept_exceptionalCompletion() {
1218 >        for (ExecutionMode m : ExecutionMode.values())
1219 >        for (boolean createIncomplete : new boolean[] { true, false })
1220 >    {
1221 >        final CFException ex = new CFException();
1222 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1223 >        final IncAction r = new IncAction();
1224 >        if (!createIncomplete) f.completeExceptionally(ex);
1225 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1226 >        if (createIncomplete) {
1227 >            checkIncomplete(g);
1228 >            f.completeExceptionally(ex);
1229 >        }
1230 >
1231 >        checkCompletedWithWrappedCFException(g, ex);
1232 >        checkCompletedWithWrappedCFException(f, ex);
1233 >        assertEquals(0, r.invocationCount);
1234 >    }}
1235  
1236      /**
1237       * thenAccept result completes exceptionally if action does
1238       */
1239 <    public void testThenAccept3() {
1240 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1241 <        FailingConsumer r = new FailingConsumer();
1242 <        CompletableFuture<Void> g = f.thenAccept(r);
1243 <        f.complete(one);
1239 >    public void testThenAccept_actionFailed() {
1240 >        for (ExecutionMode m : ExecutionMode.values())
1241 >        for (boolean createIncomplete : new boolean[] { true, false })
1242 >        for (Integer v1 : new Integer[] { 1, null })
1243 >    {
1244 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1245 >        final FailingConsumer r = new FailingConsumer(m);
1246 >        if (!createIncomplete) f.complete(v1);
1247 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1248 >        if (createIncomplete) {
1249 >            checkIncomplete(g);
1250 >            f.complete(v1);
1251 >        }
1252 >
1253          checkCompletedWithWrappedCFException(g);
1254 <        assertTrue(r.ran);
1255 <    }
1254 >        checkCompletedNormally(f, v1);
1255 >    }}
1256  
1257      /**
1258       * thenAccept result completes exceptionally if source cancelled
1259       */
1260 <    public void testThenAccept4() {
1261 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1262 <        IncAction r = new IncAction();
1263 <        CompletableFuture<Void> g = f.thenAccept(r);
1264 <        assertTrue(f.cancel(true));
1260 >    public void testThenAccept_sourceCancelled() {
1261 >        for (ExecutionMode m : ExecutionMode.values())
1262 >        for (boolean createIncomplete : new boolean[] { true, false })
1263 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1264 >    {
1265 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1266 >        final IncAction r = new IncAction();
1267 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1268 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1269 >        if (createIncomplete) {
1270 >            checkIncomplete(g);
1271 >            assertTrue(f.cancel(mayInterruptIfRunning));
1272 >        }
1273 >
1274          checkCompletedWithWrappedCancellationException(g);
1275 <    }
1275 >        checkCancelled(f);
1276 >        assertEquals(0, r.invocationCount);
1277 >    }}
1278  
1279      /**
1280       * thenCombine result completes normally after normal completion
1281       * of sources
1282       */
1283 <    public void testThenCombine_normalCompletion1() {
950 <        for (boolean createdIncomplete : new boolean[] { true, false })
951 <        for (boolean fFirst : new boolean[] { true, false })
1283 >    public void testThenCombine_normalCompletion() {
1284          for (ExecutionMode m : ExecutionMode.values())
1285 +        for (boolean createIncomplete : new boolean[] { true, false })
1286 +        for (boolean fFirst : new boolean[] { true, false })
1287          for (Integer v1 : new Integer[] { 1, null })
1288 <        for (Integer v2 : new Integer[] { 2, null }) {
1289 <
1288 >        for (Integer v2 : new Integer[] { 2, null })
1289 >    {
1290          final CompletableFuture<Integer> f = new CompletableFuture<>();
1291          final CompletableFuture<Integer> g = new CompletableFuture<>();
1292 <        final SubtractFunction r = new SubtractFunction();
959 <        CompletableFuture<Integer> h = null;
960 <        if (createdIncomplete) h = m.thenCombine(f, g, r);
1292 >        final SubtractFunction r = new SubtractFunction(m);
1293  
1294 <        if (fFirst)
1295 <            f.complete(v1);
1296 <        else
1297 <            g.complete(v2);
1298 <        if (createdIncomplete) checkIncomplete(h);
1299 <        assertEquals(r.invocationCount, 0);
1300 <        if (!fFirst)
1301 <            f.complete(v1);
1302 <        else
971 <            g.complete(v2);
972 <        if (!createdIncomplete) h = m.thenCombine(f, g, r);
1294 >        if (fFirst) f.complete(v1); else g.complete(v2);
1295 >        if (!createIncomplete)
1296 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1297 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1298 >        if (createIncomplete) {
1299 >            checkIncomplete(h);
1300 >            assertEquals(0, r.invocationCount);
1301 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1302 >        }
1303  
1304          checkCompletedNormally(h, subtract(v1, v2));
1305          checkCompletedNormally(f, v1);
1306          checkCompletedNormally(g, v2);
1307 <        assertEquals(r.invocationCount, 1);
1308 <        }
979 <    }
1307 >        assertEquals(1, r.invocationCount);
1308 >    }}
1309  
1310      /**
1311       * thenCombine result completes exceptionally after exceptional
1312       * completion of either source
1313       */
1314 <    public void testThenCombine_exceptionalCompletion1() {
986 <        for (ExecutionMode m : ExecutionMode.values())
987 <        for (Integer v1 : new Integer[] { 1, null }) {
988 <
989 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
990 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
991 <        final SubtractFunction r = new SubtractFunction();
992 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
993 <        final CFException ex = new CFException();
994 <
995 <        f.completeExceptionally(ex);
996 <        checkIncomplete(h);
997 <        g.complete(v1);
998 <
999 <        checkCompletedWithWrappedCFException(h, ex);
1000 <        checkCompletedWithWrappedCFException(f, ex);
1001 <        assertEquals(r.invocationCount, 0);
1002 <        checkCompletedNormally(g, v1);
1003 <        }
1004 <    }
1005 <
1006 <    public void testThenCombine_exceptionalCompletion2() {
1007 <        for (ExecutionMode m : ExecutionMode.values())
1008 <        for (Integer v1 : new Integer[] { 1, null }) {
1009 <
1010 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1011 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1012 <        final SubtractFunction r = new SubtractFunction();
1013 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1014 <        final CFException ex = new CFException();
1015 <
1016 <        g.completeExceptionally(ex);
1017 <        checkIncomplete(h);
1018 <        f.complete(v1);
1019 <
1020 <        checkCompletedWithWrappedCFException(h, ex);
1021 <        checkCompletedWithWrappedCFException(g, ex);
1022 <        assertEquals(r.invocationCount, 0);
1023 <        checkCompletedNormally(f, v1);
1024 <        }
1025 <    }
1026 <
1027 <    public void testThenCombine_exceptionalCompletion3() {
1314 >    public void testThenCombine_exceptionalCompletion() {
1315          for (ExecutionMode m : ExecutionMode.values())
1316 <        for (Integer v1 : new Integer[] { 1, null }) {
1317 <
1316 >        for (boolean createIncomplete : new boolean[] { true, false })
1317 >        for (boolean fFirst : new boolean[] { true, false })
1318 >        for (Integer v1 : new Integer[] { 1, null })
1319 >    {
1320          final CompletableFuture<Integer> f = new CompletableFuture<>();
1321          final CompletableFuture<Integer> g = new CompletableFuture<>();
1033        final SubtractFunction r = new SubtractFunction();
1322          final CFException ex = new CFException();
1323 +        final SubtractFunction r = new SubtractFunction(m);
1324  
1325 <        g.completeExceptionally(ex);
1326 <        f.complete(v1);
1325 >        (fFirst ? f : g).complete(v1);
1326 >        if (!createIncomplete)
1327 >            (!fFirst ? f : g).completeExceptionally(ex);
1328          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1329 <
1330 <        checkCompletedWithWrappedCFException(h, ex);
1331 <        checkCompletedWithWrappedCFException(g, ex);
1042 <        assertEquals(r.invocationCount, 0);
1043 <        checkCompletedNormally(f, v1);
1329 >        if (createIncomplete) {
1330 >            checkIncomplete(h);
1331 >            (!fFirst ? f : g).completeExceptionally(ex);
1332          }
1045    }
1046
1047    public void testThenCombine_exceptionalCompletion4() {
1048        for (ExecutionMode m : ExecutionMode.values())
1049        for (Integer v1 : new Integer[] { 1, null }) {
1050
1051        final CompletableFuture<Integer> f = new CompletableFuture<>();
1052        final CompletableFuture<Integer> g = new CompletableFuture<>();
1053        final SubtractFunction r = new SubtractFunction();
1054        final CFException ex = new CFException();
1055
1056        f.completeExceptionally(ex);
1057        g.complete(v1);
1058        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1333  
1334          checkCompletedWithWrappedCFException(h, ex);
1335 <        checkCompletedWithWrappedCFException(f, ex);
1336 <        assertEquals(r.invocationCount, 0);
1337 <        checkCompletedNormally(g, v1);
1338 <        }
1065 <    }
1335 >        assertEquals(0, r.invocationCount);
1336 >        checkCompletedNormally(fFirst ? f : g, v1);
1337 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1338 >    }}
1339  
1340      /**
1341       * thenCombine result completes exceptionally if action does
1342       */
1343 <    public void testThenCombine_actionFailed1() {
1343 >    public void testThenCombine_actionFailed() {
1344          for (ExecutionMode m : ExecutionMode.values())
1345 +        for (boolean fFirst : new boolean[] { true, false })
1346          for (Integer v1 : new Integer[] { 1, null })
1347 <        for (Integer v2 : new Integer[] { 2, null }) {
1348 <
1347 >        for (Integer v2 : new Integer[] { 2, null })
1348 >    {
1349          final CompletableFuture<Integer> f = new CompletableFuture<>();
1350          final CompletableFuture<Integer> g = new CompletableFuture<>();
1351 <        final FailingBiFunction r = new FailingBiFunction();
1351 >        final FailingBiFunction r = new FailingBiFunction(m);
1352          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1353  
1354 <        f.complete(v1);
1355 <        checkIncomplete(h);
1356 <        g.complete(v2);
1357 <
1358 <        checkCompletedWithWrappedCFException(h);
1359 <        checkCompletedNormally(f, v1);
1086 <        checkCompletedNormally(g, v2);
1354 >        if (fFirst) {
1355 >            f.complete(v1);
1356 >            g.complete(v2);
1357 >        } else {
1358 >            g.complete(v2);
1359 >            f.complete(v1);
1360          }
1088    }
1089
1090    public void testThenCombine_actionFailed2() {
1091        for (ExecutionMode m : ExecutionMode.values())
1092        for (Integer v1 : new Integer[] { 1, null })
1093        for (Integer v2 : new Integer[] { 2, null }) {
1094
1095        final CompletableFuture<Integer> f = new CompletableFuture<>();
1096        final CompletableFuture<Integer> g = new CompletableFuture<>();
1097        final FailingBiFunction r = new FailingBiFunction();
1098        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1099
1100        g.complete(v2);
1101        checkIncomplete(h);
1102        f.complete(v1);
1361  
1362          checkCompletedWithWrappedCFException(h);
1363          checkCompletedNormally(f, v1);
1364          checkCompletedNormally(g, v2);
1365 <        }
1108 <    }
1365 >    }}
1366  
1367      /**
1368       * thenCombine result completes exceptionally if either source cancelled
1369       */
1370 <    public void testThenCombine_sourceCancelled1() {
1114 <        for (ExecutionMode m : ExecutionMode.values())
1115 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1116 <        for (Integer v1 : new Integer[] { 1, null }) {
1117 <
1118 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1119 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1120 <        final SubtractFunction r = new SubtractFunction();
1121 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1122 <
1123 <        assertTrue(f.cancel(mayInterruptIfRunning));
1124 <        checkIncomplete(h);
1125 <        g.complete(v1);
1126 <
1127 <        checkCompletedWithWrappedCancellationException(h);
1128 <        checkCancelled(f);
1129 <        assertEquals(r.invocationCount, 0);
1130 <        checkCompletedNormally(g, v1);
1131 <        }
1132 <    }
1133 <
1134 <    public void testThenCombine_sourceCancelled2() {
1370 >    public void testThenCombine_sourceCancelled() {
1371          for (ExecutionMode m : ExecutionMode.values())
1372          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1373 <        for (Integer v1 : new Integer[] { 1, null }) {
1374 <
1375 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1376 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1141 <        final SubtractFunction r = new SubtractFunction();
1142 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1143 <
1144 <        assertTrue(g.cancel(mayInterruptIfRunning));
1145 <        checkIncomplete(h);
1146 <        f.complete(v1);
1147 <
1148 <        checkCompletedWithWrappedCancellationException(h);
1149 <        checkCancelled(g);
1150 <        assertEquals(r.invocationCount, 0);
1151 <        checkCompletedNormally(f, v1);
1152 <        }
1153 <    }
1154 <
1155 <    public void testThenCombine_sourceCancelled3() {
1156 <        for (ExecutionMode m : ExecutionMode.values())
1157 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1158 <        for (Integer v1 : new Integer[] { 1, null }) {
1159 <
1373 >        for (boolean createIncomplete : new boolean[] { true, false })
1374 >        for (boolean fFirst : new boolean[] { true, false })
1375 >        for (Integer v1 : new Integer[] { 1, null })
1376 >    {
1377          final CompletableFuture<Integer> f = new CompletableFuture<>();
1378          final CompletableFuture<Integer> g = new CompletableFuture<>();
1379 <        final SubtractFunction r = new SubtractFunction();
1379 >        final SubtractFunction r = new SubtractFunction(m);
1380  
1381 <        assertTrue(g.cancel(mayInterruptIfRunning));
1382 <        f.complete(v1);
1381 >        (fFirst ? f : g).complete(v1);
1382 >        if (!createIncomplete)
1383 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1384          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1385 <
1386 <        checkCompletedWithWrappedCancellationException(h);
1387 <        checkCancelled(g);
1170 <        assertEquals(r.invocationCount, 0);
1171 <        checkCompletedNormally(f, v1);
1385 >        if (createIncomplete) {
1386 >            checkIncomplete(h);
1387 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1388          }
1173    }
1174
1175    public void testThenCombine_sourceCancelled4() {
1176        for (ExecutionMode m : ExecutionMode.values())
1177        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1178        for (Integer v1 : new Integer[] { 1, null }) {
1179
1180        final CompletableFuture<Integer> f = new CompletableFuture<>();
1181        final CompletableFuture<Integer> g = new CompletableFuture<>();
1182        final SubtractFunction r = new SubtractFunction();
1183
1184        assertTrue(f.cancel(mayInterruptIfRunning));
1185        g.complete(v1);
1186        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1389  
1390          checkCompletedWithWrappedCancellationException(h);
1391 <        checkCancelled(f);
1392 <        assertEquals(r.invocationCount, 0);
1393 <        checkCompletedNormally(g, v1);
1394 <        }
1193 <    }
1391 >        checkCancelled(!fFirst ? f : g);
1392 >        assertEquals(0, r.invocationCount);
1393 >        checkCompletedNormally(fFirst ? f : g, v1);
1394 >    }}
1395  
1396      /**
1397       * thenAcceptBoth result completes normally after normal
1398       * completion of sources
1399       */
1400 <    public void testThenAcceptBoth_normalCompletion1() {
1200 <        for (ExecutionMode m : ExecutionMode.values())
1201 <        for (Integer v1 : new Integer[] { 1, null })
1202 <        for (Integer v2 : new Integer[] { 2, null }) {
1203 <
1204 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1205 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1206 <        final SubtractAction r = new SubtractAction();
1207 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1208 <
1209 <        f.complete(v1);
1210 <        checkIncomplete(h);
1211 <        assertFalse(r.ran());
1212 <        g.complete(v2);
1213 <
1214 <        checkCompletedNormally(h, null);
1215 <        assertEquals(r.value, subtract(v1, v2));
1216 <        checkCompletedNormally(f, v1);
1217 <        checkCompletedNormally(g, v2);
1218 <        }
1219 <    }
1220 <
1221 <    public void testThenAcceptBoth_normalCompletion2() {
1222 <        for (ExecutionMode m : ExecutionMode.values())
1223 <        for (Integer v1 : new Integer[] { 1, null })
1224 <        for (Integer v2 : new Integer[] { 2, null }) {
1225 <
1226 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1227 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1228 <        final SubtractAction r = new SubtractAction();
1229 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1230 <
1231 <        g.complete(v2);
1232 <        checkIncomplete(h);
1233 <        assertFalse(r.ran());
1234 <        f.complete(v1);
1235 <
1236 <        checkCompletedNormally(h, null);
1237 <        assertEquals(r.value, subtract(v1, v2));
1238 <        checkCompletedNormally(f, v1);
1239 <        checkCompletedNormally(g, v2);
1240 <        }
1241 <    }
1242 <
1243 <    public void testThenAcceptBoth_normalCompletion3() {
1400 >    public void testThenAcceptBoth_normalCompletion() {
1401          for (ExecutionMode m : ExecutionMode.values())
1402 +        for (boolean createIncomplete : new boolean[] { true, false })
1403 +        for (boolean fFirst : new boolean[] { true, false })
1404          for (Integer v1 : new Integer[] { 1, null })
1405 <        for (Integer v2 : new Integer[] { 2, null }) {
1406 <
1405 >        for (Integer v2 : new Integer[] { 2, null })
1406 >    {
1407          final CompletableFuture<Integer> f = new CompletableFuture<>();
1408          final CompletableFuture<Integer> g = new CompletableFuture<>();
1409 <        final SubtractAction r = new SubtractAction();
1409 >        final SubtractAction r = new SubtractAction(m);
1410  
1411 <        g.complete(v2);
1412 <        f.complete(v1);
1411 >        if (fFirst) f.complete(v1); else g.complete(v2);
1412 >        if (!createIncomplete)
1413 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1414          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1415 <
1416 <        checkCompletedNormally(h, null);
1417 <        assertEquals(r.value, subtract(v1, v2));
1418 <        checkCompletedNormally(f, v1);
1259 <        checkCompletedNormally(g, v2);
1415 >        if (createIncomplete) {
1416 >            checkIncomplete(h);
1417 >            assertEquals(0, r.invocationCount);
1418 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1419          }
1261    }
1262
1263    public void testThenAcceptBoth_normalCompletion4() {
1264        for (ExecutionMode m : ExecutionMode.values())
1265        for (Integer v1 : new Integer[] { 1, null })
1266        for (Integer v2 : new Integer[] { 2, null }) {
1267
1268        final CompletableFuture<Integer> f = new CompletableFuture<>();
1269        final CompletableFuture<Integer> g = new CompletableFuture<>();
1270        final SubtractAction r = new SubtractAction();
1271
1272        f.complete(v1);
1273        g.complete(v2);
1274        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1420  
1421          checkCompletedNormally(h, null);
1422 <        assertEquals(r.value, subtract(v1, v2));
1422 >        assertEquals(subtract(v1, v2), r.value);
1423          checkCompletedNormally(f, v1);
1424          checkCompletedNormally(g, v2);
1425 <        }
1281 <    }
1425 >    }}
1426  
1427      /**
1428       * thenAcceptBoth result completes exceptionally after exceptional
1429       * completion of either source
1430       */
1431 <    public void testThenAcceptBoth_exceptionalCompletion1() {
1288 <        for (ExecutionMode m : ExecutionMode.values())
1289 <        for (Integer v1 : new Integer[] { 1, null }) {
1290 <
1291 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1292 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1293 <        final SubtractAction r = new SubtractAction();
1294 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1295 <        final CFException ex = new CFException();
1296 <
1297 <        f.completeExceptionally(ex);
1298 <        checkIncomplete(h);
1299 <        g.complete(v1);
1300 <
1301 <        checkCompletedWithWrappedCFException(h, ex);
1302 <        checkCompletedWithWrappedCFException(f, ex);
1303 <        assertEquals(r.invocationCount, 0);
1304 <        checkCompletedNormally(g, v1);
1305 <        }
1306 <    }
1307 <
1308 <    public void testThenAcceptBoth_exceptionalCompletion2() {
1309 <        for (ExecutionMode m : ExecutionMode.values())
1310 <        for (Integer v1 : new Integer[] { 1, null }) {
1311 <
1312 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1313 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1314 <        final SubtractAction r = new SubtractAction();
1315 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1316 <        final CFException ex = new CFException();
1317 <
1318 <        g.completeExceptionally(ex);
1319 <        checkIncomplete(h);
1320 <        f.complete(v1);
1321 <
1322 <        checkCompletedWithWrappedCFException(h, ex);
1323 <        checkCompletedWithWrappedCFException(g, ex);
1324 <        assertEquals(r.invocationCount, 0);
1325 <        checkCompletedNormally(f, v1);
1326 <        }
1327 <    }
1328 <
1329 <    public void testThenAcceptBoth_exceptionalCompletion3() {
1431 >    public void testThenAcceptBoth_exceptionalCompletion() {
1432          for (ExecutionMode m : ExecutionMode.values())
1433 <        for (Integer v1 : new Integer[] { 1, null }) {
1434 <
1433 >        for (boolean createIncomplete : new boolean[] { true, false })
1434 >        for (boolean fFirst : new boolean[] { true, false })
1435 >        for (Integer v1 : new Integer[] { 1, null })
1436 >    {
1437          final CompletableFuture<Integer> f = new CompletableFuture<>();
1438          final CompletableFuture<Integer> g = new CompletableFuture<>();
1335        final SubtractAction r = new SubtractAction();
1439          final CFException ex = new CFException();
1440 +        final SubtractAction r = new SubtractAction(m);
1441  
1442 <        g.completeExceptionally(ex);
1443 <        f.complete(v1);
1442 >        (fFirst ? f : g).complete(v1);
1443 >        if (!createIncomplete)
1444 >            (!fFirst ? f : g).completeExceptionally(ex);
1445          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1446 <
1447 <        checkCompletedWithWrappedCFException(h, ex);
1448 <        checkCompletedWithWrappedCFException(g, ex);
1344 <        assertEquals(r.invocationCount, 0);
1345 <        checkCompletedNormally(f, v1);
1446 >        if (createIncomplete) {
1447 >            checkIncomplete(h);
1448 >            (!fFirst ? f : g).completeExceptionally(ex);
1449          }
1347    }
1348
1349    public void testThenAcceptBoth_exceptionalCompletion4() {
1350        for (ExecutionMode m : ExecutionMode.values())
1351        for (Integer v1 : new Integer[] { 1, null }) {
1352
1353        final CompletableFuture<Integer> f = new CompletableFuture<>();
1354        final CompletableFuture<Integer> g = new CompletableFuture<>();
1355        final SubtractAction r = new SubtractAction();
1356        final CFException ex = new CFException();
1357
1358        f.completeExceptionally(ex);
1359        g.complete(v1);
1360        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1450  
1451          checkCompletedWithWrappedCFException(h, ex);
1452 <        checkCompletedWithWrappedCFException(f, ex);
1453 <        assertFalse(r.ran());
1454 <        checkCompletedNormally(g, v1);
1455 <        }
1367 <    }
1452 >        assertEquals(0, r.invocationCount);
1453 >        checkCompletedNormally(fFirst ? f : g, v1);
1454 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1455 >    }}
1456  
1457      /**
1458       * thenAcceptBoth result completes exceptionally if action does
1459       */
1460 <    public void testThenAcceptBoth_actionFailed1() {
1460 >    public void testThenAcceptBoth_actionFailed() {
1461          for (ExecutionMode m : ExecutionMode.values())
1462 +        for (boolean fFirst : new boolean[] { true, false })
1463          for (Integer v1 : new Integer[] { 1, null })
1464 <        for (Integer v2 : new Integer[] { 2, null }) {
1465 <
1464 >        for (Integer v2 : new Integer[] { 2, null })
1465 >    {
1466          final CompletableFuture<Integer> f = new CompletableFuture<>();
1467          final CompletableFuture<Integer> g = new CompletableFuture<>();
1468 <        final FailingBiConsumer r = new FailingBiConsumer();
1468 >        final FailingBiConsumer r = new FailingBiConsumer(m);
1469          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1470  
1471 <        f.complete(v1);
1472 <        checkIncomplete(h);
1473 <        g.complete(v2);
1474 <
1475 <        checkCompletedWithWrappedCFException(h);
1476 <        checkCompletedNormally(f, v1);
1388 <        checkCompletedNormally(g, v2);
1471 >        if (fFirst) {
1472 >            f.complete(v1);
1473 >            g.complete(v2);
1474 >        } else {
1475 >            g.complete(v2);
1476 >            f.complete(v1);
1477          }
1390    }
1391
1392    public void testThenAcceptBoth_actionFailed2() {
1393        for (ExecutionMode m : ExecutionMode.values())
1394        for (Integer v1 : new Integer[] { 1, null })
1395        for (Integer v2 : new Integer[] { 2, null }) {
1396
1397        final CompletableFuture<Integer> f = new CompletableFuture<>();
1398        final CompletableFuture<Integer> g = new CompletableFuture<>();
1399        final FailingBiConsumer r = new FailingBiConsumer();
1400        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1401
1402        g.complete(v2);
1403        checkIncomplete(h);
1404        f.complete(v1);
1478  
1479          checkCompletedWithWrappedCFException(h);
1480          checkCompletedNormally(f, v1);
1481          checkCompletedNormally(g, v2);
1482 <        }
1410 <    }
1482 >    }}
1483  
1484      /**
1485       * thenAcceptBoth result completes exceptionally if either source cancelled
1486       */
1487 <    public void testThenAcceptBoth_sourceCancelled1() {
1416 <        for (ExecutionMode m : ExecutionMode.values())
1417 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1418 <        for (Integer v1 : new Integer[] { 1, null }) {
1419 <
1420 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1421 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1422 <        final SubtractAction r = new SubtractAction();
1423 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1424 <
1425 <        assertTrue(f.cancel(mayInterruptIfRunning));
1426 <        checkIncomplete(h);
1427 <        g.complete(v1);
1428 <
1429 <        checkCompletedWithWrappedCancellationException(h);
1430 <        checkCancelled(f);
1431 <        assertEquals(r.invocationCount, 0);
1432 <        checkCompletedNormally(g, v1);
1433 <        }
1434 <    }
1435 <
1436 <    public void testThenAcceptBoth_sourceCancelled2() {
1437 <        for (ExecutionMode m : ExecutionMode.values())
1438 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1439 <        for (Integer v1 : new Integer[] { 1, null }) {
1440 <
1441 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1442 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1443 <        final SubtractAction r = new SubtractAction();
1444 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1445 <
1446 <        assertTrue(g.cancel(mayInterruptIfRunning));
1447 <        checkIncomplete(h);
1448 <        f.complete(v1);
1449 <
1450 <        checkCompletedWithWrappedCancellationException(h);
1451 <        checkCancelled(g);
1452 <        assertEquals(r.invocationCount, 0);
1453 <        checkCompletedNormally(f, v1);
1454 <        }
1455 <    }
1456 <
1457 <    public void testThenAcceptBoth_sourceCancelled3() {
1487 >    public void testThenAcceptBoth_sourceCancelled() {
1488          for (ExecutionMode m : ExecutionMode.values())
1489          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1490 <        for (Integer v1 : new Integer[] { 1, null }) {
1491 <
1490 >        for (boolean createIncomplete : new boolean[] { true, false })
1491 >        for (boolean fFirst : new boolean[] { true, false })
1492 >        for (Integer v1 : new Integer[] { 1, null })
1493 >    {
1494          final CompletableFuture<Integer> f = new CompletableFuture<>();
1495          final CompletableFuture<Integer> g = new CompletableFuture<>();
1496 <        final SubtractAction r = new SubtractAction();
1496 >        final SubtractAction r = new SubtractAction(m);
1497  
1498 <        assertTrue(g.cancel(mayInterruptIfRunning));
1499 <        f.complete(v1);
1498 >        (fFirst ? f : g).complete(v1);
1499 >        if (!createIncomplete)
1500 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1501          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1502 <
1503 <        checkCompletedWithWrappedCancellationException(h);
1504 <        checkCancelled(g);
1472 <        assertEquals(r.invocationCount, 0);
1473 <        checkCompletedNormally(f, v1);
1502 >        if (createIncomplete) {
1503 >            checkIncomplete(h);
1504 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1505          }
1475    }
1476
1477    public void testThenAcceptBoth_sourceCancelled4() {
1478        for (ExecutionMode m : ExecutionMode.values())
1479        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1480        for (Integer v1 : new Integer[] { 1, null }) {
1481
1482        final CompletableFuture<Integer> f = new CompletableFuture<>();
1483        final CompletableFuture<Integer> g = new CompletableFuture<>();
1484        final SubtractAction r = new SubtractAction();
1485
1486        assertTrue(f.cancel(mayInterruptIfRunning));
1487        g.complete(v1);
1488        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1506  
1507          checkCompletedWithWrappedCancellationException(h);
1508 <        checkCancelled(f);
1509 <        assertEquals(r.invocationCount, 0);
1510 <        checkCompletedNormally(g, v1);
1511 <        }
1495 <    }
1508 >        checkCancelled(!fFirst ? f : g);
1509 >        assertEquals(0, r.invocationCount);
1510 >        checkCompletedNormally(fFirst ? f : g, v1);
1511 >    }}
1512  
1513      /**
1514       * runAfterBoth result completes normally after normal
1515       * completion of sources
1516       */
1517 <    public void testRunAfterBoth_normalCompletion1() {
1517 >    public void testRunAfterBoth_normalCompletion() {
1518          for (ExecutionMode m : ExecutionMode.values())
1519 +        for (boolean createIncomplete : new boolean[] { true, false })
1520 +        for (boolean fFirst : new boolean[] { true, false })
1521          for (Integer v1 : new Integer[] { 1, null })
1522 <        for (Integer v2 : new Integer[] { 2, null }) {
1523 <
1522 >        for (Integer v2 : new Integer[] { 2, null })
1523 >    {
1524          final CompletableFuture<Integer> f = new CompletableFuture<>();
1525          final CompletableFuture<Integer> g = new CompletableFuture<>();
1526 <        final Noop r = new Noop();
1509 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1526 >        final Noop r = new Noop(m);
1527  
1528 <        f.complete(v1);
1529 <        checkIncomplete(h);
1530 <        assertFalse(r.ran);
1514 <        g.complete(v2);
1515 <
1516 <        checkCompletedNormally(h, null);
1517 <        assertEquals(r.invocationCount, 1);
1518 <        checkCompletedNormally(f, v1);
1519 <        checkCompletedNormally(g, v2);
1520 <        }
1521 <    }
1522 <
1523 <    public void testRunAfterBoth_normalCompletion2() {
1524 <        for (ExecutionMode m : ExecutionMode.values())
1525 <        for (Integer v1 : new Integer[] { 1, null })
1526 <        for (Integer v2 : new Integer[] { 2, null }) {
1527 <
1528 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1529 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1530 <        final Noop r = new Noop();
1528 >        if (fFirst) f.complete(v1); else g.complete(v2);
1529 >        if (!createIncomplete)
1530 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1531          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1532 <
1533 <        g.complete(v2);
1534 <        checkIncomplete(h);
1535 <        assertFalse(r.ran);
1536 <        f.complete(v1);
1537 <
1538 <        checkCompletedNormally(h, null);
1539 <        assertEquals(r.invocationCount, 1);
1540 <        checkCompletedNormally(f, v1);
1541 <        checkCompletedNormally(g, v2);
1532 >        if (createIncomplete) {
1533 >            checkIncomplete(h);
1534 >            assertEquals(0, r.invocationCount);
1535 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1536          }
1543    }
1544
1545    public void testRunAfterBoth_normalCompletion3() {
1546        for (ExecutionMode m : ExecutionMode.values())
1547        for (Integer v1 : new Integer[] { 1, null })
1548        for (Integer v2 : new Integer[] { 2, null }) {
1549
1550        final CompletableFuture<Integer> f = new CompletableFuture<>();
1551        final CompletableFuture<Integer> g = new CompletableFuture<>();
1552        final Noop r = new Noop();
1553
1554        g.complete(v2);
1555        f.complete(v1);
1556        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1537  
1538          checkCompletedNormally(h, null);
1539 <        assertTrue(r.ran);
1539 >        assertEquals(1, r.invocationCount);
1540          checkCompletedNormally(f, v1);
1541          checkCompletedNormally(g, v2);
1542 <        }
1563 <    }
1564 <
1565 <    public void testRunAfterBoth_normalCompletion4() {
1566 <        for (ExecutionMode m : ExecutionMode.values())
1567 <        for (Integer v1 : new Integer[] { 1, null })
1568 <        for (Integer v2 : new Integer[] { 2, null }) {
1569 <
1570 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1571 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1572 <        final Noop r = new Noop();
1573 <
1574 <        f.complete(v1);
1575 <        g.complete(v2);
1576 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1577 <
1578 <        checkCompletedNormally(h, null);
1579 <        assertEquals(r.invocationCount, 1);
1580 <        checkCompletedNormally(f, v1);
1581 <        checkCompletedNormally(g, v2);
1582 <        }
1583 <    }
1542 >    }}
1543  
1544      /**
1545       * runAfterBoth result completes exceptionally after exceptional
1546       * completion of either source
1547       */
1548 <    public void testRunAfterBoth_exceptionalCompletion1() {
1590 <        for (ExecutionMode m : ExecutionMode.values())
1591 <        for (Integer v1 : new Integer[] { 1, null }) {
1592 <
1593 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1594 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1595 <        final Noop r = new Noop();
1596 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1597 <        final CFException ex = new CFException();
1598 <
1599 <        f.completeExceptionally(ex);
1600 <        checkIncomplete(h);
1601 <        g.complete(v1);
1602 <
1603 <        checkCompletedWithWrappedCFException(h, ex);
1604 <        checkCompletedWithWrappedCFException(f, ex);
1605 <        assertEquals(r.invocationCount, 0);
1606 <        checkCompletedNormally(g, v1);
1607 <        }
1608 <    }
1609 <
1610 <    public void testRunAfterBoth_exceptionalCompletion2() {
1548 >    public void testRunAfterBoth_exceptionalCompletion() {
1549          for (ExecutionMode m : ExecutionMode.values())
1550 <        for (Integer v1 : new Integer[] { 1, null }) {
1551 <
1552 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1553 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1616 <        final Noop r = new Noop();
1617 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1618 <        final CFException ex = new CFException();
1619 <
1620 <        g.completeExceptionally(ex);
1621 <        checkIncomplete(h);
1622 <        f.complete(v1);
1623 <
1624 <        checkCompletedWithWrappedCFException(h, ex);
1625 <        checkCompletedWithWrappedCFException(g, ex);
1626 <        assertEquals(r.invocationCount, 0);
1627 <        checkCompletedNormally(f, v1);
1628 <        }
1629 <    }
1630 <
1631 <    public void testRunAfterBoth_exceptionalCompletion3() {
1632 <        for (ExecutionMode m : ExecutionMode.values())
1633 <        for (Integer v1 : new Integer[] { 1, null }) {
1634 <
1550 >        for (boolean createIncomplete : new boolean[] { true, false })
1551 >        for (boolean fFirst : new boolean[] { true, false })
1552 >        for (Integer v1 : new Integer[] { 1, null })
1553 >    {
1554          final CompletableFuture<Integer> f = new CompletableFuture<>();
1555          final CompletableFuture<Integer> g = new CompletableFuture<>();
1637        final Noop r = new Noop();
1556          final CFException ex = new CFException();
1557 +        final Noop r = new Noop(m);
1558  
1559 <        g.completeExceptionally(ex);
1560 <        f.complete(v1);
1559 >        (fFirst ? f : g).complete(v1);
1560 >        if (!createIncomplete)
1561 >            (!fFirst ? f : g).completeExceptionally(ex);
1562          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1563 <
1564 <        checkCompletedWithWrappedCFException(h, ex);
1565 <        checkCompletedWithWrappedCFException(g, ex);
1646 <        assertEquals(r.invocationCount, 0);
1647 <        checkCompletedNormally(f, v1);
1563 >        if (createIncomplete) {
1564 >            checkIncomplete(h);
1565 >            (!fFirst ? f : g).completeExceptionally(ex);
1566          }
1649    }
1650
1651    public void testRunAfterBoth_exceptionalCompletion4() {
1652        for (ExecutionMode m : ExecutionMode.values())
1653        for (Integer v1 : new Integer[] { 1, null }) {
1654
1655        final CompletableFuture<Integer> f = new CompletableFuture<>();
1656        final CompletableFuture<Integer> g = new CompletableFuture<>();
1657        final Noop r = new Noop();
1658        final CFException ex = new CFException();
1659
1660        f.completeExceptionally(ex);
1661        g.complete(v1);
1662        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1567  
1568          checkCompletedWithWrappedCFException(h, ex);
1569 <        checkCompletedWithWrappedCFException(f, ex);
1570 <        assertEquals(r.invocationCount, 0);
1571 <        checkCompletedNormally(g, v1);
1572 <        }
1669 <    }
1569 >        assertEquals(0, r.invocationCount);
1570 >        checkCompletedNormally(fFirst ? f : g, v1);
1571 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1572 >    }}
1573  
1574      /**
1575       * runAfterBoth result completes exceptionally if action does
1576       */
1577 <    public void testRunAfterBoth_actionFailed1() {
1577 >    public void testRunAfterBoth_actionFailed() {
1578          for (ExecutionMode m : ExecutionMode.values())
1579 +        for (boolean fFirst : new boolean[] { true, false })
1580          for (Integer v1 : new Integer[] { 1, null })
1581 <        for (Integer v2 : new Integer[] { 2, null }) {
1582 <
1581 >        for (Integer v2 : new Integer[] { 2, null })
1582 >    {
1583          final CompletableFuture<Integer> f = new CompletableFuture<>();
1584          final CompletableFuture<Integer> g = new CompletableFuture<>();
1585 <        final FailingNoop r = new FailingNoop();
1682 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1683 <
1684 <        f.complete(v1);
1685 <        checkIncomplete(h);
1686 <        g.complete(v2);
1585 >        final FailingRunnable r = new FailingRunnable(m);
1586  
1587 <        checkCompletedWithWrappedCFException(h);
1588 <        checkCompletedNormally(f, v1);
1589 <        checkCompletedNormally(g, v2);
1587 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1588 >        if (fFirst) {
1589 >            f.complete(v1);
1590 >            g.complete(v2);
1591 >        } else {
1592 >            g.complete(v2);
1593 >            f.complete(v1);
1594          }
1595 <    }
1595 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1596  
1597 <    public void testRunAfterBoth_actionFailed2() {
1598 <        for (ExecutionMode m : ExecutionMode.values())
1696 <        for (Integer v1 : new Integer[] { 1, null })
1697 <        for (Integer v2 : new Integer[] { 2, null }) {
1698 <
1699 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1700 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1701 <        final FailingNoop r = new FailingNoop();
1702 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1703 <
1704 <        g.complete(v2);
1705 <        checkIncomplete(h);
1706 <        f.complete(v1);
1707 <
1708 <        checkCompletedWithWrappedCFException(h);
1597 >        checkCompletedWithWrappedCFException(h1);
1598 >        checkCompletedWithWrappedCFException(h2);
1599          checkCompletedNormally(f, v1);
1600          checkCompletedNormally(g, v2);
1601 <        }
1712 <    }
1601 >    }}
1602  
1603      /**
1604       * runAfterBoth result completes exceptionally if either source cancelled
1605       */
1606 <    public void testRunAfterBoth_sourceCancelled1() {
1718 <        for (ExecutionMode m : ExecutionMode.values())
1719 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1720 <        for (Integer v1 : new Integer[] { 1, null }) {
1721 <
1722 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1723 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1724 <        final Noop r = new Noop();
1725 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1726 <
1727 <        assertTrue(f.cancel(mayInterruptIfRunning));
1728 <        checkIncomplete(h);
1729 <        g.complete(v1);
1730 <
1731 <        checkCompletedWithWrappedCancellationException(h);
1732 <        checkCancelled(f);
1733 <        assertEquals(r.invocationCount, 0);
1734 <        checkCompletedNormally(g, v1);
1735 <        }
1736 <    }
1737 <
1738 <    public void testRunAfterBoth_sourceCancelled2() {
1606 >    public void testRunAfterBoth_sourceCancelled() {
1607          for (ExecutionMode m : ExecutionMode.values())
1608          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1609 <        for (Integer v1 : new Integer[] { 1, null }) {
1610 <
1609 >        for (boolean createIncomplete : new boolean[] { true, false })
1610 >        for (boolean fFirst : new boolean[] { true, false })
1611 >        for (Integer v1 : new Integer[] { 1, null })
1612 >    {
1613          final CompletableFuture<Integer> f = new CompletableFuture<>();
1614          final CompletableFuture<Integer> g = new CompletableFuture<>();
1615 <        final Noop r = new Noop();
1746 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1747 <
1748 <        assertTrue(g.cancel(mayInterruptIfRunning));
1749 <        checkIncomplete(h);
1750 <        f.complete(v1);
1751 <
1752 <        checkCompletedWithWrappedCancellationException(h);
1753 <        checkCancelled(g);
1754 <        assertEquals(r.invocationCount, 0);
1755 <        checkCompletedNormally(f, v1);
1756 <        }
1757 <    }
1758 <
1759 <    public void testRunAfterBoth_sourceCancelled3() {
1760 <        for (ExecutionMode m : ExecutionMode.values())
1761 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1762 <        for (Integer v1 : new Integer[] { 1, null }) {
1615 >        final Noop r = new Noop(m);
1616  
1764        final CompletableFuture<Integer> f = new CompletableFuture<>();
1765        final CompletableFuture<Integer> g = new CompletableFuture<>();
1766        final Noop r = new Noop();
1617  
1618 <        assertTrue(g.cancel(mayInterruptIfRunning));
1619 <        f.complete(v1);
1618 >        (fFirst ? f : g).complete(v1);
1619 >        if (!createIncomplete)
1620 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1621          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1622 <
1623 <        checkCompletedWithWrappedCancellationException(h);
1624 <        checkCancelled(g);
1774 <        assertEquals(r.invocationCount, 0);
1775 <        checkCompletedNormally(f, v1);
1622 >        if (createIncomplete) {
1623 >            checkIncomplete(h);
1624 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1625          }
1777    }
1778
1779    public void testRunAfterBoth_sourceCancelled4() {
1780        for (ExecutionMode m : ExecutionMode.values())
1781        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1782        for (Integer v1 : new Integer[] { 1, null }) {
1783
1784        final CompletableFuture<Integer> f = new CompletableFuture<>();
1785        final CompletableFuture<Integer> g = new CompletableFuture<>();
1786        final Noop r = new Noop();
1787
1788        assertTrue(f.cancel(mayInterruptIfRunning));
1789        g.complete(v1);
1790        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1626  
1627          checkCompletedWithWrappedCancellationException(h);
1628 <        checkCancelled(f);
1629 <        assertEquals(r.invocationCount, 0);
1630 <        checkCompletedNormally(g, v1);
1631 <        }
1797 <    }
1628 >        checkCancelled(!fFirst ? f : g);
1629 >        assertEquals(0, r.invocationCount);
1630 >        checkCompletedNormally(fFirst ? f : g, v1);
1631 >    }}
1632  
1633      /**
1634       * applyToEither result completes normally after normal completion
1635       * of either source
1636       */
1637 <    public void testApplyToEither_normalCompletion1() {
1637 >    public void testApplyToEither_normalCompletion() {
1638          for (ExecutionMode m : ExecutionMode.values())
1639 +        for (boolean createIncomplete : new boolean[] { true, false })
1640 +        for (boolean fFirst : new boolean[] { true, false })
1641          for (Integer v1 : new Integer[] { 1, null })
1642 <        for (Integer v2 : new Integer[] { 2, null }) {
1643 <
1642 >        for (Integer v2 : new Integer[] { 2, null })
1643 >    {
1644          final CompletableFuture<Integer> f = new CompletableFuture<>();
1645          final CompletableFuture<Integer> g = new CompletableFuture<>();
1646 <        final IncFunction r = new IncFunction();
1811 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1646 >        final IncFunction r = new IncFunction(m);
1647  
1648 <        f.complete(v1);
1649 <        checkCompletedNormally(h, inc(v1));
1650 <        g.complete(v2);
1648 >        if (!createIncomplete)
1649 >            if (fFirst) f.complete(v1); else g.complete(v2);
1650 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1651 >        if (createIncomplete) {
1652 >            checkIncomplete(h);
1653 >            assertEquals(0, r.invocationCount);
1654 >            if (fFirst) f.complete(v1); else g.complete(v2);
1655 >        }
1656 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1657 >        if (!fFirst) f.complete(v1); else g.complete(v2);
1658  
1659          checkCompletedNormally(f, v1);
1660          checkCompletedNormally(g, v2);
1661 <        checkCompletedNormally(h, inc(v1));
1662 <        }
1821 <    }
1661 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1662 >    }}
1663  
1664 <    public void testApplyToEither_normalCompletion2() {
1664 >    public void testApplyToEither_normalCompletionBothAvailable() {
1665          for (ExecutionMode m : ExecutionMode.values())
1666 +        for (boolean fFirst : new boolean[] { true, false })
1667          for (Integer v1 : new Integer[] { 1, null })
1668 <        for (Integer v2 : new Integer[] { 2, null }) {
1669 <
1668 >        for (Integer v2 : new Integer[] { 2, null })
1669 >    {
1670          final CompletableFuture<Integer> f = new CompletableFuture<>();
1671          final CompletableFuture<Integer> g = new CompletableFuture<>();
1672 <        final IncFunction r = new IncFunction();
1831 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1672 >        final IncFunction r = new IncFunction(m);
1673  
1674 <        g.complete(v2);
1675 <        checkCompletedNormally(h, inc(v2));
1676 <        f.complete(v1);
1677 <
1678 <        checkCompletedNormally(f, v1);
1679 <        checkCompletedNormally(g, v2);
1839 <        checkCompletedNormally(h, inc(v2));
1674 >        if (fFirst) {
1675 >            f.complete(v1);
1676 >            g.complete(v2);
1677 >        } else {
1678 >            g.complete(v2);
1679 >            f.complete(v1);
1680          }
1841    }
1842    public void testApplyToEither_normalCompletion3() {
1843        for (ExecutionMode m : ExecutionMode.values())
1844        for (Integer v1 : new Integer[] { 1, null })
1845        for (Integer v2 : new Integer[] { 2, null }) {
1846
1847        final CompletableFuture<Integer> f = new CompletableFuture<>();
1848        final CompletableFuture<Integer> g = new CompletableFuture<>();
1849        final IncFunction r = new IncFunction();
1681  
1851        f.complete(v1);
1852        g.complete(v2);
1682          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1683  
1684          checkCompletedNormally(f, v1);
# Line 1858 | Line 1687 | public class CompletableFutureTest exten
1687          // unspecified behavior
1688          assertTrue(Objects.equals(h.join(), inc(v1)) ||
1689                     Objects.equals(h.join(), inc(v2)));
1690 <        assertEquals(r.invocationCount, 1);
1691 <        }
1863 <    }
1690 >        assertEquals(1, r.invocationCount);
1691 >    }}
1692  
1693      /**
1694       * applyToEither result completes exceptionally after exceptional
# Line 1868 | Line 1696 | public class CompletableFutureTest exten
1696       */
1697      public void testApplyToEither_exceptionalCompletion1() {
1698          for (ExecutionMode m : ExecutionMode.values())
1699 <        for (Integer v1 : new Integer[] { 1, null }) {
1700 <
1699 >        for (boolean createIncomplete : new boolean[] { true, false })
1700 >        for (boolean fFirst : new boolean[] { true, false })
1701 >        for (Integer v1 : new Integer[] { 1, null })
1702 >    {
1703          final CompletableFuture<Integer> f = new CompletableFuture<>();
1704          final CompletableFuture<Integer> g = new CompletableFuture<>();
1875        final IncFunction r = new IncFunction();
1876        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1705          final CFException ex = new CFException();
1706 +        final IncFunction r = new IncFunction(m);
1707  
1708 <        f.completeExceptionally(ex);
1880 <        checkCompletedWithWrappedCFException(h, ex);
1881 <        g.complete(v1);
1882 <
1883 <        assertEquals(r.invocationCount, 0);
1884 <        checkCompletedNormally(g, v1);
1885 <        checkCompletedWithWrappedCFException(f, ex);
1886 <        checkCompletedWithWrappedCFException(h, ex);
1887 <        }
1888 <    }
1889 <
1890 <    public void testApplyToEither_exceptionalCompletion2() {
1891 <        for (ExecutionMode m : ExecutionMode.values())
1892 <        for (Integer v1 : new Integer[] { 1, null }) {
1893 <
1894 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1895 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1896 <        final IncFunction r = new IncFunction();
1708 >        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1709          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1710 <        final CFException ex = new CFException();
1710 >        if (createIncomplete) {
1711 >            checkIncomplete(h);
1712 >            assertEquals(0, r.invocationCount);
1713 >            (fFirst ? f : g).completeExceptionally(ex);
1714 >        }
1715  
1900        g.completeExceptionally(ex);
1716          checkCompletedWithWrappedCFException(h, ex);
1717 <        f.complete(v1);
1717 >        (!fFirst ? f : g).complete(v1);
1718  
1719 <        assertEquals(r.invocationCount, 0);
1720 <        checkCompletedNormally(f, v1);
1721 <        checkCompletedWithWrappedCFException(g, ex);
1719 >        assertEquals(0, r.invocationCount);
1720 >        checkCompletedNormally(!fFirst ? f : g, v1);
1721 >        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1722          checkCompletedWithWrappedCFException(h, ex);
1723 <        }
1909 <    }
1723 >    }}
1724  
1725 <    public void testApplyToEither_exceptionalCompletion3() {
1725 >    public void testApplyToEither_exceptionalCompletion2() {
1726          for (ExecutionMode m : ExecutionMode.values())
1727 <        for (Integer v1 : new Integer[] { 1, null }) {
1728 <
1727 >        for (boolean reverseArgs : new boolean[] { true, false })
1728 >        for (boolean fFirst : new boolean[] { true, false })
1729 >        for (Integer v1 : new Integer[] { 1, null })
1730 >    {
1731          final CompletableFuture<Integer> f = new CompletableFuture<>();
1732          final CompletableFuture<Integer> g = new CompletableFuture<>();
1733 <        final IncFunction r = new IncFunction();
1733 >        final IncFunction r1 = new IncFunction(m);
1734 >        final IncFunction r2 = new IncFunction(m);
1735          final CFException ex = new CFException();
1736 <
1737 <        g.completeExceptionally(ex);
1738 <        f.complete(v1);
1739 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1736 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1737 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1738 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1739 >        if (fFirst) {
1740 >            f.complete(v1);
1741 >            g.completeExceptionally(ex);
1742 >        } else {
1743 >            g.completeExceptionally(ex);
1744 >            f.complete(v1);
1745 >        }
1746 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1747  
1748          // unspecified behavior
1925        Integer v;
1749          try {
1750 <            assertEquals(h.join(), inc(v1));
1751 <            assertEquals(r.invocationCount, 1);
1750 >            assertEquals(inc(v1), h1.join());
1751 >            assertEquals(1, r1.invocationCount);
1752          } catch (CompletionException ok) {
1753 <            checkCompletedWithWrappedCFException(h, ex);
1754 <            assertEquals(r.invocationCount, 0);
1932 <        }
1933 <
1934 <        checkCompletedWithWrappedCFException(g, ex);
1935 <        checkCompletedNormally(f, v1);
1753 >            checkCompletedWithWrappedCFException(h1, ex);
1754 >            assertEquals(0, r1.invocationCount);
1755          }
1937    }
1938
1939    public void testApplyToEither_exceptionalCompletion4() {
1940        for (ExecutionMode m : ExecutionMode.values())
1941        for (Integer v1 : new Integer[] { 1, null }) {
1942
1943        final CompletableFuture<Integer> f = new CompletableFuture<>();
1944        final CompletableFuture<Integer> g = new CompletableFuture<>();
1945        final IncFunction r = new IncFunction();
1946        final CFException ex = new CFException();
1756  
1948        f.completeExceptionally(ex);
1949        g.complete(v1);
1950        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1951
1952        // unspecified behavior
1953        Integer v;
1757          try {
1758 <            assertEquals(h.join(), inc(v1));
1759 <            assertEquals(r.invocationCount, 1);
1758 >            assertEquals(inc(v1), h2.join());
1759 >            assertEquals(1, r2.invocationCount);
1760          } catch (CompletionException ok) {
1761 <            checkCompletedWithWrappedCFException(h, ex);
1762 <            assertEquals(r.invocationCount, 0);
1761 >            checkCompletedWithWrappedCFException(h2, ex);
1762 >            assertEquals(0, r2.invocationCount);
1763          }
1764  
1765 <        checkCompletedWithWrappedCFException(f, ex);
1766 <        checkCompletedNormally(g, v1);
1767 <        }
1965 <    }
1765 >        checkCompletedWithWrappedCFException(g, ex);
1766 >        checkCompletedNormally(f, v1);
1767 >    }}
1768  
1769      /**
1770       * applyToEither result completes exceptionally if action does
# Line 1970 | Line 1772 | public class CompletableFutureTest exten
1772      public void testApplyToEither_actionFailed1() {
1773          for (ExecutionMode m : ExecutionMode.values())
1774          for (Integer v1 : new Integer[] { 1, null })
1775 <        for (Integer v2 : new Integer[] { 2, null }) {
1776 <
1775 >        for (Integer v2 : new Integer[] { 2, null })
1776 >    {
1777          final CompletableFuture<Integer> f = new CompletableFuture<>();
1778          final CompletableFuture<Integer> g = new CompletableFuture<>();
1779 <        final FailingFunction r = new FailingFunction();
1779 >        final FailingFunction r = new FailingFunction(m);
1780          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1781  
1782          f.complete(v1);
# Line 1982 | Line 1784 | public class CompletableFutureTest exten
1784          g.complete(v2);
1785          checkCompletedNormally(f, v1);
1786          checkCompletedNormally(g, v2);
1787 <        }
1986 <    }
1787 >    }}
1788  
1789      public void testApplyToEither_actionFailed2() {
1790          for (ExecutionMode m : ExecutionMode.values())
1791          for (Integer v1 : new Integer[] { 1, null })
1792 <        for (Integer v2 : new Integer[] { 2, null }) {
1793 <
1792 >        for (Integer v2 : new Integer[] { 2, null })
1793 >    {
1794          final CompletableFuture<Integer> f = new CompletableFuture<>();
1795          final CompletableFuture<Integer> g = new CompletableFuture<>();
1796 <        final FailingFunction r = new FailingFunction();
1796 >        final FailingFunction r = new FailingFunction(m);
1797          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1798  
1799          g.complete(v2);
# Line 2000 | Line 1801 | public class CompletableFutureTest exten
1801          f.complete(v1);
1802          checkCompletedNormally(f, v1);
1803          checkCompletedNormally(g, v2);
1804 <        }
2004 <    }
1804 >    }}
1805  
1806      /**
1807       * applyToEither result completes exceptionally if either source cancelled
# Line 2009 | Line 1809 | public class CompletableFutureTest exten
1809      public void testApplyToEither_sourceCancelled1() {
1810          for (ExecutionMode m : ExecutionMode.values())
1811          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1812 <        for (Integer v1 : new Integer[] { 1, null }) {
1813 <
1812 >        for (boolean createIncomplete : new boolean[] { true, false })
1813 >        for (boolean fFirst : new boolean[] { true, false })
1814 >        for (Integer v1 : new Integer[] { 1, null })
1815 >    {
1816          final CompletableFuture<Integer> f = new CompletableFuture<>();
1817          final CompletableFuture<Integer> g = new CompletableFuture<>();
1818 <        final IncFunction r = new IncFunction();
1818 >        final IncFunction r = new IncFunction(m);
1819 >
1820 >        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1821          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1822 +        if (createIncomplete) {
1823 +            checkIncomplete(h);
1824 +            assertEquals(0, r.invocationCount);
1825 +            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1826 +        }
1827  
2019        assertTrue(f.cancel(mayInterruptIfRunning));
1828          checkCompletedWithWrappedCancellationException(h);
1829 <        g.complete(v1);
1829 >        (!fFirst ? f : g).complete(v1);
1830  
1831 <        checkCancelled(f);
1832 <        assertEquals(r.invocationCount, 0);
1833 <        checkCompletedNormally(g, v1);
1831 >        assertEquals(0, r.invocationCount);
1832 >        checkCompletedNormally(!fFirst ? f : g, v1);
1833 >        checkCancelled(fFirst ? f : g);
1834          checkCompletedWithWrappedCancellationException(h);
1835 <        }
2028 <    }
1835 >    }}
1836  
1837      public void testApplyToEither_sourceCancelled2() {
1838          for (ExecutionMode m : ExecutionMode.values())
1839          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1840 <        for (Integer v1 : new Integer[] { 1, null }) {
1841 <
1840 >        for (boolean reverseArgs : new boolean[] { true, false })
1841 >        for (boolean fFirst : new boolean[] { true, false })
1842 >        for (Integer v1 : new Integer[] { 1, null })
1843 >    {
1844          final CompletableFuture<Integer> f = new CompletableFuture<>();
1845          final CompletableFuture<Integer> g = new CompletableFuture<>();
1846 <        final IncFunction r = new IncFunction();
1847 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1848 <
1849 <        assertTrue(g.cancel(mayInterruptIfRunning));
1850 <        checkCompletedWithWrappedCancellationException(h);
2042 <        f.complete(v1);
1846 >        final IncFunction r1 = new IncFunction(m);
1847 >        final IncFunction r2 = new IncFunction(m);
1848 >        final CFException ex = new CFException();
1849 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1850 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1851  
1852 <        checkCancelled(g);
1853 <        assertEquals(r.invocationCount, 0);
1854 <        checkCompletedNormally(f, v1);
1855 <        checkCompletedWithWrappedCancellationException(h);
1852 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1853 >        if (fFirst) {
1854 >            f.complete(v1);
1855 >            assertTrue(g.cancel(mayInterruptIfRunning));
1856 >        } else {
1857 >            assertTrue(g.cancel(mayInterruptIfRunning));
1858 >            f.complete(v1);
1859          }
1860 <    }
2050 <
2051 <    public void testApplyToEither_sourceCancelled3() {
2052 <        for (ExecutionMode m : ExecutionMode.values())
2053 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2054 <        for (Integer v1 : new Integer[] { 1, null }) {
2055 <
2056 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2057 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2058 <        final IncFunction r = new IncFunction();
2059 <
2060 <        assertTrue(g.cancel(mayInterruptIfRunning));
2061 <        f.complete(v1);
2062 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1860 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1861  
1862          // unspecified behavior
2065        Integer v;
1863          try {
1864 <            assertEquals(h.join(), inc(v1));
1865 <            assertEquals(r.invocationCount, 1);
1864 >            assertEquals(inc(v1), h1.join());
1865 >            assertEquals(1, r1.invocationCount);
1866          } catch (CompletionException ok) {
1867 <            checkCompletedWithWrappedCancellationException(h);
1868 <            assertEquals(r.invocationCount, 0);
2072 <        }
2073 <
2074 <        checkCancelled(g);
2075 <        checkCompletedNormally(f, v1);
1867 >            checkCompletedWithWrappedCancellationException(h1);
1868 >            assertEquals(0, r1.invocationCount);
1869          }
2077    }
2078
2079    public void testApplyToEither_sourceCancelled4() {
2080        for (ExecutionMode m : ExecutionMode.values())
2081        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2082        for (Integer v1 : new Integer[] { 1, null }) {
2083
2084        final CompletableFuture<Integer> f = new CompletableFuture<>();
2085        final CompletableFuture<Integer> g = new CompletableFuture<>();
2086        final IncFunction r = new IncFunction();
1870  
2088        assertTrue(f.cancel(mayInterruptIfRunning));
2089        g.complete(v1);
2090        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2091
2092        // unspecified behavior
2093        Integer v;
1871          try {
1872 <            assertEquals(h.join(), inc(v1));
1873 <            assertEquals(r.invocationCount, 1);
1872 >            assertEquals(inc(v1), h2.join());
1873 >            assertEquals(1, r2.invocationCount);
1874          } catch (CompletionException ok) {
1875 <            checkCompletedWithWrappedCancellationException(h);
1876 <            assertEquals(r.invocationCount, 0);
1875 >            checkCompletedWithWrappedCancellationException(h2);
1876 >            assertEquals(0, r2.invocationCount);
1877          }
1878  
1879 <        checkCancelled(f);
1880 <        checkCompletedNormally(g, v1);
1881 <        }
2105 <    }
1879 >        checkCancelled(g);
1880 >        checkCompletedNormally(f, v1);
1881 >    }}
1882  
1883      /**
1884       * acceptEither result completes normally after normal completion
# Line 2111 | Line 1887 | public class CompletableFutureTest exten
1887      public void testAcceptEither_normalCompletion1() {
1888          for (ExecutionMode m : ExecutionMode.values())
1889          for (Integer v1 : new Integer[] { 1, null })
1890 <        for (Integer v2 : new Integer[] { 2, null }) {
1891 <
1890 >        for (Integer v2 : new Integer[] { 2, null })
1891 >    {
1892          final CompletableFuture<Integer> f = new CompletableFuture<>();
1893          final CompletableFuture<Integer> g = new CompletableFuture<>();
1894          final IncAction r = new IncAction();
# Line 2120 | Line 1896 | public class CompletableFutureTest exten
1896  
1897          f.complete(v1);
1898          checkCompletedNormally(h, null);
1899 <        assertEquals(r.value, inc(v1));
1899 >        assertEquals(inc(v1), r.value);
1900          g.complete(v2);
1901  
1902          checkCompletedNormally(f, v1);
1903          checkCompletedNormally(g, v2);
1904          checkCompletedNormally(h, null);
1905 <        }
2130 <    }
1905 >    }}
1906  
1907      public void testAcceptEither_normalCompletion2() {
1908          for (ExecutionMode m : ExecutionMode.values())
1909          for (Integer v1 : new Integer[] { 1, null })
1910 <        for (Integer v2 : new Integer[] { 2, null }) {
1911 <
1910 >        for (Integer v2 : new Integer[] { 2, null })
1911 >    {
1912          final CompletableFuture<Integer> f = new CompletableFuture<>();
1913          final CompletableFuture<Integer> g = new CompletableFuture<>();
1914          final IncAction r = new IncAction();
# Line 2141 | Line 1916 | public class CompletableFutureTest exten
1916  
1917          g.complete(v2);
1918          checkCompletedNormally(h, null);
1919 <        assertEquals(r.value, inc(v2));
1919 >        assertEquals(inc(v2), r.value);
1920          f.complete(v1);
1921  
1922          checkCompletedNormally(f, v1);
1923          checkCompletedNormally(g, v2);
1924          checkCompletedNormally(h, null);
1925 <        }
1926 <    }
1925 >    }}
1926 >
1927      public void testAcceptEither_normalCompletion3() {
1928          for (ExecutionMode m : ExecutionMode.values())
1929          for (Integer v1 : new Integer[] { 1, null })
1930 <        for (Integer v2 : new Integer[] { 2, null }) {
1931 <
1930 >        for (Integer v2 : new Integer[] { 2, null })
1931 >    {
1932          final CompletableFuture<Integer> f = new CompletableFuture<>();
1933          final CompletableFuture<Integer> g = new CompletableFuture<>();
1934          final IncAction r = new IncAction();
# Line 2169 | Line 1944 | public class CompletableFutureTest exten
1944          // unspecified behavior
1945          assertTrue(Objects.equals(r.value, inc(v1)) ||
1946                     Objects.equals(r.value, inc(v2)));
1947 <        }
2173 <    }
1947 >    }}
1948  
1949      /**
1950       * acceptEither result completes exceptionally after exceptional
# Line 2178 | Line 1952 | public class CompletableFutureTest exten
1952       */
1953      public void testAcceptEither_exceptionalCompletion1() {
1954          for (ExecutionMode m : ExecutionMode.values())
1955 <        for (Integer v1 : new Integer[] { 1, null }) {
1956 <
1955 >        for (Integer v1 : new Integer[] { 1, null })
1956 >    {
1957          final CompletableFuture<Integer> f = new CompletableFuture<>();
1958          final CompletableFuture<Integer> g = new CompletableFuture<>();
1959          final IncAction r = new IncAction();
# Line 2190 | Line 1964 | public class CompletableFutureTest exten
1964          checkCompletedWithWrappedCFException(h, ex);
1965          g.complete(v1);
1966  
1967 <        assertEquals(r.invocationCount, 0);
1967 >        assertEquals(0, r.invocationCount);
1968          checkCompletedNormally(g, v1);
1969          checkCompletedWithWrappedCFException(f, ex);
1970          checkCompletedWithWrappedCFException(h, ex);
1971 <        }
2198 <    }
1971 >    }}
1972  
1973      public void testAcceptEither_exceptionalCompletion2() {
1974          for (ExecutionMode m : ExecutionMode.values())
1975 <        for (Integer v1 : new Integer[] { 1, null }) {
1976 <
1975 >        for (Integer v1 : new Integer[] { 1, null })
1976 >    {
1977          final CompletableFuture<Integer> f = new CompletableFuture<>();
1978          final CompletableFuture<Integer> g = new CompletableFuture<>();
1979          final IncAction r = new IncAction();
# Line 2211 | Line 1984 | public class CompletableFutureTest exten
1984          checkCompletedWithWrappedCFException(h, ex);
1985          f.complete(v1);
1986  
1987 <        assertEquals(r.invocationCount, 0);
1987 >        assertEquals(0, r.invocationCount);
1988          checkCompletedNormally(f, v1);
1989          checkCompletedWithWrappedCFException(g, ex);
1990          checkCompletedWithWrappedCFException(h, ex);
1991 <        }
2219 <    }
1991 >    }}
1992  
1993      public void testAcceptEither_exceptionalCompletion3() {
1994          for (ExecutionMode m : ExecutionMode.values())
1995 <        for (Integer v1 : new Integer[] { 1, null }) {
1996 <
1995 >        for (Integer v1 : new Integer[] { 1, null })
1996 >    {
1997          final CompletableFuture<Integer> f = new CompletableFuture<>();
1998          final CompletableFuture<Integer> g = new CompletableFuture<>();
1999          final IncAction r = new IncAction();
# Line 2234 | Line 2006 | public class CompletableFutureTest exten
2006          // unspecified behavior
2007          Integer v;
2008          try {
2009 <            assertEquals(h.join(), null);
2010 <            assertEquals(r.invocationCount, 1);
2009 >            assertNull(h.join());
2010 >            assertEquals(1, r.invocationCount);
2011              assertEquals(inc(v1), r.value);
2012          } catch (CompletionException ok) {
2013              checkCompletedWithWrappedCFException(h, ex);
2014 <            assertEquals(r.invocationCount, 0);
2014 >            assertEquals(0, r.invocationCount);
2015          }
2016  
2017          checkCompletedWithWrappedCFException(g, ex);
2018          checkCompletedNormally(f, v1);
2019 <        }
2248 <    }
2019 >    }}
2020  
2021      public void testAcceptEither_exceptionalCompletion4() {
2022          for (ExecutionMode m : ExecutionMode.values())
2023 <        for (Integer v1 : new Integer[] { 1, null }) {
2024 <
2023 >        for (Integer v1 : new Integer[] { 1, null })
2024 >    {
2025          final CompletableFuture<Integer> f = new CompletableFuture<>();
2026          final CompletableFuture<Integer> g = new CompletableFuture<>();
2027          final IncAction r = new IncAction();
# Line 2263 | Line 2034 | public class CompletableFutureTest exten
2034          // unspecified behavior
2035          Integer v;
2036          try {
2037 <            assertEquals(h.join(), null);
2038 <            assertEquals(r.invocationCount, 1);
2037 >            assertNull(h.join());
2038 >            assertEquals(1, r.invocationCount);
2039              assertEquals(inc(v1), r.value);
2040          } catch (CompletionException ok) {
2041              checkCompletedWithWrappedCFException(h, ex);
2042 <            assertEquals(r.invocationCount, 0);
2042 >            assertEquals(0, r.invocationCount);
2043          }
2044  
2045          checkCompletedWithWrappedCFException(f, ex);
2046          checkCompletedNormally(g, v1);
2047 <        }
2277 <    }
2047 >    }}
2048  
2049      /**
2050       * acceptEither result completes exceptionally if action does
# Line 2282 | Line 2052 | public class CompletableFutureTest exten
2052      public void testAcceptEither_actionFailed1() {
2053          for (ExecutionMode m : ExecutionMode.values())
2054          for (Integer v1 : new Integer[] { 1, null })
2055 <        for (Integer v2 : new Integer[] { 2, null }) {
2056 <
2055 >        for (Integer v2 : new Integer[] { 2, null })
2056 >    {
2057          final CompletableFuture<Integer> f = new CompletableFuture<>();
2058          final CompletableFuture<Integer> g = new CompletableFuture<>();
2059 <        final FailingConsumer r = new FailingConsumer();
2059 >        final FailingConsumer r = new FailingConsumer(m);
2060          final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2061  
2062          f.complete(v1);
# Line 2294 | Line 2064 | public class CompletableFutureTest exten
2064          g.complete(v2);
2065          checkCompletedNormally(f, v1);
2066          checkCompletedNormally(g, v2);
2067 <        }
2298 <    }
2067 >    }}
2068  
2069      public void testAcceptEither_actionFailed2() {
2070          for (ExecutionMode m : ExecutionMode.values())
2071          for (Integer v1 : new Integer[] { 1, null })
2072 <        for (Integer v2 : new Integer[] { 2, null }) {
2073 <
2072 >        for (Integer v2 : new Integer[] { 2, null })
2073 >    {
2074          final CompletableFuture<Integer> f = new CompletableFuture<>();
2075          final CompletableFuture<Integer> g = new CompletableFuture<>();
2076 <        final FailingConsumer r = new FailingConsumer();
2076 >        final FailingConsumer r = new FailingConsumer(m);
2077          final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2078  
2079          g.complete(v2);
# Line 2312 | Line 2081 | public class CompletableFutureTest exten
2081          f.complete(v1);
2082          checkCompletedNormally(f, v1);
2083          checkCompletedNormally(g, v2);
2084 <        }
2316 <    }
2084 >    }}
2085  
2086      /**
2087       * acceptEither result completes exceptionally if either source cancelled
# Line 2321 | Line 2089 | public class CompletableFutureTest exten
2089      public void testAcceptEither_sourceCancelled1() {
2090          for (ExecutionMode m : ExecutionMode.values())
2091          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2092 <        for (Integer v1 : new Integer[] { 1, null }) {
2093 <
2092 >        for (Integer v1 : new Integer[] { 1, null })
2093 >    {
2094          final CompletableFuture<Integer> f = new CompletableFuture<>();
2095          final CompletableFuture<Integer> g = new CompletableFuture<>();
2096          final IncAction r = new IncAction();
# Line 2333 | Line 2101 | public class CompletableFutureTest exten
2101          g.complete(v1);
2102  
2103          checkCancelled(f);
2104 <        assertEquals(r.invocationCount, 0);
2104 >        assertEquals(0, r.invocationCount);
2105          checkCompletedNormally(g, v1);
2106          checkCompletedWithWrappedCancellationException(h);
2107 <        }
2340 <    }
2107 >    }}
2108  
2109      public void testAcceptEither_sourceCancelled2() {
2110          for (ExecutionMode m : ExecutionMode.values())
2111          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2112 <        for (Integer v1 : new Integer[] { 1, null }) {
2113 <
2112 >        for (Integer v1 : new Integer[] { 1, null })
2113 >    {
2114          final CompletableFuture<Integer> f = new CompletableFuture<>();
2115          final CompletableFuture<Integer> g = new CompletableFuture<>();
2116          final IncAction r = new IncAction();
# Line 2354 | Line 2121 | public class CompletableFutureTest exten
2121          f.complete(v1);
2122  
2123          checkCancelled(g);
2124 <        assertEquals(r.invocationCount, 0);
2124 >        assertEquals(0, r.invocationCount);
2125          checkCompletedNormally(f, v1);
2126          checkCompletedWithWrappedCancellationException(h);
2127 <        }
2361 <    }
2127 >    }}
2128  
2129      public void testAcceptEither_sourceCancelled3() {
2130          for (ExecutionMode m : ExecutionMode.values())
2131          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2132 <        for (Integer v1 : new Integer[] { 1, null }) {
2133 <
2132 >        for (Integer v1 : new Integer[] { 1, null })
2133 >    {
2134          final CompletableFuture<Integer> f = new CompletableFuture<>();
2135          final CompletableFuture<Integer> g = new CompletableFuture<>();
2136          final IncAction r = new IncAction();
# Line 2376 | Line 2142 | public class CompletableFutureTest exten
2142          // unspecified behavior
2143          Integer v;
2144          try {
2145 <            assertEquals(h.join(), null);
2146 <            assertEquals(r.invocationCount, 1);
2145 >            assertNull(h.join());
2146 >            assertEquals(1, r.invocationCount);
2147              assertEquals(inc(v1), r.value);
2148          } catch (CompletionException ok) {
2149              checkCompletedWithWrappedCancellationException(h);
2150 <            assertEquals(r.invocationCount, 0);
2150 >            assertEquals(0, r.invocationCount);
2151          }
2152  
2153          checkCancelled(g);
2154          checkCompletedNormally(f, v1);
2155 <        }
2390 <    }
2155 >    }}
2156  
2157      public void testAcceptEither_sourceCancelled4() {
2158          for (ExecutionMode m : ExecutionMode.values())
2159          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2160 <        for (Integer v1 : new Integer[] { 1, null }) {
2161 <
2160 >        for (Integer v1 : new Integer[] { 1, null })
2161 >    {
2162          final CompletableFuture<Integer> f = new CompletableFuture<>();
2163          final CompletableFuture<Integer> g = new CompletableFuture<>();
2164          final IncAction r = new IncAction();
# Line 2405 | Line 2170 | public class CompletableFutureTest exten
2170          // unspecified behavior
2171          Integer v;
2172          try {
2173 <            assertEquals(h.join(), null);
2174 <            assertEquals(r.invocationCount, 1);
2173 >            assertNull(h.join());
2174 >            assertEquals(1, r.invocationCount);
2175              assertEquals(inc(v1), r.value);
2176          } catch (CompletionException ok) {
2177              checkCompletedWithWrappedCancellationException(h);
2178 <            assertEquals(r.invocationCount, 0);
2178 >            assertEquals(0, r.invocationCount);
2179          }
2180  
2181          checkCancelled(f);
2182          checkCompletedNormally(g, v1);
2183 <        }
2419 <    }
2183 >    }}
2184  
2185      /**
2186       * runAfterEither result completes normally after normal completion
# Line 2425 | Line 2189 | public class CompletableFutureTest exten
2189      public void testRunAfterEither_normalCompletion1() {
2190          for (ExecutionMode m : ExecutionMode.values())
2191          for (Integer v1 : new Integer[] { 1, null })
2192 <        for (Integer v2 : new Integer[] { 2, null }) {
2193 <
2192 >        for (Integer v2 : new Integer[] { 2, null })
2193 >    {
2194          final CompletableFuture<Integer> f = new CompletableFuture<>();
2195          final CompletableFuture<Integer> g = new CompletableFuture<>();
2196 <        final Noop r = new Noop();
2196 >        final Noop r = new Noop(m);
2197          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2198  
2199          f.complete(v1);
2200          checkCompletedNormally(h, null);
2201 <        assertEquals(r.invocationCount, 1);
2201 >        assertEquals(1, r.invocationCount);
2202          g.complete(v2);
2203  
2204          checkCompletedNormally(f, v1);
2205          checkCompletedNormally(g, v2);
2206          checkCompletedNormally(h, null);
2207 <        assertEquals(r.invocationCount, 1);
2208 <        }
2445 <    }
2207 >        assertEquals(1, r.invocationCount);
2208 >    }}
2209  
2210      public void testRunAfterEither_normalCompletion2() {
2211          for (ExecutionMode m : ExecutionMode.values())
2212          for (Integer v1 : new Integer[] { 1, null })
2213 <        for (Integer v2 : new Integer[] { 2, null }) {
2214 <
2213 >        for (Integer v2 : new Integer[] { 2, null })
2214 >    {
2215          final CompletableFuture<Integer> f = new CompletableFuture<>();
2216          final CompletableFuture<Integer> g = new CompletableFuture<>();
2217 <        final Noop r = new Noop();
2217 >        final Noop r = new Noop(m);
2218          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2219  
2220          g.complete(v2);
2221          checkCompletedNormally(h, null);
2222 <        assertEquals(r.invocationCount, 1);
2222 >        assertEquals(1, r.invocationCount);
2223          f.complete(v1);
2224  
2225          checkCompletedNormally(f, v1);
2226          checkCompletedNormally(g, v2);
2227          checkCompletedNormally(h, null);
2228 <        assertEquals(r.invocationCount, 1);
2229 <        }
2230 <    }
2228 >        assertEquals(1, r.invocationCount);
2229 >        }}
2230 >
2231      public void testRunAfterEither_normalCompletion3() {
2232          for (ExecutionMode m : ExecutionMode.values())
2233          for (Integer v1 : new Integer[] { 1, null })
2234 <        for (Integer v2 : new Integer[] { 2, null }) {
2235 <
2234 >        for (Integer v2 : new Integer[] { 2, null })
2235 >    {
2236          final CompletableFuture<Integer> f = new CompletableFuture<>();
2237          final CompletableFuture<Integer> g = new CompletableFuture<>();
2238 <        final Noop r = new Noop();
2238 >        final Noop r = new Noop(m);
2239  
2240          f.complete(v1);
2241          g.complete(v2);
# Line 2481 | Line 2244 | public class CompletableFutureTest exten
2244          checkCompletedNormally(h, null);
2245          checkCompletedNormally(f, v1);
2246          checkCompletedNormally(g, v2);
2247 <        assertEquals(r.invocationCount, 1);
2248 <        }
2486 <    }
2247 >        assertEquals(1, r.invocationCount);
2248 >    }}
2249  
2250      /**
2251       * runAfterEither result completes exceptionally after exceptional
# Line 2491 | Line 2253 | public class CompletableFutureTest exten
2253       */
2254      public void testRunAfterEither_exceptionalCompletion1() {
2255          for (ExecutionMode m : ExecutionMode.values())
2256 <        for (Integer v1 : new Integer[] { 1, null }) {
2257 <
2256 >        for (Integer v1 : new Integer[] { 1, null })
2257 >    {
2258          final CompletableFuture<Integer> f = new CompletableFuture<>();
2259          final CompletableFuture<Integer> g = new CompletableFuture<>();
2260 <        final Noop r = new Noop();
2260 >        final Noop r = new Noop(m);
2261          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2262          final CFException ex = new CFException();
2263  
# Line 2503 | Line 2265 | public class CompletableFutureTest exten
2265          checkCompletedWithWrappedCFException(h, ex);
2266          g.complete(v1);
2267  
2268 <        assertEquals(r.invocationCount, 0);
2268 >        assertEquals(0, r.invocationCount);
2269          checkCompletedNormally(g, v1);
2270          checkCompletedWithWrappedCFException(f, ex);
2271          checkCompletedWithWrappedCFException(h, ex);
2272 <        }
2511 <    }
2272 >    }}
2273  
2274      public void testRunAfterEither_exceptionalCompletion2() {
2275          for (ExecutionMode m : ExecutionMode.values())
2276 <        for (Integer v1 : new Integer[] { 1, null }) {
2277 <
2276 >        for (Integer v1 : new Integer[] { 1, null })
2277 >    {
2278          final CompletableFuture<Integer> f = new CompletableFuture<>();
2279          final CompletableFuture<Integer> g = new CompletableFuture<>();
2280 <        final Noop r = new Noop();
2280 >        final Noop r = new Noop(m);
2281          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2282          final CFException ex = new CFException();
2283  
# Line 2524 | Line 2285 | public class CompletableFutureTest exten
2285          checkCompletedWithWrappedCFException(h, ex);
2286          f.complete(v1);
2287  
2288 <        assertEquals(r.invocationCount, 0);
2288 >        assertEquals(0, r.invocationCount);
2289          checkCompletedNormally(f, v1);
2290          checkCompletedWithWrappedCFException(g, ex);
2291          checkCompletedWithWrappedCFException(h, ex);
2292 <        }
2532 <    }
2292 >    }}
2293  
2294      public void testRunAfterEither_exceptionalCompletion3() {
2295          for (ExecutionMode m : ExecutionMode.values())
2296 <        for (Integer v1 : new Integer[] { 1, null }) {
2297 <
2296 >        for (Integer v1 : new Integer[] { 1, null })
2297 >    {
2298          final CompletableFuture<Integer> f = new CompletableFuture<>();
2299          final CompletableFuture<Integer> g = new CompletableFuture<>();
2300 <        final Noop r = new Noop();
2300 >        final Noop r = new Noop(m);
2301          final CFException ex = new CFException();
2302  
2303          g.completeExceptionally(ex);
# Line 2547 | Line 2307 | public class CompletableFutureTest exten
2307          // unspecified behavior
2308          Integer v;
2309          try {
2310 <            assertEquals(h.join(), null);
2311 <            assertEquals(r.invocationCount, 1);
2310 >            assertNull(h.join());
2311 >            assertEquals(1, r.invocationCount);
2312          } catch (CompletionException ok) {
2313              checkCompletedWithWrappedCFException(h, ex);
2314 <            assertEquals(r.invocationCount, 0);
2314 >            assertEquals(0, r.invocationCount);
2315          }
2316  
2317          checkCompletedWithWrappedCFException(g, ex);
2318          checkCompletedNormally(f, v1);
2319 <        }
2560 <    }
2319 >    }}
2320  
2321      public void testRunAfterEither_exceptionalCompletion4() {
2322          for (ExecutionMode m : ExecutionMode.values())
2323 <        for (Integer v1 : new Integer[] { 1, null }) {
2324 <
2323 >        for (Integer v1 : new Integer[] { 1, null })
2324 >    {
2325          final CompletableFuture<Integer> f = new CompletableFuture<>();
2326          final CompletableFuture<Integer> g = new CompletableFuture<>();
2327 <        final Noop r = new Noop();
2327 >        final Noop r = new Noop(m);
2328          final CFException ex = new CFException();
2329  
2330          f.completeExceptionally(ex);
# Line 2575 | Line 2334 | public class CompletableFutureTest exten
2334          // unspecified behavior
2335          Integer v;
2336          try {
2337 <            assertEquals(h.join(), null);
2338 <            assertEquals(r.invocationCount, 1);
2337 >            assertNull(h.join());
2338 >            assertEquals(1, r.invocationCount);
2339          } catch (CompletionException ok) {
2340              checkCompletedWithWrappedCFException(h, ex);
2341 <            assertEquals(r.invocationCount, 0);
2341 >            assertEquals(0, r.invocationCount);
2342          }
2343  
2344          checkCompletedWithWrappedCFException(f, ex);
2345          checkCompletedNormally(g, v1);
2346 <        }
2588 <    }
2346 >    }}
2347  
2348      /**
2349       * runAfterEither result completes exceptionally if action does
# Line 2593 | Line 2351 | public class CompletableFutureTest exten
2351      public void testRunAfterEither_actionFailed1() {
2352          for (ExecutionMode m : ExecutionMode.values())
2353          for (Integer v1 : new Integer[] { 1, null })
2354 <        for (Integer v2 : new Integer[] { 2, null }) {
2355 <
2354 >        for (Integer v2 : new Integer[] { 2, null })
2355 >    {
2356          final CompletableFuture<Integer> f = new CompletableFuture<>();
2357          final CompletableFuture<Integer> g = new CompletableFuture<>();
2358 <        final FailingNoop r = new FailingNoop();
2358 >        final FailingRunnable r = new FailingRunnable(m);
2359          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2360  
2361          f.complete(v1);
# Line 2605 | Line 2363 | public class CompletableFutureTest exten
2363          g.complete(v2);
2364          checkCompletedNormally(f, v1);
2365          checkCompletedNormally(g, v2);
2366 <        }
2609 <    }
2366 >    }}
2367  
2368      public void testRunAfterEither_actionFailed2() {
2369          for (ExecutionMode m : ExecutionMode.values())
2370          for (Integer v1 : new Integer[] { 1, null })
2371 <        for (Integer v2 : new Integer[] { 2, null }) {
2372 <
2371 >        for (Integer v2 : new Integer[] { 2, null })
2372 >    {
2373          final CompletableFuture<Integer> f = new CompletableFuture<>();
2374          final CompletableFuture<Integer> g = new CompletableFuture<>();
2375 <        final FailingNoop r = new FailingNoop();
2375 >        final FailingRunnable r = new FailingRunnable(m);
2376          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2377  
2378          g.complete(v2);
# Line 2623 | Line 2380 | public class CompletableFutureTest exten
2380          f.complete(v1);
2381          checkCompletedNormally(f, v1);
2382          checkCompletedNormally(g, v2);
2383 <        }
2627 <    }
2383 >    }}
2384  
2385      /**
2386       * runAfterEither result completes exceptionally if either source cancelled
# Line 2632 | Line 2388 | public class CompletableFutureTest exten
2388      public void testRunAfterEither_sourceCancelled1() {
2389          for (ExecutionMode m : ExecutionMode.values())
2390          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2391 <        for (Integer v1 : new Integer[] { 1, null }) {
2392 <
2391 >        for (Integer v1 : new Integer[] { 1, null })
2392 >    {
2393          final CompletableFuture<Integer> f = new CompletableFuture<>();
2394          final CompletableFuture<Integer> g = new CompletableFuture<>();
2395 <        final Noop r = new Noop();
2395 >        final Noop r = new Noop(m);
2396          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2397  
2398          assertTrue(f.cancel(mayInterruptIfRunning));
# Line 2644 | Line 2400 | public class CompletableFutureTest exten
2400          g.complete(v1);
2401  
2402          checkCancelled(f);
2403 <        assertEquals(r.invocationCount, 0);
2403 >        assertEquals(0, r.invocationCount);
2404          checkCompletedNormally(g, v1);
2405          checkCompletedWithWrappedCancellationException(h);
2406 <        }
2651 <    }
2406 >    }}
2407  
2408      public void testRunAfterEither_sourceCancelled2() {
2409          for (ExecutionMode m : ExecutionMode.values())
2410          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2411 <        for (Integer v1 : new Integer[] { 1, null }) {
2412 <
2411 >        for (Integer v1 : new Integer[] { 1, null })
2412 >    {
2413          final CompletableFuture<Integer> f = new CompletableFuture<>();
2414          final CompletableFuture<Integer> g = new CompletableFuture<>();
2415 <        final Noop r = new Noop();
2415 >        final Noop r = new Noop(m);
2416          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2417  
2418          assertTrue(g.cancel(mayInterruptIfRunning));
# Line 2665 | Line 2420 | public class CompletableFutureTest exten
2420          f.complete(v1);
2421  
2422          checkCancelled(g);
2423 <        assertEquals(r.invocationCount, 0);
2423 >        assertEquals(0, r.invocationCount);
2424          checkCompletedNormally(f, v1);
2425          checkCompletedWithWrappedCancellationException(h);
2426 <        }
2672 <    }
2426 >    }}
2427  
2428      public void testRunAfterEither_sourceCancelled3() {
2429          for (ExecutionMode m : ExecutionMode.values())
2430          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2431 <        for (Integer v1 : new Integer[] { 1, null }) {
2432 <
2431 >        for (Integer v1 : new Integer[] { 1, null })
2432 >    {
2433          final CompletableFuture<Integer> f = new CompletableFuture<>();
2434          final CompletableFuture<Integer> g = new CompletableFuture<>();
2435 <        final Noop r = new Noop();
2435 >        final Noop r = new Noop(m);
2436  
2437          assertTrue(g.cancel(mayInterruptIfRunning));
2438          f.complete(v1);
# Line 2687 | Line 2441 | public class CompletableFutureTest exten
2441          // unspecified behavior
2442          Integer v;
2443          try {
2444 <            assertEquals(h.join(), null);
2445 <            assertEquals(r.invocationCount, 1);
2444 >            assertNull(h.join());
2445 >            assertEquals(1, r.invocationCount);
2446          } catch (CompletionException ok) {
2447              checkCompletedWithWrappedCancellationException(h);
2448 <            assertEquals(r.invocationCount, 0);
2448 >            assertEquals(0, r.invocationCount);
2449          }
2450  
2451          checkCancelled(g);
2452          checkCompletedNormally(f, v1);
2453 <        }
2700 <    }
2453 >    }}
2454  
2455      public void testRunAfterEither_sourceCancelled4() {
2456          for (ExecutionMode m : ExecutionMode.values())
2457          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2458 <        for (Integer v1 : new Integer[] { 1, null }) {
2459 <
2458 >        for (Integer v1 : new Integer[] { 1, null })
2459 >    {
2460          final CompletableFuture<Integer> f = new CompletableFuture<>();
2461          final CompletableFuture<Integer> g = new CompletableFuture<>();
2462 <        final Noop r = new Noop();
2462 >        final Noop r = new Noop(m);
2463  
2464          assertTrue(f.cancel(mayInterruptIfRunning));
2465          g.complete(v1);
# Line 2715 | Line 2468 | public class CompletableFutureTest exten
2468          // unspecified behavior
2469          Integer v;
2470          try {
2471 <            assertEquals(h.join(), null);
2472 <            assertEquals(r.invocationCount, 1);
2471 >            assertNull(h.join());
2472 >            assertEquals(1, r.invocationCount);
2473          } catch (CompletionException ok) {
2474              checkCompletedWithWrappedCancellationException(h);
2475 <            assertEquals(r.invocationCount, 0);
2475 >            assertEquals(0, r.invocationCount);
2476          }
2477  
2478          checkCancelled(f);
2479          checkCompletedNormally(g, v1);
2480 <        }
2728 <    }
2480 >    }}
2481  
2482      /**
2483       * thenCompose result completes normally after normal completion of source
2484       */
2485 <    public void testThenCompose() {
2486 <        CompletableFuture<Integer> f, g;
2487 <        CompletableFutureInc r;
2488 <
2489 <        f = new CompletableFuture<>();
2490 <        g = f.thenCompose(r = new CompletableFutureInc());
2491 <        f.complete(one);
2492 <        checkCompletedNormally(g, two);
2493 <        assertTrue(r.ran);
2485 >    public void testThenCompose_normalCompletion() {
2486 >        for (ExecutionMode m : ExecutionMode.values())
2487 >        for (boolean createIncomplete : new boolean[] { true, false })
2488 >        for (Integer v1 : new Integer[] { 1, null })
2489 >    {
2490 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2491 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2492 >        if (!createIncomplete) f.complete(v1);
2493 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2494 >        if (createIncomplete) f.complete(v1);
2495  
2496 <        f = new CompletableFuture<>();
2497 <        f.complete(one);
2498 <        g = f.thenCompose(r = new CompletableFutureInc());
2499 <        checkCompletedNormally(g, two);
2747 <        assertTrue(r.ran);
2748 <    }
2496 >        checkCompletedNormally(g, inc(v1));
2497 >        checkCompletedNormally(f, v1);
2498 >        assertEquals(1, r.invocationCount);
2499 >    }}
2500  
2501      /**
2502       * thenCompose result completes exceptionally after exceptional
2503       * completion of source
2504       */
2505 <    public void testThenCompose2() {
2506 <        CompletableFuture<Integer> f, g;
2507 <        CompletableFutureInc r;
2508 <
2509 <        f = new CompletableFuture<>();
2510 <        g = f.thenCompose(r = new CompletableFutureInc());
2511 <        f.completeExceptionally(new CFException());
2512 <        checkCompletedWithWrappedCFException(g);
2505 >    public void testThenCompose_exceptionalCompletion() {
2506 >        for (ExecutionMode m : ExecutionMode.values())
2507 >        for (boolean createIncomplete : new boolean[] { true, false })
2508 >    {
2509 >        final CFException ex = new CFException();
2510 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2511 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2512 >        if (!createIncomplete) f.completeExceptionally(ex);
2513 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2514 >        if (createIncomplete) f.completeExceptionally(ex);
2515  
2516 <        f = new CompletableFuture<>();
2517 <        f.completeExceptionally(new CFException());
2518 <        g = f.thenCompose(r = new CompletableFutureInc());
2519 <        checkCompletedWithWrappedCFException(g);
2767 <    }
2516 >        checkCompletedWithWrappedCFException(g, ex);
2517 >        checkCompletedWithWrappedCFException(f, ex);
2518 >        assertEquals(0, r.invocationCount);
2519 >    }}
2520  
2521      /**
2522       * thenCompose result completes exceptionally if action does
2523       */
2524 <    public void testThenCompose3() {
2525 <        CompletableFuture<Integer> f, g;
2526 <        FailingCompletableFutureFunction r;
2527 <
2528 <        f = new CompletableFuture<>();
2529 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2530 <        f.complete(one);
2531 <        checkCompletedWithWrappedCFException(g);
2524 >    public void testThenCompose_actionFailed() {
2525 >        for (ExecutionMode m : ExecutionMode.values())
2526 >        for (boolean createIncomplete : new boolean[] { true, false })
2527 >        for (Integer v1 : new Integer[] { 1, null })
2528 >    {
2529 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2530 >        final FailingCompletableFutureFunction r
2531 >            = new FailingCompletableFutureFunction(m);
2532 >        if (!createIncomplete) f.complete(v1);
2533 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2534 >        if (createIncomplete) f.complete(v1);
2535  
2781        f = new CompletableFuture<>();
2782        f.complete(one);
2783        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2536          checkCompletedWithWrappedCFException(g);
2537 <    }
2537 >        checkCompletedNormally(f, v1);
2538 >    }}
2539  
2540      /**
2541       * thenCompose result completes exceptionally if source cancelled
2542       */
2543 <    public void testThenCompose4() {
2544 <        CompletableFuture<Integer> f, g;
2545 <        CompletableFutureInc r;
2546 <
2547 <        f = new CompletableFuture<>();
2548 <        g = f.thenCompose(r = new CompletableFutureInc());
2549 <        assertTrue(f.cancel(true));
2550 <        checkCompletedWithWrappedCancellationException(g);
2551 <
2552 <        f = new CompletableFuture<>();
2553 <        assertTrue(f.cancel(true));
2554 <        g = f.thenCompose(r = new CompletableFutureInc());
2555 <        checkCompletedWithWrappedCancellationException(g);
2803 <    }
2804 <
2805 <    // asyncs
2806 <
2807 <    /**
2808 <     * thenRunAsync result completes normally after normal completion of source
2809 <     */
2810 <    public void testThenRunAsync() {
2811 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2812 <        Noop r = new Noop();
2813 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2814 <        f.complete(null);
2815 <        checkCompletedNormally(g, null);
2816 <
2817 <        // reordered version
2818 <        f = new CompletableFuture<>();
2819 <        f.complete(null);
2820 <        r = new Noop();
2821 <        g = f.thenRunAsync(r);
2822 <        checkCompletedNormally(g, null);
2823 <    }
2824 <
2825 <    /**
2826 <     * thenRunAsync result completes exceptionally after exceptional
2827 <     * completion of source
2828 <     */
2829 <    public void testThenRunAsync2() {
2830 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2831 <        Noop r = new Noop();
2832 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2833 <        f.completeExceptionally(new CFException());
2834 <        try {
2835 <            g.join();
2836 <            shouldThrow();
2837 <        } catch (CompletionException success) {}
2838 <        checkCompletedWithWrappedCFException(g);
2839 <    }
2840 <
2841 <    /**
2842 <     * thenRunAsync result completes exceptionally if action does
2843 <     */
2844 <    public void testThenRunAsync3() {
2845 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2846 <        FailingNoop r = new FailingNoop();
2847 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2848 <        f.complete(null);
2849 <        checkCompletedWithWrappedCFException(g);
2850 <    }
2851 <
2852 <    /**
2853 <     * thenRunAsync result completes exceptionally if source cancelled
2854 <     */
2855 <    public void testThenRunAsync4() {
2856 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2857 <        Noop r = new Noop();
2858 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2859 <        assertTrue(f.cancel(true));
2860 <        checkCompletedWithWrappedCancellationException(g);
2861 <    }
2862 <
2863 <    /**
2864 <     * thenApplyAsync result completes normally after normal completion of source
2865 <     */
2866 <    public void testThenApplyAsync() {
2867 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2868 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2869 <        f.complete(one);
2870 <        checkCompletedNormally(g, two);
2871 <    }
2872 <
2873 <    /**
2874 <     * thenApplyAsync result completes exceptionally after exceptional
2875 <     * completion of source
2876 <     */
2877 <    public void testThenApplyAsync2() {
2878 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2879 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2880 <        f.completeExceptionally(new CFException());
2881 <        checkCompletedWithWrappedCFException(g);
2882 <    }
2883 <
2884 <    /**
2885 <     * thenApplyAsync result completes exceptionally if action does
2886 <     */
2887 <    public void testThenApplyAsync3() {
2888 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2889 <        FailingFunction r = new FailingFunction();
2890 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
2891 <        f.complete(null);
2892 <        checkCompletedWithWrappedCFException(g);
2893 <    }
2894 <
2895 <    /**
2896 <     * thenApplyAsync result completes exceptionally if source cancelled
2897 <     */
2898 <    public void testThenApplyAsync4() {
2899 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2900 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2901 <        assertTrue(f.cancel(true));
2902 <        checkCompletedWithWrappedCancellationException(g);
2903 <    }
2904 <
2905 <    /**
2906 <     * thenAcceptAsync result completes normally after normal
2907 <     * completion of source
2908 <     */
2909 <    public void testThenAcceptAsync() {
2910 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2911 <        IncAction r = new IncAction();
2912 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2913 <        f.complete(one);
2914 <        checkCompletedNormally(g, null);
2915 <        assertEquals(r.value, (Integer) 2);
2916 <    }
2917 <
2918 <    /**
2919 <     * thenAcceptAsync result completes exceptionally after exceptional
2920 <     * completion of source
2921 <     */
2922 <    public void testThenAcceptAsync2() {
2923 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2924 <        IncAction r = new IncAction();
2925 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2926 <        f.completeExceptionally(new CFException());
2927 <        checkCompletedWithWrappedCFException(g);
2928 <    }
2929 <
2930 <    /**
2931 <     * thenAcceptAsync result completes exceptionally if action does
2932 <     */
2933 <    public void testThenAcceptAsync3() {
2934 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2935 <        FailingConsumer r = new FailingConsumer();
2936 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2937 <        f.complete(null);
2938 <        checkCompletedWithWrappedCFException(g);
2939 <    }
2940 <
2941 <    /**
2942 <     * thenAcceptAsync result completes exceptionally if source cancelled
2943 <     */
2944 <    public void testThenAcceptAsync4() {
2945 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2946 <        IncAction r = new IncAction();
2947 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2948 <        assertTrue(f.cancel(true));
2949 <        checkCompletedWithWrappedCancellationException(g);
2950 <    }
2951 <
2952 <    /**
2953 <     * thenComposeAsync result completes normally after normal
2954 <     * completion of source
2955 <     */
2956 <    public void testThenComposeAsync() {
2957 <        CompletableFuture<Integer> f, g;
2958 <        CompletableFutureInc r;
2959 <
2960 <        f = new CompletableFuture<>();
2961 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2962 <        f.complete(one);
2963 <        checkCompletedNormally(g, two);
2964 <
2965 <        f = new CompletableFuture<>();
2966 <        f.complete(one);
2967 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2968 <        checkCompletedNormally(g, two);
2969 <    }
2970 <
2971 <    /**
2972 <     * thenComposeAsync result completes exceptionally after
2973 <     * exceptional completion of source
2974 <     */
2975 <    public void testThenComposeAsync2() {
2976 <        CompletableFuture<Integer> f, g;
2977 <        CompletableFutureInc r;
2978 <
2979 <        f = new CompletableFuture<>();
2980 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2981 <        f.completeExceptionally(new CFException());
2982 <        checkCompletedWithWrappedCFException(g);
2983 <        assertFalse(r.ran);
2984 <
2985 <        f = new CompletableFuture<>();
2986 <        f.completeExceptionally(new CFException());
2987 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2988 <        checkCompletedWithWrappedCFException(g);
2989 <        assertFalse(r.ran);
2990 <    }
2991 <
2992 <    /**
2993 <     * thenComposeAsync result completes exceptionally if action does
2994 <     */
2995 <    public void testThenComposeAsync3() {
2996 <        CompletableFuture<Integer> f, g;
2997 <        FailingCompletableFutureFunction r;
2998 <
2999 <        f = new CompletableFuture<>();
3000 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
3001 <        f.complete(one);
3002 <        checkCompletedWithWrappedCFException(g);
3003 <
3004 <        f = new CompletableFuture<>();
3005 <        f.complete(one);
3006 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
3007 <        checkCompletedWithWrappedCFException(g);
3008 <    }
3009 <
3010 <    /**
3011 <     * thenComposeAsync result completes exceptionally if source cancelled
3012 <     */
3013 <    public void testThenComposeAsync4() {
3014 <        CompletableFuture<Integer> f, g;
3015 <        CompletableFutureInc r;
3016 <
3017 <        f = new CompletableFuture<>();
3018 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3019 <        assertTrue(f.cancel(true));
3020 <        checkCompletedWithWrappedCancellationException(g);
3021 <
3022 <        f = new CompletableFuture<>();
3023 <        assertTrue(f.cancel(true));
3024 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3025 <        checkCompletedWithWrappedCancellationException(g);
3026 <    }
3027 <
3028 <    // async with explicit executors
3029 <
3030 <    /**
3031 <     * thenRunAsync result completes normally after normal completion of source
3032 <     */
3033 <    public void testThenRunAsyncE() {
3034 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3035 <        Noop r = new Noop();
3036 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3037 <        f.complete(null);
3038 <        checkCompletedNormally(g, null);
3039 <
3040 <        // reordered version
3041 <        f = new CompletableFuture<>();
3042 <        f.complete(null);
3043 <        r = new Noop();
3044 <        g = f.thenRunAsync(r, new ThreadExecutor());
3045 <        checkCompletedNormally(g, null);
3046 <    }
3047 <
3048 <    /**
3049 <     * thenRunAsync result completes exceptionally after exceptional
3050 <     * completion of source
3051 <     */
3052 <    public void testThenRunAsync2E() {
3053 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3054 <        Noop r = new Noop();
3055 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3056 <        f.completeExceptionally(new CFException());
3057 <        try {
3058 <            g.join();
3059 <            shouldThrow();
3060 <        } catch (CompletionException success) {}
3061 <        checkCompletedWithWrappedCFException(g);
3062 <    }
3063 <
3064 <    /**
3065 <     * thenRunAsync result completes exceptionally if action does
3066 <     */
3067 <    public void testThenRunAsync3E() {
3068 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3069 <        FailingNoop r = new FailingNoop();
3070 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3071 <        f.complete(null);
3072 <        checkCompletedWithWrappedCFException(g);
3073 <    }
3074 <
3075 <    /**
3076 <     * thenRunAsync result completes exceptionally if source cancelled
3077 <     */
3078 <    public void testThenRunAsync4E() {
3079 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3080 <        Noop r = new Noop();
3081 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3082 <        assertTrue(f.cancel(true));
3083 <        checkCompletedWithWrappedCancellationException(g);
3084 <    }
3085 <
3086 <    /**
3087 <     * thenApplyAsync result completes normally after normal completion of source
3088 <     */
3089 <    public void testThenApplyAsyncE() {
3090 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3091 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3092 <        f.complete(one);
3093 <        checkCompletedNormally(g, two);
3094 <    }
3095 <
3096 <    /**
3097 <     * thenApplyAsync result completes exceptionally after exceptional
3098 <     * completion of source
3099 <     */
3100 <    public void testThenApplyAsync2E() {
3101 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3102 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3103 <        f.completeExceptionally(new CFException());
3104 <        checkCompletedWithWrappedCFException(g);
3105 <    }
3106 <
3107 <    /**
3108 <     * thenApplyAsync result completes exceptionally if action does
3109 <     */
3110 <    public void testThenApplyAsync3E() {
3111 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3112 <        FailingFunction r = new FailingFunction();
3113 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
3114 <        f.complete(null);
3115 <        checkCompletedWithWrappedCFException(g);
3116 <    }
3117 <
3118 <    /**
3119 <     * thenApplyAsync result completes exceptionally if source cancelled
3120 <     */
3121 <    public void testThenApplyAsync4E() {
3122 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3123 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3124 <        assertTrue(f.cancel(true));
3125 <        checkCompletedWithWrappedCancellationException(g);
3126 <    }
3127 <
3128 <    /**
3129 <     * thenAcceptAsync result completes normally after normal
3130 <     * completion of source
3131 <     */
3132 <    public void testThenAcceptAsyncE() {
3133 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3134 <        IncAction r = new IncAction();
3135 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3136 <        f.complete(one);
3137 <        checkCompletedNormally(g, null);
3138 <        assertEquals(r.value, (Integer) 2);
3139 <    }
3140 <
3141 <    /**
3142 <     * thenAcceptAsync result completes exceptionally after exceptional
3143 <     * completion of source
3144 <     */
3145 <    public void testThenAcceptAsync2E() {
3146 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3147 <        IncAction r = new IncAction();
3148 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3149 <        f.completeExceptionally(new CFException());
3150 <        checkCompletedWithWrappedCFException(g);
3151 <    }
3152 <
3153 <    /**
3154 <     * thenAcceptAsync result completes exceptionally if action does
3155 <     */
3156 <    public void testThenAcceptAsync3E() {
3157 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3158 <        FailingConsumer r = new FailingConsumer();
3159 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3160 <        f.complete(null);
3161 <        checkCompletedWithWrappedCFException(g);
3162 <    }
3163 <
3164 <    /**
3165 <     * thenAcceptAsync result completes exceptionally if source cancelled
3166 <     */
3167 <    public void testThenAcceptAsync4E() {
3168 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3169 <        IncAction r = new IncAction();
3170 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3171 <        assertTrue(f.cancel(true));
3172 <        checkCompletedWithWrappedCancellationException(g);
3173 <    }
3174 <
3175 <    /**
3176 <     * thenComposeAsync result completes normally after normal
3177 <     * completion of source
3178 <     */
3179 <    public void testThenComposeAsyncE() {
3180 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3181 <        CompletableFutureInc r = new CompletableFutureInc();
3182 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3183 <        f.complete(one);
3184 <        checkCompletedNormally(g, two);
3185 <    }
3186 <
3187 <    /**
3188 <     * thenComposeAsync result completes exceptionally after
3189 <     * exceptional completion of source
3190 <     */
3191 <    public void testThenComposeAsync2E() {
3192 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3193 <        CompletableFutureInc r = new CompletableFutureInc();
3194 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3195 <        f.completeExceptionally(new CFException());
3196 <        checkCompletedWithWrappedCFException(g);
3197 <    }
3198 <
3199 <    /**
3200 <     * thenComposeAsync result completes exceptionally if action does
3201 <     */
3202 <    public void testThenComposeAsync3E() {
3203 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3204 <        FailingCompletableFutureFunction r = new FailingCompletableFutureFunction();
3205 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3206 <        f.complete(one);
3207 <        checkCompletedWithWrappedCFException(g);
3208 <    }
2543 >    public void testThenCompose_sourceCancelled() {
2544 >        for (ExecutionMode m : ExecutionMode.values())
2545 >        for (boolean createIncomplete : new boolean[] { true, false })
2546 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2547 >    {
2548 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2549 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2550 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2551 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2552 >        if (createIncomplete) {
2553 >            checkIncomplete(g);
2554 >            assertTrue(f.cancel(mayInterruptIfRunning));
2555 >        }
2556  
3210    /**
3211     * thenComposeAsync result completes exceptionally if source cancelled
3212     */
3213    public void testThenComposeAsync4E() {
3214        CompletableFuture<Integer> f = new CompletableFuture<>();
3215        CompletableFutureInc r = new CompletableFutureInc();
3216        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3217        assertTrue(f.cancel(true));
2557          checkCompletedWithWrappedCancellationException(g);
2558 <    }
2558 >        checkCancelled(f);
2559 >    }}
2560  
2561      // other static methods
2562  
# Line 3380 | Line 2720 | public class CompletableFutureTest exten
2720  
2721              () -> f.thenCompose(null),
2722              () -> f.thenComposeAsync(null),
2723 <            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
2723 >            () -> f.thenComposeAsync(new CompletableFutureInc(ExecutionMode.EXECUTOR), null),
2724              () -> f.thenComposeAsync(null, exec),
2725  
2726              () -> f.exceptionally(null),
# Line 3418 | Line 2758 | public class CompletableFutureTest exten
2758       */
2759      public void testWhenComplete_normalCompletion1() {
2760          for (ExecutionMode m : ExecutionMode.values())
2761 <        for (Integer v1 : new Integer[] { 1, null }) {
2762 <
2763 <        final AtomicInteger a = new AtomicInteger();
2761 >        for (boolean createIncomplete : new boolean[] { true, false })
2762 >        for (Integer v1 : new Integer[] { 1, null })
2763 >    {
2764 >        final AtomicInteger a = new AtomicInteger(0);
2765          final CompletableFuture<Integer> f = new CompletableFuture<>();
2766 <        final CompletableFuture<Integer> g =
2767 <            m.whenComplete(f,
2768 <                           (Integer x, Throwable t) -> {
2769 <                               threadAssertSame(x, v1);
2770 <                               threadAssertNull(t);
2771 <                               a.getAndIncrement();
2772 <                           });
2773 <        f.complete(v1);
2774 <        checkCompletedNormally(f, v1);
2766 >        if (!createIncomplete) f.complete(v1);
2767 >        final CompletableFuture<Integer> g = m.whenComplete
2768 >            (f,
2769 >             (Integer x, Throwable t) -> {
2770 >                threadAssertSame(x, v1);
2771 >                threadAssertNull(t);
2772 >                a.getAndIncrement();
2773 >            });
2774 >        if (createIncomplete) f.complete(v1);
2775 >
2776          checkCompletedNormally(g, v1);
2777 <        assertEquals(a.get(), 1);
2778 <        }
2779 <    }
2777 >        checkCompletedNormally(f, v1);
2778 >        assertEquals(1, a.get());
2779 >    }}
2780  
2781      /**
2782       * whenComplete action executes on exceptional completion, propagating
# Line 3442 | Line 2784 | public class CompletableFutureTest exten
2784       */
2785      public void testWhenComplete_exceptionalCompletion() {
2786          for (ExecutionMode m : ExecutionMode.values())
2787 <        for (Integer v1 : new Integer[] { 1, null }) {
2788 <
2789 <        final AtomicInteger a = new AtomicInteger();
2787 >        for (boolean createIncomplete : new boolean[] { true, false })
2788 >        for (Integer v1 : new Integer[] { 1, null })
2789 >    {
2790 >        final AtomicInteger a = new AtomicInteger(0);
2791          final CFException ex = new CFException();
2792          final CompletableFuture<Integer> f = new CompletableFuture<>();
2793 +        if (!createIncomplete) f.completeExceptionally(ex);
2794          final CompletableFuture<Integer> g = m.whenComplete
2795              (f,
2796               (Integer x, Throwable t) -> {
# Line 3454 | Line 2798 | public class CompletableFutureTest exten
2798                  threadAssertSame(t, ex);
2799                  a.getAndIncrement();
2800              });
2801 <        f.completeExceptionally(ex);
2801 >        if (createIncomplete) f.completeExceptionally(ex);
2802          checkCompletedWithWrappedCFException(f, ex);
2803          checkCompletedWithWrappedCFException(g, ex);
2804 <        assertEquals(a.get(), 1);
2805 <        }
2806 <    }
2804 >        assertEquals(1, a.get());
2805 >    }}
2806 >
2807 >    /**
2808 >     * whenComplete action executes on cancelled source, propagating
2809 >     * CancellationException.
2810 >     */
2811 >    public void testWhenComplete_sourceCancelled() {
2812 >        for (ExecutionMode m : ExecutionMode.values())
2813 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2814 >        for (boolean createIncomplete : new boolean[] { true, false })
2815 >    {
2816 >        final AtomicInteger a = new AtomicInteger(0);
2817 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2818 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2819 >        final CompletableFuture<Integer> g = m.whenComplete
2820 >            (f,
2821 >             (Integer x, Throwable t) -> {
2822 >                threadAssertNull(x);
2823 >                threadAssertTrue(t instanceof CancellationException);
2824 >                a.getAndIncrement();
2825 >            });
2826 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2827 >
2828 >        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2829 >        checkCompletedWithWrappedCancellationException(g);
2830 >        checkCancelled(f);
2831 >        assertEquals(1, a.get());
2832 >    }}
2833  
2834      /**
2835       * If a whenComplete action throws an exception when triggered by
2836       * a normal completion, it completes exceptionally
2837       */
2838      public void testWhenComplete_actionFailed() {
2839 +        for (boolean createIncomplete : new boolean[] { true, false })
2840          for (ExecutionMode m : ExecutionMode.values())
2841 <        for (Integer v1 : new Integer[] { 1, null }) {
2842 <
2841 >        for (Integer v1 : new Integer[] { 1, null })
2842 >    {
2843 >        final AtomicInteger a = new AtomicInteger(0);
2844          final CFException ex = new CFException();
2845          final CompletableFuture<Integer> f = new CompletableFuture<>();
2846 +        if (!createIncomplete) f.complete(v1);
2847          final CompletableFuture<Integer> g = m.whenComplete
2848              (f,
2849               (Integer x, Throwable t) -> {
2850                  threadAssertSame(x, v1);
2851                  threadAssertNull(t);
2852 +                a.getAndIncrement();
2853                  throw ex;
2854              });
2855 <        f.complete(v1);
2855 >        if (createIncomplete) f.complete(v1);
2856          checkCompletedNormally(f, v1);
2857          checkCompletedWithWrappedCFException(g, ex);
2858 <        }
2859 <    }
2858 >        assertEquals(1, a.get());
2859 >    }}
2860  
2861      /**
2862       * If a whenComplete action throws an exception when triggered by
# Line 3490 | Line 2864 | public class CompletableFutureTest exten
2864       * exception takes precedence.
2865       */
2866      public void testWhenComplete_actionFailedSourceFailed() {
2867 +        for (boolean createIncomplete : new boolean[] { true, false })
2868          for (ExecutionMode m : ExecutionMode.values())
2869 <        for (Integer v1 : new Integer[] { 1, null }) {
2870 <
2869 >        for (Integer v1 : new Integer[] { 1, null })
2870 >    {
2871 >        final AtomicInteger a = new AtomicInteger(0);
2872          final CFException ex1 = new CFException();
2873          final CFException ex2 = new CFException();
2874          final CompletableFuture<Integer> f = new CompletableFuture<>();
2875 +
2876 +        if (!createIncomplete) f.completeExceptionally(ex1);
2877          final CompletableFuture<Integer> g = m.whenComplete
2878              (f,
2879               (Integer x, Throwable t) -> {
2880                  threadAssertSame(t, ex1);
2881                  threadAssertNull(x);
2882 +                a.getAndIncrement();
2883                  throw ex2;
2884              });
2885 <        f.completeExceptionally(ex1);
2885 >        if (createIncomplete) f.completeExceptionally(ex1);
2886 >
2887          checkCompletedWithWrappedCFException(f, ex1);
2888          checkCompletedWithWrappedCFException(g, ex1);
2889 <        }
2890 <    }
3511 <
3512 <    /**
3513 <     * handleAsync action completes normally with function value on
3514 <     * either normal or exceptional completion of source
3515 <     */
3516 <    public void testHandleAsync() {
3517 <        CompletableFuture<Integer> f, g;
3518 <        IntegerHandler r;
3519 <
3520 <        f = new CompletableFuture<>();
3521 <        g = f.handleAsync(r = new IntegerHandler());
3522 <        assertFalse(r.ran);
3523 <        f.completeExceptionally(new CFException());
3524 <        checkCompletedWithWrappedCFException(f);
3525 <        checkCompletedNormally(g, three);
3526 <        assertTrue(r.ran);
3527 <
3528 <        f = new CompletableFuture<>();
3529 <        g = f.handleAsync(r = new IntegerHandler());
3530 <        assertFalse(r.ran);
3531 <        f.completeExceptionally(new CFException());
3532 <        checkCompletedWithWrappedCFException(f);
3533 <        checkCompletedNormally(g, three);
3534 <        assertTrue(r.ran);
3535 <
3536 <        f = new CompletableFuture<>();
3537 <        g = f.handleAsync(r = new IntegerHandler());
3538 <        assertFalse(r.ran);
3539 <        f.complete(one);
3540 <        checkCompletedNormally(f, one);
3541 <        checkCompletedNormally(g, two);
3542 <        assertTrue(r.ran);
3543 <
3544 <        f = new CompletableFuture<>();
3545 <        g = f.handleAsync(r = new IntegerHandler());
3546 <        assertFalse(r.ran);
3547 <        f.complete(one);
3548 <        checkCompletedNormally(f, one);
3549 <        checkCompletedNormally(g, two);
3550 <        assertTrue(r.ran);
3551 <    }
3552 <
3553 <    /**
3554 <     * handleAsync action with Executor completes normally with
3555 <     * function value on either normal or exceptional completion of
3556 <     * source
3557 <     */
3558 <    public void testHandleAsync2() {
3559 <        CompletableFuture<Integer> f, g;
3560 <        ThreadExecutor exec = new ThreadExecutor();
3561 <        IntegerHandler r;
3562 <
3563 <        f = new CompletableFuture<>();
3564 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3565 <        assertFalse(r.ran);
3566 <        f.completeExceptionally(new CFException());
3567 <        checkCompletedWithWrappedCFException(f);
3568 <        checkCompletedNormally(g, three);
3569 <        assertTrue(r.ran);
3570 <
3571 <        f = new CompletableFuture<>();
3572 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3573 <        assertFalse(r.ran);
3574 <        f.completeExceptionally(new CFException());
3575 <        checkCompletedWithWrappedCFException(f);
3576 <        checkCompletedNormally(g, three);
3577 <        assertTrue(r.ran);
3578 <
3579 <        f = new CompletableFuture<>();
3580 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3581 <        assertFalse(r.ran);
3582 <        f.complete(one);
3583 <        checkCompletedNormally(f, one);
3584 <        checkCompletedNormally(g, two);
3585 <        assertTrue(r.ran);
3586 <
3587 <        f = new CompletableFuture<>();
3588 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3589 <        assertFalse(r.ran);
3590 <        f.complete(one);
3591 <        checkCompletedNormally(f, one);
3592 <        checkCompletedNormally(g, two);
3593 <        assertTrue(r.ran);
3594 <    }
2889 >        assertEquals(1, a.get());
2890 >    }}
2891  
2892   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines