ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.44 by jsr166, Mon Jun 2 06:06:30 2014 UTC vs.
Revision 1.56 by jsr166, Mon Jun 2 22:20:32 2014 UTC

# Line 17 | Line 17 | import java.util.concurrent.Future;
17   import java.util.concurrent.CompletableFuture;
18   import java.util.concurrent.CompletionException;
19   import java.util.concurrent.CompletionStage;
20 + import java.util.concurrent.ForkJoinPool;
21 + import java.util.concurrent.ForkJoinTask;
22   import java.util.concurrent.TimeoutException;
23   import java.util.concurrent.atomic.AtomicInteger;
24   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 247 | Line 249 | public class CompletableFutureTest exten
249          f = new CompletableFuture<>();
250          f.obtrudeValue(three);
251          checkCompletedNormally(f, three);
252 +        f.obtrudeValue(null);
253 +        checkCompletedNormally(f, null);
254          f = new CompletableFuture<>();
255          f.completeExceptionally(new CFException());
256          f.obtrudeValue(four);
# Line 279 | Line 283 | public class CompletableFutureTest exten
283       */
284      public void testGetNumberOfDependents() {
285          CompletableFuture<Integer> f = new CompletableFuture<>();
286 <        assertEquals(f.getNumberOfDependents(), 0);
287 <        CompletableFuture g = f.thenRun(new Noop());
288 <        assertEquals(f.getNumberOfDependents(), 1);
289 <        assertEquals(g.getNumberOfDependents(), 0);
290 <        CompletableFuture h = f.thenRun(new Noop());
291 <        assertEquals(f.getNumberOfDependents(), 2);
286 >        assertEquals(0, f.getNumberOfDependents());
287 >        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
288 >        assertEquals(1, f.getNumberOfDependents());
289 >        assertEquals(0, g.getNumberOfDependents());
290 >        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
291 >        assertEquals(2, f.getNumberOfDependents());
292          f.complete(1);
293          checkCompletedNormally(g, null);
294 <        assertEquals(f.getNumberOfDependents(), 0);
295 <        assertEquals(g.getNumberOfDependents(), 0);
294 >        assertEquals(0, f.getNumberOfDependents());
295 >        assertEquals(0, g.getNumberOfDependents());
296      }
297  
298      /**
# Line 345 | Line 349 | public class CompletableFutureTest exten
349          }
350      }
351      static final class IncFunction implements Function<Integer,Integer> {
352 +        final ExecutionMode m;
353          int invocationCount = 0;
354          Integer value;
355 +        IncFunction(ExecutionMode m) { this.m = m; }
356          public Integer apply(Integer x) {
357 +            m.checkExecutionMode();
358              invocationCount++;
359              return value = inc(x);
360          }
361      }
362      static final class SubtractAction implements BiConsumer<Integer, Integer> {
363 +        final ExecutionMode m;
364          int invocationCount = 0;
365          Integer value;
366          // Check this action was invoked exactly once when result is computed.
367 +        SubtractAction(ExecutionMode m) { this.m = m; }
368          public void accept(Integer x, Integer y) {
369 +            m.checkExecutionMode();
370              invocationCount++;
371              value = subtract(x, y);
372          }
373      }
374      static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
375 +        final ExecutionMode m;
376          int invocationCount = 0;
377          Integer value;
378          // Check this action was invoked exactly once when result is computed.
379 +        SubtractFunction(ExecutionMode m) { this.m = m; }
380          public Integer apply(Integer x, Integer y) {
381 +            m.checkExecutionMode();
382              invocationCount++;
383              return value = subtract(x, y);
384          }
385      }
386      static final class Noop implements Runnable {
387 +        final ExecutionMode m;
388          int invocationCount = 0;
389 +        Noop(ExecutionMode m) { this.m = m; }
390          public void run() {
391 +            m.checkExecutionMode();
392              invocationCount++;
393          }
394      }
395  
396      static final class FailingSupplier implements Supplier<Integer> {
397 +        final ExecutionMode m;
398          int invocationCount = 0;
399 +        FailingSupplier(ExecutionMode m) { this.m = m; }
400          public Integer get() {
401 +            m.checkExecutionMode();
402              invocationCount++;
403              throw new CFException();
404          }
405      }
406      static final class FailingConsumer implements Consumer<Integer> {
407 +        final ExecutionMode m;
408          int invocationCount = 0;
409 +        FailingConsumer(ExecutionMode m) { this.m = m; }
410          public void accept(Integer x) {
411 +            m.checkExecutionMode();
412              invocationCount++;
413              throw new CFException();
414          }
415      }
416      static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
417 +        final ExecutionMode m;
418          int invocationCount = 0;
419 +        FailingBiConsumer(ExecutionMode m) { this.m = m; }
420          public void accept(Integer x, Integer y) {
421 +            m.checkExecutionMode();
422              invocationCount++;
423              throw new CFException();
424          }
425      }
426      static final class FailingFunction implements Function<Integer, Integer> {
427 +        final ExecutionMode m;
428          int invocationCount = 0;
429 +        FailingFunction(ExecutionMode m) { this.m = m; }
430          public Integer apply(Integer x) {
431 +            m.checkExecutionMode();
432              invocationCount++;
433              throw new CFException();
434          }
435      }
436      static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
437 +        final ExecutionMode m;
438          int invocationCount = 0;
439 +        FailingBiFunction(ExecutionMode m) { this.m = m; }
440          public Integer apply(Integer x, Integer y) {
441 +            m.checkExecutionMode();
442              invocationCount++;
443              throw new CFException();
444          }
445      }
446 <    static final class FailingNoop implements Runnable {
446 >    static final class FailingRunnable implements Runnable {
447 >        final ExecutionMode m;
448          int invocationCount = 0;
449 +        FailingRunnable(ExecutionMode m) { this.m = m; }
450          public void run() {
451 +            m.checkExecutionMode();
452              invocationCount++;
453              throw new CFException();
454          }
# Line 422 | Line 456 | public class CompletableFutureTest exten
456  
457      static final class CompletableFutureInc
458          implements Function<Integer, CompletableFuture<Integer>> {
459 +        final ExecutionMode m;
460          int invocationCount = 0;
461 +        CompletableFutureInc(ExecutionMode m) { this.m = m; }
462          public CompletableFuture<Integer> apply(Integer x) {
463 +            m.checkExecutionMode();
464              invocationCount++;
465              CompletableFuture<Integer> f = new CompletableFuture<>();
466              f.complete(inc(x));
# Line 433 | Line 470 | public class CompletableFutureTest exten
470  
471      static final class FailingCompletableFutureFunction
472          implements Function<Integer, CompletableFuture<Integer>> {
473 +        final ExecutionMode m;
474          int invocationCount = 0;
475 +        FailingCompletableFutureFunction(ExecutionMode m) { this.m = m; }
476          public CompletableFuture<Integer> apply(Integer x) {
477 +            m.checkExecutionMode();
478              invocationCount++;
479              throw new CFException();
480          }
# Line 442 | Line 482 | public class CompletableFutureTest exten
482  
483      // Used for explicit executor tests
484      static final class ThreadExecutor implements Executor {
485 <        AtomicInteger count = new AtomicInteger(0);
485 >        final AtomicInteger count = new AtomicInteger(0);
486 >        static final ThreadGroup tg = new ThreadGroup("ThreadExecutor");
487 >        static boolean startedCurrentThread() {
488 >            return Thread.currentThread().getThreadGroup() == tg;
489 >        }
490  
491          public void execute(Runnable r) {
492              count.getAndIncrement();
493 <            new Thread(r).start();
450 <        }
451 <    }
452 <
453 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
454 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
455 <    }
456 <
457 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
458 <        int invocationCount = 0;
459 <        public Integer apply(Integer x, Throwable t) {
460 <            invocationCount++;
461 <            return (t == null) ? two : three;
493 >            new Thread(tg, r).start();
494          }
495      }
496  
# Line 468 | Line 500 | public class CompletableFutureTest exten
500       */
501      enum ExecutionMode {
502          DEFAULT {
503 +            public void checkExecutionMode() {
504 +                assertNull(ForkJoinTask.getPool());
505 +            }
506 +            public <T> CompletableFuture<Void> thenRun
507 +                (CompletableFuture<T> f, Runnable a) {
508 +                return f.thenRun(a);
509 +            }
510 +            public <T> CompletableFuture<Void> thenAccept
511 +                (CompletableFuture<T> f, Consumer<? super T> a) {
512 +                return f.thenAccept(a);
513 +            }
514 +            public <T,U> CompletableFuture<U> thenApply
515 +                (CompletableFuture<T> f, Function<? super T,U> a) {
516 +                return f.thenApply(a);
517 +            }
518 +            public <T,U> CompletableFuture<U> thenCompose
519 +                (CompletableFuture<T> f,
520 +                 Function<? super T,? extends CompletionStage<U>> a) {
521 +                return f.thenCompose(a);
522 +            }
523 +            public <T,U> CompletableFuture<U> handle
524 +                (CompletableFuture<T> f,
525 +                 BiFunction<? super T,Throwable,? extends U> a) {
526 +                return f.handle(a);
527 +            }
528 +            public <T> CompletableFuture<T> whenComplete
529 +                (CompletableFuture<T> f,
530 +                 BiConsumer<? super T,? super Throwable> a) {
531 +                return f.whenComplete(a);
532 +            }
533              public <T,U> CompletableFuture<Void> runAfterBoth
534                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
535                  return f.runAfterBoth(g, a);
# Line 484 | Line 546 | public class CompletableFutureTest exten
546                   BiFunction<? super T,? super U,? extends V> a) {
547                  return f.thenCombine(g, a);
548              }
549 <            public <T,U> CompletableFuture<U> applyToEither
549 >            public <T> CompletableFuture<Void> runAfterEither
550                  (CompletableFuture<T> f,
551 <                 CompletionStage<? extends T> g,
552 <                 Function<? super T,U> a) {
553 <                return f.applyToEither(g, a);
551 >                 CompletionStage<?> g,
552 >                 java.lang.Runnable a) {
553 >                return f.runAfterEither(g, a);
554              }
555              public <T> CompletableFuture<Void> acceptEither
556                  (CompletableFuture<T> f,
# Line 496 | Line 558 | public class CompletableFutureTest exten
558                   Consumer<? super T> a) {
559                  return f.acceptEither(g, a);
560              }
561 <            public <T> CompletableFuture<Void> runAfterEither
561 >            public <T,U> CompletableFuture<U> applyToEither
562                  (CompletableFuture<T> f,
563 <                 CompletionStage<?> g,
564 <                 java.lang.Runnable a) {
565 <                return f.runAfterEither(g, a);
563 >                 CompletionStage<? extends T> g,
564 >                 Function<? super T,U> a) {
565 >                return f.applyToEither(g, a);
566 >            }
567 >        },
568 >
569 >        ASYNC {
570 >            public void checkExecutionMode() {
571 >                assertSame(ForkJoinPool.commonPool(),
572 >                           ForkJoinTask.getPool());
573 >            }
574 >            public <T> CompletableFuture<Void> thenRun
575 >                (CompletableFuture<T> f, Runnable a) {
576 >                return f.thenRunAsync(a);
577 >            }
578 >            public <T> CompletableFuture<Void> thenAccept
579 >                (CompletableFuture<T> f, Consumer<? super T> a) {
580 >                return f.thenAcceptAsync(a);
581 >            }
582 >            public <T,U> CompletableFuture<U> thenApply
583 >                (CompletableFuture<T> f, Function<? super T,U> a) {
584 >                return f.thenApplyAsync(a);
585              }
586              public <T,U> CompletableFuture<U> thenCompose
587                  (CompletableFuture<T> f,
588                   Function<? super T,? extends CompletionStage<U>> a) {
589 <                return f.thenCompose(a);
589 >                return f.thenComposeAsync(a);
590 >            }
591 >            public <T,U> CompletableFuture<U> handle
592 >                (CompletableFuture<T> f,
593 >                 BiFunction<? super T,Throwable,? extends U> a) {
594 >                return f.handleAsync(a);
595              }
596              public <T> CompletableFuture<T> whenComplete
597                  (CompletableFuture<T> f,
598                   BiConsumer<? super T,? super Throwable> a) {
599 <                return f.whenComplete(a);
599 >                return f.whenCompleteAsync(a);
600              }
515        },
516
517 //             /** Experimental way to do more testing */
518 //         REVERSE_DEFAULT {
519 //             public <T,U> CompletableFuture<Void> runAfterBoth
520 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
521 //                 return g.runAfterBoth(f, a);
522 //             }
523 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
524 //                 (CompletableFuture<T> f,
525 //                  CompletionStage<? extends U> g,
526 //                  BiConsumer<? super T,? super U> a) {
527 //                 return DEFAULT.thenAcceptBoth(f, g, a);
528 //             }
529 //         },
530
531        DEFAULT_ASYNC {
601              public <T,U> CompletableFuture<Void> runAfterBoth
602                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
603                  return f.runAfterBothAsync(g, a);
# Line 545 | Line 614 | public class CompletableFutureTest exten
614                   BiFunction<? super T,? super U,? extends V> a) {
615                  return f.thenCombineAsync(g, a);
616              }
617 <            public <T,U> CompletableFuture<U> applyToEither
617 >            public <T> CompletableFuture<Void> runAfterEither
618                  (CompletableFuture<T> f,
619 <                 CompletionStage<? extends T> g,
620 <                 Function<? super T,U> a) {
621 <                return f.applyToEitherAsync(g, a);
619 >                 CompletionStage<?> g,
620 >                 java.lang.Runnable a) {
621 >                return f.runAfterEitherAsync(g, a);
622              }
623              public <T> CompletableFuture<Void> acceptEither
624                  (CompletableFuture<T> f,
# Line 557 | Line 626 | public class CompletableFutureTest exten
626                   Consumer<? super T> a) {
627                  return f.acceptEitherAsync(g, a);
628              }
629 <            public <T> CompletableFuture<Void> runAfterEither
629 >            public <T,U> CompletableFuture<U> applyToEither
630                  (CompletableFuture<T> f,
631 <                 CompletionStage<?> g,
632 <                 java.lang.Runnable a) {
633 <                return f.runAfterEitherAsync(g, a);
631 >                 CompletionStage<? extends T> g,
632 >                 Function<? super T,U> a) {
633 >                return f.applyToEitherAsync(g, a);
634 >            }
635 >        },
636 >
637 >        EXECUTOR {
638 >            public void checkExecutionMode() {
639 >                assertTrue(ThreadExecutor.startedCurrentThread());
640 >            }
641 >            public <T> CompletableFuture<Void> thenRun
642 >                (CompletableFuture<T> f, Runnable a) {
643 >                return f.thenRunAsync(a, new ThreadExecutor());
644 >            }
645 >            public <T> CompletableFuture<Void> thenAccept
646 >                (CompletableFuture<T> f, Consumer<? super T> a) {
647 >                return f.thenAcceptAsync(a, new ThreadExecutor());
648 >            }
649 >            public <T,U> CompletableFuture<U> thenApply
650 >                (CompletableFuture<T> f, Function<? super T,U> a) {
651 >                return f.thenApplyAsync(a, new ThreadExecutor());
652              }
653              public <T,U> CompletableFuture<U> thenCompose
654                  (CompletableFuture<T> f,
655                   Function<? super T,? extends CompletionStage<U>> a) {
656 <                return f.thenComposeAsync(a);
656 >                return f.thenComposeAsync(a, new ThreadExecutor());
657 >            }
658 >            public <T,U> CompletableFuture<U> handle
659 >                (CompletableFuture<T> f,
660 >                 BiFunction<? super T,Throwable,? extends U> a) {
661 >                return f.handleAsync(a, new ThreadExecutor());
662              }
663              public <T> CompletableFuture<T> whenComplete
664                  (CompletableFuture<T> f,
665                   BiConsumer<? super T,? super Throwable> a) {
666 <                return f.whenCompleteAsync(a);
666 >                return f.whenCompleteAsync(a, new ThreadExecutor());
667              }
576        },
577
578 //         REVERSE_DEFAULT_ASYNC {
579 //             public <T,U> CompletableFuture<Void> runAfterBoth
580 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
581 //                 return f.runAfterBothAsync(g, a);
582 //             }
583 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
584 //                 (CompletableFuture<T> f,
585 //                  CompletionStage<? extends U> g,
586 //                  BiConsumer<? super T,? super U> a) {
587 //                 return DEFAULT_ASYNC.thenAcceptBoth(f, g, a);
588 //             }
589 //         },
590
591        EXECUTOR {
668              public <T,U> CompletableFuture<Void> runAfterBoth
669                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
670                  return f.runAfterBothAsync(g, a, new ThreadExecutor());
# Line 605 | Line 681 | public class CompletableFutureTest exten
681                   BiFunction<? super T,? super U,? extends V> a) {
682                  return f.thenCombineAsync(g, a, new ThreadExecutor());
683              }
608            public <T,U> CompletableFuture<U> applyToEither
609                (CompletableFuture<T> f,
610                 CompletionStage<? extends T> g,
611                 Function<? super T,U> a) {
612                return f.applyToEitherAsync(g, a, new ThreadExecutor());
613            }
614            public <T> CompletableFuture<Void> acceptEither
615                (CompletableFuture<T> f,
616                 CompletionStage<? extends T> g,
617                 Consumer<? super T> a) {
618                return f.acceptEitherAsync(g, a, new ThreadExecutor());
619            }
684              public <T> CompletableFuture<Void> runAfterEither
685                  (CompletableFuture<T> f,
686                   CompletionStage<?> g,
687                   java.lang.Runnable a) {
688                  return f.runAfterEitherAsync(g, a, new ThreadExecutor());
689              }
690 <            public <T,U> CompletableFuture<U> thenCompose
690 >            public <T> CompletableFuture<Void> acceptEither
691                  (CompletableFuture<T> f,
692 <                 Function<? super T,? extends CompletionStage<U>> a) {
693 <                return f.thenComposeAsync(a, new ThreadExecutor());
692 >                 CompletionStage<? extends T> g,
693 >                 Consumer<? super T> a) {
694 >                return f.acceptEitherAsync(g, a, new ThreadExecutor());
695              }
696 <            public <T> CompletableFuture<T> whenComplete
696 >            public <T,U> CompletableFuture<U> applyToEither
697                  (CompletableFuture<T> f,
698 <                 BiConsumer<? super T,? super Throwable> a) {
699 <                return f.whenCompleteAsync(a, new ThreadExecutor());
698 >                 CompletionStage<? extends T> g,
699 >                 Function<? super T,U> a) {
700 >                return f.applyToEitherAsync(g, a, new ThreadExecutor());
701              }
702          };
703  
704 +        public abstract void checkExecutionMode();
705 +        public abstract <T> CompletableFuture<Void> thenRun
706 +            (CompletableFuture<T> f, Runnable a);
707 +        public abstract <T> CompletableFuture<Void> thenAccept
708 +            (CompletableFuture<T> f, Consumer<? super T> a);
709 +        public abstract <T,U> CompletableFuture<U> thenApply
710 +            (CompletableFuture<T> f, Function<? super T,U> a);
711 +        public abstract <T,U> CompletableFuture<U> thenCompose
712 +            (CompletableFuture<T> f,
713 +             Function<? super T,? extends CompletionStage<U>> a);
714 +        public abstract <T,U> CompletableFuture<U> handle
715 +            (CompletableFuture<T> f,
716 +             BiFunction<? super T,Throwable,? extends U> a);
717 +        public abstract <T> CompletableFuture<T> whenComplete
718 +            (CompletableFuture<T> f,
719 +             BiConsumer<? super T,? super Throwable> a);
720          public abstract <T,U> CompletableFuture<Void> runAfterBoth
721              (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
722          public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
# Line 645 | Line 727 | public class CompletableFutureTest exten
727              (CompletableFuture<T> f,
728               CompletionStage<? extends U> g,
729               BiFunction<? super T,? super U,? extends V> a);
648        public abstract <T,U> CompletableFuture<U> applyToEither
649            (CompletableFuture<T> f,
650             CompletionStage<? extends T> g,
651             Function<? super T,U> a);
652        public abstract <T> CompletableFuture<Void> acceptEither
653            (CompletableFuture<T> f,
654             CompletionStage<? extends T> g,
655             Consumer<? super T> a);
730          public abstract <T> CompletableFuture<Void> runAfterEither
731              (CompletableFuture<T> f,
732               CompletionStage<?> g,
733               java.lang.Runnable a);
734 <        public abstract <T,U> CompletableFuture<U> thenCompose
734 >        public abstract <T> CompletableFuture<Void> acceptEither
735              (CompletableFuture<T> f,
736 <             Function<? super T,? extends CompletionStage<U>> a);
737 <        public abstract <T> CompletableFuture<T> whenComplete
736 >             CompletionStage<? extends T> g,
737 >             Consumer<? super T> a);
738 >        public abstract <T,U> CompletableFuture<U> applyToEither
739              (CompletableFuture<T> f,
740 <             BiConsumer<? super T,? super Throwable> a);
740 >             CompletionStage<? extends T> g,
741 >             Function<? super T,U> a);
742 >    }
743 >
744 >    /**
745 >     * exceptionally action is not invoked when source completes
746 >     * normally, and source result is propagated
747 >     */
748 >    public void testExceptionally_normalCompletion() {
749 >        for (boolean createIncomplete : new boolean[] { true, false })
750 >        for (Integer v1 : new Integer[] { 1, null })
751 >    {
752 >        final AtomicInteger a = new AtomicInteger(0);
753 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
754 >        if (!createIncomplete) f.complete(v1);
755 >        final CompletableFuture<Integer> g = f.exceptionally
756 >            ((Throwable t) -> {
757 >                // Should not be called
758 >                a.getAndIncrement();
759 >                throw new AssertionError();
760 >            });
761 >        if (createIncomplete) f.complete(v1);
762  
763 +        checkCompletedNormally(g, v1);
764 +        checkCompletedNormally(f, v1);
765 +        assertEquals(0, a.get());
766 +    }}
767  
668    }
768  
769      /**
770       * exceptionally action completes with function value on source
771 <     * exception; otherwise with source value
771 >     * exception
772       */
773 <    public void testExceptionally() {
774 <        CompletableFuture<Integer> f = new CompletableFuture<>();
775 <        ExceptionToInteger r = new ExceptionToInteger();
776 <        CompletableFuture<Integer> g = f.exceptionally(r);
777 <        f.completeExceptionally(new CFException());
778 <        checkCompletedNormally(g, three);
773 >    public void testExceptionally_exceptionalCompletion() {
774 >        for (boolean createIncomplete : new boolean[] { true, false })
775 >        for (Integer v1 : new Integer[] { 1, null })
776 >    {
777 >        final AtomicInteger a = new AtomicInteger(0);
778 >        final CFException ex = new CFException();
779 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
780 >        if (!createIncomplete) f.completeExceptionally(ex);
781 >        final CompletableFuture<Integer> g = f.exceptionally
782 >            ((Throwable t) -> {
783 >                threadAssertSame(t, ex);
784 >                a.getAndIncrement();
785 >                return v1;
786 >            });
787 >        if (createIncomplete) f.completeExceptionally(ex);
788  
789 <        f = new CompletableFuture<>();
790 <        r = new ExceptionToInteger();
791 <        g = f.exceptionally(r);
792 <        f.complete(one);
793 <        checkCompletedNormally(g, one);
794 <    }
789 >        checkCompletedNormally(g, v1);
790 >        assertEquals(1, a.get());
791 >    }}
792 >
793 >    public void testExceptionally_exceptionalCompletionActionFailed() {
794 >        for (boolean createIncomplete : new boolean[] { true, false })
795 >        for (Integer v1 : new Integer[] { 1, null })
796 >    {
797 >        final AtomicInteger a = new AtomicInteger(0);
798 >        final CFException ex1 = new CFException();
799 >        final CFException ex2 = new CFException();
800 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
801 >        if (!createIncomplete) f.completeExceptionally(ex1);
802 >        final CompletableFuture<Integer> g = f.exceptionally
803 >            ((Throwable t) -> {
804 >                threadAssertSame(t, ex1);
805 >                a.getAndIncrement();
806 >                throw ex2;
807 >            });
808 >        if (createIncomplete) f.completeExceptionally(ex1);
809 >
810 >        checkCompletedWithWrappedCFException(g, ex2);
811 >        assertEquals(1, a.get());
812 >    }}
813  
814      /**
815 <     * handle action completes normally with function value on either
816 <     * normal or exceptional completion of source
815 >     * handle action completes normally with function value on normal
816 >     * completion of source
817       */
818 <    public void testHandle() {
819 <        CompletableFuture<Integer> f, g;
820 <        IntegerHandler r;
818 >    public void testHandle_normalCompletion() {
819 >        for (ExecutionMode m : ExecutionMode.values())
820 >        for (boolean createIncomplete : new boolean[] { true, false })
821 >        for (Integer v1 : new Integer[] { 1, null })
822 >    {
823 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
824 >        final AtomicInteger a = new AtomicInteger(0);
825 >        if (!createIncomplete) f.complete(v1);
826 >        final CompletableFuture<Integer> g = m.handle
827 >            (f,
828 >             (Integer x, Throwable t) -> {
829 >                threadAssertSame(x, v1);
830 >                threadAssertNull(t);
831 >                a.getAndIncrement();
832 >                return inc(v1);
833 >            });
834 >        if (createIncomplete) f.complete(v1);
835  
836 <        f = new CompletableFuture<>();
837 <        f.completeExceptionally(new CFException());
838 <        g = f.handle(r = new IntegerHandler());
839 <        assertEquals(1, r.invocationCount);
700 <        assertEquals(1, r.invocationCount);
701 <        checkCompletedNormally(g, three);
836 >        checkCompletedNormally(g, inc(v1));
837 >        checkCompletedNormally(f, v1);
838 >        assertEquals(1, a.get());
839 >    }}
840  
841 <        f = new CompletableFuture<>();
842 <        g = f.handle(r = new IntegerHandler());
843 <        assertEquals(0, r.invocationCount);
844 <        f.completeExceptionally(new CFException());
845 <        checkCompletedNormally(g, three);
846 <        assertEquals(1, r.invocationCount);
841 >    /**
842 >     * handle action completes normally with function value on
843 >     * exceptional completion of source
844 >     */
845 >    public void testHandle_exceptionalCompletion() {
846 >        for (ExecutionMode m : ExecutionMode.values())
847 >        for (boolean createIncomplete : new boolean[] { true, false })
848 >        for (Integer v1 : new Integer[] { 1, null })
849 >    {
850 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
851 >        final AtomicInteger a = new AtomicInteger(0);
852 >        final CFException ex = new CFException();
853 >        if (!createIncomplete) f.completeExceptionally(ex);
854 >        final CompletableFuture<Integer> g = m.handle
855 >            (f,
856 >             (Integer x, Throwable t) -> {
857 >                threadAssertNull(x);
858 >                threadAssertSame(t, ex);
859 >                a.getAndIncrement();
860 >                return v1;
861 >            });
862 >        if (createIncomplete) f.completeExceptionally(ex);
863  
864 <        f = new CompletableFuture<>();
865 <        f.complete(one);
866 <        g = f.handle(r = new IntegerHandler());
867 <        assertEquals(1, r.invocationCount);
714 <        checkCompletedNormally(g, two);
864 >        checkCompletedNormally(g, v1);
865 >        checkCompletedWithWrappedCFException(f, ex);
866 >        assertEquals(1, a.get());
867 >    }}
868  
869 <        f = new CompletableFuture<>();
870 <        g = f.handle(r = new IntegerHandler());
871 <        assertEquals(0, r.invocationCount);
872 <        f.complete(one);
873 <        assertEquals(1, r.invocationCount);
874 <        checkCompletedNormally(g, two);
875 <    }
869 >    /**
870 >     * handle action completes normally with function value on
871 >     * cancelled source
872 >     */
873 >    public void testHandle_sourceCancelled() {
874 >        for (ExecutionMode m : ExecutionMode.values())
875 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
876 >        for (boolean createIncomplete : new boolean[] { true, false })
877 >        for (Integer v1 : new Integer[] { 1, null })
878 >    {
879 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
880 >        final AtomicInteger a = new AtomicInteger(0);
881 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
882 >        final CompletableFuture<Integer> g = m.handle
883 >            (f,
884 >             (Integer x, Throwable t) -> {
885 >                threadAssertNull(x);
886 >                threadAssertTrue(t instanceof CancellationException);
887 >                a.getAndIncrement();
888 >                return v1;
889 >            });
890 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
891 >
892 >        checkCompletedNormally(g, v1);
893 >        checkCancelled(f);
894 >        assertEquals(1, a.get());
895 >    }}
896 >
897 >    /**
898 >     * handle result completes exceptionally if action does
899 >     */
900 >    public void testHandle_sourceFailedActionFailed() {
901 >        for (ExecutionMode m : ExecutionMode.values())
902 >        for (boolean createIncomplete : new boolean[] { true, false })
903 >    {
904 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
905 >        final AtomicInteger a = new AtomicInteger(0);
906 >        final CFException ex1 = new CFException();
907 >        final CFException ex2 = new CFException();
908 >        if (!createIncomplete) f.completeExceptionally(ex1);
909 >        final CompletableFuture<Integer> g = m.handle
910 >            (f,
911 >             (Integer x, Throwable t) -> {
912 >                threadAssertNull(x);
913 >                threadAssertSame(ex1, t);
914 >                a.getAndIncrement();
915 >                throw ex2;
916 >            });
917 >        if (createIncomplete) f.completeExceptionally(ex1);
918 >
919 >        checkCompletedWithWrappedCFException(g, ex2);
920 >        checkCompletedWithWrappedCFException(f, ex1);
921 >        assertEquals(1, a.get());
922 >    }}
923 >
924 >    public void testHandle_sourceCompletedNormallyActionFailed() {
925 >        for (ExecutionMode m : ExecutionMode.values())
926 >        for (boolean createIncomplete : new boolean[] { true, false })
927 >        for (Integer v1 : new Integer[] { 1, null })
928 >    {
929 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
930 >        final AtomicInteger a = new AtomicInteger(0);
931 >        final CFException ex = new CFException();
932 >        if (!createIncomplete) f.complete(v1);
933 >        final CompletableFuture<Integer> g = m.handle
934 >            (f,
935 >             (Integer x, Throwable t) -> {
936 >                threadAssertSame(x, v1);
937 >                threadAssertNull(t);
938 >                a.getAndIncrement();
939 >                throw ex;
940 >            });
941 >        if (createIncomplete) f.complete(v1);
942 >
943 >        checkCompletedWithWrappedCFException(g, ex);
944 >        checkCompletedNormally(f, v1);
945 >        assertEquals(1, a.get());
946 >    }}
947  
948      /**
949       * runAsync completes after running Runnable
950       */
951      public void testRunAsync() {
952 <        Noop r = new Noop();
952 >        Noop r = new Noop(ExecutionMode.ASYNC);
953          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
954          assertNull(f.join());
955          assertEquals(1, r.invocationCount);
# Line 736 | Line 960 | public class CompletableFutureTest exten
960       * runAsync with executor completes after running Runnable
961       */
962      public void testRunAsync2() {
963 <        Noop r = new Noop();
963 >        Noop r = new Noop(ExecutionMode.EXECUTOR);
964          ThreadExecutor exec = new ThreadExecutor();
965          CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
966          assertNull(f.join());
# Line 749 | Line 973 | public class CompletableFutureTest exten
973       * failing runAsync completes exceptionally after running Runnable
974       */
975      public void testRunAsync3() {
976 <        FailingNoop r = new FailingNoop();
976 >        FailingRunnable r = new FailingRunnable(ExecutionMode.ASYNC);
977          CompletableFuture<Void> f = CompletableFuture.runAsync(r);
978          checkCompletedWithWrappedCFException(f);
979          assertEquals(1, r.invocationCount);
# Line 779 | Line 1003 | public class CompletableFutureTest exten
1003       * Failing supplyAsync completes exceptionally
1004       */
1005      public void testSupplyAsync3() {
1006 <        FailingSupplier r = new FailingSupplier();
1006 >        FailingSupplier r = new FailingSupplier(ExecutionMode.ASYNC);
1007          CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1008          checkCompletedWithWrappedCFException(f);
1009          assertEquals(1, r.invocationCount);
# Line 790 | Line 1014 | public class CompletableFutureTest exten
1014      /**
1015       * thenRun result completes normally after normal completion of source
1016       */
1017 <    public void testThenRun() {
1018 <        CompletableFuture<Integer> f;
1019 <        CompletableFuture<Void> g;
1020 <        Noop r;
1021 <
1022 <        f = new CompletableFuture<>();
1023 <        g = f.thenRun(r = new Noop());
1024 <        f.complete(null);
1025 <        checkCompletedNormally(g, null);
1026 <        assertEquals(1, r.invocationCount);
1017 >    public void testThenRun_normalCompletion() {
1018 >        for (ExecutionMode m : ExecutionMode.values())
1019 >        for (boolean createIncomplete : new boolean[] { true, false })
1020 >        for (Integer v1 : new Integer[] { 1, null })
1021 >    {
1022 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1023 >        final Noop r = new Noop(m);
1024 >        if (!createIncomplete) f.complete(v1);
1025 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1026 >        if (createIncomplete) {
1027 >            checkIncomplete(g);
1028 >            f.complete(v1);
1029 >        }
1030  
804        f = new CompletableFuture<>();
805        f.complete(null);
806        g = f.thenRun(r = new Noop());
1031          checkCompletedNormally(g, null);
1032 +        checkCompletedNormally(f, v1);
1033          assertEquals(1, r.invocationCount);
1034 <    }
1034 >    }}
1035  
1036      /**
1037       * thenRun result completes exceptionally after exceptional
1038       * completion of source
1039       */
1040 <    public void testThenRun2() {
1041 <        CompletableFuture<Integer> f;
1042 <        CompletableFuture<Void> g;
1043 <        Noop r;
1044 <
1045 <        f = new CompletableFuture<>();
1046 <        g = f.thenRun(r = new Noop());
1047 <        f.completeExceptionally(new CFException());
1048 <        checkCompletedWithWrappedCFException(g);
1049 <        assertEquals(0, r.invocationCount);
1040 >    public void testThenRun_exceptionalCompletion() {
1041 >        for (ExecutionMode m : ExecutionMode.values())
1042 >        for (boolean createIncomplete : new boolean[] { true, false })
1043 >    {
1044 >        final CFException ex = new CFException();
1045 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1046 >        final Noop r = new Noop(m);
1047 >        if (!createIncomplete) f.completeExceptionally(ex);
1048 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1049 >        if (createIncomplete) {
1050 >            checkIncomplete(g);
1051 >            f.completeExceptionally(ex);
1052 >        }
1053  
1054 <        f = new CompletableFuture<>();
1055 <        f.completeExceptionally(new CFException());
828 <        g = f.thenRun(r = new Noop());
829 <        checkCompletedWithWrappedCFException(g);
1054 >        checkCompletedWithWrappedCFException(g, ex);
1055 >        checkCompletedWithWrappedCFException(f, ex);
1056          assertEquals(0, r.invocationCount);
1057 <    }
1057 >    }}
1058  
1059      /**
1060 <     * thenRun result completes exceptionally if action does
1060 >     * thenRun result completes exceptionally if source cancelled
1061       */
1062 <    public void testThenRun3() {
1063 <        CompletableFuture<Integer> f;
1064 <        CompletableFuture<Void> g;
1065 <        FailingNoop r;
1066 <
1067 <        f = new CompletableFuture<>();
1068 <        g = f.thenRun(r = new FailingNoop());
1069 <        f.complete(null);
1070 <        checkCompletedWithWrappedCFException(g);
1062 >    public void testThenRun_sourceCancelled() {
1063 >        for (ExecutionMode m : ExecutionMode.values())
1064 >        for (boolean createIncomplete : new boolean[] { true, false })
1065 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1066 >    {
1067 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1068 >        final Noop r = new Noop(m);
1069 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1070 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1071 >        if (createIncomplete) {
1072 >            checkIncomplete(g);
1073 >            assertTrue(f.cancel(mayInterruptIfRunning));
1074 >        }
1075  
1076 <        f = new CompletableFuture<>();
1077 <        f.complete(null);
1078 <        g = f.thenRun(r = new FailingNoop());
1079 <        checkCompletedWithWrappedCFException(g);
850 <    }
1076 >        checkCompletedWithWrappedCancellationException(g);
1077 >        checkCancelled(f);
1078 >        assertEquals(0, r.invocationCount);
1079 >    }}
1080  
1081      /**
1082 <     * thenRun result completes exceptionally if source cancelled
1082 >     * thenRun result completes exceptionally if action does
1083       */
1084 <    public void testThenRun4() {
1085 <        CompletableFuture<Integer> f;
1086 <        CompletableFuture<Void> g;
1087 <        Noop r;
1088 <
1089 <        f = new CompletableFuture<>();
1090 <        g = f.thenRun(r = new Noop());
1091 <        assertTrue(f.cancel(true));
1092 <        checkCompletedWithWrappedCancellationException(g);
1084 >    public void testThenRun_actionFailed() {
1085 >        for (ExecutionMode m : ExecutionMode.values())
1086 >        for (boolean createIncomplete : new boolean[] { true, false })
1087 >        for (Integer v1 : new Integer[] { 1, null })
1088 >    {
1089 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1090 >        final FailingRunnable r = new FailingRunnable(m);
1091 >        if (!createIncomplete) f.complete(v1);
1092 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1093 >        if (createIncomplete) {
1094 >            checkIncomplete(g);
1095 >            f.complete(v1);
1096 >        }
1097  
1098 <        f = new CompletableFuture<>();
1099 <        assertTrue(f.cancel(true));
1100 <        g = f.thenRun(r = new Noop());
868 <        checkCompletedWithWrappedCancellationException(g);
869 <    }
1098 >        checkCompletedWithWrappedCFException(g);
1099 >        checkCompletedNormally(f, v1);
1100 >    }}
1101  
1102      /**
1103       * thenApply result completes normally after normal completion of source
1104       */
1105 <    public void testThenApply() {
1106 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1107 <        CompletableFuture<Integer> g = f.thenApply(inc);
1108 <        f.complete(one);
1109 <        checkCompletedNormally(g, two);
1110 <    }
1105 >    public void testThenApply_normalCompletion() {
1106 >        for (ExecutionMode m : ExecutionMode.values())
1107 >        for (boolean createIncomplete : new boolean[] { true, false })
1108 >        for (Integer v1 : new Integer[] { 1, null })
1109 >    {
1110 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1111 >        final IncFunction r = new IncFunction(m);
1112 >        if (!createIncomplete) f.complete(v1);
1113 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1114 >        if (createIncomplete) {
1115 >            checkIncomplete(g);
1116 >            f.complete(v1);
1117 >        }
1118 >
1119 >        checkCompletedNormally(g, inc(v1));
1120 >        checkCompletedNormally(f, v1);
1121 >        assertEquals(1, r.invocationCount);
1122 >    }}
1123  
1124      /**
1125       * thenApply result completes exceptionally after exceptional
1126       * completion of source
1127       */
1128 <    public void testThenApply2() {
1129 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1130 <        CompletableFuture<Integer> g = f.thenApply(inc);
1131 <        f.completeExceptionally(new CFException());
1132 <        checkCompletedWithWrappedCFException(g);
1133 <    }
1128 >    public void testThenApply_exceptionalCompletion() {
1129 >        for (ExecutionMode m : ExecutionMode.values())
1130 >        for (boolean createIncomplete : new boolean[] { true, false })
1131 >    {
1132 >        final CFException ex = new CFException();
1133 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1134 >        final IncFunction r = new IncFunction(m);
1135 >        if (!createIncomplete) f.completeExceptionally(ex);
1136 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1137 >        if (createIncomplete) {
1138 >            checkIncomplete(g);
1139 >            f.completeExceptionally(ex);
1140 >        }
1141  
1142 <    /**
1143 <     * thenApply result completes exceptionally if action does
1144 <     */
1145 <    public void testThenApply3() {
896 <        CompletableFuture<Integer> f = new CompletableFuture<>();
897 <        CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
898 <        f.complete(one);
899 <        checkCompletedWithWrappedCFException(g);
900 <    }
1142 >        checkCompletedWithWrappedCFException(g, ex);
1143 >        checkCompletedWithWrappedCFException(f, ex);
1144 >        assertEquals(0, r.invocationCount);
1145 >    }}
1146  
1147      /**
1148       * thenApply result completes exceptionally if source cancelled
1149       */
1150 <    public void testThenApply4() {
1151 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1152 <        CompletableFuture<Integer> g = f.thenApply(inc);
1153 <        assertTrue(f.cancel(true));
1150 >    public void testThenApply_sourceCancelled() {
1151 >        for (ExecutionMode m : ExecutionMode.values())
1152 >        for (boolean createIncomplete : new boolean[] { true, false })
1153 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1154 >    {
1155 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1156 >        final IncFunction r = new IncFunction(m);
1157 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1158 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1159 >        if (createIncomplete) {
1160 >            checkIncomplete(g);
1161 >            assertTrue(f.cancel(mayInterruptIfRunning));
1162 >        }
1163 >
1164          checkCompletedWithWrappedCancellationException(g);
1165 <    }
1165 >        checkCancelled(f);
1166 >        assertEquals(0, r.invocationCount);
1167 >    }}
1168 >
1169 >    /**
1170 >     * thenApply result completes exceptionally if action does
1171 >     */
1172 >    public void testThenApply_actionFailed() {
1173 >        for (ExecutionMode m : ExecutionMode.values())
1174 >        for (boolean createIncomplete : new boolean[] { true, false })
1175 >        for (Integer v1 : new Integer[] { 1, null })
1176 >    {
1177 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1178 >        final FailingFunction r = new FailingFunction(m);
1179 >        if (!createIncomplete) f.complete(v1);
1180 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1181 >        if (createIncomplete) {
1182 >            checkIncomplete(g);
1183 >            f.complete(v1);
1184 >        }
1185 >
1186 >        checkCompletedWithWrappedCFException(g);
1187 >        checkCompletedNormally(f, v1);
1188 >    }}
1189  
1190      /**
1191       * thenAccept result completes normally after normal completion of source
1192       */
1193 <    public void testThenAccept() {
1194 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1195 <        IncAction r = new IncAction();
1196 <        CompletableFuture<Void> g = f.thenAccept(r);
1197 <        f.complete(one);
1193 >    public void testThenAccept_normalCompletion() {
1194 >        for (ExecutionMode m : ExecutionMode.values())
1195 >        for (boolean createIncomplete : new boolean[] { true, false })
1196 >        for (Integer v1 : new Integer[] { 1, null })
1197 >    {
1198 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1199 >        final IncAction r = new IncAction();
1200 >        if (!createIncomplete) f.complete(v1);
1201 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1202 >        if (createIncomplete) {
1203 >            checkIncomplete(g);
1204 >            f.complete(v1);
1205 >        }
1206 >
1207          checkCompletedNormally(g, null);
1208 <        assertEquals(r.value, (Integer) 2);
1209 <    }
1208 >        checkCompletedNormally(f, v1);
1209 >        assertEquals(1, r.invocationCount);
1210 >        assertEquals(inc(v1), r.value);
1211 >    }}
1212  
1213      /**
1214       * thenAccept result completes exceptionally after exceptional
1215       * completion of source
1216       */
1217 <    public void testThenAccept2() {
1218 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1219 <        IncAction r = new IncAction();
1220 <        CompletableFuture<Void> g = f.thenAccept(r);
1221 <        f.completeExceptionally(new CFException());
1222 <        checkCompletedWithWrappedCFException(g);
1223 <    }
1217 >    public void testThenAccept_exceptionalCompletion() {
1218 >        for (ExecutionMode m : ExecutionMode.values())
1219 >        for (boolean createIncomplete : new boolean[] { true, false })
1220 >    {
1221 >        final CFException ex = new CFException();
1222 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1223 >        final IncAction r = new IncAction();
1224 >        if (!createIncomplete) f.completeExceptionally(ex);
1225 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1226 >        if (createIncomplete) {
1227 >            checkIncomplete(g);
1228 >            f.completeExceptionally(ex);
1229 >        }
1230 >
1231 >        checkCompletedWithWrappedCFException(g, ex);
1232 >        checkCompletedWithWrappedCFException(f, ex);
1233 >        assertEquals(0, r.invocationCount);
1234 >    }}
1235  
1236      /**
1237       * thenAccept result completes exceptionally if action does
1238       */
1239 <    public void testThenAccept3() {
1240 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1241 <        FailingConsumer r = new FailingConsumer();
1242 <        CompletableFuture<Void> g = f.thenAccept(r);
1243 <        f.complete(one);
1239 >    public void testThenAccept_actionFailed() {
1240 >        for (ExecutionMode m : ExecutionMode.values())
1241 >        for (boolean createIncomplete : new boolean[] { true, false })
1242 >        for (Integer v1 : new Integer[] { 1, null })
1243 >    {
1244 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1245 >        final FailingConsumer r = new FailingConsumer(m);
1246 >        if (!createIncomplete) f.complete(v1);
1247 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1248 >        if (createIncomplete) {
1249 >            checkIncomplete(g);
1250 >            f.complete(v1);
1251 >        }
1252 >
1253          checkCompletedWithWrappedCFException(g);
1254 <        assertEquals(1, r.invocationCount);
1255 <    }
1254 >        checkCompletedNormally(f, v1);
1255 >    }}
1256  
1257      /**
1258       * thenAccept result completes exceptionally if source cancelled
1259       */
1260 <    public void testThenAccept4() {
1261 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1262 <        IncAction r = new IncAction();
1263 <        CompletableFuture<Void> g = f.thenAccept(r);
1264 <        assertTrue(f.cancel(true));
1260 >    public void testThenAccept_sourceCancelled() {
1261 >        for (ExecutionMode m : ExecutionMode.values())
1262 >        for (boolean createIncomplete : new boolean[] { true, false })
1263 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1264 >    {
1265 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1266 >        final IncAction r = new IncAction();
1267 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1268 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1269 >        if (createIncomplete) {
1270 >            checkIncomplete(g);
1271 >            assertTrue(f.cancel(mayInterruptIfRunning));
1272 >        }
1273 >
1274          checkCompletedWithWrappedCancellationException(g);
1275 <    }
1275 >        checkCancelled(f);
1276 >        assertEquals(0, r.invocationCount);
1277 >    }}
1278  
1279      /**
1280       * thenCombine result completes normally after normal completion
1281       * of sources
1282       */
1283 <    public void testThenCombine_normalCompletion1() {
1283 >    public void testThenCombine_normalCompletion() {
1284 >        for (ExecutionMode m : ExecutionMode.values())
1285          for (boolean createIncomplete : new boolean[] { true, false })
1286          for (boolean fFirst : new boolean[] { true, false })
966        for (ExecutionMode m : ExecutionMode.values())
1287          for (Integer v1 : new Integer[] { 1, null })
1288 <        for (Integer v2 : new Integer[] { 2, null }) {
1289 <
1288 >        for (Integer v2 : new Integer[] { 2, null })
1289 >    {
1290          final CompletableFuture<Integer> f = new CompletableFuture<>();
1291          final CompletableFuture<Integer> g = new CompletableFuture<>();
1292 <        final SubtractFunction r = new SubtractFunction();
973 <        CompletableFuture<Integer> h = null;
974 <        if (createIncomplete) h = m.thenCombine(f, g, r);
1292 >        final SubtractFunction r = new SubtractFunction(m);
1293  
1294 <        if (fFirst)
1295 <            f.complete(v1);
1296 <        else
1297 <            g.complete(v2);
1298 <        if (createIncomplete) checkIncomplete(h);
1299 <        assertEquals(0, r.invocationCount);
1300 <        if (!fFirst)
1301 <            f.complete(v1);
1302 <        else
985 <            g.complete(v2);
986 <        if (!createIncomplete) h = m.thenCombine(f, g, r);
1294 >        if (fFirst) f.complete(v1); else g.complete(v2);
1295 >        if (!createIncomplete)
1296 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1297 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1298 >        if (createIncomplete) {
1299 >            checkIncomplete(h);
1300 >            assertEquals(0, r.invocationCount);
1301 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1302 >        }
1303  
1304          checkCompletedNormally(h, subtract(v1, v2));
1305          checkCompletedNormally(f, v1);
1306          checkCompletedNormally(g, v2);
1307          assertEquals(1, r.invocationCount);
1308 <        }
993 <    }
1308 >    }}
1309  
1310      /**
1311       * thenCombine result completes exceptionally after exceptional
1312       * completion of either source
1313       */
1314 <    public void testThenCombine_exceptionalCompletion1() {
1000 <        for (ExecutionMode m : ExecutionMode.values())
1001 <        for (Integer v1 : new Integer[] { 1, null }) {
1002 <
1003 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1004 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1005 <        final SubtractFunction r = new SubtractFunction();
1006 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1007 <        final CFException ex = new CFException();
1008 <
1009 <        f.completeExceptionally(ex);
1010 <        checkIncomplete(h);
1011 <        g.complete(v1);
1012 <
1013 <        checkCompletedWithWrappedCFException(h, ex);
1014 <        checkCompletedWithWrappedCFException(f, ex);
1015 <        assertEquals(0, r.invocationCount);
1016 <        checkCompletedNormally(g, v1);
1017 <        }
1018 <    }
1019 <
1020 <    public void testThenCombine_exceptionalCompletion2() {
1314 >    public void testThenCombine_exceptionalCompletion() {
1315          for (ExecutionMode m : ExecutionMode.values())
1316 <        for (Integer v1 : new Integer[] { 1, null }) {
1317 <
1318 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1319 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1026 <        final SubtractFunction r = new SubtractFunction();
1027 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1028 <        final CFException ex = new CFException();
1029 <
1030 <        g.completeExceptionally(ex);
1031 <        checkIncomplete(h);
1032 <        f.complete(v1);
1033 <
1034 <        checkCompletedWithWrappedCFException(h, ex);
1035 <        checkCompletedWithWrappedCFException(g, ex);
1036 <        assertEquals(0, r.invocationCount);
1037 <        checkCompletedNormally(f, v1);
1038 <        }
1039 <    }
1040 <
1041 <    public void testThenCombine_exceptionalCompletion3() {
1042 <        for (ExecutionMode m : ExecutionMode.values())
1043 <        for (Integer v1 : new Integer[] { 1, null }) {
1044 <
1316 >        for (boolean createIncomplete : new boolean[] { true, false })
1317 >        for (boolean fFirst : new boolean[] { true, false })
1318 >        for (Integer v1 : new Integer[] { 1, null })
1319 >    {
1320          final CompletableFuture<Integer> f = new CompletableFuture<>();
1321          final CompletableFuture<Integer> g = new CompletableFuture<>();
1047        final SubtractFunction r = new SubtractFunction();
1322          final CFException ex = new CFException();
1323 +        final SubtractFunction r = new SubtractFunction(m);
1324  
1325 <        g.completeExceptionally(ex);
1326 <        f.complete(v1);
1325 >        (fFirst ? f : g).complete(v1);
1326 >        if (!createIncomplete)
1327 >            (!fFirst ? f : g).completeExceptionally(ex);
1328          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1329 <
1330 <        checkCompletedWithWrappedCFException(h, ex);
1331 <        checkCompletedWithWrappedCFException(g, ex);
1056 <        assertEquals(0, r.invocationCount);
1057 <        checkCompletedNormally(f, v1);
1329 >        if (createIncomplete) {
1330 >            checkIncomplete(h);
1331 >            (!fFirst ? f : g).completeExceptionally(ex);
1332          }
1059    }
1060
1061    public void testThenCombine_exceptionalCompletion4() {
1062        for (ExecutionMode m : ExecutionMode.values())
1063        for (Integer v1 : new Integer[] { 1, null }) {
1064
1065        final CompletableFuture<Integer> f = new CompletableFuture<>();
1066        final CompletableFuture<Integer> g = new CompletableFuture<>();
1067        final SubtractFunction r = new SubtractFunction();
1068        final CFException ex = new CFException();
1069
1070        f.completeExceptionally(ex);
1071        g.complete(v1);
1072        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1333  
1334          checkCompletedWithWrappedCFException(h, ex);
1075        checkCompletedWithWrappedCFException(f, ex);
1335          assertEquals(0, r.invocationCount);
1336 <        checkCompletedNormally(g, v1);
1337 <        }
1338 <    }
1336 >        checkCompletedNormally(fFirst ? f : g, v1);
1337 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1338 >    }}
1339  
1340      /**
1341       * thenCombine result completes exceptionally if action does
1342       */
1343 <    public void testThenCombine_actionFailed1() {
1343 >    public void testThenCombine_actionFailed() {
1344          for (ExecutionMode m : ExecutionMode.values())
1345 +        for (boolean fFirst : new boolean[] { true, false })
1346          for (Integer v1 : new Integer[] { 1, null })
1347 <        for (Integer v2 : new Integer[] { 2, null }) {
1348 <
1347 >        for (Integer v2 : new Integer[] { 2, null })
1348 >    {
1349          final CompletableFuture<Integer> f = new CompletableFuture<>();
1350          final CompletableFuture<Integer> g = new CompletableFuture<>();
1351 <        final FailingBiFunction r = new FailingBiFunction();
1351 >        final FailingBiFunction r = new FailingBiFunction(m);
1352          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1353  
1354 <        f.complete(v1);
1355 <        checkIncomplete(h);
1356 <        g.complete(v2);
1357 <
1358 <        checkCompletedWithWrappedCFException(h);
1359 <        checkCompletedNormally(f, v1);
1100 <        checkCompletedNormally(g, v2);
1354 >        if (fFirst) {
1355 >            f.complete(v1);
1356 >            g.complete(v2);
1357 >        } else {
1358 >            g.complete(v2);
1359 >            f.complete(v1);
1360          }
1102    }
1103
1104    public void testThenCombine_actionFailed2() {
1105        for (ExecutionMode m : ExecutionMode.values())
1106        for (Integer v1 : new Integer[] { 1, null })
1107        for (Integer v2 : new Integer[] { 2, null }) {
1108
1109        final CompletableFuture<Integer> f = new CompletableFuture<>();
1110        final CompletableFuture<Integer> g = new CompletableFuture<>();
1111        final FailingBiFunction r = new FailingBiFunction();
1112        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1113
1114        g.complete(v2);
1115        checkIncomplete(h);
1116        f.complete(v1);
1361  
1362          checkCompletedWithWrappedCFException(h);
1363          checkCompletedNormally(f, v1);
1364          checkCompletedNormally(g, v2);
1365 <        }
1122 <    }
1365 >    }}
1366  
1367      /**
1368       * thenCombine result completes exceptionally if either source cancelled
1369       */
1370 <    public void testThenCombine_sourceCancelled1() {
1370 >    public void testThenCombine_sourceCancelled() {
1371          for (ExecutionMode m : ExecutionMode.values())
1372          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1373 <        for (Integer v1 : new Integer[] { 1, null }) {
1374 <
1375 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1376 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1134 <        final SubtractFunction r = new SubtractFunction();
1135 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1136 <
1137 <        assertTrue(f.cancel(mayInterruptIfRunning));
1138 <        checkIncomplete(h);
1139 <        g.complete(v1);
1140 <
1141 <        checkCompletedWithWrappedCancellationException(h);
1142 <        checkCancelled(f);
1143 <        assertEquals(0, r.invocationCount);
1144 <        checkCompletedNormally(g, v1);
1145 <        }
1146 <    }
1147 <
1148 <    public void testThenCombine_sourceCancelled2() {
1149 <        for (ExecutionMode m : ExecutionMode.values())
1150 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1151 <        for (Integer v1 : new Integer[] { 1, null }) {
1152 <
1153 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1154 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1155 <        final SubtractFunction r = new SubtractFunction();
1156 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1157 <
1158 <        assertTrue(g.cancel(mayInterruptIfRunning));
1159 <        checkIncomplete(h);
1160 <        f.complete(v1);
1161 <
1162 <        checkCompletedWithWrappedCancellationException(h);
1163 <        checkCancelled(g);
1164 <        assertEquals(0, r.invocationCount);
1165 <        checkCompletedNormally(f, v1);
1166 <        }
1167 <    }
1168 <
1169 <    public void testThenCombine_sourceCancelled3() {
1170 <        for (ExecutionMode m : ExecutionMode.values())
1171 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1172 <        for (Integer v1 : new Integer[] { 1, null }) {
1173 <
1373 >        for (boolean createIncomplete : new boolean[] { true, false })
1374 >        for (boolean fFirst : new boolean[] { true, false })
1375 >        for (Integer v1 : new Integer[] { 1, null })
1376 >    {
1377          final CompletableFuture<Integer> f = new CompletableFuture<>();
1378          final CompletableFuture<Integer> g = new CompletableFuture<>();
1379 <        final SubtractFunction r = new SubtractFunction();
1379 >        final SubtractFunction r = new SubtractFunction(m);
1380  
1381 <        assertTrue(g.cancel(mayInterruptIfRunning));
1382 <        f.complete(v1);
1381 >        (fFirst ? f : g).complete(v1);
1382 >        if (!createIncomplete)
1383 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1384          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1385 <
1386 <        checkCompletedWithWrappedCancellationException(h);
1387 <        checkCancelled(g);
1184 <        assertEquals(0, r.invocationCount);
1185 <        checkCompletedNormally(f, v1);
1385 >        if (createIncomplete) {
1386 >            checkIncomplete(h);
1387 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1388          }
1187    }
1188
1189    public void testThenCombine_sourceCancelled4() {
1190        for (ExecutionMode m : ExecutionMode.values())
1191        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1192        for (Integer v1 : new Integer[] { 1, null }) {
1193
1194        final CompletableFuture<Integer> f = new CompletableFuture<>();
1195        final CompletableFuture<Integer> g = new CompletableFuture<>();
1196        final SubtractFunction r = new SubtractFunction();
1197
1198        assertTrue(f.cancel(mayInterruptIfRunning));
1199        g.complete(v1);
1200        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1389  
1390          checkCompletedWithWrappedCancellationException(h);
1391 <        checkCancelled(f);
1391 >        checkCancelled(!fFirst ? f : g);
1392          assertEquals(0, r.invocationCount);
1393 <        checkCompletedNormally(g, v1);
1394 <        }
1207 <    }
1393 >        checkCompletedNormally(fFirst ? f : g, v1);
1394 >    }}
1395  
1396      /**
1397       * thenAcceptBoth result completes normally after normal
1398       * completion of sources
1399       */
1400 <    public void testThenAcceptBoth_normalCompletion1() {
1214 <        for (ExecutionMode m : ExecutionMode.values())
1215 <        for (Integer v1 : new Integer[] { 1, null })
1216 <        for (Integer v2 : new Integer[] { 2, null }) {
1217 <
1218 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1219 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1220 <        final SubtractAction r = new SubtractAction();
1221 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1222 <
1223 <        f.complete(v1);
1224 <        checkIncomplete(h);
1225 <        assertEquals(0, r.invocationCount);
1226 <        g.complete(v2);
1227 <
1228 <        checkCompletedNormally(h, null);
1229 <        assertEquals(r.value, subtract(v1, v2));
1230 <        checkCompletedNormally(f, v1);
1231 <        checkCompletedNormally(g, v2);
1232 <        }
1233 <    }
1234 <
1235 <    public void testThenAcceptBoth_normalCompletion2() {
1236 <        for (ExecutionMode m : ExecutionMode.values())
1237 <        for (Integer v1 : new Integer[] { 1, null })
1238 <        for (Integer v2 : new Integer[] { 2, null }) {
1239 <
1240 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1241 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1242 <        final SubtractAction r = new SubtractAction();
1243 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1244 <
1245 <        g.complete(v2);
1246 <        checkIncomplete(h);
1247 <        assertEquals(0, r.invocationCount);
1248 <        f.complete(v1);
1249 <
1250 <        checkCompletedNormally(h, null);
1251 <        assertEquals(r.value, subtract(v1, v2));
1252 <        checkCompletedNormally(f, v1);
1253 <        checkCompletedNormally(g, v2);
1254 <        }
1255 <    }
1256 <
1257 <    public void testThenAcceptBoth_normalCompletion3() {
1400 >    public void testThenAcceptBoth_normalCompletion() {
1401          for (ExecutionMode m : ExecutionMode.values())
1402 +        for (boolean createIncomplete : new boolean[] { true, false })
1403 +        for (boolean fFirst : new boolean[] { true, false })
1404          for (Integer v1 : new Integer[] { 1, null })
1405 <        for (Integer v2 : new Integer[] { 2, null }) {
1406 <
1405 >        for (Integer v2 : new Integer[] { 2, null })
1406 >    {
1407          final CompletableFuture<Integer> f = new CompletableFuture<>();
1408          final CompletableFuture<Integer> g = new CompletableFuture<>();
1409 <        final SubtractAction r = new SubtractAction();
1409 >        final SubtractAction r = new SubtractAction(m);
1410  
1411 <        g.complete(v2);
1412 <        f.complete(v1);
1411 >        if (fFirst) f.complete(v1); else g.complete(v2);
1412 >        if (!createIncomplete)
1413 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1414          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1415 <
1416 <        checkCompletedNormally(h, null);
1417 <        assertEquals(r.value, subtract(v1, v2));
1418 <        checkCompletedNormally(f, v1);
1273 <        checkCompletedNormally(g, v2);
1415 >        if (createIncomplete) {
1416 >            checkIncomplete(h);
1417 >            assertEquals(0, r.invocationCount);
1418 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1419          }
1275    }
1276
1277    public void testThenAcceptBoth_normalCompletion4() {
1278        for (ExecutionMode m : ExecutionMode.values())
1279        for (Integer v1 : new Integer[] { 1, null })
1280        for (Integer v2 : new Integer[] { 2, null }) {
1281
1282        final CompletableFuture<Integer> f = new CompletableFuture<>();
1283        final CompletableFuture<Integer> g = new CompletableFuture<>();
1284        final SubtractAction r = new SubtractAction();
1285
1286        f.complete(v1);
1287        g.complete(v2);
1288        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1420  
1421          checkCompletedNormally(h, null);
1422 <        assertEquals(r.value, subtract(v1, v2));
1422 >        assertEquals(subtract(v1, v2), r.value);
1423          checkCompletedNormally(f, v1);
1424          checkCompletedNormally(g, v2);
1425 <        }
1295 <    }
1425 >    }}
1426  
1427      /**
1428       * thenAcceptBoth result completes exceptionally after exceptional
1429       * completion of either source
1430       */
1431 <    public void testThenAcceptBoth_exceptionalCompletion1() {
1431 >    public void testThenAcceptBoth_exceptionalCompletion() {
1432          for (ExecutionMode m : ExecutionMode.values())
1433 <        for (Integer v1 : new Integer[] { 1, null }) {
1434 <
1433 >        for (boolean createIncomplete : new boolean[] { true, false })
1434 >        for (boolean fFirst : new boolean[] { true, false })
1435 >        for (Integer v1 : new Integer[] { 1, null })
1436 >    {
1437          final CompletableFuture<Integer> f = new CompletableFuture<>();
1438          final CompletableFuture<Integer> g = new CompletableFuture<>();
1307        final SubtractAction r = new SubtractAction();
1308        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1439          final CFException ex = new CFException();
1440 +        final SubtractAction r = new SubtractAction(m);
1441  
1442 <        f.completeExceptionally(ex);
1443 <        checkIncomplete(h);
1444 <        g.complete(v1);
1314 <
1315 <        checkCompletedWithWrappedCFException(h, ex);
1316 <        checkCompletedWithWrappedCFException(f, ex);
1317 <        assertEquals(0, r.invocationCount);
1318 <        checkCompletedNormally(g, v1);
1319 <        }
1320 <    }
1321 <
1322 <    public void testThenAcceptBoth_exceptionalCompletion2() {
1323 <        for (ExecutionMode m : ExecutionMode.values())
1324 <        for (Integer v1 : new Integer[] { 1, null }) {
1325 <
1326 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1327 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1328 <        final SubtractAction r = new SubtractAction();
1442 >        (fFirst ? f : g).complete(v1);
1443 >        if (!createIncomplete)
1444 >            (!fFirst ? f : g).completeExceptionally(ex);
1445          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1446 <        final CFException ex = new CFException();
1447 <
1448 <        g.completeExceptionally(ex);
1333 <        checkIncomplete(h);
1334 <        f.complete(v1);
1335 <
1336 <        checkCompletedWithWrappedCFException(h, ex);
1337 <        checkCompletedWithWrappedCFException(g, ex);
1338 <        assertEquals(0, r.invocationCount);
1339 <        checkCompletedNormally(f, v1);
1446 >        if (createIncomplete) {
1447 >            checkIncomplete(h);
1448 >            (!fFirst ? f : g).completeExceptionally(ex);
1449          }
1341    }
1342
1343    public void testThenAcceptBoth_exceptionalCompletion3() {
1344        for (ExecutionMode m : ExecutionMode.values())
1345        for (Integer v1 : new Integer[] { 1, null }) {
1346
1347        final CompletableFuture<Integer> f = new CompletableFuture<>();
1348        final CompletableFuture<Integer> g = new CompletableFuture<>();
1349        final SubtractAction r = new SubtractAction();
1350        final CFException ex = new CFException();
1351
1352        g.completeExceptionally(ex);
1353        f.complete(v1);
1354        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1450  
1451          checkCompletedWithWrappedCFException(h, ex);
1357        checkCompletedWithWrappedCFException(g, ex);
1452          assertEquals(0, r.invocationCount);
1453 <        checkCompletedNormally(f, v1);
1454 <        }
1455 <    }
1362 <
1363 <    public void testThenAcceptBoth_exceptionalCompletion4() {
1364 <        for (ExecutionMode m : ExecutionMode.values())
1365 <        for (Integer v1 : new Integer[] { 1, null }) {
1366 <
1367 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1368 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1369 <        final SubtractAction r = new SubtractAction();
1370 <        final CFException ex = new CFException();
1371 <
1372 <        f.completeExceptionally(ex);
1373 <        g.complete(v1);
1374 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1375 <
1376 <        checkCompletedWithWrappedCFException(h, ex);
1377 <        checkCompletedWithWrappedCFException(f, ex);
1378 <        assertEquals(0, r.invocationCount);
1379 <        checkCompletedNormally(g, v1);
1380 <        }
1381 <    }
1453 >        checkCompletedNormally(fFirst ? f : g, v1);
1454 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1455 >    }}
1456  
1457      /**
1458       * thenAcceptBoth result completes exceptionally if action does
1459       */
1460 <    public void testThenAcceptBoth_actionFailed1() {
1460 >    public void testThenAcceptBoth_actionFailed() {
1461          for (ExecutionMode m : ExecutionMode.values())
1462 +        for (boolean fFirst : new boolean[] { true, false })
1463          for (Integer v1 : new Integer[] { 1, null })
1464 <        for (Integer v2 : new Integer[] { 2, null }) {
1465 <
1464 >        for (Integer v2 : new Integer[] { 2, null })
1465 >    {
1466          final CompletableFuture<Integer> f = new CompletableFuture<>();
1467          final CompletableFuture<Integer> g = new CompletableFuture<>();
1468 <        final FailingBiConsumer r = new FailingBiConsumer();
1468 >        final FailingBiConsumer r = new FailingBiConsumer(m);
1469          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1470  
1471 <        f.complete(v1);
1472 <        checkIncomplete(h);
1473 <        g.complete(v2);
1474 <
1475 <        checkCompletedWithWrappedCFException(h);
1476 <        checkCompletedNormally(f, v1);
1402 <        checkCompletedNormally(g, v2);
1471 >        if (fFirst) {
1472 >            f.complete(v1);
1473 >            g.complete(v2);
1474 >        } else {
1475 >            g.complete(v2);
1476 >            f.complete(v1);
1477          }
1404    }
1405
1406    public void testThenAcceptBoth_actionFailed2() {
1407        for (ExecutionMode m : ExecutionMode.values())
1408        for (Integer v1 : new Integer[] { 1, null })
1409        for (Integer v2 : new Integer[] { 2, null }) {
1410
1411        final CompletableFuture<Integer> f = new CompletableFuture<>();
1412        final CompletableFuture<Integer> g = new CompletableFuture<>();
1413        final FailingBiConsumer r = new FailingBiConsumer();
1414        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1415
1416        g.complete(v2);
1417        checkIncomplete(h);
1418        f.complete(v1);
1478  
1479          checkCompletedWithWrappedCFException(h);
1480          checkCompletedNormally(f, v1);
1481          checkCompletedNormally(g, v2);
1482 <        }
1424 <    }
1482 >    }}
1483  
1484      /**
1485       * thenAcceptBoth result completes exceptionally if either source cancelled
1486       */
1487 <    public void testThenAcceptBoth_sourceCancelled1() {
1430 <        for (ExecutionMode m : ExecutionMode.values())
1431 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1432 <        for (Integer v1 : new Integer[] { 1, null }) {
1433 <
1434 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1435 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1436 <        final SubtractAction r = new SubtractAction();
1437 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1438 <
1439 <        assertTrue(f.cancel(mayInterruptIfRunning));
1440 <        checkIncomplete(h);
1441 <        g.complete(v1);
1442 <
1443 <        checkCompletedWithWrappedCancellationException(h);
1444 <        checkCancelled(f);
1445 <        assertEquals(0, r.invocationCount);
1446 <        checkCompletedNormally(g, v1);
1447 <        }
1448 <    }
1449 <
1450 <    public void testThenAcceptBoth_sourceCancelled2() {
1451 <        for (ExecutionMode m : ExecutionMode.values())
1452 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1453 <        for (Integer v1 : new Integer[] { 1, null }) {
1454 <
1455 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1456 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1457 <        final SubtractAction r = new SubtractAction();
1458 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1459 <
1460 <        assertTrue(g.cancel(mayInterruptIfRunning));
1461 <        checkIncomplete(h);
1462 <        f.complete(v1);
1463 <
1464 <        checkCompletedWithWrappedCancellationException(h);
1465 <        checkCancelled(g);
1466 <        assertEquals(0, r.invocationCount);
1467 <        checkCompletedNormally(f, v1);
1468 <        }
1469 <    }
1470 <
1471 <    public void testThenAcceptBoth_sourceCancelled3() {
1487 >    public void testThenAcceptBoth_sourceCancelled() {
1488          for (ExecutionMode m : ExecutionMode.values())
1489          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1490 <        for (Integer v1 : new Integer[] { 1, null }) {
1491 <
1490 >        for (boolean createIncomplete : new boolean[] { true, false })
1491 >        for (boolean fFirst : new boolean[] { true, false })
1492 >        for (Integer v1 : new Integer[] { 1, null })
1493 >    {
1494          final CompletableFuture<Integer> f = new CompletableFuture<>();
1495          final CompletableFuture<Integer> g = new CompletableFuture<>();
1496 <        final SubtractAction r = new SubtractAction();
1496 >        final SubtractAction r = new SubtractAction(m);
1497  
1498 <        assertTrue(g.cancel(mayInterruptIfRunning));
1499 <        f.complete(v1);
1498 >        (fFirst ? f : g).complete(v1);
1499 >        if (!createIncomplete)
1500 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1501          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1502 <
1503 <        checkCompletedWithWrappedCancellationException(h);
1504 <        checkCancelled(g);
1486 <        assertEquals(0, r.invocationCount);
1487 <        checkCompletedNormally(f, v1);
1502 >        if (createIncomplete) {
1503 >            checkIncomplete(h);
1504 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1505          }
1489    }
1490
1491    public void testThenAcceptBoth_sourceCancelled4() {
1492        for (ExecutionMode m : ExecutionMode.values())
1493        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1494        for (Integer v1 : new Integer[] { 1, null }) {
1495
1496        final CompletableFuture<Integer> f = new CompletableFuture<>();
1497        final CompletableFuture<Integer> g = new CompletableFuture<>();
1498        final SubtractAction r = new SubtractAction();
1499
1500        assertTrue(f.cancel(mayInterruptIfRunning));
1501        g.complete(v1);
1502        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1506  
1507          checkCompletedWithWrappedCancellationException(h);
1508 <        checkCancelled(f);
1508 >        checkCancelled(!fFirst ? f : g);
1509          assertEquals(0, r.invocationCount);
1510 <        checkCompletedNormally(g, v1);
1511 <        }
1509 <    }
1510 >        checkCompletedNormally(fFirst ? f : g, v1);
1511 >    }}
1512  
1513      /**
1514       * runAfterBoth result completes normally after normal
1515       * completion of sources
1516       */
1517 <    public void testRunAfterBoth_normalCompletion1() {
1516 <        for (ExecutionMode m : ExecutionMode.values())
1517 <        for (Integer v1 : new Integer[] { 1, null })
1518 <        for (Integer v2 : new Integer[] { 2, null }) {
1519 <
1520 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1521 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1522 <        final Noop r = new Noop();
1523 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1524 <
1525 <        f.complete(v1);
1526 <        checkIncomplete(h);
1527 <        assertEquals(0, r.invocationCount);
1528 <        g.complete(v2);
1529 <
1530 <        checkCompletedNormally(h, null);
1531 <        assertEquals(1, r.invocationCount);
1532 <        checkCompletedNormally(f, v1);
1533 <        checkCompletedNormally(g, v2);
1534 <        }
1535 <    }
1536 <
1537 <    public void testRunAfterBoth_normalCompletion2() {
1538 <        for (ExecutionMode m : ExecutionMode.values())
1539 <        for (Integer v1 : new Integer[] { 1, null })
1540 <        for (Integer v2 : new Integer[] { 2, null }) {
1541 <
1542 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1543 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1544 <        final Noop r = new Noop();
1545 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1546 <
1547 <        g.complete(v2);
1548 <        checkIncomplete(h);
1549 <        assertEquals(0, r.invocationCount);
1550 <        f.complete(v1);
1551 <
1552 <        checkCompletedNormally(h, null);
1553 <        assertEquals(1, r.invocationCount);
1554 <        checkCompletedNormally(f, v1);
1555 <        checkCompletedNormally(g, v2);
1556 <        }
1557 <    }
1558 <
1559 <    public void testRunAfterBoth_normalCompletion3() {
1517 >    public void testRunAfterBoth_normalCompletion() {
1518          for (ExecutionMode m : ExecutionMode.values())
1519 +        for (boolean createIncomplete : new boolean[] { true, false })
1520 +        for (boolean fFirst : new boolean[] { true, false })
1521          for (Integer v1 : new Integer[] { 1, null })
1522 <        for (Integer v2 : new Integer[] { 2, null }) {
1523 <
1522 >        for (Integer v2 : new Integer[] { 2, null })
1523 >    {
1524          final CompletableFuture<Integer> f = new CompletableFuture<>();
1525          final CompletableFuture<Integer> g = new CompletableFuture<>();
1526 <        final Noop r = new Noop();
1526 >        final Noop r = new Noop(m);
1527  
1528 <        g.complete(v2);
1529 <        f.complete(v1);
1528 >        if (fFirst) f.complete(v1); else g.complete(v2);
1529 >        if (!createIncomplete)
1530 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1531          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1532 <
1533 <        checkCompletedNormally(h, null);
1534 <        assertEquals(1, r.invocationCount);
1535 <        checkCompletedNormally(f, v1);
1575 <        checkCompletedNormally(g, v2);
1532 >        if (createIncomplete) {
1533 >            checkIncomplete(h);
1534 >            assertEquals(0, r.invocationCount);
1535 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1536          }
1577    }
1578
1579    public void testRunAfterBoth_normalCompletion4() {
1580        for (ExecutionMode m : ExecutionMode.values())
1581        for (Integer v1 : new Integer[] { 1, null })
1582        for (Integer v2 : new Integer[] { 2, null }) {
1583
1584        final CompletableFuture<Integer> f = new CompletableFuture<>();
1585        final CompletableFuture<Integer> g = new CompletableFuture<>();
1586        final Noop r = new Noop();
1587
1588        f.complete(v1);
1589        g.complete(v2);
1590        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1537  
1538          checkCompletedNormally(h, null);
1539          assertEquals(1, r.invocationCount);
1540          checkCompletedNormally(f, v1);
1541          checkCompletedNormally(g, v2);
1542 <        }
1597 <    }
1542 >    }}
1543  
1544      /**
1545       * runAfterBoth result completes exceptionally after exceptional
1546       * completion of either source
1547       */
1548 <    public void testRunAfterBoth_exceptionalCompletion1() {
1604 <        for (ExecutionMode m : ExecutionMode.values())
1605 <        for (Integer v1 : new Integer[] { 1, null }) {
1606 <
1607 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1608 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1609 <        final Noop r = new Noop();
1610 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1611 <        final CFException ex = new CFException();
1612 <
1613 <        f.completeExceptionally(ex);
1614 <        checkIncomplete(h);
1615 <        g.complete(v1);
1616 <
1617 <        checkCompletedWithWrappedCFException(h, ex);
1618 <        checkCompletedWithWrappedCFException(f, ex);
1619 <        assertEquals(0, r.invocationCount);
1620 <        checkCompletedNormally(g, v1);
1621 <        }
1622 <    }
1623 <
1624 <    public void testRunAfterBoth_exceptionalCompletion2() {
1548 >    public void testRunAfterBoth_exceptionalCompletion() {
1549          for (ExecutionMode m : ExecutionMode.values())
1550 <        for (Integer v1 : new Integer[] { 1, null }) {
1551 <
1552 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1553 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1630 <        final Noop r = new Noop();
1631 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1632 <        final CFException ex = new CFException();
1633 <
1634 <        g.completeExceptionally(ex);
1635 <        checkIncomplete(h);
1636 <        f.complete(v1);
1637 <
1638 <        checkCompletedWithWrappedCFException(h, ex);
1639 <        checkCompletedWithWrappedCFException(g, ex);
1640 <        assertEquals(0, r.invocationCount);
1641 <        checkCompletedNormally(f, v1);
1642 <        }
1643 <    }
1644 <
1645 <    public void testRunAfterBoth_exceptionalCompletion3() {
1646 <        for (ExecutionMode m : ExecutionMode.values())
1647 <        for (Integer v1 : new Integer[] { 1, null }) {
1648 <
1550 >        for (boolean createIncomplete : new boolean[] { true, false })
1551 >        for (boolean fFirst : new boolean[] { true, false })
1552 >        for (Integer v1 : new Integer[] { 1, null })
1553 >    {
1554          final CompletableFuture<Integer> f = new CompletableFuture<>();
1555          final CompletableFuture<Integer> g = new CompletableFuture<>();
1651        final Noop r = new Noop();
1556          final CFException ex = new CFException();
1557 +        final Noop r = new Noop(m);
1558  
1559 <        g.completeExceptionally(ex);
1560 <        f.complete(v1);
1559 >        (fFirst ? f : g).complete(v1);
1560 >        if (!createIncomplete)
1561 >            (!fFirst ? f : g).completeExceptionally(ex);
1562          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1563 <
1564 <        checkCompletedWithWrappedCFException(h, ex);
1565 <        checkCompletedWithWrappedCFException(g, ex);
1660 <        assertEquals(0, r.invocationCount);
1661 <        checkCompletedNormally(f, v1);
1563 >        if (createIncomplete) {
1564 >            checkIncomplete(h);
1565 >            (!fFirst ? f : g).completeExceptionally(ex);
1566          }
1663    }
1664
1665    public void testRunAfterBoth_exceptionalCompletion4() {
1666        for (ExecutionMode m : ExecutionMode.values())
1667        for (Integer v1 : new Integer[] { 1, null }) {
1668
1669        final CompletableFuture<Integer> f = new CompletableFuture<>();
1670        final CompletableFuture<Integer> g = new CompletableFuture<>();
1671        final Noop r = new Noop();
1672        final CFException ex = new CFException();
1673
1674        f.completeExceptionally(ex);
1675        g.complete(v1);
1676        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1567  
1568          checkCompletedWithWrappedCFException(h, ex);
1679        checkCompletedWithWrappedCFException(f, ex);
1569          assertEquals(0, r.invocationCount);
1570 <        checkCompletedNormally(g, v1);
1571 <        }
1572 <    }
1570 >        checkCompletedNormally(fFirst ? f : g, v1);
1571 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1572 >    }}
1573  
1574      /**
1575       * runAfterBoth result completes exceptionally if action does
1576       */
1577 <    public void testRunAfterBoth_actionFailed1() {
1577 >    public void testRunAfterBoth_actionFailed() {
1578          for (ExecutionMode m : ExecutionMode.values())
1579 +        for (boolean fFirst : new boolean[] { true, false })
1580          for (Integer v1 : new Integer[] { 1, null })
1581 <        for (Integer v2 : new Integer[] { 2, null }) {
1582 <
1581 >        for (Integer v2 : new Integer[] { 2, null })
1582 >    {
1583          final CompletableFuture<Integer> f = new CompletableFuture<>();
1584          final CompletableFuture<Integer> g = new CompletableFuture<>();
1585 <        final FailingNoop r = new FailingNoop();
1696 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1697 <
1698 <        f.complete(v1);
1699 <        checkIncomplete(h);
1700 <        g.complete(v2);
1585 >        final FailingRunnable r = new FailingRunnable(m);
1586  
1587 <        checkCompletedWithWrappedCFException(h);
1588 <        checkCompletedNormally(f, v1);
1589 <        checkCompletedNormally(g, v2);
1587 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1588 >        if (fFirst) {
1589 >            f.complete(v1);
1590 >            g.complete(v2);
1591 >        } else {
1592 >            g.complete(v2);
1593 >            f.complete(v1);
1594          }
1595 <    }
1707 <
1708 <    public void testRunAfterBoth_actionFailed2() {
1709 <        for (ExecutionMode m : ExecutionMode.values())
1710 <        for (Integer v1 : new Integer[] { 1, null })
1711 <        for (Integer v2 : new Integer[] { 2, null }) {
1595 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1596  
1597 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1598 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1715 <        final FailingNoop r = new FailingNoop();
1716 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1717 <
1718 <        g.complete(v2);
1719 <        checkIncomplete(h);
1720 <        f.complete(v1);
1721 <
1722 <        checkCompletedWithWrappedCFException(h);
1597 >        checkCompletedWithWrappedCFException(h1);
1598 >        checkCompletedWithWrappedCFException(h2);
1599          checkCompletedNormally(f, v1);
1600          checkCompletedNormally(g, v2);
1601 <        }
1726 <    }
1601 >    }}
1602  
1603      /**
1604       * runAfterBoth result completes exceptionally if either source cancelled
1605       */
1606 <    public void testRunAfterBoth_sourceCancelled1() {
1606 >    public void testRunAfterBoth_sourceCancelled() {
1607          for (ExecutionMode m : ExecutionMode.values())
1608          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1609 <        for (Integer v1 : new Integer[] { 1, null }) {
1610 <
1611 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1612 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1738 <        final Noop r = new Noop();
1739 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1740 <
1741 <        assertTrue(f.cancel(mayInterruptIfRunning));
1742 <        checkIncomplete(h);
1743 <        g.complete(v1);
1744 <
1745 <        checkCompletedWithWrappedCancellationException(h);
1746 <        checkCancelled(f);
1747 <        assertEquals(0, r.invocationCount);
1748 <        checkCompletedNormally(g, v1);
1749 <        }
1750 <    }
1751 <
1752 <    public void testRunAfterBoth_sourceCancelled2() {
1753 <        for (ExecutionMode m : ExecutionMode.values())
1754 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1755 <        for (Integer v1 : new Integer[] { 1, null }) {
1756 <
1609 >        for (boolean createIncomplete : new boolean[] { true, false })
1610 >        for (boolean fFirst : new boolean[] { true, false })
1611 >        for (Integer v1 : new Integer[] { 1, null })
1612 >    {
1613          final CompletableFuture<Integer> f = new CompletableFuture<>();
1614          final CompletableFuture<Integer> g = new CompletableFuture<>();
1615 <        final Noop r = new Noop();
1760 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1761 <
1762 <        assertTrue(g.cancel(mayInterruptIfRunning));
1763 <        checkIncomplete(h);
1764 <        f.complete(v1);
1765 <
1766 <        checkCompletedWithWrappedCancellationException(h);
1767 <        checkCancelled(g);
1768 <        assertEquals(0, r.invocationCount);
1769 <        checkCompletedNormally(f, v1);
1770 <        }
1771 <    }
1615 >        final Noop r = new Noop(m);
1616  
1773    public void testRunAfterBoth_sourceCancelled3() {
1774        for (ExecutionMode m : ExecutionMode.values())
1775        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1776        for (Integer v1 : new Integer[] { 1, null }) {
1617  
1618 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1619 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1620 <        final Noop r = new Noop();
1781 <
1782 <        assertTrue(g.cancel(mayInterruptIfRunning));
1783 <        f.complete(v1);
1618 >        (fFirst ? f : g).complete(v1);
1619 >        if (!createIncomplete)
1620 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1621          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1622 <
1623 <        checkCompletedWithWrappedCancellationException(h);
1624 <        checkCancelled(g);
1788 <        assertEquals(0, r.invocationCount);
1789 <        checkCompletedNormally(f, v1);
1622 >        if (createIncomplete) {
1623 >            checkIncomplete(h);
1624 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1625          }
1791    }
1792
1793    public void testRunAfterBoth_sourceCancelled4() {
1794        for (ExecutionMode m : ExecutionMode.values())
1795        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1796        for (Integer v1 : new Integer[] { 1, null }) {
1797
1798        final CompletableFuture<Integer> f = new CompletableFuture<>();
1799        final CompletableFuture<Integer> g = new CompletableFuture<>();
1800        final Noop r = new Noop();
1801
1802        assertTrue(f.cancel(mayInterruptIfRunning));
1803        g.complete(v1);
1804        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1626  
1627          checkCompletedWithWrappedCancellationException(h);
1628 <        checkCancelled(f);
1628 >        checkCancelled(!fFirst ? f : g);
1629          assertEquals(0, r.invocationCount);
1630 <        checkCompletedNormally(g, v1);
1631 <        }
1811 <    }
1630 >        checkCompletedNormally(fFirst ? f : g, v1);
1631 >    }}
1632  
1633      /**
1634       * applyToEither result completes normally after normal completion
1635       * of either source
1636       */
1637 <    public void testApplyToEither_normalCompletion1() {
1637 >    public void testApplyToEither_normalCompletion() {
1638          for (ExecutionMode m : ExecutionMode.values())
1639 +        for (boolean createIncomplete : new boolean[] { true, false })
1640 +        for (boolean fFirst : new boolean[] { true, false })
1641          for (Integer v1 : new Integer[] { 1, null })
1642 <        for (Integer v2 : new Integer[] { 2, null }) {
1643 <
1642 >        for (Integer v2 : new Integer[] { 2, null })
1643 >    {
1644          final CompletableFuture<Integer> f = new CompletableFuture<>();
1645          final CompletableFuture<Integer> g = new CompletableFuture<>();
1646 <        final IncFunction r = new IncFunction();
1825 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1646 >        final IncFunction r = new IncFunction(m);
1647  
1648 <        f.complete(v1);
1649 <        checkCompletedNormally(h, inc(v1));
1650 <        g.complete(v2);
1648 >        if (!createIncomplete)
1649 >            if (fFirst) f.complete(v1); else g.complete(v2);
1650 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1651 >        if (createIncomplete) {
1652 >            checkIncomplete(h);
1653 >            assertEquals(0, r.invocationCount);
1654 >            if (fFirst) f.complete(v1); else g.complete(v2);
1655 >        }
1656 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1657 >        if (!fFirst) f.complete(v1); else g.complete(v2);
1658  
1659          checkCompletedNormally(f, v1);
1660          checkCompletedNormally(g, v2);
1661 <        checkCompletedNormally(h, inc(v1));
1662 <        }
1835 <    }
1661 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1662 >    }}
1663  
1664 <    public void testApplyToEither_normalCompletion2() {
1664 >    public void testApplyToEither_normalCompletionBothAvailable() {
1665          for (ExecutionMode m : ExecutionMode.values())
1666 +        for (boolean fFirst : new boolean[] { true, false })
1667          for (Integer v1 : new Integer[] { 1, null })
1668 <        for (Integer v2 : new Integer[] { 2, null }) {
1669 <
1668 >        for (Integer v2 : new Integer[] { 2, null })
1669 >    {
1670          final CompletableFuture<Integer> f = new CompletableFuture<>();
1671          final CompletableFuture<Integer> g = new CompletableFuture<>();
1672 <        final IncFunction r = new IncFunction();
1845 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1846 <
1847 <        g.complete(v2);
1848 <        checkCompletedNormally(h, inc(v2));
1849 <        f.complete(v1);
1672 >        final IncFunction r = new IncFunction(m);
1673  
1674 <        checkCompletedNormally(f, v1);
1675 <        checkCompletedNormally(g, v2);
1676 <        checkCompletedNormally(h, inc(v2));
1674 >        if (fFirst) {
1675 >            f.complete(v1);
1676 >            g.complete(v2);
1677 >        } else {
1678 >            g.complete(v2);
1679 >            f.complete(v1);
1680          }
1855    }
1856    public void testApplyToEither_normalCompletion3() {
1857        for (ExecutionMode m : ExecutionMode.values())
1858        for (Integer v1 : new Integer[] { 1, null })
1859        for (Integer v2 : new Integer[] { 2, null }) {
1681  
1861        final CompletableFuture<Integer> f = new CompletableFuture<>();
1862        final CompletableFuture<Integer> g = new CompletableFuture<>();
1863        final IncFunction r = new IncFunction();
1864
1865        f.complete(v1);
1866        g.complete(v2);
1682          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1683  
1684          checkCompletedNormally(f, v1);
# Line 1873 | Line 1688 | public class CompletableFutureTest exten
1688          assertTrue(Objects.equals(h.join(), inc(v1)) ||
1689                     Objects.equals(h.join(), inc(v2)));
1690          assertEquals(1, r.invocationCount);
1691 <        }
1877 <    }
1691 >    }}
1692  
1693      /**
1694       * applyToEither result completes exceptionally after exceptional
# Line 1882 | Line 1696 | public class CompletableFutureTest exten
1696       */
1697      public void testApplyToEither_exceptionalCompletion1() {
1698          for (ExecutionMode m : ExecutionMode.values())
1699 <        for (Integer v1 : new Integer[] { 1, null }) {
1700 <
1699 >        for (boolean createIncomplete : new boolean[] { true, false })
1700 >        for (boolean fFirst : new boolean[] { true, false })
1701 >        for (Integer v1 : new Integer[] { 1, null })
1702 >    {
1703          final CompletableFuture<Integer> f = new CompletableFuture<>();
1704          final CompletableFuture<Integer> g = new CompletableFuture<>();
1889        final IncFunction r = new IncFunction();
1890        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1705          final CFException ex = new CFException();
1706 +        final IncFunction r = new IncFunction(m);
1707  
1708 <        f.completeExceptionally(ex);
1894 <        checkCompletedWithWrappedCFException(h, ex);
1895 <        g.complete(v1);
1896 <
1897 <        assertEquals(0, r.invocationCount);
1898 <        checkCompletedNormally(g, v1);
1899 <        checkCompletedWithWrappedCFException(f, ex);
1900 <        checkCompletedWithWrappedCFException(h, ex);
1901 <        }
1902 <    }
1903 <
1904 <    public void testApplyToEither_exceptionalCompletion2() {
1905 <        for (ExecutionMode m : ExecutionMode.values())
1906 <        for (Integer v1 : new Integer[] { 1, null }) {
1907 <
1908 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1909 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1910 <        final IncFunction r = new IncFunction();
1708 >        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1709          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1710 <        final CFException ex = new CFException();
1710 >        if (createIncomplete) {
1711 >            checkIncomplete(h);
1712 >            assertEquals(0, r.invocationCount);
1713 >            (fFirst ? f : g).completeExceptionally(ex);
1714 >        }
1715  
1914        g.completeExceptionally(ex);
1716          checkCompletedWithWrappedCFException(h, ex);
1717 <        f.complete(v1);
1717 >        (!fFirst ? f : g).complete(v1);
1718  
1719          assertEquals(0, r.invocationCount);
1720 <        checkCompletedNormally(f, v1);
1721 <        checkCompletedWithWrappedCFException(g, ex);
1720 >        checkCompletedNormally(!fFirst ? f : g, v1);
1721 >        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1722          checkCompletedWithWrappedCFException(h, ex);
1723 <        }
1923 <    }
1723 >    }}
1724  
1725 <    public void testApplyToEither_exceptionalCompletion3() {
1725 >    public void testApplyToEither_exceptionalCompletion2() {
1726          for (ExecutionMode m : ExecutionMode.values())
1727 <        for (Integer v1 : new Integer[] { 1, null }) {
1728 <
1727 >        for (boolean reverseArgs : new boolean[] { true, false })
1728 >        for (boolean fFirst : new boolean[] { true, false })
1729 >        for (Integer v1 : new Integer[] { 1, null })
1730 >    {
1731          final CompletableFuture<Integer> f = new CompletableFuture<>();
1732          final CompletableFuture<Integer> g = new CompletableFuture<>();
1733 <        final IncFunction r = new IncFunction();
1733 >        final IncFunction r1 = new IncFunction(m);
1734 >        final IncFunction r2 = new IncFunction(m);
1735          final CFException ex = new CFException();
1736 <
1737 <        g.completeExceptionally(ex);
1738 <        f.complete(v1);
1739 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1736 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1737 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1738 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1739 >        if (fFirst) {
1740 >            f.complete(v1);
1741 >            g.completeExceptionally(ex);
1742 >        } else {
1743 >            g.completeExceptionally(ex);
1744 >            f.complete(v1);
1745 >        }
1746 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1747  
1748          // unspecified behavior
1939        Integer v;
1749          try {
1750 <            assertEquals(h.join(), inc(v1));
1751 <            assertEquals(1, r.invocationCount);
1750 >            assertEquals(inc(v1), h1.join());
1751 >            assertEquals(1, r1.invocationCount);
1752          } catch (CompletionException ok) {
1753 <            checkCompletedWithWrappedCFException(h, ex);
1754 <            assertEquals(0, r.invocationCount);
1753 >            checkCompletedWithWrappedCFException(h1, ex);
1754 >            assertEquals(0, r1.invocationCount);
1755          }
1756  
1948        checkCompletedWithWrappedCFException(g, ex);
1949        checkCompletedNormally(f, v1);
1950        }
1951    }
1952
1953    public void testApplyToEither_exceptionalCompletion4() {
1954        for (ExecutionMode m : ExecutionMode.values())
1955        for (Integer v1 : new Integer[] { 1, null }) {
1956
1957        final CompletableFuture<Integer> f = new CompletableFuture<>();
1958        final CompletableFuture<Integer> g = new CompletableFuture<>();
1959        final IncFunction r = new IncFunction();
1960        final CFException ex = new CFException();
1961
1962        f.completeExceptionally(ex);
1963        g.complete(v1);
1964        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1965
1966        // unspecified behavior
1967        Integer v;
1757          try {
1758 <            assertEquals(h.join(), inc(v1));
1759 <            assertEquals(1, r.invocationCount);
1758 >            assertEquals(inc(v1), h2.join());
1759 >            assertEquals(1, r2.invocationCount);
1760          } catch (CompletionException ok) {
1761 <            checkCompletedWithWrappedCFException(h, ex);
1762 <            assertEquals(0, r.invocationCount);
1761 >            checkCompletedWithWrappedCFException(h2, ex);
1762 >            assertEquals(0, r2.invocationCount);
1763          }
1764  
1765 <        checkCompletedWithWrappedCFException(f, ex);
1766 <        checkCompletedNormally(g, v1);
1767 <        }
1979 <    }
1765 >        checkCompletedWithWrappedCFException(g, ex);
1766 >        checkCompletedNormally(f, v1);
1767 >    }}
1768  
1769      /**
1770       * applyToEither result completes exceptionally if action does
# Line 1984 | Line 1772 | public class CompletableFutureTest exten
1772      public void testApplyToEither_actionFailed1() {
1773          for (ExecutionMode m : ExecutionMode.values())
1774          for (Integer v1 : new Integer[] { 1, null })
1775 <        for (Integer v2 : new Integer[] { 2, null }) {
1776 <
1775 >        for (Integer v2 : new Integer[] { 2, null })
1776 >    {
1777          final CompletableFuture<Integer> f = new CompletableFuture<>();
1778          final CompletableFuture<Integer> g = new CompletableFuture<>();
1779 <        final FailingFunction r = new FailingFunction();
1779 >        final FailingFunction r = new FailingFunction(m);
1780          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1781  
1782          f.complete(v1);
# Line 1996 | Line 1784 | public class CompletableFutureTest exten
1784          g.complete(v2);
1785          checkCompletedNormally(f, v1);
1786          checkCompletedNormally(g, v2);
1787 <        }
2000 <    }
1787 >    }}
1788  
1789      public void testApplyToEither_actionFailed2() {
1790          for (ExecutionMode m : ExecutionMode.values())
1791          for (Integer v1 : new Integer[] { 1, null })
1792 <        for (Integer v2 : new Integer[] { 2, null }) {
1793 <
1792 >        for (Integer v2 : new Integer[] { 2, null })
1793 >    {
1794          final CompletableFuture<Integer> f = new CompletableFuture<>();
1795          final CompletableFuture<Integer> g = new CompletableFuture<>();
1796 <        final FailingFunction r = new FailingFunction();
1796 >        final FailingFunction r = new FailingFunction(m);
1797          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1798  
1799          g.complete(v2);
# Line 2014 | Line 1801 | public class CompletableFutureTest exten
1801          f.complete(v1);
1802          checkCompletedNormally(f, v1);
1803          checkCompletedNormally(g, v2);
1804 <        }
2018 <    }
1804 >    }}
1805  
1806      /**
1807       * applyToEither result completes exceptionally if either source cancelled
# Line 2023 | Line 1809 | public class CompletableFutureTest exten
1809      public void testApplyToEither_sourceCancelled1() {
1810          for (ExecutionMode m : ExecutionMode.values())
1811          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1812 <        for (Integer v1 : new Integer[] { 1, null }) {
1813 <
1812 >        for (boolean createIncomplete : new boolean[] { true, false })
1813 >        for (boolean fFirst : new boolean[] { true, false })
1814 >        for (Integer v1 : new Integer[] { 1, null })
1815 >    {
1816          final CompletableFuture<Integer> f = new CompletableFuture<>();
1817          final CompletableFuture<Integer> g = new CompletableFuture<>();
1818 <        final IncFunction r = new IncFunction();
1818 >        final IncFunction r = new IncFunction(m);
1819 >
1820 >        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1821          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1822 +        if (createIncomplete) {
1823 +            checkIncomplete(h);
1824 +            assertEquals(0, r.invocationCount);
1825 +            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1826 +        }
1827  
2033        assertTrue(f.cancel(mayInterruptIfRunning));
1828          checkCompletedWithWrappedCancellationException(h);
1829 <        g.complete(v1);
1829 >        (!fFirst ? f : g).complete(v1);
1830  
2037        checkCancelled(f);
1831          assertEquals(0, r.invocationCount);
1832 <        checkCompletedNormally(g, v1);
1832 >        checkCompletedNormally(!fFirst ? f : g, v1);
1833 >        checkCancelled(fFirst ? f : g);
1834          checkCompletedWithWrappedCancellationException(h);
1835 <        }
2042 <    }
1835 >    }}
1836  
1837      public void testApplyToEither_sourceCancelled2() {
1838          for (ExecutionMode m : ExecutionMode.values())
1839          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1840 <        for (Integer v1 : new Integer[] { 1, null }) {
1841 <
1840 >        for (boolean reverseArgs : new boolean[] { true, false })
1841 >        for (boolean fFirst : new boolean[] { true, false })
1842 >        for (Integer v1 : new Integer[] { 1, null })
1843 >    {
1844          final CompletableFuture<Integer> f = new CompletableFuture<>();
1845          final CompletableFuture<Integer> g = new CompletableFuture<>();
1846 <        final IncFunction r = new IncFunction();
1847 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1848 <
1849 <        assertTrue(g.cancel(mayInterruptIfRunning));
1850 <        checkCompletedWithWrappedCancellationException(h);
2056 <        f.complete(v1);
1846 >        final IncFunction r1 = new IncFunction(m);
1847 >        final IncFunction r2 = new IncFunction(m);
1848 >        final CFException ex = new CFException();
1849 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1850 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1851  
1852 <        checkCancelled(g);
1853 <        assertEquals(0, r.invocationCount);
1854 <        checkCompletedNormally(f, v1);
1855 <        checkCompletedWithWrappedCancellationException(h);
1852 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1853 >        if (fFirst) {
1854 >            f.complete(v1);
1855 >            assertTrue(g.cancel(mayInterruptIfRunning));
1856 >        } else {
1857 >            assertTrue(g.cancel(mayInterruptIfRunning));
1858 >            f.complete(v1);
1859          }
1860 <    }
2064 <
2065 <    public void testApplyToEither_sourceCancelled3() {
2066 <        for (ExecutionMode m : ExecutionMode.values())
2067 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2068 <        for (Integer v1 : new Integer[] { 1, null }) {
2069 <
2070 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2071 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2072 <        final IncFunction r = new IncFunction();
2073 <
2074 <        assertTrue(g.cancel(mayInterruptIfRunning));
2075 <        f.complete(v1);
2076 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1860 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1861  
1862          // unspecified behavior
2079        Integer v;
1863          try {
1864 <            assertEquals(h.join(), inc(v1));
1865 <            assertEquals(1, r.invocationCount);
1864 >            assertEquals(inc(v1), h1.join());
1865 >            assertEquals(1, r1.invocationCount);
1866          } catch (CompletionException ok) {
1867 <            checkCompletedWithWrappedCancellationException(h);
1868 <            assertEquals(0, r.invocationCount);
2086 <        }
2087 <
2088 <        checkCancelled(g);
2089 <        checkCompletedNormally(f, v1);
1867 >            checkCompletedWithWrappedCancellationException(h1);
1868 >            assertEquals(0, r1.invocationCount);
1869          }
2091    }
2092
2093    public void testApplyToEither_sourceCancelled4() {
2094        for (ExecutionMode m : ExecutionMode.values())
2095        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2096        for (Integer v1 : new Integer[] { 1, null }) {
2097
2098        final CompletableFuture<Integer> f = new CompletableFuture<>();
2099        final CompletableFuture<Integer> g = new CompletableFuture<>();
2100        final IncFunction r = new IncFunction();
1870  
2102        assertTrue(f.cancel(mayInterruptIfRunning));
2103        g.complete(v1);
2104        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2105
2106        // unspecified behavior
2107        Integer v;
1871          try {
1872 <            assertEquals(h.join(), inc(v1));
1873 <            assertEquals(1, r.invocationCount);
1872 >            assertEquals(inc(v1), h2.join());
1873 >            assertEquals(1, r2.invocationCount);
1874          } catch (CompletionException ok) {
1875 <            checkCompletedWithWrappedCancellationException(h);
1876 <            assertEquals(0, r.invocationCount);
1875 >            checkCompletedWithWrappedCancellationException(h2);
1876 >            assertEquals(0, r2.invocationCount);
1877          }
1878  
1879 <        checkCancelled(f);
1880 <        checkCompletedNormally(g, v1);
1881 <        }
2119 <    }
1879 >        checkCancelled(g);
1880 >        checkCompletedNormally(f, v1);
1881 >    }}
1882  
1883      /**
1884       * acceptEither result completes normally after normal completion
# Line 2125 | Line 1887 | public class CompletableFutureTest exten
1887      public void testAcceptEither_normalCompletion1() {
1888          for (ExecutionMode m : ExecutionMode.values())
1889          for (Integer v1 : new Integer[] { 1, null })
1890 <        for (Integer v2 : new Integer[] { 2, null }) {
1891 <
1890 >        for (Integer v2 : new Integer[] { 2, null })
1891 >    {
1892          final CompletableFuture<Integer> f = new CompletableFuture<>();
1893          final CompletableFuture<Integer> g = new CompletableFuture<>();
1894          final IncAction r = new IncAction();
# Line 2134 | Line 1896 | public class CompletableFutureTest exten
1896  
1897          f.complete(v1);
1898          checkCompletedNormally(h, null);
1899 <        assertEquals(r.value, inc(v1));
1899 >        assertEquals(inc(v1), r.value);
1900          g.complete(v2);
1901  
1902          checkCompletedNormally(f, v1);
1903          checkCompletedNormally(g, v2);
1904          checkCompletedNormally(h, null);
1905 <        }
2144 <    }
1905 >    }}
1906  
1907      public void testAcceptEither_normalCompletion2() {
1908          for (ExecutionMode m : ExecutionMode.values())
1909          for (Integer v1 : new Integer[] { 1, null })
1910 <        for (Integer v2 : new Integer[] { 2, null }) {
1911 <
1910 >        for (Integer v2 : new Integer[] { 2, null })
1911 >    {
1912          final CompletableFuture<Integer> f = new CompletableFuture<>();
1913          final CompletableFuture<Integer> g = new CompletableFuture<>();
1914          final IncAction r = new IncAction();
# Line 2155 | Line 1916 | public class CompletableFutureTest exten
1916  
1917          g.complete(v2);
1918          checkCompletedNormally(h, null);
1919 <        assertEquals(r.value, inc(v2));
1919 >        assertEquals(inc(v2), r.value);
1920          f.complete(v1);
1921  
1922          checkCompletedNormally(f, v1);
1923          checkCompletedNormally(g, v2);
1924          checkCompletedNormally(h, null);
1925 <        }
1926 <    }
1925 >    }}
1926 >
1927      public void testAcceptEither_normalCompletion3() {
1928          for (ExecutionMode m : ExecutionMode.values())
1929          for (Integer v1 : new Integer[] { 1, null })
1930 <        for (Integer v2 : new Integer[] { 2, null }) {
1931 <
1930 >        for (Integer v2 : new Integer[] { 2, null })
1931 >    {
1932          final CompletableFuture<Integer> f = new CompletableFuture<>();
1933          final CompletableFuture<Integer> g = new CompletableFuture<>();
1934          final IncAction r = new IncAction();
# Line 2183 | Line 1944 | public class CompletableFutureTest exten
1944          // unspecified behavior
1945          assertTrue(Objects.equals(r.value, inc(v1)) ||
1946                     Objects.equals(r.value, inc(v2)));
1947 <        }
2187 <    }
1947 >    }}
1948  
1949      /**
1950       * acceptEither result completes exceptionally after exceptional
# Line 2192 | Line 1952 | public class CompletableFutureTest exten
1952       */
1953      public void testAcceptEither_exceptionalCompletion1() {
1954          for (ExecutionMode m : ExecutionMode.values())
1955 <        for (Integer v1 : new Integer[] { 1, null }) {
1956 <
1955 >        for (Integer v1 : new Integer[] { 1, null })
1956 >    {
1957          final CompletableFuture<Integer> f = new CompletableFuture<>();
1958          final CompletableFuture<Integer> g = new CompletableFuture<>();
1959          final IncAction r = new IncAction();
# Line 2208 | Line 1968 | public class CompletableFutureTest exten
1968          checkCompletedNormally(g, v1);
1969          checkCompletedWithWrappedCFException(f, ex);
1970          checkCompletedWithWrappedCFException(h, ex);
1971 <        }
2212 <    }
1971 >    }}
1972  
1973      public void testAcceptEither_exceptionalCompletion2() {
1974          for (ExecutionMode m : ExecutionMode.values())
1975 <        for (Integer v1 : new Integer[] { 1, null }) {
1976 <
1975 >        for (Integer v1 : new Integer[] { 1, null })
1976 >    {
1977          final CompletableFuture<Integer> f = new CompletableFuture<>();
1978          final CompletableFuture<Integer> g = new CompletableFuture<>();
1979          final IncAction r = new IncAction();
# Line 2229 | Line 1988 | public class CompletableFutureTest exten
1988          checkCompletedNormally(f, v1);
1989          checkCompletedWithWrappedCFException(g, ex);
1990          checkCompletedWithWrappedCFException(h, ex);
1991 <        }
2233 <    }
1991 >    }}
1992  
1993      public void testAcceptEither_exceptionalCompletion3() {
1994          for (ExecutionMode m : ExecutionMode.values())
1995 <        for (Integer v1 : new Integer[] { 1, null }) {
1996 <
1995 >        for (Integer v1 : new Integer[] { 1, null })
1996 >    {
1997          final CompletableFuture<Integer> f = new CompletableFuture<>();
1998          final CompletableFuture<Integer> g = new CompletableFuture<>();
1999          final IncAction r = new IncAction();
# Line 2248 | Line 2006 | public class CompletableFutureTest exten
2006          // unspecified behavior
2007          Integer v;
2008          try {
2009 <            assertEquals(h.join(), null);
2009 >            assertNull(h.join());
2010              assertEquals(1, r.invocationCount);
2011              assertEquals(inc(v1), r.value);
2012          } catch (CompletionException ok) {
# Line 2258 | Line 2016 | public class CompletableFutureTest exten
2016  
2017          checkCompletedWithWrappedCFException(g, ex);
2018          checkCompletedNormally(f, v1);
2019 <        }
2262 <    }
2019 >    }}
2020  
2021      public void testAcceptEither_exceptionalCompletion4() {
2022          for (ExecutionMode m : ExecutionMode.values())
2023 <        for (Integer v1 : new Integer[] { 1, null }) {
2024 <
2023 >        for (Integer v1 : new Integer[] { 1, null })
2024 >    {
2025          final CompletableFuture<Integer> f = new CompletableFuture<>();
2026          final CompletableFuture<Integer> g = new CompletableFuture<>();
2027          final IncAction r = new IncAction();
# Line 2277 | Line 2034 | public class CompletableFutureTest exten
2034          // unspecified behavior
2035          Integer v;
2036          try {
2037 <            assertEquals(h.join(), null);
2037 >            assertNull(h.join());
2038              assertEquals(1, r.invocationCount);
2039              assertEquals(inc(v1), r.value);
2040          } catch (CompletionException ok) {
# Line 2287 | Line 2044 | public class CompletableFutureTest exten
2044  
2045          checkCompletedWithWrappedCFException(f, ex);
2046          checkCompletedNormally(g, v1);
2047 <        }
2291 <    }
2047 >    }}
2048  
2049      /**
2050       * acceptEither result completes exceptionally if action does
# Line 2296 | Line 2052 | public class CompletableFutureTest exten
2052      public void testAcceptEither_actionFailed1() {
2053          for (ExecutionMode m : ExecutionMode.values())
2054          for (Integer v1 : new Integer[] { 1, null })
2055 <        for (Integer v2 : new Integer[] { 2, null }) {
2056 <
2055 >        for (Integer v2 : new Integer[] { 2, null })
2056 >    {
2057          final CompletableFuture<Integer> f = new CompletableFuture<>();
2058          final CompletableFuture<Integer> g = new CompletableFuture<>();
2059 <        final FailingConsumer r = new FailingConsumer();
2059 >        final FailingConsumer r = new FailingConsumer(m);
2060          final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2061  
2062          f.complete(v1);
# Line 2308 | Line 2064 | public class CompletableFutureTest exten
2064          g.complete(v2);
2065          checkCompletedNormally(f, v1);
2066          checkCompletedNormally(g, v2);
2067 <        }
2312 <    }
2067 >    }}
2068  
2069      public void testAcceptEither_actionFailed2() {
2070          for (ExecutionMode m : ExecutionMode.values())
2071          for (Integer v1 : new Integer[] { 1, null })
2072 <        for (Integer v2 : new Integer[] { 2, null }) {
2073 <
2072 >        for (Integer v2 : new Integer[] { 2, null })
2073 >    {
2074          final CompletableFuture<Integer> f = new CompletableFuture<>();
2075          final CompletableFuture<Integer> g = new CompletableFuture<>();
2076 <        final FailingConsumer r = new FailingConsumer();
2076 >        final FailingConsumer r = new FailingConsumer(m);
2077          final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2078  
2079          g.complete(v2);
# Line 2326 | Line 2081 | public class CompletableFutureTest exten
2081          f.complete(v1);
2082          checkCompletedNormally(f, v1);
2083          checkCompletedNormally(g, v2);
2084 <        }
2330 <    }
2084 >    }}
2085  
2086      /**
2087       * acceptEither result completes exceptionally if either source cancelled
# Line 2335 | Line 2089 | public class CompletableFutureTest exten
2089      public void testAcceptEither_sourceCancelled1() {
2090          for (ExecutionMode m : ExecutionMode.values())
2091          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2092 <        for (Integer v1 : new Integer[] { 1, null }) {
2093 <
2092 >        for (Integer v1 : new Integer[] { 1, null })
2093 >    {
2094          final CompletableFuture<Integer> f = new CompletableFuture<>();
2095          final CompletableFuture<Integer> g = new CompletableFuture<>();
2096          final IncAction r = new IncAction();
# Line 2350 | Line 2104 | public class CompletableFutureTest exten
2104          assertEquals(0, r.invocationCount);
2105          checkCompletedNormally(g, v1);
2106          checkCompletedWithWrappedCancellationException(h);
2107 <        }
2354 <    }
2107 >    }}
2108  
2109      public void testAcceptEither_sourceCancelled2() {
2110          for (ExecutionMode m : ExecutionMode.values())
2111          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2112 <        for (Integer v1 : new Integer[] { 1, null }) {
2113 <
2112 >        for (Integer v1 : new Integer[] { 1, null })
2113 >    {
2114          final CompletableFuture<Integer> f = new CompletableFuture<>();
2115          final CompletableFuture<Integer> g = new CompletableFuture<>();
2116          final IncAction r = new IncAction();
# Line 2371 | Line 2124 | public class CompletableFutureTest exten
2124          assertEquals(0, r.invocationCount);
2125          checkCompletedNormally(f, v1);
2126          checkCompletedWithWrappedCancellationException(h);
2127 <        }
2375 <    }
2127 >    }}
2128  
2129      public void testAcceptEither_sourceCancelled3() {
2130          for (ExecutionMode m : ExecutionMode.values())
2131          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2132 <        for (Integer v1 : new Integer[] { 1, null }) {
2133 <
2132 >        for (Integer v1 : new Integer[] { 1, null })
2133 >    {
2134          final CompletableFuture<Integer> f = new CompletableFuture<>();
2135          final CompletableFuture<Integer> g = new CompletableFuture<>();
2136          final IncAction r = new IncAction();
# Line 2390 | Line 2142 | public class CompletableFutureTest exten
2142          // unspecified behavior
2143          Integer v;
2144          try {
2145 <            assertEquals(h.join(), null);
2145 >            assertNull(h.join());
2146              assertEquals(1, r.invocationCount);
2147              assertEquals(inc(v1), r.value);
2148          } catch (CompletionException ok) {
# Line 2400 | Line 2152 | public class CompletableFutureTest exten
2152  
2153          checkCancelled(g);
2154          checkCompletedNormally(f, v1);
2155 <        }
2404 <    }
2155 >    }}
2156  
2157      public void testAcceptEither_sourceCancelled4() {
2158          for (ExecutionMode m : ExecutionMode.values())
2159          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2160 <        for (Integer v1 : new Integer[] { 1, null }) {
2161 <
2160 >        for (Integer v1 : new Integer[] { 1, null })
2161 >    {
2162          final CompletableFuture<Integer> f = new CompletableFuture<>();
2163          final CompletableFuture<Integer> g = new CompletableFuture<>();
2164          final IncAction r = new IncAction();
# Line 2419 | Line 2170 | public class CompletableFutureTest exten
2170          // unspecified behavior
2171          Integer v;
2172          try {
2173 <            assertEquals(h.join(), null);
2173 >            assertNull(h.join());
2174              assertEquals(1, r.invocationCount);
2175              assertEquals(inc(v1), r.value);
2176          } catch (CompletionException ok) {
# Line 2429 | Line 2180 | public class CompletableFutureTest exten
2180  
2181          checkCancelled(f);
2182          checkCompletedNormally(g, v1);
2183 <        }
2433 <    }
2183 >    }}
2184  
2185      /**
2186       * runAfterEither result completes normally after normal completion
# Line 2439 | Line 2189 | public class CompletableFutureTest exten
2189      public void testRunAfterEither_normalCompletion1() {
2190          for (ExecutionMode m : ExecutionMode.values())
2191          for (Integer v1 : new Integer[] { 1, null })
2192 <        for (Integer v2 : new Integer[] { 2, null }) {
2193 <
2192 >        for (Integer v2 : new Integer[] { 2, null })
2193 >    {
2194          final CompletableFuture<Integer> f = new CompletableFuture<>();
2195          final CompletableFuture<Integer> g = new CompletableFuture<>();
2196 <        final Noop r = new Noop();
2196 >        final Noop r = new Noop(m);
2197          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2198  
2199          f.complete(v1);
# Line 2455 | Line 2205 | public class CompletableFutureTest exten
2205          checkCompletedNormally(g, v2);
2206          checkCompletedNormally(h, null);
2207          assertEquals(1, r.invocationCount);
2208 <        }
2459 <    }
2208 >    }}
2209  
2210      public void testRunAfterEither_normalCompletion2() {
2211          for (ExecutionMode m : ExecutionMode.values())
2212          for (Integer v1 : new Integer[] { 1, null })
2213 <        for (Integer v2 : new Integer[] { 2, null }) {
2214 <
2213 >        for (Integer v2 : new Integer[] { 2, null })
2214 >    {
2215          final CompletableFuture<Integer> f = new CompletableFuture<>();
2216          final CompletableFuture<Integer> g = new CompletableFuture<>();
2217 <        final Noop r = new Noop();
2217 >        final Noop r = new Noop(m);
2218          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2219  
2220          g.complete(v2);
# Line 2477 | Line 2226 | public class CompletableFutureTest exten
2226          checkCompletedNormally(g, v2);
2227          checkCompletedNormally(h, null);
2228          assertEquals(1, r.invocationCount);
2229 <        }
2230 <    }
2229 >        }}
2230 >
2231      public void testRunAfterEither_normalCompletion3() {
2232          for (ExecutionMode m : ExecutionMode.values())
2233          for (Integer v1 : new Integer[] { 1, null })
2234 <        for (Integer v2 : new Integer[] { 2, null }) {
2235 <
2234 >        for (Integer v2 : new Integer[] { 2, null })
2235 >    {
2236          final CompletableFuture<Integer> f = new CompletableFuture<>();
2237          final CompletableFuture<Integer> g = new CompletableFuture<>();
2238 <        final Noop r = new Noop();
2238 >        final Noop r = new Noop(m);
2239  
2240          f.complete(v1);
2241          g.complete(v2);
# Line 2496 | Line 2245 | public class CompletableFutureTest exten
2245          checkCompletedNormally(f, v1);
2246          checkCompletedNormally(g, v2);
2247          assertEquals(1, r.invocationCount);
2248 <        }
2500 <    }
2248 >    }}
2249  
2250      /**
2251       * runAfterEither result completes exceptionally after exceptional
# Line 2505 | Line 2253 | public class CompletableFutureTest exten
2253       */
2254      public void testRunAfterEither_exceptionalCompletion1() {
2255          for (ExecutionMode m : ExecutionMode.values())
2256 <        for (Integer v1 : new Integer[] { 1, null }) {
2257 <
2256 >        for (Integer v1 : new Integer[] { 1, null })
2257 >    {
2258          final CompletableFuture<Integer> f = new CompletableFuture<>();
2259          final CompletableFuture<Integer> g = new CompletableFuture<>();
2260 <        final Noop r = new Noop();
2260 >        final Noop r = new Noop(m);
2261          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2262          final CFException ex = new CFException();
2263  
# Line 2521 | Line 2269 | public class CompletableFutureTest exten
2269          checkCompletedNormally(g, v1);
2270          checkCompletedWithWrappedCFException(f, ex);
2271          checkCompletedWithWrappedCFException(h, ex);
2272 <        }
2525 <    }
2272 >    }}
2273  
2274      public void testRunAfterEither_exceptionalCompletion2() {
2275          for (ExecutionMode m : ExecutionMode.values())
2276 <        for (Integer v1 : new Integer[] { 1, null }) {
2277 <
2276 >        for (Integer v1 : new Integer[] { 1, null })
2277 >    {
2278          final CompletableFuture<Integer> f = new CompletableFuture<>();
2279          final CompletableFuture<Integer> g = new CompletableFuture<>();
2280 <        final Noop r = new Noop();
2280 >        final Noop r = new Noop(m);
2281          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2282          final CFException ex = new CFException();
2283  
# Line 2542 | Line 2289 | public class CompletableFutureTest exten
2289          checkCompletedNormally(f, v1);
2290          checkCompletedWithWrappedCFException(g, ex);
2291          checkCompletedWithWrappedCFException(h, ex);
2292 <        }
2546 <    }
2292 >    }}
2293  
2294      public void testRunAfterEither_exceptionalCompletion3() {
2295          for (ExecutionMode m : ExecutionMode.values())
2296 <        for (Integer v1 : new Integer[] { 1, null }) {
2297 <
2296 >        for (Integer v1 : new Integer[] { 1, null })
2297 >    {
2298          final CompletableFuture<Integer> f = new CompletableFuture<>();
2299          final CompletableFuture<Integer> g = new CompletableFuture<>();
2300 <        final Noop r = new Noop();
2300 >        final Noop r = new Noop(m);
2301          final CFException ex = new CFException();
2302  
2303          g.completeExceptionally(ex);
# Line 2561 | Line 2307 | public class CompletableFutureTest exten
2307          // unspecified behavior
2308          Integer v;
2309          try {
2310 <            assertEquals(h.join(), null);
2310 >            assertNull(h.join());
2311              assertEquals(1, r.invocationCount);
2312          } catch (CompletionException ok) {
2313              checkCompletedWithWrappedCFException(h, ex);
# Line 2570 | Line 2316 | public class CompletableFutureTest exten
2316  
2317          checkCompletedWithWrappedCFException(g, ex);
2318          checkCompletedNormally(f, v1);
2319 <        }
2574 <    }
2319 >    }}
2320  
2321      public void testRunAfterEither_exceptionalCompletion4() {
2322          for (ExecutionMode m : ExecutionMode.values())
2323 <        for (Integer v1 : new Integer[] { 1, null }) {
2324 <
2323 >        for (Integer v1 : new Integer[] { 1, null })
2324 >    {
2325          final CompletableFuture<Integer> f = new CompletableFuture<>();
2326          final CompletableFuture<Integer> g = new CompletableFuture<>();
2327 <        final Noop r = new Noop();
2327 >        final Noop r = new Noop(m);
2328          final CFException ex = new CFException();
2329  
2330          f.completeExceptionally(ex);
# Line 2589 | Line 2334 | public class CompletableFutureTest exten
2334          // unspecified behavior
2335          Integer v;
2336          try {
2337 <            assertEquals(h.join(), null);
2337 >            assertNull(h.join());
2338              assertEquals(1, r.invocationCount);
2339          } catch (CompletionException ok) {
2340              checkCompletedWithWrappedCFException(h, ex);
# Line 2598 | Line 2343 | public class CompletableFutureTest exten
2343  
2344          checkCompletedWithWrappedCFException(f, ex);
2345          checkCompletedNormally(g, v1);
2346 <        }
2602 <    }
2346 >    }}
2347  
2348      /**
2349       * runAfterEither result completes exceptionally if action does
# Line 2607 | Line 2351 | public class CompletableFutureTest exten
2351      public void testRunAfterEither_actionFailed1() {
2352          for (ExecutionMode m : ExecutionMode.values())
2353          for (Integer v1 : new Integer[] { 1, null })
2354 <        for (Integer v2 : new Integer[] { 2, null }) {
2355 <
2354 >        for (Integer v2 : new Integer[] { 2, null })
2355 >    {
2356          final CompletableFuture<Integer> f = new CompletableFuture<>();
2357          final CompletableFuture<Integer> g = new CompletableFuture<>();
2358 <        final FailingNoop r = new FailingNoop();
2358 >        final FailingRunnable r = new FailingRunnable(m);
2359          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2360  
2361          f.complete(v1);
# Line 2619 | Line 2363 | public class CompletableFutureTest exten
2363          g.complete(v2);
2364          checkCompletedNormally(f, v1);
2365          checkCompletedNormally(g, v2);
2366 <        }
2623 <    }
2366 >    }}
2367  
2368      public void testRunAfterEither_actionFailed2() {
2369          for (ExecutionMode m : ExecutionMode.values())
2370          for (Integer v1 : new Integer[] { 1, null })
2371 <        for (Integer v2 : new Integer[] { 2, null }) {
2372 <
2371 >        for (Integer v2 : new Integer[] { 2, null })
2372 >    {
2373          final CompletableFuture<Integer> f = new CompletableFuture<>();
2374          final CompletableFuture<Integer> g = new CompletableFuture<>();
2375 <        final FailingNoop r = new FailingNoop();
2375 >        final FailingRunnable r = new FailingRunnable(m);
2376          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2377  
2378          g.complete(v2);
# Line 2637 | Line 2380 | public class CompletableFutureTest exten
2380          f.complete(v1);
2381          checkCompletedNormally(f, v1);
2382          checkCompletedNormally(g, v2);
2383 <        }
2641 <    }
2383 >    }}
2384  
2385      /**
2386       * runAfterEither result completes exceptionally if either source cancelled
# Line 2646 | Line 2388 | public class CompletableFutureTest exten
2388      public void testRunAfterEither_sourceCancelled1() {
2389          for (ExecutionMode m : ExecutionMode.values())
2390          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2391 <        for (Integer v1 : new Integer[] { 1, null }) {
2392 <
2391 >        for (Integer v1 : new Integer[] { 1, null })
2392 >    {
2393          final CompletableFuture<Integer> f = new CompletableFuture<>();
2394          final CompletableFuture<Integer> g = new CompletableFuture<>();
2395 <        final Noop r = new Noop();
2395 >        final Noop r = new Noop(m);
2396          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2397  
2398          assertTrue(f.cancel(mayInterruptIfRunning));
# Line 2661 | Line 2403 | public class CompletableFutureTest exten
2403          assertEquals(0, r.invocationCount);
2404          checkCompletedNormally(g, v1);
2405          checkCompletedWithWrappedCancellationException(h);
2406 <        }
2665 <    }
2406 >    }}
2407  
2408      public void testRunAfterEither_sourceCancelled2() {
2409          for (ExecutionMode m : ExecutionMode.values())
2410          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2411 <        for (Integer v1 : new Integer[] { 1, null }) {
2412 <
2411 >        for (Integer v1 : new Integer[] { 1, null })
2412 >    {
2413          final CompletableFuture<Integer> f = new CompletableFuture<>();
2414          final CompletableFuture<Integer> g = new CompletableFuture<>();
2415 <        final Noop r = new Noop();
2415 >        final Noop r = new Noop(m);
2416          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2417  
2418          assertTrue(g.cancel(mayInterruptIfRunning));
# Line 2682 | Line 2423 | public class CompletableFutureTest exten
2423          assertEquals(0, r.invocationCount);
2424          checkCompletedNormally(f, v1);
2425          checkCompletedWithWrappedCancellationException(h);
2426 <        }
2686 <    }
2426 >    }}
2427  
2428      public void testRunAfterEither_sourceCancelled3() {
2429          for (ExecutionMode m : ExecutionMode.values())
2430          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2431 <        for (Integer v1 : new Integer[] { 1, null }) {
2432 <
2431 >        for (Integer v1 : new Integer[] { 1, null })
2432 >    {
2433          final CompletableFuture<Integer> f = new CompletableFuture<>();
2434          final CompletableFuture<Integer> g = new CompletableFuture<>();
2435 <        final Noop r = new Noop();
2435 >        final Noop r = new Noop(m);
2436  
2437          assertTrue(g.cancel(mayInterruptIfRunning));
2438          f.complete(v1);
# Line 2701 | Line 2441 | public class CompletableFutureTest exten
2441          // unspecified behavior
2442          Integer v;
2443          try {
2444 <            assertEquals(h.join(), null);
2444 >            assertNull(h.join());
2445              assertEquals(1, r.invocationCount);
2446          } catch (CompletionException ok) {
2447              checkCompletedWithWrappedCancellationException(h);
# Line 2710 | Line 2450 | public class CompletableFutureTest exten
2450  
2451          checkCancelled(g);
2452          checkCompletedNormally(f, v1);
2453 <        }
2714 <    }
2453 >    }}
2454  
2455      public void testRunAfterEither_sourceCancelled4() {
2456          for (ExecutionMode m : ExecutionMode.values())
2457          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2458 <        for (Integer v1 : new Integer[] { 1, null }) {
2459 <
2458 >        for (Integer v1 : new Integer[] { 1, null })
2459 >    {
2460          final CompletableFuture<Integer> f = new CompletableFuture<>();
2461          final CompletableFuture<Integer> g = new CompletableFuture<>();
2462 <        final Noop r = new Noop();
2462 >        final Noop r = new Noop(m);
2463  
2464          assertTrue(f.cancel(mayInterruptIfRunning));
2465          g.complete(v1);
# Line 2729 | Line 2468 | public class CompletableFutureTest exten
2468          // unspecified behavior
2469          Integer v;
2470          try {
2471 <            assertEquals(h.join(), null);
2471 >            assertNull(h.join());
2472              assertEquals(1, r.invocationCount);
2473          } catch (CompletionException ok) {
2474              checkCompletedWithWrappedCancellationException(h);
# Line 2738 | Line 2477 | public class CompletableFutureTest exten
2477  
2478          checkCancelled(f);
2479          checkCompletedNormally(g, v1);
2480 <        }
2742 <    }
2480 >    }}
2481  
2482      /**
2483       * thenCompose result completes normally after normal completion of source
2484       */
2485 <    public void testThenCompose_normalCompletion1() {
2485 >    public void testThenCompose_normalCompletion() {
2486          for (ExecutionMode m : ExecutionMode.values())
2487 <        for (Integer v1 : new Integer[] { 1, null }) {
2488 <
2487 >        for (boolean createIncomplete : new boolean[] { true, false })
2488 >        for (Integer v1 : new Integer[] { 1, null })
2489 >    {
2490          final CompletableFuture<Integer> f = new CompletableFuture<>();
2491 <        final CompletableFutureInc r = new CompletableFutureInc();
2492 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2493 <        f.complete(v1);
2494 <        checkCompletedNormally(g, inc(v1));
2756 <        checkCompletedNormally(f, v1);
2757 <        assertEquals(1, r.invocationCount);
2758 <        }
2759 <    }
2760 <
2761 <    public void testThenCompose_normalCompletion2() {
2762 <        for (ExecutionMode m : ExecutionMode.values())
2763 <        for (Integer v1 : new Integer[] { 1, null }) {
2491 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2492 >        if (!createIncomplete) f.complete(v1);
2493 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2494 >        if (createIncomplete) f.complete(v1);
2495  
2765        final CompletableFuture<Integer> f = new CompletableFuture<>();
2766        final CompletableFutureInc r = new CompletableFutureInc();
2767        f.complete(v1);
2768        final CompletableFuture<Integer> g = f.thenCompose(r);
2496          checkCompletedNormally(g, inc(v1));
2497          checkCompletedNormally(f, v1);
2498          assertEquals(1, r.invocationCount);
2499 <        }
2773 <    }
2499 >    }}
2500  
2501      /**
2502       * thenCompose result completes exceptionally after exceptional
2503       * completion of source
2504       */
2505 <    public void testThenCompose_exceptionalCompletion1() {
2506 <        for (ExecutionMode m : ExecutionMode.values()) {
2507 <
2505 >    public void testThenCompose_exceptionalCompletion() {
2506 >        for (ExecutionMode m : ExecutionMode.values())
2507 >        for (boolean createIncomplete : new boolean[] { true, false })
2508 >    {
2509          final CFException ex = new CFException();
2510 <        final CompletableFutureInc r = new CompletableFutureInc();
2510 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2511          final CompletableFuture<Integer> f = new CompletableFuture<>();
2512 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2513 <        f.completeExceptionally(ex);
2514 <        checkCompletedWithWrappedCFException(g, ex);
2788 <        checkCompletedWithWrappedCFException(f, ex);
2789 <        }
2790 <    }
2791 <
2792 <    public void testThenCompose_exceptionalCompletion2() {
2793 <        for (ExecutionMode m : ExecutionMode.values()) {
2512 >        if (!createIncomplete) f.completeExceptionally(ex);
2513 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2514 >        if (createIncomplete) f.completeExceptionally(ex);
2515  
2795        final CFException ex = new CFException();
2796        final CompletableFuture<Integer> f = new CompletableFuture<>();
2797        f.completeExceptionally(ex);
2798        final CompletableFutureInc r = new CompletableFutureInc();
2799        final CompletableFuture<Integer> g = f.thenCompose(r);
2516          checkCompletedWithWrappedCFException(g, ex);
2517          checkCompletedWithWrappedCFException(f, ex);
2518 <        }
2519 <    }
2518 >        assertEquals(0, r.invocationCount);
2519 >    }}
2520  
2521      /**
2522       * thenCompose result completes exceptionally if action does
2523       */
2524 <    public void testThenCompose_actionFailed1() {
2524 >    public void testThenCompose_actionFailed() {
2525          for (ExecutionMode m : ExecutionMode.values())
2526 <        for (Integer v1 : new Integer[] { 1, null }) {
2527 <
2526 >        for (boolean createIncomplete : new boolean[] { true, false })
2527 >        for (Integer v1 : new Integer[] { 1, null })
2528 >    {
2529          final CompletableFuture<Integer> f = new CompletableFuture<>();
2530          final FailingCompletableFutureFunction r
2531 <            = new FailingCompletableFutureFunction();
2532 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2533 <        f.complete(v1);
2534 <        checkCompletedWithWrappedCFException(g);
2818 <        checkCompletedNormally(f, v1);
2819 <        }
2820 <    }
2821 <
2822 <    public void testThenCompose_actionFailed2() {
2823 <        for (ExecutionMode m : ExecutionMode.values())
2824 <        for (Integer v1 : new Integer[] { 1, null }) {
2531 >            = new FailingCompletableFutureFunction(m);
2532 >        if (!createIncomplete) f.complete(v1);
2533 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2534 >        if (createIncomplete) f.complete(v1);
2535  
2826        final CompletableFuture<Integer> f = new CompletableFuture<>();
2827        f.complete(v1);
2828        final FailingCompletableFutureFunction r
2829            = new FailingCompletableFutureFunction();
2830        final CompletableFuture<Integer> g = f.thenCompose(r);
2536          checkCompletedWithWrappedCFException(g);
2537          checkCompletedNormally(f, v1);
2538 <        }
2834 <    }
2538 >    }}
2539  
2540      /**
2541       * thenCompose result completes exceptionally if source cancelled
2542       */
2543 <    public void testThenCompose_sourceCancelled1() {
2543 >    public void testThenCompose_sourceCancelled() {
2544          for (ExecutionMode m : ExecutionMode.values())
2545 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
2546 <
2545 >        for (boolean createIncomplete : new boolean[] { true, false })
2546 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2547 >    {
2548          final CompletableFuture<Integer> f = new CompletableFuture<>();
2549 <        final CompletableFutureInc r = new CompletableFutureInc();
2550 <        final CompletableFuture<Integer> g = f.thenCompose(r);
2551 <        assertTrue(f.cancel(mayInterruptIfRunning));
2552 <        checkCompletedWithWrappedCancellationException(g);
2553 <        checkCancelled(f);
2549 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2550 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2551 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2552 >        if (createIncomplete) {
2553 >            checkIncomplete(g);
2554 >            assertTrue(f.cancel(mayInterruptIfRunning));
2555          }
2850    }
2556  
2852    public void testThenCompose_sourceCancelled2() {
2853        for (ExecutionMode m : ExecutionMode.values())
2854        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
2855
2856        final CompletableFuture<Integer> f = new CompletableFuture<>();
2857        assertTrue(f.cancel(mayInterruptIfRunning));
2858        final CompletableFutureInc r = new CompletableFutureInc();
2859        final CompletableFuture<Integer> g = f.thenCompose(r);
2557          checkCompletedWithWrappedCancellationException(g);
2558          checkCancelled(f);
2559 <        }
2863 <    }
2864 <
2865 <    // asyncs
2866 <
2867 <    /**
2868 <     * thenRunAsync result completes normally after normal completion of source
2869 <     */
2870 <    public void testThenRunAsync() {
2871 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2872 <        Noop r = new Noop();
2873 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2874 <        f.complete(null);
2875 <        checkCompletedNormally(g, null);
2876 <
2877 <        // reordered version
2878 <        f = new CompletableFuture<>();
2879 <        f.complete(null);
2880 <        r = new Noop();
2881 <        g = f.thenRunAsync(r);
2882 <        checkCompletedNormally(g, null);
2883 <    }
2884 <
2885 <    /**
2886 <     * thenRunAsync result completes exceptionally after exceptional
2887 <     * completion of source
2888 <     */
2889 <    public void testThenRunAsync2() {
2890 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2891 <        Noop r = new Noop();
2892 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2893 <        f.completeExceptionally(new CFException());
2894 <        try {
2895 <            g.join();
2896 <            shouldThrow();
2897 <        } catch (CompletionException success) {}
2898 <        checkCompletedWithWrappedCFException(g);
2899 <    }
2900 <
2901 <    /**
2902 <     * thenRunAsync result completes exceptionally if action does
2903 <     */
2904 <    public void testThenRunAsync3() {
2905 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2906 <        FailingNoop r = new FailingNoop();
2907 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2908 <        f.complete(null);
2909 <        checkCompletedWithWrappedCFException(g);
2910 <    }
2911 <
2912 <    /**
2913 <     * thenRunAsync result completes exceptionally if source cancelled
2914 <     */
2915 <    public void testThenRunAsync4() {
2916 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2917 <        Noop r = new Noop();
2918 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2919 <        assertTrue(f.cancel(true));
2920 <        checkCompletedWithWrappedCancellationException(g);
2921 <    }
2922 <
2923 <    /**
2924 <     * thenApplyAsync result completes normally after normal completion of source
2925 <     */
2926 <    public void testThenApplyAsync() {
2927 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2928 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2929 <        f.complete(one);
2930 <        checkCompletedNormally(g, two);
2931 <    }
2932 <
2933 <    /**
2934 <     * thenApplyAsync result completes exceptionally after exceptional
2935 <     * completion of source
2936 <     */
2937 <    public void testThenApplyAsync2() {
2938 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2939 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2940 <        f.completeExceptionally(new CFException());
2941 <        checkCompletedWithWrappedCFException(g);
2942 <    }
2943 <
2944 <    /**
2945 <     * thenApplyAsync result completes exceptionally if action does
2946 <     */
2947 <    public void testThenApplyAsync3() {
2948 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2949 <        FailingFunction r = new FailingFunction();
2950 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
2951 <        f.complete(null);
2952 <        checkCompletedWithWrappedCFException(g);
2953 <    }
2954 <
2955 <    /**
2956 <     * thenApplyAsync result completes exceptionally if source cancelled
2957 <     */
2958 <    public void testThenApplyAsync4() {
2959 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2960 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2961 <        assertTrue(f.cancel(true));
2962 <        checkCompletedWithWrappedCancellationException(g);
2963 <    }
2964 <
2965 <    /**
2966 <     * thenAcceptAsync result completes normally after normal
2967 <     * completion of source
2968 <     */
2969 <    public void testThenAcceptAsync() {
2970 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2971 <        IncAction r = new IncAction();
2972 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2973 <        f.complete(one);
2974 <        checkCompletedNormally(g, null);
2975 <        assertEquals(r.value, (Integer) 2);
2976 <    }
2977 <
2978 <    /**
2979 <     * thenAcceptAsync result completes exceptionally after exceptional
2980 <     * completion of source
2981 <     */
2982 <    public void testThenAcceptAsync2() {
2983 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2984 <        IncAction r = new IncAction();
2985 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2986 <        f.completeExceptionally(new CFException());
2987 <        checkCompletedWithWrappedCFException(g);
2988 <    }
2989 <
2990 <    /**
2991 <     * thenAcceptAsync result completes exceptionally if action does
2992 <     */
2993 <    public void testThenAcceptAsync3() {
2994 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2995 <        FailingConsumer r = new FailingConsumer();
2996 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2997 <        f.complete(null);
2998 <        checkCompletedWithWrappedCFException(g);
2999 <    }
3000 <
3001 <    /**
3002 <     * thenAcceptAsync result completes exceptionally if source cancelled
3003 <     */
3004 <    public void testThenAcceptAsync4() {
3005 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3006 <        IncAction r = new IncAction();
3007 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
3008 <        assertTrue(f.cancel(true));
3009 <        checkCompletedWithWrappedCancellationException(g);
3010 <    }
3011 <
3012 <    // async with explicit executors
3013 <
3014 <    /**
3015 <     * thenRunAsync result completes normally after normal completion of source
3016 <     */
3017 <    public void testThenRunAsyncE() {
3018 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3019 <        Noop r = new Noop();
3020 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3021 <        f.complete(null);
3022 <        checkCompletedNormally(g, null);
3023 <
3024 <        // reordered version
3025 <        f = new CompletableFuture<>();
3026 <        f.complete(null);
3027 <        r = new Noop();
3028 <        g = f.thenRunAsync(r, new ThreadExecutor());
3029 <        checkCompletedNormally(g, null);
3030 <    }
3031 <
3032 <    /**
3033 <     * thenRunAsync result completes exceptionally after exceptional
3034 <     * completion of source
3035 <     */
3036 <    public void testThenRunAsync2E() {
3037 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3038 <        Noop r = new Noop();
3039 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3040 <        f.completeExceptionally(new CFException());
3041 <        try {
3042 <            g.join();
3043 <            shouldThrow();
3044 <        } catch (CompletionException success) {}
3045 <        checkCompletedWithWrappedCFException(g);
3046 <    }
3047 <
3048 <    /**
3049 <     * thenRunAsync result completes exceptionally if action does
3050 <     */
3051 <    public void testThenRunAsync3E() {
3052 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3053 <        FailingNoop r = new FailingNoop();
3054 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3055 <        f.complete(null);
3056 <        checkCompletedWithWrappedCFException(g);
3057 <    }
3058 <
3059 <    /**
3060 <     * thenRunAsync result completes exceptionally if source cancelled
3061 <     */
3062 <    public void testThenRunAsync4E() {
3063 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3064 <        Noop r = new Noop();
3065 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3066 <        assertTrue(f.cancel(true));
3067 <        checkCompletedWithWrappedCancellationException(g);
3068 <    }
3069 <
3070 <    /**
3071 <     * thenApplyAsync result completes normally after normal completion of source
3072 <     */
3073 <    public void testThenApplyAsyncE() {
3074 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3075 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3076 <        f.complete(one);
3077 <        checkCompletedNormally(g, two);
3078 <    }
3079 <
3080 <    /**
3081 <     * thenApplyAsync result completes exceptionally after exceptional
3082 <     * completion of source
3083 <     */
3084 <    public void testThenApplyAsync2E() {
3085 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3086 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3087 <        f.completeExceptionally(new CFException());
3088 <        checkCompletedWithWrappedCFException(g);
3089 <    }
3090 <
3091 <    /**
3092 <     * thenApplyAsync result completes exceptionally if action does
3093 <     */
3094 <    public void testThenApplyAsync3E() {
3095 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3096 <        FailingFunction r = new FailingFunction();
3097 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
3098 <        f.complete(null);
3099 <        checkCompletedWithWrappedCFException(g);
3100 <    }
3101 <
3102 <    /**
3103 <     * thenApplyAsync result completes exceptionally if source cancelled
3104 <     */
3105 <    public void testThenApplyAsync4E() {
3106 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3107 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3108 <        assertTrue(f.cancel(true));
3109 <        checkCompletedWithWrappedCancellationException(g);
3110 <    }
3111 <
3112 <    /**
3113 <     * thenAcceptAsync result completes normally after normal
3114 <     * completion of source
3115 <     */
3116 <    public void testThenAcceptAsyncE() {
3117 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3118 <        IncAction r = new IncAction();
3119 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3120 <        f.complete(one);
3121 <        checkCompletedNormally(g, null);
3122 <        assertEquals(r.value, (Integer) 2);
3123 <    }
3124 <
3125 <    /**
3126 <     * thenAcceptAsync result completes exceptionally after exceptional
3127 <     * completion of source
3128 <     */
3129 <    public void testThenAcceptAsync2E() {
3130 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3131 <        IncAction r = new IncAction();
3132 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3133 <        f.completeExceptionally(new CFException());
3134 <        checkCompletedWithWrappedCFException(g);
3135 <    }
3136 <
3137 <    /**
3138 <     * thenAcceptAsync result completes exceptionally if action does
3139 <     */
3140 <    public void testThenAcceptAsync3E() {
3141 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3142 <        FailingConsumer r = new FailingConsumer();
3143 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3144 <        f.complete(null);
3145 <        checkCompletedWithWrappedCFException(g);
3146 <    }
3147 <
3148 <    /**
3149 <     * thenAcceptAsync result completes exceptionally if source cancelled
3150 <     */
3151 <    public void testThenAcceptAsync4E() {
3152 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3153 <        IncAction r = new IncAction();
3154 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3155 <        assertTrue(f.cancel(true));
3156 <        checkCompletedWithWrappedCancellationException(g);
3157 <    }
2559 >    }}
2560  
2561      // other static methods
2562  
# Line 3318 | Line 2720 | public class CompletableFutureTest exten
2720  
2721              () -> f.thenCompose(null),
2722              () -> f.thenComposeAsync(null),
2723 <            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
2723 >            () -> f.thenComposeAsync(new CompletableFutureInc(ExecutionMode.EXECUTOR), null),
2724              () -> f.thenComposeAsync(null, exec),
2725  
2726              () -> f.exceptionally(null),
# Line 3355 | Line 2757 | public class CompletableFutureTest exten
2757       * source result.
2758       */
2759      public void testWhenComplete_normalCompletion1() {
3358        for (boolean createIncomplete : new boolean[] { true, false })
2760          for (ExecutionMode m : ExecutionMode.values())
2761 <        for (Integer v1 : new Integer[] { 1, null }) {
2762 <
2763 <        final AtomicInteger a = new AtomicInteger();
2761 >        for (boolean createIncomplete : new boolean[] { true, false })
2762 >        for (Integer v1 : new Integer[] { 1, null })
2763 >    {
2764 >        final AtomicInteger a = new AtomicInteger(0);
2765          final CompletableFuture<Integer> f = new CompletableFuture<>();
2766          if (!createIncomplete) f.complete(v1);
2767 <        final CompletableFuture<Integer> g =
2768 <            m.whenComplete(f,
2769 <                           (Integer x, Throwable t) -> {
2770 <                               threadAssertSame(x, v1);
2771 <                               threadAssertNull(t);
2772 <                               a.getAndIncrement();
2773 <                           });
2767 >        final CompletableFuture<Integer> g = m.whenComplete
2768 >            (f,
2769 >             (Integer x, Throwable t) -> {
2770 >                threadAssertSame(x, v1);
2771 >                threadAssertNull(t);
2772 >                a.getAndIncrement();
2773 >            });
2774          if (createIncomplete) f.complete(v1);
2775 <        checkCompletedNormally(f, v1);
2775 >
2776          checkCompletedNormally(g, v1);
2777 <        assertEquals(a.get(), 1);
2778 <        }
2779 <    }
2777 >        checkCompletedNormally(f, v1);
2778 >        assertEquals(1, a.get());
2779 >    }}
2780  
2781      /**
2782       * whenComplete action executes on exceptional completion, propagating
2783       * source result.
2784       */
2785      public void testWhenComplete_exceptionalCompletion() {
3384        for (boolean createIncomplete : new boolean[] { true, false })
2786          for (ExecutionMode m : ExecutionMode.values())
2787 <        for (Integer v1 : new Integer[] { 1, null }) {
2788 <
2789 <        final AtomicInteger a = new AtomicInteger();
2787 >        for (boolean createIncomplete : new boolean[] { true, false })
2788 >        for (Integer v1 : new Integer[] { 1, null })
2789 >    {
2790 >        final AtomicInteger a = new AtomicInteger(0);
2791          final CFException ex = new CFException();
2792          final CompletableFuture<Integer> f = new CompletableFuture<>();
2793          if (!createIncomplete) f.completeExceptionally(ex);
# Line 3399 | Line 2801 | public class CompletableFutureTest exten
2801          if (createIncomplete) f.completeExceptionally(ex);
2802          checkCompletedWithWrappedCFException(f, ex);
2803          checkCompletedWithWrappedCFException(g, ex);
2804 <        assertEquals(a.get(), 1);
2805 <        }
2806 <    }
2804 >        assertEquals(1, a.get());
2805 >    }}
2806 >
2807 >    /**
2808 >     * whenComplete action executes on cancelled source, propagating
2809 >     * CancellationException.
2810 >     */
2811 >    public void testWhenComplete_sourceCancelled() {
2812 >        for (ExecutionMode m : ExecutionMode.values())
2813 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2814 >        for (boolean createIncomplete : new boolean[] { true, false })
2815 >    {
2816 >        final AtomicInteger a = new AtomicInteger(0);
2817 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2818 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2819 >        final CompletableFuture<Integer> g = m.whenComplete
2820 >            (f,
2821 >             (Integer x, Throwable t) -> {
2822 >                threadAssertNull(x);
2823 >                threadAssertTrue(t instanceof CancellationException);
2824 >                a.getAndIncrement();
2825 >            });
2826 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2827 >
2828 >        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2829 >        checkCompletedWithWrappedCancellationException(g);
2830 >        checkCancelled(f);
2831 >        assertEquals(1, a.get());
2832 >    }}
2833  
2834      /**
2835       * If a whenComplete action throws an exception when triggered by
# Line 3410 | Line 2838 | public class CompletableFutureTest exten
2838      public void testWhenComplete_actionFailed() {
2839          for (boolean createIncomplete : new boolean[] { true, false })
2840          for (ExecutionMode m : ExecutionMode.values())
2841 <        for (Integer v1 : new Integer[] { 1, null }) {
2842 <
2841 >        for (Integer v1 : new Integer[] { 1, null })
2842 >    {
2843 >        final AtomicInteger a = new AtomicInteger(0);
2844          final CFException ex = new CFException();
2845          final CompletableFuture<Integer> f = new CompletableFuture<>();
2846          if (!createIncomplete) f.complete(v1);
# Line 3420 | Line 2849 | public class CompletableFutureTest exten
2849               (Integer x, Throwable t) -> {
2850                  threadAssertSame(x, v1);
2851                  threadAssertNull(t);
2852 +                a.getAndIncrement();
2853                  throw ex;
2854              });
2855          if (createIncomplete) f.complete(v1);
2856          checkCompletedNormally(f, v1);
2857          checkCompletedWithWrappedCFException(g, ex);
2858 <        }
2859 <    }
2858 >        assertEquals(1, a.get());
2859 >    }}
2860  
2861      /**
2862       * If a whenComplete action throws an exception when triggered by
# Line 3436 | Line 2866 | public class CompletableFutureTest exten
2866      public void testWhenComplete_actionFailedSourceFailed() {
2867          for (boolean createIncomplete : new boolean[] { true, false })
2868          for (ExecutionMode m : ExecutionMode.values())
2869 <        for (Integer v1 : new Integer[] { 1, null }) {
2870 <
2869 >        for (Integer v1 : new Integer[] { 1, null })
2870 >    {
2871 >        final AtomicInteger a = new AtomicInteger(0);
2872          final CFException ex1 = new CFException();
2873          final CFException ex2 = new CFException();
2874          final CompletableFuture<Integer> f = new CompletableFuture<>();
# Line 3448 | Line 2879 | public class CompletableFutureTest exten
2879               (Integer x, Throwable t) -> {
2880                  threadAssertSame(t, ex1);
2881                  threadAssertNull(x);
2882 +                a.getAndIncrement();
2883                  throw ex2;
2884              });
2885          if (createIncomplete) f.completeExceptionally(ex1);
2886  
2887          checkCompletedWithWrappedCFException(f, ex1);
2888          checkCompletedWithWrappedCFException(g, ex1);
2889 <        }
2890 <    }
3459 <
3460 <    /**
3461 <     * handleAsync action completes normally with function value on
3462 <     * either normal or exceptional completion of source
3463 <     */
3464 <    public void testHandleAsync() {
3465 <        CompletableFuture<Integer> f, g;
3466 <        IntegerHandler r;
3467 <
3468 <        f = new CompletableFuture<>();
3469 <        g = f.handleAsync(r = new IntegerHandler());
3470 <        assertEquals(0, r.invocationCount);
3471 <        f.completeExceptionally(new CFException());
3472 <        checkCompletedWithWrappedCFException(f);
3473 <        checkCompletedNormally(g, three);
3474 <        assertEquals(1, r.invocationCount);
3475 <
3476 <        f = new CompletableFuture<>();
3477 <        g = f.handleAsync(r = new IntegerHandler());
3478 <        assertEquals(0, r.invocationCount);
3479 <        f.completeExceptionally(new CFException());
3480 <        checkCompletedWithWrappedCFException(f);
3481 <        checkCompletedNormally(g, three);
3482 <        assertEquals(1, r.invocationCount);
3483 <
3484 <        f = new CompletableFuture<>();
3485 <        g = f.handleAsync(r = new IntegerHandler());
3486 <        assertEquals(0, r.invocationCount);
3487 <        f.complete(one);
3488 <        checkCompletedNormally(f, one);
3489 <        checkCompletedNormally(g, two);
3490 <        assertEquals(1, r.invocationCount);
3491 <
3492 <        f = new CompletableFuture<>();
3493 <        g = f.handleAsync(r = new IntegerHandler());
3494 <        assertEquals(0, r.invocationCount);
3495 <        f.complete(one);
3496 <        checkCompletedNormally(f, one);
3497 <        checkCompletedNormally(g, two);
3498 <        assertEquals(1, r.invocationCount);
3499 <    }
3500 <
3501 <    /**
3502 <     * handleAsync action with Executor completes normally with
3503 <     * function value on either normal or exceptional completion of
3504 <     * source
3505 <     */
3506 <    public void testHandleAsync2() {
3507 <        CompletableFuture<Integer> f, g;
3508 <        ThreadExecutor exec = new ThreadExecutor();
3509 <        IntegerHandler r;
3510 <
3511 <        f = new CompletableFuture<>();
3512 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3513 <        assertEquals(0, r.invocationCount);
3514 <        f.completeExceptionally(new CFException());
3515 <        checkCompletedWithWrappedCFException(f);
3516 <        checkCompletedNormally(g, three);
3517 <        assertEquals(1, r.invocationCount);
3518 <
3519 <        f = new CompletableFuture<>();
3520 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3521 <        assertEquals(0, r.invocationCount);
3522 <        f.completeExceptionally(new CFException());
3523 <        checkCompletedWithWrappedCFException(f);
3524 <        checkCompletedNormally(g, three);
3525 <        assertEquals(1, r.invocationCount);
3526 <
3527 <        f = new CompletableFuture<>();
3528 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3529 <        assertEquals(0, r.invocationCount);
3530 <        f.complete(one);
3531 <        checkCompletedNormally(f, one);
3532 <        checkCompletedNormally(g, two);
3533 <        assertEquals(1, r.invocationCount);
3534 <
3535 <        f = new CompletableFuture<>();
3536 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3537 <        assertEquals(0, r.invocationCount);
3538 <        f.complete(one);
3539 <        checkCompletedNormally(f, one);
3540 <        checkCompletedNormally(g, two);
3541 <        assertEquals(1, r.invocationCount);
3542 <    }
2889 >        assertEquals(1, a.get());
2890 >    }}
2891  
2892   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines