ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.56 by jsr166, Mon Jun 2 22:20:32 2014 UTC vs.
Revision 1.76 by jsr166, Sat Jun 7 21:45:13 2014 UTC

# Line 105 | Line 105 | public class CompletableFutureTest exten
105          assertTrue(f.toString().contains("[Completed exceptionally]"));
106      }
107  
108 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
109 <                                              CFException ex) {
108 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
109 >                                                      Throwable ex) {
110          try {
111              f.get(LONG_DELAY_MS, MILLISECONDS);
112              shouldThrow();
# Line 131 | Line 131 | public class CompletableFutureTest exten
131          } catch (ExecutionException success) {
132              assertSame(ex, success.getCause());
133          } catch (Throwable fail) { threadUnexpectedException(fail); }
134 +
135          assertTrue(f.isDone());
136          assertFalse(f.isCancelled());
137          assertTrue(f.toString().contains("[Completed exceptionally]"));
138      }
139  
140 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
141 +                                                Throwable ex) {
142 +        checkCompletedExceptionallyWithRootCause(f, ex);
143 +        try {
144 +            CompletableFuture<Throwable> spy = f.handle
145 +                ((U u, Throwable t) -> t);
146 +            assertTrue(spy.join() instanceof CompletionException);
147 +            assertSame(ex, spy.join().getCause());
148 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
149 +    }
150 +
151 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
152 +        checkCompletedExceptionallyWithRootCause(f, ex);
153 +        try {
154 +            CompletableFuture<Throwable> spy = f.handle
155 +                ((U u, Throwable t) -> t);
156 +            assertSame(ex, spy.join());
157 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
158 +    }
159 +
160      void checkCancelled(CompletableFuture<?> f) {
161          try {
162              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 218 | Line 239 | public class CompletableFutureTest exten
239       */
240      public void testCompleteExceptionally() {
241          CompletableFuture<Integer> f = new CompletableFuture<>();
242 +        CFException ex = new CFException();
243          checkIncomplete(f);
244 <        f.completeExceptionally(new CFException());
245 <        checkCompletedWithWrappedCFException(f);
244 >        f.completeExceptionally(ex);
245 >        checkCompletedExceptionally(f, ex);
246      }
247  
248      /**
# Line 261 | Line 283 | public class CompletableFutureTest exten
283       * obtrudeException forces completion with given exception
284       */
285      public void testObtrudeException() {
286 <        CompletableFuture<Integer> f = new CompletableFuture<>();
287 <        checkIncomplete(f);
288 <        f.complete(one);
289 <        checkCompletedNormally(f, one);
290 <        f.obtrudeException(new CFException());
269 <        checkCompletedWithWrappedCFException(f);
286 >        for (Integer v1 : new Integer[] { 1, null })
287 >    {
288 >        CFException ex;
289 >        CompletableFuture<Integer> f;
290 >
291          f = new CompletableFuture<>();
292 <        f.obtrudeException(new CFException());
293 <        checkCompletedWithWrappedCFException(f);
292 >        f.complete(v1);
293 >        for (int i = 0; i < 2; i++) {
294 >            f.obtrudeException(ex = new CFException());
295 >            checkCompletedExceptionally(f, ex);
296 >        }
297 >
298          f = new CompletableFuture<>();
299 +        for (int i = 0; i < 2; i++) {
300 +            f.obtrudeException(ex = new CFException());
301 +            checkCompletedExceptionally(f, ex);
302 +        }
303 +
304 +        f = new CompletableFuture<>();
305 +        f.completeExceptionally(ex = new CFException());
306 +        f.obtrudeValue(v1);
307 +        checkCompletedNormally(f, v1);
308 +        f.obtrudeException(ex = new CFException());
309 +        checkCompletedExceptionally(f, ex);
310          f.completeExceptionally(new CFException());
311 <        f.obtrudeValue(four);
312 <        checkCompletedNormally(f, four);
313 <        f.obtrudeException(new CFException());
314 <        checkCompletedWithWrappedCFException(f);
279 <    }
311 >        checkCompletedExceptionally(f, ex);
312 >        f.complete(v1);
313 >        checkCompletedExceptionally(f, ex);
314 >    }}
315  
316      /**
317       * getNumberOfDependents returns number of dependent tasks
318       */
319      public void testGetNumberOfDependents() {
320 +        for (ExecutionMode m : ExecutionMode.values())
321 +    {
322          CompletableFuture<Integer> f = new CompletableFuture<>();
323          assertEquals(0, f.getNumberOfDependents());
324 <        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
324 >        final CompletableFuture<Void> g = m.thenRun(f, new Noop(m));
325          assertEquals(1, f.getNumberOfDependents());
326          assertEquals(0, g.getNumberOfDependents());
327 <        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
327 >        final CompletableFuture<Void> h = m.thenRun(f, new Noop(m));
328          assertEquals(2, f.getNumberOfDependents());
329 +        assertEquals(0, h.getNumberOfDependents());
330          f.complete(1);
331          checkCompletedNormally(g, null);
332 +        checkCompletedNormally(h, null);
333          assertEquals(0, f.getNumberOfDependents());
334          assertEquals(0, g.getNumberOfDependents());
335 <    }
335 >        assertEquals(0, h.getNumberOfDependents());
336 >    }}
337  
338      /**
339       * toString indicates current completion state
# Line 310 | Line 350 | public class CompletableFutureTest exten
350          f = new CompletableFuture<String>();
351          f.completeExceptionally(new IndexOutOfBoundsException());
352          assertTrue(f.toString().contains("[Completed exceptionally]"));
353 +
354 +        f = new CompletableFuture<String>();
355 +        f.cancel(true);
356 +        assertTrue(f.toString().contains("[Completed exceptionally]"));
357 +
358 +        f = new CompletableFuture<String>();
359 +        f.cancel(false);
360 +        assertTrue(f.toString().contains("[Completed exceptionally]"));
361      }
362  
363      /**
# Line 320 | Line 368 | public class CompletableFutureTest exten
368          checkCompletedNormally(f, "test");
369      }
370  
371 <    // Choose non-commutative actions for better coverage
371 >    abstract class CheckedAction {
372 >        int invocationCount = 0;
373 >        final ExecutionMode m;
374 >        CheckedAction(ExecutionMode m) { this.m = m; }
375 >        void invoked() {
376 >            m.checkExecutionMode();
377 >            assertEquals(0, invocationCount++);
378 >        }
379 >        void assertNotInvoked() { assertEquals(0, invocationCount); }
380 >        void assertInvoked() { assertEquals(1, invocationCount); }
381 >    }
382  
383 <    // A non-commutative function that handles and produces null values as well.
384 <    static Integer subtract(Integer x, Integer y) {
385 <        return (x == null && y == null) ? null :
386 <            ((x == null) ? 42 : x.intValue())
387 <            - ((y == null) ? 99 : y.intValue());
383 >    abstract class CheckedIntegerAction extends CheckedAction {
384 >        Integer value;
385 >        CheckedIntegerAction(ExecutionMode m) { super(m); }
386 >        void assertValue(Integer expected) {
387 >            assertInvoked();
388 >            assertEquals(expected, value);
389 >        }
390 >    }
391 >
392 >    class IntegerSupplier extends CheckedAction
393 >        implements Supplier<Integer>
394 >    {
395 >        final Integer value;
396 >        IntegerSupplier(ExecutionMode m, Integer value) {
397 >            super(m);
398 >            this.value = value;
399 >        }
400 >        public Integer get() {
401 >            invoked();
402 >            return value;
403 >        }
404      }
405  
406      // A function that handles and produces null values as well.
# Line 334 | Line 408 | public class CompletableFutureTest exten
408          return (x == null) ? null : x + 1;
409      }
410  
411 <    static final Supplier<Integer> supplyOne =
412 <        () -> Integer.valueOf(1);
413 <    static final Function<Integer, Integer> inc =
414 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
341 <    static final BiFunction<Integer, Integer, Integer> subtract =
342 <        (Integer x, Integer y) -> subtract(x, y);
343 <    static final class IncAction implements Consumer<Integer> {
344 <        int invocationCount = 0;
345 <        Integer value;
411 >    class NoopConsumer extends CheckedIntegerAction
412 >        implements Consumer<Integer>
413 >    {
414 >        NoopConsumer(ExecutionMode m) { super(m); }
415          public void accept(Integer x) {
416 <            invocationCount++;
417 <            value = inc(x);
416 >            invoked();
417 >            value = x;
418          }
419      }
420 <    static final class IncFunction implements Function<Integer,Integer> {
421 <        final ExecutionMode m;
422 <        int invocationCount = 0;
423 <        Integer value;
424 <        IncFunction(ExecutionMode m) { this.m = m; }
420 >
421 >    class IncFunction extends CheckedIntegerAction
422 >        implements Function<Integer,Integer>
423 >    {
424 >        IncFunction(ExecutionMode m) { super(m); }
425          public Integer apply(Integer x) {
426 <            m.checkExecutionMode();
358 <            invocationCount++;
426 >            invoked();
427              return value = inc(x);
428          }
429      }
430 <    static final class SubtractAction implements BiConsumer<Integer, Integer> {
431 <        final ExecutionMode m;
432 <        int invocationCount = 0;
433 <        Integer value;
434 <        // Check this action was invoked exactly once when result is computed.
435 <        SubtractAction(ExecutionMode m) { this.m = m; }
430 >
431 >    // Choose non-commutative actions for better coverage
432 >    // A non-commutative function that handles and produces null values as well.
433 >    static Integer subtract(Integer x, Integer y) {
434 >        return (x == null && y == null) ? null :
435 >            ((x == null) ? 42 : x.intValue())
436 >            - ((y == null) ? 99 : y.intValue());
437 >    }
438 >
439 >    class SubtractAction extends CheckedIntegerAction
440 >        implements BiConsumer<Integer, Integer>
441 >    {
442 >        SubtractAction(ExecutionMode m) { super(m); }
443          public void accept(Integer x, Integer y) {
444 <            m.checkExecutionMode();
370 <            invocationCount++;
444 >            invoked();
445              value = subtract(x, y);
446          }
447      }
448 <    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
449 <        final ExecutionMode m;
450 <        int invocationCount = 0;
451 <        Integer value;
452 <        // Check this action was invoked exactly once when result is computed.
379 <        SubtractFunction(ExecutionMode m) { this.m = m; }
448 >
449 >    class SubtractFunction extends CheckedIntegerAction
450 >        implements BiFunction<Integer, Integer, Integer>
451 >    {
452 >        SubtractFunction(ExecutionMode m) { super(m); }
453          public Integer apply(Integer x, Integer y) {
454 <            m.checkExecutionMode();
382 <            invocationCount++;
454 >            invoked();
455              return value = subtract(x, y);
456          }
457      }
458 <    static final class Noop implements Runnable {
459 <        final ExecutionMode m;
460 <        int invocationCount = 0;
389 <        Noop(ExecutionMode m) { this.m = m; }
458 >
459 >    class Noop extends CheckedAction implements Runnable {
460 >        Noop(ExecutionMode m) { super(m); }
461          public void run() {
462 <            m.checkExecutionMode();
392 <            invocationCount++;
462 >            invoked();
463          }
464      }
465  
466 <    static final class FailingSupplier implements Supplier<Integer> {
467 <        final ExecutionMode m;
468 <        int invocationCount = 0;
469 <        FailingSupplier(ExecutionMode m) { this.m = m; }
466 >    class FailingSupplier extends CheckedAction
467 >        implements Supplier<Integer>
468 >    {
469 >        FailingSupplier(ExecutionMode m) { super(m); }
470          public Integer get() {
471 <            m.checkExecutionMode();
402 <            invocationCount++;
471 >            invoked();
472              throw new CFException();
473          }
474      }
475 <    static final class FailingConsumer implements Consumer<Integer> {
476 <        final ExecutionMode m;
477 <        int invocationCount = 0;
478 <        FailingConsumer(ExecutionMode m) { this.m = m; }
475 >
476 >    class FailingConsumer extends CheckedIntegerAction
477 >        implements Consumer<Integer>
478 >    {
479 >        FailingConsumer(ExecutionMode m) { super(m); }
480          public void accept(Integer x) {
481 <            m.checkExecutionMode();
482 <            invocationCount++;
481 >            invoked();
482 >            value = x;
483              throw new CFException();
484          }
485      }
486 <    static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
487 <        final ExecutionMode m;
488 <        int invocationCount = 0;
489 <        FailingBiConsumer(ExecutionMode m) { this.m = m; }
486 >
487 >    class FailingBiConsumer extends CheckedIntegerAction
488 >        implements BiConsumer<Integer, Integer>
489 >    {
490 >        FailingBiConsumer(ExecutionMode m) { super(m); }
491          public void accept(Integer x, Integer y) {
492 <            m.checkExecutionMode();
493 <            invocationCount++;
492 >            invoked();
493 >            value = subtract(x, y);
494              throw new CFException();
495          }
496      }
497 <    static final class FailingFunction implements Function<Integer, Integer> {
498 <        final ExecutionMode m;
499 <        int invocationCount = 0;
500 <        FailingFunction(ExecutionMode m) { this.m = m; }
497 >
498 >    class FailingFunction extends CheckedIntegerAction
499 >        implements Function<Integer, Integer>
500 >    {
501 >        FailingFunction(ExecutionMode m) { super(m); }
502          public Integer apply(Integer x) {
503 <            m.checkExecutionMode();
504 <            invocationCount++;
503 >            invoked();
504 >            value = x;
505              throw new CFException();
506          }
507      }
508 <    static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
509 <        final ExecutionMode m;
510 <        int invocationCount = 0;
511 <        FailingBiFunction(ExecutionMode m) { this.m = m; }
508 >
509 >    class FailingBiFunction extends CheckedIntegerAction
510 >        implements BiFunction<Integer, Integer, Integer>
511 >    {
512 >        FailingBiFunction(ExecutionMode m) { super(m); }
513          public Integer apply(Integer x, Integer y) {
514 <            m.checkExecutionMode();
515 <            invocationCount++;
514 >            invoked();
515 >            value = subtract(x, y);
516              throw new CFException();
517          }
518      }
519 <    static final class FailingRunnable implements Runnable {
520 <        final ExecutionMode m;
521 <        int invocationCount = 0;
449 <        FailingRunnable(ExecutionMode m) { this.m = m; }
519 >
520 >    class FailingRunnable extends CheckedAction implements Runnable {
521 >        FailingRunnable(ExecutionMode m) { super(m); }
522          public void run() {
523 <            m.checkExecutionMode();
452 <            invocationCount++;
523 >            invoked();
524              throw new CFException();
525          }
526      }
527  
528 <    static final class CompletableFutureInc
529 <        implements Function<Integer, CompletableFuture<Integer>> {
530 <        final ExecutionMode m;
531 <        int invocationCount = 0;
532 <        CompletableFutureInc(ExecutionMode m) { this.m = m; }
528 >
529 >    class CompletableFutureInc extends CheckedIntegerAction
530 >        implements Function<Integer, CompletableFuture<Integer>>
531 >    {
532 >        CompletableFutureInc(ExecutionMode m) { super(m); }
533          public CompletableFuture<Integer> apply(Integer x) {
534 <            m.checkExecutionMode();
535 <            invocationCount++;
534 >            invoked();
535 >            value = x;
536              CompletableFuture<Integer> f = new CompletableFuture<>();
537              f.complete(inc(x));
538              return f;
539          }
540      }
541  
542 <    static final class FailingCompletableFutureFunction
543 <        implements Function<Integer, CompletableFuture<Integer>> {
544 <        final ExecutionMode m;
545 <        int invocationCount = 0;
475 <        FailingCompletableFutureFunction(ExecutionMode m) { this.m = m; }
542 >    class FailingCompletableFutureFunction extends CheckedIntegerAction
543 >        implements Function<Integer, CompletableFuture<Integer>>
544 >    {
545 >        FailingCompletableFutureFunction(ExecutionMode m) { super(m); }
546          public CompletableFuture<Integer> apply(Integer x) {
547 <            m.checkExecutionMode();
548 <            invocationCount++;
547 >            invoked();
548 >            value = x;
549              throw new CFException();
550          }
551      }
# Line 496 | Line 566 | public class CompletableFutureTest exten
566  
567      /**
568       * Permits the testing of parallel code for the 3 different
569 <     * execution modes without repeating all the testing code.
569 >     * execution modes without copy/pasting all the test methods.
570       */
571      enum ExecutionMode {
572          DEFAULT {
573              public void checkExecutionMode() {
574 +                assertFalse(ThreadExecutor.startedCurrentThread());
575                  assertNull(ForkJoinTask.getPool());
576              }
577 +            public CompletableFuture<Void> runAsync(Runnable a) {
578 +                throw new UnsupportedOperationException();
579 +            }
580 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
581 +                throw new UnsupportedOperationException();
582 +            }
583              public <T> CompletableFuture<Void> thenRun
584                  (CompletableFuture<T> f, Runnable a) {
585                  return f.thenRun(a);
# Line 571 | Line 648 | public class CompletableFutureTest exten
648                  assertSame(ForkJoinPool.commonPool(),
649                             ForkJoinTask.getPool());
650              }
651 +            public CompletableFuture<Void> runAsync(Runnable a) {
652 +                return CompletableFuture.runAsync(a);
653 +            }
654 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
655 +                return CompletableFuture.supplyAsync(a);
656 +            }
657              public <T> CompletableFuture<Void> thenRun
658                  (CompletableFuture<T> f, Runnable a) {
659                  return f.thenRunAsync(a);
# Line 638 | Line 721 | public class CompletableFutureTest exten
721              public void checkExecutionMode() {
722                  assertTrue(ThreadExecutor.startedCurrentThread());
723              }
724 +            public CompletableFuture<Void> runAsync(Runnable a) {
725 +                return CompletableFuture.runAsync(a, new ThreadExecutor());
726 +            }
727 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
728 +                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
729 +            }
730              public <T> CompletableFuture<Void> thenRun
731                  (CompletableFuture<T> f, Runnable a) {
732                  return f.thenRunAsync(a, new ThreadExecutor());
# Line 702 | Line 791 | public class CompletableFutureTest exten
791          };
792  
793          public abstract void checkExecutionMode();
794 +        public abstract CompletableFuture<Void> runAsync(Runnable a);
795 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
796          public abstract <T> CompletableFuture<Void> thenRun
797              (CompletableFuture<T> f, Runnable a);
798          public abstract <T> CompletableFuture<Void> thenAccept
# Line 765 | Line 856 | public class CompletableFutureTest exten
856          assertEquals(0, a.get());
857      }}
858  
768
859      /**
860       * exceptionally action completes with function value on source
861       * exception
# Line 780 | Line 870 | public class CompletableFutureTest exten
870          if (!createIncomplete) f.completeExceptionally(ex);
871          final CompletableFuture<Integer> g = f.exceptionally
872              ((Throwable t) -> {
873 +                ExecutionMode.DEFAULT.checkExecutionMode();
874                  threadAssertSame(t, ex);
875                  a.getAndIncrement();
876                  return v1;
# Line 801 | Line 892 | public class CompletableFutureTest exten
892          if (!createIncomplete) f.completeExceptionally(ex1);
893          final CompletableFuture<Integer> g = f.exceptionally
894              ((Throwable t) -> {
895 +                ExecutionMode.DEFAULT.checkExecutionMode();
896                  threadAssertSame(t, ex1);
897                  a.getAndIncrement();
898                  throw ex2;
899              });
900          if (createIncomplete) f.completeExceptionally(ex1);
901  
902 <        checkCompletedWithWrappedCFException(g, ex2);
902 >        checkCompletedWithWrappedException(g, ex2);
903 >        assertEquals(1, a.get());
904 >    }}
905 >
906 >    /**
907 >     * whenComplete action executes on normal completion, propagating
908 >     * source result.
909 >     */
910 >    public void testWhenComplete_normalCompletion1() {
911 >        for (ExecutionMode m : ExecutionMode.values())
912 >        for (boolean createIncomplete : new boolean[] { true, false })
913 >        for (Integer v1 : new Integer[] { 1, null })
914 >    {
915 >        final AtomicInteger a = new AtomicInteger(0);
916 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
917 >        if (!createIncomplete) f.complete(v1);
918 >        final CompletableFuture<Integer> g = m.whenComplete
919 >            (f,
920 >             (Integer x, Throwable t) -> {
921 >                m.checkExecutionMode();
922 >                threadAssertSame(x, v1);
923 >                threadAssertNull(t);
924 >                a.getAndIncrement();
925 >            });
926 >        if (createIncomplete) f.complete(v1);
927 >
928 >        checkCompletedNormally(g, v1);
929 >        checkCompletedNormally(f, v1);
930 >        assertEquals(1, a.get());
931 >    }}
932 >
933 >    /**
934 >     * whenComplete action executes on exceptional completion, propagating
935 >     * source result.
936 >     */
937 >    public void testWhenComplete_exceptionalCompletion() {
938 >        for (ExecutionMode m : ExecutionMode.values())
939 >        for (boolean createIncomplete : new boolean[] { true, false })
940 >        for (Integer v1 : new Integer[] { 1, null })
941 >    {
942 >        final AtomicInteger a = new AtomicInteger(0);
943 >        final CFException ex = new CFException();
944 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
945 >        if (!createIncomplete) f.completeExceptionally(ex);
946 >        final CompletableFuture<Integer> g = m.whenComplete
947 >            (f,
948 >             (Integer x, Throwable t) -> {
949 >                m.checkExecutionMode();
950 >                threadAssertNull(x);
951 >                threadAssertSame(t, ex);
952 >                a.getAndIncrement();
953 >            });
954 >        if (createIncomplete) f.completeExceptionally(ex);
955 >
956 >        checkCompletedWithWrappedException(g, ex);
957 >        checkCompletedExceptionally(f, ex);
958 >        assertEquals(1, a.get());
959 >    }}
960 >
961 >    /**
962 >     * whenComplete action executes on cancelled source, propagating
963 >     * CancellationException.
964 >     */
965 >    public void testWhenComplete_sourceCancelled() {
966 >        for (ExecutionMode m : ExecutionMode.values())
967 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
968 >        for (boolean createIncomplete : new boolean[] { true, false })
969 >    {
970 >        final AtomicInteger a = new AtomicInteger(0);
971 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
972 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
973 >        final CompletableFuture<Integer> g = m.whenComplete
974 >            (f,
975 >             (Integer x, Throwable t) -> {
976 >                m.checkExecutionMode();
977 >                threadAssertNull(x);
978 >                threadAssertTrue(t instanceof CancellationException);
979 >                a.getAndIncrement();
980 >            });
981 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
982 >
983 >        checkCompletedWithWrappedCancellationException(g);
984 >        checkCancelled(f);
985 >        assertEquals(1, a.get());
986 >    }}
987 >
988 >    /**
989 >     * If a whenComplete action throws an exception when triggered by
990 >     * a normal completion, it completes exceptionally
991 >     */
992 >    public void testWhenComplete_actionFailed() {
993 >        for (boolean createIncomplete : new boolean[] { true, false })
994 >        for (ExecutionMode m : ExecutionMode.values())
995 >        for (Integer v1 : new Integer[] { 1, null })
996 >    {
997 >        final AtomicInteger a = new AtomicInteger(0);
998 >        final CFException ex = new CFException();
999 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1000 >        if (!createIncomplete) f.complete(v1);
1001 >        final CompletableFuture<Integer> g = m.whenComplete
1002 >            (f,
1003 >             (Integer x, Throwable t) -> {
1004 >                m.checkExecutionMode();
1005 >                threadAssertSame(x, v1);
1006 >                threadAssertNull(t);
1007 >                a.getAndIncrement();
1008 >                throw ex;
1009 >            });
1010 >        if (createIncomplete) f.complete(v1);
1011 >
1012 >        checkCompletedWithWrappedException(g, ex);
1013 >        checkCompletedNormally(f, v1);
1014 >        assertEquals(1, a.get());
1015 >    }}
1016 >
1017 >    /**
1018 >     * If a whenComplete action throws an exception when triggered by
1019 >     * a source completion that also throws an exception, the source
1020 >     * exception takes precedence.
1021 >     */
1022 >    public void testWhenComplete_actionFailedSourceFailed() {
1023 >        for (boolean createIncomplete : new boolean[] { true, false })
1024 >        for (ExecutionMode m : ExecutionMode.values())
1025 >        for (Integer v1 : new Integer[] { 1, null })
1026 >    {
1027 >        final AtomicInteger a = new AtomicInteger(0);
1028 >        final CFException ex1 = new CFException();
1029 >        final CFException ex2 = new CFException();
1030 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1031 >
1032 >        if (!createIncomplete) f.completeExceptionally(ex1);
1033 >        final CompletableFuture<Integer> g = m.whenComplete
1034 >            (f,
1035 >             (Integer x, Throwable t) -> {
1036 >                m.checkExecutionMode();
1037 >                threadAssertSame(t, ex1);
1038 >                threadAssertNull(x);
1039 >                a.getAndIncrement();
1040 >                throw ex2;
1041 >            });
1042 >        if (createIncomplete) f.completeExceptionally(ex1);
1043 >
1044 >        checkCompletedWithWrappedException(g, ex1);
1045 >        checkCompletedExceptionally(f, ex1);
1046          assertEquals(1, a.get());
1047      }}
1048  
# Line 826 | Line 1061 | public class CompletableFutureTest exten
1061          final CompletableFuture<Integer> g = m.handle
1062              (f,
1063               (Integer x, Throwable t) -> {
1064 +                m.checkExecutionMode();
1065                  threadAssertSame(x, v1);
1066                  threadAssertNull(t);
1067                  a.getAndIncrement();
# Line 854 | Line 1090 | public class CompletableFutureTest exten
1090          final CompletableFuture<Integer> g = m.handle
1091              (f,
1092               (Integer x, Throwable t) -> {
1093 +                m.checkExecutionMode();
1094                  threadAssertNull(x);
1095                  threadAssertSame(t, ex);
1096                  a.getAndIncrement();
# Line 862 | Line 1099 | public class CompletableFutureTest exten
1099          if (createIncomplete) f.completeExceptionally(ex);
1100  
1101          checkCompletedNormally(g, v1);
1102 <        checkCompletedWithWrappedCFException(f, ex);
1102 >        checkCompletedExceptionally(f, ex);
1103          assertEquals(1, a.get());
1104      }}
1105  
# Line 882 | Line 1119 | public class CompletableFutureTest exten
1119          final CompletableFuture<Integer> g = m.handle
1120              (f,
1121               (Integer x, Throwable t) -> {
1122 +                m.checkExecutionMode();
1123                  threadAssertNull(x);
1124                  threadAssertTrue(t instanceof CancellationException);
1125                  a.getAndIncrement();
# Line 909 | Line 1147 | public class CompletableFutureTest exten
1147          final CompletableFuture<Integer> g = m.handle
1148              (f,
1149               (Integer x, Throwable t) -> {
1150 +                m.checkExecutionMode();
1151                  threadAssertNull(x);
1152                  threadAssertSame(ex1, t);
1153                  a.getAndIncrement();
# Line 916 | Line 1155 | public class CompletableFutureTest exten
1155              });
1156          if (createIncomplete) f.completeExceptionally(ex1);
1157  
1158 <        checkCompletedWithWrappedCFException(g, ex2);
1159 <        checkCompletedWithWrappedCFException(f, ex1);
1158 >        checkCompletedWithWrappedException(g, ex2);
1159 >        checkCompletedExceptionally(f, ex1);
1160          assertEquals(1, a.get());
1161      }}
1162  
# Line 933 | Line 1172 | public class CompletableFutureTest exten
1172          final CompletableFuture<Integer> g = m.handle
1173              (f,
1174               (Integer x, Throwable t) -> {
1175 +                m.checkExecutionMode();
1176                  threadAssertSame(x, v1);
1177                  threadAssertNull(t);
1178                  a.getAndIncrement();
# Line 940 | Line 1180 | public class CompletableFutureTest exten
1180              });
1181          if (createIncomplete) f.complete(v1);
1182  
1183 <        checkCompletedWithWrappedCFException(g, ex);
1183 >        checkCompletedWithWrappedException(g, ex);
1184          checkCompletedNormally(f, v1);
1185          assertEquals(1, a.get());
1186      }}
# Line 948 | Line 1188 | public class CompletableFutureTest exten
1188      /**
1189       * runAsync completes after running Runnable
1190       */
1191 <    public void testRunAsync() {
1192 <        Noop r = new Noop(ExecutionMode.ASYNC);
1193 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1194 <        assertNull(f.join());
1195 <        assertEquals(1, r.invocationCount);
1196 <        checkCompletedNormally(f, null);
1197 <    }
1198 <
1199 <    /**
960 <     * runAsync with executor completes after running Runnable
961 <     */
962 <    public void testRunAsync2() {
963 <        Noop r = new Noop(ExecutionMode.EXECUTOR);
964 <        ThreadExecutor exec = new ThreadExecutor();
965 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
1191 >    public void testRunAsync_normalCompletion() {
1192 >        ExecutionMode[] executionModes = {
1193 >            ExecutionMode.ASYNC,
1194 >            ExecutionMode.EXECUTOR,
1195 >        };
1196 >        for (ExecutionMode m : executionModes)
1197 >    {
1198 >        final Noop r = new Noop(m);
1199 >        final CompletableFuture<Void> f = m.runAsync(r);
1200          assertNull(f.join());
967        assertEquals(1, r.invocationCount);
1201          checkCompletedNormally(f, null);
1202 <        assertEquals(1, exec.count.get());
1203 <    }
1202 >        r.assertInvoked();
1203 >    }}
1204  
1205      /**
1206       * failing runAsync completes exceptionally after running Runnable
1207       */
1208 <    public void testRunAsync3() {
1209 <        FailingRunnable r = new FailingRunnable(ExecutionMode.ASYNC);
1210 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1208 >    public void testRunAsync_exceptionalCompletion() {
1209 >        ExecutionMode[] executionModes = {
1210 >            ExecutionMode.ASYNC,
1211 >            ExecutionMode.EXECUTOR,
1212 >        };
1213 >        for (ExecutionMode m : executionModes)
1214 >    {
1215 >        final FailingRunnable r = new FailingRunnable(m);
1216 >        final CompletableFuture<Void> f = m.runAsync(r);
1217          checkCompletedWithWrappedCFException(f);
1218 <        assertEquals(1, r.invocationCount);
1219 <    }
1218 >        r.assertInvoked();
1219 >    }}
1220  
1221      /**
1222       * supplyAsync completes with result of supplier
1223       */
1224 <    public void testSupplyAsync() {
1225 <        CompletableFuture<Integer> f;
1226 <        f = CompletableFuture.supplyAsync(supplyOne);
1227 <        assertEquals(f.join(), one);
1228 <        checkCompletedNormally(f, one);
1229 <    }
1230 <
1231 <    /**
1232 <     * supplyAsync with executor completes with result of supplier
1233 <     */
1234 <    public void testSupplyAsync2() {
1235 <        CompletableFuture<Integer> f;
1236 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
1237 <        assertEquals(f.join(), one);
999 <        checkCompletedNormally(f, one);
1000 <    }
1224 >    public void testSupplyAsync_normalCompletion() {
1225 >        ExecutionMode[] executionModes = {
1226 >            ExecutionMode.ASYNC,
1227 >            ExecutionMode.EXECUTOR,
1228 >        };
1229 >        for (ExecutionMode m : executionModes)
1230 >        for (Integer v1 : new Integer[] { 1, null })
1231 >    {
1232 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1233 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1234 >        assertSame(v1, f.join());
1235 >        checkCompletedNormally(f, v1);
1236 >        r.assertInvoked();
1237 >    }}
1238  
1239      /**
1240       * Failing supplyAsync completes exceptionally
1241       */
1242 <    public void testSupplyAsync3() {
1243 <        FailingSupplier r = new FailingSupplier(ExecutionMode.ASYNC);
1244 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1242 >    public void testSupplyAsync_exceptionalCompletion() {
1243 >        ExecutionMode[] executionModes = {
1244 >            ExecutionMode.ASYNC,
1245 >            ExecutionMode.EXECUTOR,
1246 >        };
1247 >        for (ExecutionMode m : executionModes)
1248 >    {
1249 >        FailingSupplier r = new FailingSupplier(m);
1250 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1251          checkCompletedWithWrappedCFException(f);
1252 <        assertEquals(1, r.invocationCount);
1253 <    }
1252 >        r.assertInvoked();
1253 >    }}
1254  
1255      // seq completion methods
1256  
# Line 1030 | Line 1273 | public class CompletableFutureTest exten
1273  
1274          checkCompletedNormally(g, null);
1275          checkCompletedNormally(f, v1);
1276 <        assertEquals(1, r.invocationCount);
1276 >        r.assertInvoked();
1277      }}
1278  
1279      /**
# Line 1051 | Line 1294 | public class CompletableFutureTest exten
1294              f.completeExceptionally(ex);
1295          }
1296  
1297 <        checkCompletedWithWrappedCFException(g, ex);
1298 <        checkCompletedWithWrappedCFException(f, ex);
1299 <        assertEquals(0, r.invocationCount);
1297 >        checkCompletedWithWrappedException(g, ex);
1298 >        checkCompletedExceptionally(f, ex);
1299 >        r.assertNotInvoked();
1300      }}
1301  
1302      /**
# Line 1075 | Line 1318 | public class CompletableFutureTest exten
1318  
1319          checkCompletedWithWrappedCancellationException(g);
1320          checkCancelled(f);
1321 <        assertEquals(0, r.invocationCount);
1321 >        r.assertNotInvoked();
1322      }}
1323  
1324      /**
# Line 1118 | Line 1361 | public class CompletableFutureTest exten
1361  
1362          checkCompletedNormally(g, inc(v1));
1363          checkCompletedNormally(f, v1);
1364 <        assertEquals(1, r.invocationCount);
1364 >        r.assertValue(inc(v1));
1365      }}
1366  
1367      /**
# Line 1139 | Line 1382 | public class CompletableFutureTest exten
1382              f.completeExceptionally(ex);
1383          }
1384  
1385 <        checkCompletedWithWrappedCFException(g, ex);
1386 <        checkCompletedWithWrappedCFException(f, ex);
1387 <        assertEquals(0, r.invocationCount);
1385 >        checkCompletedWithWrappedException(g, ex);
1386 >        checkCompletedExceptionally(f, ex);
1387 >        r.assertNotInvoked();
1388      }}
1389  
1390      /**
# Line 1163 | Line 1406 | public class CompletableFutureTest exten
1406  
1407          checkCompletedWithWrappedCancellationException(g);
1408          checkCancelled(f);
1409 <        assertEquals(0, r.invocationCount);
1409 >        r.assertNotInvoked();
1410      }}
1411  
1412      /**
# Line 1196 | Line 1439 | public class CompletableFutureTest exten
1439          for (Integer v1 : new Integer[] { 1, null })
1440      {
1441          final CompletableFuture<Integer> f = new CompletableFuture<>();
1442 <        final IncAction r = new IncAction();
1442 >        final NoopConsumer r = new NoopConsumer(m);
1443          if (!createIncomplete) f.complete(v1);
1444          final CompletableFuture<Void> g = m.thenAccept(f, r);
1445          if (createIncomplete) {
# Line 1205 | Line 1448 | public class CompletableFutureTest exten
1448          }
1449  
1450          checkCompletedNormally(g, null);
1451 +        r.assertValue(v1);
1452          checkCompletedNormally(f, v1);
1209        assertEquals(1, r.invocationCount);
1210        assertEquals(inc(v1), r.value);
1453      }}
1454  
1455      /**
# Line 1220 | Line 1462 | public class CompletableFutureTest exten
1462      {
1463          final CFException ex = new CFException();
1464          final CompletableFuture<Integer> f = new CompletableFuture<>();
1465 <        final IncAction r = new IncAction();
1465 >        final NoopConsumer r = new NoopConsumer(m);
1466          if (!createIncomplete) f.completeExceptionally(ex);
1467          final CompletableFuture<Void> g = m.thenAccept(f, r);
1468          if (createIncomplete) {
# Line 1228 | Line 1470 | public class CompletableFutureTest exten
1470              f.completeExceptionally(ex);
1471          }
1472  
1473 <        checkCompletedWithWrappedCFException(g, ex);
1474 <        checkCompletedWithWrappedCFException(f, ex);
1475 <        assertEquals(0, r.invocationCount);
1473 >        checkCompletedWithWrappedException(g, ex);
1474 >        checkCompletedExceptionally(f, ex);
1475 >        r.assertNotInvoked();
1476      }}
1477  
1478      /**
1479 <     * thenAccept result completes exceptionally if action does
1479 >     * thenAccept result completes exceptionally if source cancelled
1480       */
1481 <    public void testThenAccept_actionFailed() {
1481 >    public void testThenAccept_sourceCancelled() {
1482          for (ExecutionMode m : ExecutionMode.values())
1483          for (boolean createIncomplete : new boolean[] { true, false })
1484 <        for (Integer v1 : new Integer[] { 1, null })
1484 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1485      {
1486          final CompletableFuture<Integer> f = new CompletableFuture<>();
1487 <        final FailingConsumer r = new FailingConsumer(m);
1488 <        if (!createIncomplete) f.complete(v1);
1487 >        final NoopConsumer r = new NoopConsumer(m);
1488 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1489          final CompletableFuture<Void> g = m.thenAccept(f, r);
1490          if (createIncomplete) {
1491              checkIncomplete(g);
1492 <            f.complete(v1);
1492 >            assertTrue(f.cancel(mayInterruptIfRunning));
1493          }
1494  
1495 <        checkCompletedWithWrappedCFException(g);
1496 <        checkCompletedNormally(f, v1);
1495 >        checkCompletedWithWrappedCancellationException(g);
1496 >        checkCancelled(f);
1497 >        r.assertNotInvoked();
1498      }}
1499  
1500      /**
1501 <     * thenAccept result completes exceptionally if source cancelled
1501 >     * thenAccept result completes exceptionally if action does
1502       */
1503 <    public void testThenAccept_sourceCancelled() {
1503 >    public void testThenAccept_actionFailed() {
1504          for (ExecutionMode m : ExecutionMode.values())
1505          for (boolean createIncomplete : new boolean[] { true, false })
1506 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1506 >        for (Integer v1 : new Integer[] { 1, null })
1507      {
1508          final CompletableFuture<Integer> f = new CompletableFuture<>();
1509 <        final IncAction r = new IncAction();
1510 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1509 >        final FailingConsumer r = new FailingConsumer(m);
1510 >        if (!createIncomplete) f.complete(v1);
1511          final CompletableFuture<Void> g = m.thenAccept(f, r);
1512          if (createIncomplete) {
1513              checkIncomplete(g);
1514 <            assertTrue(f.cancel(mayInterruptIfRunning));
1514 >            f.complete(v1);
1515          }
1516  
1517 <        checkCompletedWithWrappedCancellationException(g);
1518 <        checkCancelled(f);
1276 <        assertEquals(0, r.invocationCount);
1517 >        checkCompletedWithWrappedCFException(g);
1518 >        checkCompletedNormally(f, v1);
1519      }}
1520  
1521      /**
# Line 1297 | Line 1539 | public class CompletableFutureTest exten
1539          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1540          if (createIncomplete) {
1541              checkIncomplete(h);
1542 <            assertEquals(0, r.invocationCount);
1542 >            r.assertNotInvoked();
1543              if (!fFirst) f.complete(v1); else g.complete(v2);
1544          }
1545  
1546          checkCompletedNormally(h, subtract(v1, v2));
1547          checkCompletedNormally(f, v1);
1548          checkCompletedNormally(g, v2);
1549 <        assertEquals(1, r.invocationCount);
1549 >        r.assertValue(subtract(v1, v2));
1550      }}
1551  
1552      /**
# Line 1331 | Line 1573 | public class CompletableFutureTest exten
1573              (!fFirst ? f : g).completeExceptionally(ex);
1574          }
1575  
1576 <        checkCompletedWithWrappedCFException(h, ex);
1577 <        assertEquals(0, r.invocationCount);
1576 >        checkCompletedWithWrappedException(h, ex);
1577 >        r.assertNotInvoked();
1578          checkCompletedNormally(fFirst ? f : g, v1);
1579 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1338 <    }}
1339 <
1340 <    /**
1341 <     * thenCombine result completes exceptionally if action does
1342 <     */
1343 <    public void testThenCombine_actionFailed() {
1344 <        for (ExecutionMode m : ExecutionMode.values())
1345 <        for (boolean fFirst : new boolean[] { true, false })
1346 <        for (Integer v1 : new Integer[] { 1, null })
1347 <        for (Integer v2 : new Integer[] { 2, null })
1348 <    {
1349 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1350 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1351 <        final FailingBiFunction r = new FailingBiFunction(m);
1352 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1353 <
1354 <        if (fFirst) {
1355 <            f.complete(v1);
1356 <            g.complete(v2);
1357 <        } else {
1358 <            g.complete(v2);
1359 <            f.complete(v1);
1360 <        }
1361 <
1362 <        checkCompletedWithWrappedCFException(h);
1363 <        checkCompletedNormally(f, v1);
1364 <        checkCompletedNormally(g, v2);
1579 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1580      }}
1581  
1582      /**
# Line 1389 | Line 1604 | public class CompletableFutureTest exten
1604  
1605          checkCompletedWithWrappedCancellationException(h);
1606          checkCancelled(!fFirst ? f : g);
1607 <        assertEquals(0, r.invocationCount);
1607 >        r.assertNotInvoked();
1608          checkCompletedNormally(fFirst ? f : g, v1);
1609      }}
1610  
1611      /**
1612 +     * thenCombine result completes exceptionally if action does
1613 +     */
1614 +    public void testThenCombine_actionFailed() {
1615 +        for (ExecutionMode m : ExecutionMode.values())
1616 +        for (boolean fFirst : new boolean[] { true, false })
1617 +        for (Integer v1 : new Integer[] { 1, null })
1618 +        for (Integer v2 : new Integer[] { 2, null })
1619 +    {
1620 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1621 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1622 +        final FailingBiFunction r = new FailingBiFunction(m);
1623 +        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1624 +
1625 +        if (fFirst) {
1626 +            f.complete(v1);
1627 +            g.complete(v2);
1628 +        } else {
1629 +            g.complete(v2);
1630 +            f.complete(v1);
1631 +        }
1632 +
1633 +        checkCompletedWithWrappedCFException(h);
1634 +        checkCompletedNormally(f, v1);
1635 +        checkCompletedNormally(g, v2);
1636 +    }}
1637 +
1638 +    /**
1639       * thenAcceptBoth result completes normally after normal
1640       * completion of sources
1641       */
# Line 1414 | Line 1656 | public class CompletableFutureTest exten
1656          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1657          if (createIncomplete) {
1658              checkIncomplete(h);
1659 <            assertEquals(0, r.invocationCount);
1659 >            r.assertNotInvoked();
1660              if (!fFirst) f.complete(v1); else g.complete(v2);
1661          }
1662  
1663          checkCompletedNormally(h, null);
1664 <        assertEquals(subtract(v1, v2), r.value);
1664 >        r.assertValue(subtract(v1, v2));
1665          checkCompletedNormally(f, v1);
1666          checkCompletedNormally(g, v2);
1667      }}
# Line 1448 | Line 1690 | public class CompletableFutureTest exten
1690              (!fFirst ? f : g).completeExceptionally(ex);
1691          }
1692  
1693 <        checkCompletedWithWrappedCFException(h, ex);
1694 <        assertEquals(0, r.invocationCount);
1693 >        checkCompletedWithWrappedException(h, ex);
1694 >        r.assertNotInvoked();
1695          checkCompletedNormally(fFirst ? f : g, v1);
1696 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1455 <    }}
1456 <
1457 <    /**
1458 <     * thenAcceptBoth result completes exceptionally if action does
1459 <     */
1460 <    public void testThenAcceptBoth_actionFailed() {
1461 <        for (ExecutionMode m : ExecutionMode.values())
1462 <        for (boolean fFirst : new boolean[] { true, false })
1463 <        for (Integer v1 : new Integer[] { 1, null })
1464 <        for (Integer v2 : new Integer[] { 2, null })
1465 <    {
1466 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1467 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1468 <        final FailingBiConsumer r = new FailingBiConsumer(m);
1469 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1470 <
1471 <        if (fFirst) {
1472 <            f.complete(v1);
1473 <            g.complete(v2);
1474 <        } else {
1475 <            g.complete(v2);
1476 <            f.complete(v1);
1477 <        }
1478 <
1479 <        checkCompletedWithWrappedCFException(h);
1480 <        checkCompletedNormally(f, v1);
1481 <        checkCompletedNormally(g, v2);
1696 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1697      }}
1698  
1699      /**
# Line 1506 | Line 1721 | public class CompletableFutureTest exten
1721  
1722          checkCompletedWithWrappedCancellationException(h);
1723          checkCancelled(!fFirst ? f : g);
1724 <        assertEquals(0, r.invocationCount);
1724 >        r.assertNotInvoked();
1725          checkCompletedNormally(fFirst ? f : g, v1);
1726      }}
1727  
1728      /**
1729 +     * thenAcceptBoth result completes exceptionally if action does
1730 +     */
1731 +    public void testThenAcceptBoth_actionFailed() {
1732 +        for (ExecutionMode m : ExecutionMode.values())
1733 +        for (boolean fFirst : new boolean[] { true, false })
1734 +        for (Integer v1 : new Integer[] { 1, null })
1735 +        for (Integer v2 : new Integer[] { 2, null })
1736 +    {
1737 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1738 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1739 +        final FailingBiConsumer r = new FailingBiConsumer(m);
1740 +        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1741 +
1742 +        if (fFirst) {
1743 +            f.complete(v1);
1744 +            g.complete(v2);
1745 +        } else {
1746 +            g.complete(v2);
1747 +            f.complete(v1);
1748 +        }
1749 +
1750 +        checkCompletedWithWrappedCFException(h);
1751 +        checkCompletedNormally(f, v1);
1752 +        checkCompletedNormally(g, v2);
1753 +    }}
1754 +
1755 +    /**
1756       * runAfterBoth result completes normally after normal
1757       * completion of sources
1758       */
# Line 1531 | Line 1773 | public class CompletableFutureTest exten
1773          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1774          if (createIncomplete) {
1775              checkIncomplete(h);
1776 <            assertEquals(0, r.invocationCount);
1776 >            r.assertNotInvoked();
1777              if (!fFirst) f.complete(v1); else g.complete(v2);
1778          }
1779  
1780          checkCompletedNormally(h, null);
1781 <        assertEquals(1, r.invocationCount);
1781 >        r.assertInvoked();
1782          checkCompletedNormally(f, v1);
1783          checkCompletedNormally(g, v2);
1784      }}
# Line 1565 | Line 1807 | public class CompletableFutureTest exten
1807              (!fFirst ? f : g).completeExceptionally(ex);
1808          }
1809  
1810 <        checkCompletedWithWrappedCFException(h, ex);
1811 <        assertEquals(0, r.invocationCount);
1810 >        checkCompletedWithWrappedException(h, ex);
1811 >        r.assertNotInvoked();
1812          checkCompletedNormally(fFirst ? f : g, v1);
1813 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1572 <    }}
1573 <
1574 <    /**
1575 <     * runAfterBoth result completes exceptionally if action does
1576 <     */
1577 <    public void testRunAfterBoth_actionFailed() {
1578 <        for (ExecutionMode m : ExecutionMode.values())
1579 <        for (boolean fFirst : new boolean[] { true, false })
1580 <        for (Integer v1 : new Integer[] { 1, null })
1581 <        for (Integer v2 : new Integer[] { 2, null })
1582 <    {
1583 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1584 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1585 <        final FailingRunnable r = new FailingRunnable(m);
1586 <
1587 <        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1588 <        if (fFirst) {
1589 <            f.complete(v1);
1590 <            g.complete(v2);
1591 <        } else {
1592 <            g.complete(v2);
1593 <            f.complete(v1);
1594 <        }
1595 <        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1596 <
1597 <        checkCompletedWithWrappedCFException(h1);
1598 <        checkCompletedWithWrappedCFException(h2);
1599 <        checkCompletedNormally(f, v1);
1600 <        checkCompletedNormally(g, v2);
1813 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1814      }}
1815  
1816      /**
# Line 1614 | Line 1827 | public class CompletableFutureTest exten
1827          final CompletableFuture<Integer> g = new CompletableFuture<>();
1828          final Noop r = new Noop(m);
1829  
1617
1830          (fFirst ? f : g).complete(v1);
1831          if (!createIncomplete)
1832              assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
# Line 1626 | Line 1838 | public class CompletableFutureTest exten
1838  
1839          checkCompletedWithWrappedCancellationException(h);
1840          checkCancelled(!fFirst ? f : g);
1841 <        assertEquals(0, r.invocationCount);
1841 >        r.assertNotInvoked();
1842          checkCompletedNormally(fFirst ? f : g, v1);
1843      }}
1844  
1845      /**
1846 <     * applyToEither result completes normally after normal completion
1635 <     * of either source
1846 >     * runAfterBoth result completes exceptionally if action does
1847       */
1848 <    public void testApplyToEither_normalCompletion() {
1848 >    public void testRunAfterBoth_actionFailed() {
1849          for (ExecutionMode m : ExecutionMode.values())
1639        for (boolean createIncomplete : new boolean[] { true, false })
1850          for (boolean fFirst : new boolean[] { true, false })
1851          for (Integer v1 : new Integer[] { 1, null })
1852          for (Integer v2 : new Integer[] { 2, null })
1853      {
1854          final CompletableFuture<Integer> f = new CompletableFuture<>();
1855          final CompletableFuture<Integer> g = new CompletableFuture<>();
1856 <        final IncFunction r = new IncFunction(m);
1856 >        final FailingRunnable r1 = new FailingRunnable(m);
1857 >        final FailingRunnable r2 = new FailingRunnable(m);
1858  
1859 <        if (!createIncomplete)
1860 <            if (fFirst) f.complete(v1); else g.complete(v2);
1861 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1862 <        if (createIncomplete) {
1863 <            checkIncomplete(h);
1864 <            assertEquals(0, r.invocationCount);
1865 <            if (fFirst) f.complete(v1); else g.complete(v2);
1859 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1860 >        if (fFirst) {
1861 >            f.complete(v1);
1862 >            g.complete(v2);
1863 >        } else {
1864 >            g.complete(v2);
1865 >            f.complete(v1);
1866          }
1867 <        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1657 <        if (!fFirst) f.complete(v1); else g.complete(v2);
1867 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1868  
1869 +        checkCompletedWithWrappedCFException(h1);
1870 +        checkCompletedWithWrappedCFException(h2);
1871          checkCompletedNormally(f, v1);
1872          checkCompletedNormally(g, v2);
1661        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1873      }}
1874  
1875 <    public void testApplyToEither_normalCompletionBothAvailable() {
1875 >    /**
1876 >     * applyToEither result completes normally after normal completion
1877 >     * of either source
1878 >     */
1879 >    public void testApplyToEither_normalCompletion() {
1880          for (ExecutionMode m : ExecutionMode.values())
1666        for (boolean fFirst : new boolean[] { true, false })
1881          for (Integer v1 : new Integer[] { 1, null })
1882          for (Integer v2 : new Integer[] { 2, null })
1883      {
1884          final CompletableFuture<Integer> f = new CompletableFuture<>();
1885          final CompletableFuture<Integer> g = new CompletableFuture<>();
1886 <        final IncFunction r = new IncFunction(m);
1886 >        final IncFunction[] rs = new IncFunction[6];
1887 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1888  
1889 <        if (fFirst) {
1890 <            f.complete(v1);
1891 <            g.complete(v2);
1892 <        } else {
1893 <            g.complete(v2);
1894 <            f.complete(v1);
1895 <        }
1889 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1890 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1891 >        checkIncomplete(h0);
1892 >        checkIncomplete(h1);
1893 >        rs[0].assertNotInvoked();
1894 >        rs[1].assertNotInvoked();
1895 >        f.complete(v1);
1896 >        checkCompletedNormally(h0, inc(v1));
1897 >        checkCompletedNormally(h1, inc(v1));
1898 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1899 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1900 >        checkCompletedNormally(h2, inc(v1));
1901 >        checkCompletedNormally(h3, inc(v1));
1902 >        g.complete(v2);
1903  
1904 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1904 >        // unspecified behavior - both source completions available
1905 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1906 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1907 >        rs[4].assertValue(h4.join());
1908 >        rs[5].assertValue(h5.join());
1909 >        assertTrue(Objects.equals(inc(v1), h4.join()) ||
1910 >                   Objects.equals(inc(v2), h4.join()));
1911 >        assertTrue(Objects.equals(inc(v1), h5.join()) ||
1912 >                   Objects.equals(inc(v2), h5.join()));
1913  
1914          checkCompletedNormally(f, v1);
1915          checkCompletedNormally(g, v2);
1916 <
1917 <        // unspecified behavior
1918 <        assertTrue(Objects.equals(h.join(), inc(v1)) ||
1919 <                   Objects.equals(h.join(), inc(v2)));
1920 <        assertEquals(1, r.invocationCount);
1916 >        checkCompletedNormally(h0, inc(v1));
1917 >        checkCompletedNormally(h1, inc(v1));
1918 >        checkCompletedNormally(h2, inc(v1));
1919 >        checkCompletedNormally(h3, inc(v1));
1920 >        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
1921      }}
1922  
1923      /**
1924       * applyToEither result completes exceptionally after exceptional
1925       * completion of either source
1926       */
1927 <    public void testApplyToEither_exceptionalCompletion1() {
1927 >    public void testApplyToEither_exceptionalCompletion() {
1928          for (ExecutionMode m : ExecutionMode.values())
1699        for (boolean createIncomplete : new boolean[] { true, false })
1700        for (boolean fFirst : new boolean[] { true, false })
1929          for (Integer v1 : new Integer[] { 1, null })
1930      {
1931          final CompletableFuture<Integer> f = new CompletableFuture<>();
1932          final CompletableFuture<Integer> g = new CompletableFuture<>();
1933          final CFException ex = new CFException();
1934 <        final IncFunction r = new IncFunction(m);
1934 >        final IncFunction[] rs = new IncFunction[6];
1935 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1936  
1937 <        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1938 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1939 <        if (createIncomplete) {
1940 <            checkIncomplete(h);
1941 <            assertEquals(0, r.invocationCount);
1942 <            (fFirst ? f : g).completeExceptionally(ex);
1943 <        }
1937 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1938 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1939 >        checkIncomplete(h0);
1940 >        checkIncomplete(h1);
1941 >        rs[0].assertNotInvoked();
1942 >        rs[1].assertNotInvoked();
1943 >        f.completeExceptionally(ex);
1944 >        checkCompletedWithWrappedException(h0, ex);
1945 >        checkCompletedWithWrappedException(h1, ex);
1946 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1947 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1948 >        checkCompletedWithWrappedException(h2, ex);
1949 >        checkCompletedWithWrappedException(h3, ex);
1950 >        g.complete(v1);
1951  
1952 <        checkCompletedWithWrappedCFException(h, ex);
1953 <        (!fFirst ? f : g).complete(v1);
1952 >        // unspecified behavior - both source completions available
1953 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1954 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1955 >        try {
1956 >            assertEquals(inc(v1), h4.join());
1957 >            rs[4].assertValue(inc(v1));
1958 >        } catch (CompletionException ok) {
1959 >            checkCompletedWithWrappedException(h4, ex);
1960 >            rs[4].assertNotInvoked();
1961 >        }
1962 >        try {
1963 >            assertEquals(inc(v1), h5.join());
1964 >            rs[5].assertValue(inc(v1));
1965 >        } catch (CompletionException ok) {
1966 >            checkCompletedWithWrappedException(h5, ex);
1967 >            rs[5].assertNotInvoked();
1968 >        }
1969  
1970 <        assertEquals(0, r.invocationCount);
1971 <        checkCompletedNormally(!fFirst ? f : g, v1);
1972 <        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1973 <        checkCompletedWithWrappedCFException(h, ex);
1970 >        checkCompletedExceptionally(f, ex);
1971 >        checkCompletedNormally(g, v1);
1972 >        checkCompletedWithWrappedException(h0, ex);
1973 >        checkCompletedWithWrappedException(h1, ex);
1974 >        checkCompletedWithWrappedException(h2, ex);
1975 >        checkCompletedWithWrappedException(h3, ex);
1976 >        checkCompletedWithWrappedException(h4, ex);
1977 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1978      }}
1979  
1980      public void testApplyToEither_exceptionalCompletion2() {
1981          for (ExecutionMode m : ExecutionMode.values())
1727        for (boolean reverseArgs : new boolean[] { true, false })
1982          for (boolean fFirst : new boolean[] { true, false })
1983          for (Integer v1 : new Integer[] { 1, null })
1984      {
1985          final CompletableFuture<Integer> f = new CompletableFuture<>();
1986          final CompletableFuture<Integer> g = new CompletableFuture<>();
1733        final IncFunction r1 = new IncFunction(m);
1734        final IncFunction r2 = new IncFunction(m);
1987          final CFException ex = new CFException();
1988 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1989 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1990 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1988 >        final IncFunction[] rs = new IncFunction[6];
1989 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1990 >
1991 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1992 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1993          if (fFirst) {
1994              f.complete(v1);
1995              g.completeExceptionally(ex);
# Line 1743 | Line 1997 | public class CompletableFutureTest exten
1997              g.completeExceptionally(ex);
1998              f.complete(v1);
1999          }
2000 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
2000 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2001 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2002  
2003 <        // unspecified behavior
2003 >        // unspecified behavior - both source completions available
2004 >        try {
2005 >            assertEquals(inc(v1), h0.join());
2006 >            rs[0].assertValue(inc(v1));
2007 >        } catch (CompletionException ok) {
2008 >            checkCompletedWithWrappedException(h0, ex);
2009 >            rs[0].assertNotInvoked();
2010 >        }
2011          try {
2012              assertEquals(inc(v1), h1.join());
2013 <            assertEquals(1, r1.invocationCount);
2013 >            rs[1].assertValue(inc(v1));
2014          } catch (CompletionException ok) {
2015 <            checkCompletedWithWrappedCFException(h1, ex);
2016 <            assertEquals(0, r1.invocationCount);
2015 >            checkCompletedWithWrappedException(h1, ex);
2016 >            rs[1].assertNotInvoked();
2017          }
1756
2018          try {
2019              assertEquals(inc(v1), h2.join());
2020 <            assertEquals(1, r2.invocationCount);
2020 >            rs[2].assertValue(inc(v1));
2021          } catch (CompletionException ok) {
2022 <            checkCompletedWithWrappedCFException(h2, ex);
2023 <            assertEquals(0, r2.invocationCount);
2022 >            checkCompletedWithWrappedException(h2, ex);
2023 >            rs[2].assertNotInvoked();
2024 >        }
2025 >        try {
2026 >            assertEquals(inc(v1), h3.join());
2027 >            rs[3].assertValue(inc(v1));
2028 >        } catch (CompletionException ok) {
2029 >            checkCompletedWithWrappedException(h3, ex);
2030 >            rs[3].assertNotInvoked();
2031          }
2032  
1765        checkCompletedWithWrappedCFException(g, ex);
1766        checkCompletedNormally(f, v1);
1767    }}
1768
1769    /**
1770     * applyToEither result completes exceptionally if action does
1771     */
1772    public void testApplyToEither_actionFailed1() {
1773        for (ExecutionMode m : ExecutionMode.values())
1774        for (Integer v1 : new Integer[] { 1, null })
1775        for (Integer v2 : new Integer[] { 2, null })
1776    {
1777        final CompletableFuture<Integer> f = new CompletableFuture<>();
1778        final CompletableFuture<Integer> g = new CompletableFuture<>();
1779        final FailingFunction r = new FailingFunction(m);
1780        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1781
1782        f.complete(v1);
1783        checkCompletedWithWrappedCFException(h);
1784        g.complete(v2);
1785        checkCompletedNormally(f, v1);
1786        checkCompletedNormally(g, v2);
1787    }}
1788
1789    public void testApplyToEither_actionFailed2() {
1790        for (ExecutionMode m : ExecutionMode.values())
1791        for (Integer v1 : new Integer[] { 1, null })
1792        for (Integer v2 : new Integer[] { 2, null })
1793    {
1794        final CompletableFuture<Integer> f = new CompletableFuture<>();
1795        final CompletableFuture<Integer> g = new CompletableFuture<>();
1796        final FailingFunction r = new FailingFunction(m);
1797        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1798
1799        g.complete(v2);
1800        checkCompletedWithWrappedCFException(h);
1801        f.complete(v1);
2033          checkCompletedNormally(f, v1);
2034 <        checkCompletedNormally(g, v2);
2034 >        checkCompletedExceptionally(g, ex);
2035      }}
2036  
2037      /**
2038       * applyToEither result completes exceptionally if either source cancelled
2039       */
2040 <    public void testApplyToEither_sourceCancelled1() {
2040 >    public void testApplyToEither_sourceCancelled() {
2041          for (ExecutionMode m : ExecutionMode.values())
2042          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1812        for (boolean createIncomplete : new boolean[] { true, false })
1813        for (boolean fFirst : new boolean[] { true, false })
2043          for (Integer v1 : new Integer[] { 1, null })
2044      {
2045          final CompletableFuture<Integer> f = new CompletableFuture<>();
2046          final CompletableFuture<Integer> g = new CompletableFuture<>();
2047 <        final IncFunction r = new IncFunction(m);
2047 >        final IncFunction[] rs = new IncFunction[6];
2048 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2049  
2050 <        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
2051 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2052 <        if (createIncomplete) {
2053 <            checkIncomplete(h);
2054 <            assertEquals(0, r.invocationCount);
2055 <            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
2056 <        }
2050 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2051 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2052 >        checkIncomplete(h0);
2053 >        checkIncomplete(h1);
2054 >        rs[0].assertNotInvoked();
2055 >        rs[1].assertNotInvoked();
2056 >        f.cancel(mayInterruptIfRunning);
2057 >        checkCompletedWithWrappedCancellationException(h0);
2058 >        checkCompletedWithWrappedCancellationException(h1);
2059 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2060 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2061 >        checkCompletedWithWrappedCancellationException(h2);
2062 >        checkCompletedWithWrappedCancellationException(h3);
2063 >        g.complete(v1);
2064  
2065 <        checkCompletedWithWrappedCancellationException(h);
2066 <        (!fFirst ? f : g).complete(v1);
2065 >        // unspecified behavior - both source completions available
2066 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2067 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2068 >        try {
2069 >            assertEquals(inc(v1), h4.join());
2070 >            rs[4].assertValue(inc(v1));
2071 >        } catch (CompletionException ok) {
2072 >            checkCompletedWithWrappedCancellationException(h4);
2073 >            rs[4].assertNotInvoked();
2074 >        }
2075 >        try {
2076 >            assertEquals(inc(v1), h5.join());
2077 >            rs[5].assertValue(inc(v1));
2078 >        } catch (CompletionException ok) {
2079 >            checkCompletedWithWrappedCancellationException(h5);
2080 >            rs[5].assertNotInvoked();
2081 >        }
2082  
2083 <        assertEquals(0, r.invocationCount);
2084 <        checkCompletedNormally(!fFirst ? f : g, v1);
2085 <        checkCancelled(fFirst ? f : g);
2086 <        checkCompletedWithWrappedCancellationException(h);
2083 >        checkCancelled(f);
2084 >        checkCompletedNormally(g, v1);
2085 >        checkCompletedWithWrappedCancellationException(h0);
2086 >        checkCompletedWithWrappedCancellationException(h1);
2087 >        checkCompletedWithWrappedCancellationException(h2);
2088 >        checkCompletedWithWrappedCancellationException(h3);
2089 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2090      }}
2091  
2092      public void testApplyToEither_sourceCancelled2() {
2093          for (ExecutionMode m : ExecutionMode.values())
2094          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1840        for (boolean reverseArgs : new boolean[] { true, false })
2095          for (boolean fFirst : new boolean[] { true, false })
2096          for (Integer v1 : new Integer[] { 1, null })
2097      {
2098          final CompletableFuture<Integer> f = new CompletableFuture<>();
2099          final CompletableFuture<Integer> g = new CompletableFuture<>();
2100 <        final IncFunction r1 = new IncFunction(m);
2101 <        final IncFunction r2 = new IncFunction(m);
1848 <        final CFException ex = new CFException();
1849 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1850 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
2100 >        final IncFunction[] rs = new IncFunction[6];
2101 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2102  
2103 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
2103 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2104 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2105          if (fFirst) {
2106              f.complete(v1);
2107 <            assertTrue(g.cancel(mayInterruptIfRunning));
2107 >            g.cancel(mayInterruptIfRunning);
2108          } else {
2109 <            assertTrue(g.cancel(mayInterruptIfRunning));
2109 >            g.cancel(mayInterruptIfRunning);
2110              f.complete(v1);
2111          }
2112 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
2112 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2113 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2114  
2115 <        // unspecified behavior
2115 >        // unspecified behavior - both source completions available
2116 >        try {
2117 >            assertEquals(inc(v1), h0.join());
2118 >            rs[0].assertValue(inc(v1));
2119 >        } catch (CompletionException ok) {
2120 >            checkCompletedWithWrappedCancellationException(h0);
2121 >            rs[0].assertNotInvoked();
2122 >        }
2123          try {
2124              assertEquals(inc(v1), h1.join());
2125 <            assertEquals(1, r1.invocationCount);
2125 >            rs[1].assertValue(inc(v1));
2126          } catch (CompletionException ok) {
2127              checkCompletedWithWrappedCancellationException(h1);
2128 <            assertEquals(0, r1.invocationCount);
2128 >            rs[1].assertNotInvoked();
2129          }
1870
2130          try {
2131              assertEquals(inc(v1), h2.join());
2132 <            assertEquals(1, r2.invocationCount);
2132 >            rs[2].assertValue(inc(v1));
2133          } catch (CompletionException ok) {
2134              checkCompletedWithWrappedCancellationException(h2);
2135 <            assertEquals(0, r2.invocationCount);
2135 >            rs[2].assertNotInvoked();
2136 >        }
2137 >        try {
2138 >            assertEquals(inc(v1), h3.join());
2139 >            rs[3].assertValue(inc(v1));
2140 >        } catch (CompletionException ok) {
2141 >            checkCompletedWithWrappedCancellationException(h3);
2142 >            rs[3].assertNotInvoked();
2143          }
2144  
1879        checkCancelled(g);
2145          checkCompletedNormally(f, v1);
2146 +        checkCancelled(g);
2147      }}
2148  
2149      /**
2150 <     * acceptEither result completes normally after normal completion
1885 <     * of either source
2150 >     * applyToEither result completes exceptionally if action does
2151       */
2152 <    public void testAcceptEither_normalCompletion1() {
2152 >    public void testApplyToEither_actionFailed() {
2153          for (ExecutionMode m : ExecutionMode.values())
2154          for (Integer v1 : new Integer[] { 1, null })
2155          for (Integer v2 : new Integer[] { 2, null })
2156      {
2157          final CompletableFuture<Integer> f = new CompletableFuture<>();
2158          final CompletableFuture<Integer> g = new CompletableFuture<>();
2159 <        final IncAction r = new IncAction();
2160 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2159 >        final FailingFunction[] rs = new FailingFunction[6];
2160 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
2161  
2162 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2163 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2164          f.complete(v1);
2165 <        checkCompletedNormally(h, null);
2166 <        assertEquals(inc(v1), r.value);
2167 <        g.complete(v2);
2168 <
2169 <        checkCompletedNormally(f, v1);
2170 <        checkCompletedNormally(g, v2);
2171 <        checkCompletedNormally(h, null);
1905 <    }}
1906 <
1907 <    public void testAcceptEither_normalCompletion2() {
1908 <        for (ExecutionMode m : ExecutionMode.values())
1909 <        for (Integer v1 : new Integer[] { 1, null })
1910 <        for (Integer v2 : new Integer[] { 2, null })
1911 <    {
1912 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1913 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1914 <        final IncAction r = new IncAction();
1915 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2165 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2166 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2167 >        checkCompletedWithWrappedCFException(h0);
2168 >        checkCompletedWithWrappedCFException(h1);
2169 >        checkCompletedWithWrappedCFException(h2);
2170 >        checkCompletedWithWrappedCFException(h3);
2171 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2172  
2173          g.complete(v2);
2174 <        checkCompletedNormally(h, null);
2175 <        assertEquals(inc(v2), r.value);
2176 <        f.complete(v1);
2174 >
2175 >        // unspecified behavior - both source completions available
2176 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2177 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2178 >
2179 >        checkCompletedWithWrappedCFException(h4);
2180 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2181 >                   Objects.equals(v2, rs[4].value));
2182 >        checkCompletedWithWrappedCFException(h5);
2183 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2184 >                   Objects.equals(v2, rs[5].value));
2185  
2186          checkCompletedNormally(f, v1);
2187          checkCompletedNormally(g, v2);
1924        checkCompletedNormally(h, null);
2188      }}
2189  
2190 <    public void testAcceptEither_normalCompletion3() {
2190 >    /**
2191 >     * acceptEither result completes normally after normal completion
2192 >     * of either source
2193 >     */
2194 >    public void testAcceptEither_normalCompletion() {
2195          for (ExecutionMode m : ExecutionMode.values())
2196          for (Integer v1 : new Integer[] { 1, null })
2197          for (Integer v2 : new Integer[] { 2, null })
2198      {
2199          final CompletableFuture<Integer> f = new CompletableFuture<>();
2200          final CompletableFuture<Integer> g = new CompletableFuture<>();
2201 <        final IncAction r = new IncAction();
2201 >        final NoopConsumer[] rs = new NoopConsumer[6];
2202 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2203  
2204 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2205 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2206 +        checkIncomplete(h0);
2207 +        checkIncomplete(h1);
2208 +        rs[0].assertNotInvoked();
2209 +        rs[1].assertNotInvoked();
2210          f.complete(v1);
2211 +        checkCompletedNormally(h0, null);
2212 +        checkCompletedNormally(h1, null);
2213 +        rs[0].assertValue(v1);
2214 +        rs[1].assertValue(v1);
2215 +        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2216 +        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2217 +        checkCompletedNormally(h2, null);
2218 +        checkCompletedNormally(h3, null);
2219 +        rs[2].assertValue(v1);
2220 +        rs[3].assertValue(v1);
2221          g.complete(v2);
1938        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2222  
2223 <        checkCompletedNormally(h, null);
2223 >        // unspecified behavior - both source completions available
2224 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2225 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2226 >        checkCompletedNormally(h4, null);
2227 >        checkCompletedNormally(h5, null);
2228 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2229 >                   Objects.equals(v2, rs[4].value));
2230 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2231 >                   Objects.equals(v2, rs[5].value));
2232 >
2233          checkCompletedNormally(f, v1);
2234          checkCompletedNormally(g, v2);
2235 <
2236 <        // unspecified behavior
2237 <        assertTrue(Objects.equals(r.value, inc(v1)) ||
2238 <                   Objects.equals(r.value, inc(v2)));
2235 >        checkCompletedNormally(h0, null);
2236 >        checkCompletedNormally(h1, null);
2237 >        checkCompletedNormally(h2, null);
2238 >        checkCompletedNormally(h3, null);
2239 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2240      }}
2241  
2242      /**
2243       * acceptEither result completes exceptionally after exceptional
2244       * completion of either source
2245       */
2246 <    public void testAcceptEither_exceptionalCompletion1() {
2246 >    public void testAcceptEither_exceptionalCompletion() {
2247          for (ExecutionMode m : ExecutionMode.values())
2248          for (Integer v1 : new Integer[] { 1, null })
2249      {
2250          final CompletableFuture<Integer> f = new CompletableFuture<>();
2251          final CompletableFuture<Integer> g = new CompletableFuture<>();
1959        final IncAction r = new IncAction();
1960        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2252          final CFException ex = new CFException();
2253 +        final NoopConsumer[] rs = new NoopConsumer[6];
2254 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2255  
2256 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2257 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2258 +        checkIncomplete(h0);
2259 +        checkIncomplete(h1);
2260 +        rs[0].assertNotInvoked();
2261 +        rs[1].assertNotInvoked();
2262          f.completeExceptionally(ex);
2263 <        checkCompletedWithWrappedCFException(h, ex);
2263 >        checkCompletedWithWrappedException(h0, ex);
2264 >        checkCompletedWithWrappedException(h1, ex);
2265 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2266 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2267 >        checkCompletedWithWrappedException(h2, ex);
2268 >        checkCompletedWithWrappedException(h3, ex);
2269 >
2270          g.complete(v1);
2271  
2272 <        assertEquals(0, r.invocationCount);
2272 >        // unspecified behavior - both source completions available
2273 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2274 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2275 >        try {
2276 >            assertNull(h4.join());
2277 >            rs[4].assertValue(v1);
2278 >        } catch (CompletionException ok) {
2279 >            checkCompletedWithWrappedException(h4, ex);
2280 >            rs[4].assertNotInvoked();
2281 >        }
2282 >        try {
2283 >            assertNull(h5.join());
2284 >            rs[5].assertValue(v1);
2285 >        } catch (CompletionException ok) {
2286 >            checkCompletedWithWrappedException(h5, ex);
2287 >            rs[5].assertNotInvoked();
2288 >        }
2289 >
2290 >        checkCompletedExceptionally(f, ex);
2291          checkCompletedNormally(g, v1);
2292 <        checkCompletedWithWrappedCFException(f, ex);
2293 <        checkCompletedWithWrappedCFException(h, ex);
2292 >        checkCompletedWithWrappedException(h0, ex);
2293 >        checkCompletedWithWrappedException(h1, ex);
2294 >        checkCompletedWithWrappedException(h2, ex);
2295 >        checkCompletedWithWrappedException(h3, ex);
2296 >        checkCompletedWithWrappedException(h4, ex);
2297 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2298      }}
2299  
2300      public void testAcceptEither_exceptionalCompletion2() {
2301          for (ExecutionMode m : ExecutionMode.values())
2302 +        for (boolean fFirst : new boolean[] { true, false })
2303          for (Integer v1 : new Integer[] { 1, null })
2304      {
2305          final CompletableFuture<Integer> f = new CompletableFuture<>();
2306          final CompletableFuture<Integer> g = new CompletableFuture<>();
1979        final IncAction r = new IncAction();
1980        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1981        final CFException ex = new CFException();
1982
1983        g.completeExceptionally(ex);
1984        checkCompletedWithWrappedCFException(h, ex);
1985        f.complete(v1);
1986
1987        assertEquals(0, r.invocationCount);
1988        checkCompletedNormally(f, v1);
1989        checkCompletedWithWrappedCFException(g, ex);
1990        checkCompletedWithWrappedCFException(h, ex);
1991    }}
1992
1993    public void testAcceptEither_exceptionalCompletion3() {
1994        for (ExecutionMode m : ExecutionMode.values())
1995        for (Integer v1 : new Integer[] { 1, null })
1996    {
1997        final CompletableFuture<Integer> f = new CompletableFuture<>();
1998        final CompletableFuture<Integer> g = new CompletableFuture<>();
1999        final IncAction r = new IncAction();
2307          final CFException ex = new CFException();
2308 +        final NoopConsumer[] rs = new NoopConsumer[6];
2309 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2310  
2311 <        g.completeExceptionally(ex);
2312 <        f.complete(v1);
2313 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2311 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2312 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2313 >        if (fFirst) {
2314 >            f.complete(v1);
2315 >            g.completeExceptionally(ex);
2316 >        } else {
2317 >            g.completeExceptionally(ex);
2318 >            f.complete(v1);
2319 >        }
2320 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2321 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2322  
2323 <        // unspecified behavior
2007 <        Integer v;
2323 >        // unspecified behavior - both source completions available
2324          try {
2325 <            assertNull(h.join());
2326 <            assertEquals(1, r.invocationCount);
2011 <            assertEquals(inc(v1), r.value);
2325 >            assertEquals(null, h0.join());
2326 >            rs[0].assertValue(v1);
2327          } catch (CompletionException ok) {
2328 <            checkCompletedWithWrappedCFException(h, ex);
2329 <            assertEquals(0, r.invocationCount);
2328 >            checkCompletedWithWrappedException(h0, ex);
2329 >            rs[0].assertNotInvoked();
2330          }
2016
2017        checkCompletedWithWrappedCFException(g, ex);
2018        checkCompletedNormally(f, v1);
2019    }}
2020
2021    public void testAcceptEither_exceptionalCompletion4() {
2022        for (ExecutionMode m : ExecutionMode.values())
2023        for (Integer v1 : new Integer[] { 1, null })
2024    {
2025        final CompletableFuture<Integer> f = new CompletableFuture<>();
2026        final CompletableFuture<Integer> g = new CompletableFuture<>();
2027        final IncAction r = new IncAction();
2028        final CFException ex = new CFException();
2029
2030        f.completeExceptionally(ex);
2031        g.complete(v1);
2032        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2033
2034        // unspecified behavior
2035        Integer v;
2331          try {
2332 <            assertNull(h.join());
2333 <            assertEquals(1, r.invocationCount);
2039 <            assertEquals(inc(v1), r.value);
2332 >            assertEquals(null, h1.join());
2333 >            rs[1].assertValue(v1);
2334          } catch (CompletionException ok) {
2335 <            checkCompletedWithWrappedCFException(h, ex);
2336 <            assertEquals(0, r.invocationCount);
2335 >            checkCompletedWithWrappedException(h1, ex);
2336 >            rs[1].assertNotInvoked();
2337 >        }
2338 >        try {
2339 >            assertEquals(null, h2.join());
2340 >            rs[2].assertValue(v1);
2341 >        } catch (CompletionException ok) {
2342 >            checkCompletedWithWrappedException(h2, ex);
2343 >            rs[2].assertNotInvoked();
2344 >        }
2345 >        try {
2346 >            assertEquals(null, h3.join());
2347 >            rs[3].assertValue(v1);
2348 >        } catch (CompletionException ok) {
2349 >            checkCompletedWithWrappedException(h3, ex);
2350 >            rs[3].assertNotInvoked();
2351          }
2352  
2045        checkCompletedWithWrappedCFException(f, ex);
2046        checkCompletedNormally(g, v1);
2047    }}
2048
2049    /**
2050     * acceptEither result completes exceptionally if action does
2051     */
2052    public void testAcceptEither_actionFailed1() {
2053        for (ExecutionMode m : ExecutionMode.values())
2054        for (Integer v1 : new Integer[] { 1, null })
2055        for (Integer v2 : new Integer[] { 2, null })
2056    {
2057        final CompletableFuture<Integer> f = new CompletableFuture<>();
2058        final CompletableFuture<Integer> g = new CompletableFuture<>();
2059        final FailingConsumer r = new FailingConsumer(m);
2060        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2061
2062        f.complete(v1);
2063        checkCompletedWithWrappedCFException(h);
2064        g.complete(v2);
2353          checkCompletedNormally(f, v1);
2354 <        checkCompletedNormally(g, v2);
2067 <    }}
2068 <
2069 <    public void testAcceptEither_actionFailed2() {
2070 <        for (ExecutionMode m : ExecutionMode.values())
2071 <        for (Integer v1 : new Integer[] { 1, null })
2072 <        for (Integer v2 : new Integer[] { 2, null })
2073 <    {
2074 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2075 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2076 <        final FailingConsumer r = new FailingConsumer(m);
2077 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2078 <
2079 <        g.complete(v2);
2080 <        checkCompletedWithWrappedCFException(h);
2081 <        f.complete(v1);
2082 <        checkCompletedNormally(f, v1);
2083 <        checkCompletedNormally(g, v2);
2354 >        checkCompletedExceptionally(g, ex);
2355      }}
2356  
2357      /**
2358       * acceptEither result completes exceptionally if either source cancelled
2359       */
2360 <    public void testAcceptEither_sourceCancelled1() {
2360 >    public void testAcceptEither_sourceCancelled() {
2361          for (ExecutionMode m : ExecutionMode.values())
2362          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2363          for (Integer v1 : new Integer[] { 1, null })
2364      {
2365          final CompletableFuture<Integer> f = new CompletableFuture<>();
2366          final CompletableFuture<Integer> g = new CompletableFuture<>();
2367 <        final IncAction r = new IncAction();
2368 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2367 >        final NoopConsumer[] rs = new NoopConsumer[6];
2368 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2369  
2370 <        assertTrue(f.cancel(mayInterruptIfRunning));
2371 <        checkCompletedWithWrappedCancellationException(h);
2372 <        g.complete(v1);
2373 <
2374 <        checkCancelled(f);
2375 <        assertEquals(0, r.invocationCount);
2376 <        checkCompletedNormally(g, v1);
2377 <        checkCompletedWithWrappedCancellationException(h);
2378 <    }}
2379 <
2380 <    public void testAcceptEither_sourceCancelled2() {
2381 <        for (ExecutionMode m : ExecutionMode.values())
2382 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2112 <        for (Integer v1 : new Integer[] { 1, null })
2113 <    {
2114 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2115 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2116 <        final IncAction r = new IncAction();
2117 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2118 <
2119 <        assertTrue(g.cancel(mayInterruptIfRunning));
2120 <        checkCompletedWithWrappedCancellationException(h);
2121 <        f.complete(v1);
2122 <
2123 <        checkCancelled(g);
2124 <        assertEquals(0, r.invocationCount);
2125 <        checkCompletedNormally(f, v1);
2126 <        checkCompletedWithWrappedCancellationException(h);
2127 <    }}
2128 <
2129 <    public void testAcceptEither_sourceCancelled3() {
2130 <        for (ExecutionMode m : ExecutionMode.values())
2131 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2132 <        for (Integer v1 : new Integer[] { 1, null })
2133 <    {
2134 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2135 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2136 <        final IncAction r = new IncAction();
2370 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2371 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2372 >        checkIncomplete(h0);
2373 >        checkIncomplete(h1);
2374 >        rs[0].assertNotInvoked();
2375 >        rs[1].assertNotInvoked();
2376 >        f.cancel(mayInterruptIfRunning);
2377 >        checkCompletedWithWrappedCancellationException(h0);
2378 >        checkCompletedWithWrappedCancellationException(h1);
2379 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2380 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2381 >        checkCompletedWithWrappedCancellationException(h2);
2382 >        checkCompletedWithWrappedCancellationException(h3);
2383  
2384 <        assertTrue(g.cancel(mayInterruptIfRunning));
2139 <        f.complete(v1);
2140 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2384 >        g.complete(v1);
2385  
2386 <        // unspecified behavior
2387 <        Integer v;
2386 >        // unspecified behavior - both source completions available
2387 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2388 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2389          try {
2390 <            assertNull(h.join());
2391 <            assertEquals(1, r.invocationCount);
2147 <            assertEquals(inc(v1), r.value);
2390 >            assertNull(h4.join());
2391 >            rs[4].assertValue(v1);
2392          } catch (CompletionException ok) {
2393 <            checkCompletedWithWrappedCancellationException(h);
2394 <            assertEquals(0, r.invocationCount);
2393 >            checkCompletedWithWrappedCancellationException(h4);
2394 >            rs[4].assertNotInvoked();
2395          }
2152
2153        checkCancelled(g);
2154        checkCompletedNormally(f, v1);
2155    }}
2156
2157    public void testAcceptEither_sourceCancelled4() {
2158        for (ExecutionMode m : ExecutionMode.values())
2159        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2160        for (Integer v1 : new Integer[] { 1, null })
2161    {
2162        final CompletableFuture<Integer> f = new CompletableFuture<>();
2163        final CompletableFuture<Integer> g = new CompletableFuture<>();
2164        final IncAction r = new IncAction();
2165
2166        assertTrue(f.cancel(mayInterruptIfRunning));
2167        g.complete(v1);
2168        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2169
2170        // unspecified behavior
2171        Integer v;
2396          try {
2397 <            assertNull(h.join());
2398 <            assertEquals(1, r.invocationCount);
2175 <            assertEquals(inc(v1), r.value);
2397 >            assertNull(h5.join());
2398 >            rs[5].assertValue(v1);
2399          } catch (CompletionException ok) {
2400 <            checkCompletedWithWrappedCancellationException(h);
2401 <            assertEquals(0, r.invocationCount);
2400 >            checkCompletedWithWrappedCancellationException(h5);
2401 >            rs[5].assertNotInvoked();
2402          }
2403  
2404          checkCancelled(f);
2405          checkCompletedNormally(g, v1);
2406 +        checkCompletedWithWrappedCancellationException(h0);
2407 +        checkCompletedWithWrappedCancellationException(h1);
2408 +        checkCompletedWithWrappedCancellationException(h2);
2409 +        checkCompletedWithWrappedCancellationException(h3);
2410 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2411      }}
2412  
2413      /**
2414 <     * runAfterEither result completes normally after normal completion
2187 <     * of either source
2414 >     * acceptEither result completes exceptionally if action does
2415       */
2416 <    public void testRunAfterEither_normalCompletion1() {
2416 >    public void testAcceptEither_actionFailed() {
2417          for (ExecutionMode m : ExecutionMode.values())
2418          for (Integer v1 : new Integer[] { 1, null })
2419          for (Integer v2 : new Integer[] { 2, null })
2420      {
2421          final CompletableFuture<Integer> f = new CompletableFuture<>();
2422          final CompletableFuture<Integer> g = new CompletableFuture<>();
2423 <        final Noop r = new Noop(m);
2424 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2423 >        final FailingConsumer[] rs = new FailingConsumer[6];
2424 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
2425  
2426 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2427 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2428          f.complete(v1);
2429 <        checkCompletedNormally(h, null);
2430 <        assertEquals(1, r.invocationCount);
2429 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2430 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2431 >        checkCompletedWithWrappedCFException(h0);
2432 >        checkCompletedWithWrappedCFException(h1);
2433 >        checkCompletedWithWrappedCFException(h2);
2434 >        checkCompletedWithWrappedCFException(h3);
2435 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2436 >
2437          g.complete(v2);
2438  
2439 +        // unspecified behavior - both source completions available
2440 +        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2441 +        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2442 +
2443 +        checkCompletedWithWrappedCFException(h4);
2444 +        assertTrue(Objects.equals(v1, rs[4].value) ||
2445 +                   Objects.equals(v2, rs[4].value));
2446 +        checkCompletedWithWrappedCFException(h5);
2447 +        assertTrue(Objects.equals(v1, rs[5].value) ||
2448 +                   Objects.equals(v2, rs[5].value));
2449 +
2450          checkCompletedNormally(f, v1);
2451          checkCompletedNormally(g, v2);
2206        checkCompletedNormally(h, null);
2207        assertEquals(1, r.invocationCount);
2452      }}
2453  
2454 <    public void testRunAfterEither_normalCompletion2() {
2454 >    /**
2455 >     * runAfterEither result completes normally after normal completion
2456 >     * of either source
2457 >     */
2458 >    public void testRunAfterEither_normalCompletion() {
2459          for (ExecutionMode m : ExecutionMode.values())
2460          for (Integer v1 : new Integer[] { 1, null })
2461          for (Integer v2 : new Integer[] { 2, null })
2462      {
2463          final CompletableFuture<Integer> f = new CompletableFuture<>();
2464          final CompletableFuture<Integer> g = new CompletableFuture<>();
2465 <        final Noop r = new Noop(m);
2466 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2465 >        final Noop[] rs = new Noop[6];
2466 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2467  
2468 <        g.complete(v2);
2469 <        checkCompletedNormally(h, null);
2470 <        assertEquals(1, r.invocationCount);
2468 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2469 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2470 >        checkIncomplete(h0);
2471 >        checkIncomplete(h1);
2472 >        rs[0].assertNotInvoked();
2473 >        rs[1].assertNotInvoked();
2474          f.complete(v1);
2475 +        checkCompletedNormally(h0, null);
2476 +        checkCompletedNormally(h1, null);
2477 +        rs[0].assertInvoked();
2478 +        rs[1].assertInvoked();
2479 +        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2480 +        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2481 +        checkCompletedNormally(h2, null);
2482 +        checkCompletedNormally(h3, null);
2483 +        rs[2].assertInvoked();
2484 +        rs[3].assertInvoked();
2485  
2225        checkCompletedNormally(f, v1);
2226        checkCompletedNormally(g, v2);
2227        checkCompletedNormally(h, null);
2228        assertEquals(1, r.invocationCount);
2229        }}
2230
2231    public void testRunAfterEither_normalCompletion3() {
2232        for (ExecutionMode m : ExecutionMode.values())
2233        for (Integer v1 : new Integer[] { 1, null })
2234        for (Integer v2 : new Integer[] { 2, null })
2235    {
2236        final CompletableFuture<Integer> f = new CompletableFuture<>();
2237        final CompletableFuture<Integer> g = new CompletableFuture<>();
2238        final Noop r = new Noop(m);
2239
2240        f.complete(v1);
2486          g.complete(v2);
2242        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2487  
2488 <        checkCompletedNormally(h, null);
2488 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2489 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2490 >
2491          checkCompletedNormally(f, v1);
2492          checkCompletedNormally(g, v2);
2493 <        assertEquals(1, r.invocationCount);
2493 >        checkCompletedNormally(h0, null);
2494 >        checkCompletedNormally(h1, null);
2495 >        checkCompletedNormally(h2, null);
2496 >        checkCompletedNormally(h3, null);
2497 >        checkCompletedNormally(h4, null);
2498 >        checkCompletedNormally(h5, null);
2499 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2500      }}
2501  
2502      /**
2503       * runAfterEither result completes exceptionally after exceptional
2504       * completion of either source
2505       */
2506 <    public void testRunAfterEither_exceptionalCompletion1() {
2506 >    public void testRunAfterEither_exceptionalCompletion() {
2507          for (ExecutionMode m : ExecutionMode.values())
2508          for (Integer v1 : new Integer[] { 1, null })
2509      {
2510          final CompletableFuture<Integer> f = new CompletableFuture<>();
2511          final CompletableFuture<Integer> g = new CompletableFuture<>();
2260        final Noop r = new Noop(m);
2261        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2512          final CFException ex = new CFException();
2513 +        final Noop[] rs = new Noop[6];
2514 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2515  
2516 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2517 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2518 +        checkIncomplete(h0);
2519 +        checkIncomplete(h1);
2520 +        rs[0].assertNotInvoked();
2521 +        rs[1].assertNotInvoked();
2522          f.completeExceptionally(ex);
2523 <        checkCompletedWithWrappedCFException(h, ex);
2523 >        checkCompletedWithWrappedException(h0, ex);
2524 >        checkCompletedWithWrappedException(h1, ex);
2525 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2526 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2527 >        checkCompletedWithWrappedException(h2, ex);
2528 >        checkCompletedWithWrappedException(h3, ex);
2529 >
2530          g.complete(v1);
2531  
2532 <        assertEquals(0, r.invocationCount);
2532 >        // unspecified behavior - both source completions available
2533 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2534 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2535 >        try {
2536 >            assertNull(h4.join());
2537 >            rs[4].assertInvoked();
2538 >        } catch (CompletionException ok) {
2539 >            checkCompletedWithWrappedException(h4, ex);
2540 >            rs[4].assertNotInvoked();
2541 >        }
2542 >        try {
2543 >            assertNull(h5.join());
2544 >            rs[5].assertInvoked();
2545 >        } catch (CompletionException ok) {
2546 >            checkCompletedWithWrappedException(h5, ex);
2547 >            rs[5].assertNotInvoked();
2548 >        }
2549 >
2550 >        checkCompletedExceptionally(f, ex);
2551          checkCompletedNormally(g, v1);
2552 <        checkCompletedWithWrappedCFException(f, ex);
2553 <        checkCompletedWithWrappedCFException(h, ex);
2552 >        checkCompletedWithWrappedException(h0, ex);
2553 >        checkCompletedWithWrappedException(h1, ex);
2554 >        checkCompletedWithWrappedException(h2, ex);
2555 >        checkCompletedWithWrappedException(h3, ex);
2556 >        checkCompletedWithWrappedException(h4, ex);
2557 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2558      }}
2559  
2560      public void testRunAfterEither_exceptionalCompletion2() {
2561          for (ExecutionMode m : ExecutionMode.values())
2562 +        for (boolean fFirst : new boolean[] { true, false })
2563          for (Integer v1 : new Integer[] { 1, null })
2564      {
2565          final CompletableFuture<Integer> f = new CompletableFuture<>();
2566          final CompletableFuture<Integer> g = new CompletableFuture<>();
2280        final Noop r = new Noop(m);
2281        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2282        final CFException ex = new CFException();
2283
2284        g.completeExceptionally(ex);
2285        checkCompletedWithWrappedCFException(h, ex);
2286        f.complete(v1);
2287
2288        assertEquals(0, r.invocationCount);
2289        checkCompletedNormally(f, v1);
2290        checkCompletedWithWrappedCFException(g, ex);
2291        checkCompletedWithWrappedCFException(h, ex);
2292    }}
2293
2294    public void testRunAfterEither_exceptionalCompletion3() {
2295        for (ExecutionMode m : ExecutionMode.values())
2296        for (Integer v1 : new Integer[] { 1, null })
2297    {
2298        final CompletableFuture<Integer> f = new CompletableFuture<>();
2299        final CompletableFuture<Integer> g = new CompletableFuture<>();
2300        final Noop r = new Noop(m);
2567          final CFException ex = new CFException();
2568 +        final Noop[] rs = new Noop[6];
2569 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2570  
2571 <        g.completeExceptionally(ex);
2572 <        f.complete(v1);
2573 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2571 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2572 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2573 >        if (fFirst) {
2574 >            f.complete(v1);
2575 >            g.completeExceptionally(ex);
2576 >        } else {
2577 >            g.completeExceptionally(ex);
2578 >            f.complete(v1);
2579 >        }
2580 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2581 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2582  
2583 <        // unspecified behavior
2584 <        Integer v;
2583 >        // unspecified behavior - both source completions available
2584 >        try {
2585 >            assertEquals(null, h0.join());
2586 >            rs[0].assertInvoked();
2587 >        } catch (CompletionException ok) {
2588 >            checkCompletedWithWrappedException(h0, ex);
2589 >            rs[0].assertNotInvoked();
2590 >        }
2591 >        try {
2592 >            assertEquals(null, h1.join());
2593 >            rs[1].assertInvoked();
2594 >        } catch (CompletionException ok) {
2595 >            checkCompletedWithWrappedException(h1, ex);
2596 >            rs[1].assertNotInvoked();
2597 >        }
2598 >        try {
2599 >            assertEquals(null, h2.join());
2600 >            rs[2].assertInvoked();
2601 >        } catch (CompletionException ok) {
2602 >            checkCompletedWithWrappedException(h2, ex);
2603 >            rs[2].assertNotInvoked();
2604 >        }
2605          try {
2606 <            assertNull(h.join());
2607 <            assertEquals(1, r.invocationCount);
2606 >            assertEquals(null, h3.join());
2607 >            rs[3].assertInvoked();
2608          } catch (CompletionException ok) {
2609 <            checkCompletedWithWrappedCFException(h, ex);
2610 <            assertEquals(0, r.invocationCount);
2609 >            checkCompletedWithWrappedException(h3, ex);
2610 >            rs[3].assertNotInvoked();
2611          }
2612  
2317        checkCompletedWithWrappedCFException(g, ex);
2613          checkCompletedNormally(f, v1);
2614 +        checkCompletedExceptionally(g, ex);
2615      }}
2616  
2617 <    public void testRunAfterEither_exceptionalCompletion4() {
2617 >    /**
2618 >     * runAfterEither result completes exceptionally if either source cancelled
2619 >     */
2620 >    public void testRunAfterEither_sourceCancelled() {
2621          for (ExecutionMode m : ExecutionMode.values())
2622 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2623          for (Integer v1 : new Integer[] { 1, null })
2624      {
2625          final CompletableFuture<Integer> f = new CompletableFuture<>();
2626          final CompletableFuture<Integer> g = new CompletableFuture<>();
2627 <        final Noop r = new Noop(m);
2628 <        final CFException ex = new CFException();
2627 >        final Noop[] rs = new Noop[6];
2628 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2629 >
2630 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2631 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2632 >        checkIncomplete(h0);
2633 >        checkIncomplete(h1);
2634 >        rs[0].assertNotInvoked();
2635 >        rs[1].assertNotInvoked();
2636 >        f.cancel(mayInterruptIfRunning);
2637 >        checkCompletedWithWrappedCancellationException(h0);
2638 >        checkCompletedWithWrappedCancellationException(h1);
2639 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2640 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2641 >        checkCompletedWithWrappedCancellationException(h2);
2642 >        checkCompletedWithWrappedCancellationException(h3);
2643  
2330        f.completeExceptionally(ex);
2644          g.complete(v1);
2332        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2645  
2646 <        // unspecified behavior
2647 <        Integer v;
2646 >        // unspecified behavior - both source completions available
2647 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2648 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2649          try {
2650 <            assertNull(h.join());
2651 <            assertEquals(1, r.invocationCount);
2650 >            assertNull(h4.join());
2651 >            rs[4].assertInvoked();
2652          } catch (CompletionException ok) {
2653 <            checkCompletedWithWrappedCFException(h, ex);
2654 <            assertEquals(0, r.invocationCount);
2653 >            checkCompletedWithWrappedCancellationException(h4);
2654 >            rs[4].assertNotInvoked();
2655 >        }
2656 >        try {
2657 >            assertNull(h5.join());
2658 >            rs[5].assertInvoked();
2659 >        } catch (CompletionException ok) {
2660 >            checkCompletedWithWrappedCancellationException(h5);
2661 >            rs[5].assertNotInvoked();
2662          }
2663  
2664 <        checkCompletedWithWrappedCFException(f, ex);
2664 >        checkCancelled(f);
2665          checkCompletedNormally(g, v1);
2666 +        checkCompletedWithWrappedCancellationException(h0);
2667 +        checkCompletedWithWrappedCancellationException(h1);
2668 +        checkCompletedWithWrappedCancellationException(h2);
2669 +        checkCompletedWithWrappedCancellationException(h3);
2670 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2671      }}
2672  
2673      /**
2674       * runAfterEither result completes exceptionally if action does
2675       */
2676 <    public void testRunAfterEither_actionFailed1() {
2676 >    public void testRunAfterEither_actionFailed() {
2677          for (ExecutionMode m : ExecutionMode.values())
2678          for (Integer v1 : new Integer[] { 1, null })
2679          for (Integer v2 : new Integer[] { 2, null })
2680      {
2681          final CompletableFuture<Integer> f = new CompletableFuture<>();
2682          final CompletableFuture<Integer> g = new CompletableFuture<>();
2683 <        final FailingRunnable r = new FailingRunnable(m);
2684 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2683 >        final FailingRunnable[] rs = new FailingRunnable[6];
2684 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2685  
2686 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2687 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2688          f.complete(v1);
2689 <        checkCompletedWithWrappedCFException(h);
2689 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2690 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2691 >        checkCompletedWithWrappedCFException(h0);
2692 >        checkCompletedWithWrappedCFException(h1);
2693 >        checkCompletedWithWrappedCFException(h2);
2694 >        checkCompletedWithWrappedCFException(h3);
2695 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2696          g.complete(v2);
2697 <        checkCompletedNormally(f, v1);
2698 <        checkCompletedNormally(g, v2);
2699 <    }}
2697 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2698 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2699 >        checkCompletedWithWrappedCFException(h4);
2700 >        checkCompletedWithWrappedCFException(h5);
2701  
2368    public void testRunAfterEither_actionFailed2() {
2369        for (ExecutionMode m : ExecutionMode.values())
2370        for (Integer v1 : new Integer[] { 1, null })
2371        for (Integer v2 : new Integer[] { 2, null })
2372    {
2373        final CompletableFuture<Integer> f = new CompletableFuture<>();
2374        final CompletableFuture<Integer> g = new CompletableFuture<>();
2375        final FailingRunnable r = new FailingRunnable(m);
2376        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2377
2378        g.complete(v2);
2379        checkCompletedWithWrappedCFException(h);
2380        f.complete(v1);
2702          checkCompletedNormally(f, v1);
2703          checkCompletedNormally(g, v2);
2704 <    }}
2384 <
2385 <    /**
2386 <     * runAfterEither result completes exceptionally if either source cancelled
2387 <     */
2388 <    public void testRunAfterEither_sourceCancelled1() {
2389 <        for (ExecutionMode m : ExecutionMode.values())
2390 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2391 <        for (Integer v1 : new Integer[] { 1, null })
2392 <    {
2393 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2394 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2395 <        final Noop r = new Noop(m);
2396 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2397 <
2398 <        assertTrue(f.cancel(mayInterruptIfRunning));
2399 <        checkCompletedWithWrappedCancellationException(h);
2400 <        g.complete(v1);
2401 <
2402 <        checkCancelled(f);
2403 <        assertEquals(0, r.invocationCount);
2404 <        checkCompletedNormally(g, v1);
2405 <        checkCompletedWithWrappedCancellationException(h);
2406 <    }}
2407 <
2408 <    public void testRunAfterEither_sourceCancelled2() {
2409 <        for (ExecutionMode m : ExecutionMode.values())
2410 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2411 <        for (Integer v1 : new Integer[] { 1, null })
2412 <    {
2413 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2414 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2415 <        final Noop r = new Noop(m);
2416 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2417 <
2418 <        assertTrue(g.cancel(mayInterruptIfRunning));
2419 <        checkCompletedWithWrappedCancellationException(h);
2420 <        f.complete(v1);
2421 <
2422 <        checkCancelled(g);
2423 <        assertEquals(0, r.invocationCount);
2424 <        checkCompletedNormally(f, v1);
2425 <        checkCompletedWithWrappedCancellationException(h);
2426 <    }}
2427 <
2428 <    public void testRunAfterEither_sourceCancelled3() {
2429 <        for (ExecutionMode m : ExecutionMode.values())
2430 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2431 <        for (Integer v1 : new Integer[] { 1, null })
2432 <    {
2433 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2434 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2435 <        final Noop r = new Noop(m);
2436 <
2437 <        assertTrue(g.cancel(mayInterruptIfRunning));
2438 <        f.complete(v1);
2439 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2440 <
2441 <        // unspecified behavior
2442 <        Integer v;
2443 <        try {
2444 <            assertNull(h.join());
2445 <            assertEquals(1, r.invocationCount);
2446 <        } catch (CompletionException ok) {
2447 <            checkCompletedWithWrappedCancellationException(h);
2448 <            assertEquals(0, r.invocationCount);
2449 <        }
2450 <
2451 <        checkCancelled(g);
2452 <        checkCompletedNormally(f, v1);
2453 <    }}
2454 <
2455 <    public void testRunAfterEither_sourceCancelled4() {
2456 <        for (ExecutionMode m : ExecutionMode.values())
2457 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2458 <        for (Integer v1 : new Integer[] { 1, null })
2459 <    {
2460 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2461 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2462 <        final Noop r = new Noop(m);
2463 <
2464 <        assertTrue(f.cancel(mayInterruptIfRunning));
2465 <        g.complete(v1);
2466 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2467 <
2468 <        // unspecified behavior
2469 <        Integer v;
2470 <        try {
2471 <            assertNull(h.join());
2472 <            assertEquals(1, r.invocationCount);
2473 <        } catch (CompletionException ok) {
2474 <            checkCompletedWithWrappedCancellationException(h);
2475 <            assertEquals(0, r.invocationCount);
2476 <        }
2477 <
2478 <        checkCancelled(f);
2479 <        checkCompletedNormally(g, v1);
2704 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2705      }}
2706  
2707      /**
# Line 2495 | Line 2720 | public class CompletableFutureTest exten
2720  
2721          checkCompletedNormally(g, inc(v1));
2722          checkCompletedNormally(f, v1);
2723 <        assertEquals(1, r.invocationCount);
2723 >        r.assertValue(v1);
2724      }}
2725  
2726      /**
# Line 2513 | Line 2738 | public class CompletableFutureTest exten
2738          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2739          if (createIncomplete) f.completeExceptionally(ex);
2740  
2741 <        checkCompletedWithWrappedCFException(g, ex);
2742 <        checkCompletedWithWrappedCFException(f, ex);
2743 <        assertEquals(0, r.invocationCount);
2741 >        checkCompletedWithWrappedException(g, ex);
2742 >        checkCompletedExceptionally(f, ex);
2743 >        r.assertNotInvoked();
2744      }}
2745  
2746      /**
# Line 2575 | Line 2800 | public class CompletableFutureTest exten
2800       */
2801      public void testAllOf_normal() throws Exception {
2802          for (int k = 1; k < 20; ++k) {
2803 <            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2803 >            CompletableFuture<Integer>[] fs
2804 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2805              for (int i = 0; i < k; ++i)
2806                  fs[i] = new CompletableFuture<>();
2807              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
# Line 2589 | Line 2815 | public class CompletableFutureTest exten
2815          }
2816      }
2817  
2818 +    public void testAllOf_backwards() throws Exception {
2819 +        for (int k = 1; k < 20; ++k) {
2820 +            CompletableFuture<Integer>[] fs
2821 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2822 +            for (int i = 0; i < k; ++i)
2823 +                fs[i] = new CompletableFuture<>();
2824 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
2825 +            for (int i = k - 1; i >= 0; i--) {
2826 +                checkIncomplete(f);
2827 +                checkIncomplete(CompletableFuture.allOf(fs));
2828 +                fs[i].complete(one);
2829 +            }
2830 +            checkCompletedNormally(f, null);
2831 +            checkCompletedNormally(CompletableFuture.allOf(fs), null);
2832 +        }
2833 +    }
2834 +
2835      /**
2836       * anyOf(no component futures) returns an incomplete future
2837       */
# Line 2647 | Line 2890 | public class CompletableFutureTest exten
2890          Runnable[] throwingActions = {
2891              () -> CompletableFuture.supplyAsync(null),
2892              () -> CompletableFuture.supplyAsync(null, exec),
2893 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
2893 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
2894  
2895              () -> CompletableFuture.runAsync(null),
2896              () -> CompletableFuture.runAsync(null, exec),
# Line 2752 | Line 2995 | public class CompletableFutureTest exten
2995          assertSame(f, f.toCompletableFuture());
2996      }
2997  
2755    /**
2756     * whenComplete action executes on normal completion, propagating
2757     * source result.
2758     */
2759    public void testWhenComplete_normalCompletion1() {
2760        for (ExecutionMode m : ExecutionMode.values())
2761        for (boolean createIncomplete : new boolean[] { true, false })
2762        for (Integer v1 : new Integer[] { 1, null })
2763    {
2764        final AtomicInteger a = new AtomicInteger(0);
2765        final CompletableFuture<Integer> f = new CompletableFuture<>();
2766        if (!createIncomplete) f.complete(v1);
2767        final CompletableFuture<Integer> g = m.whenComplete
2768            (f,
2769             (Integer x, Throwable t) -> {
2770                threadAssertSame(x, v1);
2771                threadAssertNull(t);
2772                a.getAndIncrement();
2773            });
2774        if (createIncomplete) f.complete(v1);
2775
2776        checkCompletedNormally(g, v1);
2777        checkCompletedNormally(f, v1);
2778        assertEquals(1, a.get());
2779    }}
2780
2781    /**
2782     * whenComplete action executes on exceptional completion, propagating
2783     * source result.
2784     */
2785    public void testWhenComplete_exceptionalCompletion() {
2786        for (ExecutionMode m : ExecutionMode.values())
2787        for (boolean createIncomplete : new boolean[] { true, false })
2788        for (Integer v1 : new Integer[] { 1, null })
2789    {
2790        final AtomicInteger a = new AtomicInteger(0);
2791        final CFException ex = new CFException();
2792        final CompletableFuture<Integer> f = new CompletableFuture<>();
2793        if (!createIncomplete) f.completeExceptionally(ex);
2794        final CompletableFuture<Integer> g = m.whenComplete
2795            (f,
2796             (Integer x, Throwable t) -> {
2797                threadAssertNull(x);
2798                threadAssertSame(t, ex);
2799                a.getAndIncrement();
2800            });
2801        if (createIncomplete) f.completeExceptionally(ex);
2802        checkCompletedWithWrappedCFException(f, ex);
2803        checkCompletedWithWrappedCFException(g, ex);
2804        assertEquals(1, a.get());
2805    }}
2806
2807    /**
2808     * whenComplete action executes on cancelled source, propagating
2809     * CancellationException.
2810     */
2811    public void testWhenComplete_sourceCancelled() {
2812        for (ExecutionMode m : ExecutionMode.values())
2813        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2814        for (boolean createIncomplete : new boolean[] { true, false })
2815    {
2816        final AtomicInteger a = new AtomicInteger(0);
2817        final CompletableFuture<Integer> f = new CompletableFuture<>();
2818        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2819        final CompletableFuture<Integer> g = m.whenComplete
2820            (f,
2821             (Integer x, Throwable t) -> {
2822                threadAssertNull(x);
2823                threadAssertTrue(t instanceof CancellationException);
2824                a.getAndIncrement();
2825            });
2826        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2827
2828        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2829        checkCompletedWithWrappedCancellationException(g);
2830        checkCancelled(f);
2831        assertEquals(1, a.get());
2832    }}
2833
2834    /**
2835     * If a whenComplete action throws an exception when triggered by
2836     * a normal completion, it completes exceptionally
2837     */
2838    public void testWhenComplete_actionFailed() {
2839        for (boolean createIncomplete : new boolean[] { true, false })
2840        for (ExecutionMode m : ExecutionMode.values())
2841        for (Integer v1 : new Integer[] { 1, null })
2842    {
2843        final AtomicInteger a = new AtomicInteger(0);
2844        final CFException ex = new CFException();
2845        final CompletableFuture<Integer> f = new CompletableFuture<>();
2846        if (!createIncomplete) f.complete(v1);
2847        final CompletableFuture<Integer> g = m.whenComplete
2848            (f,
2849             (Integer x, Throwable t) -> {
2850                threadAssertSame(x, v1);
2851                threadAssertNull(t);
2852                a.getAndIncrement();
2853                throw ex;
2854            });
2855        if (createIncomplete) f.complete(v1);
2856        checkCompletedNormally(f, v1);
2857        checkCompletedWithWrappedCFException(g, ex);
2858        assertEquals(1, a.get());
2859    }}
2860
2861    /**
2862     * If a whenComplete action throws an exception when triggered by
2863     * a source completion that also throws an exception, the source
2864     * exception takes precedence.
2865     */
2866    public void testWhenComplete_actionFailedSourceFailed() {
2867        for (boolean createIncomplete : new boolean[] { true, false })
2868        for (ExecutionMode m : ExecutionMode.values())
2869        for (Integer v1 : new Integer[] { 1, null })
2870    {
2871        final AtomicInteger a = new AtomicInteger(0);
2872        final CFException ex1 = new CFException();
2873        final CFException ex2 = new CFException();
2874        final CompletableFuture<Integer> f = new CompletableFuture<>();
2875
2876        if (!createIncomplete) f.completeExceptionally(ex1);
2877        final CompletableFuture<Integer> g = m.whenComplete
2878            (f,
2879             (Integer x, Throwable t) -> {
2880                threadAssertSame(t, ex1);
2881                threadAssertNull(x);
2882                a.getAndIncrement();
2883                throw ex2;
2884            });
2885        if (createIncomplete) f.completeExceptionally(ex1);
2886
2887        checkCompletedWithWrappedCFException(f, ex1);
2888        checkCompletedWithWrappedCFException(g, ex1);
2889        assertEquals(1, a.get());
2890    }}
2891
2998   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines