ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.57 by jsr166, Mon Jun 2 22:48:50 2014 UTC vs.
Revision 1.74 by jsr166, Fri Jun 6 21:19:22 2014 UTC

# Line 105 | Line 105 | public class CompletableFutureTest exten
105          assertTrue(f.toString().contains("[Completed exceptionally]"));
106      }
107  
108 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
109 <                                              CFException ex) {
108 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
109 >                                                      Throwable ex) {
110          try {
111              f.get(LONG_DELAY_MS, MILLISECONDS);
112              shouldThrow();
# Line 131 | Line 131 | public class CompletableFutureTest exten
131          } catch (ExecutionException success) {
132              assertSame(ex, success.getCause());
133          } catch (Throwable fail) { threadUnexpectedException(fail); }
134 +
135          assertTrue(f.isDone());
136          assertFalse(f.isCancelled());
137          assertTrue(f.toString().contains("[Completed exceptionally]"));
138      }
139  
140 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
141 +                                                Throwable ex) {
142 +        checkCompletedExceptionallyWithRootCause(f, ex);
143 +        try {
144 +            CompletableFuture<Throwable> spy = f.handle
145 +                ((U u, Throwable t) -> t);
146 +            assertTrue(spy.join() instanceof CompletionException);
147 +            assertSame(ex, spy.join().getCause());
148 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
149 +    }
150 +
151 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
152 +        checkCompletedExceptionallyWithRootCause(f, ex);
153 +        try {
154 +            CompletableFuture<Throwable> spy = f.handle
155 +                ((U u, Throwable t) -> t);
156 +            assertSame(ex, spy.join());
157 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
158 +    }
159 +
160      void checkCancelled(CompletableFuture<?> f) {
161          try {
162              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 218 | Line 239 | public class CompletableFutureTest exten
239       */
240      public void testCompleteExceptionally() {
241          CompletableFuture<Integer> f = new CompletableFuture<>();
242 +        CFException ex = new CFException();
243          checkIncomplete(f);
244 <        f.completeExceptionally(new CFException());
245 <        checkCompletedWithWrappedCFException(f);
244 >        f.completeExceptionally(ex);
245 >        checkCompletedExceptionally(f, ex);
246      }
247  
248      /**
# Line 261 | Line 283 | public class CompletableFutureTest exten
283       * obtrudeException forces completion with given exception
284       */
285      public void testObtrudeException() {
286 <        CompletableFuture<Integer> f = new CompletableFuture<>();
287 <        checkIncomplete(f);
288 <        f.complete(one);
289 <        checkCompletedNormally(f, one);
290 <        f.obtrudeException(new CFException());
269 <        checkCompletedWithWrappedCFException(f);
286 >        for (Integer v1 : new Integer[] { 1, null })
287 >    {
288 >        CFException ex;
289 >        CompletableFuture<Integer> f;
290 >
291          f = new CompletableFuture<>();
292 <        f.obtrudeException(new CFException());
293 <        checkCompletedWithWrappedCFException(f);
292 >        f.complete(v1);
293 >        for (int i = 0; i < 2; i++) {
294 >            f.obtrudeException(ex = new CFException());
295 >            checkCompletedExceptionally(f, ex);
296 >        }
297 >
298 >        f = new CompletableFuture<>();
299 >        for (int i = 0; i < 2; i++) {
300 >            f.obtrudeException(ex = new CFException());
301 >            checkCompletedExceptionally(f, ex);
302 >        }
303 >
304          f = new CompletableFuture<>();
305 +        f.completeExceptionally(ex = new CFException());
306 +        f.obtrudeValue(v1);
307 +        checkCompletedNormally(f, v1);
308 +        f.obtrudeException(ex = new CFException());
309 +        checkCompletedExceptionally(f, ex);
310          f.completeExceptionally(new CFException());
311 <        f.obtrudeValue(four);
312 <        checkCompletedNormally(f, four);
313 <        f.obtrudeException(new CFException());
314 <        checkCompletedWithWrappedCFException(f);
279 <    }
311 >        checkCompletedExceptionally(f, ex);
312 >        f.complete(v1);
313 >        checkCompletedExceptionally(f, ex);
314 >    }}
315  
316      /**
317       * getNumberOfDependents returns number of dependent tasks
# Line 310 | Line 345 | public class CompletableFutureTest exten
345          f = new CompletableFuture<String>();
346          f.completeExceptionally(new IndexOutOfBoundsException());
347          assertTrue(f.toString().contains("[Completed exceptionally]"));
348 +
349 +        f = new CompletableFuture<String>();
350 +        f.cancel(true);
351 +        assertTrue(f.toString().contains("[Completed exceptionally]"));
352 +
353 +        f = new CompletableFuture<String>();
354 +        f.cancel(false);
355 +        assertTrue(f.toString().contains("[Completed exceptionally]"));
356      }
357  
358      /**
# Line 320 | Line 363 | public class CompletableFutureTest exten
363          checkCompletedNormally(f, "test");
364      }
365  
366 <    // Choose non-commutative actions for better coverage
366 >    abstract class CheckedAction {
367 >        int invocationCount = 0;
368 >        final ExecutionMode m;
369 >        CheckedAction(ExecutionMode m) { this.m = m; }
370 >        void invoked() {
371 >            m.checkExecutionMode();
372 >            assertEquals(0, invocationCount++);
373 >        }
374 >        void assertNotInvoked() { assertEquals(0, invocationCount); }
375 >        void assertInvoked() { assertEquals(1, invocationCount); }
376 >    }
377  
378 <    // A non-commutative function that handles and produces null values as well.
379 <    static Integer subtract(Integer x, Integer y) {
380 <        return (x == null && y == null) ? null :
381 <            ((x == null) ? 42 : x.intValue())
382 <            - ((y == null) ? 99 : y.intValue());
378 >    abstract class CheckedIntegerAction extends CheckedAction {
379 >        Integer value;
380 >        CheckedIntegerAction(ExecutionMode m) { super(m); }
381 >        void assertValue(Integer expected) {
382 >            assertInvoked();
383 >            assertEquals(expected, value);
384 >        }
385 >    }
386 >
387 >    class IntegerSupplier extends CheckedAction
388 >        implements Supplier<Integer>
389 >    {
390 >        final Integer value;
391 >        IntegerSupplier(ExecutionMode m, Integer value) {
392 >            super(m);
393 >            this.value = value;
394 >        }
395 >        public Integer get() {
396 >            invoked();
397 >            return value;
398 >        }
399      }
400  
401      // A function that handles and produces null values as well.
# Line 334 | Line 403 | public class CompletableFutureTest exten
403          return (x == null) ? null : x + 1;
404      }
405  
406 <    static final Supplier<Integer> supplyOne =
407 <        () -> Integer.valueOf(1);
408 <    static final Function<Integer, Integer> inc =
409 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
341 <    static final BiFunction<Integer, Integer, Integer> subtract =
342 <        (Integer x, Integer y) -> subtract(x, y);
343 <    static final class IncAction implements Consumer<Integer> {
344 <        int invocationCount = 0;
345 <        Integer value;
406 >    class NoopConsumer extends CheckedIntegerAction
407 >        implements Consumer<Integer>
408 >    {
409 >        NoopConsumer(ExecutionMode m) { super(m); }
410          public void accept(Integer x) {
411 <            invocationCount++;
412 <            value = inc(x);
411 >            invoked();
412 >            value = x;
413          }
414      }
415 <    static final class IncFunction implements Function<Integer,Integer> {
416 <        final ExecutionMode m;
417 <        int invocationCount = 0;
418 <        Integer value;
419 <        IncFunction(ExecutionMode m) { this.m = m; }
415 >
416 >    class IncFunction extends CheckedIntegerAction
417 >        implements Function<Integer,Integer>
418 >    {
419 >        IncFunction(ExecutionMode m) { super(m); }
420          public Integer apply(Integer x) {
421 <            m.checkExecutionMode();
358 <            invocationCount++;
421 >            invoked();
422              return value = inc(x);
423          }
424      }
425 <    static final class SubtractAction implements BiConsumer<Integer, Integer> {
426 <        final ExecutionMode m;
427 <        int invocationCount = 0;
428 <        Integer value;
429 <        // Check this action was invoked exactly once when result is computed.
430 <        SubtractAction(ExecutionMode m) { this.m = m; }
425 >
426 >    // Choose non-commutative actions for better coverage
427 >    // A non-commutative function that handles and produces null values as well.
428 >    static Integer subtract(Integer x, Integer y) {
429 >        return (x == null && y == null) ? null :
430 >            ((x == null) ? 42 : x.intValue())
431 >            - ((y == null) ? 99 : y.intValue());
432 >    }
433 >
434 >    class SubtractAction extends CheckedIntegerAction
435 >        implements BiConsumer<Integer, Integer>
436 >    {
437 >        SubtractAction(ExecutionMode m) { super(m); }
438          public void accept(Integer x, Integer y) {
439 <            m.checkExecutionMode();
370 <            invocationCount++;
439 >            invoked();
440              value = subtract(x, y);
441          }
442      }
443 <    static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
444 <        final ExecutionMode m;
445 <        int invocationCount = 0;
446 <        Integer value;
447 <        // Check this action was invoked exactly once when result is computed.
379 <        SubtractFunction(ExecutionMode m) { this.m = m; }
443 >
444 >    class SubtractFunction extends CheckedIntegerAction
445 >        implements BiFunction<Integer, Integer, Integer>
446 >    {
447 >        SubtractFunction(ExecutionMode m) { super(m); }
448          public Integer apply(Integer x, Integer y) {
449 <            m.checkExecutionMode();
382 <            invocationCount++;
449 >            invoked();
450              return value = subtract(x, y);
451          }
452      }
453 <    static final class Noop implements Runnable {
454 <        final ExecutionMode m;
455 <        int invocationCount = 0;
389 <        Noop(ExecutionMode m) { this.m = m; }
453 >
454 >    class Noop extends CheckedAction implements Runnable {
455 >        Noop(ExecutionMode m) { super(m); }
456          public void run() {
457 <            m.checkExecutionMode();
392 <            invocationCount++;
457 >            invoked();
458          }
459      }
460  
461 <    static final class FailingSupplier implements Supplier<Integer> {
462 <        final ExecutionMode m;
463 <        int invocationCount = 0;
464 <        FailingSupplier(ExecutionMode m) { this.m = m; }
461 >    class FailingSupplier extends CheckedAction
462 >        implements Supplier<Integer>
463 >    {
464 >        FailingSupplier(ExecutionMode m) { super(m); }
465          public Integer get() {
466 <            m.checkExecutionMode();
402 <            invocationCount++;
466 >            invoked();
467              throw new CFException();
468          }
469      }
470 <    static final class FailingConsumer implements Consumer<Integer> {
471 <        final ExecutionMode m;
472 <        int invocationCount = 0;
473 <        FailingConsumer(ExecutionMode m) { this.m = m; }
470 >
471 >    class FailingConsumer extends CheckedIntegerAction
472 >        implements Consumer<Integer>
473 >    {
474 >        FailingConsumer(ExecutionMode m) { super(m); }
475          public void accept(Integer x) {
476 <            m.checkExecutionMode();
477 <            invocationCount++;
476 >            invoked();
477 >            value = x;
478              throw new CFException();
479          }
480      }
481 <    static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
482 <        final ExecutionMode m;
483 <        int invocationCount = 0;
484 <        FailingBiConsumer(ExecutionMode m) { this.m = m; }
481 >
482 >    class FailingBiConsumer extends CheckedIntegerAction
483 >        implements BiConsumer<Integer, Integer>
484 >    {
485 >        FailingBiConsumer(ExecutionMode m) { super(m); }
486          public void accept(Integer x, Integer y) {
487 <            m.checkExecutionMode();
488 <            invocationCount++;
487 >            invoked();
488 >            value = subtract(x, y);
489              throw new CFException();
490          }
491      }
492 <    static final class FailingFunction implements Function<Integer, Integer> {
493 <        final ExecutionMode m;
494 <        int invocationCount = 0;
495 <        FailingFunction(ExecutionMode m) { this.m = m; }
492 >
493 >    class FailingFunction extends CheckedIntegerAction
494 >        implements Function<Integer, Integer>
495 >    {
496 >        FailingFunction(ExecutionMode m) { super(m); }
497          public Integer apply(Integer x) {
498 <            m.checkExecutionMode();
499 <            invocationCount++;
498 >            invoked();
499 >            value = x;
500              throw new CFException();
501          }
502      }
503 <    static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
504 <        final ExecutionMode m;
505 <        int invocationCount = 0;
506 <        FailingBiFunction(ExecutionMode m) { this.m = m; }
503 >
504 >    class FailingBiFunction extends CheckedIntegerAction
505 >        implements BiFunction<Integer, Integer, Integer>
506 >    {
507 >        FailingBiFunction(ExecutionMode m) { super(m); }
508          public Integer apply(Integer x, Integer y) {
509 <            m.checkExecutionMode();
510 <            invocationCount++;
509 >            invoked();
510 >            value = subtract(x, y);
511              throw new CFException();
512          }
513      }
514 <    static final class FailingRunnable implements Runnable {
515 <        final ExecutionMode m;
516 <        int invocationCount = 0;
449 <        FailingRunnable(ExecutionMode m) { this.m = m; }
514 >
515 >    class FailingRunnable extends CheckedAction implements Runnable {
516 >        FailingRunnable(ExecutionMode m) { super(m); }
517          public void run() {
518 <            m.checkExecutionMode();
452 <            invocationCount++;
518 >            invoked();
519              throw new CFException();
520          }
521      }
522  
523 <    static final class CompletableFutureInc
524 <        implements Function<Integer, CompletableFuture<Integer>> {
525 <        final ExecutionMode m;
526 <        int invocationCount = 0;
527 <        CompletableFutureInc(ExecutionMode m) { this.m = m; }
523 >
524 >    class CompletableFutureInc extends CheckedIntegerAction
525 >        implements Function<Integer, CompletableFuture<Integer>>
526 >    {
527 >        CompletableFutureInc(ExecutionMode m) { super(m); }
528          public CompletableFuture<Integer> apply(Integer x) {
529 <            m.checkExecutionMode();
530 <            invocationCount++;
529 >            invoked();
530 >            value = x;
531              CompletableFuture<Integer> f = new CompletableFuture<>();
532              f.complete(inc(x));
533              return f;
534          }
535      }
536  
537 <    static final class FailingCompletableFutureFunction
538 <        implements Function<Integer, CompletableFuture<Integer>> {
539 <        final ExecutionMode m;
540 <        int invocationCount = 0;
475 <        FailingCompletableFutureFunction(ExecutionMode m) { this.m = m; }
537 >    class FailingCompletableFutureFunction extends CheckedIntegerAction
538 >        implements Function<Integer, CompletableFuture<Integer>>
539 >    {
540 >        FailingCompletableFutureFunction(ExecutionMode m) { super(m); }
541          public CompletableFuture<Integer> apply(Integer x) {
542 <            m.checkExecutionMode();
543 <            invocationCount++;
542 >            invoked();
543 >            value = x;
544              throw new CFException();
545          }
546      }
# Line 496 | Line 561 | public class CompletableFutureTest exten
561  
562      /**
563       * Permits the testing of parallel code for the 3 different
564 <     * execution modes without repeating all the testing code.
564 >     * execution modes without copy/pasting all the test methods.
565       */
566      enum ExecutionMode {
567          DEFAULT {
568              public void checkExecutionMode() {
569 +                assertFalse(ThreadExecutor.startedCurrentThread());
570                  assertNull(ForkJoinTask.getPool());
571              }
572              public CompletableFuture<Void> runAsync(Runnable a) {
573                  throw new UnsupportedOperationException();
574              }
575 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
576 +                throw new UnsupportedOperationException();
577 +            }
578              public <T> CompletableFuture<Void> thenRun
579                  (CompletableFuture<T> f, Runnable a) {
580                  return f.thenRun(a);
# Line 577 | Line 646 | public class CompletableFutureTest exten
646              public CompletableFuture<Void> runAsync(Runnable a) {
647                  return CompletableFuture.runAsync(a);
648              }
649 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
650 +                return CompletableFuture.supplyAsync(a);
651 +            }
652              public <T> CompletableFuture<Void> thenRun
653                  (CompletableFuture<T> f, Runnable a) {
654                  return f.thenRunAsync(a);
# Line 647 | Line 719 | public class CompletableFutureTest exten
719              public CompletableFuture<Void> runAsync(Runnable a) {
720                  return CompletableFuture.runAsync(a, new ThreadExecutor());
721              }
722 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
723 +                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
724 +            }
725              public <T> CompletableFuture<Void> thenRun
726                  (CompletableFuture<T> f, Runnable a) {
727                  return f.thenRunAsync(a, new ThreadExecutor());
# Line 712 | Line 787 | public class CompletableFutureTest exten
787  
788          public abstract void checkExecutionMode();
789          public abstract CompletableFuture<Void> runAsync(Runnable a);
790 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
791          public abstract <T> CompletableFuture<Void> thenRun
792              (CompletableFuture<T> f, Runnable a);
793          public abstract <T> CompletableFuture<Void> thenAccept
# Line 819 | Line 895 | public class CompletableFutureTest exten
895              });
896          if (createIncomplete) f.completeExceptionally(ex1);
897  
898 <        checkCompletedWithWrappedCFException(g, ex2);
898 >        checkCompletedWithWrappedException(g, ex2);
899          assertEquals(1, a.get());
900      }}
901  
# Line 876 | Line 952 | public class CompletableFutureTest exten
952          if (createIncomplete) f.completeExceptionally(ex);
953  
954          checkCompletedNormally(g, v1);
955 <        checkCompletedWithWrappedCFException(f, ex);
955 >        checkCompletedExceptionally(f, ex);
956          assertEquals(1, a.get());
957      }}
958  
# Line 932 | Line 1008 | public class CompletableFutureTest exten
1008              });
1009          if (createIncomplete) f.completeExceptionally(ex1);
1010  
1011 <        checkCompletedWithWrappedCFException(g, ex2);
1012 <        checkCompletedWithWrappedCFException(f, ex1);
1011 >        checkCompletedWithWrappedException(g, ex2);
1012 >        checkCompletedExceptionally(f, ex1);
1013          assertEquals(1, a.get());
1014      }}
1015  
# Line 957 | Line 1033 | public class CompletableFutureTest exten
1033              });
1034          if (createIncomplete) f.complete(v1);
1035  
1036 <        checkCompletedWithWrappedCFException(g, ex);
1036 >        checkCompletedWithWrappedException(g, ex);
1037          checkCompletedNormally(f, v1);
1038          assertEquals(1, a.get());
1039      }}
# Line 976 | Line 1052 | public class CompletableFutureTest exten
1052          final CompletableFuture<Void> f = m.runAsync(r);
1053          assertNull(f.join());
1054          checkCompletedNormally(f, null);
1055 <        assertEquals(1, r.invocationCount);
1055 >        r.assertInvoked();
1056      }}
1057  
1058      /**
# Line 992 | Line 1068 | public class CompletableFutureTest exten
1068          final FailingRunnable r = new FailingRunnable(m);
1069          final CompletableFuture<Void> f = m.runAsync(r);
1070          checkCompletedWithWrappedCFException(f);
1071 <        assertEquals(1, r.invocationCount);
1071 >        r.assertInvoked();
1072      }}
1073  
1074      /**
1075       * supplyAsync completes with result of supplier
1076       */
1077 <    public void testSupplyAsync() {
1078 <        CompletableFuture<Integer> f;
1079 <        f = CompletableFuture.supplyAsync(supplyOne);
1080 <        assertEquals(f.join(), one);
1081 <        checkCompletedNormally(f, one);
1082 <    }
1083 <
1084 <    /**
1085 <     * supplyAsync with executor completes with result of supplier
1086 <     */
1087 <    public void testSupplyAsync2() {
1088 <        CompletableFuture<Integer> f;
1089 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
1090 <        assertEquals(f.join(), one);
1015 <        checkCompletedNormally(f, one);
1016 <    }
1077 >    public void testSupplyAsync_normalCompletion() {
1078 >        ExecutionMode[] executionModes = {
1079 >            ExecutionMode.ASYNC,
1080 >            ExecutionMode.EXECUTOR,
1081 >        };
1082 >        for (ExecutionMode m : executionModes)
1083 >        for (Integer v1 : new Integer[] { 1, null })
1084 >    {
1085 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1086 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1087 >        assertSame(v1, f.join());
1088 >        checkCompletedNormally(f, v1);
1089 >        r.assertInvoked();
1090 >    }}
1091  
1092      /**
1093       * Failing supplyAsync completes exceptionally
1094       */
1095 <    public void testSupplyAsync3() {
1096 <        FailingSupplier r = new FailingSupplier(ExecutionMode.ASYNC);
1097 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1095 >    public void testSupplyAsync_exceptionalCompletion() {
1096 >        ExecutionMode[] executionModes = {
1097 >            ExecutionMode.ASYNC,
1098 >            ExecutionMode.EXECUTOR,
1099 >        };
1100 >        for (ExecutionMode m : executionModes)
1101 >    {
1102 >        FailingSupplier r = new FailingSupplier(m);
1103 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1104          checkCompletedWithWrappedCFException(f);
1105 <        assertEquals(1, r.invocationCount);
1106 <    }
1105 >        r.assertInvoked();
1106 >    }}
1107  
1108      // seq completion methods
1109  
# Line 1046 | Line 1126 | public class CompletableFutureTest exten
1126  
1127          checkCompletedNormally(g, null);
1128          checkCompletedNormally(f, v1);
1129 <        assertEquals(1, r.invocationCount);
1129 >        r.assertInvoked();
1130      }}
1131  
1132      /**
# Line 1067 | Line 1147 | public class CompletableFutureTest exten
1147              f.completeExceptionally(ex);
1148          }
1149  
1150 <        checkCompletedWithWrappedCFException(g, ex);
1151 <        checkCompletedWithWrappedCFException(f, ex);
1152 <        assertEquals(0, r.invocationCount);
1150 >        checkCompletedWithWrappedException(g, ex);
1151 >        checkCompletedExceptionally(f, ex);
1152 >        r.assertNotInvoked();
1153      }}
1154  
1155      /**
# Line 1091 | Line 1171 | public class CompletableFutureTest exten
1171  
1172          checkCompletedWithWrappedCancellationException(g);
1173          checkCancelled(f);
1174 <        assertEquals(0, r.invocationCount);
1174 >        r.assertNotInvoked();
1175      }}
1176  
1177      /**
# Line 1134 | Line 1214 | public class CompletableFutureTest exten
1214  
1215          checkCompletedNormally(g, inc(v1));
1216          checkCompletedNormally(f, v1);
1217 <        assertEquals(1, r.invocationCount);
1217 >        r.assertValue(inc(v1));
1218      }}
1219  
1220      /**
# Line 1155 | Line 1235 | public class CompletableFutureTest exten
1235              f.completeExceptionally(ex);
1236          }
1237  
1238 <        checkCompletedWithWrappedCFException(g, ex);
1239 <        checkCompletedWithWrappedCFException(f, ex);
1240 <        assertEquals(0, r.invocationCount);
1238 >        checkCompletedWithWrappedException(g, ex);
1239 >        checkCompletedExceptionally(f, ex);
1240 >        r.assertNotInvoked();
1241      }}
1242  
1243      /**
# Line 1179 | Line 1259 | public class CompletableFutureTest exten
1259  
1260          checkCompletedWithWrappedCancellationException(g);
1261          checkCancelled(f);
1262 <        assertEquals(0, r.invocationCount);
1262 >        r.assertNotInvoked();
1263      }}
1264  
1265      /**
# Line 1212 | Line 1292 | public class CompletableFutureTest exten
1292          for (Integer v1 : new Integer[] { 1, null })
1293      {
1294          final CompletableFuture<Integer> f = new CompletableFuture<>();
1295 <        final IncAction r = new IncAction();
1295 >        final NoopConsumer r = new NoopConsumer(m);
1296          if (!createIncomplete) f.complete(v1);
1297          final CompletableFuture<Void> g = m.thenAccept(f, r);
1298          if (createIncomplete) {
# Line 1221 | Line 1301 | public class CompletableFutureTest exten
1301          }
1302  
1303          checkCompletedNormally(g, null);
1304 +        r.assertValue(v1);
1305          checkCompletedNormally(f, v1);
1225        assertEquals(1, r.invocationCount);
1226        assertEquals(inc(v1), r.value);
1306      }}
1307  
1308      /**
# Line 1236 | Line 1315 | public class CompletableFutureTest exten
1315      {
1316          final CFException ex = new CFException();
1317          final CompletableFuture<Integer> f = new CompletableFuture<>();
1318 <        final IncAction r = new IncAction();
1318 >        final NoopConsumer r = new NoopConsumer(m);
1319          if (!createIncomplete) f.completeExceptionally(ex);
1320          final CompletableFuture<Void> g = m.thenAccept(f, r);
1321          if (createIncomplete) {
# Line 1244 | Line 1323 | public class CompletableFutureTest exten
1323              f.completeExceptionally(ex);
1324          }
1325  
1326 <        checkCompletedWithWrappedCFException(g, ex);
1327 <        checkCompletedWithWrappedCFException(f, ex);
1328 <        assertEquals(0, r.invocationCount);
1326 >        checkCompletedWithWrappedException(g, ex);
1327 >        checkCompletedExceptionally(f, ex);
1328 >        r.assertNotInvoked();
1329      }}
1330  
1331      /**
1332 <     * thenAccept result completes exceptionally if action does
1332 >     * thenAccept result completes exceptionally if source cancelled
1333       */
1334 <    public void testThenAccept_actionFailed() {
1334 >    public void testThenAccept_sourceCancelled() {
1335          for (ExecutionMode m : ExecutionMode.values())
1336          for (boolean createIncomplete : new boolean[] { true, false })
1337 <        for (Integer v1 : new Integer[] { 1, null })
1337 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1338      {
1339          final CompletableFuture<Integer> f = new CompletableFuture<>();
1340 <        final FailingConsumer r = new FailingConsumer(m);
1341 <        if (!createIncomplete) f.complete(v1);
1340 >        final NoopConsumer r = new NoopConsumer(m);
1341 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1342          final CompletableFuture<Void> g = m.thenAccept(f, r);
1343          if (createIncomplete) {
1344              checkIncomplete(g);
1345 <            f.complete(v1);
1345 >            assertTrue(f.cancel(mayInterruptIfRunning));
1346          }
1347  
1348 <        checkCompletedWithWrappedCFException(g);
1349 <        checkCompletedNormally(f, v1);
1348 >        checkCompletedWithWrappedCancellationException(g);
1349 >        checkCancelled(f);
1350 >        r.assertNotInvoked();
1351      }}
1352  
1353      /**
1354 <     * thenAccept result completes exceptionally if source cancelled
1354 >     * thenAccept result completes exceptionally if action does
1355       */
1356 <    public void testThenAccept_sourceCancelled() {
1356 >    public void testThenAccept_actionFailed() {
1357          for (ExecutionMode m : ExecutionMode.values())
1358          for (boolean createIncomplete : new boolean[] { true, false })
1359 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1359 >        for (Integer v1 : new Integer[] { 1, null })
1360      {
1361          final CompletableFuture<Integer> f = new CompletableFuture<>();
1362 <        final IncAction r = new IncAction();
1363 <        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1362 >        final FailingConsumer r = new FailingConsumer(m);
1363 >        if (!createIncomplete) f.complete(v1);
1364          final CompletableFuture<Void> g = m.thenAccept(f, r);
1365          if (createIncomplete) {
1366              checkIncomplete(g);
1367 <            assertTrue(f.cancel(mayInterruptIfRunning));
1367 >            f.complete(v1);
1368          }
1369  
1370 <        checkCompletedWithWrappedCancellationException(g);
1371 <        checkCancelled(f);
1292 <        assertEquals(0, r.invocationCount);
1370 >        checkCompletedWithWrappedCFException(g);
1371 >        checkCompletedNormally(f, v1);
1372      }}
1373  
1374      /**
# Line 1313 | Line 1392 | public class CompletableFutureTest exten
1392          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1393          if (createIncomplete) {
1394              checkIncomplete(h);
1395 <            assertEquals(0, r.invocationCount);
1395 >            r.assertNotInvoked();
1396              if (!fFirst) f.complete(v1); else g.complete(v2);
1397          }
1398  
1399          checkCompletedNormally(h, subtract(v1, v2));
1400          checkCompletedNormally(f, v1);
1401          checkCompletedNormally(g, v2);
1402 <        assertEquals(1, r.invocationCount);
1402 >        r.assertValue(subtract(v1, v2));
1403      }}
1404  
1405      /**
# Line 1347 | Line 1426 | public class CompletableFutureTest exten
1426              (!fFirst ? f : g).completeExceptionally(ex);
1427          }
1428  
1429 <        checkCompletedWithWrappedCFException(h, ex);
1430 <        assertEquals(0, r.invocationCount);
1429 >        checkCompletedWithWrappedException(h, ex);
1430 >        r.assertNotInvoked();
1431          checkCompletedNormally(fFirst ? f : g, v1);
1432 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1354 <    }}
1355 <
1356 <    /**
1357 <     * thenCombine result completes exceptionally if action does
1358 <     */
1359 <    public void testThenCombine_actionFailed() {
1360 <        for (ExecutionMode m : ExecutionMode.values())
1361 <        for (boolean fFirst : new boolean[] { true, false })
1362 <        for (Integer v1 : new Integer[] { 1, null })
1363 <        for (Integer v2 : new Integer[] { 2, null })
1364 <    {
1365 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1366 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1367 <        final FailingBiFunction r = new FailingBiFunction(m);
1368 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1369 <
1370 <        if (fFirst) {
1371 <            f.complete(v1);
1372 <            g.complete(v2);
1373 <        } else {
1374 <            g.complete(v2);
1375 <            f.complete(v1);
1376 <        }
1377 <
1378 <        checkCompletedWithWrappedCFException(h);
1379 <        checkCompletedNormally(f, v1);
1380 <        checkCompletedNormally(g, v2);
1432 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1433      }}
1434  
1435      /**
# Line 1405 | Line 1457 | public class CompletableFutureTest exten
1457  
1458          checkCompletedWithWrappedCancellationException(h);
1459          checkCancelled(!fFirst ? f : g);
1460 <        assertEquals(0, r.invocationCount);
1460 >        r.assertNotInvoked();
1461          checkCompletedNormally(fFirst ? f : g, v1);
1462      }}
1463  
1464      /**
1465 +     * thenCombine result completes exceptionally if action does
1466 +     */
1467 +    public void testThenCombine_actionFailed() {
1468 +        for (ExecutionMode m : ExecutionMode.values())
1469 +        for (boolean fFirst : new boolean[] { true, false })
1470 +        for (Integer v1 : new Integer[] { 1, null })
1471 +        for (Integer v2 : new Integer[] { 2, null })
1472 +    {
1473 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1474 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1475 +        final FailingBiFunction r = new FailingBiFunction(m);
1476 +        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1477 +
1478 +        if (fFirst) {
1479 +            f.complete(v1);
1480 +            g.complete(v2);
1481 +        } else {
1482 +            g.complete(v2);
1483 +            f.complete(v1);
1484 +        }
1485 +
1486 +        checkCompletedWithWrappedCFException(h);
1487 +        checkCompletedNormally(f, v1);
1488 +        checkCompletedNormally(g, v2);
1489 +    }}
1490 +
1491 +    /**
1492       * thenAcceptBoth result completes normally after normal
1493       * completion of sources
1494       */
# Line 1430 | Line 1509 | public class CompletableFutureTest exten
1509          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1510          if (createIncomplete) {
1511              checkIncomplete(h);
1512 <            assertEquals(0, r.invocationCount);
1512 >            r.assertNotInvoked();
1513              if (!fFirst) f.complete(v1); else g.complete(v2);
1514          }
1515  
1516          checkCompletedNormally(h, null);
1517 <        assertEquals(subtract(v1, v2), r.value);
1517 >        r.assertValue(subtract(v1, v2));
1518          checkCompletedNormally(f, v1);
1519          checkCompletedNormally(g, v2);
1520      }}
# Line 1464 | Line 1543 | public class CompletableFutureTest exten
1543              (!fFirst ? f : g).completeExceptionally(ex);
1544          }
1545  
1546 <        checkCompletedWithWrappedCFException(h, ex);
1547 <        assertEquals(0, r.invocationCount);
1546 >        checkCompletedWithWrappedException(h, ex);
1547 >        r.assertNotInvoked();
1548          checkCompletedNormally(fFirst ? f : g, v1);
1549 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1471 <    }}
1472 <
1473 <    /**
1474 <     * thenAcceptBoth result completes exceptionally if action does
1475 <     */
1476 <    public void testThenAcceptBoth_actionFailed() {
1477 <        for (ExecutionMode m : ExecutionMode.values())
1478 <        for (boolean fFirst : new boolean[] { true, false })
1479 <        for (Integer v1 : new Integer[] { 1, null })
1480 <        for (Integer v2 : new Integer[] { 2, null })
1481 <    {
1482 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1483 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1484 <        final FailingBiConsumer r = new FailingBiConsumer(m);
1485 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1486 <
1487 <        if (fFirst) {
1488 <            f.complete(v1);
1489 <            g.complete(v2);
1490 <        } else {
1491 <            g.complete(v2);
1492 <            f.complete(v1);
1493 <        }
1494 <
1495 <        checkCompletedWithWrappedCFException(h);
1496 <        checkCompletedNormally(f, v1);
1497 <        checkCompletedNormally(g, v2);
1549 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1550      }}
1551  
1552      /**
# Line 1522 | Line 1574 | public class CompletableFutureTest exten
1574  
1575          checkCompletedWithWrappedCancellationException(h);
1576          checkCancelled(!fFirst ? f : g);
1577 <        assertEquals(0, r.invocationCount);
1577 >        r.assertNotInvoked();
1578          checkCompletedNormally(fFirst ? f : g, v1);
1579      }}
1580  
1581      /**
1582 +     * thenAcceptBoth result completes exceptionally if action does
1583 +     */
1584 +    public void testThenAcceptBoth_actionFailed() {
1585 +        for (ExecutionMode m : ExecutionMode.values())
1586 +        for (boolean fFirst : new boolean[] { true, false })
1587 +        for (Integer v1 : new Integer[] { 1, null })
1588 +        for (Integer v2 : new Integer[] { 2, null })
1589 +    {
1590 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1591 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1592 +        final FailingBiConsumer r = new FailingBiConsumer(m);
1593 +        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1594 +
1595 +        if (fFirst) {
1596 +            f.complete(v1);
1597 +            g.complete(v2);
1598 +        } else {
1599 +            g.complete(v2);
1600 +            f.complete(v1);
1601 +        }
1602 +
1603 +        checkCompletedWithWrappedCFException(h);
1604 +        checkCompletedNormally(f, v1);
1605 +        checkCompletedNormally(g, v2);
1606 +    }}
1607 +
1608 +    /**
1609       * runAfterBoth result completes normally after normal
1610       * completion of sources
1611       */
# Line 1547 | Line 1626 | public class CompletableFutureTest exten
1626          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1627          if (createIncomplete) {
1628              checkIncomplete(h);
1629 <            assertEquals(0, r.invocationCount);
1629 >            r.assertNotInvoked();
1630              if (!fFirst) f.complete(v1); else g.complete(v2);
1631          }
1632  
1633          checkCompletedNormally(h, null);
1634 <        assertEquals(1, r.invocationCount);
1634 >        r.assertInvoked();
1635          checkCompletedNormally(f, v1);
1636          checkCompletedNormally(g, v2);
1637      }}
# Line 1581 | Line 1660 | public class CompletableFutureTest exten
1660              (!fFirst ? f : g).completeExceptionally(ex);
1661          }
1662  
1663 <        checkCompletedWithWrappedCFException(h, ex);
1664 <        assertEquals(0, r.invocationCount);
1663 >        checkCompletedWithWrappedException(h, ex);
1664 >        r.assertNotInvoked();
1665          checkCompletedNormally(fFirst ? f : g, v1);
1666 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1588 <    }}
1589 <
1590 <    /**
1591 <     * runAfterBoth result completes exceptionally if action does
1592 <     */
1593 <    public void testRunAfterBoth_actionFailed() {
1594 <        for (ExecutionMode m : ExecutionMode.values())
1595 <        for (boolean fFirst : new boolean[] { true, false })
1596 <        for (Integer v1 : new Integer[] { 1, null })
1597 <        for (Integer v2 : new Integer[] { 2, null })
1598 <    {
1599 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1600 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1601 <        final FailingRunnable r = new FailingRunnable(m);
1602 <
1603 <        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1604 <        if (fFirst) {
1605 <            f.complete(v1);
1606 <            g.complete(v2);
1607 <        } else {
1608 <            g.complete(v2);
1609 <            f.complete(v1);
1610 <        }
1611 <        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1612 <
1613 <        checkCompletedWithWrappedCFException(h1);
1614 <        checkCompletedWithWrappedCFException(h2);
1615 <        checkCompletedNormally(f, v1);
1616 <        checkCompletedNormally(g, v2);
1666 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1667      }}
1668  
1669      /**
# Line 1642 | Line 1692 | public class CompletableFutureTest exten
1692  
1693          checkCompletedWithWrappedCancellationException(h);
1694          checkCancelled(!fFirst ? f : g);
1695 <        assertEquals(0, r.invocationCount);
1695 >        r.assertNotInvoked();
1696          checkCompletedNormally(fFirst ? f : g, v1);
1697      }}
1698  
1699      /**
1700 <     * applyToEither result completes normally after normal completion
1651 <     * of either source
1700 >     * runAfterBoth result completes exceptionally if action does
1701       */
1702 <    public void testApplyToEither_normalCompletion() {
1702 >    public void testRunAfterBoth_actionFailed() {
1703          for (ExecutionMode m : ExecutionMode.values())
1655        for (boolean createIncomplete : new boolean[] { true, false })
1704          for (boolean fFirst : new boolean[] { true, false })
1705          for (Integer v1 : new Integer[] { 1, null })
1706          for (Integer v2 : new Integer[] { 2, null })
1707      {
1708          final CompletableFuture<Integer> f = new CompletableFuture<>();
1709          final CompletableFuture<Integer> g = new CompletableFuture<>();
1710 <        final IncFunction r = new IncFunction(m);
1710 >        final FailingRunnable r1 = new FailingRunnable(m);
1711 >        final FailingRunnable r2 = new FailingRunnable(m);
1712  
1713 <        if (!createIncomplete)
1714 <            if (fFirst) f.complete(v1); else g.complete(v2);
1715 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1716 <        if (createIncomplete) {
1717 <            checkIncomplete(h);
1718 <            assertEquals(0, r.invocationCount);
1719 <            if (fFirst) f.complete(v1); else g.complete(v2);
1713 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r1);
1714 >        if (fFirst) {
1715 >            f.complete(v1);
1716 >            g.complete(v2);
1717 >        } else {
1718 >            g.complete(v2);
1719 >            f.complete(v1);
1720          }
1721 <        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1673 <        if (!fFirst) f.complete(v1); else g.complete(v2);
1721 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r2);
1722  
1723 +        checkCompletedWithWrappedCFException(h1);
1724 +        checkCompletedWithWrappedCFException(h2);
1725          checkCompletedNormally(f, v1);
1726          checkCompletedNormally(g, v2);
1677        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1727      }}
1728  
1729 <    public void testApplyToEither_normalCompletionBothAvailable() {
1729 >    /**
1730 >     * applyToEither result completes normally after normal completion
1731 >     * of either source
1732 >     */
1733 >    public void testApplyToEither_normalCompletion() {
1734          for (ExecutionMode m : ExecutionMode.values())
1682        for (boolean fFirst : new boolean[] { true, false })
1735          for (Integer v1 : new Integer[] { 1, null })
1736          for (Integer v2 : new Integer[] { 2, null })
1737      {
1738          final CompletableFuture<Integer> f = new CompletableFuture<>();
1739          final CompletableFuture<Integer> g = new CompletableFuture<>();
1740 <        final IncFunction r = new IncFunction(m);
1740 >        final IncFunction[] rs = new IncFunction[6];
1741 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1742  
1743 <        if (fFirst) {
1744 <            f.complete(v1);
1745 <            g.complete(v2);
1746 <        } else {
1747 <            g.complete(v2);
1748 <            f.complete(v1);
1749 <        }
1743 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1744 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1745 >        checkIncomplete(h0);
1746 >        checkIncomplete(h1);
1747 >        rs[0].assertNotInvoked();
1748 >        rs[1].assertNotInvoked();
1749 >        f.complete(v1);
1750 >        checkCompletedNormally(h0, inc(v1));
1751 >        checkCompletedNormally(h1, inc(v1));
1752 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1753 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1754 >        checkCompletedNormally(h2, inc(v1));
1755 >        checkCompletedNormally(h3, inc(v1));
1756 >        g.complete(v2);
1757  
1758 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1758 >        // unspecified behavior - both source completions available
1759 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1760 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1761 >        rs[4].assertValue(h4.join());
1762 >        rs[5].assertValue(h5.join());
1763 >        assertTrue(Objects.equals(inc(v1), h4.join()) ||
1764 >                   Objects.equals(inc(v2), h4.join()));
1765 >        assertTrue(Objects.equals(inc(v1), h5.join()) ||
1766 >                   Objects.equals(inc(v2), h5.join()));
1767  
1768          checkCompletedNormally(f, v1);
1769          checkCompletedNormally(g, v2);
1770 <
1771 <        // unspecified behavior
1772 <        assertTrue(Objects.equals(h.join(), inc(v1)) ||
1773 <                   Objects.equals(h.join(), inc(v2)));
1774 <        assertEquals(1, r.invocationCount);
1770 >        checkCompletedNormally(h0, inc(v1));
1771 >        checkCompletedNormally(h1, inc(v1));
1772 >        checkCompletedNormally(h2, inc(v1));
1773 >        checkCompletedNormally(h3, inc(v1));
1774 >        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
1775      }}
1776  
1777      /**
1778       * applyToEither result completes exceptionally after exceptional
1779       * completion of either source
1780       */
1781 <    public void testApplyToEither_exceptionalCompletion1() {
1781 >    public void testApplyToEither_exceptionalCompletion() {
1782          for (ExecutionMode m : ExecutionMode.values())
1715        for (boolean createIncomplete : new boolean[] { true, false })
1716        for (boolean fFirst : new boolean[] { true, false })
1783          for (Integer v1 : new Integer[] { 1, null })
1784      {
1785          final CompletableFuture<Integer> f = new CompletableFuture<>();
1786          final CompletableFuture<Integer> g = new CompletableFuture<>();
1787          final CFException ex = new CFException();
1788 <        final IncFunction r = new IncFunction(m);
1788 >        final IncFunction[] rs = new IncFunction[6];
1789 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1790  
1791 <        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1792 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1793 <        if (createIncomplete) {
1794 <            checkIncomplete(h);
1795 <            assertEquals(0, r.invocationCount);
1796 <            (fFirst ? f : g).completeExceptionally(ex);
1797 <        }
1791 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1792 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1793 >        checkIncomplete(h0);
1794 >        checkIncomplete(h1);
1795 >        rs[0].assertNotInvoked();
1796 >        rs[1].assertNotInvoked();
1797 >        f.completeExceptionally(ex);
1798 >        checkCompletedWithWrappedException(h0, ex);
1799 >        checkCompletedWithWrappedException(h1, ex);
1800 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1801 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1802 >        checkCompletedWithWrappedException(h2, ex);
1803 >        checkCompletedWithWrappedException(h3, ex);
1804 >        g.complete(v1);
1805  
1806 <        checkCompletedWithWrappedCFException(h, ex);
1807 <        (!fFirst ? f : g).complete(v1);
1806 >        // unspecified behavior - both source completions available
1807 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1808 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1809 >        try {
1810 >            assertEquals(inc(v1), h4.join());
1811 >            rs[4].assertValue(inc(v1));
1812 >        } catch (CompletionException ok) {
1813 >            checkCompletedWithWrappedException(h4, ex);
1814 >            rs[4].assertNotInvoked();
1815 >        }
1816 >        try {
1817 >            assertEquals(inc(v1), h5.join());
1818 >            rs[5].assertValue(inc(v1));
1819 >        } catch (CompletionException ok) {
1820 >            checkCompletedWithWrappedException(h5, ex);
1821 >            rs[5].assertNotInvoked();
1822 >        }
1823  
1824 <        assertEquals(0, r.invocationCount);
1825 <        checkCompletedNormally(!fFirst ? f : g, v1);
1826 <        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1827 <        checkCompletedWithWrappedCFException(h, ex);
1824 >        checkCompletedExceptionally(f, ex);
1825 >        checkCompletedNormally(g, v1);
1826 >        checkCompletedWithWrappedException(h0, ex);
1827 >        checkCompletedWithWrappedException(h1, ex);
1828 >        checkCompletedWithWrappedException(h2, ex);
1829 >        checkCompletedWithWrappedException(h3, ex);
1830 >        checkCompletedWithWrappedException(h4, ex);
1831 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1832      }}
1833  
1834      public void testApplyToEither_exceptionalCompletion2() {
1835          for (ExecutionMode m : ExecutionMode.values())
1743        for (boolean reverseArgs : new boolean[] { true, false })
1836          for (boolean fFirst : new boolean[] { true, false })
1837          for (Integer v1 : new Integer[] { 1, null })
1838      {
1839          final CompletableFuture<Integer> f = new CompletableFuture<>();
1840          final CompletableFuture<Integer> g = new CompletableFuture<>();
1749        final IncFunction r1 = new IncFunction(m);
1750        final IncFunction r2 = new IncFunction(m);
1841          final CFException ex = new CFException();
1842 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1843 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1844 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1842 >        final IncFunction[] rs = new IncFunction[6];
1843 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1844 >
1845 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1846 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1847          if (fFirst) {
1848              f.complete(v1);
1849              g.completeExceptionally(ex);
# Line 1759 | Line 1851 | public class CompletableFutureTest exten
1851              g.completeExceptionally(ex);
1852              f.complete(v1);
1853          }
1854 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1854 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1855 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1856  
1857 <        // unspecified behavior
1857 >        // unspecified behavior - both source completions available
1858 >        try {
1859 >            assertEquals(inc(v1), h0.join());
1860 >            rs[0].assertValue(inc(v1));
1861 >        } catch (CompletionException ok) {
1862 >            checkCompletedWithWrappedException(h0, ex);
1863 >            rs[0].assertNotInvoked();
1864 >        }
1865          try {
1866              assertEquals(inc(v1), h1.join());
1867 <            assertEquals(1, r1.invocationCount);
1867 >            rs[1].assertValue(inc(v1));
1868          } catch (CompletionException ok) {
1869 <            checkCompletedWithWrappedCFException(h1, ex);
1870 <            assertEquals(0, r1.invocationCount);
1869 >            checkCompletedWithWrappedException(h1, ex);
1870 >            rs[1].assertNotInvoked();
1871          }
1772
1872          try {
1873              assertEquals(inc(v1), h2.join());
1874 <            assertEquals(1, r2.invocationCount);
1874 >            rs[2].assertValue(inc(v1));
1875          } catch (CompletionException ok) {
1876 <            checkCompletedWithWrappedCFException(h2, ex);
1877 <            assertEquals(0, r2.invocationCount);
1876 >            checkCompletedWithWrappedException(h2, ex);
1877 >            rs[2].assertNotInvoked();
1878 >        }
1879 >        try {
1880 >            assertEquals(inc(v1), h3.join());
1881 >            rs[3].assertValue(inc(v1));
1882 >        } catch (CompletionException ok) {
1883 >            checkCompletedWithWrappedException(h3, ex);
1884 >            rs[3].assertNotInvoked();
1885          }
1886  
1781        checkCompletedWithWrappedCFException(g, ex);
1782        checkCompletedNormally(f, v1);
1783    }}
1784
1785    /**
1786     * applyToEither result completes exceptionally if action does
1787     */
1788    public void testApplyToEither_actionFailed1() {
1789        for (ExecutionMode m : ExecutionMode.values())
1790        for (Integer v1 : new Integer[] { 1, null })
1791        for (Integer v2 : new Integer[] { 2, null })
1792    {
1793        final CompletableFuture<Integer> f = new CompletableFuture<>();
1794        final CompletableFuture<Integer> g = new CompletableFuture<>();
1795        final FailingFunction r = new FailingFunction(m);
1796        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1797
1798        f.complete(v1);
1799        checkCompletedWithWrappedCFException(h);
1800        g.complete(v2);
1801        checkCompletedNormally(f, v1);
1802        checkCompletedNormally(g, v2);
1803    }}
1804
1805    public void testApplyToEither_actionFailed2() {
1806        for (ExecutionMode m : ExecutionMode.values())
1807        for (Integer v1 : new Integer[] { 1, null })
1808        for (Integer v2 : new Integer[] { 2, null })
1809    {
1810        final CompletableFuture<Integer> f = new CompletableFuture<>();
1811        final CompletableFuture<Integer> g = new CompletableFuture<>();
1812        final FailingFunction r = new FailingFunction(m);
1813        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1814
1815        g.complete(v2);
1816        checkCompletedWithWrappedCFException(h);
1817        f.complete(v1);
1887          checkCompletedNormally(f, v1);
1888 <        checkCompletedNormally(g, v2);
1888 >        checkCompletedExceptionally(g, ex);
1889      }}
1890  
1891      /**
1892       * applyToEither result completes exceptionally if either source cancelled
1893       */
1894 <    public void testApplyToEither_sourceCancelled1() {
1894 >    public void testApplyToEither_sourceCancelled() {
1895          for (ExecutionMode m : ExecutionMode.values())
1896          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1828        for (boolean createIncomplete : new boolean[] { true, false })
1829        for (boolean fFirst : new boolean[] { true, false })
1897          for (Integer v1 : new Integer[] { 1, null })
1898      {
1899          final CompletableFuture<Integer> f = new CompletableFuture<>();
1900          final CompletableFuture<Integer> g = new CompletableFuture<>();
1901 <        final IncFunction r = new IncFunction(m);
1901 >        final IncFunction[] rs = new IncFunction[6];
1902 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1903  
1904 <        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1905 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1906 <        if (createIncomplete) {
1907 <            checkIncomplete(h);
1908 <            assertEquals(0, r.invocationCount);
1909 <            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1910 <        }
1904 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1905 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1906 >        checkIncomplete(h0);
1907 >        checkIncomplete(h1);
1908 >        rs[0].assertNotInvoked();
1909 >        rs[1].assertNotInvoked();
1910 >        f.cancel(mayInterruptIfRunning);
1911 >        checkCompletedWithWrappedCancellationException(h0);
1912 >        checkCompletedWithWrappedCancellationException(h1);
1913 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1914 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1915 >        checkCompletedWithWrappedCancellationException(h2);
1916 >        checkCompletedWithWrappedCancellationException(h3);
1917 >        g.complete(v1);
1918  
1919 <        checkCompletedWithWrappedCancellationException(h);
1920 <        (!fFirst ? f : g).complete(v1);
1919 >        // unspecified behavior - both source completions available
1920 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
1921 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1922 >        try {
1923 >            assertEquals(inc(v1), h4.join());
1924 >            rs[4].assertValue(inc(v1));
1925 >        } catch (CompletionException ok) {
1926 >            checkCompletedWithWrappedCancellationException(h4);
1927 >            rs[4].assertNotInvoked();
1928 >        }
1929 >        try {
1930 >            assertEquals(inc(v1), h5.join());
1931 >            rs[5].assertValue(inc(v1));
1932 >        } catch (CompletionException ok) {
1933 >            checkCompletedWithWrappedCancellationException(h5);
1934 >            rs[5].assertNotInvoked();
1935 >        }
1936  
1937 <        assertEquals(0, r.invocationCount);
1938 <        checkCompletedNormally(!fFirst ? f : g, v1);
1939 <        checkCancelled(fFirst ? f : g);
1940 <        checkCompletedWithWrappedCancellationException(h);
1937 >        checkCancelled(f);
1938 >        checkCompletedNormally(g, v1);
1939 >        checkCompletedWithWrappedCancellationException(h0);
1940 >        checkCompletedWithWrappedCancellationException(h1);
1941 >        checkCompletedWithWrappedCancellationException(h2);
1942 >        checkCompletedWithWrappedCancellationException(h3);
1943 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1944      }}
1945  
1946      public void testApplyToEither_sourceCancelled2() {
1947          for (ExecutionMode m : ExecutionMode.values())
1948          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1856        for (boolean reverseArgs : new boolean[] { true, false })
1949          for (boolean fFirst : new boolean[] { true, false })
1950          for (Integer v1 : new Integer[] { 1, null })
1951      {
1952          final CompletableFuture<Integer> f = new CompletableFuture<>();
1953          final CompletableFuture<Integer> g = new CompletableFuture<>();
1954 <        final IncFunction r1 = new IncFunction(m);
1955 <        final IncFunction r2 = new IncFunction(m);
1864 <        final CFException ex = new CFException();
1865 <        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1866 <        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1954 >        final IncFunction[] rs = new IncFunction[6];
1955 >        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1956  
1957 <        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1957 >        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1958 >        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1959          if (fFirst) {
1960              f.complete(v1);
1961 <            assertTrue(g.cancel(mayInterruptIfRunning));
1961 >            g.cancel(mayInterruptIfRunning);
1962          } else {
1963 <            assertTrue(g.cancel(mayInterruptIfRunning));
1963 >            g.cancel(mayInterruptIfRunning);
1964              f.complete(v1);
1965          }
1966 <        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1966 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1967 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1968  
1969 <        // unspecified behavior
1969 >        // unspecified behavior - both source completions available
1970 >        try {
1971 >            assertEquals(inc(v1), h0.join());
1972 >            rs[0].assertValue(inc(v1));
1973 >        } catch (CompletionException ok) {
1974 >            checkCompletedWithWrappedCancellationException(h0);
1975 >            rs[0].assertNotInvoked();
1976 >        }
1977          try {
1978              assertEquals(inc(v1), h1.join());
1979 <            assertEquals(1, r1.invocationCount);
1979 >            rs[1].assertValue(inc(v1));
1980          } catch (CompletionException ok) {
1981              checkCompletedWithWrappedCancellationException(h1);
1982 <            assertEquals(0, r1.invocationCount);
1982 >            rs[1].assertNotInvoked();
1983          }
1886
1984          try {
1985              assertEquals(inc(v1), h2.join());
1986 <            assertEquals(1, r2.invocationCount);
1986 >            rs[2].assertValue(inc(v1));
1987          } catch (CompletionException ok) {
1988              checkCompletedWithWrappedCancellationException(h2);
1989 <            assertEquals(0, r2.invocationCount);
1989 >            rs[2].assertNotInvoked();
1990 >        }
1991 >        try {
1992 >            assertEquals(inc(v1), h3.join());
1993 >            rs[3].assertValue(inc(v1));
1994 >        } catch (CompletionException ok) {
1995 >            checkCompletedWithWrappedCancellationException(h3);
1996 >            rs[3].assertNotInvoked();
1997          }
1998  
1895        checkCancelled(g);
1999          checkCompletedNormally(f, v1);
2000 +        checkCancelled(g);
2001      }}
2002  
2003      /**
2004 <     * acceptEither result completes normally after normal completion
1901 <     * of either source
2004 >     * applyToEither result completes exceptionally if action does
2005       */
2006 <    public void testAcceptEither_normalCompletion1() {
2006 >    public void testApplyToEither_actionFailed() {
2007          for (ExecutionMode m : ExecutionMode.values())
2008          for (Integer v1 : new Integer[] { 1, null })
2009          for (Integer v2 : new Integer[] { 2, null })
2010      {
2011          final CompletableFuture<Integer> f = new CompletableFuture<>();
2012          final CompletableFuture<Integer> g = new CompletableFuture<>();
2013 <        final IncAction r = new IncAction();
2014 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2013 >        final FailingFunction[] rs = new FailingFunction[6];
2014 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingFunction(m);
2015  
2016 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2017 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2018          f.complete(v1);
2019 <        checkCompletedNormally(h, null);
2020 <        assertEquals(inc(v1), r.value);
2021 <        g.complete(v2);
2022 <
2023 <        checkCompletedNormally(f, v1);
2024 <        checkCompletedNormally(g, v2);
2025 <        checkCompletedNormally(h, null);
1921 <    }}
1922 <
1923 <    public void testAcceptEither_normalCompletion2() {
1924 <        for (ExecutionMode m : ExecutionMode.values())
1925 <        for (Integer v1 : new Integer[] { 1, null })
1926 <        for (Integer v2 : new Integer[] { 2, null })
1927 <    {
1928 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1929 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1930 <        final IncAction r = new IncAction();
1931 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2019 >        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2020 >        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2021 >        checkCompletedWithWrappedCFException(h0);
2022 >        checkCompletedWithWrappedCFException(h1);
2023 >        checkCompletedWithWrappedCFException(h2);
2024 >        checkCompletedWithWrappedCFException(h3);
2025 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2026  
2027          g.complete(v2);
2028 <        checkCompletedNormally(h, null);
2029 <        assertEquals(inc(v2), r.value);
2030 <        f.complete(v1);
2028 >
2029 >        // unspecified behavior - both source completions available
2030 >        final CompletableFuture<Integer> h4 = m.applyToEither(f, g, rs[4]);
2031 >        final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2032 >
2033 >        checkCompletedWithWrappedCFException(h4);
2034 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2035 >                   Objects.equals(v2, rs[4].value));
2036 >        checkCompletedWithWrappedCFException(h5);
2037 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2038 >                   Objects.equals(v2, rs[5].value));
2039  
2040          checkCompletedNormally(f, v1);
2041          checkCompletedNormally(g, v2);
1940        checkCompletedNormally(h, null);
2042      }}
2043  
2044 <    public void testAcceptEither_normalCompletion3() {
2044 >    /**
2045 >     * acceptEither result completes normally after normal completion
2046 >     * of either source
2047 >     */
2048 >    public void testAcceptEither_normalCompletion() {
2049          for (ExecutionMode m : ExecutionMode.values())
2050          for (Integer v1 : new Integer[] { 1, null })
2051          for (Integer v2 : new Integer[] { 2, null })
2052      {
2053          final CompletableFuture<Integer> f = new CompletableFuture<>();
2054          final CompletableFuture<Integer> g = new CompletableFuture<>();
2055 <        final IncAction r = new IncAction();
2055 >        final NoopConsumer[] rs = new NoopConsumer[6];
2056 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2057  
2058 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2059 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2060 +        checkIncomplete(h0);
2061 +        checkIncomplete(h1);
2062 +        rs[0].assertNotInvoked();
2063 +        rs[1].assertNotInvoked();
2064          f.complete(v1);
2065 +        checkCompletedNormally(h0, null);
2066 +        checkCompletedNormally(h1, null);
2067 +        rs[0].assertValue(v1);
2068 +        rs[1].assertValue(v1);
2069 +        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2070 +        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2071 +        checkCompletedNormally(h2, null);
2072 +        checkCompletedNormally(h3, null);
2073 +        rs[2].assertValue(v1);
2074 +        rs[3].assertValue(v1);
2075          g.complete(v2);
1954        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2076  
2077 <        checkCompletedNormally(h, null);
2077 >        // unspecified behavior - both source completions available
2078 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2079 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2080 >        checkCompletedNormally(h4, null);
2081 >        checkCompletedNormally(h5, null);
2082 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2083 >                   Objects.equals(v2, rs[4].value));
2084 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2085 >                   Objects.equals(v2, rs[5].value));
2086 >
2087          checkCompletedNormally(f, v1);
2088          checkCompletedNormally(g, v2);
2089 <
2090 <        // unspecified behavior
2091 <        assertTrue(Objects.equals(r.value, inc(v1)) ||
2092 <                   Objects.equals(r.value, inc(v2)));
2089 >        checkCompletedNormally(h0, null);
2090 >        checkCompletedNormally(h1, null);
2091 >        checkCompletedNormally(h2, null);
2092 >        checkCompletedNormally(h3, null);
2093 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2094      }}
2095  
2096      /**
2097       * acceptEither result completes exceptionally after exceptional
2098       * completion of either source
2099       */
2100 <    public void testAcceptEither_exceptionalCompletion1() {
2100 >    public void testAcceptEither_exceptionalCompletion() {
2101          for (ExecutionMode m : ExecutionMode.values())
2102          for (Integer v1 : new Integer[] { 1, null })
2103      {
2104          final CompletableFuture<Integer> f = new CompletableFuture<>();
2105          final CompletableFuture<Integer> g = new CompletableFuture<>();
1975        final IncAction r = new IncAction();
1976        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2106          final CFException ex = new CFException();
2107 +        final NoopConsumer[] rs = new NoopConsumer[6];
2108 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2109  
2110 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2111 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2112 +        checkIncomplete(h0);
2113 +        checkIncomplete(h1);
2114 +        rs[0].assertNotInvoked();
2115 +        rs[1].assertNotInvoked();
2116          f.completeExceptionally(ex);
2117 <        checkCompletedWithWrappedCFException(h, ex);
2117 >        checkCompletedWithWrappedException(h0, ex);
2118 >        checkCompletedWithWrappedException(h1, ex);
2119 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2120 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2121 >        checkCompletedWithWrappedException(h2, ex);
2122 >        checkCompletedWithWrappedException(h3, ex);
2123 >
2124          g.complete(v1);
2125  
2126 <        assertEquals(0, r.invocationCount);
2126 >        // unspecified behavior - both source completions available
2127 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2128 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2129 >        try {
2130 >            assertNull(h4.join());
2131 >            rs[4].assertValue(v1);
2132 >        } catch (CompletionException ok) {
2133 >            checkCompletedWithWrappedException(h4, ex);
2134 >            rs[4].assertNotInvoked();
2135 >        }
2136 >        try {
2137 >            assertNull(h5.join());
2138 >            rs[5].assertValue(v1);
2139 >        } catch (CompletionException ok) {
2140 >            checkCompletedWithWrappedException(h5, ex);
2141 >            rs[5].assertNotInvoked();
2142 >        }
2143 >
2144 >        checkCompletedExceptionally(f, ex);
2145          checkCompletedNormally(g, v1);
2146 <        checkCompletedWithWrappedCFException(f, ex);
2147 <        checkCompletedWithWrappedCFException(h, ex);
2146 >        checkCompletedWithWrappedException(h0, ex);
2147 >        checkCompletedWithWrappedException(h1, ex);
2148 >        checkCompletedWithWrappedException(h2, ex);
2149 >        checkCompletedWithWrappedException(h3, ex);
2150 >        checkCompletedWithWrappedException(h4, ex);
2151 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2152      }}
2153  
2154      public void testAcceptEither_exceptionalCompletion2() {
2155          for (ExecutionMode m : ExecutionMode.values())
2156 +        for (boolean fFirst : new boolean[] { true, false })
2157          for (Integer v1 : new Integer[] { 1, null })
2158      {
2159          final CompletableFuture<Integer> f = new CompletableFuture<>();
2160          final CompletableFuture<Integer> g = new CompletableFuture<>();
1995        final IncAction r = new IncAction();
1996        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
1997        final CFException ex = new CFException();
1998
1999        g.completeExceptionally(ex);
2000        checkCompletedWithWrappedCFException(h, ex);
2001        f.complete(v1);
2002
2003        assertEquals(0, r.invocationCount);
2004        checkCompletedNormally(f, v1);
2005        checkCompletedWithWrappedCFException(g, ex);
2006        checkCompletedWithWrappedCFException(h, ex);
2007    }}
2008
2009    public void testAcceptEither_exceptionalCompletion3() {
2010        for (ExecutionMode m : ExecutionMode.values())
2011        for (Integer v1 : new Integer[] { 1, null })
2012    {
2013        final CompletableFuture<Integer> f = new CompletableFuture<>();
2014        final CompletableFuture<Integer> g = new CompletableFuture<>();
2015        final IncAction r = new IncAction();
2161          final CFException ex = new CFException();
2162 +        final NoopConsumer[] rs = new NoopConsumer[6];
2163 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2164  
2165 <        g.completeExceptionally(ex);
2166 <        f.complete(v1);
2167 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2165 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2166 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2167 >        if (fFirst) {
2168 >            f.complete(v1);
2169 >            g.completeExceptionally(ex);
2170 >        } else {
2171 >            g.completeExceptionally(ex);
2172 >            f.complete(v1);
2173 >        }
2174 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2175 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2176  
2177 <        // unspecified behavior
2023 <        Integer v;
2177 >        // unspecified behavior - both source completions available
2178          try {
2179 <            assertNull(h.join());
2180 <            assertEquals(1, r.invocationCount);
2027 <            assertEquals(inc(v1), r.value);
2179 >            assertEquals(null, h0.join());
2180 >            rs[0].assertValue(v1);
2181          } catch (CompletionException ok) {
2182 <            checkCompletedWithWrappedCFException(h, ex);
2183 <            assertEquals(0, r.invocationCount);
2182 >            checkCompletedWithWrappedException(h0, ex);
2183 >            rs[0].assertNotInvoked();
2184          }
2032
2033        checkCompletedWithWrappedCFException(g, ex);
2034        checkCompletedNormally(f, v1);
2035    }}
2036
2037    public void testAcceptEither_exceptionalCompletion4() {
2038        for (ExecutionMode m : ExecutionMode.values())
2039        for (Integer v1 : new Integer[] { 1, null })
2040    {
2041        final CompletableFuture<Integer> f = new CompletableFuture<>();
2042        final CompletableFuture<Integer> g = new CompletableFuture<>();
2043        final IncAction r = new IncAction();
2044        final CFException ex = new CFException();
2045
2046        f.completeExceptionally(ex);
2047        g.complete(v1);
2048        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2049
2050        // unspecified behavior
2051        Integer v;
2185          try {
2186 <            assertNull(h.join());
2187 <            assertEquals(1, r.invocationCount);
2055 <            assertEquals(inc(v1), r.value);
2186 >            assertEquals(null, h1.join());
2187 >            rs[1].assertValue(v1);
2188          } catch (CompletionException ok) {
2189 <            checkCompletedWithWrappedCFException(h, ex);
2190 <            assertEquals(0, r.invocationCount);
2189 >            checkCompletedWithWrappedException(h1, ex);
2190 >            rs[1].assertNotInvoked();
2191 >        }
2192 >        try {
2193 >            assertEquals(null, h2.join());
2194 >            rs[2].assertValue(v1);
2195 >        } catch (CompletionException ok) {
2196 >            checkCompletedWithWrappedException(h2, ex);
2197 >            rs[2].assertNotInvoked();
2198 >        }
2199 >        try {
2200 >            assertEquals(null, h3.join());
2201 >            rs[3].assertValue(v1);
2202 >        } catch (CompletionException ok) {
2203 >            checkCompletedWithWrappedException(h3, ex);
2204 >            rs[3].assertNotInvoked();
2205          }
2206  
2061        checkCompletedWithWrappedCFException(f, ex);
2062        checkCompletedNormally(g, v1);
2063    }}
2064
2065    /**
2066     * acceptEither result completes exceptionally if action does
2067     */
2068    public void testAcceptEither_actionFailed1() {
2069        for (ExecutionMode m : ExecutionMode.values())
2070        for (Integer v1 : new Integer[] { 1, null })
2071        for (Integer v2 : new Integer[] { 2, null })
2072    {
2073        final CompletableFuture<Integer> f = new CompletableFuture<>();
2074        final CompletableFuture<Integer> g = new CompletableFuture<>();
2075        final FailingConsumer r = new FailingConsumer(m);
2076        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2077
2078        f.complete(v1);
2079        checkCompletedWithWrappedCFException(h);
2080        g.complete(v2);
2081        checkCompletedNormally(f, v1);
2082        checkCompletedNormally(g, v2);
2083    }}
2084
2085    public void testAcceptEither_actionFailed2() {
2086        for (ExecutionMode m : ExecutionMode.values())
2087        for (Integer v1 : new Integer[] { 1, null })
2088        for (Integer v2 : new Integer[] { 2, null })
2089    {
2090        final CompletableFuture<Integer> f = new CompletableFuture<>();
2091        final CompletableFuture<Integer> g = new CompletableFuture<>();
2092        final FailingConsumer r = new FailingConsumer(m);
2093        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2094
2095        g.complete(v2);
2096        checkCompletedWithWrappedCFException(h);
2097        f.complete(v1);
2207          checkCompletedNormally(f, v1);
2208 <        checkCompletedNormally(g, v2);
2208 >        checkCompletedExceptionally(g, ex);
2209      }}
2210  
2211      /**
2212       * acceptEither result completes exceptionally if either source cancelled
2213       */
2214 <    public void testAcceptEither_sourceCancelled1() {
2214 >    public void testAcceptEither_sourceCancelled() {
2215          for (ExecutionMode m : ExecutionMode.values())
2216          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2217          for (Integer v1 : new Integer[] { 1, null })
2218      {
2219          final CompletableFuture<Integer> f = new CompletableFuture<>();
2220          final CompletableFuture<Integer> g = new CompletableFuture<>();
2221 <        final IncAction r = new IncAction();
2222 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2221 >        final NoopConsumer[] rs = new NoopConsumer[6];
2222 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2223  
2224 <        assertTrue(f.cancel(mayInterruptIfRunning));
2225 <        checkCompletedWithWrappedCancellationException(h);
2226 <        g.complete(v1);
2224 >        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2225 >        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2226 >        checkIncomplete(h0);
2227 >        checkIncomplete(h1);
2228 >        rs[0].assertNotInvoked();
2229 >        rs[1].assertNotInvoked();
2230 >        f.cancel(mayInterruptIfRunning);
2231 >        checkCompletedWithWrappedCancellationException(h0);
2232 >        checkCompletedWithWrappedCancellationException(h1);
2233 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2234 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2235 >        checkCompletedWithWrappedCancellationException(h2);
2236 >        checkCompletedWithWrappedCancellationException(h3);
2237  
2238 <        checkCancelled(f);
2120 <        assertEquals(0, r.invocationCount);
2121 <        checkCompletedNormally(g, v1);
2122 <        checkCompletedWithWrappedCancellationException(h);
2123 <    }}
2124 <
2125 <    public void testAcceptEither_sourceCancelled2() {
2126 <        for (ExecutionMode m : ExecutionMode.values())
2127 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2128 <        for (Integer v1 : new Integer[] { 1, null })
2129 <    {
2130 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2131 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2132 <        final IncAction r = new IncAction();
2133 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2134 <
2135 <        assertTrue(g.cancel(mayInterruptIfRunning));
2136 <        checkCompletedWithWrappedCancellationException(h);
2137 <        f.complete(v1);
2138 <
2139 <        checkCancelled(g);
2140 <        assertEquals(0, r.invocationCount);
2141 <        checkCompletedNormally(f, v1);
2142 <        checkCompletedWithWrappedCancellationException(h);
2143 <    }}
2144 <
2145 <    public void testAcceptEither_sourceCancelled3() {
2146 <        for (ExecutionMode m : ExecutionMode.values())
2147 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2148 <        for (Integer v1 : new Integer[] { 1, null })
2149 <    {
2150 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2151 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2152 <        final IncAction r = new IncAction();
2153 <
2154 <        assertTrue(g.cancel(mayInterruptIfRunning));
2155 <        f.complete(v1);
2156 <        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2238 >        g.complete(v1);
2239  
2240 <        // unspecified behavior
2241 <        Integer v;
2240 >        // unspecified behavior - both source completions available
2241 >        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2242 >        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2243          try {
2244 <            assertNull(h.join());
2245 <            assertEquals(1, r.invocationCount);
2163 <            assertEquals(inc(v1), r.value);
2244 >            assertNull(h4.join());
2245 >            rs[4].assertValue(v1);
2246          } catch (CompletionException ok) {
2247 <            checkCompletedWithWrappedCancellationException(h);
2248 <            assertEquals(0, r.invocationCount);
2247 >            checkCompletedWithWrappedCancellationException(h4);
2248 >            rs[4].assertNotInvoked();
2249          }
2168
2169        checkCancelled(g);
2170        checkCompletedNormally(f, v1);
2171    }}
2172
2173    public void testAcceptEither_sourceCancelled4() {
2174        for (ExecutionMode m : ExecutionMode.values())
2175        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2176        for (Integer v1 : new Integer[] { 1, null })
2177    {
2178        final CompletableFuture<Integer> f = new CompletableFuture<>();
2179        final CompletableFuture<Integer> g = new CompletableFuture<>();
2180        final IncAction r = new IncAction();
2181
2182        assertTrue(f.cancel(mayInterruptIfRunning));
2183        g.complete(v1);
2184        final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2185
2186        // unspecified behavior
2187        Integer v;
2250          try {
2251 <            assertNull(h.join());
2252 <            assertEquals(1, r.invocationCount);
2191 <            assertEquals(inc(v1), r.value);
2251 >            assertNull(h5.join());
2252 >            rs[5].assertValue(v1);
2253          } catch (CompletionException ok) {
2254 <            checkCompletedWithWrappedCancellationException(h);
2255 <            assertEquals(0, r.invocationCount);
2254 >            checkCompletedWithWrappedCancellationException(h5);
2255 >            rs[5].assertNotInvoked();
2256          }
2257  
2258          checkCancelled(f);
2259          checkCompletedNormally(g, v1);
2260 +        checkCompletedWithWrappedCancellationException(h0);
2261 +        checkCompletedWithWrappedCancellationException(h1);
2262 +        checkCompletedWithWrappedCancellationException(h2);
2263 +        checkCompletedWithWrappedCancellationException(h3);
2264 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2265      }}
2266  
2267      /**
2268 <     * runAfterEither result completes normally after normal completion
2203 <     * of either source
2268 >     * acceptEither result completes exceptionally if action does
2269       */
2270 <    public void testRunAfterEither_normalCompletion1() {
2270 >    public void testAcceptEither_actionFailed() {
2271          for (ExecutionMode m : ExecutionMode.values())
2272          for (Integer v1 : new Integer[] { 1, null })
2273          for (Integer v2 : new Integer[] { 2, null })
2274      {
2275          final CompletableFuture<Integer> f = new CompletableFuture<>();
2276          final CompletableFuture<Integer> g = new CompletableFuture<>();
2277 <        final Noop r = new Noop(m);
2278 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2277 >        final FailingConsumer[] rs = new FailingConsumer[6];
2278 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingConsumer(m);
2279  
2280 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2281 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2282          f.complete(v1);
2283 <        checkCompletedNormally(h, null);
2284 <        assertEquals(1, r.invocationCount);
2283 >        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2284 >        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2285 >        checkCompletedWithWrappedCFException(h0);
2286 >        checkCompletedWithWrappedCFException(h1);
2287 >        checkCompletedWithWrappedCFException(h2);
2288 >        checkCompletedWithWrappedCFException(h3);
2289 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2290 >
2291          g.complete(v2);
2292  
2293 +        // unspecified behavior - both source completions available
2294 +        final CompletableFuture<Void> h4 = m.acceptEither(f, g, rs[4]);
2295 +        final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2296 +
2297 +        checkCompletedWithWrappedCFException(h4);
2298 +        assertTrue(Objects.equals(v1, rs[4].value) ||
2299 +                   Objects.equals(v2, rs[4].value));
2300 +        checkCompletedWithWrappedCFException(h5);
2301 +        assertTrue(Objects.equals(v1, rs[5].value) ||
2302 +                   Objects.equals(v2, rs[5].value));
2303 +
2304          checkCompletedNormally(f, v1);
2305          checkCompletedNormally(g, v2);
2222        checkCompletedNormally(h, null);
2223        assertEquals(1, r.invocationCount);
2306      }}
2307  
2308 <    public void testRunAfterEither_normalCompletion2() {
2308 >    /**
2309 >     * runAfterEither result completes normally after normal completion
2310 >     * of either source
2311 >     */
2312 >    public void testRunAfterEither_normalCompletion() {
2313          for (ExecutionMode m : ExecutionMode.values())
2314          for (Integer v1 : new Integer[] { 1, null })
2315          for (Integer v2 : new Integer[] { 2, null })
2316      {
2317          final CompletableFuture<Integer> f = new CompletableFuture<>();
2318          final CompletableFuture<Integer> g = new CompletableFuture<>();
2319 <        final Noop r = new Noop(m);
2320 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2319 >        final Noop[] rs = new Noop[6];
2320 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2321  
2322 <        g.complete(v2);
2323 <        checkCompletedNormally(h, null);
2324 <        assertEquals(1, r.invocationCount);
2322 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2323 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2324 >        checkIncomplete(h0);
2325 >        checkIncomplete(h1);
2326 >        rs[0].assertNotInvoked();
2327 >        rs[1].assertNotInvoked();
2328          f.complete(v1);
2329 +        checkCompletedNormally(h0, null);
2330 +        checkCompletedNormally(h1, null);
2331 +        rs[0].assertInvoked();
2332 +        rs[1].assertInvoked();
2333 +        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2334 +        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2335 +        checkCompletedNormally(h2, null);
2336 +        checkCompletedNormally(h3, null);
2337 +        rs[2].assertInvoked();
2338 +        rs[3].assertInvoked();
2339  
2241        checkCompletedNormally(f, v1);
2242        checkCompletedNormally(g, v2);
2243        checkCompletedNormally(h, null);
2244        assertEquals(1, r.invocationCount);
2245        }}
2246
2247    public void testRunAfterEither_normalCompletion3() {
2248        for (ExecutionMode m : ExecutionMode.values())
2249        for (Integer v1 : new Integer[] { 1, null })
2250        for (Integer v2 : new Integer[] { 2, null })
2251    {
2252        final CompletableFuture<Integer> f = new CompletableFuture<>();
2253        final CompletableFuture<Integer> g = new CompletableFuture<>();
2254        final Noop r = new Noop(m);
2255
2256        f.complete(v1);
2340          g.complete(v2);
2258        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2341  
2342 <        checkCompletedNormally(h, null);
2342 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2343 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2344 >
2345          checkCompletedNormally(f, v1);
2346          checkCompletedNormally(g, v2);
2347 <        assertEquals(1, r.invocationCount);
2347 >        checkCompletedNormally(h0, null);
2348 >        checkCompletedNormally(h1, null);
2349 >        checkCompletedNormally(h2, null);
2350 >        checkCompletedNormally(h3, null);
2351 >        checkCompletedNormally(h4, null);
2352 >        checkCompletedNormally(h5, null);
2353 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2354      }}
2355  
2356      /**
2357       * runAfterEither result completes exceptionally after exceptional
2358       * completion of either source
2359       */
2360 <    public void testRunAfterEither_exceptionalCompletion1() {
2360 >    public void testRunAfterEither_exceptionalCompletion() {
2361          for (ExecutionMode m : ExecutionMode.values())
2362          for (Integer v1 : new Integer[] { 1, null })
2363      {
2364          final CompletableFuture<Integer> f = new CompletableFuture<>();
2365          final CompletableFuture<Integer> g = new CompletableFuture<>();
2276        final Noop r = new Noop(m);
2277        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2366          final CFException ex = new CFException();
2367 +        final Noop[] rs = new Noop[6];
2368 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2369  
2370 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2371 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2372 +        checkIncomplete(h0);
2373 +        checkIncomplete(h1);
2374 +        rs[0].assertNotInvoked();
2375 +        rs[1].assertNotInvoked();
2376          f.completeExceptionally(ex);
2377 <        checkCompletedWithWrappedCFException(h, ex);
2377 >        checkCompletedWithWrappedException(h0, ex);
2378 >        checkCompletedWithWrappedException(h1, ex);
2379 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2380 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2381 >        checkCompletedWithWrappedException(h2, ex);
2382 >        checkCompletedWithWrappedException(h3, ex);
2383 >
2384          g.complete(v1);
2385  
2386 <        assertEquals(0, r.invocationCount);
2386 >        // unspecified behavior - both source completions available
2387 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2388 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2389 >        try {
2390 >            assertNull(h4.join());
2391 >            rs[4].assertInvoked();
2392 >        } catch (CompletionException ok) {
2393 >            checkCompletedWithWrappedException(h4, ex);
2394 >            rs[4].assertNotInvoked();
2395 >        }
2396 >        try {
2397 >            assertNull(h5.join());
2398 >            rs[5].assertInvoked();
2399 >        } catch (CompletionException ok) {
2400 >            checkCompletedWithWrappedException(h5, ex);
2401 >            rs[5].assertNotInvoked();
2402 >        }
2403 >
2404 >        checkCompletedExceptionally(f, ex);
2405          checkCompletedNormally(g, v1);
2406 <        checkCompletedWithWrappedCFException(f, ex);
2407 <        checkCompletedWithWrappedCFException(h, ex);
2406 >        checkCompletedWithWrappedException(h0, ex);
2407 >        checkCompletedWithWrappedException(h1, ex);
2408 >        checkCompletedWithWrappedException(h2, ex);
2409 >        checkCompletedWithWrappedException(h3, ex);
2410 >        checkCompletedWithWrappedException(h4, ex);
2411 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2412      }}
2413  
2414      public void testRunAfterEither_exceptionalCompletion2() {
2415          for (ExecutionMode m : ExecutionMode.values())
2416 +        for (boolean fFirst : new boolean[] { true, false })
2417          for (Integer v1 : new Integer[] { 1, null })
2418      {
2419          final CompletableFuture<Integer> f = new CompletableFuture<>();
2420          final CompletableFuture<Integer> g = new CompletableFuture<>();
2296        final Noop r = new Noop(m);
2297        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2298        final CFException ex = new CFException();
2299
2300        g.completeExceptionally(ex);
2301        checkCompletedWithWrappedCFException(h, ex);
2302        f.complete(v1);
2303
2304        assertEquals(0, r.invocationCount);
2305        checkCompletedNormally(f, v1);
2306        checkCompletedWithWrappedCFException(g, ex);
2307        checkCompletedWithWrappedCFException(h, ex);
2308    }}
2309
2310    public void testRunAfterEither_exceptionalCompletion3() {
2311        for (ExecutionMode m : ExecutionMode.values())
2312        for (Integer v1 : new Integer[] { 1, null })
2313    {
2314        final CompletableFuture<Integer> f = new CompletableFuture<>();
2315        final CompletableFuture<Integer> g = new CompletableFuture<>();
2316        final Noop r = new Noop(m);
2421          final CFException ex = new CFException();
2422 +        final Noop[] rs = new Noop[6];
2423 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2424  
2425 <        g.completeExceptionally(ex);
2426 <        f.complete(v1);
2427 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2425 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2426 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2427 >        if (fFirst) {
2428 >            f.complete(v1);
2429 >            g.completeExceptionally(ex);
2430 >        } else {
2431 >            g.completeExceptionally(ex);
2432 >            f.complete(v1);
2433 >        }
2434 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2435 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2436  
2437 <        // unspecified behavior
2438 <        Integer v;
2437 >        // unspecified behavior - both source completions available
2438 >        try {
2439 >            assertEquals(null, h0.join());
2440 >            rs[0].assertInvoked();
2441 >        } catch (CompletionException ok) {
2442 >            checkCompletedWithWrappedException(h0, ex);
2443 >            rs[0].assertNotInvoked();
2444 >        }
2445          try {
2446 <            assertNull(h.join());
2447 <            assertEquals(1, r.invocationCount);
2446 >            assertEquals(null, h1.join());
2447 >            rs[1].assertInvoked();
2448          } catch (CompletionException ok) {
2449 <            checkCompletedWithWrappedCFException(h, ex);
2450 <            assertEquals(0, r.invocationCount);
2449 >            checkCompletedWithWrappedException(h1, ex);
2450 >            rs[1].assertNotInvoked();
2451 >        }
2452 >        try {
2453 >            assertEquals(null, h2.join());
2454 >            rs[2].assertInvoked();
2455 >        } catch (CompletionException ok) {
2456 >            checkCompletedWithWrappedException(h2, ex);
2457 >            rs[2].assertNotInvoked();
2458 >        }
2459 >        try {
2460 >            assertEquals(null, h3.join());
2461 >            rs[3].assertInvoked();
2462 >        } catch (CompletionException ok) {
2463 >            checkCompletedWithWrappedException(h3, ex);
2464 >            rs[3].assertNotInvoked();
2465          }
2466  
2333        checkCompletedWithWrappedCFException(g, ex);
2467          checkCompletedNormally(f, v1);
2468 +        checkCompletedExceptionally(g, ex);
2469      }}
2470  
2471 <    public void testRunAfterEither_exceptionalCompletion4() {
2471 >    /**
2472 >     * runAfterEither result completes exceptionally if either source cancelled
2473 >     */
2474 >    public void testRunAfterEither_sourceCancelled() {
2475          for (ExecutionMode m : ExecutionMode.values())
2476 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2477          for (Integer v1 : new Integer[] { 1, null })
2478      {
2479          final CompletableFuture<Integer> f = new CompletableFuture<>();
2480          final CompletableFuture<Integer> g = new CompletableFuture<>();
2481 <        final Noop r = new Noop(m);
2482 <        final CFException ex = new CFException();
2481 >        final Noop[] rs = new Noop[6];
2482 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2483 >
2484 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2485 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2486 >        checkIncomplete(h0);
2487 >        checkIncomplete(h1);
2488 >        rs[0].assertNotInvoked();
2489 >        rs[1].assertNotInvoked();
2490 >        f.cancel(mayInterruptIfRunning);
2491 >        checkCompletedWithWrappedCancellationException(h0);
2492 >        checkCompletedWithWrappedCancellationException(h1);
2493 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2494 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2495 >        checkCompletedWithWrappedCancellationException(h2);
2496 >        checkCompletedWithWrappedCancellationException(h3);
2497  
2346        f.completeExceptionally(ex);
2498          g.complete(v1);
2348        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2499  
2500 <        // unspecified behavior
2501 <        Integer v;
2500 >        // unspecified behavior - both source completions available
2501 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2502 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2503          try {
2504 <            assertNull(h.join());
2505 <            assertEquals(1, r.invocationCount);
2504 >            assertNull(h4.join());
2505 >            rs[4].assertInvoked();
2506          } catch (CompletionException ok) {
2507 <            checkCompletedWithWrappedCFException(h, ex);
2508 <            assertEquals(0, r.invocationCount);
2507 >            checkCompletedWithWrappedCancellationException(h4);
2508 >            rs[4].assertNotInvoked();
2509 >        }
2510 >        try {
2511 >            assertNull(h5.join());
2512 >            rs[5].assertInvoked();
2513 >        } catch (CompletionException ok) {
2514 >            checkCompletedWithWrappedCancellationException(h5);
2515 >            rs[5].assertNotInvoked();
2516          }
2517  
2518 <        checkCompletedWithWrappedCFException(f, ex);
2518 >        checkCancelled(f);
2519          checkCompletedNormally(g, v1);
2520 +        checkCompletedWithWrappedCancellationException(h0);
2521 +        checkCompletedWithWrappedCancellationException(h1);
2522 +        checkCompletedWithWrappedCancellationException(h2);
2523 +        checkCompletedWithWrappedCancellationException(h3);
2524 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2525      }}
2526  
2527      /**
2528       * runAfterEither result completes exceptionally if action does
2529       */
2530 <    public void testRunAfterEither_actionFailed1() {
2530 >    public void testRunAfterEither_actionFailed() {
2531          for (ExecutionMode m : ExecutionMode.values())
2532          for (Integer v1 : new Integer[] { 1, null })
2533          for (Integer v2 : new Integer[] { 2, null })
2534      {
2535          final CompletableFuture<Integer> f = new CompletableFuture<>();
2536          final CompletableFuture<Integer> g = new CompletableFuture<>();
2537 <        final FailingRunnable r = new FailingRunnable(m);
2538 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2537 >        final FailingRunnable[] rs = new FailingRunnable[6];
2538 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2539  
2540 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2541 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2542          f.complete(v1);
2543 <        checkCompletedWithWrappedCFException(h);
2543 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2544 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2545 >        checkCompletedWithWrappedCFException(h0);
2546 >        checkCompletedWithWrappedCFException(h1);
2547 >        checkCompletedWithWrappedCFException(h2);
2548 >        checkCompletedWithWrappedCFException(h3);
2549 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2550          g.complete(v2);
2551 <        checkCompletedNormally(f, v1);
2552 <        checkCompletedNormally(g, v2);
2553 <    }}
2554 <
2384 <    public void testRunAfterEither_actionFailed2() {
2385 <        for (ExecutionMode m : ExecutionMode.values())
2386 <        for (Integer v1 : new Integer[] { 1, null })
2387 <        for (Integer v2 : new Integer[] { 2, null })
2388 <    {
2389 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2390 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2391 <        final FailingRunnable r = new FailingRunnable(m);
2392 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2551 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2552 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2553 >        checkCompletedWithWrappedCFException(h4);
2554 >        checkCompletedWithWrappedCFException(h5);
2555  
2394        g.complete(v2);
2395        checkCompletedWithWrappedCFException(h);
2396        f.complete(v1);
2556          checkCompletedNormally(f, v1);
2557          checkCompletedNormally(g, v2);
2558 <    }}
2400 <
2401 <    /**
2402 <     * runAfterEither result completes exceptionally if either source cancelled
2403 <     */
2404 <    public void testRunAfterEither_sourceCancelled1() {
2405 <        for (ExecutionMode m : ExecutionMode.values())
2406 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2407 <        for (Integer v1 : new Integer[] { 1, null })
2408 <    {
2409 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2410 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2411 <        final Noop r = new Noop(m);
2412 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2413 <
2414 <        assertTrue(f.cancel(mayInterruptIfRunning));
2415 <        checkCompletedWithWrappedCancellationException(h);
2416 <        g.complete(v1);
2417 <
2418 <        checkCancelled(f);
2419 <        assertEquals(0, r.invocationCount);
2420 <        checkCompletedNormally(g, v1);
2421 <        checkCompletedWithWrappedCancellationException(h);
2422 <    }}
2423 <
2424 <    public void testRunAfterEither_sourceCancelled2() {
2425 <        for (ExecutionMode m : ExecutionMode.values())
2426 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2427 <        for (Integer v1 : new Integer[] { 1, null })
2428 <    {
2429 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2430 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2431 <        final Noop r = new Noop(m);
2432 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2433 <
2434 <        assertTrue(g.cancel(mayInterruptIfRunning));
2435 <        checkCompletedWithWrappedCancellationException(h);
2436 <        f.complete(v1);
2437 <
2438 <        checkCancelled(g);
2439 <        assertEquals(0, r.invocationCount);
2440 <        checkCompletedNormally(f, v1);
2441 <        checkCompletedWithWrappedCancellationException(h);
2442 <    }}
2443 <
2444 <    public void testRunAfterEither_sourceCancelled3() {
2445 <        for (ExecutionMode m : ExecutionMode.values())
2446 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2447 <        for (Integer v1 : new Integer[] { 1, null })
2448 <    {
2449 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2450 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2451 <        final Noop r = new Noop(m);
2452 <
2453 <        assertTrue(g.cancel(mayInterruptIfRunning));
2454 <        f.complete(v1);
2455 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2456 <
2457 <        // unspecified behavior
2458 <        Integer v;
2459 <        try {
2460 <            assertNull(h.join());
2461 <            assertEquals(1, r.invocationCount);
2462 <        } catch (CompletionException ok) {
2463 <            checkCompletedWithWrappedCancellationException(h);
2464 <            assertEquals(0, r.invocationCount);
2465 <        }
2466 <
2467 <        checkCancelled(g);
2468 <        checkCompletedNormally(f, v1);
2469 <    }}
2470 <
2471 <    public void testRunAfterEither_sourceCancelled4() {
2472 <        for (ExecutionMode m : ExecutionMode.values())
2473 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2474 <        for (Integer v1 : new Integer[] { 1, null })
2475 <    {
2476 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2477 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2478 <        final Noop r = new Noop(m);
2479 <
2480 <        assertTrue(f.cancel(mayInterruptIfRunning));
2481 <        g.complete(v1);
2482 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2483 <
2484 <        // unspecified behavior
2485 <        Integer v;
2486 <        try {
2487 <            assertNull(h.join());
2488 <            assertEquals(1, r.invocationCount);
2489 <        } catch (CompletionException ok) {
2490 <            checkCompletedWithWrappedCancellationException(h);
2491 <            assertEquals(0, r.invocationCount);
2492 <        }
2493 <
2494 <        checkCancelled(f);
2495 <        checkCompletedNormally(g, v1);
2558 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2559      }}
2560  
2561      /**
# Line 2511 | Line 2574 | public class CompletableFutureTest exten
2574  
2575          checkCompletedNormally(g, inc(v1));
2576          checkCompletedNormally(f, v1);
2577 <        assertEquals(1, r.invocationCount);
2577 >        r.assertValue(v1);
2578      }}
2579  
2580      /**
# Line 2529 | Line 2592 | public class CompletableFutureTest exten
2592          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2593          if (createIncomplete) f.completeExceptionally(ex);
2594  
2595 <        checkCompletedWithWrappedCFException(g, ex);
2596 <        checkCompletedWithWrappedCFException(f, ex);
2597 <        assertEquals(0, r.invocationCount);
2595 >        checkCompletedWithWrappedException(g, ex);
2596 >        checkCompletedExceptionally(f, ex);
2597 >        r.assertNotInvoked();
2598      }}
2599  
2600      /**
# Line 2591 | Line 2654 | public class CompletableFutureTest exten
2654       */
2655      public void testAllOf_normal() throws Exception {
2656          for (int k = 1; k < 20; ++k) {
2657 <            CompletableFuture<Integer>[] fs = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2657 >            CompletableFuture<Integer>[] fs
2658 >                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2659              for (int i = 0; i < k; ++i)
2660                  fs[i] = new CompletableFuture<>();
2661              CompletableFuture<Void> f = CompletableFuture.allOf(fs);
# Line 2605 | Line 2669 | public class CompletableFutureTest exten
2669          }
2670      }
2671  
2672 +    public void testAllOf_backwards() throws Exception {
2673 +        for (int k = 1; k < 20; ++k) {
2674 +            CompletableFuture<Integer>[] fs
2675 +                = (CompletableFuture<Integer>[]) new CompletableFuture[k];
2676 +            for (int i = 0; i < k; ++i)
2677 +                fs[i] = new CompletableFuture<>();
2678 +            CompletableFuture<Void> f = CompletableFuture.allOf(fs);
2679 +            for (int i = k - 1; i >= 0; i--) {
2680 +                checkIncomplete(f);
2681 +                checkIncomplete(CompletableFuture.allOf(fs));
2682 +                fs[i].complete(one);
2683 +            }
2684 +            checkCompletedNormally(f, null);
2685 +            checkCompletedNormally(CompletableFuture.allOf(fs), null);
2686 +        }
2687 +    }
2688 +
2689      /**
2690       * anyOf(no component futures) returns an incomplete future
2691       */
# Line 2663 | Line 2744 | public class CompletableFutureTest exten
2744          Runnable[] throwingActions = {
2745              () -> CompletableFuture.supplyAsync(null),
2746              () -> CompletableFuture.supplyAsync(null, exec),
2747 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
2747 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
2748  
2749              () -> CompletableFuture.runAsync(null),
2750              () -> CompletableFuture.runAsync(null, exec),
# Line 2783 | Line 2864 | public class CompletableFutureTest exten
2864          final CompletableFuture<Integer> g = m.whenComplete
2865              (f,
2866               (Integer x, Throwable t) -> {
2867 +                m.checkExecutionMode();
2868                  threadAssertSame(x, v1);
2869                  threadAssertNull(t);
2870                  a.getAndIncrement();
# Line 2810 | Line 2892 | public class CompletableFutureTest exten
2892          final CompletableFuture<Integer> g = m.whenComplete
2893              (f,
2894               (Integer x, Throwable t) -> {
2895 +                m.checkExecutionMode();
2896                  threadAssertNull(x);
2897                  threadAssertSame(t, ex);
2898                  a.getAndIncrement();
2899              });
2900          if (createIncomplete) f.completeExceptionally(ex);
2901 <        checkCompletedWithWrappedCFException(f, ex);
2902 <        checkCompletedWithWrappedCFException(g, ex);
2901 >        checkCompletedExceptionally(f, ex);
2902 >        checkCompletedWithWrappedException(g, ex);
2903          assertEquals(1, a.get());
2904      }}
2905  
# Line 2835 | Line 2918 | public class CompletableFutureTest exten
2918          final CompletableFuture<Integer> g = m.whenComplete
2919              (f,
2920               (Integer x, Throwable t) -> {
2921 +                m.checkExecutionMode();
2922                  threadAssertNull(x);
2923                  threadAssertTrue(t instanceof CancellationException);
2924                  a.getAndIncrement();
2925              });
2926          if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2927  
2844        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2928          checkCompletedWithWrappedCancellationException(g);
2929          checkCancelled(f);
2930          assertEquals(1, a.get());
# Line 2863 | Line 2946 | public class CompletableFutureTest exten
2946          final CompletableFuture<Integer> g = m.whenComplete
2947              (f,
2948               (Integer x, Throwable t) -> {
2949 +                m.checkExecutionMode();
2950                  threadAssertSame(x, v1);
2951                  threadAssertNull(t);
2952                  a.getAndIncrement();
# Line 2870 | Line 2954 | public class CompletableFutureTest exten
2954              });
2955          if (createIncomplete) f.complete(v1);
2956          checkCompletedNormally(f, v1);
2957 <        checkCompletedWithWrappedCFException(g, ex);
2957 >        checkCompletedWithWrappedException(g, ex);
2958          assertEquals(1, a.get());
2959      }}
2960  
# Line 2893 | Line 2977 | public class CompletableFutureTest exten
2977          final CompletableFuture<Integer> g = m.whenComplete
2978              (f,
2979               (Integer x, Throwable t) -> {
2980 +                m.checkExecutionMode();
2981                  threadAssertSame(t, ex1);
2982                  threadAssertNull(x);
2983                  a.getAndIncrement();
# Line 2900 | Line 2985 | public class CompletableFutureTest exten
2985              });
2986          if (createIncomplete) f.completeExceptionally(ex1);
2987  
2988 <        checkCompletedWithWrappedCFException(f, ex1);
2989 <        checkCompletedWithWrappedCFException(g, ex1);
2988 >        checkCompletedExceptionally(f, ex1);
2989 >        checkCompletedWithWrappedException(g, ex1);
2990          assertEquals(1, a.get());
2991      }}
2992  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines