ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.43 by jsr166, Mon Jun 2 04:13:54 2014 UTC vs.
Revision 1.58 by jsr166, Mon Jun 2 23:10:08 2014 UTC

# Line 17 | Line 17 | import java.util.concurrent.Future;
17   import java.util.concurrent.CompletableFuture;
18   import java.util.concurrent.CompletionException;
19   import java.util.concurrent.CompletionStage;
20 + import java.util.concurrent.ForkJoinPool;
21 + import java.util.concurrent.ForkJoinTask;
22   import java.util.concurrent.TimeoutException;
23   import java.util.concurrent.atomic.AtomicInteger;
24   import static java.util.concurrent.TimeUnit.MILLISECONDS;
# Line 247 | Line 249 | public class CompletableFutureTest exten
249          f = new CompletableFuture<>();
250          f.obtrudeValue(three);
251          checkCompletedNormally(f, three);
252 +        f.obtrudeValue(null);
253 +        checkCompletedNormally(f, null);
254          f = new CompletableFuture<>();
255          f.completeExceptionally(new CFException());
256          f.obtrudeValue(four);
# Line 279 | Line 283 | public class CompletableFutureTest exten
283       */
284      public void testGetNumberOfDependents() {
285          CompletableFuture<Integer> f = new CompletableFuture<>();
286 <        assertEquals(f.getNumberOfDependents(), 0);
287 <        CompletableFuture g = f.thenRun(new Noop());
288 <        assertEquals(f.getNumberOfDependents(), 1);
289 <        assertEquals(g.getNumberOfDependents(), 0);
290 <        CompletableFuture h = f.thenRun(new Noop());
291 <        assertEquals(f.getNumberOfDependents(), 2);
286 >        assertEquals(0, f.getNumberOfDependents());
287 >        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
288 >        assertEquals(1, f.getNumberOfDependents());
289 >        assertEquals(0, g.getNumberOfDependents());
290 >        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
291 >        assertEquals(2, f.getNumberOfDependents());
292          f.complete(1);
293          checkCompletedNormally(g, null);
294 <        assertEquals(f.getNumberOfDependents(), 0);
295 <        assertEquals(g.getNumberOfDependents(), 0);
294 >        assertEquals(0, f.getNumberOfDependents());
295 >        assertEquals(0, g.getNumberOfDependents());
296      }
297  
298      /**
# Line 330 | Line 334 | public class CompletableFutureTest exten
334          return (x == null) ? null : x + 1;
335      }
336  
337 <    static final Supplier<Integer> supplyOne =
338 <        () -> Integer.valueOf(1);
339 <    static final Function<Integer, Integer> inc =
340 <        (Integer x) -> Integer.valueOf(x.intValue() + 1);
341 <    static final BiFunction<Integer, Integer, Integer> subtract =
342 <        (Integer x, Integer y) -> subtract(x, y);
337 >    static final class IntegerSupplier implements Supplier<Integer> {
338 >        final ExecutionMode m;
339 >        int invocationCount = 0;
340 >        final Integer value;
341 >        IntegerSupplier(ExecutionMode m, Integer value) {
342 >            this.m = m;
343 >            this.value = value;
344 >        }
345 >        public Integer get() {
346 >            m.checkExecutionMode();
347 >            invocationCount++;
348 >            return value;
349 >        }
350 >    }
351 >        
352      static final class IncAction implements Consumer<Integer> {
353          int invocationCount = 0;
354          Integer value;
342        public boolean ran() { return invocationCount == 1; }
355          public void accept(Integer x) {
356              invocationCount++;
357              value = inc(x);
358          }
359      }
360      static final class IncFunction implements Function<Integer,Integer> {
361 +        final ExecutionMode m;
362          int invocationCount = 0;
363          Integer value;
364 <        public boolean ran() { return invocationCount == 1; }
364 >        IncFunction(ExecutionMode m) { this.m = m; }
365          public Integer apply(Integer x) {
366 +            m.checkExecutionMode();
367              invocationCount++;
368              return value = inc(x);
369          }
370      }
371      static final class SubtractAction implements BiConsumer<Integer, Integer> {
372 +        final ExecutionMode m;
373          int invocationCount = 0;
374          Integer value;
375          // Check this action was invoked exactly once when result is computed.
376 <        public boolean ran() { return invocationCount == 1; }
376 >        SubtractAction(ExecutionMode m) { this.m = m; }
377          public void accept(Integer x, Integer y) {
378 +            m.checkExecutionMode();
379              invocationCount++;
380              value = subtract(x, y);
381          }
382      }
383      static final class SubtractFunction implements BiFunction<Integer, Integer, Integer> {
384 +        final ExecutionMode m;
385          int invocationCount = 0;
386          Integer value;
387          // Check this action was invoked exactly once when result is computed.
388 <        public boolean ran() { return invocationCount == 1; }
388 >        SubtractFunction(ExecutionMode m) { this.m = m; }
389          public Integer apply(Integer x, Integer y) {
390 +            m.checkExecutionMode();
391              invocationCount++;
392              return value = subtract(x, y);
393          }
394      }
395      static final class Noop implements Runnable {
396 +        final ExecutionMode m;
397          int invocationCount = 0;
398 <        boolean ran;
398 >        Noop(ExecutionMode m) { this.m = m; }
399          public void run() {
400 +            m.checkExecutionMode();
401              invocationCount++;
382            ran = true;
402          }
403      }
404  
405      static final class FailingSupplier implements Supplier<Integer> {
406 <        boolean ran;
407 <        public Integer get() { ran = true; throw new CFException(); }
406 >        final ExecutionMode m;
407 >        int invocationCount = 0;
408 >        FailingSupplier(ExecutionMode m) { this.m = m; }
409 >        public Integer get() {
410 >            m.checkExecutionMode();
411 >            invocationCount++;
412 >            throw new CFException();
413 >        }
414      }
415      static final class FailingConsumer implements Consumer<Integer> {
416 <        boolean ran;
417 <        public void accept(Integer x) { ran = true; throw new CFException(); }
416 >        final ExecutionMode m;
417 >        int invocationCount = 0;
418 >        FailingConsumer(ExecutionMode m) { this.m = m; }
419 >        public void accept(Integer x) {
420 >            m.checkExecutionMode();
421 >            invocationCount++;
422 >            throw new CFException();
423 >        }
424      }
425      static final class FailingBiConsumer implements BiConsumer<Integer, Integer> {
426 <        boolean ran;
427 <        public void accept(Integer x, Integer y) { ran = true; throw new CFException(); }
426 >        final ExecutionMode m;
427 >        int invocationCount = 0;
428 >        FailingBiConsumer(ExecutionMode m) { this.m = m; }
429 >        public void accept(Integer x, Integer y) {
430 >            m.checkExecutionMode();
431 >            invocationCount++;
432 >            throw new CFException();
433 >        }
434      }
435      static final class FailingFunction implements Function<Integer, Integer> {
436 <        boolean ran;
437 <        public Integer apply(Integer x) { ran = true; throw new CFException(); }
436 >        final ExecutionMode m;
437 >        int invocationCount = 0;
438 >        FailingFunction(ExecutionMode m) { this.m = m; }
439 >        public Integer apply(Integer x) {
440 >            m.checkExecutionMode();
441 >            invocationCount++;
442 >            throw new CFException();
443 >        }
444      }
445      static final class FailingBiFunction implements BiFunction<Integer, Integer, Integer> {
446 <        boolean ran;
447 <        public Integer apply(Integer x, Integer y) { ran = true; throw new CFException(); }
446 >        final ExecutionMode m;
447 >        int invocationCount = 0;
448 >        FailingBiFunction(ExecutionMode m) { this.m = m; }
449 >        public Integer apply(Integer x, Integer y) {
450 >            m.checkExecutionMode();
451 >            invocationCount++;
452 >            throw new CFException();
453 >        }
454      }
455 <    static final class FailingNoop implements Runnable {
456 <        boolean ran;
457 <        public void run() { ran = true; throw new CFException(); }
455 >    static final class FailingRunnable implements Runnable {
456 >        final ExecutionMode m;
457 >        int invocationCount = 0;
458 >        FailingRunnable(ExecutionMode m) { this.m = m; }
459 >        public void run() {
460 >            m.checkExecutionMode();
461 >            invocationCount++;
462 >            throw new CFException();
463 >        }
464      }
465  
466      static final class CompletableFutureInc
467          implements Function<Integer, CompletableFuture<Integer>> {
468 <        boolean ran;
468 >        final ExecutionMode m;
469 >        int invocationCount = 0;
470 >        CompletableFutureInc(ExecutionMode m) { this.m = m; }
471          public CompletableFuture<Integer> apply(Integer x) {
472 <            ran = true;
472 >            m.checkExecutionMode();
473 >            invocationCount++;
474              CompletableFuture<Integer> f = new CompletableFuture<>();
475 <            f.complete(Integer.valueOf(x.intValue() + 1));
475 >            f.complete(inc(x));
476              return f;
477          }
478      }
479  
480      static final class FailingCompletableFutureFunction
481          implements Function<Integer, CompletableFuture<Integer>> {
482 <        boolean ran;
482 >        final ExecutionMode m;
483 >        int invocationCount = 0;
484 >        FailingCompletableFutureFunction(ExecutionMode m) { this.m = m; }
485          public CompletableFuture<Integer> apply(Integer x) {
486 <            ran = true; throw new CFException();
486 >            m.checkExecutionMode();
487 >            invocationCount++;
488 >            throw new CFException();
489          }
490      }
491  
492      // Used for explicit executor tests
493      static final class ThreadExecutor implements Executor {
494 <        AtomicInteger count = new AtomicInteger(0);
494 >        final AtomicInteger count = new AtomicInteger(0);
495 >        static final ThreadGroup tg = new ThreadGroup("ThreadExecutor");
496 >        static boolean startedCurrentThread() {
497 >            return Thread.currentThread().getThreadGroup() == tg;
498 >        }
499  
500          public void execute(Runnable r) {
501              count.getAndIncrement();
502 <            new Thread(r).start();
437 <        }
438 <    }
439 <
440 <    static final class ExceptionToInteger implements Function<Throwable, Integer> {
441 <        public Integer apply(Throwable x) { return Integer.valueOf(3); }
442 <    }
443 <
444 <    static final class IntegerHandler implements BiFunction<Integer, Throwable, Integer> {
445 <        boolean ran;
446 <        public Integer apply(Integer x, Throwable t) {
447 <            ran = true;
448 <            return (t == null) ? two : three;
502 >            new Thread(tg, r).start();
503          }
504      }
505  
# Line 455 | Line 509 | public class CompletableFutureTest exten
509       */
510      enum ExecutionMode {
511          DEFAULT {
512 +            public void checkExecutionMode() {
513 +                assertNull(ForkJoinTask.getPool());
514 +            }
515 +            public CompletableFuture<Void> runAsync(Runnable a) {
516 +                throw new UnsupportedOperationException();
517 +            }
518 +            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
519 +                throw new UnsupportedOperationException();
520 +            }
521 +            public <T> CompletableFuture<Void> thenRun
522 +                (CompletableFuture<T> f, Runnable a) {
523 +                return f.thenRun(a);
524 +            }
525 +            public <T> CompletableFuture<Void> thenAccept
526 +                (CompletableFuture<T> f, Consumer<? super T> a) {
527 +                return f.thenAccept(a);
528 +            }
529 +            public <T,U> CompletableFuture<U> thenApply
530 +                (CompletableFuture<T> f, Function<? super T,U> a) {
531 +                return f.thenApply(a);
532 +            }
533 +            public <T,U> CompletableFuture<U> thenCompose
534 +                (CompletableFuture<T> f,
535 +                 Function<? super T,? extends CompletionStage<U>> a) {
536 +                return f.thenCompose(a);
537 +            }
538 +            public <T,U> CompletableFuture<U> handle
539 +                (CompletableFuture<T> f,
540 +                 BiFunction<? super T,Throwable,? extends U> a) {
541 +                return f.handle(a);
542 +            }
543 +            public <T> CompletableFuture<T> whenComplete
544 +                (CompletableFuture<T> f,
545 +                 BiConsumer<? super T,? super Throwable> a) {
546 +                return f.whenComplete(a);
547 +            }
548              public <T,U> CompletableFuture<Void> runAfterBoth
549                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
550                  return f.runAfterBoth(g, a);
# Line 471 | Line 561 | public class CompletableFutureTest exten
561                   BiFunction<? super T,? super U,? extends V> a) {
562                  return f.thenCombine(g, a);
563              }
564 <            public <T,U> CompletableFuture<U> applyToEither
564 >            public <T> CompletableFuture<Void> runAfterEither
565                  (CompletableFuture<T> f,
566 <                 CompletionStage<? extends T> g,
567 <                 Function<? super T,U> a) {
568 <                return f.applyToEither(g, a);
566 >                 CompletionStage<?> g,
567 >                 java.lang.Runnable a) {
568 >                return f.runAfterEither(g, a);
569              }
570              public <T> CompletableFuture<Void> acceptEither
571                  (CompletableFuture<T> f,
# Line 483 | Line 573 | public class CompletableFutureTest exten
573                   Consumer<? super T> a) {
574                  return f.acceptEither(g, a);
575              }
576 <            public <T> CompletableFuture<Void> runAfterEither
576 >            public <T,U> CompletableFuture<U> applyToEither
577                  (CompletableFuture<T> f,
578 <                 CompletionStage<?> g,
579 <                 java.lang.Runnable a) {
580 <                return f.runAfterEither(g, a);
578 >                 CompletionStage<? extends T> g,
579 >                 Function<? super T,U> a) {
580 >                return f.applyToEither(g, a);
581 >            }
582 >        },
583 >
584 >        ASYNC {
585 >            public void checkExecutionMode() {
586 >                assertSame(ForkJoinPool.commonPool(),
587 >                           ForkJoinTask.getPool());
588 >            }
589 >            public CompletableFuture<Void> runAsync(Runnable a) {
590 >                return CompletableFuture.runAsync(a);
591 >            }
592 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
593 >                return CompletableFuture.supplyAsync(a);
594 >            }
595 >            public <T> CompletableFuture<Void> thenRun
596 >                (CompletableFuture<T> f, Runnable a) {
597 >                return f.thenRunAsync(a);
598 >            }
599 >            public <T> CompletableFuture<Void> thenAccept
600 >                (CompletableFuture<T> f, Consumer<? super T> a) {
601 >                return f.thenAcceptAsync(a);
602 >            }
603 >            public <T,U> CompletableFuture<U> thenApply
604 >                (CompletableFuture<T> f, Function<? super T,U> a) {
605 >                return f.thenApplyAsync(a);
606              }
607              public <T,U> CompletableFuture<U> thenCompose
608                  (CompletableFuture<T> f,
609                   Function<? super T,? extends CompletionStage<U>> a) {
610 <                return f.thenCompose(a);
610 >                return f.thenComposeAsync(a);
611 >            }
612 >            public <T,U> CompletableFuture<U> handle
613 >                (CompletableFuture<T> f,
614 >                 BiFunction<? super T,Throwable,? extends U> a) {
615 >                return f.handleAsync(a);
616              }
617              public <T> CompletableFuture<T> whenComplete
618                  (CompletableFuture<T> f,
619                   BiConsumer<? super T,? super Throwable> a) {
620 <                return f.whenComplete(a);
620 >                return f.whenCompleteAsync(a);
621              }
502        },
503
504 //             /** Experimental way to do more testing */
505 //         REVERSE_DEFAULT {
506 //             public <T,U> CompletableFuture<Void> runAfterBoth
507 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
508 //                 return g.runAfterBoth(f, a);
509 //             }
510 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
511 //                 (CompletableFuture<T> f,
512 //                  CompletionStage<? extends U> g,
513 //                  BiConsumer<? super T,? super U> a) {
514 //                 return DEFAULT.thenAcceptBoth(f, g, a);
515 //             }
516 //         },
517
518        DEFAULT_ASYNC {
622              public <T,U> CompletableFuture<Void> runAfterBoth
623                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
624                  return f.runAfterBothAsync(g, a);
# Line 532 | Line 635 | public class CompletableFutureTest exten
635                   BiFunction<? super T,? super U,? extends V> a) {
636                  return f.thenCombineAsync(g, a);
637              }
638 <            public <T,U> CompletableFuture<U> applyToEither
638 >            public <T> CompletableFuture<Void> runAfterEither
639                  (CompletableFuture<T> f,
640 <                 CompletionStage<? extends T> g,
641 <                 Function<? super T,U> a) {
642 <                return f.applyToEitherAsync(g, a);
640 >                 CompletionStage<?> g,
641 >                 java.lang.Runnable a) {
642 >                return f.runAfterEitherAsync(g, a);
643              }
644              public <T> CompletableFuture<Void> acceptEither
645                  (CompletableFuture<T> f,
# Line 544 | Line 647 | public class CompletableFutureTest exten
647                   Consumer<? super T> a) {
648                  return f.acceptEitherAsync(g, a);
649              }
650 <            public <T> CompletableFuture<Void> runAfterEither
650 >            public <T,U> CompletableFuture<U> applyToEither
651                  (CompletableFuture<T> f,
652 <                 CompletionStage<?> g,
653 <                 java.lang.Runnable a) {
654 <                return f.runAfterEitherAsync(g, a);
652 >                 CompletionStage<? extends T> g,
653 >                 Function<? super T,U> a) {
654 >                return f.applyToEitherAsync(g, a);
655 >            }
656 >        },
657 >
658 >        EXECUTOR {
659 >            public void checkExecutionMode() {
660 >                assertTrue(ThreadExecutor.startedCurrentThread());
661 >            }
662 >            public CompletableFuture<Void> runAsync(Runnable a) {
663 >                return CompletableFuture.runAsync(a, new ThreadExecutor());
664 >            }
665 >            public <U> CompletableFuture<U> supplyAsync(Supplier<U> a) {
666 >                return CompletableFuture.supplyAsync(a, new ThreadExecutor());
667 >            }
668 >            public <T> CompletableFuture<Void> thenRun
669 >                (CompletableFuture<T> f, Runnable a) {
670 >                return f.thenRunAsync(a, new ThreadExecutor());
671 >            }
672 >            public <T> CompletableFuture<Void> thenAccept
673 >                (CompletableFuture<T> f, Consumer<? super T> a) {
674 >                return f.thenAcceptAsync(a, new ThreadExecutor());
675 >            }
676 >            public <T,U> CompletableFuture<U> thenApply
677 >                (CompletableFuture<T> f, Function<? super T,U> a) {
678 >                return f.thenApplyAsync(a, new ThreadExecutor());
679              }
680              public <T,U> CompletableFuture<U> thenCompose
681                  (CompletableFuture<T> f,
682                   Function<? super T,? extends CompletionStage<U>> a) {
683 <                return f.thenComposeAsync(a);
683 >                return f.thenComposeAsync(a, new ThreadExecutor());
684 >            }
685 >            public <T,U> CompletableFuture<U> handle
686 >                (CompletableFuture<T> f,
687 >                 BiFunction<? super T,Throwable,? extends U> a) {
688 >                return f.handleAsync(a, new ThreadExecutor());
689              }
690              public <T> CompletableFuture<T> whenComplete
691                  (CompletableFuture<T> f,
692                   BiConsumer<? super T,? super Throwable> a) {
693 <                return f.whenCompleteAsync(a);
693 >                return f.whenCompleteAsync(a, new ThreadExecutor());
694              }
563        },
564
565 //         REVERSE_DEFAULT_ASYNC {
566 //             public <T,U> CompletableFuture<Void> runAfterBoth
567 //                 (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
568 //                 return f.runAfterBothAsync(g, a);
569 //             }
570 //             public <T,U> CompletableFuture<Void> thenAcceptBoth
571 //                 (CompletableFuture<T> f,
572 //                  CompletionStage<? extends U> g,
573 //                  BiConsumer<? super T,? super U> a) {
574 //                 return DEFAULT_ASYNC.thenAcceptBoth(f, g, a);
575 //             }
576 //         },
577
578        EXECUTOR {
695              public <T,U> CompletableFuture<Void> runAfterBoth
696                  (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a) {
697                  return f.runAfterBothAsync(g, a, new ThreadExecutor());
# Line 592 | Line 708 | public class CompletableFutureTest exten
708                   BiFunction<? super T,? super U,? extends V> a) {
709                  return f.thenCombineAsync(g, a, new ThreadExecutor());
710              }
595            public <T,U> CompletableFuture<U> applyToEither
596                (CompletableFuture<T> f,
597                 CompletionStage<? extends T> g,
598                 Function<? super T,U> a) {
599                return f.applyToEitherAsync(g, a, new ThreadExecutor());
600            }
601            public <T> CompletableFuture<Void> acceptEither
602                (CompletableFuture<T> f,
603                 CompletionStage<? extends T> g,
604                 Consumer<? super T> a) {
605                return f.acceptEitherAsync(g, a, new ThreadExecutor());
606            }
711              public <T> CompletableFuture<Void> runAfterEither
712                  (CompletableFuture<T> f,
713                   CompletionStage<?> g,
714                   java.lang.Runnable a) {
715                  return f.runAfterEitherAsync(g, a, new ThreadExecutor());
716              }
717 <            public <T,U> CompletableFuture<U> thenCompose
717 >            public <T> CompletableFuture<Void> acceptEither
718                  (CompletableFuture<T> f,
719 <                 Function<? super T,? extends CompletionStage<U>> a) {
720 <                return f.thenComposeAsync(a, new ThreadExecutor());
719 >                 CompletionStage<? extends T> g,
720 >                 Consumer<? super T> a) {
721 >                return f.acceptEitherAsync(g, a, new ThreadExecutor());
722              }
723 <            public <T> CompletableFuture<T> whenComplete
723 >            public <T,U> CompletableFuture<U> applyToEither
724                  (CompletableFuture<T> f,
725 <                 BiConsumer<? super T,? super Throwable> a) {
726 <                return f.whenCompleteAsync(a, new ThreadExecutor());
725 >                 CompletionStage<? extends T> g,
726 >                 Function<? super T,U> a) {
727 >                return f.applyToEitherAsync(g, a, new ThreadExecutor());
728              }
729          };
730  
731 +        public abstract void checkExecutionMode();
732 +        public abstract CompletableFuture<Void> runAsync(Runnable a);
733 +        public abstract <U> CompletableFuture<U> supplyAsync(Supplier<U> a);
734 +        public abstract <T> CompletableFuture<Void> thenRun
735 +            (CompletableFuture<T> f, Runnable a);
736 +        public abstract <T> CompletableFuture<Void> thenAccept
737 +            (CompletableFuture<T> f, Consumer<? super T> a);
738 +        public abstract <T,U> CompletableFuture<U> thenApply
739 +            (CompletableFuture<T> f, Function<? super T,U> a);
740 +        public abstract <T,U> CompletableFuture<U> thenCompose
741 +            (CompletableFuture<T> f,
742 +             Function<? super T,? extends CompletionStage<U>> a);
743 +        public abstract <T,U> CompletableFuture<U> handle
744 +            (CompletableFuture<T> f,
745 +             BiFunction<? super T,Throwable,? extends U> a);
746 +        public abstract <T> CompletableFuture<T> whenComplete
747 +            (CompletableFuture<T> f,
748 +             BiConsumer<? super T,? super Throwable> a);
749          public abstract <T,U> CompletableFuture<Void> runAfterBoth
750              (CompletableFuture<T> f, CompletableFuture<U> g, Runnable a);
751          public abstract <T,U> CompletableFuture<Void> thenAcceptBoth
# Line 632 | Line 756 | public class CompletableFutureTest exten
756              (CompletableFuture<T> f,
757               CompletionStage<? extends U> g,
758               BiFunction<? super T,? super U,? extends V> a);
635        public abstract <T,U> CompletableFuture<U> applyToEither
636            (CompletableFuture<T> f,
637             CompletionStage<? extends T> g,
638             Function<? super T,U> a);
639        public abstract <T> CompletableFuture<Void> acceptEither
640            (CompletableFuture<T> f,
641             CompletionStage<? extends T> g,
642             Consumer<? super T> a);
759          public abstract <T> CompletableFuture<Void> runAfterEither
760              (CompletableFuture<T> f,
761               CompletionStage<?> g,
762               java.lang.Runnable a);
763 <        public abstract <T,U> CompletableFuture<U> thenCompose
763 >        public abstract <T> CompletableFuture<Void> acceptEither
764              (CompletableFuture<T> f,
765 <             Function<? super T,? extends CompletionStage<U>> a);
766 <        public abstract <T> CompletableFuture<T> whenComplete
765 >             CompletionStage<? extends T> g,
766 >             Consumer<? super T> a);
767 >        public abstract <T,U> CompletableFuture<U> applyToEither
768              (CompletableFuture<T> f,
769 <             BiConsumer<? super T,? super Throwable> a);
769 >             CompletionStage<? extends T> g,
770 >             Function<? super T,U> a);
771 >    }
772 >
773 >    /**
774 >     * exceptionally action is not invoked when source completes
775 >     * normally, and source result is propagated
776 >     */
777 >    public void testExceptionally_normalCompletion() {
778 >        for (boolean createIncomplete : new boolean[] { true, false })
779 >        for (Integer v1 : new Integer[] { 1, null })
780 >    {
781 >        final AtomicInteger a = new AtomicInteger(0);
782 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
783 >        if (!createIncomplete) f.complete(v1);
784 >        final CompletableFuture<Integer> g = f.exceptionally
785 >            ((Throwable t) -> {
786 >                // Should not be called
787 >                a.getAndIncrement();
788 >                throw new AssertionError();
789 >            });
790 >        if (createIncomplete) f.complete(v1);
791  
792 +        checkCompletedNormally(g, v1);
793 +        checkCompletedNormally(f, v1);
794 +        assertEquals(0, a.get());
795 +    }}
796  
655    }
797  
798      /**
799       * exceptionally action completes with function value on source
800 <     * exception; otherwise with source value
800 >     * exception
801       */
802 <    public void testExceptionally() {
803 <        CompletableFuture<Integer> f = new CompletableFuture<>();
804 <        ExceptionToInteger r = new ExceptionToInteger();
805 <        CompletableFuture<Integer> g = f.exceptionally(r);
806 <        f.completeExceptionally(new CFException());
807 <        checkCompletedNormally(g, three);
802 >    public void testExceptionally_exceptionalCompletion() {
803 >        for (boolean createIncomplete : new boolean[] { true, false })
804 >        for (Integer v1 : new Integer[] { 1, null })
805 >    {
806 >        final AtomicInteger a = new AtomicInteger(0);
807 >        final CFException ex = new CFException();
808 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
809 >        if (!createIncomplete) f.completeExceptionally(ex);
810 >        final CompletableFuture<Integer> g = f.exceptionally
811 >            ((Throwable t) -> {
812 >                ExecutionMode.DEFAULT.checkExecutionMode();
813 >                threadAssertSame(t, ex);
814 >                a.getAndIncrement();
815 >                return v1;
816 >            });
817 >        if (createIncomplete) f.completeExceptionally(ex);
818  
819 <        f = new CompletableFuture<>();
820 <        r = new ExceptionToInteger();
821 <        g = f.exceptionally(r);
822 <        f.complete(one);
823 <        checkCompletedNormally(g, one);
824 <    }
819 >        checkCompletedNormally(g, v1);
820 >        assertEquals(1, a.get());
821 >    }}
822 >
823 >    public void testExceptionally_exceptionalCompletionActionFailed() {
824 >        for (boolean createIncomplete : new boolean[] { true, false })
825 >        for (Integer v1 : new Integer[] { 1, null })
826 >    {
827 >        final AtomicInteger a = new AtomicInteger(0);
828 >        final CFException ex1 = new CFException();
829 >        final CFException ex2 = new CFException();
830 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
831 >        if (!createIncomplete) f.completeExceptionally(ex1);
832 >        final CompletableFuture<Integer> g = f.exceptionally
833 >            ((Throwable t) -> {
834 >                ExecutionMode.DEFAULT.checkExecutionMode();
835 >                threadAssertSame(t, ex1);
836 >                a.getAndIncrement();
837 >                throw ex2;
838 >            });
839 >        if (createIncomplete) f.completeExceptionally(ex1);
840 >
841 >        checkCompletedWithWrappedCFException(g, ex2);
842 >        assertEquals(1, a.get());
843 >    }}
844  
845      /**
846 <     * handle action completes normally with function value on either
847 <     * normal or exceptional completion of source
846 >     * handle action completes normally with function value on normal
847 >     * completion of source
848       */
849 <    public void testHandle() {
850 <        CompletableFuture<Integer> f, g;
851 <        IntegerHandler r;
849 >    public void testHandle_normalCompletion() {
850 >        for (ExecutionMode m : ExecutionMode.values())
851 >        for (boolean createIncomplete : new boolean[] { true, false })
852 >        for (Integer v1 : new Integer[] { 1, null })
853 >    {
854 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
855 >        final AtomicInteger a = new AtomicInteger(0);
856 >        if (!createIncomplete) f.complete(v1);
857 >        final CompletableFuture<Integer> g = m.handle
858 >            (f,
859 >             (Integer x, Throwable t) -> {
860 >                m.checkExecutionMode();
861 >                threadAssertSame(x, v1);
862 >                threadAssertNull(t);
863 >                a.getAndIncrement();
864 >                return inc(v1);
865 >            });
866 >        if (createIncomplete) f.complete(v1);
867  
868 <        f = new CompletableFuture<>();
869 <        f.completeExceptionally(new CFException());
870 <        g = f.handle(r = new IntegerHandler());
871 <        assertTrue(r.ran);
687 <        checkCompletedNormally(g, three);
868 >        checkCompletedNormally(g, inc(v1));
869 >        checkCompletedNormally(f, v1);
870 >        assertEquals(1, a.get());
871 >    }}
872  
873 <        f = new CompletableFuture<>();
874 <        g = f.handle(r = new IntegerHandler());
875 <        assertFalse(r.ran);
876 <        f.completeExceptionally(new CFException());
877 <        checkCompletedNormally(g, three);
878 <        assertTrue(r.ran);
873 >    /**
874 >     * handle action completes normally with function value on
875 >     * exceptional completion of source
876 >     */
877 >    public void testHandle_exceptionalCompletion() {
878 >        for (ExecutionMode m : ExecutionMode.values())
879 >        for (boolean createIncomplete : new boolean[] { true, false })
880 >        for (Integer v1 : new Integer[] { 1, null })
881 >    {
882 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
883 >        final AtomicInteger a = new AtomicInteger(0);
884 >        final CFException ex = new CFException();
885 >        if (!createIncomplete) f.completeExceptionally(ex);
886 >        final CompletableFuture<Integer> g = m.handle
887 >            (f,
888 >             (Integer x, Throwable t) -> {
889 >                m.checkExecutionMode();
890 >                threadAssertNull(x);
891 >                threadAssertSame(t, ex);
892 >                a.getAndIncrement();
893 >                return v1;
894 >            });
895 >        if (createIncomplete) f.completeExceptionally(ex);
896  
897 <        f = new CompletableFuture<>();
898 <        f.complete(one);
899 <        g = f.handle(r = new IntegerHandler());
900 <        assertTrue(r.ran);
700 <        checkCompletedNormally(g, two);
897 >        checkCompletedNormally(g, v1);
898 >        checkCompletedWithWrappedCFException(f, ex);
899 >        assertEquals(1, a.get());
900 >    }}
901  
902 <        f = new CompletableFuture<>();
903 <        g = f.handle(r = new IntegerHandler());
904 <        assertFalse(r.ran);
905 <        f.complete(one);
906 <        assertTrue(r.ran);
907 <        checkCompletedNormally(g, two);
908 <    }
902 >    /**
903 >     * handle action completes normally with function value on
904 >     * cancelled source
905 >     */
906 >    public void testHandle_sourceCancelled() {
907 >        for (ExecutionMode m : ExecutionMode.values())
908 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
909 >        for (boolean createIncomplete : new boolean[] { true, false })
910 >        for (Integer v1 : new Integer[] { 1, null })
911 >    {
912 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
913 >        final AtomicInteger a = new AtomicInteger(0);
914 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
915 >        final CompletableFuture<Integer> g = m.handle
916 >            (f,
917 >             (Integer x, Throwable t) -> {
918 >                m.checkExecutionMode();
919 >                threadAssertNull(x);
920 >                threadAssertTrue(t instanceof CancellationException);
921 >                a.getAndIncrement();
922 >                return v1;
923 >            });
924 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
925 >
926 >        checkCompletedNormally(g, v1);
927 >        checkCancelled(f);
928 >        assertEquals(1, a.get());
929 >    }}
930  
931      /**
932 <     * runAsync completes after running Runnable
932 >     * handle result completes exceptionally if action does
933       */
934 <    public void testRunAsync() {
935 <        Noop r = new Noop();
936 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
937 <        assertNull(f.join());
938 <        assertTrue(r.ran);
939 <        checkCompletedNormally(f, null);
940 <    }
934 >    public void testHandle_sourceFailedActionFailed() {
935 >        for (ExecutionMode m : ExecutionMode.values())
936 >        for (boolean createIncomplete : new boolean[] { true, false })
937 >    {
938 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
939 >        final AtomicInteger a = new AtomicInteger(0);
940 >        final CFException ex1 = new CFException();
941 >        final CFException ex2 = new CFException();
942 >        if (!createIncomplete) f.completeExceptionally(ex1);
943 >        final CompletableFuture<Integer> g = m.handle
944 >            (f,
945 >             (Integer x, Throwable t) -> {
946 >                m.checkExecutionMode();
947 >                threadAssertNull(x);
948 >                threadAssertSame(ex1, t);
949 >                a.getAndIncrement();
950 >                throw ex2;
951 >            });
952 >        if (createIncomplete) f.completeExceptionally(ex1);
953 >
954 >        checkCompletedWithWrappedCFException(g, ex2);
955 >        checkCompletedWithWrappedCFException(f, ex1);
956 >        assertEquals(1, a.get());
957 >    }}
958 >
959 >    public void testHandle_sourceCompletedNormallyActionFailed() {
960 >        for (ExecutionMode m : ExecutionMode.values())
961 >        for (boolean createIncomplete : new boolean[] { true, false })
962 >        for (Integer v1 : new Integer[] { 1, null })
963 >    {
964 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
965 >        final AtomicInteger a = new AtomicInteger(0);
966 >        final CFException ex = new CFException();
967 >        if (!createIncomplete) f.complete(v1);
968 >        final CompletableFuture<Integer> g = m.handle
969 >            (f,
970 >             (Integer x, Throwable t) -> {
971 >                m.checkExecutionMode();
972 >                threadAssertSame(x, v1);
973 >                threadAssertNull(t);
974 >                a.getAndIncrement();
975 >                throw ex;
976 >            });
977 >        if (createIncomplete) f.complete(v1);
978 >
979 >        checkCompletedWithWrappedCFException(g, ex);
980 >        checkCompletedNormally(f, v1);
981 >        assertEquals(1, a.get());
982 >    }}
983  
984      /**
985 <     * runAsync with executor completes after running Runnable
985 >     * runAsync completes after running Runnable
986       */
987 <    public void testRunAsync2() {
988 <        Noop r = new Noop();
989 <        ThreadExecutor exec = new ThreadExecutor();
990 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r, exec);
987 >    public void testRunAsync_normalCompletion() {
988 >        ExecutionMode[] executionModes = {
989 >            ExecutionMode.ASYNC,
990 >            ExecutionMode.EXECUTOR,
991 >        };
992 >        for (ExecutionMode m : executionModes)
993 >    {
994 >        final Noop r = new Noop(m);
995 >        final CompletableFuture<Void> f = m.runAsync(r);
996          assertNull(f.join());
729        assertTrue(r.ran);
997          checkCompletedNormally(f, null);
998 <        assertEquals(1, exec.count.get());
999 <    }
998 >        assertEquals(1, r.invocationCount);
999 >    }}
1000  
1001      /**
1002       * failing runAsync completes exceptionally after running Runnable
1003       */
1004 <    public void testRunAsync3() {
1005 <        FailingNoop r = new FailingNoop();
1006 <        CompletableFuture<Void> f = CompletableFuture.runAsync(r);
1004 >    public void testRunAsync_exceptionalCompletion() {
1005 >        ExecutionMode[] executionModes = {
1006 >            ExecutionMode.ASYNC,
1007 >            ExecutionMode.EXECUTOR,
1008 >        };
1009 >        for (ExecutionMode m : executionModes)
1010 >    {
1011 >        final FailingRunnable r = new FailingRunnable(m);
1012 >        final CompletableFuture<Void> f = m.runAsync(r);
1013          checkCompletedWithWrappedCFException(f);
1014 <        assertTrue(r.ran);
1015 <    }
1014 >        assertEquals(1, r.invocationCount);
1015 >    }}
1016  
1017      /**
1018       * supplyAsync completes with result of supplier
1019       */
1020 <    public void testSupplyAsync() {
1021 <        CompletableFuture<Integer> f;
1022 <        f = CompletableFuture.supplyAsync(supplyOne);
1023 <        assertEquals(f.join(), one);
1024 <        checkCompletedNormally(f, one);
1025 <    }
1026 <
1027 <    /**
1028 <     * supplyAsync with executor completes with result of supplier
1029 <     */
1030 <    public void testSupplyAsync2() {
1031 <        CompletableFuture<Integer> f;
1032 <        f = CompletableFuture.supplyAsync(supplyOne, new ThreadExecutor());
1033 <        assertEquals(f.join(), one);
761 <        checkCompletedNormally(f, one);
762 <    }
1020 >    public void testSupplyAsync_normalCompletion() {
1021 >        ExecutionMode[] executionModes = {
1022 >            ExecutionMode.ASYNC,
1023 >            ExecutionMode.EXECUTOR,
1024 >        };
1025 >        for (ExecutionMode m : executionModes)
1026 >        for (Integer v1 : new Integer[] { 1, null })
1027 >    {
1028 >        final IntegerSupplier r = new IntegerSupplier(m, v1);
1029 >        final CompletableFuture<Integer> f = m.supplyAsync(r);
1030 >        assertSame(v1, f.join());
1031 >        checkCompletedNormally(f, v1);
1032 >        assertEquals(1, r.invocationCount);
1033 >    }}
1034  
1035      /**
1036       * Failing supplyAsync completes exceptionally
1037       */
1038 <    public void testSupplyAsync3() {
1039 <        FailingSupplier r = new FailingSupplier();
1040 <        CompletableFuture<Integer> f = CompletableFuture.supplyAsync(r);
1038 >    public void testSupplyAsync_exceptionalCompletion() {
1039 >        ExecutionMode[] executionModes = {
1040 >            ExecutionMode.ASYNC,
1041 >            ExecutionMode.EXECUTOR,
1042 >        };
1043 >        for (ExecutionMode m : executionModes)
1044 >    {
1045 >        FailingSupplier r = new FailingSupplier(m);
1046 >        CompletableFuture<Integer> f = m.supplyAsync(r);
1047          checkCompletedWithWrappedCFException(f);
1048 <        assertTrue(r.ran);
1049 <    }
1048 >        assertEquals(1, r.invocationCount);
1049 >    }}
1050  
1051      // seq completion methods
1052  
1053      /**
1054       * thenRun result completes normally after normal completion of source
1055       */
1056 <    public void testThenRun() {
1057 <        CompletableFuture<Integer> f;
1058 <        CompletableFuture<Void> g;
1059 <        Noop r;
1060 <
1061 <        f = new CompletableFuture<>();
1062 <        g = f.thenRun(r = new Noop());
1063 <        f.complete(null);
1064 <        checkCompletedNormally(g, null);
1065 <        assertTrue(r.ran);
1056 >    public void testThenRun_normalCompletion() {
1057 >        for (ExecutionMode m : ExecutionMode.values())
1058 >        for (boolean createIncomplete : new boolean[] { true, false })
1059 >        for (Integer v1 : new Integer[] { 1, null })
1060 >    {
1061 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1062 >        final Noop r = new Noop(m);
1063 >        if (!createIncomplete) f.complete(v1);
1064 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1065 >        if (createIncomplete) {
1066 >            checkIncomplete(g);
1067 >            f.complete(v1);
1068 >        }
1069  
790        f = new CompletableFuture<>();
791        f.complete(null);
792        g = f.thenRun(r = new Noop());
1070          checkCompletedNormally(g, null);
1071 <        assertTrue(r.ran);
1072 <    }
1071 >        checkCompletedNormally(f, v1);
1072 >        assertEquals(1, r.invocationCount);
1073 >    }}
1074  
1075      /**
1076       * thenRun result completes exceptionally after exceptional
1077       * completion of source
1078       */
1079 <    public void testThenRun2() {
1080 <        CompletableFuture<Integer> f;
1081 <        CompletableFuture<Void> g;
1082 <        Noop r;
1083 <
1084 <        f = new CompletableFuture<>();
1085 <        g = f.thenRun(r = new Noop());
1086 <        f.completeExceptionally(new CFException());
1087 <        checkCompletedWithWrappedCFException(g);
1088 <        assertFalse(r.ran);
1079 >    public void testThenRun_exceptionalCompletion() {
1080 >        for (ExecutionMode m : ExecutionMode.values())
1081 >        for (boolean createIncomplete : new boolean[] { true, false })
1082 >    {
1083 >        final CFException ex = new CFException();
1084 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1085 >        final Noop r = new Noop(m);
1086 >        if (!createIncomplete) f.completeExceptionally(ex);
1087 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1088 >        if (createIncomplete) {
1089 >            checkIncomplete(g);
1090 >            f.completeExceptionally(ex);
1091 >        }
1092  
1093 <        f = new CompletableFuture<>();
1094 <        f.completeExceptionally(new CFException());
1095 <        g = f.thenRun(r = new Noop());
1096 <        checkCompletedWithWrappedCFException(g);
816 <        assertFalse(r.ran);
817 <    }
1093 >        checkCompletedWithWrappedCFException(g, ex);
1094 >        checkCompletedWithWrappedCFException(f, ex);
1095 >        assertEquals(0, r.invocationCount);
1096 >    }}
1097  
1098      /**
1099 <     * thenRun result completes exceptionally if action does
1099 >     * thenRun result completes exceptionally if source cancelled
1100       */
1101 <    public void testThenRun3() {
1102 <        CompletableFuture<Integer> f;
1103 <        CompletableFuture<Void> g;
1104 <        FailingNoop r;
1105 <
1106 <        f = new CompletableFuture<>();
1107 <        g = f.thenRun(r = new FailingNoop());
1108 <        f.complete(null);
1109 <        checkCompletedWithWrappedCFException(g);
1101 >    public void testThenRun_sourceCancelled() {
1102 >        for (ExecutionMode m : ExecutionMode.values())
1103 >        for (boolean createIncomplete : new boolean[] { true, false })
1104 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1105 >    {
1106 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1107 >        final Noop r = new Noop(m);
1108 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1109 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1110 >        if (createIncomplete) {
1111 >            checkIncomplete(g);
1112 >            assertTrue(f.cancel(mayInterruptIfRunning));
1113 >        }
1114  
1115 <        f = new CompletableFuture<>();
1116 <        f.complete(null);
1117 <        g = f.thenRun(r = new FailingNoop());
1118 <        checkCompletedWithWrappedCFException(g);
836 <    }
1115 >        checkCompletedWithWrappedCancellationException(g);
1116 >        checkCancelled(f);
1117 >        assertEquals(0, r.invocationCount);
1118 >    }}
1119  
1120      /**
1121 <     * thenRun result completes exceptionally if source cancelled
1121 >     * thenRun result completes exceptionally if action does
1122       */
1123 <    public void testThenRun4() {
1124 <        CompletableFuture<Integer> f;
1125 <        CompletableFuture<Void> g;
1126 <        Noop r;
1127 <
1128 <        f = new CompletableFuture<>();
1129 <        g = f.thenRun(r = new Noop());
1130 <        assertTrue(f.cancel(true));
1131 <        checkCompletedWithWrappedCancellationException(g);
1123 >    public void testThenRun_actionFailed() {
1124 >        for (ExecutionMode m : ExecutionMode.values())
1125 >        for (boolean createIncomplete : new boolean[] { true, false })
1126 >        for (Integer v1 : new Integer[] { 1, null })
1127 >    {
1128 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1129 >        final FailingRunnable r = new FailingRunnable(m);
1130 >        if (!createIncomplete) f.complete(v1);
1131 >        final CompletableFuture<Void> g = m.thenRun(f, r);
1132 >        if (createIncomplete) {
1133 >            checkIncomplete(g);
1134 >            f.complete(v1);
1135 >        }
1136  
1137 <        f = new CompletableFuture<>();
1138 <        assertTrue(f.cancel(true));
1139 <        g = f.thenRun(r = new Noop());
854 <        checkCompletedWithWrappedCancellationException(g);
855 <    }
1137 >        checkCompletedWithWrappedCFException(g);
1138 >        checkCompletedNormally(f, v1);
1139 >    }}
1140  
1141      /**
1142       * thenApply result completes normally after normal completion of source
1143       */
1144 <    public void testThenApply() {
1145 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1146 <        CompletableFuture<Integer> g = f.thenApply(inc);
1147 <        f.complete(one);
1148 <        checkCompletedNormally(g, two);
1149 <    }
1144 >    public void testThenApply_normalCompletion() {
1145 >        for (ExecutionMode m : ExecutionMode.values())
1146 >        for (boolean createIncomplete : new boolean[] { true, false })
1147 >        for (Integer v1 : new Integer[] { 1, null })
1148 >    {
1149 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1150 >        final IncFunction r = new IncFunction(m);
1151 >        if (!createIncomplete) f.complete(v1);
1152 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1153 >        if (createIncomplete) {
1154 >            checkIncomplete(g);
1155 >            f.complete(v1);
1156 >        }
1157 >
1158 >        checkCompletedNormally(g, inc(v1));
1159 >        checkCompletedNormally(f, v1);
1160 >        assertEquals(1, r.invocationCount);
1161 >    }}
1162  
1163      /**
1164       * thenApply result completes exceptionally after exceptional
1165       * completion of source
1166       */
1167 <    public void testThenApply2() {
1168 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1169 <        CompletableFuture<Integer> g = f.thenApply(inc);
1170 <        f.completeExceptionally(new CFException());
1171 <        checkCompletedWithWrappedCFException(g);
1172 <    }
1167 >    public void testThenApply_exceptionalCompletion() {
1168 >        for (ExecutionMode m : ExecutionMode.values())
1169 >        for (boolean createIncomplete : new boolean[] { true, false })
1170 >    {
1171 >        final CFException ex = new CFException();
1172 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1173 >        final IncFunction r = new IncFunction(m);
1174 >        if (!createIncomplete) f.completeExceptionally(ex);
1175 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1176 >        if (createIncomplete) {
1177 >            checkIncomplete(g);
1178 >            f.completeExceptionally(ex);
1179 >        }
1180  
1181 <    /**
1182 <     * thenApply result completes exceptionally if action does
1183 <     */
1184 <    public void testThenApply3() {
882 <        CompletableFuture<Integer> f = new CompletableFuture<>();
883 <        CompletableFuture<Integer> g = f.thenApply(new FailingFunction());
884 <        f.complete(one);
885 <        checkCompletedWithWrappedCFException(g);
886 <    }
1181 >        checkCompletedWithWrappedCFException(g, ex);
1182 >        checkCompletedWithWrappedCFException(f, ex);
1183 >        assertEquals(0, r.invocationCount);
1184 >    }}
1185  
1186      /**
1187       * thenApply result completes exceptionally if source cancelled
1188       */
1189 <    public void testThenApply4() {
1190 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1191 <        CompletableFuture<Integer> g = f.thenApply(inc);
1192 <        assertTrue(f.cancel(true));
1189 >    public void testThenApply_sourceCancelled() {
1190 >        for (ExecutionMode m : ExecutionMode.values())
1191 >        for (boolean createIncomplete : new boolean[] { true, false })
1192 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1193 >    {
1194 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1195 >        final IncFunction r = new IncFunction(m);
1196 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1197 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1198 >        if (createIncomplete) {
1199 >            checkIncomplete(g);
1200 >            assertTrue(f.cancel(mayInterruptIfRunning));
1201 >        }
1202 >
1203          checkCompletedWithWrappedCancellationException(g);
1204 <    }
1204 >        checkCancelled(f);
1205 >        assertEquals(0, r.invocationCount);
1206 >    }}
1207 >
1208 >    /**
1209 >     * thenApply result completes exceptionally if action does
1210 >     */
1211 >    public void testThenApply_actionFailed() {
1212 >        for (ExecutionMode m : ExecutionMode.values())
1213 >        for (boolean createIncomplete : new boolean[] { true, false })
1214 >        for (Integer v1 : new Integer[] { 1, null })
1215 >    {
1216 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1217 >        final FailingFunction r = new FailingFunction(m);
1218 >        if (!createIncomplete) f.complete(v1);
1219 >        final CompletableFuture<Integer> g = m.thenApply(f, r);
1220 >        if (createIncomplete) {
1221 >            checkIncomplete(g);
1222 >            f.complete(v1);
1223 >        }
1224 >
1225 >        checkCompletedWithWrappedCFException(g);
1226 >        checkCompletedNormally(f, v1);
1227 >    }}
1228  
1229      /**
1230       * thenAccept result completes normally after normal completion of source
1231       */
1232 <    public void testThenAccept() {
1233 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1234 <        IncAction r = new IncAction();
1235 <        CompletableFuture<Void> g = f.thenAccept(r);
1236 <        f.complete(one);
1232 >    public void testThenAccept_normalCompletion() {
1233 >        for (ExecutionMode m : ExecutionMode.values())
1234 >        for (boolean createIncomplete : new boolean[] { true, false })
1235 >        for (Integer v1 : new Integer[] { 1, null })
1236 >    {
1237 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1238 >        final IncAction r = new IncAction();
1239 >        if (!createIncomplete) f.complete(v1);
1240 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1241 >        if (createIncomplete) {
1242 >            checkIncomplete(g);
1243 >            f.complete(v1);
1244 >        }
1245 >
1246          checkCompletedNormally(g, null);
1247 <        assertEquals(r.value, (Integer) 2);
1248 <    }
1247 >        checkCompletedNormally(f, v1);
1248 >        assertEquals(1, r.invocationCount);
1249 >        assertEquals(inc(v1), r.value);
1250 >    }}
1251  
1252      /**
1253       * thenAccept result completes exceptionally after exceptional
1254       * completion of source
1255       */
1256 <    public void testThenAccept2() {
1257 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1258 <        IncAction r = new IncAction();
1259 <        CompletableFuture<Void> g = f.thenAccept(r);
1260 <        f.completeExceptionally(new CFException());
1261 <        checkCompletedWithWrappedCFException(g);
1262 <    }
1256 >    public void testThenAccept_exceptionalCompletion() {
1257 >        for (ExecutionMode m : ExecutionMode.values())
1258 >        for (boolean createIncomplete : new boolean[] { true, false })
1259 >    {
1260 >        final CFException ex = new CFException();
1261 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1262 >        final IncAction r = new IncAction();
1263 >        if (!createIncomplete) f.completeExceptionally(ex);
1264 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1265 >        if (createIncomplete) {
1266 >            checkIncomplete(g);
1267 >            f.completeExceptionally(ex);
1268 >        }
1269 >
1270 >        checkCompletedWithWrappedCFException(g, ex);
1271 >        checkCompletedWithWrappedCFException(f, ex);
1272 >        assertEquals(0, r.invocationCount);
1273 >    }}
1274  
1275      /**
1276       * thenAccept result completes exceptionally if action does
1277       */
1278 <    public void testThenAccept3() {
1279 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1280 <        FailingConsumer r = new FailingConsumer();
1281 <        CompletableFuture<Void> g = f.thenAccept(r);
1282 <        f.complete(one);
1278 >    public void testThenAccept_actionFailed() {
1279 >        for (ExecutionMode m : ExecutionMode.values())
1280 >        for (boolean createIncomplete : new boolean[] { true, false })
1281 >        for (Integer v1 : new Integer[] { 1, null })
1282 >    {
1283 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1284 >        final FailingConsumer r = new FailingConsumer(m);
1285 >        if (!createIncomplete) f.complete(v1);
1286 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1287 >        if (createIncomplete) {
1288 >            checkIncomplete(g);
1289 >            f.complete(v1);
1290 >        }
1291 >
1292          checkCompletedWithWrappedCFException(g);
1293 <        assertTrue(r.ran);
1294 <    }
1293 >        checkCompletedNormally(f, v1);
1294 >    }}
1295  
1296      /**
1297       * thenAccept result completes exceptionally if source cancelled
1298       */
1299 <    public void testThenAccept4() {
1300 <        CompletableFuture<Integer> f = new CompletableFuture<>();
1301 <        IncAction r = new IncAction();
1302 <        CompletableFuture<Void> g = f.thenAccept(r);
1303 <        assertTrue(f.cancel(true));
1299 >    public void testThenAccept_sourceCancelled() {
1300 >        for (ExecutionMode m : ExecutionMode.values())
1301 >        for (boolean createIncomplete : new boolean[] { true, false })
1302 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1303 >    {
1304 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1305 >        final IncAction r = new IncAction();
1306 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1307 >        final CompletableFuture<Void> g = m.thenAccept(f, r);
1308 >        if (createIncomplete) {
1309 >            checkIncomplete(g);
1310 >            assertTrue(f.cancel(mayInterruptIfRunning));
1311 >        }
1312 >
1313          checkCompletedWithWrappedCancellationException(g);
1314 <    }
1314 >        checkCancelled(f);
1315 >        assertEquals(0, r.invocationCount);
1316 >    }}
1317  
1318      /**
1319       * thenCombine result completes normally after normal completion
1320       * of sources
1321       */
1322 <    public void testThenCombine_normalCompletion1() {
950 <        for (boolean createdIncomplete : new boolean[] { true, false })
951 <        for (boolean fFirst : new boolean[] { true, false })
1322 >    public void testThenCombine_normalCompletion() {
1323          for (ExecutionMode m : ExecutionMode.values())
1324 +        for (boolean createIncomplete : new boolean[] { true, false })
1325 +        for (boolean fFirst : new boolean[] { true, false })
1326          for (Integer v1 : new Integer[] { 1, null })
1327 <        for (Integer v2 : new Integer[] { 2, null }) {
1328 <
1327 >        for (Integer v2 : new Integer[] { 2, null })
1328 >    {
1329          final CompletableFuture<Integer> f = new CompletableFuture<>();
1330          final CompletableFuture<Integer> g = new CompletableFuture<>();
1331 <        final SubtractFunction r = new SubtractFunction();
959 <        CompletableFuture<Integer> h = null;
960 <        if (createdIncomplete) h = m.thenCombine(f, g, r);
1331 >        final SubtractFunction r = new SubtractFunction(m);
1332  
1333 <        if (fFirst)
1334 <            f.complete(v1);
1335 <        else
1336 <            g.complete(v2);
1337 <        if (createdIncomplete) checkIncomplete(h);
1338 <        assertEquals(r.invocationCount, 0);
1339 <        if (!fFirst)
1340 <            f.complete(v1);
1341 <        else
971 <            g.complete(v2);
972 <        if (!createdIncomplete) h = m.thenCombine(f, g, r);
1333 >        if (fFirst) f.complete(v1); else g.complete(v2);
1334 >        if (!createIncomplete)
1335 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1336 >        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1337 >        if (createIncomplete) {
1338 >            checkIncomplete(h);
1339 >            assertEquals(0, r.invocationCount);
1340 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1341 >        }
1342  
1343          checkCompletedNormally(h, subtract(v1, v2));
1344          checkCompletedNormally(f, v1);
1345          checkCompletedNormally(g, v2);
1346 <        assertEquals(r.invocationCount, 1);
1347 <        }
979 <    }
1346 >        assertEquals(1, r.invocationCount);
1347 >    }}
1348  
1349      /**
1350       * thenCombine result completes exceptionally after exceptional
1351       * completion of either source
1352       */
1353 <    public void testThenCombine_exceptionalCompletion1() {
1353 >    public void testThenCombine_exceptionalCompletion() {
1354          for (ExecutionMode m : ExecutionMode.values())
1355 <        for (Integer v1 : new Integer[] { 1, null }) {
1356 <
1355 >        for (boolean createIncomplete : new boolean[] { true, false })
1356 >        for (boolean fFirst : new boolean[] { true, false })
1357 >        for (Integer v1 : new Integer[] { 1, null })
1358 >    {
1359          final CompletableFuture<Integer> f = new CompletableFuture<>();
1360          final CompletableFuture<Integer> g = new CompletableFuture<>();
991        final SubtractFunction r = new SubtractFunction();
992        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1361          final CFException ex = new CFException();
1362 +        final SubtractFunction r = new SubtractFunction(m);
1363  
1364 <        f.completeExceptionally(ex);
1365 <        checkIncomplete(h);
1366 <        g.complete(v1);
998 <
999 <        checkCompletedWithWrappedCFException(h, ex);
1000 <        checkCompletedWithWrappedCFException(f, ex);
1001 <        assertEquals(r.invocationCount, 0);
1002 <        checkCompletedNormally(g, v1);
1003 <        }
1004 <    }
1005 <
1006 <    public void testThenCombine_exceptionalCompletion2() {
1007 <        for (ExecutionMode m : ExecutionMode.values())
1008 <        for (Integer v1 : new Integer[] { 1, null }) {
1009 <
1010 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1011 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1012 <        final SubtractFunction r = new SubtractFunction();
1364 >        (fFirst ? f : g).complete(v1);
1365 >        if (!createIncomplete)
1366 >            (!fFirst ? f : g).completeExceptionally(ex);
1367          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1368 <        final CFException ex = new CFException();
1369 <
1370 <        g.completeExceptionally(ex);
1017 <        checkIncomplete(h);
1018 <        f.complete(v1);
1019 <
1020 <        checkCompletedWithWrappedCFException(h, ex);
1021 <        checkCompletedWithWrappedCFException(g, ex);
1022 <        assertEquals(r.invocationCount, 0);
1023 <        checkCompletedNormally(f, v1);
1368 >        if (createIncomplete) {
1369 >            checkIncomplete(h);
1370 >            (!fFirst ? f : g).completeExceptionally(ex);
1371          }
1025    }
1026
1027    public void testThenCombine_exceptionalCompletion3() {
1028        for (ExecutionMode m : ExecutionMode.values())
1029        for (Integer v1 : new Integer[] { 1, null }) {
1030
1031        final CompletableFuture<Integer> f = new CompletableFuture<>();
1032        final CompletableFuture<Integer> g = new CompletableFuture<>();
1033        final SubtractFunction r = new SubtractFunction();
1034        final CFException ex = new CFException();
1035
1036        g.completeExceptionally(ex);
1037        f.complete(v1);
1038        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1372  
1373          checkCompletedWithWrappedCFException(h, ex);
1374 <        checkCompletedWithWrappedCFException(g, ex);
1375 <        assertEquals(r.invocationCount, 0);
1376 <        checkCompletedNormally(f, v1);
1377 <        }
1045 <    }
1046 <
1047 <    public void testThenCombine_exceptionalCompletion4() {
1048 <        for (ExecutionMode m : ExecutionMode.values())
1049 <        for (Integer v1 : new Integer[] { 1, null }) {
1050 <
1051 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1052 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1053 <        final SubtractFunction r = new SubtractFunction();
1054 <        final CFException ex = new CFException();
1055 <
1056 <        f.completeExceptionally(ex);
1057 <        g.complete(v1);
1058 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1059 <
1060 <        checkCompletedWithWrappedCFException(h, ex);
1061 <        checkCompletedWithWrappedCFException(f, ex);
1062 <        assertEquals(r.invocationCount, 0);
1063 <        checkCompletedNormally(g, v1);
1064 <        }
1065 <    }
1374 >        assertEquals(0, r.invocationCount);
1375 >        checkCompletedNormally(fFirst ? f : g, v1);
1376 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1377 >    }}
1378  
1379      /**
1380       * thenCombine result completes exceptionally if action does
1381       */
1382 <    public void testThenCombine_actionFailed1() {
1382 >    public void testThenCombine_actionFailed() {
1383          for (ExecutionMode m : ExecutionMode.values())
1384 +        for (boolean fFirst : new boolean[] { true, false })
1385          for (Integer v1 : new Integer[] { 1, null })
1386 <        for (Integer v2 : new Integer[] { 2, null }) {
1387 <
1386 >        for (Integer v2 : new Integer[] { 2, null })
1387 >    {
1388          final CompletableFuture<Integer> f = new CompletableFuture<>();
1389          final CompletableFuture<Integer> g = new CompletableFuture<>();
1390 <        final FailingBiFunction r = new FailingBiFunction();
1390 >        final FailingBiFunction r = new FailingBiFunction(m);
1391          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1392  
1393 <        f.complete(v1);
1394 <        checkIncomplete(h);
1395 <        g.complete(v2);
1396 <
1397 <        checkCompletedWithWrappedCFException(h);
1398 <        checkCompletedNormally(f, v1);
1086 <        checkCompletedNormally(g, v2);
1393 >        if (fFirst) {
1394 >            f.complete(v1);
1395 >            g.complete(v2);
1396 >        } else {
1397 >            g.complete(v2);
1398 >            f.complete(v1);
1399          }
1088    }
1089
1090    public void testThenCombine_actionFailed2() {
1091        for (ExecutionMode m : ExecutionMode.values())
1092        for (Integer v1 : new Integer[] { 1, null })
1093        for (Integer v2 : new Integer[] { 2, null }) {
1094
1095        final CompletableFuture<Integer> f = new CompletableFuture<>();
1096        final CompletableFuture<Integer> g = new CompletableFuture<>();
1097        final FailingBiFunction r = new FailingBiFunction();
1098        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1099
1100        g.complete(v2);
1101        checkIncomplete(h);
1102        f.complete(v1);
1400  
1401          checkCompletedWithWrappedCFException(h);
1402          checkCompletedNormally(f, v1);
1403          checkCompletedNormally(g, v2);
1404 <        }
1108 <    }
1404 >    }}
1405  
1406      /**
1407       * thenCombine result completes exceptionally if either source cancelled
1408       */
1409 <    public void testThenCombine_sourceCancelled1() {
1409 >    public void testThenCombine_sourceCancelled() {
1410          for (ExecutionMode m : ExecutionMode.values())
1411          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1412 <        for (Integer v1 : new Integer[] { 1, null }) {
1413 <
1414 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1415 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1120 <        final SubtractFunction r = new SubtractFunction();
1121 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1122 <
1123 <        assertTrue(f.cancel(mayInterruptIfRunning));
1124 <        checkIncomplete(h);
1125 <        g.complete(v1);
1126 <
1127 <        checkCompletedWithWrappedCancellationException(h);
1128 <        checkCancelled(f);
1129 <        assertEquals(r.invocationCount, 0);
1130 <        checkCompletedNormally(g, v1);
1131 <        }
1132 <    }
1133 <
1134 <    public void testThenCombine_sourceCancelled2() {
1135 <        for (ExecutionMode m : ExecutionMode.values())
1136 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1137 <        for (Integer v1 : new Integer[] { 1, null }) {
1138 <
1139 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1140 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1141 <        final SubtractFunction r = new SubtractFunction();
1142 <        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1143 <
1144 <        assertTrue(g.cancel(mayInterruptIfRunning));
1145 <        checkIncomplete(h);
1146 <        f.complete(v1);
1147 <
1148 <        checkCompletedWithWrappedCancellationException(h);
1149 <        checkCancelled(g);
1150 <        assertEquals(r.invocationCount, 0);
1151 <        checkCompletedNormally(f, v1);
1152 <        }
1153 <    }
1154 <
1155 <    public void testThenCombine_sourceCancelled3() {
1156 <        for (ExecutionMode m : ExecutionMode.values())
1157 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1158 <        for (Integer v1 : new Integer[] { 1, null }) {
1159 <
1412 >        for (boolean createIncomplete : new boolean[] { true, false })
1413 >        for (boolean fFirst : new boolean[] { true, false })
1414 >        for (Integer v1 : new Integer[] { 1, null })
1415 >    {
1416          final CompletableFuture<Integer> f = new CompletableFuture<>();
1417          final CompletableFuture<Integer> g = new CompletableFuture<>();
1418 <        final SubtractFunction r = new SubtractFunction();
1418 >        final SubtractFunction r = new SubtractFunction(m);
1419  
1420 <        assertTrue(g.cancel(mayInterruptIfRunning));
1421 <        f.complete(v1);
1420 >        (fFirst ? f : g).complete(v1);
1421 >        if (!createIncomplete)
1422 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1423          final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1424 <
1425 <        checkCompletedWithWrappedCancellationException(h);
1426 <        checkCancelled(g);
1170 <        assertEquals(r.invocationCount, 0);
1171 <        checkCompletedNormally(f, v1);
1424 >        if (createIncomplete) {
1425 >            checkIncomplete(h);
1426 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1427          }
1173    }
1174
1175    public void testThenCombine_sourceCancelled4() {
1176        for (ExecutionMode m : ExecutionMode.values())
1177        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1178        for (Integer v1 : new Integer[] { 1, null }) {
1179
1180        final CompletableFuture<Integer> f = new CompletableFuture<>();
1181        final CompletableFuture<Integer> g = new CompletableFuture<>();
1182        final SubtractFunction r = new SubtractFunction();
1183
1184        assertTrue(f.cancel(mayInterruptIfRunning));
1185        g.complete(v1);
1186        final CompletableFuture<Integer> h = m.thenCombine(f, g, r);
1428  
1429          checkCompletedWithWrappedCancellationException(h);
1430 <        checkCancelled(f);
1431 <        assertEquals(r.invocationCount, 0);
1432 <        checkCompletedNormally(g, v1);
1433 <        }
1193 <    }
1430 >        checkCancelled(!fFirst ? f : g);
1431 >        assertEquals(0, r.invocationCount);
1432 >        checkCompletedNormally(fFirst ? f : g, v1);
1433 >    }}
1434  
1435      /**
1436       * thenAcceptBoth result completes normally after normal
1437       * completion of sources
1438       */
1439 <    public void testThenAcceptBoth_normalCompletion1() {
1200 <        for (ExecutionMode m : ExecutionMode.values())
1201 <        for (Integer v1 : new Integer[] { 1, null })
1202 <        for (Integer v2 : new Integer[] { 2, null }) {
1203 <
1204 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1205 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1206 <        final SubtractAction r = new SubtractAction();
1207 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1208 <
1209 <        f.complete(v1);
1210 <        checkIncomplete(h);
1211 <        assertFalse(r.ran());
1212 <        g.complete(v2);
1213 <
1214 <        checkCompletedNormally(h, null);
1215 <        assertEquals(r.value, subtract(v1, v2));
1216 <        checkCompletedNormally(f, v1);
1217 <        checkCompletedNormally(g, v2);
1218 <        }
1219 <    }
1220 <
1221 <    public void testThenAcceptBoth_normalCompletion2() {
1222 <        for (ExecutionMode m : ExecutionMode.values())
1223 <        for (Integer v1 : new Integer[] { 1, null })
1224 <        for (Integer v2 : new Integer[] { 2, null }) {
1225 <
1226 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1227 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1228 <        final SubtractAction r = new SubtractAction();
1229 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1230 <
1231 <        g.complete(v2);
1232 <        checkIncomplete(h);
1233 <        assertFalse(r.ran());
1234 <        f.complete(v1);
1235 <
1236 <        checkCompletedNormally(h, null);
1237 <        assertEquals(r.value, subtract(v1, v2));
1238 <        checkCompletedNormally(f, v1);
1239 <        checkCompletedNormally(g, v2);
1240 <        }
1241 <    }
1242 <
1243 <    public void testThenAcceptBoth_normalCompletion3() {
1439 >    public void testThenAcceptBoth_normalCompletion() {
1440          for (ExecutionMode m : ExecutionMode.values())
1441 +        for (boolean createIncomplete : new boolean[] { true, false })
1442 +        for (boolean fFirst : new boolean[] { true, false })
1443          for (Integer v1 : new Integer[] { 1, null })
1444 <        for (Integer v2 : new Integer[] { 2, null }) {
1445 <
1444 >        for (Integer v2 : new Integer[] { 2, null })
1445 >    {
1446          final CompletableFuture<Integer> f = new CompletableFuture<>();
1447          final CompletableFuture<Integer> g = new CompletableFuture<>();
1448 <        final SubtractAction r = new SubtractAction();
1448 >        final SubtractAction r = new SubtractAction(m);
1449  
1450 <        g.complete(v2);
1451 <        f.complete(v1);
1450 >        if (fFirst) f.complete(v1); else g.complete(v2);
1451 >        if (!createIncomplete)
1452 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1453          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1454 <
1455 <        checkCompletedNormally(h, null);
1456 <        assertEquals(r.value, subtract(v1, v2));
1457 <        checkCompletedNormally(f, v1);
1259 <        checkCompletedNormally(g, v2);
1454 >        if (createIncomplete) {
1455 >            checkIncomplete(h);
1456 >            assertEquals(0, r.invocationCount);
1457 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1458          }
1261    }
1262
1263    public void testThenAcceptBoth_normalCompletion4() {
1264        for (ExecutionMode m : ExecutionMode.values())
1265        for (Integer v1 : new Integer[] { 1, null })
1266        for (Integer v2 : new Integer[] { 2, null }) {
1267
1268        final CompletableFuture<Integer> f = new CompletableFuture<>();
1269        final CompletableFuture<Integer> g = new CompletableFuture<>();
1270        final SubtractAction r = new SubtractAction();
1271
1272        f.complete(v1);
1273        g.complete(v2);
1274        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1459  
1460          checkCompletedNormally(h, null);
1461 <        assertEquals(r.value, subtract(v1, v2));
1461 >        assertEquals(subtract(v1, v2), r.value);
1462          checkCompletedNormally(f, v1);
1463          checkCompletedNormally(g, v2);
1464 <        }
1281 <    }
1464 >    }}
1465  
1466      /**
1467       * thenAcceptBoth result completes exceptionally after exceptional
1468       * completion of either source
1469       */
1470 <    public void testThenAcceptBoth_exceptionalCompletion1() {
1288 <        for (ExecutionMode m : ExecutionMode.values())
1289 <        for (Integer v1 : new Integer[] { 1, null }) {
1290 <
1291 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1292 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1293 <        final SubtractAction r = new SubtractAction();
1294 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1295 <        final CFException ex = new CFException();
1296 <
1297 <        f.completeExceptionally(ex);
1298 <        checkIncomplete(h);
1299 <        g.complete(v1);
1300 <
1301 <        checkCompletedWithWrappedCFException(h, ex);
1302 <        checkCompletedWithWrappedCFException(f, ex);
1303 <        assertEquals(r.invocationCount, 0);
1304 <        checkCompletedNormally(g, v1);
1305 <        }
1306 <    }
1307 <
1308 <    public void testThenAcceptBoth_exceptionalCompletion2() {
1309 <        for (ExecutionMode m : ExecutionMode.values())
1310 <        for (Integer v1 : new Integer[] { 1, null }) {
1311 <
1312 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1313 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1314 <        final SubtractAction r = new SubtractAction();
1315 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1316 <        final CFException ex = new CFException();
1317 <
1318 <        g.completeExceptionally(ex);
1319 <        checkIncomplete(h);
1320 <        f.complete(v1);
1321 <
1322 <        checkCompletedWithWrappedCFException(h, ex);
1323 <        checkCompletedWithWrappedCFException(g, ex);
1324 <        assertEquals(r.invocationCount, 0);
1325 <        checkCompletedNormally(f, v1);
1326 <        }
1327 <    }
1328 <
1329 <    public void testThenAcceptBoth_exceptionalCompletion3() {
1470 >    public void testThenAcceptBoth_exceptionalCompletion() {
1471          for (ExecutionMode m : ExecutionMode.values())
1472 <        for (Integer v1 : new Integer[] { 1, null }) {
1473 <
1472 >        for (boolean createIncomplete : new boolean[] { true, false })
1473 >        for (boolean fFirst : new boolean[] { true, false })
1474 >        for (Integer v1 : new Integer[] { 1, null })
1475 >    {
1476          final CompletableFuture<Integer> f = new CompletableFuture<>();
1477          final CompletableFuture<Integer> g = new CompletableFuture<>();
1335        final SubtractAction r = new SubtractAction();
1478          final CFException ex = new CFException();
1479 +        final SubtractAction r = new SubtractAction(m);
1480  
1481 <        g.completeExceptionally(ex);
1482 <        f.complete(v1);
1481 >        (fFirst ? f : g).complete(v1);
1482 >        if (!createIncomplete)
1483 >            (!fFirst ? f : g).completeExceptionally(ex);
1484          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1485 <
1486 <        checkCompletedWithWrappedCFException(h, ex);
1487 <        checkCompletedWithWrappedCFException(g, ex);
1344 <        assertEquals(r.invocationCount, 0);
1345 <        checkCompletedNormally(f, v1);
1485 >        if (createIncomplete) {
1486 >            checkIncomplete(h);
1487 >            (!fFirst ? f : g).completeExceptionally(ex);
1488          }
1347    }
1348
1349    public void testThenAcceptBoth_exceptionalCompletion4() {
1350        for (ExecutionMode m : ExecutionMode.values())
1351        for (Integer v1 : new Integer[] { 1, null }) {
1352
1353        final CompletableFuture<Integer> f = new CompletableFuture<>();
1354        final CompletableFuture<Integer> g = new CompletableFuture<>();
1355        final SubtractAction r = new SubtractAction();
1356        final CFException ex = new CFException();
1357
1358        f.completeExceptionally(ex);
1359        g.complete(v1);
1360        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1489  
1490          checkCompletedWithWrappedCFException(h, ex);
1491 <        checkCompletedWithWrappedCFException(f, ex);
1492 <        assertFalse(r.ran());
1493 <        checkCompletedNormally(g, v1);
1494 <        }
1367 <    }
1491 >        assertEquals(0, r.invocationCount);
1492 >        checkCompletedNormally(fFirst ? f : g, v1);
1493 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1494 >    }}
1495  
1496      /**
1497       * thenAcceptBoth result completes exceptionally if action does
1498       */
1499 <    public void testThenAcceptBoth_actionFailed1() {
1499 >    public void testThenAcceptBoth_actionFailed() {
1500          for (ExecutionMode m : ExecutionMode.values())
1501 +        for (boolean fFirst : new boolean[] { true, false })
1502          for (Integer v1 : new Integer[] { 1, null })
1503 <        for (Integer v2 : new Integer[] { 2, null }) {
1504 <
1503 >        for (Integer v2 : new Integer[] { 2, null })
1504 >    {
1505          final CompletableFuture<Integer> f = new CompletableFuture<>();
1506          final CompletableFuture<Integer> g = new CompletableFuture<>();
1507 <        final FailingBiConsumer r = new FailingBiConsumer();
1507 >        final FailingBiConsumer r = new FailingBiConsumer(m);
1508          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1509  
1510 <        f.complete(v1);
1511 <        checkIncomplete(h);
1512 <        g.complete(v2);
1513 <
1514 <        checkCompletedWithWrappedCFException(h);
1515 <        checkCompletedNormally(f, v1);
1388 <        checkCompletedNormally(g, v2);
1510 >        if (fFirst) {
1511 >            f.complete(v1);
1512 >            g.complete(v2);
1513 >        } else {
1514 >            g.complete(v2);
1515 >            f.complete(v1);
1516          }
1390    }
1391
1392    public void testThenAcceptBoth_actionFailed2() {
1393        for (ExecutionMode m : ExecutionMode.values())
1394        for (Integer v1 : new Integer[] { 1, null })
1395        for (Integer v2 : new Integer[] { 2, null }) {
1396
1397        final CompletableFuture<Integer> f = new CompletableFuture<>();
1398        final CompletableFuture<Integer> g = new CompletableFuture<>();
1399        final FailingBiConsumer r = new FailingBiConsumer();
1400        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1401
1402        g.complete(v2);
1403        checkIncomplete(h);
1404        f.complete(v1);
1517  
1518          checkCompletedWithWrappedCFException(h);
1519          checkCompletedNormally(f, v1);
1520          checkCompletedNormally(g, v2);
1521 <        }
1410 <    }
1521 >    }}
1522  
1523      /**
1524       * thenAcceptBoth result completes exceptionally if either source cancelled
1525       */
1526 <    public void testThenAcceptBoth_sourceCancelled1() {
1526 >    public void testThenAcceptBoth_sourceCancelled() {
1527          for (ExecutionMode m : ExecutionMode.values())
1528          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1529 <        for (Integer v1 : new Integer[] { 1, null }) {
1530 <
1529 >        for (boolean createIncomplete : new boolean[] { true, false })
1530 >        for (boolean fFirst : new boolean[] { true, false })
1531 >        for (Integer v1 : new Integer[] { 1, null })
1532 >    {
1533          final CompletableFuture<Integer> f = new CompletableFuture<>();
1534          final CompletableFuture<Integer> g = new CompletableFuture<>();
1535 <        final SubtractAction r = new SubtractAction();
1423 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1535 >        final SubtractAction r = new SubtractAction(m);
1536  
1537 <        assertTrue(f.cancel(mayInterruptIfRunning));
1538 <        checkIncomplete(h);
1539 <        g.complete(v1);
1428 <
1429 <        checkCompletedWithWrappedCancellationException(h);
1430 <        checkCancelled(f);
1431 <        assertEquals(r.invocationCount, 0);
1432 <        checkCompletedNormally(g, v1);
1433 <        }
1434 <    }
1435 <
1436 <    public void testThenAcceptBoth_sourceCancelled2() {
1437 <        for (ExecutionMode m : ExecutionMode.values())
1438 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1439 <        for (Integer v1 : new Integer[] { 1, null }) {
1440 <
1441 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1442 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1443 <        final SubtractAction r = new SubtractAction();
1537 >        (fFirst ? f : g).complete(v1);
1538 >        if (!createIncomplete)
1539 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1540          final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1541 <
1542 <        assertTrue(g.cancel(mayInterruptIfRunning));
1543 <        checkIncomplete(h);
1448 <        f.complete(v1);
1449 <
1450 <        checkCompletedWithWrappedCancellationException(h);
1451 <        checkCancelled(g);
1452 <        assertEquals(r.invocationCount, 0);
1453 <        checkCompletedNormally(f, v1);
1541 >        if (createIncomplete) {
1542 >            checkIncomplete(h);
1543 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1544          }
1455    }
1456
1457    public void testThenAcceptBoth_sourceCancelled3() {
1458        for (ExecutionMode m : ExecutionMode.values())
1459        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1460        for (Integer v1 : new Integer[] { 1, null }) {
1461
1462        final CompletableFuture<Integer> f = new CompletableFuture<>();
1463        final CompletableFuture<Integer> g = new CompletableFuture<>();
1464        final SubtractAction r = new SubtractAction();
1465
1466        assertTrue(g.cancel(mayInterruptIfRunning));
1467        f.complete(v1);
1468        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1545  
1546          checkCompletedWithWrappedCancellationException(h);
1547 <        checkCancelled(g);
1548 <        assertEquals(r.invocationCount, 0);
1549 <        checkCompletedNormally(f, v1);
1550 <        }
1475 <    }
1476 <
1477 <    public void testThenAcceptBoth_sourceCancelled4() {
1478 <        for (ExecutionMode m : ExecutionMode.values())
1479 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1480 <        for (Integer v1 : new Integer[] { 1, null }) {
1481 <
1482 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1483 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1484 <        final SubtractAction r = new SubtractAction();
1485 <
1486 <        assertTrue(f.cancel(mayInterruptIfRunning));
1487 <        g.complete(v1);
1488 <        final CompletableFuture<Void> h = m.thenAcceptBoth(f, g, r);
1489 <
1490 <        checkCompletedWithWrappedCancellationException(h);
1491 <        checkCancelled(f);
1492 <        assertEquals(r.invocationCount, 0);
1493 <        checkCompletedNormally(g, v1);
1494 <        }
1495 <    }
1547 >        checkCancelled(!fFirst ? f : g);
1548 >        assertEquals(0, r.invocationCount);
1549 >        checkCompletedNormally(fFirst ? f : g, v1);
1550 >    }}
1551  
1552      /**
1553       * runAfterBoth result completes normally after normal
1554       * completion of sources
1555       */
1556 <    public void testRunAfterBoth_normalCompletion1() {
1502 <        for (ExecutionMode m : ExecutionMode.values())
1503 <        for (Integer v1 : new Integer[] { 1, null })
1504 <        for (Integer v2 : new Integer[] { 2, null }) {
1505 <
1506 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1507 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1508 <        final Noop r = new Noop();
1509 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1510 <
1511 <        f.complete(v1);
1512 <        checkIncomplete(h);
1513 <        assertFalse(r.ran);
1514 <        g.complete(v2);
1515 <
1516 <        checkCompletedNormally(h, null);
1517 <        assertEquals(r.invocationCount, 1);
1518 <        checkCompletedNormally(f, v1);
1519 <        checkCompletedNormally(g, v2);
1520 <        }
1521 <    }
1522 <
1523 <    public void testRunAfterBoth_normalCompletion2() {
1524 <        for (ExecutionMode m : ExecutionMode.values())
1525 <        for (Integer v1 : new Integer[] { 1, null })
1526 <        for (Integer v2 : new Integer[] { 2, null }) {
1527 <
1528 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1529 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1530 <        final Noop r = new Noop();
1531 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1532 <
1533 <        g.complete(v2);
1534 <        checkIncomplete(h);
1535 <        assertFalse(r.ran);
1536 <        f.complete(v1);
1537 <
1538 <        checkCompletedNormally(h, null);
1539 <        assertEquals(r.invocationCount, 1);
1540 <        checkCompletedNormally(f, v1);
1541 <        checkCompletedNormally(g, v2);
1542 <        }
1543 <    }
1544 <
1545 <    public void testRunAfterBoth_normalCompletion3() {
1556 >    public void testRunAfterBoth_normalCompletion() {
1557          for (ExecutionMode m : ExecutionMode.values())
1558 +        for (boolean createIncomplete : new boolean[] { true, false })
1559 +        for (boolean fFirst : new boolean[] { true, false })
1560          for (Integer v1 : new Integer[] { 1, null })
1561 <        for (Integer v2 : new Integer[] { 2, null }) {
1562 <
1561 >        for (Integer v2 : new Integer[] { 2, null })
1562 >    {
1563          final CompletableFuture<Integer> f = new CompletableFuture<>();
1564          final CompletableFuture<Integer> g = new CompletableFuture<>();
1565 <        final Noop r = new Noop();
1565 >        final Noop r = new Noop(m);
1566  
1567 <        g.complete(v2);
1568 <        f.complete(v1);
1567 >        if (fFirst) f.complete(v1); else g.complete(v2);
1568 >        if (!createIncomplete)
1569 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1570          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1571 <
1572 <        checkCompletedNormally(h, null);
1573 <        assertTrue(r.ran);
1574 <        checkCompletedNormally(f, v1);
1561 <        checkCompletedNormally(g, v2);
1571 >        if (createIncomplete) {
1572 >            checkIncomplete(h);
1573 >            assertEquals(0, r.invocationCount);
1574 >            if (!fFirst) f.complete(v1); else g.complete(v2);
1575          }
1563    }
1564
1565    public void testRunAfterBoth_normalCompletion4() {
1566        for (ExecutionMode m : ExecutionMode.values())
1567        for (Integer v1 : new Integer[] { 1, null })
1568        for (Integer v2 : new Integer[] { 2, null }) {
1569
1570        final CompletableFuture<Integer> f = new CompletableFuture<>();
1571        final CompletableFuture<Integer> g = new CompletableFuture<>();
1572        final Noop r = new Noop();
1573
1574        f.complete(v1);
1575        g.complete(v2);
1576        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1576  
1577          checkCompletedNormally(h, null);
1578 <        assertEquals(r.invocationCount, 1);
1578 >        assertEquals(1, r.invocationCount);
1579          checkCompletedNormally(f, v1);
1580          checkCompletedNormally(g, v2);
1581 <        }
1583 <    }
1581 >    }}
1582  
1583      /**
1584       * runAfterBoth result completes exceptionally after exceptional
1585       * completion of either source
1586       */
1587 <    public void testRunAfterBoth_exceptionalCompletion1() {
1590 <        for (ExecutionMode m : ExecutionMode.values())
1591 <        for (Integer v1 : new Integer[] { 1, null }) {
1592 <
1593 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1594 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1595 <        final Noop r = new Noop();
1596 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1597 <        final CFException ex = new CFException();
1598 <
1599 <        f.completeExceptionally(ex);
1600 <        checkIncomplete(h);
1601 <        g.complete(v1);
1602 <
1603 <        checkCompletedWithWrappedCFException(h, ex);
1604 <        checkCompletedWithWrappedCFException(f, ex);
1605 <        assertEquals(r.invocationCount, 0);
1606 <        checkCompletedNormally(g, v1);
1607 <        }
1608 <    }
1609 <
1610 <    public void testRunAfterBoth_exceptionalCompletion2() {
1611 <        for (ExecutionMode m : ExecutionMode.values())
1612 <        for (Integer v1 : new Integer[] { 1, null }) {
1613 <
1614 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1615 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1616 <        final Noop r = new Noop();
1617 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1618 <        final CFException ex = new CFException();
1619 <
1620 <        g.completeExceptionally(ex);
1621 <        checkIncomplete(h);
1622 <        f.complete(v1);
1623 <
1624 <        checkCompletedWithWrappedCFException(h, ex);
1625 <        checkCompletedWithWrappedCFException(g, ex);
1626 <        assertEquals(r.invocationCount, 0);
1627 <        checkCompletedNormally(f, v1);
1628 <        }
1629 <    }
1630 <
1631 <    public void testRunAfterBoth_exceptionalCompletion3() {
1587 >    public void testRunAfterBoth_exceptionalCompletion() {
1588          for (ExecutionMode m : ExecutionMode.values())
1589 <        for (Integer v1 : new Integer[] { 1, null }) {
1590 <
1589 >        for (boolean createIncomplete : new boolean[] { true, false })
1590 >        for (boolean fFirst : new boolean[] { true, false })
1591 >        for (Integer v1 : new Integer[] { 1, null })
1592 >    {
1593          final CompletableFuture<Integer> f = new CompletableFuture<>();
1594          final CompletableFuture<Integer> g = new CompletableFuture<>();
1637        final Noop r = new Noop();
1595          final CFException ex = new CFException();
1596 +        final Noop r = new Noop(m);
1597  
1598 <        g.completeExceptionally(ex);
1599 <        f.complete(v1);
1598 >        (fFirst ? f : g).complete(v1);
1599 >        if (!createIncomplete)
1600 >            (!fFirst ? f : g).completeExceptionally(ex);
1601          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1602 <
1603 <        checkCompletedWithWrappedCFException(h, ex);
1604 <        checkCompletedWithWrappedCFException(g, ex);
1646 <        assertEquals(r.invocationCount, 0);
1647 <        checkCompletedNormally(f, v1);
1602 >        if (createIncomplete) {
1603 >            checkIncomplete(h);
1604 >            (!fFirst ? f : g).completeExceptionally(ex);
1605          }
1649    }
1650
1651    public void testRunAfterBoth_exceptionalCompletion4() {
1652        for (ExecutionMode m : ExecutionMode.values())
1653        for (Integer v1 : new Integer[] { 1, null }) {
1654
1655        final CompletableFuture<Integer> f = new CompletableFuture<>();
1656        final CompletableFuture<Integer> g = new CompletableFuture<>();
1657        final Noop r = new Noop();
1658        final CFException ex = new CFException();
1659
1660        f.completeExceptionally(ex);
1661        g.complete(v1);
1662        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1606  
1607          checkCompletedWithWrappedCFException(h, ex);
1608 <        checkCompletedWithWrappedCFException(f, ex);
1609 <        assertEquals(r.invocationCount, 0);
1610 <        checkCompletedNormally(g, v1);
1611 <        }
1669 <    }
1608 >        assertEquals(0, r.invocationCount);
1609 >        checkCompletedNormally(fFirst ? f : g, v1);
1610 >        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1611 >    }}
1612  
1613      /**
1614       * runAfterBoth result completes exceptionally if action does
1615       */
1616 <    public void testRunAfterBoth_actionFailed1() {
1616 >    public void testRunAfterBoth_actionFailed() {
1617          for (ExecutionMode m : ExecutionMode.values())
1618 +        for (boolean fFirst : new boolean[] { true, false })
1619          for (Integer v1 : new Integer[] { 1, null })
1620 <        for (Integer v2 : new Integer[] { 2, null }) {
1621 <
1620 >        for (Integer v2 : new Integer[] { 2, null })
1621 >    {
1622          final CompletableFuture<Integer> f = new CompletableFuture<>();
1623          final CompletableFuture<Integer> g = new CompletableFuture<>();
1624 <        final FailingNoop r = new FailingNoop();
1682 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1624 >        final FailingRunnable r = new FailingRunnable(m);
1625  
1626 <        f.complete(v1);
1627 <        checkIncomplete(h);
1628 <        g.complete(v2);
1629 <
1630 <        checkCompletedWithWrappedCFException(h);
1631 <        checkCompletedNormally(f, v1);
1632 <        checkCompletedNormally(g, v2);
1626 >        CompletableFuture<Void> h1 = m.runAfterBoth(f, g, r);
1627 >        if (fFirst) {
1628 >            f.complete(v1);
1629 >            g.complete(v2);
1630 >        } else {
1631 >            g.complete(v2);
1632 >            f.complete(v1);
1633          }
1634 <    }
1693 <
1694 <    public void testRunAfterBoth_actionFailed2() {
1695 <        for (ExecutionMode m : ExecutionMode.values())
1696 <        for (Integer v1 : new Integer[] { 1, null })
1697 <        for (Integer v2 : new Integer[] { 2, null }) {
1698 <
1699 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1700 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1701 <        final FailingNoop r = new FailingNoop();
1702 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1634 >        CompletableFuture<Void> h2 = m.runAfterBoth(f, g, r);
1635  
1636 <        g.complete(v2);
1637 <        checkIncomplete(h);
1706 <        f.complete(v1);
1707 <
1708 <        checkCompletedWithWrappedCFException(h);
1636 >        checkCompletedWithWrappedCFException(h1);
1637 >        checkCompletedWithWrappedCFException(h2);
1638          checkCompletedNormally(f, v1);
1639          checkCompletedNormally(g, v2);
1640 <        }
1712 <    }
1640 >    }}
1641  
1642      /**
1643       * runAfterBoth result completes exceptionally if either source cancelled
1644       */
1645 <    public void testRunAfterBoth_sourceCancelled1() {
1645 >    public void testRunAfterBoth_sourceCancelled() {
1646          for (ExecutionMode m : ExecutionMode.values())
1647          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1648 <        for (Integer v1 : new Integer[] { 1, null }) {
1649 <
1648 >        for (boolean createIncomplete : new boolean[] { true, false })
1649 >        for (boolean fFirst : new boolean[] { true, false })
1650 >        for (Integer v1 : new Integer[] { 1, null })
1651 >    {
1652          final CompletableFuture<Integer> f = new CompletableFuture<>();
1653          final CompletableFuture<Integer> g = new CompletableFuture<>();
1654 <        final Noop r = new Noop();
1725 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1726 <
1727 <        assertTrue(f.cancel(mayInterruptIfRunning));
1728 <        checkIncomplete(h);
1729 <        g.complete(v1);
1730 <
1731 <        checkCompletedWithWrappedCancellationException(h);
1732 <        checkCancelled(f);
1733 <        assertEquals(r.invocationCount, 0);
1734 <        checkCompletedNormally(g, v1);
1735 <        }
1736 <    }
1654 >        final Noop r = new Noop(m);
1655  
1738    public void testRunAfterBoth_sourceCancelled2() {
1739        for (ExecutionMode m : ExecutionMode.values())
1740        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1741        for (Integer v1 : new Integer[] { 1, null }) {
1656  
1657 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1658 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1659 <        final Noop r = new Noop();
1657 >        (fFirst ? f : g).complete(v1);
1658 >        if (!createIncomplete)
1659 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1660          final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1661 <
1662 <        assertTrue(g.cancel(mayInterruptIfRunning));
1663 <        checkIncomplete(h);
1750 <        f.complete(v1);
1751 <
1752 <        checkCompletedWithWrappedCancellationException(h);
1753 <        checkCancelled(g);
1754 <        assertEquals(r.invocationCount, 0);
1755 <        checkCompletedNormally(f, v1);
1661 >        if (createIncomplete) {
1662 >            checkIncomplete(h);
1663 >            assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
1664          }
1757    }
1758
1759    public void testRunAfterBoth_sourceCancelled3() {
1760        for (ExecutionMode m : ExecutionMode.values())
1761        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1762        for (Integer v1 : new Integer[] { 1, null }) {
1763
1764        final CompletableFuture<Integer> f = new CompletableFuture<>();
1765        final CompletableFuture<Integer> g = new CompletableFuture<>();
1766        final Noop r = new Noop();
1767
1768        assertTrue(g.cancel(mayInterruptIfRunning));
1769        f.complete(v1);
1770        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1665  
1666          checkCompletedWithWrappedCancellationException(h);
1667 <        checkCancelled(g);
1668 <        assertEquals(r.invocationCount, 0);
1669 <        checkCompletedNormally(f, v1);
1670 <        }
1777 <    }
1778 <
1779 <    public void testRunAfterBoth_sourceCancelled4() {
1780 <        for (ExecutionMode m : ExecutionMode.values())
1781 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1782 <        for (Integer v1 : new Integer[] { 1, null }) {
1783 <
1784 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1785 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1786 <        final Noop r = new Noop();
1787 <
1788 <        assertTrue(f.cancel(mayInterruptIfRunning));
1789 <        g.complete(v1);
1790 <        final CompletableFuture<Void> h = m.runAfterBoth(f, g, r);
1791 <
1792 <        checkCompletedWithWrappedCancellationException(h);
1793 <        checkCancelled(f);
1794 <        assertEquals(r.invocationCount, 0);
1795 <        checkCompletedNormally(g, v1);
1796 <        }
1797 <    }
1667 >        checkCancelled(!fFirst ? f : g);
1668 >        assertEquals(0, r.invocationCount);
1669 >        checkCompletedNormally(fFirst ? f : g, v1);
1670 >    }}
1671  
1672      /**
1673       * applyToEither result completes normally after normal completion
1674       * of either source
1675       */
1676 <    public void testApplyToEither_normalCompletion1() {
1676 >    public void testApplyToEither_normalCompletion() {
1677          for (ExecutionMode m : ExecutionMode.values())
1678 +        for (boolean createIncomplete : new boolean[] { true, false })
1679 +        for (boolean fFirst : new boolean[] { true, false })
1680          for (Integer v1 : new Integer[] { 1, null })
1681 <        for (Integer v2 : new Integer[] { 2, null }) {
1682 <
1681 >        for (Integer v2 : new Integer[] { 2, null })
1682 >    {
1683          final CompletableFuture<Integer> f = new CompletableFuture<>();
1684          final CompletableFuture<Integer> g = new CompletableFuture<>();
1685 <        final IncFunction r = new IncFunction();
1811 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1685 >        final IncFunction r = new IncFunction(m);
1686  
1687 <        f.complete(v1);
1688 <        checkCompletedNormally(h, inc(v1));
1689 <        g.complete(v2);
1687 >        if (!createIncomplete)
1688 >            if (fFirst) f.complete(v1); else g.complete(v2);
1689 >        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1690 >        if (createIncomplete) {
1691 >            checkIncomplete(h);
1692 >            assertEquals(0, r.invocationCount);
1693 >            if (fFirst) f.complete(v1); else g.complete(v2);
1694 >        }
1695 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1696 >        if (!fFirst) f.complete(v1); else g.complete(v2);
1697  
1698          checkCompletedNormally(f, v1);
1699          checkCompletedNormally(g, v2);
1700 <        checkCompletedNormally(h, inc(v1));
1701 <        }
1821 <    }
1700 >        checkCompletedNormally(h, inc(fFirst ? v1 : v2));
1701 >    }}
1702  
1703 <    public void testApplyToEither_normalCompletion2() {
1703 >    public void testApplyToEither_normalCompletionBothAvailable() {
1704          for (ExecutionMode m : ExecutionMode.values())
1705 +        for (boolean fFirst : new boolean[] { true, false })
1706          for (Integer v1 : new Integer[] { 1, null })
1707 <        for (Integer v2 : new Integer[] { 2, null }) {
1708 <
1707 >        for (Integer v2 : new Integer[] { 2, null })
1708 >    {
1709          final CompletableFuture<Integer> f = new CompletableFuture<>();
1710          final CompletableFuture<Integer> g = new CompletableFuture<>();
1711 <        final IncFunction r = new IncFunction();
1831 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1832 <
1833 <        g.complete(v2);
1834 <        checkCompletedNormally(h, inc(v2));
1835 <        f.complete(v1);
1711 >        final IncFunction r = new IncFunction(m);
1712  
1713 <        checkCompletedNormally(f, v1);
1714 <        checkCompletedNormally(g, v2);
1715 <        checkCompletedNormally(h, inc(v2));
1713 >        if (fFirst) {
1714 >            f.complete(v1);
1715 >            g.complete(v2);
1716 >        } else {
1717 >            g.complete(v2);
1718 >            f.complete(v1);
1719          }
1841    }
1842    public void testApplyToEither_normalCompletion3() {
1843        for (ExecutionMode m : ExecutionMode.values())
1844        for (Integer v1 : new Integer[] { 1, null })
1845        for (Integer v2 : new Integer[] { 2, null }) {
1846
1847        final CompletableFuture<Integer> f = new CompletableFuture<>();
1848        final CompletableFuture<Integer> g = new CompletableFuture<>();
1849        final IncFunction r = new IncFunction();
1720  
1851        f.complete(v1);
1852        g.complete(v2);
1721          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1722  
1723          checkCompletedNormally(f, v1);
# Line 1858 | Line 1726 | public class CompletableFutureTest exten
1726          // unspecified behavior
1727          assertTrue(Objects.equals(h.join(), inc(v1)) ||
1728                     Objects.equals(h.join(), inc(v2)));
1729 <        assertEquals(r.invocationCount, 1);
1730 <        }
1863 <    }
1729 >        assertEquals(1, r.invocationCount);
1730 >    }}
1731  
1732      /**
1733       * applyToEither result completes exceptionally after exceptional
# Line 1868 | Line 1735 | public class CompletableFutureTest exten
1735       */
1736      public void testApplyToEither_exceptionalCompletion1() {
1737          for (ExecutionMode m : ExecutionMode.values())
1738 <        for (Integer v1 : new Integer[] { 1, null }) {
1739 <
1738 >        for (boolean createIncomplete : new boolean[] { true, false })
1739 >        for (boolean fFirst : new boolean[] { true, false })
1740 >        for (Integer v1 : new Integer[] { 1, null })
1741 >    {
1742          final CompletableFuture<Integer> f = new CompletableFuture<>();
1743          final CompletableFuture<Integer> g = new CompletableFuture<>();
1875        final IncFunction r = new IncFunction();
1876        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1744          final CFException ex = new CFException();
1745 +        final IncFunction r = new IncFunction(m);
1746  
1747 <        f.completeExceptionally(ex);
1880 <        checkCompletedWithWrappedCFException(h, ex);
1881 <        g.complete(v1);
1882 <
1883 <        assertEquals(r.invocationCount, 0);
1884 <        checkCompletedNormally(g, v1);
1885 <        checkCompletedWithWrappedCFException(f, ex);
1886 <        checkCompletedWithWrappedCFException(h, ex);
1887 <        }
1888 <    }
1889 <
1890 <    public void testApplyToEither_exceptionalCompletion2() {
1891 <        for (ExecutionMode m : ExecutionMode.values())
1892 <        for (Integer v1 : new Integer[] { 1, null }) {
1893 <
1894 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
1895 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
1896 <        final IncFunction r = new IncFunction();
1747 >        if (!createIncomplete) (fFirst ? f : g).completeExceptionally(ex);
1748          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1749 <        final CFException ex = new CFException();
1749 >        if (createIncomplete) {
1750 >            checkIncomplete(h);
1751 >            assertEquals(0, r.invocationCount);
1752 >            (fFirst ? f : g).completeExceptionally(ex);
1753 >        }
1754  
1900        g.completeExceptionally(ex);
1755          checkCompletedWithWrappedCFException(h, ex);
1756 <        f.complete(v1);
1756 >        (!fFirst ? f : g).complete(v1);
1757  
1758 <        assertEquals(r.invocationCount, 0);
1759 <        checkCompletedNormally(f, v1);
1760 <        checkCompletedWithWrappedCFException(g, ex);
1758 >        assertEquals(0, r.invocationCount);
1759 >        checkCompletedNormally(!fFirst ? f : g, v1);
1760 >        checkCompletedWithWrappedCFException(fFirst ? f : g, ex);
1761          checkCompletedWithWrappedCFException(h, ex);
1762 <        }
1909 <    }
1762 >    }}
1763  
1764 <    public void testApplyToEither_exceptionalCompletion3() {
1764 >    public void testApplyToEither_exceptionalCompletion2() {
1765          for (ExecutionMode m : ExecutionMode.values())
1766 <        for (Integer v1 : new Integer[] { 1, null }) {
1767 <
1766 >        for (boolean reverseArgs : new boolean[] { true, false })
1767 >        for (boolean fFirst : new boolean[] { true, false })
1768 >        for (Integer v1 : new Integer[] { 1, null })
1769 >    {
1770          final CompletableFuture<Integer> f = new CompletableFuture<>();
1771          final CompletableFuture<Integer> g = new CompletableFuture<>();
1772 <        final IncFunction r = new IncFunction();
1772 >        final IncFunction r1 = new IncFunction(m);
1773 >        final IncFunction r2 = new IncFunction(m);
1774          final CFException ex = new CFException();
1775 <
1776 <        g.completeExceptionally(ex);
1777 <        f.complete(v1);
1778 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1775 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1776 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1777 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1778 >        if (fFirst) {
1779 >            f.complete(v1);
1780 >            g.completeExceptionally(ex);
1781 >        } else {
1782 >            g.completeExceptionally(ex);
1783 >            f.complete(v1);
1784 >        }
1785 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1786  
1787          // unspecified behavior
1925        Integer v;
1788          try {
1789 <            assertEquals(h.join(), inc(v1));
1790 <            assertEquals(r.invocationCount, 1);
1789 >            assertEquals(inc(v1), h1.join());
1790 >            assertEquals(1, r1.invocationCount);
1791          } catch (CompletionException ok) {
1792 <            checkCompletedWithWrappedCFException(h, ex);
1793 <            assertEquals(r.invocationCount, 0);
1792 >            checkCompletedWithWrappedCFException(h1, ex);
1793 >            assertEquals(0, r1.invocationCount);
1794          }
1795  
1934        checkCompletedWithWrappedCFException(g, ex);
1935        checkCompletedNormally(f, v1);
1936        }
1937    }
1938
1939    public void testApplyToEither_exceptionalCompletion4() {
1940        for (ExecutionMode m : ExecutionMode.values())
1941        for (Integer v1 : new Integer[] { 1, null }) {
1942
1943        final CompletableFuture<Integer> f = new CompletableFuture<>();
1944        final CompletableFuture<Integer> g = new CompletableFuture<>();
1945        final IncFunction r = new IncFunction();
1946        final CFException ex = new CFException();
1947
1948        f.completeExceptionally(ex);
1949        g.complete(v1);
1950        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1951
1952        // unspecified behavior
1953        Integer v;
1796          try {
1797 <            assertEquals(h.join(), inc(v1));
1798 <            assertEquals(r.invocationCount, 1);
1797 >            assertEquals(inc(v1), h2.join());
1798 >            assertEquals(1, r2.invocationCount);
1799          } catch (CompletionException ok) {
1800 <            checkCompletedWithWrappedCFException(h, ex);
1801 <            assertEquals(r.invocationCount, 0);
1800 >            checkCompletedWithWrappedCFException(h2, ex);
1801 >            assertEquals(0, r2.invocationCount);
1802          }
1803  
1804 <        checkCompletedWithWrappedCFException(f, ex);
1805 <        checkCompletedNormally(g, v1);
1806 <        }
1965 <    }
1804 >        checkCompletedWithWrappedCFException(g, ex);
1805 >        checkCompletedNormally(f, v1);
1806 >    }}
1807  
1808      /**
1809       * applyToEither result completes exceptionally if action does
# Line 1970 | Line 1811 | public class CompletableFutureTest exten
1811      public void testApplyToEither_actionFailed1() {
1812          for (ExecutionMode m : ExecutionMode.values())
1813          for (Integer v1 : new Integer[] { 1, null })
1814 <        for (Integer v2 : new Integer[] { 2, null }) {
1815 <
1814 >        for (Integer v2 : new Integer[] { 2, null })
1815 >    {
1816          final CompletableFuture<Integer> f = new CompletableFuture<>();
1817          final CompletableFuture<Integer> g = new CompletableFuture<>();
1818 <        final FailingFunction r = new FailingFunction();
1818 >        final FailingFunction r = new FailingFunction(m);
1819          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1820  
1821          f.complete(v1);
# Line 1982 | Line 1823 | public class CompletableFutureTest exten
1823          g.complete(v2);
1824          checkCompletedNormally(f, v1);
1825          checkCompletedNormally(g, v2);
1826 <        }
1986 <    }
1826 >    }}
1827  
1828      public void testApplyToEither_actionFailed2() {
1829          for (ExecutionMode m : ExecutionMode.values())
1830          for (Integer v1 : new Integer[] { 1, null })
1831 <        for (Integer v2 : new Integer[] { 2, null }) {
1832 <
1831 >        for (Integer v2 : new Integer[] { 2, null })
1832 >    {
1833          final CompletableFuture<Integer> f = new CompletableFuture<>();
1834          final CompletableFuture<Integer> g = new CompletableFuture<>();
1835 <        final FailingFunction r = new FailingFunction();
1835 >        final FailingFunction r = new FailingFunction(m);
1836          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1837  
1838          g.complete(v2);
# Line 2000 | Line 1840 | public class CompletableFutureTest exten
1840          f.complete(v1);
1841          checkCompletedNormally(f, v1);
1842          checkCompletedNormally(g, v2);
1843 <        }
2004 <    }
1843 >    }}
1844  
1845      /**
1846       * applyToEither result completes exceptionally if either source cancelled
# Line 2009 | Line 1848 | public class CompletableFutureTest exten
1848      public void testApplyToEither_sourceCancelled1() {
1849          for (ExecutionMode m : ExecutionMode.values())
1850          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1851 <        for (Integer v1 : new Integer[] { 1, null }) {
1852 <
1851 >        for (boolean createIncomplete : new boolean[] { true, false })
1852 >        for (boolean fFirst : new boolean[] { true, false })
1853 >        for (Integer v1 : new Integer[] { 1, null })
1854 >    {
1855          final CompletableFuture<Integer> f = new CompletableFuture<>();
1856          final CompletableFuture<Integer> g = new CompletableFuture<>();
1857 <        final IncFunction r = new IncFunction();
1857 >        final IncFunction r = new IncFunction(m);
1858 >
1859 >        if (!createIncomplete) assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1860          final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1861 +        if (createIncomplete) {
1862 +            checkIncomplete(h);
1863 +            assertEquals(0, r.invocationCount);
1864 +            assertTrue((fFirst ? f : g).cancel(mayInterruptIfRunning));
1865 +        }
1866  
2019        assertTrue(f.cancel(mayInterruptIfRunning));
1867          checkCompletedWithWrappedCancellationException(h);
1868 <        g.complete(v1);
1868 >        (!fFirst ? f : g).complete(v1);
1869  
1870 <        checkCancelled(f);
1871 <        assertEquals(r.invocationCount, 0);
1872 <        checkCompletedNormally(g, v1);
1870 >        assertEquals(0, r.invocationCount);
1871 >        checkCompletedNormally(!fFirst ? f : g, v1);
1872 >        checkCancelled(fFirst ? f : g);
1873          checkCompletedWithWrappedCancellationException(h);
1874 <        }
2028 <    }
1874 >    }}
1875  
1876      public void testApplyToEither_sourceCancelled2() {
1877          for (ExecutionMode m : ExecutionMode.values())
1878          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1879 <        for (Integer v1 : new Integer[] { 1, null }) {
1880 <
1879 >        for (boolean reverseArgs : new boolean[] { true, false })
1880 >        for (boolean fFirst : new boolean[] { true, false })
1881 >        for (Integer v1 : new Integer[] { 1, null })
1882 >    {
1883          final CompletableFuture<Integer> f = new CompletableFuture<>();
1884          final CompletableFuture<Integer> g = new CompletableFuture<>();
1885 <        final IncFunction r = new IncFunction();
1886 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1887 <
1888 <        assertTrue(g.cancel(mayInterruptIfRunning));
1889 <        checkCompletedWithWrappedCancellationException(h);
2042 <        f.complete(v1);
1885 >        final IncFunction r1 = new IncFunction(m);
1886 >        final IncFunction r2 = new IncFunction(m);
1887 >        final CFException ex = new CFException();
1888 >        final CompletableFuture<Integer> j = (reverseArgs ? g : f);
1889 >        final CompletableFuture<Integer> k = (reverseArgs ? f : g);
1890  
1891 <        checkCancelled(g);
1892 <        assertEquals(r.invocationCount, 0);
1893 <        checkCompletedNormally(f, v1);
1894 <        checkCompletedWithWrappedCancellationException(h);
1891 >        final CompletableFuture<Integer> h1 = m.applyToEither(j, k, r1);
1892 >        if (fFirst) {
1893 >            f.complete(v1);
1894 >            assertTrue(g.cancel(mayInterruptIfRunning));
1895 >        } else {
1896 >            assertTrue(g.cancel(mayInterruptIfRunning));
1897 >            f.complete(v1);
1898          }
1899 <    }
2050 <
2051 <    public void testApplyToEither_sourceCancelled3() {
2052 <        for (ExecutionMode m : ExecutionMode.values())
2053 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2054 <        for (Integer v1 : new Integer[] { 1, null }) {
2055 <
2056 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2057 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2058 <        final IncFunction r = new IncFunction();
2059 <
2060 <        assertTrue(g.cancel(mayInterruptIfRunning));
2061 <        f.complete(v1);
2062 <        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
1899 >        final CompletableFuture<Integer> h2 = m.applyToEither(j, k, r2);
1900  
1901          // unspecified behavior
2065        Integer v;
1902          try {
1903 <            assertEquals(h.join(), inc(v1));
1904 <            assertEquals(r.invocationCount, 1);
1903 >            assertEquals(inc(v1), h1.join());
1904 >            assertEquals(1, r1.invocationCount);
1905          } catch (CompletionException ok) {
1906 <            checkCompletedWithWrappedCancellationException(h);
1907 <            assertEquals(r.invocationCount, 0);
1906 >            checkCompletedWithWrappedCancellationException(h1);
1907 >            assertEquals(0, r1.invocationCount);
1908          }
1909  
2074        checkCancelled(g);
2075        checkCompletedNormally(f, v1);
2076        }
2077    }
2078
2079    public void testApplyToEither_sourceCancelled4() {
2080        for (ExecutionMode m : ExecutionMode.values())
2081        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2082        for (Integer v1 : new Integer[] { 1, null }) {
2083
2084        final CompletableFuture<Integer> f = new CompletableFuture<>();
2085        final CompletableFuture<Integer> g = new CompletableFuture<>();
2086        final IncFunction r = new IncFunction();
2087
2088        assertTrue(f.cancel(mayInterruptIfRunning));
2089        g.complete(v1);
2090        final CompletableFuture<Integer> h = m.applyToEither(f, g, r);
2091
2092        // unspecified behavior
2093        Integer v;
1910          try {
1911 <            assertEquals(h.join(), inc(v1));
1912 <            assertEquals(r.invocationCount, 1);
1911 >            assertEquals(inc(v1), h2.join());
1912 >            assertEquals(1, r2.invocationCount);
1913          } catch (CompletionException ok) {
1914 <            checkCompletedWithWrappedCancellationException(h);
1915 <            assertEquals(r.invocationCount, 0);
1914 >            checkCompletedWithWrappedCancellationException(h2);
1915 >            assertEquals(0, r2.invocationCount);
1916          }
1917  
1918 <        checkCancelled(f);
1919 <        checkCompletedNormally(g, v1);
1920 <        }
2105 <    }
1918 >        checkCancelled(g);
1919 >        checkCompletedNormally(f, v1);
1920 >    }}
1921  
1922      /**
1923       * acceptEither result completes normally after normal completion
# Line 2111 | Line 1926 | public class CompletableFutureTest exten
1926      public void testAcceptEither_normalCompletion1() {
1927          for (ExecutionMode m : ExecutionMode.values())
1928          for (Integer v1 : new Integer[] { 1, null })
1929 <        for (Integer v2 : new Integer[] { 2, null }) {
1930 <
1929 >        for (Integer v2 : new Integer[] { 2, null })
1930 >    {
1931          final CompletableFuture<Integer> f = new CompletableFuture<>();
1932          final CompletableFuture<Integer> g = new CompletableFuture<>();
1933          final IncAction r = new IncAction();
# Line 2120 | Line 1935 | public class CompletableFutureTest exten
1935  
1936          f.complete(v1);
1937          checkCompletedNormally(h, null);
1938 <        assertEquals(r.value, inc(v1));
1938 >        assertEquals(inc(v1), r.value);
1939          g.complete(v2);
1940  
1941          checkCompletedNormally(f, v1);
1942          checkCompletedNormally(g, v2);
1943          checkCompletedNormally(h, null);
1944 <        }
2130 <    }
1944 >    }}
1945  
1946      public void testAcceptEither_normalCompletion2() {
1947          for (ExecutionMode m : ExecutionMode.values())
1948          for (Integer v1 : new Integer[] { 1, null })
1949 <        for (Integer v2 : new Integer[] { 2, null }) {
1950 <
1949 >        for (Integer v2 : new Integer[] { 2, null })
1950 >    {
1951          final CompletableFuture<Integer> f = new CompletableFuture<>();
1952          final CompletableFuture<Integer> g = new CompletableFuture<>();
1953          final IncAction r = new IncAction();
# Line 2141 | Line 1955 | public class CompletableFutureTest exten
1955  
1956          g.complete(v2);
1957          checkCompletedNormally(h, null);
1958 <        assertEquals(r.value, inc(v2));
1958 >        assertEquals(inc(v2), r.value);
1959          f.complete(v1);
1960  
1961          checkCompletedNormally(f, v1);
1962          checkCompletedNormally(g, v2);
1963          checkCompletedNormally(h, null);
1964 <        }
1965 <    }
1964 >    }}
1965 >
1966      public void testAcceptEither_normalCompletion3() {
1967          for (ExecutionMode m : ExecutionMode.values())
1968          for (Integer v1 : new Integer[] { 1, null })
1969 <        for (Integer v2 : new Integer[] { 2, null }) {
1970 <
1969 >        for (Integer v2 : new Integer[] { 2, null })
1970 >    {
1971          final CompletableFuture<Integer> f = new CompletableFuture<>();
1972          final CompletableFuture<Integer> g = new CompletableFuture<>();
1973          final IncAction r = new IncAction();
# Line 2169 | Line 1983 | public class CompletableFutureTest exten
1983          // unspecified behavior
1984          assertTrue(Objects.equals(r.value, inc(v1)) ||
1985                     Objects.equals(r.value, inc(v2)));
1986 <        }
2173 <    }
1986 >    }}
1987  
1988      /**
1989       * acceptEither result completes exceptionally after exceptional
# Line 2178 | Line 1991 | public class CompletableFutureTest exten
1991       */
1992      public void testAcceptEither_exceptionalCompletion1() {
1993          for (ExecutionMode m : ExecutionMode.values())
1994 <        for (Integer v1 : new Integer[] { 1, null }) {
1995 <
1994 >        for (Integer v1 : new Integer[] { 1, null })
1995 >    {
1996          final CompletableFuture<Integer> f = new CompletableFuture<>();
1997          final CompletableFuture<Integer> g = new CompletableFuture<>();
1998          final IncAction r = new IncAction();
# Line 2190 | Line 2003 | public class CompletableFutureTest exten
2003          checkCompletedWithWrappedCFException(h, ex);
2004          g.complete(v1);
2005  
2006 <        assertEquals(r.invocationCount, 0);
2006 >        assertEquals(0, r.invocationCount);
2007          checkCompletedNormally(g, v1);
2008          checkCompletedWithWrappedCFException(f, ex);
2009          checkCompletedWithWrappedCFException(h, ex);
2010 <        }
2198 <    }
2010 >    }}
2011  
2012      public void testAcceptEither_exceptionalCompletion2() {
2013          for (ExecutionMode m : ExecutionMode.values())
2014 <        for (Integer v1 : new Integer[] { 1, null }) {
2015 <
2014 >        for (Integer v1 : new Integer[] { 1, null })
2015 >    {
2016          final CompletableFuture<Integer> f = new CompletableFuture<>();
2017          final CompletableFuture<Integer> g = new CompletableFuture<>();
2018          final IncAction r = new IncAction();
# Line 2211 | Line 2023 | public class CompletableFutureTest exten
2023          checkCompletedWithWrappedCFException(h, ex);
2024          f.complete(v1);
2025  
2026 <        assertEquals(r.invocationCount, 0);
2026 >        assertEquals(0, r.invocationCount);
2027          checkCompletedNormally(f, v1);
2028          checkCompletedWithWrappedCFException(g, ex);
2029          checkCompletedWithWrappedCFException(h, ex);
2030 <        }
2219 <    }
2030 >    }}
2031  
2032      public void testAcceptEither_exceptionalCompletion3() {
2033          for (ExecutionMode m : ExecutionMode.values())
2034 <        for (Integer v1 : new Integer[] { 1, null }) {
2035 <
2034 >        for (Integer v1 : new Integer[] { 1, null })
2035 >    {
2036          final CompletableFuture<Integer> f = new CompletableFuture<>();
2037          final CompletableFuture<Integer> g = new CompletableFuture<>();
2038          final IncAction r = new IncAction();
# Line 2234 | Line 2045 | public class CompletableFutureTest exten
2045          // unspecified behavior
2046          Integer v;
2047          try {
2048 <            assertEquals(h.join(), null);
2049 <            assertEquals(r.invocationCount, 1);
2048 >            assertNull(h.join());
2049 >            assertEquals(1, r.invocationCount);
2050              assertEquals(inc(v1), r.value);
2051          } catch (CompletionException ok) {
2052              checkCompletedWithWrappedCFException(h, ex);
2053 <            assertEquals(r.invocationCount, 0);
2053 >            assertEquals(0, r.invocationCount);
2054          }
2055  
2056          checkCompletedWithWrappedCFException(g, ex);
2057          checkCompletedNormally(f, v1);
2058 <        }
2248 <    }
2058 >    }}
2059  
2060      public void testAcceptEither_exceptionalCompletion4() {
2061          for (ExecutionMode m : ExecutionMode.values())
2062 <        for (Integer v1 : new Integer[] { 1, null }) {
2063 <
2062 >        for (Integer v1 : new Integer[] { 1, null })
2063 >    {
2064          final CompletableFuture<Integer> f = new CompletableFuture<>();
2065          final CompletableFuture<Integer> g = new CompletableFuture<>();
2066          final IncAction r = new IncAction();
# Line 2263 | Line 2073 | public class CompletableFutureTest exten
2073          // unspecified behavior
2074          Integer v;
2075          try {
2076 <            assertEquals(h.join(), null);
2077 <            assertEquals(r.invocationCount, 1);
2076 >            assertNull(h.join());
2077 >            assertEquals(1, r.invocationCount);
2078              assertEquals(inc(v1), r.value);
2079          } catch (CompletionException ok) {
2080              checkCompletedWithWrappedCFException(h, ex);
2081 <            assertEquals(r.invocationCount, 0);
2081 >            assertEquals(0, r.invocationCount);
2082          }
2083  
2084          checkCompletedWithWrappedCFException(f, ex);
2085          checkCompletedNormally(g, v1);
2086 <        }
2277 <    }
2086 >    }}
2087  
2088      /**
2089       * acceptEither result completes exceptionally if action does
# Line 2282 | Line 2091 | public class CompletableFutureTest exten
2091      public void testAcceptEither_actionFailed1() {
2092          for (ExecutionMode m : ExecutionMode.values())
2093          for (Integer v1 : new Integer[] { 1, null })
2094 <        for (Integer v2 : new Integer[] { 2, null }) {
2095 <
2094 >        for (Integer v2 : new Integer[] { 2, null })
2095 >    {
2096          final CompletableFuture<Integer> f = new CompletableFuture<>();
2097          final CompletableFuture<Integer> g = new CompletableFuture<>();
2098 <        final FailingConsumer r = new FailingConsumer();
2098 >        final FailingConsumer r = new FailingConsumer(m);
2099          final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2100  
2101          f.complete(v1);
# Line 2294 | Line 2103 | public class CompletableFutureTest exten
2103          g.complete(v2);
2104          checkCompletedNormally(f, v1);
2105          checkCompletedNormally(g, v2);
2106 <        }
2298 <    }
2106 >    }}
2107  
2108      public void testAcceptEither_actionFailed2() {
2109          for (ExecutionMode m : ExecutionMode.values())
2110          for (Integer v1 : new Integer[] { 1, null })
2111 <        for (Integer v2 : new Integer[] { 2, null }) {
2112 <
2111 >        for (Integer v2 : new Integer[] { 2, null })
2112 >    {
2113          final CompletableFuture<Integer> f = new CompletableFuture<>();
2114          final CompletableFuture<Integer> g = new CompletableFuture<>();
2115 <        final FailingConsumer r = new FailingConsumer();
2115 >        final FailingConsumer r = new FailingConsumer(m);
2116          final CompletableFuture<Void> h = m.acceptEither(f, g, r);
2117  
2118          g.complete(v2);
# Line 2312 | Line 2120 | public class CompletableFutureTest exten
2120          f.complete(v1);
2121          checkCompletedNormally(f, v1);
2122          checkCompletedNormally(g, v2);
2123 <        }
2316 <    }
2123 >    }}
2124  
2125      /**
2126       * acceptEither result completes exceptionally if either source cancelled
# Line 2321 | Line 2128 | public class CompletableFutureTest exten
2128      public void testAcceptEither_sourceCancelled1() {
2129          for (ExecutionMode m : ExecutionMode.values())
2130          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2131 <        for (Integer v1 : new Integer[] { 1, null }) {
2132 <
2131 >        for (Integer v1 : new Integer[] { 1, null })
2132 >    {
2133          final CompletableFuture<Integer> f = new CompletableFuture<>();
2134          final CompletableFuture<Integer> g = new CompletableFuture<>();
2135          final IncAction r = new IncAction();
# Line 2333 | Line 2140 | public class CompletableFutureTest exten
2140          g.complete(v1);
2141  
2142          checkCancelled(f);
2143 <        assertEquals(r.invocationCount, 0);
2143 >        assertEquals(0, r.invocationCount);
2144          checkCompletedNormally(g, v1);
2145          checkCompletedWithWrappedCancellationException(h);
2146 <        }
2340 <    }
2146 >    }}
2147  
2148      public void testAcceptEither_sourceCancelled2() {
2149          for (ExecutionMode m : ExecutionMode.values())
2150          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2151 <        for (Integer v1 : new Integer[] { 1, null }) {
2152 <
2151 >        for (Integer v1 : new Integer[] { 1, null })
2152 >    {
2153          final CompletableFuture<Integer> f = new CompletableFuture<>();
2154          final CompletableFuture<Integer> g = new CompletableFuture<>();
2155          final IncAction r = new IncAction();
# Line 2354 | Line 2160 | public class CompletableFutureTest exten
2160          f.complete(v1);
2161  
2162          checkCancelled(g);
2163 <        assertEquals(r.invocationCount, 0);
2163 >        assertEquals(0, r.invocationCount);
2164          checkCompletedNormally(f, v1);
2165          checkCompletedWithWrappedCancellationException(h);
2166 <        }
2361 <    }
2166 >    }}
2167  
2168      public void testAcceptEither_sourceCancelled3() {
2169          for (ExecutionMode m : ExecutionMode.values())
2170          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2171 <        for (Integer v1 : new Integer[] { 1, null }) {
2172 <
2171 >        for (Integer v1 : new Integer[] { 1, null })
2172 >    {
2173          final CompletableFuture<Integer> f = new CompletableFuture<>();
2174          final CompletableFuture<Integer> g = new CompletableFuture<>();
2175          final IncAction r = new IncAction();
# Line 2376 | Line 2181 | public class CompletableFutureTest exten
2181          // unspecified behavior
2182          Integer v;
2183          try {
2184 <            assertEquals(h.join(), null);
2185 <            assertEquals(r.invocationCount, 1);
2184 >            assertNull(h.join());
2185 >            assertEquals(1, r.invocationCount);
2186              assertEquals(inc(v1), r.value);
2187          } catch (CompletionException ok) {
2188              checkCompletedWithWrappedCancellationException(h);
2189 <            assertEquals(r.invocationCount, 0);
2189 >            assertEquals(0, r.invocationCount);
2190          }
2191  
2192          checkCancelled(g);
2193          checkCompletedNormally(f, v1);
2194 <        }
2390 <    }
2194 >    }}
2195  
2196      public void testAcceptEither_sourceCancelled4() {
2197          for (ExecutionMode m : ExecutionMode.values())
2198          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2199 <        for (Integer v1 : new Integer[] { 1, null }) {
2200 <
2199 >        for (Integer v1 : new Integer[] { 1, null })
2200 >    {
2201          final CompletableFuture<Integer> f = new CompletableFuture<>();
2202          final CompletableFuture<Integer> g = new CompletableFuture<>();
2203          final IncAction r = new IncAction();
# Line 2405 | Line 2209 | public class CompletableFutureTest exten
2209          // unspecified behavior
2210          Integer v;
2211          try {
2212 <            assertEquals(h.join(), null);
2213 <            assertEquals(r.invocationCount, 1);
2212 >            assertNull(h.join());
2213 >            assertEquals(1, r.invocationCount);
2214              assertEquals(inc(v1), r.value);
2215          } catch (CompletionException ok) {
2216              checkCompletedWithWrappedCancellationException(h);
2217 <            assertEquals(r.invocationCount, 0);
2217 >            assertEquals(0, r.invocationCount);
2218          }
2219  
2220          checkCancelled(f);
2221          checkCompletedNormally(g, v1);
2222 <        }
2419 <    }
2222 >    }}
2223  
2224      /**
2225       * runAfterEither result completes normally after normal completion
# Line 2425 | Line 2228 | public class CompletableFutureTest exten
2228      public void testRunAfterEither_normalCompletion1() {
2229          for (ExecutionMode m : ExecutionMode.values())
2230          for (Integer v1 : new Integer[] { 1, null })
2231 <        for (Integer v2 : new Integer[] { 2, null }) {
2232 <
2231 >        for (Integer v2 : new Integer[] { 2, null })
2232 >    {
2233          final CompletableFuture<Integer> f = new CompletableFuture<>();
2234          final CompletableFuture<Integer> g = new CompletableFuture<>();
2235 <        final Noop r = new Noop();
2235 >        final Noop r = new Noop(m);
2236          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2237  
2238          f.complete(v1);
2239          checkCompletedNormally(h, null);
2240 <        assertEquals(r.invocationCount, 1);
2240 >        assertEquals(1, r.invocationCount);
2241          g.complete(v2);
2242  
2243          checkCompletedNormally(f, v1);
2244          checkCompletedNormally(g, v2);
2245          checkCompletedNormally(h, null);
2246 <        assertEquals(r.invocationCount, 1);
2247 <        }
2445 <    }
2246 >        assertEquals(1, r.invocationCount);
2247 >    }}
2248  
2249      public void testRunAfterEither_normalCompletion2() {
2250          for (ExecutionMode m : ExecutionMode.values())
2251          for (Integer v1 : new Integer[] { 1, null })
2252 <        for (Integer v2 : new Integer[] { 2, null }) {
2253 <
2252 >        for (Integer v2 : new Integer[] { 2, null })
2253 >    {
2254          final CompletableFuture<Integer> f = new CompletableFuture<>();
2255          final CompletableFuture<Integer> g = new CompletableFuture<>();
2256 <        final Noop r = new Noop();
2256 >        final Noop r = new Noop(m);
2257          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2258  
2259          g.complete(v2);
2260          checkCompletedNormally(h, null);
2261 <        assertEquals(r.invocationCount, 1);
2261 >        assertEquals(1, r.invocationCount);
2262          f.complete(v1);
2263  
2264          checkCompletedNormally(f, v1);
2265          checkCompletedNormally(g, v2);
2266          checkCompletedNormally(h, null);
2267 <        assertEquals(r.invocationCount, 1);
2268 <        }
2269 <    }
2267 >        assertEquals(1, r.invocationCount);
2268 >        }}
2269 >
2270      public void testRunAfterEither_normalCompletion3() {
2271          for (ExecutionMode m : ExecutionMode.values())
2272          for (Integer v1 : new Integer[] { 1, null })
2273 <        for (Integer v2 : new Integer[] { 2, null }) {
2274 <
2273 >        for (Integer v2 : new Integer[] { 2, null })
2274 >    {
2275          final CompletableFuture<Integer> f = new CompletableFuture<>();
2276          final CompletableFuture<Integer> g = new CompletableFuture<>();
2277 <        final Noop r = new Noop();
2277 >        final Noop r = new Noop(m);
2278  
2279          f.complete(v1);
2280          g.complete(v2);
# Line 2481 | Line 2283 | public class CompletableFutureTest exten
2283          checkCompletedNormally(h, null);
2284          checkCompletedNormally(f, v1);
2285          checkCompletedNormally(g, v2);
2286 <        assertEquals(r.invocationCount, 1);
2287 <        }
2486 <    }
2286 >        assertEquals(1, r.invocationCount);
2287 >    }}
2288  
2289      /**
2290       * runAfterEither result completes exceptionally after exceptional
# Line 2491 | Line 2292 | public class CompletableFutureTest exten
2292       */
2293      public void testRunAfterEither_exceptionalCompletion1() {
2294          for (ExecutionMode m : ExecutionMode.values())
2295 <        for (Integer v1 : new Integer[] { 1, null }) {
2296 <
2295 >        for (Integer v1 : new Integer[] { 1, null })
2296 >    {
2297          final CompletableFuture<Integer> f = new CompletableFuture<>();
2298          final CompletableFuture<Integer> g = new CompletableFuture<>();
2299 <        final Noop r = new Noop();
2299 >        final Noop r = new Noop(m);
2300          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2301          final CFException ex = new CFException();
2302  
# Line 2503 | Line 2304 | public class CompletableFutureTest exten
2304          checkCompletedWithWrappedCFException(h, ex);
2305          g.complete(v1);
2306  
2307 <        assertEquals(r.invocationCount, 0);
2307 >        assertEquals(0, r.invocationCount);
2308          checkCompletedNormally(g, v1);
2309          checkCompletedWithWrappedCFException(f, ex);
2310          checkCompletedWithWrappedCFException(h, ex);
2311 <        }
2511 <    }
2311 >    }}
2312  
2313      public void testRunAfterEither_exceptionalCompletion2() {
2314          for (ExecutionMode m : ExecutionMode.values())
2315 <        for (Integer v1 : new Integer[] { 1, null }) {
2316 <
2315 >        for (Integer v1 : new Integer[] { 1, null })
2316 >    {
2317          final CompletableFuture<Integer> f = new CompletableFuture<>();
2318          final CompletableFuture<Integer> g = new CompletableFuture<>();
2319 <        final Noop r = new Noop();
2319 >        final Noop r = new Noop(m);
2320          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2321          final CFException ex = new CFException();
2322  
# Line 2524 | Line 2324 | public class CompletableFutureTest exten
2324          checkCompletedWithWrappedCFException(h, ex);
2325          f.complete(v1);
2326  
2327 <        assertEquals(r.invocationCount, 0);
2327 >        assertEquals(0, r.invocationCount);
2328          checkCompletedNormally(f, v1);
2329          checkCompletedWithWrappedCFException(g, ex);
2330          checkCompletedWithWrappedCFException(h, ex);
2331 <        }
2532 <    }
2331 >    }}
2332  
2333      public void testRunAfterEither_exceptionalCompletion3() {
2334          for (ExecutionMode m : ExecutionMode.values())
2335 <        for (Integer v1 : new Integer[] { 1, null }) {
2336 <
2335 >        for (Integer v1 : new Integer[] { 1, null })
2336 >    {
2337          final CompletableFuture<Integer> f = new CompletableFuture<>();
2338          final CompletableFuture<Integer> g = new CompletableFuture<>();
2339 <        final Noop r = new Noop();
2339 >        final Noop r = new Noop(m);
2340          final CFException ex = new CFException();
2341  
2342          g.completeExceptionally(ex);
# Line 2547 | Line 2346 | public class CompletableFutureTest exten
2346          // unspecified behavior
2347          Integer v;
2348          try {
2349 <            assertEquals(h.join(), null);
2350 <            assertEquals(r.invocationCount, 1);
2349 >            assertNull(h.join());
2350 >            assertEquals(1, r.invocationCount);
2351          } catch (CompletionException ok) {
2352              checkCompletedWithWrappedCFException(h, ex);
2353 <            assertEquals(r.invocationCount, 0);
2353 >            assertEquals(0, r.invocationCount);
2354          }
2355  
2356          checkCompletedWithWrappedCFException(g, ex);
2357          checkCompletedNormally(f, v1);
2358 <        }
2560 <    }
2358 >    }}
2359  
2360      public void testRunAfterEither_exceptionalCompletion4() {
2361          for (ExecutionMode m : ExecutionMode.values())
2362 <        for (Integer v1 : new Integer[] { 1, null }) {
2363 <
2362 >        for (Integer v1 : new Integer[] { 1, null })
2363 >    {
2364          final CompletableFuture<Integer> f = new CompletableFuture<>();
2365          final CompletableFuture<Integer> g = new CompletableFuture<>();
2366 <        final Noop r = new Noop();
2366 >        final Noop r = new Noop(m);
2367          final CFException ex = new CFException();
2368  
2369          f.completeExceptionally(ex);
# Line 2575 | Line 2373 | public class CompletableFutureTest exten
2373          // unspecified behavior
2374          Integer v;
2375          try {
2376 <            assertEquals(h.join(), null);
2377 <            assertEquals(r.invocationCount, 1);
2376 >            assertNull(h.join());
2377 >            assertEquals(1, r.invocationCount);
2378          } catch (CompletionException ok) {
2379              checkCompletedWithWrappedCFException(h, ex);
2380 <            assertEquals(r.invocationCount, 0);
2380 >            assertEquals(0, r.invocationCount);
2381          }
2382  
2383          checkCompletedWithWrappedCFException(f, ex);
2384          checkCompletedNormally(g, v1);
2385 <        }
2588 <    }
2385 >    }}
2386  
2387      /**
2388       * runAfterEither result completes exceptionally if action does
# Line 2593 | Line 2390 | public class CompletableFutureTest exten
2390      public void testRunAfterEither_actionFailed1() {
2391          for (ExecutionMode m : ExecutionMode.values())
2392          for (Integer v1 : new Integer[] { 1, null })
2393 <        for (Integer v2 : new Integer[] { 2, null }) {
2394 <
2393 >        for (Integer v2 : new Integer[] { 2, null })
2394 >    {
2395          final CompletableFuture<Integer> f = new CompletableFuture<>();
2396          final CompletableFuture<Integer> g = new CompletableFuture<>();
2397 <        final FailingNoop r = new FailingNoop();
2397 >        final FailingRunnable r = new FailingRunnable(m);
2398          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2399  
2400          f.complete(v1);
# Line 2605 | Line 2402 | public class CompletableFutureTest exten
2402          g.complete(v2);
2403          checkCompletedNormally(f, v1);
2404          checkCompletedNormally(g, v2);
2405 <        }
2609 <    }
2405 >    }}
2406  
2407      public void testRunAfterEither_actionFailed2() {
2408          for (ExecutionMode m : ExecutionMode.values())
2409          for (Integer v1 : new Integer[] { 1, null })
2410 <        for (Integer v2 : new Integer[] { 2, null }) {
2411 <
2410 >        for (Integer v2 : new Integer[] { 2, null })
2411 >    {
2412          final CompletableFuture<Integer> f = new CompletableFuture<>();
2413          final CompletableFuture<Integer> g = new CompletableFuture<>();
2414 <        final FailingNoop r = new FailingNoop();
2414 >        final FailingRunnable r = new FailingRunnable(m);
2415          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2416  
2417          g.complete(v2);
# Line 2623 | Line 2419 | public class CompletableFutureTest exten
2419          f.complete(v1);
2420          checkCompletedNormally(f, v1);
2421          checkCompletedNormally(g, v2);
2422 <        }
2627 <    }
2422 >    }}
2423  
2424      /**
2425       * runAfterEither result completes exceptionally if either source cancelled
# Line 2632 | Line 2427 | public class CompletableFutureTest exten
2427      public void testRunAfterEither_sourceCancelled1() {
2428          for (ExecutionMode m : ExecutionMode.values())
2429          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2430 <        for (Integer v1 : new Integer[] { 1, null }) {
2431 <
2430 >        for (Integer v1 : new Integer[] { 1, null })
2431 >    {
2432          final CompletableFuture<Integer> f = new CompletableFuture<>();
2433          final CompletableFuture<Integer> g = new CompletableFuture<>();
2434 <        final Noop r = new Noop();
2434 >        final Noop r = new Noop(m);
2435          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2436  
2437          assertTrue(f.cancel(mayInterruptIfRunning));
# Line 2644 | Line 2439 | public class CompletableFutureTest exten
2439          g.complete(v1);
2440  
2441          checkCancelled(f);
2442 <        assertEquals(r.invocationCount, 0);
2442 >        assertEquals(0, r.invocationCount);
2443          checkCompletedNormally(g, v1);
2444          checkCompletedWithWrappedCancellationException(h);
2445 <        }
2651 <    }
2445 >    }}
2446  
2447      public void testRunAfterEither_sourceCancelled2() {
2448          for (ExecutionMode m : ExecutionMode.values())
2449          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2450 <        for (Integer v1 : new Integer[] { 1, null }) {
2451 <
2450 >        for (Integer v1 : new Integer[] { 1, null })
2451 >    {
2452          final CompletableFuture<Integer> f = new CompletableFuture<>();
2453          final CompletableFuture<Integer> g = new CompletableFuture<>();
2454 <        final Noop r = new Noop();
2454 >        final Noop r = new Noop(m);
2455          final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2456  
2457          assertTrue(g.cancel(mayInterruptIfRunning));
# Line 2665 | Line 2459 | public class CompletableFutureTest exten
2459          f.complete(v1);
2460  
2461          checkCancelled(g);
2462 <        assertEquals(r.invocationCount, 0);
2462 >        assertEquals(0, r.invocationCount);
2463          checkCompletedNormally(f, v1);
2464          checkCompletedWithWrappedCancellationException(h);
2465 <        }
2672 <    }
2465 >    }}
2466  
2467      public void testRunAfterEither_sourceCancelled3() {
2468          for (ExecutionMode m : ExecutionMode.values())
2469          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2470 <        for (Integer v1 : new Integer[] { 1, null }) {
2471 <
2470 >        for (Integer v1 : new Integer[] { 1, null })
2471 >    {
2472          final CompletableFuture<Integer> f = new CompletableFuture<>();
2473          final CompletableFuture<Integer> g = new CompletableFuture<>();
2474 <        final Noop r = new Noop();
2474 >        final Noop r = new Noop(m);
2475  
2476          assertTrue(g.cancel(mayInterruptIfRunning));
2477          f.complete(v1);
# Line 2687 | Line 2480 | public class CompletableFutureTest exten
2480          // unspecified behavior
2481          Integer v;
2482          try {
2483 <            assertEquals(h.join(), null);
2484 <            assertEquals(r.invocationCount, 1);
2483 >            assertNull(h.join());
2484 >            assertEquals(1, r.invocationCount);
2485          } catch (CompletionException ok) {
2486              checkCompletedWithWrappedCancellationException(h);
2487 <            assertEquals(r.invocationCount, 0);
2487 >            assertEquals(0, r.invocationCount);
2488          }
2489  
2490          checkCancelled(g);
2491          checkCompletedNormally(f, v1);
2492 <        }
2700 <    }
2492 >    }}
2493  
2494      public void testRunAfterEither_sourceCancelled4() {
2495          for (ExecutionMode m : ExecutionMode.values())
2496          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2497 <        for (Integer v1 : new Integer[] { 1, null }) {
2498 <
2497 >        for (Integer v1 : new Integer[] { 1, null })
2498 >    {
2499          final CompletableFuture<Integer> f = new CompletableFuture<>();
2500          final CompletableFuture<Integer> g = new CompletableFuture<>();
2501 <        final Noop r = new Noop();
2501 >        final Noop r = new Noop(m);
2502  
2503          assertTrue(f.cancel(mayInterruptIfRunning));
2504          g.complete(v1);
# Line 2715 | Line 2507 | public class CompletableFutureTest exten
2507          // unspecified behavior
2508          Integer v;
2509          try {
2510 <            assertEquals(h.join(), null);
2511 <            assertEquals(r.invocationCount, 1);
2510 >            assertNull(h.join());
2511 >            assertEquals(1, r.invocationCount);
2512          } catch (CompletionException ok) {
2513              checkCompletedWithWrappedCancellationException(h);
2514 <            assertEquals(r.invocationCount, 0);
2514 >            assertEquals(0, r.invocationCount);
2515          }
2516  
2517          checkCancelled(f);
2518          checkCompletedNormally(g, v1);
2519 <        }
2728 <    }
2519 >    }}
2520  
2521      /**
2522       * thenCompose result completes normally after normal completion of source
2523       */
2524 <    public void testThenCompose() {
2525 <        CompletableFuture<Integer> f, g;
2526 <        CompletableFutureInc r;
2527 <
2528 <        f = new CompletableFuture<>();
2529 <        g = f.thenCompose(r = new CompletableFutureInc());
2530 <        f.complete(one);
2531 <        checkCompletedNormally(g, two);
2532 <        assertTrue(r.ran);
2524 >    public void testThenCompose_normalCompletion() {
2525 >        for (ExecutionMode m : ExecutionMode.values())
2526 >        for (boolean createIncomplete : new boolean[] { true, false })
2527 >        for (Integer v1 : new Integer[] { 1, null })
2528 >    {
2529 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2530 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2531 >        if (!createIncomplete) f.complete(v1);
2532 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2533 >        if (createIncomplete) f.complete(v1);
2534  
2535 <        f = new CompletableFuture<>();
2536 <        f.complete(one);
2537 <        g = f.thenCompose(r = new CompletableFutureInc());
2538 <        checkCompletedNormally(g, two);
2747 <        assertTrue(r.ran);
2748 <    }
2535 >        checkCompletedNormally(g, inc(v1));
2536 >        checkCompletedNormally(f, v1);
2537 >        assertEquals(1, r.invocationCount);
2538 >    }}
2539  
2540      /**
2541       * thenCompose result completes exceptionally after exceptional
2542       * completion of source
2543       */
2544 <    public void testThenCompose2() {
2545 <        CompletableFuture<Integer> f, g;
2546 <        CompletableFutureInc r;
2547 <
2548 <        f = new CompletableFuture<>();
2549 <        g = f.thenCompose(r = new CompletableFutureInc());
2550 <        f.completeExceptionally(new CFException());
2551 <        checkCompletedWithWrappedCFException(g);
2544 >    public void testThenCompose_exceptionalCompletion() {
2545 >        for (ExecutionMode m : ExecutionMode.values())
2546 >        for (boolean createIncomplete : new boolean[] { true, false })
2547 >    {
2548 >        final CFException ex = new CFException();
2549 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2550 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2551 >        if (!createIncomplete) f.completeExceptionally(ex);
2552 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2553 >        if (createIncomplete) f.completeExceptionally(ex);
2554  
2555 <        f = new CompletableFuture<>();
2556 <        f.completeExceptionally(new CFException());
2557 <        g = f.thenCompose(r = new CompletableFutureInc());
2558 <        checkCompletedWithWrappedCFException(g);
2767 <    }
2555 >        checkCompletedWithWrappedCFException(g, ex);
2556 >        checkCompletedWithWrappedCFException(f, ex);
2557 >        assertEquals(0, r.invocationCount);
2558 >    }}
2559  
2560      /**
2561       * thenCompose result completes exceptionally if action does
2562       */
2563 <    public void testThenCompose3() {
2564 <        CompletableFuture<Integer> f, g;
2565 <        FailingCompletableFutureFunction r;
2566 <
2567 <        f = new CompletableFuture<>();
2568 <        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2569 <        f.complete(one);
2570 <        checkCompletedWithWrappedCFException(g);
2563 >    public void testThenCompose_actionFailed() {
2564 >        for (ExecutionMode m : ExecutionMode.values())
2565 >        for (boolean createIncomplete : new boolean[] { true, false })
2566 >        for (Integer v1 : new Integer[] { 1, null })
2567 >    {
2568 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2569 >        final FailingCompletableFutureFunction r
2570 >            = new FailingCompletableFutureFunction(m);
2571 >        if (!createIncomplete) f.complete(v1);
2572 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2573 >        if (createIncomplete) f.complete(v1);
2574  
2781        f = new CompletableFuture<>();
2782        f.complete(one);
2783        g = f.thenCompose(r = new FailingCompletableFutureFunction());
2575          checkCompletedWithWrappedCFException(g);
2576 <    }
2576 >        checkCompletedNormally(f, v1);
2577 >    }}
2578  
2579      /**
2580       * thenCompose result completes exceptionally if source cancelled
2581       */
2582 <    public void testThenCompose4() {
2583 <        CompletableFuture<Integer> f, g;
2584 <        CompletableFutureInc r;
2585 <
2586 <        f = new CompletableFuture<>();
2587 <        g = f.thenCompose(r = new CompletableFutureInc());
2588 <        assertTrue(f.cancel(true));
2589 <        checkCompletedWithWrappedCancellationException(g);
2590 <
2591 <        f = new CompletableFuture<>();
2592 <        assertTrue(f.cancel(true));
2593 <        g = f.thenCompose(r = new CompletableFutureInc());
2594 <        checkCompletedWithWrappedCancellationException(g);
2803 <    }
2804 <
2805 <    // asyncs
2806 <
2807 <    /**
2808 <     * thenRunAsync result completes normally after normal completion of source
2809 <     */
2810 <    public void testThenRunAsync() {
2811 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2812 <        Noop r = new Noop();
2813 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2814 <        f.complete(null);
2815 <        checkCompletedNormally(g, null);
2816 <
2817 <        // reordered version
2818 <        f = new CompletableFuture<>();
2819 <        f.complete(null);
2820 <        r = new Noop();
2821 <        g = f.thenRunAsync(r);
2822 <        checkCompletedNormally(g, null);
2823 <    }
2824 <
2825 <    /**
2826 <     * thenRunAsync result completes exceptionally after exceptional
2827 <     * completion of source
2828 <     */
2829 <    public void testThenRunAsync2() {
2830 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2831 <        Noop r = new Noop();
2832 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2833 <        f.completeExceptionally(new CFException());
2834 <        try {
2835 <            g.join();
2836 <            shouldThrow();
2837 <        } catch (CompletionException success) {}
2838 <        checkCompletedWithWrappedCFException(g);
2839 <    }
2840 <
2841 <    /**
2842 <     * thenRunAsync result completes exceptionally if action does
2843 <     */
2844 <    public void testThenRunAsync3() {
2845 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2846 <        FailingNoop r = new FailingNoop();
2847 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2848 <        f.complete(null);
2849 <        checkCompletedWithWrappedCFException(g);
2850 <    }
2851 <
2852 <    /**
2853 <     * thenRunAsync result completes exceptionally if source cancelled
2854 <     */
2855 <    public void testThenRunAsync4() {
2856 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2857 <        Noop r = new Noop();
2858 <        CompletableFuture<Void> g = f.thenRunAsync(r);
2859 <        assertTrue(f.cancel(true));
2860 <        checkCompletedWithWrappedCancellationException(g);
2861 <    }
2862 <
2863 <    /**
2864 <     * thenApplyAsync result completes normally after normal completion of source
2865 <     */
2866 <    public void testThenApplyAsync() {
2867 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2868 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2869 <        f.complete(one);
2870 <        checkCompletedNormally(g, two);
2871 <    }
2872 <
2873 <    /**
2874 <     * thenApplyAsync result completes exceptionally after exceptional
2875 <     * completion of source
2876 <     */
2877 <    public void testThenApplyAsync2() {
2878 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2879 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2880 <        f.completeExceptionally(new CFException());
2881 <        checkCompletedWithWrappedCFException(g);
2882 <    }
2883 <
2884 <    /**
2885 <     * thenApplyAsync result completes exceptionally if action does
2886 <     */
2887 <    public void testThenApplyAsync3() {
2888 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2889 <        FailingFunction r = new FailingFunction();
2890 <        CompletableFuture<Integer> g = f.thenApplyAsync(r);
2891 <        f.complete(null);
2892 <        checkCompletedWithWrappedCFException(g);
2893 <    }
2894 <
2895 <    /**
2896 <     * thenApplyAsync result completes exceptionally if source cancelled
2897 <     */
2898 <    public void testThenApplyAsync4() {
2899 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2900 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc);
2901 <        assertTrue(f.cancel(true));
2902 <        checkCompletedWithWrappedCancellationException(g);
2903 <    }
2904 <
2905 <    /**
2906 <     * thenAcceptAsync result completes normally after normal
2907 <     * completion of source
2908 <     */
2909 <    public void testThenAcceptAsync() {
2910 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2911 <        IncAction r = new IncAction();
2912 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2913 <        f.complete(one);
2914 <        checkCompletedNormally(g, null);
2915 <        assertEquals(r.value, (Integer) 2);
2916 <    }
2917 <
2918 <    /**
2919 <     * thenAcceptAsync result completes exceptionally after exceptional
2920 <     * completion of source
2921 <     */
2922 <    public void testThenAcceptAsync2() {
2923 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2924 <        IncAction r = new IncAction();
2925 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2926 <        f.completeExceptionally(new CFException());
2927 <        checkCompletedWithWrappedCFException(g);
2928 <    }
2929 <
2930 <    /**
2931 <     * thenAcceptAsync result completes exceptionally if action does
2932 <     */
2933 <    public void testThenAcceptAsync3() {
2934 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2935 <        FailingConsumer r = new FailingConsumer();
2936 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2937 <        f.complete(null);
2938 <        checkCompletedWithWrappedCFException(g);
2939 <    }
2940 <
2941 <    /**
2942 <     * thenAcceptAsync result completes exceptionally if source cancelled
2943 <     */
2944 <    public void testThenAcceptAsync4() {
2945 <        CompletableFuture<Integer> f = new CompletableFuture<>();
2946 <        IncAction r = new IncAction();
2947 <        CompletableFuture<Void> g = f.thenAcceptAsync(r);
2948 <        assertTrue(f.cancel(true));
2949 <        checkCompletedWithWrappedCancellationException(g);
2950 <    }
2951 <
2952 <    /**
2953 <     * thenComposeAsync result completes normally after normal
2954 <     * completion of source
2955 <     */
2956 <    public void testThenComposeAsync() {
2957 <        CompletableFuture<Integer> f, g;
2958 <        CompletableFutureInc r;
2959 <
2960 <        f = new CompletableFuture<>();
2961 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2962 <        f.complete(one);
2963 <        checkCompletedNormally(g, two);
2964 <
2965 <        f = new CompletableFuture<>();
2966 <        f.complete(one);
2967 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2968 <        checkCompletedNormally(g, two);
2969 <    }
2970 <
2971 <    /**
2972 <     * thenComposeAsync result completes exceptionally after
2973 <     * exceptional completion of source
2974 <     */
2975 <    public void testThenComposeAsync2() {
2976 <        CompletableFuture<Integer> f, g;
2977 <        CompletableFutureInc r;
2978 <
2979 <        f = new CompletableFuture<>();
2980 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2981 <        f.completeExceptionally(new CFException());
2982 <        checkCompletedWithWrappedCFException(g);
2983 <        assertFalse(r.ran);
2984 <
2985 <        f = new CompletableFuture<>();
2986 <        f.completeExceptionally(new CFException());
2987 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
2988 <        checkCompletedWithWrappedCFException(g);
2989 <        assertFalse(r.ran);
2990 <    }
2991 <
2992 <    /**
2993 <     * thenComposeAsync result completes exceptionally if action does
2994 <     */
2995 <    public void testThenComposeAsync3() {
2996 <        CompletableFuture<Integer> f, g;
2997 <        FailingCompletableFutureFunction r;
2998 <
2999 <        f = new CompletableFuture<>();
3000 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
3001 <        f.complete(one);
3002 <        checkCompletedWithWrappedCFException(g);
3003 <
3004 <        f = new CompletableFuture<>();
3005 <        f.complete(one);
3006 <        g = f.thenComposeAsync(r = new FailingCompletableFutureFunction());
3007 <        checkCompletedWithWrappedCFException(g);
3008 <    }
3009 <
3010 <    /**
3011 <     * thenComposeAsync result completes exceptionally if source cancelled
3012 <     */
3013 <    public void testThenComposeAsync4() {
3014 <        CompletableFuture<Integer> f, g;
3015 <        CompletableFutureInc r;
3016 <
3017 <        f = new CompletableFuture<>();
3018 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3019 <        assertTrue(f.cancel(true));
3020 <        checkCompletedWithWrappedCancellationException(g);
3021 <
3022 <        f = new CompletableFuture<>();
3023 <        assertTrue(f.cancel(true));
3024 <        g = f.thenComposeAsync(r = new CompletableFutureInc());
3025 <        checkCompletedWithWrappedCancellationException(g);
3026 <    }
3027 <
3028 <    // async with explicit executors
3029 <
3030 <    /**
3031 <     * thenRunAsync result completes normally after normal completion of source
3032 <     */
3033 <    public void testThenRunAsyncE() {
3034 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3035 <        Noop r = new Noop();
3036 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3037 <        f.complete(null);
3038 <        checkCompletedNormally(g, null);
3039 <
3040 <        // reordered version
3041 <        f = new CompletableFuture<>();
3042 <        f.complete(null);
3043 <        r = new Noop();
3044 <        g = f.thenRunAsync(r, new ThreadExecutor());
3045 <        checkCompletedNormally(g, null);
3046 <    }
3047 <
3048 <    /**
3049 <     * thenRunAsync result completes exceptionally after exceptional
3050 <     * completion of source
3051 <     */
3052 <    public void testThenRunAsync2E() {
3053 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3054 <        Noop r = new Noop();
3055 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3056 <        f.completeExceptionally(new CFException());
3057 <        try {
3058 <            g.join();
3059 <            shouldThrow();
3060 <        } catch (CompletionException success) {}
3061 <        checkCompletedWithWrappedCFException(g);
3062 <    }
3063 <
3064 <    /**
3065 <     * thenRunAsync result completes exceptionally if action does
3066 <     */
3067 <    public void testThenRunAsync3E() {
3068 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3069 <        FailingNoop r = new FailingNoop();
3070 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3071 <        f.complete(null);
3072 <        checkCompletedWithWrappedCFException(g);
3073 <    }
3074 <
3075 <    /**
3076 <     * thenRunAsync result completes exceptionally if source cancelled
3077 <     */
3078 <    public void testThenRunAsync4E() {
3079 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3080 <        Noop r = new Noop();
3081 <        CompletableFuture<Void> g = f.thenRunAsync(r, new ThreadExecutor());
3082 <        assertTrue(f.cancel(true));
3083 <        checkCompletedWithWrappedCancellationException(g);
3084 <    }
3085 <
3086 <    /**
3087 <     * thenApplyAsync result completes normally after normal completion of source
3088 <     */
3089 <    public void testThenApplyAsyncE() {
3090 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3091 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3092 <        f.complete(one);
3093 <        checkCompletedNormally(g, two);
3094 <    }
3095 <
3096 <    /**
3097 <     * thenApplyAsync result completes exceptionally after exceptional
3098 <     * completion of source
3099 <     */
3100 <    public void testThenApplyAsync2E() {
3101 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3102 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3103 <        f.completeExceptionally(new CFException());
3104 <        checkCompletedWithWrappedCFException(g);
3105 <    }
3106 <
3107 <    /**
3108 <     * thenApplyAsync result completes exceptionally if action does
3109 <     */
3110 <    public void testThenApplyAsync3E() {
3111 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3112 <        FailingFunction r = new FailingFunction();
3113 <        CompletableFuture<Integer> g = f.thenApplyAsync(r, new ThreadExecutor());
3114 <        f.complete(null);
3115 <        checkCompletedWithWrappedCFException(g);
3116 <    }
3117 <
3118 <    /**
3119 <     * thenApplyAsync result completes exceptionally if source cancelled
3120 <     */
3121 <    public void testThenApplyAsync4E() {
3122 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3123 <        CompletableFuture<Integer> g = f.thenApplyAsync(inc, new ThreadExecutor());
3124 <        assertTrue(f.cancel(true));
3125 <        checkCompletedWithWrappedCancellationException(g);
3126 <    }
3127 <
3128 <    /**
3129 <     * thenAcceptAsync result completes normally after normal
3130 <     * completion of source
3131 <     */
3132 <    public void testThenAcceptAsyncE() {
3133 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3134 <        IncAction r = new IncAction();
3135 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3136 <        f.complete(one);
3137 <        checkCompletedNormally(g, null);
3138 <        assertEquals(r.value, (Integer) 2);
3139 <    }
3140 <
3141 <    /**
3142 <     * thenAcceptAsync result completes exceptionally after exceptional
3143 <     * completion of source
3144 <     */
3145 <    public void testThenAcceptAsync2E() {
3146 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3147 <        IncAction r = new IncAction();
3148 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3149 <        f.completeExceptionally(new CFException());
3150 <        checkCompletedWithWrappedCFException(g);
3151 <    }
3152 <
3153 <    /**
3154 <     * thenAcceptAsync result completes exceptionally if action does
3155 <     */
3156 <    public void testThenAcceptAsync3E() {
3157 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3158 <        FailingConsumer r = new FailingConsumer();
3159 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3160 <        f.complete(null);
3161 <        checkCompletedWithWrappedCFException(g);
3162 <    }
3163 <
3164 <    /**
3165 <     * thenAcceptAsync result completes exceptionally if source cancelled
3166 <     */
3167 <    public void testThenAcceptAsync4E() {
3168 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3169 <        IncAction r = new IncAction();
3170 <        CompletableFuture<Void> g = f.thenAcceptAsync(r, new ThreadExecutor());
3171 <        assertTrue(f.cancel(true));
3172 <        checkCompletedWithWrappedCancellationException(g);
3173 <    }
3174 <
3175 <    /**
3176 <     * thenComposeAsync result completes normally after normal
3177 <     * completion of source
3178 <     */
3179 <    public void testThenComposeAsyncE() {
3180 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3181 <        CompletableFutureInc r = new CompletableFutureInc();
3182 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3183 <        f.complete(one);
3184 <        checkCompletedNormally(g, two);
3185 <    }
3186 <
3187 <    /**
3188 <     * thenComposeAsync result completes exceptionally after
3189 <     * exceptional completion of source
3190 <     */
3191 <    public void testThenComposeAsync2E() {
3192 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3193 <        CompletableFutureInc r = new CompletableFutureInc();
3194 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3195 <        f.completeExceptionally(new CFException());
3196 <        checkCompletedWithWrappedCFException(g);
3197 <    }
3198 <
3199 <    /**
3200 <     * thenComposeAsync result completes exceptionally if action does
3201 <     */
3202 <    public void testThenComposeAsync3E() {
3203 <        CompletableFuture<Integer> f = new CompletableFuture<>();
3204 <        FailingCompletableFutureFunction r = new FailingCompletableFutureFunction();
3205 <        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3206 <        f.complete(one);
3207 <        checkCompletedWithWrappedCFException(g);
3208 <    }
2582 >    public void testThenCompose_sourceCancelled() {
2583 >        for (ExecutionMode m : ExecutionMode.values())
2584 >        for (boolean createIncomplete : new boolean[] { true, false })
2585 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2586 >    {
2587 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2588 >        final CompletableFutureInc r = new CompletableFutureInc(m);
2589 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2590 >        final CompletableFuture<Integer> g = m.thenCompose(f, r);
2591 >        if (createIncomplete) {
2592 >            checkIncomplete(g);
2593 >            assertTrue(f.cancel(mayInterruptIfRunning));
2594 >        }
2595  
3210    /**
3211     * thenComposeAsync result completes exceptionally if source cancelled
3212     */
3213    public void testThenComposeAsync4E() {
3214        CompletableFuture<Integer> f = new CompletableFuture<>();
3215        CompletableFutureInc r = new CompletableFutureInc();
3216        CompletableFuture<Integer> g = f.thenComposeAsync(r, new ThreadExecutor());
3217        assertTrue(f.cancel(true));
2596          checkCompletedWithWrappedCancellationException(g);
2597 <    }
2597 >        checkCancelled(f);
2598 >    }}
2599  
2600      // other static methods
2601  
# Line 3307 | Line 2686 | public class CompletableFutureTest exten
2686          Runnable[] throwingActions = {
2687              () -> CompletableFuture.supplyAsync(null),
2688              () -> CompletableFuture.supplyAsync(null, exec),
2689 <            () -> CompletableFuture.supplyAsync(supplyOne, null),
2689 >            () -> CompletableFuture.supplyAsync(new IntegerSupplier(ExecutionMode.DEFAULT, 42), null),
2690  
2691              () -> CompletableFuture.runAsync(null),
2692              () -> CompletableFuture.runAsync(null, exec),
# Line 3380 | Line 2759 | public class CompletableFutureTest exten
2759  
2760              () -> f.thenCompose(null),
2761              () -> f.thenComposeAsync(null),
2762 <            () -> f.thenComposeAsync(new CompletableFutureInc(), null),
2762 >            () -> f.thenComposeAsync(new CompletableFutureInc(ExecutionMode.EXECUTOR), null),
2763              () -> f.thenComposeAsync(null, exec),
2764  
2765              () -> f.exceptionally(null),
# Line 3418 | Line 2797 | public class CompletableFutureTest exten
2797       */
2798      public void testWhenComplete_normalCompletion1() {
2799          for (ExecutionMode m : ExecutionMode.values())
2800 <        for (Integer v1 : new Integer[] { 1, null }) {
2801 <
2802 <        final AtomicInteger a = new AtomicInteger();
2800 >        for (boolean createIncomplete : new boolean[] { true, false })
2801 >        for (Integer v1 : new Integer[] { 1, null })
2802 >    {
2803 >        final AtomicInteger a = new AtomicInteger(0);
2804          final CompletableFuture<Integer> f = new CompletableFuture<>();
2805 <        final CompletableFuture<Integer> g =
2806 <            m.whenComplete(f,
2807 <                           (Integer x, Throwable t) -> {
2808 <                               threadAssertSame(x, v1);
2809 <                               threadAssertNull(t);
2810 <                               a.getAndIncrement();
2811 <                           });
2812 <        f.complete(v1);
2813 <        checkCompletedNormally(f, v1);
2805 >        if (!createIncomplete) f.complete(v1);
2806 >        final CompletableFuture<Integer> g = m.whenComplete
2807 >            (f,
2808 >             (Integer x, Throwable t) -> {
2809 >                threadAssertSame(x, v1);
2810 >                threadAssertNull(t);
2811 >                a.getAndIncrement();
2812 >            });
2813 >        if (createIncomplete) f.complete(v1);
2814 >
2815          checkCompletedNormally(g, v1);
2816 <        assertEquals(a.get(), 1);
2817 <        }
2818 <    }
2816 >        checkCompletedNormally(f, v1);
2817 >        assertEquals(1, a.get());
2818 >    }}
2819  
2820      /**
2821       * whenComplete action executes on exceptional completion, propagating
# Line 3442 | Line 2823 | public class CompletableFutureTest exten
2823       */
2824      public void testWhenComplete_exceptionalCompletion() {
2825          for (ExecutionMode m : ExecutionMode.values())
2826 <        for (Integer v1 : new Integer[] { 1, null }) {
2827 <
2828 <        final AtomicInteger a = new AtomicInteger();
2826 >        for (boolean createIncomplete : new boolean[] { true, false })
2827 >        for (Integer v1 : new Integer[] { 1, null })
2828 >    {
2829 >        final AtomicInteger a = new AtomicInteger(0);
2830          final CFException ex = new CFException();
2831          final CompletableFuture<Integer> f = new CompletableFuture<>();
2832 +        if (!createIncomplete) f.completeExceptionally(ex);
2833          final CompletableFuture<Integer> g = m.whenComplete
2834              (f,
2835               (Integer x, Throwable t) -> {
# Line 3454 | Line 2837 | public class CompletableFutureTest exten
2837                  threadAssertSame(t, ex);
2838                  a.getAndIncrement();
2839              });
2840 <        f.completeExceptionally(ex);
2840 >        if (createIncomplete) f.completeExceptionally(ex);
2841          checkCompletedWithWrappedCFException(f, ex);
2842          checkCompletedWithWrappedCFException(g, ex);
2843 <        assertEquals(a.get(), 1);
2844 <        }
2845 <    }
2843 >        assertEquals(1, a.get());
2844 >    }}
2845 >
2846 >    /**
2847 >     * whenComplete action executes on cancelled source, propagating
2848 >     * CancellationException.
2849 >     */
2850 >    public void testWhenComplete_sourceCancelled() {
2851 >        for (ExecutionMode m : ExecutionMode.values())
2852 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2853 >        for (boolean createIncomplete : new boolean[] { true, false })
2854 >    {
2855 >        final AtomicInteger a = new AtomicInteger(0);
2856 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
2857 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2858 >        final CompletableFuture<Integer> g = m.whenComplete
2859 >            (f,
2860 >             (Integer x, Throwable t) -> {
2861 >                threadAssertNull(x);
2862 >                threadAssertTrue(t instanceof CancellationException);
2863 >                a.getAndIncrement();
2864 >            });
2865 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2866 >
2867 >        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2868 >        checkCompletedWithWrappedCancellationException(g);
2869 >        checkCancelled(f);
2870 >        assertEquals(1, a.get());
2871 >    }}
2872  
2873      /**
2874       * If a whenComplete action throws an exception when triggered by
2875       * a normal completion, it completes exceptionally
2876       */
2877      public void testWhenComplete_actionFailed() {
2878 +        for (boolean createIncomplete : new boolean[] { true, false })
2879          for (ExecutionMode m : ExecutionMode.values())
2880 <        for (Integer v1 : new Integer[] { 1, null }) {
2881 <
2880 >        for (Integer v1 : new Integer[] { 1, null })
2881 >    {
2882 >        final AtomicInteger a = new AtomicInteger(0);
2883          final CFException ex = new CFException();
2884          final CompletableFuture<Integer> f = new CompletableFuture<>();
2885 +        if (!createIncomplete) f.complete(v1);
2886          final CompletableFuture<Integer> g = m.whenComplete
2887              (f,
2888               (Integer x, Throwable t) -> {
2889                  threadAssertSame(x, v1);
2890                  threadAssertNull(t);
2891 +                a.getAndIncrement();
2892                  throw ex;
2893              });
2894 <        f.complete(v1);
2894 >        if (createIncomplete) f.complete(v1);
2895          checkCompletedNormally(f, v1);
2896          checkCompletedWithWrappedCFException(g, ex);
2897 <        }
2898 <    }
2897 >        assertEquals(1, a.get());
2898 >    }}
2899  
2900      /**
2901       * If a whenComplete action throws an exception when triggered by
# Line 3490 | Line 2903 | public class CompletableFutureTest exten
2903       * exception takes precedence.
2904       */
2905      public void testWhenComplete_actionFailedSourceFailed() {
2906 +        for (boolean createIncomplete : new boolean[] { true, false })
2907          for (ExecutionMode m : ExecutionMode.values())
2908 <        for (Integer v1 : new Integer[] { 1, null }) {
2909 <
2908 >        for (Integer v1 : new Integer[] { 1, null })
2909 >    {
2910 >        final AtomicInteger a = new AtomicInteger(0);
2911          final CFException ex1 = new CFException();
2912          final CFException ex2 = new CFException();
2913          final CompletableFuture<Integer> f = new CompletableFuture<>();
2914 +
2915 +        if (!createIncomplete) f.completeExceptionally(ex1);
2916          final CompletableFuture<Integer> g = m.whenComplete
2917              (f,
2918               (Integer x, Throwable t) -> {
2919                  threadAssertSame(t, ex1);
2920                  threadAssertNull(x);
2921 +                a.getAndIncrement();
2922                  throw ex2;
2923              });
2924 <        f.completeExceptionally(ex1);
2924 >        if (createIncomplete) f.completeExceptionally(ex1);
2925 >
2926          checkCompletedWithWrappedCFException(f, ex1);
2927          checkCompletedWithWrappedCFException(g, ex1);
2928 <        }
2929 <    }
3511 <
3512 <    /**
3513 <     * handleAsync action completes normally with function value on
3514 <     * either normal or exceptional completion of source
3515 <     */
3516 <    public void testHandleAsync() {
3517 <        CompletableFuture<Integer> f, g;
3518 <        IntegerHandler r;
3519 <
3520 <        f = new CompletableFuture<>();
3521 <        g = f.handleAsync(r = new IntegerHandler());
3522 <        assertFalse(r.ran);
3523 <        f.completeExceptionally(new CFException());
3524 <        checkCompletedWithWrappedCFException(f);
3525 <        checkCompletedNormally(g, three);
3526 <        assertTrue(r.ran);
3527 <
3528 <        f = new CompletableFuture<>();
3529 <        g = f.handleAsync(r = new IntegerHandler());
3530 <        assertFalse(r.ran);
3531 <        f.completeExceptionally(new CFException());
3532 <        checkCompletedWithWrappedCFException(f);
3533 <        checkCompletedNormally(g, three);
3534 <        assertTrue(r.ran);
3535 <
3536 <        f = new CompletableFuture<>();
3537 <        g = f.handleAsync(r = new IntegerHandler());
3538 <        assertFalse(r.ran);
3539 <        f.complete(one);
3540 <        checkCompletedNormally(f, one);
3541 <        checkCompletedNormally(g, two);
3542 <        assertTrue(r.ran);
3543 <
3544 <        f = new CompletableFuture<>();
3545 <        g = f.handleAsync(r = new IntegerHandler());
3546 <        assertFalse(r.ran);
3547 <        f.complete(one);
3548 <        checkCompletedNormally(f, one);
3549 <        checkCompletedNormally(g, two);
3550 <        assertTrue(r.ran);
3551 <    }
3552 <
3553 <    /**
3554 <     * handleAsync action with Executor completes normally with
3555 <     * function value on either normal or exceptional completion of
3556 <     * source
3557 <     */
3558 <    public void testHandleAsync2() {
3559 <        CompletableFuture<Integer> f, g;
3560 <        ThreadExecutor exec = new ThreadExecutor();
3561 <        IntegerHandler r;
3562 <
3563 <        f = new CompletableFuture<>();
3564 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3565 <        assertFalse(r.ran);
3566 <        f.completeExceptionally(new CFException());
3567 <        checkCompletedWithWrappedCFException(f);
3568 <        checkCompletedNormally(g, three);
3569 <        assertTrue(r.ran);
3570 <
3571 <        f = new CompletableFuture<>();
3572 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3573 <        assertFalse(r.ran);
3574 <        f.completeExceptionally(new CFException());
3575 <        checkCompletedWithWrappedCFException(f);
3576 <        checkCompletedNormally(g, three);
3577 <        assertTrue(r.ran);
3578 <
3579 <        f = new CompletableFuture<>();
3580 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3581 <        assertFalse(r.ran);
3582 <        f.complete(one);
3583 <        checkCompletedNormally(f, one);
3584 <        checkCompletedNormally(g, two);
3585 <        assertTrue(r.ran);
3586 <
3587 <        f = new CompletableFuture<>();
3588 <        g = f.handleAsync(r = new IntegerHandler(), exec);
3589 <        assertFalse(r.ran);
3590 <        f.complete(one);
3591 <        checkCompletedNormally(f, one);
3592 <        checkCompletedNormally(g, two);
3593 <        assertTrue(r.ran);
3594 <    }
2928 >        assertEquals(1, a.get());
2929 >    }}
2930  
2931   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines