ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/CompletableFutureTest.java
(Generate patch)

Comparing jsr166/src/test/tck/CompletableFutureTest.java (file contents):
Revision 1.63 by jsr166, Fri Jun 6 16:54:16 2014 UTC vs.
Revision 1.77 by jsr166, Sat Jun 7 21:46:50 2014 UTC

# Line 105 | Line 105 | public class CompletableFutureTest exten
105          assertTrue(f.toString().contains("[Completed exceptionally]"));
106      }
107  
108 <    void checkCompletedWithWrappedCFException(CompletableFuture<?> f,
109 <                                              CFException ex) {
108 >    <U> void checkCompletedExceptionallyWithRootCause(CompletableFuture<U> f,
109 >                                                      Throwable ex) {
110          try {
111              f.get(LONG_DELAY_MS, MILLISECONDS);
112              shouldThrow();
# Line 131 | Line 131 | public class CompletableFutureTest exten
131          } catch (ExecutionException success) {
132              assertSame(ex, success.getCause());
133          } catch (Throwable fail) { threadUnexpectedException(fail); }
134 +
135          assertTrue(f.isDone());
136          assertFalse(f.isCancelled());
137          assertTrue(f.toString().contains("[Completed exceptionally]"));
138      }
139  
140 +    <U> void checkCompletedWithWrappedException(CompletableFuture<U> f,
141 +                                                Throwable ex) {
142 +        checkCompletedExceptionallyWithRootCause(f, ex);
143 +        try {
144 +            CompletableFuture<Throwable> spy = f.handle
145 +                ((U u, Throwable t) -> t);
146 +            assertTrue(spy.join() instanceof CompletionException);
147 +            assertSame(ex, spy.join().getCause());
148 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
149 +    }
150 +
151 +    <U> void checkCompletedExceptionally(CompletableFuture<U> f, Throwable ex) {
152 +        checkCompletedExceptionallyWithRootCause(f, ex);
153 +        try {
154 +            CompletableFuture<Throwable> spy = f.handle
155 +                ((U u, Throwable t) -> t);
156 +            assertSame(ex, spy.join());
157 +        } catch (Throwable fail) { threadUnexpectedException(fail); }
158 +    }
159 +
160      void checkCancelled(CompletableFuture<?> f) {
161          try {
162              f.get(LONG_DELAY_MS, MILLISECONDS);
# Line 218 | Line 239 | public class CompletableFutureTest exten
239       */
240      public void testCompleteExceptionally() {
241          CompletableFuture<Integer> f = new CompletableFuture<>();
242 +        CFException ex = new CFException();
243          checkIncomplete(f);
244 <        f.completeExceptionally(new CFException());
245 <        checkCompletedWithWrappedCFException(f);
244 >        f.completeExceptionally(ex);
245 >        checkCompletedExceptionally(f, ex);
246      }
247  
248      /**
# Line 261 | Line 283 | public class CompletableFutureTest exten
283       * obtrudeException forces completion with given exception
284       */
285      public void testObtrudeException() {
286 <        CompletableFuture<Integer> f = new CompletableFuture<>();
287 <        checkIncomplete(f);
288 <        f.complete(one);
289 <        checkCompletedNormally(f, one);
290 <        f.obtrudeException(new CFException());
269 <        checkCompletedWithWrappedCFException(f);
286 >        for (Integer v1 : new Integer[] { 1, null })
287 >    {
288 >        CFException ex;
289 >        CompletableFuture<Integer> f;
290 >
291          f = new CompletableFuture<>();
292 <        f.obtrudeException(new CFException());
293 <        checkCompletedWithWrappedCFException(f);
292 >        f.complete(v1);
293 >        for (int i = 0; i < 2; i++) {
294 >            f.obtrudeException(ex = new CFException());
295 >            checkCompletedExceptionally(f, ex);
296 >        }
297 >
298 >        f = new CompletableFuture<>();
299 >        for (int i = 0; i < 2; i++) {
300 >            f.obtrudeException(ex = new CFException());
301 >            checkCompletedExceptionally(f, ex);
302 >        }
303 >
304          f = new CompletableFuture<>();
305 +        f.completeExceptionally(ex = new CFException());
306 +        f.obtrudeValue(v1);
307 +        checkCompletedNormally(f, v1);
308 +        f.obtrudeException(ex = new CFException());
309 +        checkCompletedExceptionally(f, ex);
310          f.completeExceptionally(new CFException());
311 <        f.obtrudeValue(four);
312 <        checkCompletedNormally(f, four);
313 <        f.obtrudeException(new CFException());
314 <        checkCompletedWithWrappedCFException(f);
279 <    }
311 >        checkCompletedExceptionally(f, ex);
312 >        f.complete(v1);
313 >        checkCompletedExceptionally(f, ex);
314 >    }}
315  
316      /**
317       * getNumberOfDependents returns number of dependent tasks
318       */
319      public void testGetNumberOfDependents() {
320 +        for (ExecutionMode m : ExecutionMode.values())
321 +    {
322          CompletableFuture<Integer> f = new CompletableFuture<>();
323          assertEquals(0, f.getNumberOfDependents());
324 <        CompletableFuture g = f.thenRun(new Noop(ExecutionMode.DEFAULT));
324 >        final CompletableFuture<Void> g = m.thenRun(f, new Noop(m));
325          assertEquals(1, f.getNumberOfDependents());
326          assertEquals(0, g.getNumberOfDependents());
327 <        CompletableFuture h = f.thenRun(new Noop(ExecutionMode.DEFAULT));
327 >        final CompletableFuture<Void> h = m.thenRun(f, new Noop(m));
328          assertEquals(2, f.getNumberOfDependents());
329 +        assertEquals(0, h.getNumberOfDependents());
330          f.complete(1);
331          checkCompletedNormally(g, null);
332 +        checkCompletedNormally(h, null);
333          assertEquals(0, f.getNumberOfDependents());
334          assertEquals(0, g.getNumberOfDependents());
335 <    }
335 >        assertEquals(0, h.getNumberOfDependents());
336 >    }}
337  
338      /**
339       * toString indicates current completion state
# Line 310 | Line 350 | public class CompletableFutureTest exten
350          f = new CompletableFuture<String>();
351          f.completeExceptionally(new IndexOutOfBoundsException());
352          assertTrue(f.toString().contains("[Completed exceptionally]"));
353 +
354 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false }) {
355 +            f = new CompletableFuture<String>();
356 +            f.cancel(mayInterruptIfRunning);
357 +            assertTrue(f.toString().contains("[Completed exceptionally]"));
358 +        }
359      }
360  
361      /**
# Line 360 | Line 406 | public class CompletableFutureTest exten
406          return (x == null) ? null : x + 1;
407      }
408  
409 <    class IncAction extends CheckedIntegerAction
409 >    class NoopConsumer extends CheckedIntegerAction
410          implements Consumer<Integer>
411      {
412 <        IncAction(ExecutionMode m) { super(m); }
412 >        NoopConsumer(ExecutionMode m) { super(m); }
413          public void accept(Integer x) {
414              invoked();
415 <            value = inc(x);
415 >            value = x;
416          }
417      }
418  
# Line 808 | Line 854 | public class CompletableFutureTest exten
854          assertEquals(0, a.get());
855      }}
856  
811
857      /**
858       * exceptionally action completes with function value on source
859       * exception
# Line 852 | Line 897 | public class CompletableFutureTest exten
897              });
898          if (createIncomplete) f.completeExceptionally(ex1);
899  
900 <        checkCompletedWithWrappedCFException(g, ex2);
900 >        checkCompletedWithWrappedException(g, ex2);
901 >        assertEquals(1, a.get());
902 >    }}
903 >
904 >    /**
905 >     * whenComplete action executes on normal completion, propagating
906 >     * source result.
907 >     */
908 >    public void testWhenComplete_normalCompletion1() {
909 >        for (ExecutionMode m : ExecutionMode.values())
910 >        for (boolean createIncomplete : new boolean[] { true, false })
911 >        for (Integer v1 : new Integer[] { 1, null })
912 >    {
913 >        final AtomicInteger a = new AtomicInteger(0);
914 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
915 >        if (!createIncomplete) f.complete(v1);
916 >        final CompletableFuture<Integer> g = m.whenComplete
917 >            (f,
918 >             (Integer x, Throwable t) -> {
919 >                m.checkExecutionMode();
920 >                threadAssertSame(x, v1);
921 >                threadAssertNull(t);
922 >                a.getAndIncrement();
923 >            });
924 >        if (createIncomplete) f.complete(v1);
925 >
926 >        checkCompletedNormally(g, v1);
927 >        checkCompletedNormally(f, v1);
928 >        assertEquals(1, a.get());
929 >    }}
930 >
931 >    /**
932 >     * whenComplete action executes on exceptional completion, propagating
933 >     * source result.
934 >     */
935 >    public void testWhenComplete_exceptionalCompletion() {
936 >        for (ExecutionMode m : ExecutionMode.values())
937 >        for (boolean createIncomplete : new boolean[] { true, false })
938 >        for (Integer v1 : new Integer[] { 1, null })
939 >    {
940 >        final AtomicInteger a = new AtomicInteger(0);
941 >        final CFException ex = new CFException();
942 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
943 >        if (!createIncomplete) f.completeExceptionally(ex);
944 >        final CompletableFuture<Integer> g = m.whenComplete
945 >            (f,
946 >             (Integer x, Throwable t) -> {
947 >                m.checkExecutionMode();
948 >                threadAssertNull(x);
949 >                threadAssertSame(t, ex);
950 >                a.getAndIncrement();
951 >            });
952 >        if (createIncomplete) f.completeExceptionally(ex);
953 >
954 >        checkCompletedWithWrappedException(g, ex);
955 >        checkCompletedExceptionally(f, ex);
956 >        assertEquals(1, a.get());
957 >    }}
958 >
959 >    /**
960 >     * whenComplete action executes on cancelled source, propagating
961 >     * CancellationException.
962 >     */
963 >    public void testWhenComplete_sourceCancelled() {
964 >        for (ExecutionMode m : ExecutionMode.values())
965 >        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
966 >        for (boolean createIncomplete : new boolean[] { true, false })
967 >    {
968 >        final AtomicInteger a = new AtomicInteger(0);
969 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
970 >        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
971 >        final CompletableFuture<Integer> g = m.whenComplete
972 >            (f,
973 >             (Integer x, Throwable t) -> {
974 >                m.checkExecutionMode();
975 >                threadAssertNull(x);
976 >                threadAssertTrue(t instanceof CancellationException);
977 >                a.getAndIncrement();
978 >            });
979 >        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
980 >
981 >        checkCompletedWithWrappedCancellationException(g);
982 >        checkCancelled(f);
983 >        assertEquals(1, a.get());
984 >    }}
985 >
986 >    /**
987 >     * If a whenComplete action throws an exception when triggered by
988 >     * a normal completion, it completes exceptionally
989 >     */
990 >    public void testWhenComplete_actionFailed() {
991 >        for (boolean createIncomplete : new boolean[] { true, false })
992 >        for (ExecutionMode m : ExecutionMode.values())
993 >        for (Integer v1 : new Integer[] { 1, null })
994 >    {
995 >        final AtomicInteger a = new AtomicInteger(0);
996 >        final CFException ex = new CFException();
997 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
998 >        if (!createIncomplete) f.complete(v1);
999 >        final CompletableFuture<Integer> g = m.whenComplete
1000 >            (f,
1001 >             (Integer x, Throwable t) -> {
1002 >                m.checkExecutionMode();
1003 >                threadAssertSame(x, v1);
1004 >                threadAssertNull(t);
1005 >                a.getAndIncrement();
1006 >                throw ex;
1007 >            });
1008 >        if (createIncomplete) f.complete(v1);
1009 >
1010 >        checkCompletedWithWrappedException(g, ex);
1011 >        checkCompletedNormally(f, v1);
1012 >        assertEquals(1, a.get());
1013 >    }}
1014 >
1015 >    /**
1016 >     * If a whenComplete action throws an exception when triggered by
1017 >     * a source completion that also throws an exception, the source
1018 >     * exception takes precedence.
1019 >     */
1020 >    public void testWhenComplete_actionFailedSourceFailed() {
1021 >        for (boolean createIncomplete : new boolean[] { true, false })
1022 >        for (ExecutionMode m : ExecutionMode.values())
1023 >        for (Integer v1 : new Integer[] { 1, null })
1024 >    {
1025 >        final AtomicInteger a = new AtomicInteger(0);
1026 >        final CFException ex1 = new CFException();
1027 >        final CFException ex2 = new CFException();
1028 >        final CompletableFuture<Integer> f = new CompletableFuture<>();
1029 >
1030 >        if (!createIncomplete) f.completeExceptionally(ex1);
1031 >        final CompletableFuture<Integer> g = m.whenComplete
1032 >            (f,
1033 >             (Integer x, Throwable t) -> {
1034 >                m.checkExecutionMode();
1035 >                threadAssertSame(t, ex1);
1036 >                threadAssertNull(x);
1037 >                a.getAndIncrement();
1038 >                throw ex2;
1039 >            });
1040 >        if (createIncomplete) f.completeExceptionally(ex1);
1041 >
1042 >        checkCompletedWithWrappedException(g, ex1);
1043 >        checkCompletedExceptionally(f, ex1);
1044          assertEquals(1, a.get());
1045      }}
1046  
# Line 909 | Line 1097 | public class CompletableFutureTest exten
1097          if (createIncomplete) f.completeExceptionally(ex);
1098  
1099          checkCompletedNormally(g, v1);
1100 <        checkCompletedWithWrappedCFException(f, ex);
1100 >        checkCompletedExceptionally(f, ex);
1101          assertEquals(1, a.get());
1102      }}
1103  
# Line 965 | Line 1153 | public class CompletableFutureTest exten
1153              });
1154          if (createIncomplete) f.completeExceptionally(ex1);
1155  
1156 <        checkCompletedWithWrappedCFException(g, ex2);
1157 <        checkCompletedWithWrappedCFException(f, ex1);
1156 >        checkCompletedWithWrappedException(g, ex2);
1157 >        checkCompletedExceptionally(f, ex1);
1158          assertEquals(1, a.get());
1159      }}
1160  
# Line 990 | Line 1178 | public class CompletableFutureTest exten
1178              });
1179          if (createIncomplete) f.complete(v1);
1180  
1181 <        checkCompletedWithWrappedCFException(g, ex);
1181 >        checkCompletedWithWrappedException(g, ex);
1182          checkCompletedNormally(f, v1);
1183          assertEquals(1, a.get());
1184      }}
# Line 1104 | Line 1292 | public class CompletableFutureTest exten
1292              f.completeExceptionally(ex);
1293          }
1294  
1295 <        checkCompletedWithWrappedCFException(g, ex);
1296 <        checkCompletedWithWrappedCFException(f, ex);
1295 >        checkCompletedWithWrappedException(g, ex);
1296 >        checkCompletedExceptionally(f, ex);
1297          r.assertNotInvoked();
1298      }}
1299  
# Line 1171 | Line 1359 | public class CompletableFutureTest exten
1359  
1360          checkCompletedNormally(g, inc(v1));
1361          checkCompletedNormally(f, v1);
1362 <        r.assertInvoked();
1362 >        r.assertValue(inc(v1));
1363      }}
1364  
1365      /**
# Line 1192 | Line 1380 | public class CompletableFutureTest exten
1380              f.completeExceptionally(ex);
1381          }
1382  
1383 <        checkCompletedWithWrappedCFException(g, ex);
1384 <        checkCompletedWithWrappedCFException(f, ex);
1383 >        checkCompletedWithWrappedException(g, ex);
1384 >        checkCompletedExceptionally(f, ex);
1385          r.assertNotInvoked();
1386      }}
1387  
# Line 1249 | Line 1437 | public class CompletableFutureTest exten
1437          for (Integer v1 : new Integer[] { 1, null })
1438      {
1439          final CompletableFuture<Integer> f = new CompletableFuture<>();
1440 <        final IncAction r = new IncAction(m);
1440 >        final NoopConsumer r = new NoopConsumer(m);
1441          if (!createIncomplete) f.complete(v1);
1442          final CompletableFuture<Void> g = m.thenAccept(f, r);
1443          if (createIncomplete) {
# Line 1258 | Line 1446 | public class CompletableFutureTest exten
1446          }
1447  
1448          checkCompletedNormally(g, null);
1449 +        r.assertValue(v1);
1450          checkCompletedNormally(f, v1);
1262        r.assertInvoked();
1263        r.assertValue(inc(v1));
1451      }}
1452  
1453      /**
# Line 1273 | Line 1460 | public class CompletableFutureTest exten
1460      {
1461          final CFException ex = new CFException();
1462          final CompletableFuture<Integer> f = new CompletableFuture<>();
1463 <        final IncAction r = new IncAction(m);
1463 >        final NoopConsumer r = new NoopConsumer(m);
1464          if (!createIncomplete) f.completeExceptionally(ex);
1465          final CompletableFuture<Void> g = m.thenAccept(f, r);
1466          if (createIncomplete) {
# Line 1281 | Line 1468 | public class CompletableFutureTest exten
1468              f.completeExceptionally(ex);
1469          }
1470  
1471 <        checkCompletedWithWrappedCFException(g, ex);
1472 <        checkCompletedWithWrappedCFException(f, ex);
1471 >        checkCompletedWithWrappedException(g, ex);
1472 >        checkCompletedExceptionally(f, ex);
1473          r.assertNotInvoked();
1474      }}
1475  
# Line 1295 | Line 1482 | public class CompletableFutureTest exten
1482          for (boolean mayInterruptIfRunning : new boolean[] { true, false })
1483      {
1484          final CompletableFuture<Integer> f = new CompletableFuture<>();
1485 <        final IncAction r = new IncAction(m);
1485 >        final NoopConsumer r = new NoopConsumer(m);
1486          if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
1487          final CompletableFuture<Void> g = m.thenAccept(f, r);
1488          if (createIncomplete) {
# Line 1357 | Line 1544 | public class CompletableFutureTest exten
1544          checkCompletedNormally(h, subtract(v1, v2));
1545          checkCompletedNormally(f, v1);
1546          checkCompletedNormally(g, v2);
1547 <        r.assertInvoked();
1547 >        r.assertValue(subtract(v1, v2));
1548      }}
1549  
1550      /**
# Line 1384 | Line 1571 | public class CompletableFutureTest exten
1571              (!fFirst ? f : g).completeExceptionally(ex);
1572          }
1573  
1574 <        checkCompletedWithWrappedCFException(h, ex);
1574 >        checkCompletedWithWrappedException(h, ex);
1575          r.assertNotInvoked();
1576          checkCompletedNormally(fFirst ? f : g, v1);
1577 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1577 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1578      }}
1579  
1580      /**
# Line 1501 | Line 1688 | public class CompletableFutureTest exten
1688              (!fFirst ? f : g).completeExceptionally(ex);
1689          }
1690  
1691 <        checkCompletedWithWrappedCFException(h, ex);
1691 >        checkCompletedWithWrappedException(h, ex);
1692          r.assertNotInvoked();
1693          checkCompletedNormally(fFirst ? f : g, v1);
1694 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1694 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1695      }}
1696  
1697      /**
# Line 1618 | Line 1805 | public class CompletableFutureTest exten
1805              (!fFirst ? f : g).completeExceptionally(ex);
1806          }
1807  
1808 <        checkCompletedWithWrappedCFException(h, ex);
1808 >        checkCompletedWithWrappedException(h, ex);
1809          r.assertNotInvoked();
1810          checkCompletedNormally(fFirst ? f : g, v1);
1811 <        checkCompletedWithWrappedCFException(!fFirst ? f : g, ex);
1811 >        checkCompletedExceptionally(!fFirst ? f : g, ex);
1812      }}
1813  
1814      /**
# Line 1638 | Line 1825 | public class CompletableFutureTest exten
1825          final CompletableFuture<Integer> g = new CompletableFuture<>();
1826          final Noop r = new Noop(m);
1827  
1641
1828          (fFirst ? f : g).complete(v1);
1829          if (!createIncomplete)
1830              assertTrue((!fFirst ? f : g).cancel(mayInterruptIfRunning));
# Line 1753 | Line 1939 | public class CompletableFutureTest exten
1939          rs[0].assertNotInvoked();
1940          rs[1].assertNotInvoked();
1941          f.completeExceptionally(ex);
1942 <        checkCompletedWithWrappedCFException(h0, ex);
1943 <        checkCompletedWithWrappedCFException(h1, ex);
1942 >        checkCompletedWithWrappedException(h0, ex);
1943 >        checkCompletedWithWrappedException(h1, ex);
1944          final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1945          final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
1946 <        checkCompletedWithWrappedCFException(h2, ex);
1947 <        checkCompletedWithWrappedCFException(h3, ex);
1946 >        checkCompletedWithWrappedException(h2, ex);
1947 >        checkCompletedWithWrappedException(h3, ex);
1948          g.complete(v1);
1949  
1950          // unspecified behavior - both source completions available
# Line 1766 | Line 1952 | public class CompletableFutureTest exten
1952          final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
1953          try {
1954              assertEquals(inc(v1), h4.join());
1955 <            rs[4].assertInvoked();
1955 >            rs[4].assertValue(inc(v1));
1956          } catch (CompletionException ok) {
1957 <            checkCompletedWithWrappedCFException(h4, ex);
1957 >            checkCompletedWithWrappedException(h4, ex);
1958              rs[4].assertNotInvoked();
1959          }
1960          try {
1961              assertEquals(inc(v1), h5.join());
1962 <            rs[5].assertInvoked();
1962 >            rs[5].assertValue(inc(v1));
1963          } catch (CompletionException ok) {
1964 <            checkCompletedWithWrappedCFException(h5, ex);
1964 >            checkCompletedWithWrappedException(h5, ex);
1965              rs[5].assertNotInvoked();
1966          }
1967  
1968 <        checkCompletedWithWrappedCFException(f, ex);
1968 >        checkCompletedExceptionally(f, ex);
1969          checkCompletedNormally(g, v1);
1970 <        checkCompletedWithWrappedCFException(h0, ex);
1971 <        checkCompletedWithWrappedCFException(h1, ex);
1972 <        checkCompletedWithWrappedCFException(h2, ex);
1973 <        checkCompletedWithWrappedCFException(h3, ex);
1974 <        checkCompletedWithWrappedCFException(h4, ex);
1970 >        checkCompletedWithWrappedException(h0, ex);
1971 >        checkCompletedWithWrappedException(h1, ex);
1972 >        checkCompletedWithWrappedException(h2, ex);
1973 >        checkCompletedWithWrappedException(h3, ex);
1974 >        checkCompletedWithWrappedException(h4, ex);
1975          for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
1976      }}
1977  
1978 +    public void testApplyToEither_exceptionalCompletion2() {
1979 +        for (ExecutionMode m : ExecutionMode.values())
1980 +        for (boolean fFirst : new boolean[] { true, false })
1981 +        for (Integer v1 : new Integer[] { 1, null })
1982 +    {
1983 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
1984 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
1985 +        final CFException ex = new CFException();
1986 +        final IncFunction[] rs = new IncFunction[6];
1987 +        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
1988 +
1989 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
1990 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
1991 +        if (fFirst) {
1992 +            f.complete(v1);
1993 +            g.completeExceptionally(ex);
1994 +        } else {
1995 +            g.completeExceptionally(ex);
1996 +            f.complete(v1);
1997 +        }
1998 +        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
1999 +        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2000 +
2001 +        // unspecified behavior - both source completions available
2002 +        try {
2003 +            assertEquals(inc(v1), h0.join());
2004 +            rs[0].assertValue(inc(v1));
2005 +        } catch (CompletionException ok) {
2006 +            checkCompletedWithWrappedException(h0, ex);
2007 +            rs[0].assertNotInvoked();
2008 +        }
2009 +        try {
2010 +            assertEquals(inc(v1), h1.join());
2011 +            rs[1].assertValue(inc(v1));
2012 +        } catch (CompletionException ok) {
2013 +            checkCompletedWithWrappedException(h1, ex);
2014 +            rs[1].assertNotInvoked();
2015 +        }
2016 +        try {
2017 +            assertEquals(inc(v1), h2.join());
2018 +            rs[2].assertValue(inc(v1));
2019 +        } catch (CompletionException ok) {
2020 +            checkCompletedWithWrappedException(h2, ex);
2021 +            rs[2].assertNotInvoked();
2022 +        }
2023 +        try {
2024 +            assertEquals(inc(v1), h3.join());
2025 +            rs[3].assertValue(inc(v1));
2026 +        } catch (CompletionException ok) {
2027 +            checkCompletedWithWrappedException(h3, ex);
2028 +            rs[3].assertNotInvoked();
2029 +        }
2030 +
2031 +        checkCompletedNormally(f, v1);
2032 +        checkCompletedExceptionally(g, ex);
2033 +    }}
2034 +
2035      /**
2036       * applyToEither result completes exceptionally if either source cancelled
2037       */
# Line 1822 | Line 2065 | public class CompletableFutureTest exten
2065          final CompletableFuture<Integer> h5 = m.applyToEither(g, f, rs[5]);
2066          try {
2067              assertEquals(inc(v1), h4.join());
2068 <            rs[4].assertInvoked();
2068 >            rs[4].assertValue(inc(v1));
2069          } catch (CompletionException ok) {
2070              checkCompletedWithWrappedCancellationException(h4);
2071              rs[4].assertNotInvoked();
2072          }
2073          try {
2074              assertEquals(inc(v1), h5.join());
2075 <            rs[5].assertInvoked();
2075 >            rs[5].assertValue(inc(v1));
2076          } catch (CompletionException ok) {
2077              checkCompletedWithWrappedCancellationException(h5);
2078              rs[5].assertNotInvoked();
# Line 1844 | Line 2087 | public class CompletableFutureTest exten
2087          for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2088      }}
2089  
2090 +    public void testApplyToEither_sourceCancelled2() {
2091 +        for (ExecutionMode m : ExecutionMode.values())
2092 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2093 +        for (boolean fFirst : new boolean[] { true, false })
2094 +        for (Integer v1 : new Integer[] { 1, null })
2095 +    {
2096 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
2097 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
2098 +        final IncFunction[] rs = new IncFunction[6];
2099 +        for (int i = 0; i < rs.length; i++) rs[i] = new IncFunction(m);
2100 +
2101 +        final CompletableFuture<Integer> h0 = m.applyToEither(f, g, rs[0]);
2102 +        final CompletableFuture<Integer> h1 = m.applyToEither(g, f, rs[1]);
2103 +        if (fFirst) {
2104 +            f.complete(v1);
2105 +            g.cancel(mayInterruptIfRunning);
2106 +        } else {
2107 +            g.cancel(mayInterruptIfRunning);
2108 +            f.complete(v1);
2109 +        }
2110 +        final CompletableFuture<Integer> h2 = m.applyToEither(f, g, rs[2]);
2111 +        final CompletableFuture<Integer> h3 = m.applyToEither(g, f, rs[3]);
2112 +
2113 +        // unspecified behavior - both source completions available
2114 +        try {
2115 +            assertEquals(inc(v1), h0.join());
2116 +            rs[0].assertValue(inc(v1));
2117 +        } catch (CompletionException ok) {
2118 +            checkCompletedWithWrappedCancellationException(h0);
2119 +            rs[0].assertNotInvoked();
2120 +        }
2121 +        try {
2122 +            assertEquals(inc(v1), h1.join());
2123 +            rs[1].assertValue(inc(v1));
2124 +        } catch (CompletionException ok) {
2125 +            checkCompletedWithWrappedCancellationException(h1);
2126 +            rs[1].assertNotInvoked();
2127 +        }
2128 +        try {
2129 +            assertEquals(inc(v1), h2.join());
2130 +            rs[2].assertValue(inc(v1));
2131 +        } catch (CompletionException ok) {
2132 +            checkCompletedWithWrappedCancellationException(h2);
2133 +            rs[2].assertNotInvoked();
2134 +        }
2135 +        try {
2136 +            assertEquals(inc(v1), h3.join());
2137 +            rs[3].assertValue(inc(v1));
2138 +        } catch (CompletionException ok) {
2139 +            checkCompletedWithWrappedCancellationException(h3);
2140 +            rs[3].assertNotInvoked();
2141 +        }
2142 +
2143 +        checkCompletedNormally(f, v1);
2144 +        checkCancelled(g);
2145 +    }}
2146 +
2147      /**
2148       * applyToEither result completes exceptionally if action does
2149       */
# Line 1896 | Line 2196 | public class CompletableFutureTest exten
2196      {
2197          final CompletableFuture<Integer> f = new CompletableFuture<>();
2198          final CompletableFuture<Integer> g = new CompletableFuture<>();
2199 <        final IncAction[] rs = new IncAction[6];
2200 <        for (int i = 0; i < rs.length; i++) rs[i] = new IncAction(m);
2199 >        final NoopConsumer[] rs = new NoopConsumer[6];
2200 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2201  
2202          final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2203          final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
# Line 1908 | Line 2208 | public class CompletableFutureTest exten
2208          f.complete(v1);
2209          checkCompletedNormally(h0, null);
2210          checkCompletedNormally(h1, null);
2211 <        rs[0].assertValue(inc(v1));
2212 <        rs[1].assertValue(inc(v1));
2211 >        rs[0].assertValue(v1);
2212 >        rs[1].assertValue(v1);
2213          final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2214          final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2215          checkCompletedNormally(h2, null);
2216          checkCompletedNormally(h3, null);
2217 <        rs[2].assertValue(inc(v1));
2218 <        rs[3].assertValue(inc(v1));
2217 >        rs[2].assertValue(v1);
2218 >        rs[3].assertValue(v1);
2219          g.complete(v2);
2220  
2221          // unspecified behavior - both source completions available
# Line 1923 | Line 2223 | public class CompletableFutureTest exten
2223          final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2224          checkCompletedNormally(h4, null);
2225          checkCompletedNormally(h5, null);
2226 <        assertTrue(Objects.equals(inc(v1), rs[4].value) ||
2227 <                   Objects.equals(inc(v2), rs[4].value));
2228 <        assertTrue(Objects.equals(inc(v1), rs[5].value) ||
2229 <                   Objects.equals(inc(v2), rs[5].value));
2226 >        assertTrue(Objects.equals(v1, rs[4].value) ||
2227 >                   Objects.equals(v2, rs[4].value));
2228 >        assertTrue(Objects.equals(v1, rs[5].value) ||
2229 >                   Objects.equals(v2, rs[5].value));
2230  
2231          checkCompletedNormally(f, v1);
2232          checkCompletedNormally(g, v2);
# Line 1934 | Line 2234 | public class CompletableFutureTest exten
2234          checkCompletedNormally(h1, null);
2235          checkCompletedNormally(h2, null);
2236          checkCompletedNormally(h3, null);
2237 <        for (int i = 0; i < 4; i++) rs[i].assertValue(inc(v1));
2237 >        for (int i = 0; i < 4; i++) rs[i].assertValue(v1);
2238      }}
2239  
2240      /**
# Line 1948 | Line 2248 | public class CompletableFutureTest exten
2248          final CompletableFuture<Integer> f = new CompletableFuture<>();
2249          final CompletableFuture<Integer> g = new CompletableFuture<>();
2250          final CFException ex = new CFException();
2251 <        final IncAction[] rs = new IncAction[6];
2252 <        for (int i = 0; i < rs.length; i++) rs[i] = new IncAction(m);
2251 >        final NoopConsumer[] rs = new NoopConsumer[6];
2252 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2253  
2254          final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2255          final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
# Line 1958 | Line 2258 | public class CompletableFutureTest exten
2258          rs[0].assertNotInvoked();
2259          rs[1].assertNotInvoked();
2260          f.completeExceptionally(ex);
2261 <        checkCompletedWithWrappedCFException(h0, ex);
2262 <        checkCompletedWithWrappedCFException(h1, ex);
2261 >        checkCompletedWithWrappedException(h0, ex);
2262 >        checkCompletedWithWrappedException(h1, ex);
2263          final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2264          final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2265 <        checkCompletedWithWrappedCFException(h2, ex);
2266 <        checkCompletedWithWrappedCFException(h3, ex);
2265 >        checkCompletedWithWrappedException(h2, ex);
2266 >        checkCompletedWithWrappedException(h3, ex);
2267  
2268          g.complete(v1);
2269  
# Line 1972 | Line 2272 | public class CompletableFutureTest exten
2272          final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2273          try {
2274              assertNull(h4.join());
2275 <            rs[4].assertValue(inc(v1));
2275 >            rs[4].assertValue(v1);
2276          } catch (CompletionException ok) {
2277 <            checkCompletedWithWrappedCFException(h4, ex);
2277 >            checkCompletedWithWrappedException(h4, ex);
2278              rs[4].assertNotInvoked();
2279          }
2280          try {
2281              assertNull(h5.join());
2282 <            rs[5].assertValue(inc(v1));
2282 >            rs[5].assertValue(v1);
2283          } catch (CompletionException ok) {
2284 <            checkCompletedWithWrappedCFException(h5, ex);
2284 >            checkCompletedWithWrappedException(h5, ex);
2285              rs[5].assertNotInvoked();
2286          }
2287  
2288 <        checkCompletedWithWrappedCFException(f, ex);
2288 >        checkCompletedExceptionally(f, ex);
2289          checkCompletedNormally(g, v1);
2290 <        checkCompletedWithWrappedCFException(h0, ex);
2291 <        checkCompletedWithWrappedCFException(h1, ex);
2292 <        checkCompletedWithWrappedCFException(h2, ex);
2293 <        checkCompletedWithWrappedCFException(h3, ex);
2294 <        checkCompletedWithWrappedCFException(h4, ex);
2290 >        checkCompletedWithWrappedException(h0, ex);
2291 >        checkCompletedWithWrappedException(h1, ex);
2292 >        checkCompletedWithWrappedException(h2, ex);
2293 >        checkCompletedWithWrappedException(h3, ex);
2294 >        checkCompletedWithWrappedException(h4, ex);
2295          for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2296      }}
2297  
2298 +    public void testAcceptEither_exceptionalCompletion2() {
2299 +        for (ExecutionMode m : ExecutionMode.values())
2300 +        for (boolean fFirst : new boolean[] { true, false })
2301 +        for (Integer v1 : new Integer[] { 1, null })
2302 +    {
2303 +        final CompletableFuture<Integer> f = new CompletableFuture<>();
2304 +        final CompletableFuture<Integer> g = new CompletableFuture<>();
2305 +        final CFException ex = new CFException();
2306 +        final NoopConsumer[] rs = new NoopConsumer[6];
2307 +        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2308 +
2309 +        final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2310 +        final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
2311 +        if (fFirst) {
2312 +            f.complete(v1);
2313 +            g.completeExceptionally(ex);
2314 +        } else {
2315 +            g.completeExceptionally(ex);
2316 +            f.complete(v1);
2317 +        }
2318 +        final CompletableFuture<Void> h2 = m.acceptEither(f, g, rs[2]);
2319 +        final CompletableFuture<Void> h3 = m.acceptEither(g, f, rs[3]);
2320 +
2321 +        // unspecified behavior - both source completions available
2322 +        try {
2323 +            assertEquals(null, h0.join());
2324 +            rs[0].assertValue(v1);
2325 +        } catch (CompletionException ok) {
2326 +            checkCompletedWithWrappedException(h0, ex);
2327 +            rs[0].assertNotInvoked();
2328 +        }
2329 +        try {
2330 +            assertEquals(null, h1.join());
2331 +            rs[1].assertValue(v1);
2332 +        } catch (CompletionException ok) {
2333 +            checkCompletedWithWrappedException(h1, ex);
2334 +            rs[1].assertNotInvoked();
2335 +        }
2336 +        try {
2337 +            assertEquals(null, h2.join());
2338 +            rs[2].assertValue(v1);
2339 +        } catch (CompletionException ok) {
2340 +            checkCompletedWithWrappedException(h2, ex);
2341 +            rs[2].assertNotInvoked();
2342 +        }
2343 +        try {
2344 +            assertEquals(null, h3.join());
2345 +            rs[3].assertValue(v1);
2346 +        } catch (CompletionException ok) {
2347 +            checkCompletedWithWrappedException(h3, ex);
2348 +            rs[3].assertNotInvoked();
2349 +        }
2350 +
2351 +        checkCompletedNormally(f, v1);
2352 +        checkCompletedExceptionally(g, ex);
2353 +    }}
2354 +
2355      /**
2356       * acceptEither result completes exceptionally if either source cancelled
2357       */
# Line 2005 | Line 2362 | public class CompletableFutureTest exten
2362      {
2363          final CompletableFuture<Integer> f = new CompletableFuture<>();
2364          final CompletableFuture<Integer> g = new CompletableFuture<>();
2365 <        final IncAction[] rs = new IncAction[6];
2366 <        for (int i = 0; i < rs.length; i++) rs[i] = new IncAction(m);
2365 >        final NoopConsumer[] rs = new NoopConsumer[6];
2366 >        for (int i = 0; i < rs.length; i++) rs[i] = new NoopConsumer(m);
2367  
2368          final CompletableFuture<Void> h0 = m.acceptEither(f, g, rs[0]);
2369          final CompletableFuture<Void> h1 = m.acceptEither(g, f, rs[1]);
# Line 2029 | Line 2386 | public class CompletableFutureTest exten
2386          final CompletableFuture<Void> h5 = m.acceptEither(g, f, rs[5]);
2387          try {
2388              assertNull(h4.join());
2389 <            rs[4].assertValue(inc(v1));
2389 >            rs[4].assertValue(v1);
2390          } catch (CompletionException ok) {
2391              checkCompletedWithWrappedCancellationException(h4);
2392              rs[4].assertNotInvoked();
2393          }
2394          try {
2395              assertNull(h5.join());
2396 <            rs[5].assertValue(inc(v1));
2396 >            rs[5].assertValue(v1);
2397          } catch (CompletionException ok) {
2398              checkCompletedWithWrappedCancellationException(h5);
2399              rs[5].assertNotInvoked();
# Line 2096 | Line 2453 | public class CompletableFutureTest exten
2453       * runAfterEither result completes normally after normal completion
2454       * of either source
2455       */
2456 <    public void testRunAfterEither_normalCompletion1() {
2456 >    public void testRunAfterEither_normalCompletion() {
2457          for (ExecutionMode m : ExecutionMode.values())
2458          for (Integer v1 : new Integer[] { 1, null })
2459          for (Integer v2 : new Integer[] { 2, null })
2460      {
2461          final CompletableFuture<Integer> f = new CompletableFuture<>();
2462          final CompletableFuture<Integer> g = new CompletableFuture<>();
2463 <        final Noop r = new Noop(m);
2464 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2463 >        final Noop[] rs = new Noop[6];
2464 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2465  
2466 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2467 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2468 +        checkIncomplete(h0);
2469 +        checkIncomplete(h1);
2470 +        rs[0].assertNotInvoked();
2471 +        rs[1].assertNotInvoked();
2472          f.complete(v1);
2473 <        checkCompletedNormally(h, null);
2474 <        r.assertInvoked();
2475 <        g.complete(v2);
2476 <
2477 <        checkCompletedNormally(f, v1);
2478 <        checkCompletedNormally(g, v2);
2479 <        checkCompletedNormally(h, null);
2480 <        r.assertInvoked();
2481 <    }}
2482 <
2120 <    public void testRunAfterEither_normalCompletion2() {
2121 <        for (ExecutionMode m : ExecutionMode.values())
2122 <        for (Integer v1 : new Integer[] { 1, null })
2123 <        for (Integer v2 : new Integer[] { 2, null })
2124 <    {
2125 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2126 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2127 <        final Noop r = new Noop(m);
2128 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2473 >        checkCompletedNormally(h0, null);
2474 >        checkCompletedNormally(h1, null);
2475 >        rs[0].assertInvoked();
2476 >        rs[1].assertInvoked();
2477 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2478 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2479 >        checkCompletedNormally(h2, null);
2480 >        checkCompletedNormally(h3, null);
2481 >        rs[2].assertInvoked();
2482 >        rs[3].assertInvoked();
2483  
2484          g.complete(v2);
2131        checkCompletedNormally(h, null);
2132        r.assertInvoked();
2133        f.complete(v1);
2485  
2486 <        checkCompletedNormally(f, v1);
2487 <        checkCompletedNormally(g, v2);
2137 <        checkCompletedNormally(h, null);
2138 <        r.assertInvoked();
2139 <        }}
2140 <
2141 <    public void testRunAfterEither_normalCompletion3() {
2142 <        for (ExecutionMode m : ExecutionMode.values())
2143 <        for (Integer v1 : new Integer[] { 1, null })
2144 <        for (Integer v2 : new Integer[] { 2, null })
2145 <    {
2146 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2147 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2148 <        final Noop r = new Noop(m);
2149 <
2150 <        f.complete(v1);
2151 <        g.complete(v2);
2152 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2486 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2487 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2488  
2154        checkCompletedNormally(h, null);
2489          checkCompletedNormally(f, v1);
2490          checkCompletedNormally(g, v2);
2491 <        r.assertInvoked();
2491 >        checkCompletedNormally(h0, null);
2492 >        checkCompletedNormally(h1, null);
2493 >        checkCompletedNormally(h2, null);
2494 >        checkCompletedNormally(h3, null);
2495 >        checkCompletedNormally(h4, null);
2496 >        checkCompletedNormally(h5, null);
2497 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2498      }}
2499  
2500      /**
2501       * runAfterEither result completes exceptionally after exceptional
2502       * completion of either source
2503       */
2504 <    public void testRunAfterEither_exceptionalCompletion1() {
2504 >    public void testRunAfterEither_exceptionalCompletion() {
2505          for (ExecutionMode m : ExecutionMode.values())
2506          for (Integer v1 : new Integer[] { 1, null })
2507      {
2508          final CompletableFuture<Integer> f = new CompletableFuture<>();
2509          final CompletableFuture<Integer> g = new CompletableFuture<>();
2170        final Noop r = new Noop(m);
2171        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2510          final CFException ex = new CFException();
2511 +        final Noop[] rs = new Noop[6];
2512 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2513  
2514 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2515 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2516 +        checkIncomplete(h0);
2517 +        checkIncomplete(h1);
2518 +        rs[0].assertNotInvoked();
2519 +        rs[1].assertNotInvoked();
2520          f.completeExceptionally(ex);
2521 <        checkCompletedWithWrappedCFException(h, ex);
2521 >        checkCompletedWithWrappedException(h0, ex);
2522 >        checkCompletedWithWrappedException(h1, ex);
2523 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2524 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2525 >        checkCompletedWithWrappedException(h2, ex);
2526 >        checkCompletedWithWrappedException(h3, ex);
2527 >
2528          g.complete(v1);
2529  
2530 <        r.assertNotInvoked();
2530 >        // unspecified behavior - both source completions available
2531 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2532 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2533 >        try {
2534 >            assertNull(h4.join());
2535 >            rs[4].assertInvoked();
2536 >        } catch (CompletionException ok) {
2537 >            checkCompletedWithWrappedException(h4, ex);
2538 >            rs[4].assertNotInvoked();
2539 >        }
2540 >        try {
2541 >            assertNull(h5.join());
2542 >            rs[5].assertInvoked();
2543 >        } catch (CompletionException ok) {
2544 >            checkCompletedWithWrappedException(h5, ex);
2545 >            rs[5].assertNotInvoked();
2546 >        }
2547 >
2548 >        checkCompletedExceptionally(f, ex);
2549          checkCompletedNormally(g, v1);
2550 <        checkCompletedWithWrappedCFException(f, ex);
2551 <        checkCompletedWithWrappedCFException(h, ex);
2550 >        checkCompletedWithWrappedException(h0, ex);
2551 >        checkCompletedWithWrappedException(h1, ex);
2552 >        checkCompletedWithWrappedException(h2, ex);
2553 >        checkCompletedWithWrappedException(h3, ex);
2554 >        checkCompletedWithWrappedException(h4, ex);
2555 >        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2556      }}
2557  
2558      public void testRunAfterEither_exceptionalCompletion2() {
2559          for (ExecutionMode m : ExecutionMode.values())
2560 +        for (boolean fFirst : new boolean[] { true, false })
2561          for (Integer v1 : new Integer[] { 1, null })
2562      {
2563          final CompletableFuture<Integer> f = new CompletableFuture<>();
2564          final CompletableFuture<Integer> g = new CompletableFuture<>();
2190        final Noop r = new Noop(m);
2191        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2192        final CFException ex = new CFException();
2193
2194        g.completeExceptionally(ex);
2195        checkCompletedWithWrappedCFException(h, ex);
2196        f.complete(v1);
2197
2198        r.assertNotInvoked();
2199        checkCompletedNormally(f, v1);
2200        checkCompletedWithWrappedCFException(g, ex);
2201        checkCompletedWithWrappedCFException(h, ex);
2202    }}
2203
2204    public void testRunAfterEither_exceptionalCompletion3() {
2205        for (ExecutionMode m : ExecutionMode.values())
2206        for (Integer v1 : new Integer[] { 1, null })
2207    {
2208        final CompletableFuture<Integer> f = new CompletableFuture<>();
2209        final CompletableFuture<Integer> g = new CompletableFuture<>();
2210        final Noop r = new Noop(m);
2565          final CFException ex = new CFException();
2566 +        final Noop[] rs = new Noop[6];
2567 +        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2568  
2569 <        g.completeExceptionally(ex);
2570 <        f.complete(v1);
2571 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2569 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2570 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2571 >        if (fFirst) {
2572 >            f.complete(v1);
2573 >            g.completeExceptionally(ex);
2574 >        } else {
2575 >            g.completeExceptionally(ex);
2576 >            f.complete(v1);
2577 >        }
2578 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2579 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2580  
2581 <        // unspecified behavior
2218 <        Integer v;
2581 >        // unspecified behavior - both source completions available
2582          try {
2583 <            assertNull(h.join());
2584 <            r.assertInvoked();
2583 >            assertEquals(null, h0.join());
2584 >            rs[0].assertInvoked();
2585          } catch (CompletionException ok) {
2586 <            checkCompletedWithWrappedCFException(h, ex);
2587 <            r.assertNotInvoked();
2586 >            checkCompletedWithWrappedException(h0, ex);
2587 >            rs[0].assertNotInvoked();
2588 >        }
2589 >        try {
2590 >            assertEquals(null, h1.join());
2591 >            rs[1].assertInvoked();
2592 >        } catch (CompletionException ok) {
2593 >            checkCompletedWithWrappedException(h1, ex);
2594 >            rs[1].assertNotInvoked();
2595 >        }
2596 >        try {
2597 >            assertEquals(null, h2.join());
2598 >            rs[2].assertInvoked();
2599 >        } catch (CompletionException ok) {
2600 >            checkCompletedWithWrappedException(h2, ex);
2601 >            rs[2].assertNotInvoked();
2602 >        }
2603 >        try {
2604 >            assertEquals(null, h3.join());
2605 >            rs[3].assertInvoked();
2606 >        } catch (CompletionException ok) {
2607 >            checkCompletedWithWrappedException(h3, ex);
2608 >            rs[3].assertNotInvoked();
2609          }
2610  
2227        checkCompletedWithWrappedCFException(g, ex);
2611          checkCompletedNormally(f, v1);
2612 +        checkCompletedExceptionally(g, ex);
2613      }}
2614  
2615 <    public void testRunAfterEither_exceptionalCompletion4() {
2615 >    /**
2616 >     * runAfterEither result completes exceptionally if either source cancelled
2617 >     */
2618 >    public void testRunAfterEither_sourceCancelled() {
2619          for (ExecutionMode m : ExecutionMode.values())
2620 +        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2621          for (Integer v1 : new Integer[] { 1, null })
2622      {
2623          final CompletableFuture<Integer> f = new CompletableFuture<>();
2624          final CompletableFuture<Integer> g = new CompletableFuture<>();
2625 <        final Noop r = new Noop(m);
2626 <        final CFException ex = new CFException();
2625 >        final Noop[] rs = new Noop[6];
2626 >        for (int i = 0; i < rs.length; i++) rs[i] = new Noop(m);
2627 >
2628 >        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2629 >        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2630 >        checkIncomplete(h0);
2631 >        checkIncomplete(h1);
2632 >        rs[0].assertNotInvoked();
2633 >        rs[1].assertNotInvoked();
2634 >        f.cancel(mayInterruptIfRunning);
2635 >        checkCompletedWithWrappedCancellationException(h0);
2636 >        checkCompletedWithWrappedCancellationException(h1);
2637 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2638 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2639 >        checkCompletedWithWrappedCancellationException(h2);
2640 >        checkCompletedWithWrappedCancellationException(h3);
2641  
2240        f.completeExceptionally(ex);
2642          g.complete(v1);
2242        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2643  
2644 <        // unspecified behavior
2645 <        Integer v;
2644 >        // unspecified behavior - both source completions available
2645 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2646 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2647 >        try {
2648 >            assertNull(h4.join());
2649 >            rs[4].assertInvoked();
2650 >        } catch (CompletionException ok) {
2651 >            checkCompletedWithWrappedCancellationException(h4);
2652 >            rs[4].assertNotInvoked();
2653 >        }
2654          try {
2655 <            assertNull(h.join());
2656 <            r.assertInvoked();
2655 >            assertNull(h5.join());
2656 >            rs[5].assertInvoked();
2657          } catch (CompletionException ok) {
2658 <            checkCompletedWithWrappedCFException(h, ex);
2659 <            r.assertNotInvoked();
2658 >            checkCompletedWithWrappedCancellationException(h5);
2659 >            rs[5].assertNotInvoked();
2660          }
2661  
2662 <        checkCompletedWithWrappedCFException(f, ex);
2662 >        checkCancelled(f);
2663          checkCompletedNormally(g, v1);
2664 +        checkCompletedWithWrappedCancellationException(h0);
2665 +        checkCompletedWithWrappedCancellationException(h1);
2666 +        checkCompletedWithWrappedCancellationException(h2);
2667 +        checkCompletedWithWrappedCancellationException(h3);
2668 +        for (int i = 0; i < 4; i++) rs[i].assertNotInvoked();
2669      }}
2670  
2671      /**
2672       * runAfterEither result completes exceptionally if action does
2673       */
2674 <    public void testRunAfterEither_actionFailed1() {
2674 >    public void testRunAfterEither_actionFailed() {
2675          for (ExecutionMode m : ExecutionMode.values())
2676          for (Integer v1 : new Integer[] { 1, null })
2677          for (Integer v2 : new Integer[] { 2, null })
2678      {
2679          final CompletableFuture<Integer> f = new CompletableFuture<>();
2680          final CompletableFuture<Integer> g = new CompletableFuture<>();
2681 <        final FailingRunnable r = new FailingRunnable(m);
2682 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2681 >        final FailingRunnable[] rs = new FailingRunnable[6];
2682 >        for (int i = 0; i < rs.length; i++) rs[i] = new FailingRunnable(m);
2683  
2684 +        final CompletableFuture<Void> h0 = m.runAfterEither(f, g, rs[0]);
2685 +        final CompletableFuture<Void> h1 = m.runAfterEither(g, f, rs[1]);
2686          f.complete(v1);
2687 <        checkCompletedWithWrappedCFException(h);
2687 >        final CompletableFuture<Void> h2 = m.runAfterEither(f, g, rs[2]);
2688 >        final CompletableFuture<Void> h3 = m.runAfterEither(g, f, rs[3]);
2689 >        checkCompletedWithWrappedCFException(h0);
2690 >        checkCompletedWithWrappedCFException(h1);
2691 >        checkCompletedWithWrappedCFException(h2);
2692 >        checkCompletedWithWrappedCFException(h3);
2693 >        for (int i = 0; i < 4; i++) rs[i].assertInvoked();
2694          g.complete(v2);
2695 <        checkCompletedNormally(f, v1);
2696 <        checkCompletedNormally(g, v2);
2697 <    }}
2698 <
2278 <    public void testRunAfterEither_actionFailed2() {
2279 <        for (ExecutionMode m : ExecutionMode.values())
2280 <        for (Integer v1 : new Integer[] { 1, null })
2281 <        for (Integer v2 : new Integer[] { 2, null })
2282 <    {
2283 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2284 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2285 <        final FailingRunnable r = new FailingRunnable(m);
2286 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2695 >        final CompletableFuture<Void> h4 = m.runAfterEither(f, g, rs[4]);
2696 >        final CompletableFuture<Void> h5 = m.runAfterEither(g, f, rs[5]);
2697 >        checkCompletedWithWrappedCFException(h4);
2698 >        checkCompletedWithWrappedCFException(h5);
2699  
2288        g.complete(v2);
2289        checkCompletedWithWrappedCFException(h);
2290        f.complete(v1);
2700          checkCompletedNormally(f, v1);
2701          checkCompletedNormally(g, v2);
2702 <    }}
2294 <
2295 <    /**
2296 <     * runAfterEither result completes exceptionally if either source cancelled
2297 <     */
2298 <    public void testRunAfterEither_sourceCancelled1() {
2299 <        for (ExecutionMode m : ExecutionMode.values())
2300 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2301 <        for (Integer v1 : new Integer[] { 1, null })
2302 <    {
2303 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2304 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2305 <        final Noop r = new Noop(m);
2306 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2307 <
2308 <        assertTrue(f.cancel(mayInterruptIfRunning));
2309 <        checkCompletedWithWrappedCancellationException(h);
2310 <        g.complete(v1);
2311 <
2312 <        checkCancelled(f);
2313 <        r.assertNotInvoked();
2314 <        checkCompletedNormally(g, v1);
2315 <        checkCompletedWithWrappedCancellationException(h);
2316 <    }}
2317 <
2318 <    public void testRunAfterEither_sourceCancelled2() {
2319 <        for (ExecutionMode m : ExecutionMode.values())
2320 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2321 <        for (Integer v1 : new Integer[] { 1, null })
2322 <    {
2323 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2324 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2325 <        final Noop r = new Noop(m);
2326 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2327 <
2328 <        assertTrue(g.cancel(mayInterruptIfRunning));
2329 <        checkCompletedWithWrappedCancellationException(h);
2330 <        f.complete(v1);
2331 <
2332 <        checkCancelled(g);
2333 <        r.assertNotInvoked();
2334 <        checkCompletedNormally(f, v1);
2335 <        checkCompletedWithWrappedCancellationException(h);
2336 <    }}
2337 <
2338 <    public void testRunAfterEither_sourceCancelled3() {
2339 <        for (ExecutionMode m : ExecutionMode.values())
2340 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2341 <        for (Integer v1 : new Integer[] { 1, null })
2342 <    {
2343 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2344 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2345 <        final Noop r = new Noop(m);
2346 <
2347 <        assertTrue(g.cancel(mayInterruptIfRunning));
2348 <        f.complete(v1);
2349 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2350 <
2351 <        // unspecified behavior
2352 <        Integer v;
2353 <        try {
2354 <            assertNull(h.join());
2355 <            r.assertInvoked();
2356 <        } catch (CompletionException ok) {
2357 <            checkCompletedWithWrappedCancellationException(h);
2358 <            r.assertNotInvoked();
2359 <        }
2360 <
2361 <        checkCancelled(g);
2362 <        checkCompletedNormally(f, v1);
2363 <    }}
2364 <
2365 <    public void testRunAfterEither_sourceCancelled4() {
2366 <        for (ExecutionMode m : ExecutionMode.values())
2367 <        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2368 <        for (Integer v1 : new Integer[] { 1, null })
2369 <    {
2370 <        final CompletableFuture<Integer> f = new CompletableFuture<>();
2371 <        final CompletableFuture<Integer> g = new CompletableFuture<>();
2372 <        final Noop r = new Noop(m);
2373 <
2374 <        assertTrue(f.cancel(mayInterruptIfRunning));
2375 <        g.complete(v1);
2376 <        final CompletableFuture<Void> h = m.runAfterEither(f, g, r);
2377 <
2378 <        // unspecified behavior
2379 <        Integer v;
2380 <        try {
2381 <            assertNull(h.join());
2382 <            r.assertInvoked();
2383 <        } catch (CompletionException ok) {
2384 <            checkCompletedWithWrappedCancellationException(h);
2385 <            r.assertNotInvoked();
2386 <        }
2387 <
2388 <        checkCancelled(f);
2389 <        checkCompletedNormally(g, v1);
2702 >        for (int i = 0; i < 6; i++) rs[i].assertInvoked();
2703      }}
2704  
2705      /**
# Line 2405 | Line 2718 | public class CompletableFutureTest exten
2718  
2719          checkCompletedNormally(g, inc(v1));
2720          checkCompletedNormally(f, v1);
2721 <        r.assertInvoked();
2721 >        r.assertValue(v1);
2722      }}
2723  
2724      /**
# Line 2423 | Line 2736 | public class CompletableFutureTest exten
2736          final CompletableFuture<Integer> g = m.thenCompose(f, r);
2737          if (createIncomplete) f.completeExceptionally(ex);
2738  
2739 <        checkCompletedWithWrappedCFException(g, ex);
2740 <        checkCompletedWithWrappedCFException(f, ex);
2739 >        checkCompletedWithWrappedException(g, ex);
2740 >        checkCompletedExceptionally(f, ex);
2741          r.assertNotInvoked();
2742      }}
2743  
# Line 2680 | Line 2993 | public class CompletableFutureTest exten
2993          assertSame(f, f.toCompletableFuture());
2994      }
2995  
2683    /**
2684     * whenComplete action executes on normal completion, propagating
2685     * source result.
2686     */
2687    public void testWhenComplete_normalCompletion1() {
2688        for (ExecutionMode m : ExecutionMode.values())
2689        for (boolean createIncomplete : new boolean[] { true, false })
2690        for (Integer v1 : new Integer[] { 1, null })
2691    {
2692        final AtomicInteger a = new AtomicInteger(0);
2693        final CompletableFuture<Integer> f = new CompletableFuture<>();
2694        if (!createIncomplete) f.complete(v1);
2695        final CompletableFuture<Integer> g = m.whenComplete
2696            (f,
2697             (Integer x, Throwable t) -> {
2698                threadAssertSame(x, v1);
2699                threadAssertNull(t);
2700                a.getAndIncrement();
2701            });
2702        if (createIncomplete) f.complete(v1);
2703
2704        checkCompletedNormally(g, v1);
2705        checkCompletedNormally(f, v1);
2706        assertEquals(1, a.get());
2707    }}
2708
2709    /**
2710     * whenComplete action executes on exceptional completion, propagating
2711     * source result.
2712     */
2713    public void testWhenComplete_exceptionalCompletion() {
2714        for (ExecutionMode m : ExecutionMode.values())
2715        for (boolean createIncomplete : new boolean[] { true, false })
2716        for (Integer v1 : new Integer[] { 1, null })
2717    {
2718        final AtomicInteger a = new AtomicInteger(0);
2719        final CFException ex = new CFException();
2720        final CompletableFuture<Integer> f = new CompletableFuture<>();
2721        if (!createIncomplete) f.completeExceptionally(ex);
2722        final CompletableFuture<Integer> g = m.whenComplete
2723            (f,
2724             (Integer x, Throwable t) -> {
2725                threadAssertNull(x);
2726                threadAssertSame(t, ex);
2727                a.getAndIncrement();
2728            });
2729        if (createIncomplete) f.completeExceptionally(ex);
2730        checkCompletedWithWrappedCFException(f, ex);
2731        checkCompletedWithWrappedCFException(g, ex);
2732        assertEquals(1, a.get());
2733    }}
2734
2735    /**
2736     * whenComplete action executes on cancelled source, propagating
2737     * CancellationException.
2738     */
2739    public void testWhenComplete_sourceCancelled() {
2740        for (ExecutionMode m : ExecutionMode.values())
2741        for (boolean mayInterruptIfRunning : new boolean[] { true, false })
2742        for (boolean createIncomplete : new boolean[] { true, false })
2743    {
2744        final AtomicInteger a = new AtomicInteger(0);
2745        final CompletableFuture<Integer> f = new CompletableFuture<>();
2746        if (!createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2747        final CompletableFuture<Integer> g = m.whenComplete
2748            (f,
2749             (Integer x, Throwable t) -> {
2750                threadAssertNull(x);
2751                threadAssertTrue(t instanceof CancellationException);
2752                a.getAndIncrement();
2753            });
2754        if (createIncomplete) assertTrue(f.cancel(mayInterruptIfRunning));
2755
2756        //try { g.join(); } catch (Throwable t) { throw new Error(t); }
2757        checkCompletedWithWrappedCancellationException(g);
2758        checkCancelled(f);
2759        assertEquals(1, a.get());
2760    }}
2761
2762    /**
2763     * If a whenComplete action throws an exception when triggered by
2764     * a normal completion, it completes exceptionally
2765     */
2766    public void testWhenComplete_actionFailed() {
2767        for (boolean createIncomplete : new boolean[] { true, false })
2768        for (ExecutionMode m : ExecutionMode.values())
2769        for (Integer v1 : new Integer[] { 1, null })
2770    {
2771        final AtomicInteger a = new AtomicInteger(0);
2772        final CFException ex = new CFException();
2773        final CompletableFuture<Integer> f = new CompletableFuture<>();
2774        if (!createIncomplete) f.complete(v1);
2775        final CompletableFuture<Integer> g = m.whenComplete
2776            (f,
2777             (Integer x, Throwable t) -> {
2778                threadAssertSame(x, v1);
2779                threadAssertNull(t);
2780                a.getAndIncrement();
2781                throw ex;
2782            });
2783        if (createIncomplete) f.complete(v1);
2784        checkCompletedNormally(f, v1);
2785        checkCompletedWithWrappedCFException(g, ex);
2786        assertEquals(1, a.get());
2787    }}
2788
2789    /**
2790     * If a whenComplete action throws an exception when triggered by
2791     * a source completion that also throws an exception, the source
2792     * exception takes precedence.
2793     */
2794    public void testWhenComplete_actionFailedSourceFailed() {
2795        for (boolean createIncomplete : new boolean[] { true, false })
2796        for (ExecutionMode m : ExecutionMode.values())
2797        for (Integer v1 : new Integer[] { 1, null })
2798    {
2799        final AtomicInteger a = new AtomicInteger(0);
2800        final CFException ex1 = new CFException();
2801        final CFException ex2 = new CFException();
2802        final CompletableFuture<Integer> f = new CompletableFuture<>();
2803
2804        if (!createIncomplete) f.completeExceptionally(ex1);
2805        final CompletableFuture<Integer> g = m.whenComplete
2806            (f,
2807             (Integer x, Throwable t) -> {
2808                threadAssertSame(t, ex1);
2809                threadAssertNull(x);
2810                a.getAndIncrement();
2811                throw ex2;
2812            });
2813        if (createIncomplete) f.completeExceptionally(ex1);
2814
2815        checkCompletedWithWrappedCFException(f, ex1);
2816        checkCompletedWithWrappedCFException(g, ex1);
2817        assertEquals(1, a.get());
2818    }}
2819
2996   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines